From patchwork Tue Feb 4 10:16:11 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pablo Montes Lozano X-Patchwork-Id: 13958879 Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazon11021093.outbound.protection.outlook.com [52.101.70.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 926B82080FD for ; Tue, 4 Feb 2025 10:17:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.70.93 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738664223; cv=fail; b=RX6U8w13TU+kHRbMXgZj853+ev2/zYxFYjs9itEvHiFPjVsQM2yDWB6JGag4hj0XsDhG8DN23VM1DQ/LHv+IB6Zbo9U7jMfdyGtCEMipHQzM5nqofy6ZJjNMMXf7a9RDkFEWmyHD4N8sc5A1R4YwWSRrDMqQA8vArHZolIa83fA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738664223; c=relaxed/simple; bh=b2Lav0haFWTOY/jM0ZSAeCEgswlZvmdF90sC8vIa7H0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=tNg9C1j9LetcqVd8/ugjej58CszsfqjogPzNgersbLRsuhlKzZHNbeBDiMBdJ6fndFiLVx2/hDLMUeBp445I2ijaqKzzK28Pfo0OUpDMwxw4wyRnU5GeVGOI4E7AGkOsq776CZNDDMC0IPCzvL+UprkkEkUbdHmSl5tn4vsUoeo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=shsconsultores.es; spf=pass smtp.mailfrom=shsconsultores.es; dkim=pass (1024-bit key) header.d=acshsconsultores.onmicrosoft.com header.i=@acshsconsultores.onmicrosoft.com header.b=GFQ4foNP; arc=fail smtp.client-ip=52.101.70.93 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=shsconsultores.es Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=shsconsultores.es Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=acshsconsultores.onmicrosoft.com header.i=@acshsconsultores.onmicrosoft.com header.b="GFQ4foNP" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CgTrRl3Ku7sT1VTB53QQ+cKRxcXMzgM8i1d/TcZ2ntNiBW0+RwbKKMtRzdbQwCzhJGC2mH21G8lMPwyH1+XHF898DiyTn+kyA+3qCI85NEIS6kRJibBWt3WsY/4y8C62KRF2yiudz2uSbV1rEFB0iPx8dcVci5O13lOQ3+YlOpUhHMRdGLhuHbXVZpVOSw94ssZbu0vKVJBR2foY2s4X0zvth1Yy7v+FWg2PVZ2Fe7r91ZSLfl8LdpSjRm00b1cZFImHKtsgTNt6u20NkfeTKlP7JqtotuUD+vXbAA6r0fPTZpxPxUOS9BgeMU93h9q2ZODIrDPduMeZqZ4oaFJaGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u0uZhnOyIWh1z7eBa6WM9/Eqk+bbfBFzL4aw+F/zjYQ=; b=LW+uAOTiPl7iP1N0vM+ZBOKSl8CQdHQ0YHBtZBmHCTRFH0lMw9xU8iorKpQai3Xm2QAEIdg4U+0IDkgaPzMw2SXu7/gL2VQ+/3o9qFh7nZMoJgFVZI/oAFoGbNcfxUO1yMCYIMmvH76/aHRrZCF4r8zQ1/uni9DE2hFN+so0ocs2EhuyR28UMEZRvH83Cm0Queh2SVUeEPhC4ogCictR/norep8bwCfp2UHFPQlBRTjLbU88TZGRcvDT9Wrd8xswPKYeUVs9BjDm0lpU3odFxXCl38hVce9pBVSjY89pti+mnrfbOThzeqeXB+f92lEerTuJUAEZXWo8bjcWejocwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=shsconsultores.es; dmarc=pass action=none header.from=shsconsultores.es; dkim=pass header.d=shsconsultores.es; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=acshsconsultores.onmicrosoft.com; s=selector2-acshsconsultores-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u0uZhnOyIWh1z7eBa6WM9/Eqk+bbfBFzL4aw+F/zjYQ=; b=GFQ4foNPq2OKWX2EaLVdbWDNRsmU8WFktDbbJvMbLcN5GXQuJPnfIwu4c5BQICUYCYi5AI2G/omsrIdXf33UeSXRwDZ/nM0aI0jL9m0wn0jgRAQ3AEJpO4tzbGAjdyx8BAHurb4zwZMs9lCHakZluH9JwbE2k0g9TZAWt2cyoXQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=shsconsultores.es; Received: from AS4PR08MB7653.eurprd08.prod.outlook.com (2603:10a6:20b:4cf::5) by PA4PR08MB6240.eurprd08.prod.outlook.com (2603:10a6:102:ec::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.24; Tue, 4 Feb 2025 10:16:56 +0000 Received: from AS4PR08MB7653.eurprd08.prod.outlook.com ([fe80::fbf2:7802:4c0c:8197]) by AS4PR08MB7653.eurprd08.prod.outlook.com ([fe80::fbf2:7802:4c0c:8197%6]) with mapi id 15.20.8398.021; Tue, 4 Feb 2025 10:16:56 +0000 From: Pablo Montes To: linux-bluetooth@vger.kernel.org Cc: Pablo Montes Subject: [PATCH BlueZ 1/2] emulator: Fix Werror=stringop-overflow Date: Tue, 4 Feb 2025 11:16:11 +0100 Message-ID: <20250204101612.66823-2-pmontes@shsconsultores.es> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250204101612.66823-1-pmontes@shsconsultores.es> References: <20250204101612.66823-1-pmontes@shsconsultores.es> X-ClientProxiedBy: GV0P278CA0080.CHEP278.PROD.OUTLOOK.COM (2603:10a6:710:2b::13) To AS4PR08MB7653.eurprd08.prod.outlook.com (2603:10a6:20b:4cf::5) Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS4PR08MB7653:EE_|PA4PR08MB6240:EE_ X-MS-Office365-Filtering-Correlation-Id: 6c747be3-333d-467c-2249-08dd45050d7b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|52116014|376014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: V1DMhxosRVSVELrmhJ09c+WrVLmi4yL7sCqALHHTZFYa7e2ydRTxgMwpbiviJv0bP4h1ArzNAGz8ZzFzLdfANlt1ObrVQBPMwuD8yybSKjWNXsIHwc1PQC7lTtLvCjnfW6GtQ91MvY+4sICNC916fmBaokiFa2UyF+42UbvfiRraS9b85jkxHodRm1+LXyvzJ2xVqQ29fXPbr9F4PjKOxG3z2ounCYyNBj9x45gDUTPFK6gIT1zQtA/clmKUjFo2W/eusmcFBKLydpvUtNlUN8APKkW5CRrFohhSXy8LpGVWwyviq1zpR7v4Ut4IEIzw8JN3B+pOYS9UwJHL/vl0HltHQhqbVEaLIFoA557O0WUhVnErtXkvaVXQYHo9IoSrbSbrZrQSroQsRKQuoa4qufyz0RmwCOHc3EDAUPE6A4Te+Y2jil4MSieJxtSq9DolnQSpmMW0gHGHeQp6agH45vY3ItDigH2S+l2lzS1vd9RdEfe9/jsyCf315ViC1HwX/2vlnwj9HkkNAlmshiqTgV8SJNHpi5vbJcNW8vKvu1+kixxuGZU9odwgW/ZwRgZIxAR3FjcOm9WsnAiy5sWIHb2WN2r3L6ZfMQLgyi+2JXM9GEP+t7qIBrNK3KRR0D1qeLMWax8uhHGDhXzILRN9eZ4f8E85LRBXAOXojY9iLvIk2dmriRXjG/3qysE4lg8sKv1BbxgqSRZB5xCRWImwm0Rsw5CV6/cgxzYlOI3JnDKP6x3sPGQ2QDUxdvyJKk1xGgONaAld3+1zqe3nqr78+wYhaH6Js9rJ9m6lxx7Sb3PPrAf9/QiNiE3+sts2zuF5HsT1Tch+sn9+MEF0NPuPdQ9dueG+aERMfd5od4s8EQU541IACRbzADRcTXXiPZ877N6QQUjND8FkLMpwXXxzzrbQYsyNmfdrT0cAIJKRYxoA2wk947YFtqNO58SvQ53NdYHuCT00bVOXQ+Pw5/f7/lDye3OJb1/Ku2paGzNRC5UCIKcbXlIsGb+gGWzFsg2pNA6JlaCh7jf9XV4eMmmh/snsyX91xiCqjWop1XaExzG8Q9MBLMdrATT+k3sRtcyW6y0tiBY9tt5qho1gL4vhFFjZMbIOVRzB1hL3YaliVeu3NfTEpsKWoWTmeatGyTOcdgwa44uWz00h8P7bn9y+X0nAy7EN6YwJbdXzC/LvP0UQDPxPtVEod2G6dJtQczqVrs2zb9FUPulhblvWyGjcncPo6Y7bZ04PswCFmi1t/Cg6GfRKbpDv/3uMCHCTSd/TQm8Qf8Ri+C41hunMh91x8yoSPQWOgX+KVw9uhl1dKmhe/wvV9em2kS7X72etPmoKm5st73TSNcqtOwMRB3BdEEP1iS8Tjf2Ar+Xi+Nrcax5YNPtQwD2bamxC+mS932h8re0Y84S9xUT69WdxSaUAkC0PE5HXtQRYDQ/KVOLRNcZxe7cLTDjtsYpoYatU91ci X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS4PR08MB7653.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(52116014)(376014)(1800799024)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: S5SxABjUoluBePZ2cgf8TSsnYcL85NAHNLvGoyMoldBdyCjkMb1VBnrdrb6l+vdak1RvKEDh0pYMp3YstFIJBhMTYdikq6x/+lD5d7XSm16Uh+c5cbeSouI4GRRZTh4q5hUq0xFzoEBkWDSHtmoIuviAKfXvsbX2XrwhTJFkHBkcIkR3NQL3g9J4EzI7kCta/+K+30CX/ufkTkfgr6D8zvOwEOwup5p4l/zlWvUCcIEtmAc3DQTm3TZ/SZeNjn58Nt0pSMXpuKIKNU8MKbKIB28e8GCsrCGrjVOfLddAyaGSOXzql4ZvVxrH7tNYNqCt6vAZw6vR/Q8GnphqqNEFHi5PwR5YdY5aWBzbfKj2HdgNwqj2xafZ4EpNLeEqxh9E5i6OZU7RL43KzA9XCSt9bFuouq0sH2VaPTMHuTdSKUYlqpDZSWU8ZL8xSbGWzgzC7ZzKgxgZtmgYQ5qa3RKgZVtoiq/Lxir4DRDhtHOHHKje5x+sTl9XO7jxxIXpd5CgYDhSl/91wds7jtrpGEjINyR/SiMK3w5fpWyWkXfxfkFzqihuN5+AlPYPAXorIwCbmhRj+C/3fWcABveINhMmW41PrOnNwDVA+9tD11bgvyZMyzejqV2WHPM2SgtZ6fq1MustkrqikC8K5GdT8Na0muQUJ4YzkdK32TZrRUbFsYI+5DhEmhNxUm43BIlXN98ETviLzA4CmC0EO2LKsZi6KeZ963Xi5pbEvbg0a2T8uAR0V8A4W8kKaWZlrgZlw3g3hdwxIeaZEjkPE3BKk8ie4sUJsD98xbrHa7zzhDGDWzfy0W4HuA6HRr1+kkbKYZlfZ6Qk0IsjiqiXGLzVB2Km81f2mMckn7g6dFunJHFeVaRzdy7ACoFUPpKsrDsyNQL9vKP8uv4gPFZBI4Y6abA+yCTTNAa9pIwjQZXPWSbyz368xZqnsuc6F3q6odTRU5IfDDN+Or7OmNXQX7jt3NqAVSDrGmD6f++KVcDMVBQKLAzRHxzt8ElEk65jxTyAP825ghPT8lHIt4iup1+o3g8tw2XwY+xSblNtc98OFxgLS/06SYlsyTMVtefoAprs8ZMXlJXahloLBE6b/spSPUOLW9QQLXPsOvqzysgCjWbVmDypZRyR71g8KZ5dQSriHRMAWOcUDfSNZJm4ZH0QD8f23I2u0H3TYoIh+54MeLF5pNiuNreYSExuq2CWClKwUPZRhHXOCvgy99mo/c9KyBpV7DK2rteQ+yWPEhbqxBeFBLJnwyLQYkYAkEcCp5qZWUb/XVparWPrZ5r2874WArn+J0GnuRLeCdY3PSixcOH2e06Lof1Rj2a4WuTVmyNMJwBfBBrKQ2Ui+FqmNSnv8eiosAq0kOAaC0RViuJ1TT71eSUhGJ57wneEfLULrtODCXWvPu84DRIh040QDvtb8T5xhL8vs2r+FmYNnb+dPhuMCRlPdqJpPpUzqA0zqAMXixkQfa5YqsEsuE2+vTEvpdoeceOZFCUDVBywZqGRng+SRoNbO8tZkSq8EjgBScVYSyUG4cRtCxoQINOLpEPEELr2CaT/jVIX+MjpygBmcht2PePVusOF32UAx8cYi4BGpGcbK8NzryFKPn9XiH1oEQItig== X-OriginatorOrg: shsconsultores.es X-MS-Exchange-CrossTenant-Network-Message-Id: 6c747be3-333d-467c-2249-08dd45050d7b X-MS-Exchange-CrossTenant-AuthSource: AS4PR08MB7653.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2025 10:16:56.1386 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: daf9f132-b852-43ef-bd93-64da5b8621ee X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6r2uckrXE9w4nFidAp1h0ULDc9Gtzj1t3ikut2B1++l8DmlmN4TyfnEpSMWQSffJjZY8+TWhFQYVAqXJw41cRhvR6A7lGsv0Fl7lIMOrVzE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6240 Warning on read for a possible packet offset greater than buffer size is treated as error. I suggest using ssize_t so it is always positive. Returning if packet offset makes no sense might not discard the whole packet and start again --- emulator/serial.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/emulator/serial.c b/emulator/serial.c index b74556b13..13b844033 100644 --- a/emulator/serial.c +++ b/emulator/serial.c @@ -79,6 +79,7 @@ static void serial_read_callback(int fd, uint32_t events, void *user_data) uint8_t *ptr = buf; ssize_t len; uint16_t count; + ssize_t available; if (events & (EPOLLERR | EPOLLHUP)) { mainloop_remove_fd(serial->fd); @@ -87,8 +88,16 @@ static void serial_read_callback(int fd, uint32_t events, void *user_data) } again: + + if(serial->pkt_offset > sizeof(buf)) { + printf("packet offset overflow\n"); + serial->pkt_offset = 0; + return; + } + + available = sizeof(buf) - serial->pkt_offset; len = read(serial->fd, buf + serial->pkt_offset, - sizeof(buf) - serial->pkt_offset); + available); if (len < 0) { if (errno == EAGAIN) goto again; From patchwork Tue Feb 4 10:16:12 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pablo Montes Lozano X-Patchwork-Id: 13958880 Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazon11021093.outbound.protection.outlook.com [52.101.70.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D20F207A1D for ; Tue, 4 Feb 2025 10:17:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.70.93 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738664225; cv=fail; b=K7WHaIoiRpgBh3B5d51a5dcL4PSgge06q5ENCtJ7bszi3H/YqpSE+JjDMC1xgQ3bk11yNQ28VzBabAHUl6/B4uQDsK5455gK1ZkDZMTVglvZ1Hbso2EldM+vu6o6dDWzDYfsbw3imhKH6z4oY7/LvF6QMJvgoxPzna2azoH7GD8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738664225; c=relaxed/simple; bh=Bqjp6EhttPP0HaYWc8YkN0OVoJB7+cTOj5+8LG0kZ6g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=fCWJm5C9o9oBXtV/ksQyWoo3edhI3nAku7F3mn0ybqd21OVSoG3tHzHN8hwTtx7QG6wJ32PLu3PpTLfe/K2jug3L8NRA9YieXTSkHihTO3S3gPI0EJfXQlq5hM+I+L4mMIwfbYTa0hroerdXe5nBWOwVXD2g3OMRzJdePlLtM/Q= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=shsconsultores.es; spf=pass smtp.mailfrom=shsconsultores.es; dkim=pass (1024-bit key) header.d=acshsconsultores.onmicrosoft.com header.i=@acshsconsultores.onmicrosoft.com header.b=CYeTOzf9; arc=fail smtp.client-ip=52.101.70.93 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=shsconsultores.es Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=shsconsultores.es Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=acshsconsultores.onmicrosoft.com header.i=@acshsconsultores.onmicrosoft.com header.b="CYeTOzf9" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=bfctZnBlyTl9XJFepEDbUO7PE6V2G4uf5rr/VH58Lrv6JsABPpFxHzjsq/rSYBVwbvxy69YznnlXtMd6879ZCRa+XMzGCeiCxXvgGIUGCpY8kJpY0cw7TYFBrbdQ0tY5NpIzPJRlwCqpzOODh39aZIdKlCBH8Z9PyXyJOBrw3sWE0/zq+PgdvbB+q4OxdyyszlVXVrVmF83rKLFopLbeQtIbhQyWvPp9aiWqfuA4ogteh8R0GzPfIQ2b3CcCuUnYjBvJiWnsBvZi4e8T52g9KrO9ASHrJihhma3vOpSpzVUUPSrD7EpJtLH6k0eTcuUA3Rbj6svoG3c7aWyU/oydmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7VGcKg2EG4qboOXZPFSgIvzAcZDCc6fHFWuOKzc1H9w=; b=AtTEbD7PsEdCC/x1eULRMDnusv5C4rEQod4imaM30HN7NUUNPLAMoc8kENtmlAcNT5gFES2VNlX07Ns/NOxubKkHzE3J4JmLQC499bd1/NAu4fa1z+Sz0144i9LiqgM8q3KKxZ1rtyz2QCiGzb05+ucqOYDN3dOWHILWyWTHjFjUUoczX4GZXQxvSEDHaLdViLM0fGauXX45ZMl2Cr3FheAYd2OvQlp5dOJ+o4MbB76kKm4s9zPrzGz7hooaUrZgFaUtq4pbKmNJT+NMvgP6VtKwwgopwg/2pHWoMHXOGtzhb8Eowt7+Nut1+TusRzY+OoQm03PFu9vF13snpYJj6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=shsconsultores.es; dmarc=pass action=none header.from=shsconsultores.es; dkim=pass header.d=shsconsultores.es; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=acshsconsultores.onmicrosoft.com; s=selector2-acshsconsultores-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7VGcKg2EG4qboOXZPFSgIvzAcZDCc6fHFWuOKzc1H9w=; b=CYeTOzf9bZnOef9VOeerjNMwbfD2Tala6j+JZ+FDsqKhiG/g/jE88MMhv1ceq4XdN/fzAsOOrKIu3olOgSzydCGz3j/hdMZmvq49WFfu4W4kCHvKunCR/W4JUMcIb5o2XEXPKv12NxJ4C3mloHVLm1CPeySS0l4I+6u9I27P5RE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=shsconsultores.es; Received: from AS4PR08MB7653.eurprd08.prod.outlook.com (2603:10a6:20b:4cf::5) by PA4PR08MB6240.eurprd08.prod.outlook.com (2603:10a6:102:ec::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.24; Tue, 4 Feb 2025 10:16:59 +0000 Received: from AS4PR08MB7653.eurprd08.prod.outlook.com ([fe80::fbf2:7802:4c0c:8197]) by AS4PR08MB7653.eurprd08.prod.outlook.com ([fe80::fbf2:7802:4c0c:8197%6]) with mapi id 15.20.8398.021; Tue, 4 Feb 2025 10:16:59 +0000 From: Pablo Montes To: linux-bluetooth@vger.kernel.org Cc: Pablo Montes Subject: [PATCH BlueZ 2/2] tools: print error on mkdir Date: Tue, 4 Feb 2025 11:16:12 +0100 Message-ID: <20250204101612.66823-3-pmontes@shsconsultores.es> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250204101612.66823-1-pmontes@shsconsultores.es> References: <20250204101612.66823-1-pmontes@shsconsultores.es> X-ClientProxiedBy: GV0P278CA0080.CHEP278.PROD.OUTLOOK.COM (2603:10a6:710:2b::13) To AS4PR08MB7653.eurprd08.prod.outlook.com (2603:10a6:20b:4cf::5) Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS4PR08MB7653:EE_|PA4PR08MB6240:EE_ X-MS-Office365-Filtering-Correlation-Id: 883c7770-dac1-4d5d-4e14-08dd45050fb2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|52116014|376014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: uvIBw840eVtccmDBec0lcIyWb45ZQZVHGpTQOgSaClnnjkGkI1aCK1su8foqb3IzBir6YHcj9qNEP2vduV2V0LsSXy0Q3YO9Z8eZud+I0ZftehfjVe1gRWsW++BkQ/mT5qlifjqKcnvEj16YCRnDVqRInBttqtgl8OqIkWaOqqldy4s2pMF8WKdRZF10cGj3Y+Jw9tXmUr9G73c5r4K89Vz2HpgEZIFZTjgGZgoUwiUqtI9b2FMaY2kEEa+nm0+eeZbJ6navCu0ZyTEss3GqSdbPKOXikxUdc1xCL5oqui2P1qAUYDkMxDp/NUgJGvX/MfgQJuQQ/1QhbKpVIZuz7ufqmNxSkl1Ihi+k0IKtvvu0nHJUqWyioa35+Ygb7rYU8NqiQAtyHU5Q8vNyG0JWaZrxs/uFYimGLEpezJVscRYuNNWadZOImnDKqLKzWUm5bBeFD1BhUpRQEXoylRNw6IjYZigmUJjPoiYlVTYEFQpNAGcBJLMvCdqqs/ra7wpKiZxBZQ5HShXIDN6PriqsHBNqFfnlTt8lLNP4CllUpe2zienmPV5ZXYgZx3FrL7wacekCYRRT0ArY+W0gZuWgv393D2hC21a/QlEqiWm06K+5zmu5n0XUfLBLAmOxigmB4/8Jx5tPM4FMjIBEVNjcz64Lrmdm9oEJX9sgkr765FzBML2SHu10LINS6u+BOlbZ07WrD6TeR95Zt29IvPbWNyB3XkU2sA7D5zp3U76FHiOZVyexDGgm6cX7XkRpjdGWxJwdB69z5Ps9g/vtB8VKdQRlE5PTbSLyC+/R1C/orJAkA9aFSowIxYFhmNFQA3Dv//5JdCPK/uUmp7VApTXkgAEza8Ti9vbVmAQGThNcBiEEMM1KU7Z1eSZkrSaylDs1hFeedmY9sxohJEYFc6ecrCCeEDyetU2L3J6E4ux5vPWkt/WAzENo9zCHqodd35/v/+HyY2HO0LvkhXEtpy9ZqGxtG5eTcSik5HO5wyJZwm1O3mGOb86O70LntJjUvYMqPLMiU1+hvI0LZtj7jHfouFujiPWHUkNLvNakAKW5VBorpRmwAZ/osvNa5G5EFQKtY87WLY4bmKwxwPwQCqZEBqFGhvNPBR98Vwz203kPqArVJbve/3iVduswA0SF9EYnw++1ZB3DGAlBWylepn+Lz17uxUSfBl8FmsT5dVB0KAJJrJt632OqjRvcxzWhAQwinj2r/FRwVW0nm+YL7F+OttD+sP3r8btX86oEqepVcm1+Osrebl/1dPwJGq44vSopGPYun3oG14BE8U03DD0M9yJjulCmkEGa88XfHalZ1ttPtfbUmMNTsUhEn+Sw1Vg5rzXYbN5x2eHMifBI+8nW2Tg4DkEXjf8NLHojUHTA9ApC+f0XK1+F3IXJRzMmRu25JOjE1MAD5yovX/lEmgpva3gVeOgr0cGMHud+YaKT1qwCUfSb62F3YqSpMJRrPdjk X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS4PR08MB7653.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(52116014)(376014)(1800799024)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: eZaAHYfoPcbkDRTk3VnWUs4eDw7gcRI++Xybg0sQfLOgwapPZcHMWd+Ob5Xzu/9PK0Bg/GM45PAdy2kIlnrHMWspSiIER/tfsaG8JcuKcVQN0YUwZyZ8QwAX3NyeFev4yLKdc0tr3F1/zErAVwo4zUKQC7wyfFL80nvfnyZNntdk9qp+ibgaHP0M3sUunMcL5Jk5PPsZkCsXbG3BmiqAkx9ZGAXSMHTv9VwjXucMEJV532c73o5KtUKxxX7+gIMHHLXFZpnFdmLFFmRVMaAVtMIVTRR/Bnlw8agq0Qz3eiu7U4hwSjXsM+HliFN/qGtBYepJ/ujJD/olhgF/84XM+7GhCkWicrFjK1qw2VfIMcwnGoZi+zkaH0LVAfaqpHd85gWYN9p65qZQD2nFgM4QTqaOUNYB6nsvXGtIpJ0DplIxDzaDtS606UM8Nop1oY7XuloRQ0WAGWuM5kQSlCDCgXTmq3Y63kUfranewKBDS9ZW59WntB/bHVvFbQba8stRhVB3WqZBnE3m9gXdOxRu7dfR9Pxox6L1LFCHD9cj06saoDczW2RSMpIq5WpE+1VhLltO4lWtuWAJjKXO3vo+Z8pJO2XPIPP+oKo978ref0PjXoUB255g83iKsI10P4pBvf7F5gLDcsVHWAsF6iOE1bMuOGpaxVSBXqV23+FtsJMm7Rm++JarvxW1E7Wkp29HoJR525kSbiNGAHleSWvDQ6fnlRVAbmciDsrAMuutPbHuAL3B6evCJArafTI7pg58/8nC3uV2cNoXOq+86vQWNGhQy7ELwllVmacU1xU26OJF3h8hI8HhfDOCXQ0RUuM0RIk0v9GUCTVmz7qgsGKDltYc4zrKOVKtEV18LfkOHsONVKB90udtamfHiPCETEUztPTKjUnyPAre2ieBaOfU89EwINC+svCXxt1f6BT2bjPiMuN8AVhlDStsBpZEYsTVNqqis9ocHye+PFTx651gIqGv7m1fUVqQmfYoeuhlhnQU88oObZrAW0rN0dT3dNHQBuQwqqH3jdStsw/l7cLm7ZQwrlgEAQwFIZHIFexNYwZTzy40yYCc3IEkqjZKl7Qc42FG2Gt5KWQpB+NxbbZ625k6djsS01XgNuzUulQOXSpIHsfXa0j4jDSjYJRRoudVEpLiMk9RqLrTvgmWUtvIw2xzlKEEtSH8j3gFvTLxD84jo/25ekkk4akdBddXI9ITseITSkDcAj4fo0vQS9wHP7q80Gl5lQiZlmQ8K5RE2tIF2HUY2P0i8yGiORMobJ29D3/0j00GSTpf9aDP6vpCadZBMMQkn+INoFoIo/Q8GJIs0+oGBWQkSOq89C9gYtHCOncuPNHh3BTTfJfCuU0OhuQ2PWpl+B9L6EbEEGekeyZcBFI8OiNuTLU7HZnne15tt2w3TG7uojPZPqvpvEYNC5qbSeNeb4lRL6wfb5lwW8QP7ZKyGoTS39eavkqnf1ol8j2NCtwhRP3LXqEPvCbNGSa754cbLEWF0Q/WyZc5Gi99S56FySuKXxrbSPmlf+JvxKT72xZdo66zLAQmWZncXTl1yDlD1QrK7PNsXWLAHIT9v1GV/u/4aFoRD7sAMfRqOqhJ4QB5VvRFHoYNRNh/QQ== X-OriginatorOrg: shsconsultores.es X-MS-Exchange-CrossTenant-Network-Message-Id: 883c7770-dac1-4d5d-4e14-08dd45050fb2 X-MS-Exchange-CrossTenant-AuthSource: AS4PR08MB7653.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2025 10:16:59.8651 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: daf9f132-b852-43ef-bd93-64da5b8621ee X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TmhHV7yp5tvgkek6vbfSqC9R17MSkkVTRUKPduOLLZ0Vl7wgv0oTMpFqydjbJQ+q5lAlOnflkh11Nt6Q5/S4EWNa7N8q//G454Dy+RhDGJE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6240 On some fresh installations where XDG_CONFIG_SESSION is not defined, and $HOME/.config is not created yet, mesh-cfgclient failed with no hints --- tools/mesh-cfgclient.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/mesh-cfgclient.c b/tools/mesh-cfgclient.c index 3bd2b673a..b1d091be7 100644 --- a/tools/mesh-cfgclient.c +++ b/tools/mesh-cfgclient.c @@ -2529,8 +2529,10 @@ static bool setup_cfg_storage(void) return false; } } else if (errno == ENOENT) { - if (mkdir(mesh_dir, 0700) != 0) + if (mkdir(mesh_dir, 0700) != 0) { + l_error("Cannot create %s", mesh_dir); return false; + } } else { perror("Cannot open config directory"); return false;