From patchwork Wed Feb 5 00:45:14 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13960270 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2043.outbound.protection.outlook.com [40.107.249.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16B05227BB6; Wed, 5 Feb 2025 00:46:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.249.43 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738716368; cv=fail; b=FxnAKaYUu/xnGilaGp6qKQ8iZMPK7sk178mHE6pXDCYupxvZCPBDoo6Glm5UGvBSoP3fROvDzByD/6DyeQdIc0+PZ+TO2jR2xiEN87n56K3x2PVCPSGkfFbFcIOuOU/IRhHX07EgLDY7Kf00fL8XZ9rjo8/jWvcCML7t8n8LSrw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738716368; c=relaxed/simple; bh=f0XWM6xBggK2QfOcHzd3+B2023F378UQ/qXOqelOuSw=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=Z0QU7fy76r9g4DUMoazpn/fCSLoOGvhdoadnbs/5Y7VHMeMQhC/hdnuJVKvAuYUcTKhBt9b0cXElE6OfWXzTWoAyoXQAg8+kD9AlmKVxhRv/V0H72EdLblsuYhDYA2CXVcFafXZ1qt/HqhyGtHqmaLu0AMhuTCaTJJlF1egVNms= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=geFRxdle; arc=fail smtp.client-ip=40.107.249.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="geFRxdle" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jB7u4a6Zjh5aWhc/79HcbZURJBkQ9KsioXjOPqfthwvalAq+kYHNyfEtumib1leQS5DQx5n8iFPGauZWsxj2Tt5CSDZFtapS/IquMmJgbybEosmzRy+PhKzr3DqA0YgQdyDIKUuc6mfkPD8sPA4y9O1UYn3ksx5ep5Z2f2QyMexzreK1EviB0+O4iiD2tEkWdlncBGW5nP0uXYYj4+2ZHUm1BKnatcuEd4ALRvj/CeYPif0fTWEPZ7ZgmFz4bsOnUfBRHBZndUgz6l5KSiGSulnrDpyxDIMwI6GwGR3sdFZcBiq8UO5sEDKUkoRd2SD3XCrsBM4LHWf3uVgZXc2ALw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zBJXBX/BlDu3iR52lDbc09nZRQMR+H0jkQvpTPg3SOY=; b=qDydsRsO5Cfw3c2lKbkmnaG+7UihFE2gbyIY6tcDfN+3zHhjuGtwqQC8swd21HAEuwKdndtbaZEEap0qGm1ccOzgLDFAeZmJbJLFarcK7AGHQdTuM6FyrXp7wjQrITxJ4tPL8KRjaimdCaNfDmro7AfY3wLGSRoeyoRGlWLuEaPQH5TbnpPjN1O7yWgdNS7U/KHnuaQRPizL3PO9qR2TiXxUkE9p7MrjlZvilsPt6AnkmSG+LfKhKe7Kapw3qUmiJm+QojBjpXf+0TqOzn06i6yRpD+VPcvcSZApqmhoOxxtVl1EF7J8PFou4QBZFrcxcqJoS7xYG009zyw6iFqvuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zBJXBX/BlDu3iR52lDbc09nZRQMR+H0jkQvpTPg3SOY=; b=geFRxdleOnkCybpV4Z6Z8p4v3vzR7ioE0Sw4PRrYpkycTBaktIfDNJZtL7JHEidXmX9rjIwW1bg8TSFU7B5WOt1loDcttg++x1JbxXgvrZwxcSd6P0tyItGHxYdXuWogeNNpSHWSKVYFmQqGfMF0jeklzB8WIVnfwhsfXcI0/9Qf1oyt0qQyCY8ut2zVh0EmOskSAlIMVJ5LpGe28oH9LllmmQYV/SwSp4Iysd9KHFiB17z92TwSDSHfJiESLT7tHTfAY1mtBX0DDKYOsRmwkuK+syh+YsY343xBF2XiDQ3Vraf9zs0mmgJEY0wO8kPqToWksQ+sBHmD16IalZI3qA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by DB9PR04MB8250.eurprd04.prod.outlook.com (2603:10a6:10:245::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.25; Wed, 5 Feb 2025 00:46:00 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%3]) with mapi id 15.20.8398.025; Wed, 5 Feb 2025 00:45:59 +0000 From: "Peng Fan (OSS)" Date: Wed, 05 Feb 2025 08:45:14 +0800 Subject: [PATCH 1/4] input: keyboard: ep93xx_keypad: Use devm_pm_set_wake_irq Message-Id: <20250205-input-cleanup-v1-1-9758898ff8cb@nxp.com> References: <20250205-input-cleanup-v1-0-9758898ff8cb@nxp.com> In-Reply-To: <20250205-input-cleanup-v1-0-9758898ff8cb@nxp.com> To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1738716321; l=1402; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=lLk6bV9Q4qc+HUdwJdc/NyACnoatpwVUWdW9RwekWXs=; b=7zL7i+g9ZP1bfjG5cTwXQOi1Jqw3NcS0dh/V/mXAJHhl3OreOjEha2JCLQEuaWf1dNlcjcKUn C/WGQf1YU2oCY6Anm5IS3G7QGNuC8NoxtpvW5c2pzkeO94aFazjfUZb X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2P153CA0046.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c6::15) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|DB9PR04MB8250:EE_ X-MS-Office365-Filtering-Correlation-Id: 179e77d8-108d-47e0-ef2c-08dd457e7596 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?3smk0B6LtVq28R5W7r4eA0Vy9uzZUfn?= =?utf-8?q?cNB/OyI0pZ8Dx4IFMXVebmlcm7h70pMbjIohO6nekD0QZr89F2UHfL7PVS71L1PAa?= =?utf-8?q?c0gUXE08WFbtwtkaqeAk4lRolJNVNiEGzmrZE5haQplpDxC++D5Kgu/z1vhj0iZqY?= =?utf-8?q?I2HpoXqh+cCcNb0hpo9noGNJJFWV8vOZV6AnZOcRp+62aeen95NS8kKKupQXZ+NZ6?= =?utf-8?q?Tn4kRn0OIkkZEjIRAmb4foBY6mKaegDVSQc2UaqOR/wj1FvfifPQl8555qCD3pzx3?= =?utf-8?q?vPNIXE4+leuWyvJ0BUNKyNuseCQt1m7rmedFT3EId4GKR5ymRz6WklSCKCCBL9tJ2?= =?utf-8?q?r2DvYRtXU7/ZbENhe78asOWQrSfYW+telRQGZs2V6bkQ5++JGTc1H59pgEtDQdNYT?= =?utf-8?q?IncayErqcmIFJGIX9wYMpc2jgo/DuItvVJsXnVf75Z8qCBKzdiu7G1EvUD5MwRhFh?= =?utf-8?q?pWpyqcx7c1Qu/HFkgtfxfPTGzVNpDiOxP2lObH2HUm1+lvrS0pZnM+UNHJR1gbe+j?= =?utf-8?q?SssaL+Ysj49Nks3dgDG0bvYJ5c/PrG3uHEKjmxEDam9LZsmZ+EJYZDVPZu1AOI7gE?= =?utf-8?q?Qb7ormd0oE9ocWGWTHCj+DViMJHb6MB1QPSsbw3PB8/a/tTM0ee1LJrO4YxIKuDae?= =?utf-8?q?2eHS0eEGoKNOLGXtMReE7BRsfODW4yr+MgRsqWQoB4AsE8HZraKOSLe2m7yvl/8Qj?= =?utf-8?q?P1QaGGn9BDDF2gMJH7HaGTRF1nTEKq9bblFXWUphVp9uPfSUfqcrstvxk7TeJM1qZ?= =?utf-8?q?khr+0UTLyCdVcCSwjMNpFvcsRFA3lCwrYcr78Ct32O3nPLkeqc7hsG/+FwTtt3gq2?= =?utf-8?q?/6wNtE9qOF/mOXF9TrDvuf/S+HT0f+slykACc74lQXp6/8Q+lwL3nvoN2hrNBaD6A?= =?utf-8?q?phw95KRNuam/YAVOXcabrNquvCC7cXcPf0zaSDvhCeP9doZpbhjq5JGrgwJuMG0xy?= =?utf-8?q?mY9ZTCOYzmSFiUD1GDBAlmpggR6bg5W/FuR/3zaWWtK+ev3aR4QNShjU2md/8tp4d?= =?utf-8?q?X1PMCP7jJwlB0Ls6NYPbW6NHVESqZ5bnI1erFPklhrLIeFPjoDHsFuaMH+cZk54ei?= =?utf-8?q?N9vc2ABQiRlcgeBNrYyGsBhdAk44df+zzrmCzS14pQyQt8ZV4RBERJBeOEt7uhn+J?= =?utf-8?q?XkLmzq8ZVHvVsqTpaXZ7JQe4rnLdRgeilYMIndW2EBlzaI8s7HWOxd16wRUl9dK7U?= =?utf-8?q?9daFScujY+KU76bizebq5NCwfNJ3sHQSAcpQDDcstq8c/hQMseNu4su+zvyRwlkCp?= =?utf-8?q?PSgx1kGzlrrWXAWJEttjyogwYqGK2kzMVxI0cccCG82S4iYI9Vj7lAPwtV4ypkJHJ?= =?utf-8?q?E9kyAOZd/VclDX0+sydCA60XQxGQ0qKb81pvS4mIkP6t7vIjEJ0yaaVt+D46JCIiX?= =?utf-8?q?8daBG2bWKFF?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(52116014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?HkU3EHd6ay2huQEJKqYxGF6r/64m?= =?utf-8?q?iwwc2hV/5eS0FlaCxwB2Vmq2Jl0E8IfKfxeianD2FfdWdrx9vzWx1ZJuvacDsdmVs?= =?utf-8?q?7vTifPy55lYnj+Z67T0yE80Y1uANaHj60Kj2wQRFbeWm8ZogqcWOGLEZq4i9KOwZd?= =?utf-8?q?6Mpz67y/TunBdCLofFQLgzWZb42lQDwD16hwCu5LEE/9OeqU9P8nJkkT+XOy8dpsb?= =?utf-8?q?XIJdc0Y5CKTESYqaiw8QLMCkH5CmEakRXdChb6+XID57Pr45FFKCRLLC3bJQi3EGi?= =?utf-8?q?+80tD0mCCAm7FjshprsnLEPkbBWdIpWGno4PfFX4YyN6+co961SUEoEdnOx/GILny?= =?utf-8?q?w+B/JbF4jotOJMLudiKKhD2r4/nmy7EZU7p6aoNPggv7yP7g62vXAn8D8F3uVSc0/?= =?utf-8?q?JSUTYep9ztifSEYrp/2Zv/rKf8I5/UX4yV5ELrz50PwiS9mLlr4FDQS7ZN/nUw3lv?= =?utf-8?q?AGKcU6fgOq2AUX56RaQFZf0HN/3DA9sv76pj0GRtRD1CIQYzxi15JDQGyoVEcRM+v?= =?utf-8?q?tCX6PYVYYUfBdT3YUT3bVXEyLXGRrpU5CX6eXPJHbxZXnKGtiC6NGA7m0Qs7CKq7V?= =?utf-8?q?OTVfflH7xXvtNWroJqrPwURfvVx8qk8/x7FZwmZSdYJFyuB1mF+28XWB2CgzFH16D?= =?utf-8?q?YnGxsU0j07H4B5wyxZKVwJBZpculzO/5bwbOcaJ6NEgu2Cu3bHqwOrWbdxP8LqeQi?= =?utf-8?q?tJuuk08tLMhk/nt+2Vye+RkVF0ln1HTouLl6PQ0zEhK4sWELHTfN3DcOvQxLJvFvu?= =?utf-8?q?I6qENn3VJAEE56Gs/AXoydHKlfrFVC+rj+k5CMFYmwr+a92xbRrnr1segq/dfIHBM?= =?utf-8?q?RB5fUCLNEwR0JvKNyotEPpfL74v9q348e4yfFwZmhyTFYt8vZAqwMP3KqFGe38x1t?= =?utf-8?q?r2EAxorU2wv0mLlid2ql5jrNffxDswuD94TDFIRztIOiQ63piUXms5soUrpDD5heP?= =?utf-8?q?D53927WJ/OMnfZ1t5GAVZMo946OtC3mULt4dINJDZkVRwlbM2/IS8gcEDJ5vCOvkM?= =?utf-8?q?PxWBqCfbOm/k4XPRkxZ9/W2a5X70Zhx211Uw5zSuWs2QhWGsAtqqzChy0ZN171Xhb?= =?utf-8?q?GNCWPqP3ZmDwjfPrnqulxTtrNgeNZRq7qrpyqnRa3KCJt6Zu0AGZz6eLIa7r5SQRI?= =?utf-8?q?/A1tjboNY+nPbDJxikDCWMNivrVomnRA0py7z9SY//v8xUkHaXr2OjxVozx0IC9+B?= =?utf-8?q?sioHf19K4x348Tmk5zLnwvoL2r18FOzi6XgPszbeJGmsM7jwuUJOMc2wx8S2/lSaj?= =?utf-8?q?UUoAnp/n248Mgd0O7mPNQF/cphw1oMkZQ53HRndLbm90eomAG9JaqP7DWHFm9HT18?= =?utf-8?q?2X0mxi3w+SdkblIIeOj82DNxtKj1cUR/azdCvLrfm6GeehxP7T80y4Tt5xEA8lwEb?= =?utf-8?q?q/iwNcjB2S2OyNopuyyVOd8++pfIu27DNvZWXlIGQTRSa7k1DcHwUr/UN6qlvHl0K?= =?utf-8?q?aiXcWa21g21USqSagkTinIy63VMns+sb4yTXRyz4S7WcdeRvIKuztUSaGYi7P3NpN?= =?utf-8?q?6+LdsqzMbTMO?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 179e77d8-108d-47e0-ef2c-08dd457e7596 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2025 00:45:59.9217 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WGQINNCJDYs2ROk4RU6kG3+w4hZtZa6FykF7gGSn0TbHSxskcz6ky/kcvLLO2CTPpgi0mPczcvM72DRPZjUjsA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8250 From: Peng Fan Use devm_pm_set_wake_irq, then the 'driver.remove()' could be cleaned up. Signed-off-by: Peng Fan --- drivers/input/keyboard/ep93xx_keypad.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/input/keyboard/ep93xx_keypad.c b/drivers/input/keyboard/ep93xx_keypad.c index 817c23438f6e5176431e1f736bb511f9919b67de..6e3cbe3ca72dbd43485c23f6042b4fba007ff5e6 100644 --- a/drivers/input/keyboard/ep93xx_keypad.c +++ b/drivers/input/keyboard/ep93xx_keypad.c @@ -260,18 +260,13 @@ static int ep93xx_keypad_probe(struct platform_device *pdev) platform_set_drvdata(pdev, keypad); device_init_wakeup(&pdev->dev, 1); - err = dev_pm_set_wake_irq(&pdev->dev, keypad->irq); + err = devm_pm_set_wake_irq(&pdev->dev, keypad->irq); if (err) dev_warn(&pdev->dev, "failed to set up wakeup irq: %d\n", err); return 0; } -static void ep93xx_keypad_remove(struct platform_device *pdev) -{ - dev_pm_clear_wake_irq(&pdev->dev); -} - static const struct of_device_id ep93xx_keypad_of_ids[] = { { .compatible = "cirrus,ep9307-keypad" }, { /* sentinel */ } @@ -285,7 +280,6 @@ static struct platform_driver ep93xx_keypad_driver = { .of_match_table = ep93xx_keypad_of_ids, }, .probe = ep93xx_keypad_probe, - .remove = ep93xx_keypad_remove, }; module_platform_driver(ep93xx_keypad_driver); From patchwork Wed Feb 5 00:45:15 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13960271 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2043.outbound.protection.outlook.com [40.107.249.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DA50228375; Wed, 5 Feb 2025 00:46:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.249.43 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738716370; cv=fail; b=i34yTaCM2dxuNyHCCPalT1PnVTUGdqseEG6Sb+pK39x7oYDwGB3iBjFpu+vhz+IvdVHKBX6VlPMa8ZLIwNWApPOcTMlfIDo2VWdCdIYimewZvNF9y69T3g5a4EqNBZH8iUyiNZOpoyJJcACWxWF4cJ7og/OP0Rz4HoyhRedcOnU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738716370; c=relaxed/simple; bh=DNmSM/zlaiHe7y+SpoUtP9k7yyKM9LouOCBuhZSkcWM=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=WIVfNp75u+L2jQiDhml2tqmJPmTJTHZbrWSo8e7fEsRF7El+UmelFIEm0G6qPTdsR3ow+5DBsoSjjzSiUlj9rA3CWR29QfEB+aAPcmMRlu7ZzIg4M84R5kdVEY96d2t0TBX4Ejq1RkfQBS++5S6Bme5CyrWcsg62Ku6/vn2703I= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=KLPD0tet; arc=fail smtp.client-ip=40.107.249.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="KLPD0tet" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gVTEEGNvXF3weDr/u+3fSYMi9f/zMXGF/kjwJs0bnev7HG7nHnDVWbIuRggWj3Mc0aIWPZuDGrF/Te3JPuS8dlCVg4qy7rCxhHZshsIxQcPnAQJwJ1tq6XMxLEOkMdOKwk1/7+3axbT1Vjl7ZER8STZeJvXYQrEdert3Dhija6wsD+rsAMJllv0fwI2rqrIXXxWQy3OClPi48tvC1fE0L5JN9eI6FJ93NCNFnSRVdr7PqKylIMgiWErwgpPUA6LFAMLoIe+TpsLDXb0ZC2c+A1/wx1BQNZ+/12vDjIbeJmJ6vs/1MGaEX8SXxlMlGi+nI8XaeeWIuon/AMQQTrTRWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cS+DM8g/1DZ++lGRTiLrP/ykpiHku6xeI0up7+EwB9k=; b=uEg9El4vtReCGxZ2C/l8vlw5wUtnyLJJllGLQMxjfO9+MLaebusvm7O45D3sQfsZuzFZytjIKjHBXlTKJHzORed6gM+/MHz0f2hcqYeJQn4hElW9+7IdqAaTV3l+zFSYwonKO3rca3ShMIGVvL94EX4KkikFNqzgg8bCeVWWPRxNzw2wC+YCo2ddbp4TUOe6LH8TekO4pnawbAIuf6xWTy2Pv/fKO02c3NPgOtZsUuQoPCSWe2dkcPAHrKznmGCaoOixOTNWHiHbvXBLfBukISAK/SwKiqKXQ0JQI6nzCSthAjx8UitXSuwgylRCD3c9M9Zr3L0x6ADw6Y6/Mm2PWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cS+DM8g/1DZ++lGRTiLrP/ykpiHku6xeI0up7+EwB9k=; b=KLPD0tetSmCYuHWkpXKWL/XiL7E2aKZYDsywG1RR0R5gEjm7jMmnrnSXQEFPDzb6TJmgozE7Tkz0uiAOOaZ8Q3d2seTJbU3h14V+FdW0hyademstOxu0oBEu4J3H9PIAup72lL87Q175SvlsCfuk8aL1e1vOUNPiAMIjoJGtBx8j5839V/+WqZovsWbOlGS8nQGDZJBJDa1ohJtk369HGDIkjnZsWv4fIovmlbPfkbHklH7d9uXT6oWrgWqqxmKOR9hnsJW8+f9ygTK9AYyGLW/ifV4OdG1Fa2Cplv0pNx+Srs1IfOz8hvsDExyzYoR6FJesnvnAA24YKCAKGCswFQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by DB9PR04MB8250.eurprd04.prod.outlook.com (2603:10a6:10:245::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.25; Wed, 5 Feb 2025 00:46:01 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%3]) with mapi id 15.20.8398.025; Wed, 5 Feb 2025 00:46:01 +0000 From: "Peng Fan (OSS)" Date: Wed, 05 Feb 2025 08:45:15 +0800 Subject: [PATCH 2/4] input: keyboard: omap4_keypad: Use devm_pm_set_wake_irq Message-Id: <20250205-input-cleanup-v1-2-9758898ff8cb@nxp.com> References: <20250205-input-cleanup-v1-0-9758898ff8cb@nxp.com> In-Reply-To: <20250205-input-cleanup-v1-0-9758898ff8cb@nxp.com> To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1738716321; l=1365; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=IYFb5BcVnaCb3uUN830r92UAprUHpPfeHJSpQKDJq+A=; b=FfkYBrhoOBQaCtvD5SyQDwaRuLemJLrepWna3F/0nCmeMU9mbPq96bTN33pKCeGNsqqeEMzDF fyuOAEcGZDCCyq69PqXu4/di7aztPtnrUpRibv+9witGdOSQmQBRn33 X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2P153CA0046.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c6::15) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|DB9PR04MB8250:EE_ X-MS-Office365-Filtering-Correlation-Id: 1fc5f90e-cb6e-44a7-ebc9-08dd457e76b3 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?J+7V/f7SqbNBKMOF3nEZrDKjlE8Tv3i?= =?utf-8?q?WcsnUfcPXrKdRhtfCot+fMKayqb+PJ9Bd59YFBv0syPSHRNqVx92Aa+wuN0BNmCsL?= =?utf-8?q?D+LoWzrQYGVimaRt2W35YUykIt3lSVEePbrVDEFLG6EOD/nSGtlZShdpdTBytJhO1?= =?utf-8?q?b0Z5AJWmDj6gqizUyydJd7eDbvzczQs/tR8p1tX8Clg7e+k0hV0bZ57izWiergLHw?= =?utf-8?q?Vq3Hoby8O70GRP8m85OvUAXLrARAdIqX+716yERMduwT+3hZjFVtmd+G6Un1INV9V?= =?utf-8?q?ZqAYg4GBF2rrmO2klDVkP0Bj4UUo6OFnvDL3C7yq2Fm1/IpJMIIRMirT0BY5pB/09?= =?utf-8?q?OSgu0W5I1R7B2Ho/uoOUkoFmkDl+e+9zO2DEq43qy8yUSQKSEl/aBhHa/i0lvhEGd?= =?utf-8?q?BtOvvFaKzzNBQYGxQfFz1moSeu2SAgKcWrWY58UoV/Artn0amSLZQNenCEn45q3zR?= =?utf-8?q?rTOkt5AzRh8GwyfRJB9MQuT0Njbiz+KdY/o2ZKH3MmxCQfqcZp9TQAJ3lsp56QYBs?= =?utf-8?q?v9OKSmB9AGgcyI4+jlqmkKefK0UoY3ZjTBWi042E6NEtwI14lmYiwYOy2qh48bb3q?= =?utf-8?q?06gu5DtOMN/K00yvCGhfM1Ou3cY5/JMma0E78ZxgY5Xsm+A087n33ZnwwLNZVWpe/?= =?utf-8?q?xRPl0O/LSvlbxIJoWepU+6GHY7XKUkKN9fPZq5ylcYP8fyJdWzZ8pSAJYYM1+LyYn?= =?utf-8?q?E/Hmp6CyW4cex83pIB3HLoknJeCCT5YCP2/azfiKqi+BJgeaTyl3JPiOHI0QKOPCN?= =?utf-8?q?dAY46UmG4CHGXaM1APOEWKLzicxDuoInFjfT2F6PcDPJ/SJ4LBx6s8RHW9HZ86/2+?= =?utf-8?q?ly8o01/7Vgoj2g4laB8vsz4JkBBEkUvupej3EPgzSc6dwHwMz/GSafHv0vw7QLUu9?= =?utf-8?q?BxLCiU9ReHEAOsC2Ol02un3c2oCAfDySAREvAUtPb8XpHQmwr5kKuEV8WGb2N/1wi?= =?utf-8?q?LzQ/7ASOz9x05gldrieBWsAddJYSqiKtyRBGoj3zLv7RxqPLtooLaUpBLbWFoB6WK?= =?utf-8?q?uZrVuZ1XmYXxBOQWTQInfHmFIyOi8BL75xVxNI9G06BaNBZbgwXl6t0dgX3OsSPb1?= =?utf-8?q?uMqrOkxYteRuggDWWgiuc6RT4MYx1psEDevNVgB7THazaCNrz2tWkjoJ1yM1XvmOj?= =?utf-8?q?Abe1X+/IveqsSVVcMyd3rAj2FcM4ltM05tOQPUh4sQGhbiY70k1B3B1/UJG1y6W7A?= =?utf-8?q?NBK2UPDf7BDpapm0x0Au4unxNifzAaDHuXJuiAVgqCG6r82ezua7J4K3+7+NKC8sc?= =?utf-8?q?W6kEL9x70j5hBQELcMt9+TpG34TlqGjdSxmdEbSqEF/MgKcY/pLjvQKNuZl4U6B9i?= =?utf-8?q?LUrFolr5+MlowTENeSds0NBBzgZE83X9e0lQ+O9Lj7jq/3RSVTs9Y0E=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(52116014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?ocgQEKJHU6OSMDS/qS+rz+txPuyg?= =?utf-8?q?U853e9wFUUSZAFRy6n47D7s+PZHHciONQw2jBZgok/8Z1X466yPp9OiJaBlXtjLon?= =?utf-8?q?THZEyaCK4i5sr1vPwe5iybiHhEgbGcxHU++8FWtsm+Blivwyt8sijPDXXpWhfzCFU?= =?utf-8?q?XujuWAtle5VB1ZYFYEQtVIlOWVBN426yR21Py78tj59nHrtKLayLCwOcBpsb2Hium?= =?utf-8?q?nQoPD22Mfevb9T/QnbJ0rulGYiougtrgsiLSnYtebJg/V4jwh0f7RM1cPckoMBdom?= =?utf-8?q?Sq+g3JCwiD8mHQviug/xhVLRNHLnvnefMgg+gWVLrDygxC1GWS6q0Hk9W923WEX5p?= =?utf-8?q?7t4CM8C5SlmYUuiYoeKGTTbW5glwLTTxOf23JYvbb0qTLxN0D5/dGJxEKh8Oz/XJR?= =?utf-8?q?36FKMzPLZdNDYwiG9VWX+r0Ospd2AA0C1ngqj4kBbyAbnWoTZ36q+cIv6hRFbhxXA?= =?utf-8?q?09HflxH8A3EhBdGWX+Ehk3Qp/pZfaMcEbYMequKm5BQ0ZzAG6NXK0E8edn3DAmkSW?= =?utf-8?q?BWlX61ouk6aI0DKmHSvH2mWbgE0MWL6zxT6ZyBVpiua1/lGbv5sfKibbfA/emlSIM?= =?utf-8?q?tkpJcaabhgxAhWCHvEwVltqOWvCYcTK6jHM3486rZ/n7tN5SBSCT85WYajv/mcelh?= =?utf-8?q?QNqIhwv8+0T7ZAlEyQNCes/6p1SZkmb95qj6SaLroWn5OiYEyAdXlq25XWYg9nBk8?= =?utf-8?q?r3enzaj3Cd0SQak93PLPZPSRwJ2DiLydKqkJpvSiGIpdVfujq6bM1rjcvpf3uPuzM?= =?utf-8?q?fhxl73bNyc6d6nxpg2aJcUJIDki5DK17bswWh4iIjtv7MP1k3DLfKHPQP7+GSpzbv?= =?utf-8?q?dhT0Q/+Xp2tskAh+KD9dhpjegIeVPtw4W9bYSmm5t14SziGhP/eKdEx3gYz1/0j3V?= =?utf-8?q?8tBMg1Oeq+PjY7W1pT9e60+Ypd7nSYQ4pWcJZDtyKhnZYmo/FYE+UKqAaydfUZEkd?= =?utf-8?q?0fvQ30Zm14iLO20LEqpLWbvpDmzAiEt+vd80GAxJ/HPeOH3O2D+EJEVUIjh9rHfv8?= =?utf-8?q?Sq2MzB5C0dr1kg5H92IX9j3bnrbkGVmf1CuKrp1yrepZFgcA64OZ1HMspwMGFSWX5?= =?utf-8?q?1i13o+8y8EfXz9C3Y92WfcZXEMDUkWn4cHRxVQeB3bPEnr7acB4Lrd/A1DRuAbtjH?= =?utf-8?q?PtiArfLLq+YP+o90xDVlf5F4iQtn7QiKdHyFu/YMArKz9X/SmLcUBzUUowqVqbwCr?= =?utf-8?q?2u73EfNmlcONGpx26C8NvX2SK+HSeqjsXoRB5t0lVJAklcc7oy6UI0d9t85M3ub6o?= =?utf-8?q?0LZPZ2CgU8U0L2ny1tPM1SvV9cbHEG5OQRj88H5gZYnbPDiO7LGhgtwHuYHcF1Jvt?= =?utf-8?q?Gh5fDvf0lYlAlOq6d326jb8Q7To0xOc97Snewo5o7CRFCKQTyBiK9pYCNeNeCQNom?= =?utf-8?q?SrTvTLcxlKeGIMsqnIoVjWkb+lLrMFKpUW8wZCB6OWUaSPW/NTwdljh+5zIdtor8q?= =?utf-8?q?7GCNN8r/xrR5SrxiYWQum7YA8FgFYOFOKMakzG1Npaw+9YEysKlPJ4KXlMihulMcd?= =?utf-8?q?CaaNX3NkyycK?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1fc5f90e-cb6e-44a7-ebc9-08dd457e76b3 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2025 00:46:01.8567 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PQ6HVuj0Tl1Dq8CWznKXPz2yBYYCKcUzAa2dLggL9PApg8DxlrLY8NMIsCFYiyX9Sk2c6VEpDMEvQm9qFBbAKg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8250 From: Peng Fan Use devm_pm_set_wake_irq, then the 'driver.remove()' could be cleaned up. Signed-off-by: Peng Fan --- drivers/input/keyboard/omap4-keypad.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/input/keyboard/omap4-keypad.c b/drivers/input/keyboard/omap4-keypad.c index bffe89c0717adf9ebe5b33892efa4dc30b158f83..b7bd649d1628a6bf10db4135f73778f62db92647 100644 --- a/drivers/input/keyboard/omap4-keypad.c +++ b/drivers/input/keyboard/omap4-keypad.c @@ -465,18 +465,13 @@ static int omap4_keypad_probe(struct platform_device *pdev) } device_init_wakeup(dev, true); - error = dev_pm_set_wake_irq(dev, keypad_data->irq); + error = devm_pm_set_wake_irq(dev, keypad_data->irq); if (error) dev_warn(dev, "failed to set up wakeup irq: %d\n", error); return 0; } -static void omap4_keypad_remove(struct platform_device *pdev) -{ - dev_pm_clear_wake_irq(&pdev->dev); -} - static const struct of_device_id omap_keypad_dt_match[] = { { .compatible = "ti,omap4-keypad" }, {}, @@ -485,7 +480,6 @@ MODULE_DEVICE_TABLE(of, omap_keypad_dt_match); static struct platform_driver omap4_keypad_driver = { .probe = omap4_keypad_probe, - .remove = omap4_keypad_remove, .driver = { .name = "omap4-keypad", .of_match_table = omap_keypad_dt_match, From patchwork Wed Feb 5 00:45:16 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13960272 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2043.outbound.protection.outlook.com [40.107.249.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01AE42288C9; Wed, 5 Feb 2025 00:46:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.249.43 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738716373; cv=fail; b=hECi5EhYDhGOA5L4s2XrPQfnhPrfpeSYZ1hbqdDPuNUmXfYTTaPe8v3OqOwHZY2UPa1ZzNfmt1a4oPB4hhqbgE8oEFYDx86G4eGbr0VOSlfvLQlI1729Oin7Jow5U6idyI4yGo77t55FQYtisQg25wMKcpqmPF/dl8MDGol2Aaw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738716373; c=relaxed/simple; bh=zQeVfeCxLWPp1ta82McHGDfqjkgW42mBMCjsal6VJxQ=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=g88kimO2GRj66gkvcRqbm2BovTZAd6V9kIbLPY0jY0xtxf83KNg06vXaYDqC+Ks3z2aI4IjDl2P2aQm2jZpspHFgIfm79eBSlPPRD4PMZITtfES4wnfvTvpgUHJf+Y8XYezaX3K4LLQpnzKJRHb+kVBb13p3DsIyr5UgnNOXZxg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=aDog5Bet; arc=fail smtp.client-ip=40.107.249.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="aDog5Bet" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=t+XEhXwMEz9LBE4IeSxNDxk1Q63lNO7H3R7FY2nzc4Tm4fz5cdOym0BoGpbLat1SVvX0dQKzg06Q0ks6zCSW7QNhhUMwziZGbCwHlNDN8RLGWbo4Cky2ktcvdXahJgrfhoUMT/zepXeeZ6VFV64vT5PTdf5YkYDPxahBa+22UBFjXE2sIJbKSD85ecHahng+A8m4dq2bIbTzeWgt2Cz+pomWB/iHQpnPq+M7orb2WjShlDFvyXOcbPO+RxJzPT5rUM1oRzX7ZFeQqsWRkP5tN5c7jKg2W7+CmD+2axp3gxaoAATaRZQDrGxaoI+vZ4YmcpM9CbgdkJ4DDGSdg3GLqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eLJ6/6T287sMFeFzpA8pzl4U0kUK+AHmoE0BEwYo/f4=; b=KvEumd7WbmkOmFknrAYbPoQ0d4eRVDHwG7DR/UuEv6yGlcMfq22q8mgJZB0GOlWz8YoqrSLkMQotrwEWYco2P4IxAxwj/C8PVT9+lbWG5cQQpZTDBS0q95d+GDcBZkNInbM2hi2yhAWgFaq2wXF53LtEw8AjD4QatWS/WHUP2lkakvd/hPAsESGLh1bpVupahv5Zsnh09BlaPBNcTgaQjBX6pWl8CYW5CHYGAYf5oDpBWZhvJKXNRlT20uDTwEN+iRrTtUWcN8b+Q4bDT61JA3QWAostqflx5mpVHI/eb+cRGtfWlpF8tXuGLy31h4ZOMAg5fcqn04sgQJ5+WBRXnQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eLJ6/6T287sMFeFzpA8pzl4U0kUK+AHmoE0BEwYo/f4=; b=aDog5Betj8yK/B8AI8pqhiNQUWP1xym92WwWlVNds9jNgMTknsLoB5wePLPwwk7RmayqJCG2es74UjwiWTWs1mbCR7f2HRohImiYJduMQeTOM/rBOxzrHKiX5qhfljHI2FC9kIHjH7kjv4QKMaFata2gs1n/caJm56JuTLV7oTPhrRH2cuzz8esWZ7XwfDbWaxlLSJiZibJsG5k+p33rUrcOPU+v5RpaVY0GdJgsol50PD+YGp3vy22yeQd4TBivR64QiTZPQBf+ks3qbNp1UCoZZ8jC00FAEpyhW8efNoJAjLkySdV4ztmG7Q4q5ZZkati3vF3fu55fOKnaIVCZMA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by DB9PR04MB8250.eurprd04.prod.outlook.com (2603:10a6:10:245::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.25; Wed, 5 Feb 2025 00:46:03 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%3]) with mapi id 15.20.8398.025; Wed, 5 Feb 2025 00:46:03 +0000 From: "Peng Fan (OSS)" Date: Wed, 05 Feb 2025 08:45:16 +0800 Subject: [PATCH 3/4] input: misc: nxp-bbnsm-pwrkey: Use resource managed API to simplify code Message-Id: <20250205-input-cleanup-v1-3-9758898ff8cb@nxp.com> References: <20250205-input-cleanup-v1-0-9758898ff8cb@nxp.com> In-Reply-To: <20250205-input-cleanup-v1-0-9758898ff8cb@nxp.com> To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1738716321; l=1523; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=g2vZhAdAlG59tJHA7zmPtBw4oLxwHW1tSbJmlo9rLyg=; b=F9TW25kz+xXABLmaH6yb/mMDlaYy4cTOAR+MsjSq1CZdIy+avdAjWxqBxOZoHtxMnrQ2Lhb2q acT9Dtv/0ZyAuKqEhKwCvPI0c5nPy6DaSGUprEh9IIX90MOqwuh/i6r X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2P153CA0046.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c6::15) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|DB9PR04MB8250:EE_ X-MS-Office365-Filtering-Correlation-Id: 19780e12-73a2-43c7-62d5-08dd457e77e7 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?HFHM4AbwXSImpwuKeLrjStVTXEpevpM?= =?utf-8?q?XAx6KJTCQWFXKvsdC5SjiTrqTAv5Q7EDboyxWWBahUk67lq6XKN1fIw9dVuhCPLRz?= =?utf-8?q?8gD4ZaggPCIiStl0WxVY8tL7FnbjouQsb9wM7DpLFrCIRQQYrtqPsOYcPL+D/kjcu?= =?utf-8?q?i4oFfFPNbmeKfQjlb83niecGBhALykMtwI36JMKTDL4o2CegLGMP9RaSF7LhCsuQO?= =?utf-8?q?9WjLtwRkDGbOF1OGSr9TpPXnyyxeQfujDzP4ElmzIy9wiSLZ2s7CEFssJB1PtFkwC?= =?utf-8?q?0kOlcZiKqkEQkg4m5pUuVhrrGn6YLB2Fu2TZksJ4XicAg2/bHPpWqxPGbCSfNvOq6?= =?utf-8?q?5H4z6izmdlmg4ZV5mlOGE4TOBOf6lOPhNJNu3rRTOlSuWLkMq/qlGcUTvOLnKqI/u?= =?utf-8?q?R6BT+fEqKz4f0eeCZFH6hHo2Gv9UTVnGSEPZh28spiNc0f5Uagqn+pdT7nZ33vfjL?= =?utf-8?q?NhNxUNbu8e2ADQ8zFqG918/go5CSsD7034Hs5YPx4ekLRXuseofSAQHeSEtSp+Oco?= =?utf-8?q?DjkjIsMroChUXCzKZhKBWbWIVNU2LVnZvLU90FnJX5yu7r7edSuuAI3/nZjQJ7iCL?= =?utf-8?q?KX7eyrK1zqnH9xmepSUkRO1C5GSEoKO3mZ/lEduGb/4b46xsFYN+YqwSY6N3l6azQ?= =?utf-8?q?+1femM/CfnPBe/juAnOkhOIp/R6QV3TeM1e0BvDoWWfB0w6mzJDIVKMPTEjghJeeb?= =?utf-8?q?CwHdDOlXmlzakn7wbOcNxhPzZvmRtOrC1N7SOIMSNC0HFY6kusD/VUwfVXOzuXLOt?= =?utf-8?q?Yih0ciNlmrXK2WkUTd6R8u8jzUj/Al0dnUDJUl9mH8Mmvb2+6vyOzuQng/rED2zgn?= =?utf-8?q?ez1VmYPDlBhYl9WKtWSOkC/Fg2sF3UyyGKwvN6q8N5gRC6m0bNlIHrNq/y9U7IBYc?= =?utf-8?q?C660a6TkVsE2y9nUAALPMCcgCq+dL62A1ozcH4i63oYuknrsapwe2/ASMe+SzQXXb?= =?utf-8?q?xpX5G/uIQ/EJ7x51uoLnS/U6LqqiaPYw/K1kyAHgU9k4qZnn/2SArBmDX3RDyo3sL?= =?utf-8?q?ifqb8yCEMGZzc9uuv6YRS572/aJc1yt/ygPF1seWMJPxyIC5CoVW5ji8JmzJSvGX8?= =?utf-8?q?3RDL4PcI4EaVyJqHhigmtBG1faEb4b1giZtaH6oHXIXsA0sjAudQuZuxFyP4s2DOE?= =?utf-8?q?EwZZTKtXgHMvqXhjn0YcXK34sviHB5i4XA+5CiHMfuGV/7mXH+CSbPOsV6VTwnpDk?= =?utf-8?q?w9HZGIPAkyxq5OQp7viFLiId9mz5cyZTGAGg9VX6jKDg+QTEDAaeioFgw16fdbRD8?= =?utf-8?q?1zRm5jVjSpXCsuDpevTUFln7m6TkWEgbOkv51i1lWLkm64QZZuExut1Fl2NdIrBqZ?= =?utf-8?q?t4I0IUfY0Uv27O+aQjcuTVwrG9V51XzPfRF4WIMrLfVVZFvrdOA1ams=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(52116014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?m0D4pBfCLFT4kQKO2slE6gsE/5Gc?= =?utf-8?q?u3qKZd2qYb+c+EoSWAZGxqIpM+zTAtevpAD1U8fEc/F6Iw23AKyYUHuYpNQsD1w+e?= =?utf-8?q?bc0vjeo/FHguhAgnpRjwnFytdwQ1wmZJYRfARJ2+7rUshpoCWlH+JPq6TDqrtBy5e?= =?utf-8?q?L7HomO213LAdc6ZtRZqHbdLyv8CUnaRrkPINPv2SYH5za5ZnXrXdUZKQ7kMdS9qi9?= =?utf-8?q?2Re0TD3VddPuAzwEkqDDKSKjTee6ZpSqgjrQyWLG0rLlkhi3v0ZmyGnBDn6noQkge?= =?utf-8?q?08Dozf2pKC3HWW2/xqJ7LKFOYoI5Tp66Nc3rZVB8NGi8yIFEjeunATmWk9rCShJ6z?= =?utf-8?q?nSPjYSyTltvNdm9jQBDuqU+KIoitBj1JQYrnmhXwDbzXmbVY5KoEJrMXhkZmZgVEo?= =?utf-8?q?sPNcodLXQOksgtUkUf7MO+o6HDQMYRxEvxdSLwbh8bSY7W4HBmxuNzE3rFNqWxk2T?= =?utf-8?q?ACPArt0i2GOUMZxe3FNJnROSELNOZoPFEiFV6sN9U24h9OPUpbLJB4fj1lqHVCPLc?= =?utf-8?q?lUqiWzyqmM3pgdyRMVMAzvKDjGdmA90Nbb3JT1GqgOzQzVk5voCctgieQ9Pyhud9x?= =?utf-8?q?pIIWCHbADsyULZJcJOSmO9YP6PUvv7w9NNGBVSvTwe34O5pJpUa+OyeZpasHFoRB8?= =?utf-8?q?xpPC/9g093fRVzSxS5DOYqI2NzT0UbVPDC4IqyhX0aIXPeMZNaQuldbcuVuc4VYAt?= =?utf-8?q?ErmFWE+pmDI9kxJHV8O0Pg+ZcC27gIuBatU6pqnjyyyZOM88+pmuFolKTeAKOnTST?= =?utf-8?q?RueZd1IDwMZBA56ovoyj4vayQTOu6w5JFykghM2Eblr95Z3N6KvGn5gq9zzjCFZYm?= =?utf-8?q?zVUh5efvbw0n7Uzveo1B57Y+UR+nNmcnewuP6hw3Fja5sL/yzn6SSzaBMX/pYmuJV?= =?utf-8?q?L6iQIbo7DaK9KOiT0R+XGMd7qYMR+F0H1I26YhBeKY3jDHvJjWiUITtexhX5aFqcP?= =?utf-8?q?1BP3UfQDMKSoFdaX4HOvIAVePyvkxZ/RfpxpxUhqVbo2vPbrB0/iuy+x0vq+/rnaV?= =?utf-8?q?2LTo3qXbXtnSdp9KDte5yhwM5FMbeIh2GoDnXolDAZmegQ8M9ibV/7UTPLW1KqVy+?= =?utf-8?q?JfRAQQSHHSs0kBkbAjuZIz70rSb8gFZy/Oz7EjkwkAGV+RBy5N5XpI07P0SjQe2aN?= =?utf-8?q?rS5j3OMmZvWGtNwQnr8zBGwK35vEsDpN7COK/evTKEY4rhcKiUn0xYxND2/I8DCAk?= =?utf-8?q?Egm12dF9P7MzBk+7aiNLwfImaawJmlF/1ew4+bzUbsEv5EOc2epcNF0g28KogCVio?= =?utf-8?q?24n7HxWwptlzQnXCXi4yobZIEv+po+enfOx2h+q2jwgYsr4f9jzc/ScMSBEJAZnH6?= =?utf-8?q?P3VSfg+lc31Rz1QMnkoMnb0Ombp8HW4Dtf79APZpLn/GRVXQiCsNzxTqG+iBhuqe+?= =?utf-8?q?c2TZKVNQaNyGl9gX2Q75rEaXi5nNCY+zYi1opB/j/9N6Slk9kF3//+O5OYOi4MDQt?= =?utf-8?q?hmc4ObVUtVdvnal0znWW1YVVrJpYGnJijX2oXqbtAfOrYxWKM1b1EVQ3JliCfy2Bx?= =?utf-8?q?xgMxMHaet3PD?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 19780e12-73a2-43c7-62d5-08dd457e77e7 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2025 00:46:03.7305 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LTogL04aT/TcN3D8hrCrH8ArsIBecNVAoGOLgiF2uAgqBZoSBpNfsx9ZIlTJH0iNi4kYlX1YpwYo1Kz5rRg/sg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8250 From: Peng Fan Use devm_pm_set_wake_irq and devm_device_init_wakeup to cleanup the 'driver.remove()' hook. Signed-off-by: Peng Fan --- drivers/input/misc/nxp-bbnsm-pwrkey.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/input/misc/nxp-bbnsm-pwrkey.c b/drivers/input/misc/nxp-bbnsm-pwrkey.c index 7ba8d166d68c18b396e616f6f9074ae98c4629b7..5faad2c98af35c52dcacbf25728dbaf2cbb3c625 100644 --- a/drivers/input/misc/nxp-bbnsm-pwrkey.c +++ b/drivers/input/misc/nxp-bbnsm-pwrkey.c @@ -179,20 +179,17 @@ static int bbnsm_pwrkey_probe(struct platform_device *pdev) return error; } - device_init_wakeup(&pdev->dev, true); - error = dev_pm_set_wake_irq(&pdev->dev, bbnsm->irq); + error = devm_device_init_wakeup(&pdev->dev); + if (error) + return error; + + error = devm_pm_set_wake_irq(&pdev->dev, bbnsm->irq); if (error) dev_warn(&pdev->dev, "irq wake enable failed.\n"); return 0; } -static void bbnsm_pwrkey_remove(struct platform_device *pdev) -{ - dev_pm_clear_wake_irq(&pdev->dev); - device_init_wakeup(&pdev->dev, false); -} - static int __maybe_unused bbnsm_pwrkey_suspend(struct device *dev) { struct platform_device *pdev = to_platform_device(dev); @@ -229,8 +226,6 @@ static struct platform_driver bbnsm_pwrkey_driver = { .of_match_table = bbnsm_pwrkey_ids, }, .probe = bbnsm_pwrkey_probe, - .remove = bbnsm_pwrkey_remove, - }; module_platform_driver(bbnsm_pwrkey_driver); From patchwork Wed Feb 5 00:45:17 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13960273 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2043.outbound.protection.outlook.com [40.107.249.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 577E82288E0; Wed, 5 Feb 2025 00:46:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.249.43 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738716375; cv=fail; b=I794mPEKdV/IGk70i+t1KK7O3EGkWr1ZVU1mkPdY5RNslkSc9kF8I382KVKZGcMru98QI9Kbl+5ckLVI1FnljVUw71EVJ/jnf3FdlyjsKc2aPfBcBJdgBH4s3fN+HAMKunNMXElY+vS9wwvhwPHAxIho5kY7cNzCpD6SAqvn5V8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738716375; c=relaxed/simple; bh=yGvaO4CE8KR0YjpwnelDEdIH1YkR2FTo1uOdpptvhd8=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=mKGco8nVoBaoNvwPXqP2yCpU85sDhS6EwpmdVhAXucFenYFEolkxyACcYhfCaRkR2E/cQII+v8NpKtNPfxnZ2HOvO52wurHkg7DqDsuJCVVBBV74eo8aSnEIPRkXA6eBubkt3FMCN2dbp9pdTF/z9MSkxVqRJiHc/lv4y5jpSes= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=nNqVRm8M; arc=fail smtp.client-ip=40.107.249.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="nNqVRm8M" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=R8IS78PrAn1chKKm/8pa8WXCgJeJSynvFnpDRrOJUTaSh0MW8SmYvtKSe2hZ8lIdlcv4v/QmtzHaPUUgQ7mfe3e2BQ+RpYtKRxrbae0Tm30b7Zk9q1XmdH3U77nQ7agmw+IM0GsqolPvUuJouKNZQm6gaxhF11S/PUsGVAu0dyQSziHXBqouSPpo90UhrPBe0GDWpZiihzZf5YthdptfwVuupMyQ05fZNGpEEZ48JVcrTad/tO4Rvm7sTFhGxfdviLc154esIMV8Q0NksUDr5T+8oo+9Fl6hL0ILyNCovUDymo+Y0LSoihNGpW9m+OZFJZSf2n3xpAWug8OLBD+Kpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MhC1ngrU87eDqzUYVlj3esO6y93gVDOOhc8DDXGyy0w=; b=H99EvhV+zhswqkMBOAlx3mEFapU/CIAC9RScVt4wQ7mqIwi4P37o3E8lKsYKobjiD7rZUAQzisMwqwj3MMB44eIB+z6jBexG4GhxcN826U36J8J/nnv4TTxjKHuIUV7EHeysar6i4RCJxr4RmVDBIV78a+BnWchSHFrKNig4QjCEb8p2gCtE6NqFxULrdyB4Ur4e4IMHtq8rDtUUiQUgAC9kBxOY6jFOIOpRxc6iMgqPsnHH7QtskNKNdj+BeouPtc/m9+nXI0KS15xFIU6tFbG8UwvjAwE95Ue2K+UVPgmbAIpmGVjWH9r5LTUsrqDpnQ/dxWM6SGmGNw/js1m88g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MhC1ngrU87eDqzUYVlj3esO6y93gVDOOhc8DDXGyy0w=; b=nNqVRm8MiFmcLLehNIEGjmyEVThQKuPAN1vhKjPhVbfbZ67NRLQALqfCVrLYcaccdwIMhLVS8N5b+mdChiG/JDNnMvlRsUYrPg4ir00pItlwaMjEBe0/0s7GDa1zLXZClEzRRT0JtVWb+NH2JZXxWqvPgvIK29VB+3n5Xa/vcNXcqOSlsJqeDJ/oBPrpalTSjU5hERAsBZzgmtSkx5j7sVIpIpcFxvX95Th6xgoCoSs70YzlUbHDfVhgqxjRHTeS1wqdZBKrubDwXpL1NW4/LKioqE8WqTIIlYn9/69D0ZhVSsLbVReMGrU7Yt2kUi2oN9KgZn7qHz2Usd4hdXa28A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by DB9PR04MB8250.eurprd04.prod.outlook.com (2603:10a6:10:245::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.25; Wed, 5 Feb 2025 00:46:05 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%3]) with mapi id 15.20.8398.025; Wed, 5 Feb 2025 00:46:05 +0000 From: "Peng Fan (OSS)" Date: Wed, 05 Feb 2025 08:45:17 +0800 Subject: [PATCH 4/4] input: touchscreen: ti_am335x_tsc: Use resource managed API to simplify code Message-Id: <20250205-input-cleanup-v1-4-9758898ff8cb@nxp.com> References: <20250205-input-cleanup-v1-0-9758898ff8cb@nxp.com> In-Reply-To: <20250205-input-cleanup-v1-0-9758898ff8cb@nxp.com> To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1738716321; l=3411; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=1lZmp/EoQtZDgK9cRNpEHi0IbcGjqZ+/tYP3nl5MGB4=; b=DgvMfxudnP8VmAR/dqhrCBmy8vN9qi34oTNOmcn54WRJFI9MBo2hO2FeA2MYMam2VkZenkwyT ZVqSCnZ4D0IA1QHZoEyl0kTFw12bjlwPBCWwiGjxZy8uNXD9E0mrguM X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2P153CA0046.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c6::15) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|DB9PR04MB8250:EE_ X-MS-Office365-Filtering-Correlation-Id: d267fe25-30a6-4da5-8362-08dd457e78f7 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?dQ9ZUcEkqlsAWfwFLdSwnsYrQkMIPQH?= =?utf-8?q?9ANLFJUM+M3bwcIidjtX9+xi3KmJvc29QBfDhwKaDTVDvq/bXPpcSbdg7ooo6zKU8?= =?utf-8?q?LdVsbZBg2ITkK9hSrzbo6QR8eNk5UGDqVZz7MJf0tzCyMbNX6S+UOcEpD+/dAp3ii?= =?utf-8?q?8mUIufrRvmmKMCVs8l3lQEqTkRe09BnVMjes1sT5wqXDe7hfYQqrG/OhkG0JOhJjR?= =?utf-8?q?G5f9diC3+UaWmFXASkUPh3Er36+oaNmN/DXPVgQhgwEM5xq0fFJxw42Op/CBfhDxN?= =?utf-8?q?ExcDwOjwFg9sopNs97qzbZutVuPAthsUwoonG53/Pmq9xIKPCR932PePb3E5mcsWZ?= =?utf-8?q?C4kBTguRzAq+PwNcGeGben002UBZvMWbfHClOevtRFAhU7kex+wTHnfuXFMF8u20R?= =?utf-8?q?ifGR05mhYUOdBqi+39vfaf9jrZdW0t7R7i/Tn42Iouya4YqhPXIUVbeGK5AradcE5?= =?utf-8?q?M5zL0qlXQvZiju+wwZlyathHhOfKJTXVzr6fH10In4XUICbz3u4TKhceSga/tDwIz?= =?utf-8?q?ijVRP1Jh7ewKn0BNg1iq+3mHz5Ags/jgB15s/FoaZFJQvxtFo+V+ckchK/5nme31P?= =?utf-8?q?9Uwi2gS2iruNGSv/D4sFzcFWOTF0MRmuGHuOSO5Fd6ykmgg7FF/Dcsqb6fVOYW+f/?= =?utf-8?q?d6X7DEto4IXHm2uyx1jKSpea262FKzjx5yl5/sHGETbnTsRxTGt1u+fYJVEpPFAdi?= =?utf-8?q?o5EF/85w9qNIGdxB6216xVmOdm6k5qMWIye/M4cTkZoFavd6AvJHukyXuJzHzR53o?= =?utf-8?q?GzCG4VyWN8HOjFfTcu86Kr77FiVI97nP4Si+9Jox5WsATByiA23XeGZzMSOny6bhT?= =?utf-8?q?0fLM6ZwT2aDIzSfHeE+VXAnIglpKjWit5aCgqDbhzjQnzTxVHpsmD0v1+x3s9WmrR?= =?utf-8?q?6ohnTjoBJPMypgFvgP3gHsjHoMe5XHxjwbvRuP64fE7GC1zZwEDBxhreHqc4w/kzS?= =?utf-8?q?KKRZRcOTVm81sxnNwWc/0ltzrOluRRwo2J35Pkkn5NLqJFBABbfGY6l7+UuZd5V2x?= =?utf-8?q?aWMkBsbC4wVXhTHR93NJ/GMrZZbdGgqvvJc0rt1S8TNr+g1fAEnMjjd9sdDXO4WXK?= =?utf-8?q?lRKmJVfKpdzg2osqgU94bTVAN0D0p3uIhS1cZpMHccgJFYANQbEHO/DgW/60WjkbN?= =?utf-8?q?8Kxl5tMrz1i1RhkNfklrlomy3mBCJ+oJTFlCy0gYDGXKx0FN6eubQqRngHSQ6NiQA?= =?utf-8?q?36oieTti1YU1QqG4XuI8KPlPhXF3lxMfrl6GLt8SXdbFErVi1V2nUVokEtl6klPo4?= =?utf-8?q?p0n1k9OuM33OYrwashEeGwIcrb6oLoXbG6VT3LiPNsuIJVwYrdqnfDTh50UnEerH7?= =?utf-8?q?VvDCQCWDPPNAXDoVisOv21mmKhqLxlx07IUnjnRDpFQXOe2k3YJhfeI2eU7lDgYtq?= =?utf-8?q?rTbL6k4W9vV?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(52116014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?5Ey0C+/fjff/z7ajY9O+mz/UvL8M?= =?utf-8?q?pCFe5Pq5FMz3AzEc9Qaik1p8kwanEEAIqoUvpAPLl1mFykpMtNZT+Ee+IdWOorCWT?= =?utf-8?q?iNDd4RlCnxmy0+DNY4JXrVxZiXjlxkfu4CffiWH/SWDgS2aaBgo04jz6qwRvNkr6l?= =?utf-8?q?CesaD7sW6PGJpz02hCxCs3when373Oi7gcSCQ3OaFc+xiyKBhoLtgcwcQpsqcYn9l?= =?utf-8?q?gWo2POGexjlvxG3F5qH6KqH8zZJvyNPDnNLbmBW+25cp6xlBJl11wLIO5kSbiZRx8?= =?utf-8?q?nFYYc73rrpE1RZ2VEGHCot5AIQm7qoIWdxnY7Z8bmcDfZ0pu8q6ENNI3r4Q/qWpGw?= =?utf-8?q?WT7arzG9TKzh/cq7bkaKumF8E98aA0BeDborllVi9fcpryxHHmOEWXbuc/7Ie1l+8?= =?utf-8?q?s1u7n/5jc0tzxDEPYD9j998vqhhrB+Njk5VwQUgWsJX/SwWjMZaKpWpZROEfwppTp?= =?utf-8?q?svZfHrX/jnhfrUyzUdhtBWCc8u/ofRPOLCmvT/GPVrlLsTWQvA999rMRbij2KrJvO?= =?utf-8?q?yXWIekSXL3JKtugZtRGV7YDGlYXO3GNP67Qe+HErwchmlPjtSv+ve0zIVwdC9+u1k?= =?utf-8?q?nd0znWfOKXFKRfdRzOe7U7UkqH4lDAxX3vTMD7TtM+IB1Ya/XfJy3WdzD2qa0WCaW?= =?utf-8?q?V0h1lbtXHl3RrIMcHwu1vI20Pxzywsu3pT/+wJ5ZjH0+N12UTO3vtOLangy3hFsY/?= =?utf-8?q?+tvhHvKqEtBAouJPAGBQ92OARz0uK0cTKLlsFgGeO7dmeY6U+akAyxlcP63JLcrq0?= =?utf-8?q?8dRmyQqtxYOCp9LUoUrfkY6MBWVkRKaukPK1bAOQTEWG6eCFfYcSM5I9okREW6yjT?= =?utf-8?q?uvFzOiJepw2L4E4bR8JVZr6/L97INxYnnWj/vcHf4Y7rmkzJKpe48yYq/CNlQtVyT?= =?utf-8?q?IgS6+5HlFTNMrxyL4cdkwNJA/+rUiIN4yXVhiuXkuTB2alyR7MCYgrMOOR27lLxfo?= =?utf-8?q?nvjY55qZvP6BfXh0et0fAW2o6PNgMpHRAy3C5lTHHU3/Fb8Kqfg+nad39urj9sSGW?= =?utf-8?q?5iWmYPU48OGKQJhMqr8HPueh0vH6X3gT+ML9SntrfJ/tHSJQc/7Hm7M/JzVRZha42?= =?utf-8?q?X6YWEm7uC7HbKErMpJTklUgoYKssqT5EEs6XuK/a7REdWPPwddrinkDkWw1nby2Uo?= =?utf-8?q?xqiuhILlCQhKC85yIfMXUbyvWoUd6TyvgeDmQQ71nTVeV/d50stEL5AKOgxZ6tB5q?= =?utf-8?q?6pLFQmGlwSGFE15EDaIJVsZjuapWJ71h6PPW78a08v5p1Ojn4wOJA+recxLgzOLIn?= =?utf-8?q?EGvoJvntwsK+3l1DadIqDDCGHdFSxQcJkilMsYVoosJq6tjAmAyAw4W8X7d7F12xF?= =?utf-8?q?lo677hgRqpQLJqiBg03b+7mgmtzzbqqxi53X+jEUHo7UbSi0iYFg+beZ4J6Q5eRqw?= =?utf-8?q?mp6+LjBXuJOkDU5ZOa+g8YdPo6OmKxVxHOe/2KejYxB01jPAwNyairjuyXFaDiGaw?= =?utf-8?q?MhKHGaJkH0AIhEDez803Miay89m1C2DN7tbmS+6388haktgc4GhZimFqi547GLqGc?= =?utf-8?q?hUBDC1EqfYfj?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: d267fe25-30a6-4da5-8362-08dd457e78f7 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2025 00:46:05.5394 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mSV1+6dVHybSwQjniLqegs1LKiSrgk61RRfNdaUhyIFTRFxv4a3O1autGDDp9pN0Cw19TwjbWwws+0yGuGi+8w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8250 From: Peng Fan Use devm_input_allocate_device/devm_kzalloc/devm_request_irq to simplify code Signed-off-by: Peng Fan --- drivers/input/touchscreen/ti_am335x_tsc.c | 43 ++++++++++--------------------- 1 file changed, 14 insertions(+), 29 deletions(-) diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touchscreen/ti_am335x_tsc.c index 93d659ff90aa94ecbd7000fe05e0eef8ab3546ba..aef38b2e4e464e3b76395de5991a0f41b4f852f4 100644 --- a/drivers/input/touchscreen/ti_am335x_tsc.c +++ b/drivers/input/touchscreen/ti_am335x_tsc.c @@ -418,12 +418,11 @@ static int titsc_probe(struct platform_device *pdev) int err; /* Allocate memory for device */ - ts_dev = kzalloc(sizeof(*ts_dev), GFP_KERNEL); - input_dev = input_allocate_device(); + ts_dev = devm_kzalloc(&pdev->dev, sizeof(*ts_dev), GFP_KERNEL); + input_dev = devm_input_allocate_device(&pdev->dev); if (!ts_dev || !input_dev) { dev_err(&pdev->dev, "failed to allocate memory.\n"); - err = -ENOMEM; - goto err_free_mem; + return -ENOMEM; } tscadc_dev->tsc = ts_dev; @@ -435,18 +434,21 @@ static int titsc_probe(struct platform_device *pdev) err = titsc_parse_dt(pdev, ts_dev); if (err) { dev_err(&pdev->dev, "Could not find valid DT data.\n"); - goto err_free_mem; + return err; } - err = request_irq(ts_dev->irq, titsc_irq, - IRQF_SHARED, pdev->dev.driver->name, ts_dev); + err = devm_request_irq(&pdev->dev, ts_dev->irq, titsc_irq, IRQF_SHARED, + pdev->dev.driver->name, ts_dev); if (err) { dev_err(&pdev->dev, "failed to allocate irq.\n"); - goto err_free_mem; + return err; } - device_init_wakeup(&pdev->dev, true); - err = dev_pm_set_wake_irq(&pdev->dev, ts_dev->irq); + err = devm_device_init_wakeup(&pdev->dev); + if (err) + dev_err(&pdev->dev, "device init wakeup failed.\n"); + + err = devm_pm_set_wake_irq(&pdev->dev, ts_dev->irq); if (err) dev_err(&pdev->dev, "irq wake enable failed.\n"); @@ -456,7 +458,7 @@ static int titsc_probe(struct platform_device *pdev) err = titsc_config_wires(ts_dev); if (err) { dev_err(&pdev->dev, "wrong i/p wire configuration\n"); - goto err_free_irq; + return err; } titsc_step_config(ts_dev); titsc_writel(ts_dev, REG_FIFO0THR, @@ -475,19 +477,10 @@ static int titsc_probe(struct platform_device *pdev) /* register to the input system */ err = input_register_device(input_dev); if (err) - goto err_free_irq; + return err; platform_set_drvdata(pdev, ts_dev); return 0; - -err_free_irq: - dev_pm_clear_wake_irq(&pdev->dev); - device_init_wakeup(&pdev->dev, false); - free_irq(ts_dev->irq, ts_dev); -err_free_mem: - input_free_device(input_dev); - kfree(ts_dev); - return err; } static void titsc_remove(struct platform_device *pdev) @@ -495,18 +488,10 @@ static void titsc_remove(struct platform_device *pdev) struct titsc *ts_dev = platform_get_drvdata(pdev); u32 steps; - dev_pm_clear_wake_irq(&pdev->dev); - device_init_wakeup(&pdev->dev, false); - free_irq(ts_dev->irq, ts_dev); - /* total steps followed by the enable mask */ steps = 2 * ts_dev->coordinate_readouts + 2; steps = (1 << steps) - 1; am335x_tsc_se_clr(ts_dev->mfd_tscadc, steps); - - input_unregister_device(ts_dev->input); - - kfree(ts_dev); } static int titsc_suspend(struct device *dev)