From patchwork Wed Feb 5 00:58:19 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13960290 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A3F4C02196 for ; Wed, 5 Feb 2025 01:02:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To: In-Reply-To:References:Message-Id:Content-Transfer-Encoding:Content-Type: Subject:Date:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cXhN8yZODNUAFFzTvDXueHauX0spZjv+doLw4DqIRFA=; b=0Jr4/PdytfOd6zrUjuS9wKbxFh jTmYIA/YUpCQdK2e5hIE9kzNvxHc9ezmeHMdLvgbc0Ux9R0tq/6WOEeEyJ3pmEX1QzZcmH7oEmkFn wegDYz7i38cmQjO7pySUSo2aRVDs+++H0abmA5CUstDWpQrtBrHePkD1xZtp+kv7PRj3FKCFJVQbB wdUPK6VStg43vKaSijY7+saV2jqShA4uUQj8/DtJ9ame2Qnh5lDFBf3lbOarYD/HGV5hSgInYoTM1 +ZGER1c5qHv+kdQFR32BWrpvPc2s6avMAorftvmN/7wXO7xZdeTkdTdgj5EsXGREA2iBzzqkzfyu7 9v9zwIdA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tfTnm-00000001ypu-0Hq7; Wed, 05 Feb 2025 01:02:02 +0000 Received: from mail-francecentralazlp170130007.outbound.protection.outlook.com ([2a01:111:f403:c20a::7] helo=PA4PR04CU001.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tfTl9-00000001yLX-0j6z; Wed, 05 Feb 2025 00:59:20 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Hgz+tF5bRZ5pi15daCNM+b9SL0SkV2QBZaSxWPz/DF9zkQ52mZCOWJgahUhf+vZeZ2FemrLT4ieIXElQpkW52bV7ySfwf2FCLyk0HcSjiu8M+55OyCkn/lk84cPOtUuGN7T2THhrlVo+cfDOjhYTXHEYNQM1J14+qbHfjCwggJDc1me/O82LqzLQKsWW2xIpgiuHk8kRfPQrmasWrDvVgHaUmWx7/ut/1tWlOfzhvGHBQcFpV4ebda9XBjtxG0xxZ2YUUDdHOQoRzBNa62qMEd+8fqj+rjNafq7rXP/loCZV9E8h3vdTC9Ni3lXQ8cmA6tMGUPltSWLX0RfeMKLLxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cXhN8yZODNUAFFzTvDXueHauX0spZjv+doLw4DqIRFA=; b=hRDcZlbQYgnPziO1TpwRtfNywnXZbvM7uZk1Z8ui0cGvS132Xb4j0PTIKE2eS1n+eXjEMha2HmCtoLCQkCxnTyJ6WMsCawj0vjZbMQ8gDbbW7S9z8gngYEG193MYtBlj+AUS/Akokjp+CN3whU1+i4HxGbYcqBZDl8dwk1HbKQ9pKwYkGZlbVLVFBTjsYnP0/za31xz79dz0vHCBtfnh+AdBZdrT2lNcc0InQ/KckJZThWAp2ZwmvpoHlnUeJcCAu3DGlPtizR3FlZNXJDQlIfz8ewgJQILp+GzlNepGjK6lsOnDi575+RAEFisIlX8U3kbd2j+B4vwIoqGgHOIFbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cXhN8yZODNUAFFzTvDXueHauX0spZjv+doLw4DqIRFA=; b=SSRj6NMITme3BmCQyggX91rD+xXzcDvoYjOvKWZAREPcgnQNLeVXZNv5M+1lb0f4ag42srQcvcDdpMHjIAeHTiy+0lcwh1SVGz2+kN89LW+gzUK6p81EDi4t9KNl9QRss5b/L2jF9gM6tDmahATootyq9wfh1zgJ/gcIe8EXyHVC7uMiYOY/nmen101sYeRSgjfricu9C+f8y6UlyxqB7XHQIKafarnOBSNfpDyzV5F3IJP+V/IL1Hz58xWVvufxsxCJJEezTxM09CtMLwkDSwqdZQm8eann3dU2/c4UWywTU4sZz18TbYEkAB614lcHxbBq24ibzIOytzDKAYDxoQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by VI2PR04MB10713.eurprd04.prod.outlook.com (2603:10a6:800:275::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.26; Wed, 5 Feb 2025 00:59:14 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%3]) with mapi id 15.20.8398.025; Wed, 5 Feb 2025 00:59:13 +0000 From: "Peng Fan (OSS)" Date: Wed, 05 Feb 2025 08:58:19 +0800 Subject: [PATCH 1/7] rtc: stm32: Use resource managed API to simplify code Message-Id: <20250205-rtc-cleanup-v1-1-66165678e089@nxp.com> References: <20250205-rtc-cleanup-v1-0-66165678e089@nxp.com> In-Reply-To: <20250205-rtc-cleanup-v1-0-66165678e089@nxp.com> To: Alexandre Belloni , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Conor Dooley , Daire McNamara Cc: linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, Peng Fan , Antonio Borneo X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1738717111; l=1587; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=mSTCl6oCfnAa45eZZ0ce81+vqGl5rBwE3yA3RKdgxSo=; b=Lk2a2rVgsQVbE64qePKxXCkNhWNVGlTJaj4JEupetcuunmnR/EErmB3/D3wwreSFhSh+WzdaX WTLr3G09U4QAFHak6Ng+ayGTwEopXQOaC+KXtjNT6urJ+uuLKBqHa1h X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2P153CA0034.APCP153.PROD.OUTLOOK.COM (2603:1096:4:190::17) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|VI2PR04MB10713:EE_ X-MS-Office365-Filtering-Correlation-Id: 99d3215b-3ecc-4065-7f04-08dd45804ee1 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|52116014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?7jzUzVRt+y7uI5unLTfg9ghFoB7SWMW?= =?utf-8?q?DXIJ+kE4ZNRX89xdyaSQ5tJKLjUUHLfvxl8+3PozCkzSQnWcHJDmubZjn8nAzSYIs?= =?utf-8?q?Nxvl+v+No3JLt7ipKfkgbuZttlky/Ion31KAEU6BB8iTmPWZnmEcnSQ+cvjZWv3be?= =?utf-8?q?6cdDsAcnAcfnLj9+AB8EUmcEmkv0tAUUNCX3GpV5zgH9aoPQglGfPWEP/+tx5JOqx?= =?utf-8?q?7gYsp0Mj0HCWrPhDP3MQdPKkpW661meebn8etVNEU3OeazGr+wPKWDOjTnHHeV3lg?= =?utf-8?q?eGprNBh1j37aMqWLKXta7k7RF2q3puQ7GQ33NCQAEPCSqKH3fzIhz2PQK3pFzaqeV?= =?utf-8?q?8tKrQs+d2mvqaFLMgWgZDxouo1YbJB1r5CmwTrEBFtCkifbAAHn655srODteMUxmF?= =?utf-8?q?UXNIp/soXbJm6Ak1u2jFRsNkeOF4A0GK8HaqmUhjn6N2UT7qiuR8pFD+pa+Otw+Kb?= =?utf-8?q?ayhvoi2ntR/sZ0bzfhC2J7XKtkCom7yIWLRURDkMe2vHnPA3bI2JFyH0ghpdE3awI?= =?utf-8?q?AwUhig5IY3p+/qxqIv61/ZiOPe3H87qAdlrphC1q98D5tEbFh98JXAZA6xxXkU0fJ?= =?utf-8?q?uAVcPWa0sNG26C8gg0x5gCTTK8qLD3UrR/pxs7bu8SJLC1OTBQFsgqgJYVJq6r/+D?= =?utf-8?q?fidUEzO7HzSer7Ri0XAteK8DdSwo9rnnh7DJ88ASo17P6JRwUHFl9FIyomcS2vdng?= =?utf-8?q?OT3Lid1y/cj/icGFfA0EVFY/UT/TVuM6IC8o7pcc28SPCA9Z8S1EY0p/0Sy2fR2ni?= =?utf-8?q?p+4S5PbRoR8R+xtFsuTEXTJd3jRZUtAFh5qt+Y4njojJLNFU0T0THSI4UVj8Rwd85?= =?utf-8?q?6UkXIzCGqgzL9+K+THGbcdF5sf9Nqof4VCAi2nF2+z70uai+oBTmE2IRiZlDeLKF2?= =?utf-8?q?lPyj21LDxMCTGJ8F+FTIYIkpquOgwRdxt8jGT03Mi5kQAdIhMVpwARLqL6xoiKmSI?= =?utf-8?q?SSSsCzyEoc9qkZruUCCMBVWh9dxF3cu2YUIbzj8NGgqF7yhgJkLj9472REcrlRF/b?= =?utf-8?q?6rz5N89fxkGuWmdAY645LRihWe0g7h0Ix0IEkpMcygbmDDalK3OCqBM4OzWfZ1Pi3?= =?utf-8?q?Pq/znkxVFPvlCuA/t/Gmc9IUnvxBCPQ6nsXGwyilyFdy/vXessEpq8qNaToETli9u?= =?utf-8?q?GegNOGU4PxP491cNB9YfTWOea9FYVDfViLzVYYOTIIAeZ+yftal3P3mhGoYRGX7oF?= =?utf-8?q?SXcMFtVq19/ifcfXXxMlRb1C2u7590Ljc8eewWq8WLjbyffEYVPEhPhtYIFXJqGv/?= =?utf-8?q?ridozosR1AoN5kYzr6QLFgP8JCPKBnwLc9Yd0duNUKl0rxKup3DVZssFlbKgW/Ou5?= =?utf-8?q?u+Sewts5Uc84U079ac9oyGPxi+C4f9sZ5He7qSy1sAz9cHBcMcZeDAwlDCjRoNiLW?= =?utf-8?q?LLmLDV+4R8O?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(52116014)(366016)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?F8l5dusLkHlwLozVxELh497oCt0h?= =?utf-8?q?BllnUgrvf0cp4d8TmxaoYfsM7rfvJGQn135CfKWln40xjJlO18ChlT7FliGCn6Urw?= =?utf-8?q?rmqFK0edvoUTDhWU+CvzOfsnIvrlsaFh/yYxj5CmwmaffeuvREnEkNDB7gDoHPmjJ?= =?utf-8?q?0EDOrG2b78ynE2p8O0S6jW8gt8WcH6S+VOvfzwv5/EyKSSgxE+hyXbTTqT+0ftrSm?= =?utf-8?q?u6vjEgo/L7bRYHwZGs/2uP2Xg452A/WBT5qB5QvZNTpACbCPH7cYrN9QT1Yl4L28/?= =?utf-8?q?IvBKXiUEcTyG/4pE2EyewQpLjdOPP3dUvtZrOygpxK3A0jtWC83sjx91juYfQFGla?= =?utf-8?q?hooWrg2nPXm/4XxEKcj0rXH2Bm5iPibJ1NQs77fkUVbM/BZW+n70P/uFqUk610FvQ?= =?utf-8?q?SEzpeQPsYQiOsvsr+yoY7DZrJMR1v44FBhca5lOnG1LaDEmVVii/E2Gzi83tu9WJL?= =?utf-8?q?DGjd3Sx4ZaWGRWNs7tIGBPnrpDEwGn21YSEM3WvvIs7wL9778ElcHmzq7iJJzp91w?= =?utf-8?q?L6DC3JpBPYKmKPbNQGrlKLDyDGeTlPkdtMzSUk2K2KA32NmnA6cO7B05NMgjAAtH5?= =?utf-8?q?EQ8y9IcqnUZj4fbVzCuaBkfIsChnxeD6P4HBgmTWeCmuie5ikN5YeLHVFMqJgEgv8?= =?utf-8?q?pZ/U5fuH7BtGZRlv7Ev0mUMtPO5DlQBPnhPpa+aCZ5prF7qgt6q2kdLh8+SNqOGnF?= =?utf-8?q?ZI/9l/M7/ZKkaEqigivx1qxsGhuPdv89r2HYxgM4wvqu98qad6ZwUKfFHOgrysvJh?= =?utf-8?q?7KiBq6u5f5sE8TElcc/z2CdXc2K5T7vLnpuc717v9FuuV8nHyrSuYzakdmzrA/aXP?= =?utf-8?q?2Qe0vymTxE5p4aywr1JACa95AHaBAJ/dD348DP1zj9SsrIlJPffF7BzCSiOTCe9gN?= =?utf-8?q?WSYU+6UFOWiY+n7wBs53rDqFkqUGH3FLnAgUqVrx9irLB5/Z5vo+ncrGBbF0biX7n?= =?utf-8?q?8X499YPI2GZJLZTXpeZILyWej2X13YLHnQxsbY7lCb22LqHm/GkgLu64ZoOLpYSqt?= =?utf-8?q?fm2t6lN+NPPvolwq6m4pVzJf9Gsp1Sk+uKti2BkuOcEm7B2xLCb7qol8/LYM27rot?= =?utf-8?q?KoU8RytPdlNff7BUiP1W4JpzeIKWtXeIgbN0jfEVpym2UO51lML8GgyM69K2fFzFP?= =?utf-8?q?6gdqpR/UevGC8Ots3aEj6KhrsJgUYgzpjbAGjKeEEwQB9Zx5Sx/e7k1VhQaW8N2MV?= =?utf-8?q?gdzQhQjEdd1Chz93v2DqQJ3dce3+GZY75Xg5cV78oQVe955cCDph6I9BrouV2Tzfn?= =?utf-8?q?nO9C084vMzeBlCpgYpodRB5Rm2bZDDgVRAJBhIRW/LZ/FVVT76jeoxKwG3wtpRz+o?= =?utf-8?q?KafroeW5Ir1sBcXpTvZeY09oR4iZoLcS9i/wIgw4vuLGkGpT4xccpfijxTyiDCs+f?= =?utf-8?q?wx07T1fp2IQ/UrllSHMe//nqwuqBRfyH5iYOVCLmRF7wpNfvXW0AsQxpeak9E4kyx?= =?utf-8?q?GfQ0gEUrF7hKr/BX9dhMYjMq6QlBJG6lxCFHnI9OKJUq/QPKSeVv+bOyVNo4isvbz?= =?utf-8?q?95kkhJIGfwDO?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 99d3215b-3ecc-4065-7f04-08dd45804ee1 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2025 00:59:13.9092 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WTsFcdg24zs4xgWICahUxvnqRyfWyXSnbjgdlbO+rRQYOfstAr6scDVt53Uot8pDjSAXBE0i2EWpdGRIET1T7A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI2PR04MB10713 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250204_165919_222843_08D0ED92 X-CRM114-Status: UNSURE ( 9.80 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Peng Fan Use devm_pm_set_wake_irq and devm_device_init_wakeup to cleanup the error handling code and 'driver.remove()' hook. Reviewed-by: Antonio Borneo Signed-off-by: Peng Fan --- drivers/rtc/rtc-stm32.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/rtc/rtc-stm32.c b/drivers/rtc/rtc-stm32.c index a0564d4435690313b86669893ec639af90fd6b68..1b715db47160158b3cfc79c437ea956e301deeb5 100644 --- a/drivers/rtc/rtc-stm32.c +++ b/drivers/rtc/rtc-stm32.c @@ -1143,11 +1143,11 @@ static int stm32_rtc_probe(struct platform_device *pdev) goto err; } - ret = device_init_wakeup(&pdev->dev, true); + ret = devm_device_init_wakeup(&pdev->dev); if (ret) goto err; - ret = dev_pm_set_wake_irq(&pdev->dev, rtc->irq_alarm); + ret = devm_pm_set_wake_irq(&pdev->dev, rtc->irq_alarm); if (ret) goto err; @@ -1208,9 +1208,6 @@ static int stm32_rtc_probe(struct platform_device *pdev) if (rtc->data->need_dbp) regmap_update_bits(rtc->dbp, rtc->dbp_reg, rtc->dbp_mask, 0); - dev_pm_clear_wake_irq(&pdev->dev); - device_init_wakeup(&pdev->dev, false); - return ret; } @@ -1237,9 +1234,6 @@ static void stm32_rtc_remove(struct platform_device *pdev) /* Enable backup domain write protection if needed */ if (rtc->data->need_dbp) regmap_update_bits(rtc->dbp, rtc->dbp_reg, rtc->dbp_mask, 0); - - dev_pm_clear_wake_irq(&pdev->dev); - device_init_wakeup(&pdev->dev, false); } static int stm32_rtc_suspend(struct device *dev) From patchwork Wed Feb 5 00:58:20 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13960291 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0EABC02194 for ; Wed, 5 Feb 2025 01:03:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To: In-Reply-To:References:Message-Id:Content-Transfer-Encoding:Content-Type: Subject:Date:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VFg5y3TrIOn9VH/jNSFVTNtUnnNsK5iZCxLymVMVirI=; b=AWv6ZJ1RVoWz4c2CO4me+8XYf2 EhP+jDnLXU8+VnohPHnbYogMXUxk+F+7O7mB3dS5N3RsWzALR6t/BzQQJQ5y2Z9aEtIBq/wF+7eV2 6mLKNhb3QZfj4f9V9cx7phO5Ny662n385YqKoUTr+2IZ96TSjGwlPYLqgCjs1HnzN1aZ28U8I8hiC wfkv7VXsvc7DOhsLMmcTUnxP8OIaKA1GBaXDd6E69tW+YkdnZq3HzXhcOp3Ex+UCl3KHlNtGnoUZh P3TqzoP28UJzDBc9PUlFwQltztScF2EMINz0E3f/16RWPvMVxo+Vn4cjui1uMK2oUL6svFPXPrHJT U8KqAwjA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tfTp5-00000001z3P-1bzN; Wed, 05 Feb 2025 01:03:23 +0000 Received: from mail-francecentralazlp170130007.outbound.protection.outlook.com ([2a01:111:f403:c20a::7] helo=PA4PR04CU001.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tfTlA-00000001yLX-2SpX; Wed, 05 Feb 2025 00:59:21 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=j8L4dTNQF6PB+2/V2rnCUUxlCPNbDxDGdJKaqqcC2CHW62cmQhbz2rMj1ZsIs6PicomqCVOLmt5zMDD9kYJPabiww1iufXVRy+UJtBr1hZkb6iTzVIXkulIWIE6EvNow8/d3ddiL+UO9WOm8dPAwbG4I+rkWDgag/nVi0AkRw0oLSPJakmlYszUW2bcWpb/1CJGwmFkeZAASpVvxnE2XAbU6b3xDUdG1vBpBRXl/Gsla0Z4FedhBbnTFt+vVkovBaRa3YHd89f+HN+cC30mYSRmMs+i8nVXCRje6MGS/XXzMmnUeYAL2vUK+ZoBEJl20h5BpSfjEN+7mIRa7fHZscA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VFg5y3TrIOn9VH/jNSFVTNtUnnNsK5iZCxLymVMVirI=; b=d8KEGfsBO+a/yMYt/8MeYmgHuHZrP8QIwEToVnW2SWnNsGhocloxslRHZurofmc70z60y+dhpw43WSbrr9Leu3f6J7XY5uVMrwee1m8STDuw9aFY5wHHmpeUXNQc/Dg+4kb2WhOKEDhq79hyv13udt+++xNHZ6igOe8P8Dri1AWviLsCeZUC+ExGWWguT51hNX6wh8MVkNY0Oryj5E1kWqtYPiUt+WvTRrc0BZHel0rNks0QSdDxx0RxF9jLZkYGP7Lv1Qd94jWqn8DHKfI13NZW94HTK8ecr4xdeUGTw3Jsm4X3BHB1yKYQNQ1o9o/8RUZWUzFR/4sRZEqYdHZx9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VFg5y3TrIOn9VH/jNSFVTNtUnnNsK5iZCxLymVMVirI=; b=reSMyPCT8VEPMYbX7GR6+couZPM6zsOs50mP9UrYUzI3Vv21jIraGrIZjG4Ph9DbvZ6lJYrZT+0U3JB9XIw39GRlybNSDG8xEMqUia7X57e0NiwzPQmVy96rS1bPCfFsoK97ToHm8hVLmdOdlGElEmRdQejeBV7S/+MDe/kWKifo5iD0nPvv9HKnFXz6yiNcCcvcTJPD+j6Jot4RSt5wGZ2Ba3hs5oKsmeWE5LfWgnzBnE2lno07pLJB4mbvnErVhVQ9u7rX+Ha3JHR52wLT2DAPNMzRbVjgqhjc4QEHCmT2v7fb6lf4uNpEtwnxFAVNkVuN+9FwOBOgO1txtj45XA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by VI2PR04MB10713.eurprd04.prod.outlook.com (2603:10a6:800:275::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.26; Wed, 5 Feb 2025 00:59:17 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%3]) with mapi id 15.20.8398.025; Wed, 5 Feb 2025 00:59:17 +0000 From: "Peng Fan (OSS)" Date: Wed, 05 Feb 2025 08:58:20 +0800 Subject: [PATCH 2/7] rtc: nxp-bbnsm: Use resource managed API to simplify code Message-Id: <20250205-rtc-cleanup-v1-2-66165678e089@nxp.com> References: <20250205-rtc-cleanup-v1-0-66165678e089@nxp.com> In-Reply-To: <20250205-rtc-cleanup-v1-0-66165678e089@nxp.com> To: Alexandre Belloni , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Conor Dooley , Daire McNamara Cc: linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1738717111; l=2071; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=VAulaoWVPhHtzgpO1nG1u9VR+bogAGzfLBxhdt2/l0I=; b=ENdfDOGh0YGiORqM8nju1hwNzBEhXGkPtvmLmmrZH3kthYHpqDEz/bK2nIQJZOLHJyLNZiEJl KkNPuJQtFo7D3ncM4rUNGcWCBY7luJ/myGCOqhWy0nl6JsNPHZZfAKy X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2P153CA0034.APCP153.PROD.OUTLOOK.COM (2603:1096:4:190::17) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|VI2PR04MB10713:EE_ X-MS-Office365-Filtering-Correlation-Id: 752ceb67-d20d-4efc-4cee-08dd45805124 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|52116014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?ZzTjkaW2EWROo1H+YFwo+vK6EUqyRYQ?= =?utf-8?q?z3sF+sunexW0DEzb1+nIWBflaTEVuHR/2j93LdJkoivdEfiy/QwTXYQt/0+H+4ff2?= =?utf-8?q?RJC2FF0V3qn1tOITiC3q3NQ55KHbr4XgfRM4qXtSDUFdaslLYc8l2hvb5Dw9XlhNQ?= =?utf-8?q?ky4bh06ZvsaIb44t1hK2JOtrCvvtUVUlGrSNLiKJ+bhEpoFkJMa3iOWa5q9BmLzZX?= =?utf-8?q?4x10ULHJ33EaS6wC8q3JKjnXIqoJCoe6u2MHA35hqCpO8crr38rV5YZhMcwA9CzWx?= =?utf-8?q?e4KJNOAEcNnPvLgiUQm5UCOgAjRIPnjP+wod7+QrYTURBUY+C4iapa3VjVlCWcmqr?= =?utf-8?q?ytSMx7Sr8Hj+lkE1SNTvEjedv/W39vj7eYGIJuxRB4pJx9gFNv2tTxFe2g5HYHpQv?= =?utf-8?q?tLyQFgTfjRqahr7V+qtQxt6myVbjwFhLDfAHO46720DxGKrP/SjaLPoq+zNk+K0cC?= =?utf-8?q?cI8UXZ+1F/mz0YnercjQPepzydEeFr6Zl5CNVgEdKFZVlUBteGO9WmDNvwGZpTDgi?= =?utf-8?q?YdVsNNalLhaGb/TFJksXmGoDT4kW6V9Y1LvZwDJVWqSzrMYiByIGGir5FKey1ZJ3H?= =?utf-8?q?OVP3RTUgPxh1my0JJy1O5Cnt7SgaB5KYrxU8e9H7ATi5NpIF+Nywh8SQVKmCs56zm?= =?utf-8?q?fXYh2/Is5Sj6x8mAm05zpsw4XWE7XnRxXtGJeJyR/VMDHlDbcFIdG7jG6J9Sh0B//?= =?utf-8?q?D2VvJNAEC9N9pADhR8hrGJJjIlEY8QdcYfwgE8dgzwyVNGhhr8LN8ilTfAAJmm2I0?= =?utf-8?q?1KDJ9ID2eREd+ix68BB+oste+cYH03mjMgnolGIuf+g/Kvksstv+j2iQMW4n5G4V5?= =?utf-8?q?LUBL2yXPV3sbF6yOU4nwNty4GYYtbg2h5pLkYi+snwh4azQqrCv8Ygfuayo82C+NP?= =?utf-8?q?Xa6A80sDJaNw9TyqTRgJlm0GpU0agWzudebaoiQFeKEik7/02zFCCMQoDTHcffYTp?= =?utf-8?q?DIcp9/6AIpngf6sdJhEZE76HGE7c9XQavkSsbSX8gCzYQWQIyNSU78XgYSZzWFbBz?= =?utf-8?q?6d5AKKLGj6b8q84pvm4YIT/pn9gbLAgdWhQQoZ09QsY3MeBWG44Awt0PaOYcjPqBB?= =?utf-8?q?957Ys/QwXHr7fAW3mfgu90ex8GdhbSyNaRvp6v3ZjMJnbRljmokGCGQ57eZB42jtu?= =?utf-8?q?k1NZj1Pcl2WOmkqSL43AUAGk6vlvtAkhrWIH1sDEaGXVtpuwFt4kl9HSH35v/PcfC?= =?utf-8?q?c+dc9nyWxZ3uIixwg9oSUBT/G75btUs/tQz+f6K3NqTGgyLMz7GhuTYsWbD/EvyHw?= =?utf-8?q?9OscvlAatrV4Wu+ouWSLrcbo2Kl3KQpxzFm3vHVU4fpnnoUkhifv+gBtcMvqxZ2Jd?= =?utf-8?q?8gVGmZEgTX8waRMlTQClJ6/E1ARM8Rc5Sufyer8WOaxvQO65M6vEU1Q=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(52116014)(366016)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?SrF5NF9iSFtz9RXGeAQuMvatJd2/?= =?utf-8?q?I+vI4h9PV8jGU7HaDqsnb+CQza9g5rrMAa3m1UHi8/zvlmkR5ydQyD0GodBTqimy0?= =?utf-8?q?ixp5ZMj3WfE099xaZPoiBUJf9NzjOu1Kn5WuCQvnLi75XMvh4FGPaheCqqT0dIwL0?= =?utf-8?q?SIoofc00ZaLB9W3GtXXRjMz8lrqqfbtUOPs2hkWvuJp7Y5GlEq9QPlCp9awiVR+zh?= =?utf-8?q?uwcD/LFSFrs+oOHi0fJmXCtDmOW6QaTlMxQw0Rm7HCFuCOoJfCh8f3gDgFsso4q1a?= =?utf-8?q?voEsb/ewyr6pd1Z0HeqBMaYhhrD5zbRuQn/ic9aw8iCMGX1s4a5hDA8pX8JdmHZ8+?= =?utf-8?q?/P1089J9/T8er+4V+I6ueodV8vy4JKi3iVC2Anz/LoQSfst3hR7BOw+D/uHoZuwey?= =?utf-8?q?btc0oE8pwDVL6FCHPF/LiRwU2CeAuNSrWz5BYJOwwSM9RijJ8pXc8cjeAk98HSL9A?= =?utf-8?q?iXvmcEUbt7af7pWaS23bcqhIttm4KdBgqwT8X8A0fo4RoG4Fi0dnVNN1otkodhltA?= =?utf-8?q?9hBooGPZBOEj/kjAC937dhmRGcKTzlhMXFBiOikonbrgvqYyLALge+d9nkQ0M9+Mu?= =?utf-8?q?StUwCcpjopcOJ0ZVH2CAfd22K7ZmbYqTDZG6E+50Q8lHIe/IspgIwGAMdNbkomAfP?= =?utf-8?q?kF7q7eUczCeBzN0jhv4/2payA/73L+ouKBnz50Dv5Ozy10bjvYuoXebmp7g2/nxk8?= =?utf-8?q?Ovjwi7IosRxwhzV+ovss/qQqZNVMQ6Ck/diIbqWQ+GPWT3eEWmjJ3sEW5vCBaCRjP?= =?utf-8?q?4EcY/nBgIQAP2Tp2dfGDKt+3TdWAInQlaMwGV5kuyx3RdT8Pcif0d2hVF1mO+O7Xh?= =?utf-8?q?xPyc1YmZZ0gm+tWODWpA/xOx48JzPRrbAbnsyzQ6kCuf8x5jSjOwT+3Gb3xNUxY+a?= =?utf-8?q?wbQpD8KYnFu9XqA+byzEgZM2zG3FKQYK8Cua2xfhutQuHXG+MaXCV6+ZMTBJ7/uc6?= =?utf-8?q?qnXmmOjFjylPGvRvZHry0K1swshL0Zq2NKpJTQy8tHddVqh6WAhwK5B1YvQ/VmQ5o?= =?utf-8?q?uSkVJRy/bI6dQjP0kPb+/VJz5C+JRGWpPqgnTkHiSvWfpflBr+Q2rTU4DEh4sZiHw?= =?utf-8?q?RH5oDBPg/rzllo51K3nDlJM9Jbwf1QdHLjEVIKElPNm1rma481w53L9AMXJRmLdoB?= =?utf-8?q?nGLF8MmPG37MPHWPbXPF8m/QkZxmwF6/Z3Udt+CfLT4zGRxXm7Ko4W6MfTq8osoP1?= =?utf-8?q?tosq2nDaIJF6qS9GjjwPlpBjezb3hhp7egYdljU5S0zfcrZaAP7DM2e+UbG1x2+Kl?= =?utf-8?q?kesV9FSNPtL0DlhS2r1D07idNNTcOiNs/hjPuSM4rM+1CrXcSjrehLA1Ae6pzALfv?= =?utf-8?q?0ImWG9vSC2bnoxZH0oCjvZNv3UAEK8vBLI89MSZyInIsAfJVgIMfagTAdi2iwGDRD?= =?utf-8?q?vr+XexCvYODGA9hMR80PGlpekF7FSY5xstGlqMrvxPT/sTWdv8MaexSoJx375oHPO?= =?utf-8?q?TyNR9i6nrWt5/Kt/vDEQWVOXsuUaeuH1cnEL75s87zsA8tPbID5FML58PUlBW5XV+?= =?utf-8?q?GcDKJfRWjDlE?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 752ceb67-d20d-4efc-4cee-08dd45805124 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2025 00:59:17.7282 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zL6WspjqJXPS6S8IFRWl7g5LKLR+YmIKSG/ACkxKGdgE4A9yANxSIhX0yGmJzJLXrRg6ocm2PQPxDADRJnNYwg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI2PR04MB10713 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250204_165920_636127_81B69E32 X-CRM114-Status: GOOD ( 11.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Peng Fan Use devm_pm_set_wake_irq and devm_device_init_wakeup to cleanup the error handling code and 'driver.remove()' hook. Signed-off-by: Peng Fan --- drivers/rtc/rtc-nxp-bbnsm.c | 29 +++++++++-------------------- 1 file changed, 9 insertions(+), 20 deletions(-) diff --git a/drivers/rtc/rtc-nxp-bbnsm.c b/drivers/rtc/rtc-nxp-bbnsm.c index fa3b0328c7a255ff8a902a58d61a4b0e59eac493..d4fc9dc583d317d4852b7d897a6c45cfff6961a2 100644 --- a/drivers/rtc/rtc-nxp-bbnsm.c +++ b/drivers/rtc/rtc-nxp-bbnsm.c @@ -189,36 +189,26 @@ static int bbnsm_rtc_probe(struct platform_device *pdev) /* clear all the pending events */ regmap_write(bbnsm->regmap, BBNSM_EVENTS, 0x7A); - device_init_wakeup(&pdev->dev, true); - dev_pm_set_wake_irq(&pdev->dev, bbnsm->irq); + ret = devm_device_init_wakeup(&pdev->dev); + if (ret) + dev_err(&pdev->dev, "failed to init wakeup, %d\n", ret); + + ret = devm_pm_set_wake_irq(&pdev->dev, bbnsm->irq); + if (ret) + dev_err(&pdev->dev, "failed to set wake irq, %d\n", ret); ret = devm_request_irq(&pdev->dev, bbnsm->irq, bbnsm_rtc_irq_handler, IRQF_SHARED, "rtc alarm", &pdev->dev); if (ret) { dev_err(&pdev->dev, "failed to request irq %d: %d\n", bbnsm->irq, ret); - goto err; + return ret; } bbnsm->rtc->ops = &bbnsm_rtc_ops; bbnsm->rtc->range_max = U32_MAX; - ret = devm_rtc_register_device(bbnsm->rtc); - if (ret) - goto err; - - return 0; - -err: - dev_pm_clear_wake_irq(&pdev->dev); - device_init_wakeup(&pdev->dev, false); - return ret; -} - -static void bbnsm_rtc_remove(struct platform_device *pdev) -{ - dev_pm_clear_wake_irq(&pdev->dev); - device_init_wakeup(&pdev->dev, false); + return devm_rtc_register_device(bbnsm->rtc); } static const struct of_device_id bbnsm_dt_ids[] = { @@ -233,7 +223,6 @@ static struct platform_driver bbnsm_rtc_driver = { .of_match_table = bbnsm_dt_ids, }, .probe = bbnsm_rtc_probe, - .remove = bbnsm_rtc_remove, }; module_platform_driver(bbnsm_rtc_driver); From patchwork Wed Feb 5 00:58:21 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13960295 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E83B9C02193 for ; Wed, 5 Feb 2025 01:04:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To: In-Reply-To:References:Message-Id:Content-Transfer-Encoding:Content-Type: Subject:Date:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YQmjc+FMqh0dI0wNgt8HMjgVvX1TWtUXJ1FCgaXAoBk=; b=zk2K5TNhvfsoukHYOwDMPii0Ne vYYT7005gP/+StVJ36iyrAWhl0ql32MyNxSjHPVw+VA7VkvdujqimNE/AfAT+aVSUU97FhzvaQ2vp D+E8JGbT0znGZHvOFMyx0Eadyc+OKF6ZgXbRvvET4YGtcDiGAfUmh8PFPLbJI3JKPBigaSQkl0X6H OqAOhfUEhOAi1M+EAwLXn6r2NFZBun0gJU3GoyfBQu1b93sOHmWupfcCZlsV70/VNzbnoCEsaxEcu tbsOhIK5/h6QDjqfUPMvRlsosoK8fMmPqrjU+SuwLSNqzyvfVXrQM16MWYdeC7y38WtxRLYCNryNd Gof3RQ/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tfTqP-00000001zFH-2Y2E; Wed, 05 Feb 2025 01:04:45 +0000 Received: from mail-francecentralazlp170130007.outbound.protection.outlook.com ([2a01:111:f403:c20a::7] helo=PA4PR04CU001.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tfTlE-00000001yMs-1DTL; Wed, 05 Feb 2025 00:59:25 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hF8jQHR1bHpGG7DBMWG4w3dibEjlI6xmYMtp9LizNLzqVEpVShVxsK/P7yi+jAMA+G1oEtckq4bUg6jsXubb7aB2UqT8LP6ghhRb9avIcyRrXuwa+myDF9Gj8PyD2LFPOFhT7ecdWodliU7C0BuKg0+r8duJEWKgtoHff+uz+HPtCwogkdY6QV5fHNKF+F9xRBN2am13k33Q1AIQKm7eT57pyigS0k8JSuZZnDcbwd98ehoQ4hnegB64IElKvtZFEJ66ezvJ2xC21au8t+1vFgfM9biMT6imqJTVXIHYEucRHzLQgbqtCre+whbfTDzfIPFkWu2EVDM7DPc11qVFSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YQmjc+FMqh0dI0wNgt8HMjgVvX1TWtUXJ1FCgaXAoBk=; b=WMdWd50jrOVMQcKddw2nlMF8w4S+GQBYMZ/TvtYCfmtBvRiwYhoCPChfxOWmOe1+V0gM/K6nJUxy0CM1+MYRq1VsWeM2Ya6E51qZC3a83MjrzdIYAIGeiYIfujs+eozcvAQ8nqLNNVEJZ1dElO2Ocei/aHl697psv6Chi38iRy9tBcySN0VIUI3i+hm4yQWUXKPzf9GNcpWrTNwgUGi0Q8wqznJsytrcNWmEB/jptOLeUePEoDZY64PMvUk12xCum6UIGVA1fZDBqGedr4p/ZkBgGwUqZLklfnzK7gary5BQ4CMp8yqKZbYbni1cBPC0Uk17ihWwDI9TjFmEAIkRsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YQmjc+FMqh0dI0wNgt8HMjgVvX1TWtUXJ1FCgaXAoBk=; b=jpP49Yi1f/uJKBF/HuCKyH1176JGLscSmnjV4HizVqOpDN3EYSVXdKRFhiOd347ukXPhRqPzRo4N48Udj3QDyXX2IfxTcpHcmBwU+qKfbeeD0OD4JQR1tUKUhTlMq/4JV1bp6foAm/TN1rQUpRZxznZvaEcN4/vpNY/uy0kSv1mtfQHV5m3c/X4J9Bv8G+iP7U0P1Gz8f6+xPLxrWTstKD7/UBTGpt1zV7U75HvO/FvplFj8mWIxsPOLnkF/ZFJjMK2uzbUOWwo6q4pB9Vmn7rIVI2TncRF2xfk5L9flIpL41JzP5zpGcNj/lYBlogLk9nG5ysSRzQT/FnCK+NFmjQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by VI2PR04MB10713.eurprd04.prod.outlook.com (2603:10a6:800:275::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.26; Wed, 5 Feb 2025 00:59:21 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%3]) with mapi id 15.20.8398.025; Wed, 5 Feb 2025 00:59:21 +0000 From: "Peng Fan (OSS)" Date: Wed, 05 Feb 2025 08:58:21 +0800 Subject: [PATCH 3/7] rtc: ds1343: Use devm_pm_set_wake_irq Message-Id: <20250205-rtc-cleanup-v1-3-66165678e089@nxp.com> References: <20250205-rtc-cleanup-v1-0-66165678e089@nxp.com> In-Reply-To: <20250205-rtc-cleanup-v1-0-66165678e089@nxp.com> To: Alexandre Belloni , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Conor Dooley , Daire McNamara Cc: linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1738717111; l=1119; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=yYeVC601Fmqm3h8IRsE1e0gqqkwuyZ6uKwkA4brZ+6s=; b=+jZfInCaWBrh1hOlNrO+2f2hgBbfBUBVT/+siBpwsFBqPZBBARXE+oQbSs2ZdbRSDvheP5xec 3EQXrX8A67WANLhoZl/HhnkDbpTNAaVHp4vwnuMDgWKmNZ+/5J+sQJ0 X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2P153CA0034.APCP153.PROD.OUTLOOK.COM (2603:1096:4:190::17) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|VI2PR04MB10713:EE_ X-MS-Office365-Filtering-Correlation-Id: 91fcd344-6bdf-4d9d-9292-08dd4580537a X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|52116014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?UVIhPBJte3pL0hK/RDj2J0G0PUiYE5x?= =?utf-8?q?UFUPGLjN5XFi8m8BI+ik0il9XwbUNALqO41K/SeAgWWgBWHGtK68gwOZ/Z6oWXAa6?= =?utf-8?q?N4hnJNgtxC/LS2wdM5AKazac0a1ojYtp1jhqkU+qSCm52WWQx5G4ReFvv63EUOjSK?= =?utf-8?q?t3uRfIPTASWvwbkylnVngQaATTV3l8vhVSC9pb6rawOeHyTOMmuTuAYmrKuz2nbS8?= =?utf-8?q?4x+A0UORojLpNCrE1zipDfyg2lKoIY5cLGp8NfvcFwtYa/BOnMh7UW0UBVgqW8gTL?= =?utf-8?q?wWp+9/X/kj/iTYN1ZpcNuV2zmFYoLH+T36sN+9zUeNgwGjCUd5THmmlrFJKsimx7D?= =?utf-8?q?t2dxhiivRMb/V5c+Isay4rLK9JQNe9snQRvn9JuTYYoupS/JhYn40poRd1l9Q0sYx?= =?utf-8?q?rliFgOnNAD79icJnGB1dwd7wVx97Tzi2d/lKi2hBDSY3q2Y0VIlny/8GYDqtxNOeC?= =?utf-8?q?fob/pUrntpGNbAc4jR7RSZhFLT24jIiJzD1ASJ9XFceoG5xO6HJiqvpXpJt+rz+jQ?= =?utf-8?q?+HdY1xln1Jd3CTGg3R3bnL4v6A87KE9r3S9nB3pmZ5USzAjCGIrpPpbZ7/kQQBjnC?= =?utf-8?q?vl0ys2T9oL89HydOZCPjnugckQnxT+aDRWRJ5Txoff8VCmV2YBvF0hnotH8rddQNv?= =?utf-8?q?TxTI1+g/bQnAz6VzGzhxVrxTmso24pU+vMnu/XtTrRxRF1JtBPUhNy1HutAInpzR5?= =?utf-8?q?+0Ydt1uZA5pC6nozHUZc5/hxTsljtvsdGY3A1iqdRotDxqlly0OMskT9SaQdE/hf3?= =?utf-8?q?iWozs5C1oXdW/Dn/BzoTLyALvq6Ym2C7UYbmuOnT1bkExg9uEld0YWbg5h/sQF8Fc?= =?utf-8?q?IIqqp/5QKZt/TMe/dVzoFBD5foFLDh3o+7F/SmVzgRD1WbBPggddhMx69w5j1bIUc?= =?utf-8?q?TaeDITaboLwYx4ExUlXOsmBzrK0zPWQL5ughs3J7rpwbUn+8ovtwcPmxc9xFd573v?= =?utf-8?q?S9UIeLqI2eqpzLcmt4gSd4H1i/irqFU3vU1vTZjLQqQCKpHlk6j4Rtce6uLgNn9Ex?= =?utf-8?q?7q1D6SMqXLwMHHy2RvBlLgnDINhk2CL9r0BbzMUlgyFoYxRQzH4RSFRQ1ClpiwlL4?= =?utf-8?q?OUeeUwGwN6dJnF9W81URy+gLgVk8eRwyBdvk4ppYTacSoBT7vuxzxIB/8xe329bN/?= =?utf-8?q?RYOZdz69t3X7YIIZQl/Z8jD8Kt/1UMc+Nvh3SHJUMlE4IgcwORqmNlZzeX7XsZW7+?= =?utf-8?q?8K/4Z116VzLNoLJgeQspd3woq8Uhh/rtea8yI6viNYPwHosIDJ2QVoUDv/1L3Qvxg?= =?utf-8?q?PkGMjffmq8PrHAfDabq6e0wwS8HPXe2xtW1TJwhzsxj5LzDVKshWZK67h1gkZOLl+?= =?utf-8?q?RPqqhZuAYZAmBB9vau9pPDOfFJ/n4ZfrFfqz39/z2KJqy/d5JVJWCMKJC9THhHtEP?= =?utf-8?q?n3vzLQBF/FE?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(52116014)(366016)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?1qxFidNJgDjg/n8jJfx+W6/87viX?= =?utf-8?q?EKSn+4gbnkAkdSLO+zg+oxUSRFzwVpF5HoNaOgpUXa5a0SwCayl5+RwNO4aLx7pgG?= =?utf-8?q?6gT/cLDqOc4iv0++4rLILweYvIko6+8q3p2qUvrcju/KsF8uV4AcFPUdYIpMboj0m?= =?utf-8?q?sCSXFzU6IU3P350UfoIUxCHsa8zPbBbxtveMdCn0i0I58TRmbDsxvOSlTVZRINYiE?= =?utf-8?q?/EzndxgjXoW4gzxN9UEt244yJg38KA8cfukgspmp+eYUCSOQIgpvJxmj/MmPSNg4i?= =?utf-8?q?qvjkqBDjytsNZL8a+9y0Gxz3jsvRYwWVh2DYAQvRogocc9ICRl5iLezwF5D11L1tm?= =?utf-8?q?I+mveVfpiocz2tcWZFz2Ql7rbCgFPhWQVI4grNgR/96MnVOxavJt/DnsZAiVbqTC6?= =?utf-8?q?mbwmnRvjo/FD5v8bmseI7b9PF6acBi34JLq+UVYielpruNgKDSQyw6qYusNvdoMDe?= =?utf-8?q?dHmARr9tWrWi1LjNMaTq8tkdZmNJgmEYgjApgRO88S3rW4HF6Zfl7HwK2/TmFXWAH?= =?utf-8?q?Ejj7ZXxEp58tv5iCDMH236yWYFWuEwhKTqDyGkSB4bXBk+0exK9bjRio4xwFE4Zmd?= =?utf-8?q?qOYxt2DZEQgqgqhQM7buYyM+2lWBViJkIaiIoelAjSw6MUi1yxXsvbSpZxLN9uu0P?= =?utf-8?q?ZlaZwb7Nbu/3WLQB0B9cPRtdXdKkGUVpNkHIrCkJa2Dnuvw7J/IEdQldSrDGQKt29?= =?utf-8?q?ESpqFs1dWCfaCe6PtuOWgkIrQgBtCHgKSI1fda7a554v99xQdKiqB7MnKw1xiMuVM?= =?utf-8?q?kTWOZNMMJCRYE3X2sWEBBFzNKe16ZytPopNjOPlwdn8NY3EnnM0/AQuCp5VRTfvOW?= =?utf-8?q?gC6Rdj8Owlz/7zXJ/Hd4FB+wp2QaTC0F/0fcexnaZKI4e3c9vDydUMAGVCdi3Pg0r?= =?utf-8?q?CrnDKNKATIQZj6zFBOttFys8xxG1sb0T1DI2eT4hVfj0i8GYH++w2vplrl7UmDdIz?= =?utf-8?q?VHT3KSdz5qmOA/FATrqVrGQ4NShWMfUI2gsq8ZO/r2ENbS7CoLEH+KlQb0o3Sp9GY?= =?utf-8?q?tnpk43p5OivCsFpSvjICnkqTV8ApRZG/DKUs8Fl1vCVPY7QOMVgzmVrKYmmTm7XVV?= =?utf-8?q?b+HFtriaXUSaVjnbRf8OpjAI58xn2dDom4CtGdtWIhfLyYUeMHNva0GoOXvGW1zOp?= =?utf-8?q?OJcu1zpMvm4nI4/TZFveiuFlwlMaKzT9gbXvKHPZuFCfObYNDpmgjNnD941l30t4R?= =?utf-8?q?eyDWe6fMHIBuMICbz0uI5/f8OntuUCtkwWu6rcL9HjUT9/u/p7nwTAPQMfLOHtXtN?= =?utf-8?q?DrmwzQTIH9cAF0XkNxsK1P4o7KDWajlX03BoiFbkCEIys36SuGx50HJ+ShmyAkApH?= =?utf-8?q?z2OKRCvEmmHesc4uHI0k5AOGhbSNlNmHJpeEOQdCG7SYmOPBGSQ2GPd5M9fUGuFJR?= =?utf-8?q?ysN+1XWIaxAEZ0sWYb3M4BBX1WkmSEtcbNKEXcOMgfcA7nutF4FCRAZM3+ywu7BlO?= =?utf-8?q?TssErwkMVZbDlMI++o2sne6LLPWDhPdu1XcvOBcmZQhTFDyq1iD+mtnIHzzSumwxQ?= =?utf-8?q?01Fjf8o8xctj?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 91fcd344-6bdf-4d9d-9292-08dd4580537a X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2025 00:59:21.6295 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TPliWJlOGwUsNudt58OJ3wpS0t9EwlWYAW3C9ombczuPWBe+NO0MXOqpoeeWMO6eSjaJO0D/+jY1Ac3M27AgVw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI2PR04MB10713 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250204_165924_341904_434A796D X-CRM114-Status: UNSURE ( 8.42 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Peng Fan Use devm_pm_set_wake_irq, then the 'driver.remove()' could be cleaned up. Signed-off-by: Peng Fan --- drivers/rtc/rtc-ds1343.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/rtc/rtc-ds1343.c b/drivers/rtc/rtc-ds1343.c index ed5a6ba89a3eeb2a0b9d6dea3c8b3d40aa2cf317..aa9500791b7e0300b150bd654b69c74f3e5e6e6b 100644 --- a/drivers/rtc/rtc-ds1343.c +++ b/drivers/rtc/rtc-ds1343.c @@ -427,18 +427,13 @@ static int ds1343_probe(struct spi_device *spi) "unable to request irq for rtc ds1343\n"); } else { device_init_wakeup(&spi->dev, true); - dev_pm_set_wake_irq(&spi->dev, spi->irq); + devm_pm_set_wake_irq(&spi->dev, spi->irq); } } return 0; } -static void ds1343_remove(struct spi_device *spi) -{ - dev_pm_clear_wake_irq(&spi->dev); -} - #ifdef CONFIG_PM_SLEEP static int ds1343_suspend(struct device *dev) @@ -471,7 +466,6 @@ static struct spi_driver ds1343_driver = { .pm = &ds1343_pm, }, .probe = ds1343_probe, - .remove = ds1343_remove, .id_table = ds1343_id, }; From patchwork Wed Feb 5 00:58:22 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13960296 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1EAD3C02193 for ; Wed, 5 Feb 2025 01:06:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To: In-Reply-To:References:Message-Id:Content-Transfer-Encoding:Content-Type: Subject:Date:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0ck/KyDLZ0Hdp7ue3uxbCp/8Bgg/pRY0hm93UPm01SY=; b=Epsql3yyhUOahmF/dniwFkRqLh CKmlK4Rkuye0AM1uciA8lBlIJOrP+AjEoPFqTGIdnxUELo3h+Rwq9pSSJR6Xj4hyhzPF3QmBFWIx9 37CcfuVVxmcfutyn+JcI7udh3bD4j4g1DnRZxVR90bSGXK+olu1RCH512eJkmB47xRrkvuxSTZfow /IwMMvZKU//EyGWMNI0slSUrMyjGr8HZp06splWrqnHxVcIr1POWRjv+284WxUL4lBED82NxizNa+ JS8ZhLzNRNERjstLEun3R0HK0u70nG5U2dFNyYEoFO6pwUgG5o4BXvZiF8zfeW60HBXCuXZwIlttR i6FfwOYQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tfTrj-00000001zWM-03oX; Wed, 05 Feb 2025 01:06:07 +0000 Received: from mail-norwayeastazlp170130007.outbound.protection.outlook.com ([2a01:111:f403:c20f::7] helo=OSPPR02CU001.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tfTlT-00000001yPa-2Ltp; Wed, 05 Feb 2025 00:59:40 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KuJ5UUIAo9d9+jYxjdXgOrcgHjlSWYNpIdz566YTDSQEtqIvPK5XXyqNIn6DztO4Ri3rdXQ9tBc+Nvt+udk2AchoQE/fd5mpog4jOlBH3NTRYl8hMJOCNefX2SO1Tx1jb3HshxZnft5DZzz5Xi/ELW9pbcmNYoRceMOMSAEZAKO4wMb8AWnLS1ZpRycEj4dgR7P2uuqvlR30f7dv5JW/duj1wPWMPzjKBI4Fphcd8gGT8XjQEKCL6rxmcw0a16tVpi2gzDJ4IOF9eVTSDfX818dGff9ElMkWqSVxb+wOG3idzSHvZS8QJBIdYAtokJbAYmAgnEaskWrFT80Fy6I/cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0ck/KyDLZ0Hdp7ue3uxbCp/8Bgg/pRY0hm93UPm01SY=; b=LG0nCpKnuu9PAogxFN2sajN9+JPaB5M6qRYwZhc47ollARBOam8LfJ6uCexkftir4TMFRheBed27KqYYuaHbJuJXje1TwV7Oc+0+OnWkWCZD248ghcwCT8l1Fs49fhaVNli98zlBN7BGnx1aYxLSahK6Nh93qehsH39YC5591eoWqSTbdo1Q6zB+N+lTXz9lBj9R1VQ4GT3bcXsvLRWghBtGdUjtvc2kBps0HOxflj35TZsv4FLg7+iY1Zpg28d7QZAgPnqk7h3oXWcHJgi5AQ/pmTRrxggNtxbn86JBugO237q5ikACFLfqmNbks7fuGp2XTDYsorw0VsWyv29aeQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0ck/KyDLZ0Hdp7ue3uxbCp/8Bgg/pRY0hm93UPm01SY=; b=CfX5SlQyCVmrqBHhShACJI/gw8vkwEFvqMlWlxPis+c+eqTxomSCD0FlNpCV6RXg6HykimPu9sOiorbmy9n/oO86Xjq+tlMzzDzOwLWLcjR8CtPGHReJKPI34B1oFbSLhk3R08qnUcvrH5djsjTxB6G/lRajAvt2ZB2ortv38dTsan5X5MKUtYseFViTi9XDYZ2N6z2N9P7NhvBuAo+aVoIEtGodAZvnpfwoH/GUR6ZUbI6UqWSnCD7bZLLLpf2BUMK+017pVJEIcX7cvVC/78CE1KlWihgkiJiWPfLvTVhHSV0qEqnVwtMTkfbEzJHRIrZFBk1iCR5TTbphHp4Tqw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by VI2PR04MB10713.eurprd04.prod.outlook.com (2603:10a6:800:275::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.26; Wed, 5 Feb 2025 00:59:25 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%3]) with mapi id 15.20.8398.025; Wed, 5 Feb 2025 00:59:25 +0000 From: "Peng Fan (OSS)" Date: Wed, 05 Feb 2025 08:58:22 +0800 Subject: [PATCH 4/7] rtc: pm8xxx: Use devm_pm_set_wake_irq Message-Id: <20250205-rtc-cleanup-v1-4-66165678e089@nxp.com> References: <20250205-rtc-cleanup-v1-0-66165678e089@nxp.com> In-Reply-To: <20250205-rtc-cleanup-v1-0-66165678e089@nxp.com> To: Alexandre Belloni , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Conor Dooley , Daire McNamara Cc: linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1738717111; l=1104; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=bSEqkb62Ag5Dw5Zs7cv9/9hd9K53rCnxW5QPy69d5F4=; b=L42mVUKdk2pIlYxrwXtM9UoydiBfMxcoLJG/qK507hD+NAO+hlBnrqcre2UHyB7TyVQhpASlf v1197RGA8YYDYNV5dTDNFTz5VDBwM/ZBvnjvFAQM2Y3RLB/Imv8CwYL X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2P153CA0034.APCP153.PROD.OUTLOOK.COM (2603:1096:4:190::17) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|VI2PR04MB10713:EE_ X-MS-Office365-Filtering-Correlation-Id: 249bf700-da62-40a3-2051-08dd458055c5 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|52116014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?JaRSDBR+XJFamV1lQpnJSOX9f30FwAN?= =?utf-8?q?vgPWWjyYg/uSwZXdAelYOWegpkCKdg3llnQPLdZWAYxj/rRetrAGvUG3l2tI9pwkf?= =?utf-8?q?coSA09T3HK1yDD+u3nAp58EZoY29xJv81Z33/vn7dgA5Z2gZ+uH3Fs75SNM3q5tmo?= =?utf-8?q?dC721h6Wrziw3D9ptujZjYRGLgVa/xXRI9RvgxhXhKCi1w9DJlC+++KWzhYwJhG4T?= =?utf-8?q?imjpTDJJUSZaDCFD/oytSBvLPqLg9eHnvPRKJ/BM8dLwKisFFPsa42NntoqVdXB4F?= =?utf-8?q?2qEW0jCt2pAF61rqwKNxm+gnj4fQyRCj3izhc3UyXVrDCoUkgIIsSwXX8PPGztmvU?= =?utf-8?q?BXFrOLtg/Thud/8hT+CNaNYulZ0r5lDQyT9EA9M3qpN02/xeeTWOBZoZ875pURkuW?= =?utf-8?q?eF/G90OM0KRXLhW7rxQTIBuhF8oeb5AZPWB8mGd+LJ7pe4NYg1scZnQEnefN46zBi?= =?utf-8?q?pnuLcA4Kf0JFVboRAQjV+TaV5swYEIujp0JGYunFO9B7qveLywV+W3P4eQ0nZfRoN?= =?utf-8?q?wJe0jMxAzJyPBAa+/2csyGvGFd00wEJdSPQQuZdSmUtCLqE4EvHNAm7q534NxT+mp?= =?utf-8?q?0x1wVQX9OvwJI2Gp5zzsAN+j0IEpFprzNMPxwGy6Gw4VxsmEyUe3yarrsz+ev538P?= =?utf-8?q?pbF+jD7Nv8rcNf4oeb0GNBW8QSPemLTL7AoINSPyONqArg015/2ZPHp5RbIlHE77e?= =?utf-8?q?qdszpjSiltlyhwfFzcN4pIoOBFLFylyZ9hcy2ZWkHdUCpmT4AJjUK0cB23YqEeMae?= =?utf-8?q?WBMjEMR85zZiQjEBJcE1FSXGJW5EJyQzWPvDkb48ia0J4gOhOxUy/dGOybwbRW/8+?= =?utf-8?q?AxAhpq8OuXurxM+8uKNKXWpV/v2z3+OeZsjmXdN7OiwhgjyAVbm4uPtF0weolANlV?= =?utf-8?q?LnQCid0Is/64F4GoQQMaAXs2ZK8BLIvreOAijRVIKGULf9N1PkPkNRNW8/wmLJYc2?= =?utf-8?q?gL7fDrCDKj2eS93RJjTjVdjGzN89UuzXR5XUK3m82BnGeFR+8nurLEt3wUmNLW1Tl?= =?utf-8?q?AKgYIwV5Dmggt5nvzlO2XIPiE0S87PWy5gaNNM9G17bVliOWcI8kxmis4HDe6bRBZ?= =?utf-8?q?AWaC5doPh2ugTq5gREj8EqjX4itfCvb3GFIESgayX6Ag/QYAvwfBjPZodSGOj6Fol?= =?utf-8?q?VH9JL/tYYKnpF4E012VQIO9bHjmvTEpcMlauXTNPHQYeFpIOaGKgQ5q9uKYHM2Cmi?= =?utf-8?q?pX8jz7QyaZtJ3Budq9xQHfiSyf4H6HcYLtqhZnkej2FJ8bIBQf6h1MlWzrkV4wBnQ?= =?utf-8?q?j3T1TTnvQ3GA/eUA1SCnDnakDiS9T+em1hUCw7lO2RGeRq4PFqLIC9ArcgqpwujDK?= =?utf-8?q?PooB5z/qS9hAHpOpiEm75J6B+uQDFLSztNBxGWl7Q0WLF5VP8gU/oE+9l94uWiHOq?= =?utf-8?q?FASozbW0YbJ?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(52116014)(366016)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?k1TNRmK/75bgNMe+0ciKxwH7YA/s?= =?utf-8?q?Hl7V6Ye378vV3RuqZAqQ11YrfiHY6HkGZN9XxNq8h/7ZXJQETHAAT4+jt+Q7fs3hx?= =?utf-8?q?yqWMwocbyFn2koO4XOUOitChgyNNTgCPVeZ6bsMA+neQ6bcUSigJTItsvcTb35EFf?= =?utf-8?q?NTez80T7BmOZy5joGlLtLVqYQdn8k1hgmF7uotU0YLg4A8IYWZ0ryTmmBbzz71JdN?= =?utf-8?q?Pvhh/J/TAUQPDw4LXV0iIrRhNcZRdoHwvI1h2z/289LbUggUyqa8WgaxAY1GqRN6e?= =?utf-8?q?CcTN+KW/DSHhMGLLRwY9PtF43y1JaBjFlDm7eHQlHvwXCxCS5NSlWhpFKJ4MYVq0d?= =?utf-8?q?FeXdpYL0rzJfJ13pOvAD0zMzBqI9AlRUkMYb6aMAr/9wj5LCh2CienS+dXJq6pL/D?= =?utf-8?q?ivN8Q0V7VpTE+FjjGNUhJI0XEm6LmKhEPn7sCV2dDB+oACVOzUf64xSTKofXIPKJt?= =?utf-8?q?+VwYTBtJvYc9cZ8iBLrW5xmUsffioCV7Sae1bAZZohXacTEgv+17eizeVqVweeZ8g?= =?utf-8?q?TxYs1jucMKIbxkbukrUnjloOiyodncRXVm2s3BZgrOxoGrIm8O9U+3de3nsjHjA3s?= =?utf-8?q?/ev6ajI7bTl9YepRaxnDHTy8K3SnoHwG2/ulfKcKKRU+q1b4B+zzM8xImGCviMEwx?= =?utf-8?q?/JCtuA/QujMY/lW5ssRt65H1nVxu1GhAnpl/PbtrYUPbmjilJ1AwmHTEaiutaWqRn?= =?utf-8?q?LDYShpSg4rn0tmvAhMDLbcmH7TyjDc+/bq+govdztd5XfTGwt/ac5isKZ60gcvIiS?= =?utf-8?q?fxcDFFn88yZ21uYRfLNeKVQLl1gMx2IROqr1hS13aTSF41N7SPbGczANscc/PJgse?= =?utf-8?q?Ipj+8JNGjkZMynwIWJN1Dk/N7aZejmRS0LmGh1l5nnJCowy78nqGmY5/FtOesuRgo?= =?utf-8?q?O4Jh/n5ct34MPShNIr/LslafSvyBurzo+zOZpuDooWckyV861cairk0rlWtsJnVG5?= =?utf-8?q?pKHFFZFROzP3rR4A0ZBffLgyXrc0sYLPwSrwWOtpEHeWO3ZG2WvKac7RboecToHPw?= =?utf-8?q?CEbT5cMA2sfcKonXUcb8rCOeXQ+wCIuTP0CAqKPv3jk84AqyZyIfOcPnZTpEIkSe2?= =?utf-8?q?265w0fJxP6dhBZxRDwH02qmpKAYGhF9o0pC/ocMFLyCOvM+eR3jb6x3gZLiShAAQg?= =?utf-8?q?kVuxMS+RkWlTltJp9QqnSVGP53dgpFWlAP4xpGFKoro4H8LmcPPXTG4BUWJOyBrzZ?= =?utf-8?q?rnwYniTjT+0+3CXjhStj1Lcd0tuNGDbMKkPy84x0aa9EgZWH07SIR/hvREeJe0v2k?= =?utf-8?q?962K95WS6jxRhzVn25URfrqBKGFlhcVO9xveowAGCegbsmv7uwwHphdpbfIXUhbfT?= =?utf-8?q?CCqa8Ku34tTkyAnsM+la2wTzPOkX8pgGHubs2Toq0flousudF6o84DjS9w+WCjnWI?= =?utf-8?q?iNDRGESkwyrN3geE/qjXLKCDIl3zexme+n7ZcHowl7A1zKzbqbkLik3Hvsgkths8t?= =?utf-8?q?H5eZRB7ZsY5hPSFEBj+JudTsTNmHlmcvbRRJLPD2uPlvU6ctyvWMCod8PLPIEvrs7?= =?utf-8?q?J38ZoKJOOf0v?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 249bf700-da62-40a3-2051-08dd458055c5 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2025 00:59:25.5034 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vhxnzHxEVq9spQJvNG2Oo/QkLYeSZzav4wympD+45yAGhqp9UA0cze5+E7h2XnnIFafMUUT+VLc3sSxVdQBIVw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI2PR04MB10713 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250204_165939_605495_B768C46E X-CRM114-Status: GOOD ( 10.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Peng Fan Use devm_pm_set_wake_irq, then the 'driver.remove()' could be cleaned up. Reviewed-by: Linus Walleij Signed-off-by: Peng Fan --- drivers/rtc/rtc-pm8xxx.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/rtc/rtc-pm8xxx.c b/drivers/rtc/rtc-pm8xxx.c index b2518aea4218f36ba24a5fb660ed11c1dd78940b..852d80188bd0b5e75882c7945f166162fb039507 100644 --- a/drivers/rtc/rtc-pm8xxx.c +++ b/drivers/rtc/rtc-pm8xxx.c @@ -523,21 +523,11 @@ static int pm8xxx_rtc_probe(struct platform_device *pdev) if (rc) return rc; - rc = dev_pm_set_wake_irq(&pdev->dev, rtc_dd->alarm_irq); - if (rc) - return rc; - - return 0; -} - -static void pm8xxx_remove(struct platform_device *pdev) -{ - dev_pm_clear_wake_irq(&pdev->dev); + return devm_pm_set_wake_irq(&pdev->dev, rtc_dd->alarm_irq); } static struct platform_driver pm8xxx_rtc_driver = { .probe = pm8xxx_rtc_probe, - .remove = pm8xxx_remove, .driver = { .name = "rtc-pm8xxx", .of_match_table = pm8xxx_id_table, From patchwork Wed Feb 5 00:58:23 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13960297 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 92C9BC02193 for ; Wed, 5 Feb 2025 01:07:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To: In-Reply-To:References:Message-Id:Content-Transfer-Encoding:Content-Type: Subject:Date:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XjUzsRVsWfUKGqcMfcInIdzIFU4EDALwy1w62++QsnY=; b=3MajG7NqFqkLJ16xEaj3CrnfG0 Njc6JCqEVUywrhNySF26aauM76K2rhRZVa8Hm5oHt08P0FS+vZjFiWdgs+GgaRrX58HMua4URiohx nxZtBeKOnR1hLbZaM24PzpJnaxW9F5Z365h/VjR+LZi4M1hrp8C8QoBmbPvp67aZ99B4iFeiTqpiM nQFQjl5LIPe1wfRL4y4VCJre5pXHeC2EJUQ7pOVUWtmHnIQKh831YL2tPzQn/CTgh/rNAhrj4WZd0 HFxZw83T/okuPGcm60zHxyUfpNeTH6HtkKR2FqCqYI0/KQbu3Qj6vdrbAlMcAeoePStufN4y7MOYn SMZ5FrbQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tfTt2-00000001zfg-0rvo; Wed, 05 Feb 2025 01:07:28 +0000 Received: from mail-norwayeastazlp170130007.outbound.protection.outlook.com ([2a01:111:f403:c20f::7] helo=OSPPR02CU001.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tfTlV-00000001yPa-0FsV; Wed, 05 Feb 2025 00:59:42 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=cOrk6y517S4CC9KoI4JZc9PwIm2gfEnY3RUeF8R0QS/B3uNB+2ikdLE5PoU9V5v96R8YfsFSV1PGQXR2/mvCjVopadpp/G6GkSsWlIfEHGP9gNeuIbwLJ4+oKi+Mdjtt1ZeY2h2wog8pmKBAxVi5ecAxjVJtNCEQbyjJdDzC4R+f1nj+AgQbGdc1V/5aZbo8dJMMwaZP25oE01IambeDQWeGwnyk0u/Bql+wCzfookFGlG3tmWETzVn/Wplf0iOlkgoDwj5XrT6k0k7id9xLL9P7gyt4mYf6Mfczf/KLm5izvixsqbQk1W2P9UerDSzjzg8BF8+urf/G7A90kEoJ2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XjUzsRVsWfUKGqcMfcInIdzIFU4EDALwy1w62++QsnY=; b=zCZlSoKSkEdKsdNMNDQnjgWHaeei49zm2FYwY9dbtq90TqBqUUZaqvMFOpYJ1nNea1J2xHnYb8LCaHfkbsoit4fFOEMnYFC1SXQGPh0G14EG2sF+aVRpTH0x+uszEGnTLqm4SyXlR9TCpKhaoy9xTWIEfjvJgSMwgmf6IB/4WLPN1lifBh5rz+tb9F+pZczM6uW+AOfnTdOobTMN9IYiX2qBukRGdB1MAN9X/ZhK5Kk49KyQsijCEg1WDaVJd9JMIFM2lE2w0UkJb8xyfnLgWOPRDhyvYCz1SqMJJqcql9QHQwoMk5BR6dLhEbOb2fJ78ucDZ2gW9VQw/t62EXA9MQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XjUzsRVsWfUKGqcMfcInIdzIFU4EDALwy1w62++QsnY=; b=Z+fSu+gteDrotGKIgbOYNg+AygmbSlPGExKbLnBL8AEMimU2Mr2Z1E/B489yrs+7luKPrQF4nkDZRfV+R0AHK1k8k4ea3x6vVk+97pcZTwPODS37bcYLIrMtHrVueMn652LRrUN1gwpzmVAT8E/5epc6sKI6i255W3ad5nNvDgANEAHMD1hOQDtXjhOGzcDJXwC93ZhPMWPlxAJ72XtEOCYKz9o4G5H+dBVFoEuqEgrurdHYY2D35caL1DbDy6OIDdEQSaxZRbHJ/46LdZuWJRj+vIhFrkHrp0WIdgnCPIgOItHLyRuBTI9HAUMQEO0dsREhcAne1z1cyuSgeV/QdQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by VI2PR04MB10713.eurprd04.prod.outlook.com (2603:10a6:800:275::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.26; Wed, 5 Feb 2025 00:59:29 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%3]) with mapi id 15.20.8398.025; Wed, 5 Feb 2025 00:59:29 +0000 From: "Peng Fan (OSS)" Date: Wed, 05 Feb 2025 08:58:23 +0800 Subject: [PATCH 5/7] rtc: ab8500: Use resource managed API to simplify code Message-Id: <20250205-rtc-cleanup-v1-5-66165678e089@nxp.com> References: <20250205-rtc-cleanup-v1-0-66165678e089@nxp.com> In-Reply-To: <20250205-rtc-cleanup-v1-0-66165678e089@nxp.com> To: Alexandre Belloni , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Conor Dooley , Daire McNamara Cc: linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1738717111; l=1597; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=rISyYCuz8yJRuvtcynWqye8n/ybIJ7leHy6yEB7pHHU=; b=Tgu5l+wBrHYt6ouquPi1I0clsMFqBW3OGNogy3BMBCDUGJA8GxSwZLPzDzPbhZWJMga4JUl/G w8z4LMcp+qeD/T/P5cfUUm//g/NyGjV8k68wi/yTv036RlarYvDkDKZ X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2P153CA0034.APCP153.PROD.OUTLOOK.COM (2603:1096:4:190::17) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|VI2PR04MB10713:EE_ X-MS-Office365-Filtering-Correlation-Id: d2c1cd7c-e9b2-4692-3dc2-08dd45805810 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|52116014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?EWmcGEuB+mtwi9KDwpqmHdw1wcitGOU?= =?utf-8?q?d0PUzMrQDAY1eMrZOFNkH9yRP5LVnb3WweVfBwhyyUrNsWVkNOQlc0HiEHcIKcN+j?= =?utf-8?q?vFbH1rGWNVugWtxqB5Q76HEMXSTnWTHEUmtqiTLnoj+RGMW3JkTw9m4/B0kNmkt48?= =?utf-8?q?ihC6C07Zx4qr6qVEGaCQswieUKUl9t8d6BceKcUBFRWH88dCPJWqHBcQY2VA5rOuw?= =?utf-8?q?l/9Pm9t3NjcolSLFPN5sTDT2n1rMqSrU7XhHqT0yCwdZnp3JWIuMTKPQGWBZU+L9o?= =?utf-8?q?xqgM0/fDzm/7Sd9eysM3FhJHTU3AYRVkkw1vyxbgHdlnx86FPVIoaaQMtFZjMxK3X?= =?utf-8?q?84wRZSPiq2yIocqixmlWDwXrnEF++SjrCZR3E0vfdP/bJUpgno1rSQrOUbnY/GpfG?= =?utf-8?q?clfTAZDmsRu41jY6vbAdJfu1qK1ImoZzCPu0qt6xnffhF2tjR9IEb0Jrm59AGxTw9?= =?utf-8?q?5wvsEVPQKBbyc8JgwuJjbETeS1dJ/PiggkJN1BkcmWhfnRcOojpG8R/aZ7jsbw7md?= =?utf-8?q?ATDwyh2QnN4w7UZMsrVmyH9OS/mEEBLvRwYHQ3Reva58zv1JtMx1uyAFFABSWXeYI?= =?utf-8?q?pwPqq7/W1hYiYxLqVl2ubDsUJUrJdYa5ez4gDxmjQ8m8g6JkwsdRaXYdtrdr7+u6P?= =?utf-8?q?2cwWSWdaFqnApXt0sXl/NsmjzEu+7V5QWvIdg1HvPcdyi6BklzSlQjJxFhRXEDeHc?= =?utf-8?q?jgoW530jwvxvMXQmhWPjMQvxNa9zgrDPyA5rUWtDlPjzHAO0E5mok4WkE5IXO38So?= =?utf-8?q?TDWKU8f5CsJdShfCZQhLh4JKRPLBxyaKJTzT9wW8n2fcw/QDM0JBs8x3yZLXKmDoM?= =?utf-8?q?TAlk7w0xRRtCNuMs04xUFBaBHNpRSQROJrezd3NSRNDiPfizhnQChGNllwabDJoSq?= =?utf-8?q?rQXAi6AzrULKez2VGB8+dN2ckZq03A/CEruPXM/U7ZYzGolXMUiVGQ6D5Z0vaQRDX?= =?utf-8?q?TITWw6pC875SyEidrGhOwJNu90h9nV+i/zKXlgdSd9y2Q1ZodWDdZnXxsD1531cUY?= =?utf-8?q?LWS5A/GLOAU30ftpMj73sha+JTxo8Anel95xSr0tdRAAzGpbomSl8/3WerdT5q3Vd?= =?utf-8?q?2H0AVQvOT3kQtoQUQQkvJusE6EtlYBv2UwRaly6Za0ntS3FlwRsWVAe83ac4B6g+K?= =?utf-8?q?GotW70jHjGeFjJrlNtCZKJ4ypYV3GPsCQ0z9dZdxUpqQKeeM/o27YFoIVjsBdU/Gs?= =?utf-8?q?Bz+XVUjZxFfWkHXzf7v+RzcTC8K3hpAxVkV1DnauumTu9qshRKrYDbiMjv03RYwY4?= =?utf-8?q?AxZ6qQsOpq+37bLXBZpwrVw7I8WrX6jyI/Nz1lBhlofaywYYziIMMPQiJX/ZKej93?= =?utf-8?q?ozq9VP6u8Zyap7Vu+iqhobvwQ7ANCJkiZMSiGSLAA3wFa+moCjntPTbMynp7R4nIU?= =?utf-8?q?LiyVeewMTUO?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(52116014)(366016)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?RauEDU+jHwXNgPaCN46I72XM7qKp?= =?utf-8?q?KFuaGOd8w+bj1MVSghtT1zydARFpkgdljvA2zijCUU48PIUsrtM7WSYYdZsi0kMLW?= =?utf-8?q?NHzWPACmLOexaqtg01AA5kO5SS2WsmSZfClrR+ULiriVsXxVPV+rC7HYlxjaEbORq?= =?utf-8?q?XWQhfKN3m6vymtA+ntshDLFW9U5mHknos/eDpshcPhh7IQPzRVO19xYzv3iEyh0Gh?= =?utf-8?q?ryUeTXzcKSaMzs+LVqOJvBl0a1JXagmEtXVsgdF44EHbmhQLRi+Pdtc+amVolY3Af?= =?utf-8?q?IHid7JailYELAQSIqbY9gPGfDwc26eQ1iOaR5Z9dibVhpxXvqVjru0QbxMSk5HHiV?= =?utf-8?q?RoJvc1WAa83MjZCFDHeNAIF+c3SQKgFyFGWZceLNqsTIP5and1wTzeozjckj14tjt?= =?utf-8?q?YUPKKQ2txKE27Krvs8pFhBm0hkU1nk0FHdFGJNk/FxYnkEqr07kaem3wYciio6p54?= =?utf-8?q?jgBLbwejCg8jL3WnGUSzq450KEkN70AmneK1KOmH9Tm97jx6YqsX5tEupan0xRTuF?= =?utf-8?q?LTskQNC7rHiGN2Royi9AeBVzmZ0tB+/BK5Q0GXaFuD4p7kiXZnVC4zL4kkRSXGloB?= =?utf-8?q?UHhgxk7TDd5/rTXJSf4rf7fERrNwDfdtRhIzHKhVa6vf8pB2751Wc/Pk/sLHhXZqH?= =?utf-8?q?HJd2udc5cGABpyyQ0YJcaViD/wfdfPlHnSx9fnYhPWK2w1/J/gzwUg7e0n9WGYXwx?= =?utf-8?q?G/K58wmka9/U2mwbDoNvhaQbsotSyiY3fIAbEQKf5EXhUXugH5PQbMeK6ZIz9ML5X?= =?utf-8?q?VaVqh/TKTxZGfHUt5gAF4RAvC2pBBJzIdmV+wk2FoTo3q6yTOlaK9ckNJTPuYkBzM?= =?utf-8?q?cYzCh+mPukGTogWXzc0O6hOrlKSG51epEmfmFWbdatgQ3kjCeqOOHr4lO9zmpFyCO?= =?utf-8?q?DY2g+tZ2jDOK+Cld6Yk38KUvTCvXu7CQ3seUkEZiCTiCvl1LT5WUUEKOxSXMVZa2f?= =?utf-8?q?fzalyMAPBajNhS1XcEqcALMU3bnrQkTSYKDsW3D3+Dcn7JMCUjM6rztd/ilc/x0hL?= =?utf-8?q?geJbHD4P6u3puQUSl1WsAKtg4MIrrPAKTugwHfWuQsXWMahoEpqnf7szwPaZz3wz8?= =?utf-8?q?B8Z1oMChGmm2aGF00e8MLlliIL5mUKEJLbDj3J5RsFMBJnsm2V4OzBlCiYQ7AR88/?= =?utf-8?q?jsfU/87ZhQeDP3OurK1+MU1FQbHRyHwo8uWM2VN+ogPsCdPaPeLOp1EXq9o6cryAU?= =?utf-8?q?URdd7tgriKAKT6lxcSFkII89zBWaV8TtnsKgZxuQNm6DwNsMXx1fTaHiC8rUjRzFG?= =?utf-8?q?N/Lv9VUC3F0ka2YbA8EplijqKXRDLoibkLYThWOItu42ofUH3vy8Ky26PzUePALk7?= =?utf-8?q?hlbHfw6SJ/Q02hnCIqkGAFi6LlzDTYK1y8/Iiz9veRceRvdTe2S3yPRj18RgU2oUW?= =?utf-8?q?xaqnWD5ctkLpOJWizbGkrU0BaInxpVMVeM/Nf9WGGodCB64T2lf81HHgsJo5XVO83?= =?utf-8?q?9FfC0aJj3zW1yPQXfzYy18yA6072uUIsxbQ6YbPU+ZKQVBjKC24u6LJ1IoPO/Ha9J?= =?utf-8?q?PgJTFnjmlKgJ?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: d2c1cd7c-e9b2-4692-3dc2-08dd45805810 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2025 00:59:29.3212 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ISb8CdZQG3+/X2XsvLujU+5uDymRp+r42Uxb7J9IFZzBYyNuZz1fXnjpdD/+X0uacbVNqMUq5NZGESYQukUPqA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI2PR04MB10713 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250204_165941_125178_AE985DFC X-CRM114-Status: GOOD ( 10.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Peng Fan Use devm_pm_set_wake_irq and devm_device_init_wakeup to cleanup the error handling code and 'driver.remove()' hook. Reviewed-by: Linus Walleij Signed-off-by: Peng Fan --- drivers/rtc/rtc-ab8500.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/rtc/rtc-ab8500.c b/drivers/rtc/rtc-ab8500.c index 2dcda96f4a8ef727514c751322b84d8d2b382b75..ed2b6b8bb3bf8f99fef9f8bee9676f71f8a86d2a 100644 --- a/drivers/rtc/rtc-ab8500.c +++ b/drivers/rtc/rtc-ab8500.c @@ -361,7 +361,7 @@ static int ab8500_rtc_probe(struct platform_device *pdev) return -ENODEV; } - device_init_wakeup(&pdev->dev, true); + devm_device_init_wakeup(&pdev->dev); rtc = devm_rtc_allocate_device(&pdev->dev); if (IS_ERR(rtc)) @@ -375,7 +375,7 @@ static int ab8500_rtc_probe(struct platform_device *pdev) if (err < 0) return err; - dev_pm_set_wake_irq(&pdev->dev, irq); + devm_pm_set_wake_irq(&pdev->dev, irq); platform_set_drvdata(pdev, rtc); set_bit(RTC_FEATURE_ALARM_RES_MINUTE, rtc->features); @@ -392,18 +392,11 @@ static int ab8500_rtc_probe(struct platform_device *pdev) return devm_rtc_register_device(rtc); } -static void ab8500_rtc_remove(struct platform_device *pdev) -{ - dev_pm_clear_wake_irq(&pdev->dev); - device_init_wakeup(&pdev->dev, false); -} - static struct platform_driver ab8500_rtc_driver = { .driver = { .name = "ab8500-rtc", }, .probe = ab8500_rtc_probe, - .remove = ab8500_rtc_remove, .id_table = ab85xx_rtc_ids, }; From patchwork Wed Feb 5 00:58:24 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13960298 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 31F6AC02194 for ; Wed, 5 Feb 2025 01:09:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To: In-Reply-To:References:Message-Id:Content-Transfer-Encoding:Content-Type: Subject:Date:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SsAJU3FUgsUM88m4mSGw1WR2K15UVHFt8h4YUCR7Im8=; b=w0O0iXlf+SgB0EeVhxt0uhaZrE /L4wWECxa7qY6cCjEBcI0buoSrmkGMHDHkyEKWDM6M15I+7CKnXiH8WmQhGVRuPsbm33iLakcVEAN 5f4riPgUudc5amxj4c+mb0GkChgiixFq9ChBPi0jPlZFjZgLf+EaWzgZz5T2FKjXsV0p9q3WVWOS8 hueMSsS0B8gNuLyNIYVtbieh6b8W7qglpqRYWRQaw/Q2/DQPdjt8HWTYxckz9Y+qowQLfQhhQpvNm GvAVCdoqCOnZOsW4hl9kZuRLB0VnMEb9cjgpGNnVf6+H5EOmJsV/5NI9coj6cg7kcGRbeaLGxlYxe RTa0MBvw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tfTuL-00000001zsI-2BhX; Wed, 05 Feb 2025 01:08:49 +0000 Received: from mail-norwayeastazlp170130007.outbound.protection.outlook.com ([2a01:111:f403:c20f::7] helo=OSPPR02CU001.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tfTlW-00000001yPa-2fG0; Wed, 05 Feb 2025 00:59:43 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CfemhTSgeU4sGGfI8Re72cBatV8DGltV2OFSZUTR1hNrm6/d8+7z4I05zuAEnDH5FVRB/Wx2on+vY5bVCgpN1RJT1HYh/1vEOGhW/qvyasDVRIxi6UW448mJoaLa1vK2279LZpPXOuzL3pXZ5cIcGCGkT8sZGN+t6aWPzCMvOYHpwaJrQh9UBWNU0dOQU3VsjiXqDZhtDjsHy3CL8XNC6VXhc6lfmwtFCa1JC5JfuUvWa8tpfjsNl3k9Ds0MiNwQLxJBA2/ByldqksU142nLM0H3pBdcVGLkPSkjV5rUpM1EAA1RbK5AfhXCY2+zd7Ul0guHuApuEAMgs5kzYcd8IA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SsAJU3FUgsUM88m4mSGw1WR2K15UVHFt8h4YUCR7Im8=; b=a9M2MvI2sQI6C/8/ygaNTEP4cSZE1O7z/DXxENYRagjXfLDk+pB7XJl33nku9GcfoZZKVOUKlEU9YVYDd/BXFolhPFAZkiM9mJc069mVzvHiCTXufxt41hFTfELJefTxCmhVRDI1IfnG2VwpkE6xHg/p2t0bswg1BbgdJ9BhrS7/PcuH5Mqem5SdO7W2dIizvS7jq7X34lUOoF+jeDehjNoVLPb96wBppj1/6/djlqv8FBg7ggoiR9KnpMTCbXs8Uu4Kw9XtcbgMhQTjk+XUBZ1l93HhU48yh24UFhQu/j8lIKQHPqXYJHCHY71p8V9fDtAaZndjjau4+4Ay3dHhhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SsAJU3FUgsUM88m4mSGw1WR2K15UVHFt8h4YUCR7Im8=; b=P+1OefZ0diM739yPeiRBD5qtteCmV56h99Rgxpn09M38AdX3GYtnLmmOi0EfOW1hyM9yHme1J3uUXbwbyoarJTHR0GPjVgbf16rJ+plO2H/mpUWacHr8JKadSgT/YmAmjbNeSxZGVY5jwOk9EypKz0NYF6q5F/+0cFGuBqDHYi3TQjI9w8i3/YXcA0PnSEux7/PEg5+YTF5UK4uyy7k+PeWyDEyM4h64Q1mLJVE5pQ7AAzAs9bk1dQbRy9RUH5G30ionlKJ5KOhcF+LRTYwXP92jBf/IgRsFPwbODE2XUiojen0B8SsfvV1z3x6g9374LvPVoHKdhTXdhpYBxrdgfg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by VI2PR04MB10713.eurprd04.prod.outlook.com (2603:10a6:800:275::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.26; Wed, 5 Feb 2025 00:59:33 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%3]) with mapi id 15.20.8398.025; Wed, 5 Feb 2025 00:59:33 +0000 From: "Peng Fan (OSS)" Date: Wed, 05 Feb 2025 08:58:24 +0800 Subject: [PATCH 6/7] rtc: mpfs: Use devm_pm_set_wake_irq Message-Id: <20250205-rtc-cleanup-v1-6-66165678e089@nxp.com> References: <20250205-rtc-cleanup-v1-0-66165678e089@nxp.com> In-Reply-To: <20250205-rtc-cleanup-v1-0-66165678e089@nxp.com> To: Alexandre Belloni , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Conor Dooley , Daire McNamara Cc: linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1738717111; l=1347; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=7sZhYfT/a75JkuPsULgAYPAtV5pnc5lWQRqy0mNIenc=; b=ZZyJ6oBnd4ebUNNhIlVXgX+8rb9tbIafnXdCmfQxVegqmYR6Bau7iTLyWNEhAI0R91LFHHApT LE9qzTrd3U7BRiDAm+bXrNBCS4cu5UMLf523JpJJEsXVHDzxwY1rRzh X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2P153CA0034.APCP153.PROD.OUTLOOK.COM (2603:1096:4:190::17) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|VI2PR04MB10713:EE_ X-MS-Office365-Filtering-Correlation-Id: 28d5cc0d-d4e7-48f0-0dbb-08dd45805a56 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|52116014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?qCwVQfQ9yLKFqZ3TXVJAo5RK5LcrnAS?= =?utf-8?q?H30caXKggrju2cpN8zyv+FSLDPiqcb1EdX78L2dd4C0NVj3YgJG9Yu6b7nbgDAXLY?= =?utf-8?q?QWIXJnhXtC6pEUH1cXda//LpwhFkdq33gwHVZpJULKDyzerPfQcOAcFB1kIr8w6/W?= =?utf-8?q?dn9k9WXngqwKAMDMl9jMdLcX1FinbX9aCnhpEst32F5yo6TmcWjDBeo0KH0TfEmb1?= =?utf-8?q?1NJN/XEyPdcJZKOr0UnDFqM6o+n4GbRI9SWNOwVSHwj/sJ7XKMIIGeUbF8+qChWmm?= =?utf-8?q?U5wJj5zGQyeX40loLPccejcC51s9ztR47UQq27ZkQzzfSEVPZ+8Bi+liV1dCAtmoC?= =?utf-8?q?peyD8fNQdLc4dyWGfZvWrrSRFsg6a0bS0wFmOYAoGADU17PHlba/zdGcVyNYQgiLy?= =?utf-8?q?45sWotDrX669AeW29qoRKa1fyW5gH9uh2BxF+CFdiuZ1QBsgWFL4bUUVEnRFvL9vg?= =?utf-8?q?8qy2W+02R1arLqaA9rcAUklkPSMnn6Si0+rLjvZ/jYBOS1P/kkcJ0eTNYfk5lKV34?= =?utf-8?q?1faTFnhOByhyPOzXcb6i9+qMJXxus8elnePJvX4xMUJ2Yth4f6mz/wgG3RwUDfx6E?= =?utf-8?q?rvbsKRKS97ZfFYzU6a0UnahFYHSFTyfAHRqdcdKmEc0rdnBR+GXjXYqfp+cVpzcOT?= =?utf-8?q?Pl+JKZgfwOPF/4J8Q8HpTXqhKWiAe2+C9+Wozi5fZq1DeYUYCSEqpjnljrbaEHQB5?= =?utf-8?q?OwGvYdmE3RDZptU0mgn5fzypwwXykkwNk13+/1oWjEmlVNFvvVrvaIWlW56tLddnH?= =?utf-8?q?PFYoC4EqhV7ml8F9g+zKbb3nMp+0tMW66xaU3zsXC77nbYhXGkdbJPawwUsxWPQ0v?= =?utf-8?q?9kbkHH3nf8nDQeqQKpkqBLPRz4HaeUh3YKFcesfPMNkZq9z96vLMoym7LPCEpKasU?= =?utf-8?q?QERo29FnskA7wyasf+iq+I0qHQ5UCa+tqnod/qdRquCGJPTpA3zKrOc1HVoTe8lkF?= =?utf-8?q?T1BhbsTVXCen5pSp3YO3JfQwKkO03uvbCFUIFasR3ePkS8I6If5x3ukuWHHtDpvMQ?= =?utf-8?q?5mk4gPUdzxejcdXx4zw2ppGqGQDvfnwkPCX23JxcwGnKeZgK73U06Fh8jxq5jF/li?= =?utf-8?q?dz8BwJ66kVa+vuISdMuYPrIiZCDgImkbq0Yr1R8Qv2WShjwwkTpst6H/VuRVqyU5m?= =?utf-8?q?7HD1Tuyl6b1Xv6c2w3UA5u2wKznmglCE02URKFN5yDLxvLUleKeBtH1d9k3dGZKK7?= =?utf-8?q?fRa+XmNlxQ2hgO2wTywcnU3y8CikFdTIqqBfKo3EGQwXZOS+2+40SI2ILhtdnAPr4?= =?utf-8?q?RfoKS63murs6/PdGt3FopO7tCo/PLEXwrmotx1wkgqGkBvVRgmR0KLIDCha1xDffe?= =?utf-8?q?ivb3x7gzz6MlOUgNSOO4KkQaFWxgjo0BRI9xwNlcFfHkHth0FHvZZkyXQIB2+MtZM?= =?utf-8?q?5l1Vgl8gbBb?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(52116014)(366016)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?v0ISy84DXz2B54Niu4eWWVAEVECu?= =?utf-8?q?mmOCM7I0SrJXPSmLtQaiaI7L22C55EmYQCiBaN30aa3XHiNNZ6rqFcgKC/nK1GBMq?= =?utf-8?q?5eh8q1US3Edi+kCKbudeknuVt9vUWz1GlxbHaW7c+UDIaEPelHdvAy9O9jsVt6rci?= =?utf-8?q?9sQ7Zmg7t7iaoXDikB9+UB0YFdau1Lier4GEue0xtDjmZyw6kBhgO/1358wHwFFk4?= =?utf-8?q?iS3Q9TPvRSR2MGOby/MIQJ4eCFz2Y7eg7p21m2wYUf41emM+dpgLFNefCHUEUWytg?= =?utf-8?q?C4No/Qvu/r/kx5SRa2NumDKkBlc93e1u7JZ2ZHMcjm1LKUO233HFn7nvaIa6+tMiz?= =?utf-8?q?n60LPb3YefmImSLVOJ4egD2D4cOGICbnBrLi3+XBjnuUX9sDsBpVqq8+5MfRqHAQb?= =?utf-8?q?v3EEsHIjwRQ7SSBb0C3t+cc4eRLB8sTm1hAuexHksBlPKoI/s0SFt9jkXNyRKDfqZ?= =?utf-8?q?vg3M3e1anr1XNXDviVCRU645dt3EOMY81pmzAXq5U+tzmMZRPlpCUh6pgbkKLuEKR?= =?utf-8?q?5/jOSFgk/IEpp1qrNLk4r9JPDMYunUiaeb+6GnV6a5Wz+NZnTuBjhUQ4bWYrnIsyo?= =?utf-8?q?9gJtJpUK8Ygke2XQA0pHKqws2VN8xk/qP4H8yWBtECnDa92edI0ULjQOnsKFmexZz?= =?utf-8?q?CWycgLCAHY3YkZnkYrCzgE29GOLsK9QwJAkc3npouo7YveYypvwjzA5YbSs0gSpg4?= =?utf-8?q?gROXXz2vgZoAx0hCdRXkbgQEIBeBwfjQsf4uLxJ5/TaW4JLp7F3sej0rZIQT4iVSV?= =?utf-8?q?DTCGmKU+3QedHYlUXjRgFmlIKXc4siP5jXbXJOeMKzMcJFEzq1XlaC2aZ/Fovij6E?= =?utf-8?q?UPB8/yQgLFzj0begEB/RsbV2AoGpyx0Q/0RUiMViHGLg0OAo2Nf7AwNxgcC5xKuNJ?= =?utf-8?q?9Zf2g9OFLy9olCjanT9KzBGk1UCXfiAIu94BJ5a6adMt4PjBO+52paa9saiD5dLX2?= =?utf-8?q?0Yi/GPZtj5jEYE4w7+acK6qqMMRuGZR+UjnOuxXzxmi3EwYQMTUT2bP2Rydi7fmx5?= =?utf-8?q?Jqhe8RMRCVXydaElkukdjpoHqoEe8QVxtsuQPbILyjdN5DDvs2exNksGh/gZAMV8s?= =?utf-8?q?jAjj1RU6MzxYWiH6kXkCqzqSFsMcKc4JKSrFEmcLQYBRD4oW2cZqAy3Pv9QDKUbNZ?= =?utf-8?q?DmksHkhz0J5tgIXyPD8KGOt6z725q9X3HflQ2dr6zy1MIrd2192WQxuyix4xtU21c?= =?utf-8?q?2TvzmbHQn+OGF69SD6I2qsT0FDIhNAP4CHwU5h1x+EWboCALiQVw/xnOa/3yhUOx3?= =?utf-8?q?EltTCE4Z9Bm+2BrBatrdGEm4yGN1NI+Pokw0tj4LMF5s8niXBfeI0gU2xT189/h3R?= =?utf-8?q?WXd/3qdbowlYr2UwL5uKkcnbAR3Y6WScG2q9NbQEyeXQ19idaM2pQtcO/ckQzOZVM?= =?utf-8?q?7w8bnDsB579puDuVL1VOYz19asNabNAc8hksuQacX5cVl5tG61mHVAUKpT43zT1fu?= =?utf-8?q?kM80hKJa6677bA/40YbTVuUSR5aPpT3xd2BrgphUIW9F9W6viKqjjE5EktvWHsqZj?= =?utf-8?q?7pMHo1gUvj9D?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28d5cc0d-d4e7-48f0-0dbb-08dd45805a56 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2025 00:59:33.1380 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Egsm4Fg8ym7JJhPoaUC7uTQB5XsKHT95YEQ9DBL8mwasmxKv8UcFlWZNkcobBKS6n+gxSveulntB2MmLZhgO9w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI2PR04MB10713 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250204_165942_681949_3A879467 X-CRM114-Status: GOOD ( 10.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Peng Fan Use devm_pm_set_wake_irq, then the 'driver.remove()' could be cleaned up. Signed-off-by: Peng Fan --- drivers/rtc/rtc-mpfs.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/rtc/rtc-mpfs.c b/drivers/rtc/rtc-mpfs.c index 3892b0f9917fa7bc4f732cfe2c2b2f548ba7429f..5a38649cbd43b3c6f2fec5db95c4f0013deb2a08 100644 --- a/drivers/rtc/rtc-mpfs.c +++ b/drivers/rtc/rtc-mpfs.c @@ -267,18 +267,13 @@ static int mpfs_rtc_probe(struct platform_device *pdev) dev_info(&pdev->dev, "prescaler set to: %lu\n", prescaler); device_init_wakeup(&pdev->dev, true); - ret = dev_pm_set_wake_irq(&pdev->dev, wakeup_irq); + ret = devm_pm_set_wake_irq(&pdev->dev, wakeup_irq); if (ret) dev_err(&pdev->dev, "failed to enable irq wake\n"); return devm_rtc_register_device(rtcdev->rtc); } -static void mpfs_rtc_remove(struct platform_device *pdev) -{ - dev_pm_clear_wake_irq(&pdev->dev); -} - static const struct of_device_id mpfs_rtc_of_match[] = { { .compatible = "microchip,mpfs-rtc" }, { } @@ -288,7 +283,6 @@ MODULE_DEVICE_TABLE(of, mpfs_rtc_of_match); static struct platform_driver mpfs_rtc_driver = { .probe = mpfs_rtc_probe, - .remove = mpfs_rtc_remove, .driver = { .name = "mpfs_rtc", .of_match_table = mpfs_rtc_of_match, From patchwork Wed Feb 5 00:58:25 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13960305 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F11A3C02193 for ; Wed, 5 Feb 2025 01:10:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To: In-Reply-To:References:Message-Id:Content-Transfer-Encoding:Content-Type: Subject:Date:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EwjZqLy9UAzAbl6jmLkoboiwEpYZWe0ARcy3BM/gy6g=; b=w9RtWF6SbXhzV8raDgiHEUIUxj dSDKnJBtS74UjAO+gzR+WptQYl2rva3oIpC/ECD66Y5B3u0GMA3h0THZ6+TB9UPmwzjP1pcZKufVM kC+X355mJGCJwM28nedgLEa9G2n1NZ7Dzx08el6QKcER9Aqrhgi8z+2D6wya6prBKdmFH46CM/RyT JgecBrcNEief5TIy27oJC8xJmEmiAKPDkS7wUVaLQnCQwZw+SP+cZVqv+naf8TeAcOdlZmDmodvuQ zVcr+rB6MDQJMKfsJbhBJjF4eyRqqmCp5kB+zrXJQF93XD8ARwKavowc5OVxAKKJBTs4u6iZdXoAh U1hfVCYg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tfTvf-0000000205Z-3AMn; Wed, 05 Feb 2025 01:10:11 +0000 Received: from mail-norwayeastazlp170130007.outbound.protection.outlook.com ([2a01:111:f403:c20f::7] helo=OSPPR02CU001.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tfTlY-00000001yPa-0Z1Z; Wed, 05 Feb 2025 00:59:45 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NKAoflszZ7mlKl9PYHCgJY6OEDFp91cFt7//ipvC6nMo0K5WrAhVVg1db7OAjcqkHXHOjKSUGvxasdBoVi222Ff2tCoFnGZHR5LMeX+l1krQsXEfcwulh4v4sLlE2lA9wmchZdwZHHz/XkYADOILAdx5REpdtj5Nd9J5/oegjpChv8hZ7aXep8mileT31UmoovwSEGyqlCM3OA7++OQRpZ9YfplaaS7ioZp7WHImZAa+qS4nQ4rUpYLhRLikVivSkuuygs6dTEteacL8DTD2h2/0vSa3NZzWPyFQIP3TB9lUf3V54EcjikTIdknrKuvCJDZKPmR0I8S1IfVZgZROAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EwjZqLy9UAzAbl6jmLkoboiwEpYZWe0ARcy3BM/gy6g=; b=Iu7LzleXyPFTpA9pxajroIpa81mSuuKH6SWK35k61tWXeuB06gTi7EMZnmwTmMwRf3JNIN958e9nkmKE6125GmRPoCIscg+Utttte2KR1qpNTQqK1u/Bmn4nFFG8pmmkrFlO8By2BTQS9PJwqGYD6NC2zm7ut5XRACSX4zFx0dA1wqNZDNHF2ZP5BYWlW9GsqQB0/c10rQmzmfh2SE+EYTRaTVY8T9VSbpy0WhxYn7StF32LvREuai7yuPaCAaQWFm8mwzoGVxLBIrKEOnYignuk+kUB9JJ7CYMcT9JbHw3J6/JAK1gFyf6p/KX5UH7uQw7wHP5fKAyCsqqulRLKEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EwjZqLy9UAzAbl6jmLkoboiwEpYZWe0ARcy3BM/gy6g=; b=xehDLvqmOSYIWp59xODlz9s8xncr3v2CW4nz7PWrlcpSP0DgWSRC+d3PlXFADPlpLy7/v95oK4HJyVJcWE6gVcnAtICeYHhi6085fnpzX8E8g6gBDes9eV8F5wXDArdKR9TZsXkdIj4oyHu++ij20MbzOLRg4Dgp7aIgoUPBpJn4L4o9MVwrpTzxvwU9DYA+89DGSz+8YkhPeiLyZ2HSBb42ZNWFUYu38pdPN5sSdQHGV4lrbxG5pSYPUF83tEPWEuiHyU+K/qyn2g/4ayHojdEVXf3q2AZYaxBwRs3frS1WAvzr7UaoADYFisDxXrAcyzFhxsvYRDnMcIsPPyoe/g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by VI2PR04MB10713.eurprd04.prod.outlook.com (2603:10a6:800:275::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.26; Wed, 5 Feb 2025 00:59:37 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%3]) with mapi id 15.20.8398.025; Wed, 5 Feb 2025 00:59:37 +0000 From: "Peng Fan (OSS)" Date: Wed, 05 Feb 2025 08:58:25 +0800 Subject: [PATCH 7/7] rtc: pl031: Use resource managed API to simplify code Message-Id: <20250205-rtc-cleanup-v1-7-66165678e089@nxp.com> References: <20250205-rtc-cleanup-v1-0-66165678e089@nxp.com> In-Reply-To: <20250205-rtc-cleanup-v1-0-66165678e089@nxp.com> To: Alexandre Belloni , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Conor Dooley , Daire McNamara Cc: linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1738717111; l=1457; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=836X+TA/l2wfm7yon8oTf/+NEC4So+0tkKKh8ZKoqD0=; b=8b+RiW38bzcj7vW9C3nT/sXnco85VHDgcMhjl+0oTU3U8lRGFu1FS0OqHTfe7FEm8pMc6TD6S CcnR0JtCPB9Bg8e17MVnczKMvC1sDBxLvXZuA57wbWLOBQLeV5v1DtW X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2P153CA0034.APCP153.PROD.OUTLOOK.COM (2603:1096:4:190::17) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|VI2PR04MB10713:EE_ X-MS-Office365-Filtering-Correlation-Id: 793ddd20-9a38-46cc-7474-08dd45805c9e X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|52116014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?w9+YTbqn4IyU9Vl3B1oPLFGMByu4Auy?= =?utf-8?q?cmyrXZOHyMynAFZ3d1IFm8LQVWxFFtHsW7egrajWoQxcQc54zsSKDNY83WkEfw+W0?= =?utf-8?q?6QuyyXWDHjfBntCPVv+nkxkWCOyFL9E10NlZDf3laTJbtVXsofxSbApvvj7QVA4+A?= =?utf-8?q?RC63idePwbNCn/yhjBTWJgR7sWedvgSf2a7hI+vcgFHGWmicyxSVbdFHiuBxUkkaY?= =?utf-8?q?vx4MZjEMPR/cikzdlHzGrQF0cHSvNFzTzFAkkbgfsH8Co+KeTjqCBqxiO325BL9Dc?= =?utf-8?q?/Spvgb0CTPMjubpmHItiYTAkt+2ECzric7ew/17jejehYajEMOsoNFi0Mlcwk94H9?= =?utf-8?q?UmtAaNK9rrxAd72qfJIApr6MalUehOWHzrFVe9TA9/kGRVq3lozkseqkH3TSkxLNk?= =?utf-8?q?KExClgM9OYOCsXr6zkHrV90T28VLBGR5b0cLlAGjg/NdR+qpcK5MIDXzBj1Olyrun?= =?utf-8?q?s0rZ95R/TWXaQdvMZiHZPLvB7Lq/FK7iCO5x6vpPysDqH7EN8xhr1Jr3FpbbGffci?= =?utf-8?q?yCFG/CuxrtmDl43pBOb7dRUohaLxHsanJD1nAJTR0//7GZZrOlsfARnZiz801MLEM?= =?utf-8?q?pnCuc/VhRLF55IkRQacZlQRocFVuyzqd+7GgbUvszMJLIbfNv7PGFzcjG+g3I5+3m?= =?utf-8?q?ID6rbQm3V5QCLE8jxUi4cvc1BtmNVmxxnimpk2fXFL7dYyIQccWr+gVj6suezwMTR?= =?utf-8?q?q5Zp3VyxoM03/SJxKRQhR361k1yfkUlrHbvwcrTgWFMZrsvz9VA9k73C+/pYQgl/o?= =?utf-8?q?D/fqyt6nSGozkakwucsO4O7oYz5JWUSlMw2q4IWmGbHlTfYcICXwltkzq1Czp/4Fh?= =?utf-8?q?i8TekFy2qDdG8ljRwI/BkxAFdBQl7BFSIcE4wYBy36ywtY06GorMTjbbs2+DUeWVI?= =?utf-8?q?CyCQe/memun/s4kCufORkYgaHxNSEEdlbspnghWARgsoj2qK+1R/bcKKWVorMX+dF?= =?utf-8?q?kGQn7dS6fEdpvUkz2Ayb4jKICMH/wCACICXmcRlhTZfMIQBcUfJDG/4ibYnG0J0Yj?= =?utf-8?q?k3ETsDLjZYjQOh8bQ2JA5OaCt/uhk7T50Eg1mg1AkD5i9bg2ieo1VKyp2SKe3Fwb1?= =?utf-8?q?Oglju8su/ES4glill28yGAFImtq6sSwVJ7ZG+t0eREQnLYMzwShgVnB3eMHiCRxac?= =?utf-8?q?fTfo4+Vn3DLUyiu0dp0EjXuaIHKtZbG4UoQYE2IC0DRlAQ11zSSC8DQRBAgcC+GHT?= =?utf-8?q?tp9IW8awyvbVn29IwljhoRXzM244BlgmaZRJki/be0QdsoX3HumbZdaVQp4ShTlT8?= =?utf-8?q?YWDsbYwBs0Xvc2bcx/1+47u4WvsYW1U14jEalERcmwbvTDq8PkhOMLJN+yjFmsF9t?= =?utf-8?q?nwlYcQPrdhE/CXpPPlyCwADnhIJRG5oyJQ8EIQPxS9u4AcjFsetIYdDDRfFzMgMVx?= =?utf-8?q?2n6Y3cIW5bC?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(52116014)(366016)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?arH817r6/3CQWYFMdZsCiKGNPobt?= =?utf-8?q?hu7ywStJbazpAAYMPq5R91puBw/JXqMPJ0AbagUVj2gawKByXkecUVF+NkfDifbiT?= =?utf-8?q?A56jbJDcRxo5bZV49WNi72UuLe4xEZ9EDVh3S65WIamJWX/vsX5QK/CsFOhIOs+ed?= =?utf-8?q?w2ZfOWc+39DeLkbNbZaYX2tBiv6tUEsv6UIKQiEVO+cmS9uLubg56dykBU2sT94mC?= =?utf-8?q?b0AAhm7QuVg2xXxEQnMpuVji4SuFNUxOg/vB1ZeRkK46hFhHBwUl515206+L+PMDT?= =?utf-8?q?F8ctdDRYcK4+I1WFgoktCHyx4ooVLau6Z9puRytVzbVnu8jfrI2+905fYKvxtyFD9?= =?utf-8?q?3rYjkS/dHaSxQNhIM6hvTd0THETrQ7GCmA7R0AVdlUWscJ3CS2nbCAjFockAUiadq?= =?utf-8?q?DdX9k1AOmd10HeyJauWqT+zj5C1QEngBPVKWJZI9zRxE/4CpCmAI54rL7y+7PnmMe?= =?utf-8?q?kMmHbENerSFyR2bdAOo5fBwo/ZWQfQcss+eCLT5rvvkTx3ni+x+8RjitkXFouL7DQ?= =?utf-8?q?fu5BIah8j0yVDDWVEBJDmAFXuV6xVEDF0x9YycpdFCG2yzZbQSBJdZI3H0y7Gj9gc?= =?utf-8?q?l5wdaxXKGeIc1+4wZ5J8bMS2yiCxMAO5W/S8WFBxoLJGqfzaId1mMDWK2HC26+nAa?= =?utf-8?q?uztHkUEizBAYf1DBe0ESvFn/b0a5gaTXdHtQYw0S8DqfQ4TA2cWbNd85cp15SoLoy?= =?utf-8?q?VNXimonoya+9ZlplYTRoNzi+NegxzOtHHcXA1BP155jvhcDXKFnMsmZ/mUiWYv0Hs?= =?utf-8?q?bq5UcYjEtv5hDAEsh/CMYhW08JcsE1FXiRjseZ84f7rO4NU6C7KDuRnsklfsuQriD?= =?utf-8?q?r9yc3VER74SmDa/2Opc6Pdqy5CpCOM539PCX4Ru27yzKAClZrjY4Y50iXNdOHJ7Tu?= =?utf-8?q?s8jW2+nukoIQ/aYgLqLx5HgcLvzM67fyuyr9CziwH6VKxsHkFYpxbqaL2iY7+fvPK?= =?utf-8?q?cEvmJgh22mLx+3LIRu62mmU0OaBkfymEWdbjRSAj2AY5t+alRzZMd0ZwKB6FvPxDd?= =?utf-8?q?q82HUCJq5dkt3hj6irDfnqBHcTkbypctP5z+qZtIKMItoWyvAkhvnmShsnoPh2P+n?= =?utf-8?q?blIPQcnCXvaNAwfvhbkoDIjvpFw09Dyzj2UWxkC4h16RTXUCXS/IxvXHrZhA0Hzg3?= =?utf-8?q?QSaFCkfDbZmb9LftBa5PMxtQreHafG4T1mAeqhxY/xHwn8UeG0Nc29ayVTBDWGqTq?= =?utf-8?q?zc45m/DdHuxGt9IYKon+HUKC5Z29ClIH4P5i19ZPvcIk0OJPTfzzemqhGWqMoQ1TC?= =?utf-8?q?zb5ei4oFEq+Tyr/GDfnuHvRsdUVpcKGTIRbnf05I3e8PCbw2Hz+ZDT9wCD0kmw50u?= =?utf-8?q?1tCO5mBMnjnIEN9inqAsRslDcWHjtm9M9Kz1OEXwTNtV0xEgb7VUMVANRiMeVC4zq?= =?utf-8?q?XYWj/nebK28iQu1WAvgXzGkJX5qMOMNoUfz4ExWoIln0DnS1djc6Y+24KABwur7kp?= =?utf-8?q?sFj9R/HV6TSAJqCljE/P2XlYbHdGpTgF9UkZah7SlNmVgxQM07mf3e1JLy8xLZ/s2?= =?utf-8?q?j1BI55eJsv7l?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 793ddd20-9a38-46cc-7474-08dd45805c9e X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2025 00:59:36.9576 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2oPoxj+HRZgTo9C3XvebIy33LXIv+qsbQEPWs3oi2EnamYs+w73SWn3eqvWRDfveyM3wqXzBRRv4+6LlAn/9EA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI2PR04MB10713 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250204_165944_182521_595C0967 X-CRM114-Status: GOOD ( 10.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Peng Fan Use devm_pm_set_wake_irq and devm_device_init_wakeup to cleanup the error handling code and 'driver.remove()' hook. Reviewed-by: Linus Walleij Signed-off-by: Peng Fan --- drivers/rtc/rtc-pl031.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/rtc/rtc-pl031.c b/drivers/rtc/rtc-pl031.c index bad6a5d9c6839ca70905e3d46286b9729c1fd435..47bfc5395e5908b7722b98276399120f1ba65af0 100644 --- a/drivers/rtc/rtc-pl031.c +++ b/drivers/rtc/rtc-pl031.c @@ -284,8 +284,6 @@ static void pl031_remove(struct amba_device *adev) { struct pl031_local *ldata = dev_get_drvdata(&adev->dev); - dev_pm_clear_wake_irq(&adev->dev); - device_init_wakeup(&adev->dev, false); if (adev->irq[0]) free_irq(adev->irq[0], ldata); amba_release_regions(adev); @@ -350,7 +348,7 @@ static int pl031_probe(struct amba_device *adev, const struct amba_id *id) } } - device_init_wakeup(&adev->dev, true); + devm_device_init_wakeup(&adev->dev); ldata->rtc = devm_rtc_allocate_device(&adev->dev); if (IS_ERR(ldata->rtc)) { ret = PTR_ERR(ldata->rtc); @@ -373,7 +371,7 @@ static int pl031_probe(struct amba_device *adev, const struct amba_id *id) vendor->irqflags, "rtc-pl031", ldata); if (ret) goto out; - dev_pm_set_wake_irq(&adev->dev, adev->irq[0]); + devm_pm_set_wake_irq(&adev->dev, adev->irq[0]); } return 0;