From patchwork Wed Feb 5 10:01:16 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Claudiu X-Patchwork-Id: 13960760 X-Patchwork-Delegate: geert@linux-m68k.org Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 069161547D8 for ; Wed, 5 Feb 2025 10:01:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738749685; cv=none; b=DdniEFHRb8oFwXdrvT8vKMhdqymv9brUraJBdO1ZQtpmIP9LF2PQ1CDc8zbbWe2B6o+zTccfl+2E1Yz2V0BS2oPKbNtniHTkAAm3EOGBtchp0Gqjb1+w28B+Il13XGaLODoaKW7EIReQmVVi50NKwfBEvUXvd/SQBjxMvO1HaSk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738749685; c=relaxed/simple; bh=qxQVPA/WkzIwKFhwjbzk0asjMT7Gj4GjjUTIhYbbZSY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=WMmVPPj9aOxZiHTMKJLggPyh/eNL/tsycKVoYpLMg7jbMRpHV0AgCSeXY673Tpv9aKLjep77omiZrWQlkTHiGjDikt4hbmzwwCr7G1tNIikg32N17mvNs1zffv2HSgLxk84ItiW0maBqnYvXR6EokVaOMeBTqIfqaulfthUYxs4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=SmfawLuR; arc=none smtp.client-ip=209.85.208.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="SmfawLuR" Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-5dca468c5e4so6326558a12.1 for ; Wed, 05 Feb 2025 02:01:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1738749680; x=1739354480; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=PawpytiL+xRKfNoRH6voDpQKdEbDcwFfD1fKVQrBak4=; b=SmfawLuRPd5EuKSnmk74AuoxJX6nLusbRL10fM33owwxTeX/OgjNvxN77F026LfYaV 7F1qgtTLh8HZxngQKdGeIFFXAu/j9zVyTDMUHym2vRCDHsASK+ufQLKm6e/jOMOmI5Gy JUJSbK4K6gJGbGSVOIK3FthrAMLOBDfqsQVsaMWCHLQM5HPj/xZPBLkTqaZ1Zb7yA7Ot oH+KHvsjmly/B0SkRQubfTXW0/MxOKHc51TYGmRPVHenEXvhcPc/XHuZ3eZdzAnswVSS aZmwaYT145wI5YhFwJ1QZg/FQHcprxLMRSflhKnePwUIlpz3taWJrltzb14QOi5RwTAI hnkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738749680; x=1739354480; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PawpytiL+xRKfNoRH6voDpQKdEbDcwFfD1fKVQrBak4=; b=FY8N9oSOmFbofMu9MBS7qkI+o9/gIRowHG4OcaPKOEHXjnFtheSrFHHwhLmO5TkGDS 0S8g0uzHn2Q7EHHBNhkWnLHYf7Jrcv/2MCyAGiqoQm08+MwkoD0UnR+7AfgaoqVhljrE qQBl2yskJKlJ38fKISvbETZKW8tXFN8EdX4kQYEqJPdm5mPzDyEoYV3loOR3swy1z4M4 Bpd9vAT/uWDp4WUp16HP7M+FIeJk+vkNk/6HWqciQYYBmOA7PI7Sb2qgLtFE8+o5BHeV GeRwv96Gmz8khLad0L/5Sufk9G9hw0Xt9A+TGiLuon6aR0jTbWZlWVxhwv4ijZJJmPN4 aUJg== X-Forwarded-Encrypted: i=1; AJvYcCXMgMmjeziO6gRK+YhsnXSSOrTWQS1YquicMzBph1nV3IW8ur51xWHPiUAiE5m0g90Uz3SJBwTsoQ3rkrLG1Q1D1A==@vger.kernel.org X-Gm-Message-State: AOJu0Yz6MyApPa29u9h+GjynXq+2Q2G5VbS9fOJEHiultgt4po2dJOGI Jj1IM+9y3hNMryN8CPtbqeiT0aOBaJPPk96hahflBW13KO6MjpLLbwsND5BoPHQ= X-Gm-Gg: ASbGncuJOOwZOHl3QgtSQrc32dAC/jbIWQNgXSYiRjsyalW6+XlcqGQ99BdUcU9VrL8 c3hAuAd7RUCv/WBGrSEnUPvx10w343SEJvE4hOszV1DpyOrZTqp/HsyiKih7ZjeTRO9v3wknlOl bQn+7WYt9wxNqNwuOY47FDGr32kpJBREp6E6oUKCJ7/iIzSl5ps2Xh6kep01zUSC3JvxU3lBult 6HplSi2cIkYJJbuGh8HjoGQDmPFOWWO97eWh6JFz6qz/jzXEPy2MdUxqCIc1tAcFPyQkFTE9GMi JXBVIQGDrAF0uuJWr57AqbyRDXe+9vq5L9hPz+u5zdSbKw== X-Google-Smtp-Source: AGHT+IGRR+qNVvpkRYMLNfhpFnPmKPB/WLt/GMn1HCiYzOXe8y+iOI6UbcyDsiRPDcMDjFnJzsBNKw== X-Received: by 2002:a05:6402:280d:b0:5db:d9ac:b302 with SMTP id 4fb4d7f45d1cf-5dcdb77fcb0mr2613484a12.32.1738749680235; Wed, 05 Feb 2025 02:01:20 -0800 (PST) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.173]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5dc724d9de2sm11130554a12.81.2025.02.05.02.01.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Feb 2025 02:01:19 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: geert+renesas@glider.be, linus.walleij@linaro.org Cc: claudiu.beznea@tuxon.dev, linux-renesas-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Claudiu Beznea Subject: [PATCH] pinctrl: renesas: rzg2l: Add suspend/resume support for pull up/down Date: Wed, 5 Feb 2025 12:01:16 +0200 Message-ID: <20250205100116.2032765-1-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-renesas-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Claudiu Beznea The Renesas RZ/G3S supports a power-saving mode where power to most of the SoC components is lost, including the PIN controller. Save and restore the pull-up/pull-down register contents to ensure the functionality is preserved after a suspend/resume cycle. Signed-off-by: Claudiu Beznea Reviewed-by: Lad Prabhakar --- drivers/pinctrl/renesas/pinctrl-rzg2l.c | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/renesas/pinctrl-rzg2l.c b/drivers/pinctrl/renesas/pinctrl-rzg2l.c index 4fae24453c11..7eb91ac5ba42 100644 --- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c @@ -318,6 +318,7 @@ struct rzg2l_pinctrl_pin_settings { * @pmc: PMC registers cache * @pfc: PFC registers cache * @iolh: IOLH registers cache + * @pupd: PUPD registers cache * @ien: IEN registers cache * @sd_ch: SD_CH registers cache * @eth_poc: ET_POC registers cache @@ -331,6 +332,7 @@ struct rzg2l_pinctrl_reg_cache { u32 *pfc; u32 *iolh[2]; u32 *ien[2]; + u32 *pupd[2]; u8 sd_ch[2]; u8 eth_poc[2]; u8 eth_mode; @@ -2712,6 +2714,11 @@ static int rzg2l_pinctrl_reg_cache_alloc(struct rzg2l_pinctrl *pctrl) if (!cache->ien[i]) return -ENOMEM; + cache->pupd[i] = devm_kcalloc(pctrl->dev, nports, sizeof(*cache->pupd[i]), + GFP_KERNEL); + if (!cache->pupd[i]) + return -ENOMEM; + /* Allocate dedicated cache. */ dedicated_cache->iolh[i] = devm_kcalloc(pctrl->dev, n_dedicated_pins, sizeof(*dedicated_cache->iolh[i]), @@ -2953,7 +2960,7 @@ static void rzg2l_pinctrl_pm_setup_regs(struct rzg2l_pinctrl *pctrl, bool suspen struct rzg2l_pinctrl_reg_cache *cache = pctrl->cache; for (u32 port = 0; port < nports; port++) { - bool has_iolh, has_ien; + bool has_iolh, has_ien, has_pupd; u32 off, caps; u8 pincnt; u64 cfg; @@ -2965,6 +2972,7 @@ static void rzg2l_pinctrl_pm_setup_regs(struct rzg2l_pinctrl *pctrl, bool suspen caps = FIELD_GET(PIN_CFG_MASK, cfg); has_iolh = !!(caps & (PIN_CFG_IOLH_A | PIN_CFG_IOLH_B | PIN_CFG_IOLH_C)); has_ien = !!(caps & PIN_CFG_IEN); + has_pupd = !!(caps & PIN_CFG_PUPD); if (suspend) RZG2L_PCTRL_REG_ACCESS32(suspend, pctrl->base + PFC(off), cache->pfc[port]); @@ -2983,6 +2991,15 @@ static void rzg2l_pinctrl_pm_setup_regs(struct rzg2l_pinctrl *pctrl, bool suspen } } + if (has_pupd) { + RZG2L_PCTRL_REG_ACCESS32(suspend, pctrl->base + PUPD(off), + cache->pupd[0][port]); + if (pincnt >= 4) { + RZG2L_PCTRL_REG_ACCESS32(suspend, pctrl->base + PUPD(off), + cache->pupd[1][port]); + } + } + RZG2L_PCTRL_REG_ACCESS16(suspend, pctrl->base + PM(off), cache->pm[port]); RZG2L_PCTRL_REG_ACCESS8(suspend, pctrl->base + P(off), cache->p[port]);