From patchwork Wed Feb 5 11:25:12 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dhananjay Ugwekar X-Patchwork-Id: 13960855 X-Patchwork-Delegate: mario.limonciello@amd.com Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2085.outbound.protection.outlook.com [40.107.94.85]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E39815198E; Wed, 5 Feb 2025 11:26:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.94.85 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738754767; cv=fail; b=kwNA9sksUpFL98XfYh90BVHcBrUKzvdV76UEASTsA4GmBk5/Vq32gOf8WX/NnNhprRmF2pe2nOu65FAcZHwbnE10xHj7Q7yaMRV79WJRggWGQV6dggFg2k8PB02V6Ohf9BaVV1fNhntWLDuuiGv9FKbOPqABfNTRYaJR2vtj00Y= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738754767; c=relaxed/simple; bh=PqTDPGnG/l3yQyX8/9RbKj6Q+gwfcPqz7MhwNUZLse8=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=qWpkXNVEonTjPy0V5QY6I1Qdp/b4OoBqDQOMYkHuXiEHu3jOsZrVb55OP/kOWsV4tYSUNzrJ9W6CM7cekJD21v3DAjgG7/azqm6rKJIb4f3eMTIHqM3FG17TQ3r9rI6W0qqimNtYNEMQVRRSt/i0GqwZmTz/RJ8KU052wXNkjkY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=PlI7GyRE; arc=fail smtp.client-ip=40.107.94.85 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="PlI7GyRE" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Z2IEzqC2pAcibRQwEWrzl3PsijfKg5cozn+rDIavMm3FHEgpf7UXJHn7/4CiHNWCXGSlYJfSGiN6uPu78BQQLNsN3+5vrqyn0fXEjjncTWNN7KV/EkCIGgJ+cGxytqIWCxL7LputYcWRuLNEc02X59WD+pjwXSkc0AOLjT5jSnYj5UclzoDisx5LQWrxHpRIV7rSPm23ChzTXb15uMFCM/taPO3wVToeUxBboTl1Xs5kjQi65c+3iabSYU+P5sWMEyMT4gS+uqyOTxzxrbgjqgwhM4CpAemtjiPvb4ydbTgIwH9RptmuxejqRzDmYmBTX0vi3MEvqfZzX6+ANOodKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C/Gvnc3YAZzH4BMOAdmUo9dQtVwJ5Kq/e/bELv8Qrfk=; b=OpzNCEmmcLLgtFWB3aUniOKUNPcnb7nHG1G9o9HSjXkcwwbZoxi7MdF6O0fbM884kvyxn+RtNZhG1yHeCwUSQcA7S+FTYnjorwWZ1ztruVlZxEIWveS1u6GsnuhbuZOj8rlDWFwWd4ZErZ++6tV+/tQBf7FKZrmrJ8Z0J739aY4U0mzubJAzh0S30s26eqSB0zCuLdb7cAw4g61CnHMNUGpewV//hBfKjlDt7021VPZwKOHKH7BXvqnDCcdIu5hiD2n5oTfccHsRosZkh73vPi3jC04TMvDKM1m+aWKlOY+sTcbqAiebOrii1Wi4qt7ppbhFPvCV8RyrpABnAImffg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C/Gvnc3YAZzH4BMOAdmUo9dQtVwJ5Kq/e/bELv8Qrfk=; b=PlI7GyREhVDjttWGXHNry84xYDvY5+V0Zkcp/cX5uwzS76qlkah0OeTF8rTVAn+c+kkbO1UtGEVbUh2OepxLo//VAazFCUxmmOCsT9y5ZKKzaiSnBXII32LArNTJMauNKFxICEul+AkqTmkR6mkjzjA1Wrk22Wk99HebG/fbObE= Received: from DS7PR03CA0235.namprd03.prod.outlook.com (2603:10b6:5:3ba::30) by SA1PR12MB6948.namprd12.prod.outlook.com (2603:10b6:806:24f::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.25; Wed, 5 Feb 2025 11:25:58 +0000 Received: from DS1PEPF00017090.namprd03.prod.outlook.com (2603:10b6:5:3ba:cafe::2e) by DS7PR03CA0235.outlook.office365.com (2603:10b6:5:3ba::30) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8398.27 via Frontend Transport; Wed, 5 Feb 2025 11:25:58 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DS1PEPF00017090.mail.protection.outlook.com (10.167.17.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8398.14 via Frontend Transport; Wed, 5 Feb 2025 11:25:58 +0000 Received: from shatadru.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 5 Feb 2025 05:25:54 -0600 From: Dhananjay Ugwekar To: , , , CC: , , "Dhananjay Ugwekar" Subject: [PATCH 01/12] cpufreq/amd-pstate: Remove the goto label in amd_pstate_update_limits Date: Wed, 5 Feb 2025 11:25:12 +0000 Message-ID: <20250205112523.201101-2-dhananjay.ugwekar@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250205112523.201101-1-dhananjay.ugwekar@amd.com> References: <20250205112523.201101-1-dhananjay.ugwekar@amd.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF00017090:EE_|SA1PR12MB6948:EE_ X-MS-Office365-Filtering-Correlation-Id: 8ecd709e-2c0d-4faf-f84e-08dd45d7dcea X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|36860700013|82310400026; X-Microsoft-Antispam-Message-Info: E5zNd00ghljCDtNMeOcAZTUxJy/KkpRIeKBOc47J3rFANA19t88XY4hHpW1+PhkH0jzjIXfoOLd1iZEp9Cj6kYVlJCPK+yE9BV1DpgazZseSXeOcvr+g4jDfJpfVjxKf5giQ3/31Zjw98xw8ybxdZf77T26qHgRt6o17kzgBbWOvfxEcH8PBYPOkm2ew6LwKYIDFSkWVvw/oH+iqe+pXxaW0vPBn720VKHdR5jd3hrtFeGXQsLklhWqo81DSBJMnY0Nea0PgDi9HsNj7faaf+/mAkRjK5YYRN2C743nyoTSF4f/HCbTfZG5WRAa4zMO79NJW3VEePVz8CaoFT79Csf1BVVb5abyFkx9mkzhzfiV7oNFw5mtg/s2d0bqEZ3odAUCiJCFW+mehKumldAUlDARyQ4aThFuWOOCRkhNiur63aC740/YU9LMjB7z/9AegvHdSQzKS6/oxzmJ/YQBytiGMxk6/FvMQT0pL2/FB0+wPxuuh3RZlICWo93gP4da6MCQabAavTBfQ81EKUvnuReOxr+SrI69r4H8eTeflSAZxu7fKjw4ZSKsiDm7SmIjJnoA7ztxbDFm1rdeSFESwn/xvVxFIaAy0NVxQ4aGtqKcpjldlU0zchVXvS6nguv+CN09l4SuPGHinj57mpB8mfKXVEcsm0a4PRuDYIYeiAHhhO6DqLpsqEDdg5aeZsmh59JdEnbEcXjhHMrkeud1oKOGsWdQyTC1wvLMVzrX6yOHgzi2JkTnnVkecQR7AeaQxNGFx9m1xLDOt8RIBxvWHnnBE3rV/Qh+kDsQMn6DOzjjVPYW8olEZ4JhzsvWifaio/nZNuyFudtOT9Du0HSBJ3CH5XPCRta+cdo771EKijuAEiYKdkvjtsQ2424deDY+3K5oj/bNA3if9AwGgdCTxxTPA+QodT8QfjdsBxScXpVxCg/woclXxPZ18XoBw3oUW+YlybnYsedibRjEClA22SfB+66OGU0rHbBuDIq2DRneNim823KXYneZRmWAqQXaGTc7rxyjJQGrC7MOSV1rqGOLDvYcUiTcK5wRHtt0pOxS4Xsa8oI3m0b5FYR4w7SDm5jSN1oG7RdLpRIpJ0xzpiQqAnmPsceJ1ZyAZczCd1ha/LRgnCnkNMlPsAOTDxvivwhup2Bj1pcqDhOM5bQ2jVzB4RDtG+7oR/dmpg3jjkKB+FJQ33N430xcaAZY6uhfh/qmM+FwG/aZ3lnUrsk1HyvYeZSG13dAUGYhRI7zeQIGRzDBiU7NtLskWqQbagvvvw5E/WC7LGhsJiiVy6A2qAUJXy8X0Loxm71KG+CABxJXkTMx1jBFXSaQwO67a32OMX/0N0f4ZCBim6LA7Ssg05VOfhgJT0A06GwfDm3lfAS8NsTPDAGxc45K/LOMvRFbzviv18mUFmcn48NH9L99OAWOQPT4noFcTtpoJFEdHiUJT94b8zGtSj5T7xH34pTBpnAzaIWJq43d9rzEvKXVJcxOI/rl+AoHImbrCb/6ry8s= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(376014)(36860700013)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2025 11:25:58.2056 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8ecd709e-2c0d-4faf-f84e-08dd45d7dcea X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF00017090.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6948 Scope based guard/cleanup macros should not be used together with goto labels. Hence, remove the goto label. Fixes: 6c093d5a5b73 ("cpufreq/amd-pstate: convert mutex use to guard()") Signed-off-by: Dhananjay Ugwekar Reviewed-by: Mario Limonciello --- drivers/cpufreq/amd-pstate.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 7120f035c0be..b163c1699821 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -838,8 +838,10 @@ static void amd_pstate_update_limits(unsigned int cpu) guard(mutex)(&amd_pstate_driver_lock); ret = amd_get_highest_perf(cpu, &cur_high); - if (ret) - goto free_cpufreq_put; + if (ret) { + cpufreq_cpu_put(policy); + return; + } prev_high = READ_ONCE(cpudata->prefcore_ranking); highest_perf_changed = (prev_high != cur_high); @@ -849,8 +851,6 @@ static void amd_pstate_update_limits(unsigned int cpu) if (cur_high < CPPC_MAX_PERF) sched_set_itmt_core_prio((int)cur_high, cpu); } - -free_cpufreq_put: cpufreq_cpu_put(policy); if (!highest_perf_changed) From patchwork Wed Feb 5 11:25:13 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dhananjay Ugwekar X-Patchwork-Id: 13960856 X-Patchwork-Delegate: mario.limonciello@amd.com Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2080.outbound.protection.outlook.com [40.107.220.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4102E22A7E2; Wed, 5 Feb 2025 11:26:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.220.80 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738754778; cv=fail; b=TtRbKwCyp0z17MDJ63E1kpjJjYqSbRrJoKISkI1dkva4i4nEf5y+WOWOUObhRQ9ahS2CsGHaTHr3J3CHQqrOmYv+MUBS/K+kpjExjS3n8/w06H7cPhGyCdNbA+XqTMT8ltnVU5JqFqpTLVXu2IpVY2RqC7Kzbpt+Xtgy9UBr2no= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738754778; c=relaxed/simple; bh=Zq+/71yuVcbamiK9LkxwwMkSWmGhw5e65X+kl09Z5fE=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Yz5CPSA/sZeICuj1yIhwOZZ99/2N+iUWj8JOR6au4X5MUP/Tf994tmhdnhZGd/VFGtqEhEUdCk/Sp6DfFJE14gfSI5FQBGa/vKfTdDdzBVueuaiUQZTBc7o4wuCMLG16MnjKtRToFlIt7cz2aEuWMEn6Y7hWSsYy17zswMFBv9Q= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=kymYXuB0; arc=fail smtp.client-ip=40.107.220.80 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="kymYXuB0" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=aPaK15SdZh6SIAtF4PWDc1yy+I6UEpl5d/J4thsIkOcByGwSwMXVJt+eXVVwxYCRrFIhsNKmmxwZb73nDqt4SumUgQbrtL7DfdTh2vzcx3+UsO5wQJlpx6OT293fFrClkWMDlsIlxL6ZNvT80FmNvT/uJLrkG15UNO6FbEuS859RmisumxYs0DebJROmpIxC7Vpo0J8Uomdr/o5o2wuZkttyR+l7TFpdNMDijbkajGEbOAa6wCCffbBTbyqAe0Dq+jAU1NfxRQWsbFw3vQcEfd1yVrYGymPUNnGOD/IqwERJhAFG8hvXJfie0xGvkJleLTM/smlY9ugPzAWMWms/1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4BOUKHVGDBdqFEEzNre8oa57Ye3jTp/HT3aKOwOKUNI=; b=n2satsLAIL6MkHifLTW3GI+GBTGH910vinoGM0CrFBXCJA4vIFWg44VVjJomcWvMxm/ptqrDQDZbnTs/xkgcNfMsY8yEUE/UKem0QkCu302Yd5TbqNs2az5uWIUJGciWjdg0/BPdelc1g+OakD4V7IW8uIiYKQH3ywfAGGfYTpYmgylexVErhnGeJPMwfEgOti/OQikgofJKyLWyWj5a5AByLXMM4eNcQrjjQ7f6GfiBXEme2z0QaqQ+kiFLbz6xPopVl32UpAZcwknuP/OUMcSkTfNPD1WywmaukTBvJlG5CJt+7O55/WRloZQmvDTf5TI5SVQxHNKkV3hvxmuG2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4BOUKHVGDBdqFEEzNre8oa57Ye3jTp/HT3aKOwOKUNI=; b=kymYXuB0S8yJHkc/OVN+NNkMmF7q2Oiu9ZjDS7QnY2ZfQJaGVBOT95cgaPZZsW8gTEv/exS/m7nUl9UzB8E17nVgbkDIRa7sYILbILu02L6BuxQnNH4xYMaEMocrkqJ5LV3QAlSfwCTuRfXOoIA0vhvAKDvsByXZLhxzPHXzzu8= Received: from DS7PR06CA0027.namprd06.prod.outlook.com (2603:10b6:8:54::6) by SA1PR12MB5670.namprd12.prod.outlook.com (2603:10b6:806:239::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8422.10; Wed, 5 Feb 2025 11:26:14 +0000 Received: from DS1PEPF00017095.namprd03.prod.outlook.com (2603:10b6:8:54:cafe::f7) by DS7PR06CA0027.outlook.office365.com (2603:10b6:8:54::6) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8398.24 via Frontend Transport; Wed, 5 Feb 2025 11:26:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DS1PEPF00017095.mail.protection.outlook.com (10.167.17.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8398.14 via Frontend Transport; Wed, 5 Feb 2025 11:26:14 +0000 Received: from shatadru.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 5 Feb 2025 05:26:10 -0600 From: Dhananjay Ugwekar To: , , , CC: , , "Dhananjay Ugwekar" Subject: [PATCH 02/12] cpufreq/amd-pstate: Fix max_perf updation with schedutil Date: Wed, 5 Feb 2025 11:25:13 +0000 Message-ID: <20250205112523.201101-3-dhananjay.ugwekar@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250205112523.201101-1-dhananjay.ugwekar@amd.com> References: <20250205112523.201101-1-dhananjay.ugwekar@amd.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF00017095:EE_|SA1PR12MB5670:EE_ X-MS-Office365-Filtering-Correlation-Id: c0bda547-32e3-4d74-fe56-08dd45d7e668 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|82310400026|1800799024|376014; X-Microsoft-Antispam-Message-Info: /otw8V/7/itQxq0WKXhEZMy+BflCNPz5nC8XbLESsJhoc70HWa4wyX1BFPXbt4TZ57VspUQTNm5uibtILYAL1Y3jKVIOcxxW+h/aQ789K1XioP6AyeVqSCVkKQCYulhLHFKLMLhMk7YTEB/UWGJZjSuZirK4eSyShrvjNx2DvL2McHUuQtCL94PN7PPyaI3KpDmk6759bX5muWkuFfuecsw1sBClSGkDfGf8eP7J9gh6RK1cCpLz8XHi2zHgEyf7kLEldgMjr0JkNuylq/8e6MCnfkNOLTCjCvjoJC+beqEnqFJ6mpguxAgmPtcHqPV+P+ypd0bTTTsFIXzWmy8+fzfPOsODBKl6hePtzFnIcs2Vx7zQpGYKpnZB8W5gme1XaEgnFeiwhWE71WN0TRfxE6hJmMqs8TPB0BEVEGFFWDiHxq7bqV8LFl4pu3PzWHp4RUsGGsxit04SfnYoPamGkgsmUzfflgroCSZu4tzk1fkqxQNVO6UheopCriWs/3IdmgNiv5HAJy4BUHsfQOz8YyKthX+zWV17yiPgVatGhFOxG0r9nlNo2CDvpX0DSNTmNkEyN/aBYTs3KuMgpgzRvYv5joNzB+mXPsUP8UPfShvfWfunhjGxqRHG0tXwwPUZx4YBrMjdCAr1nTxZzkDzODKL7smBbXe1qx4HmkoJI5V5JL6hddA6yd/8+F7C4xhQ4V5U8VMgX6yh62Hvx9458Bv4xA2dhRhyKga4eaBTkqXp7/HDka5lETCEekbF6jIZJZa/HEppzyf7O7p+iw8WhNLLq6peeGjy6RlR8DpWHxuJLZiibcPWbhEZL/CFSszQaioe3nfiYGhhgQiCMItBIL6lPEc7yWusqucTCsM9u3CU0FsRM/UoYmyF8P5331TkY4f+8I8fe2eKKp42dgINK55Br+/wMt76C/AnMxEU2kNKQ33CM2el1jg/TQ1Zo9xr7zAul8MZj5ApKggM4YKFxbgKooATAAswM7QHJYKNgWfd7IxDLp2bVdwkohbKTcjP4Ely0qGdGnbj0ytk9kUVRtmgMV8f7j3OlVVVGugVpiQqfyujPceFORKkfX3aq8OnkecZTtWwfAp8PgWLbXQ+K2pSNb9w0Iy5tLL4gi4yE8ypALR7nJB+kaXhFHVEyZGfrHY8785g6LEi6SIbLKAflAgTpYmmsuC8l0h244Jaz8RKjZpNd+EXsrSwXvI3ljIkyImiemuuzapM3PiIkkBF64Y6BYPZmq0mDfICqUzo9n8gdMracqcr/PwBlVkyKtxpXClRW2TwNBbZVBI9s6ftL2wa/rfMtN771CyG/18eUkcCznlZEWZRs+NJaiNJDRDnhhFUxIIdhfow67LvtKef+Zq3LMzhn8m7Ljfb4OGzkSCpTufRDLT0eQsT7lT3csejfYmq9RN990tVuHhXjnzaGrw8eNRo97/mAc8O+bC5AkaHyZKjjYmvXTjSkIJdoU+n4ECGcC1B7xY3sG5AOVj3Dg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(82310400026)(1800799024)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2025 11:26:14.0528 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c0bda547-32e3-4d74-fe56-08dd45d7e668 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF00017095.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB5670 In adjust_perf() callback, we are setting the max_perf to highest_perf, as opposed to the correct limit value i.e. max_limit_perf. Fix that. Fixes: 3f7b835fa4d0 ("cpufreq/amd-pstate: Move limit updating code") Signed-off-by: Dhananjay Ugwekar Reviewed-by: Mario Limonciello --- drivers/cpufreq/amd-pstate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index b163c1699821..9dc3933bc326 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -699,7 +699,7 @@ static void amd_pstate_adjust_perf(unsigned int cpu, if (min_perf < lowest_nonlinear_perf) min_perf = lowest_nonlinear_perf; - max_perf = cap_perf; + max_perf = cpudata->max_limit_perf; if (max_perf < min_perf) max_perf = min_perf; From patchwork Wed Feb 5 11:25:14 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dhananjay Ugwekar X-Patchwork-Id: 13960857 X-Patchwork-Delegate: mario.limonciello@amd.com Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2066.outbound.protection.outlook.com [40.107.223.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C345322A4FC; Wed, 5 Feb 2025 11:26:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.223.66 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738754795; cv=fail; b=ghsmHl/7a3Uco40lWk355ft8PW8MsVjbI2XonbL+l11geSYz6zLwe/q2iLuUkJMNCevTZA0LQ2gBgCPuWal6X2qtP7p0sFT97UbCgVedI9QtTKuPtnlhzPGripKwgi+L9oqe1J1KUyWF32E22Cs7/qpB6lpKX5AHkO33Zx0Rwbs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738754795; c=relaxed/simple; bh=ieA1rwEDqKn5DjsSrTtA3BlBh5QPUY1S8LVhu6Ea6II=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=YvjrZKkdxHw2IQ2I3l7qizYRVz2muwHj0iiJq53Gnk6Nby9YeOJetAlGALOx83v6Of0JXCkqtJX8xkOuT+RdxZwPY6hGUJw38pGChkkQSGwlbm+WdaxCnF1m0kCgBDxVB2p/78Q4YSOKseJJWXggiiL9Cs5yW4Y63Y0ivt6L/ls= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=m2rlafo7; arc=fail smtp.client-ip=40.107.223.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="m2rlafo7" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jZ06Fo0aLbqIRV78DLX4W8T40hEWSChEITz3LnoVAkJ0644HhNnN6ifH04Mr3CXRcOZV42u2UfrMv9Bct3WJCmbw+KJNd6wsKFxB3ZTjv/N4moeCjK/5nR154A3Rh9nv5V810vbF/rm+xnc7YC5KHoeYQ5+U/ROa9LKaPS+QkBPm0Ompr2Bw9PF3TyEVzP9knf01s1XAiMfLYXiRUw8FaNR8RtCNpZRv+5THChUOYioRvm/pR85aIQDEM23bCpjObEu5ZnCOEYOTpvt+GWh4Tan3bA/3RYd+xKq+Jb7CagqlNa8UfaV2k+TxmgBFfm4lfzB0SAOVufH6LVPUVinR0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A3DcJNTr0OAKE56hBxicNA2UW3lqbrRszpTinE8WSIU=; b=Y1FVIypDiewhFUQg9yVRb/xK4dVd+UU0oSdpvsoqGRXWKTIiUsn99gay2U3APNLC1vi5d0cxN6xIfIFUlyAgjny1b8Ybl9Y5QK8DlTIYDcidAAPm9xOyNWkeP6JN2xB+OqkCIoZh60Ew4g4f7LG1Rv6/A+fAQpo1Xx9rIXU1dklzqLqFkGbUtkvCVQHKq8h4EvvZKo0WyqTB/pymsCThT2nJTdvKBjfD/nHZhZ25wIDvnn/fhE7EV4Eot/1U760fCN8G9fcVo9pHjdPWzqPqkm10k5H+2eM/zy2R8Erbsiwl4Xx1RF2QQD/307I5RicWspRM9TmU4AgrWAKH/IFefg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A3DcJNTr0OAKE56hBxicNA2UW3lqbrRszpTinE8WSIU=; b=m2rlafo77yoAKmyHLLhFuAqqISoYrXRhjLX4wJfnzpNLONxpbnO6nBIVHmyp8F067gd4Jmp257fuEf28hYYs6M2t99wrnv/vzEjEvt0b7G9/Kg9t6JIl7sDgbRtI7cwhBzLO61MRkAZqwg+82+meD3TNnCYr2D8l4ExkGz1mcE8= Received: from DM6PR03CA0080.namprd03.prod.outlook.com (2603:10b6:5:333::13) by PH7PR12MB5781.namprd12.prod.outlook.com (2603:10b6:510:1d0::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.21; Wed, 5 Feb 2025 11:26:30 +0000 Received: from DS1PEPF00017091.namprd03.prod.outlook.com (2603:10b6:5:333:cafe::7b) by DM6PR03CA0080.outlook.office365.com (2603:10b6:5:333::13) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8398.25 via Frontend Transport; Wed, 5 Feb 2025 11:26:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DS1PEPF00017091.mail.protection.outlook.com (10.167.17.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8398.14 via Frontend Transport; Wed, 5 Feb 2025 11:26:29 +0000 Received: from shatadru.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 5 Feb 2025 05:26:26 -0600 From: Dhananjay Ugwekar To: , , , CC: , , "Dhananjay Ugwekar" Subject: [PATCH 03/12] cpufreq/amd-pstate: Modify the min_perf calculation in adjust_perf callback Date: Wed, 5 Feb 2025 11:25:14 +0000 Message-ID: <20250205112523.201101-4-dhananjay.ugwekar@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250205112523.201101-1-dhananjay.ugwekar@amd.com> References: <20250205112523.201101-1-dhananjay.ugwekar@amd.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF00017091:EE_|PH7PR12MB5781:EE_ X-MS-Office365-Filtering-Correlation-Id: c3561a49-ca2e-432d-f09f-08dd45d7efda X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|36860700013|82310400026; X-Microsoft-Antispam-Message-Info: eyMJdoQ2nQ/Ri3pREdSTrrwpLnAq8iuNJgYUU5F31OZYQqR2YTWZtmFhQjduifFFg++Vi0Yby6Rh1d1um8s2UgJhLaXPX4qiV5Bk20d/JtUrw5XKV3TGQaRz8y5o3vmDqDSB8t/KoHGTj+I/cItVAWwgWtrM/abMjLLXa+4Ui/5z26g6Lu/8xW4IHXqgWJ3O3KtvQcYsKzK/XfVHkC5oPF+97XnIJ2o6jpeNXkqfbufSSN4d84zI89eRRBm2LwRZ9uKwxzdd9BIszC49gehl6EMbax6mqQWWfVqhkqwYFHCBXTRbnUD9SKdN033tGMAp/aqfrzGy3ubzWlAtTVHVvLXMGG9vPtO8lnS2Sulp4eZUsx66DPat/phECFQM3kd2JO27S1o7h3kJUrQUt6vX2qR9OZSCc76ArLt3bXrTgyIewGUjnD/ZqxS1jv9rNlQjLz47Mfl06YyPZqXA5ADpnhsv1LP4YjzhUwD+KCSnWTnqQN3kL6rceMnToVaHQasJErT75hA4kmCgDSD0HCQlXpQBMbuCavADKdwOvvhsvzDbKnOxd40SXEyOMXr7FZiD2FY374HsnaJQaWrmjmPIdWp9Imurd6/UBbVeJD4uV8kr+EbI2HKXjRy4BXSO6GGy0zmJr8wXusL8oRmfK8jgPmwB2Ax8Hp2uiourJQQN5pu2x2a6BHJQUDBmskYjwfacbeUNDyi0apW1xmW1URbdFNOhlvnDGh+i//9owebZPQxFuQgucRkk6f468hYkUxBFZLiXu3VW6VFHKgD+6eeTldZxAgF+ecljMfw1PoWat3/RGjQkM4FwZ/UYlxBzBE8PJxMFaV4wBHb816LcDorvh2rnxcLzuNSQZ0Vr5+sUKlKA4+SFPVGM8v8IL3FpA84pjKk3RduPo80TlKPa7ME3oWVtFf13U+aM5s87rOc+cuTYB2Xe//fftZQABMDkIduTEkMqUDPrvseauYaWFj9T1dq4s1cK+VcwI8SWb0NunZ1sds7MNM87FVQccXR0g+KQMdCLJP7VMHx4oMjlrXrRIBGEpqh/1m4lnpuUY5y2Zowil9448U85y0HPo3ulh+kT249nd3EiLrRwQqQoEgK+qN7bxQP9bJUIAGc0sB8DSTaEnA1cKtpUZLsmAOCs3aupz4Ptjl85qruayKGZTC8CGl5mBTe/9kWpUX4Qsc+jYhOI2v83M/6EGhHxpieb5fNvUNfJrSsuzA42KrQ9Pg+qko44L7QxH5s96gnbpMtE2YGgo+3M1h+Dwf9FgP/CvCptrA9WegaPDkgjnN60Is7fd4+U/CckXMg3d/dmbEIysTLvjfslFlk4qEwsR6HieUd7CVaiBIfb3d7WDP5gf71D3uqQ9y/pF04HyRG9Va4+tkopP9bRmLfOFlP90i11gQ8adHEsSnQ6e8k5W/x37e6pEKeLVFMEpwJr39QGksQXRD7sphmGHz9q9TzEUpA0RcwK6WWEmQzBXDUn+jOqjFLFr0jt8bhmVgL+Yh4r118y6F0= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(376014)(36860700013)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2025 11:26:29.9772 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c3561a49-ca2e-432d-f09f-08dd45d7efda X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF00017091.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5781 Instead of setting a fixed floor at lowest_nonlinear_perf, use the min_limit_perf value, so that it gives the user the freedom to lower the floor further. There are two minimum frequency/perf limits that we need to consider in the adjust_perf callback. One provided by schedutil i.e. the sg_cpu->bw_min value passed in _min_perf arg, another is the effective value of min_freq_qos request that is updated in cpudata->min_limit_perf. Modify the code to use the bigger of these two values. Signed-off-by: Dhananjay Ugwekar Reviewed-by: Mario Limonciello --- drivers/cpufreq/amd-pstate.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 9dc3933bc326..a23fb78a442b 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -672,7 +672,7 @@ static void amd_pstate_adjust_perf(unsigned int cpu, unsigned long capacity) { unsigned long max_perf, min_perf, des_perf, - cap_perf, lowest_nonlinear_perf; + cap_perf, min_limit_perf; struct cpufreq_policy *policy = cpufreq_cpu_get(cpu); struct amd_cpudata *cpudata; @@ -684,20 +684,20 @@ static void amd_pstate_adjust_perf(unsigned int cpu, if (policy->min != cpudata->min_limit_freq || policy->max != cpudata->max_limit_freq) amd_pstate_update_min_max_limit(policy); - cap_perf = READ_ONCE(cpudata->highest_perf); - lowest_nonlinear_perf = READ_ONCE(cpudata->lowest_nonlinear_perf); + min_limit_perf = READ_ONCE(cpudata->min_limit_perf); des_perf = cap_perf; if (target_perf < capacity) des_perf = DIV_ROUND_UP(cap_perf * target_perf, capacity); - min_perf = READ_ONCE(cpudata->lowest_perf); if (_min_perf < capacity) min_perf = DIV_ROUND_UP(cap_perf * _min_perf, capacity); + else + min_perf = cap_perf; - if (min_perf < lowest_nonlinear_perf) - min_perf = lowest_nonlinear_perf; + if (min_perf < min_limit_perf) + min_perf = min_limit_perf; max_perf = cpudata->max_limit_perf; if (max_perf < min_perf) From patchwork Wed Feb 5 11:25:15 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dhananjay Ugwekar X-Patchwork-Id: 13960858 X-Patchwork-Delegate: mario.limonciello@amd.com Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2088.outbound.protection.outlook.com [40.107.93.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73C9215198E; Wed, 5 Feb 2025 11:26:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.93.88 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738754810; cv=fail; b=HOtVycsLZdoWAcjLG8G1VV3HJaiQlLgJ5FVqZCH4Xib3pESYeTXIojcEMz4tilHrIOqebU3p+cO7oH3S4R0rQ/1ZgdL+xOSd7QKQk5UhJ7RkewOBy+W4XFmfhWn+C+HNfE0D7fHk01yFCpH1qhrM2idKzgWL3CK67vr1WD5AY2Y= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738754810; c=relaxed/simple; bh=i/UhMLPmCacK3mB3v0BhslvvqNKno8mc3Ai5KE4xqCI=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=j/MLFAIpXK6S3f4Vuugi2EZyJcZoh0bm3a6IqdIlDQL8ZxIlkkYiGHEUI8rB1oJNf3yId6dNM9NoV5O/PuqbjEt0URFnI8NVVWzYZJ9+oIfx9dwBVjGWZcup/i7ZjTmw7fPe9Ec8mXbmUNg4HO9AoCEveOALX/eXyVALehDsU9w= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=o/3BYcPx; arc=fail smtp.client-ip=40.107.93.88 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="o/3BYcPx" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=p0fh+tKfPOqTpPU1LRsuunsjCCO1nZAbUaelewz/OdhJXo5oQSaKQz35685Mc+kZ1++thRx4X5a0XnVIOAiyAtVlAUP/ik+JjopXFUHYtVXv8ixjZiBdE2TYJ8PvP/do3U/N3kuUVe5lPf4Xyp7t2ms/3lvyF8s0X/Zq4BtC455mpNFFp7SayRAu4A21ozvJGxZN6wSShB+dE25lHTlHS7Hc1g8zRLuxMfdUcJRewT/5HAGQZPJQ/CtHcwC2IiTrl0ShdlwqBQ6BchoFLyYiKma65RCubcxRGLH0mkc/IyakwTbaguS4CyZmYUt9mANMoKQ4ZE64eECcR4TKmY0jxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Kh6P0DUicvv/5Zr6R5mg0S7MRkYRxjIi4MYblxmUzNs=; b=v5p98NUWYVc0RCDciHxIm7sBX4nY1DvE5nW5XRWzWaek+gcYPjRlMUexb5FBWJtmOx3SM3idhXhH+RZFOc969BMtAh+/raUWU+6bGn3KTeVAYbyjDfjM3OO0A2JrYS5rEtkUUwSi3nMluBw8p9H9XAxZobrxx2XAZUbL0pCpQ1SPTVXX7BLTihPBnJj03l9wAhlxGjCJbA1VpUakfA5PLL3GGJ8VJpAANV/bH1kJTvtx35Q5RABT532SKtqcpCauqBJ3FOH/8CRN1T1DwpGlacmI2cV2xi9qyyo+tidT6ieqLCdk378D1i/YziixolG1Ju/c4bjh8zJPlCdcMcR9nA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Kh6P0DUicvv/5Zr6R5mg0S7MRkYRxjIi4MYblxmUzNs=; b=o/3BYcPxaw1Ud2I7MYBzIJ6sbSdn4d4BTUVhuqKV3HdqpMn8CpzlHPuxWz8oWnYbXdvk9vlW9Gt9dyge1JbDnp7Y8LZtic5UFgMzpONqbAXSvv0jsS87vSGtwthWPU3rFR8cBbmjYkz1H6iRuOrwkI45tursA/lwGODMLYCguIU= Received: from DS7PR03CA0214.namprd03.prod.outlook.com (2603:10b6:5:3ba::9) by CH3PR12MB9080.namprd12.prod.outlook.com (2603:10b6:610:1a7::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8422.11; Wed, 5 Feb 2025 11:26:46 +0000 Received: from DS1PEPF00017090.namprd03.prod.outlook.com (2603:10b6:5:3ba:cafe::6b) by DS7PR03CA0214.outlook.office365.com (2603:10b6:5:3ba::9) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8398.27 via Frontend Transport; Wed, 5 Feb 2025 11:26:46 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DS1PEPF00017090.mail.protection.outlook.com (10.167.17.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8398.14 via Frontend Transport; Wed, 5 Feb 2025 11:26:45 +0000 Received: from shatadru.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 5 Feb 2025 05:26:42 -0600 From: Dhananjay Ugwekar To: , , , CC: , , "Dhananjay Ugwekar" Subject: [PATCH 04/12] cpufreq/amd-pstate: Remove the redundant des_perf clamping in adjust_perf Date: Wed, 5 Feb 2025 11:25:15 +0000 Message-ID: <20250205112523.201101-5-dhananjay.ugwekar@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250205112523.201101-1-dhananjay.ugwekar@amd.com> References: <20250205112523.201101-1-dhananjay.ugwekar@amd.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF00017090:EE_|CH3PR12MB9080:EE_ X-MS-Office365-Filtering-Correlation-Id: 501ad802-3e11-4836-1d34-08dd45d7f955 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|36860700013|82310400026|1800799024; X-Microsoft-Antispam-Message-Info: 4qip58V+jH/Sje0cqLI89MmlnOK+FqlTy9v/26TK3cnY5QtZ5uhvESjOAmjiKNT6aqJU+VnRI3HYbxwMC00C5oyvB9Zn0RZv4N193OQdBJV+BGIEZseZxu7+1hkoJB8Oyw0iiXgzsoygKF4eNAXmxIvgFq2/QoD1KEAYXSOc+DextG+806/L89h5avEwhsMZqHp/7CZ8o8913SzDyHfxZWKvdYHTX03iVcK+W6CPeayhaXb4ynFEhtOhT7OBTuWytyAznGXeeC3ck8tpNU4Da3eiWcRRgAolGcfCzIkeZYdHFvheDzDK8m87ub11Cj+QFZ+7ozczJAcTMeLnvCykaa8XUhQr3VDoiVpwdFwdT/0b0O6FvTT6wCXhQC/gn5IVMJQQPtuRS25So7ZAtIwnsZzDpU6E+wcCI8yq0woXzAHXnyqeFSOMZFvQwhmNnHgsmxfc+1yjslnApxYWExtLn7LF1yvBpRbc8KyHhSSNyqnz02B3jlAz/pRMgRsm63mdJo+KlsEB5e+Eb2MjJ6WmrZTXz6n2CC0drApUdE0xzb9nbb5t9Rm4XzShwtKMa1vJKZrD9Kv+rE8AeNQgyP6UFMHhvwVPiK2Wd+ULAJcNvomxR/yVhwI0AW6JNyyKFvTPGOyFyLvokfZRW7R7Yx1T7PrjSrJbQmnvDu6HdfHtYqdYAYN6fSGmLRh9rJ4ChJmMJc3BjgAboKjXWxip/SYm7EO3mS8sgsz1NIJ+uMLM75/qtLcJh/Qkxi7i5jM1CabqihxuVUnfPd5NjEmvfPu+Nl5NOIKt7fkYTuXFPQxzXIzQjsVcMzuxDSPO9nC2gs9qJ3g2aVTMzYfC5LrzqFwk0uH+kKecWujFGyKdnYEdj3iohtNhxz7BnaVtscRavmB2s7zBJgzjytrHoojMYhU9YUyKKh5UK/X0fu9vFVUEM0bHpBepjxk4XeWZP9FJS+LjrSng40IOb/n++av5nDL7TzoDij9rUzCMQgOF6/1dXkyMPIrvf0Eo3464gVbREYCEobBs9gxAUwd1JQRkAgzXOLLGYvrXobpJGC61JwhA0XWKYXJjNjplgIPq0OdETIJAEtUET8GPFqzi4NhIdbBjXG8FaPgjxoQtMNjnyrK3wP1XIruTdPCrpwRo0+b2mVv0pFJywCIQGRiGIyGiZGD7vypR1H/+tn8pCooCkEs+fv7VJWC9XvNw5AAxnImG45lA8S9xgjCnRPoeUPY8mtMBvFLUfZiXp5VNlQfIQwsVb7/KEJyPR/rX33U2OxRfMuV3R0UPkcN/f1P/QxpT+eWztpS6Dt8pyCNPU8SZQEg383p1r8SYkWHkzeEmn2FWUQAEwmQwF9CQUKk/DGeUuhTYrJ2xKd7CbFh7PDsG9zHrAV7WUhJ7ICQZW4hy5OXLqpyRkRulsrw3gdi9fnbhCI3uHVRlQFqwKFY8vdnqkhIGG96ov8Yb/t6nXTd/b/qxiZ8Kv2i8nSxlKLZZYLF53/1BFIhjkBAkhf/ewfT+PBPWl74= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(36860700013)(82310400026)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2025 11:26:45.8774 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 501ad802-3e11-4836-1d34-08dd45d7f955 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF00017090.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB9080 des_perf is later on clamped between min_perf and max_perf in amd_pstate_update. So, remove the redundant clamping from amd_pstate_adjust_perf. Signed-off-by: Dhananjay Ugwekar Reviewed-by: Mario Limonciello --- drivers/cpufreq/amd-pstate.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index a23fb78a442b..2926f292be7b 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -703,8 +703,6 @@ static void amd_pstate_adjust_perf(unsigned int cpu, if (max_perf < min_perf) max_perf = min_perf; - des_perf = clamp_t(unsigned long, des_perf, min_perf, max_perf); - amd_pstate_update(cpudata, min_perf, des_perf, max_perf, true, policy->governor->flags); cpufreq_cpu_put(policy); From patchwork Wed Feb 5 11:25:16 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dhananjay Ugwekar X-Patchwork-Id: 13960859 X-Patchwork-Delegate: mario.limonciello@amd.com Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2088.outbound.protection.outlook.com [40.107.102.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27D0F22B5A8; Wed, 5 Feb 2025 11:27:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.102.88 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738754827; cv=fail; b=qa6Wlbzg1jwcAM/XbzXj74/O/xXieQ46KJJx2UySqUfgUhl7pSsxAoVJytq/hGQ09AO0rphxARvQT1Zq5l0lGI84pu/ARDtaKSy5dAaomPn5C6o98nVEq4zU5oJB9RqQlRhnoELdpUhSca7TpxVTW3N4sGbCpA1QQLJzay+/fwA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738754827; c=relaxed/simple; bh=wTSF5fgVXfC5kUHdv8A8W78sCv0giz+4dvZn8DNUpI4=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=oo51lqKjfbnCS0RlyJ3GF2W3go3hmPbE6selm9Zwf8/+ldZWUxLTYEBAZJdhaPajpWTDWckEX4ahLBme2mJHZ80QZnsiIYPElvHrPsz7UqMhPgHyPrS4Mxbiig8Tz6CKyXXn39ffcphnO1XAv7+6ud7LRXFpr9K3gYLlya0NKVE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=EiovUN2u; arc=fail smtp.client-ip=40.107.102.88 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="EiovUN2u" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mT/ktPVkHfJ287/G5kvkB2xLxHxT7GSL/mTE9Qx8/u+Q9+qyJpQu63wIB7raqm1WmTM59FuhAYTIvrHNQoL7GyEFxfvuNqq42koqmBqvHgvaXG2R3OfqZnGcxmXpUNf55XNHAGhXvMCh5a3tPqSE9XqQva9T78f73acEyntPMDh5zqM/Y7LgRvfcZ0T6bMyRvlcq5BiqEhFiNm+7T0ou5H2n0t9WOZFyW/k/HkbnHKpKr7SlWy7Z8OVaqnp1S3p2MTGhF0WAym7wvGrXZLPayBN1F5MaYj4rA/+cGubtc7TcMbKDR2rXRlOA+LlW1t5tmsF1NI8FlT9vtCzPbxMiaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LrktLn/e5uykyLGC0LERBYvAn34f/WvResqCWM43ZG8=; b=TeOTzIj4LXS0m9au11T/MDPTqnSmc5CkqIhoatMPboM3wdwaIeeXSksAXxsj9Ih6bzd+Pl+r0uKKjPvffZ6IYE1zspzrPOylREp2kIDIy7yfh29GU3lZK3FZOJDnlzlX8WNF6AU3djGmne1HUdgf9wIh0XwAWbqQQo8UHs3DPJ1V5QvJDyDe0+tfkn49/D6Vi/bZaUfiMgAEAhNaP103re6MSes1wHjuDqhTJgt35dptn+d24Klc2O0ZY2wpxekTzHGjd0uRrcbzqACLL1oM3QWCHmEbDSF28ICR1jQXzFv/6Es8Kp/qNPifhgVXzOIpIbIBgJMwjO7bZF4iKvpOmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LrktLn/e5uykyLGC0LERBYvAn34f/WvResqCWM43ZG8=; b=EiovUN2uKDAdxRbGKz6w9kOaPUn8rPVGcCZe6P+xvKYwb59Ir+bz3+A0jOWEbiZiilqeQvXd1VzMhoO7uLbIy370JJ/a3f9tjS0iPdXMyuLG/vrwyO1fzJOOq6tXYuIggtZQR6Zk2S9WJa7rpeng6/vBJP4bxnG/dm0fixhiwGM= Received: from DM6PR21CA0018.namprd21.prod.outlook.com (2603:10b6:5:174::28) by PH7PR12MB8425.namprd12.prod.outlook.com (2603:10b6:510:240::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8422.10; Wed, 5 Feb 2025 11:27:02 +0000 Received: from DS1PEPF00017093.namprd03.prod.outlook.com (2603:10b6:5:174:cafe::95) by DM6PR21CA0018.outlook.office365.com (2603:10b6:5:174::28) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8445.6 via Frontend Transport; Wed, 5 Feb 2025 11:27:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DS1PEPF00017093.mail.protection.outlook.com (10.167.17.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8398.14 via Frontend Transport; Wed, 5 Feb 2025 11:27:02 +0000 Received: from shatadru.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 5 Feb 2025 05:26:58 -0600 From: Dhananjay Ugwekar To: , , , CC: , , "Dhananjay Ugwekar" Subject: [PATCH 05/12] cpufreq/amd-pstate: Pass min/max_limit_perf as min/max_perf to amd_pstate_update Date: Wed, 5 Feb 2025 11:25:16 +0000 Message-ID: <20250205112523.201101-6-dhananjay.ugwekar@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250205112523.201101-1-dhananjay.ugwekar@amd.com> References: <20250205112523.201101-1-dhananjay.ugwekar@amd.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF00017093:EE_|PH7PR12MB8425:EE_ X-MS-Office365-Filtering-Correlation-Id: d2fb39db-6cfe-428f-1f8c-08dd45d80307 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|82310400026|1800799024|376014; X-Microsoft-Antispam-Message-Info: 7qJaaPwTwPkNxb1ICQPT1Nwr1Lg5KTptOYOCa/kMlXeQ4/yLWcuR4PVRkSDyF2zkX7aKzZIzpddCAmYT3kmfKTNpPIgYWJOXJ5afN/tg5cY9V1KP/5PTlaZGBJhvWwkgdH5bQfYCCiv/MLYdt9ZZO2fmA3WBgTsj7jbRNyLQmn/Ut701U/CgyOzzhiW3W0mCWaRX0FqetPED61las6uXxJK7TiPnVjQoXRRh/TjDm3OWeN91ghZnmv6+keU/fJOQjgXIWnrVo75gFDGU00XgjtOKARmj4IUO6SXY606sA5AF2x66jrBAkQB/FYOSFbvE9Fw15LOP9O3vIgRtV+00eGIlF1E4X4dFcyaLU7raR07ChW2E0cXE2fHUJJFV+WPnC/MsB6BnVc1VRlSKknYnJeZHGfNb63X1mlxR4e6wgq8NyDHj3NjWZWAuj/5mDiCbLTr39sgv304EQ+VIB+paLoj8325NrWfHF7iLi75bxlZejxvjYjq2uCcXnMrh0Kqn7Bj0LAeqL/M/PerjIU4EFcNs8zhn4PxZT0SUu5uCb+UXIAiHJG0zowpRjnxQaPx2UzRp1oCjgMvO+Wt7NsI8L9+cXU/ufGHszMI3nVrTl7aLFPDwMVriOGzLb7BoRaAX78j1xmJn1dlY3Y7BH7rJMdJW2Q1w7GVp2CacrNnwKw0ot4DwAe62ZfeXVj03xN0kg0m8RBtml0pPo5Q0WhECyArO82jV6SlpH3xuOQAfSCxdNnp6IuTaBpMkVb7rl0zQbwS/dQv//gPp7ItA5OvJLqrgtxs42Yg3M+j8VuChYI81xo7chnew1CJTDx9vvUlow3EkuYW0BFJt3DVWSq64aP7G/yv1TNi8zZO5Sc37Cxmk28Muuw4yYADxhJWGSB4Z2E1SI0Jl+aVJula2jD/svIPZCnQPYe9phEI1TBAmQexGPFOZjag4gPRsgqpScQmojbqtafcWpc/8rItKg8mfhs5ITm8KOH5g964YEdBZ2mbKA4p7xckds4X0vCOaLEM9o9EkAx1Wt6DOmRyOrURrri3lm8qBe/u0aqw/rS9FOTAd9dskh9+opJypfZb0jxJaLcPVooxZwvL8DyfCPBcOMuUv7jCahSV09whQBY9RiBA3jJcRbgalkDLF3QUD3WDWrDijATybVAjiNM0mMYt20ftZ81AsjHkF0nRERjnNeXyVeZO0SibDGdI+thWf9twsac9041OxIipQhfeF7GAXhrhbzrw9Lu1ED5K5AgtcZ+l4zbGXOJjaysE7E/BroT87+1guIlu9C2Xxhodu0Qxi+7WEj3DvYi9dDgxhfzXvHwAMsE5P9eat2AeEhLxbLXtxjM6+nCj81U2WQDKlAgZZ4TZthZ5rsgjkBT5D8yyoI4f4yVUseMt5tweZAWOKVoms4/Xwa8vCcYJImSc4OGSbSstcjVwEnGDSpR4dSH7psdsrsqPZYgShj/tJkOwBJiOYyDhsGNJdaaUvSNifon9drWYYqF/uGd3OV+F2ovQbvJ4= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(82310400026)(1800799024)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2025 11:27:02.1435 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d2fb39db-6cfe-428f-1f8c-08dd45d80307 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF00017093.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB8425 Currently, amd_pstate_update_freq passes the hardware perf limits as min/max_perf to amd_pstate_update, which eventually gets programmed into the min/max_perf fields of the CPPC_REQ register. Instead pass the effective perf limits i.e. min/max_limit_perf values to amd_pstate_update as min/max_perf. Signed-off-by: Dhananjay Ugwekar Reviewed-by: Mario Limonciello --- drivers/cpufreq/amd-pstate.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 2926f292be7b..e179e929b941 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -615,7 +615,7 @@ static int amd_pstate_update_freq(struct cpufreq_policy *policy, { struct cpufreq_freqs freqs; struct amd_cpudata *cpudata = policy->driver_data; - unsigned long max_perf, min_perf, des_perf, cap_perf; + unsigned long des_perf, cap_perf; if (!cpudata->max_freq) return -ENODEV; @@ -624,8 +624,6 @@ static int amd_pstate_update_freq(struct cpufreq_policy *policy, amd_pstate_update_min_max_limit(policy); cap_perf = READ_ONCE(cpudata->highest_perf); - min_perf = READ_ONCE(cpudata->lowest_perf); - max_perf = cap_perf; freqs.old = policy->cur; freqs.new = target_freq; @@ -642,8 +640,9 @@ static int amd_pstate_update_freq(struct cpufreq_policy *policy, if (!fast_switch) cpufreq_freq_transition_begin(policy, &freqs); - amd_pstate_update(cpudata, min_perf, des_perf, - max_perf, fast_switch, policy->governor->flags); + amd_pstate_update(cpudata, cpudata->min_limit_perf, des_perf, + cpudata->max_limit_perf, fast_switch, + policy->governor->flags); if (!fast_switch) cpufreq_freq_transition_end(policy, &freqs, false); From patchwork Wed Feb 5 11:25:17 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dhananjay Ugwekar X-Patchwork-Id: 13960860 X-Patchwork-Delegate: mario.limonciello@amd.com Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2064.outbound.protection.outlook.com [40.107.243.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C75FC21A458; Wed, 5 Feb 2025 11:27:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.243.64 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738754844; cv=fail; b=pugAjtzo2B6DnfkakURRNIF9B6elg6GrHqOw6Ki15eoCxbveXnykGPGnEY76mJsMnVhmYt7W9oNJskKZqi8eW5YkYkMR0ppgubLuoCT5fz3tcOOmpY/wg39sWAmec+rdbqFbqSDgLtfyNJf7xrcUcmTEXaG5IOHPMAZ7k1yp8uY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738754844; c=relaxed/simple; bh=y+MOtjjTpfpQYXxgiwVoYC4Sdd7MynVs/6Oxser0eko=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ZZTdFvZgXw5hpkMk6FoHPmjNGpUwUoRTOKO8ZWlTyuGy3SqkrsTD4I+YRYQ2Ibx23ZvywJB9SQEptlZ1a4z40sRXoIjp2ALBVF2uw2EaIGsSDh3caExCQqD+rL2kSXRsx7BatVCDvEPjOJLB9l3Qp8nCfSW9rrhRm8HszIbd5bs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=zkuvH3Fv; arc=fail smtp.client-ip=40.107.243.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="zkuvH3Fv" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=j7uKJ4Aj3ehJglHfu0RqQmWBtSkPgvplm27wTH8nSKLJR81QD15oUgzSNRzl9EtqGC69CiPXub3GPpWOPajvM8LD/Bmr+eWOZRD+sT1NEauvHZOiM2BF3Ze6kxPYdGuIYKexg64x7YrMsQ9mbxor+Jj7h/KRVykgLlWsSZLxmkeDr8B2IpfCiYFgIhZHXfATy384WaYOZpa3RBY+uYkTnGKKp+jCcfSYIpvWkn9UYsvnHVueYhy5wNwAzrZ4K69fCBbnX49zviGHYTdLBtvg96EeDolb8g/uF/b9juNjINelp3030PZL5B/fPqKbg9wbteOuh6zHAh8mzMS+T8KfRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7lqkVVEs/Ut6W3XzgYIsBtKtuuBsg9KLDgTvPMUR7f4=; b=yvdlsyvrnP29px8u1rOKVwRDlWS5gbJTyvK+sT+HGcRd97LxWqD8oBaPH3PjvpakOM0yeeIDhoKqVWHZVmk3HNt6xC9Gq6fQEDRpfM3W8RaWd2EQm8J6WqbXdYy641XoIqQOrUZ43WdbKqUUOq9ylz3cwWTRhIgBGMxUm6Gm+WUo1+JDgh+IOYoPDLT6DAgVn8brqZw5igpbHCZ1rPqXR4gYIxVDqwrvUFGhzsL2XJJYrIEX1U858sPSE4s9DNbthaZ8N7W3YEYjH8HjayDFEY3lGdxLpBcyazjXl3zeOgxU1n1f8FYdUtXNIUcQUJmoM7NZW5STyPeZC8KjqJ3PLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7lqkVVEs/Ut6W3XzgYIsBtKtuuBsg9KLDgTvPMUR7f4=; b=zkuvH3FvHA4mbqvTbb8x8fl6O7pLYZLm2QLSXg1OHm3+xNUTntnXaOuLnmvM76aU+aFF0K2jEwna6w2tPrnxwDgupIUiAanQZJbHfQlurOZGcGIh8DI3z6GW9mnYNmRfk+sFXu6mjqwBszZeL0U0/o8MINiOhBW+pauAcyUKtIY= Received: from DS7PR03CA0228.namprd03.prod.outlook.com (2603:10b6:5:3ba::23) by MW6PR12MB8958.namprd12.prod.outlook.com (2603:10b6:303:240::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.24; Wed, 5 Feb 2025 11:27:17 +0000 Received: from DS1PEPF00017090.namprd03.prod.outlook.com (2603:10b6:5:3ba:cafe::fb) by DS7PR03CA0228.outlook.office365.com (2603:10b6:5:3ba::23) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8398.25 via Frontend Transport; Wed, 5 Feb 2025 11:27:17 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DS1PEPF00017090.mail.protection.outlook.com (10.167.17.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8398.14 via Frontend Transport; Wed, 5 Feb 2025 11:27:17 +0000 Received: from shatadru.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 5 Feb 2025 05:27:14 -0600 From: Dhananjay Ugwekar To: , , , CC: , , "Dhananjay Ugwekar" Subject: [PATCH 06/12] cpufreq/amd-pstate: Convert all perf values to u8 Date: Wed, 5 Feb 2025 11:25:17 +0000 Message-ID: <20250205112523.201101-7-dhananjay.ugwekar@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250205112523.201101-1-dhananjay.ugwekar@amd.com> References: <20250205112523.201101-1-dhananjay.ugwekar@amd.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF00017090:EE_|MW6PR12MB8958:EE_ X-MS-Office365-Filtering-Correlation-Id: b12df71e-724d-4624-1623-08dd45d80c31 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|376014|36860700013; X-Microsoft-Antispam-Message-Info: Us6p8TkG1O6RRRs3A05dOoYonIYsDHpUpoxLEh/obvneRxoASgbGa+heueJ2ejJs+84qIDV2TJdofeNxnmNSOU7LybPQz95/P66c0TAu5ZIFhGlVvG4qmoAXVebmziHpyf8DbJlSFlvh/d9xD3heINWyihgSZ6YmA3OVkcNm8beabZhmjTKG5zKN/JYb7IuPTPf+cn5iRotiJaeLwOvbGcLkyOKftrs4hxAp9LaSxA0tnxySc7uf6iqtbBL0iMoujwSzf6qgaLq+YcpsmfGpSCxR/FGS8dxtXlrT1zcFr3TYJ2w6mt8NYqx38xhPkJj8Djmd1A/43nDzk71QeAmV7qzbf9PkBhCoii6TpVwlYkdSblvIegZP3/bb+g8xZLHvEh7n2etY6H2rZOK03kPKY8zb6e9ThDL283Iqve5xt00xnnkMXuFm79cwsVgTiBuEdRXamW7ARtiEzGq8kmmjzByCitGWT6XTn8lrsuvAwj1mIfkVAw2UBkJ/gWNl/SWR4ulmz9DXBIfMIV72w9zTdyDDC8U5RkW2Yx3FsfqJtn991gHuAeRMsaTXytkGpi3rSuy1r/f/vcgSAFLlHYzaZRoyWaiwfCjkQnkvIBQ/QiyR2ZiSUoYrxbyDsapz8u23APru5PEw+29a9yxRernE41hlYnWtq2EcRH+38Bz2JPrVaApWVJWbrZSB6fXTgSoivs6bW/PmNE3XIWPLstk0wkNwL82NVLrldStiRBZSbU7JSKXv2dj/DM8yVZmsjvtvGYPixDJI7os3RCA/OaC97Jv+VRl5a2oMZoalXi9YVpBYbChGCJuWraqiWS3SEiaWaEf3pmJ3nhjExtwMBxZo4x5jnuKmrqDIUr4wb6wXnSENOnpSnZq7jDmrRYgGJsYC2P/ArgJon57+tasyXYCas78A5MGiYjZtsTTfo6q2FieeNOu1oOIwtk9oAwCE84R8Z0pD5oTl9aivnc5GSFVvrgC+eXiAxH8o+eUZaN/kR+bZItChVS/HP2Pzv26K339rlXsKFvbTGC05gouYFgaR5y2lxjYjSBazTgI6OFFRlO1dweirhzlClxLuSTnslXxEFeENL6DL2pISZth0qPmnJLQTMu7KE3a6HxdmOK5NsjzUPJSGDGJ8l/OlJaOjpD1ANmcvCWAorkZt44v4xiq5N1K6XaBZtGcZFVlxSqH+J0Y0HPVCgmdNsD9rZJZZQnT8WmLy7m8GtwQDqx2POxLVXtopZhMl5/iUDwDrrajsKHvD0Nh4gdt+E7BnUWCNg7iTJPum/ahKD+7n6ea7JYvOw2w9aQAbERg51jSeF8MjdUodh8YlWkXFxSWRfJlIGSBEdrqLplDWmp1EDWD+Lr0UjZctbVbQ4h7O6DhyyaR4jJiqC9kelTgvcrz7V6aLehrL3/miOt9mpjPCcsuDTbsjIWeFwcW5ncz0RyCo8hjJI6ZpZ0oB8VJi1fy5QpggwpENSUNhB59bDB5dvcMxWujZwqB+LmJn7xwZBjvb2rxNSNc= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(376014)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2025 11:27:17.5180 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b12df71e-724d-4624-1623-08dd45d80c31 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF00017090.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB8958 All perf values are always within 0-255 range, hence convert their datatype to u8 everywhere. Signed-off-by: Dhananjay Ugwekar Reviewed-by: Mario Limonciello --- drivers/cpufreq/amd-pstate-trace.h | 46 +++++++++++------------ drivers/cpufreq/amd-pstate.c | 60 +++++++++++++++--------------- drivers/cpufreq/amd-pstate.h | 18 ++++----- 3 files changed, 62 insertions(+), 62 deletions(-) diff --git a/drivers/cpufreq/amd-pstate-trace.h b/drivers/cpufreq/amd-pstate-trace.h index 8d692415d905..f457d4af2c62 100644 --- a/drivers/cpufreq/amd-pstate-trace.h +++ b/drivers/cpufreq/amd-pstate-trace.h @@ -24,9 +24,9 @@ TRACE_EVENT(amd_pstate_perf, - TP_PROTO(unsigned long min_perf, - unsigned long target_perf, - unsigned long capacity, + TP_PROTO(u8 min_perf, + u8 target_perf, + u8 capacity, u64 freq, u64 mperf, u64 aperf, @@ -47,9 +47,9 @@ TRACE_EVENT(amd_pstate_perf, ), TP_STRUCT__entry( - __field(unsigned long, min_perf) - __field(unsigned long, target_perf) - __field(unsigned long, capacity) + __field(u8, min_perf) + __field(u8, target_perf) + __field(u8, capacity) __field(unsigned long long, freq) __field(unsigned long long, mperf) __field(unsigned long long, aperf) @@ -70,10 +70,10 @@ TRACE_EVENT(amd_pstate_perf, __entry->fast_switch = fast_switch; ), - TP_printk("amd_min_perf=%lu amd_des_perf=%lu amd_max_perf=%lu freq=%llu mperf=%llu aperf=%llu tsc=%llu cpu_id=%u fast_switch=%s", - (unsigned long)__entry->min_perf, - (unsigned long)__entry->target_perf, - (unsigned long)__entry->capacity, + TP_printk("amd_min_perf=%hhu amd_des_perf=%hhu amd_max_perf=%hhu freq=%llu mperf=%llu aperf=%llu tsc=%llu cpu_id=%u fast_switch=%s", + (u8)__entry->min_perf, + (u8)__entry->target_perf, + (u8)__entry->capacity, (unsigned long long)__entry->freq, (unsigned long long)__entry->mperf, (unsigned long long)__entry->aperf, @@ -86,10 +86,10 @@ TRACE_EVENT(amd_pstate_perf, TRACE_EVENT(amd_pstate_epp_perf, TP_PROTO(unsigned int cpu_id, - unsigned int highest_perf, - unsigned int epp, - unsigned int min_perf, - unsigned int max_perf, + u8 highest_perf, + u8 epp, + u8 min_perf, + u8 max_perf, bool boost ), @@ -102,10 +102,10 @@ TRACE_EVENT(amd_pstate_epp_perf, TP_STRUCT__entry( __field(unsigned int, cpu_id) - __field(unsigned int, highest_perf) - __field(unsigned int, epp) - __field(unsigned int, min_perf) - __field(unsigned int, max_perf) + __field(u8, highest_perf) + __field(u8, epp) + __field(u8, min_perf) + __field(u8, max_perf) __field(bool, boost) ), @@ -118,12 +118,12 @@ TRACE_EVENT(amd_pstate_epp_perf, __entry->boost = boost; ), - TP_printk("cpu%u: [%u<->%u]/%u, epp=%u, boost=%u", + TP_printk("cpu%u: [%hhu<->%hhu]/%hhu, epp=%hhu, boost=%u", (unsigned int)__entry->cpu_id, - (unsigned int)__entry->min_perf, - (unsigned int)__entry->max_perf, - (unsigned int)__entry->highest_perf, - (unsigned int)__entry->epp, + (u8)__entry->min_perf, + (u8)__entry->max_perf, + (u8)__entry->highest_perf, + (u8)__entry->epp, (bool)__entry->boost ) ); diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index e179e929b941..dd4f23fa2587 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -186,7 +186,7 @@ static inline int get_mode_idx_from_str(const char *str, size_t size) static DEFINE_MUTEX(amd_pstate_limits_lock); static DEFINE_MUTEX(amd_pstate_driver_lock); -static s16 msr_get_epp(struct amd_cpudata *cpudata) +static u8 msr_get_epp(struct amd_cpudata *cpudata) { u64 value; int ret; @@ -207,7 +207,7 @@ static inline s16 amd_pstate_get_epp(struct amd_cpudata *cpudata) return static_call(amd_pstate_get_epp)(cpudata); } -static s16 shmem_get_epp(struct amd_cpudata *cpudata) +static u8 shmem_get_epp(struct amd_cpudata *cpudata) { u64 epp; int ret; @@ -218,11 +218,11 @@ static s16 shmem_get_epp(struct amd_cpudata *cpudata) return ret; } - return (s16)(epp & 0xff); + return FIELD_GET(AMD_CPPC_EPP_PERF_MASK, epp); } -static int msr_update_perf(struct amd_cpudata *cpudata, u32 min_perf, - u32 des_perf, u32 max_perf, u32 epp, bool fast_switch) +static int msr_update_perf(struct amd_cpudata *cpudata, u8 min_perf, + u8 des_perf, u8 max_perf, u8 epp, bool fast_switch) { u64 value, prev; @@ -257,15 +257,15 @@ static int msr_update_perf(struct amd_cpudata *cpudata, u32 min_perf, DEFINE_STATIC_CALL(amd_pstate_update_perf, msr_update_perf); static inline int amd_pstate_update_perf(struct amd_cpudata *cpudata, - u32 min_perf, u32 des_perf, - u32 max_perf, u32 epp, + u8 min_perf, u8 des_perf, + u8 max_perf, u8 epp, bool fast_switch) { return static_call(amd_pstate_update_perf)(cpudata, min_perf, des_perf, max_perf, epp, fast_switch); } -static int msr_set_epp(struct amd_cpudata *cpudata, u32 epp) +static int msr_set_epp(struct amd_cpudata *cpudata, u8 epp) { u64 value, prev; int ret; @@ -292,12 +292,12 @@ static int msr_set_epp(struct amd_cpudata *cpudata, u32 epp) DEFINE_STATIC_CALL(amd_pstate_set_epp, msr_set_epp); -static inline int amd_pstate_set_epp(struct amd_cpudata *cpudata, u32 epp) +static inline int amd_pstate_set_epp(struct amd_cpudata *cpudata, u8 epp) { return static_call(amd_pstate_set_epp)(cpudata, epp); } -static int shmem_set_epp(struct amd_cpudata *cpudata, u32 epp) +static int shmem_set_epp(struct amd_cpudata *cpudata, u8 epp) { int ret; struct cppc_perf_ctrls perf_ctrls; @@ -320,7 +320,7 @@ static int amd_pstate_set_energy_pref_index(struct cpufreq_policy *policy, int pref_index) { struct amd_cpudata *cpudata = policy->driver_data; - int epp; + u8 epp; if (!pref_index) epp = cpudata->epp_default; @@ -479,8 +479,8 @@ static inline int amd_pstate_init_perf(struct amd_cpudata *cpudata) return static_call(amd_pstate_init_perf)(cpudata); } -static int shmem_update_perf(struct amd_cpudata *cpudata, u32 min_perf, - u32 des_perf, u32 max_perf, u32 epp, bool fast_switch) +static int shmem_update_perf(struct amd_cpudata *cpudata, u8 min_perf, + u8 des_perf, u8 max_perf, u8 epp, bool fast_switch) { struct cppc_perf_ctrls perf_ctrls; @@ -531,14 +531,14 @@ static inline bool amd_pstate_sample(struct amd_cpudata *cpudata) return true; } -static void amd_pstate_update(struct amd_cpudata *cpudata, u32 min_perf, - u32 des_perf, u32 max_perf, bool fast_switch, int gov_flags) +static void amd_pstate_update(struct amd_cpudata *cpudata, u8 min_perf, + u8 des_perf, u8 max_perf, bool fast_switch, int gov_flags) { unsigned long max_freq; struct cpufreq_policy *policy = cpufreq_cpu_get(cpudata->cpu); - u32 nominal_perf = READ_ONCE(cpudata->nominal_perf); + u8 nominal_perf = READ_ONCE(cpudata->nominal_perf); - des_perf = clamp_t(unsigned long, des_perf, min_perf, max_perf); + des_perf = clamp_t(u8, des_perf, min_perf, max_perf); max_freq = READ_ONCE(cpudata->max_limit_freq); policy->cur = div_u64(des_perf * max_freq, max_perf); @@ -550,7 +550,7 @@ static void amd_pstate_update(struct amd_cpudata *cpudata, u32 min_perf, /* limit the max perf when core performance boost feature is disabled */ if (!cpudata->boost_supported) - max_perf = min_t(unsigned long, nominal_perf, max_perf); + max_perf = min_t(u8, nominal_perf, max_perf); if (trace_amd_pstate_perf_enabled() && amd_pstate_sample(cpudata)) { trace_amd_pstate_perf(min_perf, des_perf, max_perf, cpudata->freq, @@ -591,7 +591,8 @@ static int amd_pstate_verify(struct cpufreq_policy_data *policy_data) static int amd_pstate_update_min_max_limit(struct cpufreq_policy *policy) { - u32 max_limit_perf, min_limit_perf, max_perf, max_freq; + u8 max_limit_perf, min_limit_perf, max_perf; + u32 max_freq; struct amd_cpudata *cpudata = policy->driver_data; max_perf = READ_ONCE(cpudata->highest_perf); @@ -615,7 +616,7 @@ static int amd_pstate_update_freq(struct cpufreq_policy *policy, { struct cpufreq_freqs freqs; struct amd_cpudata *cpudata = policy->driver_data; - unsigned long des_perf, cap_perf; + u8 des_perf, cap_perf; if (!cpudata->max_freq) return -ENODEV; @@ -670,8 +671,7 @@ static void amd_pstate_adjust_perf(unsigned int cpu, unsigned long target_perf, unsigned long capacity) { - unsigned long max_perf, min_perf, des_perf, - cap_perf, min_limit_perf; + u8 max_perf, min_perf, des_perf, cap_perf, min_limit_perf; struct cpufreq_policy *policy = cpufreq_cpu_get(cpu); struct amd_cpudata *cpudata; @@ -904,8 +904,8 @@ static int amd_pstate_init_freq(struct amd_cpudata *cpudata) { int ret; u32 min_freq, max_freq; - u32 highest_perf, nominal_perf, nominal_freq; - u32 lowest_nonlinear_perf, lowest_nonlinear_freq; + u8 highest_perf, nominal_perf, lowest_nonlinear_perf; + u32 nominal_freq, lowest_nonlinear_freq; struct cppc_perf_caps cppc_perf; ret = cppc_get_perf_caps(cpudata->cpu, &cppc_perf); @@ -1112,7 +1112,7 @@ static ssize_t show_amd_pstate_lowest_nonlinear_freq(struct cpufreq_policy *poli static ssize_t show_amd_pstate_highest_perf(struct cpufreq_policy *policy, char *buf) { - u32 perf; + u8 perf; struct amd_cpudata *cpudata = policy->driver_data; perf = READ_ONCE(cpudata->highest_perf); @@ -1123,7 +1123,7 @@ static ssize_t show_amd_pstate_highest_perf(struct cpufreq_policy *policy, static ssize_t show_amd_pstate_prefcore_ranking(struct cpufreq_policy *policy, char *buf) { - u32 perf; + u8 perf; struct amd_cpudata *cpudata = policy->driver_data; perf = READ_ONCE(cpudata->prefcore_ranking); @@ -1186,7 +1186,7 @@ static ssize_t show_energy_performance_preference( struct cpufreq_policy *policy, char *buf) { struct amd_cpudata *cpudata = policy->driver_data; - int preference; + u8 preference; switch (cpudata->epp_cached) { case AMD_CPPC_EPP_PERFORMANCE: @@ -1548,7 +1548,7 @@ static void amd_pstate_epp_cpu_exit(struct cpufreq_policy *policy) static int amd_pstate_epp_update_limit(struct cpufreq_policy *policy) { struct amd_cpudata *cpudata = policy->driver_data; - u32 epp; + u8 epp; amd_pstate_update_min_max_limit(policy); @@ -1597,7 +1597,7 @@ static int amd_pstate_epp_set_policy(struct cpufreq_policy *policy) static int amd_pstate_epp_reenable(struct cpufreq_policy *policy) { struct amd_cpudata *cpudata = policy->driver_data; - u64 max_perf; + u8 max_perf; int ret; ret = amd_pstate_cppc_enable(true); @@ -1634,7 +1634,7 @@ static int amd_pstate_epp_cpu_online(struct cpufreq_policy *policy) static int amd_pstate_epp_cpu_offline(struct cpufreq_policy *policy) { struct amd_cpudata *cpudata = policy->driver_data; - int min_perf; + u8 min_perf; if (cpudata->suspended) return 0; diff --git a/drivers/cpufreq/amd-pstate.h b/drivers/cpufreq/amd-pstate.h index 9747e3be6cee..19d405c6d805 100644 --- a/drivers/cpufreq/amd-pstate.h +++ b/drivers/cpufreq/amd-pstate.h @@ -70,13 +70,13 @@ struct amd_cpudata { struct freq_qos_request req[2]; u64 cppc_req_cached; - u32 highest_perf; - u32 nominal_perf; - u32 lowest_nonlinear_perf; - u32 lowest_perf; - u32 prefcore_ranking; - u32 min_limit_perf; - u32 max_limit_perf; + u8 highest_perf; + u8 nominal_perf; + u8 lowest_nonlinear_perf; + u8 lowest_perf; + u8 prefcore_ranking; + u8 min_limit_perf; + u8 max_limit_perf; u32 min_limit_freq; u32 max_limit_freq; @@ -93,11 +93,11 @@ struct amd_cpudata { bool hw_prefcore; /* EPP feature related attributes*/ - s16 epp_cached; + u8 epp_cached; u32 policy; u64 cppc_cap1_cached; bool suspended; - s16 epp_default; + u8 epp_default; }; /* From patchwork Wed Feb 5 11:25:18 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dhananjay Ugwekar X-Patchwork-Id: 13960861 X-Patchwork-Delegate: mario.limonciello@amd.com Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2048.outbound.protection.outlook.com [40.107.96.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B7BC22AE45; Wed, 5 Feb 2025 11:27:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.96.48 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738754864; cv=fail; b=T3/kdAAfC0nOy18LQ7h6YZ8qfExNEts3jGCeAxbtblm/lAQFEiHMUtBClLmfZk98X/Guef6I89BLxqzZW2KCmMFcO1AAbJ/R7qbalMZvraYfTxpH+tuArFCmJSutdK00uT4BmXVWC2WNixKraF7sU4b2pD/JoL8aaG2YqWxSyWc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738754864; c=relaxed/simple; bh=iyLstr2IVbAVHx4O7AmFjyOscLqFbUhkTzLjjri2nqg=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=WC6gN2FtdUqe5bt6MWPqp5goxS+IwGqqRI3L4FC6bP4eUUts3pITNbLe+w4hu2gDtpEPAdNP9gMREzKlXLw6dbS+CsdlJn4TMY2cPuX3OXc04qqwHGWukfx99hUADNnWHncGweuHoXSJn60b6huuMbS8QZfLW1MZX6tCC98whig= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=IGYO6jU9; arc=fail smtp.client-ip=40.107.96.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="IGYO6jU9" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mjpFm5YgqkXep2fSZ5xyUERaZcbDawkkhqqYp0LZaWotzqADfpNzDITBbO708qjB2GoMyUl2AF8uEtL7RAOo7xf9nW23CL46a/eymjPp6yvv+jIH0AdxLZgDAL3ajoMAtiajpUEvDvXInYy+NMUPqOlOPgMhr+LdB2Z9ZPF7NU8EcyU5VDQJkNVVEL1Zgm8TRfVPYS0R4Hiwr4xgQ586I/NN3lsv60DslGR/39vAmtQCOJu2pHsKptKeOw/RkAU4xlk0DYevGuRC+jcQNQgeRKOyEmQZR2mx3RUbT8LeF61OgNGlArwhucf4AUM2kgv/cGolFf2eOxBV5MKo0qDWtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VI9JizZ8Rz/2JvxA/UaGTsuj1P1fXJh3L4t2VN379WY=; b=rbI8/ck/1ZY16TE5uctXF1mKUQKTNc3VGExlXSuhSGq2D/7jKpb6QQlqkYqeJbNzUkX0hNnK2Re1xaL8Iu10aVmgk0iaHYnJ+xFTIt+g/NE7hscYUQ5zdBXMUYsORROQl4zqvoHDlkO4FDP0FNj4srpcKjA8VWCK8QlY8wEITS0Dce0LnsvT+9LlGHgEsWCTcoTPsluUUpd0ki+injBTl+PtEJZFVvc0JlTSA2JavdekzUoXyUj2SgEKDtUw6EMCJdiKRMIG+sDs5Mc3TNQ7Tj0JSOsCO3h0d684aiPeVS7WFLpzkxSRuFBJwtnyWgNZzyw3ldLhV0RWCxVc/UbItg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VI9JizZ8Rz/2JvxA/UaGTsuj1P1fXJh3L4t2VN379WY=; b=IGYO6jU9pRTlMDKOXmc9vGPs3VzdQYuVz9Pxt3qcNlzDXwUtm8eHohWYdx0i662yc6yWBkfrBjdwyyi9qvUaGxcDNO5b1BTZvWZA2Zrf4CeWUFphWjeu267h+c1wbLVEZqGxISLC6sBEeSqgl2TC4fDVbdp7r+AYargAMj2rtrE= Received: from DM6PR05CA0051.namprd05.prod.outlook.com (2603:10b6:5:335::20) by IA1PR12MB6212.namprd12.prod.outlook.com (2603:10b6:208:3e4::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.24; Wed, 5 Feb 2025 11:27:34 +0000 Received: from DS1PEPF00017094.namprd03.prod.outlook.com (2603:10b6:5:335:cafe::1) by DM6PR05CA0051.outlook.office365.com (2603:10b6:5:335::20) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8445.6 via Frontend Transport; Wed, 5 Feb 2025 11:27:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DS1PEPF00017094.mail.protection.outlook.com (10.167.17.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8398.14 via Frontend Transport; Wed, 5 Feb 2025 11:27:33 +0000 Received: from shatadru.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 5 Feb 2025 05:27:30 -0600 From: Dhananjay Ugwekar To: , , , CC: , , "Dhananjay Ugwekar" Subject: [PATCH 07/12] cpufreq/amd-pstate: Modularize perf<->freq conversion Date: Wed, 5 Feb 2025 11:25:18 +0000 Message-ID: <20250205112523.201101-8-dhananjay.ugwekar@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250205112523.201101-1-dhananjay.ugwekar@amd.com> References: <20250205112523.201101-1-dhananjay.ugwekar@amd.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF00017094:EE_|IA1PR12MB6212:EE_ X-MS-Office365-Filtering-Correlation-Id: 58b1aaab-5f03-47e1-db24-08dd45d815df X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|36860700013|82310400026; X-Microsoft-Antispam-Message-Info: Tf19k7vD5QTx3p61bgYozm1nfQiJevtMrRuesNPKqSblx5tAhSboEcxl9O1BpnQz4CZFeYaZOa0M9G43b/dlB8KD04TlVB+xE1gi79/fRh1FcwQPppsIIgkhU1HGphTGyHCeBg/H8Nk3ivGToVW1bRx7/0P2TyswFWK9kCd34pcFwlmzonM6X1EzOgwxkh2IPkX5ohELjBuMKXCtgAXxRToQBjMsCLBDMQiKCSFSeXoeD3v3QEuA0DTxt/EjEVnUDkm0sKtpXc6erL6VlFjeDV9HdJ8FuK6AEhyxqJwSJiJCEdXWnEg9CwcN0M9EMxIKwEcfOAKr0f3d64dS5bm3GWYfTk9l5k7gzXCTqNQGWq1Je4PIlK0nybHNRCmg/E3LG/hSYQQychsNt4NAFs9J47jMRdGDHr9QWsr43bDjT8y1jkR/QnY7S4YLNAjD4X7gRK3JXUkUgNNHHv8eN1FM+TxAqbBb8if40TXmQrqmLpEBVQjKZm26xQ6cqV2eUwQXrOr9q7oBC6a4eycRWI5S7WKLiqk0sfx2N7X7oJKv3DJH5sBN6moNZT9iFdO0DYwHuQeJzoe6InfY5GuKNvV4ViNK80HRMtMp0Cvdla2OxlPdI5YoSqjowVSCjPAPnwjQMEbsigzKMbO5KjvV3OcDWSwl3sM4LZcq0+Uh2A6D3FiYwY8mTD4dU9NOUCC8HaL5SsfuJtqoeYe5Y211hZzwMaX8AgHYy+XcaCxJ9c+LK3GNpQsCaMxvpLXFnbFMucLhn9m3ouelBrsSldcocoU8TQ2Yiked65OcZ6FEXTq3fSm9PBplxL1seXC0IES0P0Xg+QGq2LGjRU6E+IBTNwuDLZ4jcLLspwK4/9jRkcDX405RayQ/t1TepoRiuc8WmRTEdQ3nN4njQos8ZYg9N9RlDanx5+LbsAl/ii6tL7uFr0Vk5Lf7srkMfXrE88c23xRh1AN1l0IsjEXilNZPTuQuwfmE9r6p4sk2FJaF6Kjp/8jbnqSP0UsE7TwynXE5zrihm4Z2+EAy839BFyeuuoAcggisVVVxWM1C3rmi5xPgU9IwEYtqA3G9WKsxr8yRWEX+woCrlc/p5+wkxxcl5fiOLSH5VY8SP6PUnNcCda3aBPDQsCdKzmWLjYnocL6wjKUKozy5grOicyRZs5oUqvvmDM6o+vKsWS5ZzbyqNoknOrRiDc0DWxNvmcu890cd0Sa1wpNndZqP99v5j+RCTT1FYrtkgK0yA/9r55ze+L7bX7gFRmw/8a7q+DRinfofbC14RwuuEbjasZZaH5D2QEBslbp8R4XZCA7wy0C8cSvPWzYHK7ibVTjq2JIWT4WZKim2vH2PTluM21UD2CIvA2QgPrtDC+NemKNfQLB4qNWcHXOQiSuo5gcBY3okIIhx6KCTl8VHMqpvodKTheaa9LXKPZOLVBuu2QK+Fj074mOQ7J73iIA1QkOccrwb3d83bQ9NNuOGoQX+nAk97XcoqnFPkHAux1ycMajX+wlT1Ms265U= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(376014)(36860700013)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2025 11:27:33.7629 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 58b1aaab-5f03-47e1-db24-08dd45d815df X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF00017094.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6212 Delegate the perf<->frequency conversion to helper functions to reduce code duplication, and improve readability. Signed-off-by: Dhananjay Ugwekar Reviewed-by: Mario Limonciello --- drivers/cpufreq/amd-pstate.c | 57 +++++++++++++++++++----------------- 1 file changed, 30 insertions(+), 27 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index dd4f23fa2587..346fac646eba 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -142,6 +142,20 @@ static struct quirk_entry quirk_amd_7k62 = { .lowest_freq = 550, }; +static inline u8 freq_to_perf(struct amd_cpudata *cpudata, unsigned int freq_val) +{ + u8 perf_val = DIV_ROUND_UP_ULL((u64)freq_val * cpudata->nominal_perf, + cpudata->nominal_freq); + + return clamp_t(u8, perf_val, cpudata->lowest_perf, cpudata->highest_perf); +} + +static inline u32 perf_to_freq(struct amd_cpudata *cpudata, u8 perf_val) +{ + return DIV_ROUND_UP_ULL((u64)cpudata->nominal_freq * perf_val, + cpudata->nominal_perf); +} + static int __init dmi_matched_7k62_bios_bug(const struct dmi_system_id *dmi) { /** @@ -534,14 +548,12 @@ static inline bool amd_pstate_sample(struct amd_cpudata *cpudata) static void amd_pstate_update(struct amd_cpudata *cpudata, u8 min_perf, u8 des_perf, u8 max_perf, bool fast_switch, int gov_flags) { - unsigned long max_freq; struct cpufreq_policy *policy = cpufreq_cpu_get(cpudata->cpu); u8 nominal_perf = READ_ONCE(cpudata->nominal_perf); des_perf = clamp_t(u8, des_perf, min_perf, max_perf); - max_freq = READ_ONCE(cpudata->max_limit_freq); - policy->cur = div_u64(des_perf * max_freq, max_perf); + policy->cur = perf_to_freq(cpudata, des_perf); if ((cppc_state == AMD_PSTATE_GUIDED) && (gov_flags & CPUFREQ_GOV_DYNAMIC_SWITCHING)) { min_perf = des_perf; @@ -591,14 +603,11 @@ static int amd_pstate_verify(struct cpufreq_policy_data *policy_data) static int amd_pstate_update_min_max_limit(struct cpufreq_policy *policy) { - u8 max_limit_perf, min_limit_perf, max_perf; - u32 max_freq; + u8 max_limit_perf, min_limit_perf; struct amd_cpudata *cpudata = policy->driver_data; - max_perf = READ_ONCE(cpudata->highest_perf); - max_freq = READ_ONCE(cpudata->max_freq); - max_limit_perf = div_u64(policy->max * max_perf, max_freq); - min_limit_perf = div_u64(policy->min * max_perf, max_freq); + max_limit_perf = freq_to_perf(cpudata, policy->max); + min_limit_perf = freq_to_perf(cpudata, policy->min); if (cpudata->policy == CPUFREQ_POLICY_PERFORMANCE) min_limit_perf = min(cpudata->nominal_perf, max_limit_perf); @@ -616,21 +625,15 @@ static int amd_pstate_update_freq(struct cpufreq_policy *policy, { struct cpufreq_freqs freqs; struct amd_cpudata *cpudata = policy->driver_data; - u8 des_perf, cap_perf; - - if (!cpudata->max_freq) - return -ENODEV; + u8 des_perf; if (policy->min != cpudata->min_limit_freq || policy->max != cpudata->max_limit_freq) amd_pstate_update_min_max_limit(policy); - cap_perf = READ_ONCE(cpudata->highest_perf); - freqs.old = policy->cur; freqs.new = target_freq; - des_perf = DIV_ROUND_CLOSEST(target_freq * cap_perf, - cpudata->max_freq); + des_perf = freq_to_perf(cpudata, target_freq); WARN_ON(fast_switch && !policy->fast_switch_enabled); /* @@ -904,7 +907,6 @@ static int amd_pstate_init_freq(struct amd_cpudata *cpudata) { int ret; u32 min_freq, max_freq; - u8 highest_perf, nominal_perf, lowest_nonlinear_perf; u32 nominal_freq, lowest_nonlinear_freq; struct cppc_perf_caps cppc_perf; @@ -922,16 +924,17 @@ static int amd_pstate_init_freq(struct amd_cpudata *cpudata) else nominal_freq = cppc_perf.nominal_freq; - highest_perf = READ_ONCE(cpudata->highest_perf); - nominal_perf = READ_ONCE(cpudata->nominal_perf); - max_freq = div_u64((u64)highest_perf * nominal_freq, nominal_perf); + min_freq *= 1000; + nominal_freq *= 1000; + + WRITE_ONCE(cpudata->nominal_freq, nominal_freq); + WRITE_ONCE(cpudata->min_freq, min_freq); + + max_freq = perf_to_freq(cpudata, cpudata->highest_perf); + lowest_nonlinear_freq = perf_to_freq(cpudata, cpudata->lowest_nonlinear_perf); - lowest_nonlinear_perf = READ_ONCE(cpudata->lowest_nonlinear_perf); - lowest_nonlinear_freq = div_u64((u64)nominal_freq * lowest_nonlinear_perf, nominal_perf); - WRITE_ONCE(cpudata->min_freq, min_freq * 1000); - WRITE_ONCE(cpudata->lowest_nonlinear_freq, lowest_nonlinear_freq * 1000); - WRITE_ONCE(cpudata->nominal_freq, nominal_freq * 1000); - WRITE_ONCE(cpudata->max_freq, max_freq * 1000); + WRITE_ONCE(cpudata->lowest_nonlinear_freq, lowest_nonlinear_freq); + WRITE_ONCE(cpudata->max_freq, max_freq); /** * Below values need to be initialized correctly, otherwise driver will fail to load From patchwork Wed Feb 5 11:25:19 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dhananjay Ugwekar X-Patchwork-Id: 13960862 X-Patchwork-Delegate: mario.limonciello@amd.com Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2052.outbound.protection.outlook.com [40.107.236.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD10C22ACE4; Wed, 5 Feb 2025 11:27:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.236.52 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738754875; cv=fail; b=sQosFTWkN9vggb2HJqTX/qURacTWW4dl9UGE/iuAbxNxPgAXqM9xf2F4k2ZeW2He7/N55924sFHPmmcrbfnMGUL1heTau3TbmSVC5DSDwmxR9514Zjxx2/LnSu4r1yr4RkhsmM1CoNJSKbpyjuNHpYs+JZyf3NH0/mm4VtdSoqk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738754875; c=relaxed/simple; bh=WycPElaCc1hqQI2l3eB107Y4wWjlq7Kdg2x6zvEXw2g=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Ji79xqlZaWYefp8fpcmRY9cBZ+uNUsXgHZrxwJZlIKkRDZiFUCoXZqXk8WILXswDnKZBXD91TvBju+2nt6STi27Ho6V0TimFkT7c1dsMoQ3zCOQPpMhIwtZh4vzViy8bkzRF6Mfmp0lwl+fvtZntENpcBTSc3pbL+J8Bn/aC5+0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=dotCiWWl; arc=fail smtp.client-ip=40.107.236.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="dotCiWWl" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LBmPjDF7gs2+gqvtbt8pFLQ8I0j5NrIubZ0to/84SckN64ngAJlSfKUNm/28FVLBK0W8UCih18nyGGXqYsaqVSYxM5qC6Z2cz3IV80gmu7Iw5ph7ILV4yphdpLx1nGCkB4yhDKAhwGHBCgS4F521tb0OzHc2aUn7V3Vkyac0uaqianwOGGWUOCRIwCjb5CYOblvAErx4M3zznIe2xXAdarkZV3d/0FPkezuG47iCu4oeTzIiPdSc9Ad8cjB5D88uPTlVmX6HLT4nnY6Otz8D61zoyvq1Kln++lb0kVWdFNDW/qlmKWgRr52ACYZ1O68yrrudo9kZgTBZC5lOYiuF6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dP8zS7f5DI+O6aj87gcX+Wp+O48dfToHf/CM3VdzFqk=; b=mz9FTKeSofwMdEccu7qsrJEeKowbCBPo0pZrKbV7Wvk0hyWU466DxxU0JBYBqDygLEPCiP1eN64uVT6vkmzqiFdrgVlSxLKD3QXimU4gL8uqOX/XyqU+Lp/nlFvj5YhhcFV7RxCArZcta7Iwx/hSk+jUKGYqbqnWe+2Ef4olfC85V5N8sUyyNy1/nHd/5GiVVvzSwMjVFBxPpjJWwcTBewEOGHIv0WEBbt7lSGIZm3n/h4FHRZg+kfQhdY/lQVCfHm5RUkLCZgDuLduNQMSCYGamHhYv6AWG5OGvtGLjKHTvAwQ8pKHZH2VKpXhQ7ioNSBwjoGN0nGZ4oDolVdt+Xw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dP8zS7f5DI+O6aj87gcX+Wp+O48dfToHf/CM3VdzFqk=; b=dotCiWWlUhBUrAdLx5z+60gi3hJGl1oAXFeefY9QIj9JZbHuaU+DaOX9jeXdt4/m/frol7Jd2qnPwDZynvKX2PnkP/1ZQZ/b34Dvl3l2QqfbHeVu3ex2cU/FK9ZnshhcHV5Dr43BJV0zcPTf72yG3sz9Q9vX0SaTnJaKv9q69G8= Received: from DM5PR07CA0077.namprd07.prod.outlook.com (2603:10b6:4:ad::42) by SJ0PR12MB6902.namprd12.prod.outlook.com (2603:10b6:a03:484::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8422.10; Wed, 5 Feb 2025 11:27:49 +0000 Received: from DS1PEPF00017091.namprd03.prod.outlook.com (2603:10b6:4:ad:cafe::24) by DM5PR07CA0077.outlook.office365.com (2603:10b6:4:ad::42) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8398.22 via Frontend Transport; Wed, 5 Feb 2025 11:27:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DS1PEPF00017091.mail.protection.outlook.com (10.167.17.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8398.14 via Frontend Transport; Wed, 5 Feb 2025 11:27:49 +0000 Received: from shatadru.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 5 Feb 2025 05:27:46 -0600 From: Dhananjay Ugwekar To: , , , CC: , , "Dhananjay Ugwekar" Subject: [PATCH 08/12] cpufreq/amd-pstate: Remove the unnecessary cpufreq_update_policy call Date: Wed, 5 Feb 2025 11:25:19 +0000 Message-ID: <20250205112523.201101-9-dhananjay.ugwekar@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250205112523.201101-1-dhananjay.ugwekar@amd.com> References: <20250205112523.201101-1-dhananjay.ugwekar@amd.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF00017091:EE_|SJ0PR12MB6902:EE_ X-MS-Office365-Filtering-Correlation-Id: 5f207249-ca37-463d-9f94-08dd45d81f5c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|36860700013|1800799024; X-Microsoft-Antispam-Message-Info: quQ3tsXd7a+eamNkf9ryR4gqHDk6WQjIHgG8eA8zveTummVSOnhTXd1VPolvGhHJ5ICIWXDm2hbnfeD1l76ZY7FdOXJdKjx7hPcVdKiWksoy/MmGbCC0BJtElaJM3RB6I5s5SiyRXz5m8lxfUdoadI7yOFHp1tZTP3TIyzjUDpQ0i2KVoEqBqlujibceUoZFmYdcP3LI+jRSlNPTiTzWdk1Ayn5ZU5wxyU6QnURCIPuaZ8MWCG73FDcQP++KibM12X2doFhber7Fi+5B6ltb8/Ivtqs8MDl1+1YPMlZiA3cjbHK6ug0rEk7F2EgDZo903rAI9bf3QUs0ZXHsj2NaKb7ln804rh52hZ6XfkHi1j09IPKYgJLE8HsrMVqpirNFDcj+4v/gKZKBf1SLNNIC7t5d/JhfnL6E0M+6YfoQUaGAXnwjPQDEKbi6zhSxaidtmPGnQf0C5fR5jU4w69QHnv76tVk6P5yo6/8Z5dKDvl+IIhyuP4uGyfX1Ep7ngXM4M13ETpjZpzPur9p46Y4KIu9E9kEq1YflLUWml0UsSBwhVTISiEku46r7gYbzny96VkXFxsTqOn608AYl877Q9jhgAfXhdoqvzSY/+4TIB6s7xDojIj+RmPCjZlwgkIdmZQPkwyztQwN4RLgYTgmJiUruwmB+aSLIGpAKIqTg4tUqQBrFdK/oITF4lqn98gU5+y4LtrpbSTuU7DsP+Yt/m9ogv4ohg+1GIfKfGOq7TQRg3BFsRMIYfgtgJE7A0/zROEFBYbAExv1Y2nmuC5HwvmuP6L9YorF51VY0GahMkev+dq3e4/9ygCd5zQhSvUsybaPXLgpj7mq7pv/IuimXJTKgUW2OgdznMo0xBKYrVuN+FuK9xVXFmIWiAu3aIp5wKcC9vGFrICtP84PA9lX1mr/ITxRRK6Dq3RTJM020nExIeOWuLZkdwl3nf8wQX3nL995pfJIHz06GKGVo2Eoyl85y9f3DsAVzsPImRzGwBIII1wViBhQp1brmJojofvAbmIODndcoxQHa/NCmEHsgGdysyJ7IVVu99iBYw0sv+Njj6AKHd8gXkDkHGbhj9iuoml2eKQVRNvKoUEYb839POS22mC/35jfo4YmgK9Ry6UpyRYRvvY+MvfWbvQWCRlyV+33DzoQchbnddtrqdIuuvfWGzhYcs6hNWlNbxYGezYtrH1lnziqg4X1Q1USGpm0u+T6UhadD9saAq6dIUqwiK+qQ2hK1pxrLPRPWtr0UIlsONtKxGNv6IIRNxoWrN0W2drEyXrnFGYf3MhhjKCIRWOfmwK8SX0XebxPlkQ5U4TLMf/3NWWazNyOrkGkxXQYcS42Df25Pv+0WBzKqxnnDWAW3hCE8bH08zzSW8BQTL9eWT5dM0JuJ3/Zr5PHplE0a7eUxIVPiPRv0Nc4ei0JNtTpfgHhiMEGfR82iWbmDvpxQfrFe+XOIGiejksBGMj04IH63Z0CRNtxauAbZLgyIiR5x9LNxjCZQJQV6C5oPYn4= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(376014)(36860700013)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2025 11:27:49.6801 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5f207249-ca37-463d-9f94-08dd45d81f5c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF00017091.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6902 The update_limits callback is only called in two conditions. * When the preferred core rankings change. In which case, we just need to change the prefcore ranking in the cpudata struct. As there are no changes to any of the perf values, there is no need to call cpufreq_update_policy() * When the _PPC ACPI object changes, i.e. the highest allowed Pstate changes. The _PPC object is only used for a table based cpufreq driver like acpi-cpufreq, hence is irrelevant for CPPC based amd-pstate. Hence, the cpufreq_update_policy() call becomes unnecessary and can be removed. Signed-off-by: Dhananjay Ugwekar Reviewed-by: Mario Limonciello --- drivers/cpufreq/amd-pstate.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 346fac646eba..107ad953ce43 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -852,10 +852,6 @@ static void amd_pstate_update_limits(unsigned int cpu) sched_set_itmt_core_prio((int)cur_high, cpu); } cpufreq_cpu_put(policy); - - if (!highest_perf_changed) - cpufreq_update_policy(cpu); - } /* From patchwork Wed Feb 5 11:25:20 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dhananjay Ugwekar X-Patchwork-Id: 13960863 X-Patchwork-Delegate: mario.limonciello@amd.com Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2089.outbound.protection.outlook.com [40.107.220.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 688F522B8C3; Wed, 5 Feb 2025 11:28:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.220.89 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738754889; cv=fail; b=Eb7r/OyvVqYrOMXKYnhXLWNR/7zWxdMHnB2It1bx7H1Nl6tASldOHrrw1Nxi08SZS9DNCMxa6RuvPZ+kFP4A2qZzYU+9AeJi1NIjNR0xxrRVhMdevpfX1E77+uyahIiVeOPEooOF4WK0fbNiW1PL0V48a/z7eFuxqBM24r8GOeA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738754889; c=relaxed/simple; bh=LCA67j4SRTzHf5ebtKdg/ruoq70kStorWw5YNVcd5G4=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Dt1R2uSXMl7Q2pdefQEN0nUTPxkUUqf4nm47a8WcPKahAUWKBrlPkDowv5S3HGQXEhL3F4qkFXZN69W5FIWXJSiN2669bzMx4yxVouq5maRfFNF0/BviYKYp8e0/i2vEG5eFeOFKQi+5vIJ9CaVmwb8myN4OAJP4ijcqdPREJ0g= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=l8BcwIB7; arc=fail smtp.client-ip=40.107.220.89 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="l8BcwIB7" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lEDZXdxuoI0Aos3aUmkEmo1H4GQK/OO/R7lW2VnnWZVWHHPn8FfFr9XuX1uIT2717rnY+4+CNvzqV/kGLQc5wevvE1ypxYD6t2P/Y+KlzCIjQZXFyNSxlISG58TI0x9v/HgVDN+wESwDqJqjDicSwNJOjTCtCbwM2ueFnFnDMQn25reX9MJ4CMWpTa6dDkDQCX2ToJ/YT0WroBYx7i9BxfvU1sef7/eBoBVFm6FDZEsYVK/6d3tUN9QaSRc68CgfzwE6Js2QT/GWeHOHhDSL2sjuWHmlf7IhfLJtPa5BLEl3oV/rbPMN2OKXKIT+vqoDyQtQ0Ef72qx2sTu0XL8syw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6Gc14Rk8iBgnPPzY+p+srZJw+PVpuSU5XWgaHuWoytk=; b=EMbeWEE2BMz5ImZXEx6bPHkd3knf+/L20lHzNcAuOZBizQ7xWg9JspsGc21F0EKl9LVF6lItj8OMjabGUP7FvZlsePcXFCnaqN8xv3GC6sCtFEPVjQ/CKozLCZCSfNludPtnHmeWuokOj3PpBdu8gMPc46a7nFd0l87DtLvw70vgfiKsd0CUHkLoKotgqk0dfd4l0RNQKekWrXZikuLnu/Rou7GaXPkEnKUZj+nlOlGpKW/SsARs17l7jYk2nMKEOg9SHceOv2zxv2fwMQay2wat3egz78NCnFRSwLGltiSXjLodeIc86rnmdiV2eTcQidZbI99f66PclJtKScAOxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6Gc14Rk8iBgnPPzY+p+srZJw+PVpuSU5XWgaHuWoytk=; b=l8BcwIB773O6644OP5h7la1yuHzqfwtr735mR8eKf/rDkP36gJaO0DeHw/QhSyh+rY2R1Outnbs2hKGFRilaLOE33OEdSjGFZykWYegkyB0w4YHAqhhTBLP44wBGIxw8pdvI6/oAoP4NMOpkhWC9Yumzx7Sc8v1EJZroz2XNTg8= Received: from DM5PR07CA0071.namprd07.prod.outlook.com (2603:10b6:4:ad::36) by IA0PR12MB8905.namprd12.prod.outlook.com (2603:10b6:208:484::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8422.11; Wed, 5 Feb 2025 11:28:05 +0000 Received: from DS1PEPF00017091.namprd03.prod.outlook.com (2603:10b6:4:ad:cafe::87) by DM5PR07CA0071.outlook.office365.com (2603:10b6:4:ad::36) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8398.26 via Frontend Transport; Wed, 5 Feb 2025 11:28:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DS1PEPF00017091.mail.protection.outlook.com (10.167.17.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8398.14 via Frontend Transport; Wed, 5 Feb 2025 11:28:05 +0000 Received: from shatadru.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 5 Feb 2025 05:28:02 -0600 From: Dhananjay Ugwekar To: , , , CC: , , "Dhananjay Ugwekar" Subject: [PATCH 09/12] cpufreq/amd-pstate: Fix cpufreq_policy ref counting Date: Wed, 5 Feb 2025 11:25:20 +0000 Message-ID: <20250205112523.201101-10-dhananjay.ugwekar@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250205112523.201101-1-dhananjay.ugwekar@amd.com> References: <20250205112523.201101-1-dhananjay.ugwekar@amd.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF00017091:EE_|IA0PR12MB8905:EE_ X-MS-Office365-Filtering-Correlation-Id: 52080a01-1e3c-4534-1945-08dd45d828da X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|36860700013|1800799024|82310400026; X-Microsoft-Antispam-Message-Info: DdIz6jryQn4ueSetTiadYKZl41neyIqKwwwVa5Qp0ToqEOKWOUF9PJLjK9KmT8k6X+/V/cZQtmAQH9J0s+xrpWs0LiNbjucjswoF981CheiN1H2gjh4x4BdvChU9wr+XW2tvK6SIMy21easyvIckMKhxckD2entCVIPvauIjIFDAfL/NUamySL9fA0LybNPm6hpmXLGVUvIhyZlymwDk/WkLw9v1kKhkrYncEBPf/dvASd82YNQECiVhiwLebYtLp0W6JeV23Q2/ttDrWImYlEtvLp79m9qclG/dqb2vh/BkTJ9zOyKMrmd3rQBD843r+EO2n/5MW5146N+p07rWEyIfs5VJQ185e5rDUkNl2bQQnZ5S4yIyWhmblBmXsML1MDR2b1hlINBj1UeeL/2hhd9MIEwpWBT8bSHqL7zT8ltdCHJv+0+jK8iVraPF8kbquHmyGESG0+TXO/z9W7jZ7fT+M/mGva9Uqv621VjWt2r6FUZVoS42MsRkAOAL0bHoV2oL3yZ81r/pYO4q4Zo6/TMwAWn6e/Qi3705zLgGgmFLRnpq06drXiwA5Ck8yafJVJsABS5/SrzrdQA+o6wvzPdN8pP9nnVM3MA1Qvxkte5Fuu1vMPxrtjv9nHEbQFTJRjaDy6ASJaYJRQazbEcogX8xVolBcn/Fzhm+fSHyKGFnOijQisvX3+4ApQdDcPp317/+fDYt5A74g2Nsc8t8ePtlUQyx4mRLiPpPBbZv19nKRyn+WjLOS+pC8rM9JAzHRJa4k8f3N+LCDnl4+AcYKvtqY5aSHQz9XIPSlPWTFqxhMtuX/RmFit5rFRBFyDCHEYqy3lki7GfJatT18qm50QloOS7VrRndEnjblHuccMR5xBz6trP5XgKzY+527xzgfzxEdLiXAa9bCyBFj1BmYp2rtukIC3WkbUKKZZb9r5jkaPvmnGKNu3swT1Rvzs1w7a+z8xTio4jvK4QHIH5IaT5t3hhyVBCpqeQHZQQ+Bxzp6EBUeY5iK9hNV8zlE4lJGlzB6BnCmAx9bsrgwIrI5tOUe7ej2lUpsLoU2xbJRjN/2nbSl1C2PU7GcCyh6BsZSYTYSFAdNrlJUoWK5jlIpPZD3UFVkC4re6AT4lqvF/3J4mHW7gB7JDMShtwQpsUr83fgVeQnJd2c9otYj/kJDbGOCMH3zOTS+HOmhRkORcp+n0YM8x+5NpYRqIiXkFQrMh0ShxHfApYH6tUOdN7x0uRoRqAtDV9tT8EJB0H5ZYSAewslheeSP6pK6Sp21I3/AvfQCHTr21Qrndv+BhHbMLEvDhoGNlfirVmU3thqSIno22vWM97dwoF+RdqfbRzMBEcPeCbwbu2cCMobX219zi1VJqhVpddFiz+TD6Z9waVN+zSY848brNKw1YU5DsdLnTLZaneJiDVnWfGfjPb9vr/CXCHEzIsutF48TkPgew5hLzBr6X9Vdrddxb3okOPOr0T94FdwDuSZWpjvZinolOozEtvVhWsW+I05kzQ+U9I= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(36860700013)(1800799024)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2025 11:28:05.6019 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 52080a01-1e3c-4534-1945-08dd45d828da X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF00017091.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8905 amd_pstate_update_limits() takes a cpufreq_policy reference but doesn't decrement the refcount in one of the exit paths, fix that. Fixes: 45722e777fd9 ("cpufreq: amd-pstate: Optimize amd_pstate_update_limits()") Signed-off-by: Dhananjay Ugwekar Reviewed-by: Mario Limonciello --- drivers/cpufreq/amd-pstate.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 107ad953ce43..9c939be59042 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -821,20 +821,21 @@ static void amd_pstate_init_prefcore(struct amd_cpudata *cpudata) static void amd_pstate_update_limits(unsigned int cpu) { - struct cpufreq_policy *policy = cpufreq_cpu_get(cpu); + struct cpufreq_policy *policy = NULL; struct amd_cpudata *cpudata; u32 prev_high = 0, cur_high = 0; int ret; bool highest_perf_changed = false; + if (!amd_pstate_prefcore) + return; + + policy = cpufreq_cpu_get(cpu); if (!policy) return; cpudata = policy->driver_data; - if (!amd_pstate_prefcore) - return; - guard(mutex)(&amd_pstate_driver_lock); ret = amd_get_highest_perf(cpu, &cur_high); From patchwork Wed Feb 5 11:25:21 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dhananjay Ugwekar X-Patchwork-Id: 13960864 X-Patchwork-Delegate: mario.limonciello@amd.com Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2062.outbound.protection.outlook.com [40.107.220.62]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5325E22A7EF; Wed, 5 Feb 2025 11:28:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.220.62 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738754906; cv=fail; b=GT78jO9ACqdUtgLkBL7hk9uD7belpUJH4K3JO1FuU2WG5awBmLIOYTuGmzuMaGayWnuoFNq+73Hpbcg9bK57cpjKsYHVbZnb1WqS8XfzGMp9FbGgzJYGu7QyDk60xJ9bbh595+uWrCiZ1nP6G6OIxJakk/T6vx7S7vE7iofF8uo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738754906; c=relaxed/simple; bh=BvvhyCXkmkuJlPF+dPWWWSt7tkL+CnyW2RbiOoEGE5Q=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=XIJkTeIYNFDvluJLdLiLVYGfhr5nkfr0rN2Qhd/CRBwOCL3wy84dLzWH2CrYm2QhbrxQoZd1+G0wqotTqbtr3DK25BkjUrH6y5CjI39dkqhlmnATrswFPyJ94BVZploWv59+PMVzMcZ+Rq68H58E+90HnAs5BLNFV5OrPjB1eqU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=xYNbkx/U; arc=fail smtp.client-ip=40.107.220.62 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="xYNbkx/U" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MWtIP7I5kHInDVlYonhMiGuTwoN+suEZPadJyuju65tJMDMDw4wUG1MA6odmi14NAI4Z8HtSyX/O6VyIbANfTXm/ISqDqPShMf5vo+eeIb+VMFPhfZE1sPeupFIFeUQq0uagBPAn0gNdb530crOeVLrda0FbuMy/0RQdhmd187gau5qDVbNw0Swg3m+o1Zctcd9YkwJr9WVPLy9KcHXLGdHzd6nLF9tBE3GI8pkro1E7dKSbvUdF1iL0l1x/HdhOLBXX3kK5p9yswqWGMo+m4gthfEJ6Tvd52omub8r4LMtSj1jGINEgIEVepiO+9ZNHPS7X9d3TZqmN10iRo0ijaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mHT3In+gwK3ezqHvinLssQaWhveVYDsByG6mBRVbrGI=; b=lb2yJklYENiPBpYjIntu0n8iu/uWV03V48ElD0TmR1Vag0kwrIWbsAw4GkoOgkQWzG2Imsu1loDIgJAj7vEm9WuItcoHw+dIqsq/txiLx0OLcpkhV5IQhF7KjyBB07hIMTBUlsuDQl4doP+gsADh3DKRm8MzHhqWUZdwHD+88iGkXeDh1I9vbwPlR/ctIcJEylW3nmq1D6s2g3K2zHaZa3RgpgYKoHftTtczPZdTExpxQHoLLYS3oW8wW35edeFGkCTlQ2qL2onCDRvkG69P0ZZyl+23eFXe2m1HmA/fqZBKF5hJ4rZQv2RyfEwWpAFxdZCqVy/6tciwmsXN9QTx9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mHT3In+gwK3ezqHvinLssQaWhveVYDsByG6mBRVbrGI=; b=xYNbkx/UXoSe655wiau4LqxqNqY+AL+zVrB6Dt10TrWbcwmefMuSITnkRX1L7In0mNn1Tro+KLj5RKnx+kWHXnzXHAmi6ZCu+Uw3HnSlMdSCn0hxTwWZyJ+YMfMFOwMjYHjtSOhl3/Y9L/f39ha/jMkRo3tHm+J4+lrOV54dgkU= Received: from BN8PR15CA0001.namprd15.prod.outlook.com (2603:10b6:408:c0::14) by SJ0PR12MB6711.namprd12.prod.outlook.com (2603:10b6:a03:44d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.24; Wed, 5 Feb 2025 11:28:22 +0000 Received: from BL02EPF0001A108.namprd05.prod.outlook.com (2603:10b6:408:c0:cafe::48) by BN8PR15CA0001.outlook.office365.com (2603:10b6:408:c0::14) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8398.27 via Frontend Transport; Wed, 5 Feb 2025 11:28:21 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BL02EPF0001A108.mail.protection.outlook.com (10.167.241.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8398.14 via Frontend Transport; Wed, 5 Feb 2025 11:28:21 +0000 Received: from shatadru.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 5 Feb 2025 05:28:18 -0600 From: Dhananjay Ugwekar To: , , , CC: , , "Dhananjay Ugwekar" Subject: [PATCH 10/12] cpufreq/amd-pstate: Add missing NULL ptr check in amd_pstate_update Date: Wed, 5 Feb 2025 11:25:21 +0000 Message-ID: <20250205112523.201101-11-dhananjay.ugwekar@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250205112523.201101-1-dhananjay.ugwekar@amd.com> References: <20250205112523.201101-1-dhananjay.ugwekar@amd.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0001A108:EE_|SJ0PR12MB6711:EE_ X-MS-Office365-Filtering-Correlation-Id: 3c603354-15b3-4663-53fd-08dd45d83243 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|82310400026|36860700013; X-Microsoft-Antispam-Message-Info: aWzYmXcFps3taeyeaQriXad7Pd97tihDWIU5u6KF1USRR0V4oMMKuGYiqdhLD0tCHD4OYDGjCfB8xWQehF6GMjdouBqP5mzdLLKVuNNkBKGOQhmO9MritYEokNGEabP8qEPDSv8+dgKDBDnXqiYZvJb6XOe8K+Zfl7xgB6faES5zPb03VBzDIE6MadYj0xqWcEk+mf2I/q+VbrVUBYqeei2u8Lv4XpepyN+RJinU0jDObhUnlCPX/fsZMX0+xokNOfHYgNWGiIf7tvMq8RLbx6SVipGYzPbwDGmo9sQUO/l1z0YE9WAPA1dSOUNLZauhMfWPkkTIsvE0bHgvCVH/bLGQnLNbXCtO/4461yucf/nFLVYmbUE1yN1PpkTnMg1hHaRD6E2MtQldUgfBrW3p86hXwoutK4zqE2cygUaPmSpgOy7JfQ2NnF6lJ7KG7dVlYGJeeKjZ+S11y/iFD5fGbNGVWY3e8ywL+5yH2AVlGlhldIKs99waJeruFfT4cVLfSqPlY/LZcddrF/Oo8sY3D70YNmxAj32x1rKMNYuvx86KAU+hSHKZUdVZQyboOnqI4puPR9TuupMD+pi2Ye8SEke2Nhz6nAXrwwd8RiIRG1rXfTyjjz/Q7Xui90aOTyBPO0wuwwm7Fw57/ipirbGcMpuylWnTx0GXu/aZlpI36QFEwDhtBKA8FukHUwdWewVzQfW8aM3xwbJYswf1Avl6fihhwaAfRR4qAd7uAm0bZry1w1Ny5CxUsCUqDY7URcJPv/WpjAlF4SpdOpwDBxTwuYfOd1pLJ1ThI9Dh6nq2C8/6F4yfh5OU+TVlZIHQWoh2JzVlnkhT1RXuLaj6HjaiNA5zR4AnSg1Re1XZbt/L9AWf2uxd2jq2NCsnwntjrFXMeuGjzeWb/1Cwxg0GDoNaGV/Z9mdggWQ9DFPDRSzBD57dpeZQA2pPGxqgBWcrdUNyZDpyWH6Toe8GZMGamuaHI5u1/59ZjWl03iZD7WZ8to2n+kJjYd3s1/Uv4WmZOCQ4UNDfDRl3v9xRtTNzl2RweRB5pLdp2hWYj23orl3aRj3G8/ECyBNZ3NSa8Nb4cElEYyML0WtqiiHsSGvJvYXFLhxHWIYn2LMMscPF0guARuOkTJoXZkxvQ1xe3VkYuP6KcnE+4Jon6Y5HTObY+vt9br54BuHWc1PT/I0pSXyEkDCnV8Ga46EDDaBU9M4F9Ftek8mRhyVuNKOI+2l/8BXG5nsPgsce9f7ke4VI42lmaBz6a4OXwfP5S46F+IP5ClI1Q64J12D3070Xq7hpM8n/EDpUH5aApvSvoJmHVZY+cnYhVQiJvSCee6iLewzdeLu+WkdMNSBGwT7kUCZaq/UM+ecUhG5Iey5/nwhyOQrOX52OIVy4AZDz4I1bgQAk2BfVkt3PuFVdDeQzRk7gSDEU3K54k4MYjVciSyTtBs9Vez6/mReMK5Xhya3PP8GgM5Zkrn4N42OVisnQY+DxBb85O2T/QjUwEaACUO1bTxi8vlg= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(1800799024)(82310400026)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2025 11:28:21.4379 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3c603354-15b3-4663-53fd-08dd45d83243 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0001A108.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6711 Check if policy is NULL before dereferencing it in amd_pstate_update. Fixes: e8f555daacd3 ("cpufreq/amd-pstate: fix setting policy current frequency value") Signed-off-by: Dhananjay Ugwekar Reviewed-by: Mario Limonciello --- drivers/cpufreq/amd-pstate.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 9c939be59042..6a604f0797d9 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -551,6 +551,9 @@ static void amd_pstate_update(struct amd_cpudata *cpudata, u8 min_perf, struct cpufreq_policy *policy = cpufreq_cpu_get(cpudata->cpu); u8 nominal_perf = READ_ONCE(cpudata->nominal_perf); + if (!policy) + return; + des_perf = clamp_t(u8, des_perf, min_perf, max_perf); policy->cur = perf_to_freq(cpudata, des_perf); From patchwork Wed Feb 5 11:25:22 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dhananjay Ugwekar X-Patchwork-Id: 13960865 X-Patchwork-Delegate: mario.limonciello@amd.com Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2056.outbound.protection.outlook.com [40.107.94.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DECC22CBEC; Wed, 5 Feb 2025 11:28:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.94.56 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738754923; cv=fail; b=c9/9wOp6w8JXHKd1ari2OywBNQKORWvCX4MeVKt3RpFvzxyZTIBn5xPRjkRJ42gdx4wqEuhiK0tBQe0aStzCPt1hFEyqiQ9UyRoAkWQvTh+MBSAAVRWsQKjtPZGiZnT6uB5y2cHV/N6doLy9FOHdUQl6ED3tEBpBjzbUvLzIl9A= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738754923; c=relaxed/simple; bh=dG6h0ZhiyW4zZDfibagNWPFupt1FSF6lhdL2bC2/JqU=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=D5G9IRrMXeYq1xU23hcUtMowXOWA1cCECdpoP0dEB0xaMgb83Tn4964t6gUjAyT/85rFXQh41g2zdf1sgi9JRMLsehN4db/Rn1eOI1a21l/enMvbgBo6IKHo9QGCRXVXO2pb4Hn8ZOgTECykYkEXdfbwZj35h/1A1JbKRIrGX4U= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=eAbJITiG; arc=fail smtp.client-ip=40.107.94.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="eAbJITiG" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hDPo8vHfA8FUkp+KQoir31WmuSMpE8RIdBMLXprfAWa2S1JLJPkW4HxYzk9TisCFMnzuO1NBcV8NK1a6FJPgGpYaJXjWkxHIwRGXRY/B9Kl1GOQdzKJTtPbYP0TGjsJ79K/wmVgZVr45IpBh8BS/TkwBv9qSyt317OS8G2yHjO2T8eTPjpolaTWLK5JFrmroGZCClRAG9rOziJZSPufpuo+K92WJTABJ1kGowbBTbn75CRHXHNHoycXVx2aONCNgZs0yXzm+pzknXKrQW0JIPpRMhZy6Z4JJquvCHnpIA9CgGHtA/hpHVHmP40tqw9ey+NRQ0uJiZqWQjlEod+r1hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FrKzhYJ2s1I81LO4d2M4m2UJknIyrCxOljqyby/50po=; b=Z7HUz2NQ3ppVsB+yJFim0q0bAZoTZTa/fIM1DIyKGk68LZ/fU9UB9dZP6RU/Uh2uCMxXXNzQeAd8XjCJLUUGOk7P21/RtyMbOLH2VPevhWBatdmNNunogUVg85aeAvsrVNIxPYsFWJgJnAPcAapffbu2A6g38AMdbUvUPX8I6TFL15ENl3yzJ5zSFcUKeoeidXPJoGGjonUsDj03WH3Da+sXckRACYHBoNr1+u5sb8MB3HJRltcT7tA+ceUziUx2R2zbYVziUCslFSncKw2N8evUW+8/j99S03IdiIgGrsE9w0ga5jeReqg/JfSVu76K+t1iWwex3LWLIQqxT1LtTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FrKzhYJ2s1I81LO4d2M4m2UJknIyrCxOljqyby/50po=; b=eAbJITiGB6mD+aA873jMg+si/THsF9BGIPzi7FOPX5DnNRYmOWcauuVtkm38ilXhYFgr28yn3uueGXHMTvZaZuIztKvrxR+5AYkPvla2heLFZLAusQ//M65MdBx824/CcmURHGVRwIH2pQW28TiCuiDmaV1nZ2Y6233gbHMUdh0= Received: from MN2PR13CA0023.namprd13.prod.outlook.com (2603:10b6:208:160::36) by DM6PR12MB4339.namprd12.prod.outlook.com (2603:10b6:5:2af::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.24; Wed, 5 Feb 2025 11:28:38 +0000 Received: from BL02EPF0001A103.namprd05.prod.outlook.com (2603:10b6:208:160:cafe::53) by MN2PR13CA0023.outlook.office365.com (2603:10b6:208:160::36) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8398.25 via Frontend Transport; Wed, 5 Feb 2025 11:28:38 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BL02EPF0001A103.mail.protection.outlook.com (10.167.241.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8398.14 via Frontend Transport; Wed, 5 Feb 2025 11:28:38 +0000 Received: from shatadru.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 5 Feb 2025 05:28:34 -0600 From: Dhananjay Ugwekar To: , , , CC: , , "Dhananjay Ugwekar" Subject: [PATCH 11/12] cpufreq/amd-pstate: Use scope based cleanup for cpufreq_policy refs Date: Wed, 5 Feb 2025 11:25:22 +0000 Message-ID: <20250205112523.201101-12-dhananjay.ugwekar@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250205112523.201101-1-dhananjay.ugwekar@amd.com> References: <20250205112523.201101-1-dhananjay.ugwekar@amd.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0001A103:EE_|DM6PR12MB4339:EE_ X-MS-Office365-Filtering-Correlation-Id: 40531d0f-faef-44b4-3931-08dd45d83c28 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|82310400026|1800799024|376014; X-Microsoft-Antispam-Message-Info: GQksj0Xz5V2XLx10Xjh3EqK/6OwOuOSmTowUKY9SqTEmr4znuEPjCAp8xrdY63OzEnvlzRRXPTmnKOPSJElF6j7Oo+HH1hzn0vhIdAwPs86LDqipTJkPwJkyGCiFqKqhUrmOOtfkNEZSiPeT5960cGem0pkLxyrAMZZBxEA1ZliiCii3BKiJpdp7ItWSSi8BDnnocCXdOwq5nsvVJLJuPkh+HTERXUkok5yY6rrhEmsGNm8zqxqWynf5qgzmmYdrVobhVPuRkGRoIIyfsecpa45r/YiGtN9G6tEUuHBtBFnBaDF/AKa6yoiJRfvc0TVYT0zQxGn2H1FwIPU0YA6NuFH7T1UNuZeNcq0Q5sHlpVI6GxaEpyNjhTEjv09Nr4a9Dauy1Dv7/1MBQzG3Yr1dlJd0c5uHlgYDFhnDLMrDYdmXhWQYAgOKHtgEyRIAdM/njEsPdnGTqQ/bpTkgCFeqanwXrFScr+vI9kTV/yg0BawrHcRrEPCIxAoAwVxt9NCzcGOMXWV49p/pLnuVimTri9uz1z7wOwyKGPfIXkT1+6t+9f3X7lJUR55kleLz8K3o0Epym/J+XhYReFe88kH9b6yakNXxt3grEuPu5uceR/JZizu1nVh6yM+OZGL/RQpp9nP16bdpFqSvRbygo308/iMnIqdgpRHjCSQpjEdm3a0zTBnuKbdozF4HWTm7GMLLhmnsTDjeRRj5YsMi8kzfgOlIQqlL+WXKUTJzdaN3oQSRFulzyzLctPYdD6I/2vVeXbkSloJ71g6pwYIy9UKrudzhs1gQOisHEghxWF2ySx4zDvex1BPTw/RFPH03yFu6ODy6eKzgRE3Hui7kx+yHPQPqMmDRFw/L1GQVzUP6ibpRi1GxH8JONI4XefpRtAakv2J0O9w9Olu68QVaIOTO2/dPR4b7pqX3acIzseIw8Efr8lLBQ9PWbqLzLxMJ6yFibqKNbwrX8X0ueFxcC9NwAKpwY5q9IJxyN8ZejElMQXS3KQpOS3Ji2vm39Z+L3BoORXwEtPzEjz8jWOysdmGkQq67p32STLjMJSYH8v79nyBr0XZGXAFrgXNzXbeWuvJ68qp5fl8XfwBIDtwtATfe0DBXxka2qIjvIQlLm5jenLS/4WxErW6UbE8Oh3+Zw7EVYAH0ie+NDweAQy297XKl+4ZM8DZQcc7w64+oQVGVMVGF9YsOEZ8UEFOs8PrQmMJWwnb/EDodpg8Rot4LqdsgS3rSumpc6xLAqCDYWIgUYBOISZQH9K8khByP4n+IfQz/7UCVPx6He2HwPXDxgmzwpFXWn+bCU3iSkhypyvMlGdKbWG8b9gL9zIgK5AQVcG8iu7rdDQ2cMBswny8Oh0OmFW/0n/1xuHDHLK+1cLkAGDJU7uNgWhkB/BoJtHJ4i2Zt9cQpSZqAQM3ixj6zmts1xQhBr9aukIOcPWgYvISCvqtRBcdBq/gHIp+xBtv8ztj9NkzLJ10NMti8vDoKgNhJ/NHYMZn4i3It74a+9EvqxDA= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(82310400026)(1800799024)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2025 11:28:38.0374 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 40531d0f-faef-44b4-3931-08dd45d83c28 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0001A103.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4339 There have been instances in past where refcount decrementing is missed while exiting a function. Use automatic scope based cleanup to avoid such errors. Signed-off-by: Dhananjay Ugwekar Reviewed-by: Mario Limonciello --- drivers/cpufreq/amd-pstate.c | 25 ++++++++----------------- include/linux/cpufreq.h | 3 +++ 2 files changed, 11 insertions(+), 17 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 6a604f0797d9..ee7e3f0a4c0a 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -548,7 +548,7 @@ static inline bool amd_pstate_sample(struct amd_cpudata *cpudata) static void amd_pstate_update(struct amd_cpudata *cpudata, u8 min_perf, u8 des_perf, u8 max_perf, bool fast_switch, int gov_flags) { - struct cpufreq_policy *policy = cpufreq_cpu_get(cpudata->cpu); + struct cpufreq_policy *policy __free(put_cpufreq_policy) = cpufreq_cpu_get(cpudata->cpu); u8 nominal_perf = READ_ONCE(cpudata->nominal_perf); if (!policy) @@ -574,8 +574,6 @@ static void amd_pstate_update(struct amd_cpudata *cpudata, u8 min_perf, } amd_pstate_update_perf(cpudata, min_perf, des_perf, max_perf, 0, fast_switch); - - cpufreq_cpu_put(policy); } static int amd_pstate_verify(struct cpufreq_policy_data *policy_data) @@ -587,7 +585,8 @@ static int amd_pstate_verify(struct cpufreq_policy_data *policy_data) * amd-pstate qos_requests. */ if (policy_data->min == FREQ_QOS_MIN_DEFAULT_VALUE) { - struct cpufreq_policy *policy = cpufreq_cpu_get(policy_data->cpu); + struct cpufreq_policy *policy __free(put_cpufreq_policy) = + cpufreq_cpu_get(policy_data->cpu); struct amd_cpudata *cpudata; if (!policy) @@ -595,7 +594,6 @@ static int amd_pstate_verify(struct cpufreq_policy_data *policy_data) cpudata = policy->driver_data; policy_data->min = cpudata->lowest_nonlinear_freq; - cpufreq_cpu_put(policy); } cpufreq_verify_within_cpu_limits(policy_data); @@ -678,7 +676,7 @@ static void amd_pstate_adjust_perf(unsigned int cpu, unsigned long capacity) { u8 max_perf, min_perf, des_perf, cap_perf, min_limit_perf; - struct cpufreq_policy *policy = cpufreq_cpu_get(cpu); + struct cpufreq_policy *policy __free(put_cpufreq_policy) = cpufreq_cpu_get(cpu); struct amd_cpudata *cpudata; if (!policy) @@ -710,7 +708,6 @@ static void amd_pstate_adjust_perf(unsigned int cpu, amd_pstate_update(cpudata, min_perf, des_perf, max_perf, true, policy->governor->flags); - cpufreq_cpu_put(policy); } static int amd_pstate_cpu_boost_update(struct cpufreq_policy *policy, bool on) @@ -824,28 +821,23 @@ static void amd_pstate_init_prefcore(struct amd_cpudata *cpudata) static void amd_pstate_update_limits(unsigned int cpu) { - struct cpufreq_policy *policy = NULL; + struct cpufreq_policy *policy __free(put_cpufreq_policy) = cpufreq_cpu_get(cpu); struct amd_cpudata *cpudata; u32 prev_high = 0, cur_high = 0; - int ret; bool highest_perf_changed = false; if (!amd_pstate_prefcore) return; - policy = cpufreq_cpu_get(cpu); if (!policy) return; - cpudata = policy->driver_data; - guard(mutex)(&amd_pstate_driver_lock); - ret = amd_get_highest_perf(cpu, &cur_high); - if (ret) { - cpufreq_cpu_put(policy); + if (amd_get_highest_perf(cpu, &cur_high)) return; - } + + cpudata = policy->driver_data; prev_high = READ_ONCE(cpudata->prefcore_ranking); highest_perf_changed = (prev_high != cur_high); @@ -855,7 +847,6 @@ static void amd_pstate_update_limits(unsigned int cpu) if (cur_high < CPPC_MAX_PERF) sched_set_itmt_core_prio((int)cur_high, cpu); } - cpufreq_cpu_put(policy); } /* diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h index 7fe0981a7e46..dde5212d256c 100644 --- a/include/linux/cpufreq.h +++ b/include/linux/cpufreq.h @@ -210,6 +210,9 @@ static inline struct cpufreq_policy *cpufreq_cpu_get(unsigned int cpu) static inline void cpufreq_cpu_put(struct cpufreq_policy *policy) { } #endif +/* Scope based cleanup macro for cpufreq_policy kobject reference counting */ +DEFINE_FREE(put_cpufreq_policy, struct cpufreq_policy *, if (_T) cpufreq_cpu_put(_T)) + static inline bool policy_is_inactive(struct cpufreq_policy *policy) { return cpumask_empty(policy->cpus); From patchwork Wed Feb 5 11:25:23 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dhananjay Ugwekar X-Patchwork-Id: 13960866 X-Patchwork-Delegate: mario.limonciello@amd.com Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2042.outbound.protection.outlook.com [40.107.100.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98EF522CBC1; Wed, 5 Feb 2025 11:29:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.100.42 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738754943; cv=fail; b=hQZZ9HaONXo/sLOnUwc+UlCiZe1YJmR9KqPjhSwXAkETRydght4P0PeeltkIjsttmcRZ86j4J4/kZ2xUBb2fmJJGlPskXiNMgFVnu6v/gjDzVFR1qfBwevmhnhxzlnziJHjTNFcLHT4bCqvu98sPNk5VGsQd+zD4B/vixohK004= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738754943; c=relaxed/simple; bh=NNkvG8fjTQh143975pwtjLRJZX8Q3UdJEqoVk5ELndk=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=i319fre8Vqxji6j9Hpb6l3sQL+SZVRE/5JYvs05KTkQrpfRpYq5zccd3E5sm346Nbx6LjDwIY32EuRvFag2FuwSodJIW4pEAibKnE93XbNKD+KkBYGUTcFdrUQLz2a9IzofR0FJ5IkBxjr6un9MMQtx07dAZ/n7poJFqOoVF06k= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=Smq/YD67; arc=fail smtp.client-ip=40.107.100.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="Smq/YD67" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dXts22GNH1/H2Kc9yQTm4CsySvfID01QKRiChsR1f9Iw5IYhkoKXzOlUHlh2hYl6M6iqU70STBD350SEXQq9hVDs4TXIj85XWZ0l0DlhIg2gjP+laVpc+oT1F6g9uzaSDvm+58EnsIf98VuidnkgqNDlO/CAm6W+zwxRNVAngyQYp49QlbAqXBJwYhtOW/WAbGyH/cgKxhOIB88ljEB8h9igN741f+ZN2p+uS5viDub4iuzNCZgD0S759Vmww9e/u+FkyIKSR1Ao5YNoJ5ak01fSjYjaRzlYp/SFGojzavqpfDDXgL1RArAiHV8hqkFW5UwwLVo1SRzsECRoSuhb1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vNZLuiJ3UwXP4RTV5fFsAa3LYNE78pVCXFjThAfL8Ww=; b=UBQqtAODP7bMtsEw/I/g2st+mgQEQjJUpf2OPtlnyevYxeg5B50v3uWEfMHMTEht/fwzd9+iY2ZmkM6KvNVLN5TNNq/WmeKDlrISUDrVqpvZPgBQE1LcmA7bzwGzpqsd/ccqntoCsm0hhKD0JVyk0p1xsUOeecmzp01gosjT7qWOuLxyRuq6+cwzgIuwQmVlDZj0S3djF9pqlovC08Kd5Jo5NMEA2Wac1b/hil37bIL47rudFwDmkeXUp6j/IKY5CW/gVGsZlPGI6EvJJ3IpJztaUI6dGotaKCiYcqhWividivqdEjJ3xAlHsUTf3ld6Udk9I2AgqGFcy5hv88FPTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vNZLuiJ3UwXP4RTV5fFsAa3LYNE78pVCXFjThAfL8Ww=; b=Smq/YD67cqyhU551grtsttzF+PhD80gxO4ZFMlIl/vIvABAhQ/NmUyMakIw918nj4GSQXHC/bPX5I9M0WCwi32sKO7XaSuc4FdDhEuGTPjg95287oSwBrfrrsMlXxuPDb8Xur5wge6yac0Hk2v1fIM1RA3/0FmpuQm/q16xPdP0= Received: from MN2PR11CA0006.namprd11.prod.outlook.com (2603:10b6:208:23b::11) by PH0PR12MB7932.namprd12.prod.outlook.com (2603:10b6:510:280::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8422.11; Wed, 5 Feb 2025 11:28:53 +0000 Received: from BL02EPF0001A101.namprd05.prod.outlook.com (2603:10b6:208:23b:cafe::22) by MN2PR11CA0006.outlook.office365.com (2603:10b6:208:23b::11) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8398.24 via Frontend Transport; Wed, 5 Feb 2025 11:28:53 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BL02EPF0001A101.mail.protection.outlook.com (10.167.241.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8398.14 via Frontend Transport; Wed, 5 Feb 2025 11:28:53 +0000 Received: from shatadru.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 5 Feb 2025 05:28:50 -0600 From: Dhananjay Ugwekar To: , , , CC: , , "Dhananjay Ugwekar" Subject: [PATCH 12/12] cpufreq/amd-pstate: Remove the unncecessary driver_lock in amd_pstate_update_limits Date: Wed, 5 Feb 2025 11:25:23 +0000 Message-ID: <20250205112523.201101-13-dhananjay.ugwekar@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250205112523.201101-1-dhananjay.ugwekar@amd.com> References: <20250205112523.201101-1-dhananjay.ugwekar@amd.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0001A101:EE_|PH0PR12MB7932:EE_ X-MS-Office365-Filtering-Correlation-Id: 32f1e624-f806-449d-3717-08dd45d84533 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|82310400026|36860700013|1800799024; X-Microsoft-Antispam-Message-Info: 7ergN/J0gVUYanWnI0jXtjJldosHjID4aSauzZ9t2Q0oIGGB/it1JAy41labRZH/qcwKC5dpMw3WxC3aaJq2dezrQaH+ct/rgCff05vq0VntT3mxK2vmfnp7/TjjYIv8G0mPQY3zmccfgIUdZzhXSRnROLK2iPbmZ8iVjpHu2N917cGxpqlxboBWlTbf18BMbW1sm4kNeChHfQV5Nk7naItuBKGw4jCDDuj7HaXgPgyv1dyTH2N64gPfuoq6MB9e0xr7Bny3H7PMyAOMR17/iPey2nBVgGhReb4WRNlTZnkrDy98tssOda0r9TUx8KrgeEyys3Rhl/pGth+xDjr5Oii4AMTM5M13DPFlVSEfLMD8ZfhYJsSi1kB1aJmkPV1cXZwc0wUWFIzRx038fhv3l5RV2ectHrqUTUaQNCZP/aY2xRmhqGEufY/hRBNR3T86Ab8LRWo1WdJdBuL7N9iZRpwzufaw8t8blTXitIkHBJHfT7IrsmTVWF99utp8Tkh12FN7hRp8x8w71+OWeJy6N1pHsOr+tma2obvYTBu0fPIB7v7E5qKRODWkVteR4ZQK+AbIx8MkOVIvIrXjIacQg+HxZVwHQnNV+e8EVThs0FH46E9Hcnybjk/vfS+Z5krjDcq7aT8QkhMfARJz8Pq4JqFqAPGRPcny6yZpu+9wrGA/Pgbv1f7bHO2tAQoTIhrrhcsCYnIFBgj1Um8qnTmW2PZ15vtPRcD2Nu8hAkLG34HeOjku3tlulp69+dRGfqi5qa/lAhfUu3JBZwnkFJk6HpmNbga64Z8T4cnJCEOxSir73GX/YfzHOD8v/t95Wg7IdYun4SIa6Q1Ilna6uZQxtqMZDtk8/EP0/bOh0CNDkpNjNTq2Mbxfdp5abqdMEFOWwBFLCSgjjidu0Qw3Vg/zFd78D8MzV4AvOJsbR4l2O1BcfyF0JCsvh3wgxFObiGQ9Ag1kTaYLVF7cch0YaTdEgSIcH9VERap1B1l67Vim0u2ckpzzvfFXR07oep2adTNrmLifeGAoSYbZkoaB9mD4VzaFqOs5HRS7tY5504RnFmX/qqDftFWBR2CCNOjKtCxs9AEiNvJhFgaylg5w1xnMt1lGKqNiptqs3YBN9Xw391uG8vWA3VTif79lS5zNomv7fFN57SY7c4CfpcL20gvSbwWrcRXXIl6d7cSMhL4xZWuVwvLD/+96+L3yDSkVJTL7Ws0UsKoFwLVPaY1bzW8FczwwEEknZaWEtnzxvwg6wtQ9a4sYTWJcAWLVbc5wQtFdCAheF43ayf9rNgcBoq0FYfe7U6YDzTRcwn6DqPGMPNVnmryDt2C7sGexlobDUuKEPAKFheSLfiMs3BZKTgSR8mnxxV/svFyU6Ap6eKlWTRNiD3DNGqkYETWlEb0Oqsd5fJYVjBYsmQoz3ZRIJblrXW6mEK102bve8zM3Y7tJKFQSCT1Qm251Jl+GQSsD6gX9Z69cm/PLLWfNzVSG+saLA7vmfuA4AIQLWlXgaU/HIpo= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(82310400026)(36860700013)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2025 11:28:53.2090 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 32f1e624-f806-449d-3717-08dd45d84533 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0001A101.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7932 There is no need to take a driver wide lock while updating the highest_perf value in the percpu cpudata struct. Hence remove it. Signed-off-by: Dhananjay Ugwekar Reviewed-by: Mario Limonciello --- drivers/cpufreq/amd-pstate.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index ee7e3f0a4c0a..08ae48076812 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -832,8 +832,6 @@ static void amd_pstate_update_limits(unsigned int cpu) if (!policy) return; - guard(mutex)(&amd_pstate_driver_lock); - if (amd_get_highest_perf(cpu, &cur_high)) return;