From patchwork Wed Feb 5 17:54:00 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13961648 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DD4A2C02192 for ; Wed, 5 Feb 2025 18:03:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ejWrq6TGbjAd26qleaa7jEfcM/wgJg4o/vWWPpGilgU=; b=w+9jYr8xYqYpYARA1JgCeZOjCn VH8WySq5HwYP7lQ6rw8mLp4PZoX4AjKeLL04ZWm+bCaNuUBfC1uW5tWKGcHYm/OlDblNZu9eAuqqL BFAqXTZkgezvacS32d2Ry1aPLiIiJmKd96Sp/X/GqCp5wJt0foIUaUzv6x0Nz0dm25JCv8GtVEbpQ oi5XHrttz2GNKrZWuZBSKoL+pdmuBuzJRCWmoiJ8aJNNQrP+gRzGNRugxQlyDBJ6Ahe2dMO2KsMtJ a0NkgvA9jgz5QbL/XlRx8SmyyPGQEHjqgOFWUAt0U0L/X9/6INghtWGCmhyBmECblgpwqXnZs4X6X +8rAGP0w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tfjjc-00000004Bht-0RjG; Wed, 05 Feb 2025 18:02:48 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tfjba-00000004Auo-3uG1 for linux-arm-kernel@bombadil.infradead.org; Wed, 05 Feb 2025 17:54:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=ejWrq6TGbjAd26qleaa7jEfcM/wgJg4o/vWWPpGilgU=; b=GGHAKULb9oNjRoLn5eZabLoxSW kMKIm0NxFkhoLfPn4PS0fGzuObE1H72T9zvZ4vglWr9VE9SLkQVIxocDwhzrdJ+iOYf2Y6XFzEBuK 55JU/eihk4yuQ3tmNgTZUbAHjt6GS37Rr72ad3Ni32di8H0C/RrjOpELWsLlfPMVlwReGLgkhDs6k FnFxAo4UNd2TB4x6sB0SXW8E+HJswf/uafKg2StcwsycuNIypqxmO+NERyYtdo6O+grj3seMlNc1V 0Ub+T7wWhYkqAyAJO8CA1MNwbZnnN6v4OTG8otJfaTW1oQJocFWlZtaqMd0+ciHTRwpaMohIpuGj4 L2E62SGA==; Received: from mail-ej1-x62f.google.com ([2a00:1450:4864:20::62f]) by desiato.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tfjbW-0000000Gk3N-2es2 for linux-arm-kernel@lists.infradead.org; Wed, 05 Feb 2025 17:54:29 +0000 Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-ab7483b9bf7so10271966b.3 for ; Wed, 05 Feb 2025 09:54:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738778064; x=1739382864; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ejWrq6TGbjAd26qleaa7jEfcM/wgJg4o/vWWPpGilgU=; b=xh9TXjgZfXhPiSjfdpxsahW1nDMu7vebEK7J2fB+QaRSZkbza5Ovubaemf5WOHY/RK e1gy5tsCx4RrMfC6f4QfVXL0wr9trKSQCH84Dxg4UCcIKb6wgXMZrOPLbdNKGjsI10Vo qOKgSpgw3f43KLo8xtnad/9i1tNUNUrCAq32zEZgO6qOO1F+3BswqE1BXvz9yeaYjcHq H9rrurJsNKQGKNdAtlLo95HvdMjy6+mQWtSiHmyCEDuEUO6xORbNAEcOLgtjQ3PKuwaP hIIO3NLu+rRhWayn/1xqWx6NYYnbhwhsKM5SrX6SBMdH/VfIRNxURDN1ljpSewxvZgmr f78Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738778064; x=1739382864; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ejWrq6TGbjAd26qleaa7jEfcM/wgJg4o/vWWPpGilgU=; b=KofstXcjxGLfXmGYEa+umTm6yeKXXW++8Lq+CS0N2j7Kw1moTx5/3KokUKN+NjUWCP BGK3HkZ/y6fA2KONXYsNfBS7S2/bxAla1RGSRnedvDlVgsGmc2vovZzW0JcBJwrWoD37 fsTcGM2i6oownWnXvQwVJA7MxPbHg3fPIDwQ01PAIA7rXBiUS4Plk0zCAyHYm3zTe0uL kPFEO1xfy9697rruo2SFMhQmJW9iphM5yDpCyzrdIj+SsuyUgMBuYtML3srMZAjLyRdb JIYBObi+VeFgzermzuWaGLs6nbF5X3CDJE65YtnRw7oIRvHl/9LNU8vMJ6taQ9pg2miN Q8NQ== X-Forwarded-Encrypted: i=1; AJvYcCUkCUqjj/mSfadQUB+HVSwLr1S6EtwdCbLSLxtOlZa+2F/i9n+xKvLklBRbaSY53olzkU/dQ1o3s71e/q8OaOZY@lists.infradead.org X-Gm-Message-State: AOJu0YwXXk8ET/JQESGTLKt/E+gAyRncZvGzGD9392m6rtD/lnwHpszc RbYVQW/n85NB5ipud22XLAarm2uh0nWHix7EPaB9WUIOAHRpa63kc4hIkteepOc= X-Gm-Gg: ASbGnctDRDN0FKDfVEtgbOBzCqM8Y33HZislScwmW1FfU1eMapCNhleztYuy6pEagS4 +eabL1qvbdiY8B01d96sIvAAx096+kMFnlljMnD2AD1GZgzaQ2Bxw97juFVh7fv4tlRl6EQBlpY ECEUZFCFMQGfgipEKkD0wJbl4Iz/zGCFAfgn2F5T3Juy+gM5gdiYLY76QGlLnBnR+weriERyUOK I9OwYhQM3clTPm11abBeHO8qE5ZR5prkZT2nljzDU83V6fZ8NndJdnVgCSVus/uYZdO3uyfGoVE WShbYfEGxhK9vtIY6nEdHZeqhGzGl0HDqGIeX1qDgBUJgXctB9FXM4Qzyg== X-Google-Smtp-Source: AGHT+IFi+I2QYC8SCv1Thd4fTlvD9JpT7oehKfpn2hd6Q7dIRYgFRRv14859tXC16oyIXhFfgdVHFA== X-Received: by 2002:a17:907:7da6:b0:ab7:5c95:3a82 with SMTP id a640c23a62f3a-ab75e216488mr361291566b.1.1738778063563; Wed, 05 Feb 2025 09:54:23 -0800 (PST) Received: from localhost (p200300f65f018b0400000000000001b9.dip0.t-ipconnect.de. [2003:f6:5f01:8b04::1b9]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab6e4a560afsm1116492366b.163.2025.02.05.09.54.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Feb 2025 09:54:23 -0800 (PST) From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Daniel Mack , Haojian Zhuang , Robert Jarzmik , Rob Herring , Krzysztof Kozlowski , Conor Dooley , =?utf-8?q?Duje_Mihanovi=C4=87?= Cc: =?utf-8?q?Herv=C3=A9_Codina?= , linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH 1/3] pwm: Add upgrade path to #pwm-cells = <3> for users of of_pwm_single_xlate() Date: Wed, 5 Feb 2025 18:54:00 +0100 Message-ID: <1829c1a040c707326d9c53aee3577763e2139d58.1738777221.git.u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: References: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2059; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=y7Oa0HXBmU0/PvBO5RRFWrwovXtwoap5Pkcr2yApIVs=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBno6W63WuM92iNknmqYpooawZh3QTBAcb8wp4Xc xEhAhPpMxOJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZ6OlugAKCRCPgPtYfRL+ TpnDB/9o3E5Rkl1Ie3Dz1olMCefNaINVPnui+wUhfYEqUbZraMf8EyoN2Is75BF97QrKk9EVG/O HypieBoLrrq8NTPejeFFWGOWqMdRvydtz/dm1RrryJBV4w1fEO8/egw0MNdwD4CtUkoL69q7N0s GfMipxg5eX5o4eEyibOheuTG6DgGnHHKVl4xkOftWNaaCKmvl2FBQmzlhZQahhnEzJTGZLQIAzF LIJ1vpsJxkN9EWvNp38NXdvcR9VCaGwdddPR+ko+Kw+vul3HuiCTrDls2fcXgFCctX10IbJHoj/ GbS2ikJyLim/5wOOqAcVWPfi/MCu+yjoKCupZ7Wi2c8tyJMW X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250205_175426_953804_2F975CB3 X-CRM114-Status: GOOD ( 19.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The PWM chip on PXA only has a single output. Back when the device tree binding was defined it was considered a good idea to not pass the PWM line index as is done for all other PWM types as it would be always zero anyhow and so doesn't add any value. However for consistency reasons it is nice when all PWMs use the same binding. For that reason let of_pwm_single_xlate() (i.e. the function that implements the PXA behaviour) behave in the same way as of_pwm_xlate_with_flags() for 3 (or more) parameters. With that in place, the pxa-pwm binding can be updated to #pwm-cells = <3> without breaking old device trees that stick to #pwm-cells = <1>. Signed-off-by: Uwe Kleine-König Reviewed-by: Herve Codina --- drivers/pwm/core.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c index ccd54c089bab..bc05818fa370 100644 --- a/drivers/pwm/core.c +++ b/drivers/pwm/core.c @@ -1000,11 +1000,27 @@ of_pwm_xlate_with_flags(struct pwm_chip *chip, const struct of_phandle_args *arg } EXPORT_SYMBOL_GPL(of_pwm_xlate_with_flags); +/* + * This callback is used for PXA PWM chips that only have a single PWM line. + * For such chips you could argue that passing the line number (i.e. the first + * parameter in the common case) is useless as it's always zero. So compared to + * the default xlate function of_pwm_xlate_with_flags() the first parameter is + * the default period and the second are flags. + * + * Note that if #pwm-cells = <3>, the semantic is the same as for + * of_pwm_xlate_with_flags() to allow converting the affected driver to + * #pwm-cells = <3> without breaking the legacy binding. + * + * Don't use for new drivers. + */ struct pwm_device * of_pwm_single_xlate(struct pwm_chip *chip, const struct of_phandle_args *args) { struct pwm_device *pwm; + if (args->args_count >= 3) + return of_pwm_xlate_with_flags(chip, args); + pwm = pwm_request_from_chip(chip, 0, NULL); if (IS_ERR(pwm)) return pwm; From patchwork Wed Feb 5 17:54:01 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13961647 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4F814C02198 for ; Wed, 5 Feb 2025 18:03:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KFbHN5oAc7SgW4VT2zuwkkX5wnrVvIlDHxKFH7OFwgo=; b=PQu/yt+qOIixL13/o+ohByKTuf SOOKjkTBXz9B5U3IzZxOonmfKVbFFy/UeuzQV5NqaTDioJkDSRHqN9nYcSvJ+Bfc5gXnQd8NzdBVl ZSi4H0211zogZjoTwawvnLQr15h2JyYoXnBLVMhEnQ1RR7QAJnF0RBUN96B1MFXwuiRBAHB8RzF5E oScNtYJlH925UUQS4zoZF/kvjc7D6MCVPZ/JK3MT9kyu9Tcr2wkqH4FaUkJiP6gjf3jNXxxVVcJhF F3GlxQHMt7CxS+rB1SYxD9b8cb+wYivDJZSJFOfJZEXXTyfrkuZA/Lh+wNZL3EO6/RSQ8WnQV7JK5 TNTEvqdQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tfjja-00000004Bh3-45sz; Wed, 05 Feb 2025 18:02:46 +0000 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tfjbX-00000004Ats-00MM for linux-arm-kernel@lists.infradead.org; Wed, 05 Feb 2025 17:54:28 +0000 Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-5dcc38c7c6bso148598a12.1 for ; Wed, 05 Feb 2025 09:54:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738778065; x=1739382865; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KFbHN5oAc7SgW4VT2zuwkkX5wnrVvIlDHxKFH7OFwgo=; b=gb0mwi+uR4tQ6hPW9JFqVZQH4fpUzfmg6kG7ZTxg+zSrHNeiFPcOEfXPjL0mfHVm8T b6UkLJALKhl32IFlOxrF1mNf75W4j7R18MknDrjtasrN1EsMwJuqALvoYIURR1RvdzHr 42NxhW21l+MQUxXnnmx7e7Afyf3522dcysIII0GipyypVDOzBKLZUJ/AZ7eiLjdCL16E V3hrV46zgXq01fqB7+rF/G8h9od4dbxwJ2nnoJMF82ACAmTvUgQYI4sEiAad5qJjOAlX TBsl+xQziJ4X52TOVJH8O5q3EAUOsRkb/rIQ5EoRe+oTziQgskW33H/X9hsOvWZcyR7f c9Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738778065; x=1739382865; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KFbHN5oAc7SgW4VT2zuwkkX5wnrVvIlDHxKFH7OFwgo=; b=r3LHVVafsZWGv+PCyQnHCrsqvbGsw5RBoiv9Y6w6QAlHCXQqBiWSd+rfa9n7jTkGGA 5i1fQn/rBjWulXeoH06qSGbNNUpSNcDfQmRUgDKzdMoPZPK/DIwiPB85IspupANsf+X4 X7l3cV2V01o8nlrTPkCOX/r6rzq+u2YjmG0aqT2qSJOodJRpTRC7ed3oHFpKIyhfqA2e +/WgVZF0goNtOUjYB/uDr5pF7/TvMCmDae59XE2WtEQhxdJ0VjrW5TMrj2c5AxNwIB9L Gl4lPjK8XP0dUDh6yu1oGMfwLPsdNGpooVKOTjoTKedYpT+rtp7EwiPi/DM/S/44FwS/ sG+w== X-Forwarded-Encrypted: i=1; AJvYcCUyxqrlzQ2K7TlTKiz/1eDwzqr7oYxnB78DJfKe/7bWkSrcl2thfH3m8P49Wn3XlntrELaTLlM/q3zIsQqBxb14@lists.infradead.org X-Gm-Message-State: AOJu0YzEAnXI3aXvdxvQA4LzyZbCFXOQnOkwLGor+MP73ZmI6vNkxeTe JtHl4LWrewzoAN9HL9IAnGNbHvbOIvStDrXzOV9THKLlAjtBoiRXzOWHkq3c0QruORrzlocbxLx NdAM= X-Gm-Gg: ASbGnctWiXnOcI51NhLU5s5ub723F9XGAA9zdO9pcTwUmxExRl6s8KG7KOi37CKq1/+ U+l1j0uaM88xyGBO6/RJh9ZRf99cnannhE6XUgu8/+fy/eT3h8KoYz4pn+KxKkuxFt+Rf/j8ynf BPT32jz9J/8Y+bLqltw1LyTMcwyBivpIqlBI+rRLefnEOHcEl1VPUleccodRMKy9jY8DCXKPbMn GrDnVp/72yG6LnrQIqHukNVn/O7KFLbkyVI7VhOzQ65sYCN4zxadUxtmWL7rNdy9SyTiU1zJO2E xvq/lX3We3QRbqAujxJxt1RXoBe6D6nmBzxlOmRXkBiafnaXNyOjGg+I9A== X-Google-Smtp-Source: AGHT+IFghfD4xU69d9XitN+9G/D9V5XoV5J6reB++FH/B/My9SQ8BVRJedHW6F+AYAfpPxe7ux9Rcw== X-Received: by 2002:a17:906:3985:b0:ab7:6606:a8ba with SMTP id a640c23a62f3a-ab76606b5a8mr232774466b.11.1738778065181; Wed, 05 Feb 2025 09:54:25 -0800 (PST) Received: from localhost (p200300f65f018b0400000000000001b9.dip0.t-ipconnect.de. [2003:f6:5f01:8b04::1b9]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab71166a8e0sm773920366b.158.2025.02.05.09.54.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Feb 2025 09:54:24 -0800 (PST) From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Daniel Mack , Haojian Zhuang , Robert Jarzmik , Rob Herring , Krzysztof Kozlowski , Conor Dooley , =?utf-8?q?Duje_Mihanovi=C4=87?= Cc: =?utf-8?q?Herv=C3=A9_Codina?= , linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH 2/3] dt-bindings: pwm: marvell,pxa-pwm: Update to use #pwm-cells = <3> Date: Wed, 5 Feb 2025 18:54:01 +0100 Message-ID: <266765abb8251bd60796a3c4270e3809bfff952e.1738777221.git.u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: References: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1088; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=TpqSOnoMvrWXemfbgCJPH3YeRF/bonSoXcUzvWn+vu4=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBno6W8dWtaj4cUMGIwF5w5gV/ZCp2eGvCr2v81c xn87SbAtPiJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZ6OlvAAKCRCPgPtYfRL+ TvDUB/907bHQIbHV5ok48M2kKVOeEpYDp08cDbKuaYia/Fx2N0v/7FH8AAWICZRZLE/vEcZnGNM qg+R3mYZYFjgLW28Lh7bp5FOej7vUkYnVp09JCxUxSWUjPXTxn2H5My3eg87CRLyq5yOAePQ1uh emNu6O+cTTCjRZSSrgokGalcnxjLoWtUnsesv+Yj1O6vWAXmdSStfvqMdieyXy98weBV8dlDX3Q 9vgdy3nPQXzfL7iUWnSEgOrq6A1Vo9Bc28UtwB+lrPjrfIMcHQR9cH5+/3jOJKmdNS/BI60IIBF sjioh4W2VjZEKROmBBBuuWUG5RS/ISyXtAxWI60A+FLWV/en X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250205_095427_038917_8D1E4BE1 X-CRM114-Status: GOOD ( 13.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The PXA PWM binding is the only one that doesn't pass the PWM line index as first parameter of the parameter cells. However this can be upgraded to the mandatory binding for all new PWM drivers without breaking compatibility for old device trees using #pwm-cells = <1>. So bump #pwm-cells to 3 with the (undocumented) promise to keep the old behaviour for #pwm-cells = <1>. Signed-off-by: Uwe Kleine-König Acked-by: Conor Dooley --- Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml b/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml index 9ee1946dc2e1..ba7fba67e19e 100644 --- a/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml +++ b/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml @@ -25,8 +25,7 @@ properties: maxItems: 1 "#pwm-cells": - # Used for specifying the period length in nanoseconds - const: 1 + const: 3 clocks: maxItems: 1 From patchwork Wed Feb 5 17:54:02 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13961646 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 77D84C02199 for ; Wed, 5 Feb 2025 18:02:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=x0qvYmPCyPNFC5gLGw5pr5m26K+35wbL4YftBfSGxVs=; b=FcOjGgDih5n30ZIt7G6nAAsvED OvIXQ6Y3uxWJczcKs6mnG11uTlh+xGTiUQtFgyUUo+s/mUszcB+yDXSZH1J2Uo/Be9kNdQ/SRCsAi 0NQWRfBMn/gui+h8r+DHduHqebq0P2bGkYG2DYc7fzlPiG0MstCsB4Ow5/tHK4laFIa6FOOJaQGHa VVUOhn1XC826bjAM5DHcnQS9ilhCcuP2un3lQq9Axd5KbL3MUFxwlgLEt2h4k6P3Rjn3b1EvrY90g KUfQ7qbH/ibKkf+YVX3XiB9EJXDVNG84eba/wuBChvz+V/yhh/vQ9daF0wEY5c6tu/VuvjSrPL1Ea IQtQ6ngQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tfjjb-00000004BhQ-2J8X; Wed, 05 Feb 2025 18:02:47 +0000 Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tfjbY-00000004AuH-1qIn for linux-arm-kernel@lists.infradead.org; Wed, 05 Feb 2025 17:54:29 +0000 Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-ab6fb2940d4so218741866b.1 for ; Wed, 05 Feb 2025 09:54:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738778067; x=1739382867; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=x0qvYmPCyPNFC5gLGw5pr5m26K+35wbL4YftBfSGxVs=; b=RPkhyrVu20/91+SCrAf3r/ojFUiBwDWI4uKxhXKBVJzQ7U4NYsvjqFV+NlHpPE3q2Z IMo27BIsLxoOMexuufdpfEdkj9mt4d29lamZI6gNU5jxXLmK6VXIxVx2uBoMH22C2dMd zeeAxqoy212aXw17sfCX5Ed5G61WtKuHtUDHe5KEnl0IvVzhn4SwWCrV2Nm6tUvxtpXo OF6FS05MlOfhMpe4SJp5zGNFPv6qx3cwsqjTxgvrTwAeWaZfBWVAnPxj08Uz/qkXskVB hidT5XGbNVO9MoyXMjmOu7bzdR1EIm1TQFAUFT61kMJiFwe1+VNvwc0KNAJ2mWjvI0dm ZFjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738778067; x=1739382867; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=x0qvYmPCyPNFC5gLGw5pr5m26K+35wbL4YftBfSGxVs=; b=UsGlUkFKLBGP/rbm7jWI2M2hwbTqDm1QYNWDIz0Ubzl/hPEuZLGhcdiAR5o5baO3SN 2RFKhMrNJERzFfOTIyBVcl+ymrDDkmTFbCPZTMIzCYGCLqyypBlQRsrzVGDSi51LkjzE o1anMnEZ3BL3qvI7eDiH3qGQRfVlGECsro3E0Fdp2JB8TTOUHohKK4HcAa4pnBrjoprq B2JuKHfk80XzV1MmJkXFTX6b9nEJAdR542IuUpSwxelvLgf5FVgQrkrmYkk6UQ393n+k KRaI4TlKUvk4GKyphGJAPQj9+gbOm/4GAR8CEobXXJauPUd3Jr2V38g/hqxovXPF/+iU hvew== X-Forwarded-Encrypted: i=1; AJvYcCXI3j/8GRneln57NCryOWisR8jZaBA5AtUBJKKN3mDMmArNtkGhcQ4h0h3eyJZQ21mAg/KgFJ9TKohpfPiwHUlP@lists.infradead.org X-Gm-Message-State: AOJu0Yzenyl802QIUOtj4qU79lzwc1Oo5boUR7icbcRjBNeo4CWQ5n2Y xmglJ3ZwsyXTTwYu5eNCa6hXMxZtajEwAhJImkrLE4tjcs++U4z71r8oQ02JOjhnDScJ5u88A9Y pJ8g= X-Gm-Gg: ASbGncuqDDJjbbQdjwY6t/P2f91LISubMsRXnkm4bfbS0CQIF2iMqkatSM+fnufdGgJ cBLxbHgasFKs14Oj5giV0H9ZoOBmUBZt/zJXMo3yAZCMoHzqyzJmUqab16pUbexYtAUBMeEZnod 5gXuJF7pkTcWVy3WEcg1vpzzx9zH8QbEk6uovuIxCSA2d2VxdpVGBdShYdRwmoCM0RRvzTTinDa Z9T3k25N+Ax3CXZUaXxdlc8tH3aGE+aEizOuwwZt3Wb1Q38VKUWT3mYpGrMH0uEp315WyimTTCm GR30WHI6isEAcquOi+gidQkWJlRMaqX/NbloSmPXvC4DOUfC6s9O2Dq7ow== X-Google-Smtp-Source: AGHT+IF92wMPufEGt9cvnv832yheronJqrKc1D31ugycDeyrAicJl2GAOxWT42IXWDLHshxUJkJSnQ== X-Received: by 2002:a17:907:7b9f:b0:ab6:ef92:c238 with SMTP id a640c23a62f3a-ab76e9876bdmr31149666b.20.1738778066758; Wed, 05 Feb 2025 09:54:26 -0800 (PST) Received: from localhost (p200300f65f018b0400000000000001b9.dip0.t-ipconnect.de. [2003:f6:5f01:8b04::1b9]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab6e4a5b5ebsm1131303866b.181.2025.02.05.09.54.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Feb 2025 09:54:26 -0800 (PST) From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Daniel Mack , Haojian Zhuang , Robert Jarzmik , Rob Herring , Krzysztof Kozlowski , Conor Dooley , =?utf-8?q?Duje_Mihanovi=C4=87?= Cc: =?utf-8?q?Herv=C3=A9_Codina?= , linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH 3/3] ARM: dts: pxa: Use #pwm-cells = <3> for marvell,pxa-pwm devices Date: Wed, 5 Feb 2025 18:54:02 +0100 Message-ID: <9722b7efc8b9dfeac6ded6302e026f538cde9518.1738777221.git.u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: References: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=4037; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=iBU9OUHxDFRwrkGtwor16WU4NZhH5SNhALBCHkrsTmA=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBno6W/v2o83YpyNGfd1Rl33qRbjwDiFw+kiB5NO 7QJ/ueiAxWJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZ6OlvwAKCRCPgPtYfRL+ TjimCACv1XnU/EyqtKVJ7VMA0V++XPrQAxgKrYl92evq7HhjlahPkqlzO6fTqUUSkmZOicDP2Et RrsaWMsd7hA1yIZ4GJotAhKIDXOnQ1Ujol08cJVsdgqQmLxWeWf7rqq4POxE7kjegWSbPk9EhNW ewx4DQPY9PYODSmPoRzpDODC7nC+v/hotdTSCdYG/i1P8F+sx7TB953LdLlHnTHuA1ge7R/WLhq u56rGSqjyR2N1aZ5OLDCpRtjO4EcBvqdLlU139QbhlFTU+qcg4YpaMOgX9RfvQUktJ3XIg8G4AS 59lL5JfYfzr6qGEPQUgpPBssvXuddxVMYc8bKSvOEcpWP3PE X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250205_095428_486894_DA840374 X-CRM114-Status: GOOD ( 14.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org For consistency with most other pwm bindings, also use 3 cells for phandles to PWM devices. Signed-off-by: Uwe Kleine-König --- arch/arm/boot/dts/intel/pxa/pxa25x.dtsi | 4 ++-- arch/arm/boot/dts/intel/pxa/pxa27x.dtsi | 8 ++++---- .../arm/boot/dts/intel/pxa/pxa300-raumfeld-controller.dts | 2 +- arch/arm/boot/dts/intel/pxa/pxa3xx.dtsi | 8 ++++---- 4 files changed, 11 insertions(+), 11 deletions(-) diff --git a/arch/arm/boot/dts/intel/pxa/pxa25x.dtsi b/arch/arm/boot/dts/intel/pxa/pxa25x.dtsi index 5f8300e356ad..d25065caeebc 100644 --- a/arch/arm/boot/dts/intel/pxa/pxa25x.dtsi +++ b/arch/arm/boot/dts/intel/pxa/pxa25x.dtsi @@ -67,14 +67,14 @@ gpio: gpio@40e00000 { pwm0: pwm@40b00000 { compatible = "marvell,pxa250-pwm"; reg = <0x40b00000 0x10>; - #pwm-cells = <1>; + #pwm-cells = <3>; clocks = <&clks CLK_PWM0>; }; pwm1: pwm@40b00010 { compatible = "marvell,pxa250-pwm"; reg = <0x40b00010 0x10>; - #pwm-cells = <1>; + #pwm-cells = <3>; clocks = <&clks CLK_PWM1>; }; diff --git a/arch/arm/boot/dts/intel/pxa/pxa27x.dtsi b/arch/arm/boot/dts/intel/pxa/pxa27x.dtsi index a2cbfb3be609..ed07b65cc362 100644 --- a/arch/arm/boot/dts/intel/pxa/pxa27x.dtsi +++ b/arch/arm/boot/dts/intel/pxa/pxa27x.dtsi @@ -49,28 +49,28 @@ usb0: usb@4c000000 { pwm0: pwm@40b00000 { compatible = "marvell,pxa270-pwm", "marvell,pxa250-pwm"; reg = <0x40b00000 0x10>; - #pwm-cells = <1>; + #pwm-cells = <3>; clocks = <&clks CLK_PWM0>; }; pwm1: pwm@40b00010 { compatible = "marvell,pxa270-pwm", "marvell,pxa250-pwm"; reg = <0x40b00010 0x10>; - #pwm-cells = <1>; + #pwm-cells = <3>; clocks = <&clks CLK_PWM1>; }; pwm2: pwm@40c00000 { compatible = "marvell,pxa270-pwm", "marvell,pxa250-pwm"; reg = <0x40c00000 0x10>; - #pwm-cells = <1>; + #pwm-cells = <3>; clocks = <&clks CLK_PWM0>; }; pwm3: pwm@40c00010 { compatible = "marvell,pxa270-pwm", "marvell,pxa250-pwm"; reg = <0x40c00010 0x10>; - #pwm-cells = <1>; + #pwm-cells = <3>; clocks = <&clks CLK_PWM1>; }; diff --git a/arch/arm/boot/dts/intel/pxa/pxa300-raumfeld-controller.dts b/arch/arm/boot/dts/intel/pxa/pxa300-raumfeld-controller.dts index 12b15945ac6d..9094ec422577 100644 --- a/arch/arm/boot/dts/intel/pxa/pxa300-raumfeld-controller.dts +++ b/arch/arm/boot/dts/intel/pxa/pxa300-raumfeld-controller.dts @@ -56,7 +56,7 @@ backlight-controller-pwm { compatible = "pwm-backlight"; pinctrl-names = "default"; pinctrl-0 = <&pwm0_pins>; - pwms = <&pwm0 10000>; + pwms = <&pwm0 0 10000 0>; power-supply = <®_vbatt>; status = "disabled"; diff --git a/arch/arm/boot/dts/intel/pxa/pxa3xx.dtsi b/arch/arm/boot/dts/intel/pxa/pxa3xx.dtsi index f9c216f91865..4e69b4da0ba6 100644 --- a/arch/arm/boot/dts/intel/pxa/pxa3xx.dtsi +++ b/arch/arm/boot/dts/intel/pxa/pxa3xx.dtsi @@ -224,7 +224,7 @@ usb0: usb@4c000000 { pwm0: pwm@40b00000 { compatible = "marvell,pxa270-pwm"; reg = <0x40b00000 0x10>; - #pwm-cells = <1>; + #pwm-cells = <3>; clocks = <&clks CLK_PWM0>; status = "disabled"; }; @@ -232,7 +232,7 @@ pwm0: pwm@40b00000 { pwm1: pwm@40b00010 { compatible = "marvell,pxa270-pwm"; reg = <0x40b00010 0x10>; - #pwm-cells = <1>; + #pwm-cells = <3>; clocks = <&clks CLK_PWM1>; status = "disabled"; }; @@ -240,7 +240,7 @@ pwm1: pwm@40b00010 { pwm2: pwm@40c00000 { compatible = "marvell,pxa270-pwm"; reg = <0x40c00000 0x10>; - #pwm-cells = <1>; + #pwm-cells = <3>; clocks = <&clks CLK_PWM0>; status = "disabled"; }; @@ -248,7 +248,7 @@ pwm2: pwm@40c00000 { pwm3: pwm@40c00010 { compatible = "marvell,pxa270-pwm"; reg = <0x40c00010 0x10>; - #pwm-cells = <1>; + #pwm-cells = <3>; clocks = <&clks CLK_PWM1>; status = "disabled"; };