From patchwork Thu Feb 6 17:03:05 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mateusz Guzik X-Patchwork-Id: 13963348 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FB36238B60; Thu, 6 Feb 2025 17:03:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738861404; cv=none; b=jZP+9pHNyMVpXmHSWa2K5F4IReKxpq49HoVBsBIVFTgXLrhfzd51fyjyOP2EZM9hkycLD62AyDpnFh60Z5ZNURyBahoXda1wLb4p3OMTp9G+02xMWfjRJP9s/YeG3ELbx/QHYqLIB0WPJfNr9nSZsCS37Es62DLNd4BW1ChyXhM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738861404; c=relaxed/simple; bh=4G8n1qurah9/XX1SC2smoTLg2Y9foGcrGOVNXh1LxsU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dS6NxNFhlAEW1klCsqrxIW8OwbxzRrw+Av5qpHQ0gyjF7qWtnpPD+s3mn6Qwc592y64ZOinNZQ7saywZGDrjuWmSEGnsnMcykNeTuZSPiDFo4VX3zORfqt6kfvQI6Gh0K28D7a1zHbG19iU4fMIB9175KdXyoOaRXsxm0Cdr8Lk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Cixr7hAa; arc=none smtp.client-ip=209.85.208.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Cixr7hAa" Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-5dccc90a4f1so2441143a12.2; Thu, 06 Feb 2025 09:03:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738861401; x=1739466201; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LkZ4mmpYGy6ykhwXe8VklrwlkGdH0hD7/Bu+hQ/Ji0Q=; b=Cixr7hAaAw0gKfEKDBI2amrReyYsGAdso6egxmrcuTXw5G9QuZGEKG7x1ybFXhxPRt ntUHrlH3YFUPboGtVaAFpS2nm3xCK4h6QZ7sd9LylND9b4mUR+PB4nLjywlQ8IpK/Vsg 8s9OyAw4fNzQZ5bpOLqm4hMLdYancK0HA4gcqn7IA1y9D0CW43ccT6mVDHAphRgQLIZU u/lq5EhmgTGwslX1rkTQq5bzIDnWY1Ac/ig2CiO50DI9tuDW9mX4nu2sF5a2LAsWGRLI lroAGEwhZhQ48TP6DZ6C5yXioygC1KeBpTS/OOUQUuxEXJa3LzLB0Lux0XjorCt9YcIC 9SBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738861401; x=1739466201; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LkZ4mmpYGy6ykhwXe8VklrwlkGdH0hD7/Bu+hQ/Ji0Q=; b=t01Nc9Gq8Ozbc+nQsFbn33oBNRp2iaZWP+GRdxat69XEENKj8czrMqz9zBny+Gh2Pl FS8t7bLfr9o9z4eYU2ADW2fU7D/zIXzJgTBW8OS6DfGQkvXF3MPVWF5urX0OaYhgu4rw YW8EKYMBBeBf/an/r8MbS8wdeLdSuumD059pXsJ6QT1bQh6uA5RIBsEEts/9mUehw2pS 4z9LF1oJwvVOMhB2kqk1MbVlqv8wy7CIEckjqdRMHO7RndO799GFH13VJ7HttmnR/oVe HNCKqthK7h46J+EOEpDCgafMc9UQIPAJzBOWmk5Yq/LZwrINQmrLCkujW3Y03AL2jWAW 6W9g== X-Forwarded-Encrypted: i=1; AJvYcCVDHzMKB901UrfB2a0YUICBWq1nxdUHrQEFUNm/HHWJptzKx7dcbAWQ+TJAYxGdCGvi7aKbi1ZOr10a5YdI@vger.kernel.org, AJvYcCXxN8TJnOc5qoSTmlzEeUvv+4DAdaHT/w4gsuyjs3afqujUl1Ok701UPctgFNHGF25I8Oz1Ls7coGMPLTOV@vger.kernel.org X-Gm-Message-State: AOJu0YwUeBNn3FbAKDwb81i8MrEdaqNCVi/CsNexkz5M29bycGLVBm3T 5Y2OXPl3DHssTJsc+TcRlsE3q+4yzuKs3kHoYbvcJ5b5vzChSNqd X-Gm-Gg: ASbGnctJ97ofoKPxpreSjexmB2pPYnVhiRczeO/ykr94Oab+4i7Gvno+cEGC5xNGPx5 DkR1rtOyT4VLMnRhFaNlZcvPFqoitJm0/nvLcZqFJq67OleWihXt7JlTxGZKVSRo5td8cFX6THc FCkGikMpnDrfVS6hvS/HWAAMrUzaqgNyXVvu+m51fyGZaF5YsWBbMKjS1oWcA6vzqQjX6godAVB SSoiS3y+pBixSkSBRhmaDfevAHPIQpRhL5IaTvUT5ePjZB58zLS7rlkEcQIldm5wRBTdyNBxrCV pgaJbzu6GRYDFl/m/JRjimffpITbJLg= X-Google-Smtp-Source: AGHT+IFM8acniUSaMumLoXI6jeGdM4syBvlj6OMz9GAtJJEkeaEku/dzNyqa4HgNItmqlH573bIXUA== X-Received: by 2002:a05:6402:354b:b0:5dc:d0be:c348 with SMTP id 4fb4d7f45d1cf-5de45107542mr109822a12.20.1738861401131; Thu, 06 Feb 2025 09:03:21 -0800 (PST) Received: from f.. (cst-prg-95-94.cust.vodafone.cz. [46.135.95.94]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5dcf1b73995sm1158110a12.7.2025.02.06.09.03.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Feb 2025 09:03:20 -0800 (PST) From: Mateusz Guzik To: brauner@kernel.org Cc: viro@zeniv.linux.org.uk, jack@suse.cz, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Mateusz Guzik Subject: [PATCH v2 1/3] vfs: add initial support for CONFIG_VFS_DEBUG Date: Thu, 6 Feb 2025 18:03:05 +0100 Message-ID: <20250206170307.451403-2-mjguzik@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250206170307.451403-1-mjguzik@gmail.com> References: <20250206170307.451403-1-mjguzik@gmail.com> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Small collection of macros taken from mmdebug.h Signed-off-by: Mateusz Guzik Reviewed-by: Jan Kara --- include/linux/fs.h | 1 + include/linux/vfsdebug.h | 49 ++++++++++++++++++++++++++++++++++++++++ lib/Kconfig.debug | 9 ++++++++ 3 files changed, 59 insertions(+) create mode 100644 include/linux/vfsdebug.h diff --git a/include/linux/fs.h b/include/linux/fs.h index 1437a3323731..034745af9702 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -2,6 +2,7 @@ #ifndef _LINUX_FS_H #define _LINUX_FS_H +#include #include #include #include diff --git a/include/linux/vfsdebug.h b/include/linux/vfsdebug.h new file mode 100644 index 000000000000..c96dc589fa01 --- /dev/null +++ b/include/linux/vfsdebug.h @@ -0,0 +1,49 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef LINUX_VFS_DEBUG_H +#define LINUX_VFS_DEBUG_H 1 + +#include + +struct inode; + +#ifdef CONFIG_DEBUG_VFS +/* + * TODO: add a proper inode dumping routine, this is a stub to get debug off the ground + */ +static inline void dump_inode(struct inode *inode, const char *reason) { + pr_crit("%s failed for inode %px", reason, inode); +} +#define VFS_BUG_ON(cond) BUG_ON(cond) +#define VFS_WARN_ON(cond) (void)WARN_ON(cond) +#define VFS_WARN_ON_ONCE(cond) (void)WARN_ON_ONCE(cond) +#define VFS_WARN_ONCE(cond, format...) (void)WARN_ONCE(cond, format) +#define VFS_WARN(cond, format...) (void)WARN(cond, format) + +#define VFS_BUG_ON_INODE(cond, inode) ({ \ + if (unlikely(!!(cond))) { \ + dump_inode(inode, "VFS_BUG_ON_INODE(" #cond")");\ + BUG_ON(1); \ + } \ +}) + +#define VFS_WARN_ON_INODE(cond, inode) ({ \ + int __ret_warn = !!(cond); \ + \ + if (unlikely(__ret_warn)) { \ + dump_inode(inode, "VFS_WARN_ON_INODE(" #cond")");\ + WARN_ON(1); \ + } \ + unlikely(__ret_warn); \ +}) +#else +#define VFS_BUG_ON(cond) BUILD_BUG_ON_INVALID(cond) +#define VFS_WARN_ON(cond) BUILD_BUG_ON_INVALID(cond) +#define VFS_WARN_ON_ONCE(cond) BUILD_BUG_ON_INVALID(cond) +#define VFS_WARN_ONCE(cond, format...) BUILD_BUG_ON_INVALID(cond) +#define VFS_WARN(cond, format...) BUILD_BUG_ON_INVALID(cond) + +#define VFS_BUG_ON_INODE(cond, inode) VFS_BUG_ON(cond) +#define VFS_WARN_ON_INODE(cond, inode) BUILD_BUG_ON_INVALID(cond) +#endif /* CONFIG_DEBUG_VFS */ + +#endif diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 1af972a92d06..c08ce985c482 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -808,6 +808,15 @@ config ARCH_HAS_DEBUG_VM_PGTABLE An architecture should select this when it can successfully build and run DEBUG_VM_PGTABLE. +config DEBUG_VFS + bool "Debug VFS" + depends on DEBUG_KERNEL + help + Enable this to turn on extended checks in the VFS layer that may impact + performance. + + If unsure, say N. + config DEBUG_VM_IRQSOFF def_bool DEBUG_VM && !PREEMPT_RT From patchwork Thu Feb 6 17:03:06 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mateusz Guzik X-Patchwork-Id: 13963349 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5523238B73; Thu, 6 Feb 2025 17:03:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738861406; cv=none; b=ubkGMF0i8C+yCElf0nShJh9dlehjBKLWB8TPYxPmZgIti60jANDc2r1Qw+PIKHt4nF8xnOsO7qfve1I2kpIeonBYp27xLMb0+Vw5TbQnZvlAZPRCOql8pwVveAwEX1M/z7FPfB0E8nfqNP/ZtrHJnnRK/AvwG1E0ggHsykMm5MI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738861406; c=relaxed/simple; bh=4bGNyjfePr6cLfEicYz5bD4g9j8T0BUJf9j7LFKGCEg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tAmNiDENxrLrWZ5eQKvq4IpLSdOsTUgdCl8b+Gggi+QiZUHwv98a5y2KhoKPKxUmaft9CmgLYEF/WV6iXEMCdyapOXKXTULFl0SF250iNG+8QoeqVMqsjRbzU3tf1ljZ1USzc33SNi7ACaTZ4XqhYqyLTeRGMrT6aDhml/M3Amo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gu38IcDN; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gu38IcDN" Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-5dcef821092so1375969a12.0; Thu, 06 Feb 2025 09:03:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738861403; x=1739466203; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FEovPneKy6UrZ39w/lOvewEqfwBWVAMdy5819a+Iq1I=; b=gu38IcDNkm3Xo8geR3z3Kh05CvDc5HXN+7q9UI0sksnpnVN/tu3IM3RrkPIGvXUE3P 3X3R4YdTQmLkL2Nqk8FY3KpNkvWaMBOkuS+3g75cqbdbyOUCGfoiUUutfYEjfTYwr19c c+Wi6xqbRcqulyh+6ZpgY/+HLas8kikimmXVltxUa8IKsV5u0n52/r7tQ5Vwx+u/LQOr iTLxf3QJbu6BGxoYr0g/MXv6JobaYYCPlgaZ1uqcdrtryVkA8/pg1zINwXhQ14MXo7B1 +frwEqGqf48Ipu0yk0q00jsPRsl/c8DXoGZPPyy+U0nZRCmg974VYdvUFqdeyyDSl6q6 Q7TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738861403; x=1739466203; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FEovPneKy6UrZ39w/lOvewEqfwBWVAMdy5819a+Iq1I=; b=M+wUFHRtghgcF2eIelN/lyNVyCv4g7Ud2oYmAObt3Q5QpcmThHD+yeIwSTBvC3mxY/ 39JK0EAwblSgygbAXEsPB1saOTIbwOumeqPR7y6Ptbe7FgP28MEUF0SFx9L3uuQMo9aX 0sZHOExtQ4tfThkWMwR2+Xu/sSHhRO202sDVJKHwgNf0F1o+LgDg6g2G8s3WXrWaL0yh aabOB6Cdb3okbxwS9qaGZd/M809hRMLGZL0x4HWe7NIMVXR8hsIdfvTP1crTHhBF8FhS 76AbzwJMv6pG/H9pNbFaXdVHXyLOhCsLm5CCX51WMyEp+MIlzr0mI0SkpQiOsll9o9lT XBZA== X-Forwarded-Encrypted: i=1; AJvYcCVHxxzku2+dkE4ANYyWM72icMH6zj4CdO0phb6mZO0Dt5vyjWA+odXaFQgofG9NPHpl9wTkRN05uuAPmldc@vger.kernel.org, AJvYcCWqDltNFag5ogUQOn9uk0aaA5osVIYFDcOHaSrEKCtD0bQmdJFVc2cunw8zaRxjstuZSaa8RQbFFZJXltmW@vger.kernel.org X-Gm-Message-State: AOJu0YzcF1MwqmtItEiZwuDkRUy18SbueAZhMZLUU1VkKM0WgLZw/a+L ADnpptaH+6T9inJLmWmQHIlrGzJSe3CjgTQxY9/oWNKlhatHo3pr X-Gm-Gg: ASbGncsX1SCVPv2sRGJozwY6EAoIdVnu7BUL8zqQx9mHK3auEtJ6OUbXgnKLI1Ixuae 3xwFzo9EWE8sB9UHeOoY3S40D8aWGnF4ahFfrGJFZxiMHChB1x/fzFh/ouqxZz0UUykjNqVN4fJ ltmyIYpzQYCB4x54PX9oKUy7UzTFPAXzwg+jRoUFAim15C25M6cs5oDaWMOKZOeQ5+oS2tVIwDZ SyiFGMmHAtjnIy0IzWySOrnJSGBPXD9MYIpomLTA2Yyf2lxN4M1Y5LxmPoR4TkuKwa8WmhmnSAR WC2d1kf/Oa9Pg74MIAGky3D3hTzGs68= X-Google-Smtp-Source: AGHT+IGQwNdshHD081tWNYQI/DvmUmpHoi/6DCNjKUx5MrBc6+fl91Og1Q2YslRTGiFHV2X8apgNlg== X-Received: by 2002:a05:6402:3483:b0:5d4:4143:c06c with SMTP id 4fb4d7f45d1cf-5de450734c8mr102741a12.23.1738861402587; Thu, 06 Feb 2025 09:03:22 -0800 (PST) Received: from f.. (cst-prg-95-94.cust.vodafone.cz. [46.135.95.94]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5dcf1b73995sm1158110a12.7.2025.02.06.09.03.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Feb 2025 09:03:21 -0800 (PST) From: Mateusz Guzik To: brauner@kernel.org Cc: viro@zeniv.linux.org.uk, jack@suse.cz, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Mateusz Guzik Subject: [PATCH v2 2/3] vfs: catch invalid modes in may_open() Date: Thu, 6 Feb 2025 18:03:06 +0100 Message-ID: <20250206170307.451403-3-mjguzik@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250206170307.451403-1-mjguzik@gmail.com> References: <20250206170307.451403-1-mjguzik@gmail.com> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Signed-off-by: Mateusz Guzik Reviewed-by: Jan Kara --- fs/namei.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/namei.c b/fs/namei.c index 3ab9440c5b93..21630a0f8e30 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -3415,6 +3415,8 @@ static int may_open(struct mnt_idmap *idmap, const struct path *path, if ((acc_mode & MAY_EXEC) && path_noexec(path)) return -EACCES; break; + default: + VFS_BUG_ON_INODE(1, inode); } error = inode_permission(idmap, inode, MAY_OPEN | acc_mode); From patchwork Thu Feb 6 17:03:07 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mateusz Guzik X-Patchwork-Id: 13963350 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1689C239560; Thu, 6 Feb 2025 17:03:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738861409; cv=none; b=CStkVBOw8OWQyqtQqsg7g62kqmudfhT/Pv8lCwwICjveZL+/Y9paPbhYD0quX+uquo9OEoeKrHkyfdfup4M5xKkiXReL9+DfWoyA9sDIcGUfMcvsEofftfp/ife/MjICx9zb69/Bn4ZkFdU9cZXQfRHsbISe0cTFgZ2kzoupQoI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738861409; c=relaxed/simple; bh=61udqkcEg9wcSq/halgc8JMmMFwwfrBUY4mtNHZNt8M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RicS/Lc8GN43x4cnkq13vgIK56vMDPC9M+xfrEpYgAY5y23tIk+CS5cr7a5DDXgn/L54Lnz27gSxaNDgx3f4OkqtWhZrSUcGlsU9rOhdPApNj5sScQD5J2lkLe6utv46xH+mVcw88QXEQMsFTam1040LHscI9sF1ZVGqJmKq0w4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RNqHFDMx; arc=none smtp.client-ip=209.85.208.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RNqHFDMx" Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-5de3c29ebaeso522282a12.3; Thu, 06 Feb 2025 09:03:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738861406; x=1739466206; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+8Wgr0+Th/eZItEiexHX2VH44yFxgC7CrIHewPAPMnk=; b=RNqHFDMx/pc2H22eltM0tgYygwJ9gKHs0qst45SGIwzVoyj1vSIczCD2jqy3AK8v9o qZakdf/T1+9+IyohtIYqkBgAxFDRmt/NqBKtvGBeyaOzsirBOhSgasVWWsO88DPLqbYN s9+hv33Ck4Ymdu81c0N62a5gTSVzXRDdGRxvSQ4BZBCe0N04lGK8KERgDEggM24PBe2/ V2jrmg76q2ChXotEGIb/GzBbVB48/8JSSF5S8Hx5Bli0modf/anjTkmRVCsqXbzktMNO WUPlcaOa0LMkoNQgGilC55AMhDQ+xblQRXhzLteUoGu19SkPb7Vkix2QAddCK8TQmwcC PMnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738861406; x=1739466206; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+8Wgr0+Th/eZItEiexHX2VH44yFxgC7CrIHewPAPMnk=; b=c4u9SwQNBKHoaVcHP0uhq7gXlZ4hUFMSKnOPJBwFwI0CJUchUFnd6QognLY1c3QCW7 QqEdb3aJofwnYf+7BG30tL5CnR4d2+8H/OuFq3uEcTaDtgLnt0HretxUHoYiJ1PtwnzE wLETqMuc92vawG3Ach7gk2AvPGkEMn/3e1bBZ5iEbR8jIHNYXXtuRJYGySvqe5SWofPP c0G/CS7kPuAj9CmPmWivJLDPB4sIEGZmkjGw1ST9Vsxs0JC1RuL38ehC9GMCWAo0c6QZ Ef/8+tQM6trb+rTjBwQ75BlXoAcV8aDhlxN+FIEqg15/8Q4ITosQWq051WtidrbBwCOq LRsw== X-Forwarded-Encrypted: i=1; AJvYcCV+4FraEJIas6bB9UX+aw8rXLgnlf5b4MbyhrF0I9CcsHc+8Vx+h9+MdxhBkkIRRk1L4Ye+Gfan2kFPjP4P@vger.kernel.org, AJvYcCX0MHWzQzHLX4sPtNwNqEh9zjwOcKroaVe1mA1y913KzxkEDUm7baGVyDqSm+t9dhUfQkYUe87WB0g12l6T@vger.kernel.org X-Gm-Message-State: AOJu0Yy6FOjniMaemghtMR8cMClzlHQ0XV7G80q+JUW41VNzc2jQ3mBK wM4ehCicu/+uaQsmm9lXBgOontNS2aWjEK8MEN5R7dEsbPcqUA3I4A9aZ6+Q X-Gm-Gg: ASbGncsJl8SqxtlfL7SOCu6tBnVH7NMJL7vImgHEQWCESwBDdQFuE5vApZW8GjbiiWn hlxgReZ3OZA7buXXvStonB8Mg/DSDP3NGK9qyco5X2XAY79mZnJyax4WRS0+0gMDlAXgu8SahLu 3po8S1N/0Ik2G1RS+1rzK/8y1vaV2qrHrwxOmg3E9OfTINrGVzN0DKzhHAFaZ1mVjHVwmjJ/OMG dICbqrJv6oLqnzGf1+NVX6GT4JU6Gk9tgHOrPXueY0bUj6fkPCZKgLMTLDkUfmISr/SYBMYF4iP ISVhNHEWSgN2QIThM3ocEjhRL7FBpFE= X-Google-Smtp-Source: AGHT+IGbVRlMNxB4z8E2WSYpSjY9+Wo24eryKSFABGNz/OIqnnhcM2UhXyn0BhWRWOqb2kyUrH6KXA== X-Received: by 2002:a05:6402:13c5:b0:5dc:88dd:38b3 with SMTP id 4fb4d7f45d1cf-5de4500570bmr186504a12.12.1738861405932; Thu, 06 Feb 2025 09:03:25 -0800 (PST) Received: from f.. (cst-prg-95-94.cust.vodafone.cz. [46.135.95.94]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5dcf1b73995sm1158110a12.7.2025.02.06.09.03.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Feb 2025 09:03:25 -0800 (PST) From: Mateusz Guzik To: brauner@kernel.org Cc: viro@zeniv.linux.org.uk, jack@suse.cz, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Mateusz Guzik Subject: [PATCH v2 3/3] vfs: use the new debug macros in inode_set_cached_link() Date: Thu, 6 Feb 2025 18:03:07 +0100 Message-ID: <20250206170307.451403-4-mjguzik@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250206170307.451403-1-mjguzik@gmail.com> References: <20250206170307.451403-1-mjguzik@gmail.com> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Signed-off-by: Mateusz Guzik Reviewed-by: Jan Kara --- include/linux/fs.h | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/include/linux/fs.h b/include/linux/fs.h index 034745af9702..e71d58c7f59c 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -792,19 +792,8 @@ struct inode { static inline void inode_set_cached_link(struct inode *inode, char *link, int linklen) { - int testlen; - - /* - * TODO: patch it into a debug-only check if relevant macros show up. - * In the meantime, since we are suffering strlen even on production kernels - * to find the right length, do a fixup if the wrong value got passed. - */ - testlen = strlen(link); - if (testlen != linklen) { - WARN_ONCE(1, "bad length passed for symlink [%s] (got %d, expected %d)", - link, linklen, testlen); - linklen = testlen; - } + VFS_WARN_ON_INODE(strlen(link) != linklen, inode); + VFS_WARN_ON_INODE(inode->i_opflags & IOP_CACHED_LINK, inode); inode->i_link = link; inode->i_linklen = linklen; inode->i_opflags |= IOP_CACHED_LINK;