From patchwork Sat Feb 8 01:03:24 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 13966193 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BD99372; Sat, 8 Feb 2025 01:03:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738976619; cv=none; b=Xzw3LY0SIf+cEkAjTjh95522ynAVEpFXsjmhaBJTk4anM5i44HbfNCNk/ImnqjA7iUnqXrhpmfMzeL9hJzTda9SkshjoBqMYF9BzZSh9OO+Stb4ksDa1zQYoPLI8zwjAdZ1zKWuKzVgym4Qp6HxJl/NABV0JZuiDgXUiNwfOgIo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738976619; c=relaxed/simple; bh=ifst8yV/EF8FhiBWA8kNBGiz9/Lddb64v4sxlVdCn6Q=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nmicT8aw1wMV9eqYlSvnaTwCK8Bx5HUNwaAKox31b4vFpNG/bI6QcmIExMShwM7IfdBzBVpUkquD6XcL86Lot1co9O3zfVSLcxo2YFwevZhhETSVN8lta5Q7i/CdlWKp+G4y6SHVY8XdKoS+A4hJ9ump9hok9ig3azWrCcfz5Fw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Gs1EAWIz; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Gs1EAWIz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8A3ADC4CED1; Sat, 8 Feb 2025 01:03:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738976619; bh=ifst8yV/EF8FhiBWA8kNBGiz9/Lddb64v4sxlVdCn6Q=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=Gs1EAWIzaOQO5qGIb636mpoLtXGGiQdeN3r0aZz+EKR5DGULecWc252OXnnRAz67E eWWTx0b8Efoc/EhpvcDZtjQoRvdOdb6NbYD+YHSNDqwc0NyemHD/vgDnwQleeF8Q1b NIiyt4dUwfxIVSk0yVWcpYlolLsyublbzczmuZx7uKt4aFXA0dgzH6e7bkD5H1t3Q4 k5unFMhut7bUakDAa5uXnJ1IUag4y/CajiPE/1FI14/5yoBF55zmmYT2deh2A+a2Qi jnzKG55wF1au+LpWsQAR2avk/a/4+jRqDokH43ymtSlZVMYClSEx35jBVJgtvBpyMB PJfF3OXHSfPoA== From: broonie@kernel.org Date: Sat, 08 Feb 2025 01:03:24 +0000 Subject: [PATCH 1/4] ASoC: tas2764: Power up/down amp on mute ops Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250208-asoc-tas2764-v1-1-dbab892a69b5@kernel.org> References: <20250208-asoc-tas2764-v1-0-dbab892a69b5@kernel.org> In-Reply-To: <20250208-asoc-tas2764-v1-0-dbab892a69b5@kernel.org> To: Shenghao Ding , Kevin Lu , Baojun Xu , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Dan Murphy , Hector Martin , =?utf-8?q?M?= =?utf-8?q?artin_Povi=C5=A1er?= Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Mark Brown X-Mailer: b4 0.15-dev-42535 X-Developer-Signature: v=1; a=openpgp-sha256; l=3144; i=broonie@kernel.org; h=from:subject:message-id; bh=txU36oq3S6EeFAm2vapcUDf1FVTUFMI2CXvdCdkMac4=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBnpq1h1qssZ2tgZVALAvsm+bM/SYwoiLcxGeKG+ yzRgOd7yi+JATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCZ6atYQAKCRAk1otyXVSH 0OlaB/4kPnxzbwcET7/a+Y84GwGoq0s1jum6u1dLUNyarASveECdWOqk9LBKv8ufd/wY48RtSPM SUHAKXn3+rqadzwKwpxt4omOyRxllafF0hWoUiXlpMfTzMuXmezRQ/sl1SR98njT0PGm0ip3RWm H8uL5tZTKlXKrdLLqCltEpC8Et8PdzrL0DMpx/KV14jVm1+EZdtUM3nIaYL7t18Wxg0Uhmg7nOr SI0zv0SguIqXH182SW5aujhmWBDpZJWLLD8C+bnitiIYf5UwfRsQIe7GXLa2KQXq/U/6KSqMllS oGyi3CpY+OcIC/lcF4q677tUINlEX5M8wMJrSNaHPPADO83w X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB From: Hector Martin The ASoC convention is that clocks are removed after codec mute, and power up/down is more about top level power management. For these chips, the "mute" state still expects a TDM clock, and yanking the clock in this state will trigger clock errors. So, do the full shutdown<->mute<->active transition on the mute operation, so the amp is in software shutdown by the time the clocks are removed. This fixes TDM clock errors when streams are stopped. Signed-off-by: Hector Martin Signed-off-by: Mark Brown --- sound/soc/codecs/tas2764.c | 51 +++++++++++++++++++--------------------------- 1 file changed, 21 insertions(+), 30 deletions(-) diff --git a/sound/soc/codecs/tas2764.c b/sound/soc/codecs/tas2764.c index d482cd194c08..60d660a88fab 100644 --- a/sound/soc/codecs/tas2764.c +++ b/sound/soc/codecs/tas2764.c @@ -180,33 +180,6 @@ static SOC_ENUM_SINGLE_DECL( static const struct snd_kcontrol_new tas2764_asi1_mux = SOC_DAPM_ENUM("ASI1 Source", tas2764_ASI1_src_enum); -static int tas2764_dac_event(struct snd_soc_dapm_widget *w, - struct snd_kcontrol *kcontrol, int event) -{ - struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm); - struct tas2764_priv *tas2764 = snd_soc_component_get_drvdata(component); - int ret; - - switch (event) { - case SND_SOC_DAPM_POST_PMU: - tas2764->dac_powered = true; - ret = tas2764_update_pwr_ctrl(tas2764); - break; - case SND_SOC_DAPM_PRE_PMD: - tas2764->dac_powered = false; - ret = tas2764_update_pwr_ctrl(tas2764); - break; - default: - dev_err(tas2764->dev, "Unsupported event\n"); - return -EINVAL; - } - - if (ret < 0) - return ret; - - return 0; -} - static const struct snd_kcontrol_new isense_switch = SOC_DAPM_SINGLE("Switch", TAS2764_PWR_CTRL, TAS2764_ISENSE_POWER_EN, 1, 1); static const struct snd_kcontrol_new vsense_switch = @@ -219,8 +192,7 @@ static const struct snd_soc_dapm_widget tas2764_dapm_widgets[] = { 1, &isense_switch), SND_SOC_DAPM_SWITCH("VSENSE", TAS2764_PWR_CTRL, TAS2764_VSENSE_POWER_EN, 1, &vsense_switch), - SND_SOC_DAPM_DAC_E("DAC", NULL, SND_SOC_NOPM, 0, 0, tas2764_dac_event, - SND_SOC_DAPM_POST_PMU | SND_SOC_DAPM_PRE_PMD), + SND_SOC_DAPM_DAC("DAC", NULL, SND_SOC_NOPM, 0, 0), SND_SOC_DAPM_OUTPUT("OUT"), SND_SOC_DAPM_SIGGEN("VMON"), SND_SOC_DAPM_SIGGEN("IMON") @@ -241,9 +213,28 @@ static int tas2764_mute(struct snd_soc_dai *dai, int mute, int direction) { struct tas2764_priv *tas2764 = snd_soc_component_get_drvdata(dai->component); + int ret; + + if (!mute) { + tas2764->dac_powered = true; + ret = tas2764_update_pwr_ctrl(tas2764); + if (ret) + return ret; + } tas2764->unmuted = !mute; - return tas2764_update_pwr_ctrl(tas2764); + ret = tas2764_update_pwr_ctrl(tas2764); + if (ret) + return ret; + + if (mute) { + tas2764->dac_powered = false; + ret = tas2764_update_pwr_ctrl(tas2764); + if (ret) + return ret; + } + + return 0; } static int tas2764_set_bitwidth(struct tas2764_priv *tas2764, int bitwidth) From patchwork Sat Feb 8 01:03:25 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 13966194 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47107372; Sat, 8 Feb 2025 01:03:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738976623; cv=none; b=dc8aexEmTrAT4Z/fzQ46ULfz7pEPzqnmzCMSAc5vQlOt3dVegwakcfa8qOWEPjCBQWh6/MlNMnG2CySdkPCg1XJ/wupKjFQgS7wfNfh16Zp8y1zhtBdb6qd3mV/yMiVRUqw210BDBkcw1w31uEpKeE0IzizRBjN+jdD24DJzQZ0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738976623; c=relaxed/simple; bh=LpB13TyaqfIa/Ah4f9XkGtFnMZnkGvAbfUD1IHR7o7k=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=u0X1aT/d71A6iPSRxa0kVM+MS9GddYopdbpR81UbpjBi8tSGZi4xDAZDOXIAG8r4emfpdLZ8hu4jOUovKUdWOl5czG6X7DT9U70fN6N+MKg64dnIfQ5MKxdB1GaMWEyQsxk8rMsJkAiz3RMFPPDSukV0GY4omxPJZ1dX7Ze/mt4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WKs9/EKX; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WKs9/EKX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E6E6AC4CEE4; Sat, 8 Feb 2025 01:03:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738976622; bh=LpB13TyaqfIa/Ah4f9XkGtFnMZnkGvAbfUD1IHR7o7k=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=WKs9/EKX2cJNMBuAxOCof+y8zQaFB/8QqsCsWf4lmUVDDoXGu1VdhlSyFnDFwIB8g NJ8tNpEo2IW6ngNo7ENigk/lNq8+Om/dfNY239rq1KvKLRmIuN+9Ez7jjh2hZLZqyK iQ1O09C+GlOQ7h9P00w68gUCjSByKM1lK4JmJzniHhDMHdeNIrd0Ya9B1zH7ZVuypA W1d5M4EPdaSK5XV1L/fJYFxtf/oKUeqXYmuHtlBudWV1Ovyv4UhyuF7EmzZ52P/LSo EYGswQ0SrkcevAenOyb5eaeykBSpl5dWTlOTA/P11gi8I4FpqGJS+SP1LRSOSWh217 J4ZDXd+2AdIGg== From: broonie@kernel.org Date: Sat, 08 Feb 2025 01:03:25 +0000 Subject: [PATCH 2/4] ASoC: tas2764: Wait for ramp-down after shutdown Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250208-asoc-tas2764-v1-2-dbab892a69b5@kernel.org> References: <20250208-asoc-tas2764-v1-0-dbab892a69b5@kernel.org> In-Reply-To: <20250208-asoc-tas2764-v1-0-dbab892a69b5@kernel.org> To: Shenghao Ding , Kevin Lu , Baojun Xu , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Dan Murphy , Hector Martin , =?utf-8?q?M?= =?utf-8?q?artin_Povi=C5=A1er?= Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Mark Brown X-Mailer: b4 0.15-dev-42535 X-Developer-Signature: v=1; a=openpgp-sha256; l=1421; i=broonie@kernel.org; h=from:subject:message-id; bh=EeZ9JxtdRfnJDqF7P+IHhZuxKSGMmCozAUcZpgUxIxw=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBnpq1iexnn2unfR4qH4Z/mId3O0APy0a3WEVP8o oss6qxJK0aJATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCZ6atYgAKCRAk1otyXVSH 0Ff/B/9CKmiJdTa8wfAaZiGqifD60xj3mZ9NSOGmvffMxp0M9C1JynX8vyDf2cQQHfJqxwg0woi 20WB4NuaYcyBij6tX04p2uMIesslQ1rV5YG3X//Mk9PflLZh3VMXvCsW7jEOUGUvAXHEPqdHjhD C605zlwdulr+b+OLXAQlNZgemtvyquw77pMPdTcLgVJqgt1A9j6LvJLQEg+UDuO9jYljsjcHtT2 +S51xVcmTu9VLkT4bsuE/FZC/8c6UDYV022JOW2S3J7sgw3lXgYNOUjmk9YxjwRtAQHCdIMsqDG Ne/dS2+lgsFFpwMbjJjYhMdI8d0b24CYRyxGWYwUgMWr62Ok X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB From: Hector Martin When we shut down the amp, we need to wait for the built-in ramp-down before we can remove the TDM clocks. There is no documented status regiter to poll, so the best we can do is a delay. Datasheet says 5.9ms for ramp-down and 1.5ms between shutdown and next startup, so let's do 6ms after mute and 2ms after shutdown. That gives us a cumulative 8ms for ramp-down and guaratees the required minimum shutdown time. Signed-off-by: Hector Martin Signed-off-by: Mark Brown --- sound/soc/codecs/tas2764.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/sound/soc/codecs/tas2764.c b/sound/soc/codecs/tas2764.c index 60d660a88fab..0b033ab51f7f 100644 --- a/sound/soc/codecs/tas2764.c +++ b/sound/soc/codecs/tas2764.c @@ -142,6 +142,8 @@ static int tas2764_codec_suspend(struct snd_soc_component *component) regcache_cache_only(tas2764->regmap, true); regcache_mark_dirty(tas2764->regmap); + usleep_range(6000, 7000); + return 0; } @@ -228,10 +230,16 @@ static int tas2764_mute(struct snd_soc_dai *dai, int mute, int direction) return ret; if (mute) { + /* Wait for ramp-down */ + usleep_range(6000, 7000); + tas2764->dac_powered = false; ret = tas2764_update_pwr_ctrl(tas2764); if (ret) return ret; + + /* Wait a bit after shutdown */ + usleep_range(2000, 3000); } return 0; From patchwork Sat Feb 8 01:03:26 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 13966195 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31D201474DA; Sat, 8 Feb 2025 01:03:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738976626; cv=none; b=rWNMm6/Ax5Qpei5BDQuZNdp0kSTsleye8SzeDGxX7RvBRKYJ8HvRI+XT0UrEBaKrEDRVOs7gOD/fid/WaqCnFNnrCoDkFNa10sRHS8dkKhN2f+SSmM7tBlFZuaECAoTEFlH1GYs7GU6rJ4PVfKKG2bH9t2g8eDVqa88BUjEpx/g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738976626; c=relaxed/simple; bh=OtsO6Z9lH+1FLDdny7dGROduBRJ4anEq15A6eL5dXQM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=r75cqsMMSoiX1ENC9kDDIdvcPCqftMCe9y/al5nuBapF2HESZm5551QSqduNJZJU80GcoDAj5hHOouPfuAEyg4rvKCx/83rwygdhyEvIrEIwmlBoNyt9sUhNfb8t0CDIC9R1AP4SUw7ewTyyNmlpsh60Y1pWTEeScfUFNI8K2Cs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fXZYIBsl; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fXZYIBsl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 363D5C4CEE2; Sat, 8 Feb 2025 01:03:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738976626; bh=OtsO6Z9lH+1FLDdny7dGROduBRJ4anEq15A6eL5dXQM=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=fXZYIBslf6LozJzp94xD7Gt80qs+2lHfEDfQl7GloLN3bpY8HMjP7jZuXqtIF2ZIH tIDoal00d4zJp6y6VXb8XPi7/pHlPYJjo4xatYCBA9fEBqMtyvnClAbf9J+omAxCYA PG1LoPoFlVwJexyCH8q8qVnyajglCRBL5K0kcv32X3nQKIMAnRrux9e3tzRSzjlY8o J7jQVF54rAXJRCrAP5hO1uS9w6MTSP4wbQpwcwxPIEWZv00R1gCKUS4kKA5+by+jSA qssDelYiNTh8JAzBqACIa0vyJlJtlRX7rCWdy67+V+VnkuShSqDPSt/IwcCPJ97xXK T0ZVps3s/iItQ== From: broonie@kernel.org Date: Sat, 08 Feb 2025 01:03:26 +0000 Subject: [PATCH 3/4] ASoC: tas2764: Mark SW_RESET as volatile Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250208-asoc-tas2764-v1-3-dbab892a69b5@kernel.org> References: <20250208-asoc-tas2764-v1-0-dbab892a69b5@kernel.org> In-Reply-To: <20250208-asoc-tas2764-v1-0-dbab892a69b5@kernel.org> To: Shenghao Ding , Kevin Lu , Baojun Xu , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Dan Murphy , Hector Martin , =?utf-8?q?M?= =?utf-8?q?artin_Povi=C5=A1er?= Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Mark Brown X-Mailer: b4 0.15-dev-42535 X-Developer-Signature: v=1; a=openpgp-sha256; l=706; i=broonie@kernel.org; h=from:subject:message-id; bh=5qB82+UstkZhC0QeOUniShAIrw2KQ4uj8p2DRKpkeeg=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBnpq1jv3MwaHS8DYc7vi7Xf7etQui4p+oBJJ/wg faEss1z0OiJATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCZ6atYwAKCRAk1otyXVSH 0KC3B/4mecKiN0X4gtaq7N86iKZZ1IolXLlduqA71F+w9PuiB1mPU7Y+ou8mAR1Lxe9e+E1ONDN Am73xtucTFYq5FPa5tuPJ0so6I4qerRsk/ay0mZsBi/GN5Rav39NH9BVLdnHsdNw/dSi5AA1QdU ajFxxAWpFCcX6ntbofOclMvpgmDgmomQFyECCQkIMBLDKbzceDNzd0SMSY63W2aJN7dfITqg996 uypP7Xgh4E3JDqm80OF7XLScUDsLaYSc/kSu/72odG+yJDJDmRnB+AEEve77g/haml9wEHOgY3E pv8tySz28SAnuH2iJHnud/Dyb317ESzxaXOyG42h30m7EAMo X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB From: Hector Martin Since the bit is self-clearing. Signed-off-by: Hector Martin Signed-off-by: Mark Brown --- sound/soc/codecs/tas2764.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/tas2764.c b/sound/soc/codecs/tas2764.c index 0b033ab51f7f..d01333c7dd93 100644 --- a/sound/soc/codecs/tas2764.c +++ b/sound/soc/codecs/tas2764.c @@ -642,6 +642,7 @@ static const struct regmap_range_cfg tas2764_regmap_ranges[] = { static bool tas2764_volatile_register(struct device *dev, unsigned int reg) { switch (reg) { + case TAS2764_SW_RST: case TAS2764_INT_LTCH0 ... TAS2764_INT_LTCH4: case TAS2764_INT_CLK_CFG: return true; From patchwork Sat Feb 8 01:03:27 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 13966196 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0E46433B1; Sat, 8 Feb 2025 01:03:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738976629; cv=none; b=Iz9XidlAd/46+fy75BN6YNCEWTJ6a1DR7wDGt+0SuoEL72awrfOd/NzfiVLiGxycrxsLyJd+wUlVRI1Yiwu6yLEvoKia4PMs9mh5i/0VlYHip6CVp7H2aaWVIqV6prcTq0mUVz1t4OOacc8QKGBvvvmbk8kyamR/I6kXBxvPty0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738976629; c=relaxed/simple; bh=CSJEkYoSHgw6A84OR8krr3l1atnHur4QgCGXV3vANc0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=c8OoUw6qBIvDaOd7J91DlhRGSjfYNNtVM0bRX+QWs6KMs+g932RTZ957jd8A7Gc+6Nsbrsq5U9q248Tkvj5gtL6ZWoU0J1OYSsd8anKmKPFr/fv1BBztlcpYGAdLZk4lLvO6Bf9pNL4ioRUBqfWNit4c6aEpQZCFrAd/khTLuQc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FIMg4Vyx; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FIMg4Vyx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7AE58C4CED1; Sat, 8 Feb 2025 01:03:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738976629; bh=CSJEkYoSHgw6A84OR8krr3l1atnHur4QgCGXV3vANc0=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=FIMg4Vyx2VctynyIwBv18ADfdQFQSpFJ4y/o9e3/JjezrZdFaY5/F1jWot+jG76L0 /8eAkVqV48Zq8k4h4M4yyvE0sxw1wJP6L+iFCeMzm2b50jePx//SG6DqRDnAbkxGqC qHeuPasGU+lw9x61cKyEHfHj2rk1M+gQs8+dDJDkJ2+F0gDsbKq2S3o3QLvyo08VbV o/pbIYgqMtSqv3zH44qKSXAMh4EXG5VjsP2V0idVu71wPJ7x7q3LPSleHNUuMUV8gd ONl/pltNWqDzVDi+GVV6VQ0tc05YfLMDbYHxEAHrKFgWS3pfWDd0F6LsWGSojqcJGO A/pwSprNO37HQ== From: broonie@kernel.org Date: Sat, 08 Feb 2025 01:03:27 +0000 Subject: [PATCH 4/4] ASoC: tas2764: Add reg defaults for TAS2764_INT_CLK_CFG Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250208-asoc-tas2764-v1-4-dbab892a69b5@kernel.org> References: <20250208-asoc-tas2764-v1-0-dbab892a69b5@kernel.org> In-Reply-To: <20250208-asoc-tas2764-v1-0-dbab892a69b5@kernel.org> To: Shenghao Ding , Kevin Lu , Baojun Xu , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Dan Murphy , Hector Martin , =?utf-8?q?M?= =?utf-8?q?artin_Povi=C5=A1er?= Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Mark Brown X-Mailer: b4 0.15-dev-42535 X-Developer-Signature: v=1; a=openpgp-sha256; l=648; i=broonie@kernel.org; h=from:subject:message-id; bh=QB5fTSuWQRpBnz3TTt9b1t0jCO37QmgQ/WwnFRiQkBQ=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBnpq1jzB3C18ei2mHXnLmDEgPbn3b0h3Qr/S27H qFTeJ5wmDyJATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCZ6atYwAKCRAk1otyXVSH 0NXPB/4hP+54x8ywEjRgl75Ek2u0RmyrsCz/6qm8/a7B9jJRhfKM/iLG+Bp3Ty4aqDBYk83TiUH FCx758Hx2JLR0pUphlEO8lYM/lC3v2NpHPCvOx9pcoi5KFTyhZ9qx9VBpLJoBvBowIoGZLuOphk 4FkbuFyL4YLh3LQ8xETyMXmrr/UR1P9A5aCiiCyp1v/shpZn/hzKd/ly+fRo9FT64/U6RFo73uh L+qXCVzbKaMIeUYOTD8/X5WW9oWlRb+A8m0P0CssSBFZU3AJTvQabAzPqbnc4YYVqviq89vKn2f ZSQt7lB+XJB/x/NMcThqKx6we7DbokKlpC/fOzMs6VmIy7US X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB From: Hector Martin Signed-off-by: Hector Martin Signed-off-by: Mark Brown --- sound/soc/codecs/tas2764.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/tas2764.c b/sound/soc/codecs/tas2764.c index d01333c7dd93..49d32e957789 100644 --- a/sound/soc/codecs/tas2764.c +++ b/sound/soc/codecs/tas2764.c @@ -625,6 +625,7 @@ static const struct reg_default tas2764_reg_defaults[] = { { TAS2764_TDM_CFG2, 0x0a }, { TAS2764_TDM_CFG3, 0x10 }, { TAS2764_TDM_CFG5, 0x42 }, + { TAS2764_INT_CLK_CFG, 0x19 }, }; static const struct regmap_range_cfg tas2764_regmap_ranges[] = {