From patchwork Sat Feb 8 16:26:09 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mateusz Guzik X-Patchwork-Id: 13966427 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5421E1F30A7; Sat, 8 Feb 2025 16:26:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739031987; cv=none; b=KoQGT4tCvG6MBgQyR+f/blFlX2lHY3v4CjzJx5xMIQVo1zLaByINhTyxiK19+YIe7qCGDlW5j5KE3JYlNxEBsZl48aUIfmaTgGzQAtn3Pj/rad7cqLNtHdojUwOG/ywK1QXF/bm8t4Q3OJrsjFelupdJv6y0JP3gVtGwnEnRYKs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739031987; c=relaxed/simple; bh=thyIzr/hAE1egVwDCAqpAQjTRPiszDQk4UEy0efkMng=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jjpVKur6ylGhbmGoznkLoqUc7USAP49IJkJVde8Zn86l4xMiHAqK5Zjzx4wTcbP3zyrVQ3jV8+fHKvs4oaNfP53zwnApsgRlZpnV1znnR8GFAtx3Jbol8nIED0SxBEI89nJPjCxGC6ShUY0OSJ+H4/O08quZupmHqVEB0Vs6Opc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=R7MoFODV; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="R7MoFODV" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-ab7917fc0c2so244448866b.0; Sat, 08 Feb 2025 08:26:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739031984; x=1739636784; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FWCIQoK+T/QDWA9/1+I0/yGEQa/Cy6uKnjdSGLgFg6Q=; b=R7MoFODVCwcQaDLzw8oFvAUWSD3SMPCkLrBi01nnS727B6+tkXs0D+WdbVzjzAknB6 /s1cvvgm5oOc5LQN9AfZjltDtYpS/UNCFykzj4jhMd3nKoOKHTp3V8kD99LXtZTv8mE4 6KdE14UzgBOGrjUjBtaBvzcJlebWfw7YjIswHVMFNxuYuz23L6yhf7N7LbFfqIDqJUuQ tbXnMyO4Dib67SXVOrxVmim7tm4Az8cHpeA1DhyPotvM9doMcsYYiR2Fgw0JifcQNC1Q 5/TePmH2E+E5iH9I59TuSfuOuY7tav/Qi26wjXlnh0LlwU6T9Kj4IxO7W0xMiO69nvJT Ja2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739031984; x=1739636784; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FWCIQoK+T/QDWA9/1+I0/yGEQa/Cy6uKnjdSGLgFg6Q=; b=iLpTil4qBk9nOoWxaD+/SOaCB0dh4Ugo8DKaO3Ar0ZqMETe7dnXNPRIuIzPSmxEKPq UVXcAYwqg9H7E0OIIn5F3fwu2dFH3NxhIQ6mY/eN9uHmGcZxJJBl5ZYjd4+gkONubTw3 VgFeFvijYLUvrH0X8+XbQR1qLughztfqd77KfE9UCc2T9/dgEvRBvC9/RfsKavFhGoJY vJJrgpmJriev6sgWO59S6t2eVTnR6totJ36VlkBPUjXqeTmUWhAks2RuuyhoCiwjkUM6 oej2/BhQWStfYak1plckvPk6mdSetIwXUA031oLLM4DJKsvjcR9mNLP3NMKfIJS/iRNG ecEQ== X-Forwarded-Encrypted: i=1; AJvYcCVITwmJMtX4l9ZIHf4iEl+a2pehoY3OoAV1TRI8Twfm7k/dUcI51l4xbv2I+wTdcNvRv3m1MqHFddsQeKmZ@vger.kernel.org, AJvYcCW8HYpgSjWdv/ACT90BXWYGfUodk1p5PzqubX8JnWOfEOyciB+0CYmfA1bd6GILG9pCGlqgp3hcFrlHxj3R@vger.kernel.org X-Gm-Message-State: AOJu0YyklEBzbHlSASifI5am/uRe/dvRVO34D/INPc0hCGNsyN+7ePn1 n7cXo5FzoIlIm7QUpuksvzlK356szHTd4/MPt2kKCku+L6fZBUOQ X-Gm-Gg: ASbGncuVAe2U714G71X7sxRDS5rV4dsCBBQOJ3FnIT1fk6NJ9mtIDRrLa9YBkWf4i6w nS0wkrfn9LnAqJ/QBG2g4rwwt3H+Njz6tfbqLOWf3O8VwJPSHRZbvdoy6L0ua8/WGmLD11LVoxB pXmtaHjHQ4ysP2JFyd5EKVJNzch+AhFJiEZByVRDfoH2RymQFy0NDED4F2JUjfwzu4Q6Qi1slt6 TKSw2fdqCJ54QCJ//KFQXaHIJHR5+0VdXQFNMqvWTeXHevRBH+yyg4Ks5WEPy5ePkQE3f7ezcAg McxgM1frUP41+515v1ItKktUxxrvfrqF+A== X-Google-Smtp-Source: AGHT+IGdwjjOGmSnuYHY8CL/kldenIojki/aHYbsTcuF8zRjVjyW5iezgEkwbxSPGF0Wp6g4hDx0GA== X-Received: by 2002:a17:907:3e06:b0:ab7:5d25:88e1 with SMTP id a640c23a62f3a-ab789b2a2a1mr786056166b.9.1739031983339; Sat, 08 Feb 2025 08:26:23 -0800 (PST) Received: from f.. (cst-prg-84-201.cust.vodafone.cz. [46.135.84.201]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5de47d6461asm3193943a12.74.2025.02.08.08.26.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Feb 2025 08:26:22 -0800 (PST) From: Mateusz Guzik To: brauner@kernel.org Cc: viro@zeniv.linux.org.uk, jack@suse.cz, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Mateusz Guzik Subject: [PATCH v3 1/3] vfs: add initial support for CONFIG_VFS_DEBUG Date: Sat, 8 Feb 2025 17:26:09 +0100 Message-ID: <20250208162611.628145-2-mjguzik@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250208162611.628145-1-mjguzik@gmail.com> References: <20250208162611.628145-1-mjguzik@gmail.com> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Small collection of macros taken from mmdebug.h Signed-off-by: Mateusz Guzik --- fs/inode.c | 12 +++++++++++ include/linux/fs.h | 1 + include/linux/vfsdebug.h | 45 ++++++++++++++++++++++++++++++++++++++++ lib/Kconfig.debug | 9 ++++++++ 4 files changed, 67 insertions(+) create mode 100644 include/linux/vfsdebug.h diff --git a/fs/inode.c b/fs/inode.c index 5587aabdaa5e..b73bb0b2dad6 100644 --- a/fs/inode.c +++ b/fs/inode.c @@ -2953,3 +2953,15 @@ umode_t mode_strip_sgid(struct mnt_idmap *idmap, return mode & ~S_ISGID; } EXPORT_SYMBOL(mode_strip_sgid); + +#ifdef CONFIG_DEBUG_VFS +/* + * Dump an inode. + * + * TODO: add a proper inode dumping routine, this is a stub to get debug off the + * ground. + */ +void dump_inode(struct inode *inode, const char *reason) { + pr_warn("%s encountered for inode %px", reason, inode); +} +#endif diff --git a/include/linux/fs.h b/include/linux/fs.h index 1437a3323731..034745af9702 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -2,6 +2,7 @@ #ifndef _LINUX_FS_H #define _LINUX_FS_H +#include #include #include #include diff --git a/include/linux/vfsdebug.h b/include/linux/vfsdebug.h new file mode 100644 index 000000000000..9cf22d3eb9dd --- /dev/null +++ b/include/linux/vfsdebug.h @@ -0,0 +1,45 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef LINUX_VFS_DEBUG_H +#define LINUX_VFS_DEBUG_H 1 + +#include + +struct inode; + +#ifdef CONFIG_DEBUG_VFS +void dump_inode(struct inode *inode, const char *reason); + +#define VFS_BUG_ON(cond) BUG_ON(cond) +#define VFS_WARN_ON(cond) (void)WARN_ON(cond) +#define VFS_WARN_ON_ONCE(cond) (void)WARN_ON_ONCE(cond) +#define VFS_WARN_ONCE(cond, format...) (void)WARN_ONCE(cond, format) +#define VFS_WARN(cond, format...) (void)WARN(cond, format) + +#define VFS_BUG_ON_INODE(cond, inode) ({ \ + if (unlikely(!!(cond))) { \ + dump_inode(inode, "VFS_BUG_ON_INODE(" #cond")");\ + BUG_ON(1); \ + } \ +}) + +#define VFS_WARN_ON_INODE(cond, inode) ({ \ + int __ret_warn = !!(cond); \ + \ + if (unlikely(__ret_warn)) { \ + dump_inode(inode, "VFS_WARN_ON_INODE(" #cond")");\ + WARN_ON(1); \ + } \ + unlikely(__ret_warn); \ +}) +#else +#define VFS_BUG_ON(cond) BUILD_BUG_ON_INVALID(cond) +#define VFS_WARN_ON(cond) BUILD_BUG_ON_INVALID(cond) +#define VFS_WARN_ON_ONCE(cond) BUILD_BUG_ON_INVALID(cond) +#define VFS_WARN_ONCE(cond, format...) BUILD_BUG_ON_INVALID(cond) +#define VFS_WARN(cond, format...) BUILD_BUG_ON_INVALID(cond) + +#define VFS_BUG_ON_INODE(cond, inode) VFS_BUG_ON(cond) +#define VFS_WARN_ON_INODE(cond, inode) BUILD_BUG_ON_INVALID(cond) +#endif /* CONFIG_DEBUG_VFS */ + +#endif diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 1af972a92d06..c08ce985c482 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -808,6 +808,15 @@ config ARCH_HAS_DEBUG_VM_PGTABLE An architecture should select this when it can successfully build and run DEBUG_VM_PGTABLE. +config DEBUG_VFS + bool "Debug VFS" + depends on DEBUG_KERNEL + help + Enable this to turn on extended checks in the VFS layer that may impact + performance. + + If unsure, say N. + config DEBUG_VM_IRQSOFF def_bool DEBUG_VM && !PREEMPT_RT From patchwork Sat Feb 8 16:26:10 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mateusz Guzik X-Patchwork-Id: 13966428 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 493971F30CD; Sat, 8 Feb 2025 16:26:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739031988; cv=none; b=hoRcNCb6Das3itswJxJjMrMf9kSwGeINwWZmiCCN3CvT6nv7ORUZwKeAKd6zpPOTvm4IDw4DfFF5iGQrtE0tLaCofolCTcgbd/Z4ErYniqi+qXRyp0Lc+ugpoi7u/oTMiqsH6Qjy1cfwF4XvXx1PH3GOU7W9VtZslE0yeAg7f1I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739031988; c=relaxed/simple; bh=4bGNyjfePr6cLfEicYz5bD4g9j8T0BUJf9j7LFKGCEg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=I+L+UOeSNOtn4L0Ib07UHWajRPWjN5Uwgc/1l8XFPrEUqGuedPN+T99mJKRVGbiTmFFE4tHkUSo2zS5D2/cWxBxUNhubMBvHOdhZFPsi1q0zM5D1g7ib6u5dSwMZa6+7C6koqZWbDQIQpH22Vb1LdJuC0kq4XVZv6L2hcxV3jME= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kxUmRQ15; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kxUmRQ15" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-ab7800d3939so425451566b.2; Sat, 08 Feb 2025 08:26:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739031986; x=1739636786; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FEovPneKy6UrZ39w/lOvewEqfwBWVAMdy5819a+Iq1I=; b=kxUmRQ15evLcPhmSOLE5na0FnYUl3gl564sZBhnqLXwE9NVhl6leKCReTrqHOQx74f brwe/846O6jZvMNAP9PHDEAxFnhZD/LfxrY2bL/h8PCHYzV8QhEK3edt/h7p+NbxMvXL YEqOT3oML319QyCR82G4ybYSFrF5FaJe5mcgZSSAfCUCbFSOHhtuhT1nT5uQMd66akjS 5IXxpC22GpArGo60OSst7qD/boWLBWrq1Dq/0VbdLPWPMuWcRtbQ2avurLTB35KtNJAb hdrXSAtNkfIyLRnuCWo/EdeLIQCxs5xQFf5x/rl8KuXocW98QZ0zYtIQdN0AfGmyXn7T 75Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739031986; x=1739636786; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FEovPneKy6UrZ39w/lOvewEqfwBWVAMdy5819a+Iq1I=; b=bK8URX2DB00bSlGdVtBPLzGaNljUfiQsgLe7SOQrbOoGf/u76SiVIKBtzgr1/DjyXc kaJSEyWa/MmOMRReTl5D2hDiRuWCcItl3aHZS9w81uQB3MlFXOtKZiRKS6WBCvMbQ4zM dPDfv3WB9h6+diC2En86pR1pY+7aVMRNT61MzFHlnib34SyTtnmgaSpHV2yi6csvKS+8 NbJVeVE/3Tei1NqHdypRWPqfnvF3d8Tq+FpT1TKYF1iVSortL8zHzz2P0MIKyHhCJ8as NEf/cevc9IFhYWxxeUSfYwxQ1h09yO/iqpBhqpOHj30xt/+ySjGSIKo+tuc0GA1a7hxH Xk6A== X-Forwarded-Encrypted: i=1; AJvYcCU/y0q/qKS/lDVqZzcgPOhtD2IGID1jYnT1wd1Stn044k7MIJHGRgfMlE8HkizUin+c60MQGTxkAeqGvZkj@vger.kernel.org, AJvYcCVJqHiF1y2LGBqy/glqDG4vWNREjhDtHFBT4KstKMgfnxQ/YEJwAy3ncF0zgymXyhj/fyqX/EitrBfakGuw@vger.kernel.org X-Gm-Message-State: AOJu0YwBGiNIkRhrjZY03mg5SEYUd/keuDYlTWRGLgWApScTu/tMomAI UpkLkqRM/XTKMKXAyx0OdlgOVwfSc0uyYAdZuwApZDgUxHZWMTo4 X-Gm-Gg: ASbGncvekBSfDdqwLqagGFydYko5KD2mA1EsWZ5mv6PUgH4C0ZdrZhW2yy/1W0MVeje PAztW78XfStV0O4d7Gn9b26LkESdbBEkhnDvXsdcguhTYuk+CgIqzFihAqFybjRp19B7MOQVPXE VBFlrJWm5Pb2/wB4qxx/xT/AZejbAam9riHPVZvH8dEqFklFizEZwteg6AhLAqCSWFT1CCQSs1b iywm11B18dxNRRKjGJ6ULYPuiqGlA/71KqRIkP3eLvq1qN9OFNSMOrPQuI1J2Fq1AwfmdvIhZVu 9mUnU8hCo/3kKCygfiSBwZC8I4vSmVEpqA== X-Google-Smtp-Source: AGHT+IH9YUAdLW0S/0pQV+X1l7/PpTLLvPYx8hqknsR52w1vNN7fpqViucvYL2zjbCwZzCG4CV0yqQ== X-Received: by 2002:a17:907:7e97:b0:ab6:de3a:351d with SMTP id a640c23a62f3a-ab789a9eb33mr828172266b.12.1739031985501; Sat, 08 Feb 2025 08:26:25 -0800 (PST) Received: from f.. (cst-prg-84-201.cust.vodafone.cz. [46.135.84.201]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5de47d6461asm3193943a12.74.2025.02.08.08.26.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Feb 2025 08:26:24 -0800 (PST) From: Mateusz Guzik To: brauner@kernel.org Cc: viro@zeniv.linux.org.uk, jack@suse.cz, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Mateusz Guzik Subject: [PATCH v3 2/3] vfs: catch invalid modes in may_open() Date: Sat, 8 Feb 2025 17:26:10 +0100 Message-ID: <20250208162611.628145-3-mjguzik@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250208162611.628145-1-mjguzik@gmail.com> References: <20250208162611.628145-1-mjguzik@gmail.com> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Signed-off-by: Mateusz Guzik --- fs/namei.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/namei.c b/fs/namei.c index 3ab9440c5b93..21630a0f8e30 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -3415,6 +3415,8 @@ static int may_open(struct mnt_idmap *idmap, const struct path *path, if ((acc_mode & MAY_EXEC) && path_noexec(path)) return -EACCES; break; + default: + VFS_BUG_ON_INODE(1, inode); } error = inode_permission(idmap, inode, MAY_OPEN | acc_mode); From patchwork Sat Feb 8 16:26:11 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mateusz Guzik X-Patchwork-Id: 13966429 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DCC71F30BF; Sat, 8 Feb 2025 16:26:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739031991; cv=none; b=fvQRGINbEPhCUGJ8b9LeJB4w8/Zr5vtqBBYtOEUUJ7p3qOuMMRELYNyXLI/NlKrVB9pE/xWIN53OEgN0pxL3/lMP+nMAtTamP062wP2/K2bhRvsN5gqnaSxTiYvK9RPs1JgXugXfjPKxSX1OKALgAJFQ4MImX/WsM/sGOW0K/KI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739031991; c=relaxed/simple; bh=61udqkcEg9wcSq/halgc8JMmMFwwfrBUY4mtNHZNt8M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pOOcVugV9kFo5SKpBMmkw1zX86N4BqImxMVA+9PuWxhaG5cSsbEmADYLCcccE9Do8dSoPjLbIIVuvJoz+UrbNSxnw+kAkgJOuDVyDscXiEjVoPzOptbuXYObN97pSNw9Mk/zVsDR1LD6DcTvcwgFEWutisFuqeQQqYFtHknaqIc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BuF2bONR; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BuF2bONR" Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-5de56ff9851so2046650a12.2; Sat, 08 Feb 2025 08:26:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739031988; x=1739636788; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+8Wgr0+Th/eZItEiexHX2VH44yFxgC7CrIHewPAPMnk=; b=BuF2bONRSvuF+INxdoT1DUmP0j+iU4mV3V76hSATzPD5nQFWIx9kq0mULaCsCEZAX7 evOH+1zw74ysqxTkc6MIpEVrZTV6+gtxsbp4j9AENBYYiq76wkldvSRCtRGf6nnp+rTD 6bPMueYhncuFq4Kion6vhTRItdgT0ovEyCSZyMLxtJWXM0sSMXFml+zueB1NXtN2A3Wt FbKTTe4TZxto7gFLC/YERX0wG4Vue2UQE2J6oIqv7e9MGpEYiN3zZyjg9PU/boFg7lxK HY8QAtyxn/Z7dXF6ViQqskWukrIDbBbd6MkJ7yXUsnUgOFbb5SwVKTL4cIPrF8VX1/E/ XV1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739031988; x=1739636788; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+8Wgr0+Th/eZItEiexHX2VH44yFxgC7CrIHewPAPMnk=; b=OwGq/iRIisyxsigQgI197Ji3xNK+4qqCYttGTG+WszxnBFvUI5GvjXWEDwBxqeLzc0 Lz0OPmIWcHv0GlGtAjstyYnvwusCBTN/kZLlb9+SpZlfLhdeimILqoNqptmW2Dh13BM+ ZHRVudfvYzN/9XwgfqnLQPAjQYuEQrVRqXn7GEH1B5H+oyUMNy1RsD5rSckoWZWedPz6 u06nlLGOYEESF6y1PjzUfPG+n1/brvC4Yp/fE/4Wb+f2cDUM3iHnfxjVvnTHlz1QAJz+ w5OH1pJiTxq644YK2OIzKUrMit5jsaLGibURBOtPTSWm/EqwbzExZ/8kT6VguCDnysEZ r03g== X-Forwarded-Encrypted: i=1; AJvYcCXMlLsI0rNLWxyJVJXlFPvPI0JBI60tiyTavJG4iDS/KAwMztyxrNFLwv0KwnDuDWRmbBI9jH0XJdpJq5S6@vger.kernel.org, AJvYcCXazqHWq+UtcyLSMenK3hM0+JONWcs+bQ6ayhxOrtdQHzhKA8Ub0iHmQsdt1x96lCZp+uNC/MqDDWAgYjUn@vger.kernel.org X-Gm-Message-State: AOJu0YxrfRmLjbvxdClcbUtbAQ5VQx7NMPMAREKSQx7huQYhuwuxeCTX sFVdm3kZvLS1gPGp6OgTFbPqyFQ7JE5OuC5Mv+q3jT95Vguk7rUeGoUE9g== X-Gm-Gg: ASbGnctHCpOmEEnsD7+ss4qFR9Se4XubnoYf66ea8c8pd7nUBXEF0hhaR/KiaIaeWms Zn01Y6DitNyk90/oGzAQwNo5WdGEDeOb04ZgTghfPfKnkIQSIsr+9sfZegdFHE0coD3RP/BO7+V VRweZQbBFko/7UGKHAKh9cZg0mfha5c3rFPGJVVTylxmFPkSa/uCv8OPJlRAG3II56LFtC83XOm GwoqOPuHXmcp/nJKhYOqlQhk4oCx7ResJkmG6UKURLUfzrQKFJz0+mxfDnZadhvSBCnGi2nOi1c O/nWTwEiTlHSrry49f4NllZD3naZakHWxw== X-Google-Smtp-Source: AGHT+IHLtrxuW6vMQwspp/peB2fehaaqv7Uak6pWLo2wK+10UbiEKjCqtzb5Rpc9aBb4XK95eSHZwA== X-Received: by 2002:a05:6402:40c9:b0:5de:4acc:8a99 with SMTP id 4fb4d7f45d1cf-5de4acc8d50mr7741738a12.18.1739031986808; Sat, 08 Feb 2025 08:26:26 -0800 (PST) Received: from f.. (cst-prg-84-201.cust.vodafone.cz. [46.135.84.201]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5de47d6461asm3193943a12.74.2025.02.08.08.26.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Feb 2025 08:26:26 -0800 (PST) From: Mateusz Guzik To: brauner@kernel.org Cc: viro@zeniv.linux.org.uk, jack@suse.cz, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Mateusz Guzik Subject: [PATCH v3 3/3] vfs: use the new debug macros in inode_set_cached_link() Date: Sat, 8 Feb 2025 17:26:11 +0100 Message-ID: <20250208162611.628145-4-mjguzik@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250208162611.628145-1-mjguzik@gmail.com> References: <20250208162611.628145-1-mjguzik@gmail.com> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Signed-off-by: Mateusz Guzik --- include/linux/fs.h | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/include/linux/fs.h b/include/linux/fs.h index 034745af9702..e71d58c7f59c 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -792,19 +792,8 @@ struct inode { static inline void inode_set_cached_link(struct inode *inode, char *link, int linklen) { - int testlen; - - /* - * TODO: patch it into a debug-only check if relevant macros show up. - * In the meantime, since we are suffering strlen even on production kernels - * to find the right length, do a fixup if the wrong value got passed. - */ - testlen = strlen(link); - if (testlen != linklen) { - WARN_ONCE(1, "bad length passed for symlink [%s] (got %d, expected %d)", - link, linklen, testlen); - linklen = testlen; - } + VFS_WARN_ON_INODE(strlen(link) != linklen, inode); + VFS_WARN_ON_INODE(inode->i_opflags & IOP_CACHED_LINK, inode); inode->i_link = link; inode->i_linklen = linklen; inode->i_opflags |= IOP_CACHED_LINK;