From patchwork Sun Feb 9 18:55:20 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mateusz Guzik X-Patchwork-Id: 13967075 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5319AEAC6; Sun, 9 Feb 2025 18:55:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739127339; cv=none; b=IAOoB6adg5eVj3Do3jE27AoEchyd/0uZlXw3Bpu206OIqaRBMNqM8H/bvN8KWsbVdlk3mXQM0P9T5S8cvdh/LAbloC2ZrzEWeNWNxvAZ70vvctPjl+dvuRfi+2z92H+ybK4wIXG/rWeMoevYFQR/wMAX2ZNBAqXR6kCvS41T9cQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739127339; c=relaxed/simple; bh=Q51XQfe56AFhuGNQTaw2YQJVCi8+KJGxjjuooUOyupA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RKCqa12tZCSujTx7qJj/B9558wmkofjSepIUkz95U0A6bt9PUXleu8VSrjWhpxCURSZ998LZypxdE6zUx3rxvNRgeTdSLwrZYM+KDi84fS5rvMwfuaRP1I6nazmqfR3pv4i2T3MgzteEcWjrTX/GBTYZJeU9kT2yqI5OgvcZ76g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RMuYsO5Q; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RMuYsO5Q" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-ab78e6edb99so314059466b.2; Sun, 09 Feb 2025 10:55:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739127335; x=1739732135; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eFRswilTxe6On8n4prZbm2R1GRuCBxzYFss7QkKFRZw=; b=RMuYsO5QRk6H9m88liL4dgiI+e66BWCXqaPNjc4cLbQx8olhAieraW5km+Jw4uOAZv g6J06EXIlQEkrPXHubWd/QqZje3SQlzv6dANCxCIEyO3dRhKPlJ5r+WjTXb/c+wByRkX jE4mRHoIchOArFnrjRy0289ipzSI+9x2S8OFIzfvjRE8av69gEGXD6K0glLONbbER4gE YkXUoiayCCCRRbQ7x7i+QQA8kOWOmt/hL0t9JAE/37GuL9DGEj5Rlev/McUg88riwnux fuqwHoe7XJEh6ze5ULu8b3zieYzmiEz/vUV1KWwsjdqNlQLBkqPhGoIiaa5vNFfunGOs YkPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739127335; x=1739732135; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eFRswilTxe6On8n4prZbm2R1GRuCBxzYFss7QkKFRZw=; b=wIvaxCNz75Sr+nlfvVquMUrIBAWyRjNgkneCx4wPVxOnndQ6f1Lvh33nn4Aa12sCc7 B6c0lHs5ERQpENUzs1RJDmcf1bLfQoWmb+Upq/VWTmWzkPiYu1GIM+a0EiBRnDdpASNA c0C7pAkhppEo6v8XcQ/9WgI/3XODoGEiJX0v+9+rQqHk0VL+3PO2IvcoWtSloQ4MO50D R8itlHagW1UOY4nbmV3VYVsbXvK4thW5yOcnLRhUVZV6M3E0+6UFlDly5bdZp7FrTDQO hvo//SidJ6SAi2FPpxJGtQF7hOoiwNoFP8gZ1HLkNpTZkxeQr6F91mPKBPhRCn+TKBZ0 Wjxg== X-Forwarded-Encrypted: i=1; AJvYcCU88YQ8wWIMJaUGW7xIZLh+Y1L8uyRlKqeomt8ZSU2uu63x3fGudKvdA+cBEBMxGnzS9zznXKWS6jRjk5lN@vger.kernel.org, AJvYcCVqq17iwH9B8z4K4NRZPOJF4Za8uDjOFuqvvf5EdcaWPQpL2FGhfr5Xfe5E46MeacEMQV0gCFSw9p8nuYgv@vger.kernel.org X-Gm-Message-State: AOJu0YzkeJ1m4bVEPprm6CE9ZJRrS4YpjhvA3V/rhPSc8kJGDlLXmoHJ ghgw8t1XyRl3NHaxzTD5bT5z1Nl+8cUQWfPvz1ccu4zVAsRrc2In X-Gm-Gg: ASbGnctB/AuP5lrKVfVfwzYS0tr1TS0K+Tu29APAnNj6y/y3JazNYtDGQuxc1jbGI+V /F8Ih9HsD+SsJ9PSmOX9bwJMCD705dxEjLrVxwpriUbdqoP7PD2dxFbAE4ZLYs64xII832UGbsC 3IXqWBNnTtq6o5oXiMf4w7xRVnOOrLglXJrszAn4azXakCp8RtzMIYcGNAtINa3WKllJaO//iet ugX+SOw9F9JYSWWqHTdXZf3IH+PpU1WXe/ACFgtp7ngy9DVQezPSKrfHFSyg3t6yRInKhFiSDgB 3amEqA/rgdB52N/3iNzcqXw0oMGExhCovQ== X-Google-Smtp-Source: AGHT+IE2E6xuO4bsGmAr2vQRRwDQnOiAypsmYow6wZgZuhIkXnmSoaQozfy4BglYDKCZrwE5YFAMkw== X-Received: by 2002:a17:906:9c8d:b0:ab7:b93:f77d with SMTP id a640c23a62f3a-ab789a9ed18mr1248346166b.3.1739127335193; Sun, 09 Feb 2025 10:55:35 -0800 (PST) Received: from f.. (cst-prg-84-201.cust.vodafone.cz. [46.135.84.201]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab7a82dba37sm318478566b.165.2025.02.09.10.55.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Feb 2025 10:55:34 -0800 (PST) From: Mateusz Guzik To: brauner@kernel.org Cc: viro@zeniv.linux.org.uk, jack@suse.cz, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Mateusz Guzik Subject: [PATCH v4 1/3] vfs: add initial support for CONFIG_DEBUG_VFS Date: Sun, 9 Feb 2025 19:55:20 +0100 Message-ID: <20250209185523.745956-2-mjguzik@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250209185523.745956-1-mjguzik@gmail.com> References: <20250209185523.745956-1-mjguzik@gmail.com> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Small collection of macros taken from mmdebug.h Signed-off-by: Mateusz Guzik --- fs/inode.c | 15 ++++++++++++++ include/linux/fs.h | 1 + include/linux/vfsdebug.h | 45 ++++++++++++++++++++++++++++++++++++++++ lib/Kconfig.debug | 9 ++++++++ 4 files changed, 70 insertions(+) create mode 100644 include/linux/vfsdebug.h diff --git a/fs/inode.c b/fs/inode.c index 5587aabdaa5e..875e66261f06 100644 --- a/fs/inode.c +++ b/fs/inode.c @@ -2953,3 +2953,18 @@ umode_t mode_strip_sgid(struct mnt_idmap *idmap, return mode & ~S_ISGID; } EXPORT_SYMBOL(mode_strip_sgid); + +#ifdef CONFIG_DEBUG_VFS +/* + * Dump an inode. + * + * TODO: add a proper inode dumping routine, this is a stub to get debug off the + * ground. + */ +void dump_inode(struct inode *inode, const char *reason) +{ + pr_warn("%s encountered for inode %px", reason, inode); +} + +EXPORT_SYMBOL(dump_inode); +#endif diff --git a/include/linux/fs.h b/include/linux/fs.h index 1437a3323731..034745af9702 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -2,6 +2,7 @@ #ifndef _LINUX_FS_H #define _LINUX_FS_H +#include #include #include #include diff --git a/include/linux/vfsdebug.h b/include/linux/vfsdebug.h new file mode 100644 index 000000000000..9cf22d3eb9dd --- /dev/null +++ b/include/linux/vfsdebug.h @@ -0,0 +1,45 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef LINUX_VFS_DEBUG_H +#define LINUX_VFS_DEBUG_H 1 + +#include + +struct inode; + +#ifdef CONFIG_DEBUG_VFS +void dump_inode(struct inode *inode, const char *reason); + +#define VFS_BUG_ON(cond) BUG_ON(cond) +#define VFS_WARN_ON(cond) (void)WARN_ON(cond) +#define VFS_WARN_ON_ONCE(cond) (void)WARN_ON_ONCE(cond) +#define VFS_WARN_ONCE(cond, format...) (void)WARN_ONCE(cond, format) +#define VFS_WARN(cond, format...) (void)WARN(cond, format) + +#define VFS_BUG_ON_INODE(cond, inode) ({ \ + if (unlikely(!!(cond))) { \ + dump_inode(inode, "VFS_BUG_ON_INODE(" #cond")");\ + BUG_ON(1); \ + } \ +}) + +#define VFS_WARN_ON_INODE(cond, inode) ({ \ + int __ret_warn = !!(cond); \ + \ + if (unlikely(__ret_warn)) { \ + dump_inode(inode, "VFS_WARN_ON_INODE(" #cond")");\ + WARN_ON(1); \ + } \ + unlikely(__ret_warn); \ +}) +#else +#define VFS_BUG_ON(cond) BUILD_BUG_ON_INVALID(cond) +#define VFS_WARN_ON(cond) BUILD_BUG_ON_INVALID(cond) +#define VFS_WARN_ON_ONCE(cond) BUILD_BUG_ON_INVALID(cond) +#define VFS_WARN_ONCE(cond, format...) BUILD_BUG_ON_INVALID(cond) +#define VFS_WARN(cond, format...) BUILD_BUG_ON_INVALID(cond) + +#define VFS_BUG_ON_INODE(cond, inode) VFS_BUG_ON(cond) +#define VFS_WARN_ON_INODE(cond, inode) BUILD_BUG_ON_INVALID(cond) +#endif /* CONFIG_DEBUG_VFS */ + +#endif diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 1af972a92d06..c08ce985c482 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -808,6 +808,15 @@ config ARCH_HAS_DEBUG_VM_PGTABLE An architecture should select this when it can successfully build and run DEBUG_VM_PGTABLE. +config DEBUG_VFS + bool "Debug VFS" + depends on DEBUG_KERNEL + help + Enable this to turn on extended checks in the VFS layer that may impact + performance. + + If unsure, say N. + config DEBUG_VM_IRQSOFF def_bool DEBUG_VM && !PREEMPT_RT From patchwork Sun Feb 9 18:55:21 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mateusz Guzik X-Patchwork-Id: 13967076 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 578821E2613; Sun, 9 Feb 2025 18:55:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739127341; cv=none; b=CSDheAggnp1zc0uz1uPpdA3W8ekb4hHdhajmMG6n4CiaYrDblNr/3aMYsKPggoPSZOebx01Ga9HhPrY6ciQtkCJL7uKVl2EWr/N7PCSY/hTBlh/gwS08RnCIAxU8AQBV0i71XWyhmtb/uiq9xZZb6xHNkpUDbiqqzkWF/QeOVOI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739127341; c=relaxed/simple; bh=4bGNyjfePr6cLfEicYz5bD4g9j8T0BUJf9j7LFKGCEg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MaziV5qq9tXevrUN2w+fmnhiq/XX2RcmbSCenNDCytEiejJHiBmO4Lr1NqJ/xc/sfiRs6vDmnJO8uwr6LywL+7r3ZKKRJ09m9Z24x1gGR0R03DjtFvhtI2Lg8bJMr+Mpfw2Yy2AR/GeuZxfUnO6AVFDMPO++x2NL2Ql4qkKUpLc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NOxhzWuy; arc=none smtp.client-ip=209.85.218.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NOxhzWuy" Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-aaeec07b705so593166066b.2; Sun, 09 Feb 2025 10:55:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739127337; x=1739732137; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FEovPneKy6UrZ39w/lOvewEqfwBWVAMdy5819a+Iq1I=; b=NOxhzWuypVX2Stc72ezRgeknKF1iPxeQGX+FvW6+0cefpQ/sbQNrslLBV+BeYK3UWq hKngVAbuEFbHhDINwYo58s8vxIo+MsLIahdkSndIDqQTAbyqUakuIjG8WKObYn7pg16l 6uQ8J7xBgWtQ52On9imskCd7dLKZmc/gl3AmvQVBYXM4ZM4sEj35XPSLwMycQOjCwf5j 080PdhvXCMZxqIXDJ/YeZR3RWHe2qJbfHqmwItxOAkQU5YK/9Bz1gpsV77lAQJgFe1OS XclsMHBi0u5bKEo5mOMNY21KedsVnWJVObw4+WF6GLhObwzzd+nSafUOCxjKoK+aaFXT kCew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739127337; x=1739732137; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FEovPneKy6UrZ39w/lOvewEqfwBWVAMdy5819a+Iq1I=; b=lHZj5hR0ISltrNzvXe4uJsmlEJavfDBEC8puC1tg6EuMFQDZi5n7JZjzNvf5MQd3Em 1uOc16pZDzHiidLCWB3r0lCdMypu1QKxp9O4DIpKvwRxpfWxU5TPX/n/H6LQdtQg6kYd //c51gWD72mck82Pq5Q14Os2iqbtKbYrwNtmq5yrsRT/T4w/rGSh5NIxiIHrJUUdIbq8 R/NwA0jUGkAuB40iJPR0xbuVQUuDLqSTSs1TmYqCzHgzEOW3hVGv4cKeqpRXR4bcj8Bl 1N7DCp8qgszg7Brtkh8mDeznitTjJyB03GqaXqBdpNeYYFl2LABY3Dz1ztCUdiOJ0hjJ Q+jQ== X-Forwarded-Encrypted: i=1; AJvYcCVf+3ACWCXRiTuq7Tp4tgK9aX6gWch+3MtkdaEfp///+bbqHhfkt6l5D6hjt6wqj+bPOW9bvzgKU7Hi4FPE@vger.kernel.org, AJvYcCVrFkbJSeIRC8FlfbySeYN3Oufe6oqRhjHVVYY04t4rIqTpfhee8YQwcknF3hRNVcs2145DcIeOT44FiCSQ@vger.kernel.org X-Gm-Message-State: AOJu0YypbRRc1URTlli1Muu91y7WtdejuRP+tyRITMlW/UT9wsoDBhry I84scplpWeG+9Q3ybk2MGyAJ3PhEYNOF3uaFAmifaEhfX/DJkVP3bjWCiw== X-Gm-Gg: ASbGncsORPnMAPxor1BBf9ym0p9SSIuK12bM8oJhh9PGdkGRUSvXildLs1fbsOpkWKV LIhs7s/oNEwYctu1uhIADDwt4YMIkbQWIVRYUxPeQmZ+Hy9EYwgGPigAPeA+rPNtzkyZp1O3HsR 9xH3yvJmtaOeCyCfw2VcD0Qy9Frnumjc1DzyIaGqJl2VvPQqg9EfR1ndBJjo0JCYNm/0SnY6sm6 h93GXWW2u8c/NEpqV0Bln2ZCcE3CmwNfgbhhmbKzO+CWCy/MUggStOsRZXRa+OU04XBqS9B6Zyd zCMxAt5fmlhv3TyJ8K+KnH1IKxGGZSyOxQ== X-Google-Smtp-Source: AGHT+IFuROLubKDuUUgKlNZuHaYwDlsVRWyvDEWASNekr0cwZyx/WMFCIELIUUionRX1mduBCK/msg== X-Received: by 2002:a17:907:3f27:b0:ab6:f06b:4a26 with SMTP id a640c23a62f3a-ab789aef91amr1175828966b.34.1739127337332; Sun, 09 Feb 2025 10:55:37 -0800 (PST) Received: from f.. (cst-prg-84-201.cust.vodafone.cz. [46.135.84.201]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab7a82dba37sm318478566b.165.2025.02.09.10.55.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Feb 2025 10:55:36 -0800 (PST) From: Mateusz Guzik To: brauner@kernel.org Cc: viro@zeniv.linux.org.uk, jack@suse.cz, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Mateusz Guzik Subject: [PATCH v4 2/3] vfs: catch invalid modes in may_open() Date: Sun, 9 Feb 2025 19:55:21 +0100 Message-ID: <20250209185523.745956-3-mjguzik@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250209185523.745956-1-mjguzik@gmail.com> References: <20250209185523.745956-1-mjguzik@gmail.com> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Signed-off-by: Mateusz Guzik --- fs/namei.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/namei.c b/fs/namei.c index 3ab9440c5b93..21630a0f8e30 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -3415,6 +3415,8 @@ static int may_open(struct mnt_idmap *idmap, const struct path *path, if ((acc_mode & MAY_EXEC) && path_noexec(path)) return -EACCES; break; + default: + VFS_BUG_ON_INODE(1, inode); } error = inode_permission(idmap, inode, MAY_OPEN | acc_mode); From patchwork Sun Feb 9 18:55:22 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mateusz Guzik X-Patchwork-Id: 13967077 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA8B01E3775; Sun, 9 Feb 2025 18:55:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739127343; cv=none; b=FOvzwebX8g2rxtVHm5kjVlY5IP/nSQ62jo8MKtEdkek+krrcIarbaMj/Q+JIUmkKXNfEaxqUZi0iBBU4aREfE7/XqOkjIPL1ZnsL3N5OHipANrAgqgS7/8PJUUpH7w3Of/tAVEn3b8R0pvNZTTAF2zeBQDgRzS0o1Wyz9FsWun8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739127343; c=relaxed/simple; bh=61udqkcEg9wcSq/halgc8JMmMFwwfrBUY4mtNHZNt8M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lcC6FXBOo5xRGAWFU+XVLd+tmpgkQtE0l9Sh9dsYFq9s+QWbVmtPZKWaAVimCQuJfoRSetpdspbVhzmdz9vTq74AMGEFGmIRqhaLiGfOnZLG7jU8RAdM6lpO6ct4/SeTh1q6EHseKmLXskcnBy7i5UcitxJU4eKztF4xCSi8BWs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fWnIIGHo; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fWnIIGHo" Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-ab7c07e8b9bso39106666b.1; Sun, 09 Feb 2025 10:55:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739127340; x=1739732140; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+8Wgr0+Th/eZItEiexHX2VH44yFxgC7CrIHewPAPMnk=; b=fWnIIGHodDMiSmtg4RKubLpmTTRDM+zCHCH+7uFVTQpu227kcyPNLcwLyLGeeZMb5w XKlvJavrNjEaX+AOSmXTxYDjnlGn9NKzk+r8VCjy1XPguGmz+Oo0/JswORGVwPAig5F2 NLk1Mh6JOVdLuHniIf40usO+WGs9gsnqTZs4AWM5kR+Hkk9s5FtUfG9350It5wdn12Nw ut58qd9QRkjYHFwb7jLYaWkrHdyYa9LbzJupDcOB5jKE58zGdHg3cvllPgYHOiQgQjjZ 4jOLj7jkyz1MzBkoV1hbx/BSOXstvTU2qMxuiz8Hq7ZKbwXFDje5gNpz4e13QSows2Mq 8Szg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739127340; x=1739732140; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+8Wgr0+Th/eZItEiexHX2VH44yFxgC7CrIHewPAPMnk=; b=fYMhr60QayftY51cclUKRbQUc3n4HMw8RaGhxa7HZj2Kd5lpkb5VjgALP1yHJeiAFE 6WMdaPhFA82ePrwqpcRpjLpyJrHGEqPTVivYhyX8Ob7YjSlyL6l4yEb8GEDC4y8jzM8B cWV8L0nMjk0TeP0My3I+uq4FE3LOr3ljYru+cmWnHs/4noYRnQf2dGNJ0uPTEtwA3QtT y7mXdi5Wjq4T3YSUMM9wghwqfjznG7r9PIta+rsQUw7Q9NutBuNWdz5OpI8AsIZINSL0 212CH144CdZyFHJxsisP5PH9s+vTve7omPsIRLbNt9o4St/ZOsdTPBqnxtuc+IOSZAUc y0vw== X-Forwarded-Encrypted: i=1; AJvYcCVhAGMr2yDI7A7xmIPTfmypfinEZByTqOc0tDAR9igRHMlNVWH0vFS2fzg82ONOgrkDSRJe9lx606aXJ5oz@vger.kernel.org, AJvYcCWJvsgJuh/bmbJDlDBcEE2XMZMOCqO3n6OxABaU+u3kjF76SFGkWdQBl0aFF43eI49BhpLsUVNEdSk9JQuy@vger.kernel.org X-Gm-Message-State: AOJu0YwQbt5H5P5zu0PiZOu97sDQikNxsI6NR/+aG9VT87FoOtrMrTz2 m2Uaa50xiH6d6Ywb5bZcUca8UPHAWaw7yPGob1qlp3cmRjip5TqY X-Gm-Gg: ASbGncsECcFHJTSzsuoD8kBKaBYWMPVCPd9t4klEYbsGdzHuoS8hhPTle0s/INNii9h oBcqzn1Zd70MCmX2gWk5S4Av3ZeroDjLTPgloJISqdXghisUtw9N5yR1gmaukqUSkvrnPEaL6yP EZVNKBg+ZP9Gk6Gaxssm7/hCbNOXayOMTY6WUCoohZrVgyUz1iTPeBufneeHGrB6+ZMobD197/z oWs2o6CQ7QGQbPGAPEdxvSKA3OGuWetN89v8yLw0Lq0xQVTVpBfIu+/qUj1DMltCRoZSt0YnsK3 EZ5SJxkMhx1OZ+P9WE7rPViP/lUr6dUWQw== X-Google-Smtp-Source: AGHT+IFRwO1qrAyYzxDW0kmOstWFYA6/jMcMo+ErrpykpQ5fdyvPNQaobkhgkCSDdH0JDq9yBx/2Dw== X-Received: by 2002:a17:907:7faa:b0:ab6:fea0:5f14 with SMTP id a640c23a62f3a-ab789ada0e4mr1126946266b.16.1739127339955; Sun, 09 Feb 2025 10:55:39 -0800 (PST) Received: from f.. (cst-prg-84-201.cust.vodafone.cz. [46.135.84.201]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab7a82dba37sm318478566b.165.2025.02.09.10.55.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Feb 2025 10:55:39 -0800 (PST) From: Mateusz Guzik To: brauner@kernel.org Cc: viro@zeniv.linux.org.uk, jack@suse.cz, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Mateusz Guzik Subject: [PATCH v4 3/3] vfs: use the new debug macros in inode_set_cached_link() Date: Sun, 9 Feb 2025 19:55:22 +0100 Message-ID: <20250209185523.745956-4-mjguzik@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250209185523.745956-1-mjguzik@gmail.com> References: <20250209185523.745956-1-mjguzik@gmail.com> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Signed-off-by: Mateusz Guzik --- include/linux/fs.h | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/include/linux/fs.h b/include/linux/fs.h index 034745af9702..e71d58c7f59c 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -792,19 +792,8 @@ struct inode { static inline void inode_set_cached_link(struct inode *inode, char *link, int linklen) { - int testlen; - - /* - * TODO: patch it into a debug-only check if relevant macros show up. - * In the meantime, since we are suffering strlen even on production kernels - * to find the right length, do a fixup if the wrong value got passed. - */ - testlen = strlen(link); - if (testlen != linklen) { - WARN_ONCE(1, "bad length passed for symlink [%s] (got %d, expected %d)", - link, linklen, testlen); - linklen = testlen; - } + VFS_WARN_ON_INODE(strlen(link) != linklen, inode); + VFS_WARN_ON_INODE(inode->i_opflags & IOP_CACHED_LINK, inode); inode->i_link = link; inode->i_linklen = linklen; inode->i_opflags |= IOP_CACHED_LINK;