From patchwork Mon Feb 10 11:45:33 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tommaso Merciai X-Patchwork-Id: 13967740 X-Patchwork-Delegate: geert@linux-m68k.org Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2295D1F3B95; Mon, 10 Feb 2025 11:46:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739187983; cv=none; b=cr+PZ5J13goO83maDuzw+IJ4va63YaPhrhmJzyxM3IaWKBirQMCivqf8K8eIxNor4v6NCHQDBfsI7HnLXCIj8BLSXq1yL0qJxHqSj8QYZT66TASaQ592zkmbuJtZ5mKw7WU3ZMHZEC+HVLk6tICIiE0zO9YeGUhMI18ZSsIPeS8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739187983; c=relaxed/simple; bh=Uo4TmisU7wn9Kpc2fbHxaydHm+iJ80nLy/agd1E+ApM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=dJnJaf5idzdP7m8BGkLiu73fyf/NDo34qKT9Tjq+/YS5tRNmLt3EUXX1t1QaYxHkFQoB/oHw/w8++KAFxSHhUvmNY70YuwdrQFHeVJLWmiTb86cf/wcFtIbLM0XMFM3zI/p01Kawhm00rf9MAsg/2mVrlqaQsCQ3xx+bYngrmc0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ncC5G3X+; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ncC5G3X+" Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-aaecf50578eso845220666b.2; Mon, 10 Feb 2025 03:46:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739187980; x=1739792780; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Tcko+2LGTEjB783TiWIDWhciLjGO64bpOmui7Jw9kx0=; b=ncC5G3X+l8Y2u7nnqBi8C5zewdTstlg8XvTnSU7xFRk2CMucmwRm+2G0s0tVQ0WhUe Gn7HmbCEVQWqo91ODCOVKfKy+Fzod1a8NsSrUMPM/j9V0Gus9G0Y9OLHDl/aKMyqHIff vcyskuMBthqjFslvRjoln9W3EYL2pH31CudkpTMmJ/y1ADtWNi3GiuQxMAOvJvb8RcRI F1wqH8e0bsteZNkgmc9L4IO5+PLKGPzj6T0UeR7YVaazbJ5PcDdInnKEOChV6GkElWNm SZ/Ei3F5SoOZrWV/BLiocUYpmWLL+qKztfi43GCYHgkQiApgq1D5oFTes6GrCVTwc+RY yLJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739187980; x=1739792780; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Tcko+2LGTEjB783TiWIDWhciLjGO64bpOmui7Jw9kx0=; b=fkCo/hYAVEz0szVu0hA3yURJBBCzVrAzNOb9nwAgwgcCBZhljlY9n7DMpTqpJZTRVs 7nRdVkvvMbGwE/sGj3HsVzqsRQ+yGEse5gjWi5RRmBc6kz75q+IX2GvVme+gK40b+Fm1 bie6qvYG1FJL+cassyfY7iWX0z4haX9n4jOxdOkVNCYi6c/UQX7AHpcJWtT/QgjigQPx VaoZ0ersKEfKXMfRoyUKxtnIz7LFYj8PeQn17+Xrl+3IF9fBC78V0T+PEUa0SYzcHxnE TK/BMaDoruU2irUM1lG9c5+CYArsMqq2fLbzGrAZkg0h9iacFYb4J63ebxwmpHBP9hCW AcZg== X-Forwarded-Encrypted: i=1; AJvYcCUOMfK67oy4lvFtQldM2VWrtH6vmDaL1BxP5W7v/9NneiN3qHNfmbcvZg5/xk05lkPziimKldW5SSkd@vger.kernel.org, AJvYcCVZXs1ob/hrqFX6mSZCR6jbx1uYhVb7uqC0AFkpyWIRQ0Q7J3vwT19NoCYowWNzynzKSCVsE8QE2++fpYE=@vger.kernel.org, AJvYcCW3VxN4vk9I7eO7cTS7JKVyddba5Fm4IbKcmdnrzQEMt56pTALa4/n/Qp7P8YgH+FnxGL45hOclcAuaJYjo@vger.kernel.org, AJvYcCXsnIHw5tdm97n9Tp4BUbRsBCNeTWuixqNdJVi43Q9UtiypStDsjZ6UQPpE3ZVvDT6HW309379WrnDc@vger.kernel.org X-Gm-Message-State: AOJu0YydQbkEsRKAVnpRazZo0LGnFDoeI2FdwCv7VPB48BndFaZJwOEP vlluMsFiV6VSFyUfvoawIKdQCWpYAGUTczzXQcPIqmBegSDpQEk3 X-Gm-Gg: ASbGncsgyEb7nXtcq5P4FDa4dPhLX8ZMFHmoadJRwdfboLMgx3LCslyVQCE4zepOp+W MrBOfVakLfJ4kFxb0jhk7X/hA+xnJoKIfCg2t16QIFeVwYDSEDP5KPSofNP3XxhLIMv5u2wtt3o uarAgWKaqz1a3trDsQm8mfNEUOIIMW3b408KrR8iuuDiIPKBQYxYr3T0T4f5DHP4roWH/q/dkAh 2gLBRSE2X2DWwoqcftsnOEMnuqY7Il4bx1quYhFDVSTEPlw4rH9LsGch4P3LFSkfUreyMJ0S3fy EFCz+WV6S594whUjqmc25Uej2f8984pbof8gk1RpN0Je2HVTxJQ/sXWXJZp30GfCJt03gX8l8E7 grwYE8jQR6t+XQlmqJoMFAu6FH84= X-Google-Smtp-Source: AGHT+IHLu0Y36JRC+51o0vyk4KbOZ8N6uUlsAc0UT5MymiVYg29nPUAml9edHiLfIvZ3aUgSS41LBA== X-Received: by 2002:a17:907:1ca0:b0:ab7:9df1:e562 with SMTP id a640c23a62f3a-ab79df1e783mr831432766b.48.1739187980240; Mon, 10 Feb 2025 03:46:20 -0800 (PST) Received: from tom-desktop.example.org (net-188-217-54-237.cust.vodafonedsl.it. [188.217.54.237]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab7a9e6e06fsm428948566b.80.2025.02.10.03.46.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 03:46:19 -0800 (PST) From: Tommaso Merciai X-Google-Original-From: Tommaso Merciai To: tomm.merciai@gmail.com Cc: linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org, biju.das.jz@bp.renesas.com, prabhakar.mahadev-lad.rj@bp.renesas.com, Tommaso Merciai , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Michael Turquette , Stephen Boyd , Magnus Damm , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Subject: [PATCH 1/8] clk: renesas: r9a09g047: Add support for CRU0 clocks, and resets Date: Mon, 10 Feb 2025 12:45:33 +0100 Message-Id: <20250210114540.524790-2-tommaso.merciai.xr@bp.renesas.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250210114540.524790-1-tommaso.merciai.xr@bp.renesas.com> References: <20250210114540.524790-1-tommaso.merciai.xr@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-renesas-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Add support for CRU0 clocks and resets along with the corresponding divider. Signed-off-by: Tommaso Merciai Reviewed-by: Geert Uytterhoeven --- drivers/clk/renesas/r9a09g047-cpg.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/drivers/clk/renesas/r9a09g047-cpg.c b/drivers/clk/renesas/r9a09g047-cpg.c index 51fd24c20ed5..5d02031219d8 100644 --- a/drivers/clk/renesas/r9a09g047-cpg.c +++ b/drivers/clk/renesas/r9a09g047-cpg.c @@ -28,6 +28,7 @@ enum clk_ids { CLK_PLLCLN, CLK_PLLDTY, CLK_PLLCA55, + CLK_PLLVDO, /* Internal Core Clocks */ CLK_PLLCM33_DIV16, @@ -35,7 +36,10 @@ enum clk_ids { CLK_PLLCLN_DIV8, CLK_PLLCLN_DIV16, CLK_PLLDTY_ACPU, + CLK_PLLDTY_ACPU_DIV2, CLK_PLLDTY_ACPU_DIV4, + CLK_PLLDTY_DIV16, + CLK_PLLVDO_CRU0, /* Module Clocks */ MOD_CLK_BASE, @@ -49,6 +53,12 @@ static const struct clk_div_table dtable_1_8[] = { {0, 0}, }; +static const struct clk_div_table dtable_2_4[] = { + {0, 2}, + {1, 4}, + {0, 0}, +}; + static const struct clk_div_table dtable_2_64[] = { {0, 2}, {1, 4}, @@ -69,6 +79,7 @@ static const struct cpg_core_clk r9a09g047_core_clks[] __initconst = { DEF_FIXED(".pllcln", CLK_PLLCLN, CLK_QEXTAL, 200, 3), DEF_FIXED(".plldty", CLK_PLLDTY, CLK_QEXTAL, 200, 3), DEF_PLL(".pllca55", CLK_PLLCA55, CLK_QEXTAL, PLL_CONF(0x64)), + DEF_FIXED(".pllvdo", CLK_PLLVDO, CLK_QEXTAL, 105, 2), /* Internal Core Clocks */ DEF_FIXED(".pllcm33_div16", CLK_PLLCM33_DIV16, CLK_PLLCM33, 1, 16), @@ -78,7 +89,11 @@ static const struct cpg_core_clk r9a09g047_core_clks[] __initconst = { DEF_FIXED(".pllcln_div16", CLK_PLLCLN_DIV16, CLK_PLLCLN, 1, 16), DEF_DDIV(".plldty_acpu", CLK_PLLDTY_ACPU, CLK_PLLDTY, CDDIV0_DIVCTL2, dtable_2_64), + DEF_FIXED(".plldty_acpu_div2", CLK_PLLDTY_ACPU_DIV2, CLK_PLLDTY_ACPU, 1, 2), DEF_FIXED(".plldty_acpu_div4", CLK_PLLDTY_ACPU_DIV4, CLK_PLLDTY_ACPU, 1, 4), + DEF_FIXED(".plldty_div16", CLK_PLLDTY_DIV16, CLK_PLLDTY, 1, 16), + + DEF_DDIV(".pllvdo_cru0", CLK_PLLVDO_CRU0, CLK_PLLVDO, CDDIV3_DIVCTL3, dtable_2_4), /* Core Clocks */ DEF_FIXED("sys_0_pclk", R9A09G047_SYS_0_PCLK, CLK_QEXTAL, 1, 1), @@ -154,6 +169,12 @@ static const struct rzv2h_mod_clk r9a09g047_mod_clks[] __initconst = { BUS_MSTOP(8, BIT(4))), DEF_MOD("sdhi_2_aclk", CLK_PLLDTY_ACPU_DIV4, 10, 14, 5, 14, BUS_MSTOP(8, BIT(4))), + DEF_MOD("cru_0_aclk", CLK_PLLDTY_ACPU_DIV2, 13, 2, 6, 18, + BUS_MSTOP(9, BIT(4))), + DEF_MOD_NO_PM("cru_0_vclk", CLK_PLLVDO_CRU0, 13, 3, 6, 19, + BUS_MSTOP(9, BIT(4))), + DEF_MOD("cru_0_pclk", CLK_PLLDTY_DIV16, 13, 4, 6, 20, + BUS_MSTOP(9, BIT(4))), }; static const struct rzv2h_reset r9a09g047_resets[] __initconst = { @@ -177,6 +198,9 @@ static const struct rzv2h_reset r9a09g047_resets[] __initconst = { DEF_RST(10, 7, 4, 24), /* SDHI_0_IXRST */ DEF_RST(10, 8, 4, 25), /* SDHI_1_IXRST */ DEF_RST(10, 9, 4, 26), /* SDHI_2_IXRST */ + DEF_RST(12, 5, 5, 22), /* CRU_0_PRESETN */ + DEF_RST(12, 6, 5, 23), /* CRU_0_ARESETN */ + DEF_RST(12, 7, 5, 24), /* CRU_0_S_RESETN */ }; const struct rzv2h_cpg_info r9a09g047_cpg_info __initconst = { From patchwork Mon Feb 10 11:45:34 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tommaso Merciai X-Patchwork-Id: 13967741 X-Patchwork-Delegate: kieran@bingham.xyz Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 948621F3BAE; Mon, 10 Feb 2025 11:46:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739187986; cv=none; b=MTUNX8W6DR8lQD+Tzx/drz9FeiCIlFxSwUUy820TbVz7RS2oM5Uu3ulFF0lfrag0Z/DG2PFXLZG8GWILUoAyKlegmV618XLRsi/PStWVKXDep6Isel96U6dekUwWgoTG1++dbAZq8vFoAQon1fBKymDay5gqhGr3llh3pibLKe8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739187986; c=relaxed/simple; bh=W3BecK8kvWhrKX6u9NpUd1Hv73BjssHxDJFWOrQnheg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=uPqjVMzJGLITjuPGSpk+sEAmSkTgv74/kNFFFy8MdDmkuwNlEPfAXpOzggcGauHidEjKnqcQR+x+PO7wwn8pjCryRX4kbeTV78hHFpdHvAJgMNpcTktfTAd3X1iHrcRxxnWk6zqzxOCfK0sVYoHRtOwBlcSiE5WJ71mnDzi+2jI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RlGAx3/u; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RlGAx3/u" Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-5de5bf41652so3544774a12.1; Mon, 10 Feb 2025 03:46:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739187983; x=1739792783; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cpg9KpBNgMnER2heO+c2aFQqwj+tuJAjEMuxsRouwjM=; b=RlGAx3/udY8wRcCt27ginVhDisbfHe1IxSzBkskzcWrPqD6gZiDly8ub6wYOcNnK1I UAli15ioWVp8EHcUrlUPwCDN2801j8ciW9K49dxrENa9vGChS8wF4z8EfiHBw49uH8e8 9u/vjAbxmbAaLotTOIWnT/h+X2qzmQwGrWkJNhXIF3HoxvQpSWMsH1bISymVjIzN2NmG 6rpYz6BFHtNa1IQmxyUzfawXSLlY/M3MtXW364a/oRwfcgrvKlhczVD44rZPGDgaAsSS Om3L8dQfLMEuJA6hvPEuy5QDLlwPVCc/CJFAwD7VNrlj3469LEpXYbCfbloBbFDsycdg /e3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739187983; x=1739792783; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cpg9KpBNgMnER2heO+c2aFQqwj+tuJAjEMuxsRouwjM=; b=H8grzoRivbWQnACMR8d6lEXStgVE7THHRRU4YupgcObor8ORTiFeRHzgVH6n362odH 1lH+rofKTDT5i+Jw+3pYw2stz5kDskdh0wRGZcs5hcddMV2LvjmPHArLBb1tvqOLmpGK aV6GV2fvGwmTB0H3LwWSo3Zb984cj/k4DXqWY+4H/F5ag+Kc8hXLT+ERaVWsIYxK4yy4 cZ51LQAxdkSEKqQ6CA63UytN1kxeEogzu1VwZsxN6yvd3e41ytFtrnr27ks1q2pa4qgT u1URhqsKjLZgA6qmB1eiImi8mvFSEIDY8070FBxkaW52JxAYxAnc+RiGeLsUGMjdaLUa jwag== X-Forwarded-Encrypted: i=1; AJvYcCUEW7p5ybGXK33O+maipKzC1wTvXbUC4h3wX/NptnRnTqrNx7G4qxYMzBsVhPCFkuTQfs3fuOpRGYpi@vger.kernel.org, AJvYcCV+EMv3HzEvt10g0p8RSy77ZXs21w8P1tWj9bVha2KpzECAU07kJyrxiVAC/J/JD2+sid+TxuyQVCHFtfpq@vger.kernel.org, AJvYcCXqhRmbNmpxEuRdztyGDS7O91Eo4WJGlwZr5l4dIggDjdQ0D6SR5+7t007dzpCbX6KVvVtMpIyvVkd5CnE=@vger.kernel.org X-Gm-Message-State: AOJu0YylySk6pNiV5nZPplJl84CIoOtHJtidlvUuw4Mf6sbwLPgPE84V XpEJXYV0JpYcQoabXOZnX6pMm76qIx4EgoLQn35DJyvafKou3X1A X-Gm-Gg: ASbGnctFoUYBXuhskdvdYo8yGKcrdlnfk8NluknFtlncDdqEFi2PG7h5360mv46V72i Tmzzj+l8j+zlGbiXjjVoECxKi/SKlFoZE2aXVV3x8n0MXLD6Cx6R/V+BATeRohyGwvejxc2SubL mb3RqNSRxUyggtQsKIZ9N47HtKeGzWmT4rP363atB0NQM4VqWsqplDZpHozOMD6/CCLvFulWjeT 0UPioeZAohWyyd6LhEfQsgkL8eDxOUxENX4PR+HKpMMNyC4qW9SoHTw0VwiapzpoB91wd4fMDm+ SilHQUpEgYu6FJZEfoaqewrS4ajS8tLf4wSPMH8ka+rTJ3Hr78t6RcfPHyy3jkeS5REWgXFYmbd xRrx3N26N74sHftG5d/5lw++AMqs= X-Google-Smtp-Source: AGHT+IHiWSAStiYpGW5KAigmZSZA0ERMAPot2WHmHlIhc20+7i+WJMJr7UHhYULuKhuPnQDRFkLrag== X-Received: by 2002:a17:907:7d90:b0:ab7:bcf9:34f with SMTP id a640c23a62f3a-ab7bcf95824mr361190966b.15.1739187982729; Mon, 10 Feb 2025 03:46:22 -0800 (PST) Received: from tom-desktop.example.org (net-188-217-54-237.cust.vodafonedsl.it. [188.217.54.237]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab7a9e6e06fsm428948566b.80.2025.02.10.03.46.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 03:46:22 -0800 (PST) From: Tommaso Merciai X-Google-Original-From: Tommaso Merciai To: tomm.merciai@gmail.com Cc: linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org, biju.das.jz@bp.renesas.com, prabhakar.mahadev-lad.rj@bp.renesas.com, Tommaso Merciai , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/8] media: dt-bindings: renesas,rzg2l-csi2: Document Renesas RZ/V2H(P) SoC Date: Mon, 10 Feb 2025 12:45:34 +0100 Message-Id: <20250210114540.524790-3-tommaso.merciai.xr@bp.renesas.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250210114540.524790-1-tommaso.merciai.xr@bp.renesas.com> References: <20250210114540.524790-1-tommaso.merciai.xr@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-renesas-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Lad Prabhakar The MIPI CSI-2 block on the Renesas RZ/V2H(P) SoC is similar to the one found on the Renesas RZ/G2L SoC, with the following differences: - A different D-PHY - Additional registers for the MIPI CSI-2 link - Only two clocks Add a new compatible string, `renesas,r9a09g057-csi2`, for the RZ/V2H(P) SoC. Signed-off-by: Lad Prabhakar Signed-off-by: Tommaso Merciai --- .../bindings/media/renesas,rzg2l-csi2.yaml | 63 ++++++++++++++----- 1 file changed, 48 insertions(+), 15 deletions(-) diff --git a/Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml b/Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml index 7faa12fecd5b..0d07c55a3f35 100644 --- a/Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml +++ b/Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml @@ -17,12 +17,15 @@ description: properties: compatible: - items: - - enum: - - renesas,r9a07g043-csi2 # RZ/G2UL - - renesas,r9a07g044-csi2 # RZ/G2{L,LC} - - renesas,r9a07g054-csi2 # RZ/V2L - - const: renesas,rzg2l-csi2 + oneOf: + - items: + - enum: + - renesas,r9a07g043-csi2 # RZ/G2UL + - renesas,r9a07g044-csi2 # RZ/G2{L,LC} + - renesas,r9a07g054-csi2 # RZ/V2L + - const: renesas,rzg2l-csi2 + + - const: renesas,r9a09g057-csi2 # RZ/V2H(P) reg: maxItems: 1 @@ -31,16 +34,24 @@ properties: maxItems: 1 clocks: - items: - - description: Internal clock for connecting CRU and MIPI - - description: CRU Main clock - - description: CRU Register access clock + oneOf: + - items: + - description: Internal clock for connecting CRU and MIPI + - description: CRU Main clock + - description: CRU Register access clock + - items: + - description: CRU Main clock + - description: CRU Register access clock clock-names: - items: - - const: system - - const: video - - const: apb + oneOf: + - items: + - const: system + - const: video + - const: apb + - items: + - const: video + - const: apb power-domains: maxItems: 1 @@ -48,7 +59,7 @@ properties: resets: items: - description: CRU_PRESETN reset terminal - - description: CRU_CMN_RSTB reset terminal + - description: CRU_CMN_RSTB reset terminal or D-PHY reset reset-names: items: @@ -101,6 +112,28 @@ required: - reset-names - ports +allOf: + - if: + properties: + compatible: + contains: + const: renesas,r9a09g057-csi2 + then: + properties: + clocks: + maxItems: 2 + + clock-names: + maxItems: 2 + + else: + properties: + clocks: + maxItems: 3 + + clock-names: + maxItems: 3 + additionalProperties: false examples: From patchwork Mon Feb 10 11:45:35 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tommaso Merciai X-Patchwork-Id: 13967742 X-Patchwork-Delegate: kieran@bingham.xyz Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BD9F1F3FD7; Mon, 10 Feb 2025 11:46:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739187989; cv=none; b=QxSUgtXjeLob/r/dl+kqDK83vh/Zgxqu6IrhhivRaHEtQFOKYTkh3lXhF0Wfw5OET9SUZObfHDHHjn6sJDdBcBzWHx2ep5Ufltbm15Z4YocDi6MyT2wqvBjSEOTUDYEL875ScOwvCDdMklFc6hDRZdxMBBLa1JKybAYq/I9BIAQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739187989; c=relaxed/simple; bh=XamZnLRlVYuN4lMtrYwd602NH5O3lnsVOuUr7CA4cUE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=FRETqmZGV7ZkkWuMH3DghHp3vHIRuoUbLvTOSoEszigqqZ3QeZJn7Xc6CMKXmFwiG5YJa8yZIDpOuQJwqWVKxE7HNLPF4Q82fO6T1WU8woipuZHs/zOgWSrDUwu3EwxVFHlfeit26xwbw7NTW/Ij+01RDkZBGyeb06jz5uOxXJA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ESUpIAYo; arc=none smtp.client-ip=209.85.218.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ESUpIAYo" Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-ab7917fc0c2so501265466b.0; Mon, 10 Feb 2025 03:46:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739187986; x=1739792786; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+S/37MwR/DWmOrWf8urGZTxa08grfHR1QAdWmPOa4i8=; b=ESUpIAYoS2W+2940X7DcTVlWljxv+BAlN2Rt1dQHA9lRvADGtJF+9uNnQlPo267mh6 p/0VK4BB+qv6xaCmHRFsST29rWuup5/45Fq5cDJ2xV4oA6lQPdFFqYsQWOR58Al/ev2Y zreqFjgjWh7/M7JB10tEbB9S2o+xbxS7Lq90DR06vfRzwkqQFZxOrs4mDAuM1Jc5roMA aVDnmXmmaL30BM/jSDu2P5xJaw7hp+wcTP+al5yh5MPmycFdlbt4kuUcJ8449+sDGK48 IlMNVhB6pAJN1+hvvv3d3cDPXio8vQjLvI8oJvPWG4vgM5iS2/upw/GJ2wQbSHE2JTM8 Af3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739187986; x=1739792786; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+S/37MwR/DWmOrWf8urGZTxa08grfHR1QAdWmPOa4i8=; b=Qe4Qhxcl44BGuEbhHI/z+tGoIfYXYDvyLZPTLD5S3oTIu+NczYS2OzoO5LrmWn9MS0 v4BMYIPM2YWayn/9C+6+lZpfoDDdpMxxgitXsXp9qVwis4eqGurstja2BdKVxJmtGec2 tVg1vYjHiqj5I8WGNgULIduF15cGQmw7LJajO2IaDavB1wtTr3O3CItk9jWdYRkKNoVQ f9FMfzgQpjm8A6ZBD8MtDU4FF5STzUH8dKPPFy4GvwTk2czNIjQr2PAHtx+g2R8/NQ0R P9gOWwWkQAF4PV38TYBCXA6b1ASmINQk12c+UCNFC2u86y1R6NCPIAGdlP6ex4tlbR6p 5Kzg== X-Forwarded-Encrypted: i=1; AJvYcCUQ2nxoIkRg2BIKh39VtGgSyQax4enPLMcVAhZA7pdnq/YUA8YQPCtRTxF86mQ5b5cBHr5G+dTeW4Ga@vger.kernel.org, AJvYcCWmOFhR/J/EHDFVSybvN2/Ri9l2CzIrfRoEVsrriAwTZ8B+S0EDF+ZfjiPPTTrN/w6ALYcW9S4FC5gmLRQ=@vger.kernel.org, AJvYcCXVX2llmi+xGkbqDGaPP+L4AjTgPmO0+KBYlJdbo8WSXQ95fpR4X5CKT0KUbKurg5sjDKb1i+TVXbjwn8Im@vger.kernel.org X-Gm-Message-State: AOJu0YyQcLQet+BmH7uP8KXBFjPlEpgM07tjm3saEssB2i+3FLWOWyma bZIGDQ1owbfeUE3t0Zw4jRi61q5qYgB2+ahnCisxfsjA1Cawo9aP X-Gm-Gg: ASbGncvOicVhxa70vBFMXbcDNRUFI14+M+lU3xnChmVzTp0B3R+7YxAGS2c97ybdJ+C AU3nOF664luKsn5fkGgzpQJCtFiq7PFvpUufNEKOAI29ubGSqZCEmjdRCVGObiRQEuDSXIWDd9i 9m6mV1qG8j3RF3sFaYiIzPghdX6JGjgvzLk1xhzjZnaRxlZCfcbW/N/UssoMfA/B9vJjBCqqELF Zl9kqA2UkuE0BlQIbo8LU/kAXXqaQITCiSWF2Y/u+KRWFztva06FGNZuRg3kxOJTrW9kPhpfsS2 OXGFN674rlfv6VDDmnvtWW4oqLMOnMPtM7v6F57KLNEPqS/f1vEgIrga2AqyYL3VEHUmufqJ0so q4BtBrsZZW7d+aX7+tsgaPxVC84s= X-Google-Smtp-Source: AGHT+IHi0y/3WYORyp57ukR7kPa0jCnPFXkpclrSAxXC35PxcOwc+4rPLMIMonNEZBTfSz5lgm7kzQ== X-Received: by 2002:a17:907:608d:b0:ab7:94f9:89a with SMTP id a640c23a62f3a-ab794f908a9mr1365561066b.2.1739187985379; Mon, 10 Feb 2025 03:46:25 -0800 (PST) Received: from tom-desktop.example.org (net-188-217-54-237.cust.vodafonedsl.it. [188.217.54.237]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab7a9e6e06fsm428948566b.80.2025.02.10.03.46.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 03:46:24 -0800 (PST) From: Tommaso Merciai X-Google-Original-From: Tommaso Merciai To: tomm.merciai@gmail.com Cc: linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org, biju.das.jz@bp.renesas.com, prabhakar.mahadev-lad.rj@bp.renesas.com, Tommaso Merciai , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/8] media: dt-bindings: renesas,rzg2l-csi2: Document Renesas RZ/G3E CSI-2 block Date: Mon, 10 Feb 2025 12:45:35 +0100 Message-Id: <20250210114540.524790-4-tommaso.merciai.xr@bp.renesas.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250210114540.524790-1-tommaso.merciai.xr@bp.renesas.com> References: <20250210114540.524790-1-tommaso.merciai.xr@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-renesas-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Document the CSI-2 block which is part of CRU found in Renesas RZ/G3E SoC. The CSI-2 block on the RZ/G3E SoC is identical to one found on the RZ/V2H(P) SoC. Signed-off-by: Tommaso Merciai --- .../devicetree/bindings/media/renesas,rzg2l-csi2.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml b/Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml index 0d07c55a3f35..ecc620e9ca52 100644 --- a/Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml +++ b/Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml @@ -25,6 +25,10 @@ properties: - renesas,r9a07g054-csi2 # RZ/V2L - const: renesas,rzg2l-csi2 + - items: + - const: renesas,r9a09g047-csi2 # RZ/G3E + - const: renesas,r9a09g057-csi2 + - const: renesas,r9a09g057-csi2 # RZ/V2H(P) reg: From patchwork Mon Feb 10 11:45:36 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tommaso Merciai X-Patchwork-Id: 13967743 X-Patchwork-Delegate: kieran@bingham.xyz Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7CF11F4261; Mon, 10 Feb 2025 11:46:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739187991; cv=none; b=b7NxgiLKLJJRZ1n2V42abFHDzGPRNTmc2f+5pEPIRfVkWg+Jr9ncxy68cx3oSCnWeyi8zlIPWVX1IHS+xg3nUR678etUhA9+t8G4A/d7qe5RriDfP1t9GfPnv+HLKfgj7ldA2GXC+UaTwKtxIqq68aTToMYamg93xFGmdCqkQP8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739187991; c=relaxed/simple; bh=glO4UHaz3RD3fduKHW4s2v/ZY1TdUQtL0ceFYfAmvUw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=jLFgU4XN1fVHHbgsZQwWEzCgq6sBSNVt9BKTpLcQMkmdpNdu0dVXxu0/qttkgTTc/N4dJlAhdtEEDUN6sI21sgyp7hFHtDg29l77w4DJyM3wzZBWr8mVP4gt6Aa1gHNdqVO9wgh47xCPOhzbQ5wUimVhzDI+H54UDSBqjrFUt/s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iA3S5hgi; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iA3S5hgi" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-ab7c6fc35b3so113038066b.2; Mon, 10 Feb 2025 03:46:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739187988; x=1739792788; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FnkKsW19OEov2QgBC44PML1O8ZJIYR7AhQohKtAxJy0=; b=iA3S5hgil8NVUtNWv15iSieuOleAaBStoUW54nEFcB/VYjnM/XmRI/9H1uTQtsPfzn gaK6DZRxmwYO0AYI7vlss8FUSSIS2l+svq5Acbpefah2O1cBR4Sr7FW5QPG0P0gnUQ4O GVSP/7w41IcbrXdsRxJDSr2RBcUL7KmEgygWFayLgH8kc76xMsSDV+OvQRuRWIUm7BJX 8PpjrPx1+a9xg8Z+StNUJMdnX1lSPdaitzqxwAP0Me3M8UIWpz4ljMnnGsBoqhFY/fvm tVhF8qH6iRbDFAN/+IUhubwmZjyq1HYcPoLGymbuLq6n4rE+PxAfLyDW0cJZ2B/XcaKi XYIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739187988; x=1739792788; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FnkKsW19OEov2QgBC44PML1O8ZJIYR7AhQohKtAxJy0=; b=H3ci9ArXRduad8yydJSnO9SIPXy3Erh2yhRK71oxwwjlZiUnRAKkzl/xYc8T5YmqPv NEqVZbW1pADTho7h7HeCvL+XNQBpgUhqDxXm6r4wl1eh4aBYtZ3NuUguq1R4vsWT7XZW yJghFqezf0tjpV1Qi0UfC/ogNIbTKEyyCuQ9DEbKO+bHfcJXwNUuiZMX18xcNcasC1Lz +aogVuzY0Hp1neqLO404F272ZSyl9IMFP+5LGrorQTC6O2YzTWGc+kTUui0YCEe+75Jj kOfYJmNXYNnTASyRomaF9aozyaMrgunj+PQ6xqZARBcOLexDJKTxRxcOT2cGpWc6MiNB VXLg== X-Forwarded-Encrypted: i=1; AJvYcCUT0NGFc7Bv0kzXbubESUQDtdOmW5hTfAoU1riYvPvEuiPi5J52hUkuJ+UZr61zkZ1TitI8+ftrY8At4jQ=@vger.kernel.org, AJvYcCVPab08dghjHBcEQrn1lKJalIg50gyl1p14Rocch+v30cwN/7k/yrGwux7QXTMss5v2XwHQ5G4QcSz4@vger.kernel.org, AJvYcCX9hY82FVUhUgfNx9BWDGh06tflWIW5vkwSnjZD1/tY1yesdb8Q1Mev4eUVUPbxbZTlEtH7X+Zn2u1CRVdJ@vger.kernel.org X-Gm-Message-State: AOJu0YxhoYiZo4AhIS9dTEWGlp8dvarZOYC9/NhU/R5KpJd1vmTqVOdB bLIhuVOnixGOeZKu6wZrYzWSV2mo4TI1VfgUrZZ/VUBLp54jL6uIy8LDAA== X-Gm-Gg: ASbGnctGn5urJff45OzfgpqcyZsDKEiAU3W++iIkSB9MfS0t5Z7rnEGqu4cBRrSsjHV rwmRooP5MxWaZtG1srWXA+DJvNn9YRjCcTqdOiGXdQrsToG0Mwos6kK5PwzxNxKyApNu6VMIkUn 1VgrqnoolMxdYsMfpAll/+XMzWuHNQ1y12/KC5vmqi6jHWohUBlM8qH7x3DSiKhjTlYEcKpk3u3 kC6CYRdvxCxx+WCjG4Y2uIds291PNehaxx6Se5pkPowFfFMNvZW+LKhqHyNdSNRpC7yf1tFmBcD pa1GALi9ImeRxvZ/hrG3G5hsxCfmZ9ACzrHyNAwcnJi8CMrHOBuFfMZc/9l6K83MrLNRcKFZR7X x/Hray+hyheyADv80Qp5wl2tj3l0= X-Google-Smtp-Source: AGHT+IGCYgTr+h7vSv2zr4+9waXZIbj4U9eWKPeeV+nJjj40xrjcMG1ec+tYGILsSfK85NAjhaq7UQ== X-Received: by 2002:a17:907:d204:b0:ab7:b589:4f9e with SMTP id a640c23a62f3a-ab7b5894fe3mr517108666b.39.1739187987802; Mon, 10 Feb 2025 03:46:27 -0800 (PST) Received: from tom-desktop.example.org (net-188-217-54-237.cust.vodafonedsl.it. [188.217.54.237]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab7a9e6e06fsm428948566b.80.2025.02.10.03.46.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 03:46:27 -0800 (PST) From: Tommaso Merciai X-Google-Original-From: Tommaso Merciai To: tomm.merciai@gmail.com Cc: linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org, biju.das.jz@bp.renesas.com, prabhakar.mahadev-lad.rj@bp.renesas.com, Tommaso Merciai , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/8] media: dt-bindings: renesas,rzg2l-cru: Document Renesas RZ/G3E SoC Date: Mon, 10 Feb 2025 12:45:36 +0100 Message-Id: <20250210114540.524790-5-tommaso.merciai.xr@bp.renesas.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250210114540.524790-1-tommaso.merciai.xr@bp.renesas.com> References: <20250210114540.524790-1-tommaso.merciai.xr@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-renesas-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The CRU block found on the Renesas RZ/G3E ("R9A09G047") SoC has five interrups: - image_conv: image_conv irq - axi_mst_err: AXI master error level irq - vd_addr_wend: Video data AXI master addr 0 write end irq - sd_addr_wend: Statistics data AXI master addr 0 write end irq - vsd_addr_wend: Video statistics data AXI master addr 0 write end irq This IP has only one input port 'port@1' similar to the RZ/G2UL CRU. Document the CRU block found on the Renesas RZ/G3E ("R9A09G047") SoC. Signed-off-by: Tommaso Merciai --- .../bindings/media/renesas,rzg2l-cru.yaml | 33 ++++++++++++------- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/Documentation/devicetree/bindings/media/renesas,rzg2l-cru.yaml b/Documentation/devicetree/bindings/media/renesas,rzg2l-cru.yaml index bc1245127025..7e4a7ed56378 100644 --- a/Documentation/devicetree/bindings/media/renesas,rzg2l-cru.yaml +++ b/Documentation/devicetree/bindings/media/renesas,rzg2l-cru.yaml @@ -17,24 +17,34 @@ description: properties: compatible: - items: - - enum: - - renesas,r9a07g043-cru # RZ/G2UL - - renesas,r9a07g044-cru # RZ/G2{L,LC} - - renesas,r9a07g054-cru # RZ/V2L - - const: renesas,rzg2l-cru + oneOf: + - items: + - enum: + - renesas,r9a07g043-cru # RZ/G2UL + - renesas,r9a07g044-cru # RZ/G2{L,LC} + - renesas,r9a07g054-cru # RZ/V2L + - const: renesas,rzg2l-cru + + - const: renesas,r9a09g047-cru # RZ/G3E reg: maxItems: 1 interrupts: - maxItems: 3 + maxItems: 5 interrupt-names: - items: - - const: image_conv - - const: image_conv_err - - const: axi_mst_err + oneOf: + - items: + - const: image_conv + - const: image_conv_err + - const: axi_mst_err + - items: + - const: image_conv + - const: axi_mst_err + - const: vd_addr_wend + - const: sd_addr_wend + - const: vsd_addr_wend clocks: items: @@ -120,6 +130,7 @@ allOf: contains: enum: - renesas,r9a07g043-cru + - renesas,r9a09g047-cru then: properties: ports: From patchwork Mon Feb 10 11:45:37 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tommaso Merciai X-Patchwork-Id: 13967744 X-Patchwork-Delegate: kieran@bingham.xyz Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B67B1F4E25; Mon, 10 Feb 2025 11:46:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739187995; cv=none; b=XQSfl3IkIAD1nd0hHdvh8wa/nU56b84J5NtPiswigMiumKp098K09sJagM8p/OSRUf184bGB06njYHPzE2wW4UxXUPuFkbOdQRgtzgodUm7I56tfbpQixoB6XaRghSMPnyDV/K33V2Ed5noemBPfzAhIjm2FfCEMfCVoLLnQpew= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739187995; c=relaxed/simple; bh=m0aKVrk7tFoMOEcANYZLY8kSPo/fi11DmlNFeIDignY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=RwhkqVpe+O8J0IoCdp7YvytUq+eDqp8i9fEE0yy92aJQa7HaEbp4odJJ8v0riyTYIX/Z9PPAi1HWfimAtGHG8kWJv4QOgKo0aEa0/o5nuXl+m5jjMhAHqgu+sdb1De+PLLUoKmZf/IevAHUkwZk9r0eDlqyYAxkmgA3xCBEEokg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FmDPoQfz; arc=none smtp.client-ip=209.85.208.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FmDPoQfz" Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-5de6069ceb5so3020546a12.1; Mon, 10 Feb 2025 03:46:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739187992; x=1739792792; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nz3szSsYkvkaaHse2i8ixxQzSkMQ/TCVXddNYl+k4PM=; b=FmDPoQfz9lcUMsj2wc2vHeTXrQe6sAoy+i89jgfyy8LRteYdR4L/eQ5t+k1qam4rhU wUL3OhYIXWkYA1/LfJvIx6j6iQ66w9ZcFrVO9Et/ISXgd1Dt530syIGhl12oUxTFkMxu iKP2M4WsDrOKaLzebjhiw4JCs38I6/eBlfSmnbPTXbmshygkODEaJ/rM1poVyykuWnJt 8jESdxk2/rjL7JXquppk8Q6ljj+rhgC2wDZe3i5H8AOMSp4AiTwBL8fMYok70G6mwSjU ALTNd1UW5ldQ1OV9oGUHCy/DvDhgtGK63E86iItxeGz3Qenooz24y7yI8ojsNDd1kyep Zolg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739187992; x=1739792792; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nz3szSsYkvkaaHse2i8ixxQzSkMQ/TCVXddNYl+k4PM=; b=CW+IHI3SVilLfzGICMrwdAudzIqgeCDmselsqnSqHCxSUam9PyPY3HDSxlyj6kY7Jt hpPB4ZTjBc4M6iYPwoENFjZYRGO0ISWIdstI9iT58ok4OTB32hAJ+VkQ+jsmEDrBOk4y dOzwmwXftcYaQsDCWCNe1VFEdoiV7Q2Q4GChaZnpgey5+u4c/dSbKHvMxaC4zL/mrCoP bAwQIeaFog2fwoljhRnpBIW4oszRqrlP3wmQrfdCvKgEaY/iv0MXQ63nXfBSLG/b+crO E0mLrOXqD6gIuZhTx+706Oek2/VxFpWonABMecVasfSWG0Qld0sGCgkuW2ua1diQLjBt VS4Q== X-Forwarded-Encrypted: i=1; AJvYcCUR0z3m0mYG2O1cPcdDav3ElwBuunmuJYejf+4mU239WtwszGaTW1Vr6ftEy7cMC3MydAa+QjPu57igrno=@vger.kernel.org, AJvYcCWrk4338oN3EdzSB8MLhBRIooYynRHxY+kxIbveb27yzRDwDouMepVOHvP6d2SGAIi0GRwo4pNtR+YKOw2k@vger.kernel.org, AJvYcCXkY5VRmI+cbc6kkP6qw6Ssr5CWtZPsVaXseKv4Xv8ZMRdv0xpioxbSjDdCpddeMypGNsH3s7/4sPSE@vger.kernel.org X-Gm-Message-State: AOJu0Yx0OrlpsaybTJRDGv4yFAmRNgEtfaR8SGiw2zdccJF3X4Jb4Ibe oPOh1kXmeveUXHZVl+A4KsMZqePJO49Es319ioyR1qushyTqLeEl X-Gm-Gg: ASbGncvaWV5OT3OrV8MZf4k8blePrMNKnA9SN4RnP9ZGtjLWsy8qNDZrMlSYeVepfKy T/V+imCvPy+bxKzgbdNhtatVGt35buuuRM7ija/oT5Glc6Z4ORxhODk4RF8uiRUjVL8Nq400+mB COQai9u8zhsPdiUAjcjVx6vDz02HJ1j9wGIu42XhCRrPDpGQscop4L5+Qz1WZyplbBI9vXfoSdq 60CTKtN5xzYwtIJmQKon1it5Yd8Ob2mWo+hW9Wp9BYRSS5hnPRJoLJsIjh9elBOrd5/Uw57Ee/q 4PjXIPDAfogywKgqiBLPotmA9yjUJTDkEoF/a23D7K3usinZ+UEH3TgTFzbjBZnPVuZVOk4AXBR vl68HvO3/kcIVgEsbOx9hUw74cFk= X-Google-Smtp-Source: AGHT+IGbK56al2+IkAJDAkRxBgl79GgTLsF/jHB38d0GCZbDYUJMvCHJ++lVQG19QUdZ/eLFrwvXog== X-Received: by 2002:a17:906:390f:b0:ab7:b821:6782 with SMTP id a640c23a62f3a-ab7b8216a00mr415884566b.14.1739187991300; Mon, 10 Feb 2025 03:46:31 -0800 (PST) Received: from tom-desktop.example.org (net-188-217-54-237.cust.vodafonedsl.it. [188.217.54.237]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab7a9e6e06fsm428948566b.80.2025.02.10.03.46.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 03:46:30 -0800 (PST) From: Tommaso Merciai X-Google-Original-From: Tommaso Merciai To: tomm.merciai@gmail.com Cc: linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org, biju.das.jz@bp.renesas.com, prabhakar.mahadev-lad.rj@bp.renesas.com, Tommaso Merciai , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Geert Uytterhoeven , Magnus Damm , Laurent Pinchart , Hans Verkuil , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 5/8] media: rzg2l-cru: csi2: Use temporary variable for struct device in rzg2l_csi2_probe() Date: Mon, 10 Feb 2025 12:45:37 +0100 Message-Id: <20250210114540.524790-6-tommaso.merciai.xr@bp.renesas.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250210114540.524790-1-tommaso.merciai.xr@bp.renesas.com> References: <20250210114540.524790-1-tommaso.merciai.xr@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-renesas-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Lad Prabhakar Use a temporary variable for the struct device pointers to avoid dereferencing. Signed-off-by: Lad Prabhakar Signed-off-by: Tommaso Merciai Reviewed-by: Biju Das --- .../platform/renesas/rzg2l-cru/rzg2l-csi2.c | 31 ++++++++++--------- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c index 881e910dce02..948f1917b830 100644 --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c @@ -764,10 +764,11 @@ static const struct media_entity_operations rzg2l_csi2_entity_ops = { static int rzg2l_csi2_probe(struct platform_device *pdev) { + struct device *dev = &pdev->dev; struct rzg2l_csi2 *csi2; int ret; - csi2 = devm_kzalloc(&pdev->dev, sizeof(*csi2), GFP_KERNEL); + csi2 = devm_kzalloc(dev, sizeof(*csi2), GFP_KERNEL); if (!csi2) return -ENOMEM; @@ -775,28 +776,28 @@ static int rzg2l_csi2_probe(struct platform_device *pdev) if (IS_ERR(csi2->base)) return PTR_ERR(csi2->base); - csi2->cmn_rstb = devm_reset_control_get_exclusive(&pdev->dev, "cmn-rstb"); + csi2->cmn_rstb = devm_reset_control_get_exclusive(dev, "cmn-rstb"); if (IS_ERR(csi2->cmn_rstb)) - return dev_err_probe(&pdev->dev, PTR_ERR(csi2->cmn_rstb), + return dev_err_probe(dev, PTR_ERR(csi2->cmn_rstb), "Failed to get cpg cmn-rstb\n"); - csi2->presetn = devm_reset_control_get_shared(&pdev->dev, "presetn"); + csi2->presetn = devm_reset_control_get_shared(dev, "presetn"); if (IS_ERR(csi2->presetn)) - return dev_err_probe(&pdev->dev, PTR_ERR(csi2->presetn), + return dev_err_probe(dev, PTR_ERR(csi2->presetn), "Failed to get cpg presetn\n"); - csi2->sysclk = devm_clk_get(&pdev->dev, "system"); + csi2->sysclk = devm_clk_get(dev, "system"); if (IS_ERR(csi2->sysclk)) - return dev_err_probe(&pdev->dev, PTR_ERR(csi2->sysclk), + return dev_err_probe(dev, PTR_ERR(csi2->sysclk), "Failed to get system clk\n"); - csi2->vclk = devm_clk_get(&pdev->dev, "video"); + csi2->vclk = devm_clk_get(dev, "video"); if (IS_ERR(csi2->vclk)) - return dev_err_probe(&pdev->dev, PTR_ERR(csi2->vclk), + return dev_err_probe(dev, PTR_ERR(csi2->vclk), "Failed to get video clock\n"); csi2->vclk_rate = clk_get_rate(csi2->vclk); - csi2->dev = &pdev->dev; + csi2->dev = dev; platform_set_drvdata(pdev, csi2); @@ -804,18 +805,18 @@ static int rzg2l_csi2_probe(struct platform_device *pdev) if (ret) return ret; - pm_runtime_enable(&pdev->dev); + pm_runtime_enable(dev); ret = rzg2l_validate_csi2_lanes(csi2); if (ret) goto error_pm; - csi2->subdev.dev = &pdev->dev; + csi2->subdev.dev = dev; v4l2_subdev_init(&csi2->subdev, &rzg2l_csi2_subdev_ops); csi2->subdev.internal_ops = &rzg2l_csi2_internal_ops; - v4l2_set_subdevdata(&csi2->subdev, &pdev->dev); + v4l2_set_subdevdata(&csi2->subdev, dev); snprintf(csi2->subdev.name, sizeof(csi2->subdev.name), - "csi-%s", dev_name(&pdev->dev)); + "csi-%s", dev_name(dev)); csi2->subdev.flags = V4L2_SUBDEV_FL_HAS_DEVNODE; csi2->subdev.entity.function = MEDIA_ENT_F_VID_IF_BRIDGE; @@ -852,7 +853,7 @@ static int rzg2l_csi2_probe(struct platform_device *pdev) v4l2_async_nf_cleanup(&csi2->notifier); media_entity_cleanup(&csi2->subdev.entity); error_pm: - pm_runtime_disable(&pdev->dev); + pm_runtime_disable(dev); return ret; } From patchwork Mon Feb 10 11:45:38 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tommaso Merciai X-Patchwork-Id: 13967745 X-Patchwork-Delegate: kieran@bingham.xyz Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F12D1F540C; Mon, 10 Feb 2025 11:46:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739187998; cv=none; b=tI0P64nNoEbX3mhIAE20/hBtbXGp1gmpEc1kuXz+K3SwcA1vuz1oNY5A22y8SYNx2YbxgMg/nqfT3KpQD+0A8MF2OiyGDiN8h2nS0W6JX9xD/w9BI+X8yvoHjqGdFHMjpofbFWW/3MElIBI7laMaAfj81q1Y6DAFGdey/fcZ6Lo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739187998; c=relaxed/simple; bh=oiV3oL9dSD4CI/6Eb1rg9fApuIg6n3xWhtO/IS5Xd48=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=O7KXIrpridJ8H/3ICQsDoIqdLvW/cIEW/jMt/Y6ukGHE9W9+dgCJLnEpQkJPmPqClh19rsppD4FKmU821HU9z4OcIjF4cozHeBLwDJVSsDJ88I21btItr0RJsR5qeKsUNsYaJHILhCSdu/iemQ499Nje6JTwL8jx2A4xgrYZ5lQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=P9WyhbCt; arc=none smtp.client-ip=209.85.218.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="P9WyhbCt" Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-ab7cb1154abso80040166b.0; Mon, 10 Feb 2025 03:46:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739187995; x=1739792795; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2cHOLKsMbINIaOJV+51j6N1WbHFmr4xoYh8MR/djTMs=; b=P9WyhbCtbNBI6CLG1Aip4ammIGtd70bzSzCPDZg3qEnKYpKIFmxcekkjAiEakvteiH JFF1jeo9f6NY1As+vooVCGmPTqyBl+E9qqSXCuvwJ6Yo/RTpUqAyMGkyEW0lzDt7ueLi swaJhMN+az0NeT10dMw/dm900KmoOC71mlJWi0Hxtum0kF/3TV2zXmiiPt8zhuu1OOsa V/kpAa2dz5jJbOErzU7Q+1Hq0+boji5KKibPEvW1v1auJGuzAvVg8CNqmgXhIsCy2GVL Jik/j9LTC9cfK00i/tsDPAy2uhSnMq2NP/4Pc44e6EvGb6iHdDfAaZMn0eDGc1RMOOYD 5maA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739187995; x=1739792795; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2cHOLKsMbINIaOJV+51j6N1WbHFmr4xoYh8MR/djTMs=; b=W4msDnMckXR7pi9Ey/Ed/sElA2nLtX5J3Trj09xsnpPqDDjUncWWG+NmBMOzPAa1Qn J2IF38QDSke9HkiYPRk5V6/6iLgmVesqal4neQpf0KSJT4eTx8ssRHUGg5o6rcTumhiE Mz+0mBYx7HFZvXjCzolLc2vIL1HL24tKZ58/g3L6p4qRRxM5uN3c8lxEyBQwco2mHsoC XRro9LudJ+Vvpa6tnAoqC81X0OHTO7is1Nqnmof3DDy0OaY5Op9Bfp6AssM/d3Gjhi2c pWwa0MjRVNTpnPvj5Cg/O3h5KpD0z3GY8e7x/9eHpx+jxfUNXECo47cuhWMxCDxaNU8G BLXA== X-Forwarded-Encrypted: i=1; AJvYcCUj8NKa/YuqysARBghDdvYkETo7Ws6M4OTjHRax2XI2M4ASVNi7SRjY2Eeah7iJAu1Lgi+i1QwMEEAQ74A=@vger.kernel.org, AJvYcCX9ZYu17O893YwFzLpXI5WrGMN0UueyFbHTaXILKAwwXFQcYkKoGv8onWFvSymQ9q/scXlwlTcCE4m+OyRT@vger.kernel.org, AJvYcCXIWxd08+jnPaBTiWEJM/+2yGjtd4XqTFe7nxn6ug/FrXnkLHORfd9OlEDiBoyt+skudSaflH0WzQ8+@vger.kernel.org X-Gm-Message-State: AOJu0YzZ6lP/oPLsIUZPk1w1Mud1ngZ7NqgAYdMYqvi9db0orFUZQYNz ixHj4FwgE+5NY0CogQLtvVGG2mq1ECdBZbejPjYdZUacuYi0LSv8z8eKDQ== X-Gm-Gg: ASbGncs6pyPMGgMptQoHofOp+Y7DuNSmopRBeKOgn7xUnmtE4QIkPo0/uWCUMIVyp/m nbJxNbHiEAjs5baH7ahQ0BSzd3bmDmqetf4d0jyB8LN0asmpIsEfMAz2luDjH6ontJatL8cgQwv SaMd0Tvqim+uEkFasyAx/Vw9/w9s/DtLv0m2i3K7ttvyxv4ObfLVdXFUsscSFRscrnnKEzA9iVG 7pp2X3Vq0bbpwxzmWhouDtgNQZbrmoh7daifiAVRWlLwn3ndfa/1W0OKNUdtnM98pJNH0MXf+/2 4lBBctLCP0RctHGNNpY3aA5tUrxQOrLHkv+YtwyEkuljderyJZJjZiQLjzohORPwr9TMgRYuJLD P8Hcb32ZDzzvzA5h4loJrMuMc8xc= X-Google-Smtp-Source: AGHT+IGiMPiccONylC0UKLjyKhZ3k7AFdWfFUq7AG4w3wNHe1IsClqnJ+KBsn761/bgnqxFp08ff7Q== X-Received: by 2002:a05:6402:40cb:b0:5d0:bf5e:eb8 with SMTP id 4fb4d7f45d1cf-5de45070884mr29082944a12.23.1739187994776; Mon, 10 Feb 2025 03:46:34 -0800 (PST) Received: from tom-desktop.example.org (net-188-217-54-237.cust.vodafonedsl.it. [188.217.54.237]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab7a9e6e06fsm428948566b.80.2025.02.10.03.46.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 03:46:34 -0800 (PST) From: Tommaso Merciai X-Google-Original-From: Tommaso Merciai To: tomm.merciai@gmail.com Cc: linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org, biju.das.jz@bp.renesas.com, prabhakar.mahadev-lad.rj@bp.renesas.com, Tommaso Merciai , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Laurent Pinchart , Hans Verkuil , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 6/8] media: rzg2l-cru: csi2: Use devm_pm_runtime_enable() Date: Mon, 10 Feb 2025 12:45:38 +0100 Message-Id: <20250210114540.524790-7-tommaso.merciai.xr@bp.renesas.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250210114540.524790-1-tommaso.merciai.xr@bp.renesas.com> References: <20250210114540.524790-1-tommaso.merciai.xr@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-renesas-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Use newly added devm_pm_runtime_enable() into rzg2l_csi2_probe() and drop error path accordingly. Drop also unnecessary pm_runtime_disable() from rzg2l_csi2_remove(). Signed-off-by: Tommaso Merciai Reviewed-by: Biju Das Reviewed-by: Laurent Pinchart --- drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c index 948f1917b830..4ccf7c5ea58b 100644 --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c @@ -805,11 +805,13 @@ static int rzg2l_csi2_probe(struct platform_device *pdev) if (ret) return ret; - pm_runtime_enable(dev); + ret = devm_pm_runtime_enable(dev); + if (ret) + return ret; ret = rzg2l_validate_csi2_lanes(csi2); if (ret) - goto error_pm; + return ret; csi2->subdev.dev = dev; v4l2_subdev_init(&csi2->subdev, &rzg2l_csi2_subdev_ops); @@ -834,7 +836,7 @@ static int rzg2l_csi2_probe(struct platform_device *pdev) ret = media_entity_pads_init(&csi2->subdev.entity, ARRAY_SIZE(csi2->pads), csi2->pads); if (ret) - goto error_pm; + return ret; ret = v4l2_subdev_init_finalize(&csi2->subdev); if (ret < 0) @@ -852,8 +854,6 @@ static int rzg2l_csi2_probe(struct platform_device *pdev) v4l2_async_nf_unregister(&csi2->notifier); v4l2_async_nf_cleanup(&csi2->notifier); media_entity_cleanup(&csi2->subdev.entity); -error_pm: - pm_runtime_disable(dev); return ret; } @@ -867,7 +867,6 @@ static void rzg2l_csi2_remove(struct platform_device *pdev) v4l2_async_unregister_subdev(&csi2->subdev); v4l2_subdev_cleanup(&csi2->subdev); media_entity_cleanup(&csi2->subdev.entity); - pm_runtime_disable(&pdev->dev); } static int rzg2l_csi2_pm_runtime_suspend(struct device *dev) From patchwork Mon Feb 10 11:45:39 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tommaso Merciai X-Patchwork-Id: 13967746 X-Patchwork-Delegate: kieran@bingham.xyz Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49FA41F7060; Mon, 10 Feb 2025 11:46:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739188002; cv=none; b=FtO6iV5kRRi3zyPE6STmeaFcVGaIXLDfxj+do986mKTgRdamEzhkKwfnQ6qENSyQ/lIRolUACAav+fjxqU75IeFn79rICWDkfBDx9fpEuaZeXDSVYd3b/z0k8OHr48dnlBHpKE83qwBHgyBQCmg2ycwl1OO8qcuDpWY58znt50w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739188002; c=relaxed/simple; bh=IkMF0n7MKdUNN8xQh6JlNCT4oSGo+0zV2gkJGAExEgI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=N6K814zTIp7BU7LXMim7dBies8ZpNYHc1py1TnJ383NjJOZShdscDBOJ//sLVfirc4FhiqzOOr6SoPwOND5vr2G0gLj8sZ/WG1GLui+x1B322sz8Mlg3moV2jnLTgO9inp7/20WWia+k0GRAfmg6yX4ooPnZRXsRTgPhkC/t4XI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=f2vtlw12; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="f2vtlw12" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-ab7c6fc35b3so113071266b.2; Mon, 10 Feb 2025 03:46:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739187998; x=1739792798; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rF22zAvBGpv5Tb+cbF1nWCHUWRiZC8kh/HmTUzcCedM=; b=f2vtlw123OM0NVFG8DIjbP18u3e95ywYqCxx6OKUaxAXm5wSs19qfvxUq3/Jodhi2/ 014thwAMLdWFl2wdZybNIU6lLqjrdc2rPx10Kp98a7cj90GHGOu653fDqmDJqgODnvhX QmhiMLIeYzg67Qos+eN4DyqIGYx5aJTa/5t2v4y4O2/kS4a4yWQKzcXKluox4nBwJDTY 2E11QlTZywvD1GokMxOT8oplYVP8LpUHC04S0AdCexyAWcaDL5Uzon64DvYX1y4a+mN1 H3F3lBAf+j3x4wHkYVbDMrEuF6bNWiwjKZeqFAJ06nzieJ8oVuHyEtROs01+ITqUwSvQ 47aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739187998; x=1739792798; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rF22zAvBGpv5Tb+cbF1nWCHUWRiZC8kh/HmTUzcCedM=; b=EP6DtJXPs2R7X36D83/dDN4vVSWE91ZJTdRD8lThoEAtG5TnQuvXB2YkVymKnlH5UJ JFVnLLYYR6mPaVXyc/sAD/BlYeO9Uoic4mOAXKLREHgY1nmXinUBLbnT4iX6epUJKKJK TX9LsrzTHsol5tgLyPYsBxuLverVJ9s5ddC+e1ZcElWZsWRtQkUkrQ2qzp5jR2rTVpwN Q8r19fKm3jb65EwcHCwjJW9v+sEwa8UHLpL/O6ZaePWzgPx6njmeORpRNXkbJ5XCWHEY 7kMlmYo6D6lEIpk2WLvyp9cvWeUQ/9m4Rl8bO8/7w+gfQnpp5l18fHz0XWl6mSVGZKUE aoWg== X-Forwarded-Encrypted: i=1; AJvYcCUsmi2LtQwF4deHcsK/EWwyHlFL0llH8c0FruWdA2YjSBzB+fPyX+uG09TXYHDUOXhLToEPQGDhThcGM37r@vger.kernel.org, AJvYcCVLQowdPBRQEke8fUJC0nFsunBKTLlbku0JoufjLz27B91UE1n4dE5Jwt4fHy4248pLNhI9vmiSGo9SwWs=@vger.kernel.org, AJvYcCXeSt9zxBLPsmDUSAewb3BPIem7dhcyivp+lADci4mrHiocnUokeifI99V9SYdMnIciKxg96WGdGq3P@vger.kernel.org X-Gm-Message-State: AOJu0YxuPOAgNh4Ur42QzkoZ6NrSGCOAfQNYsoMjPV7sfDOago745TTj mPsR8fZ0TMcQvznh1gRevsAM1i0lvPfFF0YF7CK2U7P9HyGk1s2s X-Gm-Gg: ASbGncvL/ltq0SiQfyAOxCH8ZkGKn39ZJv8sbeebsCRgIxKDVa+RFOFD6LhSktId+YO BlFC6W3+8zIpnWvUNyOS56EB3IjQ7ozHwm29WZDnjYirAQ94myhycZyHkDtuNLT3o/NEnRQAzz1 1wgMVfDBd8pPLdeb3aivTgliAFRVCKIX/Uc28DO+eL0LDaEJg8et+spTx4S0wVLcDVQ9GR6RYRV OgSmRguNunPSO/OCnSTGJNh/z59IbMUlyVOd/10KeHnTW0l0++tCeczYCsRsMcLDQ04wq2fDBKS BZ7ZZTV26+dgR9Tqxs45IZ+FGpB/idPJYCQJSZVJSHqpniQwS2KnSVgX9GD0LoT2RK+zoSDLTty kP/MpNAw7yqJNPXphbG3WgKzcvIw= X-Google-Smtp-Source: AGHT+IFuaL5cqIGTztKLZF6XwPMKmANIqJLVQA65gpv+Xf96dIfnOl/54T8TfjWrTFO2vP1a8RLITQ== X-Received: by 2002:a17:907:d204:b0:ab7:b589:4f9e with SMTP id a640c23a62f3a-ab7b5894fe3mr517154066b.39.1739187998399; Mon, 10 Feb 2025 03:46:38 -0800 (PST) Received: from tom-desktop.example.org (net-188-217-54-237.cust.vodafonedsl.it. [188.217.54.237]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab7a9e6e06fsm428948566b.80.2025.02.10.03.46.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 03:46:37 -0800 (PST) From: Tommaso Merciai X-Google-Original-From: Tommaso Merciai To: tomm.merciai@gmail.com Cc: linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org, biju.das.jz@bp.renesas.com, prabhakar.mahadev-lad.rj@bp.renesas.com, Tommaso Merciai , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Geert Uytterhoeven , Magnus Damm , Laurent Pinchart , Hans Verkuil , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 7/8] media: rzg2l-cru: rzg2l-core: Use temporary variable for struct device in rzg2l_cru_probe() Date: Mon, 10 Feb 2025 12:45:39 +0100 Message-Id: <20250210114540.524790-8-tommaso.merciai.xr@bp.renesas.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250210114540.524790-1-tommaso.merciai.xr@bp.renesas.com> References: <20250210114540.524790-1-tommaso.merciai.xr@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-renesas-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Lad Prabhakar Use a temporary variable for the struct device pointers to avoid dereferencing. Signed-off-by: Lad Prabhakar Signed-off-by: Tommaso Merciai Reviewed-by: Biju Das Reviewed-by: Laurent Pinchart --- .../platform/renesas/rzg2l-cru/rzg2l-core.c | 29 ++++++++++--------- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c index 89be584a4988..70fed0ce45ea 100644 --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c @@ -240,10 +240,11 @@ static int rzg2l_cru_media_init(struct rzg2l_cru_dev *cru) static int rzg2l_cru_probe(struct platform_device *pdev) { + struct device *dev = &pdev->dev; struct rzg2l_cru_dev *cru; int irq, ret; - cru = devm_kzalloc(&pdev->dev, sizeof(*cru), GFP_KERNEL); + cru = devm_kzalloc(dev, sizeof(*cru), GFP_KERNEL); if (!cru) return -ENOMEM; @@ -251,32 +252,32 @@ static int rzg2l_cru_probe(struct platform_device *pdev) if (IS_ERR(cru->base)) return PTR_ERR(cru->base); - cru->presetn = devm_reset_control_get_shared(&pdev->dev, "presetn"); + cru->presetn = devm_reset_control_get_shared(dev, "presetn"); if (IS_ERR(cru->presetn)) - return dev_err_probe(&pdev->dev, PTR_ERR(cru->presetn), + return dev_err_probe(dev, PTR_ERR(cru->presetn), "Failed to get cpg presetn\n"); - cru->aresetn = devm_reset_control_get_exclusive(&pdev->dev, "aresetn"); + cru->aresetn = devm_reset_control_get_exclusive(dev, "aresetn"); if (IS_ERR(cru->aresetn)) - return dev_err_probe(&pdev->dev, PTR_ERR(cru->aresetn), + return dev_err_probe(dev, PTR_ERR(cru->aresetn), "Failed to get cpg aresetn\n"); - cru->vclk = devm_clk_get(&pdev->dev, "video"); + cru->vclk = devm_clk_get(dev, "video"); if (IS_ERR(cru->vclk)) - return dev_err_probe(&pdev->dev, PTR_ERR(cru->vclk), + return dev_err_probe(dev, PTR_ERR(cru->vclk), "Failed to get video clock\n"); - cru->dev = &pdev->dev; - cru->info = of_device_get_match_data(&pdev->dev); + cru->dev = dev; + cru->info = of_device_get_match_data(dev); irq = platform_get_irq(pdev, 0); if (irq < 0) return irq; - ret = devm_request_irq(&pdev->dev, irq, rzg2l_cru_irq, 0, + ret = devm_request_irq(dev, irq, rzg2l_cru_irq, 0, KBUILD_MODNAME, cru); if (ret) - return dev_err_probe(&pdev->dev, ret, "failed to request irq\n"); + return dev_err_probe(dev, ret, "failed to request irq\n"); platform_set_drvdata(pdev, cru); @@ -285,8 +286,8 @@ static int rzg2l_cru_probe(struct platform_device *pdev) return ret; cru->num_buf = RZG2L_CRU_HW_BUFFER_DEFAULT; - pm_suspend_ignore_children(&pdev->dev, true); - pm_runtime_enable(&pdev->dev); + pm_suspend_ignore_children(dev, true); + pm_runtime_enable(dev); ret = rzg2l_cru_media_init(cru); if (ret) @@ -296,7 +297,7 @@ static int rzg2l_cru_probe(struct platform_device *pdev) error_dma_unregister: rzg2l_cru_dma_unregister(cru); - pm_runtime_disable(&pdev->dev); + pm_runtime_disable(dev); return ret; } From patchwork Mon Feb 10 11:45:40 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tommaso Merciai X-Patchwork-Id: 13967747 X-Patchwork-Delegate: kieran@bingham.xyz Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C4141F76B3; Mon, 10 Feb 2025 11:46:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739188006; cv=none; b=gw5zGR6olLbqlbe1ugGcPIjH6VMCKnqFyn55VkHtVRdw6sDGHn0UpauB5qy6KStuq4pMNN24tqFlpqPiIyyXEvHVX1ATtKVMZoozl1k6nlgO2XHpvTVk1jnOcijevBv9P0epRfT4PLj4fXmqGDmil1Y3aMWmWJBJ79uL1n656bE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739188006; c=relaxed/simple; bh=ByguyBXADWYTX/oRAJYRKQiHaqitMS1wE2xl0S/y6xU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=M5RCorPANVFY8csvgLFFZK2msGtRJ7TwyJXMcHu76uBB6pKAxC8ZRRTW8phO5+L8f3jmYxrIepeo5YoHHzi8ERTDfz/lDksrMeKa6+P5QX+vpHdtBertFQNx35MWpLapXAXdrAjrtR1uThhxnhAVBXp/cIGrSUGY+4huaB0bRu4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cdGFoGjw; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cdGFoGjw" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-aaedd529ba1so536087366b.1; Mon, 10 Feb 2025 03:46:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739188002; x=1739792802; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1ONRQIkN6hOeMPC6pr5QUst9OFB5Ve/NbKINHvThgHg=; b=cdGFoGjwEZUSbbQG+Uh79HkC2PaagBS/wxdNE/dzQXuJxjkQa3nl78BczLmAQt9xqc RibLwehWUXVgNbc28LDeUp+K1KFBvmCMuL5Q5n1teru/fRSZg5BK54VEGrFSajK5cfak foyBaWYyWJDOxbuJU9il3eSlMabWAZ29tVJOGGpBQASx57moTT5F0BORRwTPCLb+KpZy fkHX9xkIWgclo93gL5j9pahAKmz3eH0KqhMYum/+vPbFmtb+TR6IJ1IotpaUU57PzMly Gni7sYvOhnyv/O+XQlIfpduzhCCFgQfqyyaRLeUB99vjip/vX9v6abo/whjncS65EZlh fHig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739188002; x=1739792802; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1ONRQIkN6hOeMPC6pr5QUst9OFB5Ve/NbKINHvThgHg=; b=cZKTv5AI4RYbxJhq30HwUO2nxD7QBoCDyi+nLX+M2g0v647z3dgywT0JITL8c0UJdU NMjkgtI16+G+wv4CreZQIa8j49bRRoTvAwYh5zI8bj9gk/eluPTj2gNpf9JQUSROyows bdjXZ/wIeCT/5cNcnSNDfldzCXUjLdcX2lBBAcpc3nWjkG+XKEzFjdpKX8lG6W8ITkVp wOXPSGSfeAaUL2OUhIBIL/mEIYei01v/pB5SuKnKDoYhWZI2XPQagi5EJQCQ2Zb2A3bG s9q1tY5GlQeCi/yPhyLIeygbdj4UPZWZ0vWiupZCL04pqSzm0p6Z0FCjSwGaK2EqQ8nq 5CaA== X-Forwarded-Encrypted: i=1; AJvYcCUwGMXT4dydeM+yO33hW0dMFLLA7m8VCJsPklX0IeWC3dfu4rbVTmxm/KmeoavIiLD8qZanGQ59v/tJ0/0=@vger.kernel.org, AJvYcCWy6I80n2ZAF4oEDJq1n8x4o7xzr6d4JFxYrJDevDVlh7aO+LE9mSMkSFe6Vbvru5dkqzLo+/NsvuQxEWAp@vger.kernel.org, AJvYcCXr5GZrzex/h+4s1lxxN/fgzMjaoOTB4P8LCCwuDE4hgWSdXkMpYewXrhW3M6MFOdoNG7nMMfh6EgaS@vger.kernel.org X-Gm-Message-State: AOJu0YwlrtBSu+n5zeohCXzy31hfCH0Bzx28oWyabBLi7YqkHvfNr+eV VNl2GGWO8F3EaDo094EjiDD+k9cqhC+CUwTIvWDMIpenJMuKuCh+ X-Gm-Gg: ASbGncsNn4OLloybcAJiLASuM4HaU4SAt2W0vzf6ursobkGl0ZXfN/D/K6R+pNglLwm 5TbWbx9nOQDWP+sdmbUsyk0TxrPrusLQUdv80+SPRYDChlrEzST2E4ivwVDjpf3/D5ZWmczIzpc CnkOO4lhl8fWdqslKDrYapqVRiV4yR97+OVBGoPJ687uQX8NorXkU2dRVxMQIH8id7ChhmySf8D wchVi64Q7t6ihkxvIkODjIItBs6wEWyURB0N6XImhdq/QFX8u5EgkMMRp/GZDOUWz2BGAXS56c/ 49T0KM7G4HCV7Dc2qdJFNMgLMtB5pxUPiwUOuioEq2rXc0y1z4CM+By4WH3jURhw0eEX9nzDsyt OZo+xDeWpiQQhD98WrXDo8UN4C7Y= X-Google-Smtp-Source: AGHT+IHEAXMfF9ZZ1zfKKC4roNhEFvjRQ/KPi7La7Ne5MBIdI0BsVzZ518DZR9RFmVTLkdAeQcPxOw== X-Received: by 2002:a05:6402:208a:b0:5dc:5a51:cbfa with SMTP id 4fb4d7f45d1cf-5de44fe949emr35419842a12.6.1739188001773; Mon, 10 Feb 2025 03:46:41 -0800 (PST) Received: from tom-desktop.example.org (net-188-217-54-237.cust.vodafonedsl.it. [188.217.54.237]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab7a9e6e06fsm428948566b.80.2025.02.10.03.46.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 03:46:41 -0800 (PST) From: Tommaso Merciai X-Google-Original-From: Tommaso Merciai To: tomm.merciai@gmail.com Cc: linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org, biju.das.jz@bp.renesas.com, prabhakar.mahadev-lad.rj@bp.renesas.com, Tommaso Merciai , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Laurent Pinchart , Hans Verkuil , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 8/8] media: rzg2l-cru: rzg2l-core: Use devm_pm_runtime_enable() Date: Mon, 10 Feb 2025 12:45:40 +0100 Message-Id: <20250210114540.524790-9-tommaso.merciai.xr@bp.renesas.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250210114540.524790-1-tommaso.merciai.xr@bp.renesas.com> References: <20250210114540.524790-1-tommaso.merciai.xr@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-renesas-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Use newly added devm_pm_runtime_enable() into rzg2l_cru_probe() and drop unnecessary pm_runtime_disable() from rzg2l_cru_probe() and rzg2l_csi2_remove(). Signed-off-by: Tommaso Merciai Reviewed-by: Biju Das --- drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c index 70fed0ce45ea..5548b328d970 100644 --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c @@ -287,7 +287,9 @@ static int rzg2l_cru_probe(struct platform_device *pdev) cru->num_buf = RZG2L_CRU_HW_BUFFER_DEFAULT; pm_suspend_ignore_children(dev, true); - pm_runtime_enable(dev); + ret = devm_pm_runtime_enable(dev); + if (ret) + return ret; ret = rzg2l_cru_media_init(cru); if (ret) @@ -297,7 +299,6 @@ static int rzg2l_cru_probe(struct platform_device *pdev) error_dma_unregister: rzg2l_cru_dma_unregister(cru); - pm_runtime_disable(dev); return ret; } @@ -306,8 +307,6 @@ static void rzg2l_cru_remove(struct platform_device *pdev) { struct rzg2l_cru_dev *cru = platform_get_drvdata(pdev); - pm_runtime_disable(&pdev->dev); - v4l2_async_nf_unregister(&cru->notifier); v4l2_async_nf_cleanup(&cru->notifier);