From patchwork Mon Feb 10 22:33:27 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13968830 Received: from mail-oi1-f177.google.com (mail-oi1-f177.google.com [209.85.167.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7D2B253F08 for ; Mon, 10 Feb 2025 22:37:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227055; cv=none; b=qq7s9MnvpLBZ8JW3LBaaj+2H+e8e7RKwyB26W8zsvil1B5u91QX0df2oW0XZTZHurzEDBTaIdTkqm5a/qd+vRrGj3BfuQyRIXc8DZBNmXSeigX5eWXBrclIbZUSQgWj3yGxWmnoVWdUrlMEtvAZ1rf/l1oZkaeFBOYjuZjegqeQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227055; c=relaxed/simple; bh=N0Em4RkHQUvBxoy2r74GZrWjDlivg7oqNPXmv4at8dI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CKrZxxgBVJtf8L1+YTVdZz48QPmVksPOkGw8xldnSK8YGtLoIM9kxtTR4B/XdV9y/yw7TAcSCwC92wP/mOuwtNrQEhhROH4Raao+M/5CxOP5CaScjNk77j6ixiXCJoK93BM/QgApQ7hakrZaERNOwoLXsME0pBF0S1alj5Isfrs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=UtsC4PU2; arc=none smtp.client-ip=209.85.167.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="UtsC4PU2" Received: by mail-oi1-f177.google.com with SMTP id 5614622812f47-3f3a97b3e26so1138337b6e.2 for ; Mon, 10 Feb 2025 14:37:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739227053; x=1739831853; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=+BdRdts91zZ1lBz7cZl7Oig3MKNc6jPxib3EI6sYvCw=; b=UtsC4PU2jEf6Iigi4rlnw6wcpWHJPn9dN1Y/ssJiTHPQO/CZtNRpsBzMfDZlyt/we0 RHuvVN+hHYkiWa+JZ9v2hwWgZBkL9x+SieJHP5Ac/9ymC+T0V6fuZ9mDkfZyOmRAwJne uPbi8Z4raeikVNmyPxq48ndMS9AY4DnshSuYZQXcVYZAxWB6CLw/5yRRn7eHlEkcFFnI cWRNaWQ/SNXQXB/fEk3gZ3NBilf2Ay0p8Z3tmcIGDHXh9atrJO+I7wOKX6b+rD/P9Tw9 bum8f285kxDjh+R4nDlD/oxghHe+83NmYNGeeyjmHMDgAXUxM9+gyp49TVcNafo13Xw1 0qXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739227053; x=1739831853; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+BdRdts91zZ1lBz7cZl7Oig3MKNc6jPxib3EI6sYvCw=; b=Jvqzl+Ir62BQcgfEDbP/n09L008GPiJSQypf4bqxe+ly4eYfZEvM82HPUMRzsF+uXr PJMoK012LMEOz3bpME5RpED9LsQfLrW1GpU3r40J1TeIoaX1LRgQPBz9kjMTpnzj07st e0Z2BQACuTA4zLROo8hMkRx6C7gqNNWyK5mkQ2hJGYGn0okGO8rA4Ib0+8DZXEf7Y8R6 /UE5asYPlCtFO7FqoFF/4eFxPAvt0XJNSV80QWXBtOODUNm0Y7uLuBFiEJ7iIGaeXhD4 9QeqwWvl//LwEWdhh3aEC+Hl0J8/qCxIZ8h4kUr1CissawII14NSCaV0qg+P3V3qzfIO 0NPw== X-Forwarded-Encrypted: i=1; AJvYcCWsSsK5rth9bH40J2UlfpbKBL5nc394Aw3xO/Y3Ns2PLESsOhcGgz2DHuHOcX8qw3YWNiK9B9Y=@vger.kernel.org X-Gm-Message-State: AOJu0YzyH+S2ZyGg30txhlwhWGEQbNMwCdI1jYYv5+P8667+Nzb/bzqb tJrfKkVXOOf/G0u/Z2A3nLi4STf2PdttiMVHjDkFbUn1YK/z8mYcjPy84qcFd4Y= X-Gm-Gg: ASbGnctLIdoVsSEFlCLJKUX5CiWe3I3FdZH5+sCWcc7Q5U4HcTrRvX8ZRy1AOPsKm9O r+MUfgj7HkSj6Dgi+fJw7JVDtL18uRc/RP7vbzzq/FAIOjtVDtiFRMnwd6zWZ8ybHhSRAw3wX/m mPXxzvG0dFF/RR5F60bzx61ZCLprSUT/yjV9GSjt1O66oJnzburOVY3dmvXhJEyMRuZ5KVrSCVx jrqr7DY5KpHW0nlCj7WbRZxPupMZJnE3C+G4X4kkowW/hSrS+j9v2kkt9SBk2nhf36/tzAqduKb U+mpegAwnsOA8YIhJe5P1gM7icfZRpMHUAgrHFdgh3hbCjg= X-Google-Smtp-Source: AGHT+IHsM3QlE/6UGVvIOu1IlhPnETs+gBtT/fIeOJD2BqtDOh052hlxzN8ugWj1HusAxyIKgoI2uA== X-Received: by 2002:a05:6808:1590:b0:3f3:b8c5:4ff9 with SMTP id 5614622812f47-3f3b8c55799mr3309849b6e.28.1739227052973; Mon, 10 Feb 2025 14:37:32 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f389ed1ca2sm2521820b6e.11.2025.02.10.14.37.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 14:37:31 -0800 (PST) From: David Lechner Date: Mon, 10 Feb 2025 16:33:27 -0600 Subject: [PATCH v3 01/15] gpiolib: add gpiod_multi_set_value_cansleep() Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250210-gpio-set-array-helper-v3-1-d6a673674da8@baylibre.com> References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> In-Reply-To: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Add a new gpiod_multi_set_value_cansleep() helper function with fewer parameters than gpiod_set_array_value_cansleep(). Calling gpiod_set_array_value_cansleep() can get quite verbose. In many cases, the first arguments all come from the same struct gpio_descs, so having a separate function where we can just pass that cuts down on the boilerplate. Signed-off-by: David Lechner Reviewed-by: Geert Uytterhoeven Reviewed-by: Andy Shevchenko Reviewed-by: Linus Walleij --- FYI, I dropped Linus' Reviewed-by: tag since adding the IS_ERR_OR_NULL() check isn't exactly trivial. --- include/linux/gpio/consumer.h | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/include/linux/gpio/consumer.h b/include/linux/gpio/consumer.h index db2dfbae8edbd12059826183b1c0f73c7a58ff40..5cbd4afd78625367a761e224acc3f7336d310dd0 100644 --- a/include/linux/gpio/consumer.h +++ b/include/linux/gpio/consumer.h @@ -3,6 +3,7 @@ #define __LINUX_GPIO_CONSUMER_H #include +#include #include struct acpi_device; @@ -655,4 +656,14 @@ static inline void gpiod_unexport(struct gpio_desc *desc) #endif /* CONFIG_GPIOLIB && CONFIG_GPIO_SYSFS */ +static inline int gpiod_multi_set_value_cansleep(struct gpio_descs *descs, + unsigned long *value_bitmap) +{ + if (IS_ERR_OR_NULL(descs)) + return PTR_ERR_OR_ZERO(descs); + + return gpiod_set_array_value_cansleep(descs->ndescs, descs->desc, + descs->info, value_bitmap); +} + #endif From patchwork Mon Feb 10 22:33:28 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13968831 Received: from mail-oi1-f181.google.com (mail-oi1-f181.google.com [209.85.167.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EB7C254AFE for ; Mon, 10 Feb 2025 22:37:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227058; cv=none; b=Ch6HI/zF8OlJG90J/FL1so3j5t9CEbQbaSmmqp3m7d2zuYzNb7wFfEPHkOjp8KHKJqxcMUiwH+79mtYNOmju/j+yn+y7RSOBSURq1hoq1GSzUQHGlVNWEMbemILz4Vqa7q+dEH3bszovbUmg+JYCSvjmB0MINLrJfff9zlLWQss= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227058; c=relaxed/simple; bh=niyVa96MKYbn0/yX32i9Lb8f6xkttYKqAUie+rLFIpw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uxAYsb9aQPHlxENrXjfUi61pnuDFg7qweE6LakT12ttOVDR53nhJlSSQ2Dvx/He9yfAElOVIx1szvlRNTEMHM3vi2PpaMZiHc4bsCgaqN6fg4FbMNb/1bjeCI6NnhRWE8leHhc0Gdl4bjZWapJkLIGiHM3GRhDovcIa7hrrpz9k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=NiddYB0j; arc=none smtp.client-ip=209.85.167.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="NiddYB0j" Received: by mail-oi1-f181.google.com with SMTP id 5614622812f47-3f3b83185d6so600994b6e.1 for ; Mon, 10 Feb 2025 14:37:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739227056; x=1739831856; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=YJrdF9PqOCsaQVoyXe6fXVbwa2pQeAvJKGzGuCxpxAQ=; b=NiddYB0jNhn//VaVWUzcWNGKWIeEyKfcIB2RGxGapk2Rsw7QuhJTHCJ4XwS/Nmfi0m wv4f2mthWm/UF4OJUKuECfl4tuSEVDfnuWTQkQpAWIZUaZxu8DMh3ph3evLpfuEw6IEK MoW9iB84yzBIHcsc2B7d9OBfcqiMCmZntNlfXoWvLZr9088w6ZY0uHXFK2r4TbQkUsq7 PmnmEn0pl488AdriFRaZasKhpgeY0kWGFDrR/+guatUWgoUhgFzt4Tjg4u3vnJXp99Ce JkzEaOo5JuUjNYlQmHr+6wYvDKwooRd/S0wbt7IVT6hFs7Fv49vWVBAb+RTYfcws6sHi o4pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739227056; x=1739831856; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YJrdF9PqOCsaQVoyXe6fXVbwa2pQeAvJKGzGuCxpxAQ=; b=Dq/Yo5y5au0OfbXU8QQss3gbfbWIoyx92VVVbC2iM2jKwZMN50+PfBMPELv7VBzJuV UBaZJD3F8v0uha1VScCBsXRjAw0SUTdNFE/TwNP5hXacK+PnTMmZwv/TkF8tqiGP497b acd7Kn3cOrGq8lEnIj6dZqJPzOik1VcxuDmK7ynj12iOKPVpJpbrIsk5gd1r53yEP1+h 96ja4tOcZEdIHLFpUUs7INumlxDfRSlNkEu8HFWm5MIsjnc7a8+WA2cbSamlSVDuAlml Qpue2s+k/LuZO9vkj4Z1B0mSCZ8JYG56yjvHpyR9a4eG4/VpY3nO36IS1uG+YqAFIgJu sV0w== X-Forwarded-Encrypted: i=1; AJvYcCUMaXTKT1WUgIPkt5/MnBMpU5ZDEtAUzrp6hDK3bEjnWeFzjUS1diFCANZIS00WoqSxSoUM77k=@vger.kernel.org X-Gm-Message-State: AOJu0YxF55SOSR6Y16JOBdfG5GDNKIRVC4ZXWi4Up33+Gv4egPMo8ORs XyoSRmLypIH0j3p/Tk3wL3gWbyX2oQzD3yMxrP9xgRQ+7osUlQqydM43KLpZ40k= X-Gm-Gg: ASbGncssCSoGO+oeWUFqp2Ry4newQU/TgcQix0OBsIrrdaG0Jc4J0ORv8hQfRFR3MF9 l8wAQgzoosp75IH4//sf7Qc8GKWuM6nhS4S0/rN6EgrS9VUtRYFMAsSGaVy42S4BdtF/PFzVXDz FdCdVJWpsk56pwTcbsGq4qbf2RgaVsH+zvlbqRRJ2Sj1y/pPUw0BLIW5R24N948z3rncovmwD6q XjwFoQAmrHqUKJMH0UWX13OSkzAIK4yn4EqOVsqZ1sC8Mu0bB29iP//5othLlvmgHgr+qgpN25S knJ2QYHdetRTpL8NWk9byufKw/2p+1mu9lHR+SUuW00hQpw= X-Google-Smtp-Source: AGHT+IEaS15Bntym3mAt6zrku3a2Uko68yjmwMRgXiq6dPbA7MZZB8Aa64yOncDet1fFdEO8/9GX1g== X-Received: by 2002:a05:6808:198f:b0:3f3:b6c2:a29 with SMTP id 5614622812f47-3f3b6c2115dmr3804142b6e.7.1739227056176; Mon, 10 Feb 2025 14:37:36 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f389ed1ca2sm2521820b6e.11.2025.02.10.14.37.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 14:37:34 -0800 (PST) From: David Lechner Date: Mon, 10 Feb 2025 16:33:28 -0600 Subject: [PATCH v3 02/15] auxdisplay: seg-led-gpio: use gpiod_multi_set_value_cansleep Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250210-gpio-set-array-helper-v3-2-d6a673674da8@baylibre.com> References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> In-Reply-To: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value_cansleep(). Acked-by: Andy Shevchenko Reviewed-by: Linus Walleij Reviewed-by: Geert Uytterhoeven Signed-off-by: David Lechner --- drivers/auxdisplay/seg-led-gpio.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/auxdisplay/seg-led-gpio.c b/drivers/auxdisplay/seg-led-gpio.c index f10c25e6bf126cfaac3e4c353f8bfc6639d94a60..dfb62e9ce9b407fe356c3a7d2d25319b91a11a75 100644 --- a/drivers/auxdisplay/seg-led-gpio.c +++ b/drivers/auxdisplay/seg-led-gpio.c @@ -36,8 +36,7 @@ static void seg_led_update(struct work_struct *work) bitmap_set_value8(values, map_to_seg7(&map->map.seg7, linedisp->buf[0]), 0); - gpiod_set_array_value_cansleep(priv->segment_gpios->ndescs, priv->segment_gpios->desc, - priv->segment_gpios->info, values); + gpiod_multi_set_value_cansleep(priv->segment_gpios, values); } static int seg_led_linedisp_get_map_type(struct linedisp *linedisp) From patchwork Mon Feb 10 22:33:29 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13968832 Received: from mail-oi1-f170.google.com (mail-oi1-f170.google.com [209.85.167.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C43F2512ED for ; Mon, 10 Feb 2025 22:37:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227062; cv=none; b=cyKP+DnGS0+FVhy0aV8XRPV3v92QibkkKcmZDr0viGYB7ANE+qwmTvk/V85W3H1qRqDOuyo6AHidIZ39Yg1pWTnqtJKxS9NBpEmc6Mtdt4VlWYVI6Sca/eNYG3FIerQRTkcxAKgf7tgp0eZVigrBue4+D2NvyCZiz6lPbYmgUeU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227062; c=relaxed/simple; bh=SFpLyUrSkeov8lTDekLTl8UML1Z5oaveGJ3pRpViCz0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=LWkXVN8jXA5OTmQNWwKqzXs+OlkDlAAa/nCMgZmf8yqPtGMWOsmmpLofUzLffGFUBaNDs4SL8SShDIIzgw0GhBzRpTdBOj2AaKeDGL6DBcg6JzXAbTwDHMHPbyytOwHN0cRNOzJAZMk5Oc/8Q0pE68HzwC80Kl0JjR/I3ddNx0g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=DLi0qjsC; arc=none smtp.client-ip=209.85.167.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="DLi0qjsC" Received: by mail-oi1-f170.google.com with SMTP id 5614622812f47-3f3c0abde9eso222234b6e.1 for ; Mon, 10 Feb 2025 14:37:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739227059; x=1739831859; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=dI+YClki4Q+OM8j5JXLpkAENpDyF7Cb60VCru1h+I9Y=; b=DLi0qjsCM9M4kRFPV0vlUdPq+P6jLzFdtm9bQWFR9JOodzbMazE/Al5tiMqScDd179 pvG21zG8gsruYL+RhrsqoWBz2CLpUZri9iLyCTr7EfFSboiHU5ObQHmjPiv94bzGs53E nt1g1NTy78XMuXkKBbOf0kPO6fFpjjMdwAZ7VMQ3F7ugQGcgLb8RmgfYlP8lmvPZwaQk zw0ooUfpLst7YQwUGpU+N6/O9XahJdKy++vUMqsQD6CXFZq+HM9RC+6LGqNFjkH2gYTI ze3Re6J/b8pCBOJhbniQUGBkF0OSBApxd08j/OUhCH0VnLe0eDNsXPNekRiOmn9KWXTc zhVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739227059; x=1739831859; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dI+YClki4Q+OM8j5JXLpkAENpDyF7Cb60VCru1h+I9Y=; b=PMbt/yS3WEm61eu+GON8ZsAh6Qe2liJzAIuLivOW8YOQ3O3ezrWlFCjRndWpewZ9/U 2Aq4d1alwpzRYjL/wAUFkptQfpGkBREVrAtZDYM4yMJTM+vZZew7cxS0vF2IyYZ2lQqw 2UY3IkBtQV78P3yQ0n4PITgGheEK1JtzVmXXdk3XlQYpmnG5oRLpJMF3FU721KCFkjiQ vMRlzDdJUi7UwZ20kEJSQVibBLBKwqX4X8s5eFBPTQcaA9I5Kl+d1zImvuMwBGA6pV8K 4J72QyggeFvJZCZbEyVLuwCVNCWzW3MgK1TY+Je1/r+RIlrq2HnNQAbdIEIHlKoymQee /DlQ== X-Forwarded-Encrypted: i=1; AJvYcCUZKuVUVlL5jQ3/pD47N8PL3lF/d/mSI7VZhYu9PXwDiCP+W0Z3KmLh82yZyDcP3uorNCQoV2w=@vger.kernel.org X-Gm-Message-State: AOJu0YzPj+n2JEq+CBfciPY8nnxo0YFVfRc3Q77ZNaIpiHkhrln7sPeL oIj+/cjiHmGvDOmF4NktXALSYoQ8Aya+W8DVnxqu/5sASg2Bcfc05Pn57GDLdBY= X-Gm-Gg: ASbGncsu2eo4UGlytAcW0uoZSD3cc0ZRaHpsmD0NAvXLbwzTNQud83Ylgn/yT/F78ah K5KZj/nTRdg/NZvSWp3ecnpnIBrEQxgYYglUhKRRO9bcZMruwPiy9El5xiU+jjSVjFQAsxav9NT HFx/91YYoaWtZhJNm8Fa2fnM+cYoZ/8GYg12dkw0pddLghCewgvyU6+gUqEIcAJaRM7Z3TNu9cn Nrh/BrOq8RUkMri3zUGEWJhNkkwbNLBVI+vta81ZLcYG7vXUxewxTy4VgTGq9WzdLUm8BE8vxV0 VBqYdNobGDI0DxhlCM0xiN2N+pJZl+vKNobwe/ylDTWfXtc= X-Google-Smtp-Source: AGHT+IFW6c/bCwKZFJx1mUCSPW7GBmt4Y2h9+oGTyfDUlc4EaqeUGtPptBQHkkXiE7A01fG2q4Y7jw== X-Received: by 2002:a05:6808:3095:b0:3f3:c370:4d65 with SMTP id 5614622812f47-3f3c3704f3cmr548358b6e.20.1739227059360; Mon, 10 Feb 2025 14:37:39 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f389ed1ca2sm2521820b6e.11.2025.02.10.14.37.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 14:37:37 -0800 (PST) From: David Lechner Date: Mon, 10 Feb 2025 16:33:29 -0600 Subject: [PATCH v3 03/15] bus: ts-nbus: validate ts,data-gpios array size Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250210-gpio-set-array-helper-v3-3-d6a673674da8@baylibre.com> References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> In-Reply-To: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Add validation of ts,data-gpios array size during probe. The driver later hard-codes 8 as the size of the array when using it, so we should be validating that the array is actually that big to prevent possible out of bounds accesses. Reviewed-by: Linus Walleij Signed-off-by: David Lechner --- drivers/bus/ts-nbus.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/bus/ts-nbus.c b/drivers/bus/ts-nbus.c index 2328c48b9b1260e805c631f2aa7379d620084537..d3ee102a13893c83c50e41f7298821f4d7ae3487 100644 --- a/drivers/bus/ts-nbus.c +++ b/drivers/bus/ts-nbus.c @@ -48,6 +48,10 @@ static int ts_nbus_init_pdata(struct platform_device *pdev, return dev_err_probe(&pdev->dev, PTR_ERR(ts_nbus->data), "failed to retrieve ts,data-gpio from dts\n"); + if (ts_nbus->data->ndescs != 8) + return dev_err_probe(&pdev->dev, -EINVAL, + "invalid number of ts,data-gpios\n"); + ts_nbus->csn = devm_gpiod_get(&pdev->dev, "ts,csn", GPIOD_OUT_HIGH); if (IS_ERR(ts_nbus->csn)) return dev_err_probe(&pdev->dev, PTR_ERR(ts_nbus->csn), From patchwork Mon Feb 10 22:33:30 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13968833 Received: from mail-oi1-f175.google.com (mail-oi1-f175.google.com [209.85.167.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D3F72512ED for ; Mon, 10 Feb 2025 22:37:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227065; cv=none; b=a7bnwsw9Pn+fkJ7thehmAZygim+xTCorKkqP30bjAGuWV5lrOxDh1ZYzYWQuSct8KUNoPWkVIoVp419txamkqe3p60ofkD7C7Xk667Lu1Xf+AdPwFD+Qpt37i5SkqREId/MVJbfs/JnmcnHrMUsy2WFbHlD//G9KVtLzNj3UbnY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227065; c=relaxed/simple; bh=K5V5TnWu+110nnHuULWw1Pwd0QiBFgzUapmy9BeC2p8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=R4IAevGLES+AIBZIC4NB7vy4rnZTAS1fkpGVxbmzo4S2piEHJKw2nC0yFBgzRfUvDtDPVV0Gl4y70Tw/KmDTW4wCuoQo+TFB/NgektB/h7SpuxBmuzJuWED1bk+IDvWeX1mo7+6gd2mReCHnIKPHh9MT7gMZ7O/5xX5FcMUiUAY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=z4odNCuW; arc=none smtp.client-ip=209.85.167.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="z4odNCuW" Received: by mail-oi1-f175.google.com with SMTP id 5614622812f47-3f3ba3d0433so594181b6e.2 for ; Mon, 10 Feb 2025 14:37:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739227062; x=1739831862; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=oAgdP5/7nbSCpei3bdgHz+Kvp3J/VbeQ+Dc9cWuRxQY=; b=z4odNCuWEIdXw6egWdAWzvkDfUm2yp9LCjnZQvBCOP3qcsaxfCXnX9ztT4tAzJgMaI oDzp3usrGdpGtWbm0FqUkKrpmWAEIq0wPRJUUbuLHncebfsQtZRIdXurTcE0coBezaot JCqwfqdc21V6HhF23eOTpr1Hv00Dk390SFpGVTMpKQAG5hTBVYYJCwcIsgcO9kiueCqz pcz1nbGaOl3KNFWRBj/DCKZxfPkD/u9KWoJF+RASmhfD3E5roTW7Q9RZbtvCdUfMt4C1 4t7qWk6gsXi17m+oWug7qVV/Df5lYt5w/9r/5UtGtJtXuARRfAjocCTg95E9CRvg5S42 AFPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739227062; x=1739831862; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oAgdP5/7nbSCpei3bdgHz+Kvp3J/VbeQ+Dc9cWuRxQY=; b=TQ0sq1aqoHPLhxMuby0HzFp64IUlAugLHbTaK153Fq5Gm0cCAb5eZNjY7z02PYHUor dA9qjtf470fyQTxQbvRCXof5n7fAj4UWfx6cdUMk4VF0CnRm5ZAXw1NDw1Cp6KHhN8ET QUBkVReKiLwLiOSQ75xw+AEvxsfyPqEbLBFqEkW8LzSPlLKCOldWp5rGTI8jOd/Dwcc3 7tpMwV2YQ7uIKU1giNxVV2mXH1UkxtMfn8OxfDzMk3v9OcGp+VWWwZ6mv6GnxYKi2O7e 8i+UeTbOWJqaQxHa1oEF1kNMF1/rRtTNdM2X3J5yfWBMoQIrhMnSAZ3MzYUwpubfEOm+ TFVw== X-Forwarded-Encrypted: i=1; AJvYcCXktUA015KhtIOzYIGTRCGbeb+W/cnYv0pKRuqqInrOnUfaBrXfjeQZg3i+hvgxp8d/vA6pCkg=@vger.kernel.org X-Gm-Message-State: AOJu0Yz8VyBVcqzmfUlmcYg52zP4zqBrE0Aun0MFfw8ck0eftOQa5rxB BmBthlmMfI2nGc8+Ufk6mxFMlhvMkqJLN8BUSinzdxM8bYfCnJKgK5QTwvyRG3g= X-Gm-Gg: ASbGncsU12S6pv8eHNWW1V8nCJXlYS3j/HQ8npGZw+QaKxBK+JeLfWyI9znvmG7WO3p 2OaRLzPTFjS4qI3LhXAYQqyyJCltsJl5j+qrfm3uyU0Av+5D+uWWn96MSncA4J/novjGWdkMNst 05Qr9yYSPdTsglbh+GoiIuZ9KOuQlmGX1rpdEO91uEQWhmaaNqNey8HCHLD7R00RmL38Szzw9QD cjXEn3ak196pmmXpaHw8D2MDyhmz78F3gwbBPvLjuoRlxQJ3F/3PLLxBqjIjmtG+gSpQilJclyf u4nKpBRe3NSaNjaVrrQxJ9dN93ZBCCijdwqLTSmf8m2o4Wo= X-Google-Smtp-Source: AGHT+IGCum5h1AQwvUJNh3Kk51lVy6xq7QJ+B7z8EkY33CFant2nucCBaXwDqcXBpkDagMClSCsXTA== X-Received: by 2002:a05:6808:4099:b0:3f3:b0ae:7998 with SMTP id 5614622812f47-3f3b0ae7b3fmr3901508b6e.17.1739227062548; Mon, 10 Feb 2025 14:37:42 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f389ed1ca2sm2521820b6e.11.2025.02.10.14.37.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 14:37:41 -0800 (PST) From: David Lechner Date: Mon, 10 Feb 2025 16:33:30 -0600 Subject: [PATCH v3 04/15] bus: ts-nbus: use gpiod_multi_set_value_cansleep Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250210-gpio-set-array-helper-v3-4-d6a673674da8@baylibre.com> References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> In-Reply-To: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value_cansleep(). ts_nbus->data->ndescs is validated to be 8 during probe, so will have the same value as the hard-coded 8 that is removed by this change. Reviewed-by: Linus Walleij Signed-off-by: David Lechner --- drivers/bus/ts-nbus.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/bus/ts-nbus.c b/drivers/bus/ts-nbus.c index d3ee102a13893c83c50e41f7298821f4d7ae3487..b4c9308caf0647a3261071d9527fffce77784af2 100644 --- a/drivers/bus/ts-nbus.c +++ b/drivers/bus/ts-nbus.c @@ -109,8 +109,7 @@ static void ts_nbus_reset_bus(struct ts_nbus *ts_nbus) values[0] = 0; - gpiod_set_array_value_cansleep(8, ts_nbus->data->desc, - ts_nbus->data->info, values); + gpiod_multi_set_value_cansleep(ts_nbus->data, values); gpiod_set_value_cansleep(ts_nbus->csn, 0); gpiod_set_value_cansleep(ts_nbus->strobe, 0); gpiod_set_value_cansleep(ts_nbus->ale, 0); @@ -150,12 +149,11 @@ static int ts_nbus_read_byte(struct ts_nbus *ts_nbus, u8 *val) */ static void ts_nbus_write_byte(struct ts_nbus *ts_nbus, u8 byte) { - struct gpio_descs *gpios = ts_nbus->data; DECLARE_BITMAP(values, 8); values[0] = byte; - gpiod_set_array_value_cansleep(8, gpios->desc, gpios->info, values); + gpiod_multi_set_value_cansleep(ts_nbus->data, values); } /* From patchwork Mon Feb 10 22:33:31 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13968834 Received: from mail-oi1-f175.google.com (mail-oi1-f175.google.com [209.85.167.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6EE325335E for ; Mon, 10 Feb 2025 22:37:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227067; cv=none; b=QeTgf5QXVuNa3q0l7S55SgQ/wN9qsHawOMj8RlC3tD8ruP//jft9eNWf8vKgKoBc5Kvwgapu5nmrHY9QBimfT4B3KrcvelCNeBLYYcCi445nYsCbL7+erX6qOLVJsyze1QgH25sfuV7BrDRNh0PwMy98Dj/OotUwjNhyc94EkcQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227067; c=relaxed/simple; bh=h4/JkT/aieYSqhfnM9UnuUTJJW8FA5AwmbHA2f2Z3qI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lJgUWiDmvpkA7LG0P2gz5kTHIo1ORnFFlzo5nw9uL7zeTJ1Q7EL5ndgv7iY0tjOI/MeEhpoXAcmN6q7W1nUPGMerNx2LbGp2zLl/Y1d+3V7Zs3Av5a9M89fxGYKw+E2WtYxBFtIf1sD43WHyvzddTi8hIK7srCn6Qp7JfMheVa8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=TLOvJjDN; arc=none smtp.client-ip=209.85.167.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="TLOvJjDN" Received: by mail-oi1-f175.google.com with SMTP id 5614622812f47-3f314ff6ffdso2853703b6e.0 for ; Mon, 10 Feb 2025 14:37:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739227065; x=1739831865; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=aXB+byZeKAp4YicbFdNdAOrg4x68Xt2NQ79nnhRrJVU=; b=TLOvJjDNBxarUBELg7go/ZxX0zU+xs39riDy84aC4j2XbIyhm1pT74p/AGm39IqyRZ bknIVVrQU2LwEzznw9FCg4/I6+7S/onqBEXzcpR65VT172DkSyNa4b6zuoHcZwRcLORR yooOMj/CxF7agVXCqEErNuJBbNcNcreGO1y0qaCMTXz0qQzT3w7uMQD+kc2Q5ty9Dzm/ 3zF3qLHrKWV/Srh+kAZopRBiRZo7Nk9kUIIJ8dS4T6VUnaNj25a1ZNm3dcZ2WGQw+O5a qAtRg4iru5kNYEqyRzgAT3OoX/SGWZ5VwNlTo6iGuKGRzWMV5R4ptInabd4QfOB9yJqD zbng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739227065; x=1739831865; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aXB+byZeKAp4YicbFdNdAOrg4x68Xt2NQ79nnhRrJVU=; b=OKPiLa0eDVBdRDHwOMDBBVC90DBGsvziGHoopWDa4TjcR083ttAZQs5pUqeiSvsmxr gojChHhAOuftMaOdlpA+q0vV0XTUt/tciYkttwj+SDvqgPpDroQk/9Sgu+t/yDTPkn9P L1euUB3OZ3L7GTvyBVGb0myX/ROynXYR8t+lY0zCT9kRatyxokhjXT5c6etQSRhKQZc/ +RW5CiGdXkXkASfCsU557Xj17uzGG651PXqhqJrFAfi+nYZnelhirbfJ2mja8toRxnBG Gynb+UUIlfCniB9ICyean7oGtfmmCl62LEwttY4/KJzdd7aS6q36fLMJ9730BpffD7wo A7nQ== X-Forwarded-Encrypted: i=1; AJvYcCV++gEvs0U/Efh/mi66iOQ3xpL9+nHFK/iEslWTl5QS+j6QBC9W74mugi3M6tHyp/+22FlXQoQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yw2uDtsZ9nfOsfqVFz1JxuO4XWyRfddrDV/p9xc/kODY1y+JrOL KHH9QnuYhYa+YBPZTI6jv9tS7F+y6AG0n7BNhiJT0zrc4VQw4+rFCgqNOd0FQbI= X-Gm-Gg: ASbGnctsbfemCPT+JS0rygw0E7TZtT/lclX7VcnS7Guwihx7y4Gb4ETaUDF8oDxDfOL qwJeM5hGdHp+XcmiZnUI2Of7a6aIlNFYUSZ1lBDFhR6e+1057rbHb91Zk+JXyJge/Vi2dsV/VQN 1mY9dyESY9PWkfPe2bHsI/iKU6iSjZ02G96HaWyt7rqsAXvRl/YOmZLBI3GWl7N8fKh2hV7Ah0n Wtz/Sb0sfF4Jv+FVuFMn11ObtlEHfmM5aaXJwNXWtqXw9cyxBCH1sgY3lkyXpro7za/5WnI99K8 IYtbFf0yrVbSU+Oq2KBneEpasgFMwlPhth9+S9UC3GuRLXk= X-Google-Smtp-Source: AGHT+IHioMIxu9VGnzXizdV46F3qMiFjs48WUo2oHZz5JGkXBH5C7gXq210bMR9McIstDGpa5KGthg== X-Received: by 2002:a05:6808:319a:b0:3f3:c1e0:c466 with SMTP id 5614622812f47-3f3c1e0c4edmr1094523b6e.5.1739227064928; Mon, 10 Feb 2025 14:37:44 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f389ed1ca2sm2521820b6e.11.2025.02.10.14.37.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 14:37:43 -0800 (PST) From: David Lechner Date: Mon, 10 Feb 2025 16:33:31 -0600 Subject: [PATCH v3 05/15] bus: ts-nbus: use bitmap_get_value8() Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250210-gpio-set-array-helper-v3-5-d6a673674da8@baylibre.com> References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> In-Reply-To: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, Andy Shevchenko , David Lechner X-Mailer: b4 0.14.2 Use bitmap_get_value8() instead of accessing the bitmap directly. Accessing the bitmap directly is not considered good practice. We now have a helper function that can be used instead, so let's use it. Suggested-by: Andy Shevchenko Signed-off-by: David Lechner Reviewed-by: Andy Shevchenko --- drivers/bus/ts-nbus.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/bus/ts-nbus.c b/drivers/bus/ts-nbus.c index b4c9308caf0647a3261071d9527fffce77784af2..beac67f3b820377f8bb1fc4f4ee77e15ee240834 100644 --- a/drivers/bus/ts-nbus.c +++ b/drivers/bus/ts-nbus.c @@ -10,6 +10,7 @@ * TS-4600 SoM. */ +#include #include #include #include @@ -107,7 +108,7 @@ static void ts_nbus_reset_bus(struct ts_nbus *ts_nbus) { DECLARE_BITMAP(values, 8); - values[0] = 0; + bitmap_set_value8(values, byte, 0); gpiod_multi_set_value_cansleep(ts_nbus->data, values); gpiod_set_value_cansleep(ts_nbus->csn, 0); @@ -151,7 +152,7 @@ static void ts_nbus_write_byte(struct ts_nbus *ts_nbus, u8 byte) { DECLARE_BITMAP(values, 8); - values[0] = byte; + bitmap_set_value8(values, byte, 8); gpiod_multi_set_value_cansleep(ts_nbus->data, values); } From patchwork Mon Feb 10 22:33:32 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13968835 Received: from mail-oi1-f177.google.com (mail-oi1-f177.google.com [209.85.167.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E445A25B697 for ; Mon, 10 Feb 2025 22:37:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227070; cv=none; b=nOSwhdTicT8+9y+eWVWq1sasnDA4iiN5eb1c0/g0lR33FgPltHTLMF+7w4E1zOPlIWKmGqk1pBU3TFtveRfGqkWkSKIdDwewXW2iNIsqvoMgFjKWGhWJs3NP6yERemkpfT7u8wwmia2YdOl1mYv17YWYOsDiMz8S6eIo53Cz/Gk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227070; c=relaxed/simple; bh=LctkGb8pv2p2rQX9wrZO/xPsAUNTTxqNczAZXgDu87c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NtbNDvrD6oPTn8Rqvm97AfMc+9baqkLK0GRk3Cb9OKMuIiGxLtCovUG7bwdo3MpYyuFX8sSzdyU3n0GVQUd2TUccMI6BvitID7zTevOrg+ZClT0l13Lsh6IJEhP0w5WTKNdifuaWxV3EcOkOgsQ9AVtCIbN1qVlddnO+0HbxkFs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=JSuLsJIu; arc=none smtp.client-ip=209.85.167.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="JSuLsJIu" Received: by mail-oi1-f177.google.com with SMTP id 5614622812f47-3f3b83185d6so601075b6e.1 for ; Mon, 10 Feb 2025 14:37:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739227068; x=1739831868; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=bXHiG48V9LuVOCVuPYOg0jYRbGMvcGRS76/y0RlN0SA=; b=JSuLsJIubHBSOQF3wLWj+iCM6/U9leKY2xdJrIXTYB/Ln+EEvCyBucdC3O7xK7+yjg +UXX9Xh8D+egCKgFE/HB4zzq14uH5zJKE8hzBMMEYKM8JPwsCk9NxqKuuAr2Bm7Ac25H zW9HtmlIp1YhAudqNG6vA2twyN7AwrZi7V4fW/s03pOnm5cQsfR8ETYqbh0u6mzK2V5h Ac7+R55B2wD/ne9vPaSiOU0sWD50XAUm6WcKFqmOCDglpSluMpvXz2+Mc7mCCbowvRP7 +FqWlSj8UETjcdjwyhYHUxb6orF7xrrDPf837dnQ0MsPCvwhDzBldHlffteYLRTmmIky bwaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739227068; x=1739831868; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bXHiG48V9LuVOCVuPYOg0jYRbGMvcGRS76/y0RlN0SA=; b=rsL/bKIXKpIvSZpQErXzNu2n+yP0c44BZbBGfxDOAQRO8ehD1C6Zeewr4DlZVkem2+ le+rQZws1GOA39bd0pus1SU+XMoQ2YQEIO22AJHFD8LdkVKj5yc7fM5AKCyok0kitCoj WsUl/l86aZduYVa5YKwuPeWRGUnbWeANb4COzTK82NDq3JI0G446YNhDAe//D3XuT78t QQTN7kPPG7ftMjtIySETFuQl/YxtjwgUQ9H0SzBVvfFo6rQimH7NRO7XJBsR8rO3HhSm z/KJnQjswhhE5I5XjBGgpuu7rpUlAtllPoI7+m0pL0YxcX2uMVAdsEE/1eK4Jseb4aBR qHsg== X-Forwarded-Encrypted: i=1; AJvYcCXQsEnnc1umKS8HvRjNSAZB+7ekMfhlrpCWKnMTz5QctivyYSuIn0hmXp5yAYusYOoYd2Mu4gk=@vger.kernel.org X-Gm-Message-State: AOJu0Yynniiu2Ues5bu9XC5djrZ0jY9SB3tEV0FHybIWBZunLbCKFUWI vsnnHdFyxLmEbO2w4jbCsnf8dujeYJv/lWLgwIFRfpaUps9tJSZQNH9tU4ca7oo= X-Gm-Gg: ASbGnct5kXYc6BblkRucioRYS12lBhnPacIHddfuxKIk5Exfbwb9c/JGZh2XR7SUFOi Y49QujnyXSYu64XwdO3nnIv/IXTfNq5k2V1Mvn84dnVfkLS2kpx1Atv4CjI6sVP3oh7BFiat9zn 1rQvTqbdDcVP3ah5YboMJ6vzdb20WJltMOba5stU6TAgLSLOytSCUTWL+in/r8kA59kK7i162xG X/I69+bwsKeiHKg4N8xMDyyeR7mjKstzFhR20Qw3SSSNfQOdyPoaFbXPZJZvIPdufQlF+CPFee2 4BDf6k6imJ0tT8ZEQXIFnd7zi+Cd119Ar/9DQ1KuCQx3iAI= X-Google-Smtp-Source: AGHT+IFehF7HNx0K+6D6lVInKbCaf1fMxaCHCpkyg1GkxvFsa7pSUfnDQ2Sc+6Hc2oSsp+PH8uo0Jg== X-Received: by 2002:a05:6808:2f13:b0:3eb:8d22:b6ef with SMTP id 5614622812f47-3f3923b0208mr10855482b6e.37.1739227068102; Mon, 10 Feb 2025 14:37:48 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f389ed1ca2sm2521820b6e.11.2025.02.10.14.37.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 14:37:46 -0800 (PST) From: David Lechner Date: Mon, 10 Feb 2025 16:33:32 -0600 Subject: [PATCH v3 06/15] gpio: max3191x: use gpiod_multi_set_value_cansleep Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250210-gpio-set-array-helper-v3-6-d6a673674da8@baylibre.com> References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> In-Reply-To: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value_cansleep(). Also add max3191x_ namespace prefix to the driver's helper function since we are changing the function signature anyway. Reviewed-by: Linus Walleij Signed-off-by: David Lechner Reviewed-by: Andy Shevchenko --- drivers/gpio/gpio-max3191x.c | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/drivers/gpio/gpio-max3191x.c b/drivers/gpio/gpio-max3191x.c index bbacc714632b70e672a3d8494636fbc40dfea8ec..fc0708ab5192bd518bb0e6362f737bacbd549d61 100644 --- a/drivers/gpio/gpio-max3191x.c +++ b/drivers/gpio/gpio-max3191x.c @@ -309,23 +309,21 @@ static int max3191x_set_config(struct gpio_chip *gpio, unsigned int offset, return 0; } -static void gpiod_set_array_single_value_cansleep(unsigned int ndescs, - struct gpio_desc **desc, - struct gpio_array *info, +static void max3191x_gpiod_multi_set_single_value(struct gpio_descs *descs, int value) { unsigned long *values; - values = bitmap_alloc(ndescs, GFP_KERNEL); + values = bitmap_alloc(descs->ndescs, GFP_KERNEL); if (!values) return; if (value) - bitmap_fill(values, ndescs); + bitmap_fill(values, descs->ndescs); else - bitmap_zero(values, ndescs); + bitmap_zero(values, descs->ndescs); - gpiod_set_array_value_cansleep(ndescs, desc, info, values); + gpiod_multi_set_value_cansleep(descs, values); bitmap_free(values); } @@ -396,10 +394,8 @@ static int max3191x_probe(struct spi_device *spi) max3191x->mode = device_property_read_bool(dev, "maxim,modesel-8bit") ? STATUS_BYTE_DISABLED : STATUS_BYTE_ENABLED; if (max3191x->modesel_pins) - gpiod_set_array_single_value_cansleep( - max3191x->modesel_pins->ndescs, - max3191x->modesel_pins->desc, - max3191x->modesel_pins->info, max3191x->mode); + max3191x_gpiod_multi_set_single_value(max3191x->modesel_pins, + max3191x->mode); max3191x->ignore_uv = device_property_read_bool(dev, "maxim,ignore-undervoltage"); From patchwork Mon Feb 10 22:33:33 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13968836 Received: from mail-oi1-f177.google.com (mail-oi1-f177.google.com [209.85.167.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F3DD25D533 for ; Mon, 10 Feb 2025 22:37:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227075; cv=none; b=pRX0pNWSxERsMl4xA9w/uOMTJ2M9PH/2Hrzb9PpAdfS0hE4oJF2U2NumNaybrghWPx/O2nitoGLyozblWkwEsyhcRjh5vwXfyRZ0C8HkCHKuHZMUEzWG+kL48Ud4lTKkKMsnodGi/eSpTjWAPzd58I3b7teCY4lfoQ4Do6htoaE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227075; c=relaxed/simple; bh=E+QxbL31Mk8vy8KiWcSsFLkHYNRVN/Q8L14IDdICZ60=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gNiOd5VJuN18FTjXbnDqzEUgKYRqkjUuQ+Pm4iYBjYCCDkD+iGOgh1uV8KgsQsnX3BmoUAArvIBZJqP3yE93dgOtkXdh5rProroaJQ4fcB3fAmxDDKX9rIwEotR2WOj0oft4Cd967SD5JJ7YsCHYuRNRT2PqeVIFEtJFcDKraSo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=IupX7MF5; arc=none smtp.client-ip=209.85.167.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="IupX7MF5" Received: by mail-oi1-f177.google.com with SMTP id 5614622812f47-3f3bc69c8c6so548313b6e.3 for ; Mon, 10 Feb 2025 14:37:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739227071; x=1739831871; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=9KFibiHSceSI9J0YTbtHgVyCC6KTbDSSVoM74byAuKE=; b=IupX7MF5SYuuAqOP2Tfu9nnVp7KL3B6z/1ukgLgzjaYemPo7bXexCIkRSyozbc00NR GdPkTPZeY9fZk8PJuaFoh4pCx91s3v+mpg5oB46IbKVas1ngrtCjW3sp7ozhLe4+gqxy Pzh3uO3ycj0HHNNP3EGFkJ2DH1Zi4NcptaWW6DNAKiAz9kd5mINv/UnHcZYktdnoP35B ZwX7bGV4f+cGbF4kO0LBiWvSQiCx6r6VmlHPsN5QC0uQweVrMaxGueO6jSf9K7QvabNu 5c6h+li92oA9DXqLPxzQI0D6+xQun/37mTsHMRYRMBRX8CR0f/oN1JH2aR34Uwesz9JX Gk6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739227071; x=1739831871; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9KFibiHSceSI9J0YTbtHgVyCC6KTbDSSVoM74byAuKE=; b=a2D0oTuhnkmyDuFwu55LmHo8Kjy2y2KhCkWB2dgGjkdBYIkbYPb965oMyyF4k7ypaf iOYwiR0C7YbjY7uAcLZnMzbtirexMVighO1g8VVuVYwR7jtIO/EE8FLE2F5No0mXkcKr an4Y4qkfjVfSMDXSg+HjrZPpbtf7BNSnQWLvHcR45j0ZMB5enkzJ/mvCyISYrgNLJ2qu INQ0F/ZhTjG7gq0cmiegJxCw1jH2LbIFlUWajbdnWyUZTrgH/CqZV2EbSpBlj28Wqry5 rbufMwGvgeyzudDGGRuJYfrKqlpbZVJqGjefMbRAcK+32rocHMDIjlNQfGQfxCoIOhqQ 9NCg== X-Forwarded-Encrypted: i=1; AJvYcCXd4nj/9gJP0z6gr+/x0d7YgD1oTAKLK7iM4IFBOAuBjIlzmfSCLpCWHp+BQkXQca2E7OYnh/o=@vger.kernel.org X-Gm-Message-State: AOJu0YzGlrokDL0RFjf4ll2a4YhIgjC1U/EjjR4mRyYVyDgx+lo2UQWH XRd/E46jkIHmtkXhRX4IqmOE5ftIgcMMSLHKAHsGTNZ/lpnHqdzUsVBq8IE/ml4= X-Gm-Gg: ASbGncutaO4yzTjLUPZTSnDipdX1Xz2LFWLT58taA3XrykXgVfGX20VXs9YswM/MUbv H9nIjScFauhvFjfpFhaX/mt34BDf1LplDZKfCu5vPPasdQ0Vf2Op4BdADslj8iURerBpQA2Nlt1 3cvADKom+76BMBYQwJKiH3Sm92mdG5X7qX1gCEspTzLg2WTC4ZymCTT9uAlI0AD4u6a8TM1zoai +K4PuWU0/o9Kxe8jan75zS9ok/jEiBTf6tv6KY4ZOeCDeD4duET5I5ODB9NbnOFLzHIoQB+NZ6p KszM7eghYWLEUAHG8CiklTsNutU//ZeH/RGYmREW1g2kkBs= X-Google-Smtp-Source: AGHT+IEqlKxdcHtWmpci4BLtxbDP+p3ZildeCHTAvguDG8QvB4Ez48M4koY5bUOldTogYj+eiwGfHw== X-Received: by 2002:a05:6808:250a:b0:3f3:ba60:f889 with SMTP id 5614622812f47-3f3c2696ddbmr691568b6e.28.1739227071302; Mon, 10 Feb 2025 14:37:51 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f389ed1ca2sm2521820b6e.11.2025.02.10.14.37.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 14:37:49 -0800 (PST) From: David Lechner Date: Mon, 10 Feb 2025 16:33:33 -0600 Subject: [PATCH v3 07/15] iio: adc: ad7606: use gpiod_multi_set_value_cansleep Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250210-gpio-set-array-helper-v3-7-d6a673674da8@baylibre.com> References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> In-Reply-To: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, Jonathan Cameron , David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value(). These are not called in an atomic context, so changing to the cansleep variant is fine. Also drop unnecessary braces while we are at it. Reviewed-by: Linus Walleij Acked-by: Jonathan Cameron Signed-off-by: David Lechner --- drivers/iio/adc/ad7606.c | 3 +-- drivers/iio/adc/ad7606_spi.c | 7 +++---- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/iio/adc/ad7606.c b/drivers/iio/adc/ad7606.c index d8e3c7a43678c57470a5118715637a68b39125c1..9a124139924e4a4fbbbd234a8514eb77024442b3 100644 --- a/drivers/iio/adc/ad7606.c +++ b/drivers/iio/adc/ad7606.c @@ -818,8 +818,7 @@ static int ad7606_write_os_hw(struct iio_dev *indio_dev, int val) values[0] = val & GENMASK(2, 0); - gpiod_set_array_value(st->gpio_os->ndescs, st->gpio_os->desc, - st->gpio_os->info, values); + gpiod_multi_set_value_cansleep(st->gpio_os, values); /* AD7616 requires a reset to update value */ if (st->chip_info->os_req_reset) diff --git a/drivers/iio/adc/ad7606_spi.c b/drivers/iio/adc/ad7606_spi.c index e2c1475257065c98bf8e2512bda921d6d88a3002..091f31edb6604da3a8ec4d2d5328ac6550faa22c 100644 --- a/drivers/iio/adc/ad7606_spi.c +++ b/drivers/iio/adc/ad7606_spi.c @@ -296,10 +296,9 @@ static int ad7606B_sw_mode_config(struct iio_dev *indio_dev) * in the device tree, then they need to be set to high, * otherwise, they must be hardwired to VDD */ - if (st->gpio_os) { - gpiod_set_array_value(st->gpio_os->ndescs, - st->gpio_os->desc, st->gpio_os->info, os); - } + if (st->gpio_os) + gpiod_multi_set_value_cansleep(st->gpio_os, os); + /* OS of 128 and 256 are available only in software mode */ st->oversampling_avail = ad7606B_oversampling_avail; st->num_os_ratios = ARRAY_SIZE(ad7606B_oversampling_avail); From patchwork Mon Feb 10 22:33:34 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13968837 Received: from mail-oi1-f180.google.com (mail-oi1-f180.google.com [209.85.167.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57717254AE3 for ; Mon, 10 Feb 2025 22:37:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227077; cv=none; b=jxSsqwt4ZfB3Rsd/64CbYJ7bfnaQQcG/FKFdPsCWb4VvgQELn4BNzbIx0Wr6/asbNbhM6tGvhAlzAZkoAtGOZ0aQQ5FPZXaVoiWgel1HwHgTpBgJDU76Qi03u9uZ/lc7t6tZYJv8IQh1vr+P2QQpirc9Kfh8dtHSB69TEDQbApY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227077; c=relaxed/simple; bh=DEtDLgJv5UYwZaak4CnPj1ALmi7rrV6hWuddp/nLJio=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=BXYU28OZa19UtOKS6povsYxFE1b/sECzArbWDO8CfddkYAPyB1AZdPxpDJNdkaOy9FQrRdENa5DytKLkp1ibz6FPK1xJx3PRowoIof8ha5KHmNgSiaNjla9zzsXS5eV51CHH32pjXOC5TQdngD9Eum694MwH1vOoLwbh78F4Ekc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=vujvn9q1; arc=none smtp.client-ip=209.85.167.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="vujvn9q1" Received: by mail-oi1-f180.google.com with SMTP id 5614622812f47-3f3ac204922so1247847b6e.3 for ; Mon, 10 Feb 2025 14:37:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739227074; x=1739831874; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=GMcrxDurUnSK2SHairVKflMalwdh2XVxdj0wjaWv8sM=; b=vujvn9q16sHkCxjODesonUK7YfToaWCovqp1meHYAiAMGuxuvuxvtjgT7kb4u9Rr6V swRcw0YIojKyBSboU0wstCJdaRggX8BRWH4M6uBpGT8p1fBitXYbaydpvLWzCEQjAgyH NK8GDJF94FCeuET5MshCx5YbGjJaWqAgw3WdWfpWFRjlu/QtI/QggzM5FO97TiYmaxBz PAABk2lpH9oFI0pUI/2JkcpFJHdPWUeviNglFTcXNGwMqsgsZIHJYDsnSsc9LP95ZXSs ERAcFCFmZaDh5TkuKpoMUw8CZYx5ReOtYpGtHricMbLSB2JZJizhsvkfgo09Zkf0S9Pe pc4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739227074; x=1739831874; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GMcrxDurUnSK2SHairVKflMalwdh2XVxdj0wjaWv8sM=; b=V/GdtWAjWyxoeBKmxZePhbX4gLY6sizfo6n1C9NKabCCUdzwycWNW4NkGsqve8DsIr KZ63DmJgHK8Ice4Bf0e1xrcC3heIITJRQ4AK9mgRWYwgQKd2jfGdlYWQSDQGem/PbDzW R3WAUkLO7VP37ikIg0g/PHDqzq21m1HDV8H7P5FGZIKX7KzsQs6m0MfKQoK2JZ/jhENG aaWMtDpkSx5yqdSiO5SDG1fVlnseT3mdnM4eOPjFiUrof3Y5Fg+58Yx9Hmk99KOUu30G hZCO/75yXHkXMyzdCebYQX9i+6mqaEjmAYw+4CeooQKhC9wESPJIatC17gEyQrxsvxN+ gIZw== X-Forwarded-Encrypted: i=1; AJvYcCUMl8JF0RpFpK+M6vljAMRDKX9xIJdOsNdDRoqJYWzHm5iZbLZwIo9z5Eu8surBxBpIrnY9Cy0=@vger.kernel.org X-Gm-Message-State: AOJu0Yz1Pfvrz0wp2aEdS4x1uxS3OEYfeGHuiH4bWVrqmFxp8Ygi1Ix7 2d9bT0WcfS4mjBb7o4v0kBVF2cECxmPYN+177I9sWYlkaza+TtPsKG2peZPEBKI= X-Gm-Gg: ASbGncu6eN9jIKkFcxYZ6Zl5uwk6r2MDnpMfCrm/9zMWHgVOub8R1TTOV6obiBKopb2 woU2NU6VZ9+IZcMajevXwrGASaYo4jO3xa9pv5HFGwAF14a9RkWNyBeIdOO+9TGGJJsuXoTCbxR Yj91tgNsfI9Lf6UCaLS1d9N11LpZoBSYksSkyXD8LcAyRQEj1swlR6VU6zdwPKVeQoKTA7gvojJ S8ws1hzW6m71ctdMUIcVsQkyK0Guc0yJHJVAj6fHSqGZH1aCWn5yGwttCJPp95tsL30eO5MkSo+ M4V5pfxJkQk5mYAjfDYUiBxM3kia2Nbx2NTT++YaWsewlfY= X-Google-Smtp-Source: AGHT+IHpQCMO/UtYCFM9csSv77tlAPoKshLmX0/bTL0+YDtp28Q6Z4e9EVZz3B9NbqVlL1P+vOnPrw== X-Received: by 2002:a05:6808:1a19:b0:3eb:39f5:de8b with SMTP id 5614622812f47-3f392362d24mr10975894b6e.32.1739227074492; Mon, 10 Feb 2025 14:37:54 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f389ed1ca2sm2521820b6e.11.2025.02.10.14.37.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 14:37:53 -0800 (PST) From: David Lechner Date: Mon, 10 Feb 2025 16:33:34 -0600 Subject: [PATCH v3 08/15] iio: amplifiers: hmc425a: use gpiod_multi_set_value_cansleep Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250210-gpio-set-array-helper-v3-8-d6a673674da8@baylibre.com> References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> In-Reply-To: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, Jonathan Cameron , David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value_cansleep(). Passing NULL as the 3rd argument to gpiod_set_array_value_cansleep() only needs to be done if the array was constructed manually, which is not the case here. This change effectively replaces that argument with st->gpios->array_info. The possible side effect of this change is that it could make setting the GPIOs more efficient. Reviewed-by: Linus Walleij Acked-by: Jonathan Cameron Signed-off-by: David Lechner --- drivers/iio/amplifiers/hmc425a.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/iio/amplifiers/hmc425a.c b/drivers/iio/amplifiers/hmc425a.c index 2ee4c0d70281e24c1c818249b86d89ebe06d4876..d9a359e1388a0f3eb5909bf668ff82102286542b 100644 --- a/drivers/iio/amplifiers/hmc425a.c +++ b/drivers/iio/amplifiers/hmc425a.c @@ -161,8 +161,7 @@ static int hmc425a_write(struct iio_dev *indio_dev, u32 value) values[0] = value; - gpiod_set_array_value_cansleep(st->gpios->ndescs, st->gpios->desc, - NULL, values); + gpiod_multi_set_value_cansleep(st->gpios, values); return 0; } From patchwork Mon Feb 10 22:33:35 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13968838 Received: from mail-oi1-f176.google.com (mail-oi1-f176.google.com [209.85.167.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A147D254AE3 for ; Mon, 10 Feb 2025 22:37:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227080; cv=none; b=A/pE/27gDVOksJgglUmUBdGpfgg8pfp5ej0oYdL00Ards+FxkfRno2SoK2W4F4wWRtGGXPFAGvrkVG/GiQRJk9QfRpYoINYAXuXo5gJvRtigu9iMo16FofdGKMMR95AwY1I57kqyXQmx+gn5hT6ZA4ZPyVnWM6V+fSdJW65uZ/g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227080; c=relaxed/simple; bh=w2oc7RoPm/sb7RYTc8soBDQAfVbctsAzru+e/xVugio=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=f1CbTX15fnmoUFrurSOQQQCeoS6SpcWdxnLATR74lb0B41j+vNWYdcDZM8HZ9aPPa7erFus3N+bPbUK8A54efLcDTuQKHe2ONHZMV68kcIDqd9do4Gaq/UR/RBc5DymLta4MTOqRk/ZrRTHzyz3xHb6yQXS56kIp2dmOKid5CXE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=EX6Geyr2; arc=none smtp.client-ip=209.85.167.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="EX6Geyr2" Received: by mail-oi1-f176.google.com with SMTP id 5614622812f47-3f3b8f6ff68so698437b6e.3 for ; Mon, 10 Feb 2025 14:37:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739227078; x=1739831878; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=teHDghklDJ1V7cAi8g37Bvg2ko8a0NpXKiatSq796/g=; b=EX6Geyr2f5PrlcFQSDLNi8nG/h2PCdswLOTbPl4cfWLsKNV2v0DyC90gNZ3HcnGcC7 WLFTD6vVne9vl9xZfLrI850yPkknlKXY+s9FoBjWe0o6kfDt05hvDX6Z4xPtx2twLoDu Gg5/75WgIukUpmgSmbfgiekGaK/Uz2lI3X3FXAvJDPj3bqjUqSCBLtBayYCCwiM+d6P7 8wFqrDDLd/EwGgjGGVqn1XWvp23Ng9elYqsFt7WQrjcFELX6uRC5J6xC+yKawGNvuLEN loDm8yXQayJvC4kj+QCMv0rbMw2wPJCXPEWGTqZgBHuVYhUPwJg1c1WoYlntxYKYpzUR 40sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739227078; x=1739831878; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=teHDghklDJ1V7cAi8g37Bvg2ko8a0NpXKiatSq796/g=; b=Fw0a1HiVJnQYntiOQ8Fi1gB1S95cwkQCw8oeaZy3yT6i2jr1uYBvcJ9OCXiJdb+eWy 0pDILnvVGuFuZKg8dhyh1B1HfEFujdVkVJpM6fNmmcguo/6O2sA7Y9UooqCXylSIZx3A btRy3wE3A5B+5BFPxo+sHH9Mno7Q8Kj14sxtxzjvalxVUJx1bJI3mHow7VngPG2dY6Zm xi+u1kgk6ctMwyDjuapd1qWBc+gNbXtY1voxThc86yLtDrP0RrQ1R1hLPMAJlPQxXKNQ DEaUFjjF8M5CdbhOj3f18Eda0udqiVtoyWrlIP28Mv6jbiWR8y6nreaREmQpW1Jb2uwU aOgA== X-Forwarded-Encrypted: i=1; AJvYcCW4DHZJxlKFfHcZ32aYn6M1pSeJgXSXhfeWX1mnm8XU+ZnHwK3UwhP7bGYSGQyZx5JrT6hJQ/U=@vger.kernel.org X-Gm-Message-State: AOJu0Yw70SAxbPV3oNejX96FfU93n5RTMbaZNmxJdmk+tbUmnU2CDGZC 3BSwHKo6WJNqMJHR4ecHU+2XagGX4lk9lZJ+g5NXw5gRaOJB2QKvDHJ1s04humU= X-Gm-Gg: ASbGncvidEMNfzD2OJT7dnyUvlriIZfEqLfiqdm0/IGVwAjqxmyu5WR21+o6sRzVbtK BDjG1fVE2AavfbHOdfJA8mvTwe5BgNVXm3dmZCOSpfRQQ3DsgfgfHSkQDi8f2wBTJ57qW9BIIge M5QV6XEdFtpAJfzOsAtX+JxIW5SrRi7mfzOhaKBKamyiacimloQ08pB2opy2BUPipRJQr02OR9L kCYGsPDOQDlgw9Cy/okIUsiv0Cb08g6QDiieGsKLDtmPADujERYTvlkDtymzHEswqyZGu8iKutc W/ZC7LHX3B3jnewHzOZV43Nk8kKiTRAQ828MkouCtyLUrkQ= X-Google-Smtp-Source: AGHT+IG3DTzAWvVW4SJ21A/SRgFk31074gXMN9+oGlJqzs/MtMc8XsiOogFgKzSWDZ9AZ40PkdjrRg== X-Received: by 2002:a05:6808:3c8e:b0:3f3:bda5:5739 with SMTP id 5614622812f47-3f3bda570bamr2064722b6e.17.1739227077726; Mon, 10 Feb 2025 14:37:57 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f389ed1ca2sm2521820b6e.11.2025.02.10.14.37.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 14:37:56 -0800 (PST) From: David Lechner Date: Mon, 10 Feb 2025 16:33:35 -0600 Subject: [PATCH v3 09/15] iio: resolver: ad2s1210: use gpiod_multi_set_value_cansleep Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250210-gpio-set-array-helper-v3-9-d6a673674da8@baylibre.com> References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> In-Reply-To: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, Jonathan Cameron , David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value(). These are not called in an atomic context, so changing to the cansleep variant is fine. Reviewed-by: Linus Walleij Acked-by: Jonathan Cameron Signed-off-by: David Lechner --- drivers/iio/resolver/ad2s1210.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/iio/resolver/ad2s1210.c b/drivers/iio/resolver/ad2s1210.c index b681129a99b6cf399668bf01a1f5a15fbc4f95b8..7f18df790157f1e411fb70de193a49f0677c999f 100644 --- a/drivers/iio/resolver/ad2s1210.c +++ b/drivers/iio/resolver/ad2s1210.c @@ -182,8 +182,7 @@ static int ad2s1210_set_mode(struct ad2s1210_state *st, enum ad2s1210_mode mode) bitmap[0] = mode; - return gpiod_set_array_value(gpios->ndescs, gpios->desc, gpios->info, - bitmap); + return gpiod_multi_set_value_cansleep(gpios, bitmap); } /* @@ -1473,10 +1472,7 @@ static int ad2s1210_setup_gpios(struct ad2s1210_state *st) bitmap[0] = st->resolution; - ret = gpiod_set_array_value(resolution_gpios->ndescs, - resolution_gpios->desc, - resolution_gpios->info, - bitmap); + ret = gpiod_multi_set_value_cansleep(resolution_gpios, bitmap); if (ret < 0) return dev_err_probe(dev, ret, "failed to set resolution gpios\n"); From patchwork Mon Feb 10 22:33:36 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13968839 Received: from mail-oi1-f173.google.com (mail-oi1-f173.google.com [209.85.167.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E7FD25EF9B for ; Mon, 10 Feb 2025 22:38:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227083; cv=none; b=VOjJMeTQuoaGFCrFR6k37f0bBumIhXbTZg1is7z+IsD04mCIuT5w//KIS0NwE932hTkn+PwDNIzIIZZfSddDC8wPJye9QikJ3vZ4WOgV3GeveY+MVH23aq5yJmCnorQEpeCvmlFMCE3rEeS50FddHYIo//nEmYm5T/oheOTbGh0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227083; c=relaxed/simple; bh=0Dd/TwIMPTa1NXxF+RDclsVv0WgpIYcbyrIZrxifJTs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lLXkh1YPZEk+r+m2JA77kaTgP2LjcTFc7mMNPQYDmCRHm/jBESE8XR0qYCf+jebvSbJ+zmNQKGmaxf9E8B2rVU3FoCfw5CUP2xIQkKACHjlD7aMuOsLaOc/8QmrIeJSg/8eN41BqL0zy62y8RDqISsh7EtT1hXfJQJeRqKN2LwY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=M3WvfM8y; arc=none smtp.client-ip=209.85.167.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="M3WvfM8y" Received: by mail-oi1-f173.google.com with SMTP id 5614622812f47-3f3a6cb98a5so1662598b6e.0 for ; Mon, 10 Feb 2025 14:38:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739227081; x=1739831881; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=7aQTsUJHgsqLkUdzEeUSjaVO0EDwfbxDIRSr93MsbW4=; b=M3WvfM8ymctecf7QYdHpg7RaqGEsSScrBBIP+Sm8JoWZiIhr1YQWZYm4I49UrOti0X 4XZ/AUUmkJVqIyITioaWP9A2CIByRnd15BMVkg+7lgnMkbw9e1PIV9+2Kt3Iu/s/YCiV dNixT0lIbp9WZ5zStWkZdKDOerMk4C+L9IdKdMBpUWGi0zEJMhewdOnwbmz6kNLOLWvk 8RTyGRZ8WMcsHMAyw99dkawyekVFF3t9u34sR/jrDW0m9l6Jw+N44mdF4HncsBbkQ75c jwxpbxNm8EbtpTyE3mfHY9oauY6l3DGauHoaF8WcpP0vnq5E/AxtLGqmSMospizOgeNA qAfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739227081; x=1739831881; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7aQTsUJHgsqLkUdzEeUSjaVO0EDwfbxDIRSr93MsbW4=; b=sSgcAcRM92AIK1uAotmq7D96H/RgfcEXPi6JlvqkWl2w1sHXzfe09509vanYGDUEsN XQS/gl1of7M+5SDfYn8NMkbPOCtaIo6kvO7cXWzF8rlnkjTrVpkBjhR4wwS/3nO8SoCu KFga1/svEY8gFo8NH2ybj2qJUoXl4eCkCtBziOjIheoCUUG9vbHGFWi8kncj5IgFdu/w /knN3WUrFnQtLNcV9ztW7brW1CfMttwrXv4SUBBJRPPlTy8mcURkCjEg/4aGLvljWR+I hVM2WItJysdSi8OHp4gzdhX2vvagGlFWEaaBOnti0zTYGbCFQe0l8t21dji3qvXpjx4G oY7A== X-Forwarded-Encrypted: i=1; AJvYcCV2Kb1qprkd8mIpe7sh3bJRJwOaENx1s/lXZ3IAEKXrdaobx7gboqO/TV1/b5pKGGeYGDIPSso=@vger.kernel.org X-Gm-Message-State: AOJu0YzXSZPYagRskmIXISeHkJYDTej0zWWGByL0gOyzyvpTtViunGfC WhtWjxAxP3zBom8n0AfPu2mUDx8OAbEHFvWiaf3tUzAW8PTRcKjod4rpOrc3Xv4= X-Gm-Gg: ASbGncvFsxr91VaN7rTizfvh2ox8vWGEumo0F72MGK92CSAqkR+SmLeDlCSYbg80c/7 ntJWEvjZYY+D3UaPJ/S4jZTZ5rAsVv5Iah55xSIYI4BKCO1n21mRuPqk6+pS7KLQwBYRKw9oprm akxJID/BBW36cfDQZvW4FS6u4ZkBHCsTVXmmlsCSWvI3rcrZZFPnywr1AdkwBjW8uHxJQ8ZkKZx H1JDXGNs//V1uY055MiWpHSdI9hidXO39Mv3RcEEN2qbPETsKk92U6rtPExyXmy/X/lFdB1X2pa 48+vh+7O8HQx//hPAlKoSg3aUNKacMEKodHHmdc5cjFV8LI= X-Google-Smtp-Source: AGHT+IGzPPZHWL9nm38yMUud0RRSbV/Ra+QmKEWIgQuJSF5KnPaRf3ayet85Wv9392Tvxy5qCKs2yQ== X-Received: by 2002:a05:6808:3c8a:b0:3eb:4681:a895 with SMTP id 5614622812f47-3f3921f0b9cmr10552910b6e.7.1739227080875; Mon, 10 Feb 2025 14:38:00 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f389ed1ca2sm2521820b6e.11.2025.02.10.14.37.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 14:37:59 -0800 (PST) From: David Lechner Date: Mon, 10 Feb 2025 16:33:36 -0600 Subject: [PATCH v3 10/15] iio: resolver: ad2s1210: use bitmap_write Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250210-gpio-set-array-helper-v3-10-d6a673674da8@baylibre.com> References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> In-Reply-To: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Replace bitmap array access with bitmap_write. Accessing the bitmap array directly is not recommended and now there is a helper function that can be used. Reviewed-by: Linus Walleij Signed-off-by: David Lechner Acked-by: Jonathan Cameron --- drivers/iio/resolver/ad2s1210.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/iio/resolver/ad2s1210.c b/drivers/iio/resolver/ad2s1210.c index 7f18df790157f1e411fb70de193a49f0677c999f..04879e6d538bce664469c5f6759d8b1cedea16e9 100644 --- a/drivers/iio/resolver/ad2s1210.c +++ b/drivers/iio/resolver/ad2s1210.c @@ -46,6 +46,7 @@ */ #include +#include #include #include #include @@ -180,7 +181,7 @@ static int ad2s1210_set_mode(struct ad2s1210_state *st, enum ad2s1210_mode mode) if (!gpios) return mode == st->fixed_mode ? 0 : -EOPNOTSUPP; - bitmap[0] = mode; + bitmap_write(bitmap, mode, 0, 2); return gpiod_multi_set_value_cansleep(gpios, bitmap); } @@ -1470,7 +1471,7 @@ static int ad2s1210_setup_gpios(struct ad2s1210_state *st) return dev_err_probe(dev, -EINVAL, "requires exactly 2 resolution-gpios\n"); - bitmap[0] = st->resolution; + bitmap_write(bitmap, st->resolution, 0, 2); ret = gpiod_multi_set_value_cansleep(resolution_gpios, bitmap); if (ret < 0) From patchwork Mon Feb 10 22:33:37 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13968840 Received: from mail-oi1-f182.google.com (mail-oi1-f182.google.com [209.85.167.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C618126136A for ; Mon, 10 Feb 2025 22:38:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227087; cv=none; b=TLLYxQzstOzEm+snLLQKjFs/2jHtr6kK1uJqz+ADvXD8lhvn+wucv8ebQ8UtbL1eInHlaMmWTJi60DKhYm0ZoBVIMe/xdPBlHfmnMyRFVy6Dgh6PRGxWv2M0c2WyZtK/XPDMAf+cKpRD8ozWKRn0nlcAAeZbH3h0Cvs+wUOCtUY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227087; c=relaxed/simple; bh=HaFWSgBdfXggpkPiEPQivtzXY7Xojib1tG2MzfPUdgM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cI9ydNjGNlOtbXRNPeDu1zRz0mtjqevum3OjzqO86OyOn9yfV/W5Ss4/hb/yENcOHdgro4RGpUYaSVbNADuWahVa/aCt2suSYRnwiqEX6Eyb/LdezTVNJQworhzvxbGHNbGEKUeVrPunmtvu36ulcgXI+UP3VNWn05RGZAeNyig= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=dvT7bBar; arc=none smtp.client-ip=209.85.167.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="dvT7bBar" Received: by mail-oi1-f182.google.com with SMTP id 5614622812f47-3f3b927b88aso373316b6e.3 for ; Mon, 10 Feb 2025 14:38:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739227084; x=1739831884; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Hnz0az7lntDGiOpb5KMBiHYUt+/ZN1SFQQir1JT9FNk=; b=dvT7bBarIKuEWBzaSXQSY+SnArGsqGr/slLKnVFFZomy3o8Y7mA0cJYOeuqEF8ebQ5 EYjWEFTAsMlN8wUjpBXVRZJ4c+9sfmhTPhJARW0U9roz14XLV8uumAVN7Y4jQfNDt+Mx 4VsoXxl3N2f/veqPjFziqBFyN2fRoP9igA0vAQGZa9VpTK7akEoPfDtAOkq7aw1zoabj 3DXbgv9RD9VrFaEutLLzROGEcDyjB/5zKDPh/FwpDAlDAs8vmg4uISd+0qNZd0Z8E062 M5zOhNCFsU5ajmPnD42Xq9RfJsENLoSkUPInqDccieECrnEeZIN9EzBY+oXsOedDWPq+ qZ7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739227084; x=1739831884; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Hnz0az7lntDGiOpb5KMBiHYUt+/ZN1SFQQir1JT9FNk=; b=syST1xiUhklKGF6VTC54u8ORxuGFngY1TiF6RRrIavyX1kB1O6+Om2U8TAB+EO3Dlw OCz7litVDx4VnrEp1fZFkUuLg9A6kORJ+FkccZAGpHzcA1qVmI1+PP/sL+m65NPcuybK W71P/3skKIoHOlY0sTcS1InGxtmr3OGuyogRtuwlWfTk8zUiWzOEoWYJ75AW8NEytqXQ YQ0cIaEyk7K9JoXV2kjlzTR8Cfs5bhdOMe9W0e+T+9+GwTIe/9QqQCzVwaj220zCEbut blDydCeD2IKHxstFufNtiE44kwGCeOoWCWBFgHQ3vLAaiEl1MmfzP5+SJJfejXwWYmpz Iz8A== X-Forwarded-Encrypted: i=1; AJvYcCU2B+GBK3z+xxD/Hw1EcJcd8h187OUS5t8pJ+fS+qgmCYNkybpVa/RsbwIrU0dR8wKnvnUJFdM=@vger.kernel.org X-Gm-Message-State: AOJu0YzaXcwvJV+WppPDm9BHMk+N99xRTQOI5lK9phN8lJ3doAA+rihI rnBXP72cJtNjRpaxtdhGGK1fYJS2u8WVTJqWQbqqdhlIarPKN1GUSEJcJ6m57Kw= X-Gm-Gg: ASbGncuo86sXYJCMxhS8XsotuMtbpm6Ja64DuyIai7cz8+NcYvyYQIQso1oAK65yHrM CY0JRXulImWpMQE0Z4Diljl2DujtKoAmYUGfIJOnykOQjoYOxOLJLe7Ejo1XE7S/6hsLiEK8UdD Gk7N/QqjfFQKuUzBqxpHn0UO57vl7tvIGG9n/avbBwh8dKSJcT/V2RAIMyxPC+s4wXpCYMga/dd 7ksoZKR4ZQqIPyh8aOmFq4Rpo2SPv26M68naqJrSfSBVNeihav3gIguXpuZ+XwCeCf9jZDDxx8L oMeoU5ItbMvbenXVjVvSexp/9wYeu7C7FFUtbNkr4vZamLw= X-Google-Smtp-Source: AGHT+IHyCAwDYiRcWVzrn7K/Vx60yNjdpFZhmlXwDMeVTAgENeKIRtjDdhXHEsiUOrCJ2abC/Ga6Zw== X-Received: by 2002:a05:6808:2209:b0:3f3:ba53:1e11 with SMTP id 5614622812f47-3f3ba53229amr2521701b6e.6.1739227084078; Mon, 10 Feb 2025 14:38:04 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f389ed1ca2sm2521820b6e.11.2025.02.10.14.38.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 14:38:02 -0800 (PST) From: David Lechner Date: Mon, 10 Feb 2025 16:33:37 -0600 Subject: [PATCH v3 11/15] mmc: pwrseq_simple: use gpiod_multi_set_value_cansleep Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250210-gpio-set-array-helper-v3-11-d6a673674da8@baylibre.com> References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> In-Reply-To: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value_cansleep(). Acked-by: Ulf Hansson Reviewed-by: Linus Walleij Signed-off-by: David Lechner --- drivers/mmc/core/pwrseq_simple.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/mmc/core/pwrseq_simple.c b/drivers/mmc/core/pwrseq_simple.c index 37cd858df0f4d7123683e1fe23a4c3fcd7817d13..4b47e6c3b04b99dc328a8b063665a76340a8e0d0 100644 --- a/drivers/mmc/core/pwrseq_simple.c +++ b/drivers/mmc/core/pwrseq_simple.c @@ -54,8 +54,7 @@ static void mmc_pwrseq_simple_set_gpios_value(struct mmc_pwrseq_simple *pwrseq, else bitmap_zero(values, nvalues); - gpiod_set_array_value_cansleep(nvalues, reset_gpios->desc, - reset_gpios->info, values); + gpiod_multi_set_value_cansleep(reset_gpios, values); bitmap_free(values); } From patchwork Mon Feb 10 22:33:38 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13968841 Received: from mail-oi1-f175.google.com (mail-oi1-f175.google.com [209.85.167.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE9FD261393 for ; Mon, 10 Feb 2025 22:38:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227089; cv=none; b=ClLCxo+kvnQV08HtiQPTkDxAc4G76rMNzId5JWD7kOEz7jWVPCeoygQoM2DEih+NXH2wosEeiRdaio52/qwSnQN84An3/ukCqGHpimbAGWLdjXD0yPMDsmHAr9s6NXBHPSfT/tvXVBCRfzRmx2uk1Gyv9o5haCOmCbJJoNwVwVg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227089; c=relaxed/simple; bh=DTPgNGmkXhUVKQ7XC6/DETbHbqjA5xVWJi+TJtvGAQA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Ao5c3CObKbtGP1VbWDl5FXuW7VYod9ujfB8lmUQ57zS81C59L66f98gFiT0VohedaTtIXzHn5tf0UhDntPiOFGEdJE72iyAtkczBeAe8AHOf4LMYP/4ZPfmH4twceU9VtTG6aVWtQzR32fI+TX3nA0SXJCC9pxsk/7ghudtUj+w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=LTcJkq0b; arc=none smtp.client-ip=209.85.167.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="LTcJkq0b" Received: by mail-oi1-f175.google.com with SMTP id 5614622812f47-3f3bc69c8c6so548447b6e.3 for ; Mon, 10 Feb 2025 14:38:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739227087; x=1739831887; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=/aqCjYxf4gSpR0G6gRQq6zdrmHAVbQWmkyM76ZxN2F8=; b=LTcJkq0bR7PqP6F7wNnr7kEwpB4IF+ENhJyvzgS8fx9V1DHttG4+yB9aXdX2XtYqey ImnOvKF1kPCn+B+hvwptAIyqjFNAhCVoYf4R7MYlBP3TdUek2RvoXt9ei+lvtG1TpNZR ldm6VIh8HdBroOf+FV63AN3VmfB3IcIuE04PXtVLjGk/7zP69+7IGc8rwtxn8G0PW7LR 93iucsg1kEq8zsf/UOq2z0xlzl/mjinkGJli56pIiLAyo+aYgXx8EtjBhb+XdWAeo8b8 pNiGcAzR3dQcfld0oLNZt3rK+u/gbZ8n4OevvpuU/QoE7LeRXbkQSsHY2H3sg33vaU0C lNDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739227087; x=1739831887; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/aqCjYxf4gSpR0G6gRQq6zdrmHAVbQWmkyM76ZxN2F8=; b=UjTQiPsj7yX1+fp05661OgyWlf8/HhKNfkDtQIZtE2plRt/nlYS2SiTMG0HDk5yliK KH96hkVqenNqEjKB5I6fsdpdTLZMavQXQ8Cd1nHW414B3ShIRyWqjompIinQJ8CMSDmX tq3dTcqKjszggZ2ePnRTrs5m+4tt5AnFCV41w/OEcfPQvZ30bZyqKMsUr6wBSFvZIUCw DDVdJKzoMsKAsJDVUZFtjvd4krDIq5OUfl//q/0Mp9dGnZZm5dUyrvYHXq6BHG50+McV OT0OGU4KbhYE8Y1Uh1tk7YKHp/BUz5mJAN7PrYGfc0f23crTipis58NP85okzalUAmle rNhw== X-Forwarded-Encrypted: i=1; AJvYcCU1RWZiqSbgERFYCJULttRX22pAn/+4zb2e69TNDVgDT/33iITSjvIsqxDb860O23CrQTe8XnM=@vger.kernel.org X-Gm-Message-State: AOJu0Yxz4YXcqgZHfuLMvBRToKM03BXPTmSvyjUq9RU8dZdYn2WJyPgW ijZ27RlUlPeoQYee8CsUn39Fha6YdY1xlkgJ4kS0j5cNFLMSRkXcnfwky2PgU3M= X-Gm-Gg: ASbGncsEXoXRRpzhqyjMfRrRkTpyBo3FCaccVlyfdrlfHOJgPPUbLzQvRPhOv7QNTep scQqItatddxQyKe2e7b1EcgqqytibS4Kg7UE+bFY4+4Lalcp1xC06OqoF+llFPo5Cs068ln/gv6 3RgEuxWZBt6q0TB7hsdxbQrHLXA+5xbnV2tLWrT7i+hL07s6eIo0mTwneXA8gam014eDUKs8D5r 2NrpAthMraI5BuULbmYgEyatclnXGj1IKJiCJ1JUJKv6LN7zFhPzUZ0qeOqb4NvxDqMxHarjUEE jS85MAvuTg+MdvOJJOKOj91T36OTZAh7qKkpU8Z+moBHogg= X-Google-Smtp-Source: AGHT+IFodsa1xU/+j9iOyHK4zd5srfGLBws68RU1hOd0Hvn3EqSmNLjWe0xJTDgUwSiCbolk4Lse1g== X-Received: by 2002:a05:6808:23cb:b0:3eb:5f1a:d083 with SMTP id 5614622812f47-3f3c2633408mr767124b6e.20.1739227087286; Mon, 10 Feb 2025 14:38:07 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f389ed1ca2sm2521820b6e.11.2025.02.10.14.38.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 14:38:05 -0800 (PST) From: David Lechner Date: Mon, 10 Feb 2025 16:33:38 -0600 Subject: [PATCH v3 12/15] mux: gpio: use gpiod_multi_set_value_cansleep Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250210-gpio-set-array-helper-v3-12-d6a673674da8@baylibre.com> References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> In-Reply-To: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value_cansleep(). Acked-by: Peter Rosin Reviewed-by: Linus Walleij Signed-off-by: David Lechner --- drivers/mux/gpio.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/mux/gpio.c b/drivers/mux/gpio.c index cc5f2c1861d4a22d984bcd37efb98dd3561ee765..5710879cd47f89b6ef4458d6b4419a1fe9ad349f 100644 --- a/drivers/mux/gpio.c +++ b/drivers/mux/gpio.c @@ -28,9 +28,7 @@ static int mux_gpio_set(struct mux_control *mux, int state) bitmap_from_arr32(values, &value, BITS_PER_TYPE(value)); - gpiod_set_array_value_cansleep(mux_gpio->gpios->ndescs, - mux_gpio->gpios->desc, - mux_gpio->gpios->info, values); + gpiod_multi_set_value_cansleep(mux_gpio->gpios, values); return 0; } From patchwork Mon Feb 10 22:33:39 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13968842 X-Patchwork-Delegate: kuba@kernel.org Received: from mail-oi1-f177.google.com (mail-oi1-f177.google.com [209.85.167.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 766D3254B1C for ; Mon, 10 Feb 2025 22:38:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227093; cv=none; b=kpWDjUNhJvCQo3+xm8gbJb/GHEmm703FBMxaMtQnFYaOy6XRj33TLR0URAUkYJIRWZfJGzwQ5vgfhws3tVNgyzaA6rzdmshuo6rR1isBPb7qDiIjzg2hip2G5mTIBFpCqGsbs/08kN8aP1VJJHS2ucLiAGe3kM82gV+YRgVFWgU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227093; c=relaxed/simple; bh=S7dgE3UPYoL2oEd02LPby/4FImzR8JSvqPwrh4K9qkM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=SNZkGguYKid9U3bwIDTz2qMtQZcTuo+gCZJA1utIgWwZdauerr3mNtphjO92uIYYuFm2ZA3/5Bdy5LbfVb8/QWis86TiQ6zGxjHuzu3QnUbFxRXFZ7NYD1XLjkXnyaejTT9CT2FJ+9zNs4R/VpZln2upuEDn1SYs0IDEcgjSSFI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=BJ0usfEc; arc=none smtp.client-ip=209.85.167.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="BJ0usfEc" Received: by mail-oi1-f177.google.com with SMTP id 5614622812f47-3f3b93e4e32so650355b6e.0 for ; Mon, 10 Feb 2025 14:38:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739227090; x=1739831890; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=wW6RHWEtayZ55WpdhtLO2i1JoETOot8MdB4MGkvPArg=; b=BJ0usfEc8bq2iGaNqvnO+QrMUgXM4SZlUqy86xdWNruvIJewuF0mRFPLiTJrvKgBkD SjPXKAuhfZoCQlkwLVxSwPryGbpR7fHGwTcWaL8B8PpBUn+bjKC76ATM2e3VE9qQna6J B+5N59bxZXtcAONRrE4AThe7VNP4QoM3rAF43E3RumEFvj/I3GwobPkbndcTNDJqN+Wr kQOX41HS5dORLNUgDRg0VlhIa0xDaxRzpL3BEY9N3YGYpdQQE+zOUSIQsGC0QMOhrJbJ ilScfPVVtamPAZvcWVgMwsr4k0+HYngZSpXAKdfgPw0ott3VUMhIQcvo22BQqYhqlEfR 9mwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739227090; x=1739831890; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wW6RHWEtayZ55WpdhtLO2i1JoETOot8MdB4MGkvPArg=; b=bw0Nz5bXqdcKFKJRoonJAcuULw9tg98c6UUoEP2A3llBHPot+06LYFpYbLNS20rL97 5D8adXutoMD4JgGvZc2FpE8Pq5RAz2GfgHFvi5HKwnWAjtDKZK7J3ohxdjWGG74pYzN/ of1GHP9bgQiNzUqr4xeFlwYI9/YDbGTkLwjkluljpf9jw0FWpjiKffBZAvg0L7P3vZV1 7Yj6jJYANnfzY/s3tLh7Nixl2csFi+2cOct5NgyEmGvP3VneGVeuFPC13n3SyoQ1hjqg K/BQboDtsRxZH6LoMSRSh3tqD+clcGhGeXKABdWmbr1Pmo3uPzxaABxfpW0tYf2HV4P8 WSVw== X-Forwarded-Encrypted: i=1; AJvYcCVXIn5QQhAdT0HrxAjAETYUif4bS4nOCqkznl3C+MYWG00J539lZ17zn61pOFn9lbkXse582lU=@vger.kernel.org X-Gm-Message-State: AOJu0YxamQyEdT81w22C0Km/awF/OYKiTTZRlYL+PYJzocvkVT0ZBX45 ardqFQDjfcMBwV+dcZI091ZFBSwxQxiMWCuAENyihaFBPHaKIshDNypk6dJcosI= X-Gm-Gg: ASbGncudtgjmUwSilvLdaKQ7kAaBNybdWzMUBJ8HaV3tMtCVwFl8NeBA1HuvebBamXH OYh01NhENQb/yJ5pfP0mbpm0zpay9h2qhXEHw7AJpYjOocQFtrFhgslnCf7xOS8RNm9+f2rUgdx CFz4NUWpJtPfJEdzVS9KwzPWOKfNb6j7APyCyBwLoP1tMVQlVQhcSW6/HuzA0XlUt8sbxgjMot9 2XgJWeVQz+PkLl4ze0fihSeqJz2jYuU7Rk00xS3bXkvHzG2oXzu14wEPBccvoQIACv5gXW9cCX7 E0UIUxZu4eDMJN+/R2XdSs1K33YWWwACZBeECSWL9JIFdwE= X-Google-Smtp-Source: AGHT+IExgIdSlhgQSDcOsxwx6WPuocJhwApgTGH7w9m44PNZh2BZdc/bphIdIFYjyr15eu6B7MhSQQ== X-Received: by 2002:a05:6808:308e:b0:3e6:54c8:fad3 with SMTP id 5614622812f47-3f3c2abf6c3mr690448b6e.19.1739227090579; Mon, 10 Feb 2025 14:38:10 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f389ed1ca2sm2521820b6e.11.2025.02.10.14.38.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 14:38:09 -0800 (PST) From: David Lechner Date: Mon, 10 Feb 2025 16:33:39 -0600 Subject: [PATCH v3 13/15] net: mdio: mux-gpio: use gpiod_multi_set_value_cansleep Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250210-gpio-set-array-helper-v3-13-d6a673674da8@baylibre.com> References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> In-Reply-To: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 X-Patchwork-Delegate: kuba@kernel.org Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value_cansleep(). Reviewed-by: Linus Walleij Signed-off-by: David Lechner --- drivers/net/mdio/mdio-mux-gpio.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/mdio/mdio-mux-gpio.c b/drivers/net/mdio/mdio-mux-gpio.c index ef77bd1abae984e5b1e51315de39cae33e0d063d..fefa40ea5227c5a35d89ec2c6f95c6668a2470f6 100644 --- a/drivers/net/mdio/mdio-mux-gpio.c +++ b/drivers/net/mdio/mdio-mux-gpio.c @@ -30,8 +30,7 @@ static int mdio_mux_gpio_switch_fn(int current_child, int desired_child, values[0] = desired_child; - gpiod_set_array_value_cansleep(s->gpios->ndescs, s->gpios->desc, - s->gpios->info, values); + gpiod_multi_set_value_cansleep(s->gpios, values); return 0; } From patchwork Mon Feb 10 22:33:40 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13968843 Received: from mail-oi1-f176.google.com (mail-oi1-f176.google.com [209.85.167.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4C0D262D12 for ; Mon, 10 Feb 2025 22:38:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227096; cv=none; b=LPT87NYcK6TlJjM8kw2san5+/M27kzDzks1bojciRqyXNB25HWXCYuT6lnIE7EQGuYnObhNjx6txfJzCtWH0RcZ4y1UbCiCv5P6JU/x0O7X/bpMw4+WWX519eS+jVhSprc+HAfeHghwjyEcKU60ljVuWPbbS5gTggA9dUFtz/GA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227096; c=relaxed/simple; bh=QtC6oLxmw2DvbNfS+XsWeQUt9WZBo54DTtz6cY2CdFQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=KINSs26QmYyKy9eOoyN3a3ZufL0hsLtPzgjb9GaUsQz/rdM3x8EAg4ldduWPKK3EVjG6mVGAcDtCeg3ouGy5b9ynQ+4O/nNldRBd8bQA9eZ4wtezJqRMjW9D8x/0TgpWn0YaNFJ5sEaPhFzdtwTlCfpToWGIOErAVuTReYo5JP4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=zEC5uXyi; arc=none smtp.client-ip=209.85.167.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="zEC5uXyi" Received: by mail-oi1-f176.google.com with SMTP id 5614622812f47-3f3a6ee569cso484185b6e.0 for ; Mon, 10 Feb 2025 14:38:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739227094; x=1739831894; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Rir37DR+dGjXzV88JkfAUftf+GWLKbTzx84djPKNaJM=; b=zEC5uXyiKhnWOqx5/A8Yv466JRMMJpfwQTn92/mpKZPcLRRpvvrtis3ZcZ8KXEs2bZ MYupPNSVfFZyhyW8mGDUXI7AkGkRPbwA5Ip8LRCzhWlJNwQ8JW1hHsZnwHNb90V0OYyN DyaeDXGZtV6R4og2AP/D+rqByz5AEqDCvkw+vDjbZOT/yDIPlpGbDsdU987VvJhNr3Rm LgUIQVTjmd6QOgHUUBpVWidY5H2scFqZbGYGkzFylqfteOf5Lui0VIZgYmrn9uwBVKfv iYI7mnqGc/V52O3qyFceLfV+fnXugHeokcmKk86QXw6q21/eBgjFmexD0j/GxKETOMKu KnJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739227094; x=1739831894; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Rir37DR+dGjXzV88JkfAUftf+GWLKbTzx84djPKNaJM=; b=VHcq9TWnRg2rESf8Jw7u1ZdKlR6wMMdsrwFwu5h2SRJC4oFm+qEwthKv3ziuY1IF7A U/jGhXc/lygLYy88UTmVcTLICuOuAxEzLexv3JcVZQ5mEW70qIDC3mjR3U+tZv9mG458 Wd00UEbbOlsfVwedh9OLxvoJY7HSTiQ33wwiOmgDK/FfMXDwM9NkUnoM+dVT+6CK2zm5 24NKyKf9e6MR2QXLc5mz4jn6Vir1RuGs0LfpRLoE0HRc5oNJrWsN6bMmlwjps8cjbAAH j+uzYv6irPS4Fuu3oL3soF8+P0O/cs0OdvRmbjLpjoT6Nrz5nxXDzrnHhoSnqyoKj0k+ h1Ag== X-Forwarded-Encrypted: i=1; AJvYcCWPZ4WjgK6/tJohDvxhJK+GEE/hI3qe//nc+xfahjegmaNSl3R0LW+Xuhba3Hi1/eIA4Ize6p8=@vger.kernel.org X-Gm-Message-State: AOJu0YztN7Rw0tr1mq5auLRPvUERFbUuGyFIcyqGmtCFTWdozIITkVJJ uaBcWr5cagX/UUD0dP/YhS6B/2WfGGGnYceBXCE34P4hJW/mL15o+SuUJrNd7/8= X-Gm-Gg: ASbGnctqSiZD1yS8f0Ck0F98tYSDpe4GhYADfmfCqCYkqYmi+XsjG02DjzxLRUex2JE kbAiDw2Af32qsJv1pFYHfJ1wXAltlVykhIsZHFSG6Hwf3YiUOMdbpS4wejUUq0JouOceOxh6bzt 4jVwYOrjCwCtzdsxYSamuEpjYs0+tdXiq5Me2sxjdeIh2Y1Ka9BOJH56fm7D49BMBWyS/lovkVF ZExrf3N/z3mLMHTQMT0wbaXClHzd8k9J5XaKyoAe9yzfunJFzw+w/Vyr0m5B5x+x1iqYVJCCHq8 1EzePIG+cj7CD/3LzCvJSzoFmQipaJ/Oa7XyxJTAUn2LQrA= X-Google-Smtp-Source: AGHT+IEVAt15PQdS8DVNqyeJacSiAcXpbNeOp6OkG5/0y5b43SqHZC4XrUJm46YNpLSsnE3NWRVPBQ== X-Received: by 2002:a05:6808:150e:b0:3ea:519e:cc71 with SMTP id 5614622812f47-3f39242c9d0mr8056705b6e.39.1739227093792; Mon, 10 Feb 2025 14:38:13 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f389ed1ca2sm2521820b6e.11.2025.02.10.14.38.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 14:38:12 -0800 (PST) From: David Lechner Date: Mon, 10 Feb 2025 16:33:40 -0600 Subject: [PATCH v3 14/15] phy: mapphone-mdm6600: use gpiod_multi_set_value_cansleep Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250210-gpio-set-array-helper-v3-14-d6a673674da8@baylibre.com> References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> In-Reply-To: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value_cansleep(). ddata->cmd_gpios->ndescs is validated to be equal to PHY_MDM6600_NR_CMD_LINES during driver probe, so it will have the same value as the previously hard-coded argument. Reviewed-by: Linus Walleij Signed-off-by: David Lechner Acked-by: Vinod Koul --- drivers/phy/motorola/phy-mapphone-mdm6600.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/phy/motorola/phy-mapphone-mdm6600.c b/drivers/phy/motorola/phy-mapphone-mdm6600.c index 152344e4f7e44de0f8ab1cae6ae01a1f1c5408e9..fd0e0cd1c1cfb10fb55ed271e47b6a0bf857028e 100644 --- a/drivers/phy/motorola/phy-mapphone-mdm6600.c +++ b/drivers/phy/motorola/phy-mapphone-mdm6600.c @@ -177,9 +177,7 @@ static void phy_mdm6600_cmd(struct phy_mdm6600 *ddata, int val) values[0] = val; - gpiod_set_array_value_cansleep(PHY_MDM6600_NR_CMD_LINES, - ddata->cmd_gpios->desc, - ddata->cmd_gpios->info, values); + gpiod_multi_set_value_cansleep(ddata->cmd_gpios, values); } /** From patchwork Mon Feb 10 22:33:41 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13968844 Received: from mail-oi1-f181.google.com (mail-oi1-f181.google.com [209.85.167.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEEF4263889 for ; Mon, 10 Feb 2025 22:38:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227099; cv=none; b=WwcL6L/ljZtH89HZ7i9CBMeBzZS+sY8i1qbssGWjUerhRvD9wxj527a8mnCI4dqclH0DY/Diee8HUzDk3Iep1yuwTrFHRfFOKZitvlMEMfBhcyZ/YQ2E/tADKGjt9spY9vFISX+NFHWr8wIPbKaXJqrNS1eFC7n6Rst4crKhn2Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739227099; c=relaxed/simple; bh=SREiuK3L9rZlfmn2CRPkgp1zixwI3ho4VDIygOej2Dw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hlX2wlmKJFre9gJAi2VjqjKV6NKU8Xyq2iWR8n1DsIh27qHXXwx4bjtMUOJ5geQ3qMJWfIl28j996fqyRnyxoAabxsxHnwkT040NufgnV/mLLS/xf7X9tKpf69LipMkXNQ3rxr2RiDfOvCgeT+5oTUa+nOVydU6c1191Dqhz7xY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=sBoqBWii; arc=none smtp.client-ip=209.85.167.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="sBoqBWii" Received: by mail-oi1-f181.google.com with SMTP id 5614622812f47-3f3b2a18d8dso1043671b6e.2 for ; Mon, 10 Feb 2025 14:38:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1739227097; x=1739831897; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Zrl0lG0s99SDBuGZ/+AcMLJIAJmPLy1NCd/dBoX8jU8=; b=sBoqBWiilrg6G6DcKncG/QpD3XTif6KLjw4bVZEcVRfSe0hlXDRNldE9YF2PAWEulM /sVf3tX5SwJe89Lj9M3MIJaCSs/jc++FpF8/lBpSXw2Rh4aJABVWPzB+mAbwOIK7QYhN 6oPTUx7jplW5h1Q9Glmxas07OXMuPokCylYCVZrWgO1kbMVxEreyu7pT3Uos0DthgENZ qRm2huNp0aJC+MYKTFrjAeCcU0mMxdfCA6N5q8CvwJ9rjYFSF2MzzMa+Jy26pj/OKhJr 5eOr6oS8AUK89BLsnCV0I9YsOlDgM+6fh0+hziadoBBOWYFT53YLUukUBy7sBwFkSFVY JHFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739227097; x=1739831897; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Zrl0lG0s99SDBuGZ/+AcMLJIAJmPLy1NCd/dBoX8jU8=; b=LFDX6220Ap2QfzAjaw+VdbE5OWSq4pGxrkUFEyJ/JcS8a5UfDZkwbmkq3Gi7e63VpH uEGe3zLufHde1TuDYNbZdhqvfMtuPQUbF29YimyLk7y1uO8+Iewi7IqWzFPrKJYf6X4g rQOy1zKwCMBs+vDUPCFd/YzMKtB3RFALxA40oVAJmClqly6oPPgy8QKN4Q6BpgQTxw9c QHVW/ZjN92nK73qGa/pI9XgyzitdENPVx04lhIM3Cfo0O3DuuMZIsSvFnyOllw8oRwaD 3gSAQ9lfz008R2Q9BqaqD6geL5JtD4vt9vTxxlbmoykCQDrT5wq9cGM/A1w/zJE7I5Om CuYQ== X-Forwarded-Encrypted: i=1; AJvYcCXCrHUDoRJ9howoOCXV7Qr73OYImth0hry0ryUCYGcWDXO9WcxNivHvDjFhqT3Wic+UDZ0JN04=@vger.kernel.org X-Gm-Message-State: AOJu0YzCS+YoRT/1Fw6DtzovEWQf+6KyqjjmGkrwmFiFlISO5NsMGNiJ xeWt1BLxTMIYOoN+5UOVP8UMMfVDZvgTktAWfTP8HPDzIEF8M/f0F8tqzFKSLpY= X-Gm-Gg: ASbGncs+nzK5WMr6Fb8+o3xFMpaDErGQWPAEaDieAMp/WtnnjAXN2zbfPahrOz5Ynvx ZCJz/XlH20SHUDAVYdYW2E7yBU6pT6rH6nMKAWXTKuyS2w3NyGXRHhVvYh/1Qb1xelt0Beo+cS8 xvzW6wwve4Nu9drruVe77KdcUE2a1G5r5+f2Ahr4VrNldFKmj48RDGG+fVhSp0yWqrDajz8gj1D YGUYdFYgl2q+YI2ln75NKBxJcowggFviUga6BbmIu40kU7eDLR1G4751peKC6p8p+JhsjwEZYGG pDgVlcc0L52QIqf1tYIVxvoXMMmCHXnS0gG5F/r//rmWvA0= X-Google-Smtp-Source: AGHT+IENohB4+Vdl15nvUdajyBJJbaG44s39TfMb4Zf97z1Hi7JTuCyMgAhZEnJb83znOkXtS3I7Kg== X-Received: by 2002:a05:6808:10c7:b0:3f3:be50:2a69 with SMTP id 5614622812f47-3f3be502d24mr1971166b6e.17.1739227097004; Mon, 10 Feb 2025 14:38:17 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f389ed1ca2sm2521820b6e.11.2025.02.10.14.38.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 14:38:15 -0800 (PST) From: David Lechner Date: Mon, 10 Feb 2025 16:33:41 -0600 Subject: [PATCH v3 15/15] ASoC: adau1701: use gpiod_multi_set_value_cansleep Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250210-gpio-set-array-helper-v3-15-d6a673674da8@baylibre.com> References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> In-Reply-To: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value_cansleep(). Acked-by: Mark Brown Reviewed-by: Linus Walleij Signed-off-by: David Lechner --- sound/soc/codecs/adau1701.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/codecs/adau1701.c b/sound/soc/codecs/adau1701.c index 291249e0a2a32df7dde81904dce2f6be143fc2d7..6876462d8bdbb41d551f776c2d7fe6ed46115fa1 100644 --- a/sound/soc/codecs/adau1701.c +++ b/sound/soc/codecs/adau1701.c @@ -325,9 +325,7 @@ static int adau1701_reset(struct snd_soc_component *component, unsigned int clkd __assign_bit(1, values, 1); break; } - gpiod_set_array_value_cansleep(adau1701->gpio_pll_mode->ndescs, - adau1701->gpio_pll_mode->desc, adau1701->gpio_pll_mode->info, - values); + gpiod_multi_set_value_cansleep(adau1701->gpio_pll_mode, values); } adau1701->pll_clkdiv = clkdiv;