From patchwork Tue Feb 11 22:22:16 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bitterblue Smith X-Patchwork-Id: 13970766 X-Patchwork-Delegate: pkshih@realtek.com Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44896267715 for ; Tue, 11 Feb 2025 22:22:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739312541; cv=none; b=qI77JCEnYkS/BvUb31pPGXr8fk5pQPvL7ARNeb/LlmaN7MFIRVFEg7a1oH0+fS9139X9RBVQZjBMb/QQqmTod3sHJUicQAB3WhA1dhX8Q/SGHAuMrT1iYbvoXWIv1LIc7Az9H5bnsWc6iUC+SEwMRv7JVwftY6gega63QadcK44= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739312541; c=relaxed/simple; bh=+VayUWbg8pu3OIpUV7DPdKi3S42ml7UlmBsVRWRZfh0=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=O8WG3VrGfaqJreHzbM13x8TR7p/UVFdKCuHR5Lpy3m9am8l044fs3hOa2gkpCTIbNFgCGP90jiECHi5bUAj6Ral7j6SGUGAkce9kG9LDNAq1It+xBz+XRyGK5LN4V03BfIAj9ixaIGRZ4O1Hh2GDqmSgPg6oLNfmVfWRn17c89Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HRU/3ivB; arc=none smtp.client-ip=209.85.218.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HRU/3ivB" Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-aaee2c5ee6eso992778066b.1 for ; Tue, 11 Feb 2025 14:22:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739312538; x=1739917338; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=VbiTCbXEeldJnegnvSXu0fmcBO2Za0kGDLfJrHVRyUM=; b=HRU/3ivBCyBw5LxZxI2UnZdlIVUa/+f00JSEYL1cwXgaxjSqK9UFD89cAJZWIgjpeg yqdUh+CW4QsFuFiTiDzQMNOh3q7JKXypisw3veWWUtevO0SKelSvmLETew3n4ptvpiJ7 dt8vHIPm78KsixMB3hb8nkBuziX53SNfZmfdFUBYW92ZsTiDMzKtij3mWcB+LEGEZ/rB eY/Nzy8sd1vd2z238OKYW+PFn5k1lyZrsmtsOS5fqDCesFCJ+HNhGwbLTzhKMvJN/rse vtIl0CRm4BxTExDDhmcYb2pXPPDebqXH70D0UZ2nRyhYBzQFks+OhDJNoxqk/6WuH+D1 zRjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739312538; x=1739917338; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VbiTCbXEeldJnegnvSXu0fmcBO2Za0kGDLfJrHVRyUM=; b=La5yxmZ2l0TK7pI+tYCROWmN6IBYICudJ4cmWsEZbot1DCSMiuVylPUeE4qSGpBe1e Xdqu7lGyISeD9u48shke6a0hGJA6RlJCPJRdM71zhPGrw4Ure5143xfisIe7FQXlEa59 BWbZDqZ+hXVH2PEAYRvgpfBduw54IkCHsZGJtEhkQqtHZCIR5YYmI3psxwOh5D69DIwp ahHAgGBUsiqeT0uqhiN8cv0DW5LHP2NNN1+2g05wCpW8x96bxBr1dZGz7guGi4p2mLQA hzUuZ309QJn2250bUC3ihH9lCVKWU7rNnQqcJOGOAout7DiRB9UGTj7eKmfqi+svwi/h lW4g== X-Gm-Message-State: AOJu0YzKZeQhj0xLX/VGbiSpaVJOsEpf2+RlCZcsO1rK+Jzso0LlBFuV e0DxWnj2NHk1DFT47KdnT8wd/fCFV6nHqj9V3FQVTi/l3e0HbixlkqPV+Q== X-Gm-Gg: ASbGncsTJxwji38udIW5uRKmrDPxpRRHBvUxxs31a0ZYiLy2qFKthJuu9g818YBCGIe bAhO4GPuaV24azEiqQ0r21rysomHQs9mwOAtIZEhd5vDsujzE3eULlFicrhDb/3Juk8zMYvU/VE gYpcYFY7zsxEpEald1SWIJ+cP6h7NFLk78ZEiujECmGc1IjMuntDX3FydDq5FPumzVuGylS0Ua5 6ei7eICc3wqXjEelKfmxjB3Z9Anojj8lH9jjZxyepio7XlUKappwx4lvflHPi0eRKpPX5Sk38VC Ktej5MRdA0NJNz3VxDZyBrPA X-Google-Smtp-Source: AGHT+IFBB9C5py1SO+kqi4bkM/UVahiIJCh4aqcBeiLSKVF9r452PEdR1us9vy1GZu4rtVybVlBD1Q== X-Received: by 2002:a17:906:7956:b0:ab7:f221:f7b4 with SMTP id a640c23a62f3a-ab7f34738c0mr51235366b.43.1739312538186; Tue, 11 Feb 2025 14:22:18 -0800 (PST) Received: from [192.168.0.50] ([79.119.240.253]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab7bc28c58csm535888166b.135.2025.02.11.14.22.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Feb 2025 14:22:17 -0800 (PST) Message-ID: <83c8e281-0d25-4de6-a6c7-84d24b228888@gmail.com> Date: Wed, 12 Feb 2025 00:22:16 +0200 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 1/8] wifi: rtw88: Fix rtw_mac_power_switch() for RTL8814AU From: Bitterblue Smith To: "linux-wireless@vger.kernel.org" Cc: Ping-Ke Shih References: <21111380-5db6-4a72-ace9-f18b5bcd525c@gmail.com> Content-Language: en-US In-Reply-To: <21111380-5db6-4a72-ace9-f18b5bcd525c@gmail.com> rtw_mac_power_switch() checks bit 8 of REG_SYS_STATUS1 to see if the chip is powered on. This bit appears to be always on in the RTL8814AU, so ignore it. Signed-off-by: Bitterblue Smith --- drivers/net/wireless/realtek/rtw88/mac.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtw88/mac.c b/drivers/net/wireless/realtek/rtw88/mac.c index 63edf6461de8..5de16c75adf2 100644 --- a/drivers/net/wireless/realtek/rtw88/mac.c +++ b/drivers/net/wireless/realtek/rtw88/mac.c @@ -291,7 +291,8 @@ static int rtw_mac_power_switch(struct rtw_dev *rtwdev, bool pwr_on) if (rtw_read8(rtwdev, REG_CR) == 0xea) cur_pwr = false; else if (rtw_hci_type(rtwdev) == RTW_HCI_TYPE_USB && - (rtw_read8(rtwdev, REG_SYS_STATUS1 + 1) & BIT(0))) + chip->id != RTW_CHIP_TYPE_8814A && + (rtw_read8(rtwdev, REG_SYS_STATUS1 + 1) & BIT(0))) cur_pwr = false; else cur_pwr = true; From patchwork Tue Feb 11 22:22:57 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bitterblue Smith X-Patchwork-Id: 13970767 X-Patchwork-Delegate: pkshih@realtek.com Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A76E6268C6F for ; Tue, 11 Feb 2025 22:23:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739312582; cv=none; b=X1Lisdnru2waWZndwT6xVAvMI3PG7mRV2TlCACfMoYJsQRFYPTb9O2+/9A9BzimzmOugp66gNoTDE7fvthKbRg8AJIJrkWx2//aMz+9dfkoILD4jCGbo4QXkdB05XUdlZOEXQkV6NeKgsWQ57sIovkk2aosH1wrx6YzhNfagcUg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739312582; c=relaxed/simple; bh=u+0iscWxOX/frncBLJZD/fTIR1UVTn88WPwh8FDlV1s=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=TxfI5beQMJvX3AyPyWb1bKSE3bo5DmSEJ3zTMXbkcgDX1GoHkQDibZXa5xIlpRu3cq3Nn6T+PBlcIV/Sv3qnnLG9/GIqFgSuyevxOgQwj3sm/yY/5xE6ljIGuvSU0U0N06zMXUkFlkr5+NnvGTPmZqcxmrpnuAUkKW8OF89hCp4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UFVtncZr; arc=none smtp.client-ip=209.85.218.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UFVtncZr" Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-ab7cc0c1a37so402947466b.0 for ; Tue, 11 Feb 2025 14:23:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739312579; x=1739917379; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=NGDdEz65l/ypbKS6iBlVdY+5xPDO6F9oyP9HxAS0I2A=; b=UFVtncZrpqalmB/vmf6pCzwdyQt+fo7rrNTziCnkGxcKyBqgP1Q14rgI5NGRMC4Xym YqiuW0edeHARJNFh8tSgukRkA5EuquH8WJ2fl4ofzqjn64GvxWmNrNJgGEl1Zqbdst92 N8cbQ3GcPp4IbHYh+DbGp77dTMl7WrJprTNtqwExpbVFf/vH3YyDxG3gVJTzmiHM8wkP n3oqvEDY1kLYgAQqce4DQSU5Hi20e1waZSpO2MIujxXa52GuoEDjVqWwV+i7/5Mpd/iK JqgZ+M1VCWKW08wt6+/Wakwx+uoBQj9mu1IcSffjV14pFHjspDuIV7JVMJsYlKD+5G3U BNUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739312579; x=1739917379; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NGDdEz65l/ypbKS6iBlVdY+5xPDO6F9oyP9HxAS0I2A=; b=jdXFSqNDooVNU3jurfPYw6tjhIOBtnoy/3cqskUZYt5IMPtOSvV+hVqaVuki7ua9PR jsNCOzvdBEpjseKDWNsLH7K5a8drHNWbVjeBMG+uN6g9lwxskd9s5/vCCqosb4V+Ceqe p3P9ne5rSajbSXaQW16GxI3xhFj0gqRoICmbRavB0bpIAyg18jJbU9lHX5M7X7SHFspR nRlhQPOHaygVARZqI3d/xyQNK3rG7nQxb686qrCi1oSiqW/dTjjvuRbzqwUenk2mDOVw 1mcCGEi+ilsGOuPJkNOH7BhkQNU8eVDNk0SmBkXA5TPYfa76YaiZMoIYtn8XImNzSbv+ Sx9g== X-Gm-Message-State: AOJu0YyLovZrTpWNkGtVsOD28/3jeEalNgeorZJUNP3bC/rek+U1/qNJ wPyg7ufuNWnu72lMgW7uIJktbaM4iRfDwjSxgilGxwkldyQJl+bv1s6NRw== X-Gm-Gg: ASbGncuKE5FbJ1Yk/F2eET2ST/cjhgH1FY5TeKDOMNruoGHVvfl1Qt+6NiyI/2svQ/V QjWFwu/oB2fYX7vHOel8JIr2JmfmNZ0D2Kj1xV5yNy98cDf+yPOvx17cO0u7JGtVC0WK/KiLqT0 nqhEAa2n59W+/3cskJGgljpopf8bTkCNKcgN85c+YtYLY+F1ZmLQoFVi2ifRUXDSy47D8fjZ/LF dxCUIeyjtrJCqUWOXGN6j5HwXVrDhBPc6nroPzyb4Xd2hVxhbVTqyfk+Y73sfp2zD8O6h2X8Lw/ CH8qgPZx6vhXp5i8HNCw1phZ X-Google-Smtp-Source: AGHT+IHX/n31zZUrNbf89vDg3KXA7pM5VrN6phtjDU9dMCznJs7c0lsivEZVSPRbPdCxTnHmw/vamg== X-Received: by 2002:a17:907:9719:b0:ab7:e811:de86 with SMTP id a640c23a62f3a-ab7f33a39d3mr51752166b.13.1739312578890; Tue, 11 Feb 2025 14:22:58 -0800 (PST) Received: from [192.168.0.50] ([79.119.240.253]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab7791a4b13sm1092656866b.125.2025.02.11.14.22.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Feb 2025 14:22:58 -0800 (PST) Message-ID: <23d28222-8f83-43a8-b312-d5858cf355d8@gmail.com> Date: Wed, 12 Feb 2025 00:22:57 +0200 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 2/8] wifi: rtw88: Fix rtw_desc_to_mcsrate() to handle MCS16-31 From: Bitterblue Smith To: "linux-wireless@vger.kernel.org" Cc: Ping-Ke Shih References: <21111380-5db6-4a72-ace9-f18b5bcd525c@gmail.com> Content-Language: en-US In-Reply-To: <21111380-5db6-4a72-ace9-f18b5bcd525c@gmail.com> This function translates the rate number reported by the hardware into something mac80211 can understand. It was ignoring the 3SS and 4SS HT rates. Signed-off-by: Bitterblue Smith --- drivers/net/wireless/realtek/rtw88/util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtw88/util.c b/drivers/net/wireless/realtek/rtw88/util.c index e222d3c01a77..ba02ba72e104 100644 --- a/drivers/net/wireless/realtek/rtw88/util.c +++ b/drivers/net/wireless/realtek/rtw88/util.c @@ -101,7 +101,7 @@ void rtw_desc_to_mcsrate(u16 rate, u8 *mcs, u8 *nss) *nss = 4; *mcs = rate - DESC_RATEVHT4SS_MCS0; } else if (rate >= DESC_RATEMCS0 && - rate <= DESC_RATEMCS15) { + rate <= DESC_RATEMCS31) { *mcs = rate - DESC_RATEMCS0; } } From patchwork Tue Feb 11 22:23:19 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bitterblue Smith X-Patchwork-Id: 13970768 X-Patchwork-Delegate: pkshih@realtek.com Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65E0C1B4243 for ; Tue, 11 Feb 2025 22:23:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739312604; cv=none; b=JViHDrPG7hTudm2C+hN2Klz6qUG0Bnrn3xZFB9bP2px5LRCLZ8Tl23HG19ny/9UlYojtWdqZq8OaGThuqyLzWtYdBbB0yjPZ/IbFs/XuK5qmmeWT08Oro1QWiW/uawYle0vl5ah2tjU34ttUKIr9AwCWTaptdeSJVeGFrtO+adw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739312604; c=relaxed/simple; bh=as8PTLPQ7jJaqIVxtzWeWF6+J/91+LkZOUmtLPdNjuM=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=X0NluUtr94IhIPKElNvUfUm9Fh+BMQ5PAD3yON2GUsqWdTPJ5Zi8hPLPnvGLZgY3oanVOvOVY5Vmbn3Fi9QhwtFcnO7BDMXUCL6pznDSrKo6Mnc/ZrfN+L5Wt/PXJis+T8W8Z2Fk8uRhc/oP+KD+fQuzFb/dSmaPQ5Q8cToyk98= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jtQ33NZv; arc=none smtp.client-ip=209.85.208.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jtQ33NZv" Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-5dcdb56c9d3so9781584a12.0 for ; Tue, 11 Feb 2025 14:23:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739312601; x=1739917401; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=9YgchMAmn9tt0Nglo8OmxPNVzUyvTpxHyVJrjH8I3dk=; b=jtQ33NZvax4e858E7+Ov7gNXYPoRiNdl6lHKGP6NKrWcAkDNzuNECpZzW6jeJV/vjq ZApez3WWOctvGpo+2J2Cw2ONUJ1Jt8zPSBVV/y+DJnIPOguFSW36X7QFgezwX/5BlgIY /6JO3mFJBB66t5V5PVafVEreqANvh9dtgDNrNTXsdXsOeUp4gyjHsACweZ+qEpPI79Tm YR6GD3aObuI+mFN3slVWz0OoWhdXEFcuptqR6TYnZDdrAi98zk/x2WmAedM9upUf5zww KkIAD6qKjsRx2mGwoZdXZzaZHJfUKNCiu9MwaPvOdQglDmghVxjaM1jOBJPuKYEV8oIh 3DyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739312601; x=1739917401; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9YgchMAmn9tt0Nglo8OmxPNVzUyvTpxHyVJrjH8I3dk=; b=V6Mro5yQhLo+WA2hzBU34J8CUm9W0/OvHb1LZftiNDok3j3XcfhVsiwet9BKrgAxGx a2o1fV0semC+IEFaU0+k2aq1bY/qikvTyAI5cGg0ds/ZzuXs+kiR6RNLKyvFjn/ZZ0QB oB7HxX/CQjkvQjRLiVUN3Ga/80IOLvVyJ/xm8Ao4dXW2RHkdo/09qxPk5/a+QX7SCX/w 7vRu1cX9M0wujN42duilz4gmCwc7ej6CFs0rTgZYGUaOKS9MnlYnjEWxrRKftXE71vS3 Ia9ldSgEXNYpb28bDvPqpgnVjCJJtrv+sRZuXGuIEtauVqTPC2tRnokw3pKVt9Dm0tZ4 xgBQ== X-Gm-Message-State: AOJu0Yxx9aMchmdMAJp7YRtu5dvNX1gP1YMg5DpW9q6HdzZOCS5/cUZq //3RYLNb89+dEEleiGAVM+eDEwQABM1/qyshIL+x118J0miOWzd1w4YPfQ== X-Gm-Gg: ASbGncsZ1Nsgpl7BWXqdE9r/g2eySLaqtem65dgXMgwIDivoQyrDdZBAe/51USZj6HP j4oZS+xuRe0u0FlThAmyNqLt/SIajveiwcRdUwHlzP+C4/s2QXpwYNzMPzOk5zBwuJpOngFui8v IeBGM+r21wym9VoJZoVxiskwNB8GWeCE+Rs5gF5/K5spabreZ4ITHxa2D0tXcQjxFwyq3P4K7Vw eMmYpwQRqjhy7kItbdeBlqchyhUA5nFiwhXUkJWg5qKYY36UykFTHkvnmsltRdMJyxOeVfixUFH DpMCV1xca4HDThr+bQ7MHikf X-Google-Smtp-Source: AGHT+IEtBVR++LokhpnjB4eTm0iwtmi4sLHu42iUt8D6ufvXVI18hP1ivlns7EG/5/5OWk3waPPxNg== X-Received: by 2002:a05:6402:35cb:b0:5dc:58c8:3154 with SMTP id 4fb4d7f45d1cf-5deadde67f8mr1915672a12.28.1739312600498; Tue, 11 Feb 2025 14:23:20 -0800 (PST) Received: from [192.168.0.50] ([79.119.240.253]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab7dca728fcsm223495666b.166.2025.02.11.14.23.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Feb 2025 14:23:20 -0800 (PST) Message-ID: Date: Wed, 12 Feb 2025 00:23:19 +0200 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 3/8] wifi: rtw88: Fix rtw_init_ht_cap() for RTL8814AU From: Bitterblue Smith To: "linux-wireless@vger.kernel.org" Cc: Ping-Ke Shih References: <21111380-5db6-4a72-ace9-f18b5bcd525c@gmail.com> Content-Language: en-US In-Reply-To: <21111380-5db6-4a72-ace9-f18b5bcd525c@gmail.com> Set the RX mask and the highest RX rate according to the number of spatial streams the chip can receive. For RTL8814AU that is 3. Signed-off-by: Bitterblue Smith Acked-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtw88/main.c | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/drivers/net/wireless/realtek/rtw88/main.c b/drivers/net/wireless/realtek/rtw88/main.c index e4f9b744f24d..3319bb5044c3 100644 --- a/drivers/net/wireless/realtek/rtw88/main.c +++ b/drivers/net/wireless/realtek/rtw88/main.c @@ -1565,6 +1565,7 @@ static void rtw_init_ht_cap(struct rtw_dev *rtwdev, { const struct rtw_chip_info *chip = rtwdev->chip; struct rtw_efuse *efuse = &rtwdev->efuse; + int i; ht_cap->ht_supported = true; ht_cap->cap = 0; @@ -1584,17 +1585,11 @@ static void rtw_init_ht_cap(struct rtw_dev *rtwdev, ht_cap->ampdu_factor = IEEE80211_HT_MAX_AMPDU_64K; ht_cap->ampdu_density = chip->ampdu_density; ht_cap->mcs.tx_params = IEEE80211_HT_MCS_TX_DEFINED; - if (efuse->hw_cap.nss > 1) { - ht_cap->mcs.rx_mask[0] = 0xFF; - ht_cap->mcs.rx_mask[1] = 0xFF; - ht_cap->mcs.rx_mask[4] = 0x01; - ht_cap->mcs.rx_highest = cpu_to_le16(300); - } else { - ht_cap->mcs.rx_mask[0] = 0xFF; - ht_cap->mcs.rx_mask[1] = 0x00; - ht_cap->mcs.rx_mask[4] = 0x01; - ht_cap->mcs.rx_highest = cpu_to_le16(150); - } + + for (i = 0; i < efuse->hw_cap.nss; i++) + ht_cap->mcs.rx_mask[i] = 0xFF; + ht_cap->mcs.rx_mask[4] = 0x01; + ht_cap->mcs.rx_highest = cpu_to_le16(150 * efuse->hw_cap.nss); } static void rtw_init_vht_cap(struct rtw_dev *rtwdev, From patchwork Tue Feb 11 22:23:55 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bitterblue Smith X-Patchwork-Id: 13970769 X-Patchwork-Delegate: pkshih@realtek.com Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BEFA267714 for ; Tue, 11 Feb 2025 22:23:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739312639; cv=none; b=d+kxr3vVWtZpc+1XKhUSfe0JS8nagP7QUK9PZcQSj+dz8IiX8ie8BeYoPZ4pR3gBYV2qxzGkSpy6JySZ4cwCZAdcpnoDyMtPbF7ocxejm56cREyyQaz3HVpQNKad5FIK6z3VNdwOUonihfJe6+gxCizNgaQSoXU/7YIUQX+/fDY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739312639; c=relaxed/simple; bh=8OOt5VUmuoUOmx1zA7BPvfMxbeOhC1Za86OZenEi3Pk=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=BayvkbUiXBt5ZKaKpmo53o7u4RdsLK57pc589gAGOahFgHS8hmRNl6V9mSQTzn8XefUB07zD7zuTl/93QA8xLnIcxOeMQXS1tpfNNeplam6wyfXhMDS8ccJOuNnugeNSITaYl5fyakdcLnCgAIXv4arhxjyaZ3EpL3Oy1Khdnp0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Vqcv6ig6; arc=none smtp.client-ip=209.85.218.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Vqcv6ig6" Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-ab7e80c4b55so191014566b.0 for ; Tue, 11 Feb 2025 14:23:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739312636; x=1739917436; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=/zc2OVM5XY9gyqbnVO1o7VPq2IP1Z0aNrrnWGpKs/1M=; b=Vqcv6ig6eTQxp8vrXkjy+L3zLrVMZI52KSKMtt6B8QK3iIgAZKmGgG0xEhPwxdtsTY pO+jv73CQhIkrnPXjDJUJePTrXcSwXhTRkwrYI04MjCsErDve6zGtQls5mn/ar8NW79h gwPACl8nOkrfhUPN7C7mNG2GrEsLrsiks8ucP0wMCA2MpJfoxZvCX6kPqN1lY6EHI3Yx ry9yYH9pSsCSsJ9nsqnY6uJz6JHnYTiTbt7V6ulXujg3dvDkab7AiXvE6VFTL4l1RRk4 Z6sLZyoHxWRJVrsvM87g9YWjH/7NdZ9ChOqXkTiENLnqFsdoGRTLMSb01ZSGu8lJGbeL Z3VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739312636; x=1739917436; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/zc2OVM5XY9gyqbnVO1o7VPq2IP1Z0aNrrnWGpKs/1M=; b=itK5oWovv29+UTKN4vX9ggOjxMOA/ihnj4fRdCKzONiN9gqcSqWZUi6+NoyVpjQ1p6 w3lNe3zuDYEP8EcKm0vFbzBK1s30jpU+ga1mloMtLFPBEYtTVToyehcjCdtqB5k2lSN3 +EXmEJ6wt17jJi33WwpjjJWaliPkdlVpEd02vBu2PVfAHKVBd0c+ZjiJNR5Y0z+vrHJb rFA4TdOATk1X4sdal98WHG5rx5fpmfrvRXN8QGtlLueoABURiqdlQoKAVBi4aJLsGbaO g4uc+k5r7sBNT3VZqsH9vDdm42u1dP2sPOmz2pNwOcvdix8qIZr4CDW7SRYBA6ocpLXG TDEg== X-Gm-Message-State: AOJu0YyadqVQPNqZBGLu3+su4QdcgQicQndgWoYmJB4z17Jnm2sM1Tai nJ+NWX3hpwRcrPm+sBefLPNNhgUgc8+z1QhqIAr+nJKKBeQeLuU+1w1YzQ== X-Gm-Gg: ASbGnctz4g7TPrazvCV6c0tKnCPPoKrwRaw7jb/zWP/ruMv7hu/NfUOfBDLpyt06LGf 7zO6gy7AQKNO9SnlwqWap+ssIz25Tbd+2loX8lDQ0SZsPG+C/Xhk9LxrpnA91i/eUGbLfEDBjN+ MSM8IcgsZXBpF1N/2/XnDy1aHw4y0G31x0FuEZIe4JUHByRH36gzASgFKffaYy38dCWF9Tv7SCV F/Tf1GXWswcEtg2lrpJ4ZEz0j6VqsE9V9FBq0ORU/FKGgysLhDqAqEf1XHkfJfA5FgX42MSJaM7 WfxqBXYMeyUF2s7wnnGeisoX X-Google-Smtp-Source: AGHT+IGOEXikU38Kc2F/X7hSd46iA6sjjpdaDKLtCOl/IJwY9zhLkiuN4H2AC60YidN8oh5jZdmCPw== X-Received: by 2002:a17:907:d1a:b0:ab7:f096:61da with SMTP id a640c23a62f3a-ab7f347a696mr68276966b.41.1739312636217; Tue, 11 Feb 2025 14:23:56 -0800 (PST) Received: from [192.168.0.50] ([79.119.240.253]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab7b393da3fsm614844866b.96.2025.02.11.14.23.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Feb 2025 14:23:55 -0800 (PST) Message-ID: <26c2ef1a-b382-4901-b286-d1b48d808900@gmail.com> Date: Wed, 12 Feb 2025 00:23:55 +0200 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 4/8] wifi: rtw88: Fix rtw_init_vht_cap() for RTL8814AU From: Bitterblue Smith To: "linux-wireless@vger.kernel.org" Cc: Ping-Ke Shih References: <21111380-5db6-4a72-ace9-f18b5bcd525c@gmail.com> Content-Language: en-US In-Reply-To: <21111380-5db6-4a72-ace9-f18b5bcd525c@gmail.com> Set the MCS maps and the highest rates according to the number of spatial streams the chip has. For RTL8814AU that is 3. Signed-off-by: Bitterblue Smith Acked-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtw88/main.c | 23 +++++++++-------------- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/drivers/net/wireless/realtek/rtw88/main.c b/drivers/net/wireless/realtek/rtw88/main.c index 3319bb5044c3..959f56a3cc1a 100644 --- a/drivers/net/wireless/realtek/rtw88/main.c +++ b/drivers/net/wireless/realtek/rtw88/main.c @@ -1596,8 +1596,9 @@ static void rtw_init_vht_cap(struct rtw_dev *rtwdev, struct ieee80211_sta_vht_cap *vht_cap) { struct rtw_efuse *efuse = &rtwdev->efuse; - u16 mcs_map; + u16 mcs_map = 0; __le16 highest; + int i; if (efuse->hw_cap.ptcl != EFUSE_HW_CAP_IGNORE && efuse->hw_cap.ptcl != EFUSE_HW_CAP_PTCL_VHT) @@ -1620,21 +1621,15 @@ static void rtw_init_vht_cap(struct rtw_dev *rtwdev, if (rtw_chip_has_rx_ldpc(rtwdev)) vht_cap->cap |= IEEE80211_VHT_CAP_RXLDPC; - mcs_map = IEEE80211_VHT_MCS_SUPPORT_0_9 << 0 | - IEEE80211_VHT_MCS_NOT_SUPPORTED << 4 | - IEEE80211_VHT_MCS_NOT_SUPPORTED << 6 | - IEEE80211_VHT_MCS_NOT_SUPPORTED << 8 | - IEEE80211_VHT_MCS_NOT_SUPPORTED << 10 | - IEEE80211_VHT_MCS_NOT_SUPPORTED << 12 | - IEEE80211_VHT_MCS_NOT_SUPPORTED << 14; - if (efuse->hw_cap.nss > 1) { - highest = cpu_to_le16(780); - mcs_map |= IEEE80211_VHT_MCS_SUPPORT_0_9 << 2; - } else { - highest = cpu_to_le16(390); - mcs_map |= IEEE80211_VHT_MCS_NOT_SUPPORTED << 2; + for (i = 0; i < 8; i++) { + if (i < efuse->hw_cap.nss) + mcs_map |= IEEE80211_VHT_MCS_SUPPORT_0_9 << (i * 2); + else + mcs_map |= IEEE80211_VHT_MCS_NOT_SUPPORTED << (i * 2); } + highest = cpu_to_le16(390 * efuse->hw_cap.nss); + vht_cap->vht_mcs.rx_mcs_map = cpu_to_le16(mcs_map); vht_cap->vht_mcs.tx_mcs_map = cpu_to_le16(mcs_map); vht_cap->vht_mcs.rx_highest = highest; From patchwork Tue Feb 11 22:24:33 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bitterblue Smith X-Patchwork-Id: 13970770 X-Patchwork-Delegate: pkshih@realtek.com Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AAD5C267AFB for ; Tue, 11 Feb 2025 22:24:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739312678; cv=none; b=YmvMh0P7CUauZ29tens/Do1SToeMtp7zu/MK9lvNLvad7ztzfjHFLIRdiqI50ATOmMNrmxo6t9s2oehW9gSVBix9WnYuCJsSMdpBUdiV2BX6uJaCSQtZzvG9AnmOyLu3E16Mb0u0fPOuutmlbElXjGl587/BQQsxIUICuZrwNuM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739312678; c=relaxed/simple; bh=nW0diVWDrTgynFFoF/DWdwzpmGDFT5GDzzdnTqg0lEI=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=mhaFTkCGWjPKXaZt8LpW473lIj1E1Ki9m0xo2LLWggq31/jiqvM7aNYXJDdl+rcUPRj9hacBPVVEMm5DAnnx81Lj6n+cZL0Lpw76YerLK4xCMZ4SYaY/hTPMdlDqoXFHX9lf0f/Rg600pbceDAqL97tMw6QX5IW5xg7D0lz/NRc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Lp9WE0ro; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Lp9WE0ro" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-ab2b29dfc65so933005566b.1 for ; Tue, 11 Feb 2025 14:24:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739312675; x=1739917475; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=xI6GjA/juggeNWyo3ngAzYep14tdluCQ5ZqWxQaJ1XU=; b=Lp9WE0roOrueN7aEHoGqLF8G9queePHd6FH10pFsxZzuH7TNoVcOX+zwQGZvL1+eQk 5uj/NztgsOc9ccvEFd5WTgx6ifQnCOi0XH9zGzyK7XVIJzQ4PNAcqesp3mKZ6pEb3IXS TQ4ZzCXceab5Ic91MM4V6236wqtA1HzxgzEYSJsyo99EnmQPu7Fel6evW78GdpxiNFZj H2b+4pwti1o7cmYSEBUYGJEZVqm/U5pAwPpl+Mpa1Qijx+S/P52siTGi502DyESKMUHj eKoDtOY40fRAyR+A39P+HApXS5bLcYkL7uhrpNmf0IvDFcH8qzqeD2reE8jm6UEyNrRI pt1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739312675; x=1739917475; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xI6GjA/juggeNWyo3ngAzYep14tdluCQ5ZqWxQaJ1XU=; b=Cz4JbHUBJI5Py36JkzW/Upp8S0C4kPbo1Legv2+b1PUsNJ53uU94Op3cs4kxlRHDKH 2YjTD30g3qL/YkKe8T8DYTcFLDxUdks/e+BCxb+STHjUzUMw675J9rybTyBL7eqNBSDK J1rMg4bsPKJF0fhWtI98iTbfL9yxp9ccDWz8rfUqrDuYzonDIdFd+cfHpqTcmfqpd+VX iYHPGBpHzeObc5JkNOHG+syrSx0nWJxTZRM2O7FNvSIwxxDSf391qaEGv4DHWA9wO7Uf yTLT0GuYhL3YsG6iNhPmW5ueixViGRwNT7HgKoZGMjvb7P3bbnob3bh9YJtOxlCEZeJn kb5w== X-Gm-Message-State: AOJu0YzOWDCsFPnLKBia8fmtvtbjETJg3YMgeYAWJB6tLaiW/DVTc3nh EE/AR0mdsSpAXwqnbsaISsAlhY4oqAdBCf9O0GKpiq+5zvx+/sPkdpkBvg== X-Gm-Gg: ASbGnctsHKRB7m1f4x8+FyhlKLomMwjPSOp7HsJcHinS5tdS1HRlziva2bTUVdJcCSd o6yKHWMsEJ5lBHAwvxbCcgF8cbk+Ry1i2iUa/fTAbdsk6UXNPvxpW/EYUOgmcqw51MZlaWPgC8Q a+urL84euMXtiZStf0yABiyUIy4Ro61ZeP2gwJ5AD/v01v/qK7sgpyj8c/3m55ZZfrn5Xfwh1pQ Q4aD3UcTMCIFsCD/eO0d+rJyv9iB006IaqqCAYtbnxqtHmN3BKukcX5giKI/Puw/hjtmzXHhga3 yAHQR6AkO1hmlYdQNPiw35Wq X-Google-Smtp-Source: AGHT+IE2u1+D934fYsTGACC0L5BYXvO9FXrp9In67SzP57232cJ3vRAfiS2RyniM/eYftUS4P7G4lA== X-Received: by 2002:a17:907:868a:b0:aae:fb7c:50df with SMTP id a640c23a62f3a-ab7f347c173mr58827666b.36.1739312674705; Tue, 11 Feb 2025 14:24:34 -0800 (PST) Received: from [192.168.0.50] ([79.119.240.253]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab7b12d5f49sm642234766b.73.2025.02.11.14.24.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Feb 2025 14:24:34 -0800 (PST) Message-ID: <222fe9d5-804c-4521-9983-fb0620414810@gmail.com> Date: Wed, 12 Feb 2025 00:24:33 +0200 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 5/8] wifi: rtw88: Fix rtw_rx_phy_stat() for RTL8814AU From: Bitterblue Smith To: "linux-wireless@vger.kernel.org" Cc: Ping-Ke Shih References: <21111380-5db6-4a72-ace9-f18b5bcd525c@gmail.com> Content-Language: en-US In-Reply-To: <21111380-5db6-4a72-ace9-f18b5bcd525c@gmail.com> Record statistics for the 3SS rates too. Signed-off-by: Bitterblue Smith Acked-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtw88/main.h | 7 +++++++ drivers/net/wireless/realtek/rtw88/rx.c | 6 ++++++ 2 files changed, 13 insertions(+) diff --git a/drivers/net/wireless/realtek/rtw88/main.h b/drivers/net/wireless/realtek/rtw88/main.h index 24ac749271cc..c15e0f55d09a 100644 --- a/drivers/net/wireless/realtek/rtw88/main.h +++ b/drivers/net/wireless/realtek/rtw88/main.h @@ -386,6 +386,9 @@ enum rtw_evm { RTW_EVM_1SS, RTW_EVM_2SS_A, RTW_EVM_2SS_B, + RTW_EVM_3SS_A, + RTW_EVM_3SS_B, + RTW_EVM_3SS_C, /* keep it last */ RTW_EVM_NUM }; @@ -403,6 +406,10 @@ enum rtw_snr { RTW_SNR_2SS_B, RTW_SNR_2SS_C, RTW_SNR_2SS_D, + RTW_SNR_3SS_A, + RTW_SNR_3SS_B, + RTW_SNR_3SS_C, + RTW_SNR_3SS_D, /* keep it last */ RTW_SNR_NUM }; diff --git a/drivers/net/wireless/realtek/rtw88/rx.c b/drivers/net/wireless/realtek/rtw88/rx.c index 90fc8a5fa89e..8b0afaaffaa0 100644 --- a/drivers/net/wireless/realtek/rtw88/rx.c +++ b/drivers/net/wireless/realtek/rtw88/rx.c @@ -73,6 +73,12 @@ static void rtw_rx_phy_stat(struct rtw_dev *rtwdev, rate_ss_evm = 2; evm_id = RTW_EVM_2SS_A; break; + case DESC_RATEMCS16...DESC_RATEMCS23: + case DESC_RATEVHT3SS_MCS0...DESC_RATEVHT3SS_MCS9: + rate_ss = 3; + rate_ss_evm = 3; + evm_id = RTW_EVM_3SS_A; + break; default: rtw_warn(rtwdev, "unknown pkt rate = %d\n", pkt_stat->rate); return; From patchwork Tue Feb 11 22:24:57 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bitterblue Smith X-Patchwork-Id: 13970771 X-Patchwork-Delegate: pkshih@realtek.com Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9ADA267714 for ; Tue, 11 Feb 2025 22:25:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739312703; cv=none; b=a6pJYZLUfsMujYus89MkrnIOksgGQ17CV52AnFn+ueXN/7UX+/he8TS4cIuhMVxpHPKB9rdaxyvBdHAlJrRF4KovJFlwE1WravhiXtrf8y7ocL4MYrIsUVLU+X5XAS9UvTY38k5gezUFYoGDOYJtkCet5JSje1lAhPGLbHmpmsY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739312703; c=relaxed/simple; bh=PiiQW0ijNoNFw8f147R0xemdYO5btmKopDfjR7WkyWY=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=qSbKxQXNtYAypWElMcVnJe/G5FlGN5fv1GUR9p1j8BwUdaYSgaTQNIUs1q3LI6cK9DWFtRSsCBCo2NLWm9JX5emRk5kOeI6HGHS4R1VM5zjus6WMIIe51C9fyA5h1PzSDSn6S+TN9w16rnhh7CfuCa0d7HdyuVlm94H54euye9M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FzHR1eJI; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FzHR1eJI" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-aaeec07b705so965449466b.2 for ; Tue, 11 Feb 2025 14:25:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739312700; x=1739917500; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=0Sht9ZoxvjV6jE0d1ZV54/qMwff58zRmJuZIirIf0Dw=; b=FzHR1eJI/81zAvYftWv+ACjVV08CDklSRJutK8FVTR/fP4rHlzwj5tuYSMQPnIO4My xTpUkavXLgsCBx4W3WrvNINxGOahtS/Q1+qLoTOuU5ZS9nvY3XLsSo4t9k3kQdf1D7Q+ 4De7W0QK6FCNRWky13+OsAABsXM2SqxJuXl3RIlu4aGtHgVzwJFrsklsIwRi6WuHI98z OcLJPIbRdpxHuv5wjYpjHBTztSg9et5xyrnO0vTKqsgKNBJaSmMevEi0+FhYbBnzV3RF j6Fah1VqAd8RNIBjvKIQqRtpowaY/1H8crsLx8HS4SYtn4uV5PXUgx+RaW4BLG6SKolN o3EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739312700; x=1739917500; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0Sht9ZoxvjV6jE0d1ZV54/qMwff58zRmJuZIirIf0Dw=; b=PKxRZtmvDkfpq5jT9CLAfKrnto6cbOkbMPFUrpcjPSpc3ZuuCj565nSM0Z2QYN0TME +USFi8bpGX81E/wHEbdQFS3lpG7Cs+eeDN52crxAvLC7vMgP6jr6ze9+Ml2jPY2QPPrN m0ayp1LwCX8xjgbcLFZc/c/pb6XiwEHDvlG+kUwoqYE5HPiTyegmAKdusPctTkpEEhcY qdv7NrC2ClhfSe0iWYnvREYnvRi8zV6kCdSG9ZPq5j2nsm/WAFNnHcKmDLhaLak88Tlk NxC4D/jdv07bqSkb6D/mmckIjuWK9z8xnAh7nnmB4u71gz3Xu6839pm8rgtMgzP7HyaJ TeMg== X-Gm-Message-State: AOJu0YwGqjvZPAZvdQb8NpTwNnqYTuEYurTtTFjUVClLjmIAbOT5PTOe yeB2NvlDnfPOC72XdOoOQ9Gw8EjRX1v5FAU3eAd6DfVFsA4CNPh65iflyQ== X-Gm-Gg: ASbGncvZ1LQWVji/0Zg4CKfbbrpEUBoisjmpcX1e7z6Ir4lNGD6qnINTWxWmsOtqGy9 zam8/74plCkuoCPBpLkaIWKMM3vSzV1iX+s5EKa+XTSJs766bJrvNTeXuW/3CAtSRwhlVcN85ou Gf1jaqW6KyowOCYoDZr6LlwevbJm1G1v3s7whYi4wh9bHM275iEQIl2ZvS+hjal9JJ+kUuEVcBS PVhOliBoz4OozxRYveHOg2zQvZjDHFwFqBimG++tbvCKQilcF61cYmdWuvuIZAcPf3wg39rDp/9 gBBIOwqEYg+/pHtO3T5XRgPY X-Google-Smtp-Source: AGHT+IE/Vlt1lRVFHXw361r8UbENYfVmq0mOljQ8fdbF9Wr7rEC5WqPCRi3RUBwK4DyiE/q4ILQBlQ== X-Received: by 2002:a17:907:d410:b0:ab2:faed:f180 with SMTP id a640c23a62f3a-ab7f33daf6amr52989166b.33.1739312699845; Tue, 11 Feb 2025 14:24:59 -0800 (PST) Received: from [192.168.0.50] ([79.119.240.253]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab7ceae3a3bsm354220366b.129.2025.02.11.14.24.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Feb 2025 14:24:59 -0800 (PST) Message-ID: <6d04c43c-1d40-46ec-a569-1b19a2aaa59c@gmail.com> Date: Wed, 12 Feb 2025 00:24:57 +0200 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 6/8] wifi: rtw88: Extend rtw_phy_config_swing_table() for RTL8814AU From: Bitterblue Smith To: "linux-wireless@vger.kernel.org" Cc: Ping-Ke Shih References: <21111380-5db6-4a72-ace9-f18b5bcd525c@gmail.com> Content-Language: en-US In-Reply-To: <21111380-5db6-4a72-ace9-f18b5bcd525c@gmail.com> Select the TX power tracking tables for RF paths C and D as well. Signed-off-by: Bitterblue Smith Acked-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtw88/phy.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/drivers/net/wireless/realtek/rtw88/phy.c b/drivers/net/wireless/realtek/rtw88/phy.c index b487457d2215..55be0d8e0c28 100644 --- a/drivers/net/wireless/realtek/rtw88/phy.c +++ b/drivers/net/wireless/realtek/rtw88/phy.c @@ -2458,32 +2458,56 @@ void rtw_phy_config_swing_table(struct rtw_dev *rtwdev, swing_table->n[RF_PATH_A] = tbl->pwrtrk_2g_ccka_n; swing_table->p[RF_PATH_B] = tbl->pwrtrk_2g_cckb_p; swing_table->n[RF_PATH_B] = tbl->pwrtrk_2g_cckb_n; + swing_table->p[RF_PATH_C] = tbl->pwrtrk_2g_cckc_p; + swing_table->n[RF_PATH_C] = tbl->pwrtrk_2g_cckc_n; + swing_table->p[RF_PATH_D] = tbl->pwrtrk_2g_cckd_p; + swing_table->n[RF_PATH_D] = tbl->pwrtrk_2g_cckd_n; } else { swing_table->p[RF_PATH_A] = tbl->pwrtrk_2ga_p; swing_table->n[RF_PATH_A] = tbl->pwrtrk_2ga_n; swing_table->p[RF_PATH_B] = tbl->pwrtrk_2gb_p; swing_table->n[RF_PATH_B] = tbl->pwrtrk_2gb_n; + swing_table->p[RF_PATH_C] = tbl->pwrtrk_2gc_p; + swing_table->n[RF_PATH_C] = tbl->pwrtrk_2gc_n; + swing_table->p[RF_PATH_D] = tbl->pwrtrk_2gd_p; + swing_table->n[RF_PATH_D] = tbl->pwrtrk_2gd_n; } } else if (IS_CH_5G_BAND_1(channel) || IS_CH_5G_BAND_2(channel)) { swing_table->p[RF_PATH_A] = tbl->pwrtrk_5ga_p[RTW_PWR_TRK_5G_1]; swing_table->n[RF_PATH_A] = tbl->pwrtrk_5ga_n[RTW_PWR_TRK_5G_1]; swing_table->p[RF_PATH_B] = tbl->pwrtrk_5gb_p[RTW_PWR_TRK_5G_1]; swing_table->n[RF_PATH_B] = tbl->pwrtrk_5gb_n[RTW_PWR_TRK_5G_1]; + swing_table->p[RF_PATH_C] = tbl->pwrtrk_5gc_p[RTW_PWR_TRK_5G_1]; + swing_table->n[RF_PATH_C] = tbl->pwrtrk_5gc_n[RTW_PWR_TRK_5G_1]; + swing_table->p[RF_PATH_D] = tbl->pwrtrk_5gd_p[RTW_PWR_TRK_5G_1]; + swing_table->n[RF_PATH_D] = tbl->pwrtrk_5gd_n[RTW_PWR_TRK_5G_1]; } else if (IS_CH_5G_BAND_3(channel)) { swing_table->p[RF_PATH_A] = tbl->pwrtrk_5ga_p[RTW_PWR_TRK_5G_2]; swing_table->n[RF_PATH_A] = tbl->pwrtrk_5ga_n[RTW_PWR_TRK_5G_2]; swing_table->p[RF_PATH_B] = tbl->pwrtrk_5gb_p[RTW_PWR_TRK_5G_2]; swing_table->n[RF_PATH_B] = tbl->pwrtrk_5gb_n[RTW_PWR_TRK_5G_2]; + swing_table->p[RF_PATH_C] = tbl->pwrtrk_5gc_p[RTW_PWR_TRK_5G_2]; + swing_table->n[RF_PATH_C] = tbl->pwrtrk_5gc_n[RTW_PWR_TRK_5G_2]; + swing_table->p[RF_PATH_D] = tbl->pwrtrk_5gd_p[RTW_PWR_TRK_5G_2]; + swing_table->n[RF_PATH_D] = tbl->pwrtrk_5gd_n[RTW_PWR_TRK_5G_2]; } else if (IS_CH_5G_BAND_4(channel)) { swing_table->p[RF_PATH_A] = tbl->pwrtrk_5ga_p[RTW_PWR_TRK_5G_3]; swing_table->n[RF_PATH_A] = tbl->pwrtrk_5ga_n[RTW_PWR_TRK_5G_3]; swing_table->p[RF_PATH_B] = tbl->pwrtrk_5gb_p[RTW_PWR_TRK_5G_3]; swing_table->n[RF_PATH_B] = tbl->pwrtrk_5gb_n[RTW_PWR_TRK_5G_3]; + swing_table->p[RF_PATH_C] = tbl->pwrtrk_5gc_p[RTW_PWR_TRK_5G_3]; + swing_table->n[RF_PATH_C] = tbl->pwrtrk_5gc_n[RTW_PWR_TRK_5G_3]; + swing_table->p[RF_PATH_D] = tbl->pwrtrk_5gd_p[RTW_PWR_TRK_5G_3]; + swing_table->n[RF_PATH_D] = tbl->pwrtrk_5gd_n[RTW_PWR_TRK_5G_3]; } else { swing_table->p[RF_PATH_A] = tbl->pwrtrk_2ga_p; swing_table->n[RF_PATH_A] = tbl->pwrtrk_2ga_n; swing_table->p[RF_PATH_B] = tbl->pwrtrk_2gb_p; swing_table->n[RF_PATH_B] = tbl->pwrtrk_2gb_n; + swing_table->p[RF_PATH_C] = tbl->pwrtrk_2gc_p; + swing_table->n[RF_PATH_C] = tbl->pwrtrk_2gc_n; + swing_table->p[RF_PATH_D] = tbl->pwrtrk_2gd_p; + swing_table->n[RF_PATH_D] = tbl->pwrtrk_2gd_n; } } EXPORT_SYMBOL(rtw_phy_config_swing_table); From patchwork Tue Feb 11 22:25:32 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bitterblue Smith X-Patchwork-Id: 13970772 X-Patchwork-Delegate: pkshih@realtek.com Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9AB1C268FDB for ; Tue, 11 Feb 2025 22:25:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739312737; cv=none; b=f9jXLuBMaFwklYcNs3Eo/ouoN7RPomJu0PwDQl5w207+Z6tOAqxfYNiBgCbqzDM8d6PMcIBsPGbWk9xjmCIV0eBnvpQKJOWkx22sp+dZ44nQ61GD6XU0m2SG8oWzZC1/DENiTP3E4YJyxBy7exMxk2oIo195l8hHaqGz2eAdylQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739312737; c=relaxed/simple; bh=q39GKe54wWsixypymdEc02ltQC77Y4eY9LP9seBWqdM=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=OCHYMXA/ppmgg/nE/N/dMOk+MqCLPebh+Z7U0c+u40WnlKLTEnfemEAU5WKCEOUxut9y+yn4XiA9x8c+BZ788a7/zv+kjD7jXI8BcjYSJ0EG6TfjuFIsyC1VeOLkXLRlhxQtT0SHHzcY926ZAH8skxk2pcC8qWyNUsnOsFxJEXk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DZBmDjcg; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DZBmDjcg" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-ab2b29dfc65so933113566b.1 for ; Tue, 11 Feb 2025 14:25:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739312734; x=1739917534; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=bF2VIE1a4aWIniUoomxj4NoiwWg/dsC1RN0XrnuE7Fc=; b=DZBmDjcgx2W+lFnSXlRP9mEe2ZAuF63D4s224Gu/R1Ou//5HDI8OwqQY+KNnm6+x8s KVW0WK6TjwzJ3TvCsbI3kp1wjxIb++kU3M1bE6Y24Bu7X4fizcSLS763IhkJPWDsoS2F KswV5hnDKuH193RXDipRU5uaqtRCGiXFTR72EDwD9z1X48BX0YkijUS4iJD85YeAw78j fdUC6G+fBbJ/W9+JseyzJbeBq6WaPd0y/uO8a6v6WDOdw0G3UreytN39FYAaNJDloQQL IIBZuNw5wrBW12sS2s2S/gmKUTZ6etD6rdfDcuZuKclwnCIU9zrnzt9M35lzeDmVTben KNfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739312734; x=1739917534; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bF2VIE1a4aWIniUoomxj4NoiwWg/dsC1RN0XrnuE7Fc=; b=GYyoapoeM5X7CF5V/vKfRsjeYHT7EpkeAnxD1msdUYtdKQ3a3G4aYiNdWNoDqdVBuS jwu4dJChvyHrck4x1ABSU3h1WMz4uP31bA/Xp6jyTJUZNosEsg3bUXLO4W1MYfXo85qW Kxom4q6NndFMIxjIUqjS03qbs199Xz29pMeBXrZqj/hdZ1NevT2lMxFM5ToXH3t5rUzO Nh/zJp+L7Ln5MBz7ll8P+rHCLPPWNduhDHeVqEE54mk/i4YCizCHgno0x+OrDBXR8kU2 98EXtpvdcLJxjCrxb8Z+rTrmwIKB57F1390qNJju0n53AJ/vSS4ESf7q8NNoVlnm+03m I3rQ== X-Gm-Message-State: AOJu0Ywa8t+CSVWCNipqwlt9pEBlhlvKQBv81NvWPL7jNMdjk93KGDrE b1V5iAw+vSuiOGTp5bZLk0CLjun82ZigRJXP0QUxQK1wxY6gCKNvX90m9Q== X-Gm-Gg: ASbGncuL1Y6MLNNdDaxD9XunLrN6+UBN/w1eAt5X2MgK8hfcbPvRMdeMvg7VnX5x+dr Aa95Bl3j2KwehEEG8Zwkk1wX4qcynfNPOj3CbrFqkdveF7UyQByAfZBPlK48mzsrQikdRInccjw BYvGi+D/pinCPEgdmPee68CQVJjRpHwg2roXz0fZ8H/RkhPx+0qyprunQAzC2zk3Hs+mpbWvsjp OYRFhPiBHhYTvxvdwLMIRJ2IqK7ZRJ96WhVfU66IXIoK5yF10o2uTHTlkEuJ6ZFvoyaWcUlqigG Hp8Q7VpDtbVniOcJWqzTgsaY X-Google-Smtp-Source: AGHT+IGTRJ9+6u/xsS4CxSsgFiudc9me6E3ZfilGOo0bsJtb88NNDYpdb7DWepxxFJCetzRjZoAmJg== X-Received: by 2002:a17:907:d1a:b0:ab7:83c2:bdbf with SMTP id a640c23a62f3a-ab7f347aa61mr66847566b.41.1739312733480; Tue, 11 Feb 2025 14:25:33 -0800 (PST) Received: from [192.168.0.50] ([79.119.240.253]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab7e9853560sm136911966b.111.2025.02.11.14.25.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Feb 2025 14:25:33 -0800 (PST) Message-ID: <2af9cee8-1b4e-4d97-bbf6-4f793005f910@gmail.com> Date: Wed, 12 Feb 2025 00:25:32 +0200 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 7/8] wifi: rtw88: Extend rtw_debugfs_get_phy_info() for RTL8814AU From: Bitterblue Smith To: "linux-wireless@vger.kernel.org" Cc: Ping-Ke Shih References: <21111380-5db6-4a72-ace9-f18b5bcd525c@gmail.com> Content-Language: en-US In-Reply-To: <21111380-5db6-4a72-ace9-f18b5bcd525c@gmail.com> Print information about the 3rd and 4th RF paths and about the 3rd spatial stream. Also, fix a small bug: don't show the average SNR and EVM for the OFDM and HT/VHT rates when the rate is actually CCK 11M. Signed-off-by: Bitterblue Smith Acked-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtw88/debug.c | 37 +++++++++++++++------- 1 file changed, 26 insertions(+), 11 deletions(-) diff --git a/drivers/net/wireless/realtek/rtw88/debug.c b/drivers/net/wireless/realtek/rtw88/debug.c index 364ec0436d0f..1adb03d1210a 100644 --- a/drivers/net/wireless/realtek/rtw88/debug.c +++ b/drivers/net/wireless/realtek/rtw88/debug.c @@ -654,10 +654,10 @@ static void rtw_print_rate(struct seq_file *m, u8 rate) case DESC_RATE6M...DESC_RATE54M: rtw_print_ofdm_rate_txt(m, rate); break; - case DESC_RATEMCS0...DESC_RATEMCS15: + case DESC_RATEMCS0...DESC_RATEMCS31: rtw_print_ht_rate_txt(m, rate); break; - case DESC_RATEVHT1SS_MCS0...DESC_RATEVHT2SS_MCS9: + case DESC_RATEVHT1SS_MCS0...DESC_RATEVHT4SS_MCS9: rtw_print_vht_rate_txt(m, rate); break; default: @@ -849,20 +849,28 @@ static int rtw_debugfs_get_phy_info(struct seq_file *m, void *v) last_cnt->num_qry_pkt[rate_id + 9]); } - seq_printf(m, "[RSSI(dBm)] = {%d, %d}\n", + seq_printf(m, "[RSSI(dBm)] = {%d, %d, %d, %d}\n", dm_info->rssi[RF_PATH_A] - 100, - dm_info->rssi[RF_PATH_B] - 100); - seq_printf(m, "[Rx EVM(dB)] = {-%d, -%d}\n", + dm_info->rssi[RF_PATH_B] - 100, + dm_info->rssi[RF_PATH_C] - 100, + dm_info->rssi[RF_PATH_D] - 100); + seq_printf(m, "[Rx EVM(dB)] = {-%d, -%d, -%d, -%d}\n", dm_info->rx_evm_dbm[RF_PATH_A], - dm_info->rx_evm_dbm[RF_PATH_B]); - seq_printf(m, "[Rx SNR] = {%d, %d}\n", + dm_info->rx_evm_dbm[RF_PATH_B], + dm_info->rx_evm_dbm[RF_PATH_C], + dm_info->rx_evm_dbm[RF_PATH_D]); + seq_printf(m, "[Rx SNR] = {%d, %d, %d, %d}\n", dm_info->rx_snr[RF_PATH_A], - dm_info->rx_snr[RF_PATH_B]); - seq_printf(m, "[CFO_tail(KHz)] = {%d, %d}\n", + dm_info->rx_snr[RF_PATH_B], + dm_info->rx_snr[RF_PATH_C], + dm_info->rx_snr[RF_PATH_D]); + seq_printf(m, "[CFO_tail(KHz)] = {%d, %d, %d, %d}\n", dm_info->cfo_tail[RF_PATH_A], - dm_info->cfo_tail[RF_PATH_B]); + dm_info->cfo_tail[RF_PATH_B], + dm_info->cfo_tail[RF_PATH_C], + dm_info->cfo_tail[RF_PATH_D]); - if (dm_info->curr_rx_rate >= DESC_RATE11M) { + if (dm_info->curr_rx_rate >= DESC_RATE6M) { seq_puts(m, "[Rx Average Status]:\n"); seq_printf(m, " * OFDM, EVM: {-%d}, SNR: {%d}\n", (u8)ewma_evm_read(&ewma_evm[RTW_EVM_OFDM]), @@ -875,6 +883,13 @@ static int rtw_debugfs_get_phy_info(struct seq_file *m, void *v) (u8)ewma_evm_read(&ewma_evm[RTW_EVM_2SS_B]), (u8)ewma_snr_read(&ewma_snr[RTW_SNR_2SS_A]), (u8)ewma_snr_read(&ewma_snr[RTW_SNR_2SS_B])); + seq_printf(m, " * 3SS, EVM: {-%d, -%d, -%d}, SNR: {%d, %d, %d}\n", + (u8)ewma_evm_read(&ewma_evm[RTW_EVM_3SS_A]), + (u8)ewma_evm_read(&ewma_evm[RTW_EVM_3SS_B]), + (u8)ewma_evm_read(&ewma_evm[RTW_EVM_3SS_C]), + (u8)ewma_snr_read(&ewma_snr[RTW_SNR_3SS_A]), + (u8)ewma_snr_read(&ewma_snr[RTW_SNR_3SS_B]), + (u8)ewma_snr_read(&ewma_snr[RTW_SNR_3SS_C])); } seq_puts(m, "[Rx Counter]:\n"); From patchwork Tue Feb 11 22:26:11 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bitterblue Smith X-Patchwork-Id: 13970773 X-Patchwork-Delegate: pkshih@realtek.com Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7608267AFB for ; Tue, 11 Feb 2025 22:26:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739312775; cv=none; b=VSKu52C2QVqhB7AfLoNoLexRHNLlY6HWy6yBpjorBArx1wt0acg1YAgUbsYIKwX3KHJXkBlhlqT7YCoiT9YyGKJW3NkwavK7JryJCjMTMfz+0Y6vSZVtbo5iKXdN9iLntvErx0oZgNeJ6Mb3OpSe2IQyzGeXYCeUX+cGktIl8YU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739312775; c=relaxed/simple; bh=WMQZ4G6KGSATIk2HAhb3UOeSAY7+nKsmS0IBKr1z/4Y=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=eKb0mvgsvuoos2sUHz+2znqXvURoQWKnjqEkr4neqk1JSyXF7PcmLww4u5MWfGP0Jl0ffuWjRJkIwOdrgaRcUan2Cw41flRHeVdMuWzoJ4z9XqbFLeyv7PuCyXxUyCj0jdvVGWidGhHxrScTgOC/oOtTrhHB0QkQB1MGSp76veA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gw7Es3nj; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gw7Es3nj" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-ab7e9254bb6so133668866b.1 for ; Tue, 11 Feb 2025 14:26:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739312772; x=1739917572; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=0fTULECwBuzzTX7pSLnSQoHxx4aAeFdJAs05MrYoVJg=; b=gw7Es3njJTjkjbjDLCjr88g0nFCfOKu23LCIGnrijaS3yrWQywPU+MyiqSIc3VJke9 Viv8QRQtTdXL6kKz9qKYZp7fUN74/eEj9uhzA3yZuS7GKG8NC33rps2+zyuJ6PbZaZxw 3sa7a+f9o1T/7SRd/oIsaFUp9EeytWEC5Hoo3nLYKZRzygGaT3yoMiTbEml/aMKDIbyp BdB1F0d/xgGR7IO6lqYrqhK3MaZ7BaylxLxJt2Nrgo0VAUKUlYWrY2ZjayVlonxqrZ95 ZOqviYKmdvDtwWaQpUNdFOfIvPZOQgBy97hkQ6OCdLXkDZrrS2umQ3qirw//QWbN1rrx wg2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739312772; x=1739917572; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0fTULECwBuzzTX7pSLnSQoHxx4aAeFdJAs05MrYoVJg=; b=ZJdD7/LrYt+jDVhIG4C+2oHOzRry8EMPd0+thaiDDhmPQhrcZU3E3IGt0N0urI+JiV rIUXhZGuR5ok7QsbrveKdb7JwMZHFF4aCWupHo7t5LH9WaNtT+1I+s8U2F+Fy5q8DqtW sYATF0NXustSMeJfXgwtANJnzMhAmtVMEEqPSD8KdqjE9JOaWThxRa0RsFJpGLrpw3b6 tLNIneXOKFj8G9r8MWc5iczf9hymky2ydmbagqHHfKFX/CH9hxmKvLnaxEdQMAYkIJ9k t+Ng7tf/ZCLWaBKMJ+Hs5A6cRCHzIxxl/om1CiNyCVcK+eJp5J+CgRIepno9lr0LyxNt N4Rw== X-Gm-Message-State: AOJu0Yy14y1MicOytyZ5zVu9Gi9nW4G/abarMxyH0AcbYPqaZrIfZbVQ JpmvawkO7CFFFKGmLUeEpxO15L7+FbHdlINjHHudFGPmGvuGZJ/fZXq0KQ== X-Gm-Gg: ASbGncs5PpVmlLyCoO7sElSuZiIxDreVSo7yvNZpjrxnzkBri8lJvBIeOn+IwhNcXx7 fYy2C1rgJRy1T7qREzRUK3edIJhk9N+62NUFSpHld6NOFhZoaeOC/4CVSOwpyk7FBoEqtN6QWrY qR8r/Ng/weJSmgmlesNz/g54F1ULSpBYsuJWk3Kad1dbKExs4dZvztAAn8cT4RDJQy0PiuyP+4F iPAEX7wRqecg24juW8BZbBx2o24CYxXqJ12proBIW58N5xlNmGwufiaHnQccw7C/qHr8j447xkA WEU8La7ZWsgp6SCV72YG/I8L X-Google-Smtp-Source: AGHT+IF4CuNeb/uBtwZKMJf0n2wp8/3yvZWxKaaJzIwsdFFCFn4EmKbYIKLaLSl7tPUk/bHJ0/ZqJQ== X-Received: by 2002:a17:907:94c5:b0:aac:619:e914 with SMTP id a640c23a62f3a-ab7f33b480amr77530666b.16.1739312772000; Tue, 11 Feb 2025 14:26:12 -0800 (PST) Received: from [192.168.0.50] ([79.119.240.253]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab7e386014dsm188617966b.55.2025.02.11.14.26.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Feb 2025 14:26:11 -0800 (PST) Message-ID: <6bb6443a-3e2a-4cd4-83b9-34d2eb235654@gmail.com> Date: Wed, 12 Feb 2025 00:26:11 +0200 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 8/8] wifi: rtw88: Extend rtw_debugfs_get_tx_pwr_tbl() for RTL8814AU From: Bitterblue Smith To: "linux-wireless@vger.kernel.org" Cc: Ping-Ke Shih References: <21111380-5db6-4a72-ace9-f18b5bcd525c@gmail.com> Content-Language: en-US In-Reply-To: <21111380-5db6-4a72-ace9-f18b5bcd525c@gmail.com> Make it print the TX power details for RF paths C and D, and for 3SS and 4SS rates. Signed-off-by: Bitterblue Smith --- drivers/net/wireless/realtek/rtw88/debug.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/net/wireless/realtek/rtw88/debug.c b/drivers/net/wireless/realtek/rtw88/debug.c index 1adb03d1210a..0efb5c19b90e 100644 --- a/drivers/net/wireless/realtek/rtw88/debug.c +++ b/drivers/net/wireless/realtek/rtw88/debug.c @@ -708,20 +708,14 @@ static int rtw_debugfs_get_tx_pwr_tbl(struct seq_file *m, void *v) "path", "rate", "pwr", "base", "byr", "lmt", "sar", "rem"); mutex_lock(&hal->tx_power_mutex); - for (path = RF_PATH_A; path <= RF_PATH_B; path++) { + for (path = RF_PATH_A; path <= RF_PATH_D; path++) { /* there is no CCK rates used in 5G */ if (hal->current_band_type == RTW_BAND_5G) rate = DESC_RATE6M; else rate = DESC_RATE1M; - /* now, not support vht 3ss and vht 4ss*/ - for (; rate <= DESC_RATEVHT2SS_MCS9; rate++) { - /* now, not support ht 3ss and ht 4ss*/ - if (rate > DESC_RATEMCS15 && - rate < DESC_RATEVHT1SS_MCS0) - continue; - + for (; rate <= DESC_RATEVHT4SS_MCS9; rate++) { rtw_get_tx_power_params(rtwdev, path, rate, bw, ch, regd, &pwr_param);