From patchwork Wed Feb 12 02:06:27 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Shengken.Lin@amlogic.com" X-Patchwork-Id: 13970935 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D6C9C021A0 for ; Wed, 12 Feb 2025 02:06:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DAB656B0082; Tue, 11 Feb 2025 21:06:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D5B526B0083; Tue, 11 Feb 2025 21:06:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C49EF6B0085; Tue, 11 Feb 2025 21:06:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A92A26B0082 for ; Tue, 11 Feb 2025 21:06:38 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 64684A13C5 for ; Wed, 12 Feb 2025 02:06:38 +0000 (UTC) X-FDA: 83109653676.06.E5E3C58 Received: from mail-sh.amlogic.com (unknown [58.32.228.46]) by imf30.hostedemail.com (Postfix) with ESMTP id 9804780007 for ; Wed, 12 Feb 2025 02:06:36 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=amlogic.com; spf=pass (imf30.hostedemail.com: domain of Shengken.Lin@amlogic.com designates 58.32.228.46 as permitted sender) smtp.mailfrom=Shengken.Lin@amlogic.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739325996; a=rsa-sha256; cv=none; b=BxyieT6GsEpUrOTdiKGTWglOBh0Lz9oG8pYYZ0m98mgxIXZ9nNDlgPPjd27TcCSIsASDPR B2cq70kff1IldZXcPvmPAku+LI0+xO5Fm54Lurb0hMFFc0f0ljZQwSPKunQOmUgTtT5BJo LALiTPdkqDuSz6Ff/uIioDoelGnaxIg= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=amlogic.com; spf=pass (imf30.hostedemail.com: domain of Shengken.Lin@amlogic.com designates 58.32.228.46 as permitted sender) smtp.mailfrom=Shengken.Lin@amlogic.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739325996; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references; bh=WY0x1LZ8QOPyGUZ/XlxwyEcxkGKlIJMmrW4skRdy/Js=; b=t91T+Xf+LVhp30rzGkw3v9vUfJ9s5c0CME97X5ngb3Zvi3AvLi+E9pvFXRopqEZQMBS+VW nmLP0O1wYdU1h7ZBQ6dzDFkCU+s9lO73Fq80IEhosUqUtRHq2hUwOxvsDtDKNuO1DbNyUs EQ/i/cKBWMpYEgA1PO+X3L4ZUr9ij1k= Received: from walle01-sz.amlogic.com (10.28.11.73) by mail-sh.amlogic.com (10.18.11.5) with Microsoft SMTP Server id 15.1.2507.39; Wed, 12 Feb 2025 10:06:32 +0800 From: Shengken Lin To: CC: , , Shengken Lin Subject: [PATCH] mm: Remove redundant PageMemcgKmem(page) call Date: Wed, 12 Feb 2025 10:06:27 +0800 Message-ID: <20250212020627.3461237-1-shengken.lin@amlogic.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-Originating-IP: [10.28.11.73] X-Rspam-User: X-Rspamd-Queue-Id: 9804780007 X-Rspamd-Server: rspam12 X-Stat-Signature: cpx7jj67nmdf3h3nsp8uxq5fhe9m6gjj X-HE-Tag: 1739325996-435561 X-HE-Meta: U2FsdGVkX19NXQZpaYqCagglsYM7TnuopeHsjWHs9nj45xaqa9OqHsa8v7Dn3wzUSg6QaGa68Y221HowkaCjM/Ij4pzPWcyUyI3A3lv3G21X4aHhY9yrp7WiVW0VBmQHbQh2yJRX76ZnQArDI5BIW3ue3CSAK6ML2fv4yclqhszvx0V+xliT0e7Cf3M+Mw9AV8NtW1u1GhToishsaQUr8bV6Du9i6UiR0SuAEK/pWEW1U/D6QjBzfMAJ5Aqh0no/l1hn9OP5uXdxUTiDt1eD8tWxAnQrw049ZdjtYv1sR/2wyCPk0M4Swo7B1G4VjLUBo26LL8J5Zlm21tJ0h4yS57WQLcnnUfPj6FrY5LoKfQ9+QjQIkuhmM1NEOxEiYo46URdfqVz2QsJrTz91TxKgEqKUbTVW5CbyHg6xKTMSqUV27KGuad+keD5JaZ4ekMsS4EGIBjrgZW80Ophiw7vKEXmcpqZEWM3v7FCHmmmncxfSOKd6LUlokWJX8ncI9f7ToAE9P6vaFPoQEf5QtiBE4KbzAcUvHcSXsy5VYYF1lF1/IwI6RcmOsNdPselSQkqqEb8EoXriFBvrLw6rRp/Fp5Uye/Jn4OC5XR/b99kwecBy762OAvamqMQwzbWn5/QeDU8zv98NI57LV0Mr1jWWrYY6lEX0foMOHjuyyaVLgnRSD41wl3kQ0Qtcep4rOXVV4vhxsleQl/10MjdlCyeM2XeheVNtfE0imIgXplg6/vawkXHbarYgrUBFBAUId7ciO3eDrW2ccp1qwiXQuGvuqq7dIoD9SjCVt57+FtXdG0bny2n2GbAECygHZvTEguHBm2ksv9maHT288rpU4b9dxelmGxtHLZTTm+ilPz+heJZpzBwOAnAT9mLY5S8NHdSj+ZBqN5XttbGxEYJNyNYT0FxU4y7f1k6bVFRtxo4kV3d9I8r+kLMfZcyzJYhCFFD+NO23j7OAoBUVyRqVZM0 MCfJSba8 t0V9B/dpFN5MoDCxgCFVS9lUogAJRFM8M5CfI/K2sNdm2DCw17iY6X7/1H9XIH+zBY6ZR9AyoAoBWVWf9MufRy7sj2wbNthb/OKm5wIde3CIKJoKnKaXmYsVFa+7/oE8opZkjVQV6xkslKXyRFhV2qPHNnv5DXEKW/ANucGHGd7yJimKbX3+rSIld5SFzlaQ/xWbyXstXH2cKV2HhpL9zq2kzxmjS/WmNv4/1s4U5AhyHvluUz/3Wb3kokQFWRd2B7/4WxisO0wlX/yxizt1hLlRjGeTtsDCi0ssHxFPw7PnheCpB8CfXjApfMg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The function of PageMemcgKmem(page) is the same as that of folio_memcg_kmem(folio). Since __memcg_kmem_uncharge_page already uses folio_memcg_kmem to check if a folio has been uncharged, calling PageMemcgKmem(page) before __memcg_kmem_uncharge_page is redundant. Signed-off-by: Shengken Lin --- mm/page_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.34.1 diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 579789600a3c..5a76760de495 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -1055,7 +1055,7 @@ __always_inline bool free_pages_prepare(struct page *page, trace_mm_page_free(page, order); kmsan_free_page(page, order); - if (memcg_kmem_online() && PageMemcgKmem(page)) + if (memcg_kmem_online()) __memcg_kmem_uncharge_page(page, order); /*