From patchwork Wed Feb 12 10:02:01 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Aditya Garg X-Patchwork-Id: 13971507 X-Patchwork-Delegate: jikos@jikos.cz Received: from MA0PR01CU009.outbound.protection.outlook.com (mail-southindiaazolkn19010011.outbound.protection.outlook.com [52.103.67.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C82D205E1B; Wed, 12 Feb 2025 10:02:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.103.67.11 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739354534; cv=fail; b=EeeE3AYwadxOUYCat5clyEyDqex1BgsVulN28FD1fynwwJEZstpNLH3m+6MwbTZBWHPH91WoapFkgXtDTHXtPPGOh4rgG88yjU6/hmdimsL0nOaJMni6BtSX6OELcpWFgKG/JqthEj0QXTnpMWYa8L4A/A1myQSN2ZnI/VIloR4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739354534; c=relaxed/simple; bh=HqwQ/rPQquzdarvfs9qLkJcGq/qtWqi5DTRuO4yt0+g=; h=From:To:CC:Subject:Date:Message-ID:Content-Type:MIME-Version; b=kN6rCM2mI2iGxZyG70b1octnujLKFNBYTNNdAvdWnkDIbWq9fbmBrivr15g/kJeRzVcUKGq48rg82ZhLE7kYFPe70tUtBGfwXtfLZGqdqZUm7+sVx3hYrrJjw9AG8VSnnh8gfG75WPCby1zlK/EBTs/URk+7zx23yjvC+iCcgMw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=live.com; spf=pass smtp.mailfrom=live.com; dkim=pass (2048-bit key) header.d=live.com header.i=@live.com header.b=l5A1RZ//; arc=fail smtp.client-ip=52.103.67.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=live.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=live.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=live.com header.i=@live.com header.b="l5A1RZ//" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xQOtwutFI/ys+Y+l1qbw4hR/RcyaP4zQ6yestwbPgQTV6sNOh7Ouio5Ly8mVFBWzGDGWSPRBThodhCjc8S3Ui0tLl3nKJMD8y44dPTVturY997RHpU2hKkqZCA/vlBNHpBP5BbVThSwmMgjqL9YjswAK8kgblkpUFXsKcmyLWDfwbiD6rpO8MZ5XJe/D26vyvVBHEOu/eNWkFSJxvg5+EMdvKNlM5bAiLygZyMHb5MIUjkbamcwT9lJTJPUA+OnkX/BdsP/IPx5sJDWjJ7lbic97A8IMjpwYeT6aqLc/qMtkT5Iwa4mLBcCNo8bQmcpZ+NrSjfH9kzP8ug/Fa/u0sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HqwQ/rPQquzdarvfs9qLkJcGq/qtWqi5DTRuO4yt0+g=; b=LZrM4pt82v6Ue0mivIucRUwwiOKApOSUuS7I22Jm39kFYuqPxqWrSzzyMeZOTmchRXE33bXkrCLSQtr6W6CSdjWTO2k2nrTg96k2SDmP5CDDOxnP7lYOhf4WESgvQ+MrAz2cpIbSj3ZJVbu4ZCekY1/DRXC5JgGWDi0LprGP/yKHR4ugW3/B2/rWPymFSGIoJpZfsYTgafMwE+reFcSXrIzV1XjTWRAq4QNyRQJ2mhg31DtyNXPmmLKwyeJb1A2mTJ2O6hQK8H5pfVxDF2ryb+sYA/GTyssQAQc4mPR9nMtfMSzgKjdJcdt/AqkPi+CAAS15JQUE95faCO9EIC7w8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HqwQ/rPQquzdarvfs9qLkJcGq/qtWqi5DTRuO4yt0+g=; b=l5A1RZ//JtSh99c+y2C4b1RezWg230f51U3DBxR9fNgTL3PgUYAMLisnyP+yUOL8HYlLFN3jKFzUniDj/w4FRWRS19uCqfZ1Ce2NTrcvkj/eGZAQaervJ5QToLjRqobyk2egv3peL0dpQ/GW2GktiaNCdm8XWwemHANWJo1ff1Ndc/EX+17rICO2amc1/riswt9l/aMjL1OB5h8btkJZg1+PQUjAqanLMak+j+JKKDiqyF5FdJutv/eHpSbJm3cxf5+nABNfBGFVt4VR/3viO0qvuoVvSApcKeKpUAzsO2NyBX9JC2+Fug87MEPNHcMXbgkl67/WNY3rHZhIiLhp9Q== Received: from PN0PR01MB9608.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:110::10) by PN2PPF10DD11BE6.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c04:1::585) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8422.15; Wed, 12 Feb 2025 10:02:01 +0000 Received: from PN0PR01MB9608.INDPRD01.PROD.OUTLOOK.COM ([fe80::972:abe8:752:bbde]) by PN0PR01MB9608.INDPRD01.PROD.OUTLOOK.COM ([fe80::972:abe8:752:bbde%5]) with mapi id 15.20.8422.015; Wed, 12 Feb 2025 10:02:01 +0000 From: Aditya Garg To: Jiri Kosina , "jkosina@suse.com" , Benjamin Tissoires , "bentiss@kernel.org" CC: Orlando Chamberlain , Kerem Karabay , Linux Kernel Mailing List , "linux-input@vger.kernel.org" Subject: [PATCH 1/2] HID: hid-appletb-kbd: simplify logic used to switch between media and function keys on pressing fn key Thread-Topic: [PATCH 1/2] HID: hid-appletb-kbd: simplify logic used to switch between media and function keys on pressing fn key Thread-Index: AQHbfTUoyx1vQm+EHkSaO2M+WOzzfA== Date: Wed, 12 Feb 2025 10:02:01 +0000 Message-ID: <588AFB72-03C9-4EC6-853B-3F4C362B7AA7@live.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PN0PR01MB9608:EE_|PN2PPF10DD11BE6:EE_ x-ms-office365-filtering-correlation-id: 59b6f5d8-b3fd-4a66-b06e-08dd4b4c4b77 x-microsoft-antispam: BCL:0;ARA:14566002|8062599003|19110799003|15080799006|7092599003|8060799006|461199028|440099028|3412199025|102099032; x-microsoft-antispam-message-info: =?utf-8?q?yBKlh+z5LluHt0PK54TF/QYArxYB1aK?= =?utf-8?q?qZM56fH5DJlzuHJkVU3L3HuPyvjbv4ueNnCweAV7tAdcn+VZJZ5vvfmhZmrPm/VQ5?= =?utf-8?q?AUThH+ygHNIao7TbxtqJa3+gYfONkD0b/wDuw5aU+WCdfEygs1UUGKr/XPiEwgDwB?= =?utf-8?q?x/1OQgz9rwrWEQlofkHr7UgVHqFWsM+QKA9+MXRelqraUMzTst+YENqOoNcDiQKVm?= =?utf-8?q?fUOSAwyrS+GcFjKWCJqNXaj8d+NZJG+gpW4GTqvOqItL2gVenztoJWgwPN8u+6dME?= =?utf-8?q?hpp3tZLecWYweCfka1kIIjqIy9BuY/yMCsUS24TNfYQfgq8yPy9kxpAdjPH1Ww+3P?= =?utf-8?q?XJd2PiuYrEDW9jRzOI3qEYtkM3T0ZHSvwlZ5y4GJyQFrp1T7RrzqmkZY4Y9QAsi2G?= =?utf-8?q?gSCxzKxAJ8kFshvGwlDjMKwqOQ7GRcEdjUhdGOC17BVbDfjf1nV+fHP52qNRyhkja?= =?utf-8?q?Ax/KU7ZkA1BWLDN9WQgCHF/IcrCf17iYhUI56yvSVAsyQCWvhYtFEDlJmVAhDTz9n?= =?utf-8?q?Cmzz+FVQCgnyQb/cHHQWHrtXFFOgkqbdcBONeMvMA+/pZqrpE1TahKdw7YkKocfD1?= =?utf-8?q?inDQUOCSqzvabwqVLQFDIBpCsQhYP6l1myotjxANy35o3+vD1EhCTyA6JjZe6Oru5?= =?utf-8?q?7+9Otyc/SUoiPrHqB/dO4IAGrnrpd1773vanSStVzTzXW83O1IHweN1PTNP8Dpkcq?= =?utf-8?q?4J6ryN9ywIu07id2eFidvubjSRWHEncrCmadji9ZNXGP8HpBEVwLcDIXG6volk0xf?= =?utf-8?q?T7hIKkCLo2oei6mRCwdZLZ1hPusDR5F5xumPaEHz83UOhuvCtnG7fkGeN0xl6yflR?= =?utf-8?q?l7wCX5UaSCi4ykClW6EeuO092UXjj3Y9ZaPqVP+PqH6bJMU/8wPuPkFgo/2CX1Pzj?= =?utf-8?q?tiDtbzAkqW9R3qZBfRZs+R9B2SCqZ0ut/cXHfqNFaYzKPLSuaMpe1dVKLz0QhlnhD?= =?utf-8?q?UlunLvF1+WHMTmLKXS03gpKPFcZ/Zmlk3WqTkeG5kdiwwI8P/z5D4ebqQKySbp82D?= =?utf-8?q?2tNpHEp2FiVSNu5g93/V3E7AWX9z4cvNm1q1JaQ=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?q?tuT1yvnlZBYLGOfk1m0G/NPpKWFz?= =?utf-8?q?NfAJVU0LDKpFvbh6S7kxW0lThaNjB85AOEoNOkarR/slH9xtGMI/27mSHypNt+PPn?= =?utf-8?q?rZ6Ma/DfsZo3CyLh9uupG8RVgczFk6v+SoevbXfydsf69tQTO2F1xY4aHvDiSzBrg?= =?utf-8?q?WCnY7Ai+FDDxJKp7DdvWbypvQ+MkW/Revhj5VFn9YYGmVkvU331sjkbaRJXLf/9G/?= =?utf-8?q?yylXrCFMjm+3U0am3b8xGB1FQhE/sXrIC2RYCorJvHkAqTAVvKA92IHmNnQEHucqB?= =?utf-8?q?rS3bi1LVyzalhv5NSp4A347TCejifiRDM0QrWTvhAazzRgcKtGrht4ppOh8LyW6c3?= =?utf-8?q?bBkEMMcmOkrSIlnvZfLpoRaWvZgWgAUkK5IywbPAJBTMN6ZdWp2F7Stnx0Cj4AEBy?= =?utf-8?q?uTl4txuNq2iYpIo+DvD4F0FnsH4bWiwTGR2wYbryoFZNzBW63wqnxnNT0gBmaJBEs?= =?utf-8?q?XnNK/GTp4m8u5Dp75MLiBOXbIdnFTTP7Wu6HUBMZNg1w1nIpgmSFy4ggig5+8ugyQ?= =?utf-8?q?lb0hpBO/Crsfixx3oAuIFc3l19FMVD+OsKfwtRoVjUse/l+yKcl4oZf+92LFbnyEs?= =?utf-8?q?glwclyfMvY039RGc1Fg314VOxyy2pNNMxH2h7B/yO5WWpvXsIu5TUxSvFuHcI0vU7?= =?utf-8?q?DFJl8bJGOvj5FZ/zVa1rBLNKrnhEY62A3DQB+HfHBRqUl87d04KTgTueVFYjO+boH?= =?utf-8?q?u4RH2S/0k+Cg/0OQRGi1nWvKfblrUUHVmAJANOVyRHgzzJKtbZ1WYXAxGImcc+gJI?= =?utf-8?q?IbzsTQjd4Ky9Qu7rfiqsnBfnAOV/AxmXdTHitlxdd0CMDAjSfAF1MpqefuU1G1Go6?= =?utf-8?q?Dmm0fjFPKxpizwmZ0SLGl323ySjNkgBq4D4OuuZ0clVU1CRnT4Us3Ytv9gPG35k93?= =?utf-8?q?7O9YEMIYS9ttCQtFb3bXPxpPED2lV6kgUCp5+BNxQ7AoMYtBQZXy4J0sky41ru7AN?= =?utf-8?q?KtOuM1B/o3FnbZGFn3aWKuFs6yZNdty4e8PG62Yc1GXO0yMNQcEoWUtr+zmEbLhbc?= =?utf-8?q?hegRBRxh3XdFOm+e75tWBcmleXSWF5Myxnv2/Utdhswr0w/hP1Zr+pqEnpzuSx7KI?= =?utf-8?q?X3recI1geVScj4STy/l+LFu3KmER7ehavoQ+6L2dU8sLipRHbiZDcM8KsTQzpyEJ/?= =?utf-8?q?pKRFegc3yJxXz4qrtwJBBKr3xghAk5ukDvalZhXMQbl32QpBlBK1cAUvnF3RFIwhF?= =?utf-8?q?5b1NtjteVhzGB13FoJJkr8qs1nNP2v3imvQrar1k+TZyluZtZctZpfJK47MSUmN3C?= =?utf-8?q?OHF5RxmmA8v2ggBY?= Content-ID: <7E5734B7F36DD044A3087F6678381EA5@INDPRD01.PROD.OUTLOOK.COM> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-ae5c4.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PN0PR01MB9608.INDPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 59b6f5d8-b3fd-4a66-b06e-08dd4b4c4b77 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Feb 2025 10:02:01.2198 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PN2PPF10DD11BE6 From: Aditya Garg This commit simplifies the logic in appletb_kbd_inp_event used for switching between the media and function keys on pressing the fn key. We now also prevent touching the kbd->saved_mode variable in case the esc key only mode is chosen. A small comment style error has also been fixed and I have added myself to MODULE_AUTHOR. Signed-off-by: Aditya Garg --- drivers/hid/hid-appletb-kbd.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/hid/hid-appletb-kbd.c b/drivers/hid/hid-appletb-kbd.c index 38fc0e58c..c248ce825 100644 --- a/drivers/hid/hid-appletb-kbd.c +++ b/drivers/hid/hid-appletb-kbd.c @@ -236,13 +236,13 @@ static void appletb_kbd_inp_event(struct input_handle *handle, unsigned int type reset_inactivity_timer(kbd); - if (type == EV_KEY && code == KEY_FN && appletb_tb_fn_toggle) { + if (type == EV_KEY && code == KEY_FN && appletb_tb_fn_toggle && + (kbd->current_mode == APPLETB_KBD_MODE_SPCL || + kbd->current_mode == APPLETB_KBD_MODE_FN)) { if (value == 1) { kbd->saved_mode = kbd->current_mode; - if (kbd->current_mode == APPLETB_KBD_MODE_SPCL) - appletb_kbd_set_mode(kbd, APPLETB_KBD_MODE_FN); - else if (kbd->current_mode == APPLETB_KBD_MODE_FN) - appletb_kbd_set_mode(kbd, APPLETB_KBD_MODE_SPCL); + appletb_kbd_set_mode(kbd, kbd->current_mode == APPLETB_KBD_MODE_SPCL + ? APPLETB_KBD_MODE_FN : APPLETB_KBD_MODE_SPCL); } else if (value == 0) { if (kbd->saved_mode != kbd->current_mode) appletb_kbd_set_mode(kbd, kbd->saved_mode); @@ -497,10 +497,11 @@ static struct hid_driver appletb_kbd_hid_driver = { }; module_hid_driver(appletb_kbd_hid_driver); -/* The backlight driver should be loaded before the keyboard driver is initialised*/ +/* The backlight driver should be loaded before the keyboard driver is initialised */ MODULE_SOFTDEP("pre: hid_appletb_bl"); MODULE_AUTHOR("Ronald Tschalär"); MODULE_AUTHOR("Kerem Karabay "); +MODULE_AUTHOR("Aditya Garg "); MODULE_DESCRIPTION("MacBookPro Touch Bar Keyboard Mode Driver"); MODULE_LICENSE("GPL"); From patchwork Wed Feb 12 10:03:00 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aditya Garg X-Patchwork-Id: 13971508 X-Patchwork-Delegate: jikos@jikos.cz Received: from PNYPR01CU001.outbound.protection.outlook.com (mail-centralindiaazolkn19010003.outbound.protection.outlook.com [52.103.68.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B432A2080D0; Wed, 12 Feb 2025 10:03:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.103.68.3 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739354587; cv=fail; b=RV2a1qs8Orq4gZ9QWPKaa88nY51dCrJK2OgD5n60/Q9mTOVfZvgmTGjY9LtGVwvyaI7NrHMaC7RmteUWkD2/0gTc06AQFXj/tf0OGECZf76XnVMHoLY2nD22Q5UrlJ1iv+VO0sFEXFRXCDDr30XWWn6odLYwGo/Y3Yb6ScFb114= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739354587; c=relaxed/simple; bh=AQOlqBDnB7cLJAgP8lzTnMWBvgDnU+SFs76pQ16IDu4=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=i/wg7xZACV2UQWqu98jJsXNdu2ekuFJX1uadsdvjCaQYeiu6PZpGgF9wb1U359B5+oFmfugopmTZ4b2H6GMCGPkJMjfqtkInL1Eo4H+9KfNrsf1rl2LizLo2lUT/rHOz14exQ1aaUv4olEHpye83fl6qcdAL1r4XRQ7Vd6gOSIg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=live.com; spf=pass smtp.mailfrom=live.com; dkim=pass (2048-bit key) header.d=live.com header.i=@live.com header.b=niLmCy33; arc=fail smtp.client-ip=52.103.68.3 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=live.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=live.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=live.com header.i=@live.com header.b="niLmCy33" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jQqWspinlgu4IBmOSYJlWMUz5i0oyNGtVor5RsjEPoWqwSG1ZeBemjMY3CZIkMk/yKG+Fprdv5ZfrF1HvdBF+tZVsKGjMPzHkG2UsN6ler3FTOefNGk0VL/mVE8hVlOwiOBDtI/pdTYSIHRNoReIDwLT3elVZhukCgP4+Eyalbjv7IfTrF+7t/yP+/2EQIDc9dZtWm3idv/Hv6t2dhkxlu9Q4fjG/MI9etaRKF4bRexa3t5bfIbeHiF05T6mrjc4i2nENthax0VzhWjuLDG6pLJC1SmAA+0sMsiPGN+kjKkGv9AzcHViLJmqChoFuGrhviYl/s5dGG7XemP48Uc5cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RTYRjwX3SgZ48vmK8X/POKlNQdYbvoOOqDKIdAvACsY=; b=Ea4CDVc7bPijtLiVGJ4kZbbEnh0hxj42m/nzGtHxcAMTKfkfMxSKhAe2+x4vbZaY9DlE3ANehSU1tupSh2Co+IobrzrHEJLsRuJODJSbQNzxiy0IydBNPlJymUhfwV7pY6FntNNtCOw4plZCzM1M8qUhQL84ONapx6AbJw9PTWqm9UBSDjMgCDz8eGG2JCeqgV61shRnOUjQLcFpVIoYOJGjK0QR385jmfDStt4NGKYOEv/9TSQIj5D/YTFBaN3bU9cO+xPf+gWSlCZDGIa/gfZySkImONEIErPRXmQjTBI3MuVsqpi8oRNp5Nt0bpfgMi6J+yoCktCBAJShXeux0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RTYRjwX3SgZ48vmK8X/POKlNQdYbvoOOqDKIdAvACsY=; b=niLmCy33ZkKoJ8bzM4/tYL3pWlfX1jK8AqbRUFiHNhyQW3QsPkx4mrdsOh/LWw99AUCn5fgSYIIy/JXitBgCN+BlYp1FcstY1TprrsXlm38d/YWPQj4CfjhyTjguZ3tUFVvPKHtTMMWzlL/IKqx+sMlqvewAbjZHj7YHrqtaCAf3X2/Cc+tJQcGHYjmmnjxTr3rnU2zcW9OiwjsQaeCWI1iho7xqIg+MGncN4oVzcQROf6LshiFvfYj67rHuaZiQ02ymWElUKzfRpJ8qc5DR5eGsnyRmoVcDEjyft9OSVBKUy5Cg42W3qdaMd9ZnPzRfY27HjrvhzV77Ng9LG2W0yQ== Received: from PN0PR01MB9608.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:110::10) by PN2PPF10DD11BE6.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c04:1::585) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8422.15; Wed, 12 Feb 2025 10:03:00 +0000 Received: from PN0PR01MB9608.INDPRD01.PROD.OUTLOOK.COM ([fe80::972:abe8:752:bbde]) by PN0PR01MB9608.INDPRD01.PROD.OUTLOOK.COM ([fe80::972:abe8:752:bbde%5]) with mapi id 15.20.8422.015; Wed, 12 Feb 2025 10:03:00 +0000 From: Aditya Garg To: Jiri Kosina , "jkosina@suse.com" , Benjamin Tissoires , "bentiss@kernel.org" CC: Orlando Chamberlain , Kerem Karabay , Linux Kernel Mailing List , "linux-input@vger.kernel.org" Subject: [PATCH 2/2] HID: hid-appletb-bl: fix incorrect error message for default brightness Thread-Topic: [PATCH 2/2] HID: hid-appletb-bl: fix incorrect error message for default brightness Thread-Index: AQHbfTVM4IHCc5iYHUW/FHt3tt7AWw== Date: Wed, 12 Feb 2025 10:03:00 +0000 Message-ID: <0CF9D2C1-6FCE-496B-9030-195891116C01@live.com> References: <588AFB72-03C9-4EC6-853B-3F4C362B7AA7@live.com> In-Reply-To: <588AFB72-03C9-4EC6-853B-3F4C362B7AA7@live.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PN0PR01MB9608:EE_|PN2PPF10DD11BE6:EE_ x-ms-office365-filtering-correlation-id: ae4348f8-f343-4834-ade1-08dd4b4c6ee0 x-microsoft-antispam: BCL:0;ARA:14566002|8062599003|19110799003|15080799006|7092599003|8060799006|461199028|440099028|3412199025|102099032; x-microsoft-antispam-message-info: F1uZNmNCCiGs5Nhh2+ZDcJo1gEIDPj+CY1s9ei1BCCqSVmbjRb/YPx7fSV6hla9+YP1y+AiS4dE+ljqdLiUHLT5LEBzMoo/72ICZK5vKtcJ+wPxuUV7uZlmEgx5HWVbcGqXmRbeuj6eiB68e/89H/jpC+wv/m7LyM5pbQ0//HjG/TXEZZgxBv2AaY0Ks8Amh5U+7dAxT7qvgNDI1/kqNAwpYtZ4AfzCASmV3DYF5loeWYeM8GB+iQHEpfTP/nnEFel8pp7EBw0LOgc1V7RMh2zKOhlrrlyDjOMz6jpv28nm53vYUAcxDY4DEvwXp74JW1JZ9r0Np/8RsxLcOqLd5aUeXU37xx4om3oTLhbYq5lDxdXs48M4l9HCD3K5hvVWktGnvqRqmFWmaxYA9duZVyoramHLWoGqqQBrduJ7KOCPTuwMZw/t6OJdt+jWpU/GBGhXlVRFhBD81wjM1847ezXfLUtS/t6H78aQTf/l7UglAY2IsAAS/wa82MjjVsOD59RlmX97aFVhgyDMGsC/7apYwZ9Vq+hpqeEBmEbF1PJ9fyTRQrtpWLzapHLbBYWOrulLU/DoZteCgXhPpKZpHDhLdn9cqRqfcOXryQMbE7y/lF+1O4wAr4RCJP2LLQbKVuPuYGYQr2awPqqTrDa5p1eRM0j3d70c5jQaNNASB92aABpB4Ait9xjYi3OBXTMRtY5Vc8sCash/lqh9AEKcT08CMzD+tIIPgNerGTpZMtBVM/ICe5tV/XSygMy20RCjd+KaiYz86FHN2CChiBT3HtbwzTz2i0qGtSbRwsIIh4Ahejqt1vSIAmR/aqKzfG1st5KbZgG0oqoVb81UCT4jXh5DjsUSvSbpRGTDSYNKBVsgiRQya909wOxE3JTZilk9PDtw8l+GxkJquFsTaer0kqp5EsPX+mhUvjBhJuuePJhgQL4YMBcHqb8k+pUurTRZQTTRT2TiFEeCnciqDafNlAZL3iXPDG6Hq656BLY6VbCa7Y7s1EWI7V5vbAwIrxjhpgkE5wl7syomt2AqDQu0qt4N/ZY1zjqDEM/ZYK/3ET8waw9ZC3NxzTzQ2huh6NRYJ/w63ZZ/jsmhPj08sudr9Vg== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: Of6qKzi8gGlDwMcOS9ab/kIOinH5wOXdoJt6mh/tRbS3xO5jpRMcC9+TMG0nvT8v2zqBcpShihaTStdJyFlr9UaXo084Z3KbkXsDFFngEfyECbSyPH9/sfI66JHTAoADhkGPuTvp62w574HtAmyBb6t2xgFkJkTW/pVY1zQZUhaJTos2rCdgUyXWuWAYZtz9U3MLobIYnEhtutbCaIACrINcmTPFHqJnkMLGaUmR12PfBE2Q6QcWAy+ngMvFEbjWT6DIuo3Q9hh4pag4lXrYZdd286alS/BsTLPkIWltrN0GPUYgHRFX8/7z4oaSpucrBrMFZtkqyLbTQj8xrsGbylXWfZqirktWjw++EppmvbUDa1sTWakpbCZ2aqBjSB0XAumlQUIStAqvA/egW/n/BTp7L5few/InTbxLWOkduZxGPB1kIDTPCsCTAfkXTYMBigZ4sl4diwQCoVY9Eia626GWbyl5ga2SUeAeKVFCxQRx+RKQKknI3+CQP9sfQUtx76zCFLgURkVEhB9iRGU9/u60eCWZW4jDCeKzBdl/9Eik6f4aHhRGuZrlxGdQe8TYRkIU9LnzkSMhIvOaJ6yB4+AbhOSkRpTqczSOA4YDgvXQ4/Z5IrkUmZfsOMbTtiwIXyCHDvTTwizFg6FD21lTsIJ2YrOxP37ZExJ4zd3JTNlQRtEWeO6ElbozpZYNX08udD/DfBPagMWzQqCvqY4t+m3Smc0k/YZ/fvr2wrDX97eTpTUIBPODQcawCnMA8dIx6CWZ29/4w7raEbIrhreVk1YlWfdC9WJL2m6tiHy7zMSISbslVHts1TZLNdBvYiUA7weoW4DPEUqp85gs+7gYk7h2NzwgM+an/bzvgZgRIHbzmthrF4w3p4RWSD+bk+R7TDia0bJLBvxIUN97t1uv9NFeCndqPhA+fczlRjB9q3A+GrwdEGoYZRkxfcUQUB/G498XsjBz43zYTToxVHEQZengMlu6HPvlOkSW15cMCeNeCIF4d9QU39oEdDqzqGrv9taTubNNkZdESLtKk9Nea0dTsDA5ezY4bMLYrAx7QyXaBSkhSFLrRby8XyIhxHxsV0zEIHGhja4VP0xEqon1qtd9V8Ngnn/wUZK+yDxAJH+iyU5gu+SUwXi54kjjPvDARCQUkFdjOTgKk+bVDYqjPVrmXad1Uy10dhQWofEJl0Y4MCc4H4bQW9Lxvy+MXRZ0xuDeh0N1rgi4Fl6FjwDh1Om3F+Y3w2AJ4DYBldGRvqnT1jtb/VuT/ydEXzHuKJAhWdz33mPqoWr3Mf1kh/DcP6WNHSIVlJ8gNE4fX8nYslYmcte1dCvn3gwpXpWMWL0w Content-ID: Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-ae5c4.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PN0PR01MB9608.INDPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: ae4348f8-f343-4834-ade1-08dd4b4c6ee0 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Feb 2025 10:03:00.5646 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PN2PPF10DD11BE6 From: Aditya Garg The error message responsible to show failure to set default backlight brightness incorrectly showed the intended brightness as off irrespective of what the user had set it. This patch intends to fix the same. Signed-off-by: Aditya Garg --- drivers/hid/hid-appletb-bl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/hid/hid-appletb-bl.c b/drivers/hid/hid-appletb-bl.c index 1a3dcd44b..8e15ad5b6 100644 --- a/drivers/hid/hid-appletb-bl.c +++ b/drivers/hid/hid-appletb-bl.c @@ -145,7 +145,8 @@ static int appletb_bl_probe(struct hid_device *hdev, const struct hid_device_id appletb_bl_brightness_map[(appletb_bl_def_brightness > 2) ? 2 : appletb_bl_def_brightness]); if (ret) { - dev_err_probe(dev, ret, "Failed to set touch bar brightness to off\n"); + dev_err_probe(dev, ret, "Failed to set default touch bar brightness to %d\n", + appletb_bl_def_brightness); goto close_hw; }