From patchwork Thu Feb 13 05:56:12 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: 'Guanjun' X-Patchwork-Id: 13972842 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0826C021A4 for ; Thu, 13 Feb 2025 05:56:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 313A06B007B; Thu, 13 Feb 2025 00:56:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 29C906B0083; Thu, 13 Feb 2025 00:56:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 116936B0085; Thu, 13 Feb 2025 00:56:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E0AFD6B007B for ; Thu, 13 Feb 2025 00:56:23 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 82E0A1205AD for ; Thu, 13 Feb 2025 05:56:23 +0000 (UTC) X-FDA: 83113861446.05.6FE2E34 Received: from out30-118.freemail.mail.aliyun.com (out30-118.freemail.mail.aliyun.com [115.124.30.118]) by imf01.hostedemail.com (Postfix) with ESMTP id 99C5140005 for ; Thu, 13 Feb 2025 05:56:18 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=A1Okd9o+; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf01.hostedemail.com: domain of guanjun@linux.alibaba.com designates 115.124.30.118 as permitted sender) smtp.mailfrom=guanjun@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739426181; a=rsa-sha256; cv=none; b=ZRzI7A412KUm/qSeQcdyoHkL25695hzfLJ5qJ2B3DcZiVkOXiv+ERROz+H1BuDh4BIxCdL t8pfQ3kfaJRN18UwT/NOoYfdo5DDjcpKmY0kZWH0hqHPr46e1SmImoXQm5zB95uS8yxILx mJY5Xl9xnqIRHVJLz0w4Ovk1Nfp8k3g= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=A1Okd9o+; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf01.hostedemail.com: domain of guanjun@linux.alibaba.com designates 115.124.30.118 as permitted sender) smtp.mailfrom=guanjun@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739426181; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=rASHGD09VIAcvDVE/Y5zG8ZXrXsg0FttXsa+JAeYPMY=; b=bBJ1WwCpgpcFmEEvRmYEpWhTEUkoXwqYzEAaEojVm6dhS4J/WEPVjVKJCHjz/GJf2msQrH xz0FC1Gb3xu2rlbJTphu4VR5kR87ZUKTVTH5TV6VrSDLEY8GG8YRpscyxhksSRZZMHoVHF 8i2++NrHJ/YqOCgeTh68lK596dvUIA8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1739426174; h=From:To:Subject:Date:Message-ID:MIME-Version; bh=rASHGD09VIAcvDVE/Y5zG8ZXrXsg0FttXsa+JAeYPMY=; b=A1Okd9o+qWbqglV8Eqjv/tn31pSge72dSoiROlcILXurdmERi3peqiqcuf+GB0VB+jfQdtxMc1TfFicejl3Mq0cEqUZ01ge2nMOtaRJXooMbheIzYME4JRXEoQQrjxjMKMIlTAY0C4cEzCs1YrSx5semdHxoPloHsoCRXdWCsdw= Received: from localhost(mailfrom:guanjun@linux.alibaba.com fp:SMTPD_---0WPMKlTX_1739426172 cluster:ay36) by smtp.aliyun-inc.com; Thu, 13 Feb 2025 13:56:12 +0800 From: 'Guanjun' To: willy@infradead.org, akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: guanjun@linux.alibaba.com Subject: [PATCH mm 1/1] filemap: Remove redundant folio_test_large check in filemap_free_folio Date: Thu, 13 Feb 2025 13:56:12 +0800 Message-ID: <20250213055612.490993-1-guanjun@linux.alibaba.com> X-Mailer: git-send-email 2.43.5 MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Queue-Id: 99C5140005 X-Rspamd-Server: rspam12 X-Stat-Signature: qbf6wrt15hy1gnj8z7z6n3gc3i8hms3m X-HE-Tag: 1739426178-162849 X-HE-Meta: U2FsdGVkX1+hCAcHO3g3iVe0pcrGwN3flp3WfYwcwTHrJZO4VLO+QdZICVJILCDgDb/I1iKwwQtXFmijIgp0KC/kLD6c1pKRrYHN/JpL03ZowMqpeIM5TPzie9LvQgkgePeM5Hyv6AbNIbfqFPJcO4Tqje72cH/Ytb2au1gjpe2dbcxrN9690n0biijUpvzBcgbRy8E5r5ykuWasgZFpgNlsKUtqaBrvzizLPhY0cScopimlIB7sIBgIl1FPv2fLKOgHofFIj4FDfYli55WDkEt1oTCBgBpwK5ibbemuUHYD/9rC+UNcvMeRPL7UmMN0kW68EPII1fJJ7SrWaa7FZnrJwTWIObWJ7/fKdbBwII6H0uVdbQi85G2gqz1GJsd/dE94ep0TAcbUXTU2fgcYhd51/e3jmSWLX1LmvNGL9USBtuvhcTDNdCSdmMRnZKodq5jnDr2UWUB1mgGbW36ebVefrt4fhUwexuEvJpTmyXG4ZymLYYPCisYddPeWizokrKmf3gL5Gtw2yov92Cs4R5mI9yQA6AjDiKHfluO1Rq5SKgqVp7GOhsD1Sc03p3L2+mdDEHTWfL35r/LJkUFd/Fa4q5e9Dbo31Z4fWpUTIg3XIwJyxMY3WzeAIU5XirFjiClgbFTcYiY/BQ+1kd5KGQf98/5HpavTEkCuH4ztZtELMrrvp8uJDiXAMJlyHR5xsKKx1EBbiQGxXiPZe+Tdg0r9I89+noyhw1DW0EaYBs69H6+Gwa9KZQDEsLZqP+IbibiKcWKVe/2sDR01oiXIk+Nnn48yAqWGLdZg0KdARCjOw/zTI5eflW1FFcC7010Ec72euGlvPBv4SnS26/K19qlic9yiQ5LErQby8NxowyHfLOcHNjZEtMU/yLZFEzQofk/hTdii2CbrQb1jTsxoUwbbD5pqZvmn36MTWBgofPW8Jmnjcw2b5YU01nlVGnc06smQkAPivoZiliWL3w5 xcd2DYAA cdOWPd40eABqbNZEVHjmx2juyEwOZt2SOlP0KOtS+j0dh4LnYYKCcUSVfXRBaXcgZmc07P7kiNhYtTh0HTzMPmby6iHLgSZyc+WYEd5+LpUsJX6QF6liAinnxa7jjQUJzu5MphU5jglqoDgtpigXfauneqOFi2lPm86ZfrO4MSDtgJgJKlW/K1ULbuwyYI8XDBKun+4PAy44uUD05At/CzhZ9eOG94jvsFt2YK1TpkSwuZqYy1/tFPnHkDWFWUyDkaUdHG5YJpuJfK00= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000203, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Guanjun The folio_test_large check in filemap_free_folio is unnecessary because folio_nr_pages, which is called internally, already performs this check. Removing the redundant condition simplifies the code and avoids double validation. This change improves code readability and reduces unnecessary operations in the folio freeing path. Signed-off-by: Guanjun Acked-by: David Hildenbrand --- mm/filemap.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/mm/filemap.c b/mm/filemap.c index 804d7365680c..2b860b59a521 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -227,15 +227,12 @@ void __filemap_remove_folio(struct folio *folio, void *shadow) void filemap_free_folio(struct address_space *mapping, struct folio *folio) { void (*free_folio)(struct folio *); - int refs = 1; free_folio = mapping->a_ops->free_folio; if (free_folio) free_folio(folio); - if (folio_test_large(folio)) - refs = folio_nr_pages(folio); - folio_put_refs(folio, refs); + folio_put_refs(folio, folio_nr_pages(folio)); } /**