From patchwork Thu Feb 13 11:44:53 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Petr Tesarik X-Patchwork-Id: 13973177 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32164C0219D for ; Thu, 13 Feb 2025 11:45:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 867346B0083; Thu, 13 Feb 2025 06:45:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 817396B0088; Thu, 13 Feb 2025 06:45:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6DE556B0089; Thu, 13 Feb 2025 06:45:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 51E206B0083 for ; Thu, 13 Feb 2025 06:45:37 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id EA7E8A0CFE for ; Thu, 13 Feb 2025 11:45:36 +0000 (UTC) X-FDA: 83114741472.03.58DA55E Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by imf18.hostedemail.com (Postfix) with ESMTP id C89931C0002 for ; Thu, 13 Feb 2025 11:45:34 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=Or6lkNSo; spf=pass (imf18.hostedemail.com: domain of ptesarik@suse.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=ptesarik@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739447135; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=zNK7rLFtZxlsVr2HlY81+ucXl/w9wHCFQRGCafrM+CU=; b=Vk2ptVCB8KacCL/yXm5HA//O77Jx2o4hj5+xqSu4s4d2Mk6ej386reoFOYSSSVqPW+wo0+ Ih0fLsy3mote7ztOC1WLin1Ql2sgaQad9msZIbSYMeSazke/ChQbSEeoAOdrtmjxDyATj/ /qVGmVsFzaWWOAzyKCKuAG+4P6B4RmY= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=Or6lkNSo; spf=pass (imf18.hostedemail.com: domain of ptesarik@suse.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=ptesarik@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739447135; a=rsa-sha256; cv=none; b=5ccId+4s/CJ7mKETqkpd+vgJ1dunVeMsZNITGNnUiZeXbO6PvJAGvexhfIs9TLjy3SHTYx gT/ugphflk0NOxfKfQ33QP+Mm9+KL/T7KiOYn8W//IG2uFFo9r1ODWtXEFRxBOjE5XbPxU 2RAKpwx25Tpu2v1pMDR50q73fBDvPtY= Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-5dbf65c0c4fso93642a12.0 for ; Thu, 13 Feb 2025 03:45:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1739447133; x=1740051933; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=zNK7rLFtZxlsVr2HlY81+ucXl/w9wHCFQRGCafrM+CU=; b=Or6lkNSoFrUNFMWmBdhVXj69cYuNm7VOmqSWcpxrvPtGc1KXGyYNvREK7wNuqNn4cj oPT/Y/Lmh4iH8adGbutF72W27MUEwSvHqBfTexscsvX6et4/yplE8zc7WrGU4si2tIZP OEarEwQGNtz+0tRQgsF//XZYCNqa7zQqxqb3K/+A4WrSW+0qfNpXmUvFwjI6+b4SFgbW 9wC+5PG5a0x2EB6zjc/YvWJeMVCjv3GTbZHZq13Nhla5TXTNtwxw7xsqLZdmdQKWumSU X5Cfc7ITAwJUpc9LNCSrbQiRmq40QVwU3I2dx9zEFbTmw+HKSJ1BFUAWXLs2oydZT+1o B6Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739447133; x=1740051933; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zNK7rLFtZxlsVr2HlY81+ucXl/w9wHCFQRGCafrM+CU=; b=LFO2i0gasCHfEwcSfOjocjY8C0jlL4rht9gFgkQsy/FkTcoIyTttU7P6kDVMJm3xv/ gFA0BnpRRJU4d3B/spzWC4Tv/PGU3qI1PJ97CUHWKhleRt5dleKRNeeIpKlKINItzVp5 v7cnRN8wQfQTVIbHlvMaam83zVxIX0kljZQ8ai7h7YonddtC0/yRaDttT1xH2o13+T2u Av6V9deJShE4Q2xmqI8ye8yw7Vs2NH7ieUdYxy06zxgmRKdFnGUPOAhULFJlx+vVgYDa Sf/1ON7HELPE0zcJkD577t0k03OBM07M2PPp1U94bAVyDO576k87EfWsom2LZuZ+Cysu tazQ== X-Gm-Message-State: AOJu0YxbP2oLZcJTB/pEwLiVu2qZa2TzO4QuyCqmp1ykkQt/SX9CTExp c0ZdErvUrkESp+CuCUq7WGVBYiBIZuQwhDbR6ugzBfS/4I+O3Wn3bYd4F5enW/5BUQ09srO5SrC R X-Gm-Gg: ASbGncuiPaOfT0RjvLY8i5IYy3NOKUud/qR56b53DkLCLeSTZquhyopyTrYKpX7kh4X hVXyTvIJJjg5iOJzPKJagIz0x4TWWirJ1s48EEm9Pu1p9xe1x3MQqw3pop/OpI7YLKCDNUkuCTM 4hxzUcWKvjlGhHS2GK/ZWClAkMvVLGx4k+Nyaf2qCoKPrWEHdTrkbzpWXs1tVo3HOc7DUwwXxjT slwjvGpepzH/TQ4P8a26VhUWN5C+qZJiH3tMRb3uyzP5ukeVEd3P1exBJHIvwU46gqmB5B4pnFw ugMMcgbdL8qPUuSMIff8aMc5V8nQsqtHzOmICDBfsRwqfcmovRLB4Omv4VdK+faqIBRdZNnKZ38 OQac5oQ== X-Google-Smtp-Source: AGHT+IFhwk4ltxE1xQ3p0mGfeZawu/5MpD6Z/sNSEWalFb7gtGBPeQtv4gNW8tEYCXMCRKVGAjZ0ow== X-Received: by 2002:a17:907:60d2:b0:ab6:eec4:c9c2 with SMTP id a640c23a62f3a-ab7f33cd42emr238790366b.7.1739447133131; Thu, 13 Feb 2025 03:45:33 -0800 (PST) Received: from localhost (dynamic-2a00-1028-83b8-1e7a-3010-3bd6-8521-caf1.ipv6.o2.cz. [2a00:1028:83b8:1e7a:3010:3bd6:8521:caf1]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aba5339dec3sm115780666b.157.2025.02.13.03.45.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Feb 2025 03:45:32 -0800 (PST) From: Petr Tesarik To: "Liam R. Howlett" , Andrew Morton , maple-tree@lists.infradead.org (open list:MAPLE TREE) Cc: linux-mm@kvack.org (open list:MAPLE TREE), linux-kernel@vger.kernel.org (open list:LIBRARY CODE), Petr Tesarik Subject: [PATCH] maple_tree: Remove a BUG_ON() in mas_alloc_nodes() Date: Thu, 13 Feb 2025 12:44:53 +0100 Message-ID: <20250213114453.1078318-1-ptesarik@suse.com> X-Mailer: git-send-email 2.48.1 MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: C89931C0002 X-Stat-Signature: 3wggo1j5eobj8cidcapenn9ibrrh79wy X-HE-Tag: 1739447134-220398 X-HE-Meta: U2FsdGVkX1+80iSYqsZUHwd8jeZYRU24WloNHZXJ1XNUX6xKTz3GyPWwcViDL/0y7J0TbiCFEYyg2CPXvUkvVfFXppz6Zng2qC3aBfteo4qETDZJA7kFFDsaQRvmD+GsjnqrvYLpXhhiF4qmCNLhHlFIKMT5QqFttRRiX7rapB2HQvTannp0Y8MPEqrplP3NhSfujZwzBghsc3Yq7gx2+0BLngoNT5cecPR7Zn/NP07mS+VWtLD6rOnNo4hm6EJfYyUQWw4MWFuzUM+v11VSr/5lssgDn7ztUEaDpEXeFwQV2hQu9MP9P2s86GRUS1D0T+oglJqu6FLbmh2QH3YxjbZJb57Xg5ef72qJrp/Q8hZ1mUmmQbpbpsAtok9QoLtEyQfnTC8MWhdAKa3h0UbYGkC4TcB21QHwBeav//ZV0rxojteisklvvUxb6cUrpcutxbcpXGpbX+aMtaJTiovhZvCXfsbQ5GWEyUiUZaIeTBD7j6uD7FUOAnV2OP4ZCJyavh4fFj4W0yRojwyyqvkX6tEi5Y3F+aoOl702vBGyp21cEPhCfAJ5sRDnacA/hTs0NyuneQwE8Huh5Mn9SB+MdWNNMrl8cY9zPh0DAWBxBEPhOYcNzPzQ11IOh/uZd30tpnxr9zAE7SST61MvjRea1vXtuHHBmTaTtrOCkt7NKFDuzi2RzL8lze8AOsSMmebyxKOIl64iL6uattHA64r1Z0pNfJkyTB9BVpZZZ/2NYSjRSmlu72jnhGmi4Cr5rcKwXlc0bdVOkvZkKIKzu6xtfMfO4qH31dYV3SM6rTpQDnwtPUxFbCnF2mJCbW8+UhkqiwU4zindeNx3cL9g29oXPxuA8lvDMxRwgpppsa5gXMwxvf+S6YwkCQMcOdYGySlBIeO/YvgEyWL7gEdxj6rC1mB38F3j1EKjL2KaOfNLPFVjW5OoGKG5oleNFCEDxk5mvjS+m7qxl3t5ekO+p3A vYYI/WA2 KSNE3T9xy6/y2u/4NAYs8Y4MP8vTm3Ip/wu+YNtN7E+u2ghCK2NbpSvdqpj2iJTM8PgrUkWLy/R7WN5Fg4rbuk1Jf4o5Qy1P8qA4lT3pJEezSIWb7e5s4sbAOWl2mTWNd8IfJprFrj33V8dVeUzbzzAQjcqGrwNFoeu3OBoitSp0RR0xyei39UNnTeDX2l8bgdBZNdIFlEovIcXX24yogNLfHF8F49tD+8mVhWFKyuBJmNjlhpRIZcggxYTg00r666h7ZQ+mIedwom5zvL7Mc9l9nmJzuZGtquJw7mYI8b5d9O8r+6yPyU03s8YzPkGwrgNGskH6QerkpnR9v9QLWyxoviIoMz5a2PslXQMuTTZ1rmPqvwhL1hPd4Omjji29knPY8ErPVf5oVwsUsWyzxCvsFUg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000013, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Remove a BUG_ON() right before a WARN_ON() with the same condition. Calling WARN_ON() and BUG_ON() here is definitely wrong. Since the goal is generally to remove BUG_ON() invocations from the kernel, keep only the WARN_ON(). Fixes: 067311d33e65 ("maple_tree: separate ma_state node from status") Signed-off-by: Petr Tesarik Reviewed-by: Liam R. Howlett --- lib/maple_tree.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/maple_tree.c b/lib/maple_tree.c index f7153ade1be5..0f2111d436c4 100644 --- a/lib/maple_tree.c +++ b/lib/maple_tree.c @@ -1245,7 +1245,6 @@ static inline void mas_alloc_nodes(struct ma_state *mas, gfp_t gfp) if (mas->mas_flags & MA_STATE_PREALLOC) { if (allocated) return; - BUG_ON(!allocated); WARN_ON(!allocated); }