From patchwork Fri Feb 14 04:02:12 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick Chan X-Patchwork-Id: 13974426 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B9CF2753EA; Fri, 14 Feb 2025 04:04:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739505849; cv=none; b=Tmqg40DYxCA2Zrvuj/uV0sAv3EJ/xifft1GinQ8ZjfC8457dfIKxr4ks0yKhODdbGOYOfBZrMMNc9b2yZQowXyLmTM4ys5PFgGA+KrC+RkvrtXyt//O6mfv1QNvbZa5OtfIJyPEqMUfllsPZr0UVgwMVo5PyXPUlVpU2loI/0IU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739505849; c=relaxed/simple; bh=e4LCw8b9TArgBNatCS4iPLDcnxNGjb099gyuFiAoxA8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=csZECs5wXoQyx/nlHk2X7aS0g6upoDetrPDxJOC8O6yleE0WTZvdR8NkD/cT489dOXIHmv0X7zlA8LE3dzP5QZYoau8ZyRpNTvbbWVmtsCApvOK7TrrctSktmcsaEjXBPfSNHEx7k1NzxGXo7IKaXHAR8cSGqSwej0IMNeQFONI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jXqfRRlN; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jXqfRRlN" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-219f8263ae0so26927185ad.0; Thu, 13 Feb 2025 20:04:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739505847; x=1740110647; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Bvsk07Lzw6XdWgB2cdXk97Y7I1cSDuStLmoSGezH+tI=; b=jXqfRRlNvw0YrXRFaduk/yA7CdR/BhvlhjwHxEVkoglL1WoBH9uQtubIMAoMHZlo+w yNfkIIHFbCI996bOnmY7wFpWBiiLzAb9/hUMOnysOZ2SNhjKQXWvmingxvDZzyN1KEVj aCoo4CpSf/fI8kifzPDlPndTTAkYedrmEMJQBbW10WQQKKHwv4NM3GNCZ7fEXFf/CgQR Kcqq6fuc3cZ66zNs1nWAqGwBVgVMOOmLL9a3KY8x6VlmpWxRqDLaaLkF9/9ioSR9x2A4 08ccpy0S8L3jJd5SgSflHF3GE+kBArSFPaXy2edl4bsHI7PfRGmEeHglMz/w24oDI5+H NcbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739505847; x=1740110647; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Bvsk07Lzw6XdWgB2cdXk97Y7I1cSDuStLmoSGezH+tI=; b=KqEqPTTMyxzIJZ28v9m6TMV+1+siqO+GEr6jmVtAvjkT+/PfGqWL+UN+5gVKloSckS 8mR/c4sCjifrC8vbaINxnTqPLxxVjk6qqDPcFnBBqk2KlGPLfohDYxhSzqAkT7sROsFL hrCg8poj2RJBMDrG0OnW/ROmxeQqi2QLAfkkXPUO4Hps8oxkycWQ8w4hklK4C5kra82+ lZVE9dXbI1PiAmWE2uN32n+sRThMogCMVdPgzTOrzJdsLDLtMFC7PlRu7bRYBZaESgWB /o4WseMU6Wd7AaVrVYYDp7hl4I+pRE4zhdOwRS7O2/ETRNu/Y/ZBNntGmT+OVvR5G56t dI+Q== X-Forwarded-Encrypted: i=1; AJvYcCU1Z57Ks6jYaaBamFF2ujAjSuu8AtatZjsstKkwCdL/Abug37BCnmRlIZ+keDDdgBLclb0dhojpUQk2@vger.kernel.org, AJvYcCWfX0c26+7XoZFPt8jyOZkwbek9ZjRtA/wLnA2NwIn+quq5vjkiXOmbMvnyWmaqFnZDoURVg4se8+4xtdZa@vger.kernel.org, AJvYcCXJOiFhp1HhWiG/WqOS167sXLzy8ogsXIghBMOwet7ucCy92poxkDpvC0Ggj9N6HpNMbb8jJ/LsYWyzbQ==@vger.kernel.org, AJvYcCXkgNfk3ScLX4joIlPvzmXGC39LX03NvkVbFrwb8802+LzsoS5pnwuBV410jmyABvpExlQkbfa40f/BXb4=@vger.kernel.org X-Gm-Message-State: AOJu0Yyb0WTqOF2+gN1deRd9J3SZB0Udb3SaZcZB6rNL/NO7DZX4l+Wy NZHVM4RejLwNRp1yO08FA/kgLOyw7x8EtU5aBEiD7vBeo0F5HVhA X-Gm-Gg: ASbGnct09jQGVuF1lXUqvSdyRsrEx9wIU66R57/hKzHnHh+XFusYjBCmirqx8b5w+6V V3KguraXPHU00BSHlx0sKo9yk2UM7Cr/kdGrS/e59d9lFxGZXtMNTOLhNpMgjG7gUPhcVt9wT5M 8HCqy3pIG1WYctNVmVPJ+bipkLtLt5US4ThycAfZgsm5FwFGMNh11g3rW1Xyez+cqTKHnDoKGvB gW4e6WiFBZFbVssTluiDSs93cwLqdTHu1/Pr9CKx421ao7Xs51H+wIaEcl84MMmLG1xdhcI2qso KV0sxK6vkJEiDsU= X-Google-Smtp-Source: AGHT+IGgz94u5dSaKE5PwBYaLjtoVurlg0X6dABIb3PB35R+FknVncdnfvcsPkYesVe9CLDNkNni2w== X-Received: by 2002:aa7:8894:0:b0:725:9f02:489a with SMTP id d2e1a72fcca58-7322c3f4d96mr13423478b3a.17.1739505847127; Thu, 13 Feb 2025 20:04:07 -0800 (PST) Received: from nick-mbp.. ([49.130.17.220]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-7324273e3e7sm2181227b3a.91.2025.02.13.20.04.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Feb 2025 20:04:06 -0800 (PST) From: Nick Chan To: Janne Grunau , Sven Peter , Alyssa Rosenzweig , Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Helge Deller , Nick Chan , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v6 1/3] dt-bindings: leds: backlight: apple,dwi-bl: Add Apple DWI backlight Date: Fri, 14 Feb 2025 12:02:12 +0800 Message-ID: <20250214040306.16312-2-towinchenmi@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250214040306.16312-1-towinchenmi@gmail.com> References: <20250214040306.16312-1-towinchenmi@gmail.com> Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Add backlight controllers attached via Apple DWI 2-wire interface. Reviewed-by: Krzysztof Kozlowski Reviewed-by: Daniel Thompson (RISCstar) Signed-off-by: Nick Chan --- .../bindings/leds/backlight/apple,dwi-bl.yaml | 57 +++++++++++++++++++ 1 file changed, 57 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/backlight/apple,dwi-bl.yaml diff --git a/Documentation/devicetree/bindings/leds/backlight/apple,dwi-bl.yaml b/Documentation/devicetree/bindings/leds/backlight/apple,dwi-bl.yaml new file mode 100644 index 000000000000..29caeb356e6f --- /dev/null +++ b/Documentation/devicetree/bindings/leds/backlight/apple,dwi-bl.yaml @@ -0,0 +1,57 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/backlight/apple,dwi-bl.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Apple DWI 2-Wire Interface Backlight Controller + +maintainers: + - Nick Chan + +description: + Apple SoCs contain a 2-wire interface called DWI. On some Apple iPhones, + iPads and iPod touches with a LCD display, 1-2 backlight controllers + are connected via DWI. Interfacing with DWI controls all backlight + controllers at the same time. As such, the backlight controllers are + treated as a single controller regardless of the underlying + configuration. + +allOf: + - $ref: common.yaml# + +properties: + compatible: + items: + - enum: + - apple,s5l8960x-dwi-bl + - apple,t7000-dwi-bl + - apple,s8000-dwi-bl + - apple,t8010-dwi-bl + - apple,t8015-dwi-bl + - const: apple,dwi-bl + + reg: + maxItems: 1 + + power-domains: + maxItems: 1 + +required: + - compatible + - reg + +unevaluatedProperties: false + +examples: + - | + soc { + #address-cells = <2>; + #size-cells = <2>; + + dwi_bl: backlight@20e200010 { + compatible = "apple,s5l8960x-dwi-bl", "apple,dwi-bl"; + reg = <0x2 0x0e200010 0x0 0x8>; + power-domains = <&ps_dwi>; + }; + }; From patchwork Fri Feb 14 04:02:13 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick Chan X-Patchwork-Id: 13974427 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 065922753EA; Fri, 14 Feb 2025 04:04:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739505856; cv=none; b=jUovP2BxJ1ovdi/aKNGKiuvF23Z+GTFDndbvaqlTFFM/zhbwjGN/GO//h5EsStwGW2nYv2xZeLyTaYj5dkYLjd+ZMi+pBJKyWmk/ssL8dRqYnxscieW5EHn5SzkNuSbonqrpmPP23rp7ffKFXxGyZVLVO2nQJ0At0if0Do9b5E4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739505856; c=relaxed/simple; bh=3GL2/WeIQojBOOSCQVtLEOFC8W4Kf1COEU0/3t8SOG0=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=V8ITg0HeKBpspkdR5tYZq+N3D155Yxil6N5tD5qq2r28J8ZVmQOXrb7u9PXYOFQTBY94B3r/dUYUbxXqeFrbASsdhGq2nTNYFVjQd/ssuLM7QLR5WNyBIeEctE1gbcfZaTIMCZhxKPZrz5ADbZ1aWQqMaevd3uXnMVYX1nLoFdg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZItL4nMg; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZItL4nMg" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-21f92258aa6so42275575ad.3; Thu, 13 Feb 2025 20:04:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739505853; x=1740110653; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=THGbXf//SrScK+32A3BUuAqCods80KxGwHDBckzXHsI=; b=ZItL4nMgHWaeBwWNXpiLrlQ0sfLzf4zy8A5QkADiSDE/Qoo+osFVirtxwyhGZ8Qjsj rl6sNZ2BnRjKBE0QRO1yKQpzCbyeD9vOOvl1v22Pkk897l+pYBuV/5TROSI1rayADeeJ 2XflYF3yX08QC4COhwelSsJsOfISRvquQD7NWrvtPmovRtuG82BMgZi6lM8APgHUUDe3 9n9TdzJWTYKjLbJz+95WQvivoi7eE/Ia3WyqUh/pnnm6ddozBRZKRvqkmdbGSscO7UPk rNlevB3Z9j9RFUnUAiGt8gOo3GqgfXIrb7HRpIY3qwTcaRb2qIqrXxaEQIJcW34uzX33 lC5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739505853; x=1740110653; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=THGbXf//SrScK+32A3BUuAqCods80KxGwHDBckzXHsI=; b=QNzCv4N0t3Y0yymvi819IoIBwFd+BbU7I72S2OopfMaMfyXCTIaXu/5XR/Vel+IeDx x+B9lTfhrrlS5VRsf6y+qZMmVyQjdsGgTGGWQd3Cb/5LhN8kowE0NvGQY3WvTB3+REFE eNMtRboOm0M25nANejj0fujTpO4TH30KQCaKtRvp3C2iC7XAkvrmZT3U6Natkpvs+qil R7k/LgUT6oYUUZ6fbxbpaLXwIaSGvUjmOf9XpxMfJJHLvNsWbuoh2nlAt9n6/gIy/VG1 61TRE1LwxPSEIeagxlRdpNd6qbMfC8N0dIQNJQNrbqS7CXO91PTjRV9oeZouPi0tcm3V MukA== X-Forwarded-Encrypted: i=1; AJvYcCV75mfyYcszwSlun+Iy0vfqoTpt4fP3kvjHMF93mSr3bn7vOXyH1E9bFiRLrhehCvFVgQ5tlpkLNj9KG8o=@vger.kernel.org, AJvYcCWfCdrWMxqRd98zYgWFJY2VOa6Co01XIoTUMduz34IKaYNxUp15WYHQseuBMJlF6N2OcPeAjd5vuWa8ow==@vger.kernel.org, AJvYcCWiPU7RbgD80FMG4ZIiWyRCwdLUFc2xCLhMv/YDpTMCkdAMimsTbJFONFZ0h6RT98XjI+umoLLECnK2@vger.kernel.org, AJvYcCXxNLr4jy6Rz14PScTtruyXEnJ6EtfoA833aMsOkAMqtlTuIvU70P5IPDEtS2iDVdAoKIZAyDjgV5Zm+h4D@vger.kernel.org X-Gm-Message-State: AOJu0Yx1eKLFGk9vSWDnrvNipTdJaLgo9IBMnhrBDkstffHjBVyBLVNi 6j/+kAL3T1CQz8jCHDxaTXKEow/o3kVtl9QZHxBMTvc72OFzFCjA X-Gm-Gg: ASbGncuDE7pbzIANHhVk4AwjeqFYR/ALmYhv7S5Zu6Vhe/9ToK5ayNGgvd+jLUGyaUe 0cXIzOylKLc+bwqzKu3u6l3RyqNcfZPK73T1mb1rpGIlpDm9H3KHr9Xi4xX/usBoC7//VtwckRX InVZ3d07cBqGJCk6oM5zXSx5SLdpPI0tORG0fK5CVhyFtWM550EjhlvzIBowsUlNRD6M2c4j+cH xjbDyeQMNjcbXFgty7yE94re62cgzlBdsMKJUtDoNc9S51mjWHk6zBSi8zbiw5Nx3wLgSvKLtLj ELb1kp7bl3mNLgM= X-Google-Smtp-Source: AGHT+IGxivn76yELBYxib0w0BFCjx4VgWlcePDuyKrKPnZS1ISzc7Gxg04wRI/FeWDE8mSYuN0bpnA== X-Received: by 2002:a05:6a20:2585:b0:1ed:a812:8860 with SMTP id adf61e73a8af0-1ee5c796e7fmr16856578637.25.1739505853270; Thu, 13 Feb 2025 20:04:13 -0800 (PST) Received: from nick-mbp.. ([49.130.17.220]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-7324273e3e7sm2181227b3a.91.2025.02.13.20.04.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Feb 2025 20:04:12 -0800 (PST) From: Nick Chan To: Janne Grunau , Sven Peter , Alyssa Rosenzweig , Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Helge Deller , Nick Chan , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org Subject: [PATCH v6 2/3] backlight: apple_dwi_bl: Add Apple DWI backlight driver Date: Fri, 14 Feb 2025 12:02:13 +0800 Message-ID: <20250214040306.16312-3-towinchenmi@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250214040306.16312-1-towinchenmi@gmail.com> References: <20250214040306.16312-1-towinchenmi@gmail.com> Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Add driver for backlight controllers attached via Apple DWI 2-wire interface, which is found on some Apple iPhones, iPads and iPod touches with a LCD display. Although there is an existing apple_bl driver, it is for backlight controllers on Intel Macs attached via PCI, which is completely different from the Samsung-derived DWI block. Reviewed-by: Daniel Thompson (RISCstar) Signed-off-by: Nick Chan --- drivers/video/backlight/Kconfig | 11 +++ drivers/video/backlight/Makefile | 1 + drivers/video/backlight/apple_dwi_bl.c | 123 +++++++++++++++++++++++++ 3 files changed, 135 insertions(+) create mode 100644 drivers/video/backlight/apple_dwi_bl.c diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig index 3614a5d29c71..cee113bba30f 100644 --- a/drivers/video/backlight/Kconfig +++ b/drivers/video/backlight/Kconfig @@ -290,6 +290,17 @@ config BACKLIGHT_APPLE If you have an Intel-based Apple say Y to enable a driver for its backlight. +config BACKLIGHT_APPLE_DWI + tristate "Apple DWI 2-Wire Interface Backlight Driver" + depends on ARCH_APPLE || COMPILE_TEST + help + Say Y to enable the backlight driver for backlight controllers + attached via the Apple DWI 2-wire interface which is found in some + Apple iPhones, iPads and iPod touches. + + To compile this driver as a module, choose M here: the module will + be called apple_dwi_bl. + config BACKLIGHT_QCOM_WLED tristate "Qualcomm PMIC WLED Driver" select REGMAP diff --git a/drivers/video/backlight/Makefile b/drivers/video/backlight/Makefile index 8fc98f760a8a..156ff9461fb3 100644 --- a/drivers/video/backlight/Makefile +++ b/drivers/video/backlight/Makefile @@ -23,6 +23,7 @@ obj-$(CONFIG_BACKLIGHT_ADP5520) += adp5520_bl.o obj-$(CONFIG_BACKLIGHT_ADP8860) += adp8860_bl.o obj-$(CONFIG_BACKLIGHT_ADP8870) += adp8870_bl.o obj-$(CONFIG_BACKLIGHT_APPLE) += apple_bl.o +obj-$(CONFIG_BACKLIGHT_APPLE_DWI) += apple_dwi_bl.o obj-$(CONFIG_BACKLIGHT_AS3711) += as3711_bl.o obj-$(CONFIG_BACKLIGHT_BD6107) += bd6107.o obj-$(CONFIG_BACKLIGHT_CLASS_DEVICE) += backlight.o diff --git a/drivers/video/backlight/apple_dwi_bl.c b/drivers/video/backlight/apple_dwi_bl.c new file mode 100644 index 000000000000..93bd744972d6 --- /dev/null +++ b/drivers/video/backlight/apple_dwi_bl.c @@ -0,0 +1,123 @@ +// SPDX-License-Identifier: GPL-2.0 OR MIT +/* + * Driver for backlight controllers attached via Apple DWI 2-wire interface + * + * Copyright (c) 2024 Nick Chan + */ + +#include +#include +#include +#include +#include +#include + +#define DWI_BL_CTL 0x0 +#define DWI_BL_CTL_SEND1 BIT(0) +#define DWI_BL_CTL_SEND2 BIT(4) +#define DWI_BL_CTL_SEND3 BIT(5) +#define DWI_BL_CTL_LE_DATA BIT(6) +/* Only used on Apple A9 and later */ +#define DWI_BL_CTL_SEND4 BIT(12) + +#define DWI_BL_CMD 0x4 +#define DWI_BL_CMD_TYPE GENMASK(31, 28) +#define DWI_BL_CMD_TYPE_SET_BRIGHTNESS 0xa +#define DWI_BL_CMD_DATA GENMASK(10, 0) + +#define DWI_BL_CTL_SEND (DWI_BL_CTL_SEND1 | \ + DWI_BL_CTL_SEND2 | \ + DWI_BL_CTL_SEND3 | \ + DWI_BL_CTL_LE_DATA | \ + DWI_BL_CTL_SEND4) + +#define DWI_BL_MAX_BRIGHTNESS 2047 + +struct apple_dwi_bl { + void __iomem *base; +}; + +static int dwi_bl_update_status(struct backlight_device *bl) +{ + struct apple_dwi_bl *dwi_bl = bl_get_data(bl); + + int brightness = backlight_get_brightness(bl); + + u32 cmd = 0; + + cmd |= FIELD_PREP(DWI_BL_CMD_DATA, brightness); + cmd |= FIELD_PREP(DWI_BL_CMD_TYPE, DWI_BL_CMD_TYPE_SET_BRIGHTNESS); + + writel(cmd, dwi_bl->base + DWI_BL_CMD); + writel(DWI_BL_CTL_SEND, dwi_bl->base + DWI_BL_CTL); + + return 0; +} + +static int dwi_bl_get_brightness(struct backlight_device *bl) +{ + struct apple_dwi_bl *dwi_bl = bl_get_data(bl); + + u32 cmd = readl(dwi_bl->base + DWI_BL_CMD); + + return FIELD_GET(DWI_BL_CMD_DATA, cmd); +} + +static const struct backlight_ops dwi_bl_ops = { + .options = BL_CORE_SUSPENDRESUME, + .get_brightness = dwi_bl_get_brightness, + .update_status = dwi_bl_update_status +}; + +static int dwi_bl_probe(struct platform_device *dev) +{ + struct apple_dwi_bl *dwi_bl; + struct backlight_device *bl; + struct backlight_properties props; + struct resource *res; + + dwi_bl = devm_kzalloc(&dev->dev, sizeof(*dwi_bl), GFP_KERNEL); + if (!dwi_bl) + return -ENOMEM; + + dwi_bl->base = devm_platform_get_and_ioremap_resource(dev, 0, &res); + if (IS_ERR(dwi_bl->base)) + return PTR_ERR(dwi_bl->base); + + memset(&props, 0, sizeof(struct backlight_properties)); + props.type = BACKLIGHT_PLATFORM; + props.max_brightness = DWI_BL_MAX_BRIGHTNESS; + props.scale = BACKLIGHT_SCALE_LINEAR; + + bl = devm_backlight_device_register(&dev->dev, dev->name, &dev->dev, + dwi_bl, &dwi_bl_ops, &props); + if (IS_ERR(bl)) + return PTR_ERR(bl); + + platform_set_drvdata(dev, dwi_bl); + + bl->props.brightness = dwi_bl_get_brightness(bl); + + return 0; +} + +static const struct of_device_id dwi_bl_of_match[] = { + { .compatible = "apple,dwi-bl" }, + {}, +}; + +MODULE_DEVICE_TABLE(of, dwi_bl_of_match); + +static struct platform_driver dwi_bl_driver = { + .driver = { + .name = "apple-dwi-bl", + .of_match_table = dwi_bl_of_match + }, + .probe = dwi_bl_probe, +}; + +module_platform_driver(dwi_bl_driver); + +MODULE_DESCRIPTION("Apple DWI Backlight Driver"); +MODULE_AUTHOR("Nick Chan "); +MODULE_LICENSE("Dual MIT/GPL"); From patchwork Fri Feb 14 04:02:14 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick Chan X-Patchwork-Id: 13974428 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E744178CC8; Fri, 14 Feb 2025 04:04:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739505862; cv=none; b=ZF8siewg+K9eaY4CoS8QHYoiWkU7HBTc4nzngtouvwdZbGJ45SqBnv9w2PDaqcEX5q8zleJY9WsGKtOEayNzBq/ovskaYeswOq7V3eHz6OYcEJhBWsn4XyC5gPYy8VeYBpPjU6CLn/8InsiGaBX/2dv38Bvlc7+aI5NEE4ytPSU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739505862; c=relaxed/simple; bh=mtPz4s+4egQ0jOh3GQAGAPwNPBPu0BZnd8qj+UMcZso=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ngP2c7Ak5gG8Oo/MPMZwiZRGigcfiocC0BKShDJH0dHNOYhD4CNNZhcp2gxGD84v61wIhkLm0q6UpweLzN2bICw7eH5pqWpJ0I5eDeFczkRxb38rjq7Q10RhYdt20ai+vgwJ/IPZHr4dYxeuCQG/er6Ir5W71i62lBuud8q7JqY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NTYmwrCa; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NTYmwrCa" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-21f5660c2fdso32443355ad.2; Thu, 13 Feb 2025 20:04:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739505859; x=1740110659; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=Uc4uCqsleGcCsKVC2kCtafnEyIcpxj+3QblkARK4r2c=; b=NTYmwrCa1RVeC59d+k/EUbi3uRfOn7E/v+Zq9YiAQ7iGM4p69ket7ytd/a2otEWTBf 3IUb+glLEUtIhsQAXRZCFZ3c85Bcs78vEGZTdAlyKFvm9IHGc08vrTnTfLbp+5IxsPN1 kA62BvZVyESIbw+mqGZxe+QwX347qQ0qAnWK/bKQfJ5woyojV4CYiMIJLVT+PeQckljU bWBfswwhV5RURZEpHN5lLuT+HB6pJsCQvkbkCy7BslP+sbQjFq9OMJMjALe3ZDNaBhbO MeC6hw2j9qK/caz7SyJWyuFPGGwHxyfGE0i7L53LGhL91R0wpMHT75DghG/xDgd4pQSx hsfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739505859; x=1740110659; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Uc4uCqsleGcCsKVC2kCtafnEyIcpxj+3QblkARK4r2c=; b=c8IYcP0tq/1S0XhCeNYbwt2i8HLaZPfSdV1y/2A/YKgHKQW8v5Sozv/ZH4jHy+iEJK BvxniasaQ0sSrJjRZnx6GZ9VKF+yD6STLCtL61PFnCkPAh0NbLpaf83CkJlKMscynmzP 5kXaCEGAJMckRyL2LE7tUAv+iMXMe7IjNpCItFoXPo31T7P1JeCPwsb939vsjatMXQxp AeXdgiTvE9uMspE0061FSd7ikqxskJW5IrO8J+Rf7hERp6ZIX88JFmzwWAeeeEl+xCZa Z84UQYUnx+u9UNDNd4nrV+5A1DaVJjj70N8Uv56/FJPoW70QXTnB/FzXAm0jW5TzXsMN pjoQ== X-Forwarded-Encrypted: i=1; AJvYcCUUIfuAlPdahk+AxmtYNuoGE8QdOUw4QMIoGGalimk2FAdDnJ+t3yu+ruhcF7xO+hb+4oTMbrsvi8paEA==@vger.kernel.org, AJvYcCWOdaLSWbfEuWy5d9zh4tXgT97cieUgG2+K2HPzXqMrZxkkgvN255BWSkPkwBp7NhIBylAMICXx/1IH7Pg=@vger.kernel.org, AJvYcCXSyHN4cBPWt2L+RZVUQDqUGh6CP5Lok+x2t7XG0y1c9WHzWrYrDKJ3A0Bn+x44MA5iKE0TwyQxRxbhn+23@vger.kernel.org, AJvYcCXpHcsmP6U7ALjNyW0SWN8oyN7uSq3nvRuTiqmbMdth3aV/iXDMdVdcDFY3bv41QHx6KCaIu7pKxpD+@vger.kernel.org X-Gm-Message-State: AOJu0YzwoQiqlSrAPA4Hv5oNfmztOz7dqd9sdHFATHS4GRH8Y7nNp8sN cKT6y627TSeOQkwhtqjSAo0iLxa5VQbn3WwJ9v6r3KTsfxnn3Nxj X-Gm-Gg: ASbGncv4LGpsEJhyZcD5yqO2wkFaSMEtymjOdnnXzwJA0eG+6ciWiBo0V5TtLfX57Fi 9aXBDhpmNoBS3lpA/QtA3xIB+RZgi8Fs/B9r0MQiGWI0up5ttDtPY339jrzAj41WWzf689hUt7J n25Ahl38xRFDTjqNi7QN/PN6Jy9lmgkLl67LlfViYuvdBaFmfITlarLn/L9Sp9TU/anhMzhYhwh DtvXfESTrQso4fEJtTXdkXD/mlbk1r7U4RMBUA1r5Yt5qMyAo6UbHICujjMWzUf4YJTGZMpaON7 h8MBFpSsD9eV0v4= X-Google-Smtp-Source: AGHT+IHkN1crcRx1umsgU8oqxNqZWEWNVP7TrG7rSyx2t22hQspF82Y6IBy/bUusVKbjj5NHW6Qt4w== X-Received: by 2002:a05:6300:614a:b0:1ee:1bc6:2341 with SMTP id adf61e73a8af0-1ee6b2fe438mr10767975637.15.1739505859444; Thu, 13 Feb 2025 20:04:19 -0800 (PST) Received: from nick-mbp.. ([49.130.17.220]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-7324273e3e7sm2181227b3a.91.2025.02.13.20.04.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Feb 2025 20:04:19 -0800 (PST) From: Nick Chan To: Janne Grunau , Sven Peter , Alyssa Rosenzweig , Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Helge Deller , Nick Chan , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org Subject: [PATCH v6 3/3] MAINTAINERS: Add entries for Apple DWI backlight controller Date: Fri, 14 Feb 2025 12:02:14 +0800 Message-ID: <20250214040306.16312-4-towinchenmi@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250214040306.16312-1-towinchenmi@gmail.com> References: <20250214040306.16312-1-towinchenmi@gmail.com> Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Add MAINTAINERS entries for the driver. Reviewed-by: Daniel Thompson (RISCstar) Signed-off-by: Nick Chan --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 896a307fa065..a576324807f5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2228,6 +2228,7 @@ F: Documentation/devicetree/bindings/i2c/apple,i2c.yaml F: Documentation/devicetree/bindings/interrupt-controller/apple,* F: Documentation/devicetree/bindings/iommu/apple,dart.yaml F: Documentation/devicetree/bindings/iommu/apple,sart.yaml +F: Documentation/devicetree/bindings/leds/backlight/apple,dwi-bl.yaml F: Documentation/devicetree/bindings/mailbox/apple,mailbox.yaml F: Documentation/devicetree/bindings/net/bluetooth/brcm,bcm4377-bluetooth.yaml F: Documentation/devicetree/bindings/nvme/apple,nvme-ans.yaml @@ -2253,6 +2254,7 @@ F: drivers/nvmem/apple-efuses.c F: drivers/pinctrl/pinctrl-apple-gpio.c F: drivers/pwm/pwm-apple.c F: drivers/soc/apple/* +F: drivers/video/backlight/apple_dwi_bl.c F: drivers/watchdog/apple_wdt.c F: include/dt-bindings/interrupt-controller/apple-aic.h F: include/dt-bindings/pinctrl/apple.h