From patchwork Fri Feb 14 20:45:21 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicola Vetrini X-Patchwork-Id: 13975620 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5FE08C02198 for ; Fri, 14 Feb 2025 20:46:17 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.889051.1298289 (Exim 4.92) (envelope-from ) id 1tj2ZP-0008D0-Gu; Fri, 14 Feb 2025 20:45:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 889051.1298289; Fri, 14 Feb 2025 20:45:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tj2ZP-0008Ct-EL; Fri, 14 Feb 2025 20:45:55 +0000 Received: by outflank-mailman (input) for mailman id 889051; Fri, 14 Feb 2025 20:45:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tj2ZN-0007yt-NU for xen-devel@lists.xenproject.org; Fri, 14 Feb 2025 20:45:53 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ae1ec817-eb14-11ef-9aa4-95dc52dad729; Fri, 14 Feb 2025 21:45:52 +0100 (CET) Received: from nico.tail608894.ts.net (unknown [46.228.253.214]) by support.bugseng.com (Postfix) with ESMTPSA id 99A024EF5132; Fri, 14 Feb 2025 21:45:50 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ae1ec817-eb14-11ef-9aa4-95dc52dad729 Authentication-Results: bugseng.com; arc=none smtp.remote-ip=46.228.253.214 ARC-Seal: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; cv=none; t=1739565952; b=xPwuqNYGQ0eAGFGRyfwh4anRtFtqfBrMOU7h5kXDlLzVlXBny3XABWt3cSG9B+G9wsA/ PEfQ1l22a8f1gGqtes44KEsui9Dl9SBb98SEghuxT6PpbVbdZGZ+0J2ixHZqNx9IyfNE1 acxg5z+Flu7X5ISXS8NCKG9GCbwS9O0PzK7NOcF0UXncf7bzHIU+X9Byxs2D5yTaOa39F tnReLasA2dMIXUzxHzTI+8mXtf4h9Cqg36P6AgUNhlA+ToF/9rEuyZ+JWe48TS0/gNq7K 4cZVfHQlQz/1JrgR+j3cfOL8AcvGecL/B21ttz4wWM/wMNOBLMorjMl4XhO8qpL+svi1o 0JA7LUmXHaTVbn5uyl7+Z5dR1OF2uu1tGRutVf71cji7qjXvnQeL65Ygk2d1A3z4Soky7 FATO9HwF2tLpEANZC7Aksh54z4EC9Nok3QRn9tLIJD4VvE5YbZ5jqOYjmesuGxkRgl2RD m6OYbJemT7Az2G+jlghogq+0Ikd+X8Qw0Ocs0hiaoZlxyoR66qRXrogjyiBTwBm8/M0yy pQ7fcd+NkbF58XZyHHxvfODuGqP+bb1I2W/Z50Jv9VZtXhG9WM+0SvKy1wPgQexxCXtI0 k0QVGS5mtQ9DgKDM76N+a1t36YXr8wBf66COQ31VwwbloLm6heVI//8MKFR2MyM= ARC-Message-Signature: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; c=relaxed/relaxed; t=1739565952; h=DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:MIME-Version:Content-Transfer-Encoding; bh=ianbSJP6MU89q0CSVCoMWfu1NYhsn60Q7ly6lHvCE5w=; b=LSZJ78zPVUeyrJX1daXA08Y2o23D4PEBao0W/FAGuWqLXGMN2Sj7qVqDCW/rnkSm3dfy QcL3ftJBHbwBl9WTqfeuZQ2TcZBpafKpRgtWkgIhsj3NqHVujbk8FGd1X22BjTz4COqfE lf7IGmFQnN83tRVdwRunlGo/avheqifL2vKZ41w/X3jaA9CHW0NOYRUKQ/mZUIy0y2HGz M93Gpfg2nafSKOLHY0tEm/ub2uwY+dWFh9+DcghaibWzMb80rHYjTYJzgIf/KoCyIYaVR MkHwS/MEv2HJ+AneWfzspYUWWLFKFVSQFJAo5O/cWZ4eem2eDmIRyg8FwygvwscCysF9H zAE2+XkUWYA9S0IrQ4bcGfOmrc09r6o3zypuVTEvaCFUtNvaLCd7PmQ50fzPwBk2ha8Ci fVUFeB6FKvkfrlt3iOqL6pDs0KEm10t5pO7MsgDUadhaclZOT5kQNppamNBvWyWczPoIw HOHEuMGjxMXrDoANjvqglHTE4vPEfjq7JzL6nmE9GIQxElivSmdsUCEnI0D48bY6PbnMj u8XhunfoJjJK4YYFOQeZ+d0BEGtNYlFBVmUUyD3IzhkGMNmIv0TW+r4PWUx/uCMCUH0Zw 5BPOQ3QqJOnKAxz9PtBxpvXXYlMmDH89YhprOxJsd7vMrYu0UR7lDvjx1fNTdr4= ARC-Authentication-Results: i=1; bugseng.com; arc=none smtp.remote-ip=46.228.253.214 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bugseng.com; s=mail; t=1739565952; bh=Yt2wbyQXx3BTPDFqXdXdqKA0/5JzMgkgfEVNWnh+UN0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FkoA6NkZ3d5/ILa9gZJUr2AoSyg3D1O50kTpjdAJ+FOfXBI0ynxXmeQ9MyZR9k+v7 NTlNEqJiFyFWQZYRGZkps1x9zD35TCocEEz7KAwZbsagFsOPOs5S5M3YvdMlJ/DTRj 7/lfPZPxyb/dKX1GKKZcn9wdJIeAYzJFUx8lKtk5sl62P4/IL2tHdedw2cDpT6t7oK ksKMM1zOJ+JP2XtYV0PRz+l/uocp0L0WIToV7NIlviuy6GUH3wuX17i55BfP6c5C7J dU9MM7+p+iTwM3UH/CZYTuFc+v5qwHLv88PXZ86EN8uC593wfZIwzXgw7SZqTDRzt+ fCoTomOuN3QyA== From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [XEN PATCH 1/3] xen/arm: platform: address violation of MISRA C Rule 7.2 Date: Fri, 14 Feb 2025 21:45:21 +0100 Message-ID: <33f3ba81af293a92fb27d55b42e620b807f1a5b3.1739564781.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 Rule 7.2 states: "A u or U suffix shall be applied to all integer constants that are represented in an unsigned type". Some PM_* constants are unsigned quantities, despite some of them being representable in a signed type, so a 'U' suffix should be present. No functional change. Signed-off-by: Nicola Vetrini Reviewed-by: Stefano Stabellini --- This fix is needed in order to keep the rule clean when the Xen configuration under static analysis is changed later in patch 3 of this series. Only PM_RSTC_WRCFG_CLR is strictly needed to conform to the rule, but the other constants have a 'U' added for consistency. PM_RSTC and PM_WDOG are used as offsets, so in principle they can be negative, therefore they are left as is. --- xen/arch/arm/platforms/brcm-raspberry-pi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/platforms/brcm-raspberry-pi.c b/xen/arch/arm/platforms/brcm-raspberry-pi.c index 407ec07f63b8..d49460329cc8 100644 --- a/xen/arch/arm/platforms/brcm-raspberry-pi.c +++ b/xen/arch/arm/platforms/brcm-raspberry-pi.c @@ -47,11 +47,11 @@ static const struct dt_device_match rpi4_blacklist_dev[] __initconst = }; -#define PM_PASSWORD 0x5a000000 +#define PM_PASSWORD 0x5a000000U #define PM_RSTC 0x1c #define PM_WDOG 0x24 -#define PM_RSTC_WRCFG_FULL_RESET 0x00000020 -#define PM_RSTC_WRCFG_CLR 0xffffffcf +#define PM_RSTC_WRCFG_FULL_RESET 0x00000020U +#define PM_RSTC_WRCFG_CLR 0xffffffcfU static void __iomem *rpi4_map_watchdog(void) { From patchwork Fri Feb 14 20:45:22 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicola Vetrini X-Patchwork-Id: 13975619 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 67BC3C021A4 for ; Fri, 14 Feb 2025 20:46:17 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.889052.1298299 (Exim 4.92) (envelope-from ) id 1tj2ZS-0008SS-Nt; Fri, 14 Feb 2025 20:45:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 889052.1298299; Fri, 14 Feb 2025 20:45:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tj2ZS-0008SJ-KS; Fri, 14 Feb 2025 20:45:58 +0000 Received: by outflank-mailman (input) for mailman id 889052; Fri, 14 Feb 2025 20:45:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tj2ZR-0008RW-H3 for xen-devel@lists.xenproject.org; Fri, 14 Feb 2025 20:45:57 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id afe48f91-eb14-11ef-9896-31a8f345e629; Fri, 14 Feb 2025 21:45:55 +0100 (CET) Received: from nico.tail608894.ts.net (unknown [46.228.253.214]) by support.bugseng.com (Postfix) with ESMTPSA id 0AF954EF5133; Fri, 14 Feb 2025 21:45:52 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: afe48f91-eb14-11ef-9896-31a8f345e629 Authentication-Results: bugseng.com; arc=none smtp.remote-ip=46.228.253.214 ARC-Seal: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; cv=none; t=1739565955; b=SRGrr3fWpxobkT6A8GTnCqfGSsQBST0I5DTyG9lsvRSxJ/stJC5nYLCHqzeOX3bL13Nz RaDeFCCB4uz2Gvk4hzwOMkS29/0It39M/KVLSohFkYnoVZcFZMaZJhdQ6qLginsodZ9C+ DZiazjAxtqeWNLQlXJFzzd98zEJ9YcydDqioBF9NT71aEwqh21uyU6Um+WIiiOB+g32U6 sKq5e67S9f3WHF3W4mB8Q4njU50sM1FdtMFVvIPuCP45+W66EaElwlEpu77b5NxCtTus3 CltaL2vgSumf3txWHo8wdQ6skthayfTjURsgk8iGJyx4V9tl6AOyrH266Wu30qUSuOjtC 0z/mzm4OmAVaRj1f3B10B4m8EJkixRrFlOwMHY8FE9sloPgwmxWn/G9h84hNeoZekORek X16AN903m+ot8Jml3ELcf5I2twsLO9Gwm5T5Frn2Ev/2JLvQR0ZBbHm6dXmwYqV9bMwwm af9Du4SpK/2tSAaZDZNdT9IzV8R0HDTEUn8MMbc1VqQ7VjZxWMElPjH/OUR/I+lVawE3g 7cEAbZcS1RKrjMBQ+vRd6zITHnL7jtuG8Dbuh1nLE8OYWXR8VABSJhc45xMph7bp5PwA/ 90Yi5RGf/jLHcNpKHfg9uxMJAWda0yNP46Do/Z2DPTbhJil4o1T7X/3rlx87cpw= ARC-Message-Signature: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; c=relaxed/relaxed; t=1739565955; h=DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:MIME-Version:Content-Transfer-Encoding; bh=F6dLZHpAftKOEJLHOuiXBv1ROWYaaj6czWWml//vfP0=; b=oviKzs0tnfmSMvkUg1ae9I4NMp+AGpxMtrjTWz7KMlJSjAJzhjnw7+x2fi4VMa5AQLTX 02YxcshJDUkm7eKlH3WpSg68eJYZNO7IzGJrSEZWRCKKe4ubxqq2t7iucAfCUv8BOknBg ltJutQGsP6DmwIXPdGpR1akJqv/2XWwJDIygwXaFgsxXgITePLxwrt6HuWEga5Q7wYfVO uEg1qH2AF1yIF4lL/kvl+73j439Zdp2AmF0ZqmTPzLVLuGZntu+y2aHkY9f5daHtJ7O5p BjqPFQSPcSyHMe+v6aDATsvC0dqaQf1as2aZgzj/92hJgQvmeFVnDjbs9LBIFHz7rY3FY ic4+U0Ch9DzgHG2WKSPSnx2wGGBauaJu5ZU4gNMrtH+Etni9GS88GJzKtacTRcyFXdd9B aX/IqN/NuMYJuUymLhlNNlwtZblFNoG97wlYNTYVRTSCNIZTL0RkxKy5ny5ivZFh7u32C oL2XuhtVyeVY6nuyb5dX6iN5s/DgZP1p0HtUoNogjQELcLw6u7SVeR+OR2ItfzoSURSzW jwtBTapXsDjAEHnQtzIQg+NZTI4B+4aZ1rYGfTheMdaQTXS3Xt5f9OuFYJanqBd6AUXdm CF8SSTinOuVKsgKvrXjK/dsjLB2oXj8PhHsFAc0qN1tgC/hlMCKg4niLvea7wDY= ARC-Authentication-Results: i=1; bugseng.com; arc=none smtp.remote-ip=46.228.253.214 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bugseng.com; s=mail; t=1739565955; bh=rEgEDMpEVP5VlbunFiK29t0Y1ZnvBhmsHk6WUsWWNG4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PO5lgtBMFI2wMxd7QJ/57rYccIJUVHSFshYS2KAkD2u825wmMrbHonalfLVmdht8m GsAJci8/YN7Ay3037S1Fq4m830N9u/IbrHUsACV18fDKe+Ig5XhrKATtZ4R83wM5Ur DRembfBxS8XQIq8vzeC1TVYfGKcVPDq00hUWImsd6EhYlwnV2eFXe5NYILGodv62Tx j3I9U5sv+ROhOPM24S/eHikJDw7szcUSQegHuoHot36KYXr0B9r1n/tEELiQTKzeHJ hgsrdKyP+Haw0d3u49oPLRVxzFrZkxgmZJcYHUHhZOIA7j4YzyEchrp4SW3UA+sQDC Ip7rjfauefO5A== From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Dario Faggioli , Meng Xu , Juergen Gross , George Dunlap Subject: [XEN PATCH 2/3] xen/sched: address violation of MISRA C Rule 8.2 Date: Fri, 14 Feb 2025 21:45:22 +0100 Message-ID: <36cd255a8d4068a66ad8cf45060d60b84b9d4c6d.1739564781.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 Rule 8.2 states: "Function types shall be in prototype form with named parameters". The parameter name is missing from the function pointer type that constitutes the first parameter. No functional change. Signed-off-by: Nicola Vetrini Reviewed-by: Stefano Stabellini Reviewed-by: Juergen Gross --- This small fix is needed in order to keep the rule clean in the follow-up patch that changes the Xen configuration under static analysis. I wasn't really certain about the right name to give to the parameter, so if there are better options I'd be happy to accept them. --- xen/common/sched/rt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/common/sched/rt.c b/xen/common/sched/rt.c index f368e0fdd5a5..0300d2d2e454 100644 --- a/xen/common/sched/rt.c +++ b/xen/common/sched/rt.c @@ -500,7 +500,7 @@ deadline_queue_remove(struct list_head *queue, struct list_head *elem) } static inline bool -deadline_queue_insert(struct rt_unit * (*qelem)(struct list_head *), +deadline_queue_insert(struct rt_unit * (*qelem)(struct list_head *q_iter), struct rt_unit *svc, struct list_head *elem, struct list_head *queue) { From patchwork Fri Feb 14 20:45:23 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicola Vetrini X-Patchwork-Id: 13975622 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34925C02198 for ; Fri, 14 Feb 2025 20:46:24 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.889053.1298309 (Exim 4.92) (envelope-from ) id 1tj2ZU-0000HW-0p; Fri, 14 Feb 2025 20:46:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 889053.1298309; Fri, 14 Feb 2025 20:45:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tj2ZT-0000HI-Sf; Fri, 14 Feb 2025 20:45:59 +0000 Received: by outflank-mailman (input) for mailman id 889053; Fri, 14 Feb 2025 20:45:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tj2ZT-0008RW-55 for xen-devel@lists.xenproject.org; Fri, 14 Feb 2025 20:45:59 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b10af914-eb14-11ef-9896-31a8f345e629; Fri, 14 Feb 2025 21:45:57 +0100 (CET) Received: from nico.tail608894.ts.net (unknown [46.228.253.214]) by support.bugseng.com (Postfix) with ESMTPSA id AA7994EF5134; Fri, 14 Feb 2025 21:45:55 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b10af914-eb14-11ef-9896-31a8f345e629 Authentication-Results: bugseng.com; arc=none smtp.remote-ip=46.228.253.214 ARC-Seal: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; cv=none; t=1739565957; b=Lla4XqTHOtWjPGen//yc8P17LwkRnoy7+pwpcaMQB7erb1t5SxAjjBQiMhiGqGkU7Mfx niub6Hj3PjPU6i2OFEo9BpzQzTZcRHbt2IZRGCDgedGYcNjP8YWxWIW31e17VR1x6Yd4t zEPdG3dBgc1yPzqt57VwMa1TFnqdJmWyCR8cSACKG/h5MIAArza1KsUtPjdXhEieyxTX2 C8mMG1Gnzj7nCVRpVBKhCSfmGx1j4dOGOo4AAq0P49CF4kiiFvfQ954yTCKT/CATlLp0R qhB1S4WWcGbcqsKpi7fEmXYGVN7xcuhaDbapvjknht6kEv/2q+OR/Hx118By1oTl05cFe Nf8KJ6k4zIxc/a3ZjhuE3hdS3Wz89vpeI1oMvWqU8jqc9mMD5Gu6jRlAypowI9LNYj+2e Q4jTV8SFvT15vNlW0wph7yMaDDy+ZzjCq/VEN5TCXBKbxw6q/ux5t02fazedWIWObyFcw VplhM0HEhH4a0mO+0JgHl/zy7yXpwAuTCTv3vO/oWUSQf7JK1uWHkupnP+Ueu7oI6siRW RqRkDn7zKnA1vhc9NAN5PDRodR77Soam4pvqgX8R8sncEDCDPsrVBEvIOvqpJtLBkHoXK gxMCyj0Ma3nNP+8ay2oBO1xnbIJXIPAY0xyAWcJmz9Lb8KdZTMQFl3b6ONWakNE= ARC-Message-Signature: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; c=relaxed/relaxed; t=1739565957; h=DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:MIME-Version:Content-Transfer-Encoding; bh=Zb+EMl98O0ZzCZxtewSKJBtly4RcCPP87vJH7H6TQLM=; b=R1TgljP1wYSt3A37rBXRMMGsrUJs3uRY73KjrUs9ILRCrJ/MbTjOAJp2mIqkPvdnyBP4 hg/YE7G2DAlNDCd6CmYdV/TKSY7PhyU7AM4hR28ZkrhLe2xF5uYZvxTlemRdhCkgCkDYp E4GpTT/wUU8Ukm/x3wK1tNaeuLKmPtvmg4ER5+d9v+RVi9IHbtuOgIbSwIEOR+hSsdGVY Z4kakiTw+Nc4DQJ90yeK2EeGoRw6C1VdQTC7E6oiWGxypXatqynwLHzvmSutzlR4cHq6j cmf7TRMfQ3bhZETtodEYoAJ4/uy7PoV1z+NSBh3d/6p5D6XtHtqi1cv18HRJqjQ/kBzqU CQcOOUGDEUTj8TUYJxF8/BIB6514x9T2T+wNnUZ+28MMw09OIXBOWorElkeYPXWMSNGYQ lqmzd0S83RfSkDqthhRMwmkv1+UljdlVGvuI0V4L+JvvZztonzJBryp53shBY2sQUUHeu YDSQKwvktGs06yOUDmkTqR8FvpqjCLhpCds39y6crwrS7lpRTnYliaVDXS+pNqDLRZLM4 fQkRfXrCu9sO1ZpW67pppfGDttN6aSmpKnA+/I5uMSsF2DAZDkt0E+tZXOa4OTVf0GM51 Vb8vVqAt7w5QSTzp9cMIoukbd3NcU0LqQMv09V0peOlQxPIMeHjxfHE0oZ3efUw= ARC-Authentication-Results: i=1; bugseng.com; arc=none smtp.remote-ip=46.228.253.214 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bugseng.com; s=mail; t=1739565957; bh=7a+q1HRRNPQx/8e6r9wT8jYCD+iO1bKhPB6DZuglAQU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LGG2RFB1OuiGBFmkRC3Gkd2axeyIMSVBYxCyxxcNvnEK8gZvgSoKQ5EfnOthHPBPJ uIqtCn8aoeXZ+QHIqc4G0QpSpTWMec4ET0qlnlD1WuYC+VbyPrICXSQNPFAFkHmbwo KmMTz1kUXZWu8bV3cXctD3bA8c5PjA7TR70RZaR/muD/sCan1BRJZT8BpcDZuCktkH SzpFpRhsIFJ/XN7czRHIkbTMopQN9akNml8nvoqlLMU5KqbIY9ALxP5AThfajVeEAl JGEsWZhn3WIjJ9xRIdMnoaxdTAvK70wJennadLn4Ejt+LR+QQECdm/h+9OgDY1UTLG O2bKUVWT80ZdA== From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Doug Goldstein Subject: [XEN PATCH 3/3] automation: Update ECLAIR analysis configuration Date: Fri, 14 Feb 2025 21:45:23 +0100 Message-ID: <31d13d891b26cdc03c85ed8fc01dea8bee505f1c.1739564781.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 The Xen configurations for the ARM64 and X86_64 ECLAIR analyses is currently held in fixed files under 'automation/eclair_analysis/xen_{arm,x86}_config'. The values of the configuration options there are susceptible to going stale due to configuration option changes. To enhance maintainability, the configuration under analysis is derived from the respective architecture's defconfig, with suitable changes added via EXTRA_XEN_CONFIG. Signed-off-by: Nicola Vetrini Reviewed-by: Stefano Stabellini --- This patch should be applied on top of the other two in the series to ensure that the CI has no failures related to clean guidelines. Note that any out of date values taken by configuration options currently in xen_*_config were determined to be benign with respect to the analysis results, but this wasn't the right approach in the long term. --- automation/eclair_analysis/prepare.sh | 8 +- automation/eclair_analysis/xen_arm_config | 141 --------------------- automation/eclair_analysis/xen_x86_config | 143 ---------------------- automation/gitlab-ci/analyze.yaml | 68 ++++++++++ 4 files changed, 73 insertions(+), 287 deletions(-) delete mode 100644 automation/eclair_analysis/xen_arm_config delete mode 100644 automation/eclair_analysis/xen_x86_config diff --git a/automation/eclair_analysis/prepare.sh b/automation/eclair_analysis/prepare.sh index 3a646414a392..4285ff26de54 100755 --- a/automation/eclair_analysis/prepare.sh +++ b/automation/eclair_analysis/prepare.sh @@ -25,18 +25,20 @@ fi export XEN_TARGET_ARCH if [ "$1" = "X86_64" ]; then - CONFIG_FILE="${script_dir}/xen_x86_config" XEN_TARGET_ARCH=x86_64 elif [ "$1" = "ARM64" ]; then - CONFIG_FILE="${script_dir}/xen_arm_config" XEN_TARGET_ARCH=arm64 else fatal "Unknown configuration: $1" fi ( + make -C xen defconfig + if [[ -n "${EXTRA_XEN_CONFIG}" ]]; then + echo "${EXTRA_XEN_CONFIG}" >> xen/.config + fi + ./configure - cp "${CONFIG_FILE}" xen/.config make clean find . -type f -name "*.safparse" -print -delete "${script_dir}/build.sh" "$1" diff --git a/automation/eclair_analysis/xen_arm_config b/automation/eclair_analysis/xen_arm_config deleted file mode 100644 index ef140ceb7383..000000000000 --- a/automation/eclair_analysis/xen_arm_config +++ /dev/null @@ -1,141 +0,0 @@ -CONFIG_CC_IS_GCC=y -CONFIG_GCC_VERSION=90400 -CONFIG_CLANG_VERSION=0 -CONFIG_LD_IS_GNU=y -CONFIG_CC_HAS_VISIBILITY_ATTRIBUTE=y -CONFIG_ARM_64=y -CONFIG_ARM=y -CONFIG_ARCH_DEFCONFIG="arch/arm/configs/arm64_defconfig" - -# UBSAN -CONFIG_UBSAN=n - -# -# Architecture Features -# -CONFIG_ARM64_SVE=n -CONFIG_64BIT=y -CONFIG_NR_CPUS=4 -# CONFIG_ACPI is not set -CONFIG_ARM_EFI=y -CONFIG_GICV3=y -CONFIG_HAS_ITS=y -CONFIG_HVM=y -# CONFIG_NEW_VGIC is not set -CONFIG_SBSA_VUART_CONSOLE=y -CONFIG_ARM_SSBD=y -CONFIG_HARDEN_BRANCH_PREDICTOR=y -CONFIG_TEE=n -CONFIG_OPTEE=n -CONFIG_FFA=n -# CONFIG_STATIC_SHM is not set -# end of Architecture Features - -# -# ARM errata workaround via the alternative framework -# -CONFIG_ARM64_ERRATUM_827319=y -CONFIG_ARM64_ERRATUM_824069=y -CONFIG_ARM64_ERRATUM_819472=y -CONFIG_ARM64_ERRATUM_843419=y -CONFIG_ARM64_ERRATUM_832075=y -CONFIG_ARM64_ERRATUM_834220=y -CONFIG_ARM64_ERRATUM_1508412=y -CONFIG_ARM_ERRATUM_858921=y -CONFIG_ARM64_WORKAROUND_REPEAT_TLBI=y -CONFIG_ARM64_ERRATUM_1286807=y -# end of ARM errata workaround via the alternative framework - -CONFIG_ARM64_HARDEN_BRANCH_PREDICTOR=y -# CONFIG_ALL_PLAT is not set -# CONFIG_QEMU is not set -# CONFIG_RCAR3 is not set -CONFIG_MPSOC=y -# CONFIG_NO_PLAT is not set -CONFIG_MPSOC_PLATFORM=y - -# -# Common Features -# -CONFIG_GRANT_TABLE=y -CONFIG_HAS_ALTERNATIVE=y -CONFIG_HAS_DEVICE_TREE=y -CONFIG_HAS_FAST_MULTIPLY=y -CONFIG_HAS_PDX=y -CONFIG_HAS_PMAP=y -# CONFIG_MEM_ACCESS is not set -CONFIG_STATIC_MEMORY=y - -# -# Speculative hardening -# -CONFIG_SPECULATIVE_HARDEN_ARRAY=y -# end of Speculative hardening - -# CONFIG_HYPFS is not set -CONFIG_IOREQ_SERVER=y -# CONFIG_EFI_SET_VIRTUAL_ADDRESS_MAP is not set -# CONFIG_XSM is not set -# CONFIG_ARGO is not set - -# -# Schedulers -# -# CONFIG_SCHED_CREDIT is not set -CONFIG_SCHED_CREDIT2=y -# CONFIG_SCHED_RTDS is not set -# CONFIG_SCHED_ARINC653 is not set -CONFIG_SCHED_NULL=y -CONFIG_SCHED_CREDIT2_DEFAULT=y -# CONFIG_SCHED_NULL_DEFAULT is not set -CONFIG_SCHED_DEFAULT="credit2" -# end of Schedulers - -CONFIG_BOOT_TIME_CPUPOOLS=y -# CONFIG_LIVEPATCH is not set -# CONFIG_ENFORCE_UNIQUE_SYMBOLS is not set -CONFIG_SUPPRESS_DUPLICATE_SYMBOL_WARNINGS=y -CONFIG_CMDLINE="" -CONFIG_DOM0_MEM="" -CONFIG_DTB_FILE="" -# CONFIG_TRACEBUFFER is not set -# end of Common Features - -# -# Device Drivers -# -# CONFIG_HAS_NS16550 is not set -CONFIG_HAS_CADENCE_UART=y -# CONFIG_HAS_IMX_LPUART is not set -# CONFIG_HAS_MVEBU is not set -# CONFIG_HAS_MESON is not set -CONFIG_HAS_PL011=y -# CONFIG_HAS_SCIF is not set -CONFIG_SERIAL_TX_BUFSIZE=16384 -CONFIG_HAS_PASSTHROUGH=y -CONFIG_ARM_SMMU=y -CONFIG_ARM_SMMU_V3=y -# CONFIG_IPMMU_VMSA is not set -CONFIG_IOMMU_FORCE_PT_SHARE=y -# end of Device Drivers - -CONFIG_EXPERT=y -CONFIG_UNSUPPORTED=y - -# -# Debugging Options -# -CONFIG_DEBUG=y -CONFIG_FRAME_POINTER=y -CONFIG_COVERAGE=y -CONFIG_DEBUG_LOCK_PROFILE=y -CONFIG_DEBUG_LOCKS=y -CONFIG_PERF_COUNTERS=y -CONFIG_PERF_ARRAYS=y -CONFIG_VERBOSE_DEBUG=y -CONFIG_DEVICE_TREE_DEBUG=y -CONFIG_SCRUB_DEBUG=y -CONFIG_DEBUG_TRACE=y -CONFIG_XMEM_POOL_POISON=y -CONFIG_DEBUG_INFO=y -# end of Debugging Options diff --git a/automation/eclair_analysis/xen_x86_config b/automation/eclair_analysis/xen_x86_config deleted file mode 100644 index abc44d43e108..000000000000 --- a/automation/eclair_analysis/xen_x86_config +++ /dev/null @@ -1,143 +0,0 @@ -CONFIG_CC_IS_GCC=y -CONFIG_GCC_VERSION=90400 -CONFIG_CLANG_VERSION=0 -CONFIG_LD_IS_GNU=y -CONFIG_CC_HAS_VISIBILITY_ATTRIBUTE=y -CONFIG_X86_64=y -CONFIG_X86=y -CONFIG_ARCH_DEFCONFIG="arch/x86/configs/x86_64_defconfig" -CONFIG_CC_HAS_INDIRECT_THUNK=y -CONFIG_HAS_AS_CET_SS=y -CONFIG_HAS_CC_CET_IBT=y - -CONFIG_REQUIRE_NX=n - -# -# Architecture Features -# -CONFIG_64BIT=y -CONFIG_NR_CPUS=16 -CONFIG_NR_NUMA_NODES=2 -# CONFIG_PV is not set -CONFIG_HVM=y -# CONFIG_XEN_SHSTK is not set -# CONFIG_XEN_IBT is not set -# CONFIG_SHADOW_PAGING is not set -# CONFIG_BIGMEM is not set -# CONFIG_HVM_FEP is not set -# CONFIG_TBOOT is not set -CONFIG_XEN_ALIGN_DEFAULT=y -# CONFIG_XEN_ALIGN_2M is not set -CONFIG_X2APIC_PHYSICAL=y -# CONFIG_XEN_GUEST is not set -# CONFIG_HYPERV_GUEST is not set -# CONFIG_MEM_PAGING is not set -# CONFIG_MEM_SHARING is not set -# end of Architecture Features - -# -# Common Features -# -CONFIG_COMPAT=y -CONFIG_CORE_PARKING=y -CONFIG_GRANT_TABLE=y -CONFIG_ALTERNATIVE_CALL=y -CONFIG_ARCH_MAP_DOMAIN_PAGE=y -CONFIG_GENERIC_BUG_FRAME=y -CONFIG_HAS_ALTERNATIVE=y -CONFIG_HAS_COMPAT=y -CONFIG_HAS_EX_TABLE=y -CONFIG_HAS_FAST_MULTIPLY=y -CONFIG_HAS_IOPORTS=y -CONFIG_HAS_KEXEC=y -CONFIG_HAS_PDX=y -CONFIG_HAS_SCHED_GRANULARITY=y -CONFIG_HAS_UBSAN=y -CONFIG_MEM_ACCESS_ALWAYS_ON=y -CONFIG_MEM_ACCESS=y -CONFIG_NEEDS_LIBELF=y -CONFIG_NUMA=y - -# -# Speculative hardening -# -CONFIG_INDIRECT_THUNK=y -CONFIG_SPECULATIVE_HARDEN_ARRAY=y -CONFIG_SPECULATIVE_HARDEN_BRANCH=y -# end of Speculative hardening - -# CONFIG_HYPFS is not set -CONFIG_IOREQ_SERVER=y -# CONFIG_KEXEC is not set -# CONFIG_EFI_SET_VIRTUAL_ADDRESS_MAP is not set -# CONFIG_XENOPROF is not set -# CONFIG_XSM is not set -# CONFIG_ARGO is not set - -# -# Schedulers -# -# CONFIG_SCHED_CREDIT is not set -CONFIG_SCHED_CREDIT2=y -# CONFIG_SCHED_RTDS is not set -# CONFIG_SCHED_ARINC653 is not set -CONFIG_SCHED_NULL=y -CONFIG_SCHED_CREDIT2_DEFAULT=y -# CONFIG_SCHED_NULL_DEFAULT is not set -CONFIG_SCHED_DEFAULT="credit2" -# end of Schedulers - -# CONFIG_LIVEPATCH is not set -# CONFIG_ENFORCE_UNIQUE_SYMBOLS is not set -# CONFIG_SUPPRESS_DUPLICATE_SYMBOL_WARNINGS is not set -CONFIG_CMDLINE="" -CONFIG_DOM0_MEM="" -# CONFIG_TRACEBUFFER is not set -# end of Common Features - -# -# Device Drivers -# -CONFIG_ACPI=y -CONFIG_ACPI_LEGACY_TABLES_LOOKUP=y -CONFIG_ACPI_NUMA=y -CONFIG_HAS_NS16550=y -CONFIG_HAS_EHCI=y -CONFIG_SERIAL_TX_BUFSIZE=16384 -# CONFIG_XHCI is not set -CONFIG_HAS_CPUFREQ=y -CONFIG_HAS_PASSTHROUGH=y -CONFIG_AMD_IOMMU=y -# CONFIG_INTEL_IOMMU is not set -# CONFIG_IOMMU_QUARANTINE_NONE is not set -CONFIG_IOMMU_QUARANTINE_BASIC=y -# CONFIG_IOMMU_QUARANTINE_SCRATCH_PAGE is not set -CONFIG_HAS_PCI=y -CONFIG_HAS_PCI_MSI=y -CONFIG_VIDEO=y -CONFIG_VGA=y -CONFIG_HAS_VPCI=y -# end of Device Drivers - -CONFIG_EXPERT=y -CONFIG_UNSUPPORTED=y -CONFIG_ARCH_SUPPORTS_INT128=y - -# -# Debugging Options -# -CONFIG_DEBUG=y -# CONFIG_CRASH_DEBUG is not set -CONFIG_GDBSX=y -CONFIG_FRAME_POINTER=y -# CONFIG_COVERAGE is not set -# CONFIG_DEBUG_LOCK_PROFILE is not set -CONFIG_DEBUG_LOCKS=y -# CONFIG_PERF_COUNTERS is not set -CONFIG_VERBOSE_DEBUG=y -CONFIG_SCRUB_DEBUG=y -# CONFIG_UBSAN is not set -# CONFIG_DEBUG_TRACE is not set -CONFIG_XMEM_POOL_POISON=y -CONFIG_DEBUG_INFO=y -# end of Debugging Options diff --git a/automation/gitlab-ci/analyze.yaml b/automation/gitlab-ci/analyze.yaml index 02e0ea692c66..35ff3620cf8e 100644 --- a/automation/gitlab-ci/analyze.yaml +++ b/automation/gitlab-ci/analyze.yaml @@ -40,6 +40,36 @@ eclair-x86_64: LOGFILE: "eclair-x86_64.log" VARIANT: "X86_64" RULESET: "monitored" + EXTRA_XEN_CONFIG: | + CONFIG_AMD=y + CONFIG_INTEL=n + CONFIG_AMD_SVM=y + CONFIG_INTEL_VMX=n + CONFIG_NR_CPUS=16 + CONFIG_NR_NUMA_NODES=2 + CONFIG_PV=n + CONFIG_XEN_IBT=n + CONFIG_XEN_SHSTK=n + CONFIG_SHADOW_PAGING=n + CONFIG_HVM_FEP=n + CONFIG_TBOOT=n + CONFIG_HYPFS=n + CONFIG_KEXEC=n + CONFIG_ARGO=y + CONFIG_SCHED_CREDIT=n + CONFIG_SCHED_RTDS=n + CONFIG_SCHED_ARINC653=n + CONFIG_LIVEPATCH=n + CONFIG_TRACEBUFFER=n + CONFIG_INTEL_IOMMU=n + CONFIG_EXPERT=y + CONFIG_DEBUG=y + CONFIG_GDBSX=n + CONFIG_FRAME_POINTER=n + CONFIG_SELF_TESTS=n + CONFIG_DEBUG_LOCKS=n + CONFIG_SCRUB_DEBUG=n + CONFIG_XMEM_POOL_POISON=n eclair-ARM64: extends: .eclair-analysis:triggered @@ -47,6 +77,44 @@ eclair-ARM64: LOGFILE: "eclair-ARM64.log" VARIANT: "ARM64" RULESET: "monitored" + EXTRA_XEN_CONFIG: | + CONFIG_NR_CPUS=16 + CONFIG_GICV2=n + CONFIG_GICV3=y + CONFIG_VGICV2=n + CONFIG_HAS_ITS=y + CONFIG_HWDOM_VUART=n + CONFIG_STATIC_SHM=y + CONFIG_STATIC_EVTCHN=y + CONFIG_STATIC_MEMORY=y + CONFIG_SCMI_SMC=n + CONFIG_PARTIAL_EMULATION=n + CONFIG_HYPFS=n + CONFIG_IOREQ_SERVER=y + CONFIG_XSM=n + CONFIG_ARGO=y + CONFIG_SCHED_CREDIT=n + CONFIG_SCHED_RTDS=n + CONFIG_SCHED_ARINC653=n + CONFIG_BOOT_TIME_CPUPOOLS=y + CONFIG_TRACEBUFFER=n + CONFIG_HAS_CADENCE_UART=n + CONFIG_HAS_NS16550=n + CONFIG_HAS_IMX_LPUART=n + CONFIG_HAS_MVEBU=n + CONFIG_HAS_MESON=n + CONFIG_HAS_OMAP=n + CONFIG_HAS_SCIF=n + CONFIG_HAS_LINFLEX=n + CONFIG_ARM_SMMU=n + CONFIG_ARM_SMMU_V3=y + CONFIG_EXPERT=y + CONFIG_DEBUG=y + CONFIG_FRAME_POINTER=n + CONFIG_SELF_TESTS=n + CONFIG_DEBUG_LOCKS=n + CONFIG_SCRUB_DEBUG=n + CONFIG_XMEM_POOL_POISON=n .eclair-analysis:on-schedule: extends: .eclair-analysis