From patchwork Mon Feb 17 05:57:52 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "zhaoyang.huang" X-Patchwork-Id: 13977094 Received: from SHSQR01.spreadtrum.com (unknown [222.66.158.135]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE572185B67; Mon, 17 Feb 2025 05:59:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=222.66.158.135 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739771995; cv=none; b=G81G0bN48Bx+0ukkB/DcA4JVVhNdTrW+51Ay9DjTynuJtGcnrS5tafpwPjcSYgDRciNuUs0wX/Ud5VERX+tYJnMP6uXfdlwu11pwdB2wge+GTbaHD9qtsYNCF0nbHd4PCOXqjWYFAzsiWVAx+qr2sy0i32CjqBjPr+2tS5Tc2NQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739771995; c=relaxed/simple; bh=g7Q+y8+A4NwlRtwNBB1WH2LjNfPbiAYgZBWEPMXGK30=; h=From:To:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=GeeknEQzcyHavlAmirHu3UKFlhcZv+f1jlyIfQKUDAFJ4E/Q+5ltdJzn7+IEDWoWvYDoSSOgdCDR4daTiKlD2cKGnTPO2ThgIRoGIDcRF9b9VZQ6SHWPo0mYrMAiIA1D9iCeUxd+p9+Bhr0XYWQwQjSKt8TCqaO0C0tP0qp1hA8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=unisoc.com; spf=pass smtp.mailfrom=unisoc.com; arc=none smtp.client-ip=222.66.158.135 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=unisoc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=unisoc.com Received: from dlp.unisoc.com ([10.29.3.86]) by SHSQR01.spreadtrum.com with ESMTP id 51H5vuDC033805; Mon, 17 Feb 2025 13:57:56 +0800 (+08) (envelope-from zhaoyang.huang@unisoc.com) Received: from SHDLP.spreadtrum.com (bjmbx02.spreadtrum.com [10.0.64.8]) by dlp.unisoc.com (SkyGuard) with ESMTPS id 4YxBfV1Qrjz2RjGfx; Mon, 17 Feb 2025 13:53:38 +0800 (CST) Received: from BJMBX01.spreadtrum.com (10.0.64.7) by BJMBX02.spreadtrum.com (10.0.64.8) with Microsoft SMTP Server (TLS) id 15.0.1497.23; Mon, 17 Feb 2025 13:57:53 +0800 Received: from BJMBX01.spreadtrum.com ([fe80::54e:9a:129d:fac7]) by BJMBX01.spreadtrum.com ([fe80::54e:9a:129d:fac7%16]) with mapi id 15.00.1497.023; Mon, 17 Feb 2025 13:57:53 +0800 From: =?eucgb2312_cn?b?u8azr9H0IChaaGFveWFuZyBIdWFuZyk=?= To: syzbot , "axboe@kernel.dk" , "linux-block@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "syzkaller-bugs@googlegroups.com" , Zhaoyang Huang , =?eucgb2312_cn?b?v7W8zbH1IChTdGV2ZSBL?= =?eucgb2312_cn?b?YW5nKQ==?= Subject: reply: [syzbot] [block?] BUG: corrupted list in loop_process_work Thread-Topic: reply: [syzbot] [block?] BUG: corrupted list in loop_process_work Thread-Index: AQHbgQDh8Pr7W9BEV0eZ2+pQanIaTg== Date: Mon, 17 Feb 2025 05:57:52 +0000 Message-ID: <1739771872662.83054@unisoc.com> References: <67afa060.050a0220.21dd3.0051.GAE@google.com> In-Reply-To: <67afa060.050a0220.21dd3.0051.GAE@google.com> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MAIL: SHSQR01.spreadtrum.com 51H5vuDC033805 #syz test Hello, syzbot found the following issue on: HEAD commit: c674aa7c289e Add linux-next specific files for 20250212 git tree: linux-next console+strace: https://syzkaller.appspot.com/x/log.txt?x=125063f8580000 kernel config: https://syzkaller.appspot.com/x/.config?x=a0fd539126ae5541 dashboard link: https://syzkaller.appspot.com/bug?extid=c104904eeb2c0edbdb06 compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40 syz repro: https://syzkaller.appspot.com/x/repro.syz?x=158a3bdf980000 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=17e18aa4580000 Downloadable assets: disk image: https://storage.googleapis.com/syzbot-assets/cc5b357d26d3/disk-c674aa7c.raw.xz vmlinux: https://storage.googleapis.com/syzbot-assets/11dcf272a27b/vmlinux-c674aa7c.xz kernel image: https://storage.googleapis.com/syzbot-assets/4e487b1c1c6e/bzImage-c674aa7c.xz mounted in repro: https://storage.googleapis.com/syzbot-assets/4ea41e9eae4d/mount_0.gz The issue was bisected to: commit 3bee991f2b68175c828dc3f9c26367fe1827319a Author: Zhaoyang Huang Date: Fri Feb 7 09:19:42 2025 +0000 loop: release the lo_work_lock before queue_work bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=161029b0580000 final oops: https://syzkaller.appspot.com/x/report.txt?x=151029b0580000 console output: https://syzkaller.appspot.com/x/log.txt?x=111029b0580000 IMPORTANT: if you fix the issue, please add the following tag to the commit: Reported-by: syzbot+c104904eeb2c0edbdb06@syzkaller.appspotmail.com Fixes: 3bee991f2b68 ("loop: release the lo_work_lock before queue_work") list_add double add: new=ffff88807fe21c70, prev=ffff88807fe21c70, next=ffff888024c29160. ------------[ cut here ]------------ kernel BUG at lib/list_debug.c:37! Oops: invalid opcode: 0000 [#1] PREEMPT SMP KASAN PTI CPU: 1 UID: 0 PID: 12 Comm: kworker/u8:1 Not tainted 6.14.0-rc2-next-20250212-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 12/27/2024 Workqueue: loop0 loop_workfn RIP: 0010:__list_add_valid_or_report+0xa4/0x130 lib/list_debug.c:35 Code: f7 74 11 b0 01 5b 41 5c 41 5d 41 5e 41 5f 5d c3 cc cc cc cc 48 c7 c7 40 e5 60 8c 4c 89 fe 4c 89 e2 4c 89 f1 e8 fd 88 35 fc 90 <0f> 0b 48 c7 c7 40 e3 60 8c e8 ee 88 35 fc 90 0f 0b 48 c7 c7 e0 e3 RSP: 0018:ffffc90000117628 EFLAGS: 00010046 RAX: 0000000000000058 RBX: 1ffff1100ffc438e RCX: 89e05f8d6ffcb000 RDX: 0000000000000000 RSI: 0000000080000001 RDI: 0000000000000000 RBP: 1ffff1100498522d R08: ffffffff819f562c R09: 1ffff92000022e60 R10: dffffc0000000000 R11: fffff52000022e61 R12: ffff88807fe21c70 R13: dffffc0000000000 R14: ffff888024c29160 R15: ffff88807fe21c70 FS: 0000000000000000(0000) GS:ffff8880b8700000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007ff4b64ffe00 CR3: 000000007cfa4000 CR4: 00000000003526f0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Call Trace: __list_add_valid include/linux/list.h:88 [inline] __list_add include/linux/list.h:150 [inline] list_add_tail include/linux/list.h:183 [inline] loop_process_work+0x1f96/0x21c0 drivers/block/loop.c:1977 process_one_work kernel/workqueue.c:3236 [inline] process_scheduled_works+0xa66/0x1840 kernel/workqueue.c:3317 worker_thread+0x870/0xd30 kernel/workqueue.c:3398 kthread+0x7a9/0x920 kernel/kthread.c:464 ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:148 ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244 Modules linked in: ---[ end trace 0000000000000000 ]--- RIP: 0010:__list_add_valid_or_report+0xa4/0x130 lib/list_debug.c:35 Code: f7 74 11 b0 01 5b 41 5c 41 5d 41 5e 41 5f 5d c3 cc cc cc cc 48 c7 c7 40 e5 60 8c 4c 89 fe 4c 89 e2 4c 89 f1 e8 fd 88 35 fc 90 <0f> 0b 48 c7 c7 40 e3 60 8c e8 ee 88 35 fc 90 0f 0b 48 c7 c7 e0 e3 RSP: 0018:ffffc90000117628 EFLAGS: 00010046 RAX: 0000000000000058 RBX: 1ffff1100ffc438e RCX: 89e05f8d6ffcb000 RDX: 0000000000000000 RSI: 0000000080000001 RDI: 0000000000000000 RBP: 1ffff1100498522d R08: ffffffff819f562c R09: 1ffff92000022e60 R10: dffffc0000000000 R11: fffff52000022e61 R12: ffff88807fe21c70 R13: dffffc0000000000 R14: ffff888024c29160 R15: ffff88807fe21c70 FS: 0000000000000000(0000) GS:ffff8880b8700000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007ff4b64ffe00 CR3: 000000007cfa4000 CR4: 00000000003526f0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 --- This report is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at syzkaller@googlegroups.com. syzbot will keep track of this issue. See: https://goo.gl/tpsmEJ#status for how to communicate with syzbot. For information about bisection process see: https://goo.gl/tpsmEJ#bisection If the report is already addressed, let syzbot know by replying with: #syz fix: exact-commit-title If you want syzbot to run the reproducer, reply with: #syz test: git://repo/address.git branch-or-commit-hash If you attach or paste a git patch, syzbot will apply it before testing. If you want to overwrite report's subsystems, reply with: #syz set subsystems: new-subsystem (See the list of subsystem names on the web dashboard) If the report is a duplicate of another one, reply with: #syz dup: exact-subject-of-another-report If you want to undo deduplication, reply with: #syz undup From 4fca4916e323224267fe1d6c8ca332824ebf7808 Mon Sep 17 00:00:00 2001 From: Zhaoyang Huang Date: Mon, 17 Feb 2025 10:40:59 +0800 Subject: [RFC PATCH] loop: fix __list_add_valid in loop driver Oops reported by syzbot[1] which introduced by commit 3bee991f2b68 of linux-next(loop: release the lo_work_lock before queue_work). This should be caused by bellow race scenario and could be fixed by subsituting the judge if working_pending to list_empty. mainline before 3bee991f2b68: T0 kworker/u0:1 loop_queue_work() { process_one_work() { if(!work_pending) set_work_pool_and_clear_pending() queue_work() { set_work_data(WORK_PENDING) spin_unlock(worker->lock) } loop_process_work { spin_lock(worker->lock) if(!work_pending) //FAILED HERE list_add(&work->idle_list) linux-next after 3bee991f2b68: T0 & kworker/u0:0 kworker/u0:1 loop_queue_work() { process_one_work() { set_work_pool_and_clear_pending() spin_unlock(worker->lock) loop_process_work() { spin_lock(worker->lock) if(!work_pending) //FIRST ADD list_add(&work->idle_list) if(!work_pending) queue_work() set_work_data(WORK_PENDING) spin_unlock(worker->lock) } process_one_work() { set_work_pool_and_clear_pending() loop_process_work() { spin_lock(worker->lock) if(!work_pending) //SECOND ADD list_add(&work->idle_list) BUG(...) [1] list_add double add: new=ffff88807fe21c70, prev=ffff88807fe21c70, next=ffff888024c29160. ------------[ cut here ]------------ kernel BUG at lib/list_debug.c:37! Oops: invalid opcode: 0000 [#1] PREEMPT SMP KASAN PTI CPU: 1 UID: 0 PID: 12 Comm: kworker/u8:1 Not tainted 6.14.0-rc2-next-20250212-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 12/27/2024 Workqueue: loop0 loop_workfn RIP: 0010:__list_add_valid_or_report+0xa4/0x130 lib/list_debug.c:35 Code: f7 74 11 b0 01 5b 41 5c 41 5d 41 5e 41 5f 5d c3 cc cc cc cc 48 c7 c7 40 e5 60 8c 4c 89 fe 4c 89 e2 4c 89 f1 e8 fd 88 35 fc 90 <0f> 0b 48 c7 c7 40 e3 60 8c e8 ee 88 35 fc 90 0f 0b 48 c7 c7 e0 e3 RSP: 0018:ffffc90000117628 EFLAGS: 00010046 RAX: 0000000000000058 RBX: 1ffff1100ffc438e RCX: 89e05f8d6ffcb000 RDX: 0000000000000000 RSI: 0000000080000001 RDI: 0000000000000000 RBP: 1ffff1100498522d R08: ffffffff819f562c R09: 1ffff92000022e60 R10: dffffc0000000000 R11: fffff52000022e61 R12: ffff88807fe21c70 R13: dffffc0000000000 R14: ffff888024c29160 R15: ffff88807fe21c70 FS: 0000000000000000(0000) GS:ffff8880b8700000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007ff4b64ffe00 CR3: 000000007cfa4000 CR4: 00000000003526f0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Call Trace: __list_add_valid include/linux/list.h:88 [inline] __list_add include/linux/list.h:150 [inline] list_add_tail include/linux/list.h:183 [inline] loop_process_work+0x1f96/0x21c0 drivers/block/loop.c:1977 process_one_work kernel/workqueue.c:3236 [inline] process_scheduled_works+0xa66/0x1840 kernel/workqueue.c:3317 worker_thread+0x870/0xd30 kernel/workqueue.c:3398 kthread+0x7a9/0x920 kernel/kthread.c:464 ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:148 ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244 Modules linked in: ---[ end trace 0000000000000000 ]--- RIP: 0010:__list_add_valid_or_report+0xa4/0x130 lib/list_debug.c:35 Code: f7 74 11 b0 01 5b 41 5c 41 5d 41 5e 41 5f 5d c3 cc cc cc cc 48 c7 c7 40 e5 60 8c 4c 89 fe 4c 89 e2 4c 89 f1 e8 fd 88 35 fc 90 <0f> 0b 48 c7 c7 40 e3 60 8c e8 ee 88 35 fc 90 0f 0b 48 c7 c7 e0 e3 RSP: 0018:ffffc90000117628 EFLAGS: 00010046 RAX: 0000000000000058 RBX: 1ffff1100ffc438e RCX: 89e05f8d6ffcb000 RDX: 0000000000000000 RSI: 0000000080000001 RDI: 0000000000000000 RBP: 1ffff1100498522d R08: ffffffff819f562c R09: 1ffff92000022e60 R10: dffffc0000000000 R11: fffff52000022e61 R12: ffff88807fe21c70 R13: dffffc0000000000 R14: ffff888024c29160 R15: ffff88807fe21c70 FS: 0000000000000000(0000) GS:ffff8880b8700000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007ff4b64ffe00 CR3: 000000007cfa4000 CR4: 00000000003526f0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Reported-by: syzbot+c104904eeb2c0edbdb06@syzkaller.appspotmail.com Fixes: 3bee991f2b68 ("loop: release the lo_work_lock before queue_work") Signed-off-by: Zhaoyang Huang --- drivers/block/loop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/loop.c b/drivers/block/loop.c index 68c943a77e41..2bcdd9646ac3 100644 --- a/drivers/block/loop.c +++ b/drivers/block/loop.c @@ -1972,7 +1972,7 @@ static void loop_process_work(struct loop_worker *worker, * *and* the worker will not run again which ensures that it * is safe to free any worker on the idle list */ - if (worker && !work_pending(&worker->work)) { + if (worker && list_empty(&worker->idle_list)) { worker->last_ran_at = jiffies; list_add_tail(&worker->idle_list, &lo->idle_worker_list); loop_set_timer(lo); -- 2.25.1