From patchwork Mon Feb 17 14:04:46 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alexandre Courbot X-Patchwork-Id: 13977900 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 544BCC021AD for ; Mon, 17 Feb 2025 14:05:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D718710E4D2; Mon, 17 Feb 2025 14:04:59 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.b="N71tKTwH"; dkim-atps=neutral Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2077.outbound.protection.outlook.com [40.107.220.77]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0C1C110E4D3; Mon, 17 Feb 2025 14:04:58 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lqI7tRq9WKOwiU2avy/i0aXSPqomDbRSYk3sj2blaESVdvxUh11pFB7uXbJ44+5tvB2e0IdN2vnJ/OrnA6fCwQ5MLjh1EhUsJJ0cmA3Cpl5DX7/S/djHIUu51UrZeRoGoPu17WnD74hma1g8Vf7rjgiu51pLDQYnG6f7vxnUMT9D6rIJIpEQcqvw1b7bVPgWNbXnueBShJIH5yQcFLkka/oYLN9OJ41f92UlArhINcX1YC/JzwcvBjjirCHuE6w0HJIaLwr6KH9VRrjFAFeMPRYm7fXOTRtHC2XMjkLYYpERdxupYfPm/jOMvBp4aqPWdDlfy4fuCTWbHj4Iae2OvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0giXkbfZ97KCjGxEv6E3orDPpMhefyg3MZB6wGUVyZU=; b=OCS3w/aKNWSFqzYNkgY4UBh+IWm+UF+iI7cddfdHMFpYq+j9d7b5a4jJDDJy+FpPKDPFfstsUMW+lQGNUqGfy3rzwq2MV0kRDoxNDkh1f7xOFCrS2mQGQ+GojwvjmT0nuj+TIF4/3cV/IZTBTd1DaUIRl+oNstthLrt8xQtwGAwdN14RMhbJHoaB9SnDwEWaHWE35odGPC3f12l4bub6YI0rcGRlF+osbIRIUCqrxeiyY9PIb/430St7zdgiQUAmYojOCVN4UYa1qi0nb0gOJvYuVEjwSOSnZu2AQ2MLT07xe+B05Ypz8VvO+tmQD8+zV7d8FaWNqqca7J6vdWUOOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0giXkbfZ97KCjGxEv6E3orDPpMhefyg3MZB6wGUVyZU=; b=N71tKTwHE3jAqtiXzc4PuN7swJWQUCaFFub9whQVP8awHWZHnSgvNWEDf/IYe0YYd59CJPqRYhcoDcps+yhnoqAmByHsO9CS9+SL86Lhr+Saon7q/XHcvumKeTTqGQMjGyQbA3zwokO1sisS9/3SXecWcAFHmCr2j/OpnGa2BL6o4G8VkS+Dz1HFD1Ml4uXwXHqG+tA1Y7axJt61u9DAds/nPRkluVBkeWJoUsV4luKaShe1vUnTQJJ1ShNikjMftFHyQje89Zcn3iTmO8Q3iRMLGuimU0lxilMVjm4+HFdjInzoUC+eHWbIpB0ohH2mJCYx1CTQwfUh9lPdUOMPdQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by MN2PR12MB4208.namprd12.prod.outlook.com (2603:10b6:208:1d0::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8445.19; Mon, 17 Feb 2025 14:04:54 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::6e37:569f:82ee:3f99]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::6e37:569f:82ee:3f99%6]) with mapi id 15.20.8445.017; Mon, 17 Feb 2025 14:04:54 +0000 From: Alexandre Courbot Date: Mon, 17 Feb 2025 23:04:46 +0900 Subject: [PATCH RFC 1/3] rust: add useful ops for u64 Message-Id: <20250217-nova_timer-v1-1-78c5ace2d987@nvidia.com> References: <20250217-nova_timer-v1-0-78c5ace2d987@nvidia.com> In-Reply-To: <20250217-nova_timer-v1-0-78c5ace2d987@nvidia.com> To: Danilo Krummrich , David Airlie , John Hubbard , Ben Skeggs Cc: linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alexandre Courbot X-Mailer: b4 0.14.2 X-ClientProxiedBy: TYCP301CA0076.JPNP301.PROD.OUTLOOK.COM (2603:1096:405:7b::10) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|MN2PR12MB4208:EE_ X-MS-Office365-Filtering-Correlation-Id: afccc283-ab71-4a81-ad63-08dd4f5c0dd0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|10070799003|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?q?jg1pVBPS5dL8gBR9vV6Ckp2hY3SDuwa?= =?utf-8?q?9zFIpOFGAE2pMHozEcBU3edZLC9bYrQv34jGuNwfZY0vWbZS1IRoKYcCXX6fUNBGm?= =?utf-8?q?wMcR/LjlAA2qyTNbApAASz3KcsCo2D5BJmckW5slnEI/39ipYLAvPDNUH2eEIfrxK?= =?utf-8?q?F3tr0AxyubRoDnse+oRQp1M4xHN0Gitj5d83p1Ohw2T/4+JhL1yTFuJiDZho7u7hC?= =?utf-8?q?ER4wKzSZRsD5t/OtTT5nxM+L3zXYHdBIavz/u9J/87ZQz/nBJqU7INYDW28IU8U5O?= =?utf-8?q?zdBx1ClOlMUoqb3JC+dIIidfa27XJdOa/cXyc685836NgJrhyB2dZrPB/WMurTQG/?= =?utf-8?q?tKxz4nmoacVD46BUCmwzGpJ3qlMWkvuOlDijKuHHEt4O+gwvAO//ZHpCuBSg20A7S?= =?utf-8?q?eo7gFGBsOaWJBxotIrTD7LDtsIRVWFubBaX793QEUk4GPCp4iv3tstJ72hYUxRXYG?= =?utf-8?q?jEv2HdvutLC4TQMRS8GVgV+WQcAJMJu14x9DwqPBvDPwkfYxOa2gOhS6UHc3iyucl?= =?utf-8?q?E0BqVkiYLWK6v7Qj94xRk8dArYC/yHlD5OaimEk0ZiS6QT8OeOfhjK7SXapcaVbei?= =?utf-8?q?R5KH++6UqleQJRt1TKc7eFcPr0h5eX9U3svtOradBEI54iAnjAZpLIX6WdsEB4E8Q?= =?utf-8?q?YBOkdGY7G3ayor53euS0PCYHai9AYO9Zs6S5IfEw+rwCNpwhW8Hx3HqRMtkOO6TyC?= =?utf-8?q?Saz5TXwzn6dJdT1uHNPidGXsQv3+Wm4g8ZnhuVyB/ILqf2l5eFks57/Ip0mwNbVyU?= =?utf-8?q?vKkIitKQemgEibDqw2wQ3z10H8LuodVBTkM+r4MFDoFjGh/epvIwhghZY5hxf+5BN?= =?utf-8?q?YS70Mzz8WsmsipUVfkLft7UEEWtAO71FPris4KS+Ym0pRIi+ff+gdYa8EdKMYwT12?= =?utf-8?q?Tkowt/uBPYRG7FQ2+Lfy3nLSW8JUgDNt8YRi8Hrl+g+THYy5tWnUS+u5uFtXfI9+O?= =?utf-8?q?7qobDESTYm0E9ZVwqBHUYJtr7000kNY2C4wWdsx5gZaJfMrBAZYIvawYkxSIzJpmi?= =?utf-8?q?MZVjTXDr9MEoXQ6Z1V/wjA417RMZtHsfqqOKqOas7bga2e3BN6vi6wJR5TcIqULNi?= =?utf-8?q?OHH23BuqO5ClYI0XbcOTJl8EfoQAixAqJyjQ3kg8WS3JGhFIo4hRNOUBl4AZjJC4B?= =?utf-8?q?kGTL9Z9G8Cw+7qtnsfWn4/DQp78rELXBwF5Oy0TbVEToFuy9h4AvPjtIBvVPBEF9p?= =?utf-8?q?4EvM5nwHrwkmkbFMtHpczjuDLrZpmxI2ta722Y+NyUDnQ+XcLgo6bqabi6kyDY0Fw?= =?utf-8?q?QoSBdRV9yNpx/9Jo4Oh5MhPXUtfDKYS4pG/Ao0Ter50sZX1lakw+/7hMdchsKDIFP?= =?utf-8?q?2sf1VV6PvsRa?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB3990.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(10070799003)(376014)(366016)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?Zc0q47i92E/gDnnxIJ6Ljp8+Vkzr?= =?utf-8?q?FIVvaB8dGKNm4/TD7I/z+fpRv8VsFLT4i1HmOv8s2iZaPtuEhgen1gH/aqR2twEps?= =?utf-8?q?AkrQio/PAy3ztVJ9qXFo700cZUaDODPgoVtFS90c26yFGKnHghaGfokDP0FXFeQen?= =?utf-8?q?KJ3XAvYjRueKLafM1q7cu89psqokS7Cht0+l5Wij0Wplv0i2WYs4Z5Fx/bcLkwtEB?= =?utf-8?q?htRscPC96osyFPhL9ELsh7n00UF9LLZCVi1U7ESN7giNoEPoK0cmrdZyaIQT4sxJj?= =?utf-8?q?wZOP9wQ5kWyFPj7FRKWQ0iMD/U/+okZ+RTwrpDV8WGwhBBw+l3H60kHNoLAsrEWNp?= =?utf-8?q?fys6W5Sp/KIWyBkCpfJYZUvKJXWaNV66ixd9Wvcq9q70mFavo2bPdqyJMdMRH9kkM?= =?utf-8?q?TDzK0mmOkD543ddk+LeNbWPu4FxxqtRda2z8uwM9ptHb96FkyjKj33cHY4BW67B+A?= =?utf-8?q?vOwcNPLxyue4XVBIQ8vB4tYZmKQG2pW1GYsbvsACfkuwyqoBqPy5bqGIgvR7cChKK?= =?utf-8?q?njfjbwfgVu7Hjxa8CNAiWxCKkCVovgGTQWKphGnjRezhpNLCa7Ls7bGjCSTcJ2U97?= =?utf-8?q?A7S5veQ9CdhIlABJvD24UL87oO/Pn4BAqgIaldQSzReIM5w7GfaOwFfrYYorUCbO5?= =?utf-8?q?jeTLn/WFLKbhJ1tOrTGKSt7ZEYO7d/UUz/nNSUNKxhANvTUJKZpyx2HBd8/iyd6Qg?= =?utf-8?q?sFMwqVKlseI/HhH9MUvyETiGnaeWrB8F2jBSSET26hU4FD5x5Z2dWjZdP5CKiaCm/?= =?utf-8?q?zVpLjt6qfJxx+fz0xPPsFPAZH6DjPqsZGRrnQkjW/ym8lrejf/1dzMdirqViFGnmq?= =?utf-8?q?1AJkk60k8h3nE/V2uPiVfTsRO8pWropuEazbAN/HBG9b4dHiYZu1qwdcHbDt6TTgi?= =?utf-8?q?DTqVbaAKxyYwXuW979fSm50iVpJbIIpSUmuhZv+moIAyp3lANg1bZu4x0bLT90QbD?= =?utf-8?q?+uYsHYR0GzHy8ESiWrjXzjh3ORqTfZdnixtjQbI0PtqxwdSI6yLkWa0+dg5k/ANpK?= =?utf-8?q?fveVAbpHAh2f3g/22kvxMqnw0hTXPpMWmcw/Eh4SfZD1O/H5I6OHr8PPfAdKs3L16?= =?utf-8?q?5QeNcNgKcXidrqomadf0VMIFz1SBEZLe0fBRhUROF7nWl8jUYTtstc5bxeA14r08d?= =?utf-8?q?fSS403VpvcYXD+dBuJBea8aHGI4FddGfrASXZbCNjpo5xZiTZwSHSq7Zw1Jy8ciTn?= =?utf-8?q?8qw1m/DGtwMV9u0BM2nSycL2lHSLvndXbrmw1wxE5ec17uDEioPfocMPRiX/82Y6i?= =?utf-8?q?lnFoGlDz8d9iBxpoIuVkoUSSzbC5ZJO/9Y380o+WXmL74hU4JRSbNLLc19mkDNIZ6?= =?utf-8?q?uvcjER26A7Mt5NfbS7JOv8JbOONvSUL4HF5chTJnofqrpL3Thz3QQ6GkljDgIT1K9?= =?utf-8?q?tX8sPR+h0FaMHvjpC6/3n6r8PofYZb6xXptZRMWrLJw7p++6ataNd2vHj6cKCzrAL?= =?utf-8?q?UcNWN4FdErnLtjdz6pjjXMbpWVcXTGyf1U8QJPz7DWoMK27DPGHc7SpGvv6P6BMuK?= =?utf-8?q?XnYMEfQjeNCdQxxoKbDFe4zssRyHuutRbORSiaaYzxKjPsepyT3whTxoJUMg60rxl?= =?utf-8?q?xKV2MYtcSuI?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: afccc283-ab71-4a81-ad63-08dd4f5c0dd0 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2025 14:04:54.6271 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nqfm1WcBo9gcf+0UtFOIXPq3avpG4vTlCEYISPhcOoyu7zAxQkca1alO6bNlss8ij4TYUJna1V4HlqNjZ2eDBQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4208 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" It is common to build a u64 from its high and low parts obtained from two 32-bit registers. Conversely, it is also common to split a u64 into two u32s to write them into registers. Add an extension trait for u64 that implement these methods in a new `num` module. It is expected that this trait will be extended with other useful operations, and similar extension traits implemented for other types. Signed-off-by: Alexandre Courbot Reviewed-by: Sergio González Collado --- rust/kernel/lib.rs | 1 + rust/kernel/num.rs | 32 ++++++++++++++++++++++++++++++++ 2 files changed, 33 insertions(+) diff --git a/rust/kernel/lib.rs b/rust/kernel/lib.rs index 496ed32b0911a9fdbce5d26738b9cf7ef910b269..8c0c7c20a16aa96e3d3e444be3e03878650ddf77 100644 --- a/rust/kernel/lib.rs +++ b/rust/kernel/lib.rs @@ -59,6 +59,7 @@ pub mod miscdevice; #[cfg(CONFIG_NET)] pub mod net; +pub mod num; pub mod of; pub mod page; #[cfg(CONFIG_PCI)] diff --git a/rust/kernel/num.rs b/rust/kernel/num.rs new file mode 100644 index 0000000000000000000000000000000000000000..5e714cbda4575b8d74f50660580dc4c5683f8c2b --- /dev/null +++ b/rust/kernel/num.rs @@ -0,0 +1,32 @@ +// SPDX-License-Identifier: GPL-2.0 + +//! Numerical and binary utilities for primitive types. + +/// Useful operations for `u64`. +pub trait U64Ext { + /// Build a `u64` by combining its `high` and `low` parts. + /// + /// ``` + /// use kernel::num::U64Ext; + /// assert_eq!(u64::from_u32s(0x01234567, 0x89abcdef), 0x01234567_89abcdef); + /// ``` + fn from_u32s(high: u32, low: u32) -> Self; + + /// Returns the `(high, low)` u32s that constitute `self`. + /// + /// ``` + /// use kernel::num::U64Ext; + /// assert_eq!(u64::into_u32s(0x01234567_89abcdef), (0x1234567, 0x89abcdef)); + /// ``` + fn into_u32s(self) -> (u32, u32); +} + +impl U64Ext for u64 { + fn from_u32s(high: u32, low: u32) -> Self { + ((high as u64) << u32::BITS) | low as u64 + } + + fn into_u32s(self) -> (u32, u32) { + ((self >> u32::BITS) as u32, self as u32) + } +} From patchwork Mon Feb 17 14:04:47 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandre Courbot X-Patchwork-Id: 13977901 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 364D6C021AA for ; Mon, 17 Feb 2025 14:05:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 75B3F10E488; Mon, 17 Feb 2025 14:05:03 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.b="n/zGG2sw"; dkim-atps=neutral Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2089.outbound.protection.outlook.com [40.107.236.89]) by gabe.freedesktop.org (Postfix) with ESMTPS id 23FDE10E4CC; Mon, 17 Feb 2025 14:05:01 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pH0HqmU77/bKFOEiP0Xaz/RmSxZhPr1X11NikqD4lBTSZNbbEOagDpaDdkD3XCNV5nnEvBP9hsfbYyW/nyBXle+qNCEx5ChwrC3PkhVZBauet1kvfLK3bFG+OLqwVMLjxM4BfZfJJCn3NK1yeOocs2Xe6VW9/rZvya1rLhwrXf4k9WL2kFd7/UGrr/tD0uGtThE1q8bp6w9Lx/GQ0gSxxOCKs7t1q12dF1659s6e2R1SzMSKpYwqM7nKs82SlU+oz6CgxtcGvkCVa/4ACw1JFGr4/PHONo5KSCYu2rNoDBoyHv5U/ATzUINig8YoPOGSBcMyPh068PUe446RtPoWNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WdBRs2AA2V0j6HXXiO7Ggy7uRBITJWic5eW1ClXT9Ys=; b=Mi8rhik+5lKXVXOdkpkSNd8syA9VD0o4LbvZ3Psm1VCBT68ARP9dCtM0zDCCia33iWkSievFStErbcLZNWPC9CTj9XDVwjrvDLUn7bM7Xrr2to1IFgbvR4TvmJLlP3LxFWGVO41Rh7YCtBdDVObnIOkz8/LJxz4MuqVKZ9j2lEs3VGRbe4x0hMO4I1KlnMLhv1mtQ1ko/ALTjn9V8egDtIuDCjS3WDiw17xX2U8rmqggDnbm1Gu4Iav4Y9EZMgvm6hjIRmV+uz0jh99q045JLIpWGbiAAYSsN5f2+wjS+vtdjaetYHdrxRt8RXWPaPbow2KrVnAa0GjwKcSaNxLM6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WdBRs2AA2V0j6HXXiO7Ggy7uRBITJWic5eW1ClXT9Ys=; b=n/zGG2swV1sFFYzVnbSJVCAxLpUYiH3hPeUbI1p63vro1BLi09kNuH/sJDtmzjfT7inuCa3NFy1i0uIRlsCU4u90XpJTutjCns2AClSrV+bZrh4m3l6RpbpNQo6M11PDw2ii6bc02lY9UOReeip2RokU/F/Pk1LBOqGXPkzZWUXzOiuMdLZiqOIJM5Nmajqdy63xpa0GzGd0vhswTlg8OjQ2Mbl6PzvbrYiLHtjSQqvuZGs6oJB2qK1bSwFkobQ/AEfAePNK2wPZ9fhDduwNecq/8xS8hErlEVZPbbX56ENgT1z0bGU/lqmDJ8FKRLFl9/BcfxS7IRbzLLSBRi/YSQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by MN2PR12MB4208.namprd12.prod.outlook.com (2603:10b6:208:1d0::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8445.19; Mon, 17 Feb 2025 14:04:57 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::6e37:569f:82ee:3f99]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::6e37:569f:82ee:3f99%6]) with mapi id 15.20.8445.017; Mon, 17 Feb 2025 14:04:57 +0000 From: Alexandre Courbot Date: Mon, 17 Feb 2025 23:04:47 +0900 Subject: [PATCH RFC 2/3] rust: make ETIMEDOUT error available Message-Id: <20250217-nova_timer-v1-2-78c5ace2d987@nvidia.com> References: <20250217-nova_timer-v1-0-78c5ace2d987@nvidia.com> In-Reply-To: <20250217-nova_timer-v1-0-78c5ace2d987@nvidia.com> To: Danilo Krummrich , David Airlie , John Hubbard , Ben Skeggs Cc: linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alexandre Courbot X-Mailer: b4 0.14.2 X-ClientProxiedBy: TYAPR01CA0106.jpnprd01.prod.outlook.com (2603:1096:404:2a::22) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|MN2PR12MB4208:EE_ X-MS-Office365-Filtering-Correlation-Id: 3b815ea6-1c48-42a7-8c33-08dd4f5c0fc6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|10070799003|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?q?PilbYj/oZL/EkobplmdLxuOCROQNjpa?= =?utf-8?q?ah/ZGSUJjeKOCevXOL00I/uOq5UmZ9nbww8uBVy+NxN6eSMQZf05/DUsK9cAce3e4?= =?utf-8?q?zwBXhGfKIu8gWRvoWxhsnnhWcQnn6jj6GFW50DwZzrnwot9PTZjA66xJe9iVHa6kS?= =?utf-8?q?VbHMOUkbHHmxLL2dKpdPUee66TuBluI+Ka0RNcjCh9l+2fcWdXinT81boTglDPpSv?= =?utf-8?q?1Z5Q8LLoJL0QTpkyYKS3nF4ayrGkWE4M/5iWgmyKfDGvXMXV0deiX30QbQAVFx6UQ?= =?utf-8?q?bGFPEgImFEaobskO/FxQT1cTa2hMM69auOWMmtX/im+8DH+k0jwuzTXxK8WV23G2C?= =?utf-8?q?KpmRIwIcU8hjOcHTOrudXt+qAm8l9I+xjtlI1KE/XrEjTMcg4CDDESjNdnNg7sjub?= =?utf-8?q?TDt5f+d+WR0g+hXZRxS7OMzkrN3WQr9e7md/5CNfsDh4Rb8omWYO/xgNSEzwjIj4z?= =?utf-8?q?nlh2396DxpEU1a+946TnWXKLHGgv7OP6hrJUSKP+zvTZutVFAlSfcoACEk34t1yRp?= =?utf-8?q?UNDcAlfHLFoT2h30Za+XjUYM1eB5JSRLdiQLoaVO2GDLxxnizZSupS/rzn14ZT1Qi?= =?utf-8?q?O+E+Gj3QHtMNYT+tCiCTe6DxBbKTPZZ03n94uB+mrrPtSdce5OhyThtPH1Eat9lCu?= =?utf-8?q?cZ5luHkvv+3bTsF2eO50PyLSHqgA61+NH3nDZU4aA7qfHVNmPJR706Ky6T4b9lXrf?= =?utf-8?q?/Rxy+OzDYMkgABhhjT90BUw1tO6agk88i8fstjoEQFaTnG5sU48WoGeZdvGlnw4I1?= =?utf-8?q?adC/OZRC7FVm4TEAOY6Mgird4nllhSt0p2JadWQiOCtvF06RQQH5SMeRl3AiKTLxm?= =?utf-8?q?5gesSIoJOfU9PGn7GzgfdKuHTbrbmW5u7GlldCvHBPaJ+wOWfFgaocm5jf+J8YDlL?= =?utf-8?q?OOVWMQlgkQY62bqNmXyvkJrTmP+L8VMpX6gafvBd/F4/spGlPH9zVF1nRT+Q3/fPc?= =?utf-8?q?PsUlalgIyAek3FaJEGA2htnHZJ5C6cihsav8neNEnwlDZa/SeWf0icVQS6i7W2VLn?= =?utf-8?q?7xvE8Yhx1T6XBEr+a3923ZxDvBNAq3yBWuUlYjLhvBODVZet473VD+vhj0iLzaU/i?= =?utf-8?q?/VqvRwdezed5xqTcH/ADx50Sc/tJuxxq7Nu5ein9pENR+yMtGVGkTQWsQ+oZBG9rQ?= =?utf-8?q?0l+U++NjUkU95WPU/gXQSaIR2KiRo/4UN6eTHzF9OooIOwDOC8qBhVGqXfm0iAH3w?= =?utf-8?q?nx4SekbgahkUBxqzvrCSXeVUhQY92cB3/+cU5VmS9m3Pp46pq3mpeCaXJU9rwfMkR?= =?utf-8?q?9K4qYWTmLRpL/6rUn5ZZAkcL+nrdNZf69mjL/jKUdTV4ymsE8jmCBTlW4KPKjoGmL?= =?utf-8?q?KHbfeHw9Yrqe?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB3990.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(10070799003)(376014)(366016)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?a0VyfEZcgtgNHyk1XVyVZszYTtfd?= =?utf-8?q?XM9tkjiEA7m8oQ9X39PWPr3NXrGn/rJ8iSHP16JeTl3uD0CihCEhg1TMYiOPGFH2I?= =?utf-8?q?L7HRSBL7jEvJ4ira1NJV29Dez6Zoj/k4DIdY7an7h/zeXH10gPXyMCVDzEt+FHJHg?= =?utf-8?q?pXdu2+qGhrwCJyh3g1IsC3X7vufAXGP7Hu1GLE98isRvMpMAE/IXYoJnuWCQiciwB?= =?utf-8?q?upKy9vSg9fkT+LTj67lWzg/SQidEh3fJ5V8YFuqr/KQRFustWd1kWlDciAyLgSP09?= =?utf-8?q?PcQFY4hQjASwIQGf2BfKGmie8sPn6wVT5qJPwDW6DRmt9T2waAO2pajKLZVFR/I5A?= =?utf-8?q?sf6OBT3wL+8gT838MK/D/GMPiak2XyqGJl/5dIMhObYpa4far6R38kjL+co+o2n2k?= =?utf-8?q?ohT3BsW81uHPhxkKCgQ+0aTugPG6jq5K0YH2yDQ4Wjs5eoI/QJTkkKdsoFdhVuV+Q?= =?utf-8?q?sY1FNyLQW0Y3dZJTRRKlZ3/C7e7gx+sY6Rx+0y+t0RpeazdmvQsm16EPykICchsnS?= =?utf-8?q?6Fn/l+xBFRGuHHFKtIS4ZRZqh8CCG1X0m85FJAWXAjzte0B68g+cIKURx834dseEw?= =?utf-8?q?9tFKXsWNlhWo8jx0MZdb9J9G5Tu1EXBm2Yhw5RoLlmJy4jxIpd3npHqzhFIQQxiWe?= =?utf-8?q?/hPR6MkuYNYA7YKrP+mcPf2EVZYE0NtSNkyyXEk1eCy1hTTjkyUrUwD4Hy6c7ALLR?= =?utf-8?q?4T3abLeMM22iLEfybuYoJi6xMC3JqksLOSN49A2MBwAxrJtfAV5HgMUffVnGZ4UQy?= =?utf-8?q?XwaVobrnCPuxXxyxEYV1XwzjADf5IikjVkIuuUxCUM9UIzY3Pz7lOGy2gb/O+wfLF?= =?utf-8?q?yU7FWXExcnaJ+ucCWDhUNWqxw3iBcc83G1Zqtm+NVPrHOBqJlkSzVizQ7p3ErXbsb?= =?utf-8?q?zFDk+cRKIVsBj4YvjvrzUHI5gB+MLnqRClB0nqjU2Aobp2rmOEq5mPk2UqRGf5tVb?= =?utf-8?q?Jm8SkVjXpWiu8fbeN56vlwJThiJW2IU82nx7sYCaWOQLa+7AHDBcuUE1oIbqTMWjj?= =?utf-8?q?cUv2kajnELEembjHEwB6uieI4aK5HONDiz4ER19wG7ROuL6JF7O0KWAGRxNA0OSvt?= =?utf-8?q?oyg2twB/LPTtrY5xwJOR1ivOIZ+Il01YVgjaTPyYaZM8v+x0TUVCTYrh+6aplgb/V?= =?utf-8?q?lYQXUdCgicba0A2+dkJ2+st72lg8g64l5ARsITXRgfr/wVOk6UEiq4JLzlP9woArV?= =?utf-8?q?KtM1oAmr57lNg6W9RWH1ihOpvta7YEXgFJFVH0gTE6JdG8NnsaFUPpiYD2nVjzYZo?= =?utf-8?q?6+dg/ekVvroxbsqSMjxBZsQf3iwRdyxjlA3m4nqf/ReWEiVoBElarAY1gbjCsO7b3?= =?utf-8?q?Z9DSP7X8A37A8AiDmwk3TWlFD6Nk0kAKT4Z+oaCO5Pe5CXZYLBMmgb35qvNEj+N5A?= =?utf-8?q?rmXXAX/CB1tBYkIyXzgvDRmZ1+H/JxrEbUgRTugE6sP/Puu/xorpcZtq2pAMvU16c?= =?utf-8?q?+WC8HbK1MyLbi+1wyjhtAVWBp7S8Wq0l30edjqMUAI6wfPpHCyzmwlXI7zLb/Q3nX?= =?utf-8?q?L3tqpcWwvxyK3425zYH9pCDKX0YIx8t2f53wRYAXZUkIetaAS4NWUE0Glgf/DWf+n?= =?utf-8?q?1sbYWi9evhx?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3b815ea6-1c48-42a7-8c33-08dd4f5c0fc6 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2025 14:04:57.7910 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yRA8AopH11UFoByyvULCNfree+bIOLAdZA/gPEcjsVA0RsAf0jDteIe/dGdQW4Pzu99491LgL+HU8kcPhGZIkA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4208 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Signed-off-by: Alexandre Courbot --- rust/kernel/error.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/rust/kernel/error.rs b/rust/kernel/error.rs index f6ecf09cb65f4ebe9b88da68b3830ae79aa4f182..8858eb13b3df674b54572d2a371b8ec1303492dd 100644 --- a/rust/kernel/error.rs +++ b/rust/kernel/error.rs @@ -64,6 +64,7 @@ macro_rules! declare_err { declare_err!(EPIPE, "Broken pipe."); declare_err!(EDOM, "Math argument out of domain of func."); declare_err!(ERANGE, "Math result not representable."); + declare_err!(ETIMEDOUT, "Connection timed out."); declare_err!(ERESTARTSYS, "Restart the system call."); declare_err!(ERESTARTNOINTR, "System call was interrupted by a signal and will be restarted."); declare_err!(ERESTARTNOHAND, "Restart if no handler."); From patchwork Mon Feb 17 14:04:48 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandre Courbot X-Patchwork-Id: 13977902 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DC038C021AA for ; Mon, 17 Feb 2025 14:05:06 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3A10910E470; Mon, 17 Feb 2025 14:05:06 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.b="TUwW4EWy"; dkim-atps=neutral Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2051.outbound.protection.outlook.com [40.107.223.51]) by gabe.freedesktop.org (Postfix) with ESMTPS id C4ABC10E4CC; Mon, 17 Feb 2025 14:05:03 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wGcLoOkWoQ8fZjBEsTgaEiajgOhYkyi/T0+ee6z99+RJjtStZu7N+iCEqhs0+XnaQswpqzD8pWs0126UOdxsirIFNTDZ9xebgxSV28D1LaMjvJG4Q5gi9H8mlfyaRzFJt/4OwYUA065P5geRj3XZ+hMm0fPmNIu3YSsvthiyS/BJcpIlEUYeCYXEmRKhTdS17RNFhrVJPV1f8CxHyRTXRY8lrsw7qe/EsVBIlHbA4STiAgNxlhiq7m0VEl8/2U6mRSzI/4GYBAmNEc81G7cMB2dN7rh5hehh6Xd1bJxWkC2GNWqLXK7FP5/NYdCWtlbIa9JUiRWSTj4jOzu7N/lXvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J1wAGrVj8vWW/OvvMWGZlOw9PqiZi2ZxtUNkqEuVztk=; b=hasUBo+4qi05uQv6/FXKzynrt+4Tmr/Q4wEIbxgjW5shzeZeNiGJOpz97tjIf5WG85NveNh1QBDdqbpHYcY+Jyl/vXYhuk3SKtpNAcVF7Se32sg83eHQh85NKEtw+zAjGi1Nr8tMHEgDce7E8LRS3kDogwh/cVdLAb7ee8gllm4BfeAwhWlGVr1iCGzMvt4X0GFQBYINXWX9eTvofd5nmb9w9L21bOYSQzf/WDeucKFhMefRDySPb+4T/9LKdpZvvDMqm7W8Vdr5hzPtNhLJwk2Vh7EjgLaz46dbQMd5kmq0JtjlDP947Vl9kwb+otcXzEOI85nJukwJTn+RBS6KFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J1wAGrVj8vWW/OvvMWGZlOw9PqiZi2ZxtUNkqEuVztk=; b=TUwW4EWy1YqUte37LW6WrZIy22aZ+ab+Ln26Hg7pswtJffxDuGMZ53v+PgTpWzX9zN7Usnzcb/zN5UG9mBXVKPcmBC5kikPg6ieG9TRua8h0J2U7cCWPm0u1giIQ7SxOSWRdgCiQW/N9PPbf7UqfbS1aGp0mWw14eTtWbEg1XTh3duI78ph7cZNnO8NNFesvYjdq2u1hP2m/mtQJT212kBLzhGjz9xgjo8VZJH5KFZ6goWo+yRS8mubuW4qa1qnMNEhe6rO9Vq2Kv2QEoaQT6ShGK9y6NGO5wZmfvm2gjVb26Hry6bNOQ0T8G6j9mKuPTznJFQHTswR/qOSiL7SCXw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by MN2PR12MB4208.namprd12.prod.outlook.com (2603:10b6:208:1d0::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8445.19; Mon, 17 Feb 2025 14:05:01 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::6e37:569f:82ee:3f99]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::6e37:569f:82ee:3f99%6]) with mapi id 15.20.8445.017; Mon, 17 Feb 2025 14:05:01 +0000 From: Alexandre Courbot Date: Mon, 17 Feb 2025 23:04:48 +0900 Subject: [PATCH RFC 3/3] gpu: nova-core: add basic timer device Message-Id: <20250217-nova_timer-v1-3-78c5ace2d987@nvidia.com> References: <20250217-nova_timer-v1-0-78c5ace2d987@nvidia.com> In-Reply-To: <20250217-nova_timer-v1-0-78c5ace2d987@nvidia.com> To: Danilo Krummrich , David Airlie , John Hubbard , Ben Skeggs Cc: linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alexandre Courbot X-Mailer: b4 0.14.2 X-ClientProxiedBy: TYAPR01CA0079.jpnprd01.prod.outlook.com (2603:1096:404:2c::19) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|MN2PR12MB4208:EE_ X-MS-Office365-Filtering-Correlation-Id: c2b42191-45a7-45f9-c0ba-08dd4f5c11d5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|10070799003|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?q?ghI7bU6yX2dKGcXLVTMVXsW/wMP50lh?= =?utf-8?q?SokFzAdnhxFo19/ALAaWZ+Sg4FiMsjRmI6WSi/WfpiR8MAavBdkSsV13QMxHs3oM4?= =?utf-8?q?80t4VwlXDaNx789gEwfrOQfYRWJ+6/+DN4RUD17XFOrS4IwaDeGjqA8oFLr1qQh5n?= =?utf-8?q?qwJDh7hpRvfBmvts+1hQv/85rlvRwCD/+FX+WsErBhEfN50x2vRE+Ze/shAhyrIqc?= =?utf-8?q?r7kDh5xEVCZDbPlf8je7LlU+xhbw6uCfwQWcumyR87vuhHyrCYFmoqf6VOIkMZt8y?= =?utf-8?q?rfZHxp5huGww3iOe/sCEli0549QMObRghrmygUrYsOhWU+6GWrjXWtGmW+KaRD+xc?= =?utf-8?q?G8y8fhimsap/3gBNlQiWkwtcd6c7acDia/qgds3Afj9MPDfUVJFR9nMHCPoo4MQuy?= =?utf-8?q?RvIdOhMW81RL8vx561h7HrnFfhn9YFdlsBjY3woKN2+gzpHDOWnxVEKJjG5ZUyiwI?= =?utf-8?q?xLRcCRmzJXxKbW5J7Da7zcubLnfqDWS8dsRHjr8Ro2t3dIRFUmx/EEL1xcKwVd4/n?= =?utf-8?q?0a5Dj7xyp+dBLXEnhR/rrhAx4SjKjNgkhunmIybdqiC+GypP3qA8kzXmGkkJ0GBvZ?= =?utf-8?q?8PVtc6IZUikB4TzmRls/wjxMDz8aly6kDHHEANlVjs09m54M9Hs2svg/Y3iiYR335?= =?utf-8?q?voPMm7IfLO1eWJvtZXmM4PokPAwvXPTuz7LZZ2Lle5pF4XSxwADfKEoQMC+AxJClK?= =?utf-8?q?r3Y9aryxTqracCpp5saFaNIhukkdVcj06gOJA2zLsSyY2Kxw9XNqGp791VESK1o1M?= =?utf-8?q?kG2h+816/wLK7wYrfrAPWBV3uxYfcVAqVojdcJ03xd/NHszv4WYIdDedxZSnvRuJz?= =?utf-8?q?KIJPte8HVZQQYm5sQ3NKrNSNTgDJC458XRrwB+yzBk90MVKpQUiW9DFy9erUNDJkI?= =?utf-8?q?ykiIfkpwQAJ3kAtf2XxisCoqcA9L0swgNDr9dHXDBoyGwywXU3A1Cw+J3i3lhZY3C?= =?utf-8?q?hGogPCH3ESbn8FykuhfjOyMaQvMhbxFZJwCg7cagol7ODBKFjblCHdDrNnPo0lydz?= =?utf-8?q?FGU9v1uGEtScO/cVLVmkXQ8oOIKUWbRHkx3INpOx+y5cMUwqiIT0RMraIQdFlWwl1?= =?utf-8?q?A6rSw5yjTVC+tQZHRGts9uJWHQt4nNvGwixka8V1lXs+cMEx58dXYZWVJlM89kLv/?= =?utf-8?q?GxCqVxjzMS1iiEHvlkFmkwp/a6qg2chokC5zsgSqIfp10Z5xVTSaGNdglxwiiMszl?= =?utf-8?q?ZjUthWMw6OQLsAOoFEOpIyTSOoAXBP1H9hDen2vQEdH+PAtI8TIUEdB+7v4T1wKNi?= =?utf-8?q?/VPBgB3HVfTsbL3XDTuP/C5ektUmwkgwSMM2AzNNchd0uI5cgPXPAi2wQGAz3gLMw?= =?utf-8?q?1YVR99r+SYQq?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB3990.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(10070799003)(376014)(366016)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?YYzVFX/JV0NI2FdnFjBL4iVzgzup?= =?utf-8?q?l1rlTDgZtRbkQbVBKtWQR+hgoAYh4mMIh2n0objDu6/weKIu4I6kDotggJ6vuVagD?= =?utf-8?q?1pcqgEUDsj9FU/NjnTfNkE9MHUQjj4SiBPo9ksjPHNPm5mwYPKwxc8IMMd1ZmeEMd?= =?utf-8?q?nat9h2QjLrllBCmEuhZhjtOLFjv25TlsJNYiPIj2sbF5iczsA1Bc719itO2j3OOik?= =?utf-8?q?ODFe6//nrE3bPFOTqYPKrO7YgGnT5yfhn101AcXVZs3DxTp+VDllvTHuBoPxDdhra?= =?utf-8?q?1InShfjX+Jdh2lhZ9+o8Erm22fbgBcYnHHecoP8X7G/xr8N95gx/+yo8PPTK7YX0s?= =?utf-8?q?/cqSHAwO2rQ8l2oyIn9d7uExMKcdep4NuDeiJowA1HyWiY+w1WNxo0/pRvoXYvnsG?= =?utf-8?q?GZUkG5uRgZRjEMvmWAT+K71s2vMnYshjeFKiQtiiiJ1aXxenpchn/Srm4C57pSVsm?= =?utf-8?q?N9YXxZrFhgkbUWyPBzQelC9vSzxO5OfUeWksb0ui93VnQzKTmfFuIHhOvMEGcbUS7?= =?utf-8?q?WpPqGtSSNM69ItIVHj2io0ZAzYuRvNws80k0WIv1TDP/05nw7dOCCATLQ4w6aGSSG?= =?utf-8?q?iHQwqPwBSkKcTwhIlyIs0h7CK4PL/1DTwbOkOyK3qmIBTWdJZgMrhY8pDi812JV1h?= =?utf-8?q?71IlcdvDb59su1f+yZRHLK8s8M06iVbydX4qmiddMg98rs0Y3nNiiqpdIJo6y6lpd?= =?utf-8?q?YsLk2Shaj4GV/C93ppZIvMGu+RzMmMfQwzT+ZOSJx2GooH3ua/74rH+5VaCOWkUXR?= =?utf-8?q?xy9pDZ+cOx6dYE8XIDyxsGzsBlxkMosZ1PUBFKbKm0nX6yyMVqWAkyxqLd+FKBLCS?= =?utf-8?q?YDmEjNq8Nqii/GtQJuT18fBEN1IE5kD9ef/fU3Y2P4LFwP8bLadMs+4v3gwhe9VeB?= =?utf-8?q?QFlgk4NhAict/Qnj++zXiMXnE4XycWEKXGQzIksHAJw8pi56nQQeABYro441ySQ1L?= =?utf-8?q?ZMA0QLHaDVvnsPy5DQ310U2JWGZRaAvmchqxWHd+bxMl5Ul7j0Ov13S2GzeHgDf3Y?= =?utf-8?q?6oW3buTOxDfom8xE2h4Sm47JwTHL9Nvt0amu5wvh7B4TkkbUyRrWsXXj7jYUgTNyM?= =?utf-8?q?YhLAtZnJT1wPj3YM55X8ypdw5mKSwp/SYtwoMZjrsJekKRHGJy3wQKYzieiBH4ZuM?= =?utf-8?q?126HMdVz+bVldGKY83hZrzmXBaUTPjGI2xOEKXWyjck4RgSSBfAnrE1i8nklm4JRK?= =?utf-8?q?BuUvAXec0j8iYMy6PbwAljiVmJXiYSdjjohZqOwj4yTou6jwyueZMUQy8mxb+BQ2G?= =?utf-8?q?ajY/abpGhgY47PQKVFOhsLKVK2URFc3v88FLwEd+3VQkv5MQ95FuAOvsW2tO8bg5y?= =?utf-8?q?FXSeUBPkwdm4xxJ44b3xdcdpHT9XVrPN4baNioC3TOPWuzZwlksGYqjEM79VQDqgD?= =?utf-8?q?Nxcm0UscptpTeHg6YuhAQ3oyagg1WoLpjzpw8lxrBElvyITUTP97l7pbgM3y/dK9Y?= =?utf-8?q?JTsqSsyxyEUgthwvnX0+xpHwWvDvOMH/vtaRvRaZTz/bXDEmHDClt3erlPz0zaZC2?= =?utf-8?q?9BexEBMfo5D/YMfzDnnSKYREzRxyy7HUbV2sIEC025M1KIhqMck018UUNcNIlYbc1?= =?utf-8?q?oLi2xTtrKQT?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: c2b42191-45a7-45f9-c0ba-08dd4f5c11d5 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2025 14:05:01.2295 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ALLvxZGH0KXEPPkZP6xX87Un3kiw3gEsF9YFXsSTd6VDZuHOKt09zyR9NAB0O6BpZdccxqoApg6xGFAoBQzjpQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4208 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Add a basic timer device and exercise it during device probing. This first draft is probably very questionable. One point in particular which should IMHO receive attention: the generic wait_on() method aims at providing similar functionality to Nouveau's nvkm_[num]sec() macros. Since this method will be heavily used with different conditions to test, I'd like to avoid monomorphizing it entirely with each instance ; that's something that is achieved in nvkm_xsec() using functions that the macros invoke. I have tried achieving the same result in Rust using closures (kept as-is in the current code), but they seem to be monomorphized as well. Calling extra functions could work better, but looks also less elegant to me, so I am really open to suggestions here. Signed-off-by: Alexandre Courbot --- drivers/gpu/nova-core/driver.rs | 4 +- drivers/gpu/nova-core/gpu.rs | 35 ++++++++++++++- drivers/gpu/nova-core/nova_core.rs | 1 + drivers/gpu/nova-core/regs.rs | 43 ++++++++++++++++++ drivers/gpu/nova-core/timer.rs | 91 ++++++++++++++++++++++++++++++++++++++ 5 files changed, 172 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/nova-core/driver.rs b/drivers/gpu/nova-core/driver.rs index 63c19f140fbdd65d8fccf81669ac590807cc120f..0cd23aa306e4082405f480afc0530a41131485e7 100644 --- a/drivers/gpu/nova-core/driver.rs +++ b/drivers/gpu/nova-core/driver.rs @@ -10,7 +10,7 @@ pub(crate) struct NovaCore { pub(crate) gpu: Gpu, } -const BAR0_SIZE: usize = 8; +const BAR0_SIZE: usize = 0x9500; pub(crate) type Bar0 = pci::Bar; kernel::pci_device_table!( @@ -42,6 +42,8 @@ fn probe(pdev: &mut pci::Device, _info: &Self::IdInfo) -> Result> GFP_KERNEL, )?; + let _ = this.gpu.test_timer(); + Ok(this) } } diff --git a/drivers/gpu/nova-core/gpu.rs b/drivers/gpu/nova-core/gpu.rs index e7da6a2fa29d82e9624ba8baa2c7281f38cb3133..2fbf4041f6d421583636c7bede449c3416272301 100644 --- a/drivers/gpu/nova-core/gpu.rs +++ b/drivers/gpu/nova-core/gpu.rs @@ -1,12 +1,16 @@ // SPDX-License-Identifier: GPL-2.0 +use kernel::device::Device; +use kernel::types::ARef; use kernel::{ device, devres::Devres, error::code::*, firmware, fmt, pci, prelude::*, str::CString, }; use crate::driver::Bar0; use crate::regs; +use crate::timer::Timer; use core::fmt; +use core::time::Duration; /// Enum representation of the GPU chipset. #[derive(fmt::Debug)] @@ -165,10 +169,12 @@ fn new(dev: &device::Device, spec: &Spec, ver: &str) -> Result { /// Structure holding the resources required to operate the GPU. #[pin_data] pub(crate) struct Gpu { + dev: ARef, spec: Spec, /// MMIO mapping of PCI BAR 0 bar: Devres, fw: Firmware, + timer: Timer, } impl Gpu { @@ -184,6 +190,33 @@ pub(crate) fn new(pdev: &pci::Device, bar: Devres) -> Result Result<()> { + let bar = self.bar.try_access().ok_or(ENXIO)?; + + dev_info!(&self.dev, "testing timer subdev\n"); + assert!(matches!( + self.timer + .wait_on(&bar, Duration::from_millis(10), || Some(())), + Ok(()) + )); + assert_eq!( + self.timer + .wait_on(&bar, Duration::from_millis(10), || Option::<()>::None), + Err(ETIMEDOUT) + ); + + Ok(()) } } diff --git a/drivers/gpu/nova-core/nova_core.rs b/drivers/gpu/nova-core/nova_core.rs index 5d0230042793dae97026146e94f3cdb31ba20642..94b165a340ddfffd448f87cd82200391de075806 100644 --- a/drivers/gpu/nova-core/nova_core.rs +++ b/drivers/gpu/nova-core/nova_core.rs @@ -5,6 +5,7 @@ mod driver; mod gpu; mod regs; +mod timer; kernel::module_pci_driver! { type: driver::NovaCore, diff --git a/drivers/gpu/nova-core/regs.rs b/drivers/gpu/nova-core/regs.rs index f2766f95e9d1eeab6734b18525fe504e1e7ea587..5127cc3454c047d64b7aaf599d8bf5f63a08bdfe 100644 --- a/drivers/gpu/nova-core/regs.rs +++ b/drivers/gpu/nova-core/regs.rs @@ -54,3 +54,46 @@ pub(crate) fn major_rev(&self) -> u8 { ((self.0 & BOOT0_MAJOR_REV_MASK) >> BOOT0_MAJOR_REV_SHIFT) as u8 } } + +const PTIMER_TIME_0: usize = 0x00009400; +const PTIMER_TIME_1: usize = 0x00009410; + +#[derive(Copy, Clone, PartialEq, Eq)] +pub(crate) struct PtimerTime0(u32); + +impl PtimerTime0 { + #[inline] + pub(crate) fn read(bar: &Bar0) -> Self { + Self(bar.readl(PTIMER_TIME_0)) + } + + #[inline] + pub(crate) fn write(bar: &Bar0, val: u32) { + bar.writel(val, PTIMER_TIME_0) + } + + #[inline] + pub(crate) fn lo(&self) -> u32 { + self.0 + } +} + +#[derive(Copy, Clone, PartialEq, Eq)] +pub(crate) struct PtimerTime1(u32); + +impl PtimerTime1 { + #[inline] + pub(crate) fn read(bar: &Bar0) -> Self { + Self(bar.readl(PTIMER_TIME_1)) + } + + #[inline] + pub(crate) fn write(bar: &Bar0, val: u32) { + bar.writel(val, PTIMER_TIME_1) + } + + #[inline] + pub(crate) fn hi(&self) -> u32 { + self.0 + } +} diff --git a/drivers/gpu/nova-core/timer.rs b/drivers/gpu/nova-core/timer.rs new file mode 100644 index 0000000000000000000000000000000000000000..f6a787d4fbdb90b3dc13e322d50da1c7f64818df --- /dev/null +++ b/drivers/gpu/nova-core/timer.rs @@ -0,0 +1,91 @@ +// SPDX-License-Identifier: GPL-2.0 + +//! Nova Core Timer subdevice + +use core::time::Duration; + +use kernel::num::U64Ext; +use kernel::prelude::*; + +use crate::driver::Bar0; +use crate::regs; + +pub(crate) struct Timer {} + +impl Timer { + pub(crate) fn new() -> Self { + Self {} + } + + pub(crate) fn read(bar: &Bar0) -> u64 { + loop { + let hi = regs::PtimerTime1::read(bar); + let lo = regs::PtimerTime0::read(bar); + + if hi == regs::PtimerTime1::read(bar) { + return u64::from_u32s(hi.hi(), lo.lo()); + } + } + } + + #[allow(dead_code)] + pub(crate) fn time(bar: &Bar0, time: u64) { + let (hi, lo) = time.into_u32s(); + + regs::PtimerTime1::write(bar, hi); + regs::PtimerTime0::write(bar, lo); + } + + /// Wait until `cond` is true or `timeout` elapsed, based on GPU time. + /// + /// When `cond` evaluates to `Some`, its return value is returned. + /// + /// `Err(ETIMEDOUT)` is returned if `timeout` has been reached without `cond` evaluating to + /// `Some`, or if the timer device is stuck for some reason. + pub(crate) fn wait_on Option>( + &self, + bar: &Bar0, + timeout: Duration, + cond: F, + ) -> Result { + // Number of consecutive time reads after which we consider the timer frozen if it hasn't + // moved forward. + const MAX_STALLED_READS: usize = 16; + + let (mut cur_time, mut prev_time, deadline) = (|| { + let cur_time = Timer::read(bar); + let deadline = + cur_time.saturating_add(u64::try_from(timeout.as_nanos()).unwrap_or(u64::MAX)); + + (cur_time, cur_time, deadline) + })(); + let mut num_reads = 0; + + loop { + if let Some(ret) = cond() { + return Ok(ret); + } + + (|| { + cur_time = Timer::read(bar); + + /* Check if the timer is frozen for some reason. */ + if cur_time == prev_time { + if num_reads >= MAX_STALLED_READS { + return Err(ETIMEDOUT); + } + num_reads += 1; + } else { + if cur_time >= deadline { + return Err(ETIMEDOUT); + } + + num_reads = 0; + prev_time = cur_time; + } + + Ok(()) + })()?; + } + } +}