From patchwork Tue Feb 18 14:35:03 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Roger_Pau_Monn=C3=A9?= X-Patchwork-Id: 13980141 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 55620C02198 for ; Tue, 18 Feb 2025 14:58:55 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.891838.1300851 (Exim 4.92) (envelope-from ) id 1tkP3T-0005Ed-EG; Tue, 18 Feb 2025 14:58:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 891838.1300851; Tue, 18 Feb 2025 14:58:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tkP3T-0005EW-Bk; Tue, 18 Feb 2025 14:58:35 +0000 Received: by outflank-mailman (input) for mailman id 891838; Tue, 18 Feb 2025 14:58:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tkOgq-0006F6-6e for xen-devel@lists.xenproject.org; Tue, 18 Feb 2025 14:35:12 +0000 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [2a00:1450:4864:20::52c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8e7ef3c7-ee05-11ef-9896-31a8f345e629; Tue, 18 Feb 2025 15:35:10 +0100 (CET) Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-5dc89df7eccso10276403a12.3 for ; Tue, 18 Feb 2025 06:35:10 -0800 (PST) Received: from localhost ([84.78.159.3]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abb952c7364sm450691866b.18.2025.02.18.06.35.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Feb 2025 06:35:09 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8e7ef3c7-ee05-11ef-9896-31a8f345e629 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1739889310; x=1740494110; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QWQsofR/OwYu0UntOR2i7CjQrmM6vERZ5SxhIV+/oQs=; b=U4nKR4DkIT3zNZf84AnWijmuzeYqAl31/JWzI/7ba5Hc/OsF3DHvgKCG7T5i7NL56g PPRNiNazRyaDh3D3QpwqflVlBDZsDgsU8g6YVdPfVkZxxI6EukreGeQns5y69AEfjw8c rlQ2zB5oMi8K8nKzy2xJmJqXcjCal1Xzmq5wY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739889310; x=1740494110; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QWQsofR/OwYu0UntOR2i7CjQrmM6vERZ5SxhIV+/oQs=; b=Nv3rhk3+qzYavT2GITKMDRm9Y/nQgYp1zjWDCmOQoWlPNoMia5Di01wgn1Hhk8eZOV z8LXdKZ8ga4d40pDB71UE9qY10EBtHBM8d224e8+kSaJfjKglZoSouXACKMcSUpP94JJ 7dv4lCKyNUg6KGu51c0WsUR3iMvv+rwZo+lcUyykhWYc6WIgXYycZSAKx7WYbtXbBlfH xWfU4KxqS9csiUAyi59XWLKa7tWGeCsia7GMDlxTy7OeT5S6ae9kBLwwc9/iSR1Qq4zI qhsKW8TBOfpAOqWZh/zoKJbOjvcWVgVa1wjMlleXG478Z4Lpw+uw5/e9okTRj4YNOEAF PEBg== X-Gm-Message-State: AOJu0Yxjyo3Zrm/zUbjZq2yp8753598sh1E/xJeqbkD/ow5b+BK2Pa54 toBHoAFV9BM7f7PPH9mLRozcidylfvZg70Y2gfBSKw+att70GssAnNljiSWmFhCc0JGwcMgnnfB P X-Gm-Gg: ASbGncu+eYcIubuOQjs63bT4/0+XCrLVjg6oBGXclGGSJniA+rGwhaOXs00JF/KC5Z5 cwPWs+cSLQjyW1FJuFIFnn90xWxBpMlNiWF6AKJ4liCkDbPiGNOCsb3hTy7oWlaP+0PYnc3YPKB l/AJFut7/H3f4WiyctUJ/v1y4fD1k34+d1P+ljJkmse5qLR/o2LC7N1n4H1R4LZlCcPTzLF6rjF MbUO06yd2Ut3ZqZLLyP9tP1ryQeBsWZAvzXjr0QFbWtdwU1TDNfm6+jzOxE2Vt3SLtP9qFKvtV+ cdn/2WspFSuBsoMUkl1g X-Google-Smtp-Source: AGHT+IFdki87Kb70og2rfQkffNBKPkMfweUZa4yACA4+AB+FPxgpdQXCGMHoZ1di5iaJp/yiwTq1tw== X-Received: by 2002:a17:906:3117:b0:ab7:b356:62e0 with SMTP id a640c23a62f3a-abb711c3ef2mr1262258466b.53.1739889309751; Tue, 18 Feb 2025 06:35:09 -0800 (PST) From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jan Beulich , Andrew Cooper Subject: [PATCH v2 1/2] x86/emul: dump unhandled memory accesses for PVH dom0 Date: Tue, 18 Feb 2025 15:35:03 +0100 Message-ID: <20250218143504.77638-2-roger.pau@citrix.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20250218143504.77638-1-roger.pau@citrix.com> References: <20250218143504.77638-1-roger.pau@citrix.com> MIME-Version: 1.0 A PV dom0 can map any host memory as long as it's allowed by the IO capability range in d->iomem_caps. On the other hand, a PVH dom0 has no way to populate MMIO region onto it's p2m, so it's limited to what Xen initially populates on the p2m based on the host memory map and the enabled device BARs. Introduce a new debug build only printk that reports attempts by dom0 to access addresses not populated on the p2m, and not handled by any emulator. This is for information purposes only, but might allow getting an idea of what MMIO ranges might be missing on the p2m. Signed-off-by: Roger Pau Monné Acked-by: Jan Beulich --- xen/arch/x86/hvm/emulate.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/xen/arch/x86/hvm/emulate.c b/xen/arch/x86/hvm/emulate.c index 0d90cc4598be..08b9493e6d88 100644 --- a/xen/arch/x86/hvm/emulate.c +++ b/xen/arch/x86/hvm/emulate.c @@ -337,6 +337,9 @@ static int hvmemul_do_io( /* If there is no suitable backing DM, just ignore accesses */ if ( !s ) { + if ( is_mmio && is_hardware_domain(currd) ) + gdprintk(XENLOG_DEBUG, "unhandled memory %s %#lx size %u\n", + dir ? "read from" : "write to", addr, size); rc = hvm_process_io_intercept(&null_handler, &p); vio->req.state = STATE_IOREQ_NONE; } From patchwork Tue Feb 18 14:35:04 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Roger_Pau_Monn=C3=A9?= X-Patchwork-Id: 13980129 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 514B1C02198 for ; Tue, 18 Feb 2025 14:45:11 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.891772.1300812 (Exim 4.92) (envelope-from ) id 1tkOqO-0005WR-H4; Tue, 18 Feb 2025 14:45:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 891772.1300812; Tue, 18 Feb 2025 14:45:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tkOqO-0005WK-E5; Tue, 18 Feb 2025 14:45:04 +0000 Received: by outflank-mailman (input) for mailman id 891772; Tue, 18 Feb 2025 14:45:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tkOgq-000673-Pf for xen-devel@lists.xenproject.org; Tue, 18 Feb 2025 14:35:12 +0000 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [2a00:1450:4864:20::62c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8f6839d0-ee05-11ef-9aa7-95dc52dad729; Tue, 18 Feb 2025 15:35:12 +0100 (CET) Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-abb7f539c35so623453966b.1 for ; Tue, 18 Feb 2025 06:35:12 -0800 (PST) Received: from localhost ([84.78.159.3]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abbb297ccd6sm187008966b.160.2025.02.18.06.35.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Feb 2025 06:35:10 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8f6839d0-ee05-11ef-9aa7-95dc52dad729 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1739889311; x=1740494111; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0KCSjyGMRhRccb8+O9P77tIoteqmX4B4he+uBAZ8Pjw=; b=OWiFWdMYRYB7snYSckv4xTnS9MHwbq2hjK6RMxKE530/0JPzanPJYoh7fbhf/jr1m+ 0Tl+AbpagygD3VWuXc8gUe0TuTNz1Yip2FChrcVUaGklArZwiPL4V94gsdVc9Mp7hH4m NJsPUH2WejWxBxmwGChWXKAUuUbeNyx22sWgk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739889311; x=1740494111; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0KCSjyGMRhRccb8+O9P77tIoteqmX4B4he+uBAZ8Pjw=; b=frXlQ16cQT0z7qZN/y5E54znM2zS1wT9PQ7X2Mpg/Ks21ljaCyixj+Jqg16Xc1yeie LIYFN8VT2BY3OZXbN3cIdxs6MUwnxqVipHN5Srfg9jCTzfw9GQa5pIa+kLe3BZ7SJzcI gbgsxWML3bPSCK1PJu/7lwQvIoVBKZN3XBRvclKcel4hVrjkcRaJheAMzqsecFDCVTpl oTIQPgPv6KVkt61btONCMPf8A0g31YH2xCgt1g5UdwISnOc2yPwz27nnWboS7zPZ9b4E fM2Ng8RF66zWWgISSeJTNC+sJ/M9DqiyR7eZp4VNdjxbDwHwog/IhlyBF4u7K+J6XKpx qnaQ== X-Gm-Message-State: AOJu0YxIzGwe/tbSAE4/RuNCKlm0AGB3AaPFOp/OIvD391/6NE7nqJCs HrsoCC16gh52RnB7JAvE5yAaB4VmxNFxFIbdJ/W5n9mm37CBl4fKPXGvaeOXPrcqfGZkE48HUgb t X-Gm-Gg: ASbGncsw6QwYuNQ5JH0z73NxnzXtHUs/APkQx5ay3V0EJF8r7TU3S52j+3kPSe7ZKLu +MVWzshejDpZZflKosoR0KKvpmHlgByrDbgwAfJz4BpQNiPFWEHcSRbcnNPU4mysv4ckBUKlGK1 RTGp7PVP/4VoQeiny54wxvpzb1EMgtQWxIUppGup1xe2jKXIhOgb03nNbn9Y+3DktQc9OjtSCoY 7l4tcGvomx6M9ALxtn3rllqWqRMcWHOwpuPlxRY0YcWaLYLt522EKGn6W3f52KNutAckRt31o6q 8bNNFGc1b3n7TUZAZWyq X-Google-Smtp-Source: AGHT+IE4yCeMa8fCFyU/iSMMhgr0I/IAAo1OeHksm9dYKyIsTmmsIQKy3faWCG8qXOC7BzW+O/V9Kw== X-Received: by 2002:a17:907:6091:b0:ab7:d916:4fe4 with SMTP id a640c23a62f3a-abb70bacfc2mr1528841866b.24.1739889310862; Tue, 18 Feb 2025 06:35:10 -0800 (PST) From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Oleksii Kurochko , Community Manager , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , Stefano Stabellini Subject: [PATCH v2 2/2] x86/dom0: attempt to fixup p2m page-faults for PVH dom0 Date: Tue, 18 Feb 2025 15:35:04 +0100 Message-ID: <20250218143504.77638-3-roger.pau@citrix.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20250218143504.77638-1-roger.pau@citrix.com> References: <20250218143504.77638-1-roger.pau@citrix.com> MIME-Version: 1.0 When building a PVH dom0 Xen attempts to map all (relevant) MMIO regions into the p2m for dom0 access. However the information Xen has about the host memory map is limited. Xen doesn't have access to any resources described in ACPI dynamic tables, and hence the p2m mappings provided might not be complete. PV doesn't suffer from this issue because a PV dom0 is capable of mapping into it's page-tables any address not explicitly banned in d->iomem_caps. Introduce a new command line options that allows Xen to attempt to fixup the p2m page-faults, by creating p2m identity maps in response to p2m page-faults. This is aimed as a workaround to small ACPI regions Xen doesn't know about. Note that missing large MMIO regions mapped in this way will lead to slowness due to the VM exit processing, plus the mappings will always use small pages. The ultimate aim is to attempt to bring better parity with a classic PV dom0. Note such fixup rely on the CPU doing the access to the unpopulated address. If the access is attempted from a device instead there's no possible way to fixup, as IOMMU page-fault are asynchronous. Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich --- Only slightly tested on my local PVH dom0 deployment. --- Changes since v1: - Make the fixup function static. - Print message in case mapping already exists. --- CHANGELOG.md | 10 ++++ docs/misc/xen-command-line.pandoc | 16 +++++- xen/arch/x86/dom0_build.c | 5 ++ xen/arch/x86/hvm/emulate.c | 74 +++++++++++++++++++++++++- xen/arch/x86/include/asm/hvm/emulate.h | 3 ++ 5 files changed, 105 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1de1d1eca17f..e5e6ab3a8902 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,16 @@ Notable changes to Xen will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) +## [4.21.0 UNRELEASED](https://xenbits.xenproject.org/gitweb/?p=xen.git;a=shortlog;h=staging) - TBD + +### Changed + +### Added + - On x86: + - Option to attempt to fixup p2m page-faults on PVH dom0. + +### Removed + ## [4.20.0 UNRELEASED](https://xenbits.xenproject.org/gitweb/?p=xen.git;a=shortlog;h=staging) - TBD ### Changed diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc index 9bbd00baef91..83bb69cfb852 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -822,7 +822,8 @@ Specify the bit width of the DMA heap. ### dom0 = List of [ pv | pvh, shadow=, verbose=, - cpuid-faulting=, msr-relaxed= ] (x86) + cpuid-faulting=, msr-relaxed=, + pf-fixup= ] (x86) = List of [ sve= ] (Arm64) @@ -883,6 +884,19 @@ Controls for how dom0 is constructed on x86 systems. If using this option is necessary to fix an issue, please report a bug. +* The `pf-fixup` boolean is only applicable when using a PVH dom0 and + defaults to false. + + When running dom0 in PVH mode the dom0 kernel has no way to map MMIO + regions into its physical memory map, such mode relies on Xen dom0 builder + populating the physical memory map with all MMIO regions that dom0 should + access. However Xen doesn't have a complete picture of the host memory + map, due to not being able to process ACPI dynamic tables. + + The `pf-fixup` option allows Xen to attempt to add missing MMIO regions + to the dom0 physical memory map in response to page-faults generated by + dom0 trying to access unpopulated entries in the memory map. + Enables features on dom0 on Arm systems. * The `sve` integer parameter enables Arm SVE usage for Dom0 and sets the diff --git a/xen/arch/x86/dom0_build.c b/xen/arch/x86/dom0_build.c index 2fe6b449149e..11c20b9ab0a4 100644 --- a/xen/arch/x86/dom0_build.c +++ b/xen/arch/x86/dom0_build.c @@ -16,6 +16,7 @@ #include #include #include +#include #include #include #include @@ -286,6 +287,10 @@ int __init parse_arch_dom0_param(const char *s, const char *e) opt_dom0_cpuid_faulting = val; else if ( (val = parse_boolean("msr-relaxed", s, e)) >= 0 ) opt_dom0_msr_relaxed = val; +#ifdef CONFIG_HVM + else if ( (val = parse_boolean("pf-fixup", s, e)) >= 0 ) + opt_dom0_pf_fixup = val; +#endif else return -EINVAL; diff --git a/xen/arch/x86/hvm/emulate.c b/xen/arch/x86/hvm/emulate.c index 08b9493e6d88..3cd7f2e22f26 100644 --- a/xen/arch/x86/hvm/emulate.c +++ b/xen/arch/x86/hvm/emulate.c @@ -10,12 +10,15 @@ */ #include +#include #include #include #include #include #include #include + +#include #include #include #include @@ -161,6 +164,36 @@ void hvmemul_cancel(struct vcpu *v) hvmemul_cache_disable(v); } +bool __ro_after_init opt_dom0_pf_fixup; +static int hwdom_fixup_p2m(paddr_t addr) +{ + unsigned long gfn = paddr_to_pfn(addr); + struct domain *currd = current->domain; + p2m_type_t type; + mfn_t mfn; + int rc; + + ASSERT(is_hardware_domain(currd)); + ASSERT(!altp2m_active(currd)); + + /* + * Fixups are only applied for MMIO holes, and rely on the hardware domain + * having identity mappings for non RAM regions (gfn == mfn). + */ + if ( !iomem_access_permitted(currd, gfn, gfn) || + !is_memory_hole(_mfn(gfn), _mfn(gfn)) ) + return -EPERM; + + mfn = get_gfn(currd, gfn, &type); + if ( !mfn_eq(mfn, INVALID_MFN) || !p2m_is_hole(type) ) + rc = mfn_eq(mfn, _mfn(gfn)) ? -EEXIST : -ENOTEMPTY; + else + rc = set_mmio_p2m_entry(currd, _gfn(gfn), _mfn(gfn), 0); + put_gfn(currd, gfn); + + return rc; +} + static int hvmemul_do_io( bool is_mmio, paddr_t addr, unsigned long *reps, unsigned int size, uint8_t dir, bool df, bool data_is_addr, uintptr_t data) @@ -338,8 +371,45 @@ static int hvmemul_do_io( if ( !s ) { if ( is_mmio && is_hardware_domain(currd) ) - gdprintk(XENLOG_DEBUG, "unhandled memory %s %#lx size %u\n", - dir ? "read from" : "write to", addr, size); + { + /* + * PVH dom0 is likely missing MMIO mappings on the p2m, due to + * the incomplete information Xen has about the memory layout. + * + * Either print a message to note dom0 attempted to access an + * unpopulated GPA, or try to fixup the p2m by creating an + * identity mapping for the faulting GPA. + */ + if ( opt_dom0_pf_fixup ) + { + int inner_rc = hwdom_fixup_p2m(addr); + + if ( !inner_rc || inner_rc == -EEXIST ) + { + if ( !inner_rc ) + gdprintk(XENLOG_DEBUG, + "fixup p2m mapping for page %lx added\n", + paddr_to_pfn(addr)); + else + gprintk(XENLOG_INFO, + "fixup p2m mapping for page %lx already present\n", + paddr_to_pfn(addr)); + + rc = X86EMUL_RETRY; + vio->req.state = STATE_IOREQ_NONE; + break; + } + + gprintk(XENLOG_WARNING, + "unable to fixup memory %s %#lx size %u: %d\n", + dir ? "read from" : "write to", addr, size, + inner_rc); + } + else + gdprintk(XENLOG_DEBUG, + "unhandled memory %s %#lx size %u\n", + dir ? "read from" : "write to", addr, size); + } rc = hvm_process_io_intercept(&null_handler, &p); vio->req.state = STATE_IOREQ_NONE; } diff --git a/xen/arch/x86/include/asm/hvm/emulate.h b/xen/arch/x86/include/asm/hvm/emulate.h index 760ce5e77cce..d17c025a1d45 100644 --- a/xen/arch/x86/include/asm/hvm/emulate.h +++ b/xen/arch/x86/include/asm/hvm/emulate.h @@ -148,6 +148,9 @@ static inline void hvmemul_write_cache(const struct vcpu *v, paddr_t gpa, void hvm_dump_emulation_state(const char *loglvl, const char *prefix, struct hvm_emulate_ctxt *hvmemul_ctxt, int rc); +/* For PVH dom0: signal whether to attempt fixup of p2m page-faults. */ +extern bool opt_dom0_pf_fixup; + #endif /* __ASM_X86_HVM_EMULATE_H__ */ /*