From patchwork Tue Feb 18 23:54:43 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zi Yan X-Patchwork-Id: 13981096 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2077.outbound.protection.outlook.com [40.107.237.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E1531D86CE; Tue, 18 Feb 2025 23:54:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.237.77 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739922897; cv=fail; b=uWTs+eSYzQvFTHv9ylQrz+c5MmfUl8SU+NYpcfQoUlD3Ff/cmpZOhEOo2HcTrhBzpKT2QhlQwwM8thqVgPI2rfu9RZIs9ZU+DHC1YrBmGreEdbc2fBR6f3d6u9tXVoLOC8dJR9SeJlNs4RFzQMTvTeBUeQ1JCJ8YkRSNKZeO5q0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739922897; c=relaxed/simple; bh=gb6oAPWikrhiEl0tkdvCnw+lCENhLtMeTjS58jAXZUw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=qnBAWKtvQGb4CKu4BsvUIEc37T8nTetnSIVPXfZ9wBf/C58hwCcmnrRTwniLr4GTzC1Vr0/zen3qoosXILIQi9EqbVTKn6m1RjM450i6jriIv212hzGbKxU9rWsDzdXJ8lph7p4z0mBRuUj4AH8N6F/pE+qF/172ZbqhrYyNtsQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=CELEFCGS; arc=fail smtp.client-ip=40.107.237.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="CELEFCGS" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HSxK2K3HAA2cXtJ8wcGRoyHu3k45C6cJa7DZ5Kt70P8RdPDKWIagydtjKFUn4hqAxqkcrA1XYuMk0wFOrkCShIyW4NkiCrGsdhWu7b5pyo5yHwUAgJPwLRy3rGk/nV9v+/lL2PCfA8IanVjoMLE+bT7+kcPdzNBP5NAisNA4djF4JTLquxRAPHUNaXSlXw8kGCmoePR4gQ9yfox/u/V4inTXBwnvjzV/kEdpVD1l0B5nTOLW9Mck+Yo5724KIsYQOP+T4JI7sLzwGFTvWFIw4Qj1rTJT3jkE2jGkeM0ApU4o/snl6yULK0zsWesOQRs38RzMrIg5qCoA4IrvxSY4Zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6QuCbMHib6zbVMGyf2zEu2fYzLX/UadW3QhlKETvqro=; b=FlYzRR4iAFvrA4LOsic7VAddFnqug11Cw98z6HFjaNEPhAXrFnSGEIUSczfR+zmTS451EiCuQvYjXN1aTZMvBqPATaSd+Bi46TV3bL0HPyNewrJXZGigCI1feAV2GNv+Q3KIQzKeOjht0dokeEMelUbTD3wu/i6+y+C2lUWEDgR2TWYhPVeoiAhNNucOIkF1Krp6gHD3PtrJ3utD9SNMxwgPL1wX9CdpODQn7+r7i9cI5oR6soOPOCQ+o5//YvKAsFCbPbUYOeo8Z9MQUlF67NTfdtPwg2PYZyn6tAbA/PqdTCz4L2JQCzwIC1KenJ/ixkErPz7SrHyTLzd6zQQ4OA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6QuCbMHib6zbVMGyf2zEu2fYzLX/UadW3QhlKETvqro=; b=CELEFCGSaH42frk3O1qLdSmpR46U42A3BR1mWs6Bev5Mje8Xepz0FkwpUNNWoVLdb/xJhj5/NN7MSyEcDPiMpl21xYKqC9IkRJVtGoiM7IObHGK8Nrl9t1FaYGy5572ZMS2/PVdnA0Q3+hvBD4Owhzm0iaDJXIRmQNHUIUNWyE/mESZE2ED1QOAatPlsVhu7ttP6uneOBO8fALabz//dZUIUuGRY03yXvbEy4QG+WizMQPRvL7tJsFnlrXTeewSeay4+pAbAIcxiWyR0lXKgF6ProoHhBjSbHRzEOX+/4PspVHlBeFAwXKRXlhAP59wyejfYHHH6biGDDGbLYRkZ7Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by CH2PR12MB4326.namprd12.prod.outlook.com (2603:10b6:610:af::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.14; Tue, 18 Feb 2025 23:54:50 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a%5]) with mapi id 15.20.8445.017; Tue, 18 Feb 2025 23:54:50 +0000 From: Zi Yan To: Matthew Wilcox , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Cc: Andrew Morton , Hugh Dickins , Baolin Wang , Kairui Song , Miaohe Lin , linux-kernel@vger.kernel.org, Zi Yan Subject: [PATCH v2 1/2] mm/filemap: use xas_try_split() in __filemap_add_folio() Date: Tue, 18 Feb 2025 18:54:43 -0500 Message-ID: <20250218235444.1543173-2-ziy@nvidia.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250218235444.1543173-1-ziy@nvidia.com> References: <20250218235444.1543173-1-ziy@nvidia.com> X-ClientProxiedBy: MN2PR12CA0004.namprd12.prod.outlook.com (2603:10b6:208:a8::17) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|CH2PR12MB4326:EE_ X-MS-Office365-Filtering-Correlation-Id: 3afa03cb-0c92-493a-9f75-08dd5077a1f5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016|7053199007; X-Microsoft-Antispam-Message-Info: Vlx7hFIuVZHAmaqDDHO0s3WxK7QBCF3DMmN+ZsxvSb4ZwBEVVUVJJ8h31weRWvADxvPTwl/54Exk+jVQW1whevX1ebaYJoaF3Df+vi9YCNRX3SJIaSYUitSOeDnkkioWjUKYZrgpbcKlDdLX4HllBdiB+3OvfQFz+TPJm4pyPDXLfvlH/ZBbZfdeoFS3dYhjaNzwL0d8XgDRfuUk1SIj/M/NdYA2/FkjXzEL6jCP5qdGzMCp1vVu4ELLYeuGTjXl913CSpy2B9dc0NW6cvdVW3p+35mcBEjpY/Ra4AFghM9fqhEMeikIcm4GXFZSgNCUR27Lsw+kEo4D/hdnfvoO6ERVZ6ATuw92S/H9qB7MibKEhGbm+iFZQN0miKW3oyCHk+LQ28FYZsBsk1EAm2LvKvAyBh6lkRz9/O2MCyfQzap5qM37EIdUWQgytyHAvQ1vI5XOCwq4ulCVQ12GS4uGhS4FpHVSE/ta1MDdCHIVBKleTnxpMb8zV3eoaySwEEnlJANillIbpszxm6drwall9L7g+DUOHcNbvmYsvKdbsUkE3NmS4VFwtr3MECpXVCzxkO9b5H1es8LNCoQWrKdM5ZfB3rxbQGE+3CS5+PeadYyxiuYyOua8K8OO8XlEEKh1SmWesMnLiJPYPFKuPTjxtRYduVqe7kT3srUDsNLtgex4ZgphGVbpuAea+AZDElFeGKqw12it1xFbBqg5+j9d1rqf16OxKsjkvt9qifrjroY+jlgnRb3SgIf9Pf8LLlrg0+UGl8U8RmGts55mkCR1m6wwLmy0sV+swqbr5chqnbSExSsV+ugeWih50wgT2ZxSSObi9ltp58o8AO0uDbHGXulCVCn+kkZpl52W4KZu81sOs69Ya1lT4ljpYroDwmq27+mKX0giwj1oRk1m2hx1Qd/EoepefKK5WKRP7FQXg62/Zd3SysL+jpUYEKPSnHFK2yTlCxP/Mnq/zpKBXHkqGTyeCJ6EAeJuZVtotj6i12RQSUs8mnRCMAmx97+8eEnlNk2dSGefrUKFOWe1f18sqBFSozG4sgZZrF0dYSiub5WL98W9wVdYT+cZ0zMp7PFV1O5LDNwy8pq6mOy7ZWe7DssW+EkRH5OCKVdI4IsiD10KPbprAOGO92vlK8PUs8FJXQFFqNF0bX32uslhhIGKEj6SvnUXTlPJiGo3l7swx+f36OenL+B07k6yNIchV8jVR4IaTedCTkiXrYqzWOg8UFF+0EZLy26zBUwJJzEgokdKn+VXKI9mWPR/EBcj/xRhdoxEeIXGoeo3b9EaAG79Y3wXLQAUC8Ldg4FI2G/ldcuzrvU1Do2MIATXZ+H9f48yiYkLYlaEs0mEjJRK6EwwFPGh3IJkB2dFFrcnkiYMU8F8TPaCzSkDDDKa6yTUXYhe X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(366016)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: lfn8KFSqV11jr+GcImt3il76RzJRSXwerw4dbEDbOZ117DbKwv3yGUrXoYGRR5/WlMnU48S5xDuLnnSUKMGXSoweNGnX7xeqAr118EbOXErORmJmHA94XMhDGT2ZJjTPM9VRaYWq+PGQoFsO4CK5Fnl2Fy4gO/54P00Qa0lW+axO7iWa/hL9HGa7sVFCUwSm/yDHmsim+og0hOyXHo0PXmowJdkWOAJ9TxLX+VXl9GFYBZVWsUgrFTg2b0zlB0n8oRgyjl1mA9HTS9F90iCByafoPLm7OWZBOCPufGJsp/2GpeIv9tRrYyKG/THnUsmgQnwot9KI43ox3UTqIHM8F3z9iQC5htma6vGWnNznaToRZOPw8d9CxQT2TPEGnTUMnsGNJTtRKZ9KcZ1e6oISfKamoTZSnv/F781mhoPoe9v57S9VLvQjut9hd09WCtPnSw2eKIAYney1F6ty7+4uamEYlSILH69RSSw20UwTs0TN320XNqsuvdam7omKCMqpS28qmtaxr5XF+tVPH0hBJ+6Wdifa3dPc8c0ow7TNqlDxiaiGcSFaTeGPYDVPsUMi7Z/F6pz4hWeuUAEUfxQ4azvH+R/3UO+22pBKytN6PAcLKlihJxc8rVYv07/snzXCEY8H7o6els1DZ1wH9tvBLIcxF0NrfLD+ArM0msicLfSYNV8aiNTxnVzZekyeHQWAxJ8LNgt1ZGUV5grjOICevZQK8o7f8QOJ1Z4s2uuxPxudhKMkRgRS7KxB2uEdyAWo1DPWOqXp+/MPxzoP4KsF2YnjmkLLw3efRVReBKLXemSljrGnsRHNj/wd7j+kjHsJr/iwlsIonu2EW33bdOUyYsdQ8KDNbUazgT5w8+v3WeRkDS3B3OgSk0jYz8WMQRd2R6XVIKSbP6fZl/vbY/M1tdXYOU8KcKrUuEsLCrYEaqXIyt5nCio+AlhbcgU0tPdEqmDDceOeNxHjJHXrGuRgCjtIxlUwEMJS31Tf84wohHkPNGwu+aVzhyUeILapzZG3BePFCOxsGbZTHVS3D8rrlRHA7H25dos0F3u3gtbQubHQRWr+Wi9wnpa9+xSryNqQn31i2lsDXyK6HCUyg26LOLzEOtZJGvL1QQLmPe2pdCVCXIQr+8b1X6+Xgh12Sz3Izu3vuNSIoq2CaQP2e+kmhllw6Nh+ZiRXRjRi1qmJM7zlRiG0C0yaX0BJW53+cbj5wSZQ19m5jhZxLDUkl5MlrCtheIINW5r6JKfjl+JZ6EVyDMs2zY1YSQG2B5WR8n5VqlV+af3GrkuAt0mR6L39qgvMpvgW3hceTvWPPkFGX5QlYRY8pZILD7d6NLYhHmp0k9SSS/wAsi7atlAhLBouW0x4Ucw7Pb9CSBEO25FGPmwTB0j+1Uo61uU3gTACiRWnquW7YLvA+XSgo1Ag8vjcmoeClK6uMk668tjrlofa5R2kO1cmRE7wf8FYQjQrYbwZnw5y1wWxxCym9rj8d7AUJt4SDqMV5as8mmJXWq8hRhntSG4Y6cT95BmTfqohxPFdVh21J2Rg8AHbPQd9unePlXjJ8m5KSFiQnkurGKOPkhJj2HySAPhSBBPRnI258/lX X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3afa03cb-0c92-493a-9f75-08dd5077a1f5 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2025 23:54:50.6132 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: G3TY6gyEslgopXXqtiaz5V/b3pnb3GIN2DU0SijRwcIXCOXy1ftCZ75ghZvo7Pc7 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4326 During __filemap_add_folio(), a shadow entry is covering n slots and a folio covers m slots with m < n is to be added. Instead of splitting all n slots, only the m slots covered by the folio need to be split and the remaining n-m shadow entries can be retained with orders ranging from m to n-1. This method only requires (n/XA_CHUNK_SHIFT) - (m/XA_CHUNK_SHIFT) new xa_nodes instead of (n % XA_CHUNK_SHIFT) * ((n/XA_CHUNK_SHIFT) - (m/XA_CHUNK_SHIFT)) new xa_nodes, compared to the original xas_split_alloc() + xas_split() one. For example, to insert an order-0 folio when an order-9 shadow entry is present (assuming XA_CHUNK_SHIFT is 6), 1 xa_node is needed instead of 8. xas_try_split_min_order() is introduced to reduce the number of calls to xas_try_split() during split. Signed-off-by: Zi Yan Cc: Baolin Wang Cc: Hugh Dickens Cc: Kairui Song Cc: Miaohe Lin Cc: Mattew Wilcox --- include/linux/xarray.h | 7 +++++++ lib/xarray.c | 25 +++++++++++++++++++++++ mm/filemap.c | 46 +++++++++++++++++------------------------- 3 files changed, 51 insertions(+), 27 deletions(-) diff --git a/include/linux/xarray.h b/include/linux/xarray.h index 9eb8c7425090..6ef3d682b189 100644 --- a/include/linux/xarray.h +++ b/include/linux/xarray.h @@ -1557,6 +1557,7 @@ void xas_split(struct xa_state *, void *entry, unsigned int order); void xas_split_alloc(struct xa_state *, void *entry, unsigned int order, gfp_t); void xas_try_split(struct xa_state *xas, void *entry, unsigned int order, gfp_t gfp); +unsigned int xas_try_split_min_order(unsigned int order); #else static inline int xa_get_order(struct xarray *xa, unsigned long index) { @@ -1583,6 +1584,12 @@ static inline void xas_try_split(struct xa_state *xas, void *entry, unsigned int order, gfp_t gfp) { } + +static inline unsigned int xas_try_split_min_order(unsigned int order) +{ + return 0; +} + #endif /** diff --git a/lib/xarray.c b/lib/xarray.c index b9a63d7fbd58..e8dd80aa15db 100644 --- a/lib/xarray.c +++ b/lib/xarray.c @@ -1133,6 +1133,28 @@ void xas_split(struct xa_state *xas, void *entry, unsigned int order) } EXPORT_SYMBOL_GPL(xas_split); +/** + * xas_try_split_min_order() - Minimal split order xas_try_split() can accept + * @order: Current entry order. + * + * xas_try_split() can split a multi-index entry to smaller than @order - 1 if + * no new xa_node is needed. This function provides the minimal order + * xas_try_split() supports. + * + * Return: the minimal order xas_try_split() supports + * + * Context: Any context. + * + */ +unsigned int xas_try_split_min_order(unsigned int order) +{ + if (order % XA_CHUNK_SHIFT == 0) + return order == 0 ? 0 : order - 1; + + return order - (order % XA_CHUNK_SHIFT); +} +EXPORT_SYMBOL_GPL(xas_try_split_min_order); + /** * xas_try_split() - Try to split a multi-index entry. * @xas: XArray operation state. @@ -1145,6 +1167,9 @@ EXPORT_SYMBOL_GPL(xas_split); * be allocated, the function will use @gfp to get one. If more xa_node are * needed, the function gives EINVAL error. * + * NOTE: use xas_try_split_min_order() to get next split order instead of + * @order - 1 if you want to minmize xas_try_split() calls. + * * Context: Any context. The caller should hold the xa_lock. */ void xas_try_split(struct xa_state *xas, void *entry, unsigned int order, diff --git a/mm/filemap.c b/mm/filemap.c index 2b860b59a521..c6650de837d0 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -857,11 +857,10 @@ EXPORT_SYMBOL_GPL(replace_page_cache_folio); noinline int __filemap_add_folio(struct address_space *mapping, struct folio *folio, pgoff_t index, gfp_t gfp, void **shadowp) { - XA_STATE(xas, &mapping->i_pages, index); - void *alloced_shadow = NULL; - int alloced_order = 0; + XA_STATE_ORDER(xas, &mapping->i_pages, index, folio_order(folio)); bool huge; long nr; + unsigned int forder = folio_order(folio); VM_BUG_ON_FOLIO(!folio_test_locked(folio), folio); VM_BUG_ON_FOLIO(folio_test_swapbacked(folio), folio); @@ -870,7 +869,6 @@ noinline int __filemap_add_folio(struct address_space *mapping, mapping_set_update(&xas, mapping); VM_BUG_ON_FOLIO(index & (folio_nr_pages(folio) - 1), folio); - xas_set_order(&xas, index, folio_order(folio)); huge = folio_test_hugetlb(folio); nr = folio_nr_pages(folio); @@ -880,7 +878,7 @@ noinline int __filemap_add_folio(struct address_space *mapping, folio->index = xas.xa_index; for (;;) { - int order = -1, split_order = 0; + int order = -1; void *entry, *old = NULL; xas_lock_irq(&xas); @@ -898,21 +896,26 @@ noinline int __filemap_add_folio(struct address_space *mapping, order = xas_get_order(&xas); } - /* entry may have changed before we re-acquire the lock */ - if (alloced_order && (old != alloced_shadow || order != alloced_order)) { - xas_destroy(&xas); - alloced_order = 0; - } - if (old) { - if (order > 0 && order > folio_order(folio)) { + if (order > 0 && order > forder) { + unsigned int split_order = max(forder, + xas_try_split_min_order(order)); + /* How to handle large swap entries? */ BUG_ON(shmem_mapping(mapping)); - if (!alloced_order) { - split_order = order; - goto unlock; + + while (order > forder) { + xas_set_order(&xas, index, split_order); + xas_try_split(&xas, old, order, + GFP_NOWAIT); + if (xas_error(&xas)) + goto unlock; + order = split_order; + split_order = + max(xas_try_split_min_order( + split_order), + forder); } - xas_split(&xas, old, order); xas_reset(&xas); } if (shadowp) @@ -936,17 +939,6 @@ noinline int __filemap_add_folio(struct address_space *mapping, unlock: xas_unlock_irq(&xas); - /* split needed, alloc here and retry. */ - if (split_order) { - xas_split_alloc(&xas, old, split_order, gfp); - if (xas_error(&xas)) - goto error; - alloced_shadow = old; - alloced_order = split_order; - xas_reset(&xas); - continue; - } - if (!xas_nomem(&xas, gfp)) break; } From patchwork Tue Feb 18 23:54:44 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zi Yan X-Patchwork-Id: 13981097 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2077.outbound.protection.outlook.com [40.107.237.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 037AF1DE4C5; Tue, 18 Feb 2025 23:54:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.237.77 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739922899; cv=fail; b=JTTIIDV5fMBphX2S8R7PMjnrwwTjtw/nq894FA2CyMezxpS2m6Z1eLcU7i43IEl7Xsj27u92gmejiDtXdzWQqbpXmAL+nCJbuoAfx8J5/2t5g7SOyc/NRIzsvDGev4kamDgcbR8RIZ9mVPHcXI53VXjFaxg5hia8xJtwwitd/OY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739922899; c=relaxed/simple; bh=llx6smOQycPyExD0SM1kgd8qffR8Sjf/PboG+UsJBek=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=nkpxOkrxa9rWME/EMfK+p/VrP7SbzX0S4LjcAh90iuwqkXgeLpmxg76aLcDWoHLBz8/0eozzNAx11z6NmFf+shUFb2Q5ILJsjclxzZ58kBXjAwXVnDLG9suxDg27iExyIpm/VYeYmBbhj/o99/KgJ7yXgnuE3RgTGNdPgDPEPo8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=n8Ohi2yH; arc=fail smtp.client-ip=40.107.237.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="n8Ohi2yH" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hGJbAquKXAXrfmZB96EkqIvizLllw06rl3yeuK3wQhxvFViC0bhadlpRpg0Fx5QZmKhwyfnj7+/IedYuyZFw0gUF6L2kIbIjpIMgk+oCz46Xpz/tGQVVD6tTuucF+whfR6WpeF1nvGS971KafixODZW7ozSIyaSJpEqrhELV+LWfYs14KePI8QIv2oDI0LQFeQFbMO8jajZg/XpPAICzpz0b+daypFFrA23f2Jhsg9aDmo63t7HZrhmRxBk+znXSJ9+jSOKKNHX0ghhhZhXWCN7rVDU1NddZlHIo982plyK7FM6bZR4EnzrrJYm4NFsgzurIT6/bHlMprGwoJaKCxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZSaLygK6n05T2AmjCflis9+gvKk+KoVwHlKgr40r1Tg=; b=B+diu3VzNhxVGLqz3mKGAdhRpQTysdTZgcVycz0PzkkoJ6nrZC5YM1NeHm9beHkbVKSFEzGjmtJJsNnrb9y2GUVRi8Rw5cDwUlg8R5EmrulvkpObcH94MGy1Qa7PF15mMH/YZCHwhfn0HHA7rcXQ6+5UL9WLYvYlVsC7CBAyFo3ickP6Dmz9wbsaI3uWfqXmRUlYVXXj0+iVudZjOpbKZwV5n7V/VpG/UFHxe9xESJfsyFHUseE2V7R8MVGV2Qr04T+Sdr4aTDNzuqTaEQepSSKqy6GjiMMpdtVIyHJEdZ/VPzEYmaDuS/vYiflZwsu/m0PH8ZOhRjgfydM8HtxQdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZSaLygK6n05T2AmjCflis9+gvKk+KoVwHlKgr40r1Tg=; b=n8Ohi2yH+oFRM0E8dicRBcy7uk2ED9cSJedn4iWYwaQlyRq1jdv8pXCWiQt8iAwWu27ndntg5UwiHkZ4S6tVSXbqi6yFoQv6fUnS7cZ8jd/4QX03Ma7n6/LyL07XLpa6Rx3PNNEhuIuq30oRPqhu0kP1aubYX0AxwClAB/FLnLsaBz2vCqe7729VGaSyX4GxYbRIVzq7yJ0V8mGNTNtC8PB6ptft7RpJqBpQ3RUtC/tlri9Omv8a0+rl0hNwq0WGpBrQoD/BV0Un5U3ozEK/eHkWsmzQYBMKFQPxH5X5FAgk3e4rHu3jzbrHA9feNpvg1ZhQxc8fAXiblIEDWhcogA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by CH2PR12MB4326.namprd12.prod.outlook.com (2603:10b6:610:af::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.14; Tue, 18 Feb 2025 23:54:54 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a%5]) with mapi id 15.20.8445.017; Tue, 18 Feb 2025 23:54:51 +0000 From: Zi Yan To: Matthew Wilcox , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Cc: Andrew Morton , Hugh Dickins , Baolin Wang , Kairui Song , Miaohe Lin , linux-kernel@vger.kernel.org, Zi Yan Subject: [PATCH v2 2/2] mm/shmem: use xas_try_split() in shmem_split_large_entry() Date: Tue, 18 Feb 2025 18:54:44 -0500 Message-ID: <20250218235444.1543173-3-ziy@nvidia.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250218235444.1543173-1-ziy@nvidia.com> References: <20250218235444.1543173-1-ziy@nvidia.com> X-ClientProxiedBy: MN2PR12CA0031.namprd12.prod.outlook.com (2603:10b6:208:a8::44) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|CH2PR12MB4326:EE_ X-MS-Office365-Filtering-Correlation-Id: 40cf3213-d0da-4b4e-01cc-08dd5077a2af X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016|7053199007; X-Microsoft-Antispam-Message-Info: 7JPTErAzy8PqEVfv4RpUldDRVhzXz1+m7YFvOvRH5ABqwE4W0M0oC1qp+/RUw6h4FGwyyZkPj1s9+Y0Z0cqMTd2/PuL+QKDaoE6HFtKRtoRWh8nhK11h6Nob2mN7vT7rYXEyGiDBm50kV/dn3OLGVzjubznKS53WlufFGYjBp1BEjZNCsUapHuddy8LE69IJ36ODA7hInQ05WYLjDvgg7EFU2zApl6jl0cOsjJQ3QdZgIqEn6EkAlg2aMo9cGCQholZlJr6A9nwPMl8jIVvQ2bd6FopJE6m9mKxZmIrseK3WIjAuBkbkUePPkE+g9UW2dmW1BuQtbLoVeDlAAnYufQEguaD8uUle+gISyd9+LXpR+by1TL4vxH4LsJh4PYDD2o8ux5UQPOIjtXJCQRhzEPjr8tZw6HCkPCYSztp4hEBgti3AzDaH48GBe7U7LyZ1W7T8oQxNi9yPK+AZbbqDDYwPmRkoOeVxjYjCHE1y5EGsnQWaGsXCQWixBGQIl7QdeXfYDolvlaFiiRsdFkr4Ydhw4NpXkAJs28zsBGSvBebOvvSa6yxZlgG57hY3zqhu4WS+h+QGb2rVaBChlMIDk5g8yIJA9ujJq0277XHqTWdVLYDiCHIwEfDWrAshPknjfwYiewP+NY2hFfHLu11nL7qLCNjvfa/o4jTLcaNa9vRc2Z7EejiJcS5k59DOrwU2c/5xwUCjXXxcRfviL99HsCcZPWrCD3qvCAXFIwbPdTBK2cW3yBoSx8I+zvKxONRQH+TmS9He1KmTnwZ8R85BoXqwFD0LobJgicdWjrNPRhfIFueeZ7N7E7OR7e2uTjpKzGXtFZoNMDjbjTdnSd6gLUIafkaJ9nOyMeW6l+s7zMeo3vEUWEjv9nZErAmddU4v9uSxV5Yj2YPjP3IcOBD6n432tJ8/eUhqPkHzXKjCW5O98JUXR/pNFgGwVqRViPPa6aYa/LLY6BNCHhboZNxTFRD/MVuVRp72yNHOefV1W72UkQ9pzPIBwbC1v4we3IAtCnu8bvMngDz90Qz9sRxTGXbOuIburLdzdmNBt/k59laLQJ7fpgcQ5NHw9v1qBVOT5Rl/c6VnOZ4v2oXeLAptCwsrroGeIE2N3kLzE6YNYBCfQ5Td2HKGQEhmElORc/vD1AK8Swp8D+fakO48pH8rRxLZou1iuAxYV8kbxTJKfQrDmQ1h2eUms6XVwu3hqPeWmtcY9YZ+fYt5wVPo9Baa7AWSra+qDVN34htyQgYl9lakw5XkJKyVUCJcIOrs0xqVhpPwxjQez3TduRqKhSGbB4PPSE/lNC9XIbqH7Fs4iV3fzod9J2ORxhMXJn2uHlYbittuWM10+LCYjdIzbZN/R5kq05KNd+btMSa6FHy546xJxA8JRoJkuAIFJWo7Ks6o X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(366016)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: eTq+8wuZlUSauLfhVdZhboND1Jtk9tNKvvogaZ46u2HV9LEv2QVzWLkU9cFkT/ehR1R2eb6byeClzp7DT9SFncwltONV3pfp9lLoxTCETH1V9zdJlIRz6uMhW7bfvAvL448fx6cDVfN4eQP2H8kvOVct1gEr59yf2Rfin38u08lP6MUS4LvDWbSFKLmw6tXJbcd/hWWYHwqqkc0D3p3oK+xz1hSZkATJ+6MerpRivpkADN4jTd6FjA59Z1t8/uVLrmk54dQr7rG860/vMirIwTTZeH6W4He/f991ST1coC53JcjLkBnd7Atv48IsrnjckWBzccV7RUFpaozmtQndyyG3E2a7GoXbTbJRP40hdZOQgDvCnNVGWBXu7rLelReOHB3C6xotsKeUa+MIUQyQSmNe1yVVxA+yWdH/nLGPs4pHJ4jERYxwXEo2YEy+pRGy1x4a2kaEAKb/3/nikuFqJND1P8kPIh+BT6yq1Jgt5pGjJn+Xqo85OVxsAW26xeEQlhSUDrXZCx+2YPXgeMnr9XrovNb8wXmvZWctjj+WPpZFgQutI2lz5DLzPBuBR+B64JZ9l+hvHCYMRkh1/3D6hEZ5eg07O29Yf4qA9V1UI767nDWOxDw/ONG6qNx6m9c4fX8gLUwkcNR12N0nz8gC/U7D0bc+Of+85hejBCKVrsak3RwwQGR2AmquzjOF6J4nlHO88H3B9rIytH0C7oSVHVITBcdUGpljg4Qt5QUjzOOjYFttNSkt9DmjOPYSJfEuw5p9F031Ohh1VYT2+yuQxF5LRWbLQBDtKNT2y01MtqCzWyfqj/L2ho6ldKVuxQ9c5AaYcsRqS0xp4BnhxXZ+zugmyvVIOWQXLQCoav9VBWAWC5MUtjgv7ykBiKBWuShmo3t/sSdQesjb/PXidNOhL44I1Bymbq48M286drCbBT9XYiPozDKc6px3Y0EBHyrTVl0yJ/lIbWWJ4SUjvqJs3FrfoNayMx7qZB7yegquvkNLQyNTVoMWCa7ek5iUynLTHh4gj9WlGmRBySAJ4I6TKMhiR512/X/2zC13apff/u55M1EHKThrPJzQRbTqeYNIbpzrQjTBS90cChbY7ztww9QUT4PbS/AnsiP7xTaNjWpF0ogNnxwujwDB5S8zRPJ6nuPdsqdZZ5FtJ+y3pALsVHlnN9O7DviVUEDX/W48t/ztnUOqhUJvd7a4rmNS4bG8oYDJCMQOIBLSYfgnN9hkgYVKdMZlkmhE9QEo5r+fhHlqqREYSdKuBobTog589gXgmeJqV+X8A5sqSFrN4BwoiQSpckbg4AI6Heac1CisO798G5dKKI833b5ksfU1uMWylOB+6PNt64wMnKOgukZW3liu3bx30meN1QiHGbB+zSV609caho2XycUTALn6Pn21Op3ISKa32BCllJzYTInXX9JnnDng4eRuBlc6HZ5LsuS+t+vguczv8hE6Vb7WzR96NiTSDpzDi6rgLL2AINH6XH1jSV+CfzDFakRVEpTpqYozbQEPVkJeTsByIazoATZKpTrr9Z1/JQSJNvgHqJzFGjN7vF2ILV3sZdUjye2PnV9Rc6DnyXuADuRcy+HMrTmZ X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 40cf3213-d0da-4b4e-01cc-08dd5077a2af X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2025 23:54:51.8384 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Vo6omoQZ4/8lg8PF28XCXQGOwFiPCH7MQCkNceB0BfkPBO9cy2P1AqbKIgXRpj06 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4326 During shmem_split_large_entry(), large swap entries are covering n slots and an order-0 folio needs to be inserted. Instead of splitting all n slots, only the 1 slot covered by the folio need to be split and the remaining n-1 shadow entries can be retained with orders ranging from 0 to n-1. This method only requires (n/XA_CHUNK_SHIFT) new xa_nodes instead of (n % XA_CHUNK_SHIFT) * (n/XA_CHUNK_SHIFT) new xa_nodes, compared to the original xas_split_alloc() + xas_split() one. For example, to split an order-9 large swap entry (assuming XA_CHUNK_SHIFT is 6), 1 xa_node is needed instead of 8. xas_try_split_min_order() is used to reduce the number of calls to xas_try_split() during split. Signed-off-by: Zi Yan Cc: Baolin Wang Cc: Hugh Dickens Cc: Kairui Song Cc: Mattew Wilcox Cc: Miaohe Lin --- mm/shmem.c | 43 ++++++++++++++++--------------------------- 1 file changed, 16 insertions(+), 27 deletions(-) diff --git a/mm/shmem.c b/mm/shmem.c index 671f63063fd4..b35ba250c53d 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -2162,14 +2162,14 @@ static int shmem_split_large_entry(struct inode *inode, pgoff_t index, { struct address_space *mapping = inode->i_mapping; XA_STATE_ORDER(xas, &mapping->i_pages, index, 0); - void *alloced_shadow = NULL; - int alloced_order = 0, i; + int split_order = 0; + int i; /* Convert user data gfp flags to xarray node gfp flags */ gfp &= GFP_RECLAIM_MASK; for (;;) { - int order = -1, split_order = 0; + int order = -1; void *old = NULL; xas_lock_irq(&xas); @@ -2181,20 +2181,21 @@ static int shmem_split_large_entry(struct inode *inode, pgoff_t index, order = xas_get_order(&xas); - /* Swap entry may have changed before we re-acquire the lock */ - if (alloced_order && - (old != alloced_shadow || order != alloced_order)) { - xas_destroy(&xas); - alloced_order = 0; - } - /* Try to split large swap entry in pagecache */ if (order > 0) { - if (!alloced_order) { - split_order = order; - goto unlock; + int cur_order = order; + + split_order = xas_try_split_min_order(cur_order); + + while (cur_order > 0) { + xas_set_order(&xas, index, split_order); + xas_try_split(&xas, old, cur_order, GFP_NOWAIT); + if (xas_error(&xas)) + goto unlock; + cur_order = split_order; + split_order = + xas_try_split_min_order(split_order); } - xas_split(&xas, old, order); /* * Re-set the swap entry after splitting, and the swap @@ -2213,26 +2214,14 @@ static int shmem_split_large_entry(struct inode *inode, pgoff_t index, unlock: xas_unlock_irq(&xas); - /* split needed, alloc here and retry. */ - if (split_order) { - xas_split_alloc(&xas, old, split_order, gfp); - if (xas_error(&xas)) - goto error; - alloced_shadow = old; - alloced_order = split_order; - xas_reset(&xas); - continue; - } - if (!xas_nomem(&xas, gfp)) break; } -error: if (xas_error(&xas)) return xas_error(&xas); - return alloced_order; + return split_order; } /*