From patchwork Wed Feb 19 23:30:44 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mykyta Yatsenko X-Patchwork-Id: 13983116 X-Patchwork-Delegate: bpf@iogearbox.net Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A26AD1D79BE for ; Wed, 19 Feb 2025 23:31:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740007867; cv=none; b=FF9Pl/mj7L7KEeYNdQ3znj3AGuScOgLXSUnEYjcIDxyGdbiHYSa1UWR7wZF3CG4aoLdSd1h2cDEgna9e6ceA5C9NrJdAs0ggG5iPcp1e9g9n3PGc6nz2vRvqUh1zKudff4af6zNmOSgLDijDUtGNREMRdy0oVtALKH1IaZzuuvk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740007867; c=relaxed/simple; bh=4ZOyBJIn3TP5lfu46/1v/rlActWY3+22dgp54mLf4b8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HMXIfez1XWp/XEbM0Bva1jl8WsVwvz7U+MIBOczlGJn2r2D4AmdkoAYTpoE093yx+fl9yjdc0sB2K7kyT8Y0vpvUeez4HFl3WSj9wYi8y96ab4atKuM+jIagxWqtNwHEc4FzQcASndU5euN0QFPEA6FGec+Rpp1UXoOCK/yDyzU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FP2GG0Sg; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FP2GG0Sg" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-38f31f7732dso226127f8f.1 for ; Wed, 19 Feb 2025 15:31:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740007864; x=1740612664; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=olk1ID+c/nSeUhKEzW6L9waOKhyuVDLIZnc3+wKeWlo=; b=FP2GG0SgNretS4ZhFVGVzGuBlJ8eruP3ZsiI8tTN+dQctYyR2E/g3SQUr39bY79eMD skOiWFjWdxNK52oRXsyL1TQxrTcpm963QEXdx5oSFQrfGvSpnijg3DaPrvFue+5Z7u0m FY7R1rVVknRAZotjySRWSIJ8y2aIvlTnbUuQ4woX3WCUvbmq3ZoRJkfWp1PPemRUJa5W gehLwTSlZwhn3s4Y3gv5PUgC6zTtlXTeiuUFrrOC5jjIT4B5hW2G5cg9zXrPd2fHLFk8 6s30K1OMyHgsRzBnfPsmx9tQa8flTYSp36K4/OC48lwv1zirz/f3vZ9zj2VlyMtEWqBO 7UkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740007864; x=1740612664; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=olk1ID+c/nSeUhKEzW6L9waOKhyuVDLIZnc3+wKeWlo=; b=p3WAGFWVs50sJ7c/9JHH/MIjbazDxZjb1WN+mPxDgMKMPw9gs368fy2akhrAPEBxTW cDCWIynSlpKR9u2+wZGUwz1IMkAm53TcypFGEjyfoplVnjVHhS3ma0to6hGfUvO/jqQ9 ZU6ATbnM7XentacCqR3AxgyN0FrMhY1dfdsjeX9DwSg5NnjOlDSIMFbEnZSRDbFROVE/ w756xODMZCrbHjkRmmg6ujicHB7z97k2mt323UJT4Jn5O8IjA9rvAaRu7mF9GaleiYhZ r1vkwWouGGDerry9zZtZ/Cjiw5FAf2hpdGg4gH4kHiV2W8vtqelqUqpVbrsoqY27Jnij MV5Q== X-Gm-Message-State: AOJu0YzLG8fU0jrzeLN0DN2VjY38g5l3D21WVsIV/Ax2SfSL+JkRlY8J 6t0gVg4PGS9uKA+Mtei8AnprqZ33p8wH97/x3xIrfqYEurCa3OS2t1tjYw== X-Gm-Gg: ASbGncsYvkbuay3rOf6Aylq0lmPYi5QWzjBt7owdJw/e0YXaxFBwEs5x/uxD91gi4QI /l80+oW/Y5kXROCX/nZRqAMYEh0Vc/jyRiiFrQZXBHP1ErkHBwmFDlrjqGK7XVBhqHjrrPSOudK aXRCchlrthy0VjYMgL8o5WBJiHOwfPwYGWkTG2rsNDMgWMzTw3MZZRkvXFK2rU0ob382Daf+uUF IKrqx9N7hhjfZeXAQKCerUXfg7KgsoL5sCZhrOVlYlL0kqj5Xb0ex32AdnFZZw24Se1LS+88iG9 xtJYxkgCfJNakKLZ0iK5My4cV9RmPqODVMkVWK+MzBF4/klL31Ku6ae0VHKdgMtsSaOw3g5s7k0 PAcZIEmDX8AeGDwen9gzv X-Google-Smtp-Source: AGHT+IHxicVlGrQSgsm6c8LHmC3h2EpF1Etqq6g0ocCqn4N4d8Z4nMnukY2I2WC8LiJWLxFb2/1quQ== X-Received: by 2002:a05:6000:1563:b0:38f:4ca6:5fc6 with SMTP id ffacd0b85a97d-38f615bc84bmr924795f8f.14.1740007863849; Wed, 19 Feb 2025 15:31:03 -0800 (PST) Received: from localhost.localdomain (cpc158789-hari22-2-0-cust468.20-2.cable.virginm.net. [86.26.115.213]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38f259f7998sm18779048f8f.82.2025.02.19.15.31.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Feb 2025 15:31:02 -0800 (PST) From: Mykyta Yatsenko To: bpf@vger.kernel.org, ast@kernel.org, andrii@kernel.org, daniel@iogearbox.net, kafai@meta.com, kernel-team@meta.com, eddyz87@gmail.com Cc: Mykyta Yatsenko Subject: [PATCH bpf-next v3 1/2] selftests/bpf: implement setting global variables in veristat Date: Wed, 19 Feb 2025 23:30:44 +0000 Message-ID: <20250219233045.201595-2-mykyta.yatsenko5@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250219233045.201595-1-mykyta.yatsenko5@gmail.com> References: <20250219233045.201595-1-mykyta.yatsenko5@gmail.com> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: bpf@iogearbox.net From: Mykyta Yatsenko To better verify some complex BPF programs we'd like to preset global variables. This patch introduces CLI argument `--set-global-vars` or `-G` to veristat, that allows presetting values to global variables defined in BPF program. For example: prog.c: ``` enum Enum { ELEMENT1 = 0, ELEMENT2 = 5 }; const volatile __s64 a = 5; const volatile __u8 b = 5; const volatile enum Enum c = ELEMENT2; const volatile bool d = false; char arr[4] = {0}; SEC("tp_btf/sched_switch") int BPF_PROG(...) { bpf_printk("%c\n", arr[a]); bpf_printk("%c\n", arr[b]); bpf_printk("%c\n", arr[c]); bpf_printk("%c\n", arr[d]); return 0; } ``` By default verification of the program fails: ``` ./veristat prog.bpf.o ``` By presetting global variables, we can make verification pass: ``` ./veristat wq.bpf.o -G "a = 0" -G "b = 1" -G "c = 2" -G "d = 3" ``` Signed-off-by: Mykyta Yatsenko Acked-by: Eduard Zingerman --- tools/testing/selftests/bpf/veristat.c | 282 +++++++++++++++++++++++++ 1 file changed, 282 insertions(+) diff --git a/tools/testing/selftests/bpf/veristat.c b/tools/testing/selftests/bpf/veristat.c index 06af5029885b..8a540c4b4bba 100644 --- a/tools/testing/selftests/bpf/veristat.c +++ b/tools/testing/selftests/bpf/veristat.c @@ -154,6 +154,16 @@ struct filter { bool abs; }; +struct var_preset { + char *name; + enum { INTEGRAL, NAME } type; + union { + long long ivalue; + char *svalue; + }; + bool applied; +}; + static struct env { char **filenames; int filename_cnt; @@ -195,6 +205,8 @@ static struct env { int progs_processed; int progs_skipped; int top_src_lines; + struct var_preset *presets; + int npresets; } env; static int libbpf_print_fn(enum libbpf_print_level level, const char *format, va_list args) @@ -246,12 +258,15 @@ static const struct argp_option opts[] = { { "test-reg-invariants", 'r', NULL, 0, "Force BPF verifier failure on register invariant violation (BPF_F_TEST_REG_INVARIANTS program flag)" }, { "top-src-lines", 'S', "N", 0, "Emit N most frequent source code lines" }, + { "set-global-vars", 'G', "GLOBALS", 0, "Set global variables provided in the expression, for example \"var1 = 1\"" }, {}, }; static int parse_stats(const char *stats_str, struct stat_specs *specs); static int append_filter(struct filter **filters, int *cnt, const char *str); static int append_filter_file(const char *path); +static int append_var_preset(struct var_preset **presets, int *cnt, const char *expr); +static int append_var_preset_file(const char *filename); static error_t parse_arg(int key, char *arg, struct argp_state *state) { @@ -363,6 +378,19 @@ static error_t parse_arg(int key, char *arg, struct argp_state *state) return -ENOMEM; env.filename_cnt++; break; + case 'G': { + if (arg[0] == '@') { + if (append_var_preset_file(arg + 1)) { + fprintf(stderr, "Could not parse global variables preset: %s\n", + arg); + argp_usage(state); + } + } else if (append_var_preset(&env.presets, &env.npresets, arg)) { + fprintf(stderr, "Could not parse global variables preset: %s\n", arg); + argp_usage(state); + } + break; + } default: return ARGP_ERR_UNKNOWN; } @@ -1292,6 +1320,249 @@ static int process_prog(const char *filename, struct bpf_object *obj, struct bpf return 0; }; +static int append_var_preset(struct var_preset **presets, int *cnt, const char *expr) +{ + void *tmp; + struct var_preset *cur; + char var[256], val[256]; + + tmp = realloc(*presets, (*cnt + 1) * sizeof(**presets)); + if (!tmp) + return -ENOMEM; + *presets = tmp; + cur = &(*presets)[*cnt]; + cur->applied = false; + + if (sscanf(expr, "%s = %s\n", var, val) != 2) { + fprintf(stderr, "Could not parse expression %s\n", expr); + return -EINVAL; + } + + if (isalpha(*val)) { + cur->svalue = strdup(val); + cur->type = NAME; + } else if (*val == '-' || isdigit(*val)) { + long long value; + + errno = 0; + value = strtoll(val, NULL, 0); + if (errno == ERANGE) { + errno = 0; + value = strtoull(val, NULL, 0); + } + cur->ivalue = value; + cur->type = INTEGRAL; + if (errno) { + fprintf(stderr, "Could not parse integer value %s\n", val); + return -EINVAL; + } + } else { + fprintf(stderr, "Could not parse value %s\n", val); + return -EINVAL; + } + cur->name = strdup(var); + (*cnt)++; + return 0; +} + +static int append_var_preset_file(const char *filename) +{ + char buf[1024]; + FILE *f; + int err = 0; + + f = fopen(filename, "rt"); + if (!f) { + err = -errno; + fprintf(stderr, "Failed to open presets in '%s': %d\n", filename, err); + return -EINVAL; + } + + while (fscanf(f, " %1023[^\n]\n", buf) == 1) { + if (buf[0] == '\0' || buf[0] == '#') + continue; + + err = append_var_preset(&env.presets, &env.npresets, buf); + if (err) + goto cleanup; + } + +cleanup: + fclose(f); + return err; +} + +static bool is_signed_type(const struct btf_type *t) +{ + if (btf_is_int(t)) + return btf_int_encoding(t) & BTF_INT_SIGNED; + if (btf_is_any_enum(t)) + return btf_kflag(t); + return true; +} + +static int enum_value_from_name(const struct btf *btf, const struct btf_type *t, + const char *evalue, long long *retval) +{ + if (btf_is_enum(t)) { + struct btf_enum *e = btf_enum(t); + int i, n = btf_vlen(t); + + for (i = 0; i < n; ++i, ++e) { + const char *cur_name = btf__name_by_offset(btf, e->name_off); + + if (strcmp(cur_name, evalue) == 0) { + *retval = e->val; + return 0; + } + } + } else if (btf_is_enum64(t)) { + struct btf_enum64 *e = btf_enum64(t); + int i, n = btf_vlen(t); + + for (i = 0; i < n; ++i, ++e) { + const char *cur_name = btf__name_by_offset(btf, e->name_off); + __u64 value = btf_enum64_value(e); + + if (strcmp(cur_name, evalue) == 0) { + *retval = value; + return 0; + } + } + } + return -EINVAL; +} + +static bool is_preset_supported(const struct btf_type *t) +{ + return btf_is_int(t) || btf_is_enum(t) || btf_is_enum64(t); +} + +static int set_global_var(struct bpf_object *obj, struct btf *btf, const struct btf_type *t, + struct bpf_map *map, struct btf_var_secinfo *sinfo, + struct var_preset *preset) +{ + const struct btf_type *base_type; + void *ptr; + long long value = preset->ivalue; + size_t size; + + base_type = btf__type_by_id(btf, btf__resolve_type(btf, t->type)); + if (!base_type) { + fprintf(stderr, "Could not resolve type %d\n", t->type); + return -EINVAL; + } + if (!is_preset_supported(base_type)) { + fprintf(stderr, "Setting global variable for btf kind %d is not supported\n", + btf_kind(base_type)); + return -EINVAL; + } + + if (preset->type == NAME && btf_is_any_enum(base_type)) { + if (enum_value_from_name(btf, base_type, preset->svalue, &value) != 0) { + fprintf(stderr, "Could not find integer value for enum element %s\n", + preset->svalue); + return -EINVAL; + } + } + + /* Check if value fits into the target variable size */ + if (sinfo->size < sizeof(preset->ivalue)) { + bool is_signed = is_signed_type(base_type); + __u32 unsigned_bits = sinfo->size * 8 - (is_signed ? 1 : 0); + long long max_val = 1ll << unsigned_bits; + + if (preset->ivalue >= max_val || preset->ivalue < -max_val) { + fprintf(stderr, + "Variable %s value %lld is out of range [%lld; %lld]\n", + btf__name_by_offset(btf, t->name_off), preset->ivalue, + is_signed ? -max_val : 0, max_val - 1); + return -EINVAL; + } + } + + ptr = (void *)bpf_map__initial_value(map, &size); + if (!ptr || (sinfo->offset + sinfo->size > size)) + return -EINVAL; + + if (__BYTE_ORDER == __LITTLE_ENDIAN) { + memcpy(ptr + sinfo->offset, &value, sinfo->size); + } else if (__BYTE_ORDER == __BIG_ENDIAN) { + __u8 src_offset = sizeof(value) - sinfo->size; + + memcpy(ptr + sinfo->offset, (void *)&value + src_offset, sinfo->size); + } + return 0; +} + +static int set_global_vars(struct bpf_object *obj, struct var_preset *presets, int npresets) +{ + struct btf_var_secinfo *sinfo; + const char *sec_name; + const struct btf_type *t; + struct bpf_map *map; + struct btf *btf; + int i, j, k, n, cnt, err = 0; + + if (npresets == 0) + return 0; + + btf = bpf_object__btf(obj); + if (!btf) + return -EINVAL; + + cnt = btf__type_cnt(btf); + for (i = 1; i != cnt; ++i) { + t = btf__type_by_id(btf, i); + + if (!btf_is_datasec(t)) + continue; + + sinfo = btf_var_secinfos(t); + sec_name = btf__name_by_offset(btf, t->name_off); + map = bpf_object__find_map_by_name(obj, sec_name); + if (!map) + continue; + + n = btf_vlen(t); + for (j = 0; j < n; ++j, ++sinfo) { + const struct btf_type *var_type = btf__type_by_id(btf, sinfo->type); + const char *var_name; + + if (!btf_is_var(var_type)) + continue; + + var_name = btf__name_by_offset(btf, var_type->name_off); + + for (k = 0; k < npresets; ++k) { + if (strcmp(var_name, presets[k].name) != 0) + continue; + + if (presets[k].applied) { + fprintf(stderr, "Variable %s is set more than once", + var_name); + return -EINVAL; + } + + err = set_global_var(obj, btf, var_type, map, sinfo, presets + k); + if (err) + return err; + + presets[k].applied = true; + break; + } + } + } + for (i = 0; i < npresets; ++i) { + if (!presets[i].applied) { + fprintf(stderr, "Global variable preset %s has not been applied\n", + presets[i].name); + } + presets[i].applied = false; + } + return err; +} + static int process_obj(const char *filename) { const char *base_filename = basename(strdupa(filename)); @@ -1341,6 +1612,11 @@ static int process_obj(const char *filename) if (prog_cnt == 1) { prog = bpf_object__next_program(obj, NULL); bpf_program__set_autoload(prog, true); + err = set_global_vars(obj, env.presets, env.npresets); + if (err) { + fprintf(stderr, "Failed to set global variables\n"); + goto cleanup; + } process_prog(filename, obj, prog); goto cleanup; } @@ -1355,6 +1631,12 @@ static int process_obj(const char *filename) goto cleanup; } + err = set_global_vars(tobj, env.presets, env.npresets); + if (err) { + fprintf(stderr, "Failed to set global variables\n"); + goto cleanup; + } + lprog = NULL; bpf_object__for_each_program(tprog, tobj) { const char *tprog_name = bpf_program__name(tprog); From patchwork Wed Feb 19 23:30:45 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mykyta Yatsenko X-Patchwork-Id: 13983117 X-Patchwork-Delegate: bpf@iogearbox.net Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28321260A4A for ; Wed, 19 Feb 2025 23:31:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740007869; cv=none; b=dvk+i2LHVQX66RxVpWDKNp55XH6WgbsHM11attF3u1hGUkEPgryTV5E0KEnN85zmWqcfIJKRWyAj523jtKfqXh3vY8yiFkhXrwMSLbN3qWGxITSxreyiumrlqh0i18QtsOh//0WxrejPC2k941ZanDL3CYs/77esy4bi2mcfe+g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740007869; c=relaxed/simple; bh=9oI+CryHIWFfVk+vJAE0HpM32KMTc4S6nwYfuupuVcw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MNemYPjxkSW9u3RLoJUZUY50vau7hLmlLJOCYhpMipw+Eifx06WzYlJAm8wPUl+Yh0dGDeCn06IQ5raTaU5UeVswzmbTAGeiwDBMPNAU0Hi4qNh90CfnoQ9hO+GfpXXRwV7qj1S+TOeOTpveryJN2Oxp+Dr3m+7n2iBGGG/QXog= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZtELp/yY; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZtELp/yY" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-38f5fc33602so198312f8f.0 for ; Wed, 19 Feb 2025 15:31:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740007865; x=1740612665; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WtGC9yy/rZNIhGxG00U3J4p1ioOI+GZIf1K3eZY5cOM=; b=ZtELp/yYEV1qY6hSf660mzMqV1dAS2LDGKI/3c5CJzUFeJeVhMLUVziDFlfilXGkcw 3rwiU0x5ep/NR9unc2iwYCMqlDEU8LKt1UIOJx50qPlYrCsz6I6Qf4fFE4UvHy6ZLMxK /QARZ+R3L9b/eT+rsbo0rFX0o1t3ODSiPa8NEmue4ukKRjlw6u0UCmGAZJa1n5n4DwXH nKwv9W7zlDNYoFZKrqpjfLopFmntmwiUQTUlucXegvWtE7JAO0slrh5gdHbybydAaLtZ 9T6TlGXotwMsetYafxkKSkKyT9e/EvNmZ0yUAmmJ8qTJsJsLQgD6JlQS2HwT6EzZFI5C 3IbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740007865; x=1740612665; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WtGC9yy/rZNIhGxG00U3J4p1ioOI+GZIf1K3eZY5cOM=; b=jn9H5CG0OZkDH47jR64IqYFEmRxW5KJol6A9llP76qhDT7MTJIeKN+lT2pweIOCLfY DvGxk7dMI6HhrFKeD11hsqnMHvck028K3Fy3I3Q/oMNfJNSWMkScjVOUXk5EvoLDcGTk 9CfPLVqEwmlY7dRGnRPnLEQIwlemcRYncI+88vMAXrwPDmWWmicy5dLv6ujBX7DCbOME UAfGUrLAzKf5tz2P08Gdfbe049uj+cIY/zc2o0OI7FTufFUlvKWwWtr1TZHmpp33qhSB JLDqz4li07EV28CXcpc5GXJumWBIHUDLPZtrCkKVQ1Z/Ev8WzUkTsp8A+V2uUl7pYPgS e+WQ== X-Gm-Message-State: AOJu0Yzl5bcnzHxUXwDYFpAGa2BigRnlTbap7WpO8Xb93JXcDW9ckh3e /tepeDsRQQ89unZfmpuPl3SW9DnOrcv1ENzKvuwUtd/g2mUdbasAdVGeqg== X-Gm-Gg: ASbGnct57aFHLQzh7F+AvLDbRiFnXanrT/uLP1/QIRQvgDIeVBXmOvp4T55E3hJUsIf Ks+unbSwReqg8VpIh6VatZKu4Z3zzhCnD0mqk6eMZXm1zsvGrZ8ncFKgSz9L4pvbt/CzynJPQkP 5Zk279GUIN71RUzls9rEOBYntmKctnaPIkvA3T5Oqmg3GmU6Amp3LpVfndFHZI0GL1hApqardIg g10FXn9RkS2F6Wrb/sx3aAICS86oLEyDlm6eOGA5krJQDG26zbQysfActT/ZewYhsCc6M+sJTHM Pc8hdae8XxEjuhIceTe3k+F7wQEL8pkLGOXNzL5wyMTUqfjlNJS06NN5TPoRi0Hrt7FUGMKYkfM 7kyf/U8wYCMjm9tDBRotu X-Google-Smtp-Source: AGHT+IGVfiYj46jle18rJGsJlQo/B4ruKVXJnmMPXjcAEy7t0CP0kQ4euek8UuJO+tQv2rP11c37vw== X-Received: by 2002:a5d:5f4d:0:b0:38c:5da8:5f88 with SMTP id ffacd0b85a97d-38f61609df3mr1043559f8f.28.1740007865313; Wed, 19 Feb 2025 15:31:05 -0800 (PST) Received: from localhost.localdomain (cpc158789-hari22-2-0-cust468.20-2.cable.virginm.net. [86.26.115.213]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38f259f7998sm18779048f8f.82.2025.02.19.15.31.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Feb 2025 15:31:04 -0800 (PST) From: Mykyta Yatsenko To: bpf@vger.kernel.org, ast@kernel.org, andrii@kernel.org, daniel@iogearbox.net, kafai@meta.com, kernel-team@meta.com, eddyz87@gmail.com Cc: Mykyta Yatsenko Subject: [PATCH bpf-next v3 2/2] selftests/bpf: introduce veristat test Date: Wed, 19 Feb 2025 23:30:45 +0000 Message-ID: <20250219233045.201595-3-mykyta.yatsenko5@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250219233045.201595-1-mykyta.yatsenko5@gmail.com> References: <20250219233045.201595-1-mykyta.yatsenko5@gmail.com> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: bpf@iogearbox.net From: Mykyta Yatsenko Introducing test for veristat, part of test_progs. Test cases cover functionality of setting global variables in BPF program. Signed-off-by: Mykyta Yatsenko Acked-by: Eduard Zingerman --- tools/testing/selftests/bpf/Makefile | 1 + .../selftests/bpf/prog_tests/test_veristat.c | 136 ++++++++++++++++++ .../selftests/bpf/progs/set_global_vars.c | 47 ++++++ tools/testing/selftests/bpf/test_progs.h | 8 ++ 4 files changed, 192 insertions(+) create mode 100644 tools/testing/selftests/bpf/prog_tests/test_veristat.c create mode 100644 tools/testing/selftests/bpf/progs/set_global_vars.c diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile index 0d552bfcfe7d..5e9d3c91c6db 100644 --- a/tools/testing/selftests/bpf/Makefile +++ b/tools/testing/selftests/bpf/Makefile @@ -690,6 +690,7 @@ $(OUTPUT)/$(TRUNNER_BINARY): $(TRUNNER_TEST_OBJS) \ $(TRUNNER_EXTRA_OBJS) $$(BPFOBJ) \ $(RESOLVE_BTFIDS) \ $(TRUNNER_BPFTOOL) \ + $(OUTPUT)/veristat \ | $(TRUNNER_BINARY)-extras $$(call msg,BINARY,,$$@) $(Q)$$(CC) $$(CFLAGS) $$(filter %.a %.o,$$^) $$(LDLIBS) $$(LDFLAGS) -o $$@ diff --git a/tools/testing/selftests/bpf/prog_tests/test_veristat.c b/tools/testing/selftests/bpf/prog_tests/test_veristat.c new file mode 100644 index 000000000000..eff79bf55fe3 --- /dev/null +++ b/tools/testing/selftests/bpf/prog_tests/test_veristat.c @@ -0,0 +1,136 @@ +// SPDX-License-Identifier: GPL-2.0 +/* Copyright (c) 2025 Meta Platforms, Inc. and affiliates. */ +#include +#include +#include + +#define __CHECK_STR(str, name) \ + do { \ + if (!ASSERT_HAS_SUBSTR(fix->output, (str), (name))) \ + goto out; \ + } while (0) + +struct fixture { + char tmpfile[80]; + int fd; + char *output; + size_t sz; + char veristat[80]; +}; + +static struct fixture *init_fixture(void) +{ + struct fixture *fix = malloc(sizeof(struct fixture)); + + if (access("./veristat", F_OK) == 0) + strcpy(fix->veristat, "./veristat"); + /* for no_alu32 and cpuv4 veristat is in parent folder */ + if (access("../veristat", F_OK) == 0) + strcpy(fix->veristat, "../veristat"); + + snprintf(fix->tmpfile, sizeof(fix->tmpfile), "/tmp/test_veristat.XXXXXX"); + fix->fd = mkstemp(fix->tmpfile); + fix->sz = 1000000; + fix->output = malloc(fix->sz); + return fix; +} + +static void teardown_fixture(struct fixture *fix) +{ + free(fix->output); + close(fix->fd); + remove(fix->tmpfile); + free(fix); +} + +static void test_set_global_vars_succeeds(void) +{ + struct fixture *fix = init_fixture(); + + SYS(out, + "%s set_global_vars.bpf.o"\ + " -G \"var_s64 = 0xf000000000000001\" "\ + " -G \"var_u64 = 0xfedcba9876543210\" "\ + " -G \"var_s32 = -0x80000000\" "\ + " -G \"var_u32 = 0x76543210\" "\ + " -G \"var_s16 = -32768\" "\ + " -G \"var_u16 = 60652\" "\ + " -G \"var_s8 = -128\" "\ + " -G \"var_u8 = 255\" "\ + " -G \"var_ea = EA2\" "\ + " -G \"var_eb = EB2\" "\ + " -G \"var_ec = EC2\" "\ + " -G \"var_b = 1\" "\ + "-vl2 > %s", fix->veristat, fix->tmpfile); + + read(fix->fd, fix->output, fix->sz); + __CHECK_STR("_w=0xf000000000000001 ", "var_s64 = 0xf000000000000001"); + __CHECK_STR("_w=0xfedcba9876543210 ", "var_u64 = 0xfedcba9876543210"); + __CHECK_STR("_w=0x80000000 ", "var_s32 = -0x80000000"); + __CHECK_STR("_w=0x76543210 ", "var_u32 = 0x76543210"); + __CHECK_STR("_w=0x8000 ", "var_s16 = -32768"); + __CHECK_STR("_w=0xecec ", "var_u16 = 60652"); + __CHECK_STR("_w=128 ", "var_s8 = -128"); + __CHECK_STR("_w=255 ", "var_u8 = 255"); + __CHECK_STR("_w=11 ", "var_ea = EA2"); + __CHECK_STR("_w=12 ", "var_eb = EB2"); + __CHECK_STR("_w=13 ", "var_ec = EC2"); + __CHECK_STR("_w=1 ", "var_b = 1"); + +out: + teardown_fixture(fix); +} + +static void test_set_global_vars_from_file_succeeds(void) +{ + struct fixture *fix = init_fixture(); + char input_file[80]; + const char *vars = "var_s16 = -32768\nvar_u16 = 60652"; + int fd; + + snprintf(input_file, sizeof(input_file), "/tmp/veristat_input.XXXXXX"); + fd = mkstemp(input_file); + if (!ASSERT_GE(fd, 0, "valid fd")) + goto out; + + write(fd, vars, strlen(vars)); + SYS(out, "%s set_global_vars.bpf.o -G \"@%s\" -vl2 > %s", + fix->veristat, input_file, fix->tmpfile); + read(fix->fd, fix->output, fix->sz); + __CHECK_STR("_w=0x8000 ", "var_s16 = -32768"); + __CHECK_STR("_w=0xecec ", "var_u16 = 60652"); + +out: + close(fd); + remove(input_file); + teardown_fixture(fix); +} + +static void test_set_global_vars_out_of_range(void) +{ + struct fixture *fix = init_fixture(); + + SYS_FAIL(out, + "%s set_global_vars.bpf.o -G \"var_s32 = 2147483648\" -vl2 2> %s", + fix->veristat, fix->tmpfile); + + read(fix->fd, fix->output, fix->sz); + __CHECK_STR("is out of range [-2147483648; 2147483647]", "out of range"); + +out: + teardown_fixture(fix); +} + +void test_veristat(void) +{ + if (test__start_subtest("set_global_vars_succeeds")) + test_set_global_vars_succeeds(); + + if (test__start_subtest("set_global_vars_out_of_range")) + test_set_global_vars_out_of_range(); + + if (test__start_subtest("set_global_vars_from_file_succeeds")) + test_set_global_vars_from_file_succeeds(); +} + +#undef __CHECK_STR diff --git a/tools/testing/selftests/bpf/progs/set_global_vars.c b/tools/testing/selftests/bpf/progs/set_global_vars.c new file mode 100644 index 000000000000..9adb5ba4cd4d --- /dev/null +++ b/tools/testing/selftests/bpf/progs/set_global_vars.c @@ -0,0 +1,47 @@ +// SPDX-License-Identifier: GPL-2.0 +/* Copyright (c) 2025 Meta Platforms, Inc. and affiliates. */ +#include "bpf_experimental.h" +#include +#include "bpf_misc.h" +#include + +char _license[] SEC("license") = "GPL"; + +enum Enum { EA1 = 0, EA2 = 11 }; +enum Enumu64 {EB1 = 0llu, EB2 = 12llu }; +enum Enums64 { EC1 = 0ll, EC2 = 13ll }; + +const volatile __s64 var_s64 = -1; +const volatile __u64 var_u64 = 0; +const volatile __s32 var_s32 = -1; +const volatile __u32 var_u32 = 0; +const volatile __s16 var_s16 = -1; +const volatile __u16 var_u16 = 0; +const volatile __s8 var_s8 = -1; +const volatile __u8 var_u8 = 0; +const volatile enum Enum var_ea = EA1; +const volatile enum Enumu64 var_eb = EB1; +const volatile enum Enums64 var_ec = EC1; +const volatile bool var_b = false; + +char arr[4] = {0}; + +SEC("socket") +int test_set_globals(void *ctx) +{ + volatile __s8 a; + + a = var_s64; + a = var_u64; + a = var_s32; + a = var_u32; + a = var_s16; + a = var_u16; + a = var_s8; + a = var_u8; + a = var_ea; + a = var_eb; + a = var_ec; + a = var_b; + return a; +} diff --git a/tools/testing/selftests/bpf/test_progs.h b/tools/testing/selftests/bpf/test_progs.h index 404d0d4915d5..870694f2a359 100644 --- a/tools/testing/selftests/bpf/test_progs.h +++ b/tools/testing/selftests/bpf/test_progs.h @@ -427,6 +427,14 @@ void hexdump(const char *prefix, const void *buf, size_t len); goto goto_label; \ }) +#define SYS_FAIL(goto_label, fmt, ...) \ + ({ \ + char cmd[1024]; \ + snprintf(cmd, sizeof(cmd), fmt, ##__VA_ARGS__); \ + if (!ASSERT_NEQ(0, system(cmd), cmd)) \ + goto goto_label; \ + }) + #define ALL_TO_DEV_NULL " >/dev/null 2>&1" #define SYS_NOFAIL(fmt, ...) \