From patchwork Thu Feb 20 17:44:12 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksii Kurochko X-Patchwork-Id: 13984353 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5312FC021B3 for ; Thu, 20 Feb 2025 17:44:33 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.894056.1302911 (Exim 4.92) (envelope-from ) id 1tlAb4-0005Po-Ol; Thu, 20 Feb 2025 17:44:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 894056.1302911; Thu, 20 Feb 2025 17:44:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tlAb4-0005P8-KR; Thu, 20 Feb 2025 17:44:26 +0000 Received: by outflank-mailman (input) for mailman id 894056; Thu, 20 Feb 2025 17:44:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tlAb3-000469-G8 for xen-devel@lists.xenproject.org; Thu, 20 Feb 2025 17:44:25 +0000 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [2a00:1450:4864:20::136]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 52767291-efb2-11ef-9896-31a8f345e629; Thu, 20 Feb 2025 18:44:23 +0100 (CET) Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-5454f00fc8dso1123948e87.0 for ; Thu, 20 Feb 2025 09:44:23 -0800 (PST) Received: from fedora.. ([94.75.70.14]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54619e7bc2esm1600904e87.244.2025.02.20.09.44.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Feb 2025 09:44:22 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 52767291-efb2-11ef-9896-31a8f345e629 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740073463; x=1740678263; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oYTq60dCm0oueVL7ngcy1QPIgBRII2BLwz0B+u62Oqo=; b=SyDpQzox84ZFdQ+pToXWHkVwygn6tqNtBQwhfPq60dNpurQqfL5edykJG5h5ibaR/6 Ew7SjBY0E59+zDVoCZ2Ltt5CM97BJHdiztJbVwORnDXpLrlwAhQHg9FZpDWGCWQDcxUI 2rqqikGYDsm68LnRDGlcIDRAksesahVqwXW6uyQ6E2+SimRqwa0uqtf3E6AJH4RSXDsK ELSsAO0qETRR0Zrz+zhbyIsuQHGycVA7T7YfjSsNNs/5Vazq4hI30wt+KMErhZeCSc2x phMQ6cjAgN4EWmxLA8kN+G0U20r47U2jn4Z6KYEFjD8tESMUx2i8mBTnDW4mqa0aLtDD Zj7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740073463; x=1740678263; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oYTq60dCm0oueVL7ngcy1QPIgBRII2BLwz0B+u62Oqo=; b=UnQu4XJpHUod/LFqH4VmvKljlc8YLydfI4W6lwdOYSliy0xmR+KSa7Y0vOiaqUYxlh n6QPXJ6tW/tP7hyGN/TMtWDN4tl7j2O57sQji3a0p8jcMPmVALVQ3y6hetAo+owdWTHz nFeeKEu8ws8fGVIXl6ED8vVuVo7GY6WlBcVNt2Z1iZeq6kIPjb6RSQzZ8qxFcI0pLL9/ karWgcJH4CSnQv43uZ2rEUxXHfCMQXygij4ehJI6rwOQkMwGEtKZfVpqzvo4mn3KM+2V bm44xyTT/7Y/oHUaJ2HLS1317gjx+1XZGyvt2BeQTYTMxIVSW2fDDdN8/ZZpd+MPpfdo GtOA== X-Gm-Message-State: AOJu0YyiGAFfTy367E+dhau6yEzrue9vlo0OTmKAJm1EZzjgrrqQ4s3l 1TlNoCbxGJlirhGFOa35nE02awW0yUa6de0IciF419KRPG5Z25df7gS50g== X-Gm-Gg: ASbGncunrFp1zYlt1DzCs7G0EyzfamAmPxZmDt7oxwxqYbreN/PRvVpAw+6rmPLC0AI 7eWUXL7aw+vDQ7H/V5qXFasXBUFY97ypelqzPnQSJgFGgmXMrYRboGxzJVA4ZHMy3oc8gXB23iA YJV72vXxwGCZK8UHTf9xZmSgJgVdOkThc/v16lCLBV8oYQO1BXArUF2LXGy4eS5HfDGnUHOEbwV h1nQ3HEMU7BVupRTOcGIKbPYGZMXqHFxiZMagFKxlwgs54Q37pFh8kEsq4sSg9QLCOAhtW5W3Ip hZ54fVJOvQIMKZLc X-Google-Smtp-Source: AGHT+IF7igNsSkCtNDbnRn7i1YCeJfkJ0ycL+wVg3wZGfVddXV0HgvlH6ptDFOf8mGCw78AvBWzmJw== X-Received: by 2002:a05:6512:159a:b0:545:291:7ee0 with SMTP id 2adb3069b0e04-5462ef1c613mr3923529e87.34.1740073462981; Thu, 20 Feb 2025 09:44:22 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Oleksii Kurochko , Doug Goldstein , Stefano Stabellini Subject: [PATCH for 4.21 v7 1/4] automation: drop debian:11-riscv64 container Date: Thu, 20 Feb 2025 18:44:12 +0100 Message-ID: <659bd8c00e79be1a47fc2aae75accd69b3bedaf4.1740071755.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: References: MIME-Version: 1.0 There are two reasons for that: 1. In the README, GCC baseline is chosen to be 12.2, whereas Debian 11 uses GCC 10.2.1. 2. Xen requires mandatory some Z extensions, but GCC 10.2.1 does not support Z extensions in -march, causing the compilation to fail. Signed-off-by: Oleksii Kurochko --- Changes in v7: - new patch. --- automation/gitlab-ci/build.yaml | 14 -------------- automation/scripts/containerize | 1 - 2 files changed, 15 deletions(-) diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml index 35e224366f..57fe29127d 100644 --- a/automation/gitlab-ci/build.yaml +++ b/automation/gitlab-ci/build.yaml @@ -720,20 +720,6 @@ debian-12-ppc64le-gcc: HYPERVISOR_ONLY: y # RISC-V 64 cross-build -debian-11-riscv64-gcc: - extends: .gcc-riscv64-cross-build - variables: - CONTAINER: debian:11-riscv64 - KBUILD_DEFCONFIG: tiny64_defconfig - HYPERVISOR_ONLY: y - -debian-11-riscv64-gcc-debug: - extends: .gcc-riscv64-cross-build-debug - variables: - CONTAINER: debian:11-riscv64 - KBUILD_DEFCONFIG: tiny64_defconfig - HYPERVISOR_ONLY: y - debian-12-riscv64-gcc: extends: .gcc-riscv64-cross-build variables: diff --git a/automation/scripts/containerize b/automation/scripts/containerize index bc43136078..0953e0728c 100755 --- a/automation/scripts/containerize +++ b/automation/scripts/containerize @@ -31,7 +31,6 @@ case "_${CONTAINER}" in _fedora) CONTAINER="${BASE}/fedora:41-x86_64";; _bullseye-ppc64le) CONTAINER="${BASE}/debian:11-ppc64le" ;; _bookworm-ppc64le) CONTAINER="${BASE}/debian:12-ppc64le" ;; - _bullseye-riscv64) CONTAINER="${BASE}/debian:11-riscv64" ;; _bookworm-riscv64) CONTAINER="${BASE}/debian:12-riscv64" ;; _bookworm-x86_64-gcc-ibt) CONTAINER="${BASE}/debian:12-x86_64-gcc-ibt" ;; _bookworm|_bookworm-x86_64|_) CONTAINER="${BASE}/debian:12-x86_64" ;; From patchwork Thu Feb 20 17:44:13 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Oleksii Kurochko X-Patchwork-Id: 13984355 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7DCA7C021B3 for ; Thu, 20 Feb 2025 17:44:36 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.894060.1302926 (Exim 4.92) (envelope-from ) id 1tlAb7-0005tt-Fd; Thu, 20 Feb 2025 17:44:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 894060.1302926; Thu, 20 Feb 2025 17:44:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tlAb7-0005s2-7G; Thu, 20 Feb 2025 17:44:29 +0000 Received: by outflank-mailman (input) for mailman id 894060; Thu, 20 Feb 2025 17:44:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tlAb5-000469-0i for xen-devel@lists.xenproject.org; Thu, 20 Feb 2025 17:44:27 +0000 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [2a00:1450:4864:20::232]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 53564bd3-efb2-11ef-9896-31a8f345e629; Thu, 20 Feb 2025 18:44:25 +0100 (CET) Received: by mail-lj1-x232.google.com with SMTP id 38308e7fff4ca-3076262bfc6so12663321fa.3 for ; Thu, 20 Feb 2025 09:44:25 -0800 (PST) Received: from fedora.. ([94.75.70.14]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54619e7bc2esm1600904e87.244.2025.02.20.09.44.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Feb 2025 09:44:23 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 53564bd3-efb2-11ef-9896-31a8f345e629 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740073464; x=1740678264; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9oI63t7vbkRwo0ryN869PS74UDKf8jwfaKSN0DbSDcU=; b=OdFC7kKfKcInsdkvKYjfOqSnEcK/VyyzH0tb+/MqI/Demrx6xRoOSzr3GFctVrd3SF UdESIny59O1dPGQOEBSYLHZ/rucHUa2xMxSCkAqLdz3PzHydm7EkhgSZEUVh7MU4QYUX 6WgnVwhNzJ1yWIbfseAZbjYADgHb2uedUX4LSo7K1NnNwnz2pNlx8syPmA+rVf5djcaJ mJiGVq1CL8yexXvmNiDwAWxvI1X9PicKiDoEpxTuxS+DPCAE/TRg914ldpIya/eacYqL IWNFzNPFOQdGxLQrivnXaog6khXTlo9kQdTAnJit1PNtU1O85iPUF+UGeW+QTTUe5qdt Wtmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740073464; x=1740678264; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9oI63t7vbkRwo0ryN869PS74UDKf8jwfaKSN0DbSDcU=; b=KVfrvTypX7NrwisawZSmFUtQF5uDeY3MiP+/IcbLnCBEHYvUgV/e/5zGqVucTEdkBK kV5NvKhD4T6osWHoOrHADMVFeBte6WSZvlwyf0zH73KU4B0c6e4V6PTXQvGJHQfLgO6p Dbllni8YQutgIdjKsY5HkC5U/39mcH2Txryac6ZMw09lbKXKSt6B02GCTUq1e3SQqKAc w1lWLC520i8m9YJQY0Jkgs+dO7jtsLpEbE9YKnjkNgo2yDADSO6tAKsv3MIyUISLCgEe FhI7ytMqoQemqiYaQiYwArDDQAeTDbO7gBfdv5baL5RTVt0KqsrxMxzjBFTKVRW4DpJ5 afDQ== X-Gm-Message-State: AOJu0YxOjhhnZL//obFqSeTPXJlFYagt6KAee/M4FBdztMRgWiNfA5gT pvVKehwsUPawTgfG04W57W2UXvCG8To8PvYk21gfltZhAUIpSjynX0dTjA== X-Gm-Gg: ASbGnct8ntL7gTTbCGY32Cb/sfQO6836j9L/p80bj8iMszVDtWgOjV3+yL77YXhSag9 WlFsZBHPEgRAopTsNzKEFgrmqolXS64QPSkNl75JJgpvt3qq6Q+KOFPI0579WnfFBjxLK2cGdSQ CG22hVlOEA8kSItwhXSYfwywGqzOn90Tj3vkRjMvyzh+9QasTyzdHY6bCSvr5ajvZt7Oz6ufnVB u/Guubffjg4rm8ntFXrrGlmjF65ApzerJCysDXJst8EHdviqbd8arbOg1So6V7+RKpHeueJJK6x q/TnQbEluyR+CN8t X-Google-Smtp-Source: AGHT+IHEN1afJNGPcuaEcHW03kiyYnkf2QitDJDDrra5wQfbQj1NrrwZGolqHQ0KCCuK5YxH9AE/eg== X-Received: by 2002:a05:6512:1105:b0:545:764:2f8d with SMTP id 2adb3069b0e04-5452fe938c6mr9565418e87.44.1740073463994; Thu, 20 Feb 2025 09:44:23 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Oleksii Kurochko , Alistair Francis , Bob Eshleman , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?utf-8?q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini Subject: [PATCH for 4.21 v7 2/4] xen/riscv: drop CONFIG_RISCV_ISA_RV64G Date: Thu, 20 Feb 2025 18:44:13 +0100 Message-ID: X-Mailer: git-send-email 2.48.1 In-Reply-To: References: MIME-Version: 1.0 'G' stands for "imafd_zicsr_zifencei". Extensions 'f' and 'd' aren't really needed for Xen, and allowing floating point registers to be used can lead to crashes. Extensions 'i', 'm', 'a', 'zicsr', and 'zifencei' are necessary for the operation of Xen, which is why they are used explicitly (unconditionally) in -march. Drop "Base ISA" choice from riscv/Kconfig as it is always empty. Signed-off-by: Oleksii Kurochko --- Changes in V7: - For better readability use += instead of := for riscv-march-* in arch.mk. - Drop spaces from riscv-march-y by usage of subst macros. - Drop "Base ISA" choice as it is empty now. - Update the commit message. --- Changes in V6: - new patch. --- xen/arch/riscv/Kconfig | 18 ------------------ xen/arch/riscv/arch.mk | 8 +++++--- 2 files changed, 5 insertions(+), 21 deletions(-) diff --git a/xen/arch/riscv/Kconfig b/xen/arch/riscv/Kconfig index fa95cd0a42..d882e0a059 100644 --- a/xen/arch/riscv/Kconfig +++ b/xen/arch/riscv/Kconfig @@ -23,24 +23,6 @@ endmenu menu "ISA Selection" -choice - prompt "Base ISA" - default RISCV_ISA_RV64G if RISCV_64 - help - This selects the base ISA extensions that Xen will target. - -config RISCV_ISA_RV64G - bool "RV64G" - help - Use the RV64I base ISA, plus - "M" for multiply/divide, - "A" for atomic instructions, - “F”/"D" for {single/double}-precision floating-point instructions, - "Zicsr" for control and status register access, - "Zifencei" for instruction-fetch fence. - -endchoice - config RISCV_ISA_C bool "Compressed extension" default y diff --git a/xen/arch/riscv/arch.mk b/xen/arch/riscv/arch.mk index 17827c302c..3034da76cb 100644 --- a/xen/arch/riscv/arch.mk +++ b/xen/arch/riscv/arch.mk @@ -6,10 +6,12 @@ $(call cc-options-add,CFLAGS,CC,$(EMBEDDED_EXTRA_CFLAGS)) riscv-abi-$(CONFIG_RISCV_32) := -mabi=ilp32 riscv-abi-$(CONFIG_RISCV_64) := -mabi=lp64 -riscv-march-$(CONFIG_RISCV_ISA_RV64G) := rv64g -riscv-march-$(CONFIG_RISCV_ISA_C) := $(riscv-march-y)c +riscv-march-$(CONFIG_RISCV_64) := rv64 +riscv-march-y += ima +riscv-march-$(CONFIG_RISCV_ISA_C) += c +riscv-march-y += _zicsr_zifencei -riscv-generic-flags := $(riscv-abi-y) -march=$(riscv-march-y) +riscv-generic-flags := $(riscv-abi-y) -march=$(subst $(space),,$(riscv-march-y)) # check-extension: Check whether extenstion is supported by a compiler and # an assembler. From patchwork Thu Feb 20 17:44:14 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksii Kurochko X-Patchwork-Id: 13984354 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1CED3C021B1 for ; Thu, 20 Feb 2025 17:44:36 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.894057.1302921 (Exim 4.92) (envelope-from ) id 1tlAb6-0005oI-Vt; Thu, 20 Feb 2025 17:44:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 894057.1302921; Thu, 20 Feb 2025 17:44:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tlAb6-0005o5-S7; Thu, 20 Feb 2025 17:44:28 +0000 Received: by outflank-mailman (input) for mailman id 894057; Thu, 20 Feb 2025 17:44:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tlAb4-0003tj-Oh for xen-devel@lists.xenproject.org; Thu, 20 Feb 2025 17:44:26 +0000 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [2a00:1450:4864:20::135]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 53fa0638-efb2-11ef-9aa9-95dc52dad729; Thu, 20 Feb 2025 18:44:26 +0100 (CET) Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-547bcef2f96so638001e87.1 for ; Thu, 20 Feb 2025 09:44:26 -0800 (PST) Received: from fedora.. ([94.75.70.14]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54619e7bc2esm1600904e87.244.2025.02.20.09.44.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Feb 2025 09:44:24 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 53fa0638-efb2-11ef-9aa9-95dc52dad729 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740073466; x=1740678266; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GfTE4xLgX/dOLMTD+d3nRIgvQgv9cL+Smevhi13SZIg=; b=FFw3b8Sd8PTIP50nzlfZXlAe5+1tdabxvtmfv7Cbhe8fzUU55stqyYMQS5NHijlRWk RuNOmIRWYCy0w/mM3m0aUjlwu1qfahPNqFS2CbAgC6/0KDznHN5Bq4lb5QWE2NfxlE+W exHcr7NhvBFrrmYb7sDHco8ygH/xGOVYbjEmbmHO2irbh64X9yhfhZRDx3vDYPWg424v APRggCNeUBeejXO6WKc4KCQHhHcHMCSZzp1DAd1JMORsYeK8cQnGx95AmTBbiHv4GMTL D4s3ePhL+DmYkoEjc5FVYTJ0jzaukjzdbtJ2OTDsJVKnMnoTjQF4wWAzHRHNiukcdKn+ 0yqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740073466; x=1740678266; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GfTE4xLgX/dOLMTD+d3nRIgvQgv9cL+Smevhi13SZIg=; b=fTyBGDBVOthtel5cSOLOi0rjAOJtVl7YW2kP5IyZT22H782NWXPBGrGXDpntS751a9 awntEYIEhEm8Jyvd8jv8xH3SSqkr6fsq4lhd/YvMRuwHYJSHCtN1FB5+ViORWv7oUA4l 0QvfaDvpEUl/MQTnk4PP+KHDgg5TJpjyqbLHuIOp0VyzJwVpX94FYnAcURcQ957Pp550 ut6oJanPpmvE096vf6z1jc/rLBva3BqN7sKqwVJdlBMQbVorkv3lHAjVXA3k7W9nleeo nga78M0bTz+WUBagR8l4pba/y7INXtCkC/e4GPXxiMm3+TjpsBgY2gWIzXx+GOuYC+y4 NL1Q== X-Gm-Message-State: AOJu0YwcKcjyfWGKxiw4vPlP7dHFjqvit7VidF22mwJ0312P3hmgGW9o hmrIcdATFzL3YgBflDoxyFIepg+ZRGBM9+mc4jAKVRDkpG7TnxNFfrns2Q== X-Gm-Gg: ASbGncvT/lqDRt8GR75Q61RSrz+2fRMmYIw26SYGLh3jpUYlyRnIAk2Osz7IjquP9/V rf7ufFKtjd6yVyqsakM9+bgzJ1eZxP4sKCy+oYjVIdwlc/Zs1jDlDj2GHG25OKRD0aHDeLFx6st Xb90vFwRdSeV7t8JUuFFJe00V+tKWUq/Dmup0MMQ34U+VHb6yOjo79CWcg4Am7TXDHRrIWOkVGW syEyLlGPNzZCBP9yH6/1qukkAZqUxCK7HxJ2sJsLcc9g7p/rTcHngw9RH1zTrExNAJW9cfeX5H9 nlBSN3voivFXXFA6 X-Google-Smtp-Source: AGHT+IFS9azdP4yjyl+lTGHngETcXp7QTofqYfYAR9N7GVeT8XwiyiU/hko02X75HvvPdjNYvUHTfQ== X-Received: by 2002:a05:6512:b06:b0:545:cd5:84d9 with SMTP id 2adb3069b0e04-547241d9e06mr1651669e87.12.1740073465547; Thu, 20 Feb 2025 09:44:25 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Oleksii Kurochko , Alistair Francis , Bob Eshleman , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?utf-8?q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini Subject: [PATCH for 4.21 v7 3/4] xen/riscv: make zbb as mandatory Date: Thu, 20 Feb 2025 18:44:14 +0100 Message-ID: <611e289e357a26490b95b2aa93d7288c77787171.1740071755.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: References: MIME-Version: 1.0 According to riscv/booting.txt, it is expected that Zbb should be supported. Signed-off-by: Oleksii Kurochko --- Changes in v7: - new patch. --- xen/arch/riscv/arch.mk | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/xen/arch/riscv/arch.mk b/xen/arch/riscv/arch.mk index 3034da76cb..236ea7c8a6 100644 --- a/xen/arch/riscv/arch.mk +++ b/xen/arch/riscv/arch.mk @@ -9,7 +9,7 @@ riscv-abi-$(CONFIG_RISCV_64) := -mabi=lp64 riscv-march-$(CONFIG_RISCV_64) := rv64 riscv-march-y += ima riscv-march-$(CONFIG_RISCV_ISA_C) += c -riscv-march-y += _zicsr_zifencei +riscv-march-y += _zicsr_zifencei_zbb riscv-generic-flags := $(riscv-abi-y) -march=$(subst $(space),,$(riscv-march-y)) @@ -25,13 +25,10 @@ $(eval $(1) := \ $(call as-insn,$(CC) $(riscv-generic-flags)_$(1),$(value $(1)-insn),_$(1))) endef -zbb-insn := "andn t0$(comma)t0$(comma)t0" -$(call check-extension,zbb) - zihintpause-insn := "pause" $(call check-extension,zihintpause) -extensions := $(zbb) $(zihintpause) +extensions := $(zihintpause) extensions := $(subst $(space),,$(extensions)) From patchwork Thu Feb 20 17:44:15 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksii Kurochko X-Patchwork-Id: 13984356 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4F76C021B1 for ; Thu, 20 Feb 2025 17:44:38 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.894063.1302939 (Exim 4.92) (envelope-from ) id 1tlAb9-0006NH-17; Thu, 20 Feb 2025 17:44:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 894063.1302939; Thu, 20 Feb 2025 17:44:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tlAb8-0006Le-Pw; Thu, 20 Feb 2025 17:44:30 +0000 Received: by outflank-mailman (input) for mailman id 894063; Thu, 20 Feb 2025 17:44:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tlAb7-0003tj-52 for xen-devel@lists.xenproject.org; Thu, 20 Feb 2025 17:44:29 +0000 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [2a00:1450:4864:20::135]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 54f5b0ec-efb2-11ef-9aa9-95dc52dad729; Thu, 20 Feb 2025 18:44:28 +0100 (CET) Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-5461dab4bfdso1478155e87.3 for ; Thu, 20 Feb 2025 09:44:28 -0800 (PST) Received: from fedora.. ([94.75.70.14]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54619e7bc2esm1600904e87.244.2025.02.20.09.44.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Feb 2025 09:44:26 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 54f5b0ec-efb2-11ef-9aa9-95dc52dad729 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740073467; x=1740678267; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=INbGKM9qO+IuDzqpap2IDtPXWV9N24ot8TFZMg1hBOA=; b=m3JQkh5Y6VXxl+6QkqqqfrSYygOqknZK/rEbRUDzIcVL07sqleBYl9Itz3GwigqcaF JaXrprJCHOsYL5vYpBKI/vIuplR1V+sjE3+ojxnrhqRdpEsdFuaA/LUSmLmx309gjJR6 FqnqP3NiIiymM0M9fhCWTf9lAhYUg08Lv6lqb0l7lma4vsb2ZrmthYspMtxY7m++Udkk I1dcFyE4NKcsiXfEveDVEs+vlfzzmJaQjTAUDcYWGZcyyW9JtK5JyU3X13tV7VKHFC9E Pt4hPBfULxkoZS1NKxpmJN5qbXda4YUfJH66GxLeb1aVAhgrlQUTWALJ4TZLNqLTgwEy ikrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740073467; x=1740678267; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=INbGKM9qO+IuDzqpap2IDtPXWV9N24ot8TFZMg1hBOA=; b=DkjAmRfEXPXfvFkEjMpzkDLEY+JF9ZpxX1GoHUEBiWEk8br197ORbG93Bo/ih6lwRW lWls7d6u9zcFdukMgAkt10QIG9SLTQijxnXsX4rrEhuEv6PgMxHdxfnDFlSHpeADintv anes/JXsOKPauEYW18h6BRCXqgUYAgydJEY9GAE6GYui3PL6lZYve23fVK+SfdAx1A5i ZZSb6LhT5OuOOeBNDGhiaoWT0GUH4TGmRUwxZtPAW6B12jTQVMDnpHXiWi/pVH/kRpjV y4d/ubdwIouVRLZ/ZaUcAx6/HfQi+uWmwimjw9qmps/fux3/KcnpB1lXGdnW6fsGao+y 1WKQ== X-Gm-Message-State: AOJu0Yx999G7IV4EhgpsVIwohmNgqHh6MLQPvprJh6TVpjnG2BVUA2/k olXaVZSubpV2xX/EbewnV3CHW4NA82sLR3ue+Arz52dMccnd4O6BahXmag== X-Gm-Gg: ASbGncvLVgtIVi90KACS2+9js1iEneSISZIwEhklWaTw7PROt+kC4Jo37euhqgWvUAU s9vTy7CwLkcN6jpCQIJ4utYu3VpvZtDaDDz1VS6+7v8pWAYLS9fP9UmHHTc79wY6JoF+McHlb6+ WgNAhWLnYPU/2f6EbPYQfuLfpju7BEhBZJ8Ra3zrKsl/pyowIc+5ZkqVr6Z2zCp0OM/7imxmRYM L9+lZOGMu9k2qw5bTTpIIUCa0Z/LvB7NvkrvmqNhAYaFosorzkxgatB8V27ZY2kxaLIv22WZp6L YppCqmdyA8Fp8Bps X-Google-Smtp-Source: AGHT+IEcsTZnMvlZYl28Dl66lEbcugQU6l6t7Fep7UEJwHGzWOgJKRXGYplqv0HJKvVD1f78vNNS8Q== X-Received: by 2002:a05:6512:1113:b0:545:a1a:556f with SMTP id 2adb3069b0e04-547262890dcmr1425174e87.50.1740073466536; Thu, 20 Feb 2025 09:44:26 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Oleksii Kurochko , Alistair Francis , Bob Eshleman , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?utf-8?q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini Subject: [PATCH for 4.21 v7 4/4] xen/riscv: identify specific ISA supported by cpu Date: Thu, 20 Feb 2025 18:44:15 +0100 Message-ID: X-Mailer: git-send-email 2.48.1 In-Reply-To: References: MIME-Version: 1.0 Supported ISA extensions are specified in the device tree within the CPU node, using two properties: `riscv,isa-extensions` and `riscv,isa`. Currently, Xen does not support the `riscv,isa-extensions` property and will be added in the future. The `riscv,isa` property is parsed for each CPU, and the common extensions are stored in the `host_riscv_isa` bitmap. This bitmap is then used by `riscv_isa_extension_available()` to check if a specific extension is supported. The current implementation is based on Linux kernel v6.12-rc3 implementation with the following changes: - Drop unconditional setting of {RISCV_ISA_EXT_ZICSR, RISCV_ISA_EXT_ZIFENCEI, RISCV_ISA_EXT_ZICNTR, RISCV_ISA_EXT_ZIHPM} because Xen is going to run on hardware produced after the aforementioned extensions were split out of "i". - Remove saving of the ISA for each CPU, only the common available ISA is saved. - Remove ACPI-related code as ACPI is not supported by Xen. - Drop handling of elf_hwcap, since Xen does not provide hwcap to userspace. - Replace of_cpu_device_node_get() API, which is not available in Xen, with a combination of dt_for_each_child_node(), dt_device_type_is_equal(), and dt_get_cpuid_from_node() to retrieve cpuid and riscv,isa in riscv_fill_hwcap_from_isa_string(). - Rename arguments of __RISCV_ISA_EXT_DATA() from _name to ext_name, and _id to ext_id for clarity. - Replace instances of __RISCV_ISA_EXT_DATA with RISCV_ISA_EXT_DATA. - Replace instances of __riscv_isa_extension_available with riscv_isa_extension_available for consistency. Also, update the type of `bit` argument of riscv_isa_extension_available(). - Redefine RISCV_ISA_EXT_DATA() to work only with ext_name and ext_id, as other fields are not used in Xen currently. Also RISCV_ISA_EXT_DATA() is reworked in the way to take only one argument `ext_name`. - Add check of first 4 letters of riscv,isa string to riscv_isa_parse_string() as Xen doesn't do this check before so it is necessary to check correctness of riscv,isa string. ( it should start with rv{32,64} with taking into account upper and lower case of "rv"). Additionally, check also that 'i' goes after 'rv{32,64}' to be sure that `out_bitmap` can't be empty. - Drop an argument of riscv_fill_hwcap() and riscv_fill_hwcap_from_isa_string() as it isn't used, at the moment. - Update the comment message about QEMU workaround. - Apply Xen coding style. - s/pr_info/printk. - Drop handling of uppercase letters of riscv,isa in riscv_isa_parse_string() as Xen checks that riscv,isa should be in lowercase according to the device tree bindings. - Update logic of riscv_isa_parse_string(): now it stops parsing of riscv,isa if illegal symbol was found instead of ignoring them. Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in V7: - Add blanks around '##' in RISCV_ISA_EXT_DATA macros. - Add zba and zbs to riscv_isa_ext[] as we have such in enumerators so someone could try to ask if it is supported or not by CPU. - Fix the comment, start from uppercase letter. - Add Acked-by: Jan Beulich . --- Changes in V6: - Explicitly set ZBA, ZBB, ZBS extensions if `b` is present in riscv,isa. - Update enum riscv_isa_ext_id; not an extension name is in lowercase. - Update RISCV_ISA_EXT_DATA() macro to recieve only one argument. - Add __init for is_lowercase_extension_name(). - Indent label by one blank. - Add quotes around %c. - Drop extensions 'f' and 'd' from required_extensions[] array. - Update the commit message. --- Changes in V5: - Add IMAFD + zifencei extensions to required_extensions[] as we are using -maarch=rv64g* for compilation. - Add "C" extension to required_extensions[] as if CONFIG_RISCV_ISA_C=y then -march will be = rv64gc*. - Fix typos. - s/strncmp/memcmp. - Drop usage of ext_err and reuse ext_end instead. - Drop tolower() functions as we guarante that riscv,isa will be in lower case. - Declare req_extns_amount as const. - Check what riscv_isa_parse_string() returns. - Add check that Vendor extensions (case 'x') name is alnum. - Return -EINVAL from riscv_isa_parse_string() if an extension has wrong name. - Update logic of riscv_isa_parse_string(): now it stop parsing of riscv,isa if illegal symbol was found instead of ignoring them. - Drop ASSERT ASSERT(!bitmap_empty(this_isa, RISCV_ISA_EXT_MAX)) as now riscv_isa_parse_string() has a check which guarantes that, at least, "rv{32,64}i" is in "riscv,isa" thereby this_isa can't be empty. - Update the commit message. --- Changes in V4: - Add "Originally ... " at the start of cpufeature.c. - Sync required_extensions[] with riscv_isa_ext[] in terms of element sorting/ordering. - Fix identations. - s/#error/# error. - With insisting on ISA string being all lowercase, drop handling the uppercases in riscv_isa_parse_string(). - check riscv,isa recieved from device tree; it must be in lowercase. - Update ASSERT() in match_isa_ext(): drop checking of riscv,isa recieved from device tree as this check was moved to riscv_fill_hwcap(). - Update is_lowercase_extension_name() to ignore digits as they could be used for extension version which is part of the extension name so should be skipped. - Alight ternanry operator properly in riscv_fill_hwcap(). - Update the commit message: add information that handling of uppercase letters in riscv,isa are dropped in riscv_isa_parsing_string() becase Xen checks that riscv,isa must be all in lowercase according to device tree binding. --- Changes in V3: - Drop description of changes in cpufeature.c and leave only in the commit message to not deal with possible staleness of them in the future. - Update for dt_get_cpuid_from_node(): - update printk() message. - add some explanation about if-condition on the start of the function. - add dt_cpuid argument for function dt_get_cpuid_from_node() to deal with potential truncation issue from paddr_t (dt_read_paddr() returns that ) to int. - Add Zicsr to required_extensions[]. - Drop an argument check at the start of is_lowercase_extension_name() as function is static and callers are expected to pass a good pointer. - Add a comment with some additional explanation about the stop condition of checking a case of extension name. - Omit blanks after opening and closing parentheses in the comments. - Add missed parentheses in match_isa_ext(). - Drop ASSERT() which checks that first two letters of `isa` string are in lower case as after this ASSERT() there is an if-condition which does the same. - Cut part of printk_once()'s message in riscv_isa_parse_string() related to riscv,isa-extension as it isn't supported for now and usage of it will lead to panic(). - Drop function riscv_fill_hwcap_from_ext_list() at all as Xen isn't going to support riscv,isa-extensions for now. - Clarify printk()'s message when riscv,isa property wasn't found in cpu node. Now it contains "for DT's cpu%d node", where %d is cpuid, instead of "for cpu%d" to not confuse cpuid number ( if it Xen's cpu id and physical cpu's id). - Updates in riscv_isa_extension_available(): - Drop local varible `bmap` and initialize `isa_bitmap` in more readable way. - Rename argument `bit` of riscv_isa_extension_available() to `id` for clearness. - Update handling of failure of h/w capabilities parsing in riscv_fill_hwcap(). - Introduce has_isa_extensions_property() to check if "riscv,isa-extension" is present in any device tree cpu node. --- Changes in V2: - Update the list of changes in comparison with Linux on the top of cpufeature.c. - Now really drop all ACPI-related stuff. Add #ifdef CONFIG_ACPI #error ... #endif instead. - Make `id` ( member of riscv_isa_ext_data structure ) not const. - s/__read_mostly/__ro_after_init for riscv_isa bitmap. - Update the comment above riscv_isa_ext[] declaration: - Drop Linux details. - Revised the numbering of the ordering rules for RISC-V ISA extensions. - Add comment that extension name must be all lowercase according to device tree binding. - Add __initconst for declarations of riscv_isa_ext[] and required_extensions[]. - Move riscv_isa_ext_count for global declaration to match_isa_ext where it is really used. - Add new function is_lowercase_extension_name(). - Updates for match_isa_ext(): - Move last argument of match_isa_ext() to new line to not violate line length. - s/int/unsigned int for cycle varible `i`. - s/set_bit/__set_bit as no need for atomicity at this stage of boot. - Add ASSERT() to be sure that extension name is in lowercase. - s/strncasecmp/strncasecmp as extension name must be in a lowercase. - Updates for riscv_isa_parse_string(): - Move last argument of riscv_isa_parse_string() to new line to not violate line length. - Update the checks at the start of the function. Now if CONFIG_RISCV_32=y the only rv32 is accepted, or rv64 for CONFIG_RISCV_64=y. - Drop ACPI-related stuff. - Add blank lines between non-fall-through case blocks. - Add blanks in `for loops` before ')'. - Update the comment about QEMU workaround for invalid single-letter 's' & 'u'. - Updates for riscv_fill_hwcap_from_ext_list(): - Drop initilizer of cpuid inside dt_for_each_child_node() {...}. - Introduce res and return it instead of -EINVAL. - Drop `else` and change printk("riscv,isa-extensions isnt supported\n") to panic("riscv,isa-extensions isnt supported\n"). - Drop ( cpuid >= NR_CPUS ) check as cpuid technically could be any number. Only cpuid=0 is guaranteed to be. - Updates for riscv_fill_hwcap_from_isa_string(): - move cpuid and isa variables to dt_for_each_child_node() {...}. - Drop initilizer of cpuid inside dt_for_each_child_node() {...}. - Drop ( cpuid >= NR_CPUS ) check as cpuid technically could be any number. Only cpuid=0 is guaranteed to be. - Add ASSERT() to be sure that `this_isa` isn't null to prevent ending up with extensions not supported by one of the CPUs. - Updates for riscv_isa_extension_available(): - Code style fixes. - Drop conditional operator used in return as functions returns bool. - s/extenstion/extensions, s/extenstion/extenstion. - Drop RISCV_ISA_EXT_SxAIA as it isn't used. - Move definitions of RISCV_ISA_EXT_{a,c,d,...,v} to enum riscv_isa_ext_id. - Move macros RISCV_ISA_EXT_MAX to enum riscv_isa_ext_id. - Update the comment above definition of RISCV_ISA_EXT_BASE. - Fix code style ( violation of line length ) for riscv_isa_extension_available(). - Sync commit message with the comment on the start of cpufeature.c --- xen/arch/riscv/Makefile | 1 + xen/arch/riscv/cpufeature.c | 504 ++++++++++++++++++++++++ xen/arch/riscv/include/asm/cpufeature.h | 59 +++ xen/arch/riscv/setup.c | 3 + 4 files changed, 567 insertions(+) create mode 100644 xen/arch/riscv/cpufeature.c create mode 100644 xen/arch/riscv/include/asm/cpufeature.h diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile index a5eb2aed4b..b0c8270a99 100644 --- a/xen/arch/riscv/Makefile +++ b/xen/arch/riscv/Makefile @@ -1,3 +1,4 @@ +obj-y += cpufeature.o obj-$(CONFIG_EARLY_PRINTK) += early_printk.o obj-y += entry.o obj-y += mm.o diff --git a/xen/arch/riscv/cpufeature.c b/xen/arch/riscv/cpufeature.c new file mode 100644 index 0000000000..bf09aa1170 --- /dev/null +++ b/xen/arch/riscv/cpufeature.c @@ -0,0 +1,504 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * Originally taken for Linux kernel v6.12-rc3. + * + * Copyright (C) 2015 ARM Ltd. + * Copyright (C) 2017 SiFive + * Copyright (C) 2024 Vates + */ + +#include +#include +#include +#include +#include +#include +#include + +#include + +#ifdef CONFIG_ACPI +# error "cpufeature.c functions should be updated to support ACPI" +#endif + +struct riscv_isa_ext_data { + unsigned int id; + const char *name; +}; + +#define RISCV_ISA_EXT_DATA(ext_name) \ +{ \ + .id = RISCV_ISA_EXT_ ## ext_name, \ + .name = #ext_name, \ +} + +/* Host ISA bitmap */ +static __ro_after_init DECLARE_BITMAP(riscv_isa, RISCV_ISA_EXT_MAX); + +static int __init dt_get_cpuid_from_node(const struct dt_device_node *cpu, + unsigned long *dt_cpuid) +{ + const __be32 *prop; + unsigned int reg_len; + + /* + * For debug purpose check dt_n_size_cells(cpu) value. + * + * Based on DT's bindings [1] and RISC-V's DTS files in kernel #size-cells + * for cpu node is expected to be 0. + * + * [1] https://www.kernel.org/doc/Documentation/devicetree/bindings/riscv/cpus.txt + */ + if ( dt_n_size_cells(cpu) != 0 ) + printk("DT's cpu node `%s`: #size-cells %d\n", + dt_node_full_name(cpu), dt_n_size_cells(cpu)); + + prop = dt_get_property(cpu, "reg", ®_len); + if ( !prop ) + { + printk("cpu node `%s`: has no reg property\n", dt_node_full_name(cpu)); + return -EINVAL; + } + + if ( reg_len < dt_cells_to_size(dt_n_addr_cells(cpu)) ) + { + printk("cpu node `%s`: reg property too short\n", + dt_node_full_name(cpu)); + return -EINVAL; + } + + /* + * It is safe to convert `paddr_t` to `unsigned long` as dt_read_paddr() + * in the context of this function returns cpuid which according to RISC-V + * specification could be from 0 to ((1ULL << (MXLEN)) - 1), where + * MXLEN=32 for RV32 and MXLEN=64 for RV64. + */ + *dt_cpuid = dt_read_paddr(prop, dt_n_addr_cells(cpu)); + + return 0; +} + +/* + * The canonical order of ISA extension names in the ISA string is defined in + * chapter 27 of the unprivileged specification. + * + * The specification uses vague wording, such as should, when it comes to + * ordering, so for our purposes the following rules apply: + * + * 1. All multi-letter extensions must be separated from other extensions by an + * underscore. + * + * 2. Additional standard extensions (starting with 'Z') must be sorted after + * single-letter extensions and before any higher-privileged extensions. + * + * 3. The first letter following the 'Z' conventionally indicates the most + * closely related alphabetical extension category, IMAFDQLCBKJTPVH. + * If multiple 'Z' extensions are named, they must be ordered first by + * category, then alphabetically within a category. + * + * 4. Standard supervisor-level extensions (starting with 'S') must be listed + * after standard unprivileged extensions. If multiple supervisor-level + * extensions are listed, they must be ordered alphabetically. + * + * 5. Standard machine-level extensions (starting with 'Zxm') must be listed + * after any lower-privileged, standard extensions. If multiple + * machine-level extensions are listed, they must be ordered + * alphabetically. + * + * 6. Non-standard extensions (starting with 'X') must be listed after all + * standard extensions. If multiple non-standard extensions are listed, they + * must be ordered alphabetically. + * + * An example string following the order is: + * rv64imadc_zifoo_zigoo_zafoo_sbar_scar_zxmbaz_xqux_xrux + * + * New entries to this struct should follow the ordering rules described above. + * + * Extension name must be all lowercase (according to device-tree binding) + * and strncmp() is used in match_isa_ext() to compare extension names instead + * of strncasecmp(). + */ +const struct riscv_isa_ext_data __initconst riscv_isa_ext[] = { + RISCV_ISA_EXT_DATA(i), + RISCV_ISA_EXT_DATA(m), + RISCV_ISA_EXT_DATA(a), + RISCV_ISA_EXT_DATA(f), + RISCV_ISA_EXT_DATA(d), + RISCV_ISA_EXT_DATA(q), + RISCV_ISA_EXT_DATA(c), + RISCV_ISA_EXT_DATA(h), + RISCV_ISA_EXT_DATA(zicntr), + RISCV_ISA_EXT_DATA(zicsr), + RISCV_ISA_EXT_DATA(zifencei), + RISCV_ISA_EXT_DATA(zihintpause), + RISCV_ISA_EXT_DATA(zihpm), + RISCV_ISA_EXT_DATA(zba), + RISCV_ISA_EXT_DATA(zbb), + RISCV_ISA_EXT_DATA(zbs), + RISCV_ISA_EXT_DATA(smaia), + RISCV_ISA_EXT_DATA(ssaia), +}; + +static const struct riscv_isa_ext_data __initconst required_extensions[] = { + RISCV_ISA_EXT_DATA(i), + RISCV_ISA_EXT_DATA(m), + RISCV_ISA_EXT_DATA(a), +#ifdef CONFIG_RISCV_ISA_C + RISCV_ISA_EXT_DATA(c), +#endif + RISCV_ISA_EXT_DATA(zicsr), + RISCV_ISA_EXT_DATA(zifencei), + RISCV_ISA_EXT_DATA(zihintpause), + RISCV_ISA_EXT_DATA(zbb), +}; + +static bool __init is_lowercase_extension_name(const char *str) +{ + /* + * `str` could contain full riscv,isa string from device tree so one + * of the stop conditions is checking for '_' as extensions are + * separated by '_'. + */ + for ( unsigned int i = 0; (str[i] != '\0') && (str[i] != '_'); i++ ) + if ( !isdigit(str[i]) && !islower(str[i]) ) + return false; + + return true; +} + +static void __init match_isa_ext(const char *name, const char *name_end, + unsigned long *bitmap) +{ + const size_t riscv_isa_ext_count = ARRAY_SIZE(riscv_isa_ext); + + for ( unsigned int i = 0; i < riscv_isa_ext_count; i++ ) + { + const struct riscv_isa_ext_data *ext = &riscv_isa_ext[i]; + + /* + * `ext->name` (according to initialization of riscv_isa_ext[] + * elements) must be all in lowercase. + */ + ASSERT(is_lowercase_extension_name(ext->name)); + + if ( (name_end - name == strlen(ext->name)) && + !memcmp(name, ext->name, name_end - name) ) + { + __set_bit(ext->id, bitmap); + break; + } + } +} + +static int __init riscv_isa_parse_string(const char *isa, + unsigned long *out_bitmap) +{ + if ( (isa[0] != 'r') && (isa[1] != 'v') ) + return -EINVAL; + +#if defined(CONFIG_RISCV_32) + if ( isa[2] != '3' && isa[3] != '2' ) + return -EINVAL; +#elif defined(CONFIG_RISCV_64) + if ( isa[2] != '6' && isa[3] != '4' ) + return -EINVAL; +#else +# error "unsupported RISC-V bitness" +#endif + + /* + * In unpriv. specification (*_20240411) is mentioned the following: + * (1) A RISC-V ISA is defined as a base integer ISA, which must be + * present in any implementation, plus optional extensions to + * the base ISA. + * (2) Chapter 6 describes the RV32E and RV64E subset variants of + * the RV32I or RV64I base instruction sets respectively, which + * have been added to support small microcontrollers, and which + * have half the number of integer registers. + * + * What means that isa should contain, at least, I or E. + * + * As Xen isn't expected to be run on microcontrollers and according + * to device tree binding the first extension should be "i". + */ + if ( isa[4] != 'i' ) + return -EINVAL; + + isa += 4; + + while ( *isa ) + { + const char *ext = isa++; + const char *ext_end = isa; + + switch ( *ext ) + { + case 'x': + printk_once("Vendor extensions are ignored in riscv,isa\n"); + /* + * To skip an extension, we find its end. + * As multi-letter extensions must be split from other multi-letter + * extensions with an "_", the end of a multi-letter extension will + * either be the null character or the "_" at the start of the next + * multi-letter extension. + */ + for ( ; *isa && *isa != '_'; ++isa ) + if ( unlikely(!isalnum(*isa)) ) + goto riscv_isa_parse_string_err; + + ext_end = NULL; + break; + + case 's': + /* + * Workaround for invalid single-letter 's' & 'u' (QEMU): + * Before QEMU 7.1 it was an issue with misa to ISA string + * conversion: + * https://patchwork.kernel.org/project/qemu-devel/patch/dee09d708405075420b29115c1e9e87910b8da55.1648270894.git.research_trasio@irq.a4lg.com/#24792587 + * Additional details of the workaround on Linux kernel side: + * https://lore.kernel.org/linux-riscv/ae93358e-e117-b43d-faad-772c529f846c@irq.a4lg.com/#t + * + * No need to set the bit in riscv_isa as 's' & 'u' are + * not valid ISA extensions. It works unless the first + * multi-letter extension in the ISA string begins with + * "Su" and is not prefixed with an underscore. + */ + if ( ext[-1] != '_' && ext[1] == 'u' ) + { + ++isa; + ext_end = NULL; + break; + } + fallthrough; + case 'z': + /* + * Before attempting to parse the extension itself, we find its end. + * As multi-letter extensions must be split from other multi-letter + * extensions with an "_", the end of a multi-letter extension will + * either be the null character or the "_" at the start of the next + * multi-letter extension. + * + * Next, as the extensions version is currently ignored, we + * eliminate that portion. This is done by parsing backwards from + * the end of the extension, removing any numbers. This may be a + * major or minor number however, so the process is repeated if a + * minor number was found. + * + * ext_end is intended to represent the first character *after* the + * name portion of an extension, but will be decremented to the last + * character itself while eliminating the extensions version number. + * A simple re-increment solves this problem. + */ + for ( ; *isa && *isa != '_'; ++isa ) + if ( unlikely(!isalnum(*isa)) ) + goto riscv_isa_parse_string_err; + + ext_end = isa; + + if ( !isdigit(ext_end[-1]) ) + break; + + while ( isdigit(*--ext_end) ) + ; + + if ( ext_end[0] != 'p' || !isdigit(ext_end[-1]) ) + { + ++ext_end; + break; + } + + while ( isdigit(*--ext_end) ) + ; + + ++ext_end; + break; + + /* + * If someone mentioned `b` extension in riscv,isa instead of Zb{a,b,s} + * explicitly then set bits exlicitly in out_bitmap to satisfy + * requirement of Zbb (mentioned in required_extensions[]). + */ + case 'b': + __set_bit(RISCV_ISA_EXT_zba, out_bitmap); + __set_bit(RISCV_ISA_EXT_zbb, out_bitmap); + __set_bit(RISCV_ISA_EXT_zbs, out_bitmap); + fallthrough; + default: + /* + * Things are a little easier for single-letter extensions, as they + * are parsed forwards. + * + * After checking that our starting position is valid, we need to + * ensure that, when isa was incremented at the start of the loop, + * that it arrived at the start of the next extension. + * + * If we are already on a non-digit, there is nothing to do. Either + * we have a multi-letter extension's _, or the start of an + * extension. + * + * Otherwise we have found the current extension's major version + * number. Parse past it, and a subsequent p/minor version number + * if present. The `p` extension must not appear immediately after + * a number, so there is no fear of missing it. + */ + if ( unlikely(!isalpha(*ext)) ) + goto riscv_isa_parse_string_err; + + if ( !isdigit(*isa) ) + break; + + while ( isdigit(*++isa) ) + ; + + if ( *isa != 'p' ) + break; + + if ( !isdigit(*++isa) ) + { + --isa; + break; + } + + while ( isdigit(*++isa) ) + ; + + break; + } + + /* + * The parser expects that at the start of an iteration isa points to the + * first character of the next extension. As we stop parsing an extension + * on meeting a non-alphanumeric character, an extra increment is needed + * where the succeeding extension is a multi-letter prefixed with an "_". + */ + if ( *isa == '_' ) + ++isa; + + if ( unlikely(!ext_end) ) + continue; + + match_isa_ext(ext, ext_end, out_bitmap); + } + + return 0; + + riscv_isa_parse_string_err: + printk("illegal symbol '%c' in riscv,isa string\n", *isa); + return -EINVAL; +} + +static void __init riscv_fill_hwcap_from_isa_string(void) +{ + const struct dt_device_node *cpus = dt_find_node_by_path("/cpus"); + const struct dt_device_node *cpu; + + if ( !cpus ) + { + printk("Missing /cpus node in the device tree?\n"); + return; + } + + dt_for_each_child_node(cpus, cpu) + { + DECLARE_BITMAP(this_isa, RISCV_ISA_EXT_MAX); + const char *isa; + unsigned long cpuid; + + if ( !dt_device_type_is_equal(cpu, "cpu") ) + continue; + + if ( dt_get_cpuid_from_node(cpu, &cpuid) < 0 ) + continue; + + if ( dt_property_read_string(cpu, "riscv,isa", &isa) ) + { + printk("Unable to find \"riscv,isa\" devicetree entry " + "for DT's cpu%ld node\n", cpuid); + continue; + } + + for ( unsigned int i = 0; (isa[i] != '\0'); i++ ) + if ( !isdigit(isa[i]) && (isa[i] != '_') && !islower(isa[i]) ) + panic("According to DT binding riscv,isa must be lowercase\n"); + + if ( riscv_isa_parse_string(isa, this_isa) ) + panic("Check riscv,isa in dts file\n"); + + if ( bitmap_empty(riscv_isa, RISCV_ISA_EXT_MAX) ) + bitmap_copy(riscv_isa, this_isa, RISCV_ISA_EXT_MAX); + else + bitmap_and(riscv_isa, riscv_isa, this_isa, RISCV_ISA_EXT_MAX); + } +} + +static bool __init has_isa_extensions_property(void) +{ + const struct dt_device_node *cpus = dt_find_node_by_path("/cpus"); + const struct dt_device_node *cpu; + + if ( !cpus ) + { + printk("Missing /cpus node in the device tree?\n"); + return false; + } + + dt_for_each_child_node(cpus, cpu) + { + const char *isa; + + if ( !dt_device_type_is_equal(cpu, "cpu") ) + continue; + + if ( dt_property_read_string(cpu, "riscv,isa-extensions", &isa) ) + continue; + + return true; + } + + return false; +} + +bool riscv_isa_extension_available(const unsigned long *isa_bitmap, + enum riscv_isa_ext_id id) +{ + if ( !isa_bitmap ) + isa_bitmap = riscv_isa; + + if ( id >= RISCV_ISA_EXT_MAX ) + return false; + + return test_bit(id, isa_bitmap); +} + +void __init riscv_fill_hwcap(void) +{ + unsigned int i; + const size_t req_extns_amount = ARRAY_SIZE(required_extensions); + bool all_extns_available = true; + + riscv_fill_hwcap_from_isa_string(); + + if ( bitmap_empty(riscv_isa, RISCV_ISA_EXT_MAX) ) + { + const char *failure_msg = has_isa_extensions_property() ? + "\"riscv,isa-extension\" isn't supported" : + "\"riscv,isa\" parsing failed"; + + panic("HW capabilities parsing failed: %s\n", failure_msg); + } + + for ( i = 0; i < req_extns_amount; i++ ) + { + const struct riscv_isa_ext_data ext = required_extensions[i]; + + if ( !riscv_isa_extension_available(NULL, ext.id) ) + { + printk("Xen requires extension: %s\n", ext.name); + all_extns_available = false; + } + } + + if ( !all_extns_available ) + panic("Look why the extensions above are needed in " + "https://xenbits.xenproject.org/docs/unstable/misc/riscv/booting.txt\n"); +} diff --git a/xen/arch/riscv/include/asm/cpufeature.h b/xen/arch/riscv/include/asm/cpufeature.h new file mode 100644 index 0000000000..1015b6ee44 --- /dev/null +++ b/xen/arch/riscv/include/asm/cpufeature.h @@ -0,0 +1,59 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef ASM__RISCV__CPUFEATURE_H +#define ASM__RISCV__CPUFEATURE_H + +#ifndef __ASSEMBLY__ + +#include + +/* + * These macros represent the logical IDs of each multi-letter RISC-V ISA + * extension and are used in the ISA bitmap. The logical IDs start from + * RISCV_ISA_EXT_BASE, which allows the 0-25 range to be reserved for single + * letter extensions and are used in enum riscv_isa_ext_id. + * + * New extensions should just be added to the bottom, rather than added + * alphabetically, in order to avoid unnecessary shuffling. + */ +#define RISCV_ISA_EXT_BASE 26 + +enum riscv_isa_ext_id { + RISCV_ISA_EXT_a, + RISCV_ISA_EXT_c, + RISCV_ISA_EXT_d, + RISCV_ISA_EXT_f, + RISCV_ISA_EXT_h, + RISCV_ISA_EXT_i, + RISCV_ISA_EXT_m, + RISCV_ISA_EXT_q, + RISCV_ISA_EXT_v, + RISCV_ISA_EXT_zicntr = RISCV_ISA_EXT_BASE, + RISCV_ISA_EXT_zicsr, + RISCV_ISA_EXT_zifencei, + RISCV_ISA_EXT_zihintpause, + RISCV_ISA_EXT_zihpm, + RISCV_ISA_EXT_zba, + RISCV_ISA_EXT_zbb, + RISCV_ISA_EXT_zbs, + RISCV_ISA_EXT_smaia, + RISCV_ISA_EXT_ssaia, + RISCV_ISA_EXT_MAX +}; + +void riscv_fill_hwcap(void); + +bool riscv_isa_extension_available(const unsigned long *isa_bitmap, + enum riscv_isa_ext_id id); + +#endif /* __ASSEMBLY__ */ + +#endif /* ASM__RISCV__CPUFEATURE_H */ + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c index f2b6e684ac..b0e587678e 100644 --- a/xen/arch/riscv/setup.c +++ b/xen/arch/riscv/setup.c @@ -13,6 +13,7 @@ #include +#include #include #include #include @@ -123,6 +124,8 @@ void __init noreturn start_xen(unsigned long bootcpu_id, panic("Booting using ACPI isn't supported\n"); } + riscv_fill_hwcap(); + printk("All set up\n"); machine_halt(); From patchwork Fri Feb 21 17:02:45 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksii Kurochko X-Patchwork-Id: 13986054 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9BC64C021B5 for ; Fri, 21 Feb 2025 17:03:27 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.894529.1303232 (Exim 4.92) (envelope-from ) id 1tlWQR-0007VX-1f; Fri, 21 Feb 2025 17:02:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 894529.1303232; Fri, 21 Feb 2025 17:02:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tlWQQ-0007VQ-Ux; Fri, 21 Feb 2025 17:02:54 +0000 Received: by outflank-mailman (input) for mailman id 894529; Fri, 21 Feb 2025 17:02:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tlWQQ-0007VK-A8 for xen-devel@lists.xenproject.org; Fri, 21 Feb 2025 17:02:54 +0000 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [2a00:1450:4864:20::136]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b062ef2a-f075-11ef-9aa9-95dc52dad729; Fri, 21 Feb 2025 18:02:53 +0100 (CET) Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-54527a7270eso2349397e87.0 for ; Fri, 21 Feb 2025 09:02:53 -0800 (PST) Received: from fedora.. ([94.75.70.14]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5462cb28b60sm1005199e87.153.2025.02.21.09.02.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Feb 2025 09:02:50 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b062ef2a-f075-11ef-9aa9-95dc52dad729 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740157372; x=1740762172; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oSCir598LGNdv+E28EDZq8itwovdKCQa3YLBf5vzXcY=; b=hCUsRjMenYzyVtzdvE4pkcRrYEbCu6B/VkoXHPNwHTz3vw/FifjTfgb5IxCt6sQHed teUutptU6dxzMgpP1qkPjdwuNhgH7XvT0DA3CAvjVuve3IR7NZj0go+Q6+Gy+su0UGGo S90TydwaGL4/j/aJQWbaSAkaNe5TcznL2eehGhsENVk6V1hO2C0/9GWAQMAFdzb0/xq+ cTaM192cn7sOciBayxh7BkUMk48u8Cyndn/2+TPgq2GQAw+qVuXnjmJXTsbdO9qMZmSk 9ce6ELTnf1+J928qeRV1zi0WI5XdGXm7QfSOdYZoNkPreU9ojy0QLZLJov2h7MoBFrjd y0wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740157372; x=1740762172; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oSCir598LGNdv+E28EDZq8itwovdKCQa3YLBf5vzXcY=; b=XaLpD4xiatHTthmgSa0XIcATXCC4+NZKFUZaOs0oT9e8qns3/MGsS6bTBg3UuPgjtX qjdnobTd79N977y0tWQFmk1Yv94n7FNrhrzSnCcgqLdABXGU8Ve+CxxKS/gavkxY61ox ak85A349D3DDM77GuHdV1HWPpMeTTicUhjxn8iuGEvV2W5TRF1NGfEKNqmsIMGz4DEFt H+ISjLo6l20Y7TisDGlXAYt/ArmAngaHV1pLMuIg0tKvB/gm8biC1oqySFg8zNSTNte7 lnLSrshkwF6sF6wem0CAbLU6CLNRg0HssylyUkNf/yyO1GJA0WfdeK1OV5xlEhOTiwRl 232g== X-Gm-Message-State: AOJu0YxerqWUy5I1VPqN1zNBkQHqm35MHQ62Hr5XAVlDm0A+ftRO04WZ rZV6eJLq0qXjh6XfcSNMhOvqwc7Ks8EFA92dYgdy3CTfz/GoVoppGOZS3A== X-Gm-Gg: ASbGncs3R8F2FzFG4KhkTSAVj6hgONiigQSinMXNrrJzwg274mzWxxJSfsW0CgGwSCH P3PAfXyDSAJS4r13xVUam7lxjm1Xc5Sy9egaEAEqM6cGWLz4GoJhaYeG+XGIoDKcFTEfWfWGt0z QtpqDG9xIPVo6FGEoTo7r+foKw5N610QbNbCKi72pXwCxxCVOquv0kGIFeDDFbjx6qJ3F51OGmy kWs/6ALCAyzpMx4zNjXUtFsvvPKrnPYtMUc/MrtxqiRWHBDCyCmZFIYEPbIvgfyvrtCcMosuByJ hmnnCdTqqKUmyAykCgMqqvkrSMk= X-Google-Smtp-Source: AGHT+IFhTf+TBWWEItH+P3OS5HLn+E0qrL5/W1w2O2Y9k56+2KFRWsGXLVFb3pBQfjokrk9I8EL1rA== X-Received: by 2002:a05:6512:108c:b0:546:207c:1c59 with SMTP id 2adb3069b0e04-5483925982dmr1975899e87.34.1740157372091; Fri, 21 Feb 2025 09:02:52 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Oleksii Kurochko , Alistair Francis , Bob Eshleman , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?utf-8?q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini Subject: [PATCH for 4.21 v7 0.5/4] xen/README: add compiler and binutils versions for RISCV-64 Date: Fri, 21 Feb 2025 18:02:45 +0100 Message-ID: <5d71d27f7393753d549c73ab2e5639acc2260df8.1740071755.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: References: MIME-Version: 1.0 Set the baseline for the compiler and binutils to >=12.2 for GCC and >=2.39 for GNU binutils, as Xen's GitLab CI will use the Debian 12 container for RISCV-64 testing. Therefore, these versions are expected to be the minimum supported versions. Signed-off-by: Oleksii Kurochko --- README | 3 +++ 1 file changed, 3 insertions(+) diff --git a/README b/README index 373885523c..9e401be4ac 100644 --- a/README +++ b/README @@ -48,6 +48,9 @@ provided by your OS distributor: - For ARM 64-bit: - GCC 5.1 or later - GNU Binutils 2.24 or later + - For RISC-V 64-bit: + - GCC 12.2 or later + - GNU Binutils 2.39 or later * POSIX compatible awk * Development install of zlib (e.g., zlib-dev) * Development install of Python 2.7 or later (e.g., python-dev)