From patchwork Fri Feb 21 20:27:40 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tamir Duberstein X-Patchwork-Id: 13986253 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4079253358; Fri, 21 Feb 2025 20:27:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740169668; cv=none; b=pJqJ9nmgp4Xa+Y9ewHzXADkRNr/LW9mQfgiPQ91SNPB2zK2V5leY++oZqlLRUjnJwTsFCkPjDOTlt352lIH/QfoYe2frbrPRj87KTBlCiacLymFhc7Ev/dQ46dHk10purV8fojbKjzo3xwTojNQ4AB1UltroS0Pn/77MoP5ZuLg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740169668; c=relaxed/simple; bh=Utj1uL53bGcOISkDLGZ/dzP17TacBe++2ickX+Z4jao=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ATsrDMxW0getemXhIiqr49kvIkC0hyNNiGWL2yXqduil3a2fatIg14F6a/YIycadQtcFKJN3sk25iOcepBvb8840lwAPx6ZWUqK2Y4KPlkLAW2PyUxHY+8TMHrl/vBPuV5lTDKhbQPAaDAjoaZ/UivRDbNvcDFb1m4jWsLK+tCs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=L0MbRLjx; arc=none smtp.client-ip=209.85.160.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="L0MbRLjx" Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-471f88518c8so14685391cf.0; Fri, 21 Feb 2025 12:27:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740169665; x=1740774465; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=cOOcp/qgQEHGFEfqObW1wtWughu2PPbbcKKF2dJjXy4=; b=L0MbRLjxNFCTY7tjExvgwd8xzuTyHRSOkxH8/n5xyky7f11vT962n6lhfIhnVNG7WJ 9mk3Q3MmmJO7mX6ARsNS01uE2aGH/VDNt/JSfHdn8Oc9XVa+QOd3EbKRbL3ATeG7FHSM dcq9eLxnaPDETUPxxSCsKI9IjRqFjVE+eleiVJzKg7Ja27jgF5FByTBtpWc9LyzT7izB cIIV2Dd6H9DuvE/Fr1k7/VPlIz6AL6KW4DJi9V3VU/YYaNvP2d2aTyMisRpVKZQknBW+ ppXsZoZqYvh2eOkb1QtRW4VYQJpYRqPhOSEl6cchX+BoYQ56+RZKgTzO7AMrBTGF+xxY jBuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740169665; x=1740774465; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cOOcp/qgQEHGFEfqObW1wtWughu2PPbbcKKF2dJjXy4=; b=qj0H2Wgkv1Cte8RloW2pQ6eah4pbmUTPzoTKNJGZ6ACwDsRGbEXRFa7a+twLBON0e0 F7SILytHMzV9uu9NhBUJjgiStG/1jSgJXZ+diZvH+oQJr0iBkcYaiDgOJEa2D7ZwdrsW 8JQIs9Z6HvJ2SDUf7C/C22c4mWmnn25fyohoXWz4fAIXNrCnf74UE0aOd7qPeHpcUbuF mlAe5b7bzR1N7SCzflJerr2ok+YII+EAeTRABWOsUm5rF7joLUI5wNjBTrzf3j+TqoQi p2M0em5FJZPyDf6SE8MJtVPHyxt8c4OvhO4lxHruZHpc0MS6A8oNfg0T9nHOcawkBw7+ L23w== X-Forwarded-Encrypted: i=1; AJvYcCUMYDsHfY6M0NpDUoG3TloTvlECIKynagKcyTvBv3wgXr0SO2wLCpHo4txg5JjT4prGD5o8x9eIt3sHx0IDh3o=@vger.kernel.org, AJvYcCUiIm8jvJF8jDJLpJ+KySl0spPx9wbMZnSmNoDuFonRGVmLh7BVK/FmQ259SdI0b2mMoOupmrhNQfXvvNUF@vger.kernel.org, AJvYcCX8TSPNmMC/hxUXg22jyM1X/nFEcmIxpW3/ncPdjjXbxuvJStR8ZaSIgi5fjDmrCqShBCnRiDt8Pf+q3PpT@vger.kernel.org, AJvYcCXoA7kNnfuknlWgDBUw6SMg/tGKkQxpjkJnqbr55MrCTeV9XnnvzCtcKEV4cBh3w/aj7rRzuB6RuDZ3@vger.kernel.org X-Gm-Message-State: AOJu0YzUiQu9paGv8kBvptZV1ykwTgy2UYNr3ApiTIqBs28WgxBV2Knk I89J0UDQG8SjJxto/brGSpIG84TNmHDZ1p6rdvPIl7dCQZGCAZ+A X-Gm-Gg: ASbGncv9DKO+bICoCuh7iwf+cmvOxzhI/iODCXNh6LDKbP7NkW3wP/tNjltw6NGxyjk Ca8qh/cz1y5Q0vd1K3bTdSt1VVPujqqlTxrepvz7gm14AqKTBUH90eKUXtvoap+1Qlk8L/Hy5tw OrOmMWUfDpLBGCNS5mr4+3mt0bJuyFDPBe6+vdmGOR+V+frh6cRLQqiw28PnzdZLda6tY7uyxpX HMW/w4SBh5bmqxhp52ExulR0nTOwG1uEKQx8G07O4V4FIoaB3pqB34jDz68lIbEeIWbN9hLEAIx SvSI7UFHf/dhetDtjKVTM9alfI3mGnK970r0aBh/xf3eLC7VLg== X-Google-Smtp-Source: AGHT+IFJT1MCYvEC1pyF6PPIxsO1z6skF5DStTySr18N/0ko+53p6PSx7ER53iXMR9amFmjHfOkzLQ== X-Received: by 2002:a05:620a:2791:b0:7c0:6ab0:a25 with SMTP id af79cd13be357-7c0cef106f2mr578885885a.28.1740169665344; Fri, 21 Feb 2025 12:27:45 -0800 (PST) Received: from tamird-mac.local ([2600:4041:5be7:7c00:880f:47d4:56c6:b852]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c0a99d363csm539224985a.70.2025.02.21.12.27.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Feb 2025 12:27:44 -0800 (PST) From: Tamir Duberstein Date: Fri, 21 Feb 2025 15:27:40 -0500 Subject: [PATCH v18 1/3] rust: types: add `ForeignOwnable::PointedTo` Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250221-rust-xarray-bindings-v18-1-cbabe5ddfc32@gmail.com> References: <20250221-rust-xarray-bindings-v18-0-cbabe5ddfc32@gmail.com> In-Reply-To: <20250221-rust-xarray-bindings-v18-0-cbabe5ddfc32@gmail.com> To: Danilo Krummrich , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Matthew Wilcox , Bjorn Helgaas , Greg Kroah-Hartman , "Rafael J. Wysocki" , Tamir Duberstein , FUJITA Tomonori , "Rob Herring (Arm)" Cc: =?utf-8?q?Ma=C3=ADra_Canal?= , Asahi Lina , rust-for-linux@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org X-Mailer: b4 0.15-dev Allow implementors to specify the foreign pointer type; this exposes information about the pointed-to type such as its alignment. This requires the trait to be `unsafe` since it is now possible for implementors to break soundness by returning a misaligned pointer. Encoding the pointer type in the trait (and avoiding pointer casts) allows the compiler to check that implementors return the correct pointer type. This is preferable to directly encoding the alignment in the trait using a constant as the compiler would be unable to check it. Acked-by: Danilo Krummrich Signed-off-by: Tamir Duberstein --- rust/kernel/alloc/kbox.rs | 38 ++++++++++++++++++++------------------ rust/kernel/miscdevice.rs | 10 +++++----- rust/kernel/pci.rs | 2 +- rust/kernel/platform.rs | 2 +- rust/kernel/sync/arc.rs | 21 ++++++++++++--------- rust/kernel/types.rs | 46 +++++++++++++++++++++++++++++++--------------- 6 files changed, 70 insertions(+), 49 deletions(-) diff --git a/rust/kernel/alloc/kbox.rs b/rust/kernel/alloc/kbox.rs index cb4ebea3b074..55529832db54 100644 --- a/rust/kernel/alloc/kbox.rs +++ b/rust/kernel/alloc/kbox.rs @@ -349,68 +349,70 @@ fn try_init(init: impl Init, flags: Flags) -> Result } } -impl ForeignOwnable for Box +// SAFETY: The `into_foreign` function returns a pointer that is well-aligned. +unsafe impl ForeignOwnable for Box where A: Allocator, { + type PointedTo = T; type Borrowed<'a> = &'a T; type BorrowedMut<'a> = &'a mut T; - fn into_foreign(self) -> *mut crate::ffi::c_void { - Box::into_raw(self).cast() + fn into_foreign(self) -> *mut Self::PointedTo { + Box::into_raw(self) } - unsafe fn from_foreign(ptr: *mut crate::ffi::c_void) -> Self { + unsafe fn from_foreign(ptr: *mut Self::PointedTo) -> Self { // SAFETY: The safety requirements of this function ensure that `ptr` comes from a previous // call to `Self::into_foreign`. - unsafe { Box::from_raw(ptr.cast()) } + unsafe { Box::from_raw(ptr) } } - unsafe fn borrow<'a>(ptr: *mut crate::ffi::c_void) -> &'a T { + unsafe fn borrow<'a>(ptr: *mut Self::PointedTo) -> &'a T { // SAFETY: The safety requirements of this method ensure that the object remains alive and // immutable for the duration of 'a. - unsafe { &*ptr.cast() } + unsafe { &*ptr } } - unsafe fn borrow_mut<'a>(ptr: *mut crate::ffi::c_void) -> &'a mut T { - let ptr = ptr.cast(); + unsafe fn borrow_mut<'a>(ptr: *mut Self::PointedTo) -> &'a mut T { // SAFETY: The safety requirements of this method ensure that the pointer is valid and that // nothing else will access the value for the duration of 'a. unsafe { &mut *ptr } } } -impl ForeignOwnable for Pin> +// SAFETY: The `into_foreign` function returns a pointer that is well-aligned. +unsafe impl ForeignOwnable for Pin> where A: Allocator, { + type PointedTo = T; type Borrowed<'a> = Pin<&'a T>; type BorrowedMut<'a> = Pin<&'a mut T>; - fn into_foreign(self) -> *mut crate::ffi::c_void { + fn into_foreign(self) -> *mut Self::PointedTo { // SAFETY: We are still treating the box as pinned. - Box::into_raw(unsafe { Pin::into_inner_unchecked(self) }).cast() + Box::into_raw(unsafe { Pin::into_inner_unchecked(self) }) } - unsafe fn from_foreign(ptr: *mut crate::ffi::c_void) -> Self { + unsafe fn from_foreign(ptr: *mut Self::PointedTo) -> Self { // SAFETY: The safety requirements of this function ensure that `ptr` comes from a previous // call to `Self::into_foreign`. - unsafe { Pin::new_unchecked(Box::from_raw(ptr.cast())) } + unsafe { Pin::new_unchecked(Box::from_raw(ptr)) } } - unsafe fn borrow<'a>(ptr: *mut crate::ffi::c_void) -> Pin<&'a T> { + unsafe fn borrow<'a>(ptr: *mut Self::PointedTo) -> Pin<&'a T> { // SAFETY: The safety requirements for this function ensure that the object is still alive, // so it is safe to dereference the raw pointer. // The safety requirements of `from_foreign` also ensure that the object remains alive for // the lifetime of the returned value. - let r = unsafe { &*ptr.cast() }; + let r = unsafe { &*ptr }; // SAFETY: This pointer originates from a `Pin>`. unsafe { Pin::new_unchecked(r) } } - unsafe fn borrow_mut<'a>(ptr: *mut crate::ffi::c_void) -> Pin<&'a mut T> { - let ptr = ptr.cast(); + unsafe fn borrow_mut<'a>(ptr: *mut Self::PointedTo) -> Pin<&'a mut T> { // SAFETY: The safety requirements for this function ensure that the object is still alive, // so it is safe to dereference the raw pointer. // The safety requirements of `from_foreign` also ensure that the object remains alive for diff --git a/rust/kernel/miscdevice.rs b/rust/kernel/miscdevice.rs index e14433b2ab9d..463701adbfcd 100644 --- a/rust/kernel/miscdevice.rs +++ b/rust/kernel/miscdevice.rs @@ -231,7 +231,7 @@ impl VtableHelper { // fops_* methods in this file, which all correctly cast the private data to the new type. // // SAFETY: The open call of a file can access the private data. - unsafe { (*raw_file).private_data = ptr.into_foreign() }; + unsafe { (*raw_file).private_data = ptr.into_foreign().cast() }; 0 } @@ -245,7 +245,7 @@ impl VtableHelper { file: *mut bindings::file, ) -> c_int { // SAFETY: The release call of a file owns the private data. - let private = unsafe { (*file).private_data }; + let private = unsafe { (*file).private_data }.cast(); // SAFETY: The release call of a file owns the private data. let ptr = unsafe { ::from_foreign(private) }; @@ -266,7 +266,7 @@ impl VtableHelper { arg: c_ulong, ) -> c_long { // SAFETY: The ioctl call of a file can access the private data. - let private = unsafe { (*file).private_data }; + let private = unsafe { (*file).private_data }.cast(); // SAFETY: Ioctl calls can borrow the private data of the file. let device = unsafe { ::borrow(private) }; @@ -291,7 +291,7 @@ impl VtableHelper { arg: c_ulong, ) -> c_long { // SAFETY: The compat ioctl call of a file can access the private data. - let private = unsafe { (*file).private_data }; + let private = unsafe { (*file).private_data }.cast(); // SAFETY: Ioctl calls can borrow the private data of the file. let device = unsafe { ::borrow(private) }; @@ -315,7 +315,7 @@ impl VtableHelper { file: *mut bindings::file, ) { // SAFETY: The release call of a file owns the private data. - let private = unsafe { (*file).private_data }; + let private = unsafe { (*file).private_data }.cast(); // SAFETY: Ioctl calls can borrow the private data of the file. let device = unsafe { ::borrow(private) }; // SAFETY: diff --git a/rust/kernel/pci.rs b/rust/kernel/pci.rs index 4c98b5b9aa1e..e33e3373b84e 100644 --- a/rust/kernel/pci.rs +++ b/rust/kernel/pci.rs @@ -86,7 +86,7 @@ extern "C" fn probe_callback( extern "C" fn remove_callback(pdev: *mut bindings::pci_dev) { // SAFETY: The PCI bus only ever calls the remove callback with a valid pointer to a // `struct pci_dev`. - let ptr = unsafe { bindings::pci_get_drvdata(pdev) }; + let ptr = unsafe { bindings::pci_get_drvdata(pdev) }.cast(); // SAFETY: `remove_callback` is only ever called after a successful call to // `probe_callback`, hence it's guaranteed that `ptr` points to a valid and initialized diff --git a/rust/kernel/platform.rs b/rust/kernel/platform.rs index 50e6b0421813..a956a39035b4 100644 --- a/rust/kernel/platform.rs +++ b/rust/kernel/platform.rs @@ -76,7 +76,7 @@ extern "C" fn probe_callback(pdev: *mut bindings::platform_device) -> kernel::ff extern "C" fn remove_callback(pdev: *mut bindings::platform_device) { // SAFETY: `pdev` is a valid pointer to a `struct platform_device`. - let ptr = unsafe { bindings::platform_get_drvdata(pdev) }; + let ptr = unsafe { bindings::platform_get_drvdata(pdev) }.cast(); // SAFETY: `remove_callback` is only ever called after a successful call to // `probe_callback`, hence it's guaranteed that `ptr` points to a valid and initialized diff --git a/rust/kernel/sync/arc.rs b/rust/kernel/sync/arc.rs index 3cefda7a4372..dfe4abf82c25 100644 --- a/rust/kernel/sync/arc.rs +++ b/rust/kernel/sync/arc.rs @@ -140,9 +140,10 @@ pub struct Arc { _p: PhantomData>, } +#[doc(hidden)] #[pin_data] #[repr(C)] -struct ArcInner { +pub struct ArcInner { refcount: Opaque, data: T, } @@ -342,18 +343,20 @@ pub fn into_unique_or_drop(self) -> Option>> { } } -impl ForeignOwnable for Arc { +// SAFETY: The `into_foreign` function returns a pointer that is well-aligned. +unsafe impl ForeignOwnable for Arc { + type PointedTo = ArcInner; type Borrowed<'a> = ArcBorrow<'a, T>; type BorrowedMut<'a> = Self::Borrowed<'a>; - fn into_foreign(self) -> *mut crate::ffi::c_void { - ManuallyDrop::new(self).ptr.as_ptr().cast() + fn into_foreign(self) -> *mut Self::PointedTo { + ManuallyDrop::new(self).ptr.as_ptr() } - unsafe fn from_foreign(ptr: *mut crate::ffi::c_void) -> Self { + unsafe fn from_foreign(ptr: *mut Self::PointedTo) -> Self { // SAFETY: The safety requirements of this function ensure that `ptr` comes from a previous // call to `Self::into_foreign`. - let inner = unsafe { NonNull::new_unchecked(ptr.cast::>()) }; + let inner = unsafe { NonNull::new_unchecked(ptr) }; // SAFETY: By the safety requirement of this function, we know that `ptr` came from // a previous call to `Arc::into_foreign`, which guarantees that `ptr` is valid and @@ -361,17 +364,17 @@ unsafe fn from_foreign(ptr: *mut crate::ffi::c_void) -> Self { unsafe { Self::from_inner(inner) } } - unsafe fn borrow<'a>(ptr: *mut crate::ffi::c_void) -> ArcBorrow<'a, T> { + unsafe fn borrow<'a>(ptr: *mut Self::PointedTo) -> ArcBorrow<'a, T> { // SAFETY: The safety requirements of this function ensure that `ptr` comes from a previous // call to `Self::into_foreign`. - let inner = unsafe { NonNull::new_unchecked(ptr.cast::>()) }; + let inner = unsafe { NonNull::new_unchecked(ptr) }; // SAFETY: The safety requirements of `from_foreign` ensure that the object remains alive // for the lifetime of the returned value. unsafe { ArcBorrow::new(inner) } } - unsafe fn borrow_mut<'a>(ptr: *mut crate::ffi::c_void) -> ArcBorrow<'a, T> { + unsafe fn borrow_mut<'a>(ptr: *mut Self::PointedTo) -> ArcBorrow<'a, T> { // SAFETY: The safety requirements for `borrow_mut` are a superset of the safety // requirements for `borrow`. unsafe { Self::borrow(ptr) } diff --git a/rust/kernel/types.rs b/rust/kernel/types.rs index 2bbaab83b9d6..55ddd50e8aaa 100644 --- a/rust/kernel/types.rs +++ b/rust/kernel/types.rs @@ -18,7 +18,19 @@ /// /// This trait is meant to be used in cases when Rust objects are stored in C objects and /// eventually "freed" back to Rust. -pub trait ForeignOwnable: Sized { +/// +/// # Safety +/// +/// Implementers must ensure that [`into_foreign`] returns a pointer which meets the alignment +/// requirements of [`PointedTo`]. +/// +/// [`into_foreign`]: Self::into_foreign +/// [`PointedTo`]: Self::PointedTo +pub unsafe trait ForeignOwnable: Sized { + /// Type used when the value is foreign-owned. In practical terms only defines the alignment of + /// the pointer. + type PointedTo; + /// Type used to immutably borrow a value that is currently foreign-owned. type Borrowed<'a>; @@ -27,16 +39,18 @@ pub trait ForeignOwnable: Sized { /// Converts a Rust-owned object to a foreign-owned one. /// - /// The foreign representation is a pointer to void. There are no guarantees for this pointer. - /// For example, it might be invalid, dangling or pointing to uninitialized memory. Using it in - /// any way except for [`from_foreign`], [`try_from_foreign`], [`borrow`], or [`borrow_mut`] can - /// result in undefined behavior. + /// # Guarantees + /// + /// The return value is guaranteed to be well-aligned, but there are no other guarantees for + /// this pointer. For example, it might be null, dangling, or point to uninitialized memory. + /// Using it in any way except for [`ForeignOwnable::from_foreign`], [`ForeignOwnable::borrow`], + /// [`ForeignOwnable::try_from_foreign`] can result in undefined behavior. /// /// [`from_foreign`]: Self::from_foreign /// [`try_from_foreign`]: Self::try_from_foreign /// [`borrow`]: Self::borrow /// [`borrow_mut`]: Self::borrow_mut - fn into_foreign(self) -> *mut crate::ffi::c_void; + fn into_foreign(self) -> *mut Self::PointedTo; /// Converts a foreign-owned object back to a Rust-owned one. /// @@ -46,7 +60,7 @@ pub trait ForeignOwnable: Sized { /// must not be passed to `from_foreign` more than once. /// /// [`into_foreign`]: Self::into_foreign - unsafe fn from_foreign(ptr: *mut crate::ffi::c_void) -> Self; + unsafe fn from_foreign(ptr: *mut Self::PointedTo) -> Self; /// Tries to convert a foreign-owned object back to a Rust-owned one. /// @@ -58,7 +72,7 @@ pub trait ForeignOwnable: Sized { /// `ptr` must either be null or satisfy the safety requirements for [`from_foreign`]. /// /// [`from_foreign`]: Self::from_foreign - unsafe fn try_from_foreign(ptr: *mut crate::ffi::c_void) -> Option { + unsafe fn try_from_foreign(ptr: *mut Self::PointedTo) -> Option { if ptr.is_null() { None } else { @@ -81,7 +95,7 @@ unsafe fn try_from_foreign(ptr: *mut crate::ffi::c_void) -> Option { /// /// [`into_foreign`]: Self::into_foreign /// [`from_foreign`]: Self::from_foreign - unsafe fn borrow<'a>(ptr: *mut crate::ffi::c_void) -> Self::Borrowed<'a>; + unsafe fn borrow<'a>(ptr: *mut Self::PointedTo) -> Self::Borrowed<'a>; /// Borrows a foreign-owned object mutably. /// @@ -109,21 +123,23 @@ unsafe fn try_from_foreign(ptr: *mut crate::ffi::c_void) -> Option { /// [`from_foreign`]: Self::from_foreign /// [`borrow`]: Self::borrow /// [`Arc`]: crate::sync::Arc - unsafe fn borrow_mut<'a>(ptr: *mut crate::ffi::c_void) -> Self::BorrowedMut<'a>; + unsafe fn borrow_mut<'a>(ptr: *mut Self::PointedTo) -> Self::BorrowedMut<'a>; } -impl ForeignOwnable for () { +// SAFETY: The `into_foreign` function returns a pointer that is dangling, but well-aligned. +unsafe impl ForeignOwnable for () { + type PointedTo = (); type Borrowed<'a> = (); type BorrowedMut<'a> = (); - fn into_foreign(self) -> *mut crate::ffi::c_void { + fn into_foreign(self) -> *mut Self::PointedTo { core::ptr::NonNull::dangling().as_ptr() } - unsafe fn from_foreign(_: *mut crate::ffi::c_void) -> Self {} + unsafe fn from_foreign(_: *mut Self::PointedTo) -> Self {} - unsafe fn borrow<'a>(_: *mut crate::ffi::c_void) -> Self::Borrowed<'a> {} - unsafe fn borrow_mut<'a>(_: *mut crate::ffi::c_void) -> Self::BorrowedMut<'a> {} + unsafe fn borrow<'a>(_: *mut Self::PointedTo) -> Self::Borrowed<'a> {} + unsafe fn borrow_mut<'a>(_: *mut Self::PointedTo) -> Self::BorrowedMut<'a> {} } /// Runs a cleanup function/closure when dropped. From patchwork Fri Feb 21 20:27:41 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tamir Duberstein X-Patchwork-Id: 13986254 Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDF90253F0D; Fri, 21 Feb 2025 20:27:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740169671; cv=none; b=nvkdCkj1PYrLHut0Y/Sbv56zd3tjW/nPe10WfrXQRzLsmZeopbQEgGoISRZ/r3GZrdEQ35wky0T1LaxoxTW8xngsUDHxqUC/GuJs9RjlWlf4UBOvtzRoKyDgblXMZAYRYHb6GTai5627Yj50mTMVbIOZp33YbRVjvmwdmKFPang= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740169671; c=relaxed/simple; bh=79VkQRszeTKai8h1oQJKIFbB9SETkGd3FPdSPispFCs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ik+o3ht+4thyAmlk6b13tSiHY+rsSVf/5ZT7YMVcoLqDneeHwXP2b5g8mG+Q2aiYJSHbyTqWazfD5N8PjgKqaZ6+xhXOFwK9HDA/d9Q6LcfrFuGRsQ1WwUb4XM6bPR+wDK5mTNv1Bs9ilnFGzTqBr5xbhZaSpdu5D6qWI0AQ4iI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=R88BDILB; arc=none smtp.client-ip=209.85.222.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="R88BDILB" Received: by mail-qk1-f175.google.com with SMTP id af79cd13be357-7be8f28172dso175168085a.3; Fri, 21 Feb 2025 12:27:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740169668; x=1740774468; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=XFXvKkJUD37pdr/9jEL9ZkBZwOEHfbsPm8qU02bWGDg=; b=R88BDILBDw+41+FFWY32YP+KsbCgfBcDzkat+ljSpHRQzTdOkV5EOEOA4/FgoV3Yvs 1W/3tMPy3omK4IZkO0flUhjjNuaduZ2Os9M3wCwJbQY4mfk/JTypiKLJGmWpispoQfQm nzyqZ4Dmhowvfy8HlZy70oPcdUKkqimAsV49YSM3FalUysNXFPY06Xcd/G/3Z4x0dWK6 2K3EBC7IvbcNdqTmv1satDALr4zOLYKRB3OH5T5ecKxb+gnqek/mQucXw/bmtkXXA8l7 D4UvQgUhVwcSHTHAbMBqwgw4alt5EEdqrmlSZOfgiBwl1OpCg4bbwKJHh+84oogWxf+W eoiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740169668; x=1740774468; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XFXvKkJUD37pdr/9jEL9ZkBZwOEHfbsPm8qU02bWGDg=; b=fqS/x4NFenYUUUdUXTzzXdvhL25sdrEsrCLRko5FOO35Ia4uBPgrNzuUNFx2hTqd6T tMu3Jo0VXeK+En5x7K1fz6zVzQm24sL0mkK9TxoA2cAXmj93gb6UfRk8luMd02xZi8tX /q1n9nDv58EwvSwi76URRsy/MivTxjhg0PMvMvpkv3UKc5kmBhm4fNtHggccHJ10n6Is +XXwbO4wcs+hfC5XcTJa6xddaR4oFh7C8vJTyIdNSp+3hFGCvD/2EtPYeJF/fVZ7Eer8 v1cAyWZMBEwAYfORMpz+yqW5Pee8Tzq2nCmaLbcLqaK7Npq508ImDAMjOoHlEkuRey33 A0uQ== X-Forwarded-Encrypted: i=1; AJvYcCUBkTlzEsTN4AgRf1fXcNKU6SLe2Zhjt/r/qNajY2G0Tdr7rR13Le6sFjLVfRjR5ptWtLXkj9UKtKlY/PCGcyc=@vger.kernel.org, AJvYcCWi6FNGfVcRYrgxCs/S/53tR3nDzgZK8astfu0e6rdVCAMGfp5luycDxJ5lmbFBYsH1IH5cYLJKxw9lrP3E@vger.kernel.org, AJvYcCXSWMw3OurbwPAhLTYmCVqo/O4p5Gp9diqF/fvR9Z7d7D9F3Yb0cj0/crg6PiQDpVuZMdK17XwOFFVN@vger.kernel.org, AJvYcCXeKTXw5Zg1tW4AtvpuTKUG/0csWvsHf3HIBx9gFEtuXY5KH3RwMzKuBGzb+eA3Jit24cjV6yqCU9ObDqXQ@vger.kernel.org X-Gm-Message-State: AOJu0Yx2kZbx43IR7cp7/AlqYGrMM+/SLz0Bs1vUL5rb7ISWhgJ4FnAW Xb0O8S9JrGK5VzrjryVatDTyQrVvet3P/TiguPUuUlnJvnkIIaft X-Gm-Gg: ASbGncsQe0Ek7JRt77NJu7CfvSvhiEe5AIPHrbzyf5ERgzgyM+apqfVdDhBuiNv+8py QQXwHS37BDqrxgVlTcLwtIHB6TUevVyUFanlIipKmahZesgWa0Xb+Za/E5pSIH3ffBOzxNE6pfp 7lfE1qCh4lOJu+V2/4Y/0kgGxed3KnzIigo3bSzq8SUer1a2TPcPciRBINbxAIILINd0ImDU0I+ djbzaXhQG29VlEhIv90DNmo3NLoaIrsYoMn4uIbKhimz1KOkFg+5V64hn+bDG+HiNfsW0vCn/uO 2RiwYZPELGsgVdMSGdzIdqFvLOj8/N3dHYxnu7QPD+ZUtQwWWA== X-Google-Smtp-Source: AGHT+IGG40wmJBIe3UfeV3nvKhEypy7SjBjMM7cZnhd8thtWl2fJLRx4zMaodX5KMlEP/uRKGtAM3Q== X-Received: by 2002:a05:620a:2801:b0:7c0:b3cd:9bc7 with SMTP id af79cd13be357-7c0ceeeae37mr692165785a.3.1740169667560; Fri, 21 Feb 2025 12:27:47 -0800 (PST) Received: from tamird-mac.local ([2600:4041:5be7:7c00:880f:47d4:56c6:b852]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c0a99d363csm539224985a.70.2025.02.21.12.27.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Feb 2025 12:27:47 -0800 (PST) From: Tamir Duberstein Date: Fri, 21 Feb 2025 15:27:41 -0500 Subject: [PATCH v18 2/3] rust: xarray: Add an abstraction for XArray Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250221-rust-xarray-bindings-v18-2-cbabe5ddfc32@gmail.com> References: <20250221-rust-xarray-bindings-v18-0-cbabe5ddfc32@gmail.com> In-Reply-To: <20250221-rust-xarray-bindings-v18-0-cbabe5ddfc32@gmail.com> To: Danilo Krummrich , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Matthew Wilcox , Bjorn Helgaas , Greg Kroah-Hartman , "Rafael J. Wysocki" , Tamir Duberstein , FUJITA Tomonori , "Rob Herring (Arm)" Cc: =?utf-8?q?Ma=C3=ADra_Canal?= , Asahi Lina , rust-for-linux@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org X-Mailer: b4 0.15-dev `XArray` is an efficient sparse array of pointers. Add a Rust abstraction for this type. This implementation bounds the element type on `ForeignOwnable` and requires explicit locking for all operations. Future work may leverage RCU to enable lockless operation. Inspired-by: Maíra Canal Inspired-by: Asahi Lina Reviewed-by: Andreas Hindborg Reviewed-by: Alice Ryhl Signed-off-by: Tamir Duberstein --- rust/bindings/bindings_helper.h | 6 + rust/helpers/helpers.c | 1 + rust/helpers/xarray.c | 28 ++++ rust/kernel/lib.rs | 1 + rust/kernel/xarray.rs | 277 ++++++++++++++++++++++++++++++++++++++++ 5 files changed, 313 insertions(+) diff --git a/rust/bindings/bindings_helper.h b/rust/bindings/bindings_helper.h index f46cf3bb7069..18a40a83453d 100644 --- a/rust/bindings/bindings_helper.h +++ b/rust/bindings/bindings_helper.h @@ -35,6 +35,7 @@ #include #include #include +#include #include /* `bindgen` gets confused at certain things. */ @@ -48,3 +49,8 @@ const gfp_t RUST_CONST_HELPER___GFP_ZERO = __GFP_ZERO; const gfp_t RUST_CONST_HELPER___GFP_HIGHMEM = ___GFP_HIGHMEM; const gfp_t RUST_CONST_HELPER___GFP_NOWARN = ___GFP_NOWARN; const blk_features_t RUST_CONST_HELPER_BLK_FEAT_ROTATIONAL = BLK_FEAT_ROTATIONAL; + +const xa_mark_t RUST_CONST_HELPER_XA_PRESENT = XA_PRESENT; + +const gfp_t RUST_CONST_HELPER_XA_FLAGS_ALLOC = XA_FLAGS_ALLOC; +const gfp_t RUST_CONST_HELPER_XA_FLAGS_ALLOC1 = XA_FLAGS_ALLOC1; diff --git a/rust/helpers/helpers.c b/rust/helpers/helpers.c index 0640b7e115be..6811f71f2cbb 100644 --- a/rust/helpers/helpers.c +++ b/rust/helpers/helpers.c @@ -35,3 +35,4 @@ #include "vmalloc.c" #include "wait.c" #include "workqueue.c" +#include "xarray.c" diff --git a/rust/helpers/xarray.c b/rust/helpers/xarray.c new file mode 100644 index 000000000000..60b299f11451 --- /dev/null +++ b/rust/helpers/xarray.c @@ -0,0 +1,28 @@ +// SPDX-License-Identifier: GPL-2.0 + +#include + +int rust_helper_xa_err(void *entry) +{ + return xa_err(entry); +} + +void rust_helper_xa_init_flags(struct xarray *xa, gfp_t flags) +{ + return xa_init_flags(xa, flags); +} + +int rust_helper_xa_trylock(struct xarray *xa) +{ + return xa_trylock(xa); +} + +void rust_helper_xa_lock(struct xarray *xa) +{ + return xa_lock(xa); +} + +void rust_helper_xa_unlock(struct xarray *xa) +{ + return xa_unlock(xa); +} diff --git a/rust/kernel/lib.rs b/rust/kernel/lib.rs index 398242f92a96..e6e49dcdcb4c 100644 --- a/rust/kernel/lib.rs +++ b/rust/kernel/lib.rs @@ -85,6 +85,7 @@ pub mod types; pub mod uaccess; pub mod workqueue; +pub mod xarray; #[doc(hidden)] pub use bindings; diff --git a/rust/kernel/xarray.rs b/rust/kernel/xarray.rs new file mode 100644 index 000000000000..58ea5cf8c314 --- /dev/null +++ b/rust/kernel/xarray.rs @@ -0,0 +1,277 @@ +// SPDX-License-Identifier: GPL-2.0 + +//! XArray abstraction. +//! +//! C header: [`include/linux/xarray.h`](srctree/include/linux/xarray.h) + +use crate::{ + alloc, bindings, build_assert, + error::{Error, Result}, + init::PinInit, + pin_init, + types::{ForeignOwnable, NotThreadSafe, Opaque}, +}; +use core::{iter, marker::PhantomData, mem, pin::Pin, ptr::NonNull}; +use macros::{pin_data, pinned_drop}; + +/// An array which efficiently maps sparse integer indices to owned objects. +/// +/// This is similar to a [`crate::alloc::kvec::Vec>`], but more efficient when there are +/// holes in the index space, and can be efficiently grown. +/// +/// # Invariants +/// +/// `self.xa` is always an initialized and valid [`bindings::xarray`] whose entries are either +/// `XA_ZERO_ENTRY` or came from `T::into_foreign`. +/// +/// # Examples +/// +/// ```rust +/// use kernel::alloc::KBox; +/// use kernel::xarray::{AllocKind, XArray}; +/// +/// let xa = KBox::pin_init(XArray::new(AllocKind::Alloc1), GFP_KERNEL)?; +/// +/// let dead = KBox::new(0xdead, GFP_KERNEL)?; +/// let beef = KBox::new(0xbeef, GFP_KERNEL)?; +/// +/// let mut guard = xa.lock(); +/// +/// assert_eq!(guard.get(0), None); +/// +/// assert_eq!(guard.store(0, dead, GFP_KERNEL)?.as_deref(), None); +/// assert_eq!(guard.get(0).copied(), Some(0xdead)); +/// +/// *guard.get_mut(0).unwrap() = 0xffff; +/// assert_eq!(guard.get(0).copied(), Some(0xffff)); +/// +/// assert_eq!(guard.store(0, beef, GFP_KERNEL)?.as_deref().copied(), Some(0xffff)); +/// assert_eq!(guard.get(0).copied(), Some(0xbeef)); +/// +/// guard.remove(0); +/// assert_eq!(guard.get(0), None); +/// +/// # Ok::<(), Error>(()) +/// ``` +#[pin_data(PinnedDrop)] +pub struct XArray { + #[pin] + xa: Opaque, + _p: PhantomData, +} + +#[pinned_drop] +impl PinnedDrop for XArray { + fn drop(self: Pin<&mut Self>) { + self.iter().for_each(|ptr| { + let ptr = ptr.as_ptr(); + // SAFETY: `ptr` came from `T::into_foreign`. + // + // INVARIANT: we own the only reference to the array which is being dropped so the + // broken invariant is not observable on function exit. + drop(unsafe { T::from_foreign(ptr) }) + }); + + // SAFETY: `self.xa` is always valid by the type invariant. + unsafe { bindings::xa_destroy(self.xa.get()) }; + } +} + +/// Flags passed to [`XArray::new`] to configure the array's allocation tracking behavior. +pub enum AllocKind { + /// Consider the first element to be at index 0. + Alloc, + /// Consider the first element to be at index 1. + Alloc1, +} + +impl XArray { + /// Creates a new initializer for this type. + pub fn new(kind: AllocKind) -> impl PinInit { + let flags = match kind { + AllocKind::Alloc => bindings::XA_FLAGS_ALLOC, + AllocKind::Alloc1 => bindings::XA_FLAGS_ALLOC1, + }; + pin_init!(Self { + // SAFETY: `xa` is valid while the closure is called. + // + // INVARIANT: `xa` is initialized here to an empty, valid [`bindings::xarray`]. + xa <- Opaque::ffi_init(|xa| unsafe { + bindings::xa_init_flags(xa, flags) + }), + _p: PhantomData, + }) + } + + fn iter(&self) -> impl Iterator> + '_ { + let mut index = 0; + + // SAFETY: `self.xa` is always valid by the type invariant. + iter::once(unsafe { + bindings::xa_find(self.xa.get(), &mut index, usize::MAX, bindings::XA_PRESENT) + }) + .chain(iter::from_fn(move || { + // SAFETY: `self.xa` is always valid by the type invariant. + Some(unsafe { + bindings::xa_find_after(self.xa.get(), &mut index, usize::MAX, bindings::XA_PRESENT) + }) + })) + .map_while(|ptr| NonNull::new(ptr.cast())) + } + + /// Attempts to lock the [`XArray`] for exclusive access. + pub fn try_lock(&self) -> Option> { + // SAFETY: `self.xa` is always valid by the type invariant. + if (unsafe { bindings::xa_trylock(self.xa.get()) } != 0) { + Some(Guard { + xa: self, + _not_send: NotThreadSafe, + }) + } else { + None + } + } + + /// Locks the [`XArray`] for exclusive access. + pub fn lock(&self) -> Guard<'_, T> { + // SAFETY: `self.xa` is always valid by the type invariant. + unsafe { bindings::xa_lock(self.xa.get()) }; + + Guard { + xa: self, + _not_send: NotThreadSafe, + } + } +} + +/// A lock guard. +/// +/// The lock is unlocked when the guard goes out of scope. +#[must_use = "the lock unlocks immediately when the guard is unused"] +pub struct Guard<'a, T: ForeignOwnable> { + xa: &'a XArray, + _not_send: NotThreadSafe, +} + +impl Drop for Guard<'_, T> { + fn drop(&mut self) { + // SAFETY: + // - `self.xa.xa` is always valid by the type invariant. + // - The caller holds the lock, so it is safe to unlock it. + unsafe { bindings::xa_unlock(self.xa.xa.get()) }; + } +} + +/// The error returned by [`store`](Guard::store). +/// +/// Contains the underlying error and the value that was not stored. +pub struct StoreError { + /// The error that occurred. + pub error: Error, + /// The value that was not stored. + pub value: T, +} + +impl From> for Error { + fn from(value: StoreError) -> Self { + self.error + } +} + +impl<'a, T: ForeignOwnable> Guard<'a, T> { + fn load(&self, index: usize, f: F) -> Option + where + F: FnOnce(NonNull) -> U, + { + // SAFETY: `self.xa.xa` is always valid by the type invariant. + let ptr = unsafe { bindings::xa_load(self.xa.xa.get(), index) }; + let ptr = NonNull::new(ptr.cast())?; + Some(f(ptr)) + } + + /// Provides a reference to the element at the given index. + pub fn get(&self, index: usize) -> Option> { + self.load(index, |ptr| { + // SAFETY: `ptr` came from `T::into_foreign`. + unsafe { T::borrow(ptr.as_ptr()) } + }) + } + + /// Provides a mutable reference to the element at the given index. + pub fn get_mut(&mut self, index: usize) -> Option> { + self.load(index, |ptr| { + // SAFETY: `ptr` came from `T::into_foreign`. + unsafe { T::borrow_mut(ptr.as_ptr()) } + }) + } + + /// Removes and returns the element at the given index. + pub fn remove(&mut self, index: usize) -> Option { + // SAFETY: + // - `self.xa.xa` is always valid by the type invariant. + // - The caller holds the lock. + let ptr = unsafe { bindings::__xa_erase(self.xa.xa.get(), index) }.cast(); + // SAFETY: + // - `ptr` is either NULL or came from `T::into_foreign`. + // - `&mut self` guarantees that the lifetimes of [`T::Borrowed`] and [`T::BorrowedMut`] + // borrowed from `self` have ended. + unsafe { T::try_from_foreign(ptr) } + } + + /// Stores an element at the given index. + /// + /// May drop the lock if needed to allocate memory, and then reacquire it afterwards. + /// + /// On success, returns the element which was previously at the given index. + /// + /// On failure, returns the element which was attempted to be stored. + pub fn store( + &mut self, + index: usize, + value: T, + gfp: alloc::Flags, + ) -> Result, StoreError> { + build_assert!( + mem::align_of::() >= 4, + "pointers stored in XArray must be 4-byte aligned" + ); + let new = value.into_foreign(); + + let old = { + let new = new.cast(); + // SAFETY: + // - `self.xa.xa` is always valid by the type invariant. + // - The caller holds the lock. + // + // INVARIANT: `new` came from `T::into_foreign`. + unsafe { bindings::__xa_store(self.xa.xa.get(), index, new, gfp.as_raw()) } + }; + + // SAFETY: `__xa_store` returns the old entry at this index on success or `xa_err` if an + // error happened. + let errno = unsafe { bindings::xa_err(old) }; + if errno != 0 { + // SAFETY: `new` came from `T::into_foreign` and `__xa_store` does not take + // ownership of the value on error. + let value = unsafe { T::from_foreign(new) }; + Err(StoreError { + value, + error: Error::from_errno(errno), + }) + } else { + let old = old.cast(); + // SAFETY: `ptr` is either NULL or came from `T::into_foreign`. + // + // NB: `XA_ZERO_ENTRY` is never returned by functions belonging to the Normal XArray + // API; such entries present as `NULL`. + Ok(unsafe { T::try_from_foreign(old) }) + } + } +} + +// SAFETY: `XArray` has no shared mutable state so it is `Send` iff `T` is `Send`. +unsafe impl Send for XArray {} + +// SAFETY: `XArray` serialises the interior mutability it provides so it is `Sync` iff `T` is +// `Send`. +unsafe impl Sync for XArray {} From patchwork Fri Feb 21 20:27:42 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tamir Duberstein X-Patchwork-Id: 13986255 Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1B9025335A; Fri, 21 Feb 2025 20:27:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740169672; cv=none; b=PNyeWUiT6p4zjTldpZGj7WM35RmJSthfekwQIQDvo9OUdZmFXJUUXtf1WbYK1Cz+jpt7rbXuE1fi6bciZyC9C3EaC0hr475047bow1Q+o7+8w39OXa/dWiNjtFYIIb02TzIJlMiboHmv9MWPMuM1gqCrexM2ufEAuwwiiYAoYG8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740169672; c=relaxed/simple; bh=nGhttoR1swOP1QTQwepuqeDirYgZPEDMvtJFLrL5dpk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=T4R1ac/tAw4e+Ccr/Hq8DWy7t9mMmztRZnlEu+S/RQD3VDvQ24QUpWVf20u4SdUtg4z9EjdzshDRtD81UECOFhCsX2qj4yesNgZ8bfUSSDQvb+iDQdj2FwBbr2db+9WYdJgDLMq2aLziwoiyE4a2b/T31jWinHbBkrp0GhboV/k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=f0ZBdYYL; arc=none smtp.client-ip=209.85.222.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="f0ZBdYYL" Received: by mail-qk1-f172.google.com with SMTP id af79cd13be357-7be8f281714so286979385a.1; Fri, 21 Feb 2025 12:27:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740169669; x=1740774469; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ipEWRTbUNI0fhw7p2quxgycmIwXwELriTrZg15QiXvk=; b=f0ZBdYYLTwTUzg8FTtxf3KU6TgUtjekCsKIZA6luesUxMxxt5lLHxi0hhWxr3rvWEh lkZeLh887xL1D5KhFReVhzQcDlnQ7uRxVezFnbel+SksGa95XXDesXf16TbD4LsuGVZA FdbYtXuGJuDCFvTsunNS66G+L+6fwjSQdoXfnYw/knXey3aXXvbZ1a615or719J+W6KV GkSs5H9LHNiywGZZar91lYHw5Qwb46ps5HSr+Wdc6XVBJ7h1ARzE/vkaz5np3GTYPX4s ArX9+U12YFmRhZhpy8823m0LRaZfbNmGN0p2ZLtZGf3LdVjP/vnOXSScJGyjLZX5b2Kn DJYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740169669; x=1740774469; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ipEWRTbUNI0fhw7p2quxgycmIwXwELriTrZg15QiXvk=; b=aW4dMi6tAwP8xjJc9xCQYWUwn740aWZf/DTuvP1NFqxLwzHDcz8zY+dXCGWYhuTxle R/RNydIM6C6AetdkmBcASC+SezVUjyvizAit89WzMJPyQjIwmt8CnUUKTTqKHJyTFKqI h583qEmn/Gd3aOp5r86wtiz5g1olrptSPqwxNxFws1TOmLoQXVGPeYRQViLtvVlmWJ1o uSHInCwcDnlc+OV8vDv/tpU5ybP0VNIi4B1fKMSxKVK5lDes8hcp4bzLihrBMpBBFdWv Qj/uOR0dDppT9uWo5J+jvppqpCS5qFKyNPgXNnqnjk4WzooM9hQoQqa28WDqzV7Dn7zh DNWQ== X-Forwarded-Encrypted: i=1; AJvYcCUGx7BXOSv46MpgWdW90FDWXLwc4He/NDioBcGmJjsSVKGW7nz6lDo9l8T3+JeerJN55ebZf9urKMtWWYJ2@vger.kernel.org, AJvYcCUd04E5DFszz+ObBHAs1grwf/hfJ5s57669z/43NDhxMGln5LnumBVy2JKYy9D7itaTMbAthMsc2UGREc4F@vger.kernel.org, AJvYcCV4u2v4P8pq6oo93JhkOgkjj0kOepkss5jWTEZD0rdTuhZgQ1Vrd+M5jQmjmY6fxBr5ibsVD4HN3R0n@vger.kernel.org, AJvYcCVsER99ejtFFngJYSK2qdUNoq/4UOVU/csxxLXzGndh+4IC9KCNNHqwJG8WClDUhR/yhgJ2tNwOlMKP8Chtj8w=@vger.kernel.org X-Gm-Message-State: AOJu0Yyzk53oPGF3pzyct4teOPhPgaMeiGxVeoS0rRQsjqM/ocsNRW1Z mLfamS/FiOI+VcSN7tkOsrbNpFcHIv229QyybGylqhWyj3qCCK8Z X-Gm-Gg: ASbGncucSlqKMb4QPYBsR3nzgekM4vHW7p6Q+2WVmzyokFVC1s/5KRpodxN2vYiUUwI L3kt+Giu+ljQYHHOE7ImW5/7IOBCcrMalL2Yfqv+IOxBKUUrSTmnoIrUfDYLCsEnUcpaHDznfYy /zLvUbBQu1ZmKctvEJaSW1KNX/0cdceNG6xqn1b2QONeMpuxGkAXcBj7/pXo3QWUKZ6JeyuMmDb nz+D0Onoy2ZnrSalgjyJ1zkV/QbY2qe8jdn4Le8aXLsv9j+jdooB1qt1sA7KCL5nqWp5b/RIwHU suiVHnOSr9J/8JHRlIire6JUkIdAEVlwsF/HIDeqv5D01oR1Rw== X-Google-Smtp-Source: AGHT+IGzdMSv/oYQrAzUn6Bchc187UjEzN2FLNKCWP2FOrjv2+RNm6uEFODoqMSglyfAVjItmAIXJQ== X-Received: by 2002:a05:620a:2b86:b0:7c0:a2d9:cb65 with SMTP id af79cd13be357-7c0cef66eb1mr679494585a.57.1740169669461; Fri, 21 Feb 2025 12:27:49 -0800 (PST) Received: from tamird-mac.local ([2600:4041:5be7:7c00:880f:47d4:56c6:b852]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c0a99d363csm539224985a.70.2025.02.21.12.27.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Feb 2025 12:27:48 -0800 (PST) From: Tamir Duberstein Date: Fri, 21 Feb 2025 15:27:42 -0500 Subject: [PATCH v18 3/3] MAINTAINERS: add entry for Rust XArray API Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250221-rust-xarray-bindings-v18-3-cbabe5ddfc32@gmail.com> References: <20250221-rust-xarray-bindings-v18-0-cbabe5ddfc32@gmail.com> In-Reply-To: <20250221-rust-xarray-bindings-v18-0-cbabe5ddfc32@gmail.com> To: Danilo Krummrich , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Matthew Wilcox , Bjorn Helgaas , Greg Kroah-Hartman , "Rafael J. Wysocki" , Tamir Duberstein , FUJITA Tomonori , "Rob Herring (Arm)" Cc: =?utf-8?q?Ma=C3=ADra_Canal?= , Asahi Lina , rust-for-linux@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org X-Mailer: b4 0.15-dev Add an entry for the Rust xarray abstractions. Acked-by: Andreas Hindborg Signed-off-by: Tamir Duberstein --- MAINTAINERS | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index efee40ea589f..f8d6a5f4a4cc 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -25794,6 +25794,17 @@ F: lib/test_xarray.c F: lib/xarray.c F: tools/testing/radix-tree +XARRAY API [RUST] +M: Tamir Duberstein +M: Andreas Hindborg +L: rust-for-linux@vger.kernel.org +S: Supported +W: https://rust-for-linux.com +B: https://github.com/Rust-for-Linux/linux/issues +C: https://rust-for-linux.zulipchat.com +T: git https://github.com/Rust-for-Linux/linux.git rust-next +F: rust/kernel/xarray.rs + XBOX DVD IR REMOTE M: Benjamin Valentin S: Maintained