From patchwork Tue Mar 19 01:25:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aditya Pakki X-Patchwork-Id: 10859683 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4AE7415AC for ; Tue, 19 Mar 2019 14:32:10 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 25C7E2944F for ; Tue, 19 Mar 2019 14:32:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2380829589; Tue, 19 Mar 2019 14:32:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 766B4296CB for ; Tue, 19 Mar 2019 14:32:09 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 8F1D6885; Tue, 19 Mar 2019 15:31:17 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 8F1D6885 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1553005927; bh=KnaRQz5s2xQezm06m2lMukOmc3u1ZaI1HEN35Q/JcHQ=; h=From:To:Date:Cc:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=P9oLPUngKiLU2dyBZFf3vnR3Jii7eRVkQw+pcfXotmyFsRwedbhN9cZ1M20Gp7QzJ xnwDTYOOyFBf5pYfj/Cezjw428jzYne2uP2zYhxP3ui0VSgyNZluYkI0xMIFy/rymT EQxQmhU6SRoyPf9x6VGQWaNHOYmvopoTmsGcw4gE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 0A0E6F8972A; Tue, 19 Mar 2019 15:26:22 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa1.perex.cz (Postfix, from userid 50401) id 9C977F80C0B; Tue, 19 Mar 2019 02:25:35 +0100 (CET) Received: from mta-p6.oit.umn.edu (mta-p6.oit.umn.edu [134.84.196.206]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id DF024F80792 for ; Tue, 19 Mar 2019 02:25:31 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz DF024F80792 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=umn.edu header.i=@umn.edu header.b="bc9ReCT2" Received: from localhost (unknown [127.0.0.1]) by mta-p6.oit.umn.edu (Postfix) with ESMTP id 94D116DE for ; Tue, 19 Mar 2019 01:25:29 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p6.oit.umn.edu ([127.0.0.1]) by localhost (mta-p6.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yJI9DBcC9kKM for ; Mon, 18 Mar 2019 20:25:29 -0500 (CDT) Received: from mail-it1-f197.google.com (mail-it1-f197.google.com [209.85.166.197]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p6.oit.umn.edu (Postfix) with ESMTPS id 6D85D6A7 for ; Mon, 18 Mar 2019 20:25:29 -0500 (CDT) Received: by mail-it1-f197.google.com with SMTP id m132so2413542ita.4 for ; Mon, 18 Mar 2019 18:25:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id; bh=e81gva8RESvZVXCF6/lhVsiNVnyDaMCLqN30BEvMok0=; b=bc9ReCT2szDHK/qH+HhSl21bSi4oneKTL8L1Q0f0R2BrC/B0nWlKQWxEJmAdnlAE93 pvw3aD+uzA37/wDC7wpOC272FjozztyTrBgarhtpJ0i7vkjbgl74jjPbGKhts91Wukq+ 3IvKlPUHN0EYCyxeCM3Z3fdfWEhugxC+rY3WCUj3Z8tD9CtN4W5+Lg+tdo1qWObwxKrQ b3WTrvBEjHh9muTostb6wOdVanAdYKLAxNvDNvDFDAP+fexuJqLrRBc8pAKjUrh2rvna Qu77UMmP2GObH81CLrOLO70x+eHIvJFwkkg6t756wnNtIFHpHq0m4RFQnDhT475VsQOz th2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=e81gva8RESvZVXCF6/lhVsiNVnyDaMCLqN30BEvMok0=; b=Tl6ITl4vkROJ+a5ZloHyJztJd8bLWGupEKp2o5OUXKc7lxtTBz+Cy7V1keMl5FOmcF 93A6uiQp4yTxCw68mLuHgDwztZIQOkdFa/sn6bdX0bQGK32qdu7/doNf1hrblUzxlM5F hIhNqKpAPQYuXEnthWo7mAWbYnvHmQrDNnd7+JOZCHUDlK6+myCuZxlRLVix+XAGLNYY R+LUjv/ernO1XqWY+pDcwZ2XjRQ/izdcPpDlxC9v1ou6myZW4iapD50a25pkBFukvit5 tmlxaKQVg8hbPC0RIQ7ZXy55nZxli9Ny+/QZxAQbxebVbcDJSJ3wo5x4VrJfWbOU3hFo QL/g== X-Gm-Message-State: APjAAAUKgTxEj1SYNFANBxd5JgGn0zPwlm56+MT0ys37IoeY5eljvRLU wb9yJVaKEjYX3H3InqwAJWeRjErlF0+ZNy8OXoiiCLRd7FyZSLlqVUwhpsxvVU7Z1r9pWAtz6xH b1LSwuwfAEA3II1ihVxbxdPOveTw= X-Received: by 2002:a05:660c:88f:: with SMTP id o15mr1145467itk.46.1552958728652; Mon, 18 Mar 2019 18:25:28 -0700 (PDT) X-Google-Smtp-Source: APXvYqw6gPvP7Bi4ldqqqpa8ypua7Eq4q3LRqj4mYGODFSvLbvHeeNulD1IlJzSppObbLDKy/ivxRg== X-Received: by 2002:a05:660c:88f:: with SMTP id o15mr1145447itk.46.1552958728240; Mon, 18 Mar 2019 18:25:28 -0700 (PDT) Received: from lenovo-1.hsd1.mn.comcast.net (c-73-242-25-233.hsd1.mn.comcast.net. [73.242.25.233]) by smtp.googlemail.com with ESMTPSA id g194sm1080038itc.31.2019.03.18.18.25.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Mar 2019 18:25:27 -0700 (PDT) From: Aditya Pakki To: pakki001@umn.edu Date: Mon, 18 Mar 2019 20:25:23 -0500 Message-Id: <20190319012523.14644-1-pakki001@umn.edu> X-Mailer: git-send-email 2.17.1 X-Mailman-Approved-At: Tue, 19 Mar 2019 15:26:12 +0100 Cc: alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org, kjlu@umn.edu, linux-kernel@vger.kernel.org, David Brown , Srinivas Kandagatla , Andy Gross Subject: [alsa-devel] [PATCH] slimbus: ngd: Fix to avoid potential NULL pointer dereference X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" X-Virus-Scanned: ClamAV using ClamSMTP In of_qcom_slim_ngd_register, of_match_node may fail and return a NULL pointer. This patch avoids such a scenario leading to NULL pointer dereference. Fixes: 458a445deb9c ("slimbus: ngd: Fix build error on x86") Signed-off-by: Aditya Pakki --- drivers/slimbus/qcom-ngd-ctrl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctrl.c index 71f094c9ec68..9cc7256028c9 100644 --- a/drivers/slimbus/qcom-ngd-ctrl.c +++ b/drivers/slimbus/qcom-ngd-ctrl.c @@ -1332,6 +1332,8 @@ static int of_qcom_slim_ngd_register(struct device *parent, u32 id; match = of_match_node(qcom_slim_ngd_dt_match, parent->of_node); + if (!match) + return -ENXIO; data = match->data; for_each_available_child_of_node(parent->of_node, node) { if (of_property_read_u32(node, "reg", &id))