From patchwork Tue Feb 25 07:26:06 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tariq Toukan X-Patchwork-Id: 13989389 X-Patchwork-Delegate: kuba@kernel.org Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2080.outbound.protection.outlook.com [40.107.94.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52BDA16088F; Tue, 25 Feb 2025 07:27:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.94.80 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740468439; cv=fail; b=M3RW92CRTS+sWiKo1PNUx1C6iPsofZlgQnknCRr6OQTLdrE2Ad+/+kG1RdBS8dXlrbZubTAnnegvWM2v0HEZENZrniHQZl+zQ9FdQI1dxph8nAlqrBwb/cIfLZDlQRL+DbhD9msR+7rbVKLC47/0QQMg3gFuWeZLpyKM1XpyA6w= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740468439; c=relaxed/simple; bh=xVf3Rrhy79qL0tBz4qALFxLNs45zLZqE9vnyTM7Kkjc=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=PVL/aUaBarVkPF9brrVJ2Qn1GhSWWurdjnuQZE4cIgam/KcbbuZYd6tpelkqo6h5Ik4dZSqzx1z2niII2taMJXsu9GTDv4FqB6a6ALeKsjyLEnTh9ZXMra5uNKboU09AX+zPuM6gumNMGLvXuVqH7Tzly/WRlBGW1OXjsn4GLtA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=ISIeRLap; arc=fail smtp.client-ip=40.107.94.80 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="ISIeRLap" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=P0dBQgTWK63TxlBNv5JmoswOkWICm6icuAa9O57Kd0ZrZN+xJipduGsTbLa6rqd/sQD1jL6MlYfx2NJDx6GSIT8pFS3IZ7htrp1BKPMRuEBpxytHJzqROrAInTy0sQubQVSnNYZcnOdAl6Qu5hXBQDyhgub/3/F3cFpop2JrX+Kxd/qTL01KREnz/MCbOZeWaWOWMdvRoVWRevK7zQMe9E7bsCvF0jyDuDZMvjWMeMIQP/ejGJj3sLEtYobkF4RbkpF2g3VDc0eyyiPgf1zs5OLFrPeeu25+WWX/SzOPsffS3YnkM6yASxhjWI7VbtX4K2ToU510oeD93Uf1zpDZoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XHdviLVkhgNTk1YJqCB6rnJYTmg2dCWuNEK2d6diN0Q=; b=h8KRSgZdRNLzmx2NUYUj5aanz8TRxOog4MBuEKafVsC7y3zb36bqVU4JsC74kHe23gxH+eG2Q04k8KQFhhNSondCXtjmzgbYahwC5q8lEj4zINkaG3On7D+qSwOGPWeA1jui7hvoT521PJTQrYqw058wcKrlfoLtgj8th5IGyD+VDqH33JKmVXWUWYQ24SxgyhNHzPr4P8yJIDPUOMods6MnyFzHufwSM9uWXx+Q4wkJkLm4w+BN9TrjZJQ85o362hnR5ByQpFxjhQyZB2vZk0Jq5VJdzholcQRt3Z29UtNn537vdw1MArfhgB5JHmWdTEXO4vnSYlUxy3qm3yDXww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=davemloft.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XHdviLVkhgNTk1YJqCB6rnJYTmg2dCWuNEK2d6diN0Q=; b=ISIeRLapPe8eNLhrEOJzMPua/o2aGZSjCyLXPDaZ2xJbou0rt8cu4weHW+bJhUMP73UARoSZIgB50Zow9l6r3kOD3bv2NV/Re2La5qLMatg+F7+zvyAgL8Cbt79SizeeDx+dczC8qSWD6QBk6BAV5rWfeYv3UTRtY1oFSgSHr67ubL88RnZzLZ+oQrdGPSNOky5m+elIPjsfA0dZ9vfznBRPa6/EI34vsdkdCyUl0i9Y3UsKPnRSf04uBeNORc3VVmoQm095ZTjHibM+cHy/YAq1VH7fQmwUXMLaC8mkCrInJS9Tg0LmzBmbtR2y1lC4Y7wKjmrFq3WFdk4oNh6c6g== Received: from SJ0PR13CA0219.namprd13.prod.outlook.com (2603:10b6:a03:2c1::14) by SJ0PR12MB7006.namprd12.prod.outlook.com (2603:10b6:a03:486::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.21; Tue, 25 Feb 2025 07:27:15 +0000 Received: from CO1PEPF000066E7.namprd05.prod.outlook.com (2603:10b6:a03:2c1:cafe::25) by SJ0PR13CA0219.outlook.office365.com (2603:10b6:a03:2c1::14) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8489.16 via Frontend Transport; Tue, 25 Feb 2025 07:27:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CO1PEPF000066E7.mail.protection.outlook.com (10.167.249.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8489.16 via Frontend Transport; Tue, 25 Feb 2025 07:27:14 +0000 Received: from rnnvmail203.nvidia.com (10.129.68.9) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 24 Feb 2025 23:27:01 -0800 Received: from rnnvmail203.nvidia.com (10.129.68.9) by rnnvmail203.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Mon, 24 Feb 2025 23:27:01 -0800 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.9) with Microsoft SMTP Server id 15.2.1544.14 via Frontend Transport; Mon, 24 Feb 2025 23:26:57 -0800 From: Tariq Toukan To: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet , "Andrew Lunn" CC: Gal Pressman , Mark Bloch , "Saeed Mahameed" , Leon Romanovsky , Tariq Toukan , Cosmin Ratiu , Carolina Jubran , Shay Drory , , , , Dragos Tatulea Subject: [PATCH net 1/3] net/mlx5: Fix vport QoS cleanup on error Date: Tue, 25 Feb 2025 09:26:06 +0200 Message-ID: <20250225072608.526866-2-tariqt@nvidia.com> X-Mailer: git-send-email 2.45.0 In-Reply-To: <20250225072608.526866-1-tariqt@nvidia.com> References: <20250225072608.526866-1-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: AnonymousSubmission X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000066E7:EE_|SJ0PR12MB7006:EE_ X-MS-Office365-Filtering-Correlation-Id: f088d792-8ab5-44e3-59bb-08dd556dd398 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|36860700013|1800799024; X-Microsoft-Antispam-Message-Info: WcxthG5rdHRM9/PrTu4mHrmcsodvebZunYXS4r+6aXpBSiU17PIm+Yi6SGhheSV9p2bAhtSLV0f8Dgt3hZUQpQ3x3C4JoIg4G1KhGBbzes16bRv6WhwL2YRQPGKdikY9QM63g7Yd2i/7HWOweKxFJ3qNTPAJ0R71yoD1E0SVWdnsmUv1bWXRkIMet8H/xFHJF4RMHE3g7fUC+Nh2agI1T1O5n/sYVNqAWYOXjNLHDWghSjO4kPatrqCy/POo5brfHCWM8snaxzobAA7uyqP3QzqowaioiCo8eVfIM9DrgXsk17VG1ZdSpZKjxHvC4bngXPD/e/NyV/e/T8MLSqKKRmXTUAJWASzV87XJgdksqVrvQ8sILOiGOwB1LjrmyVWFzq/VXnPbvxPjixntriQmapr6qPwOjsDw0BBPtlD6fp3rlEsLCcjX6MD0TK/Js5I1In8hRppytlXa3RRVD6apsGwXfIzHXnOD/aNEEhybvyMHD1tOl0cGHh/wDFClaoSYXDORLWIkyDaAZoYH2mFFk28dRQsjMER9fmQ19y6xB1rfrf6YVcd4f0S08CGr1nYVjl+Zo0GPXsaFYOmuQM8mjwECEw8w5GOQBm/ohJBR+Mj47BgUXSrPT01veQxtzzzQkRXOFBB1s7czvW05LKprTh9uJ4rwx+ZmKc6FjwPC2h9zOx4oNYy3MXmloTWc+NfGjrIfXjtqYRrhA7IgbbuM2rTrNYXDph5G9fdNw1aXFT3cP/h3NeDwErKBIIcNsQbEbd1ytv/CAoT63wjj2V3+DJTB1hYw0JvNjQHTHN+R3OoAgGPgV8fqOjINNZ0e6UbzUX7XsiKi2LQN2HAW+CWfqIfHyPlK4kjgysXEMBnF3tkFPYM3oh4eMiRHvbnw+whSrYeex9V85loJDV4ksEfdK3eE9nyyrtY26b4swH1mmbbp3FjO3E44hZU5y+/q6HFeZYS8eqS5kHbLp8hQcAdTkDcgCuhTBUo0p8ZLDkwzKOGhf45JdvuWstPTdscsD+QWFIXL7UmIN9FXF2C+qTo8+P1kZg4UZZVtWyZZKS6PgmrwP/5TKCiezR+scHOzPb0Jj7fOnuKxcEJosUB2KO9pfrfjd/lCLzRnXitdppeHK9BQAuBUeRz/bGvwiyzto6Erwq1sFrFivNXeGOsUKEJ5PLUGanvjGIPVPjD/d858IjndHZUoqgRGAkTHPJupyrS3MOcs1BnKJ7GnLjOrGvn0GL1BJ93eXiR4P/Fp+nJGjp7lyRGjujtyUBTUhLgWun0+BSScaDprpqDlfNKK9dQh3+aRp4QG2HTlFkwBWYP11YsMRMwFYGyF4MNYqaZE90GNMhF/nM6rqbtV5fPUpubKVFBFRb5DD7gNs6ap5JfJbCOyLKleeMa6WlwjFoHYajULNRH502WPKYQJlaINcsceg7v+dyHyUbY2E/a8L+5HZgqt8Tcr3XSG5c//EJzRsczr9ntyPN+WZXQCzIJqgkzQa00983jbfr7Z5g422KeQ37o= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(82310400026)(376014)(36860700013)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2025 07:27:14.5314 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f088d792-8ab5-44e3-59bb-08dd556dd398 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000066E7.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB7006 X-Patchwork-Delegate: kuba@kernel.org From: Carolina Jubran When enabling vport QoS fails, the scheduling node was never freed, causing a leak. Add the missing free and reset the vport scheduling node pointer to NULL. Fixes: be034baba83e ("net/mlx5: Make vport QoS enablement more flexible for future extensions") Signed-off-by: Carolina Jubran Reviewed-by: Cosmin Ratiu Reviewed-by: Dragos Tatulea Signed-off-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c b/drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c index 8b7c843446e1..07a28073a49e 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c @@ -591,8 +591,11 @@ static int mlx5_esw_qos_vport_enable(struct mlx5_vport *vport, enum sched_node_t sched_node->vport = vport; vport->qos.sched_node = sched_node; err = esw_qos_vport_enable(vport, parent, extack); - if (err) + if (err) { + __esw_qos_free_node(sched_node); esw_qos_put(esw); + vport->qos.sched_node = NULL; + } return err; } From patchwork Tue Feb 25 07:26:07 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tariq Toukan X-Patchwork-Id: 13989391 X-Patchwork-Delegate: kuba@kernel.org Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2062.outbound.protection.outlook.com [40.107.223.62]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4E2425B687; Tue, 25 Feb 2025 07:27:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.223.62 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740468450; cv=fail; b=ber9wsUALfI2TP9jPwul+unub/XsvO/+A7fsnnCHPoQtMaysPGQCxfUbesRe25vQWbrgetphpPBGpDw6oT1AI7n6Q2LeT531HszRpHFeY0XR+n/kkYe2wraHDHM9Cmefl3IuoVY7RbrPgJarKF5/uNCownVxH6MEIUDpup9A1OI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740468450; c=relaxed/simple; bh=XN/gsiRm1+4xsz0+UcNnYxbmK6EH2/WnedpaDYp0j8U=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=kkZqJLfdw8FziAzJ1gJ22vzXqB7ZjC+5LYByUW9SbgsSu1gOCoxf1PKDAcWRmILX7U+VA3SVl6YurD775qJHyBE/lp9+jPE//Nu7uje118p5ikm3CoQGn/hfVqty3UJc3XWdmMbFobG9QUQZQHinruHJvh/O2Du9t9ynH1EWvMQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=oh1wrGyY; arc=fail smtp.client-ip=40.107.223.62 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="oh1wrGyY" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WGCY8xfxcqoxiA7WvlPambyPaJQHcZ3Xnzl28ii0ECODnF9037KErjAgWfrC1SdXbXz9QdOHK6HS8I0UrEbiYambvKac5Ngv7ZyNDQm0+t+/dLWs+RAz1aQV6ktkS3bK4nx584fVxmeAk86IM8Ksn4WG+sXOVm1lVFsSeKpeF0UjM2LQslT+Ev7QJEU+OUy3GUMOsrYo4zy7MsvvnfY7L3GiFhv4AsNdi4dh2rFp0dDeyYPG2UK8+JEDSHrEFyBIKe2lv+cheSfiGMbUqNkTOw6GlETwzKwXVGD3kPxJQoAczEhKl+74Fl3V1E+L0qDdnHMRDJwlXbsKbkWsVnjH9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kqlEDE/Dx/7yQ8JuROZJkO568Vsl3m48qQGmsglR9+A=; b=PP1eggkM+mFjc0CoYg91+nLzwstVAdsar7lSq2bpV84NXEizL+sVgmc99FaJZgZDUz0DeO6H44qE9RcjKdjB6UMLC1YMYlSknX0WCdcGFqocS7zhV/hD9VTOXAWg3lhtrABkfNJqZC/u5qLae5CbqFteowwJxIKaJ2vBTnxZNlMUtLk66+F3P6Xt7ckoIYYWU7dJJBW34C00g+eUBKNH+k+sENNK+Vn8chiUzE1pMJ9in9gwVEASD9CPBk+SmZ+71gkgeZxcU3cSYt9vH9QnUeT8XSnRTlUXB8ewOaaVwGSXza7k/XGOvv2N7ORHwUc8EG9J/pIiyV7OyLXxOi5RFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=davemloft.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kqlEDE/Dx/7yQ8JuROZJkO568Vsl3m48qQGmsglR9+A=; b=oh1wrGyYdlVi1O+eyhkneBKRE8jROiK2XewB5ePelVuhyssBBpA45YuYHpa3Ny77tFapGx3yEOCXtjpj7AOUqel5ZB3yNTvEcfbUDClwwc5yPxbq7r5m1bBojmD93is8Zjn2khCA4vNAGxuZyfG5xe4P/57CZ603a1OuGlGFPOh+6K9oi1FumbjdtT3kA9S6HLMqRF9p5ZcaDNkxIj1goXXldqsanEIhkgRIyLHeIeVWGtbjkK+fottHn3l0kGcHwv8pWDaeOWYrFYufFF8Xr94XxfxDx5Q50v52ghGhIF7hhGBxp+e3nTia4luqjmtQVwuvhHyD0tZ6QbbCh/qS7w== Received: from SJ0PR13CA0082.namprd13.prod.outlook.com (2603:10b6:a03:2c4::27) by SN7PR12MB6742.namprd12.prod.outlook.com (2603:10b6:806:26e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.19; Tue, 25 Feb 2025 07:27:22 +0000 Received: from CO1PEPF000066EB.namprd05.prod.outlook.com (2603:10b6:a03:2c4:cafe::de) by SJ0PR13CA0082.outlook.office365.com (2603:10b6:a03:2c4::27) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8489.16 via Frontend Transport; Tue, 25 Feb 2025 07:27:22 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CO1PEPF000066EB.mail.protection.outlook.com (10.167.249.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8489.16 via Frontend Transport; Tue, 25 Feb 2025 07:27:21 +0000 Received: from rnnvmail203.nvidia.com (10.129.68.9) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 24 Feb 2025 23:27:05 -0800 Received: from rnnvmail203.nvidia.com (10.129.68.9) by rnnvmail203.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Mon, 24 Feb 2025 23:27:05 -0800 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.9) with Microsoft SMTP Server id 15.2.1544.14 via Frontend Transport; Mon, 24 Feb 2025 23:27:01 -0800 From: Tariq Toukan To: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet , "Andrew Lunn" CC: Gal Pressman , Mark Bloch , "Saeed Mahameed" , Leon Romanovsky , Tariq Toukan , Cosmin Ratiu , Carolina Jubran , Shay Drory , , , , Dragos Tatulea Subject: [PATCH net 2/3] net/mlx5: Restore missing trace event when enabling vport QoS Date: Tue, 25 Feb 2025 09:26:07 +0200 Message-ID: <20250225072608.526866-3-tariqt@nvidia.com> X-Mailer: git-send-email 2.45.0 In-Reply-To: <20250225072608.526866-1-tariqt@nvidia.com> References: <20250225072608.526866-1-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: AnonymousSubmission X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000066EB:EE_|SN7PR12MB6742:EE_ X-MS-Office365-Filtering-Correlation-Id: dff08f9a-e865-466e-8853-08dd556dd7ce X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|82310400026|1800799024|376014; X-Microsoft-Antispam-Message-Info: EZ6NkjbmQdPrEFJk5JHK6Uoqa9S9FrTuqksu0pQDNKaEb+x238HR9YQAtfv3637CY+ov0xxTEO/26Ex0a1C8Q2MNWDWR24fKHX88pIqubOlPgsNWQvBfNd6+cpJwvErqnjFck1YqnNQYx9ykc8BfZLxISKDPTziMi3vqXTkQZ6/nSaJIIeoea8vYbVlNKUxP4LRnhSHU4kwir9MAy4+wQtqshJ5K9Ro1qF8+YTsEuDoyDXDxDYxyUaXPzmb9iuDHQFkJ17iW1mfQREjRahdmtjOnS6VySeG/wd1MAznhmduKfWeTcJuUL/ItmSQPfaRNmMEaf7Iiy92MT1BGfaqmb5otJr5S2cpZkx728p7VQjkozkpqOUo6Y0xtAshtdR1PfHdW63b260ZmXHCMG+wSrSEgFBykprzVdLg/Dv0GBcEAvStyQRaZp/c5mHOAB5vn2QUO0zBDXb5VkzNiSew8g7EeN+JcZVN31ZC4kWYG82WDugDgtERa9ILBJTi/ieGo/Qqay74ATE7RRtWl9HrEoDpNl/PvXdAMZuE8FyT+yX4yLfHU7+ID2/H/9UbR/w2ByYNrhWrwoAc/xfuJnC7fUBRpW+7P3nVsP+4LGitY5Lzzts7RRpWOpGAzkvEsFG8pN9S+1U1nb3mlf3qLcq+QcwanpHlG+1pD90K/Q7btmcx4Px4W06bz4dNOORd53L39V3fA7AyUihDWVsEFjKI/SDdQrzDjLs3vojGbrhm38bUmIphQ4JI5ME7hjKdAZjvIU66xHqj+DPd7S5BdVaioRbUIlJXe38eWoPTN565StZKB3eH0JQnTWsYlna3fmtNBnp8o8ZGFmyTIuXjqlnmTX7JkGa3Z61Acq43VM95wiXJ/DQj+bukOSvaTxfatkTfFpoWmiAr4Es45zyctQg6eXrOCW7rvZDTCsotoHeCYb6qtR/icBaei6XYs8rji+mAmEUBgYg7yaHU0vn8AoEg49PT9rFEkpBPJb9TgGAHw3wNVdrol82fqCRnYL/xZYn9QeDlN1hiUNM40LPAIYWuQQRYRWf1JJj/atWOtZNfCwfuznsLV3sKGa453gvjVZx2gz+vBb5DbOmvtFpbM/RRdErteudn6GNyv0HiW9povQUjZGNHd67ELV6tVqZl/+pC9zkjrPT3NLrwFiO43N8Ufps7eJ8uCVW4ihl4Q246jVtmIxrYBhNzNA6he5Ldg1ot8++WNjYkgZwczJsCDjLrt1pzxdVRMCjepRii+DHeMceDla2JJU1T+rbnnhrYWZKMDuVHuYmq8uhGR/k4+Jp2hOuV4hMgyjdP0AlcVx04G3MX1tBZS8llCpbczklvNTf5Mgg+wQ4qchuirHq6Vpo9Nkr6bit4J0P+1tqL9wQ3EwuKhcnN9ArM1gGfF+sZslWFjJyZRcYS5CHY8nnzw+kbsbggNgbRG4oArpQtdhs1gFimvMmIa3APaUGtsP2m8QaS2WuxhgQI1xnK7qvPQYBsqjnKdaG1B1xzZgAj60ox/3yQ= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(36860700013)(82310400026)(1800799024)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2025 07:27:21.5192 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dff08f9a-e865-466e-8853-08dd556dd7ce X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000066EB.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6742 X-Patchwork-Delegate: kuba@kernel.org From: Carolina Jubran Restore the `trace_mlx5_esw_vport_qos_create` event when creating the vport scheduling element. This trace event was lost during refactoring. Fixes: be034baba83e ("net/mlx5: Make vport QoS enablement more flexible for future extensions") Signed-off-by: Carolina Jubran Reviewed-by: Dragos Tatulea Signed-off-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c b/drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c index 07a28073a49e..823c1ba456cd 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c @@ -564,6 +564,9 @@ static int esw_qos_vport_enable(struct mlx5_vport *vport, struct mlx5_esw_sched_ return err; esw_qos_normalize_min_rate(parent->esw, parent, extack); + trace_mlx5_esw_vport_qos_create(vport->dev, vport, + vport->qos.sched_node->max_rate, + vport->qos.sched_node->bw_share); return 0; } From patchwork Tue Feb 25 07:26:08 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tariq Toukan X-Patchwork-Id: 13989392 X-Patchwork-Delegate: kuba@kernel.org Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2045.outbound.protection.outlook.com [40.107.92.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE6E8256C6C; Tue, 25 Feb 2025 07:27:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.92.45 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740468451; cv=fail; b=HfMXjkBqMkDXGCMu8MWUzInIc8KhEavrD836Mu/l4Tu5OVblTJ4X1R2rgSyEoihdYVbF5bZMPfrOsnt2RU3WvztnDm3PrOxbq3/mf0eYAXoirrxXSpW58XmrAcAuCd2j8p/c3TuY4MwZbEvTORRBD9cdF2G+nwMlyIpBJDY5/lY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740468451; c=relaxed/simple; bh=yMetKcXPDcHJsBe7A73xyunyWpWtwLL80VNGtIqsVAE=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ULF5zXvSC3wwDSBMNBKcCkXKH/JeBURHbdfv8aM30VnzdHninCwI6tySqqAtFjquEZzwESeyPDSwlzEVKn84Hq+UQDOB0dOoXxGG9DjSZVkI68r1tAF9e9h9yTNeDuuxBBkPHsSc1VwBEgleGds9a+5pXwu30OXev514UY46/N0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=p63qY2lJ; arc=fail smtp.client-ip=40.107.92.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="p63qY2lJ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=EycekmC7GMAZBLOM0MD1yuQlWt1kv9yZuX2sgWP7XqjMa8WeyN8aXzskUaI+t0azFkPC6jVJp+BzF7Ci69tMq4H32v6dNHwA99J1bpu4Jhnsheq8pseKSmiAzZZFohaYzAxtJefan7kiTTibVOgwzojpTOz+2gR++ggdMfh+bDwLmp2H0vWy3F+D6MJ0aeNLb8fhBzbWjNxG5DYnEzJ94SrRnDlk+QV/8bjwUhQZ4Rji/5/b8pjTlo3NrW2ZW4S+TtFQOLNqYzyi1nKH8CRZxd0EHxMo4Yr9Ik18ta0Zj3GSeXd7/6hXAYA2j8+GXrSaVz+oBgW3EyOJG/NM/pJUxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Wk/TVLfjamrwMSjoBEyvl5+bo4M8uTGqh4RpN/BLfm0=; b=AU/qq1Iu/FX9NRYu4vwJGB/juEFfKEF+I0WQYkwSk+ldaNBLecqwNG95Ne68+mPWoDHIuxOapmREFtseX8fOi2TUg7J2eJxwYSK/OFjBD5X1TtAZrVDQL6QcNg2tME14aAoDjfj8EKbuPaj9cEaZeQ68ZkYe9IXmL0mCX+lK2OR3sOBl51JemekrkNrkzV1GwIeZ0avlJ9k+c24/5sEBRsts3/XtV2eTpD/dAJagexfbeCUzvoCQg2ePT6fZ+lpArljtJdUwP1aSWw6UPm801p+IckaEyoiuNrIh22EzqOnDpCgFhW2t15tVjzoSLGrJhrdaOWFfNKY7V+wU3CoDWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=davemloft.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Wk/TVLfjamrwMSjoBEyvl5+bo4M8uTGqh4RpN/BLfm0=; b=p63qY2lJyEzjsEqt2iz8DkpdkE1fT46L1O6M36B4yJN5GRfwRMmx4Q5F+VFeh65yvDeqUV4T4kfw2wUwG6ByNfQVq4OSMHIv/PH7Dms5SIDhmWgJ8Ifqk8E659B+GsWvRyVspBDaQL5kmCxbol4/mkaJSj1K3zWNDaYH4FYcmR5X0WWCU7rF1yeO0AJgwslaD/ydzWkl99ZAyl5YcGO0TWpyuZu0xnAnRo+vFnKy5ck0BvueguGJPQdfdcAaextOlYmfjGkzM7kjVImlbtEh1QqVnTEOIactMXFXM9nEDZDXIo7OKFBr+1gpOr2aFYVhfknzICTQtkLKgscMyvPYyg== Received: from SN4PR0501CA0045.namprd05.prod.outlook.com (2603:10b6:803:41::22) by MN2PR12MB4359.namprd12.prod.outlook.com (2603:10b6:208:265::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.22; Tue, 25 Feb 2025 07:27:26 +0000 Received: from SN1PEPF0002636C.namprd02.prod.outlook.com (2603:10b6:803:41:cafe::f0) by SN4PR0501CA0045.outlook.office365.com (2603:10b6:803:41::22) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8489.16 via Frontend Transport; Tue, 25 Feb 2025 07:27:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SN1PEPF0002636C.mail.protection.outlook.com (10.167.241.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8489.16 via Frontend Transport; Tue, 25 Feb 2025 07:27:25 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 24 Feb 2025 23:27:10 -0800 Received: from rnnvmail203.nvidia.com (10.129.68.9) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Mon, 24 Feb 2025 23:27:10 -0800 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.9) with Microsoft SMTP Server id 15.2.1544.14 via Frontend Transport; Mon, 24 Feb 2025 23:27:05 -0800 From: Tariq Toukan To: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet , "Andrew Lunn" CC: Gal Pressman , Mark Bloch , "Saeed Mahameed" , Leon Romanovsky , Tariq Toukan , Cosmin Ratiu , Carolina Jubran , Shay Drory , , , , kernel test robot , "Moshe Shemesh" Subject: [PATCH net 3/3] net/mlx5: IRQ, Fix null string in debug print Date: Tue, 25 Feb 2025 09:26:08 +0200 Message-ID: <20250225072608.526866-4-tariqt@nvidia.com> X-Mailer: git-send-email 2.45.0 In-Reply-To: <20250225072608.526866-1-tariqt@nvidia.com> References: <20250225072608.526866-1-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: AnonymousSubmission X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF0002636C:EE_|MN2PR12MB4359:EE_ X-MS-Office365-Filtering-Correlation-Id: ae415b4e-fa77-4dd4-9e99-08dd556dda1e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|7416014|376014|1800799024|36860700013; X-Microsoft-Antispam-Message-Info: e9pB5gNIFV4Vj3jOIr3mPtG5gdwt0B1GL95VNHAlmWphcQVJRCGYyjujM7f8MULqASmkrdqpLwxfT8d70bke9JQFpK95Hr+JApTAHpdfgVUUuu79YZbhXaotWITJBkv2eUYe8EH8JBcd3Uf9G2lCOwZYMrIMNB8MpAiV7IJx/S7xxJUZMe/FK+JP4EoBRB526eM1Uyhzktol650N+AdexeQMhwL1mXDF6gQyyemwMYXaRUqER5IPWduKHZfpToIC6/AGMb16zkthM0ubOYI4THk/T4YKxCmRlZQCF0DzZhbJ5j6go+LNxzbZA0GHvKpwAV3c6Uv/oTxFgKFa6cihG1yfFJRgfDsTdcmcUGKxKKe3UfUvW4icjaO501H33Q3ntKEnwjdqV3Bf89gxO2Mw1Ni137Yh8mqOuyOKrW49SesJwfF/N9qQjeXH86wFCxSh+e3NmafzYpWPRNmVoWvfAO7zC9ax0tcIeS06CoGhslqfYXygkHBjEK+XetB/LoTMZJxeeIaNZXAbzPulJD6TnP1qVmH8N6ky8DiFZRXpbW+ylPs4P94eH+azLGfInGg8b322r7ulh0PBq2bmoFAxKOQS+NLOKC9mCx4iMUV4zB3GTajspp6mpUtoX59NC9eMAmEbgd08MJCymDoFKOpPU3DU2nIbOXagtJW5NSyA8Qx1m8HUOD0B3lakhQSaURSOfTWqLysK9sNH0YtOD4gGAyYwVaAn3YxLNA63nXWtIXJzUbj1hkB8VckXCWZTN5y2wMxYWNUKJd0NbPPLT52hhnxMgrIzIWfKP/9b/5NTcw/mTOakxOVoibT0MdH5XuU89J1L830+bY0KAwI3Otlt2WZgI+9W0DoaLoy6Or5c8rC1mv07ITobX54RIEehL111+rGkArruuTdmfggp97WeZHjKk3kSS2JiFyVPQlsjpmIV38t9KVj70bPQxi4Xr05Dx9h+jkGRNS7Q53Um1wKoITshK2qHBCDgmIfrB0QjAXxSBSsMGaHYJZ385+5/pbuiqC0T/vXi5CpY99ygiKaahmbqWWLrRIorR+ahM9E7h4ebAJ/1ZYhrXUCnoNWGvQA65lCZfXnCEFk9t4CpJ0VxYJYNEflZ1DDG3ZSyASaR7WrvD1R00N2o8apPvF5xE4MlxyKwV/8RujKqeQ7tairjHx59FBzMkmKP4bo+vIj8NV02JI9wuFnrQH0+hhYFbFZAGkvI7my1Tmtt7SSU3donzG5bVol8esAlbrfO7ffSjnNS3H2+3vg69PCDdnrP9dWx46uRsmaV00aDdA9QHRcGkaWmMwGKPLSZIdpm3qFK6L5O644bPzBly7gKWbbSZ9XanccZ9++6r44fmHfPoWsc58ah2vfUjtAPC/qg5C6WZ+rsW4Lo5QR7/wMGS5jQkqD9aIEnS64GPnwc4sGwUA4y8Vat3bPmSsp9wEdHqp64vKO9fdwUxy61uMWh1Nb1Uvr6nuygGUaFTAN0qhcZ759Vpr3Rt9f0Zv3cAhgVsXBn/yA= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(82310400026)(7416014)(376014)(1800799024)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2025 07:27:25.4153 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ae415b4e-fa77-4dd4-9e99-08dd556dda1e X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF0002636C.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4359 X-Patchwork-Delegate: kuba@kernel.org From: Shay Drory irq_pool_alloc() debug print can print a null string. Fix it by providing a default string to print. Fixes: 71e084e26414 ("net/mlx5: Allocating a pool of MSI-X vectors for SFs") Signed-off-by: Shay Drory Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202501141055.SwfIphN0-lkp@intel.com/ Reviewed-by: Moshe Shemesh Signed-off-by: Tariq Toukan Reviewed-by: Kalesh AP --- drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c b/drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c index 7db9cab9bedf..d9362eabc6a1 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c @@ -572,7 +572,7 @@ irq_pool_alloc(struct mlx5_core_dev *dev, int start, int size, char *name, pool->min_threshold = min_threshold * MLX5_EQ_REFS_PER_IRQ; pool->max_threshold = max_threshold * MLX5_EQ_REFS_PER_IRQ; mlx5_core_dbg(dev, "pool->name = %s, pool->size = %d, pool->start = %d", - name, size, start); + name ? name : "mlx5_pcif_pool", size, start); return pool; }