From patchwork Tue Feb 25 10:40:49 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Naveen N Rao (AMD)" X-Patchwork-Id: 13990055 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 463062EB1D for ; Tue, 25 Feb 2025 13:52:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740491562; cv=none; b=TUuZgQy/UWN0XRzvGduYFAexfo8ArHG4hzHfTFZd+04uOLkdQWKprmoP7ouH7N3cNitevE+lG/Pzv5kURsimj7XiJCICUa8h936kKQ9Sr6W88Sf+kzXXuNH5FdLWuOFdUtQPtP8Mg8ApxPY+Ywqd8yeToQAhbCqvJ6pjSzudm8Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740491562; c=relaxed/simple; bh=dIXYlNSEMwdsW7HhBFNnyBxdxXgyR4yX5aThGpx/xKs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Oh5Uz3Isq8D6RtAsITZwtgwLXsb3gQ6m2qUaB2R+foZ8Sbmzy5grzWsWvvScU2zCHHWTHfwaepasYFPsulb53biO0F3rkOksBRMy1FX5h2lwJrWUuBSdcg143/XB+ctkE9M5/3jPQJQ9TFnznDP7KqYCSBZwSNt+7tKfKDlgKiY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QnGssGnw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QnGssGnw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 33374C4CEDD; Tue, 25 Feb 2025 13:52:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740491561; bh=dIXYlNSEMwdsW7HhBFNnyBxdxXgyR4yX5aThGpx/xKs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QnGssGnwLab5+GpcNUAoAh4FKNcReblmbn5EVhqqCTx+p1aF/LbQAqTcsi8810heX 8z0vYDUSgMM7ef6qVR3c2VMeKg2clwgHo/0BDLxsdP35Vb4ZIm4YnIPIM7HCwyMhgT 1Bd7n1bXE2F/X82G/Oiax+7QTZf7O6r22oRBKkPxcrg0mJcxzcGHuxFNWzWUm2YIqm Em0JnfevDwH9ZybgRiOe3sDEqHjnbg9I+go+d5GJg9ne5JH6B/yaJhXxIfG0I3o3do 1NnCbirdGf29c0W7iRAI9Z4Xj77gHPoyz86vBlBEFmuirCnTb6vm2KwALfys7GtuDu 6bq1sUJsNlSrA== From: "Naveen N Rao (AMD)" To: Cc: Paolo Bonzini , Sean Christopherson , Vasant Hegde , Suravee Suthikulpanit Subject: [RFC kvm-unit-tests PATCH 1/4] x86/apic: Move ioapic tests together and add them to apic test group Date: Tue, 25 Feb 2025 16:10:49 +0530 Message-ID: X-Mailer: git-send-email 2.48.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Commit f5cfdd33cb21 ("x86/apic: Add test config to allow running apic tests against SVM's AVIC") added most of the APIC tests to the "apic" test group, but missed adding ioapic test. Add it. Also move ioapic-split test next to the regular ioapic test to keep the two together. Signed-off-by: Naveen N Rao (AMD) --- x86/unittests.cfg | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/x86/unittests.cfg b/x86/unittests.cfg index 6e69c50b9b0d..8d046e6d7356 100644 --- a/x86/unittests.cfg +++ b/x86/unittests.cfg @@ -14,12 +14,6 @@ extra_params = -cpu qemu64,+x2apic,+tsc-deadline -machine kernel_irqchip=split arch = x86_64 groups = apic -[ioapic-split] -file = ioapic.flat -extra_params = -cpu qemu64 -machine kernel_irqchip=split -arch = x86_64 -groups = apic - [x2apic] file = apic.flat smp = 2 @@ -38,11 +32,18 @@ arch = x86_64 timeout = 60 groups = apic +[ioapic-split] +file = ioapic.flat +extra_params = -cpu qemu64 -machine kernel_irqchip=split +arch = x86_64 +groups = apic + [ioapic] file = ioapic.flat smp = 4 extra_params = -cpu qemu64,+x2apic arch = x86_64 +groups = apic [cmpxchg8b] file = cmpxchg8b.flat From patchwork Tue Feb 25 10:40:50 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Naveen N Rao (AMD)" X-Patchwork-Id: 13990052 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61D0426A0AD for ; Tue, 25 Feb 2025 13:52:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740491549; cv=none; b=YI8xazPcbV9SnSg7cjG2B/endp6CVyS1I8KZTOpFIagqeL1yt+RUOfHyN2oGECkO/9GBCflcaDJCnYvneIeKfLjJZIgEWB0IMhoK0XciG5UC+R6SvPVlFgQfk9N/9kdHbUhZp8jydlqw9ZO4JUcdXtPKjvV38+lPPGMGpRze9OI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740491549; c=relaxed/simple; bh=x10T7/eCTeM0M4xy3rCmMnWyO7UukP7ZVK9yhTioOlg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YHHzeAMi4aWMWgZSxrhTHUxfJwbw6Sxzx0+ftbgiMoNx7wM3YJWfFd/Oy7GJeUvovL27jcTCrLJ+e9eKVAFeveVgEa2AUNxZhmaNPsw/DyrgICcJu0wOaJIbvalUU6xECHXjpI7nO3EP9oZBVG0CjgFCX0Xu8BfJhMXdfj3vIMo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YDQ1aGQm; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YDQ1aGQm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4EE05C4CEE9; Tue, 25 Feb 2025 13:52:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740491548; bh=x10T7/eCTeM0M4xy3rCmMnWyO7UukP7ZVK9yhTioOlg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YDQ1aGQmDiNCd89QjnmHsvF5gbMZMVl371l6VaAoqH9weAnTD079E7AXppihTTtT7 9jc2k5qUD6kBinPLy7Jd2EcW6CibDos384aFCwYdRe6TXiO6x9IyPVVz1zOgM7uG7B XvDtNE4JD964RbwvJ2Y/AcATt5VSm69oqk66Bcp1YlBQyQre9j2V0Y8lBmKGBIkuQK kiGq6RzJmnL6PUpZLEy829C59c7bj8fhWwSSaoXNSkBpjZQdG8dT8ICeg72Hi4vhH2 sSEkln8SHiFVFO6Y0op/7gXkF8pEA8h/t8ky/8fwSbogNLZnNoIKxMCxis6o+gLMJC Pcw7ZM7+gPsgQ== From: "Naveen N Rao (AMD)" To: Cc: Paolo Bonzini , Sean Christopherson , Vasant Hegde , Suravee Suthikulpanit Subject: [RFC kvm-unit-tests PATCH 2/4] x86/apic: Disable PIT for x2apic test to allow SVM AVIC to be tested Date: Tue, 25 Feb 2025 16:10:50 +0530 Message-ID: <6aba109b9ac7e883d00b74d084e58f37acd805e3.1740479886.git.naveen@kernel.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 SVM AVIC is inhibited if kvm-pit is enabled in the default "reinject" mode. Commit f5cfdd33cb21 ("x86/apic: Add test config to allow running apic tests against SVM's AVIC") disabled PIT in xapic test to allow AVIC to be tested. However, since then, AVIC has been enabled to work in x2apic mode, but still requires PIT to either be disabled or set to "discard". Update x2apic test to disable PIT so that AVIC can be exercized with x2apic. Signed-off-by: Naveen N Rao (AMD) --- x86/unittests.cfg | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/x86/unittests.cfg b/x86/unittests.cfg index 8d046e6d7356..35fb88c3cb79 100644 --- a/x86/unittests.cfg +++ b/x86/unittests.cfg @@ -14,10 +14,11 @@ extra_params = -cpu qemu64,+x2apic,+tsc-deadline -machine kernel_irqchip=split arch = x86_64 groups = apic +# Don't create a Programmable Interval Timer (PIT, a.k.a 8254) to allow testing SVM's AVIC [x2apic] file = apic.flat smp = 2 -extra_params = -cpu qemu64,+x2apic,+tsc-deadline +extra_params = -cpu qemu64,+x2apic,+tsc-deadline -machine pit=off arch = x86_64 timeout = 30 groups = apic From patchwork Tue Feb 25 10:40:51 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Naveen N Rao (AMD)" X-Patchwork-Id: 13990053 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02B5C2698A2 for ; Tue, 25 Feb 2025 13:52:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740491553; cv=none; b=LVysOqgv4pO+liHtPoQa54jxb0d/VmGUmG+5EZZSua2Tu9vXq+XmsNdqHxGcEpejmYEXD8UEeCM8ccPe5x+FkDuQ1xmTGa8KjLExrl1QA4bpGi5NnzpEZwVedHBRhGgNaiF4XLJVsDy+ce16klcEYgOpPA03wg269iAVlgFXiRs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740491553; c=relaxed/simple; bh=4M9YtIWRYkhNFPRkpSeuIwBeyPnax1SxZlBHkaST38w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aUSXw9nM+adD7NkytKsUdCQh4IRqgT3w1Z4uodGQ2t2B4xdYqFb2LiiDU+FI6ZmudHAjOq5g86Fs0CstYKN2MAMzemiogT9R2inl5iSw409i0M3RFMHZxHppAwU0tCSN6TWAVbzH7mgCRoQ1r3TNqJdFMg+B8HHzVJ+k/gScF2A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=q8+hFLgF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="q8+hFLgF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 357B4C4CEDD; Tue, 25 Feb 2025 13:52:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740491552; bh=4M9YtIWRYkhNFPRkpSeuIwBeyPnax1SxZlBHkaST38w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=q8+hFLgF20WjqI8XL8yvN9zjDu+E7zvJ/oE50FBtqfrEHvL60Ky3yQJ6qXXKa42jr Z3EI4qy+OuLUzFipEnoR+nWakXQ8PNJ7vpN3gcFvrpVegCdtFD+94fV3FnxS4RPph6 8GI4/ttE/BmZj0CbxPKOMbE5aeyvMk/DnekHSYgyNZlzTPutJej8uPWjX0l1ZG+8/x JXnedqcJwGOA/sJQvAm97ePU4Z3Rj16PHXCryRGVjsZbdIBge6ymuNpSX9ACVPbUKr C0mc45zlu2Hb1qqB06Ziq8Ik7/1ulagnR2/80uo/eEtI2CXYHnmoyUbTUOT3NwSpqU fBf9BR1GHwVtA== From: "Naveen N Rao (AMD)" To: Cc: Paolo Bonzini , Sean Christopherson , Vasant Hegde , Suravee Suthikulpanit Subject: [RFC kvm-unit-tests PATCH 3/4] x86/apic: Disable PIT for ioapic test to allow SVM AVIC to be tested Date: Tue, 25 Feb 2025 16:10:51 +0530 Message-ID: <7dfb12588b6e0a5d91be0bdca4a64b222b5be2ae.1740479886.git.naveen@kernel.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 SVM AVIC is inhibited if kvm-pit is present in the default reinject mode. Disable PIT so that AVIC is exercized with the ioapic test. Signed-off-by: Naveen N Rao (AMD) --- x86/unittests.cfg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x86/unittests.cfg b/x86/unittests.cfg index 35fb88c3cb79..b057b59b1e30 100644 --- a/x86/unittests.cfg +++ b/x86/unittests.cfg @@ -42,7 +42,7 @@ groups = apic [ioapic] file = ioapic.flat smp = 4 -extra_params = -cpu qemu64,+x2apic +extra_params = -cpu qemu64,+x2apic -machine pit=off arch = x86_64 groups = apic From patchwork Tue Feb 25 10:40:52 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Naveen N Rao (AMD)" X-Patchwork-Id: 13990054 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 583EB2698A2 for ; Tue, 25 Feb 2025 13:52:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740491558; cv=none; b=VPwBcI96V7QPdcOup5sKnX8S8+AwVN7HukSceYq90zqv8t6m7wiQ+BQKXkDiRec0uuAJbDomvUrqL++u9yClw0k7sLqUZvbaGudHw6I206n28vMx3BXsz0MaqCDgFOY9wwoJsXNXo7OoPZRKaD4n7VfcWJFLJFVIipMnjG+q2iI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740491558; c=relaxed/simple; bh=04DTe4ZbF8RWqojsW2aRPJDtp4uzdvc7rSSGqG0IRSY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=k+RrAJ3FtXsS3znAhQXc1Vw4HYeW/H1wlIix6ugclVStV6FevkL9k0a2lT2KHTT1hPCpBWE6+c1YdgYVFTXf3wSFdORGTrAqJCYwnrD4Mtlx/TZoliXQCI8CY+BkveWHEq4152XVIe9fMLzueBfiXiGK3WUg409MU0UMcLWC4eA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Npx2DlPh; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Npx2DlPh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E2F4FC4CEDD; Tue, 25 Feb 2025 13:52:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740491557; bh=04DTe4ZbF8RWqojsW2aRPJDtp4uzdvc7rSSGqG0IRSY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Npx2DlPhd/glu/0z/YOMn8lcfICVM3QjzbqvZI2rZi2xEji/1YWBOpBxl4mZN43ir n4KOk/EsS7+e5qpTzFYXyCh2qloZw1rl0un9KdasosqSI2o2gTiSuV2J1Lyp0wLpVx Y/4Wad04CJzUfL0DKBTVN9f4b4rJcB0ZfObKH14hnBHeS8ow6Vv+DJP62D0dPfIq+M 91hPPSwagP1gNIF66cf4sMhTFRc2pYYYzFyV7XvKZm+SBAooOvapQ91w8SP60oBr9R /qcADYdRNROhNYB5qnKLIxEbDJkGx/x4cTwHUhPFhdvWFz6Zlsv2pezX8PVVROrxKx Sege5X/XJUsrg== From: "Naveen N Rao (AMD)" To: Cc: Paolo Bonzini , Sean Christopherson , Vasant Hegde , Suravee Suthikulpanit Subject: [RFC kvm-unit-tests PATCH 4/4] x86/apic: Add test for xapic-split Date: Tue, 25 Feb 2025 16:10:52 +0530 Message-ID: X-Mailer: git-send-email 2.48.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The current apic-split test actually uses x2apic. Rename the same, and add a separate test for xapic in split irqchip mode. Signed-off-by: Naveen N Rao (AMD) --- x86/unittests.cfg | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/x86/unittests.cfg b/x86/unittests.cfg index b057b59b1e30..35646e320620 100644 --- a/x86/unittests.cfg +++ b/x86/unittests.cfg @@ -7,7 +7,7 @@ # arch = i386|x86_64 ############################################################################## -[apic-split] +[x2apic-split] file = apic.flat smp = 2 extra_params = -cpu qemu64,+x2apic,+tsc-deadline -machine kernel_irqchip=split @@ -23,6 +23,13 @@ arch = x86_64 timeout = 30 groups = apic +[xapic-split] +file = apic.flat +smp = 2 +extra_params = -cpu qemu64,-x2apic,+tsc-deadline -machine kernel_irqchip=split +arch = x86_64 +groups = apic + # Hide x2APIC and don't create a Programmable Interval Timer (PIT, a.k.a 8254) # to allow testing SVM's AVIC, which is disabled if either is exposed to the guest. [xapic]