From patchwork Fri Feb 28 02:40:38 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 13995492 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 42410C19F32 for ; Fri, 28 Feb 2025 02:40:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B47DE10EBDF; Fri, 28 Feb 2025 02:40:49 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="SAs4kyOu"; dkim-atps=neutral Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) by gabe.freedesktop.org (Postfix) with ESMTPS id 21B7210EBE2 for ; Fri, 28 Feb 2025 02:40:47 +0000 (UTC) Received: by mail-lj1-f181.google.com with SMTP id 38308e7fff4ca-30a28bf1baaso15906871fa.3 for ; Thu, 27 Feb 2025 18:40:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740710445; x=1741315245; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=21TVA0G0gojITtd03fcIP3wwFgnkOgv1z7AmIqkOOEg=; b=SAs4kyOuhn3FkSYGWDCoTXA5YExzV2SZrMNoDL5raidWrKxlm/0D+1fYYnXaIt9MMK ELZZ5LRCGcKJ9U4o4VLmdwtFT1ZSU4aLYba14RchNlWQb+2UK/bRb/+qe8Y1DARxjqKh tYehuGAR88Zss+B4gysfuDIB3ymKKjacI/8SAc2fpUuqe9+W3KR0xKjuBmtSytdg/4hW lfsA4mRRUj9Ha/FuSLCWXQDyZj02RT9c12eqGyX3roRBr26l5xC3q2tTppfdZVs/hpbp VysKrxpTDPF1NhKMARDw5hdocXAxOjEca1WqPgOlzaqpsXnNE6LtCmhzDL6ZsGgCud3T J6yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740710445; x=1741315245; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=21TVA0G0gojITtd03fcIP3wwFgnkOgv1z7AmIqkOOEg=; b=rpHuSeRAHtQtri9D1xKmDDurY/N1U+MUaNkFUrDgTsqpwOD/ahk//oaEf7kL2AF5yJ AqxzcterLzR9kSyDf8mCtwguZXXOwxZMtXT82P0pt7y+6VX9gC2IUVVkg5SM3TORM6We 9Gs9doWtdYoaicBIQGXHlKltXXoEHuEiF2pNStaio2eY5WuLGVvGKxwF8wZ1ePrWQSY9 QL1rsOLwAeV0cLhXnhw7R1qDggRpriEtuKWhSdd8FAUwn0UtGtaAln2PKQHOcDUQketg u8TkUyZ5HqQn74rweLA7oEDaT/a30KMD4FgpfqaadhVeX0XxMIFuIyZqkWWUGhLMur2t LJJQ== X-Forwarded-Encrypted: i=1; AJvYcCVstq2uEDmVHd27/7l8kHke2XKab+ERN290dHSUfvId3zJmyykBeDdBE4vw2IyTclbv6Cx0EOsR+Jc=@lists.freedesktop.org X-Gm-Message-State: AOJu0Yw29zryiIj2xQU5vWd7Rld3diwM5wEy7jkQNZIFPU2RoRDm4biv xHTdbkn2mcbHRPTrA/RPmxPzpPzhAqW09meuDE8fMsdIZN/SaERwApj217aWY+E= X-Gm-Gg: ASbGncsq10SPkaFEetnLRrAT1RhPl3e++LvDZndaHrGH9CExHqaVCGfQ5MSqYmw1qvE adDZvPvo2OQ2/JKR67P8BSgT4A8Ro9fhPLEy0JD0pjtVBCL8oG3IImPp4a6LGqlUoNWxpEVqBwC J4OGMI+nj2WO81nZPAOSNURQl3GEzHc2wS4EJtROCCPtr8fEUx2lP80+bP+plGKNYKPzmdXK/Ih qV4+F69LOdXzUskvv4IJgKUZPrga1etCPjIaRZSh2KmuLx4V6a9deHthrp+CBCervEA+4wDniOs PrkqyU77MejZY1ZQwDME07MPgVM+/V/qkw== X-Google-Smtp-Source: AGHT+IE7Mky/M2fDSKSULiY34EQmUiMxEjS62GBJfX2zcyCayPQhXRzgX2IA/oB8JS7VImdstOeq7Q== X-Received: by 2002:a2e:be9e:0:b0:2ff:d3c6:9cf4 with SMTP id 38308e7fff4ca-30b93200529mr4213001fa.1.1740710445348; Thu, 27 Feb 2025 18:40:45 -0800 (PST) Received: from umbar.lan ([192.130.178.90]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-30b867a7403sm3493881fa.17.2025.02.27.18.40.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Feb 2025 18:40:44 -0800 (PST) From: Dmitry Baryshkov Date: Fri, 28 Feb 2025 04:40:38 +0200 Subject: [PATCH 1/4] drm/msm/dpu: remove DSC feature bit for PINGPONG on MSM8937 MIME-Version: 1.0 Message-Id: <20250228-dpu-fix-catalog-v1-1-b05d22fbc2b4@linaro.org> References: <20250228-dpu-fix-catalog-v1-0-b05d22fbc2b4@linaro.org> In-Reply-To: <20250228-dpu-fix-catalog-v1-0-b05d22fbc2b4@linaro.org> To: Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , =?utf-8?b?QmFybmFiw6FzIEN6w6ltw6Fu?= , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1513; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=7BzZsMBnZu1h07UISleUgszbH3T6+OpRP/jWCT7kc0s=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBnwSIouiJGhGOZyYTg9iPINN+LzRYzfnPSJR5m8 KuNAd1pze+JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZ8EiKAAKCRCLPIo+Aiko 1cATB/9IAWUW3l3iAA5pqb5DkZfeWKaw/TMntlcwc4Bb6aqNPNgO66bOsVK00C5ogk6vFwOFct4 PnmRtKjTfFCYwEzwXiNDfOq+Ua7F1PmHEuAlCwH5nZGx0H7/N9tuCYrPSA9hmqEbEroie1zHG0s kTnOeXsw9p9puyTdXaGzHOrU/nizHJsXuCuBX3aSAGQmXCeAYXPy7k7HCb3aRqQrSeAsSfg6rYy Td0GRICCFRhTJJ6mQWHO+0IXlXfE5B3fu141VPJ5vs5doAJMkBIq67op4EGTsg7ehQCQB4iTZ9i MIiT1DyLeWTiMoh8f27DcnrTEMaQpbsqCxCxiiVZcih9G4fa X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The MSM8937 platform doesn't have DSC blocks nor does have it DSC registers in the PINGPONG block. Drop the DPU_PINGPONG_DSC feature bit from the PINGPONG's feature mask and, as it is the only remaining bit, drop the .features assignment completely. Fixes: c079680bb0fa ("drm/msm/dpu: Add support for MSM8937") Reported-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_1_14_msm8937.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_1_14_msm8937.h b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_1_14_msm8937.h index ab3dfb0b374ead36c7f07b0a77c703fb2c09ff8a..a848f825c5948c5819758e131af60b83b543b15a 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_1_14_msm8937.h +++ b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_1_14_msm8937.h @@ -100,14 +100,12 @@ static const struct dpu_pingpong_cfg msm8937_pp[] = { { .name = "pingpong_0", .id = PINGPONG_0, .base = 0x70000, .len = 0xd4, - .features = PINGPONG_MSM8996_MASK, .sblk = &msm8996_pp_sblk, .intr_done = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 8), .intr_rdptr = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 12), }, { .name = "pingpong_1", .id = PINGPONG_1, .base = 0x70800, .len = 0xd4, - .features = PINGPONG_MSM8996_MASK, .sblk = &msm8996_pp_sblk, .intr_done = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 9), .intr_rdptr = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 13), From patchwork Fri Feb 28 02:40:39 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 13995494 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98759C282C1 for ; Fri, 28 Feb 2025 02:40:54 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A98AB10EBE8; Fri, 28 Feb 2025 02:40:50 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="bTO9if2B"; dkim-atps=neutral Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8820B10EBE1 for ; Fri, 28 Feb 2025 02:40:49 +0000 (UTC) Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-307d1ab59c6so18219141fa.1 for ; Thu, 27 Feb 2025 18:40:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740710448; x=1741315248; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=vOGs6Fa6zuHrhwyPIl+nFTAKnbOoAu0XxgAk7bsGnFo=; b=bTO9if2BLgCZJO8/x5LnH/lR8k3BhLX2ZdSBPQqOI9aY27sFtQFwNGxk/9dxIHIzBy 1pvdmKOIwlJV5ZbI7zrK7cKR0QUzgatQ9MAytmTxPDUf/r/e6mQ7HIH7A5wKki7EO+yN sBkFbliEp/bXkuJJ8JNYAe4ABVJqPWXS7UmbmmFHVyAiTBONKX7YkiXCT4MrbD/d+Xkt XXSAW7H62c2f0DqflHeF89HXAeb3Wifh4Zon7ApOhiDzpAX9PActZjOqR7dwKkKDA0Hp RGqBYj0cGokEOpfemfoRmoplu8ZOWqh90/G7h465gHDY2ibUHiNsoTwo/e+wXTBAmXc1 XLTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740710448; x=1741315248; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vOGs6Fa6zuHrhwyPIl+nFTAKnbOoAu0XxgAk7bsGnFo=; b=dcZK/ikZoNMYaWgztf0ZjFlTHZ7T5zFBmpyfNV2hqoPIcEihDLx+EUor46rdMXWZmF M8B4J0e08RtKMCbBQ0eHy7SohzolONYSEuLfeLPNGDyJrBSNEQW+tbShzTrWcQ3DR75q wBm/cL0GTyUkPX64ibL7q+0r5XJHbVij6WhJUcSkWP50TeYqAx1tT5WAFFq40hC6kxrX 7TNUmpUGA7JSOu5wc7cdjr/NojrWtw/Q9rdKREYLjKpNbTF9QHgoPudg1DyPkyMrjJLA V0A2hkH4GZ31QHVdTjoptfsDjjOkWP9Bu6hDTvU8EocnzBzZJagWt+JtjsKFiwloZh7W PIRQ== X-Forwarded-Encrypted: i=1; AJvYcCWO2jfuvzaUFvkCniJ9xijLYGcFO4vmMoI5qtzhFF6Cv8/6bQ0Ct/LtblKAtbtP1iwfHwdCVxXfrZs=@lists.freedesktop.org X-Gm-Message-State: AOJu0YwagLnlqHj8QnzYcT5S+S0c+KkWIYWckUEJ0ptSdC+UHWrUNPMn 8wc83kYXZxDCg/tsdzSmgnH3fYwMaPDjqnVpGFd7uOlbSn+/4R9b6ZJbNq+Weu8= X-Gm-Gg: ASbGncuKH+V6t5VoRLJpNky+q1ZyjD+QpN2Kg1pWaYlqmL4TfEBJIMsnSAFLCZCMN78 AQ73HG+pLIXpKFWm0iLcOmj93nrwg77E5YX2yA/nPZY1YRQdcuaMjPRqQrb2TfbIm19v1Z1T0Un AjF6OUfS4LZJYyLEFpzXRug3VrxY68O6janPa1WGFr4DQ5XT6dJos9je7FyMxGytX9OVOuUxbQf x+CdZy7wiShlaBgR5ByKKRUZfUxRrl/mFSif3m38mQQU2IqrL80LGIhQjsT57A/xiLnJ/OUMC9z fwE+zCM3c6Y08bDMTSZyuzfbCMKEQoAFwA== X-Google-Smtp-Source: AGHT+IEB4jROCc8fnBy3MSZrW9RzrxCaLFObuJxsi615v2WW4DWyQ2y9erjQd2zzlfZt4HWqNT73Xw== X-Received: by 2002:a05:651c:e07:b0:30b:9813:afe1 with SMTP id 38308e7fff4ca-30b9813b4eemr801181fa.25.1740710447809; Thu, 27 Feb 2025 18:40:47 -0800 (PST) Received: from umbar.lan ([192.130.178.90]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-30b867a7403sm3493881fa.17.2025.02.27.18.40.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Feb 2025 18:40:46 -0800 (PST) From: Dmitry Baryshkov Date: Fri, 28 Feb 2025 04:40:39 +0200 Subject: [PATCH 2/4] drm/msm/dpu: remove DSC feature bit for PINGPONG on MSM8917 MIME-Version: 1.0 Message-Id: <20250228-dpu-fix-catalog-v1-2-b05d22fbc2b4@linaro.org> References: <20250228-dpu-fix-catalog-v1-0-b05d22fbc2b4@linaro.org> In-Reply-To: <20250228-dpu-fix-catalog-v1-0-b05d22fbc2b4@linaro.org> To: Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , =?utf-8?b?QmFybmFiw6FzIEN6w6ltw6Fu?= , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1244; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=AHlIDMaamS4Q911Ji55qeGiDjSSjpx7O5PqZx+FIb8k=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBnwSIo7NuSbAFeNFO1NY+RizSOKgHJrrMgQz/BM XWFEbzrn0CJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZ8EiKAAKCRCLPIo+Aiko 1Q9yB/9Isl5/jVjtfyVK1130CUffh72E0EfipCMgeU8T2V/cUd/oht19i47Bklr9nLRGpZgr0QF nhI5oaX2BJowBZ7XVBBL46P6bSfq7TwhGC0DrGEvNK3B9LHLnQOAdgv7wYlUqjVhqK29uQEwE5/ JJi/sefWmvVpPkWxytK+0EhNUbmF5UyfG0ADicerAHsoIy1s5QIBWruB3KdrnqsC5r/qU2j6R4m OdJs/X0VWXZRxsHn7psLQ9Q+H4INkAUvLxYhtHMHRQt0uwlxtkDVFzs2iBcWmIv6w9LROVF+Jq8 C/JtiYINhX+7199v3tqxSZaCU1G2USuXFqjGQffzH+WkMPGY X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The MSM8937 platform doesn't have DSC blocks nor does have it DSC registers in the PINGPONG block. Drop the DPU_PINGPONG_DSC feature bit from the PINGPONG's feature mask and, as it is the only remaining bit, drop the .features assignment completely. Fixes: 62af6e1cb596 ("drm/msm/dpu: Add support for MSM8917") Reported-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_1_15_msm8917.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_1_15_msm8917.h b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_1_15_msm8917.h index 6bdaecca676144f9162ab1839d99f3e2e3386dc7..6f2c40b303e2b017fc3f913563a1a251779a9124 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_1_15_msm8917.h +++ b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_1_15_msm8917.h @@ -93,7 +93,6 @@ static const struct dpu_pingpong_cfg msm8917_pp[] = { { .name = "pingpong_0", .id = PINGPONG_0, .base = 0x70000, .len = 0xd4, - .features = PINGPONG_MSM8996_MASK, .sblk = &msm8996_pp_sblk, .intr_done = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 8), .intr_rdptr = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 12), From patchwork Fri Feb 28 02:40:40 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 13995496 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 67D08C19F32 for ; Fri, 28 Feb 2025 02:41:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D290510EBDE; Fri, 28 Feb 2025 02:41:03 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="NBdmBb73"; dkim-atps=neutral Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2A33710EBEA for ; Fri, 28 Feb 2025 02:40:51 +0000 (UTC) Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-30918c29da2so17735321fa.0 for ; Thu, 27 Feb 2025 18:40:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740710450; x=1741315250; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ivKSxnQ8DB5AtKJZbKFIHtIat0403ancJcDyUvz/X6g=; b=NBdmBb73jLoeDLSoifkXmO2/Zi/nF06vih0noJxLSZhH7r99v+EYWcYJK543J0Kto/ YS/G6Ru3raXiAYDtLSlynwLsNkdqkWTqERBnVDztr+G5NxZQApFN1MUgO9BJIkaXbEvZ eDuOVGSerc14IbDInIJH2w8bGu1r32IBQrok+YL60fgovJBhYda6D0K9+sjeH8uxd4VA DunDinCOXxYSyhGUbEaaBPfIbdbeFylPofbgigrNsF/mKYOD9UhtFlg7d7jYyKgEAS0m NNRJf3WYUErbAoLCKkoqe5osCkn9aOO7ykrPO1XkcHtUII1TR9VoSjGAoWcFj+o7GTCk 8wfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740710450; x=1741315250; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ivKSxnQ8DB5AtKJZbKFIHtIat0403ancJcDyUvz/X6g=; b=Zr66ywtQHu0aXnlEVpjZNbgB8ojetWs6C40HgyW7tKij6n9LTw8G5yBLdM+t99bKuA W1IdI7Vv3S/+N3YAHBywGjhh5ODu78gfvyyWnR2seUH6/0PB+fPl7+MP6kwy/w0UMmiL zPLGsEt8wocxIwf/bSJaTTSZbXBk1yuqj38vvNtoQQpQOe+LLlwsweP59XV7rjwjmc/0 +wkNYcvCUv9MqBEu2kkci84aLM6Vh74C9OP2yN+xThmjJKJnU9n/AlCeYkADsvZynZnZ QYSU65IPtrc4KfX7sSdC/gSAdrygRrrJsU9CMLhKY+38pQGBfr+wDVOWoiryTozaTS0e sgdw== X-Forwarded-Encrypted: i=1; AJvYcCVReIuMtL8ARhhzxUYlaUUo51mR1Ss5noK6E0rDK0aMBcZp3wvGTE8snaF659vcqFZKx80wYiDc1DM=@lists.freedesktop.org X-Gm-Message-State: AOJu0YzD091yFCKiTVyAFX9i1d8KnvIx+LQ45yGl0rw5lxKh0PuJEB7n KhSJtsd8/x7DBcUjPJ0yyDvsTzFHLPRQS85IbnxfEBI5WI0lNzAYq6gB2T+RHbo= X-Gm-Gg: ASbGncv9+acSSYUCDfHZPIZwXqakEKENRbqpAZdZLwSOP1ha7scI9iL4XaaWB11D6fw IVe1TFiAlpgT9QwWUdAuq72cXfKxElwo9r19o2a+COGH7ruG4U1lgCym0ONzCQBo+EdTdDb9TjB 7+WX9hF84GHQiS8vm7UAGcjGCmftnaXoNmOooe9XYmuKNtisu8B1cSTu0+Yko7xOWYwc3bCGnM+ dKgoMgiIYFn7fvCT/3S+ZUzRAIw8wg/KXcAy/7xckrGRhPSaHjxrXbukXaYZvOFFOJQ9J89bSRk r3Z76QY0JNTpverxvaDlBsblvYevo7J+pQ== X-Google-Smtp-Source: AGHT+IE/VW7ZgoJU2q0xpHj7pO/LeLZ/mYSQfo8wBTmKbg/dVc3r8HWfV/LWuQdxsmOFJYHvOL8c+Q== X-Received: by 2002:a2e:97d7:0:b0:307:46f3:4e92 with SMTP id 38308e7fff4ca-30b9330f002mr4041901fa.32.1740710450233; Thu, 27 Feb 2025 18:40:50 -0800 (PST) Received: from umbar.lan ([192.130.178.90]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-30b867a7403sm3493881fa.17.2025.02.27.18.40.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Feb 2025 18:40:48 -0800 (PST) From: Dmitry Baryshkov Date: Fri, 28 Feb 2025 04:40:40 +0200 Subject: [PATCH 3/4] drm/msm/dpu: remove DSC feature bit for PINGPONG on MSM8953 MIME-Version: 1.0 Message-Id: <20250228-dpu-fix-catalog-v1-3-b05d22fbc2b4@linaro.org> References: <20250228-dpu-fix-catalog-v1-0-b05d22fbc2b4@linaro.org> In-Reply-To: <20250228-dpu-fix-catalog-v1-0-b05d22fbc2b4@linaro.org> To: Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , =?utf-8?b?QmFybmFiw6FzIEN6w6ltw6Fu?= , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1513; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=Bwi+iwgQ+Rb+/es8x9Up9adCN7AKO6f7tRpJXs0LvbM=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBnwSIot0dlLqcggIIEO7ccmseCO13JHyvnyniPc KESL6DNx4mJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZ8EiKAAKCRCLPIo+Aiko 1TM3B/9mVqc0uvziUX3Tfx76243xUbsqYZITOi2QiWPJ1rY12KtI28dI38UK6LtJWufHmCVOv6U K3AteEANOCQhfsWEAcc2X5OoZLxbhOC0PX5mWxhIa1fBooxOZ3qJ0iTaAvLiM3N4eMfpexuwqKQ PiYlKCoUFOrBG5pX6W8t3ttXhit7FqPVEl306MqBHnMqsFPpLiBkkXxgGuSJN/xSFooM1RyAyHf oYvC6CZso81Yl2LlxQUj9SRozPVfA0EWn3N95cWaO7sxGhw26E0x1MWmFvAroeaQoSOOeiq8PGm +hajaiNPw/XEAxGFtru1VBOvp1FxPigWInofMvhvbmctpgb8 X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The MSM8937 platform doesn't have DSC blocks nor does have it DSC registers in the PINGPONG block. Drop the DPU_PINGPONG_DSC feature bit from the PINGPONG's feature mask and, as it is the only remaining bit, drop the .features assignment completely. Fixes: 7a6109ce1c2c ("drm/msm/dpu: Add support for MSM8953") Reported-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_1_16_msm8953.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_1_16_msm8953.h b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_1_16_msm8953.h index 14f36ea6ad0eb61e87f043437a8cd78bb1bde49c..04f2021a7bef1bdefee77ab34074c06713f80487 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_1_16_msm8953.h +++ b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_1_16_msm8953.h @@ -100,14 +100,12 @@ static const struct dpu_pingpong_cfg msm8953_pp[] = { { .name = "pingpong_0", .id = PINGPONG_0, .base = 0x70000, .len = 0xd4, - .features = PINGPONG_MSM8996_MASK, .sblk = &msm8996_pp_sblk, .intr_done = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 8), .intr_rdptr = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 12), }, { .name = "pingpong_1", .id = PINGPONG_1, .base = 0x70800, .len = 0xd4, - .features = PINGPONG_MSM8996_MASK, .sblk = &msm8996_pp_sblk, .intr_done = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 9), .intr_rdptr = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 13), From patchwork Fri Feb 28 02:40:41 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 13995495 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D73F6C282C1 for ; Fri, 28 Feb 2025 02:41:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6071D10EBD6; Fri, 28 Feb 2025 02:41:03 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="o3QhBtTo"; dkim-atps=neutral Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) by gabe.freedesktop.org (Postfix) with ESMTPS id EF7C910EBE5 for ; Fri, 28 Feb 2025 02:40:54 +0000 (UTC) Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-30a3092a9ebso17614851fa.1 for ; Thu, 27 Feb 2025 18:40:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740710453; x=1741315253; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=C0drAA2PvbJ4hUCTdzmpW/pfB1rIMSFKchoim7lWctY=; b=o3QhBtToUs6+JdVwvC7dsNTqCh39JdQAWmK2obJuIwZ1Cosi1mSePiNw6qLbCdcMnk e1Lc46eiZnM+fg6itKCJNgFyrHOOE/jPF8umcV9785cUKPXpzhSyTC9dvGrwpdUKjFKS c/xWtXgA9V3vzZ7qE7ocj6F4Iszu41R+yEeKIXhmw/CY6Pw6qVXike9Z6zAJ5QzxySAJ L0Mn93rdok57YL69Tgs7u74OobSS0rTX3BUpscv8p4RxN7rJR6rzm2cwvN1CfS+TLANh Uq4TY67vCfTgFEcXtK/UsOlNB+JbpgZNtI48U5tn9seGYbvamxNjPCMr20k3qZy7G6ya lSkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740710453; x=1741315253; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=C0drAA2PvbJ4hUCTdzmpW/pfB1rIMSFKchoim7lWctY=; b=DsftYT0Ijgmth4zp14yP+plaYaXr6UMJMWExkikukEvw8Dh75lv4sj8bXHFmECuX7Q yNcSNAdjlVdRS2cUch1D90nsOsUHHq14vVUzEcArEAHkKxeU5AgW24tozWWT/VsxnPTj Ibt+qCP4AhsS80QkDWCT3jYuMZhnk0m+3sV2kUN15tQB3qAEYVVrAQb4eoz1ZCG5mmsb ucXX7nJK3b4pC7kDEP4KO+W6ws1BhT6ad8sFLKB/Gv39h9+gcrxDma/qKaBsM0FsG/XN 9DEgRcnvVCUELdbwUqlxhLJzR6EAxw63vyzs9LvOB71E8JyLCisbe4QZrTjbtS+979d9 AeIA== X-Forwarded-Encrypted: i=1; AJvYcCXOPET9NLQmcD0IO6T+BOpqUVNIRja/SJbtaiAvMNcIPtiId+0Q46evprY9XOZCxNx96P335b9jxyU=@lists.freedesktop.org X-Gm-Message-State: AOJu0YzFtg8BXLXXJlq88sBykGx2YkchvOV14WXIw6Axkgnl3Lf0ClI5 is+du/7WVyRQNW8SXbQjT/7UdjrmgRMvOQ0+VHqANxXNDPZ2qZhqQaTEkDAOt5I= X-Gm-Gg: ASbGncsO99mY2oNO2UCMFtla9FRgWeBScNaSWVTOBrvjVsiP5nE+QREmopy/YtWr+Lg jVRiUpTLeOd9I6JFDk+qFEhXnfy71SN2ZaLpZGOm+JhSszBhw+Q2nQHmVE3+IoWfDAaco+SiWrj 66hLLXjTDqxuDaYmyu3zsPyoZPr0P39q+3qC4tRaAVLx1VdCFLHOysZLdFnMJGcWf+XNorFNwtP 4AvrOEv3REt1lY+hKNTDaVFg40tBsOjNl4avE9Cd3hoTzwAxjJnXdDbIb26/cXDTBjnYzXcDMid cMiBPSwKH1bXdWYplHr8CwKaQAOOGvD/Yw== X-Google-Smtp-Source: AGHT+IEyA6OYswRzZk6KES4gyk4YksuY5o9aOh5bM9ecrpKh5LG64AXf+j9DZx4ELbV5JDnuU1skDA== X-Received: by 2002:a05:651c:b0d:b0:30b:8de7:c877 with SMTP id 38308e7fff4ca-30b932f27f5mr3782391fa.29.1740710452656; Thu, 27 Feb 2025 18:40:52 -0800 (PST) Received: from umbar.lan ([192.130.178.90]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-30b867a7403sm3493881fa.17.2025.02.27.18.40.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Feb 2025 18:40:51 -0800 (PST) From: Dmitry Baryshkov Date: Fri, 28 Feb 2025 04:40:41 +0200 Subject: [PATCH 4/4] drm/msm/dpu: remove DSC feature bit for PINGPONG on SDM630 MIME-Version: 1.0 Message-Id: <20250228-dpu-fix-catalog-v1-4-b05d22fbc2b4@linaro.org> References: <20250228-dpu-fix-catalog-v1-0-b05d22fbc2b4@linaro.org> In-Reply-To: <20250228-dpu-fix-catalog-v1-0-b05d22fbc2b4@linaro.org> To: Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , =?utf-8?b?QmFybmFiw6FzIEN6w6ltw6Fu?= , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1666; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=5ERbWujSiKto3U+OO7RC5nldxvAV3Xb1FsVd/34DI+E=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBnwSIppBKKZZWahn5Gl8puGu+J1APz0T7Ew7c91 NvB4zUOR9WJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZ8EiKQAKCRCLPIo+Aiko 1eomB/kBscyXJstvxO1FfWarKxnLaj7+/cQqdJ7b2BZA4oKjEbWHt2gFNgSYoHv7kOWYpUX11BW GOEP2C05FVnfyF6dAFFx0mebAYSL3KQGKruZ5UmU/fXl3oAMzp5l3/H8Wav17TR+3S6eREXFEUX P6EYdVUAY+SIMsvoVXjsm+MEfBEe6hrDo6xtWeHDslnkniKMMZ8W6mfbNjXmaYMRafQtpOPTg+9 EzqgYx/i//5cMR3KYNmfD8xzFYv6b1AjfzxcKEYahT3njHxlN0xubMbY9xyrNbULC769joFbum5 2HMO77CtKfK4Aaxm3utxQUGoihOPJq58CCHDcD12f+w5MiYE X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The MSM8937 platform doesn't have DSC blocks nor does have it DSC registers in the PINGPONG block. Drop the DPU_PINGPONG_DSC feature bit from the PINGPONG's feature mask, replacing PINGPONG_SDM845_MASK and PINGPONG_SDM845_TE2_MASK with proper bitmasks. Fixes: 7204df5e7e68 ("drm/msm/dpu: add support for SDM660 and SDM630 platforms") Reported-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_3_sdm630.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_3_sdm630.h b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_3_sdm630.h index df01227fc36468f4945c03e767e1409ea4fc0896..4fdc9c19a74a0c52ae502b77fb8697a53bef0f97 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_3_sdm630.h +++ b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_3_sdm630.h @@ -115,14 +115,15 @@ static const struct dpu_pingpong_cfg sdm630_pp[] = { { .name = "pingpong_0", .id = PINGPONG_0, .base = 0x70000, .len = 0xd4, - .features = PINGPONG_SDM845_TE2_MASK, + .features = BIT(DPU_PINGPONG_DITHER) | + BIT(DPU_PINGPONG_TE2), .sblk = &sdm845_pp_sblk_te, .intr_done = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 8), .intr_rdptr = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 12), }, { .name = "pingpong_2", .id = PINGPONG_2, .base = 0x71000, .len = 0xd4, - .features = PINGPONG_SDM845_MASK, + .features = BIT(DPU_PINGPONG_DITHER), .sblk = &sdm845_pp_sblk, .intr_done = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 10), .intr_rdptr = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 14),