From patchwork Tue Mar 4 14:35:58 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 14000849 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96CB5277035; Tue, 4 Mar 2025 14:36:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741098968; cv=none; b=qCEjPBCn4d+9riKqD9aB9TYzoAoRCOVu8KOY/IFmzGUl7CoMp/1HIHc/27Lrzc3PXUzFC/+2VwZOz72971NVh/Zd3iNHb7TPnWtwTAB8UXmFp+CwBbcJ4qIGOLntMerxhBWGCJCisHKd7l7gMB6CxThBTi6+bYp5oivWCgluMoo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741098968; c=relaxed/simple; bh=cxAHcKn3pjMzcqMsPbIcMtnWuN6ttXQC0+V/fkbmKvQ=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=KhD8/dw6HFmoxWRDeEHNRKGwIN47AX+nDfU+I/CDWXghPFODtGoiDFfg8fi/oWM9wAvdoPr3WJ+MQvle1z4mp7BsrogCBjkIOGU4TUluScdmRGJCTkEPox9u2l8s9GsGjh/93AS+1iUV8C064q9k0xSh8iP/wCYt08a0vgeMV4M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Ud6yEq5m; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ud6yEq5m" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A992CC4CEE5; Tue, 4 Mar 2025 14:36:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741098968; bh=cxAHcKn3pjMzcqMsPbIcMtnWuN6ttXQC0+V/fkbmKvQ=; h=From:To:Cc:Subject:Date:From; b=Ud6yEq5mfVrYRwCmVwBJFAvYm8IltOAiJpTsxkTEiOYRE+uWDkrMs2RfI0KWQ8wrc UNeiBIlohenNoHU8xHMU+Uvt/LspNi8+jZ1L8UfV6QlYxKT8b50fh2xneXHSkITqqT 5cfw612VG2efzL1hKWtdJZi/mA8fbyw6kw0hW6jFQegx9t7dANi2rwH/+wuBjcxj1Z dIbb7KW3MX2kstip183XraPRL1iuWnzUx2reYHpYWeiD9oz10/JeYUx5OSJ8p/Upg6 arFUETT1VglWZkDDGtdeJEFN7kj4t7OwoZdo3ORAqq19eVuOIO/uNLJl8wUUOzHbME xferlzQb5QSPg== From: Arnd Bergmann To: Borislav Petkov , Tony Luck , Fan Ni , Jonathan Cameron , Shiju Jose Cc: Arnd Bergmann , James Morse , Mauro Carvalho Chehab , Robert Richter , "Jiri Slaby (SUSE)" , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] EDAC: fix dev_set_name() format string Date: Tue, 4 Mar 2025 15:35:58 +0100 Message-Id: <20250304143603.995820-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-edac@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Arnd Bergmann Passing a variable string as the format to dev_set_name() causes a W=1 warning: drivers/edac/edac_device.c:736:9: error: format not a string literal and no format arguments [-Werror=format-security] 736 | ret = dev_set_name(&ctx->dev, name); | ^~~ Use a literal "%s" instead so the name can be the argument. Fixes: db99ea5f2c03 ("EDAC: Add support for EDAC device features control") Signed-off-by: Arnd Bergmann --- drivers/edac/edac_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/edac/edac_device.c b/drivers/edac/edac_device.c index 16611515ab34..0734909b08a4 100644 --- a/drivers/edac/edac_device.c +++ b/drivers/edac/edac_device.c @@ -733,7 +733,7 @@ int edac_dev_register(struct device *parent, char *name, ctx->private = private; dev_set_drvdata(&ctx->dev, ctx); - ret = dev_set_name(&ctx->dev, name); + ret = dev_set_name(&ctx->dev, "%s", name); if (ret) goto data_mem_free;