From patchwork Tue Mar 4 15:37:53 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Michal_Koutn=C3=BD?= X-Patchwork-Id: 14000982 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD16A28368D for ; Tue, 4 Mar 2025 15:38:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741102725; cv=none; b=B+cTxVVpUiMuNcW/fHHFPIvTAcToPKpWOVb3u6XSPkdP+vAhqwSNNSF9sM4MCca8xwhcQG4ysOwiygqq1QDD47m0aARj3OEjbMYgZZkCYQKxtZSzFuFItWrED322RZhkW30u+qQcxd+m4mcVQF6ZtQ5Olq5NV9maV5sTbFdsQsc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741102725; c=relaxed/simple; bh=n4HhF0iE5d/zFnVCBm46vTJrbP1QNpIud73Lm3o314M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=MtYJ3Oae0OR/MTkeTJlTlWNdyNI8JtJbUBZQURLRawm5Bqh+H65iVKqZgTukbUmarjEIbCbSIE+1hC2Y3vJ4YVvH5GmXgvCc79jWjH09DRZ1uVIDYuXINBCQ2dD6OjdVXKbSCfUBBUb9l5UmMjHiMNuo7HKxn3IDOJ6dqmsxQhw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=O5Gbhjvy; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="O5Gbhjvy" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-43bc30adad5so15268435e9.1 for ; Tue, 04 Mar 2025 07:38:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1741102721; x=1741707521; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bDY1B2OgIPZSJkU1XkPMYSxsKEiRbouQuwYY7R8HO+0=; b=O5Gbhjvyz1AbPH2XY5j8usKVLea3mIH8afcb1jSDErxdguD/2ZgCi9YaQvXRXJU4nS c/hG42fQ9ixjctO6Ae+Nx69F0j7DDfE9YTp3gf3aVKTUC4fJQSofvi2/O7QAJgZtC9FY 8BCC87kqSq0GyYbo3EgH5jrnGsGSli/8Jo3UVgbhf+G0012VnwLXnz4W48rj9Nd/42ug wS2JidLH+p8Ug97ruqcBc06XyRAbMZg80jXtVfhW4CxmWlkadtmSLWm1sxr/b/9NUQrp GvYt3IVOaqcpjYCdG7JrCdazwg6cxBWA/rFnEnsgZ80W+dSuKSSVgJxO6raVRsRhozlc dGpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741102721; x=1741707521; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bDY1B2OgIPZSJkU1XkPMYSxsKEiRbouQuwYY7R8HO+0=; b=lNOzA2LwyFV0J/bCPvhVDK7WUDI9gSDuD1tYKYKyIMXJvrp/VxN/0jv0K0ubHjPpeA 6zEfR3RmKxflw+E8Ai+viABWKhuIDjHU34qy+P3mYGKowvofLsAf6SDgwMtmDpgYq1wc w+JcsJrXvvx7ZWIon24PbwCcgOnRDnvCleM43La2l5XyRI3wVoSlUj3QmjivRHP1a7gJ iq8ZY0xIq7M7YoJeeTAKW2VtJ23pnEnYFchwo+PzcZCJPyUmCflQNAjznNS9pRR40all vA3GKcpF9iIsLaSfAYNmWTXB3ReiWS3Nzbiy5jtWhbVYwqpr1UCTM/o8sJ9u9b70eHmM j/Dg== X-Forwarded-Encrypted: i=1; AJvYcCV17GCPDMbMM2WQ1/OHnKIrb3HNZpK4uNf8wubcDHgwdXhnOp04A3NQpFen8a6ciBqUWWW41OWoqYHxNw==@vger.kernel.org X-Gm-Message-State: AOJu0Yxi/1AGvfDp26eJ3RwBQWCWccdGKL9Wf0azA8EFcurw0vjgeb74 Wyv40lxo2UxROCiKqNmTyrko8+c9N8wPJUowFnm8U1D8NPTeEms+t4ECoRnWAGY= X-Gm-Gg: ASbGncsecB5o/bmYqoqaorbBeLk8/HlTJwVKVo3Ur3JdfcOwQdkBzHjgQPmi5z/ZfFn zXpfv6nqQzZL3exAoYJHbxfWnJRNQL3KeG+O7sEUpdK7FuvjlGDO6WpZHcmma6yQ9hBMdLd8C9q SIbzBiO4Zv5aeRYJFgjahEgSXWRn8G2J+8dYbvrkg1SsqD5HHZUrrz+7wkFe7bD3YDEiobJdXVq L1XGHXyjJkeUjbNCMrOgYa4ruB52kZQagIa+pYHkqZ9GMDYPBQYZBt+Nnu+UX9h9HDRIH23GS1c VU8focauqX98ll2Sgjs6Me8iZZ3p88d7zH7T5/gGu1nBrI8= X-Google-Smtp-Source: AGHT+IEK7jyhUNwdxioelGYxeSf+GoJMffZJrLOw6owQIFfGVyUvngoXcwDOhtyH+GDoI3MOes9CWg== X-Received: by 2002:a05:600c:4685:b0:439:9a5b:87d4 with SMTP id 5b1f17b1804b1-43ba67047bemr148306905e9.13.1741102721047; Tue, 04 Mar 2025 07:38:41 -0800 (PST) Received: from blackdock.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43aba5710ebsm238670625e9.26.2025.03.04.07.38.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 07:38:40 -0800 (PST) From: =?utf-8?q?Michal_Koutn=C3=BD?= To: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Tejun Heo , Josef Bacik , Jens Axboe , Johannes Weiner , =?utf-8?q?Michal_Koutn=C3=BD?= , Waiman Long Subject: [PATCH 1/9] cgroup/cpuset-v1: Add deprecation warnings to sched_load_balance and memory_pressure_enabled Date: Tue, 4 Mar 2025 16:37:53 +0100 Message-ID: <20250304153801.597907-2-mkoutny@suse.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250304153801.597907-1-mkoutny@suse.com> References: <20250304153801.597907-1-mkoutny@suse.com> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 These two v1 feature have analogues in cgroup v2. Signed-off-by: Michal Koutný --- kernel/cgroup/cpuset-v1.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/cgroup/cpuset-v1.c b/kernel/cgroup/cpuset-v1.c index 25c1d7b77e2f2..3e81ac76578c7 100644 --- a/kernel/cgroup/cpuset-v1.c +++ b/kernel/cgroup/cpuset-v1.c @@ -430,12 +430,14 @@ static int cpuset_write_u64(struct cgroup_subsys_state *css, struct cftype *cft, retval = cpuset_update_flag(CS_MEM_HARDWALL, cs, val); break; case FILE_SCHED_LOAD_BALANCE: + pr_warn_once("cpuset.%s is deprecated, use cpus.partition instead\n", cft->name); retval = cpuset_update_flag(CS_SCHED_LOAD_BALANCE, cs, val); break; case FILE_MEMORY_MIGRATE: retval = cpuset_update_flag(CS_MEMORY_MIGRATE, cs, val); break; case FILE_MEMORY_PRESSURE_ENABLED: + pr_warn_once("cpuset.%s is deprecated, use memory.pressure instead\n", cft->name); cpuset_memory_pressure_enabled = !!val; break; case FILE_SPREAD_PAGE: From patchwork Tue Mar 4 15:37:54 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Michal_Koutn=C3=BD?= X-Patchwork-Id: 14000983 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 675BA28369E for ; Tue, 4 Mar 2025 15:38:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741102730; cv=none; b=juRXIvxZzosTBif8yof3TEvKWib/xoAwO9WXl4T8v/+LXk/JEcw8aLw3RyxZNvziWKi7lRp/EimneFRd/3mIrrAsZgWGu4wNDGil+u+QsVs0RpxDufojz1RixCxzbwIh016wV0MOtt+d25YLiokSYrbzmqfhVvc5pgjs3Z2L1L4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741102730; c=relaxed/simple; bh=j/4wLCwQln8i7pXmi4m03KiQwQyMuLnJxfUl/0RP5OU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=WwTMoEy9IDu2yYRHq8yVO5gGpAWbFDFsCIorxOA6EJ5+b6Dp9Sw0jiajxBHntqwNRKDGUPk7wrENtMNpNx80bqvelv97ZgzheVkb3x4TrowTJj0zuX2OJ4eprdLSM+8aaQVTOyF/ttjt9EfT8r0VUy6fSVm/VtgqeFyxiOtS/E4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=N2HYJLli; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="N2HYJLli" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-38a8b17d7a7so3440160f8f.2 for ; Tue, 04 Mar 2025 07:38:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1741102726; x=1741707526; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OFPt2CI1XVgWzStHf0nCdXSR4n5UutvMSPTp/cgKSsU=; b=N2HYJLliJ9A/Tj6vHsUxVN93UT6Fy84xy/lYFyQ6ldK6DNjsMaczFQGZMBa5eG3til TxjVJcEVt109Wx4/gTU7rImxV+PeSWDaAAZPLZ8IF7lrNqPHMhwBqva0pe3wU/rfMRf0 A0cO8qitFhDk7ArJRt0GzDrNfy+8cUP9v3HdBFeinJIn3MTFE+NMe0BFFgRVbKMb7wEb FxJRXU7CFz0yeLT6Xh+yKL+NCGqb2SIO5c7DIq4iKi9ckOJOjXMXuI3AJ0HEAwt8wJ0s tUSYJc4nUVdesSKpY99OtF7rygHU51W7uItPGvwpXKmG1aV7Wv57WtRvJ401A80GcQoF PVfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741102726; x=1741707526; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OFPt2CI1XVgWzStHf0nCdXSR4n5UutvMSPTp/cgKSsU=; b=RugUj5qQ+WHg/yeOCdSxD8FyhpxC3zaUSjO/jaE3PdRztlXswZr3HGYWu24tujgzFd mmAheDkEn77oNxXNuBvgqg6okEcfrrSKdTa73eJiJ5daZSt7/N1a9YCidgXci4DvyWLJ mE25xSzWNjXwUQnBsGAGfqQMlZou81V6xr24nqLkQPDGq7aBlRdROo5mwD6FcQPG4EIt zGYPoAZOCa4Q9MTBR5AjWSQT8WfzxCuE4lAEkmEURgW4xAzwvRVUOqdOHimdzjERekni dcfE3+9BPm45KkUclsnYkr+uGQdr1L2eDtFaoK5CLae851WG3Q/M8YQzu5LYR7VYmj44 0ZnQ== X-Forwarded-Encrypted: i=1; AJvYcCX/tFC5n1ZB9CNbIdelWp/saEgh3b7QuFVyyT/y3TJ0fyE+fZzGd9p8KBQIK30fCFmOUQRttrYUq/IyLw==@vger.kernel.org X-Gm-Message-State: AOJu0YyUXy4Q8AT6BRvIt9c44YKKOqQAuR/O15/1C447AanImE4PAFPF bB/IRhkUIS9mBtuRzxWR8uFyywGTm0RgN4QZKQikoVzxjEEK5lVIWb1aw4I2EGs= X-Gm-Gg: ASbGncuvO2smLf/oG0CNRbH/4aRq9DGM4DBnvC4Tr2VGkyRCDVDzHrQPbRT6c7TL014 suzl2A5UFKXQbqjBTyQ+k8wDtKB2Q9Nal7cLtKgMmyXj8PHUJ8tpJg5W8zaKB8sD3Yl8+z0dzzd 56/GYzbqEDOSa2koJVGhcMZmLFOBpBC+UBq15Ej1IQ/HOeF3+CbVbJwfQBUV3GLC5+e+Qj8Ry49 csrnd9niPd+ok/xn9cD8/Wy3O0EuXPA5UqsLEejZVTW6FifzMgFjO6/NJt3ISALK+HGYqq5cOBo 2TDK1k5TRWtgUUOc/l2NvWMbWr5qvS8m2pjebLqMtIPItpk= X-Google-Smtp-Source: AGHT+IFzh8tpm5PJ+6KB1qG+RR0gOraUB8vKw1xBf/Zc44nQ/d4j9J/DEIN5yaKw5Z2Ch0s1pQhPNw== X-Received: by 2002:a5d:5849:0:b0:391:268:6475 with SMTP id ffacd0b85a97d-391026866f1mr5796830f8f.20.1741102725724; Tue, 04 Mar 2025 07:38:45 -0800 (PST) Received: from blackdock.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43aba5710ebsm238670625e9.26.2025.03.04.07.38.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 07:38:45 -0800 (PST) From: =?utf-8?q?Michal_Koutn=C3=BD?= To: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Tejun Heo , Josef Bacik , Jens Axboe , Johannes Weiner , =?utf-8?q?Michal_Koutn=C3=BD?= , Waiman Long Subject: [PATCH 2/9] cgroup/cpuset-v1: Add deprecation warnings to memory_spread_page and memory_spread_slab Date: Tue, 4 Mar 2025 16:37:54 +0100 Message-ID: <20250304153801.597907-3-mkoutny@suse.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250304153801.597907-1-mkoutny@suse.com> References: <20250304153801.597907-1-mkoutny@suse.com> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 There is MPOL_INTERLEAVE for user explicit allocations. Deprecate spreading of allocations that users carry out unwittingly. Signed-off-by: Michal Koutný --- kernel/cgroup/cpuset-v1.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/cgroup/cpuset-v1.c b/kernel/cgroup/cpuset-v1.c index 3e81ac76578c7..9aae6dabb0b56 100644 --- a/kernel/cgroup/cpuset-v1.c +++ b/kernel/cgroup/cpuset-v1.c @@ -441,9 +441,11 @@ static int cpuset_write_u64(struct cgroup_subsys_state *css, struct cftype *cft, cpuset_memory_pressure_enabled = !!val; break; case FILE_SPREAD_PAGE: + pr_warn_once("cpuset.%s is deprecated\n", cft->name); retval = cpuset_update_flag(CS_SPREAD_PAGE, cs, val); break; case FILE_SPREAD_SLAB: + pr_warn_once("cpuset.%s is deprecated\n", cft->name); retval = cpuset_update_flag(CS_SPREAD_SLAB, cs, val); break; default: From patchwork Tue Mar 4 15:37:55 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Michal_Koutn=C3=BD?= X-Patchwork-Id: 14000984 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2311E2836BE for ; Tue, 4 Mar 2025 15:38:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741102734; cv=none; b=EMVJiV9bmeWkTFWZXu1vp3K2Ub61RvwpyrsSJqnRyXRhpBWqVXbz5BSdVqN5bDGONdahzUD261wp5C+hoWHxXK/97G3XKaU+JBxXbRGzs05psqGbRNpV12h4w7O6ueySl1QGqJ3/aJt42kyM7hnX5QVW1EV2Ei2W878UAejEmuo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741102734; c=relaxed/simple; bh=7wYWG9ZVBBfm6qGUhQl1CLl2MgF3R1Q5kOXcuHck6Es=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=LuE4cOh6UWfppiPgK5+otAJhwcYW4h8VAhCka7aEx+9dp3yZSTWFpW8ULUJUOqrLKcd83dRbhA0iAiO05itw4TOO7zgI0FxU8hN4fHGcm5n+GzgrKTOTMfRNgVYiqsIZFQkHPcyyM72AKfBwLOivSv0XrKn5CKNEXHKrjgzA1Tg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=KXppXQkD; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="KXppXQkD" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-439846bc7eeso37419735e9.3 for ; Tue, 04 Mar 2025 07:38:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1741102729; x=1741707529; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=U3wpAZuZ4KSnXLbNZ2vVh3tj9jZngNuo0DCz+MLkfDs=; b=KXppXQkDk92JQzy4v8GmbTtE/SQwvZcjp9mxH5CnBZD0Ct1HgT8D6MfFKmyp9bNVvn bCd2aQtt8D0SjeXq0Oc5MLpuq3g1LieVC/EBNfKgcA59dBAJKVYJXwQd+f6/GAIm9/m0 rwOyD/nWBci8Vdb67QEUsZ3nnXTatRKAvBfHDt6shbRGUKtS3yq6PjkUVw8vy7cfKH1S gobZTYmTgBK0hjnyJ935+55kW3goVuJYaCtFNtxc3yCehR83a4NKnRf26R0fnhpeImEF /F+GtfKR+7dp296RxtwxL0wmTtrWhviygtM91yL9hFO5ju+DKY+olPXolzXKg1FNyq4/ Ujxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741102729; x=1741707529; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=U3wpAZuZ4KSnXLbNZ2vVh3tj9jZngNuo0DCz+MLkfDs=; b=IMcVbFOoeu7dITW4uf8HKYgSOlTmzjrlfjgJNrNiWsPAOrygtVkUxtKH7m9mA52oJU e+052fqxWrg6IkmDQMEH7ygGu8eS4hwOX1n21tRz3xSqmHIrzWMSBe5bxqKIFXJEhpte ApUeXScwGYBWktdCUP/qZOsoymGO7fQkTyVkrGwM5mVG5ISuueGQ5cs3Qq5KdNTapR2h Z8+Llxb5h4bOVtYT8DorOeI2LyGHVqbg1fey1OE7QipZu3zbJl4+GJM4Vrj+GTYrWxM6 FKbvD/4Irz37vp9ss6GOF1KPy3wBxqC4qRHt+9piddd1rCHwf8yABMdz/QaY6FthO+QF 37LA== X-Forwarded-Encrypted: i=1; AJvYcCXA+16XvWxniT0k2Da92ypCSS4g++c9PaiERjhkL+6kdRPtZQTuX0D1SojEVcd3NMdlqwGa86OTZEfDcg==@vger.kernel.org X-Gm-Message-State: AOJu0YwHv8l/raCC19hQqlRxm4fjCJSITOgUVCFNGeVkoY+v5f1YhkdO CCOAezAOeFxoHEr8epEwvetEbNx++4MKgWeWrNzNIuOIfjIy8zYkvaRFdSCqYX4= X-Gm-Gg: ASbGnct7ktNMTTi5Tb3DoDfcEzBsGz77U94+HZCDge0FEbzktrBsBEnCRAtK567sC8s x3QDUnADUAn1XWqt0Y+FBhA+K3GRihEJupcem7qsc406eQnn3NjMO13vlC2BTLMRtzn7+fcGde3 ioKJLWJ8+XeRlQnNqSgxkklqpdovvV6Rgr6W2YRVGMoKpILWQ1/whP1MjES5aBcZD0EpD0hdn6M VaIUXlARGL5ei+M26wfpDjqjYc7YX2rxbzO8ahwtONBuKnBAzpbSVJnkckDH6haFepuqG7nWda4 SMDs4jYeM7oxGjZ33lkZiofOTAf1HhhACVtOx+/QSWCtbgs= X-Google-Smtp-Source: AGHT+IGuIQECszQqXO1I3O177p66zxaZAZdsZPbssWdo0WGLgBAu3ofXHTqWUVYSmtGpaEjf12Uqqw== X-Received: by 2002:a05:600c:19cd:b0:439:8346:505f with SMTP id 5b1f17b1804b1-43ba6747836mr136899675e9.20.1741102729333; Tue, 04 Mar 2025 07:38:49 -0800 (PST) Received: from blackdock.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43aba5710ebsm238670625e9.26.2025.03.04.07.38.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 07:38:49 -0800 (PST) From: =?utf-8?q?Michal_Koutn=C3=BD?= To: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Tejun Heo , Josef Bacik , Jens Axboe , Johannes Weiner , =?utf-8?q?Michal_Koutn=C3=BD?= , Waiman Long Subject: [PATCH 3/9] cgroup/blkio: Add deprecation warnings to reset_stats Date: Tue, 4 Mar 2025 16:37:55 +0100 Message-ID: <20250304153801.597907-4-mkoutny@suse.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250304153801.597907-1-mkoutny@suse.com> References: <20250304153801.597907-1-mkoutny@suse.com> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 It is difficult to sync with stat updaters, stats are (should be) monotonic so users can calculate differences from a reference. Signed-off-by: Michal Koutný --- block/blk-cgroup.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c index 9ed93d91d754a..b77219dd8b061 100644 --- a/block/blk-cgroup.c +++ b/block/blk-cgroup.c @@ -659,6 +659,7 @@ static int blkcg_reset_stats(struct cgroup_subsys_state *css, struct blkcg_gq *blkg; int i; + pr_warn_once("blkio.%s is deprecated\n", cftype->name); mutex_lock(&blkcg_pol_mutex); spin_lock_irq(&blkcg->lock); From patchwork Tue Mar 4 15:37:56 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Michal_Koutn=C3=BD?= X-Patchwork-Id: 14000985 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E31262836B6 for ; Tue, 4 Mar 2025 15:38:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741102735; cv=none; b=AaE4HqsqXsFH2G6uiak1KB+3PFGNDk1pz3Jkh4nLErAp2rv0cnOCMXy81eg9vufvpyd1GRxIKS/MREF57cs6h/dN1BT0GX4UVmw6hhjR3W/+RXZbmvSqkD+saDWpqBRQrzG6qcMycdnryNatrQv0clE7+NWNwUKDBPww+plWKB0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741102735; c=relaxed/simple; bh=sBkomMAtTTGImKblWaof3H+sklb+CZPuq62TvsZ9BT8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=VipyhSIPjsrDuINCzuz6BwolVZ1VeN6s/8UI2c3i+g6eh6bihimNHExUnxyHc81NivJE/N9CsskRI+pKdTJcoQECJW0x565nh3HnP+efaERGifqeBDkxtnWm2KkMF15HKEE7CN2Qn/4q3pUGYLe1LaBYqOLwaz7L1n+Q1rL9P5I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=ggFXJvHB; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="ggFXJvHB" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-43bc4b16135so13883755e9.1 for ; Tue, 04 Mar 2025 07:38:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1741102732; x=1741707532; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NEhwpcuno0WFjY8t9/+hary0RYULU8RVoeuO+wPInIQ=; b=ggFXJvHBhk3FyOTugMTLumv9ejhutG93f2c2njr6QhGBm/HpbSfBjnShqdQnZLjEay IrNcwvkou/rQNukBMJ0xRX9qpPYt0lbfP3Zqc0+Czb58++kGoiqZ0zzHFP4BpnjAFFz3 DV+u0dp/I2Kl9Ru1/GC5+n3M0VIXZh2MPR9mt3614qMuBLatnBZt8YYt02b2XC3BJFY4 wbyLyU5dWlkDHSg+NU4QAXhVpFYyN8UFtnhX9mSjCU57kiVW/J1bArNbm5hCbsnoF1do nk8bih0klWP0Le1l6FCGeBxFwLMSGBp1pQ4b2w0mezqruH2+3tL6wT6VCvV1faX67TqZ oSww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741102732; x=1741707532; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NEhwpcuno0WFjY8t9/+hary0RYULU8RVoeuO+wPInIQ=; b=Olk5imW4lBPYbGVY9dxuVXts0XaJ68/0UI5RcdseizqImtPGu7O9Eo109kin78P9YX yp8fFnHQwSAv4SeVdKRnkGOSbrZ0FjmT6/LJhjdoYpvaNaL8P+hn2tYTaoxeAg5fJi6b zdR3glBDt5v32eD7+u7n+QMxQue8sVaKDLpWcb1a7qDzq8DiWTAi5TjP1n8oQfY2gS8Y XuYoSzyq9FYQx9/MsrVL+EtdJQQP1Prm6ALMdd9ZWMlT7a/1SBk++n/9SKWSYi47Nj8U MUE1OG0v8QvprdMdOS8UEH3TS5IUoy/1stfBLGjCr1z2p7d9fCXnBu9b72KK/ClQwrG0 Vkcw== X-Forwarded-Encrypted: i=1; AJvYcCU68x1/OR+FVWyEhbIngxRAR9ujL3a9NM6RI3yblbxZtCLk91PmoIuhLzQxaGbpskrr94KFiNMJHXjRoQ==@vger.kernel.org X-Gm-Message-State: AOJu0YwIUEvxoUv675H2YS2zsJBO+o8VmTq+ilF+viial+V83nwxxyqd nTo0qVPh5yWfGQyPL4JtiEk0vh0mK7++KYBHM47c61ZqE954hDuFeU9Fh/lQRu8Qm/ROxsS8IHM Xt3o= X-Gm-Gg: ASbGnctYaeIS67sfOZwS8DWZ2lvJV4RrdK+kQaaBdLWLGJhP0BlqvD5ybUPT/UfB2kF WN+3GAGfWHS9xEr1zmFN+CGXV/QKmF9xcHaw0mFiPlQC3DWKBghxIZDonq79/mOD4WrM+Z9LJ7Y EGVLBLndo930FbO2ydpVLpt/XfUjwDbaJDqNEU10jp8HyW38IX6a9oSwb0qUC/3i1G3K7ZsVo6A tdnBnWR7p16ayAQSUm2T6MN2POmWVX788PgqNf5Gj9NQGzjD7Eam0O7cjlXDwaMQGPEBM1DNVla cKdaa4UWF9q1JsePJZMZQOzyDUGMNotfkJ7CDXwMoFy4+/8= X-Google-Smtp-Source: AGHT+IEK7ULJaNBAjTgJI8C4sH5VL3JYp9ZcoPsT94hUTXeN1rzXj0hOcFllyp1216i8WCkMP8FL8A== X-Received: by 2002:a05:600c:3ca3:b0:439:930a:58aa with SMTP id 5b1f17b1804b1-43ba665e31dmr166089505e9.0.1741102732343; Tue, 04 Mar 2025 07:38:52 -0800 (PST) Received: from blackdock.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43aba5710ebsm238670625e9.26.2025.03.04.07.38.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 07:38:52 -0800 (PST) From: =?utf-8?q?Michal_Koutn=C3=BD?= To: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Tejun Heo , Josef Bacik , Jens Axboe , Johannes Weiner , =?utf-8?q?Michal_Koutn=C3=BD?= , Waiman Long Subject: [PATCH 4/9] cgroup: Print warning when /proc/cgroups is read on v2-only system Date: Tue, 4 Mar 2025 16:37:56 +0100 Message-ID: <20250304153801.597907-5-mkoutny@suse.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250304153801.597907-1-mkoutny@suse.com> References: <20250304153801.597907-1-mkoutny@suse.com> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 As a followup to commits 6c2920926b10e ("cgroup: replace unified-hierarchy.txt with a proper cgroup v2 documentation") and ab03125268679 ("cgroup: Show # of subsystem CSSes in cgroup.stat"), add a runtime message to users who read status of controllers in /proc/cgroups on v2-only system. The detection is based on a) no controllers are attached to v1, b) default hierarchy is mounted (the latter is for setups that neven mount v2 but read /proc/cgroups upon boot when controllers default to v2). Signed-off-by: Michal Koutný Acked-by: Waiman Long --- kernel/cgroup/cgroup-internal.h | 1 + kernel/cgroup/cgroup-v1.c | 7 +++++++ kernel/cgroup/cgroup.c | 2 +- 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/kernel/cgroup/cgroup-internal.h b/kernel/cgroup/cgroup-internal.h index c964dd7ff967a..95ab39e1ec8f0 100644 --- a/kernel/cgroup/cgroup-internal.h +++ b/kernel/cgroup/cgroup-internal.h @@ -168,6 +168,7 @@ struct cgroup_mgctx { extern struct cgroup_subsys *cgroup_subsys[]; extern struct list_head cgroup_roots; +extern bool cgrp_dfl_visible; /* iterate across the hierarchies */ #define for_each_root(root) \ diff --git a/kernel/cgroup/cgroup-v1.c b/kernel/cgroup/cgroup-v1.c index e28d5f0d20ed0..5c59b01024019 100644 --- a/kernel/cgroup/cgroup-v1.c +++ b/kernel/cgroup/cgroup-v1.c @@ -673,6 +673,7 @@ struct cftype cgroup1_base_files[] = { int proc_cgroupstats_show(struct seq_file *m, void *v) { struct cgroup_subsys *ss; + bool cgrp_v1_visible = false; int i; seq_puts(m, "#subsys_name\thierarchy\tnum_cgroups\tenabled\n"); @@ -684,12 +685,18 @@ int proc_cgroupstats_show(struct seq_file *m, void *v) for_each_subsys(ss, i) { if (cgroup1_subsys_absent(ss)) continue; + cgrp_v1_visible |= ss->root != &cgrp_dfl_root; + seq_printf(m, "%s\t%d\t%d\t%d\n", ss->legacy_name, ss->root->hierarchy_id, atomic_read(&ss->root->nr_cgrps), cgroup_ssid_enabled(i)); } + if (cgrp_dfl_visible && !cgrp_v1_visible) + pr_warn_once("/proc/cgroups lists only v1 controllers, use cgroup.controllers of root cgroup for v2 info\n"); + + return 0; } diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c index afc665b7b1fe5..3a5af0fc544a6 100644 --- a/kernel/cgroup/cgroup.c +++ b/kernel/cgroup/cgroup.c @@ -171,7 +171,7 @@ EXPORT_SYMBOL_GPL(cgrp_dfl_root); * The default hierarchy always exists but is hidden until mounted for the * first time. This is for backward compatibility. */ -static bool cgrp_dfl_visible; +bool cgrp_dfl_visible; /* some controllers are not supported in the default hierarchy */ static u16 cgrp_dfl_inhibit_ss_mask; From patchwork Tue Mar 4 15:37:57 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Michal_Koutn=C3=BD?= X-Patchwork-Id: 14000986 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D3BE2857E9 for ; Tue, 4 Mar 2025 15:38:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741102740; cv=none; b=frgN/OWrb/VNADvHnRs94EzDq/Ey+8IZFHZ60MGIplEQqNA/mJPd3Ebk5+ovYMD9abmCA/RJEIFKTOUtRelSXu1AdcjIxXZrz2oCb8Aubv2CZupwXaoBXCMOlSQHpfCZZo0l3Q+B33zqcPo4bpaGrPKnB9WZTE3dMTUD8k8EAz8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741102740; c=relaxed/simple; bh=cHns8fqxRp7euip5mPfMcCQkmw1AJFKlvqhDmvw49+I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=FXyAaTaEt/nb9fbn4crXT9FNsVuKpaBMfTjwKObflSbqcvQRK+kR7jp1GjVOpJItO+rHM6TFMcBMFhmzlezfx1h301R5Nj9urdPqeHpUzrhbgs7+QNi+LujgM7TcpqEzj28l7V2ZVX440JnoRSv3OBmREOhiHd/sR3a724ADgLo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=MSKlbFbn; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="MSKlbFbn" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4394a823036so54473425e9.0 for ; Tue, 04 Mar 2025 07:38:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1741102736; x=1741707536; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wBPZZxD2lIKyHp8wqmCpoZT9q9nUxOdWhcx01NnsOjw=; b=MSKlbFbnpfmgz5nTwVs4Oufvas/KA4uM8n/f8oKuhd0j8Cwhhr6BwiXr9DWVb5PqaX uY+3ytvDvyPecRbxdLSJW08F3hJ59jTE4HIBM1p295lyRMQhUvBrZfRbtdaSA4H0IEEN AzPXgGtJZAuHmpWFDWmX7vw8fUayakPRoU2j+gPF1Y7R/0HWxSF9p4xGonAqC8Zb9fm7 WifCTiRhX8J4re/aRNwWYFHhSAKSaVIz9LnzB1Mn97OUs2OejYMZdWdSgCYobWz8Hhod C5KmKSam97nGoHYyfD9EBpXjhFXrUqnShXakh8FYTp4n6C48JTohRc2cw67bf067eug1 fFdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741102736; x=1741707536; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wBPZZxD2lIKyHp8wqmCpoZT9q9nUxOdWhcx01NnsOjw=; b=lSdUk1Oaq4LDhZidp3YR7/T+TacnhC9zCr5VzqDj9U0oiVaLJ7Wt0W8dm5yPZEQNKi oZnBldJl4aPRXp3ksWH2xN1fH6lQkAwpb/O9XRBfXnic4XyIvIj591QsGJFpWzJqEI2p 9NKDuc1Uu3P+OmOEd1Cr01nbtz7e5N6cXJ8Q77cs2sNY6zs7pVnNFEOUA0UbWHYGa2AW /st3fzUW6UMVPmVkWA2tftKw9cqnlzlqQ7UQELqqG7vYiPcIUAWPWJWnQ3QLYimqnW/i N15Mj/bfPYPyTg2GC+WWGy9n5hdnqCgCQBnUI8EKCZfS6BKvdsFvCeutKLZebgXmjVJJ 76zw== X-Forwarded-Encrypted: i=1; AJvYcCVpOcRGXPbsetATYm/JN6g05J9e6glfHY7IC3D11uuqGvn4XJHJ2gaSgmX8zWAXPcVJk95cy4/MkE4rRQ==@vger.kernel.org X-Gm-Message-State: AOJu0Yy4bY67xI6XvjpyUY/10R1YX6yfXaa65/V7KVKeai8kzP3cdHOc i6wJ+k7j8PYmqM8scV8BcQC3dtD0vtEBUKhrUW2P4EB2H1r1XBnBS8MHOagEOBE= X-Gm-Gg: ASbGncvfyaIKe8c4xFyyzNT3+ALPUq/Ib463NqjAvhmoxuj6qGaG6cg0jz7o+hYIlD1 1onxmt7dIDLNh0GZXst43eglRsQdAer++N6uMFSbh7NR8dppdOq8R02V2YQCjR47cBhFBKlkABC tdhdCegnBwgnADWl/gDyio0jrwgu4TIv5gLuV06BpOzGD0bGNvkqLmqLNTeWc+Ah48x9XvrNSWd pl7JjFc+SWQd2jNFp8OEuXRC86Qp+1vprBzFLWdBTDh02VGzeY18hWZGBV5gsnPMn1rhAUIIGD5 WRPFt3nZwAE9lUhefc197bsgUfF9TBy51UnwBrrFMv5VcVQ= X-Google-Smtp-Source: AGHT+IFobiCmJ5R4HiRsL7pd40Q47J6t9IkNByEpgJJ+za6Nh1z2wpG/Yd/Pf+T6IGoi+Jf+ap0SAA== X-Received: by 2002:a05:600c:a47:b0:439:969e:d80f with SMTP id 5b1f17b1804b1-43ba6773869mr156464875e9.31.1741102735859; Tue, 04 Mar 2025 07:38:55 -0800 (PST) Received: from blackdock.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43aba5710ebsm238670625e9.26.2025.03.04.07.38.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 07:38:55 -0800 (PST) From: =?utf-8?q?Michal_Koutn=C3=BD?= To: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Tejun Heo , Josef Bacik , Jens Axboe , Johannes Weiner , =?utf-8?q?Michal_Koutn=C3=BD?= , Waiman Long , Paul Menage , Paul Jackson Subject: [PATCH 5/9] RFC cgroup/cpuset-v1: Add deprecation warnings to mem_exclusive and mem_hardwall Date: Tue, 4 Mar 2025 16:37:57 +0100 Message-ID: <20250304153801.597907-6-mkoutny@suse.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250304153801.597907-1-mkoutny@suse.com> References: <20250304153801.597907-1-mkoutny@suse.com> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The concept of exclusive memory affinity may require complex approaches like with cpuset v2 cpu partitions. There is so far no implementation in cpuset v2. Specific kernel memory affinity may cause unintended (global) bottlenecks like kmem limits. Cc: Paul Menage Cc: Paul Jackson Signed-off-by: Michal Koutný --- kernel/cgroup/cpuset-v1.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/cgroup/cpuset-v1.c b/kernel/cgroup/cpuset-v1.c index 9aae6dabb0b56..05d3622ea41e5 100644 --- a/kernel/cgroup/cpuset-v1.c +++ b/kernel/cgroup/cpuset-v1.c @@ -424,9 +424,11 @@ static int cpuset_write_u64(struct cgroup_subsys_state *css, struct cftype *cft, retval = cpuset_update_flag(CS_CPU_EXCLUSIVE, cs, val); break; case FILE_MEM_EXCLUSIVE: + pr_warn_once("cpuset.%s is deprecated\n", cft->name); retval = cpuset_update_flag(CS_MEM_EXCLUSIVE, cs, val); break; case FILE_MEM_HARDWALL: + pr_warn_once("cpuset.%s is deprecated\n", cft->name); retval = cpuset_update_flag(CS_MEM_HARDWALL, cs, val); break; case FILE_SCHED_LOAD_BALANCE: From patchwork Tue Mar 4 15:37:58 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Michal_Koutn=C3=BD?= X-Patchwork-Id: 14000987 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 226CB28FFC3 for ; Tue, 4 Mar 2025 15:38:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741102742; cv=none; b=Wf6LxLVdLztvU/xx8wTbHKofPnqWPmsiznP9W/FD15Qc4DcaHY/EAwOwkeixkkJxob2zhQzhtIoBznz1g6lJ2r2S9hzT6olKQRgi7d36bb0HLYJBTi8YEVNWU1vBjfa3tQSkxkuC/bD2JzsHqbFG6KDVJuqswMPXQcjZbZigtVc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741102742; c=relaxed/simple; bh=MdgvuPV/x8WhlRRCw7Trx9k9ojx5GfL3R2IFVSBLDBQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=FSVk5FiV7ZqTwwa/v/777baE/nMc1i5QX4wHZgwRMmgFbWeTt08SvMd6UWdNbK1r0WpxaseHbaxkT2niDdZoRJA319myutNMu3CX2g+dQV5Tf/IeEz+n6p5qkg5IaYn8AVMW+KcieXOVeP8y0i8WbeQo7iiXSWsNvwn70bBHXCc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=VsTqcrWL; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="VsTqcrWL" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-439ac3216dcso39812925e9.1 for ; Tue, 04 Mar 2025 07:38:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1741102738; x=1741707538; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TgXxWXRYbTk04GQd58ITj+iG+NER5RZZsNgCYR7jvUU=; b=VsTqcrWLiRztdJqD+hckVkKPe1yjJ76YHIAWTRnEf737KnahCd6bqo1dAMJhSD/VSq 4DqQnPNAKhRzX3Aiuw2/i0mBSgSDxhHYlcFJE1hAEabP7ANQgTGDT0PO1kYBuR48XpPR AS77lJoAKkkEL4LWLzf5vY9QXoEGyrZrV9bTL2apQMJJZN1DjVsNg2IW1h2XvQ4Jz8IS uUQMzvihGsce8JQ79fkjhCOLS4Sivt0c82bu8seSHuRQI6SqLzXJbnuf+iHkWSwa0kyJ RHuOVB+bgpMcJqNyaPTYocI+uPnPQ/trxh2ggCGW8iwzNejTjizmJuIi0Z/9Z8iPtyow hZ6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741102738; x=1741707538; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TgXxWXRYbTk04GQd58ITj+iG+NER5RZZsNgCYR7jvUU=; b=YP31q/O0BJCfEnYOX0v5hGEeP+AHkNLTD+JS6EmigGcBtHAopbH18oFZsRE25G7VUh 68+U2CBOOmo784REr4kLzVueLcEf0H/VUnLvzwyzSzdLzx5MzJYeFliDKaXwTIUEhzt6 i05XtqMe7XqHs1CBmIZ56tK8oOYOIv9K4S5EYMvB8dTo3ZpWwMUNrFYDlLSruCPZbYs9 4Ottcusb/HSkJFvvj2D8e6qQTcE34amjqHr9z13PNchzp/B5xzb6D8Y39j1AqjgeRLXH vXPnVbvnFcfSgScul0bdbkYubK9d6XFJfGNqVOY2SVXLBOGtjpXQvhtpFXewCwAGHrbx 3CGA== X-Forwarded-Encrypted: i=1; AJvYcCXhbncAZOFDnFEMCaJ0BpMB/HjUk1T55PSs7T5/OXWObycvabgTcleZZX1PviNj59/QEgF0L+PGlkCGhw==@vger.kernel.org X-Gm-Message-State: AOJu0YwGwfGAe7RZITdfRQSYhTsnbENam3vhL2r5Qxp4/eLPbt81IxNQ v52qOxP6yeV4M1Wc0EXQl1f2MMvR612Y+Gq5+FEemqYecsKCvrh5UeyByqLLb7M= X-Gm-Gg: ASbGncvC0lnNwkAPv5cXBtctkughnckbzpaJkffuBiuv8fNTLDbuAGjYDuqoFsESaFI Mj7OWj3PIitAG1Z2wp3pM36KPiHOFz+Mgf/+ACjr+EmEpma54JvxlRavCOLrOJCW5Q3UZ+Cb1sr uQcPN72E8Er2v7tVN79RY6Lfr1yCWc2b8AE86GdLGPxCXvqEorwQHTAjMsrP2LfCfzwQK5YxNhG BS2DLGgPoy5gl5MN3MUUI+Vk7VQcJDdYtfCUYWgI2kY7NqtVQYpxaBeOguDZjyxqnxChiMmzmQj lbdyx3VywlIjkuE2zazcpIEHrigE7z6N19fURz76zIOAHUU= X-Google-Smtp-Source: AGHT+IGFdMgALKsPh/yOBcPEpPtHnNxwQeHrF4SOqKDJXo/p70nI+zMPXEdR7SegUyRy3tSFD06IsQ== X-Received: by 2002:a05:6000:2ce:b0:38d:d9bd:18a6 with SMTP id ffacd0b85a97d-390eca07164mr13871828f8f.42.1741102738265; Tue, 04 Mar 2025 07:38:58 -0800 (PST) Received: from blackdock.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43aba5710ebsm238670625e9.26.2025.03.04.07.38.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 07:38:58 -0800 (PST) From: =?utf-8?q?Michal_Koutn=C3=BD?= To: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Tejun Heo , Josef Bacik , Jens Axboe , Johannes Weiner , =?utf-8?q?Michal_Koutn=C3=BD?= , Waiman Long , Paul Jackson Subject: [PATCH 6/9] RFC cgroup/cpuset-v1: Add deprecation warnings to memory_migrate Date: Tue, 4 Mar 2025 16:37:58 +0100 Message-ID: <20250304153801.597907-7-mkoutny@suse.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250304153801.597907-1-mkoutny@suse.com> References: <20250304153801.597907-1-mkoutny@suse.com> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Memory migration (between cgroups) was given up in v2 due to performance reasons of its implementation. Migration between NUMA nodes within one memcg may still make sense to modify affinity at runtime though. Cc: Paul Jackson Signed-off-by: Michal Koutný --- kernel/cgroup/cpuset-v1.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/cgroup/cpuset-v1.c b/kernel/cgroup/cpuset-v1.c index 05d3622ea41e5..6155d890f10a4 100644 --- a/kernel/cgroup/cpuset-v1.c +++ b/kernel/cgroup/cpuset-v1.c @@ -436,6 +436,7 @@ static int cpuset_write_u64(struct cgroup_subsys_state *css, struct cftype *cft, retval = cpuset_update_flag(CS_SCHED_LOAD_BALANCE, cs, val); break; case FILE_MEMORY_MIGRATE: + pr_warn_once("cpuset.%s is deprecated\n", cft->name); retval = cpuset_update_flag(CS_MEMORY_MIGRATE, cs, val); break; case FILE_MEMORY_PRESSURE_ENABLED: From patchwork Tue Mar 4 15:37:59 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Michal_Koutn=C3=BD?= X-Patchwork-Id: 14000988 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D75DD28FFDE for ; Tue, 4 Mar 2025 15:39:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741102743; cv=none; b=ESluvRbgVm4hSx8fI4ga+x0gFYRk2e9bpNlX1x7vDDuhd/gL10OM0Z8XRPvsKPmQ3vOl5vRg/ObYFtQ7eNPUs10NTzUp87j+2dKj5oLwCxH2wHi58lsthksRR+MZOv+/vafH6GpL+Fy4Syv5TwU4xZSGpW6tbjdGYXtESvvnA9A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741102743; c=relaxed/simple; bh=m52peCNVice4dNNY5xbCz5VOoTIMY+0qmJAW8b2N3QY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=NTd2fXi+oIGrEdzGFBNLwfC4fAGX1ZH0sjwlGk1xEwlj9GYzM7CaiY5qzlFeY7aP4VvQCAY1/i5/hyhYVWl45BOSlwjEbuELSilefbLyjmFp24G9BZ4PdtCx3Qz6JR7QswYw7dykZ9CJa745UmjW+aClAK0ya2BZnktLGbLI9vk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=CIjlrGVD; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="CIjlrGVD" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4394a0c65fcso62465535e9.1 for ; Tue, 04 Mar 2025 07:39:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1741102740; x=1741707540; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=K0SMnkypgJ+E0WuuzIPm19tlt9b9dHVVlixZH4mmHVo=; b=CIjlrGVD0tl2N1dEl0VymJokuUjMCJi27QUmXaxHeMRaLwon9MBFTUQSJLV9rbUAm9 avvwf5k/Pc1u5vYR1tpZihY+tzq0nyhjjeP2DmbTdKrEAfkvOSt5S3tZ0jdE3dVMm7DH dv6tswX6zFpK7r7/mP+iViWiapeG+9ty+cT4W3kDycLoo+mBRVL52aeWFAwvBUvAZbjC 3skbz+xMJQjhnrGSZnNIkmXl2Q9RcBhPb3ZG8dXDXe6FgBR7d7J7h/SQicnuPAwPYgZE oTlvsQlzzir8ZRPxynCEJreh5tFrBVqRbnLIoYsbgW6HGeAXemeL4RuOKh/T/wKxUbAe w4jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741102740; x=1741707540; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=K0SMnkypgJ+E0WuuzIPm19tlt9b9dHVVlixZH4mmHVo=; b=LRaAFD5NQEkO2P1vcTWhpJfE8NSn92VoKKg9S0fMJc48cGzBz+D7/cAePue96WBTll 2ql6IYOr8LQWhYaHEjqEZJGvhU0XzAZXHYuk9QUyKV2Di13ACg4Yo+8PIZujEnKcJ56p V6w5VqzXE9ehKOGHm62L4N+i3plO7y34td61XEGpy4rgzrPeC7Dd5fM0qrjNbdawl53H 5cnzZOTADSSy+7AEweMbtmS7VwfzWvJlfFZfwOcSTRI6ajNHPjvs7oqtXcmb9YmerYj1 IKkYgA0s7d+O61W0VT01voZENIIkJdhEkS4dPfkt71LPUgn+7HnjYD9mR8q3KGPnDQF/ cNkg== X-Forwarded-Encrypted: i=1; AJvYcCWfFTezicy3V6Snja+FHAMoeotJVQdreuknzbnYTtSP4p1K+RDWXT91D/YqQ3PASF8l4NyQAOVWA0m8QA==@vger.kernel.org X-Gm-Message-State: AOJu0YxAS+XTewODHXcME+m+eZrGCZYGernzrzeZztCDbnIXu6rxxep7 bb3nmAGD6cax0oRBAKX1srpAOp59F0rdyUKbOQOEktNRmRVe0R4gByI+ASR1haY= X-Gm-Gg: ASbGncvBA1AmeEVdtrf1WBSlXQjbEN9dQBzlUNtfi/EFhJwXP9OYEWwesIs3Dfln5QO 2X3pN+DB74+DH8hejKZCLA8kZNS/7gys7elVBBfuQo4Wr4evCmvIqz1jj0LL6KPzrIbZ1hBnmCL o9ovrBjxoQ0fk597xz86tyq+ORs6zCi6VEapbhPCN37fdA5t21wyDitRogH+VDg/7awDoEWt6Z+ LTvLOtcTQETje8lsTCQF+yaz9wVn0ijrY3vfufDbmXbnlVgVzYvCSkqFJiOFwLUoQvkPpyEiSn3 q75Ns4PmjDxCSIU3SDBi4uKRv17DtCUGRgEhHDISg3ZcjRE= X-Google-Smtp-Source: AGHT+IHVsiEQmN3Y21537PIQvBH5PobiQYRSPlH0O79ylXjcUAzUwaUszPliAbCkCArUCFHUG5m/LA== X-Received: by 2002:a05:600c:4685:b0:439:a0a3:a15 with SMTP id 5b1f17b1804b1-43ba67045camr187495795e9.14.1741102740250; Tue, 04 Mar 2025 07:39:00 -0800 (PST) Received: from blackdock.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43aba5710ebsm238670625e9.26.2025.03.04.07.38.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 07:39:00 -0800 (PST) From: =?utf-8?q?Michal_Koutn=C3=BD?= To: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Tejun Heo , Josef Bacik , Jens Axboe , Johannes Weiner , =?utf-8?q?Michal_Koutn=C3=BD?= , Waiman Long , Hidetoshi Seto Subject: [PATCH 7/9] RFC cgroup/cpuset-v1: Add deprecation warnings to sched_relax_domain_level Date: Tue, 4 Mar 2025 16:37:59 +0100 Message-ID: <20250304153801.597907-8-mkoutny@suse.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250304153801.597907-1-mkoutny@suse.com> References: <20250304153801.597907-1-mkoutny@suse.com> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This is not a properly hierarchical resource, it might be better implemented based on a sched_attr. Cc: Hidetoshi Seto Signed-off-by: Michal Koutný --- kernel/cgroup/cpuset-v1.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/cgroup/cpuset-v1.c b/kernel/cgroup/cpuset-v1.c index 6155d890f10a4..ada6fcdffe0b5 100644 --- a/kernel/cgroup/cpuset-v1.c +++ b/kernel/cgroup/cpuset-v1.c @@ -175,6 +175,7 @@ static int cpuset_write_s64(struct cgroup_subsys_state *css, struct cftype *cft, switch (type) { case FILE_SCHED_RELAX_DOMAIN_LEVEL: + pr_warn_once("cpuset.%s is deprecated\n", cft->name); retval = update_relax_domain_level(cs, val); break; default: From patchwork Tue Mar 4 15:38:00 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Michal_Koutn=C3=BD?= X-Patchwork-Id: 14000989 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26146290BC0 for ; Tue, 4 Mar 2025 15:39:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741102747; cv=none; b=EAglg7OgOh8TEvOlR5aw5+qYN8489AMKMzeMNHPAf3x89wqKGSuPVEBQRhxRxnFrXTz+SuR+OG9lRHx+9+oZ84ZuJj6X3RFVo+fKZhO0R+uNq8Cca8DbUlFgQ7wJeGco1gvwcis0SLFnzoK1xNJ2wX5AiSQEW33z1sNoCl7m1BI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741102747; c=relaxed/simple; bh=uEBo2XwkWIu1kEQdFfc+UP0MGpzG764Wn7p6Ra7wCqU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Kvm/pNRcxcST0YpLK24Hn9AP5SPquE6fp7S2seEuk6kVVyILGGfWHskjDR/TFOGqJVUfEJzVkdHEEC5vE2qlLtkqCtS5z40yCJCbvIxdZcBL5IkU/3zNfePjtnAIMZd/PZaNDuYXgkALx24R4M+I9N2Y1kgPuoskFCGZ84qwua8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=QgTw9Ucc; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="QgTw9Ucc" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-43bc6a6aaf7so17339265e9.2 for ; Tue, 04 Mar 2025 07:39:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1741102742; x=1741707542; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mhMHstYP/DAcPBOLk4EEWApjXQhALePsm/Er/3v899M=; b=QgTw9UccyVFux+Vzt527ZlRdEEyF6sGd6zoXTXS0p45mPX9AzYejJpkn2vqR7TsLpx R52dwdvY571HVzEMMaFSL6H9goHxavWIFiL7FS8K4VxUFvHSP25zU1TmLdfEfitFzC/f GOhvhPpio+foB3nG1G2wj7z+mLTUKtvGH6AWSQqU/qr3INofgfHz4uzZFWBLs9iyqDjz 74STZli9eGyHQlKwYEG5OBAf59pLUHkhdvJPlNhI2KW2uoj/q02A0L2PmPwC/F/FjAhw 81qFOHe8SDmPP1exWfvOrNvZeNPqe+yRULlrBJn20zOSzMnvO9GUr5RRcGrpnLLR4cF1 V4gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741102742; x=1741707542; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mhMHstYP/DAcPBOLk4EEWApjXQhALePsm/Er/3v899M=; b=MWeYvoO8RtcVCfRZH2D75PtTuSRNK/FjPTbDJfCCnhhLiKZq2opOe0+miDcIplfx41 Y1ZYpMfK/JdZzIQsI6vV3jT18ADesg4bxp/U+lzwcuS87FfKCoSEzLnpFFhxbIsYgY7M 7lm9E4n2XK4EuZ/k1Rb5mj3MayvwXRSwOijqHJGP3pzsNPrKl+ybHUNDA02tPbe7HOi9 XQVJD2YQNzns4NhhUEwA1U+Ug1oXmNwCuhmwz71sGQey0ZWFSdDPNn9eHTbNZD/nIWvF 9PgEi9Fzj22LKO8aDDK+Y5md+fI8Vy8BLv61qpAD+eWtxzyfqFGuLYZwTB/JoYCAzl4Q iQyw== X-Forwarded-Encrypted: i=1; AJvYcCV8HVPtxg9WG5dmBByMZV1vAjjzOq/UYvAKPs+yJJV26wSD/0IsNf1Uf1p84RFPlaxelO5vQ2Tn5zwnHQ==@vger.kernel.org X-Gm-Message-State: AOJu0YxQibYHMrUlk4ySH55arr3lOD/f30DUt4z3QVsVpaIMw7mtkCRD Up5+q4SN9guiukTm3bbDEl0XQneKaWXqVtmU+E+Te7zQRo9BLAOB5ae1I8+R+DE= X-Gm-Gg: ASbGncty72yCP21CDRoihL/XW4k9B4GgQkLAWmnmRUaPTGbb4Uq8KTbHJNtfeKHu+Ar po8Yz63FrRhD7NgL/JHebLMkaUP5uol57CEHmtMChXCd9ZlxTuZNuDT/CouHqB2elKICiLty5zU Zf9mycZEhT9BDJwlAAYYtzLjOFU0X7jud3/3w8fThqyXsO8pu7jsD2+tOEQAFDEANfaU2UDzrXm tT7h002UaIEnE2sfbiubQkOu9KVixeL359xJ3JftSvRW/HHRtMkBeBgcCjNco/YrQTphME+tB4/ fUAZg8VdT/DiixQuF/+Y43NhL1TJqPfJA/ksBTSbM6Ga44Y= X-Google-Smtp-Source: AGHT+IGgG3j37XPpBlw8fV8aejT9Y282Zg84Ylxu78/13gmSg1k/Grk33Ygxi04T6savqD/zyfoG5w== X-Received: by 2002:a05:600c:478a:b0:43b:c7bb:84ee with SMTP id 5b1f17b1804b1-43bc7bb85bfmr53809865e9.2.1741102742506; Tue, 04 Mar 2025 07:39:02 -0800 (PST) Received: from blackdock.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43aba5710ebsm238670625e9.26.2025.03.04.07.39.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 07:39:02 -0800 (PST) From: =?utf-8?q?Michal_Koutn=C3=BD?= To: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Tejun Heo , Josef Bacik , Jens Axboe , Johannes Weiner , =?utf-8?q?Michal_Koutn=C3=BD?= , Waiman Long Subject: [PATCH 8/9] cgroup: Update file naming comment Date: Tue, 4 Mar 2025 16:38:00 +0100 Message-ID: <20250304153801.597907-9-mkoutny@suse.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250304153801.597907-1-mkoutny@suse.com> References: <20250304153801.597907-1-mkoutny@suse.com> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This changed long time ago in commit 8d7e6fb0a1db9 ("cgroup: update cgroup name handling"). Signed-off-by: Michal Koutný --- include/linux/cgroup-defs.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/include/linux/cgroup-defs.h b/include/linux/cgroup-defs.h index 17960a1e858db..561a9022ec100 100644 --- a/include/linux/cgroup-defs.h +++ b/include/linux/cgroup-defs.h @@ -619,9 +619,8 @@ struct cgroup_root { */ struct cftype { /* - * By convention, the name should begin with the name of the - * subsystem, followed by a period. Zero length string indicates - * end of cftype array. + * name of the subsystem is prepended in cgroup_file_name(). + * Zero length string indicates end of cftype array. */ char name[MAX_CFTYPE_NAME]; unsigned long private; From patchwork Tue Mar 4 15:38:01 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Michal_Koutn=C3=BD?= X-Patchwork-Id: 14000990 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFE7C2980D8 for ; Tue, 4 Mar 2025 15:39:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741102748; cv=none; b=eYhi2EHYrLBKkFNYK3BgH/2Evf0OzJ9Z8UBtQMO0aY9fpp1tnsm9LKLqD8Jxw9zTr0DuFnfdfMKgsfOoRsQefhAEPUCgwi+ws0YGTFUxjToijVaTdnYg6+h9ZX1SAUq8iWdQfgX/PQjcazBHJ7ozjg73Zs+GQDDeqEilTjcXTss= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741102748; c=relaxed/simple; bh=LvkOijoEyLqDMsqQX+Kl7wQP+Lfreox2ddu/WO8YtBM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=iSwyB3o3KaPn7lwl3yawtoK22HcfwIgzrq7qdjPkyKDqK1ivEcrFLKlBdz/vb/5ckxazZrkeD6PyFTt1qGvma50UZuQQxJa+Ilb8E3/OF8SoK1dVFeWXYwESGahqrbyYX0oBgoEW2T3afaUZHbJZ4SUwHd745/z7auaWHDWrRwQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=ReG+dyPC; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="ReG+dyPC" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-43948021a45so53136435e9.1 for ; Tue, 04 Mar 2025 07:39:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1741102745; x=1741707545; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LkXOSC9ROskp3x3ku4mQvAAKFjUVG2MCmIDW0NJqpNc=; b=ReG+dyPCRDFzyYsj4zAYWz+OKEE+rGOqNz3/dsxcIS6XEcShSVkTOBrrbwHt7layU1 q17uB35yxIqgEEh4Uaa/dDkymiADB3WLoC0pnAt6Iwr+pmCS/Bkcl7yiDnuPs9E1yjb5 SXZdxDMirB3pe52gx2v8nfSuWl2Yq1T4XtaBXmHBZ2+TjCkwGbPn3wQe3nQYG6NrFT9I WdmTKAY058SuNpiA3IMy/wg3MYne/Pll5dQ2t4RclcRQHwHLhMI5NUnJOBtziqWaq2Nn 2kdHJzoN/WidBmWxXxgReZFzcvWtWXErsTqmFYkdvUtxtyJ/Zkydf1TZ9KGLRlk7N35I omBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741102745; x=1741707545; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LkXOSC9ROskp3x3ku4mQvAAKFjUVG2MCmIDW0NJqpNc=; b=TZNBYusOGfla0wIJI2tPVH/qCpg4TZHNP84ZPrHN8mxHD1SZ1PnaCmFUXlHy+5SEYe Lt9Sp03VR9tZTVR64yTOmtQk2NqRxi1PkO4smhPYvzCNmG3LtSWS0d7Ug/7PeCf8VCQc nWkRX1F4Hv3NsGKS3vx0MvoW1oLBALIYTk7j2OwGZWScRuHS6eCV/GIAZlMtp6lVN2C3 poHs/KAarW1VUKqOFFCi9IZexQlHyhZJu2J4d03F0vYyT7NBTbt2o+aTUZ8zH6dMewhK atnBapctnPhuCf4Gkhh5LhcZ7AGMZGICzQ10YhlR5XEa6o/oV54mxxO3CPcRg7TmQQnZ XFUQ== X-Forwarded-Encrypted: i=1; AJvYcCW/cJ7X+KgZSmKYEVCVmvNivtqlIyjLEbqNxGbfDCABVJvrPpGTqM5XtyKxnAAHnIrQqCpwixOf+IdbTw==@vger.kernel.org X-Gm-Message-State: AOJu0YzBSl9gl0q5Zf95kG9tdZX7L7elpl/+Yu1mycpiKrfKtDh+fOqG y8BslmP2CxDD2Rpe5Qwwy48jrH/sgrhZFEpuffTL9uANsPAuKwEgnGRhvZUQIKU= X-Gm-Gg: ASbGncvBSaHGh9MJPsS9foO7l+QlkMHq1rXW5LvDj35UQT1ZQvBvvKnCLvRd8mdFFjT Nnl366y15mIqepGt0TL4SutqY/FD/sWuYRegnPyRH02o4OkA92BIVuF6R6oybew4xw7TfIMS7zK v8rKJLQwXYCuw7v2p5b+8GG8eb7AcWZm87deom36ZkvJbNWxC/DXdUxc7uKMZtsC/Bs0Qu4ff+6 VE/iNBUEaEnp20O+pFk7pdJoyoLBO7P6dmWE0DlgSEtw2oQhQwujE4gkcpNH0qbuxPDUUk3dmmn fNEGzboKURQQYFNYGfJ7il8Eo7+s9PGcIOb4+iCT0hCV2Z8= X-Google-Smtp-Source: AGHT+IFd0Y1kfVUDwA+rIlXltUNEpd+BRYNRN/rGxGNdGzkzrMQ0wTVhTLyq8Q5ZNmhBP5e9sRDWeQ== X-Received: by 2002:a05:600c:44d6:b0:43b:c0fa:f9c9 with SMTP id 5b1f17b1804b1-43bc0fb002cmr75491345e9.7.1741102745403; Tue, 04 Mar 2025 07:39:05 -0800 (PST) Received: from blackdock.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43aba5710ebsm238670625e9.26.2025.03.04.07.39.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 07:39:05 -0800 (PST) From: =?utf-8?q?Michal_Koutn=C3=BD?= To: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Tejun Heo , Josef Bacik , Jens Axboe , Johannes Weiner , =?utf-8?q?Michal_Koutn=C3=BD?= , Waiman Long Subject: [PATCH 9/9] blk-cgroup: Simplify policy files registration Date: Tue, 4 Mar 2025 16:38:01 +0100 Message-ID: <20250304153801.597907-10-mkoutny@suse.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250304153801.597907-1-mkoutny@suse.com> References: <20250304153801.597907-1-mkoutny@suse.com> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Use one set of files when there is no difference between default and legacy files, similar to regular subsys files registration. No functional change. Signed-off-by: Michal Koutný --- block/blk-cgroup.c | 7 +++++-- block/blk-ioprio.c | 23 +++++++---------------- include/linux/cgroup.h | 1 + kernel/cgroup/cgroup.c | 2 +- 4 files changed, 14 insertions(+), 19 deletions(-) diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c index b77219dd8b061..db6adc8a7ff41 100644 --- a/block/blk-cgroup.c +++ b/block/blk-cgroup.c @@ -1771,12 +1771,15 @@ int blkcg_policy_register(struct blkcg_policy *pol) mutex_unlock(&blkcg_pol_mutex); /* everything is in place, add intf files for the new policy */ - if (pol->dfl_cftypes) + if (pol->dfl_cftypes == pol->legacy_cftypes) { + WARN_ON(cgroup_add_cftypes(&io_cgrp_subsys, + pol->dfl_cftypes)); + } else { WARN_ON(cgroup_add_dfl_cftypes(&io_cgrp_subsys, pol->dfl_cftypes)); - if (pol->legacy_cftypes) WARN_ON(cgroup_add_legacy_cftypes(&io_cgrp_subsys, pol->legacy_cftypes)); + } mutex_unlock(&blkcg_pol_register_mutex); return 0; diff --git a/block/blk-ioprio.c b/block/blk-ioprio.c index 8fff7ccc0ac73..13659dc15c3ff 100644 --- a/block/blk-ioprio.c +++ b/block/blk-ioprio.c @@ -113,27 +113,18 @@ static void ioprio_free_cpd(struct blkcg_policy_data *cpd) kfree(blkcg); } -#define IOPRIO_ATTRS \ - { \ - .name = "prio.class", \ - .seq_show = ioprio_show_prio_policy, \ - .write = ioprio_set_prio_policy, \ - }, \ - { } /* sentinel */ - -/* cgroup v2 attributes */ static struct cftype ioprio_files[] = { - IOPRIO_ATTRS -}; - -/* cgroup v1 attributes */ -static struct cftype ioprio_legacy_files[] = { - IOPRIO_ATTRS + { + .name = "prio.class", + .seq_show = ioprio_show_prio_policy, + .write = ioprio_set_prio_policy, + }, + { } /* sentinel */ }; static struct blkcg_policy ioprio_policy = { .dfl_cftypes = ioprio_files, - .legacy_cftypes = ioprio_legacy_files, + .legacy_cftypes = ioprio_files, .cpd_alloc_fn = ioprio_alloc_cpd, .cpd_free_fn = ioprio_free_cpd, diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h index f8ef47f8a634d..8e7415c64ed1d 100644 --- a/include/linux/cgroup.h +++ b/include/linux/cgroup.h @@ -113,6 +113,7 @@ int cgroup_transfer_tasks(struct cgroup *to, struct cgroup *from); int cgroup_add_dfl_cftypes(struct cgroup_subsys *ss, struct cftype *cfts); int cgroup_add_legacy_cftypes(struct cgroup_subsys *ss, struct cftype *cfts); +int cgroup_add_cftypes(struct cgroup_subsys *ss, struct cftype *cfts); int cgroup_rm_cftypes(struct cftype *cfts); void cgroup_file_notify(struct cgroup_file *cfile); void cgroup_file_show(struct cgroup_file *cfile, bool show); diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c index 3a5af0fc544a6..e93b0563a8964 100644 --- a/kernel/cgroup/cgroup.c +++ b/kernel/cgroup/cgroup.c @@ -4447,7 +4447,7 @@ int cgroup_rm_cftypes(struct cftype *cfts) * function currently returns 0 as long as @cfts registration is successful * even if some file creation attempts on existing cgroups fail. */ -static int cgroup_add_cftypes(struct cgroup_subsys *ss, struct cftype *cfts) +int cgroup_add_cftypes(struct cgroup_subsys *ss, struct cftype *cfts) { int ret;