From patchwork Wed Mar 5 03:44:10 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stanley Chu X-Patchwork-Id: 14001984 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9EB3DC282D3 for ; Wed, 5 Mar 2025 04:44:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rVX38OzyB8buiIktVdALjdZvLPNO7X5PMsyOM4l0Ik4=; b=W0oDya2vqNhvNZ GD/uLtX8jDv+yfa8WJrpsTj6NAIx/o0aowkQHizWQfCjIBs9MiMBPiNTEmAO0qx0gN/JEGkJk+gnM mrhLbhFrsf9J4xOmq4i50d4r6DeeFIoJpya2uj6rLyCbPz0MGjtOFI5Th/phDUzuCAfHzTcSNdKZc WgJN9rkNY9/9vktgGlU0WXZYfm4omVL/C5516O7cRD/daD1VGi+lJOpwVq8L/rzqge2itFuYbwgGO 4nffbhS3Ytu0I6ZV8iLHprLh1grkcavBl0/Xc+gFpX8mrNzzhWpBCkKQ0t0c9kSw+DBYvNA5ZMrMT /1COevkVeDu3qEpExagw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tpgcm-00000006yjU-1gkb; Wed, 05 Mar 2025 04:44:52 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tpfga-00000006typ-3MG3 for linux-i3c@bombadil.infradead.org; Wed, 05 Mar 2025 03:44:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:MIME-Version :References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=TbBWp8Gpp+tRkxfYN3BsRLi83MVsRiY+awmccSWrlIQ=; b=g+xN3bJ/pi8ovCQlkK3QV2j0+D /JUA/JPHsYGmbNyRAl/7raShMpc09dzGWktiTQ6dWwktNAuvfivJFutmZ5ArFItDVFK4zyNiJaqpu +oJvCtZ1+tMuqUuWMKzrQsQ/LFHyunTD/sh7LcOEYe2dB2hlskUnOzc9FeP1biAOX/fWXuGpzuXWe +oczCn7MyviRU6S38ey6XATzbIcA2M/g08VRRMCimPfSwO8ZpwbflJ940p8tDvrELu5iX1zuDsEri qx/7Co6hROmH/6kmGxy9jcp9OOTq0CNUYLIIZ4mEtMdY+Fb0Cg67eCUByi+VClYgLqlT6gfQ0ud6B QH9coMxw==; Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]) by desiato.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tpfgX-00000000LUg-2PdO for linux-i3c@lists.infradead.org; Wed, 05 Mar 2025 03:44:43 +0000 Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-2234daaf269so104128905ad.3 for ; Tue, 04 Mar 2025 19:44:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741146280; x=1741751080; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TbBWp8Gpp+tRkxfYN3BsRLi83MVsRiY+awmccSWrlIQ=; b=KWfT9ZyE1CZaM6WCAwwr3vnzYKM3XNnkVRtuIQ7JeaTyyDrAO/sMZm1BAy7KLVyFk+ OpShbC6bOI+arXOVzz2G3+ih/w5p867UYw2L3fMHR4dBMoqTMQm6soaJZXd9CNJS9ZCt BosjOAd01eUl1xBiVtw8oAzA1cVbZkOhWwrlO20+6JQZPNNENcuh0EiuuSRiaifzCE62 Ner3IPuLvMMdaP0ke4ByAaGAnYiL9u2qiXCSMsUdxpneMF1uw+PvjD1biWX60YgKp/BK vIkPuf24DCwJ29XbP4PnOAmVO8Qj6+eCDMws7gGqiWCg2NlYAfkE0o+/Wq7exQbmAbrd HK7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741146280; x=1741751080; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TbBWp8Gpp+tRkxfYN3BsRLi83MVsRiY+awmccSWrlIQ=; b=WroU95yvdqCy7pmTgEiJ+D4TYF5z0xXpt8/vaZf6bhxlLnJE7mAc6XvNxPjPnAyoQu HdbHdLkZNspm/ogBuH3rJpzpPBpU2h1YvOHXv4bT+zBI0zO76j4wjPqIcDpx5Kf310VU mdCZdUx4qf+INpPGJQ9DwBbQ6Z4Y/RQBpFvA3q3bgCsLZm6saIfmJD9jw3J0nGuY7VRV agcFNf01U1bIkbdQclCf6jyXlaQze/0OJZGyFIV10myokjjxOY4tFEUD7JE1pvbOggZ0 7JqkRdZhFq9l9O0eT9T/KAxOIYx3eVPogaB1Y0f1uw/99C4Ej+bThDsp22ZToiBdePW4 w4bA== X-Forwarded-Encrypted: i=1; AJvYcCU1cOuRYta1L+TUTAMCysmK5jnBoTDrpjKEfnjS6ArE3K1zzbCA9dI36ol5crTY/O6yM9ouxLv0yU4=@lists.infradead.org X-Gm-Message-State: AOJu0YyIj9dJf4P/1V3xCBxRIx4EOvj/0hxbklvAmK/19jVzB9duAf76 PAi8k8b7UcZ6s6EZUksxYJppz8SM0HTao96RcTBbshURU3Fdt0VT X-Gm-Gg: ASbGncvDeO/p2BpisGMJxC7++ZBv6hT4xT07+yGHPIPvDwa4ZjkYfOSk62JojEsGyT3 zhwMYqmwUbdbIG6y/8VM5rkS79HVugIOjLWh7T56sXsZnBXak2TRpJ7xAaszu3HS/YQ66Eyj1fa jEG2uLDcqgERi0u5iWeShD+rbnTVQQRa+djk0BA/blap6sFeNCNSDO3ozWIAHo79DAA3wmAcQ5e AydkE18jQJa1lwrxIqTsRgRW+jAx6U4k4o/WKZS7HHJI9XqvU3owjNvJNGWvVnEPLS1Vb8ihkuL fhVh0esFpmLWI2skgO5viIODKRDRujxKF3t5XzjSW9lXuI82V/53K4A= X-Google-Smtp-Source: AGHT+IEtVqtQQnVo8PHaSXN1K3Sc2Cf8P+sKm3QdUVwoE0JuCrOF0cXwevOrjax0u+LApJLfkKso+w== X-Received: by 2002:a17:902:ec82:b0:223:5c33:56a8 with SMTP id d9443c01a7336-223f1d26109mr25099565ad.35.1741146280016; Tue, 04 Mar 2025 19:44:40 -0800 (PST) Received: from cs20-buildserver.lan ([2403:c300:d305:9d26:2e0:4cff:fe68:863]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-223504c5c37sm102734335ad.133.2025.03.04.19.44.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 19:44:39 -0800 (PST) From: Stanley Chu X-Google-Original-From: Stanley Chu To: frank.li@nxp.com, miquel.raynal@bootlin.com, alexandre.belloni@bootlin.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, tomer.maimon@nuvoton.com, kwliu@nuvoton.com, yschu@nuvoton.com Subject: [PATCH v6 1/5] dt-bindings: i3c: silvaco: Add npcm845 compatible string Date: Wed, 5 Mar 2025 11:44:10 +0800 Message-Id: <20250305034414.2246870-2-yschu@nuvoton.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250305034414.2246870-1-yschu@nuvoton.com> References: <20250305034414.2246870-1-yschu@nuvoton.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250305_034441_996814_38847C3F X-CRM114-Status: UNSURE ( 9.62 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org From: Stanley Chu Nuvoton npcm845 SoC uses the same Silvico IP but an older version. Need to add a new compatible string to distinguish between different hardware versions. Reviewed-by: Frank Li Acked-by: Krzysztof Kozlowski Signed-off-by: Stanley Chu --- Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml index c56ff77677f1..4fbdcdac0aee 100644 --- a/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml +++ b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml @@ -14,7 +14,9 @@ allOf: properties: compatible: - const: silvaco,i3c-master-v1 + enum: + - nuvoton,npcm845-i3c + - silvaco,i3c-master-v1 reg: maxItems: 1 From patchwork Wed Mar 5 03:44:11 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stanley Chu X-Patchwork-Id: 14002016 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C0147C19F32 for ; Wed, 5 Mar 2025 05:59:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hKYHxyJkW7B1ze7XOkTdOZmh0uMEdVuySDNAui0Nfo4=; b=l+D7bhJaF9hfg2 HtudYo0F36l4//Pn8DpMZQvWkNlm6Rm19Jpc1mRFBEcuJDdF7lsrSah6v1nmk27htlBEwUjZ65FP+ CiivmOAaitOYtrqkCNpgPhCE4RvMR7PidX0v2XPB/dJRiVDeMTY72uWvjJj4JDS3GrovdJ3SyZY5s m0rB0kc7JFTjHO1sacMSW9ipBKnEUEnQd/XIjz9pkX14TQvmWIYMwze4cZm1i5dKze9atfH/dq84C 2KJxRBri7467Bphmi96gittePkFQzJpFwWaCxGzDghU/0ZKfq+udWBbvsm14N0dea9PpOJEVfyblm vPmUMv1fzEg1A2Wp4iVw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tphnM-000000074l0-2IFd; Wed, 05 Mar 2025 05:59:52 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tpfgf-00000006tzm-1j0o for linux-i3c@bombadil.infradead.org; Wed, 05 Mar 2025 03:44:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:MIME-Version :References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=VxSorQjSMBJHTcXavhQOvOimi4+hQN1XV3dQDpeZRl4=; b=pxwOv3sbrkzLGDRfJXM8RQ7aQX xyPpMRodAew4ohnraAVbWaA5IwA/l8wCyWRKLqObfAZwk9Hb1mwwe1hZzeG8t6xbY7+DzxqkeVRuQ lJU5+JCTZJLlU3q3xNl+mcf3IlwXenWz02VtPP29bkjtuPJAsgfOo0BTnQw6caBByQGk1XvgImTzq q68QMNELsjyls+cf8rsnyEp/QiOGBMNos73ZZ7Hysf9Hm3Be8RJcWgPX3cnvu1BvWoAE0zwwUYzFN IZkXKCqha81qSOLAxUo38+QbiC6lHTw9or7x0K9TJ1ZAHma/yq07IaPSfIwJp/TJMZ7PUtlWdgmc5 qZ5qv2GQ==; Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]) by desiato.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tpfgb-00000000LVA-2FuN for linux-i3c@lists.infradead.org; Wed, 05 Mar 2025 03:44:47 +0000 Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-22398e09e39so59646735ad.3 for ; Tue, 04 Mar 2025 19:44:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741146283; x=1741751083; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VxSorQjSMBJHTcXavhQOvOimi4+hQN1XV3dQDpeZRl4=; b=bmofAbf4EYMNoqSdKJKZRdeKN/4JwXSg58nXkR6eJN6fJe2f9BSIJ9UpORRz7GRW/S jnQ0OzTgb66JuI6gWCGEzxLcC6pcwWHKyV3bWdFz+FF61MtdThGOEHuTeAnRDU7+wcPM hAPoU4ttbl6Qxb91ukcM/TuoVhf1WRGfWom5IKWBzQ1+XcF2AxqYEUC7n5oH54Xe7kJo rg5/9tvhCPjXyisFk6La96iosLJFakF+TZv9RHsMCFMl/Cat1rV2GfDy6XUk6rm2QS+3 FUVXlZC0Cd1vkPM7ceE2MiifD2F1HKNX/LDqEr89y1FVtjeaz+eg8N/kjswVvBxy9mpv nl7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741146283; x=1741751083; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VxSorQjSMBJHTcXavhQOvOimi4+hQN1XV3dQDpeZRl4=; b=gtOKM5da+nCPsAYyQ6W4wGqN5J4dRoQ7dxkoW3PWCcI+q1l7zcxVNxpUex3wYKL+E0 ImbFDO4A4lL6sfVHf3tWmEyCrzdWmiG0JDcK06dkZODwTokUUqgvH1YBQIQvgpbeD96y rs5kG3xd1EawZlJWPesNtmg5B/zsXs+JVtqZX1gZ4XkJ2ujvuoZgsnawRpukGb27RbAp tylNP/BBZf2Oa38ONXEhooB2U4mVsHzJxk46aJNto4V58XESkF5zPW8jLzcTOBjWNKEK k6zsapfcs8Qkem1tEdmpy6179YO30MbKk+mgHtOqrdE1R3I/gbSAEMt814be+mIrD2UG 9vdg== X-Forwarded-Encrypted: i=1; AJvYcCVt3f2hqJnO3hGmoNHCIrTUFO8IHIJty4eP5N7WVPFqamG9mEOTqOSVVikVZT1VmxDHZGKHeQq8Lbo=@lists.infradead.org X-Gm-Message-State: AOJu0Yw+YhtFJxtlv7kVQXKXHl+aindEsptSsYMuy0/HKJ18AXbvJMXC TfYQ0UDVgAb4pkYuCTC3tBwe9IZ4zDZQqeNlwsaHZVwFoVFDUi/g X-Gm-Gg: ASbGncttwDcrYOqpUIwgIiVhOuDz0AGkdvaQjMI6e4y7JSOuUY8S+gyj6dj1h4+OVqq gOdQUfnOAE+Dkwnb5hhulvdmNJDszm9h1KLpdY/hT4unhwwvLsjYVSGrkb+TJiJXhjQ9MQFVkUG xSAE5hTuzvlrMkO4jKZ1DFd/xMgSFgGC9KJO/V+9JKNDurfUo9fEqhLbGoebdOmH0TpaMyQ+oau yhbS9gcn1reZZc34SQ8DzCS8DqwBYEmsyZ1chmRK38ADg8GDhdxLYVl+coFixlNOKKZIPAkjPlL ynvKklYbTW1KcxbRWanuhtqtfLrRvTcGAxXGl36g70rnWHlCRrUQoAI= X-Google-Smtp-Source: AGHT+IEN4FhUYURRgYRRhgTu3XPVnsiW8vehuNjd+QA5rMsT8ISHbmnMzH5qpu1A6/3fHjlDi0Nr1w== X-Received: by 2002:a17:902:ec90:b0:21f:4c65:6290 with SMTP id d9443c01a7336-223f1c7d39emr24886825ad.1.1741146282851; Tue, 04 Mar 2025 19:44:42 -0800 (PST) Received: from cs20-buildserver.lan ([2403:c300:d305:9d26:2e0:4cff:fe68:863]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-223504c5c37sm102734335ad.133.2025.03.04.19.44.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 19:44:42 -0800 (PST) From: Stanley Chu X-Google-Original-From: Stanley Chu To: frank.li@nxp.com, miquel.raynal@bootlin.com, alexandre.belloni@bootlin.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, tomer.maimon@nuvoton.com, kwliu@nuvoton.com, yschu@nuvoton.com Subject: [PATCH v6 2/5] i3c: master: svc: Add support for Nuvoton npcm845 i3c Date: Wed, 5 Mar 2025 11:44:11 +0800 Message-Id: <20250305034414.2246870-3-yschu@nuvoton.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250305034414.2246870-1-yschu@nuvoton.com> References: <20250305034414.2246870-1-yschu@nuvoton.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250305_034445_748566_6A74BE33 X-CRM114-Status: GOOD ( 13.28 ) X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org From: Stanley Chu Nuvoton npcm845 SoC uses an older IP version, which has specific hardware issues that need to be addressed with a different compatible string. Add driver data for different compatible strings to define platform specific quirks. Add compatible string for npcm845 to define its own driver data. Signed-off-by: Stanley Chu --- drivers/i3c/master/svc-i3c-master.c | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c index d6057d8c7dec..7cafdc8fd1ad 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -158,6 +158,10 @@ struct svc_i3c_regs_save { u32 mdynaddr; }; +struct svc_i3c_drvdata { + u32 quirks; +}; + /** * struct svc_i3c_master - Silvaco I3C Master structure * @base: I3C master controller @@ -183,6 +187,7 @@ struct svc_i3c_regs_save { * @ibi.tbq_slot: To be queued IBI slot * @ibi.lock: IBI lock * @lock: Transfer lock, protect between IBI work thread and callbacks from master + * @drvdata: Driver data * @enabled_events: Bit masks for enable events (IBI, HotJoin). * @mctrl_config: Configuration value in SVC_I3C_MCTRL for setting speed back. */ @@ -214,6 +219,7 @@ struct svc_i3c_master { spinlock_t lock; } ibi; struct mutex lock; + const struct svc_i3c_drvdata *drvdata; u32 enabled_events; u32 mctrl_config; }; @@ -1817,6 +1823,10 @@ static int svc_i3c_master_probe(struct platform_device *pdev) if (!master) return -ENOMEM; + master->drvdata = of_device_get_match_data(dev); + if (!master->drvdata) + return -EINVAL; + master->regs = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(master->regs)) return PTR_ERR(master->regs); @@ -1958,8 +1968,13 @@ static const struct dev_pm_ops svc_i3c_pm_ops = { svc_i3c_runtime_resume, NULL) }; +const struct svc_i3c_drvdata npcm845_drvdata = {}; + +const struct svc_i3c_drvdata svc_default_drvdata = {}; + static const struct of_device_id svc_i3c_master_of_match_tbl[] = { - { .compatible = "silvaco,i3c-master-v1"}, + { .compatible = "nuvoton,npcm845-i3c", .data = &npcm845_drvdata }, + { .compatible = "silvaco,i3c-master-v1", .data = &svc_default_drvdata }, { /* sentinel */ }, }; MODULE_DEVICE_TABLE(of, svc_i3c_master_of_match_tbl); From patchwork Wed Mar 5 03:44:12 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stanley Chu X-Patchwork-Id: 14002018 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8A3E0C19F32 for ; Wed, 5 Mar 2025 06:14:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5ywuB66xi5NLUWieQb7EG5eDswTs8OndozPw99TFTi8=; b=r0d+yDl4XRNsgJ MqHuI3zbvZktUK3sdyhF+n9D7Csgq9tMZNeb0YwniWQYkuj7TXZCqx4x2I3bC2mI+efpc5kEL8nQ5 483hhSIs5QFMXQGJ7axG2iB//lumHxaxn1wkIwHwgjuYgt3456Tc4of1ynrLjr77SqaBnv8mI3Xud bl+Iqs2hFJ5mUG3uDuGWCoR/aKjER9vcfGXXP0/G7zh6gUVxYTgityHIhLKZD0Jnu+GnAwQXwSBJN PcBOiFjPvsVcgk+jUESdvdLdSKq26eGMDmXUoR8syJLqDuFn6/HH2q4T8LxSBhxIKiefZt6F+d2Rq +2QogmjFVmwHr/oR+xSw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tpi1s-000000076AW-0f4A; Wed, 05 Mar 2025 06:14:52 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tpfgj-00000006u0q-2EJ3 for linux-i3c@bombadil.infradead.org; Wed, 05 Mar 2025 03:44:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:MIME-Version :References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=K5XgaLNVCOBJH6qLNdTYPllzrDzuWjs4hTrWU2in37A=; b=ovP2o/ZMmApuntAC0BfvJnnsJY AdCQPtcVuiKodbnS/pdacapOUw/NOEKzoS9bIUBNb5vKvlxVsBxTGy94ZO2eLsH9ohS7Q+9Sz108M 1s7z139LwgtFBlxHIBp0B5IcrmjP3cbVQOEkFMpaklIX264//tJudZ/AJ2fnneJEsBlofyZT+I9S9 1YZ8Rb9j8ZQV6kGqylizvtoz//MBoCKdzvstJilrkS51ovKNMwatQ4pkGijgs6y52WGx0gEz+G2/H bTtPyL9fELKgae1skze7mzG6ZJCKJuMi6AxXnPp6arnj27OFcwnYApKJeL5LvcecRNjlV0IsFt1Zy PtmUlIXQ==; Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]) by desiato.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tpfgd-00000000LVV-2Vkk for linux-i3c@lists.infradead.org; Wed, 05 Mar 2025 03:44:49 +0000 Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-22349bb8605so122796835ad.0 for ; Tue, 04 Mar 2025 19:44:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741146286; x=1741751086; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=K5XgaLNVCOBJH6qLNdTYPllzrDzuWjs4hTrWU2in37A=; b=mbwvrJTKEonFt+inB6dfF8MwDviCtPPKjcmmlewzAIuT+1EthN3p3g1+ETCO8NhDTG XngcpiJWj6G1X9zAT00OQQarAiTa0mlTb6EaEooikq+4BSxSdqFgTizuT1rbDE4uc1Ia ZpD81fXPhgeDUy57Bzk7QHRDrm8hykbyGWY5jiWi2D8U/CM4NGNeZyFrPRbdugH66NGY EdH4M7ARl2Opmiz7EpwsNJW2HJic/jASpf0tDLnj/9XwShxk0Qzit1B01vIC6tGo67eN uiF3Jp0ncxQkEfweEcYz3UOP3qn90CBMGpS1AyV2KjnGX2e5vRvafPsJjNfwmVW1kuOE 97pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741146286; x=1741751086; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=K5XgaLNVCOBJH6qLNdTYPllzrDzuWjs4hTrWU2in37A=; b=t0i5J6VktLxP/UFgEQIOsO3T9G6piR89Y2KPfzZXMWY8nAFBS5imKNApIL62kWbxkc 6Q2ct22ywtabWg65UjgT86V08nqn6TecGW6RQW4/sxQ6LDeKWr0t7ULLJM/b3ASa000l M/A55aHAx4UJsrGKGy8xPzcDSaDfC0NoRcmK4BXrK8UXrmy4nj/eT8eEo5r4JJ7GgsCU Xv8DlQrrhxsTLz4BL4qOYRyIMF7VCsWFR+HBkOdGw70VpIxo6/yRWTCrKQInEQCsEfVj ZeWvyzNsWYJRhhBd+rLVc47wJRgHZghxep7vHgqJ+Vk0VO17JH78CkiiLbJfHkwhUHn4 kJEg== X-Forwarded-Encrypted: i=1; AJvYcCVrN7kbOppIzj1WY1sqLMf/V97+gs3pm37c0iJ67dMty8sx6iI8PI+8amEeMlXi7YY1vuH2l32JrRI=@lists.infradead.org X-Gm-Message-State: AOJu0YyTBnIK+SriAN07A0TZYr8Se9vV8ILLc+51Q4TekcoFbCjV/QfK 0OJL+InWj8KG6riqtuKINlITRS5prsI9FubGrp6tWdgbbNFYjSft X-Gm-Gg: ASbGncsopL9ljPoRdTv6uVuIoL9TXYcSq8i3kjgCcFyDS+ILuGb3rhgcxlBwmWEJnXe 1aGDI6vk1NCLu2ZTccU5IRA0znFu9qbg6ooMe5pxgnKXL0zu/zR3ybuJ1swsve9PJ0lL1Zim/2l vSR30PS3JQKt9qn21A4sPyqIyQVEzfA0SRkCNpB3wUkqPuxoom5EJod/DNGIPmuQr/UP5EXP3z8 q8EonIcBu5egHktuShZvb5UZK8HaAZb/Mhm7m/Aa1K0RM1OuzLrm1d/shugCXIg849kF4LzYoiK q2ICKvF9GzeHWzfqpCLWtvd+4D2UJSyspUAF+Q/QOH4c6dgm113V8p4= X-Google-Smtp-Source: AGHT+IGPoR5eAIQW9xdEo8WStH1w40nmyMmwzBz1XdEZxtqBN5FLjqj3BW1bdcFkkK22otVnGbjCBA== X-Received: by 2002:a17:902:ecca:b0:215:8809:b3b7 with SMTP id d9443c01a7336-223f1c6b194mr22922005ad.7.1741146285606; Tue, 04 Mar 2025 19:44:45 -0800 (PST) Received: from cs20-buildserver.lan ([2403:c300:d305:9d26:2e0:4cff:fe68:863]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-223504c5c37sm102734335ad.133.2025.03.04.19.44.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 19:44:45 -0800 (PST) From: Stanley Chu X-Google-Original-From: Stanley Chu To: frank.li@nxp.com, miquel.raynal@bootlin.com, alexandre.belloni@bootlin.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, tomer.maimon@nuvoton.com, kwliu@nuvoton.com, yschu@nuvoton.com Subject: [PATCH v6 3/5] i3c: master: svc: Fix npcm845 FIFO empty issue Date: Wed, 5 Mar 2025 11:44:12 +0800 Message-Id: <20250305034414.2246870-4-yschu@nuvoton.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250305034414.2246870-1-yschu@nuvoton.com> References: <20250305034414.2246870-1-yschu@nuvoton.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250305_034448_165594_066ECF47 X-CRM114-Status: GOOD ( 21.35 ) X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org From: Stanley Chu I3C HW stalls the write transfer if the transmit FIFO becomes empty, when new data is written to FIFO, I3C HW resumes the transfer but the first transmitted data bit may have the wrong value. Fill the FIFO in advance to prevent FIFO from becoming empty. Reviewed-by: Frank Li Signed-off-by: Stanley Chu --- drivers/i3c/master/svc-i3c-master.c | 71 +++++++++++++++++++++++++---- 1 file changed, 61 insertions(+), 10 deletions(-) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c index 7cafdc8fd1ad..46b032b61f3c 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -113,6 +113,7 @@ #define SVC_I3C_MWDATAHE 0x0BC #define SVC_I3C_MRDATAB 0x0C0 #define SVC_I3C_MRDATAH 0x0C8 +#define SVC_I3C_MWDATAB1 0x0CC #define SVC_I3C_MWMSG_SDR 0x0D0 #define SVC_I3C_MRMSG_SDR 0x0D4 #define SVC_I3C_MWMSG_DDR 0x0D8 @@ -133,6 +134,16 @@ #define SVC_I3C_EVENT_IBI GENMASK(7, 0) #define SVC_I3C_EVENT_HOTJOIN BIT(31) +/* + * SVC_I3C_QUIRK_FIFO_EMPTY: + * I3C HW stalls the write transfer if the transmit FIFO becomes empty, + * when new data is written to FIFO, I3C HW resumes the transfer but + * the first transmitted data bit may have the wrong value. + * Workaround: + * Fill the FIFO in advance to prevent FIFO from becoming empty. + */ +#define SVC_I3C_QUIRK_FIFO_EMPTY BIT(0) + struct svc_i3c_cmd { u8 addr; bool rnw; @@ -236,6 +247,11 @@ struct svc_i3c_i2c_dev_data { struct i3c_generic_ibi_pool *ibi_pool; }; +static inline bool svc_has_quirk(struct svc_i3c_master *master, u32 quirk) +{ + return (master->drvdata->quirks & quirk); +} + static inline bool is_events_enabled(struct svc_i3c_master *master, u32 mask) { return !!(master->enabled_events & mask); @@ -894,7 +910,7 @@ static int svc_i3c_master_do_daa_locked(struct svc_i3c_master *master, u8 *addrs, unsigned int *count) { u64 prov_id[SVC_I3C_MAX_DEVS] = {}, nacking_prov_id = 0; - unsigned int dev_nb = 0, last_addr = 0; + unsigned int dev_nb = 0, last_addr = 0, dyn_addr; u32 reg; int ret, i; @@ -937,6 +953,25 @@ static int svc_i3c_master_do_daa_locked(struct svc_i3c_master *master, if (SVC_I3C_MSTATUS_RXPEND(reg)) { u8 data[6]; + /* + * One slave sends its ID to request for address assignment, + * prefilling the dynamic address can reduce SCL clock stalls + * and also fix the SVC_I3C_QUIRK_FIFO_EMPTY quirk. + * + * Ideally, prefilling before the processDAA command is better. + * However, it requires an additional check to write the dyn_addr + * at the right time because the driver needs to write the processDAA + * command twice for one assignment. + * Prefilling here is safe and efficient because the FIFO starts + * filling within a few hundred nanoseconds, which is significantly + * faster compared to the 64 SCL clock cycles. + */ + dyn_addr = i3c_master_get_free_addr(&master->base, last_addr + 1); + if (dyn_addr < 0) + return -ENOSPC; + + writel(dyn_addr, master->regs + SVC_I3C_MWDATAB); + /* * We only care about the 48-bit provisioned ID yet to * be sure a device does not nack an address twice. @@ -1015,21 +1050,16 @@ static int svc_i3c_master_do_daa_locked(struct svc_i3c_master *master, if (ret) break; - /* Give the slave device a suitable dynamic address */ - ret = i3c_master_get_free_addr(&master->base, last_addr + 1); - if (ret < 0) - break; - - addrs[dev_nb] = ret; + addrs[dev_nb] = dyn_addr; dev_dbg(master->dev, "DAA: device %d assigned to 0x%02x\n", dev_nb, addrs[dev_nb]); - - writel(addrs[dev_nb], master->regs + SVC_I3C_MWDATAB); last_addr = addrs[dev_nb++]; } /* Need manual issue STOP except for Complete condition */ svc_i3c_master_emit_stop(master); + svc_i3c_master_flush_fifo(master); + return ret; } @@ -1226,6 +1256,24 @@ static int svc_i3c_master_xfer(struct svc_i3c_master *master, SVC_I3C_MCTRL_RDTERM(*actual_len), master->regs + SVC_I3C_MCTRL); + /* + * The entire transaction can consist of multiple write transfers. + * Prefilling before EmitStartAddr causes the data to be emitted + * immediately, becoming part of the previous transfer. + * The only way to work around this hardware issue is to let the + * FIFO start filling as soon as possible after EmitStartAddr. + */ + if (svc_has_quirk(master, SVC_I3C_QUIRK_FIFO_EMPTY) && !rnw && xfer_len) { + u32 end = xfer_len > SVC_I3C_FIFO_SIZE ? 0 : SVC_I3C_MWDATAB_END; + u32 len = min_t(u32, xfer_len, SVC_I3C_FIFO_SIZE); + + writesb(master->regs + SVC_I3C_MWDATAB1, out, len - 1); + /* Mark END bit if this is the last byte */ + writel(out[len - 1] | end, master->regs + SVC_I3C_MWDATAB); + xfer_len -= len; + out += len; + } + ret = readl_poll_timeout(master->regs + SVC_I3C_MSTATUS, reg, SVC_I3C_MSTATUS_MCTRLDONE(reg), 0, 1000); if (ret) @@ -1314,6 +1362,7 @@ static int svc_i3c_master_xfer(struct svc_i3c_master *master, emit_stop: svc_i3c_master_emit_stop(master); svc_i3c_master_clear_merrwarn(master); + svc_i3c_master_flush_fifo(master); return ret; } @@ -1968,7 +2017,9 @@ static const struct dev_pm_ops svc_i3c_pm_ops = { svc_i3c_runtime_resume, NULL) }; -const struct svc_i3c_drvdata npcm845_drvdata = {}; +const struct svc_i3c_drvdata npcm845_drvdata = { + .quirks = SVC_I3C_QUIRK_FIFO_EMPTY, +}; const struct svc_i3c_drvdata svc_default_drvdata = {}; From patchwork Wed Mar 5 03:44:13 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stanley Chu X-Patchwork-Id: 14002019 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DB1A2C282D9 for ; Wed, 5 Mar 2025 06:14:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8fZ8neCQDUobx+hnVkpfNsi5+e2LJdksCstiPpPz82w=; b=sKhVlGgs4/73gc ljIWruWUTjlNDfdFcKPZkIAsCkQltnilo/8S1XApI697cnfh27uLrfmsA0E3WHNKsC1ySwiAVwfhT 4XwE1yTRHLihvhqrRfcRhdx3wv2XwH2QX8ITb7UlVZAnCmB9R9gkqF8i5+U8mlzYnVlqyZKBP30WN kvPjs2otMnuLDbmmfujM1kWKOZbnECsUclHouncfU4cNiVxx9XXfqcu0glcsazhxNG1XjgmM6ZJLj fpITncNDhUqZndGgWEHmpkMXA+FIAr/rGp8OUHb9lm6pjGInPiNu4JhsbTDIchR/u70Xu+ctXMGYk lmsz909mZfdpIC9la85w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tpi1s-000000076Ae-1tvL; Wed, 05 Mar 2025 06:14:52 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tpfgm-00000006u1e-3emx for linux-i3c@bombadil.infradead.org; Wed, 05 Mar 2025 03:44:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:MIME-Version :References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=rWiOwn7nT5PFN7bTmIow5wbcXHHUl8L4grOIfv03884=; b=H/+rHrts2JUp0kf9wBtAzwkdWV ylUWiLPSnfkNqo3YCa2iscDXy8RTayKdvWpeK0dOjPMI6Ws0qBGyZ48YgKLlyiUez0Tif/dOnhWDa qL3Z/8h4f/slzzuuswT+fip72oTr8TYTkIoQQzTkteW5OGzpBhcFiRUF3ddtvhcCyH61kCYHAJuhD QmS2Qs3uv8eKJjvaU4zsUg1ZNbEJhw+l9+qkGVpe6ZMcaz0mCmbqN+GV5gZg7s9V8YnN0crTgbrQj o9kwK6yoGkc23lfZ8jhj96y3Vvc2U1mWxrrKg7U1M4bsLV1tE3YbbIbHndeiTOhH7jI+rtKY6Ijw0 ZCmkNO+Q==; Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]) by desiato.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tpfgh-00000000LW4-42KB for linux-i3c@lists.infradead.org; Wed, 05 Mar 2025 03:44:55 +0000 Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-22349bb8605so122797095ad.0 for ; Tue, 04 Mar 2025 19:44:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741146288; x=1741751088; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rWiOwn7nT5PFN7bTmIow5wbcXHHUl8L4grOIfv03884=; b=NWKll3H59Rojem/w5jp8IB5ms4eBe1LxcSX45WbtsZm2gFVybw+kqRGu98Wc9pzAfn RcXnWemOlTtvVFQiWQeFiepeskZqI25Bj7uwZ9MaiJ01BLz3786WakiDKmrwkjpc4dOe fRvN8DDhS7W7MmeSth4tcXC27V9VjxcR1NmrHNBx2EFYR4ft0qL6Y0Z5yMV2SI16uLyt EASK1eM9IxXdrolb718Ba5LicINR4AXjV0fzlN4TKCXeCGkGOJr1Wmuke6VFypMJWAMq unU7bDKbxT2mwsPIre/EJOPCtJbYPLOXuO3hL4qS/88f0fkqTpg4qTwmNrTHcj98SfyL ihqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741146288; x=1741751088; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rWiOwn7nT5PFN7bTmIow5wbcXHHUl8L4grOIfv03884=; b=Eqil5C8tWSr9X/sTYXEYXVo1eYQgC/Z0GeM7Evo5OS5QYw7F3e7O6wC0aSzF8jWOPI zX+dKcWof4oWueo4NRBRkvs4sPhvawHZmK5H5nEpbaIxXhh6b/BdTc0mjWMcMqcTc+gg rTkT0jRo9J3GD3Z7fEqn5CfgiUx7Dq9belylBIw2k9x5c+gtLbKR5P1nlYCvIr4eKDUc rWZqov+6husb55NInv/RXHmASqSgwlSdWMdX53KWveUYGJRwhpbmV5xANcQVtGgMpO8Z 6AbJxUeIxlLZeb8xt8WBt3LJTcz+Ia9S4EG+uQ5FOlCI+by+ch/hDY8Y+klb/aTaX/jz BU+w== X-Forwarded-Encrypted: i=1; AJvYcCXx7wmqakjSRjkqi6GR8aPYZSin2uxf9ajQk89WZvtNA3pwhEDCXGd5YuBBmVjDA20ITU/oelAk6pM=@lists.infradead.org X-Gm-Message-State: AOJu0YziS1Y2+aWwo/yn2/N3rFCFika4Yd9B4w1j7KFsn6+h+0DrTvRW /2K5KKUMN82G0Cc71l4gpOV2qP7Fp0LOsTK46if2EffZ7CkB1ySG X-Gm-Gg: ASbGncsQ/5UKYdr1HnvPiaVpzqnwLhW3QO+9b6azbTuvAV1QwbFn8N8HsXA30jShFLm nvTOCzp1Aev6SLPL4G9th0qNgLXSD/RUmtIIOd7X+lRv44zfFYA84K6bZgwLr18aH+YoGRCzwCZ Qj0NvhB1D0W7XCfwoyqbmuvxu9KxbBSl36w+kAycuuSB55+vWYAvqIekhdmUtC1hnWFqoob7fOu TuLnwy+q0NWpC4UXxl9oXGrxYOnjp7hVgOuxLefBNHzFI8tR1xYkUhczyrwH9s9KWY5R0GXvW6I E4Ayqf3jFq9o0n4iS2S2ekibeIs5ryz/bTVE1GLD5AdL3oJn2mPg1CM= X-Google-Smtp-Source: AGHT+IF6e7ShP+dFYnCi3KFWoYYWdUXK08szUlSs8mu7o0gUCi5hQ15jqTxbMjAROfk9XAz/T2tSVg== X-Received: by 2002:a17:903:2312:b0:21f:9c48:254b with SMTP id d9443c01a7336-223f1c9945amr28241945ad.24.1741146288312; Tue, 04 Mar 2025 19:44:48 -0800 (PST) Received: from cs20-buildserver.lan ([2403:c300:d305:9d26:2e0:4cff:fe68:863]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-223504c5c37sm102734335ad.133.2025.03.04.19.44.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 19:44:48 -0800 (PST) From: Stanley Chu X-Google-Original-From: Stanley Chu To: frank.li@nxp.com, miquel.raynal@bootlin.com, alexandre.belloni@bootlin.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, tomer.maimon@nuvoton.com, kwliu@nuvoton.com, yschu@nuvoton.com Subject: [PATCH v6 4/5] i3c: master: svc: Fix npcm845 invalid slvstart event Date: Wed, 5 Mar 2025 11:44:13 +0800 Message-Id: <20250305034414.2246870-5-yschu@nuvoton.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250305034414.2246870-1-yschu@nuvoton.com> References: <20250305034414.2246870-1-yschu@nuvoton.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250305_034452_718908_0BA3C797 X-CRM114-Status: GOOD ( 13.43 ) X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org From: Stanley Chu I3C HW may generate an invalid SlvStart event when emitting a STOP. If it is a true SlvStart, the MSTATUS state is SLVREQ. Check the MSTATUS state to ignore the false event. Reviewed-by: Frank Li Signed-off-by: Stanley Chu --- drivers/i3c/master/svc-i3c-master.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c index 46b032b61f3c..5c29912e0a69 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -58,6 +58,7 @@ #define SVC_I3C_MSTATUS 0x088 #define SVC_I3C_MSTATUS_STATE(x) FIELD_GET(GENMASK(2, 0), (x)) #define SVC_I3C_MSTATUS_STATE_DAA(x) (SVC_I3C_MSTATUS_STATE(x) == 5) +#define SVC_I3C_MSTATUS_STATE_SLVREQ(x) (SVC_I3C_MSTATUS_STATE(x) == 1) #define SVC_I3C_MSTATUS_STATE_IDLE(x) (SVC_I3C_MSTATUS_STATE(x) == 0) #define SVC_I3C_MSTATUS_BETWEEN(x) FIELD_GET(BIT(4), (x)) #define SVC_I3C_MSTATUS_NACKED(x) FIELD_GET(BIT(5), (x)) @@ -143,6 +144,12 @@ * Fill the FIFO in advance to prevent FIFO from becoming empty. */ #define SVC_I3C_QUIRK_FIFO_EMPTY BIT(0) +/* + * SVC_I3C_QUIRK_FLASE_SLVSTART: + * I3C HW may generate an invalid SlvStart event when emitting a STOP. + * If it is a true SlvStart, the MSTATUS state is SLVREQ. + */ +#define SVC_I3C_QUIRK_FALSE_SLVSTART BIT(1) struct svc_i3c_cmd { u8 addr; @@ -586,6 +593,11 @@ static irqreturn_t svc_i3c_master_irq_handler(int irq, void *dev_id) /* Clear the interrupt status */ writel(SVC_I3C_MINT_SLVSTART, master->regs + SVC_I3C_MSTATUS); + /* Ignore the false event */ + if (svc_has_quirk(master, SVC_I3C_QUIRK_FALSE_SLVSTART) && + !SVC_I3C_MSTATUS_STATE_SLVREQ(active)) + return IRQ_HANDLED; + svc_i3c_master_disable_interrupts(master); /* Handle the interrupt in a non atomic context */ @@ -2018,7 +2030,8 @@ static const struct dev_pm_ops svc_i3c_pm_ops = { }; const struct svc_i3c_drvdata npcm845_drvdata = { - .quirks = SVC_I3C_QUIRK_FIFO_EMPTY, + .quirks = SVC_I3C_QUIRK_FIFO_EMPTY | + SVC_I3C_QUIRK_FALSE_SLVSTART, }; const struct svc_i3c_drvdata svc_default_drvdata = {}; From patchwork Wed Mar 5 03:44:14 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stanley Chu X-Patchwork-Id: 14002017 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4C212C282D3 for ; Wed, 5 Mar 2025 05:59:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=19sYu8kNNP4n6TDZL5JPXZbb4an5nrFMcmu/5eznU+w=; b=2Qc1bQLX7788gW a3IehbQJY7fIsHbVof1wlDNeC15Up49JPLU94ioLG6nBWvYNDLsn0r71WpZKJeNfxYfUpMq+8h50J DwMBrILra7R6E0biMYdhRhiM2edZi8LbscKnjr+j0nZ+mduecKUAJU+bFFbBE98EfKEYUUTzY9tGN OO1LRD92pkC8RIaDVJDTtffR4qq4fmLvmLqbASFkcbhEW1okqKvxsWIjl4cPvpG5TxQefpVWDV+36 zsRlnV4BikMn5mwq0iuM9L5tDGOj6H42mhRxjDkDFX96HNnwDdH/7zeUxZ0l5WgQf7L9PWRWaVV/x Y0L9IK98ntU9XnVtzc2g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tphnN-000000074lD-0IuS; Wed, 05 Mar 2025 05:59:53 +0000 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tpfgi-00000006u0a-1COh for linux-i3c@lists.infradead.org; Wed, 05 Mar 2025 03:44:53 +0000 Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-22355618fd9so109698895ad.3 for ; Tue, 04 Mar 2025 19:44:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741146291; x=1741751091; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FSYH5+SwcmtCe+p0n+lRYfrltYt+gVN39RZaCf2MCi8=; b=S26khqbnSdVzE0X42/KxyCDPLhICYaneOUhxZ6tBqBPS0h5lfe/ItJBFpSbS2PV9FE XdQR97WsUK3LOdECGs75bp//6bxvbfjZ2Kndem1xZIl2UEOmkZBtIcjY3G+YU6pI27Ze FdKV4dxcC1ouyo08Bm/6sTwAaS+NVNL2bQXA7C8ZybxebhMoqPyY+jOL4aM4BOOnflkd z3MZFD/AFZqNBf5PbT8gDdVZLEV7s2GiZwrQTHYQGzahiVqjvPymleUzYUjFyrid4fvQ GYU5QDh3Jtln+xu8hoJmgd0gAMcJo0/Bvr0VlY4xPKez1rGC0XVahYwHEeW2fb0h0236 /3fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741146291; x=1741751091; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FSYH5+SwcmtCe+p0n+lRYfrltYt+gVN39RZaCf2MCi8=; b=IqFkVsqZzJ+F3OE7dddRmGObSbAzpMvagg0UgEtGzolGmEyyTePFx+2lvKi4RUDVMl EA3MqBwhFNwgWqEIUn659t1sKJYp84K9KDGh/dPDoApMmt6On2Y4fSOAPH13d6TB7BbI YlY+rfiYi6vYphE7ZcuWHLZjNsMnM3NcrGX0O+CDoHwbMrcsEZgKsmLHlzb97GLNcWQa mzuNU/rq8plhYqrDxTtMk+vRY5xh01usyFUpT5+KrMeGfsuq5GM9xPsZSrYxV+kGNfE7 yON3zUvI95GKa2pQjNfKHkeOnLaJPZ6jia0YBXq/jxUUuDJpUyYBeI96Fp7N5RkNabIg GuSA== X-Forwarded-Encrypted: i=1; AJvYcCVUE9cYxzRj13J9YX5mnEjYq61eY2eiFzb8BhpbruYqiE+/6WaLjIXMy2VHc23OwrwaOHK16A9+6qs=@lists.infradead.org X-Gm-Message-State: AOJu0YzCmCNCzZ4mjaS7GSr/2ftKPv8qv8kNYfU4M4vjI3iat3a1pIn2 aMzCs4kmhxLmUR8IffarQo4A+wYD44PvHlwe2f7Fdz1Q0Mkg7PLg X-Gm-Gg: ASbGnct9HM/sv8+8/I6fkik9CPOD+qgzahQc+12MCGFcTlflytkm6w8qiQGs0hoLphZ dmG7qJ7NuZoPw+oUTY2I27Ox7WeEAiyHPbhThZW26irUg7XBKQppdr4lu4nUbT3u/CjhF9onW2x 6Kni5wVAK0dySeHfUc2IywRqoMnYMj9SXHDgN/M6HQ6nzhFeyvbJM3Af0PZ0WMFBG2Gp+4TJlgg QwQNVj+1hbEpzDF4hosNazcDTaVhVl/CeiUG3k3PTHXwdyo0Ipy1w3Cda1z22U966Mc48coQ1Ix z05nlOcuCQmRvYPStXpCkQ9PbbQdHczM8E+s3FkPhsd7KStFBsXGZeM= X-Google-Smtp-Source: AGHT+IEY/W5EzK2xQM9ApeNVjlE0dvEXpH3lZiSewWlXGQlloKZ5FWhsNbQOOWfviYkdHfIw/kEpyg== X-Received: by 2002:a17:903:11c3:b0:215:4a4e:9262 with SMTP id d9443c01a7336-223f1c6af8fmr20720365ad.8.1741146291089; Tue, 04 Mar 2025 19:44:51 -0800 (PST) Received: from cs20-buildserver.lan ([2403:c300:d305:9d26:2e0:4cff:fe68:863]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-223504c5c37sm102734335ad.133.2025.03.04.19.44.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 19:44:50 -0800 (PST) From: Stanley Chu X-Google-Original-From: Stanley Chu To: frank.li@nxp.com, miquel.raynal@bootlin.com, alexandre.belloni@bootlin.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, tomer.maimon@nuvoton.com, kwliu@nuvoton.com, yschu@nuvoton.com Subject: [PATCH v6 5/5] i3c: master: svc: Fix npcm845 DAA process corruption Date: Wed, 5 Mar 2025 11:44:14 +0800 Message-Id: <20250305034414.2246870-6-yschu@nuvoton.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250305034414.2246870-1-yschu@nuvoton.com> References: <20250305034414.2246870-1-yschu@nuvoton.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250304_194452_331065_CEC59CB8 X-CRM114-Status: GOOD ( 13.19 ) X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org From: Stanley Chu When MCONFIG.SKEW=0 and MCONFIG.ODHPP=0, the ENTDAA transaction gets corrupted and results in a no repeated-start condition at the end of address assignment. Workaround: Set MCONFIG.SKEW to 1 before initiating the DAA process. After the DAA process is completed, return MCONFIG.SKEW to its previous value. Reviewed-by: Frank Li Signed-off-by: Stanley Chu --- drivers/i3c/master/svc-i3c-master.c | 30 ++++++++++++++++++++++++++++- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c index 5c29912e0a69..df7eb038c6c9 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -32,6 +32,7 @@ #define SVC_I3C_MCONFIG_ODBAUD(x) FIELD_PREP(GENMASK(23, 16), (x)) #define SVC_I3C_MCONFIG_ODHPP(x) FIELD_PREP(BIT(24), (x)) #define SVC_I3C_MCONFIG_SKEW(x) FIELD_PREP(GENMASK(27, 25), (x)) +#define SVC_I3C_MCONFIG_SKEW_MASK GENMASK(27, 25) #define SVC_I3C_MCONFIG_I2CBAUD(x) FIELD_PREP(GENMASK(31, 28), (x)) #define SVC_I3C_MCTRL 0x084 @@ -150,6 +151,16 @@ * If it is a true SlvStart, the MSTATUS state is SLVREQ. */ #define SVC_I3C_QUIRK_FALSE_SLVSTART BIT(1) +/* + * SVC_I3C_QUIRK_DAA_CORRUPT: + * When MCONFIG.SKEW=0 and MCONFIG.ODHPP=0, the ENTDAA transaction gets + * corrupted and results in a no repeated-start condition at the end of + * address assignment. + * Workaround: + * Set MCONFIG.SKEW to 1 before initiating the DAA process. After the DAA + * process is completed, return MCONFIG.SKEW to its previous value. + */ +#define SVC_I3C_QUIRK_DAA_CORRUPT BIT(2) struct svc_i3c_cmd { u8 addr; @@ -259,6 +270,13 @@ static inline bool svc_has_quirk(struct svc_i3c_master *master, u32 quirk) return (master->drvdata->quirks & quirk); } +static inline bool svc_has_daa_corrupt(struct svc_i3c_master *master) +{ + return ((master->drvdata->quirks & SVC_I3C_QUIRK_DAA_CORRUPT) && + !(master->mctrl_config & + (SVC_I3C_MCONFIG_SKEW_MASK | SVC_I3C_MCONFIG_ODHPP(1)))); +} + static inline bool is_events_enabled(struct svc_i3c_master *master, u32 mask) { return !!(master->enabled_events & mask); @@ -1144,7 +1162,16 @@ static int svc_i3c_master_do_daa(struct i3c_master_controller *m) } spin_lock_irqsave(&master->xferqueue.lock, flags); + + if (svc_has_daa_corrupt(master)) + writel(master->mctrl_config | SVC_I3C_MCONFIG_SKEW(1), + master->regs + SVC_I3C_MCONFIG); + ret = svc_i3c_master_do_daa_locked(master, addrs, &dev_nb); + + if (svc_has_daa_corrupt(master)) + writel(master->mctrl_config, master->regs + SVC_I3C_MCONFIG); + spin_unlock_irqrestore(&master->xferqueue.lock, flags); svc_i3c_master_clear_merrwarn(master); @@ -2031,7 +2058,8 @@ static const struct dev_pm_ops svc_i3c_pm_ops = { const struct svc_i3c_drvdata npcm845_drvdata = { .quirks = SVC_I3C_QUIRK_FIFO_EMPTY | - SVC_I3C_QUIRK_FALSE_SLVSTART, + SVC_I3C_QUIRK_FALSE_SLVSTART | + SVC_I3C_QUIRK_DAA_CORRUPT, }; const struct svc_i3c_drvdata svc_default_drvdata = {};