From patchwork Wed Mar 5 10:00:29 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Baluta X-Patchwork-Id: 14002260 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2040.outbound.protection.outlook.com [40.107.20.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AAE47205ACE; Wed, 5 Mar 2025 10:01:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.20.40 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741168868; cv=fail; b=fTqI2xY939vIb2f+glZTpjokAxUSjKZmL/gCffeDNFr++M1y8okDvWrM2JnO6fv/kUPkd7uhqe2LzA0mt1wYSjzCXrxXtV/97zJnd3+ga4CFz0jnX9By8mgdS3apfJFa09MzIoeG79IcWMXgPuRYePRZkuFjcGDDEq/T/Wrtluw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741168868; c=relaxed/simple; bh=CXWA2QRvld9BhvBo/rR+LK89ImoGyDWDhU0XYuUJS9I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=KgBH1gelJD0HbyJH698BImRNuDXfKnIif3XCCojuWZjIQPXeJUnxqogc355k2JOff2BwjwBIhtd7+hAcNRGzfLZo0qiOA8Ltu0GRAxlHIiaz7INQFVZOE0GyYMYAosdYqocD7Xjij0c1YOSvcudmu5DE8VtIRUwgJiX9J1HtzqU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=jxZ8Mcl8; arc=fail smtp.client-ip=40.107.20.40 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="jxZ8Mcl8" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rQgNquf1ho2TuwvFJWWn7pwSDMjzJX8w4hVhMUiw1k53apMi9ENuY1VUpPCteiuxsjPNEZleQAd0wdCcAH+hTAbdf/yWJsPV+RgYUSqTtR0idWgr4CBlC+w8aZM1vh50oqfQ67pkRt4ZCgo9Ioy8JLbTO9mirUATqz/YqCH+10umCrwtbaTA7/7Wwk1lbqia8M8uDDKInsPXAN+PsGWkZk4mZl4ETvKgPZVB96ODBWDlsudPt2DivV2o5ZKd/qVTi6MSpHxl6tpvSBKPcApxJkYYDDQeB0xeZzj5i9xhf5DbqA8X7EdLqvr1DeOgZ2eZFWuxR1yOdmFPz0YIWS9Zeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qlMvMZO/tcfYiZINsUbEej4wSm1eHa76idm2MdvMLKs=; b=yAd61Y80Fa/SmiUs1ga/uhsT4jLHStHA69j3N/CX15CKxtPdtlW8oTBdoYFV2ZEANilpsRXKwvOQXd8oDcCpj7NVoJuAjiqFOQk1qLNUUi3dqM89RPJm2fjrEfJeHNyE8fQBQD3lCPxwOF2qe/WqShMBZLgHyd6VWUequ8iaH+ahlmPY4qMZkQ2MC7mHI+uV7d5LAuRGCOkx4uJA1+5ob8HmrfcHHi8sY27Cc601BbwPx4MQro0j6RO+5wtz4AidRXoM4KVHjPgDrAfRFmYlOGvEQ8oNRimcrjVkMmmDT5fnJ3YrIaAXOOtyglbSvq42EjAzo3wRUTlg7UZg4PJdKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qlMvMZO/tcfYiZINsUbEej4wSm1eHa76idm2MdvMLKs=; b=jxZ8Mcl8R50CJdn4XqSYHKb1/NtHx22sDQZMjcyTgFD9FIfwf7QPg+6fxHGMz37ngq9T55XDd83/Ly9wlgL86yz1/JYh00iJ+m9LmAQ0yc4sewIIeWF1EMIt0k1WjCQvtwiAT/CcqueZ17Ql3cLGJKZg1gPZeen7KVOdfRfBSGyK/NqrvuV6ffw2Rvn6Bb68rnQMlAPlzFV7dP84Ssq0a/BGEGP3kAk088n232KLoIhunkwBaVCAzPHzw78DIZuXAbRH4cL+m/Fz7LG2AhBWS4pB11gTiNJ0lfzpm1fWV4oPr/w01z/3NbMyY5/E73SbAemOVrar0tq9OQeIR7QwfA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB8247.eurprd04.prod.outlook.com (2603:10a6:20b:3f2::13) by VI0PR04MB10541.eurprd04.prod.outlook.com (2603:10a6:800:26a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8489.27; Wed, 5 Mar 2025 10:01:00 +0000 Received: from AS8PR04MB8247.eurprd04.prod.outlook.com ([fe80::84f7:e2c3:ceed:c0a6]) by AS8PR04MB8247.eurprd04.prod.outlook.com ([fe80::84f7:e2c3:ceed:c0a6%5]) with mapi id 15.20.8511.015; Wed, 5 Mar 2025 10:01:00 +0000 From: Daniel Baluta To: p.zabel@pengutronix.de, robh@kernel.org, krzk+dt@kernel.org, shawnguo@kernel.org, mathieu.poirier@linaro.org, devicetree@vger.kernel.org, linux-remoteproc@vger.kernel.org Cc: conor+dt@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, andersson@kernel.org, Frank.Li@nxp.com, peng.fan@nxp.com, laurentiu.mihalcea@nxp.com, iuliana.prodan@nxp.com, shengjiu.wang@nxp.com, Daniel Baluta Subject: [PATCH v4 1/8] dt-bindings: reset: audiomix: Add reset ids for EARC and DSP Date: Wed, 5 Mar 2025 12:00:29 +0200 Message-ID: <20250305100037.373782-2-daniel.baluta@nxp.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250305100037.373782-1-daniel.baluta@nxp.com> References: <20250305100037.373782-1-daniel.baluta@nxp.com> X-ClientProxiedBy: WA2P291CA0031.POLP291.PROD.OUTLOOK.COM (2603:10a6:1d0:1f::12) To AS8PR04MB8247.eurprd04.prod.outlook.com (2603:10a6:20b:3f2::13) Precedence: bulk X-Mailing-List: linux-remoteproc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8247:EE_|VI0PR04MB10541:EE_ X-MS-Office365-Filtering-Correlation-Id: 5632f8c5-cdba-4d9c-54a4-08dd5bcca203 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|52116014|7416014|376014|38350700014; X-Microsoft-Antispam-Message-Info: uq4AB8VY9mvzUieDh3BByG2HJf3Ku1nNCkNQunJC52CNDeNqfF7Zb50cp+npeHxmE9OAS1fcRxjc0I45hpqYkOC+jUS7JeaUz6AriZ1MsGurCYQLKtrQzTIpZU7UzEOA1HcsyhnpFyIJPeou6r29lqmxQzr4lyctjL3/vXk2Q+1VVMq/E6HqRs1LoRQRdwP0I7Fo8/ekONKnWIpE8LyKes1mAtGjsqgQshs7TgKj+jfIU66OGQcKqfOcv0XVbqX8nAULaltKnrw80Q4FIH9ECvf5PgFFY1qBfLaZti1J/pMCMkGQlElHwFdkcxugT7PDMII5qJDVWhw6YA1UjyWQrtMCw87k86DYzerCvF7PR+nW4aRikT2tkvz08qbtm4MtMvD036YhyO7J54EXvBU6pupmU2UIqDCOdQVtuheLSTd7SzrESkyavHKUViHMgGaiCNNDyFF5sMLgL+bBJ7omjNadiDGr2gLtHNidyf4DMeWKSBE8UHsCt0sndKuwbsHrMVpZs6+u0X/Fkh2BHgxwSsVwL1C1iUFbtFFCRgswdi5Bv18yfc1r2brAttCptBU/Ckyu8ffUpT7GwP/pOO/XslJOsL5XJrkvpQjdu9KFOhuSJ7Kj/NhdQbrxEhhyIyP6hf8pyGvvI/7YrMKpdCIcBFIStR6MBEaE114AbkSaCfVRn/WhhqBg2Uo4GNXUklqM7jlfgSn336ucvo4HZrqTZUxb0NwtGFBIjQ5qEgVKkIILE8xvemTVvsp3Kkz/1L9lxhu8WpzZNhqmGXOqTd1s3s4SjVIWclC7RjLiws4b1qzkfY8PVjwouTp0QzoxSRlyBUFHfoGs05U36lAx6/+/W5CkJh+RWU89366aPxeibH2OQ2zPjcGaaXM/tY7ydADSaXi9Ht3CFGJIcYQtGemgzPegBTu0oSCQeJdjhgrtYyHZe8RPSSCIyF71SOfMo6lKcLifp2gu36TKpBa0GCn8hoNqE18mdHZEdbkMHtaVwtbV+HGpKXRR6QtG0erp8YeywqSt/NKmmgxPwp7HLDfjGNUwAo7xRrJtwXLkE/aDI7HvWVWWzo60LAiGMFvJnyj3nb2uGk6kQQHHcT6uotei2fDshs4lZY7uQxwqgNLLy3OCdjYgyHpHYkK9CwyvTwKNneeBWK8u1InognQVdTWK0Zum6kXq0fusdxZ86t20E+IT0aPeMSFSlYk8UQfVYrvGW9l+Tj+SZ1TIF7DZl9clyESyhcqvaEASUpW+SjYijV4I9PM6Gh2DJwJ6J2rgIfgiN1vKWLIzghaZDPZZOHi5XSNtkE2HjK2au34bJrDiEP3JPnUl+r08InAUGmPCZ7Vm+QDtPA8sW2OzPj3zsViFiT7YCym1fZZYKWid7aw6k1whI5cFAJjarjQiO+WEg/ZVP6MtFFoVkS+BKkGlNeb7JCn+n93J4XV1LfwAGPs0YDL7Xt6LO7HSIIaIAOe1CljU X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8247.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(52116014)(7416014)(376014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: wrMu2eJN8mGZjXMTqxOUJN9SkgUR12m5SHIRZnf/dDP9K4ddYvDxcv2lPwFFO8vbsBmfAkZ3yVhfVwj49LQO89t/g5gfTBJqFhhxW5/0pAGOIAhprJT5/SK2eGGMBvAV26eOnUes6uNVufOdaRa8DTUB+Fi3Vr9gj7cxAR1eaCG3amCfuWmkq5Ns9noREImFcYT6nNx1xS2RknCfEACz4987GEzE+irH2zd8NwUI5UYb5wkLcyHjRuTqXoh17+zh7CHBoRWyySVi/w3tityfxndayu2nrinAx+sEHKeBZGsEVRglfYhGmgNYguSiD6wEZzfxYfgJToEGWh0mdoi7SMluovOMU+gpJK2ImK/LxtGRM8bZK83Ir5XAYF+BFF0+ZEENuYiJDJJKY+2vY1X8dXE5oYnHWC64v2NTP5C3Ki1yc2GgIVI69/MNRiVLQG2b9NJPk4/eXSzbzuS1HMS7NLaz+tJXKCAY9RiTg6VNizmT/hMp+z+o1o6xMlkqUtmBtFtNpHL7U8McFVjJN2c4BkwMaeRNkGjvJigHhSbsnO+wxBdTtAvzZMrFT0kKNN4rJppN3dYB6uo2KLHssSmyGDsBZ7L7OHPmKisW8hrM/XFOQUw7YRHbUQGuAF3Efzcx0kmU5UQloj3m+fKLzXhDqpWNd8Y5TVpU7hdqtIN0hiNwYJTi7Cts1TPR0u3xZhQxYKkW+pTd8Cn1xwny5K4QTSahHv36ik7c63pE/Eggt8SPSApUcf+abJE5Eqw3k0vKoZFOaZ16Am1+v9iYFEi2W/Ltqg0+xSW47myayWVFi6R7VmB1VDfjGVORALuLzRAMARd3WMkXozUo2x0oCgpPUfuA9T34/ni92OBKU3L9aissHJ3xa5OA9jKhHw6oUWhgaGgS1bkustdQ9DSpdnivnic3Lzayc5fmh4P6BY6YmGhLn5Ib2idlxBxONnZLv692IQgHnvAcR+ai1wX08JCI5YiPGyDpnY4kEIJfTnaHAbDG9Md8z8Nid/5jJI/01GzpjRFdC6XxOHDmfpT1tTLtVfm3RW9oR5UElbI9fuDcUGxtYX3LdCVtEsqgzhajhkKOqMNKRX/L9EaRxfYnb68F1B13k+ZY8V9U5r6i6aHlCTrN9RZnIMBx/blEU5/My+WAZy1Osd3iMaXGqpQ0oyrnzPlKgKiugrea+ASaa+c2x5bZg2FAWWm2A8c6Mi9Y8C+Kbyztho6kx3cl4k9085i5d+XCKKl+m5MIsW6kehgG3aWE2AVy08OddF9R04qnNMd2Uv5QWfB1yYtlDQA93pbMCyN608Vey+5o1SGsdYnqCyhQ8JbbtO0BaV2gwDKOAq9rq4dl6xO+uz7b50mOdVsPoW7FaKzLq2op+l8O3ul1iIthUH9vnpn1AJ5mglXnRT1hEXkfzVfeC2cu5z/AjRHMcjhDxs0xZp3c5XwAPFAj6MPRh2shN2fvEosSTQvfHbiNDpJDazxoyfw+ufG4sM4FVShZ+tEue5WE4tq1W30TCcOzbA0/+wKeMjLo+gyImWwThHySJqYQvC7IRgHxPXQcIgxecN95vm2ZsktvNILDKKOrUbVTXhDyHCAT2ch3QA/S X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5632f8c5-cdba-4d9c-54a4-08dd5bcca203 X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8247.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2025 10:01:00.8249 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1rqJdx/3G3pZt4LJD11n3aMhY6e5kDVrTyT8aphEg/jG4OW0ME5m0ddYwJTRJNYtkmWDWFO2UPnEUzqNhGux5w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI0PR04MB10541 Add reset ids used for EARC and DSP on i.MX8MP platform. Acked-by: Rob Herring (Arm) Reviewed-by: Frank Li Signed-off-by: Daniel Baluta --- include/dt-bindings/reset/imx8mp-reset-audiomix.h | 13 +++++++++++++ 1 file changed, 13 insertions(+) create mode 100644 include/dt-bindings/reset/imx8mp-reset-audiomix.h diff --git a/include/dt-bindings/reset/imx8mp-reset-audiomix.h b/include/dt-bindings/reset/imx8mp-reset-audiomix.h new file mode 100644 index 000000000000..746c1337ed99 --- /dev/null +++ b/include/dt-bindings/reset/imx8mp-reset-audiomix.h @@ -0,0 +1,13 @@ +/* SPDX-License-Identifier: GPL-2.0-only OR MIT */ +/* + * Copyright 2025 NXP + */ + +#ifndef DT_BINDING_RESET_IMX8MP_AUDIOMIX_H +#define DT_BINDING_RESET_IMX8MP_AUDIOMIX_H + +#define IMX8MP_AUDIOMIX_EARC_RESET 0 +#define IMX8MP_AUDIOMIX_EARC_PHY_RESET 1 +#define IMX8MP_AUDIOMIX_DSP_RUNSTALL 2 + +#endif /* DT_BINDING_RESET_IMX8MP_AUDIOMIX_H */ From patchwork Wed Mar 5 10:00:30 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Baluta X-Patchwork-Id: 14002261 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2040.outbound.protection.outlook.com [40.107.20.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E62C1205E3E; Wed, 5 Mar 2025 10:01:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.20.40 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741168871; cv=fail; b=MCylAl5fD39zrIdZlH3/N8KeOWTGXZtz6VmgBeAH04+eV0Cxi4n0yuFWXtO10uSqto3HOZZ0wbXpaX3TmcQDatsAWwSu1IlBS8wLMPVdmSm23O4jf5eFYVXgJi5+1Lpn972MzSLZT+Rv5GmIzwLCc+yWQZ4mdBqpPTJwwdBX8vw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741168871; c=relaxed/simple; bh=yOe+tdSfV4kQ2i4yYHtuRcJ1OvYEDiS+u033Zq5dAKE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=vFq0J83Z2pmaE+FKn2zC9p0m6ns1LrKn07sj4sXYPib5X3LEiNTFnuEr5FFpeZ+LDDkaIr/yWs3Y1HxxL3UPI5L3vDrBfSga/VuX9igqSKDGjiNxmKsUMkahjAax6hjH0g+RK8XGkhDGpYnClxn33hzNTTFZlOWKc2uA6xytM5g= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=Rb5p6KBn; arc=fail smtp.client-ip=40.107.20.40 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="Rb5p6KBn" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RANCmJHT7/ScOHb1wQatIioaS5wl4YlvyTpo6TbRa4YGVpCQr1rf4Cq0hLNY8UPVI7YLO868fflNWcJ93VkJxbVvn26crtS/GFbDXjqzq3o/dnhGpGdcibgfwfruQ6shRUnqvvOYfyfP2tuX6uQVsQ0ntGTzLa22uRqXdX20XaFk9KdXi0vcJLOLjAWSfzT32FqxmC9IgKNGhfQMkII8wGPigmrCH1I1HKmftGye4eCU65moZJPW/G/PKeYltWo5VnW9sGWwU3yRNfYEoCv3JuulWG2kWSKGBzn5DjjPtO8peDXVM5WqKrbn6CjpFlR9Jz6FAgVxtehsxIKnvZBoGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JKy2s+27b2kojQ0f97gloccGL0feO2hcAJlvBdx21Lo=; b=XQj0cBTLOSCYh5Xji3szNK14HJRm5z6lu1i2PbTfOpNJg0Vlc/BJdqgHDCXNRR86z259uxpj0IJW2tpTHuRLlnC8m1rKx0FL+/sD0A7T7xysvvFHbQl5SzVrRG5bFYhgObrS3vPg/n5BUg2TlFOo5Mncyy+lIgr5pRAuDqMo79Eaac4I4cgEypoXu/YrADUakEaF8E1D2k85jKI7M1t/Ed4VPc2j4TIwSykci3d+pGGIRnscfrCo9okKhSS6T6D4nbV0iPKWCoHLb/fRn5EfySVzOeA9XgaDPdOOCWOfiqmuBvrPW/ENjmlInnOA3r7ClYL3Zpud3TIcCD0zKks9Zg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JKy2s+27b2kojQ0f97gloccGL0feO2hcAJlvBdx21Lo=; b=Rb5p6KBnND4hT3Ys6bMgfzcR+bNp5naBZnkf/QgthqG3WXyRFbp+YvhZimE5uLsy6Bjrkp0dXM7YMIufu2sPrA1Sc8/KcMhzhOcN87ZnRfTzSMY1ZP3X7J33J7kLvLJCDdFAAXD1FDCnkR9F1nVueKbsbseY+SmCtTe+k7UcyJ9BrqB9Qfz4YVdzVpnozQ48L157cAk+U4SaonJnY3x4Rn70w7DQsznVRTYgZ70/M8VJZBcEO+SgQJs1Zx0+WXWUF6cE/xHR2N2LNWDg2bh0/l6KoC3jYqDazNpNhuNNUJA62vjaM5SMvaqonkrCP2XX8fRB6IozY57IQhd+PFo4JA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB8247.eurprd04.prod.outlook.com (2603:10a6:20b:3f2::13) by VI0PR04MB10541.eurprd04.prod.outlook.com (2603:10a6:800:26a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8489.27; Wed, 5 Mar 2025 10:01:03 +0000 Received: from AS8PR04MB8247.eurprd04.prod.outlook.com ([fe80::84f7:e2c3:ceed:c0a6]) by AS8PR04MB8247.eurprd04.prod.outlook.com ([fe80::84f7:e2c3:ceed:c0a6%5]) with mapi id 15.20.8511.015; Wed, 5 Mar 2025 10:01:03 +0000 From: Daniel Baluta To: p.zabel@pengutronix.de, robh@kernel.org, krzk+dt@kernel.org, shawnguo@kernel.org, mathieu.poirier@linaro.org, devicetree@vger.kernel.org, linux-remoteproc@vger.kernel.org Cc: conor+dt@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, andersson@kernel.org, Frank.Li@nxp.com, peng.fan@nxp.com, laurentiu.mihalcea@nxp.com, iuliana.prodan@nxp.com, shengjiu.wang@nxp.com, Daniel Baluta Subject: [PATCH v4 2/8] dt-bindings: dsp: fsl,dsp: Add resets property Date: Wed, 5 Mar 2025 12:00:30 +0200 Message-ID: <20250305100037.373782-3-daniel.baluta@nxp.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250305100037.373782-1-daniel.baluta@nxp.com> References: <20250305100037.373782-1-daniel.baluta@nxp.com> X-ClientProxiedBy: WA2P291CA0031.POLP291.PROD.OUTLOOK.COM (2603:10a6:1d0:1f::12) To AS8PR04MB8247.eurprd04.prod.outlook.com (2603:10a6:20b:3f2::13) Precedence: bulk X-Mailing-List: linux-remoteproc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8247:EE_|VI0PR04MB10541:EE_ X-MS-Office365-Filtering-Correlation-Id: ac3e644f-497a-4dcb-8ce0-08dd5bcca37a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|52116014|7416014|376014|38350700014; X-Microsoft-Antispam-Message-Info: 63Pq/RXnEWHWI4YoqSiHuzmUoMqvU8bTIMUIuNtFEh/qA9Xmqaq1zpkU71zYdhX9PG/1hSOE4NK1DW/aR+ylaJ9nxNxWuvMiZwD8TJQpfn6uvfH/sAwonxPeqLxSwmXg9tezKJeWkesPOTjCoDQ0lMgu8BErQ0TV9DHkl0QNws6KlC5CtkIrW3+x41LBphoSACsJPB0bCh2LjQwRhnipa0vagwNH+D+LvmyJjzkoiavWL3nuhV+6umoJ7sh5wZkCGEYY484+bdFUTH9wL9mlQbfzsmSSm/2UYNzVr1oLzm0/N7i0LJCriBGMx/OVvCi8xSboGL5GoHh00FkxzAdUX10ArbnJ82YzD894c3bUDYyFu0S5XVm6O5b7BVW5gNmNvNzLMFCcRT6BHNieDiBjP76+O6He21pIEVGZGyYxfoXolgqGmvOja88cuuD0ReCncU6eGgxWcsWxlZ3B/uToVkwje99Mww3X/WoEuyE25LW/98c6So3r6sKl7m7ZJ3JzTh8wglyvmqUpRbChzZyjj9cXhZOyLcowgzMEUK1+3uwjdBVmg09vlR/7D3wKqAIljMlfcPj5kBzMcUMAngpizZhVOtrLELR6jbip9EVMUgGBKEfMunbpb26LBiwRPdenCyouJzBY8jMrlanZMUxuMA/XPwSSiYoaJdWw53kDOu68waCm+reihE8Kf1xXl45S/rdMOZXyQNEUET0wYentA3pA3Rlfur1ZGi8xZY1tFTfv9KNU5Uvl8X5srnJ+25p1Qo90Fuo90oEaZjkEHMcnKLRXAmTFMzYhz/Gn32XXUdCJX+dFg28I7se3LdqDbRMaBL+nYLt+9//BhttLV2Eti86yOJkcAR85oCmL8z+wiG9M4BCWaX9T7X17X01zsHeaC9laMAzIlNgm8sI+EX2AB7t+cJ9Z2iBEVugK3msHGGA+Xxt4DivYoR7nsbXA14aTKQhtX6LsH1EbC8xZVKn7EqJjiicw2CF8l3nI8jNILRx14oKF1kjdLZqk/UEH7aNpaoSnQeQD/P5qAlrLGKeU8NICcUZD+ucxAPcHk/xSlxCCKhB19yFpYCJ3PNF8McrtMKQ46f9GemPYBfAnC52Wi/KBx+f0qV920OOlxXRk7sN2ASLTwDNTlEhxotn3UyWGly3aGbc0S+8ZitRb9VBlJ4N7WPGAJc39Vis2Kd4PZjtFdu7CwtJ7FscwJk4nRMXa3usNOsoU2LOvFxPUoBUjTE8r5pEN87Je8e4lncYU/3CVeGfABOX+sMCA+qwbzq11N0MGIgRUDRkC3rTcHK5mxJPtU6ULybKWx5/AORshtmgEVrqAHuo5I4S1yVgeNc70yfpPwRd/ft+TT7cWfeMruVdlA9poGDJFnhGNOp0/qfy1CpGojXtw0Gfyd4hFMi6NtS6ZFdPFetfC9ksa1oAldVacIkkmtkC9gupRKdewG1C1CIQ6pGpU7HwigzPk3MoL X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8247.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(52116014)(7416014)(376014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 0qHmmjVr6T4y5/jiAekpkIgbEPe1t1lWffNPJX8rSy58IoeFqo54dPQfeqf6Z+43r+ckF+sEm9vhW+nIqC8udETzHoeCQWvFCwIi5XE15FvTC8CQoaSuTdYoB6QZI1w7OH/fe/0iFD3ncSFNgmM7BMr8nBwaWYo8IBBxGPj4FWQgWSrA+mUDOPv7d0dXul5mMQ8AghZl2jUpKdcmsUib345fCOKCVCJavjIQF42HThxJs51oX5ujeGIw/segWX2WWvZ7G3JopxjmEBF4uAZWAV1P1yAQoN2+eZjUe6X3jyOt8xq0jM78zu+3TamUHmDpnQX69MOzpjKcV7jkzTHpsSGhgb2nOSO+umHvOmqg6pWmvMCnjhBT7l6PpXdZXSPX2uIPkEsDaHzymosJAX4n5jsY7xrsDyxf0zzXbHQz3CJ4DtlEKLc6BNs1eM8KlBtgoYv0fuZr2jXq9xAMRhao3A3/7vysunZeB0U+j3FG3lJsUOT9HII6aJ44yTa3/Er0ZOApOt/Gfz2C7XkxcxnwV3ZEcF7lRozf6Z9FqwmO11Vjkdmzuk/sH41VFesk71Ca14nIQ5ZEWZpiOWSxqRCLd1l6DRafOFEF/HXi/d3IyCbu88gv7ldGME4zkp6FU7/++8uUi6YuXyklKq4WdTD1iKXXqoarpbx7IHc3xtzOU14v7dxiirouF0eFnmn2Nun/yWqKbP0gn31jTY1zeAnFUYDPtviEMvQa2EA/qSX7KIz7XA/M3iPETMlgifiV0j+azvd/4TFZ1YNJtj66KbnkFO/mG65qSU0G3zr8Kc/oF4GThU2epP1/T/Acf46qBTrriwSoPZMkNTTP0q5yjCYkxgV8nvFBcdEOYeV8Bhd3BlRExSeX/692JX72CJMkdn6Rcmw8ciRs/M1B2Vxf2D0b4BEyqmbAqSm88LVYIKtUNfZ2c+GjCG7QqzR28DpeEtVhDynLfsZhJcUWDtrNc8j4b9pAtMWLCG9Vq2ThOhIbWyo7jhEcMoSIKQYA6dtuFKvXZDpSB4Qs3+lrSvCnOenDUx+hY7GrWTXx4PlXzVPZ+s1fN8gOcde2dZ+mlEGve2GOv4ewYbiGAFhInXJTcHCOAZ1VbpRQrZChL2m1dmZFk5zGxPwKSew285Ubh0ZFx00p5HMScMJ5CgspRqEHgW5MeiU937hd8UNTx3bE5TCWs4+GeojF8PKYIWvklra7Epk8Bpdf2uVN584ccsTARP3W/m/kVZY7h9kZSYC4u4Bklf0YzAyvUEl9dgdr+8jmnuLwioe3vNhTF24znnYoctdsvXoNlZNEV6aqIrJSWvT1bipqT7xDDbi8LJgo4SkVJXGsJCe3zHGA+YKu42UsODqGjeMZwaNV7ss4jXBBNoB/D9rjMkCGLzdf15HaWtsw7kEUYKgSJ4OviIxU0dEbHJnNnGZuppR9mnne96TVkfpshghCCQZdLdbelPLQUAM1ap7x/lPfI27h0hSTA5DaHetDr2vsDAEvXvO5crrvCJv92gjtWYPHMsql2plgpZT8V7ZqucCBssv90t0lnYLcE+m8qmPyaxj2pYQZynUHCXWbWJlE1Ujsas917Ne9j3SYZGuL X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: ac3e644f-497a-4dcb-8ce0-08dd5bcca37a X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8247.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2025 10:01:03.2365 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BtrdCIgpU9cbdB/3bs1VF29V/dQ4+30SXrzXpkpF9YV9jf2IRw8RzqjkK6CvUL41a57W6rd6utEdJNKcdkT0tw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI0PR04MB10541 Assert and deassert functionality of the DSP found on i.MX8MP is realized by combining control bits from two modules: Audio Block Control and Debug Access Port. Audio block control bits are used to Run/Stall the DSP core while the DAP bits are used for software reset the core. The original plan was to use fsl,dsp-ctrl property and to refer the audiomix bits via syscon interface. This proposal received NACK from community we shouldn't abuse the syscon interface [1]. So remove fsl,dsp-ctrl property for i.MX8MP and use reset control interface instead. Example dts node only uses runstall control now, but softreset will be added in the future when we will convert the softreset functionality to use reset controller API. [1] https://patchwork.kernel.org/project/imx/patch/20250212085222.107102-6-daniel.baluta@nxp.com/ Reviewed-by: Frank Li Signed-off-by: Daniel Baluta Reviewed-by: Rob Herring (Arm) --- .../devicetree/bindings/dsp/fsl,dsp.yaml | 24 ++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml index ab93ffd3d2e5..b8693e4b4b0d 100644 --- a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml +++ b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml @@ -82,6 +82,15 @@ properties: description: Phandle to syscon block which provide access for processor enablement + resets: + minItems: 1 + + reset-names: + minItems: 1 + items: + - const: runstall + - const: softreset + required: - compatible - reg @@ -164,6 +173,17 @@ allOf: - const: txdb1 - const: rxdb0 - const: rxdb1 + - if: + properties: + compatible: + contains: + enum: + - fsl,imx8mp-dsp + - fsl,imx8mp-hifi4 + then: + required: + - resets + - reset-names additionalProperties: false @@ -186,6 +206,7 @@ examples: }; - | #include + #include dsp_reserved: dsp@92400000 { reg = <0x92400000 0x1000000>; no-map; @@ -220,5 +241,6 @@ examples: <&mu2 3 0>; memory-region = <&dsp_vdev0buffer>, <&dsp_vdev0vring0>, <&dsp_vdev0vring1>, <&dsp_reserved>; - fsl,dsp-ctrl = <&audio_blk_ctrl>; + resets = <&audio_blk_ctrl IMX8MP_AUDIOMIX_DSP_RUNSTALL>; + reset-names = "runstall"; }; From patchwork Wed Mar 5 10:00:31 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Baluta X-Patchwork-Id: 14002262 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2040.outbound.protection.outlook.com [40.107.20.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57FB82063F0; Wed, 5 Mar 2025 10:01:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.20.40 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741168873; cv=fail; b=ewIyrZLHc5ruSVEsdSeM3D+EemhPDr3RypgSv3GUxskRuCiqS/RPljZd1GlGeSMxPHg0Cqs6UHXyXhpY3lFLW7TfZO7lholDsj3VQsy8tj6pdbJVF89CKPGsRGZkxQU5LO8XvwluOi6/PTqOGgbU7QXwQKbi6cbpDwXa0Lkq3YY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741168873; c=relaxed/simple; bh=EAERBQkLpH8qR86MxmIDgyb++TQDZgGtRu8LK89mqik=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=YIhi9hkztUkZmP7kvD/u1sH+caGXY+l2ycNFWVCgy4PIAZKEww/eO53lHPe6ft7evxvdH/eaTamJMaCY7OPm7RJdfP2IeTG35Zaog6CVUrstGJfeO4UpXaiex/bkk4OQ6Kd1Fu0ICeS4weUAHHHe6SvFehSTi0kS74GT+hgG5rg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=OS/WCu+b; arc=fail smtp.client-ip=40.107.20.40 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="OS/WCu+b" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=cvD2tCNsqcJvyqsDjPjxDEHoPIfLyA0VTDNl2Y36sanSo1tKOXIwHHh/fyQRlQB7iTGJBmhZMKsvhlF6Y8wslS/ur0sArFmTG39PyEJvldQ/vNWb3iQnTZmP3dHBB/hL+fx9upNC53qTLkBgycsAO+he5fld20HU3X9j9P7Svxiiay+FrQzrPR0jlFI5xIlZ9zbfczaiJy44jH6mLBVWqsatsmcH5xCwMUZE6067zsSJEo/sHJepOrh3mpott338Vm7m9ouwiFHfvthIEq1/wJEhSXMbEmtMBorAvLZrsCD1gm4Sa/A5Y+pC22b1BYMIuWCk+eFQfBeobJZF1pOqzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XhqehvG6czOCWJNUmth5r4kLo3nZ/EIxnbgVWAS9nNQ=; b=hqRB9Wk4WKZQwz3cWqB2UhYfRdZvSFHPZCb8+f5+YOS/X5smU/Gq6VO725i7u/NmumgPo+PfNSJHhsQoXny7EZRPfXX20hfsMR6YvEO6Ww4BJEuWtzuWhf1RrnMb3c2u+UMI6+iw/vqYw4n1xoWXpaTkp3w9OFR5RWzRW0HGuV4Ys1wF0Zilt1rJwpbbkWuKWh3VeeI40poExxA9YvYOHyCZSpRp4P8kSbOHZd/xzhLUmDeKMaPMZaKR/KwUdfgKZMLDj0YAlAzNDLVorxqbvHJ8zfdE0E0V5TU5r57n2qnDtSvGPGh5KjNOkQnutB1aY0+lPnPzD2uuQZTVGIYTWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XhqehvG6czOCWJNUmth5r4kLo3nZ/EIxnbgVWAS9nNQ=; b=OS/WCu+bvWeP6VvOMQQhkT+zy6BI1AD1XCwV+yiyU23BqXlIbUKuuMCtAyMdj3QEJ6FVXa30cB7Ku3iXIpFYLODiDRcisWWqUzWDXnttjXduMRJke6q9DvC/HMEzMTUBPkR669fn6r36nHjPATiyJQdS97HUmLpxQ149+2oVTksKqGVArMsjlivmnEAyLyLUhzD2Kx2mQg5onxf8UL4OvzGJJx6jBRgM0dDLPx6/oMu1VWJt9kypLz4FCSFfW122lyPMvdOf8f9YEgoUICjlrJtaYGauBNlBouKptiNvl3EBKpcA4ff0VHlFq5ckLnCPI29VlLOOOF7gU0DATwNTew== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB8247.eurprd04.prod.outlook.com (2603:10a6:20b:3f2::13) by VI0PR04MB10541.eurprd04.prod.outlook.com (2603:10a6:800:26a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8489.27; Wed, 5 Mar 2025 10:01:05 +0000 Received: from AS8PR04MB8247.eurprd04.prod.outlook.com ([fe80::84f7:e2c3:ceed:c0a6]) by AS8PR04MB8247.eurprd04.prod.outlook.com ([fe80::84f7:e2c3:ceed:c0a6%5]) with mapi id 15.20.8511.015; Wed, 5 Mar 2025 10:01:05 +0000 From: Daniel Baluta To: p.zabel@pengutronix.de, robh@kernel.org, krzk+dt@kernel.org, shawnguo@kernel.org, mathieu.poirier@linaro.org, devicetree@vger.kernel.org, linux-remoteproc@vger.kernel.org Cc: conor+dt@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, andersson@kernel.org, Frank.Li@nxp.com, peng.fan@nxp.com, laurentiu.mihalcea@nxp.com, iuliana.prodan@nxp.com, shengjiu.wang@nxp.com, Daniel Baluta Subject: [PATCH v4 3/8] arm64: dts: imx8mp: Use resets property Date: Wed, 5 Mar 2025 12:00:31 +0200 Message-ID: <20250305100037.373782-4-daniel.baluta@nxp.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250305100037.373782-1-daniel.baluta@nxp.com> References: <20250305100037.373782-1-daniel.baluta@nxp.com> X-ClientProxiedBy: WA2P291CA0031.POLP291.PROD.OUTLOOK.COM (2603:10a6:1d0:1f::12) To AS8PR04MB8247.eurprd04.prod.outlook.com (2603:10a6:20b:3f2::13) Precedence: bulk X-Mailing-List: linux-remoteproc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8247:EE_|VI0PR04MB10541:EE_ X-MS-Office365-Filtering-Correlation-Id: c8a7d636-c1a6-406b-ea8f-08dd5bcca4eb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|52116014|7416014|376014|38350700014; X-Microsoft-Antispam-Message-Info: RpHmIWKkpybvzDz75Z5NOsuXuD6jIhR239niCa3HuCdhrBLG2zwuS5a+GWiKkjRt1i29/otOiXHOJX6i2kiuziBud2K/1FcTlDzDb9o7hxzE/GPRoz8nJUWqdxdgofB+hfuWNnAhB4CqgkQrHuheFXIXJ/L3YJ+xQ01knPCKSvEwnYjbfmFlpgLZnyuksQL/Fg8FfKKM04yqaet+nQo2UkWW5+Bww+uRE7wcHWBrWDsrLhNlLDp6+zyALxZ5cFmiGZm+82hLUV+i3fSVwE4oRjA2TuZGwA9D2W4WTnRA5imt1Kv0WEt3RdOwEcNZZBe/PkITGDoQliiQMm53DYcluiqGpn6GOKQ5WxBR54NAEsy8fhsrj9KIo4t7BLAx8OABXVoPr9qBMPSl3f64GrJz6/aPbREAM2JYc9XzqWbn1DSLZ8zFmZt4AHzH9VqnZMZwqCM7oLzCnvaaCnFyp7u9GaysGONkxre4FpKJiKJ1qMcl7YrP0aikZY3TjHQsn9jQjjjRrl3fNQlnUy+NI3TGnpWh0jNkJlRrzQf87g/B4rR+ftVo2+HD8DL553jlxIYzGdlf9X3DcSqhfNqtjmffZcX1mvv9hOPcYRjxFByWWdGUqjjQKMK7eaSdB2QqT2tctIhqDs0HbSPFY07T2Mc7yM/t3FodiQaOuFEDC2atJ6wG0KRnBcTh2l5mYcSDB7Y9rVGKBxXS/2vLpR+1QxmN81ULYHgalYooep84rNz1GRxnda5Bz5d60txGFP0N/SdjEZUyxKplSLtJ8lVxAHwJzId+6CtCKMyAPu9xtx0MIOeQoMS+Pq71u14KIpeNnP1oeKGK4Y8jbO57RHs0RRkufjAO9avC7ur5WnbbhaB6LQOSNpFFb83L9o7bPdz14sAO60NSxo01dk5RYMYR5+GuYnRFayIFzre8pcsM/m7o3nVGiGIKkKZaHkdrTQs7z3RBanmjGGdL8UoixzsMLK10WMOwa59ua2T4xaUHMsA0FIxwPB6OEOabRGUxf/+LgDlFhszkrh74lWjv4NkVODM+UY7sts843hj0bFZ9saqMAP0Jhxvg0QabpVaSPUdmInAcnpfdE+2d6Vu4xplJSOGYI4o7LkLOSzLhHujhmbFnc2qCwuFlyrpIYa0aMxFqONZNrthbXFUtIHbR9nPUGFbydtMncS8CAY2h+LUs92YQNNOvIjFOAq4sTArXAOP4CY/tXg1YkzdHKy00iBjA2LQ1FJR36eoQ4zisXi0R8/45ycp2PWxR6SMVLNBZwrBhUM1S/dRgATAAA1m6tvPZjZWSgfxCEC249RKbWBo2yipc+qyBXbx/BM5ZMcojfZ8oOHbmILyWmiXTItLid27O1Z9bSVSNghjZ478ueJ30+gwWx2NwcFiDaKkRoy1oj35Z6i6SRnk5WB2uRrHNzMCfMXBwmNY8R4g94Bg+2rdFlOSHNoc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8247.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(52116014)(7416014)(376014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: joFYyid+Hob1BoFlyYKiTztte2bxX5U2d7FKqbNEQKo9Oyr/WcOolAYWJ3D743rT/yUJBSNafvWlPjxSn/1VRSN3fmr9YbPrwoAjCxA4mZmfLsYJ6IORGvKPjAyw/u88zdLss7iuCFXGtQoYrDLEn+4wyzEkpkcvZZyoyyPxf9EcgOGuI6BS/5FcVzn7hBW5jksr/tBHiO/RYJlLEAzinHvSy5zD8kWK7Uu21+//AvBvpkU4kYhsJVibHq31s/2gnCmlI23iFIPjLC5DVFoP9lcbr2/KtSEIaP2J7e5lLXYu5icd6bNvq5NrujLO9+4WGhVG3fwYw0A3xumNw4Tzt2dPi6W8uz6mADCj4QlfwIuoPxFhLrZjef4qGxpme39oriRtcNiWG87O5OnbFGjdyEGLLQtB1B+TVp6eVewvXs3tt8h3thD3rQZEGQD918H7a1lzlUrPYx6G0ghVRxDFuLU8wccB0+uUECw9aS8aO7R8XaQAbb7p3XPWQSf9CWQVek/rWNwtqfSaxAhA01hIw1pBFRozM4lB8SNcq74yn2jz+FANyqaq9TGu6WRK7DvFu5DKPG8FUTVC3cXQza3a3NZiuZXMWiNKicszySSOhB4uaDs/hapUr0Ge2EGzTwyIMYRE3+/83FY4yQtB5gVSKFmu67zcB0QsnSsgE8G4/XJJ35n6yGcZXZkCm2ZeXypI1xq3NaJlkhGyojsOuggI43i6diR8hu7/9MuGWT+W78Hkz9bhNzWSul3GpxI0Z8DjchjElcGKl0bs41FEXDKAUPp6zpFK6USoLxe7l8gc0C9H0xomsg0CIsQtvsEatyM2Gj4rc7h8BvHZ6FGiywemryy865IgsU2R3XbIXy61RwXyyfZzwJyLcXjY7LrLQUYpNegWkZb5S4dex3NLrFqKpwDAzRTW3BuLDhEOR+Eu6rIpagtzexnSVuEauMWWpWD2mAAJ5q05misLQfNC5miE6bGLzzrzcTFJWBkxLf6pb4bUlov47h0oGMjTscqcxwDF8sDTJdgYs/sVJaVCuuJoI3ydodZtID+FtY0O0PchHi7j/9SXPNi7fZcUl9OulYVnRWxiNBHu4Dv2yCDYiLzk2HlZQNdlynISQJxeIZlfFdE2akPxuMrXUF/cLId5H8WJzJo6f2VaobmCoc/HxleIC01gSoutRNm/WCTg1yBAKF7GO4WHtqOpHOPVOG0EyvFgVUC8E1DaejSfJeJgN2Uo/IL63bUy47wawMU6WxedPyWKli0LV1jpQXeqECh/JxcusfNied5cd0dYf9Z/ZxERHpGugDbK4jFOGcPtyyo0Vj4WPksm28D8UeEWb4/Y3yF0jY9kp3/nswQwFP6kAyCcFgXxY15KFErtW415t+VbSUXS6Ov7lKXjqvXrBa+fteDRtN0pR/6j9B9eS4BoR93Jt2ErBplbcCQ6M85Nr9Rep39cWyCOrZdxytGgHADboeJrKKBcwAavPInWdvn5bxYXnKIPEooqHphuKMHfyY7xi+1eZ1L01lvTCPykrl3ATFyxISyc0C+U4cv8BGzMCkVp2s3379fNpyz1EFNE7zG/roPoRstYAlg/H9i5UT84gu3Q X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: c8a7d636-c1a6-406b-ea8f-08dd5bcca4eb X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8247.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2025 10:01:05.6940 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dUywO+KVQ4akgSJoiPXg5p9O3e/+Eb0RmBTZZTUDJ5UxYEEcCEVnveytA7Z/qE2iNuAu9IAKhkGgcq8uN/Fwwg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI0PR04MB10541 Add resets property to dsp node in order to be able to control the dsp run/stall bit from audio block control. Reviewed-by: Frank Li Signed-off-by: Daniel Baluta Reviewed-by: Peng Fan --- arch/arm64/boot/dts/freescale/imx8mp.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi index e0d3b8cba221..90ecee81e465 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi @@ -6,6 +6,7 @@ #include #include #include +#include #include #include #include @@ -2421,6 +2422,8 @@ dsp: dsp@3b6e8000 { mboxes = <&mu2 2 0>, <&mu2 2 1>, <&mu2 3 0>, <&mu2 3 1>; memory-region = <&dsp_reserved>; + resets = <&audio_blk_ctrl IMX8MP_AUDIOMIX_DSP_RUNSTALL>; + reset-names = "runstall"; status = "disabled"; }; }; From patchwork Wed Mar 5 10:00:32 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Baluta X-Patchwork-Id: 14002263 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2040.outbound.protection.outlook.com [40.107.20.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16BBE2066F3; Wed, 5 Mar 2025 10:01:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.20.40 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741168876; cv=fail; b=mABosF592Lu3p2oY92EdTjt8SZ3p8I4O1CHcfW0dZ2RrlaQW8UTXQIhA3MBvBXKyNG4knSnl3eGu/CdSiZyF9I0Nllcm9uhtH1UkTvqO50kmpOukMvAN4EIO04r0gd11OWM3/zYn4xKUWerGs1gevF0dzDLMGdEM1/e/8QWr7Cg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741168876; c=relaxed/simple; bh=259dYXLm+MObzu7jGv5+ZR/+ZkrwuIkrsl3svr443uM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=FY3DSSCff6jN+2y2m14rQCC80EnkTGUFovipXSKm4vRa6emqDDTfiHxVT5dxw6Ddx6lbJWYy20q9RAnPjJBLdcVXPnxKJBTTq9S2md1w4ha0C4H9lspK1dhZQEw/xaf16Q9ynTUbtFCnXcEwPMLRRGSrAmz4bHgsMEnxY2OMvr8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=Y7MOFkiJ; arc=fail smtp.client-ip=40.107.20.40 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="Y7MOFkiJ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=uvDu5Atz2vDLNwLUyJEfN+3Ag0SSRVJ0sSK/Q1IKrQ4GUorPtpifiGFHTPDOa85hLFfrvefFwQm4RnJQtPMbl1AbrjS7aURsV0OXtHXsAsqJzfBHwKHZVPsqRJh3rpCl/ZHvGbFNZYsC8sEvuFt36hupRMS0mPS08GdYyGI5BkMtb+KBdmW8Xde/aScCWoHXWkRsOAwkekeo00JiYRpsS2yMF/sKwp9nopZ1jV5ZAeojPa/lGhQAywN7GFUWux+ELc7hoXU9ahJ02AEMjh7KAl+SQjStzx+upE+jQQC3uqOXn7BMB+PEPaFUaKLQjciVDOHAo/qv+raDKEZ+q60OSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z1UCzXUHSgWcfQB2vGcwiagSt5MUWom2vNc5p8g8uLU=; b=Xi/zXS47yBJA+tNO3JtBdkkPAJllWsQ90bEoYwfQJJDZp30r5/9egLiynH9zr/n8vgVDPJSAVbH0wCoibqiJHA2iZdsYS9J51XUlndB2lafYgVylfjnFYEjOiPjn/wV7DyrTpuv4m8ekvqPRozCtPDzltv8+lqJyluyiKBK7hLlV+ZVix4eicJnIvtepHdnZMU1Tnx2IPqurqn0Ldh+2/3wdQKaETOpNdRaXpp7RzxawTHHEMVTg8QNCmHDe2fPpIVMS0/Y4RGZ3f3mO7aJwFnWAlr1RfMex8b86UqSaGoGhR55MgL0fwEPbRUz9pCMSSWp/tFApA27X4wnbcOU7CQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z1UCzXUHSgWcfQB2vGcwiagSt5MUWom2vNc5p8g8uLU=; b=Y7MOFkiJ3pPkU9gVfGX8ItWr8Sl+h5XW3RmT7gof7dI5JgCLypwdELbaHTsvM+oWXRUn9fKuHo6tosiw5CPTm4Y5VEd7AljHT4814yGzkEnOOYysN3EobD+By1DSQrAgvc1/+KduCYpr/RkkjKrIs2R6Pj6FY+wCy/0bm+RK6cchpWfq60remnQJ9xkCTKG2xSjNee0lj0+KVNL9ZnzszSrwePYyGfaXAzFQwFcAN3SEOtWNCWqCtLOdW+t8/2urXJefnP0Q9mxZYxH3Tl73uyTLNGdRR919oy5W73yG/Kt0BNhHrGq2OvfjKs7IAx3kd8nQtN7FHnCWFy6PBpQiow== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB8247.eurprd04.prod.outlook.com (2603:10a6:20b:3f2::13) by VI0PR04MB10541.eurprd04.prod.outlook.com (2603:10a6:800:26a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8489.27; Wed, 5 Mar 2025 10:01:08 +0000 Received: from AS8PR04MB8247.eurprd04.prod.outlook.com ([fe80::84f7:e2c3:ceed:c0a6]) by AS8PR04MB8247.eurprd04.prod.outlook.com ([fe80::84f7:e2c3:ceed:c0a6%5]) with mapi id 15.20.8511.015; Wed, 5 Mar 2025 10:01:08 +0000 From: Daniel Baluta To: p.zabel@pengutronix.de, robh@kernel.org, krzk+dt@kernel.org, shawnguo@kernel.org, mathieu.poirier@linaro.org, devicetree@vger.kernel.org, linux-remoteproc@vger.kernel.org Cc: conor+dt@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, andersson@kernel.org, Frank.Li@nxp.com, peng.fan@nxp.com, laurentiu.mihalcea@nxp.com, iuliana.prodan@nxp.com, shengjiu.wang@nxp.com, Daniel Baluta Subject: [PATCH v4 4/8] reset: imx8mp-audiomix: Add prefix for internal macro Date: Wed, 5 Mar 2025 12:00:32 +0200 Message-ID: <20250305100037.373782-5-daniel.baluta@nxp.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250305100037.373782-1-daniel.baluta@nxp.com> References: <20250305100037.373782-1-daniel.baluta@nxp.com> X-ClientProxiedBy: WA2P291CA0031.POLP291.PROD.OUTLOOK.COM (2603:10a6:1d0:1f::12) To AS8PR04MB8247.eurprd04.prod.outlook.com (2603:10a6:20b:3f2::13) Precedence: bulk X-Mailing-List: linux-remoteproc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8247:EE_|VI0PR04MB10541:EE_ X-MS-Office365-Filtering-Correlation-Id: 75634066-0015-440f-d5fb-08dd5bcca6a4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|52116014|7416014|376014|7053199007|38350700014; X-Microsoft-Antispam-Message-Info: sJboICR8OdS5c+dQkJ7e+3MD1u86R0IRkaHLzPw0fJuTCmowOIvuTSxkcJQnWn/rNDollrXcl2cC/w/BBYdHL13ye+N2wwoG0Hfkk0NKOp/s3YttCtikh53FBliMkPu54GlVkyLUDxKe3YqLGKDYdhYiTUosFvhAtNLCffGTgcDG6FhIq9ImvYO21ce+ftcPPfv/K+KshA48GzVZmuJlyGwswjEttBpjNuh6Q0/P65OgmBFlZlNXnNHkLUJThYh3iwYXEEDQFQlm5ezoE9r1Kg6eASEmcTlmy7KgEYeXx+aLMg/4cWyN0Hgbo6ygx6YROIlF6kPHKToaqG1UIOrCDCpgxyxCmZArk+4/e/h+oX4KJ6exQ5/az18G9eELNLAexmdzyfbsDuR4cruTK8mTDNEnYaRXtwxig9pXxPjo0R0jsDAAoKrC1A2AczWwNGY9Px9BDQOt1tYW0fvGJP7pEBZv2FYTLYZ1b/G17ROFAeZHJ57b3QMFPq+quEQDhCryCfBIc7krgpuq2/qICHWWZjXsiFoL4Agig0K87NNEGyYvHmHHdUBY9SU7VpYSWhJmaZPBNo0rj+Mhty2VIirNoCU2rYNIlH+XNI298noaTE0IxLRUPI5zNld+4Oj97d3FTf/GZHCUb+CnUXjmwRojll/UEcpf7viHctfcE0Rrnw1ROY3Kn5ZGMjpFpqiEEZe8X4fctCAhama1hIvhYD4RZZpvt/Xn45/2eNs5ilQlNpxdlr9Y7A/MPe4HgpwWyFyb0UtZnHsQseR6uuvLudsUjnWw2g29gVYkhjJEYKUGQRegyDmuz1yZZzp2o0L+plWz2AbPYjuQmadIbSDmEOyfTH2APJnNDJ9ey76isJ0v8qCWr3QMdsgmHDNJ0X870aYMcObL6MnzVjsAaKUTEOPcDtEsdUcu/ZBgrgXFrZSL1LB68QplDkDH/NKmQFybrrqOz3ETnr1xPr3I4NvF8m8Hw+2foZDr1nwR51XVW9riVyuWgfXCW0/X0mPB/LM+HxH5FD3St4H68jAc1ATNiN5WO9Wz9CcNu5rjr7RPzfVF2J5LQZIc3fV4Jx0aoa5Fg7UNWh+DvJMwNd/SYQ0ygTM+ikHJpXQ1q18vOUepyD/KCrEzlps+5VkeU7VFtjxjuDxd4n4gM6gJ0CcuekQtPTl56w5WWb125sV9dviNYN/rgpxwbBanzOA1LlR7geNreJbOZm1zgTIrub6hahwajEwsOTaMePMrlnQtN6D4YfZ84Pp5xQRkHamg4oSuvR589xmQGknvhVWVhAjLKq8UhX6tEqdeHCD+BK8T4p87P+AajtrmpZv1r4VzCsXoNd1hNLruYsws5ZF94blmAmBTbpP0qDewA3t/bmYcAN9I2Mo37DH7ybDylGreJTSJOqByGBFNB/qoPN0t4xsNDO8xf33FHCcwO4uw59djtQ1eTQQWuOcO57k+fKH20Ypm5SrOxwbl X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8247.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(52116014)(7416014)(376014)(7053199007)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: NCbgvfeRfKb3s4yYryWP/TMV4nh0JnOrKK3IrPnFe+y3f5KIUfzc0JcHQYnXefPweNha2keBLHo5tMs6PH2L/QryrNWShOaodG10Lbp8LJTsR225+truIC6dJ7RhXQuyAF+U/mjRp9neVmT15LKg8t/8kv2gDtxF9fORKm01bFei62saIn341DP4/Wm1NCPYd8XHPwzYxU+RwrQt9DwbS/Bjgtf+P1h3F6wcTDKi66rfFvZi85RtBCqg2BK4PLQ1rh1FQgy+CWk4SZA5F8HBjbGMBZ3VohK2LzM563opF34yNQTZQxzM2H+BVmzPb4l8/yADKBngTkIeTqI0tXKBzz2Z+ASBy0oxBt/C+UZBIqjKNf/BCtIP+WofbPNK6vWcfFhvGG9U/Npr1rVX8yF4EbAAk+x4Kh+yBHQguWKj+ineI0xhC/mfNg/hym0riVqPvPpn6U9PocXhlz9S7gubg4/48GcWrGe7lAtNxr7xyjK/WUVjxXSVu25yPD/khCtzMDywf2giYK+HOVHGAgD0HuHZ4nPIgmfRUcfZQaBkDRn8TOYAglszrjhiJyj5SDLpDYIgDmA+qxRi+gvtV3vcfPDe9IJVci/EcxJ/yB1jeJSx20YJyQ03YExQMJd0kTpZMieLHxvBZQYMwytbyNL93sXbfn1Xnwo/sYKbPRY6jG3oUSFo3DbL1OTrk9YbrCF1Rj+dTNQbytWUSZBQEY/9K6MZ7sW9l2XkoaeR5NjfHOPfWVU4P58Vg8MJpaOhPSiBKLvUAbLY/xd214dZBLAy2uQCmU8c6y2RK4Z0sNTmwAm96xerfDR8snqPGrIxbm5jktgGUJaf6b6P94ClHrxNIpLOvkIrL/g65IORlBzSAPLEBbcqCwWyW3EEJZFRU00fP2L6pFSbRmi5MptdtmDzcQ/pOopMxd7fhon58BoCcodRzACQwjkDnHDEqrhqf6hXWam6D4Jhely+MU2o+fPPpKiQ779NL+xLB9kB3zqxyYjm+SXbyd+3m40ycgAu8joVB1JidBN38A03UgJ3e3dpOKHMqoi856WSEsR8jJpbT0NN6VXt3Ea5X+zCgP3qXiS+evhmqpXlM6R6UJKvQpnwmMybMyGcaGFJssQZ/ZNDAf/nDNOKiNWu2koh58dKybJ0DakQ8/mCyd78ggqW3OpFa8P52fP8SHogrs5vjigIClx3HWMVb68uvUg+EnNTgUVDGvyFiJekRrR27PNgRYV4Xy0INFw9+tJlt2da0db3EWKRuXVzMAGmjfZFe+I9Ifr3C0/s18J6kjm108TvZ0KuVqxwL/9Qtu+aB4W048Yr0EzZa0IdwuhALpD5HfM9LChaS6NLMeMqp1MA+Fc3SMKJ3GEC3dG67D1mwqQqeeS4fR5LzyKUIP3GqnHit3DkoiTZ2IbjThjfnRtFmqJxnp2PeAsukurjoSmBanbWFecDj0ptWgWum9wEPHfgjv6OeBRLPXXEIEo1HmgCxVoCx4pWyrq/2Cn/oYzOMjNgvhxXMqN2+87RXD58PvQhEBXZEHqAgnMT0c+eSuvc45lbFCrNW8wcHxep7rNsUeCilKSam3/8sTmTD6ltPGMl1Hb9sZBC X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 75634066-0015-440f-d5fb-08dd5bcca6a4 X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8247.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2025 10:01:08.5732 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2wT3SAiSIHNkdJas6MFw29NIGG059W2TWjFUVDCtmC4IzPmqJxceCURq4lPk8Tn8/ow3gs+sWLPgZScdtacQgg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI0PR04MB10541 This adds IMX8MP_AUDIOMIX_ prefix to internal macros in order to show that specific macros are related to audiomix. Reviewed-by: Philipp Zabel Reviewed-by: Frank Li Reviewed-by: Peng Fan Signed-off-by: Daniel Baluta --- drivers/reset/reset-imx8mp-audiomix.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/reset/reset-imx8mp-audiomix.c b/drivers/reset/reset-imx8mp-audiomix.c index 6e3f3069f727..c2c3e8113182 100644 --- a/drivers/reset/reset-imx8mp-audiomix.c +++ b/drivers/reset/reset-imx8mp-audiomix.c @@ -11,8 +11,8 @@ #include #include -#define EARC 0x200 -#define EARC_RESET_MASK 0x3 +#define IMX8MP_AUDIOMIX_EARC_RESET_OFFSET 0x200 +#define IMX8MP_AUDIOMIX_EARC_RESET_MASK 0x3 struct imx8mp_audiomix_reset { struct reset_controller_dev rcdev; @@ -35,8 +35,8 @@ static int imx8mp_audiomix_reset_assert(struct reset_controller_dev *rcdev, mask = BIT(id); spin_lock_irqsave(&priv->lock, flags); - reg = readl(reg_addr + EARC); - writel(reg & ~mask, reg_addr + EARC); + reg = readl(reg_addr + IMX8MP_AUDIOMIX_EARC_RESET_OFFSET); + writel(reg & ~mask, reg_addr + IMX8MP_AUDIOMIX_EARC_RESET_OFFSET); spin_unlock_irqrestore(&priv->lock, flags); return 0; @@ -52,8 +52,8 @@ static int imx8mp_audiomix_reset_deassert(struct reset_controller_dev *rcdev, mask = BIT(id); spin_lock_irqsave(&priv->lock, flags); - reg = readl(reg_addr + EARC); - writel(reg | mask, reg_addr + EARC); + reg = readl(reg_addr + IMX8MP_AUDIOMIX_EARC_RESET_OFFSET); + writel(reg | mask, reg_addr + IMX8MP_AUDIOMIX_EARC_RESET_OFFSET); spin_unlock_irqrestore(&priv->lock, flags); return 0; @@ -78,7 +78,7 @@ static int imx8mp_audiomix_reset_probe(struct auxiliary_device *adev, spin_lock_init(&priv->lock); priv->rcdev.owner = THIS_MODULE; - priv->rcdev.nr_resets = fls(EARC_RESET_MASK); + priv->rcdev.nr_resets = fls(IMX8MP_AUDIOMIX_EARC_RESET_MASK); priv->rcdev.ops = &imx8mp_audiomix_reset_ops; priv->rcdev.of_node = dev->parent->of_node; priv->rcdev.dev = dev; From patchwork Wed Mar 5 10:00:33 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Baluta X-Patchwork-Id: 14002264 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2040.outbound.protection.outlook.com [40.107.20.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DA5F206F0B; Wed, 5 Mar 2025 10:01:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.20.40 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741168879; cv=fail; b=CKyAS3TQhf1agFGHt93kfjsES5XqfpnnMSqnQsBceHi800SFkOATYWEddpVj81FEKoMayabISGmyg5VXZq93SZfu87gGbiNjMvQzEAKglPfZnnbIU5xZC3ARzgNYNV7hPnbranckKiZrTgC9i+GSqxufHKues/yohrQ3WEvwGFY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741168879; c=relaxed/simple; bh=nNET2o9MG/DnbUz8RuWW0mjS/KloCcBKeipsuWUAI9A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=BhA8jKd8rHOWeM5076XvEHEh4E1eSxYdSvbtFExZGlajp9x07CfsO8jFvMQO6GkKudccvDu8O3wkh8kUBsIhoEENtDzEqM9mG3mlZbyKnKBKxvS7JBB9f8Z3/0TVpYcV/04b9J2IVbg8ySzGBgacX7a5ys/+HZjs8VA9LxU0GjA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=i9R/SIe1; arc=fail smtp.client-ip=40.107.20.40 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="i9R/SIe1" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Bo3vNq2dkSpyXSwmyF/9o0nJ/o7gcyestTZeY7Y4gHaSOVfr28tA3VgfoeWa9Gk7a6jv+J2GsIlDCkNwqMX40E4lE54jDznmrCXx3zmSrqpE8y+6+hzyaDd0U+q+pio8HWP6UdBTBvxmvosrGwFozKIc5mQv5QyDBX+GEw2nE1ZwxG0aW38ytMHEF4dYNUbKQHuYvRij6sAqejAgZWtXGKlyU7JdKCfxVcZ9KjheyCrnPuOHEU4Eq58/U9cXSWclt2+u/TJyvV8R8rSMZgzn0qmg+GCeTDJvwFO/BeJTCtB5//2GlUuGgxZDWt8GROMGzp8xXtAx3iA+p8I56q0lsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SufzJ/ZZ1nnO603FcFiql4zJjMiX33sMOeIReWG+GmY=; b=PzF0OLoCpnXPVJfXKVxoT6Ws/rWRJOaT3/3lv4xtzsf+klSXLeCRogCLh5xK9/vBJMRTYs8G/oQ8VtsJh3R2hxndl0AN4oSfCMSrUNlV16h9/3juj0wW/WjKVn1BhIsS3pJK7zOK14ST1zANCh7EnTutgEfbf2v9JcNJOKj/ClqT5+9joVTw8/ATeVZIXzUpFoYUr65EHdyXLaD20gUjAA86vTZffVlNMOH0pb11TVIEcWxqz2MVAOPQb21uEmZ3u9/xkxGxuvazpwKHHBeeqz5MMutXDBZ91+J5nVaF2G36jlpwRCkdCEaMUgo9KAT5F8zyzM742fEAHqnL/Gu07A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SufzJ/ZZ1nnO603FcFiql4zJjMiX33sMOeIReWG+GmY=; b=i9R/SIe1Gn+bpPvAkyndF9K4VCCog9EBeUomcG75G9z/nkoCuR1ezmhIUskN2xB+7yyr+J6niKc2c4t/AvWcqUcFGuf5cU0NCN2LpL/SHYGbHcCkh7SZYnDKUmd7VEuRNyBec7rvrVzjBL+Bn4R6uanBSMFvtgKtj9QQJk4IpVHC1QpPNzhlkzk//0mjvXl+j+RxrC9aSkZNDRcUsNaKQgYfjvmT+QrsKzmguAQrGCwrq27P5g7kPKgA+D8NsUbQB+xpfIhn6eMG9mk+LMwrcI4FUd+Tmp4Odwy/L606b7TUdUQW8a4InG3IzLAuu9+UvTJa2gKY4xSHj4qgXHYQHA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB8247.eurprd04.prod.outlook.com (2603:10a6:20b:3f2::13) by VI0PR04MB10541.eurprd04.prod.outlook.com (2603:10a6:800:26a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8489.27; Wed, 5 Mar 2025 10:01:11 +0000 Received: from AS8PR04MB8247.eurprd04.prod.outlook.com ([fe80::84f7:e2c3:ceed:c0a6]) by AS8PR04MB8247.eurprd04.prod.outlook.com ([fe80::84f7:e2c3:ceed:c0a6%5]) with mapi id 15.20.8511.015; Wed, 5 Mar 2025 10:01:11 +0000 From: Daniel Baluta To: p.zabel@pengutronix.de, robh@kernel.org, krzk+dt@kernel.org, shawnguo@kernel.org, mathieu.poirier@linaro.org, devicetree@vger.kernel.org, linux-remoteproc@vger.kernel.org Cc: conor+dt@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, andersson@kernel.org, Frank.Li@nxp.com, peng.fan@nxp.com, laurentiu.mihalcea@nxp.com, iuliana.prodan@nxp.com, shengjiu.wang@nxp.com, Daniel Baluta Subject: [PATCH v4 5/8] reset: imx8mp-audiomix: Prepare the code for more reset bits Date: Wed, 5 Mar 2025 12:00:33 +0200 Message-ID: <20250305100037.373782-6-daniel.baluta@nxp.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250305100037.373782-1-daniel.baluta@nxp.com> References: <20250305100037.373782-1-daniel.baluta@nxp.com> X-ClientProxiedBy: WA2P291CA0031.POLP291.PROD.OUTLOOK.COM (2603:10a6:1d0:1f::12) To AS8PR04MB8247.eurprd04.prod.outlook.com (2603:10a6:20b:3f2::13) Precedence: bulk X-Mailing-List: linux-remoteproc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8247:EE_|VI0PR04MB10541:EE_ X-MS-Office365-Filtering-Correlation-Id: a8e90186-5a78-495c-5191-08dd5bcca830 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|52116014|7416014|376014|38350700014; X-Microsoft-Antispam-Message-Info: AcFcVJ2uit2xhnsHrczFtKnR5qi7F8o8pnQ8QbTkUBFDqSmFnC+GbndO5oYSokaUc5a8CnD4G9KS6CNSbBoy70DREvfFM6PjNN5sn4ErbN0ZfWItm/KwJLgFxNHFyzzFngde8eGL2Um3NpENdFvrFZ6zbrzvi8XwGsUMkNGh6nZ++Ya/AZF1dbVCm935YMD2YywbaSPc7OwHJaXTCqGQiTwBbSclAeyJyc1EofeMG6x99SGb7COV0/IjNbXGSa0NOS3Tm3BRIbsw7BSADiWbwnS4JtN3haZZHcQBZqSf/AocHHPgvCou+kAwbxtCuDuSJYUOCxKivCDwjXnGGF4b+PMPY+pSKja0Quy5AWYdnEbsNzGIGyWjl0CO0S7BMQbICF3C38H267cL8dJMbBn+99pbNsVKfpMwDK8S7zv2AuQmLg5ZWfxxzx9VM1IHekft8P/fLcv6wskj3z62w3zItxFaWaB7g3Yxf1bNkRSljQ/QO3zOMI8Mgry6k0e/aPOtjKcYVYVpk0FgezM5G0buQo0EPE9DCkd7KgyZs3REGU6VT5bYYztsaDON4Id008WVT2EUKPxyhJHNltRJgeAnvPlPXmcuYN9TJ9jUZ7BIqU4xg7fb070qatnR/bhxhmhz/SuwVkMxMUWMZr1hX5n67NkjwM4rYtQmVCCjpQMdx6EaaKzshNJAvH/xsEjojPHrvK87TENsHoqBms8qjmLn5R/wEDP1EktTvQYoFe/pH/Y3UdvKzozr90/KzY75L3EgiKslBSpB5KvIR80TBfxDT/BKoldLNN11dJ4HtHt5lJjIHJJ3HpxVL4rqGdMDZfuEq/er0IDhP1cP1dCjoNSolskwh5fR4VwrAN6e6MHaHB3cCV5HrjgUw12GOrX9QxV+hg3hqJdDvOq+OF5YXDeyxwD3/9j2xX9i59BD0pkllZM2xdNiYIC0J9pnj///zMbJAGcntpAodPxCXUog48EnmcROcCT1uMAA2W65BzUYfQqrEY6yEy1Vz3CqypoWM2lZdc5MJaGbm4E/YPKdvDdpFV4Pm9t99DgTYWIVQgwE7vaob6h+ouVXJWhCIf3wrGvri4SYPr8EEC2/cs+qUDzvBPks25zmzkYRK9g011L7ykoV9ezE6ImQGG9TTtILCS9hre8FyIRm4dXrKrOWsdwSHesxrzIRGirbFJBETQUEdjZcIZVvQFO8SaI5VIRNJqZWgzPGWdMG5C6FmiD8Gmkf2rr+knuckmU4cPEIQV27TJppUr3YUBelWF/yMdb9y8cg5FayfV8oQXKQUNLblGdp9+1ryb7haf9DnMXjjjzHdaTXU2Vsi1eLOx6SEmlwBTEWnMFTYsZjMgjvejq94Fw/YLRhvmHItRWGtuE6EP5rO1VLcnfwWaQwVFznE3J6TNPQiimJCPqpgClEmuRnA5GtT0XUJLSTNaLn5R8GS0UrFVNih0jI8d1mLzc/qvkirDrR X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8247.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(52116014)(7416014)(376014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Xk2xn4H4B3Zi1nObPCzoUVwyP2MsD24pZnl2Dp/s1Z230SSOAuB02uxYiqC3qPC874RT1uZEI25x+V6RtnYr/2iS/RLxR4wkXH4Qj8YcY0RxgGh/P3vwlFtHlo7p6VCrUWtikcv9Y2GUXJ9aw/SwjJdXvh1LYn67m6w6Pqn/QaZGMlgMLDJ424fiZCUtvF/tmdn/35QWbENyr/jdMxP0mn0pwBRrwiEuDJ2BdG09rbtriJX21Mf3lfAfKeqx+K1VreF/k0X0mXioEFyjCE0WQZXSvHbC1po/iaUxdWDrOgvDcbFoCxXSgJXaEr6IvC0uutZIybcvQBejR89RoZjk8knSQ/AAEJike5/uxdXmG/rr+Nojgkw5Fnp8Qaw8S8efwP5sBMz6Xhq4JuNryjfg6cXip1cX6/1aJ4OnyDYcCUE/InvhU4DnyL0LklgNMTM0a393X1qgFFq4yc/kYJT5lRdxBHB/bDphOBQz/heBhk5b3CIM9kOPOpSnA27Q7HoatVZq9oCEDnmhnO6/Lo9VcCLCpJpJNYDmKdGzxibxha7OIoEn5F8yor0RP6ROABy7rBrsebf7uWS0DAeEJdUEdjacOVtPPOnDXJZ8jUtsMClzyhYKQgROiZPG7mNYMD/C5BCBhuw8crAGC9ntZ0ylvfEr6rSh3ptVl5LBNxVaeEsKJTzIGnY5U91O13I6CjjGs+kYwCuFrk6FnoO0RYKMh4kLjwdXowYdZ4lps9RPZ9fAHHhdq4GaYy+BZ/AEcixzNSzCr3XPZei/ZYdvRzraaoB+furP7wjsK6HI7AYkCn4Rt3qIASP2xA2Xv+eYpTc4/Tdzu75wgAeCB7LG4JR5kIKrKzVRN5/mdIcWkugdhHMoG7+4/7Uxc+9lZRTHcOyFrjjRu6PKspoRPZSY+B76m/sOsu6asSaVWaABIOVpAX8dAjKBoeS3tyT0WUsim8qBK16OdhMx7Ne6byKry0+Xtr+X17JhsMgGrOlQR7Av6juTwWgKRU8SzuDrLULK59Gi9A0ahrOjF20B7G2kOuBRXVVEHyRyBjWIepTrSetZ7hKH0lPleq8jbHbJomvWbWMwHr4GkU/kqLmERNUW/EYSqSNRMRECZPRpaaXSu//7AzMteWYWEnDa3mU/dPmWIDSkVn7j7rZYVWt8fFH8JVoHxXLewlznSClA/7k5l3jNVX/5VNfYWYcHMasd1Jgu4TZE8XlRpqaLiqYY1iU9xrvqwrv7MheXs3SULdIt6H7rQn2xJvsEtppBpZnSxsXwDtZVu3lGtdKtyOXlzOKYMEe7KUGw5skBwEBtvMxHfPnzmIRp1dyjfHpXDzOM5r7KVT/FOC8a/eMX6lAbMJ0DKo8hWNSyz2MG1KTf7Hu1+9pRTTjVc13MJnPWEyCl23lNad6FbDo5amcq69FtEzCFl+xVI0vXGH1hoZ5F2rYFhoNgaLtjckL2Q90C9NUf0GjXc/+CZrMLWJsaln69RRXnVVivJtXF6LlnGEQBv3DIloobPVei4pLubkuYbUBbQxr0Yj0w9XvwvfFw1roN4JNi158TL803T3RkxvYCeUyyN/K+HWz2jqy4mg/sxF4nj0gllbCt X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: a8e90186-5a78-495c-5191-08dd5bcca830 X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8247.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2025 10:01:11.2817 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZFMmrFG1SDQcoawzuHgClBhywAcdkx598OBH4AOwZ8lHQfM2Ft48B0hwU3vn9NoHmUrBO6WUVFARN2vw2JciEw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI0PR04MB10541 Current code supports EARC PHY Software Reset and EARC Software Reset but it is not easily extensible to more reset bits. So, refactor the code in order to easily allow more reset bits in the future. Reviewed-by: Frank Li Signed-off-by: Daniel Baluta Reviewed-by: Peng Fan --- drivers/reset/reset-imx8mp-audiomix.c | 43 ++++++++++++++++++++------- 1 file changed, 33 insertions(+), 10 deletions(-) diff --git a/drivers/reset/reset-imx8mp-audiomix.c b/drivers/reset/reset-imx8mp-audiomix.c index c2c3e8113182..abef6d768e62 100644 --- a/drivers/reset/reset-imx8mp-audiomix.c +++ b/drivers/reset/reset-imx8mp-audiomix.c @@ -3,6 +3,8 @@ * Copyright 2024 NXP */ +#include + #include #include #include @@ -12,7 +14,24 @@ #include #define IMX8MP_AUDIOMIX_EARC_RESET_OFFSET 0x200 -#define IMX8MP_AUDIOMIX_EARC_RESET_MASK 0x3 +#define IMX8MP_AUDIOMIX_EARC_RESET_MASK BIT(1) +#define IMX8MP_AUDIOMIX_EARC_PHY_RESET_MASK BIT(2) + +struct imx8mp_reset_map { + unsigned int offset; + unsigned int mask; +}; + +static const struct imx8mp_reset_map reset_map[] = { + [IMX8MP_AUDIOMIX_EARC_RESET] = { + .offset = IMX8MP_AUDIOMIX_EARC_RESET_OFFSET, + .mask = IMX8MP_AUDIOMIX_EARC_RESET_MASK, + }, + [IMX8MP_AUDIOMIX_EARC_PHY_RESET] = { + .offset = IMX8MP_AUDIOMIX_EARC_RESET_OFFSET, + .mask = IMX8MP_AUDIOMIX_EARC_PHY_RESET_MASK, + }, +}; struct imx8mp_audiomix_reset { struct reset_controller_dev rcdev; @@ -30,13 +49,15 @@ static int imx8mp_audiomix_reset_assert(struct reset_controller_dev *rcdev, { struct imx8mp_audiomix_reset *priv = to_imx8mp_audiomix_reset(rcdev); void __iomem *reg_addr = priv->base; - unsigned int mask, reg; + unsigned int mask, offset, reg; unsigned long flags; - mask = BIT(id); + mask = reset_map[id].mask; + offset = reset_map[id].offset; + spin_lock_irqsave(&priv->lock, flags); - reg = readl(reg_addr + IMX8MP_AUDIOMIX_EARC_RESET_OFFSET); - writel(reg & ~mask, reg_addr + IMX8MP_AUDIOMIX_EARC_RESET_OFFSET); + reg = readl(reg_addr + offset); + writel(reg & ~mask, reg_addr + offset); spin_unlock_irqrestore(&priv->lock, flags); return 0; @@ -47,13 +68,15 @@ static int imx8mp_audiomix_reset_deassert(struct reset_controller_dev *rcdev, { struct imx8mp_audiomix_reset *priv = to_imx8mp_audiomix_reset(rcdev); void __iomem *reg_addr = priv->base; - unsigned int mask, reg; + unsigned int mask, offset, reg; unsigned long flags; - mask = BIT(id); + mask = reset_map[id].mask; + offset = reset_map[id].offset; + spin_lock_irqsave(&priv->lock, flags); - reg = readl(reg_addr + IMX8MP_AUDIOMIX_EARC_RESET_OFFSET); - writel(reg | mask, reg_addr + IMX8MP_AUDIOMIX_EARC_RESET_OFFSET); + reg = readl(reg_addr + offset); + writel(reg | mask, reg_addr + offset); spin_unlock_irqrestore(&priv->lock, flags); return 0; @@ -78,7 +101,7 @@ static int imx8mp_audiomix_reset_probe(struct auxiliary_device *adev, spin_lock_init(&priv->lock); priv->rcdev.owner = THIS_MODULE; - priv->rcdev.nr_resets = fls(IMX8MP_AUDIOMIX_EARC_RESET_MASK); + priv->rcdev.nr_resets = ARRAY_SIZE(reset_map); priv->rcdev.ops = &imx8mp_audiomix_reset_ops; priv->rcdev.of_node = dev->parent->of_node; priv->rcdev.dev = dev; From patchwork Wed Mar 5 10:00:34 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Baluta X-Patchwork-Id: 14002265 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2040.outbound.protection.outlook.com [40.107.20.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCA0E206F2E; Wed, 5 Mar 2025 10:01:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.20.40 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741168881; cv=fail; b=nvJdqyfxLhnyv6lLxtEOYgUj1B7XNsBjLKEdoXj2UsV1DCJAcqxGgNpL5yG5jkX8Vdzmn4Ya96jtTShBXootGB+U2VnoaO7KCSQELTGxVYGZBErYg2jyLcrf7Bn19IZW/t0v4ETTJHzFurjVVBvElLzFZ3VHuzxaFxbyMmtZcMM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741168881; c=relaxed/simple; bh=C6CObQ20S2bL8rK0CXqBcWBs6rdo2Vbippk/sFCdEAE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=CRCyik5I3yj1yWkbs4p0jHBmhoe4+vqUK9z6DsEmeS/HOXrxfvFC9tIcLCeTPj9u4C0PTZzGO07VWDJEsL/X8aSHGG0dqqdqKnQfwL9Y6bfmgHTPij2Bmg41cx9hRzSkFNCBc36mbaR0Z6/a/PZBPoMah2h92q4EgcatPejQ53Y= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=GTR6k6RH; arc=fail smtp.client-ip=40.107.20.40 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="GTR6k6RH" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=aESmLtErvKKSF9zaXxuYSl856v+/0L18Id84gtac6kouv3XU5YiXEjodcSG66JGfE6SoeH9Al71ReCAJ2zzzt5Kb3L0StI4xdXhGaIpwDulk5cKDij/cEWzkOgWaZu1jkJFJA7kQq4+N+rxNNorC05ykKjcV7XbPcuLeDUSn/Kqymo4BpTBWH5HEGB1sp2ecqk5TDcUtAhrR5P3CtYlI1CrgyQQ/Xz7G5fnE1/rygcasRluEvXjZCeF54JrIhjQXCxqiZx58ljNkj+pyOChnEo3nGRuQ6itWXjrlsyWCxPFNYmiCHLAq8LdEN/9NKUO56FF0j4W+KPT92u6+1Vw4TA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UoWerf/Floya97PLnucqOzprD5LnjvQTcTSnYM0OHRc=; b=yIT+0tFS6SuEtvs/qwSa4HjS1rhxIf4r8C96B5ux2zsuNnge99xyru/VOLcPyNDRSbhOk9rbhXDgm2YG8XwNU2wUgRwI596Mlfbbm9B0q0hXxE+qG+qhnUxPWBya3g5Sm1Of+7+vnQXVTJ/s7OVzwbgfdPMfNl0W3ACzdbxB4oDwl8lTaqEHpXdxPE/UX4HdOYIxLL6Vx+SMQFLpNlbWdJOmYnkbt7/KsKPcDDc90BcuStOLmQRZe5P0QY1Zx7rdmwz5u3Z6DG6SMpTO9HfeqZFxFCSfYAi+7jp6Yve7r8LXOjMYPR/k18T+IviH95qffgw8Yx9PgiAfNUT+RDZdgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UoWerf/Floya97PLnucqOzprD5LnjvQTcTSnYM0OHRc=; b=GTR6k6RH5L21N0GcSaai6jyiPgwbcjZRyEn0EjXRPzDAFuAh0E8SNH+84KjOfuIDHp/SPky+W1rWhWmd/ZZIJ9UbUHpRD6GQ5f/pMozYpfbsqa0tSwKvvsfyvCtqXMwsqGtZkz8lzVTyQxvKyHjwEP1qrY0KpCi6j2AsNMCqE/6dP39lQermaUuxsXfkL+gsrPiN3RIEdRrvSPDanwiq+oMm3JvrFEPK3EU5ZGi3J0s+LYTPNHMWOInzIXlpyZenWegN7hyf8Mw2Hj9QiaOfPbTUkW51JhjZDR2PX3ORpK9pUOS01/1vN5BaLB1vKX5/E0RZFYUmLUpuoKIEztprXw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB8247.eurprd04.prod.outlook.com (2603:10a6:20b:3f2::13) by VI0PR04MB10541.eurprd04.prod.outlook.com (2603:10a6:800:26a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8489.27; Wed, 5 Mar 2025 10:01:13 +0000 Received: from AS8PR04MB8247.eurprd04.prod.outlook.com ([fe80::84f7:e2c3:ceed:c0a6]) by AS8PR04MB8247.eurprd04.prod.outlook.com ([fe80::84f7:e2c3:ceed:c0a6%5]) with mapi id 15.20.8511.015; Wed, 5 Mar 2025 10:01:13 +0000 From: Daniel Baluta To: p.zabel@pengutronix.de, robh@kernel.org, krzk+dt@kernel.org, shawnguo@kernel.org, mathieu.poirier@linaro.org, devicetree@vger.kernel.org, linux-remoteproc@vger.kernel.org Cc: conor+dt@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, andersson@kernel.org, Frank.Li@nxp.com, peng.fan@nxp.com, laurentiu.mihalcea@nxp.com, iuliana.prodan@nxp.com, shengjiu.wang@nxp.com, Daniel Baluta Subject: [PATCH v4 6/8] reset: imx8mp-audiomix: Introduce active_low configuration option Date: Wed, 5 Mar 2025 12:00:34 +0200 Message-ID: <20250305100037.373782-7-daniel.baluta@nxp.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250305100037.373782-1-daniel.baluta@nxp.com> References: <20250305100037.373782-1-daniel.baluta@nxp.com> X-ClientProxiedBy: WA2P291CA0031.POLP291.PROD.OUTLOOK.COM (2603:10a6:1d0:1f::12) To AS8PR04MB8247.eurprd04.prod.outlook.com (2603:10a6:20b:3f2::13) Precedence: bulk X-Mailing-List: linux-remoteproc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8247:EE_|VI0PR04MB10541:EE_ X-MS-Office365-Filtering-Correlation-Id: d8b9929a-3a73-4e28-53c2-08dd5bcca9b7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|52116014|7416014|376014|7053199007|38350700014; X-Microsoft-Antispam-Message-Info: qidBD/hNV6kdRHzKd6KBOv1lDmlIb+9Pi0Ingmr5LQSnics6k+TE7EDZhVWzwS1DL7X8Df10MRmgMy51vtq9KYkLLxqSvjvnUl3lXu/+1HxXY34l2wHbW2dxkdjqHIegLnrm9wN1nEwe41WoJSlgbPtzL/4bshdBcplrs3IxTPd7G472JYV/Thy+gKLIwRxfP8Jb3iKkRRG5qXu7s2n28nDxFiv/AgDUp9Jc+Yi07I4u9GdZu5ArgF27csfvqPVrYlJBlOjwg2JEd3jKxq+lnXuc9uuorGxRCooou8u12PHIRwsCVxORXUU0YiR68Qb3u17OrFg2CftL9ig7tu5yJmefQ+IzbFwzw57JTSeCnhsObam9yhETN1MHl5AwsycCjDaV6JMl3sGyRVZAoaI5v2vFga4d6e/tcG1uzc9LnwlxNX98jmt9OLJ534vnuQ81FNY7ejtJ4Eo2HHhtfLqc/c3N72eCGj8SFG8OGl5ghmrHHuLonNSOOB+uyk84T/LyDp9rbmQNTcReEISVXKXNNafKzLKlwE57uFUVKp4+XfESiLPQS2Z2JVYoVUDhxK7FYzAsLJUMFUkdT1q1R7s/UCStaSBTF4ULdFGZ+x7Q7r94c7JSFbUcvvKgENAfDu+hq/qP98qDx6KuYd4SrwJeZqn0PTBumg+X4BCVYL8IwjABUM15DmWyRjCs7mOKovyl4+NMbDziw4PAxLfpLItu09FNSYQUVCc43unAwGSRRsL4N818mxsbiePaUpHsztArhydrPc7zPOMynR9Fa88tCIOmdOAomsR774axAqbXXeAaCUIXgVdQDkHGfpvLbxmPnE878JXpIWrA/d1DDFbDu9kZ6gzxHZUv280AhJs0rRXFon07+SiEYg5io/jL/Z7IfUcWv06TDmsEmMDNh13fvYpT8Ckcczj8Y6E3PGhpliGi7KhrjOHUypxjbi5tkFtSNecMgs88A7D7u3iRi67rkzS4rVz/6hy9mMDUj+yRw5AAoeb6fU12xP+pmTLH+gop6MrCunTDjhAbMCXE0I5QR1+Ti563eqqnJ+5nfecoIR8UrTxehjeC6sdc1R6Wxb5SQcMsHwaeGoU9o4D2a+okrJk5CRL4RioIftFcuoZDJpzKbKuCahFkxcb0iK7aaFFlprMuWDTGxBVsYL5inmK1Y/P09QetD5wFsIjUpXkNA3KANcPzJtSbckptGvaq3zQ/4JGk+4aAbtA41j8YQM44gcHyL5G+RsTFz6UVOVGJkOBbyweAceeKfdIP4Ztw3Lv5skNRt2tYGDMYhpkYP8FuppfAXG7WSqPwIk082uw/IHukZS2YdWbl29wXMBqw9Up+pJElPGrQMSCsW1QwDLI6ZNnGku3q1zlulVVt5BVmXq/al6/Y6f2ZS/agPqs/OkwGSTT+eVFsZ5kXv2HNo0O5hMndpR4q/kDXb37mnEbLvZeZJVBby6azLT8q75otK9WH X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8247.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(52116014)(7416014)(376014)(7053199007)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: BlJEH0AhWTXwEomrI/X00xLbii2zD076D3yuccIv2soeWlJqvGq8LoW/et06NxyTXO/VByAZ3ry9Ll7oiVJUU/utXH0ZMFVA2+nCMbTeXuCXUkqH3Y3zFoXvfr07IC45S6t2gM4Dr0gTnDZOL+W8SnW4ZZ5Lu9lGF14wbFvWJgrfTZ9MbCaurU7Ru4/Z1A/X5b51V7twuN3y6CLJ2fXMNAbbn5PaVhWOdDuOjjysuue0Ca8XCMd/9utabhPbL2qbhQzYHm3OgphFfS+jPNW/rCaZeh7FauRF6PLaULhwxWWggC8ceAc1z7g1ktfOa7xDFTx1PRBExzx8rTyBkcLsB+8Kb04oJT7y1KcvBMENncML+AKJPkGQvokXG2Q5l7ZmxysBcnU6Y8SLP4FseE6PpCFHddVdGAXMVwMwJCN/BBWw8gZmH5J4CU1FJaGQ3i0MKr60dckcb1JfonkVsCsX5i8XbuzFoRJeDiL2BO2V3FjH9Zzd8s9m1d24SmDoU3/Nf8/gk1ecpI0faQDvz2vBL/zfba7OZ75UH7Od5Eb8AmWxshUQZKw0M+LVKRGiOsc6Dm9Axz6ip24ZcjeAD747ow34BQHDo/BDJCORbs60BtKbxDL1Z3mY8wfIqtdj77/rjsvXCtHo9c+e+QBpbRywdikplmlY7u+8roa3m1MtYr62SSZCWNs2DBIMIg0OFbo283hJBX6fetunZACshAZ+7EaN3zOlAXLcO06LMd7EPX5L/CzWejRXfuN/35MbkphNqMHQmGS57y3EXW1ZhuPIMoND9x+wEIaRO8ZJw49VxWU9sIEjMFMPMrQuTJ5i6H/8tSBen7B6h0S0XVYF78c6+iLcA20PEap1j8pi0t0IFB8udLTnEsJPqtgsAyn1BP9rYdfOJDbWEkF8aRepSv0NhSgEjrTINg3KbGSqPIXC+vxGo8IUhEZkAyWXJliX7BS6EcZlIcpmpPYgQzfjX+dETd65WLZItVahSmQYWlHQk6a0+rUfoW/Di4Q0d62Y0q7IN1KHmAllkUb9p067MkWdatezHzOr6RDoX9uHY5LQSrbydfekNQeolSUYYi0yeJR62OSLBzLFKS9GundC7YDXbuBQFKMMn6pg0yzYtmWb7+M2ad/RV7cqwc6XEqjD3wrlmM/hCArmB7S9JQjMrWkf7N2NDG1wV82HA+earJmAsvNh2rm86jX9VUU07XhgEmGkaEaDGL/rB7/KP5tMr46WbSwGFpJIVztULixDNsAz2+jIDk0bszN5UWSBZ0Y5L8PXzxSxhPCbRzniLNPfjo+l4g3osu2bdKiV7H9Kkkln9ik4hkYLE4Drq8Cswc7uOAZzIrUuZPExMMrNkAWAm1SCDGTFF4tKPnBzni/C52jWEGr9pq/58FvW1jUBuX84gEGHQE9ZMdh+yPJ5wyb0w1x7D5EgoNDU4FGcUrgHfEYJEDZ6SgNonHTbjA5bVLmaBBDtNiLiDQdCeouef00fU6mG1rJpIWvfqDS9GF/6ZfAG/enC+BQoQzIkrCkXLXw8icm3s2/jsUWCkGoteUg/3Q4zzB6DY5Fcg7OcLDK8UdjUMbHHscQRdgh0PIHhfDsmjN3S X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: d8b9929a-3a73-4e28-53c2-08dd5bcca9b7 X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8247.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2025 10:01:13.7403 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6TN7QPcSFKNn9zEEDs3gFfYxfQ9QWwAp0zdjtxUFFGjyheMmiWXR8rWLVUkcFZQDaavMhK8N9ATkiN/4gD9KKQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI0PR04MB10541 For EARC and EARC PHY the reset happens when clearing the reset bits. Refactor assert/deassert function in order to take into account the active_low configuration option. Reviewed-by: Philipp Zabel Reviewed-by: Peng Fan Reviewed-by: Frank Li Signed-off-by: Daniel Baluta --- drivers/reset/reset-imx8mp-audiomix.c | 41 ++++++++++++++------------- 1 file changed, 22 insertions(+), 19 deletions(-) diff --git a/drivers/reset/reset-imx8mp-audiomix.c b/drivers/reset/reset-imx8mp-audiomix.c index abef6d768e62..04ad27aca806 100644 --- a/drivers/reset/reset-imx8mp-audiomix.c +++ b/drivers/reset/reset-imx8mp-audiomix.c @@ -20,16 +20,19 @@ struct imx8mp_reset_map { unsigned int offset; unsigned int mask; + bool active_low; }; static const struct imx8mp_reset_map reset_map[] = { [IMX8MP_AUDIOMIX_EARC_RESET] = { .offset = IMX8MP_AUDIOMIX_EARC_RESET_OFFSET, .mask = IMX8MP_AUDIOMIX_EARC_RESET_MASK, + .active_low = true, }, [IMX8MP_AUDIOMIX_EARC_PHY_RESET] = { .offset = IMX8MP_AUDIOMIX_EARC_RESET_OFFSET, .mask = IMX8MP_AUDIOMIX_EARC_PHY_RESET_MASK, + .active_low = true, }, }; @@ -44,42 +47,42 @@ static struct imx8mp_audiomix_reset *to_imx8mp_audiomix_reset(struct reset_contr return container_of(rcdev, struct imx8mp_audiomix_reset, rcdev); } -static int imx8mp_audiomix_reset_assert(struct reset_controller_dev *rcdev, - unsigned long id) +static int imx8mp_audiomix_update(struct reset_controller_dev *rcdev, + unsigned long id, bool assert) { struct imx8mp_audiomix_reset *priv = to_imx8mp_audiomix_reset(rcdev); void __iomem *reg_addr = priv->base; - unsigned int mask, offset, reg; - unsigned long flags; + unsigned int mask, offset, active_low; + unsigned long reg, flags; mask = reset_map[id].mask; offset = reset_map[id].offset; + active_low = reset_map[id].active_low; spin_lock_irqsave(&priv->lock, flags); + reg = readl(reg_addr + offset); - writel(reg & ~mask, reg_addr + offset); + if (active_low ^ assert) + reg |= mask; + else + reg &= ~mask; + writel(reg, reg_addr + offset); + spin_unlock_irqrestore(&priv->lock, flags); return 0; } +static int imx8mp_audiomix_reset_assert(struct reset_controller_dev *rcdev, + unsigned long id) +{ + return imx8mp_audiomix_update(rcdev, id, true); +} + static int imx8mp_audiomix_reset_deassert(struct reset_controller_dev *rcdev, unsigned long id) { - struct imx8mp_audiomix_reset *priv = to_imx8mp_audiomix_reset(rcdev); - void __iomem *reg_addr = priv->base; - unsigned int mask, offset, reg; - unsigned long flags; - - mask = reset_map[id].mask; - offset = reset_map[id].offset; - - spin_lock_irqsave(&priv->lock, flags); - reg = readl(reg_addr + offset); - writel(reg | mask, reg_addr + offset); - spin_unlock_irqrestore(&priv->lock, flags); - - return 0; + return imx8mp_audiomix_update(rcdev, id, false); } static const struct reset_control_ops imx8mp_audiomix_reset_ops = { From patchwork Wed Mar 5 10:00:35 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Baluta X-Patchwork-Id: 14002266 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2040.outbound.protection.outlook.com [40.107.20.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0522207658; Wed, 5 Mar 2025 10:01:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.20.40 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741168883; cv=fail; b=FwkmbaODHAP2bdIbvzY09XAF9zR1pgg4jIfq3EFIdXCoj+294nuFPfQ2MfNCAZ2kyTvV9/9oH+PGKr3T//3Fjw02YnQX+g00WASSDZ4xOFlg+mJi6It6ZC8pWcdmsoVRP6pu4oYqV2n3P5lntowRlva6NAnjPgxnEa/KhWU5+0U= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741168883; c=relaxed/simple; bh=YritmhOjf3ccSOJ4/GBJIlP2XKujZqfFBfTVQgNfMyE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=mffQv0flspUZw1Dd/ePuR59pxQTCwp+tK8jUCgfVJiYcvoMW/okqc8CsAbKf83RGpgIMwEUzGJXFv8e+8vqcoMniA0HjxLzzWusQXfOwDlLncZNQSW8mJ8CeXbwzv1nUqm97t+m7WczXvLiO3swhqH/2B/A23YChoatYG6ey3HY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=ds2OR/Oy; arc=fail smtp.client-ip=40.107.20.40 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="ds2OR/Oy" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=exx2OCgRzVJQLAcxxfoEw99q8sOogq/BcqkhtB3NbAenbVSyyOgPeyUdBTnZ+rsxITcyqxhUmvrRI87Uoszg3pcpwQDTImEPYx1NkqlibVmle2r1U38rB6jId3K27TbLIMKt465c0IEUove0+1PRTL7QPKRkj6wUdF2wqpeDKc3R49qZnx6Jbaw9f7PHI4HV1XAV2Ea4Gi5FHT3P/B9mhePtOqaZV6oCVo4WI0Zpq1TQ2OLg8b0EufTRJwLn46nZX6sM9PDserAkQc/1wodW0gvdbp2OBMMaOSd1XdvE84L9Ql6KB8TDdfsPTlxsnKDIJFut+jY7SeDVQHockr7W5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sTsrVbs71pSl3nHVoYW7ycmSUiuNwFBNK93g5XNbbZA=; b=Fk4s1h91DMrXxWy2Vb8R7IiPzc2rjA20T7qeKoSYv4kuPfS7xQRuMcxP8vKv3eylB0Fb0Ipd9CCbZ9MiYmCrrEQlQ4bgqpzU54G72KOtuurLi/Y2DcUTUVYM9MbYbXkFJfERg8UQiYTaS1hsELe6O3XNmKgf7cutRmgM6KInnQ+NGYIA9t2pAJmChJWTvotKZlKKazswv912HAl6l2Xzy/NzN9Gzzm3p3yQUt7AqamjPUpzA/NO+m2u6kbNKigpchKZKa4trfskni4EFXIkQrxue1R2zXw0mLwbBG7czN/31JjZckvmB0/X3niae8nEeZ4q0RLjX6MhjNpXIVS6kZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sTsrVbs71pSl3nHVoYW7ycmSUiuNwFBNK93g5XNbbZA=; b=ds2OR/OyZwfkD+OBOGhCNBhfDEwGefMY/dq48fPdtNRLzy6FD9D2L9dG7LZi2vYoD9tb7quU/NmyCDyWWuaWMbCvmOhhk9EV31WO9P6mrjjevwE9H7G95pUhNFioDpON2clJxyafDcO1EroIQA8QYj7+JdXZ2xRAiRAt4BbL8bomYsTZi/sJiqGZULRROWIQ/w7r5fEUGmGDNW0Q3ug9LiNa8AcBFolYuPf7dMPjMA2qteZLuWoQTPNdhR//TgR5aODs10vI4Ekz3N3bmJBVNitIZktqSNjBDggmDTwTW3XudDjR+rTeaeKJQhHUvvJKnKV1KenRzHgT2NpJYUCKlg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB8247.eurprd04.prod.outlook.com (2603:10a6:20b:3f2::13) by VI0PR04MB10541.eurprd04.prod.outlook.com (2603:10a6:800:26a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8489.27; Wed, 5 Mar 2025 10:01:16 +0000 Received: from AS8PR04MB8247.eurprd04.prod.outlook.com ([fe80::84f7:e2c3:ceed:c0a6]) by AS8PR04MB8247.eurprd04.prod.outlook.com ([fe80::84f7:e2c3:ceed:c0a6%5]) with mapi id 15.20.8511.015; Wed, 5 Mar 2025 10:01:16 +0000 From: Daniel Baluta To: p.zabel@pengutronix.de, robh@kernel.org, krzk+dt@kernel.org, shawnguo@kernel.org, mathieu.poirier@linaro.org, devicetree@vger.kernel.org, linux-remoteproc@vger.kernel.org Cc: conor+dt@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, andersson@kernel.org, Frank.Li@nxp.com, peng.fan@nxp.com, laurentiu.mihalcea@nxp.com, iuliana.prodan@nxp.com, shengjiu.wang@nxp.com, Daniel Baluta Subject: [PATCH v4 7/8] reset: imx8mp-audiomix: Add support for DSP run/stall Date: Wed, 5 Mar 2025 12:00:35 +0200 Message-ID: <20250305100037.373782-8-daniel.baluta@nxp.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250305100037.373782-1-daniel.baluta@nxp.com> References: <20250305100037.373782-1-daniel.baluta@nxp.com> X-ClientProxiedBy: WA2P291CA0031.POLP291.PROD.OUTLOOK.COM (2603:10a6:1d0:1f::12) To AS8PR04MB8247.eurprd04.prod.outlook.com (2603:10a6:20b:3f2::13) Precedence: bulk X-Mailing-List: linux-remoteproc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8247:EE_|VI0PR04MB10541:EE_ X-MS-Office365-Filtering-Correlation-Id: cbc3f511-9828-48ef-699f-08dd5bccab33 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|52116014|7416014|376014|38350700014; X-Microsoft-Antispam-Message-Info: GuLkQ3s4MHUDv9BgBKV9vfzEYwoowk4NRE7egOHyH0Jg7EbSTNQoScFw6B1dEDOqPILzS9XDm7kcQxTt5Ca2angplN0vUxZ3Tgu9vT3eqcHVB4BzcGkKPu/dvbdu+w3cG94JEMc/VqUPiNWHy0dbKuC8vfJrnDlWsSfRtWMIfrmUIHDLSqiWAp/kbXv1DTTnHLLi09Z9tP0jD1siaqu+MHM5yL1igncjmR5zaszYVCDf32sgwfSy3By0eQ0dqMjrpSX4u7uxKUF27CJu/IUPgEzCieskq9QDTqjTF4qanvUa1w1jgywBLotxoesy/1Dse39hYNlRg1J/Z4mu9AqSBj7Qv6KDvKTYghwG5G8sbS5YU3DXdj/Qq1ysptFsJc7UcPLsDJ1PQ1D7RhX1B+Sh9fDNDNE8apjp41yC0JVrloYwb8ZGZNmyjJbSjXsT1zKQVN0Oi3cFwrH0MjIOatabtxjlYdJKogFFZn6aMofVFeuwhm0haQpOr3TkSrdrZRKYuVIiPL+Ym2hkTDH0e/rNTUxnJCqXtiF5h5qkhuWKA2kfo9+N8A+nOiTNvgrkPjyuKhSauG3zRFoqJHksatnMeEcYzt4gzXfyyPv338DDS2l/LdYkAZKwfH2XzrZ4guH5bdZrONFrAMC9kQMfCDhIik0OIYCe2tT//ZQe5Dqk3cQrmXaC6pw1341uLOUg9dUUbzWF6WBmLqE6QyASnqmPf+KtAcNq9OgTHxefQDbIlhVWNtmizDvbtlzdV+G8tmJC/W1gyQXHbEhvOLSvBRxuJl81iozwXseFSZe0AgWZwvG+UcUtawB6gxnfcBpsS2Rp+8AUxV5SjBRossEstDm/+O4WrIb+PuBw7DGOj+kECK6EruqxceGhRf2kvM8KFmPkQsJ40KwvL0GkTtNOW9CtE/lcdnW5JMdR/6flTGeYUwqEQK5Rg/A99kTpXumM0Q17nGoQ6J8234l4UBnIGi+eW4jUPZvcw93uh61I0MCS0i2BQrIhYuLQXwpwixHH30cXIhjI1PpuUs13T2nLiBrd/fkjqvYgk4ucEoDS04SUN/nqF56X1elAZ5AzUjYYogvFpd8x8bR+4mc41U3tgrKV2r2uaArTo4ozWFJ7NnsLZfFTuyODlDLbrJuxVUdF7NzbYDF8jaFC/fiQCHJwUBHWaEfYRBYX/gYZlsToU8Anatz1L3wkul706MP0e/Fbg3UTWIicMxX4P7ecFuQ6C7V93IAFxIhV/oyeahmx1ouYYAp3NLb19L5Pnv1CBcLNwiLdc5NjPIK4VMrcde6YOremRZ45/IpmwYS9l4+moz39U/oxLmtugPalEsfZ92lEEhO8FltKHkk8sj0U34j04IBHalJcr6ddE7uidYBW8aZ0/8TYtB1p2PHdrHlGQmQFuIhwmiZlblOjAoPQm1SvQPEkAIwNte4kw/xFuecuVE2wU0Zi5g8vnR+THm66GTjyY0md X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8247.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(52116014)(7416014)(376014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 8yW3Y0lTHAa2bwN8dDtzlVOKSNOU4z0ALyHYs7pV/g8xdstwFz+bE7oVs/HOwFWB23+m/K2hHxJkf4r361r1sKBhO8aW34wqt+iCMUgNmEdbOq03HZJgos3LtEQJZoo7+VfR4NubkjwAcaUxLnohHjwwrPutrTRFhTpDsSLee4CkqhgPt1URBpKSN6qmcgN6nVMUGNKfLGiUZ8YvfTGyVMvPHg/mwzglipe+GEVfcWiMSBJ7R1K9UN1WlRr9lPkfdze3ciiQ131b+YSrd00EpEXZH4UD8NKgSHFke2hoaW+aRd2IYOGR/yu9I7YeKvPAAKBauzdsm5k7gsuzepEgAqkXbzYaQyq10tX4403oIstzcpPSOvieo+H0ZZef2MI+8zikFH7ya/TTcAPTmvt9/GI6o1GS44EbfNGJA3XlAgaADtVpWFiO77nVc9qSlrSytfEb3+BfEuaSsroZQraLavpZPoHhbBp+gspU7vsUfLwkZ0fkE+1sEaPahry1ysBADIOVs2/ZIvMvXwD961qd7BVx6F8/3gaz0PshBWrNG5nGTdDcb6F5MtZTmmG7udXTsq9nMnqnelu1g4kn/0zwmoCpfuGq52BF9kDINQYYzNvlN6MTSkyaHYqODJXLO9wE0tand4cSwF6oMNz2/McPSiaLM7kpkqS25cTI7XroiB0IHGGwj8tqxbcJok0/sPRcBQHG/EdshGwH1wxwm9GPYq7gitG/eCHPhzYy9HQr4HwLrybMcMKLM+JkDYsyi/WZqkZfRIvSIja2acneCSTkRZHJwE5iATlZgmQl4bY41f6kBBNv6ludk2NIhUVmb/pqvuHgl5zzlPdEvHZwcZTcIo5hObNrewmIJ9VQUk9lYZxhNlNyT8uZRjmvzGAxV2bFjHoBfoh9dSTKRwFbpOAVf8J3xr7bHvy1/W72EXtHSH3Mu8ZMbiNX8XKq5D2AGfGguuaRD0O9Ba1iD7p0HMIGvqWHWiO59P5cnRpgplSSQG+IqWr7NIgmZyi44gOovxaT8qKMKpoKIFjmz8GbP8dKyAVzs7YlV6Py1F1/Tj5HPxp4eXTh5nyalvgKtIJItOYgl1G8NX2k5PsUEsmNfspaKVk6USly6SIe+jQAIgHcVd8Ilrit6io75REHViQUtdsSoaL0qvOVaD1PHop/AdyAl07BsjCFcRi0JlBl81KY+m2kTJKanZWTa9VqCX19CjSBtgnRyJa72PhzOvj73RQuxUOgykzE7P/w2xcZAWNEjx1Y8edmSUwj82Sla6BJw1ihlPNmJ8D+meVIs+cvuC9/D5GVjLLeLpUeUdooyidMVdvkf9nZo/qUVRABFA+cyk6Y2GoovdMxF8gR0vYl4gFAIZpZ94XbnM7Lgq2EfjZsMtHbaBhJ1Z0ySX1qTJPK3RMfEHYvKbL8V4lpPs/PCLStZ9TZihC9ea4lsxr/97HfqtfwdOUh4ZFWf0wPs6hn2z6n5YCjCFDQwPAwH12IU1TXofLMQEEjukpdurIiKxAYVa9k+t4PQQinBlIR2+w6EptMrQaYxTxtSiKNEbcY5Y0qMPJsnv3MUBySFLqacq45MR7Dy4aZh+4CcBVN/iFh2Y7J X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: cbc3f511-9828-48ef-699f-08dd5bccab33 X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8247.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2025 10:01:16.3262 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: U/lJLZ66E+CkX24lZE9EW4SxWo0yT81w/BAUNbSZC86cwkaSdotNW52GejDOCGWwpYMl+MlOe+cp8oODIFzS4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI0PR04MB10541 We can Run/Stall the DSP via audio block control bits found in audiomix. Implement this functionality using the reset controller and use assert for Stall and deassert for Run. Reviewed-by: Frank Li Signed-off-by: Daniel Baluta Reviewed-by: Peng Fan --- drivers/reset/reset-imx8mp-audiomix.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/reset/reset-imx8mp-audiomix.c b/drivers/reset/reset-imx8mp-audiomix.c index 04ad27aca806..6b357adfe646 100644 --- a/drivers/reset/reset-imx8mp-audiomix.c +++ b/drivers/reset/reset-imx8mp-audiomix.c @@ -17,6 +17,9 @@ #define IMX8MP_AUDIOMIX_EARC_RESET_MASK BIT(1) #define IMX8MP_AUDIOMIX_EARC_PHY_RESET_MASK BIT(2) +#define IMX8MP_AUDIOMIX_DSP_RUNSTALL_OFFSET 0x108 +#define IMX8MP_AUDIOMIX_DSP_RUNSTALL_MASK BIT(5) + struct imx8mp_reset_map { unsigned int offset; unsigned int mask; @@ -34,6 +37,11 @@ static const struct imx8mp_reset_map reset_map[] = { .mask = IMX8MP_AUDIOMIX_EARC_PHY_RESET_MASK, .active_low = true, }, + [IMX8MP_AUDIOMIX_DSP_RUNSTALL] = { + .offset = IMX8MP_AUDIOMIX_DSP_RUNSTALL_OFFSET, + .mask = IMX8MP_AUDIOMIX_DSP_RUNSTALL_MASK, + .active_low = false, + }, }; struct imx8mp_audiomix_reset { From patchwork Wed Mar 5 10:00:36 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Baluta X-Patchwork-Id: 14002267 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2040.outbound.protection.outlook.com [40.107.20.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E81F2207A03; Wed, 5 Mar 2025 10:01:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.20.40 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741168885; cv=fail; b=Vq8Gd6gNfFHAzt9dgWwIDe0i7QKM8ESUl7afJHRh+w1g+vpG9hg+glpbC4cCLTbtpdblij/A+0jFR1mdnf/9PTPxoVkVqWPRNq1nxOmTc1A9Q74RPolJwaHECq2a2b/4s0ouKE9SByLvpwXEasTY0twhHNSfjoZmDu6RJxDmhkA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741168885; c=relaxed/simple; bh=WcbGSF7kL35sAFpaN4tmka6+hfVyeUeUYh1LaGlM9fE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=dT4wWS1bBWqKge/cpAJLSktbpYjW7ISeFYdm1DvtnwJZHf8qPVS2uzTqIPWjWeja43xpOEylpK+NUigQsqSF3+R/4iIueuczCE4IDP2/8+AL5bX4wYBvlKbCsaLLNNceSQAu9+qljtKIftKFq17iGks1J3UUCsoiVFZ7lr0C3sY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=aSii665l; arc=fail smtp.client-ip=40.107.20.40 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="aSii665l" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=um4WdmpLMXf1HpmCrt+Bv/PmF4GVS0uq3MXGInlnvKD4PeHkF2aBZqanEjzTnDm7DlLRWjKzk2lAu/qmOlyR7OW/MWFwfjnrz37d5O+J2s7dBsIe9BpTpDaoQxQMQAJFWdEaritK8BpFyegLJY3OdalwaUhzzErldrHT/OxpCMeSHDRrfIrCrWEGtx6eybdqD20l8fr32XMErSwFenu4KUCKdMWHZY9JaQ9hDa71/gpb2JkkAdzhUmuSbVkvhA3E08VQcSug9kSYj1YvGyHH9oXgZXL3phH0/5paeFSmLca9T8S8Rd4Hfv1JD9KiVzmoZCe/6aawm1UkGkzB0g7iiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zi3Ta5oQXcePbjnJLMNF/ShJJD47jZo9ro9ibNheTqs=; b=LCfVtGbp2C5or0sTjY8A4ivB4sDLvsEZ8JR8y5I5vGxNGz5MOV7AzG7yeN5LNPD23Tbe1GxzTEn2xLGjPWO6fJYfYwxk3s+9l+TlIBbsQQ3N+lK7OB/iRzgj1D4gghjCBspCfqFMZW2rTw2ug4cAZlwKeL2g2xsCwMtrtN036aro5qTGvURva6Lay9A5iWZSOfY3OZqtgqTUqQ3GR7RmBvphxYvClcckFMx/Crbn8ZWMFuwctSsKV8RhEwz7LbH/TO7vWUlMLarQYcOIsgZCPcS0clGkCtcRH0/0d6UrjSX8WfRr6TFBGGChvFh4vrbbzVCwSjhnQOK1t+ugIkqI0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zi3Ta5oQXcePbjnJLMNF/ShJJD47jZo9ro9ibNheTqs=; b=aSii665l0Imvt21asQC/Hl2OD1S8q6U+z5ThufwHTr8BJoh8/FzSHOpDteCDVGsBggBaECX1cZ/++zUzVbD8GX0X73rpDcBSqeje+o2AXChGTl/j6VYhlk0Jy94/JlEFsGNo/9y+J5SxakCGLUswdVH8MpYzPmCq3iAU+NvOXzQR1AxBWiEl/BzBoh9pEqS0wtrZ+a4kJQzsivXv86qhrHiKis77kkQYvxlPLylRZ0vAonuPBoFFuHo4LdwAhsOmqDZUk3lU/nt9eh24aBytulrLIxkirJkgTryVOrmxN6xek5WDMOz1ssWe95zIlffvo+Y0AoiErmZ9vap+K22RWw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB8247.eurprd04.prod.outlook.com (2603:10a6:20b:3f2::13) by VI0PR04MB10541.eurprd04.prod.outlook.com (2603:10a6:800:26a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8489.27; Wed, 5 Mar 2025 10:01:19 +0000 Received: from AS8PR04MB8247.eurprd04.prod.outlook.com ([fe80::84f7:e2c3:ceed:c0a6]) by AS8PR04MB8247.eurprd04.prod.outlook.com ([fe80::84f7:e2c3:ceed:c0a6%5]) with mapi id 15.20.8511.015; Wed, 5 Mar 2025 10:01:19 +0000 From: Daniel Baluta To: p.zabel@pengutronix.de, robh@kernel.org, krzk+dt@kernel.org, shawnguo@kernel.org, mathieu.poirier@linaro.org, devicetree@vger.kernel.org, linux-remoteproc@vger.kernel.org Cc: conor+dt@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, andersson@kernel.org, Frank.Li@nxp.com, peng.fan@nxp.com, laurentiu.mihalcea@nxp.com, iuliana.prodan@nxp.com, shengjiu.wang@nxp.com, Daniel Baluta Subject: [PATCH v4 8/8] imx_dsp_rproc: Use reset controller API to control the DSP Date: Wed, 5 Mar 2025 12:00:36 +0200 Message-ID: <20250305100037.373782-9-daniel.baluta@nxp.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250305100037.373782-1-daniel.baluta@nxp.com> References: <20250305100037.373782-1-daniel.baluta@nxp.com> X-ClientProxiedBy: WA2P291CA0031.POLP291.PROD.OUTLOOK.COM (2603:10a6:1d0:1f::12) To AS8PR04MB8247.eurprd04.prod.outlook.com (2603:10a6:20b:3f2::13) Precedence: bulk X-Mailing-List: linux-remoteproc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8247:EE_|VI0PR04MB10541:EE_ X-MS-Office365-Filtering-Correlation-Id: 234ce139-b55e-4b63-4685-08dd5bccacca X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|52116014|7416014|376014|38350700014; X-Microsoft-Antispam-Message-Info: IjQQ/p1HX1jFVwGB5grt+8YtvcDuVBfbrktqqq3wu//3sdnPKlVXJsMRJsdIrzLLofyMLbHJKgbU9hx6Oyg2tDHVYxwRlm5rqWjeRAbMgaKaq0pREQ6UR7b1dxhUQoh3KuM8fIyCyGC04u1TEpZ5Z54jDtfyIuVbUopKurtYVc86y11R4vSHYmlrQqECGIF8/zk5slGGuru29cryjo7xgsWL44vFiGy5CBVFK4ZQNR8dnTBK4U8aO86xNK3jgnVU7xuoy4IiohWtVw9Bw78WANN9+ntYAX8TytqV+j23GRlL44qBkBPQ/0Dg+fAVPzVk8k5IN3Ng7u+VI2ffnbLovhb0YRtmb98g3ZuEiqekNc1isxBRRCf6ptLU+XuFpZUeMgTdsHJxZvaYeIpfwdycIDchSwTqTah3KD12YZpr4tKEDLC3JbQHj6EqCPvgrzbLsVwlKgy04Sbps57nrIZ0+s94nlhsD8TDpNslDW0HqECkz5AUE4tZIL88j9efz9752qIninAxw/NZfAcPWYBRQx4S2+/vu3IQWBZqfZJqobpOL5f9lA5I6sfqXC3dRRMnzdrlzvE/w7SGofo3GHDbu5U1ML/YnaspOqHBbpThE1eaXHSVRT9InjoyX0ZYOi7F6LeFAWrV31ENX2pDboKjH5fV2m1NLxiQJyalvuYWwG4QLB3HA3vQhuExPhypnQMqac6ArtLaSkM2NFKcfNNooz0kQnc8Fbpc1mAoLGSpxgr8dFTtYtOhuUHonwIY7ZGTM4+azQrAGdGY8spSYN4BUplHEvhM1yGll4AMTrSklCabBPu/CyOZ0eArtJJOxHRktlrtGBLEuq9WCv6mKrn+vOXkxeVmZfLXmSXYIRwY6m5P5MyupUfMuhsQkRoce3HXTjqroIqpt/VyWY9dsaab8FCSuhHaRwk7QJvry6+N/8q9nXsMsADR8QG5htpPlclZd4T7Blmf9ElJUvXml1CE8AcBT5O9wbhLevrnadIERda8/60HD80T+qI0mXiF999u8cfq7sDMJKbz5pSO4HkAU42+l5Nka+nhJMvjgz3WC9T51NacIGBh1SUxQWA/xkmaRFcebRUW2Vp1G2tAedghliNELoxRincDmGJibOE2aPLpUXUrjU6Pjyqw0XXhM4zS3tNBiuDRdA3GazRpefjo2iDpjrSenTAsLKpbYuuPuEiiaj5UlVXVsvi9GOkWTs0BZLgdSd8Md0tCEGoITgG1DaenuYqDi9nSTYwst5eiLcvJ29Il/M8i7DHlR4nNkXDll+rMtWj7W1P6qkKDz3j2V7KFICaROVMalrivJc9hNikNC5THs2hqFWTTZx1R/5+O/esXwjz7ewai8nbo1PGl3loBK9jGDAyFxo2WtlGID9NAn4/hYOqv3EdGRg08gzjUNBxsUKOGhtvG02KvFdv8FtDuRwYNrUvIhHpDGS3dgb+vSh+guEKDvtaik5lEoifE X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8247.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(52116014)(7416014)(376014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: sDhR+A/S72IlOK95ApddkEunwir1PTM7nAYbWpn5o3QyCPkgc5oDk9VfHhmw7Hw4HYmorMNz2kxNYew+z9xlwwDR752MgMSMDQD3vemDJnX5IVCjD5ohtPWwXVCoc3OsMBXHHeOrxwHbcJqdQVli3VEWgAn7PhgI21sNotXjCpwq+/surzAjjXwM5I6wVLpCAAk1A16etw3Soy9mcVzl1lro61zKyDHUo89xqlreVf+65TasKqdYJyrVANCDf01FpNEFmeC1jCcXLhl2TZv9HTbBmRaRf5s3Jo90eIrduA79cmayLGAz0UNlL4yBHhelTJuu8iKLnFLhApMGFklZUL2rXgao56+q7ys8ZIEpxW5kWL4nQEr9Eexd0J2T1aZT1EikRWkKhYlmoLtxVgKZhemcr6mKnWoqjmbB8Ercl4TeYvwcxd2PMQtuk6EQr7g7A7057uUzN+mF9qi88EGA5wH7GVKyAmLdiAe2Od38egN2OQM0tfQoffaJHt/4Sa0dgZ88P4JgnHmXm0iayX5RzncVkpkRc0TOlH9X8EFG/wWgI32GTDauqpaMnoeZ7i0tIdlWBLpZ06xZSPOdtfcNwNu0dl89FB/5BhFcZsPfmfmzgwqb6tXrtNBBrbE0op+xtw8utyNbTSllyuxmbsEYx2WQmwUyZk1QKmOqrrWoz7K9C+olPe0cvpEXfdMIsoPXThwCj+VWxEjU0RSRH8UQivtu6QMvTmEQuSBJ6LmXagfsBulamI2R4Gw5uiP5lNL/vIQ3/GqV+TPVJAp+j8qSmKF4BvBxSq/E0dXegYz/nj8fZByMG9Ts5YhbT8mvsVB5E52P3g+lGS69ULf7iAdleCc6bxRe0gG/14g2sIdZtmmScY91EdmgpYV6bdGnVfVKY7sxL4WOuM7EV0kOm+jGfdtWzDEPSxtHFCSrvbE4ahHEfmaPUK/0c48bQACAWM9fD2pK7m5LAQbYtFMAHXbgaBmTo7YwR5Wo2lYmQnSVQcyIUVo1jjPBrCQI5GOUAKrTFpUJLmsELP4wZDXYnZD6o0pYd/qXvtBx8p6KTg3IFpUAvwlD35C8580KdeWhm6zp+uMCB4bRjCsN5TH0mzHcTN9EcrwGBbosrImcViGPsKsMjGNqT9p52Xtvml3ekLoKBauDYhcauh01Dgt6Szgxs/b66PwGLHrHcT78HkjS1IQtm5CW0RA9Oi4LO7AfoiE49rpy3WK57m4zOV6da+NKnsM0Gw/FS++Iq/vT0n0/O6U0gRskiZ+1X5AqFWozog8ZHtFDq28sBYGoHGZi2sNcD/72SR3VZYLcNvL0ewlHKLtOKVud3QShcZEdcm27JvIr5JX/1Of4IYL/vumPML0TDpDDV12ESu8VH+AlOo9AAnMnV2gX/0UTfN0+8OH8pDkxmyvwPNCiXcdDjVefSSxjYG7bLCBBOWRk4ath4kMfPK+l9LfhHNk9lqAi3i/hHQT6hjUSDDSVnhHP99Zluf33teNdYn6uAM7QsBP2Q86MQqNHBar0Kg12fxWR2IBrc8wVaKARwIdxnBmLcjot7EW8zUt70adUG3P/c8KMjxrjK6jH06wfhG6u25pi1ngGu9RL X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 234ce139-b55e-4b63-4685-08dd5bccacca X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8247.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2025 10:01:18.9501 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5HlO+7s5tdr4aUZkKZibTM5jWlOIEgaCpbDnV7FPv4VWmuvd+JYhuGSJHnuFqJS+uTv9LpzNlXGSUYFlqBkZbw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI0PR04MB10541 DSP on i.MX8MP doesn't have a direct reset line so according to hardware design team in order to handle assert/deassert/reset functionality we need to use a combination of control bits from two modules. Audio block control module for Run/Stall control of the DSP and DAP module in order to do software reset. Initial design accessed RunStall bits from audio block control using the syscon interface but this got NACKed by community because of abusing the syscon interface [1]. So instead we use the reset controller API. [1] https://patchwork.kernel.org/project/imx/patch/20250212085222.107102-6-daniel.baluta@nxp.com/ Reviewed-by: Peng Fan Reviewed-by: Frank Li Signed-off-by: Daniel Baluta --- drivers/remoteproc/imx_dsp_rproc.c | 25 +++++++++++++++++-------- drivers/remoteproc/imx_rproc.h | 2 ++ 2 files changed, 19 insertions(+), 8 deletions(-) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_dsp_rproc.c index ea5024919c2f..bc60edcdd661 100644 --- a/drivers/remoteproc/imx_dsp_rproc.c +++ b/drivers/remoteproc/imx_dsp_rproc.c @@ -19,6 +19,7 @@ #include #include #include +#include #include #include "imx_rproc.h" @@ -111,6 +112,7 @@ enum imx_dsp_rp_mbox_messages { */ struct imx_dsp_rproc { struct regmap *regmap; + struct reset_control *run_stall; struct rproc *rproc; const struct imx_dsp_rproc_dcfg *dsp_dcfg; struct clk_bulk_data clks[DSP_RPROC_CLK_MAX]; @@ -192,9 +194,7 @@ static int imx8mp_dsp_reset(struct imx_dsp_rproc *priv) /* Keep reset asserted for 10 cycles */ usleep_range(1, 2); - regmap_update_bits(priv->regmap, IMX8M_AudioDSP_REG2, - IMX8M_AudioDSP_REG2_RUNSTALL, - IMX8M_AudioDSP_REG2_RUNSTALL); + reset_control_assert(priv->run_stall); /* Take the DSP out of reset and keep stalled for FW loading */ pwrctl = readl(dap + IMX8M_DAP_PWRCTL); @@ -231,13 +231,9 @@ static int imx8ulp_dsp_reset(struct imx_dsp_rproc *priv) /* Specific configuration for i.MX8MP */ static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8mp = { - .src_reg = IMX8M_AudioDSP_REG2, - .src_mask = IMX8M_AudioDSP_REG2_RUNSTALL, - .src_start = 0, - .src_stop = IMX8M_AudioDSP_REG2_RUNSTALL, .att = imx_dsp_rproc_att_imx8mp, .att_size = ARRAY_SIZE(imx_dsp_rproc_att_imx8mp), - .method = IMX_RPROC_MMIO, + .method = IMX_RPROC_RESET_CONTROLLER, }; static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_cfg_imx8mp = { @@ -329,6 +325,9 @@ static int imx_dsp_rproc_start(struct rproc *rproc) true, rproc->bootaddr); break; + case IMX_RPROC_RESET_CONTROLLER: + ret = reset_control_deassert(priv->run_stall); + break; default: return -EOPNOTSUPP; } @@ -369,6 +368,9 @@ static int imx_dsp_rproc_stop(struct rproc *rproc) false, rproc->bootaddr); break; + case IMX_RPROC_RESET_CONTROLLER: + ret = reset_control_assert(priv->run_stall); + break; default: return -EOPNOTSUPP; } @@ -995,6 +997,13 @@ static int imx_dsp_rproc_detect_mode(struct imx_dsp_rproc *priv) priv->regmap = regmap; break; + case IMX_RPROC_RESET_CONTROLLER: + priv->run_stall = devm_reset_control_get_exclusive(dev, "runstall"); + if (IS_ERR(priv->run_stall)) { + dev_err(dev, "Failed to get DSP runstall reset control\n"); + return PTR_ERR(priv->run_stall); + } + break; default: ret = -EOPNOTSUPP; break; diff --git a/drivers/remoteproc/imx_rproc.h b/drivers/remoteproc/imx_rproc.h index 17a7d051c531..cfd38d37e146 100644 --- a/drivers/remoteproc/imx_rproc.h +++ b/drivers/remoteproc/imx_rproc.h @@ -24,6 +24,8 @@ enum imx_rproc_method { IMX_RPROC_SMC, /* Through System Control Unit API */ IMX_RPROC_SCU_API, + /* Through Reset Controller API */ + IMX_RPROC_RESET_CONTROLLER, }; /* dcfg flags */