From patchwork Wed Mar 5 10:27:46 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Ritesh Harjani (IBM)" X-Patchwork-Id: 14002332 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 365292063FB; Wed, 5 Mar 2025 10:27:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741170480; cv=none; b=GV/tAMMofx4qNYkArZZWd9rm8RzsqFZds5K0StTNMuOKoiFuUqg4j8P4PrcZbPp3MkzGGM0/kINY6SO+UZDj2nk5ta1CgNbICtdKa5VU7kLXXYcc+pmH9cOWc+Yy6nrTaBhIFOUv7+Eu6pKua9MW0V92ud/fjE0vzwACUOPL/Ac= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741170480; c=relaxed/simple; bh=ISAvPA9mGuMe3kEiIGiHmnkLLBT133ajEwpJ3/bg+7Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GmsMGlqaR/oPKesSOTQHjMUokFBKaB8BmcBylA4FaKEKnPssl3M0pXYXEQOV4aUXVo/oQxSa0jU67GIJ2k3Y6n/bNVoySHLareWuhT4Tyr0eTecKMi442JYmsqjGYrDZnP2an/7LHGLp2bJk6DDafSXtqv/kwlCSlhbtbxBev0s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SKvTPS2K; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SKvTPS2K" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-22185cddbffso10573465ad.1; Wed, 05 Mar 2025 02:27:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741170477; x=1741775277; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=k67TXimsNyCJpPgpLzBGFfJN65RsX6oOCekGytWHejQ=; b=SKvTPS2K8WUteeYDmZEW8zi+iyOemPtGLIBtmGGKoeUildRpekS+/1XJ5sitKiAnHR eYFpS9CW1a4Cm69fyTW/rjXxNTyVuGPiU2PLW2yzSvMimk2OTsNRdlDOTQUaSLo3jOES MRagzfDhK8fQEtwGJCl1PY5oU0nCiJmyFBkEt9115OJZhlbdMjglYX/mu5sD0Zku1yQZ EpL9HlIYtp4GbE7SWN6tmcIcq3tMhl0fyxSblfLHLQ5Q9oqzi7XNnGbMfWbWocHlG8nF SQDoQi1arLM975E6JeoUqJ2qVpW8y5pG6xQ3hgWtmTR4UzqwvtNqgpKjWkLCoEBZJvvZ +Z0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741170477; x=1741775277; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k67TXimsNyCJpPgpLzBGFfJN65RsX6oOCekGytWHejQ=; b=Etm/WbjelsfJWwVY+a3jCLbl177RiYslFJTkpwYbNPAEiM5NxkEVfi8mxy0UC09DMK 1Rb7pdlV1kstEolqRsOPRSovLX81qnzNE1GIV4E7V4zVwy4PtIzyXUzEcAQvhDNcIKHX rT3A56xYkqJ6LqIaYDYo2OXl/iEZ9yGxA7X0efNAZN2iuRE27GRXaVAxUCVTa/tc2DQv A5SCEWQ75WQWMQST+y5+GP+D0iBaV93222stE5cl0lEigxCym/gayOR83YAYBmwlsJ+v aKZk8S3t+TGoPP67DGyOakxLkvUtQjaPMZ7iqT8HphEA9ruLP71t2V8XMkZ2OZBF7itJ D5AQ== X-Gm-Message-State: AOJu0YwybQ9wSHdYbV6sPJgED1KR2xQQoKCAt5BqGUG7cELCHWfb1b0y h1FmvtcN2xQI9PR0cL83Ag+9zxxSFD5lAHUhFs2eKKIA1TH6nnu7zJhzZQ== X-Gm-Gg: ASbGncv2gTuuS6+r5lSxnZLTmc/mtwiVG9OHP4OIM6RuxDDh5maEC2OXmgbUIX4jMpw i1mRfUJCfvs/kiarBpvn/S1T780yGX4ByTfqwUJX9ziPcgeWBtMScSc2jiFij/ht0vCdkd32fea fbAymlS9yw9qBv5vMeaUPr6ysOO4mNnkaTPi1nhZR3LSl2pwGkrJltDoHJyeaKxdcTPijh3PZux ZLm7gvB24yps3mzS9kQfimO3Jb9NzzdpS8a0DfuSm6mv3GeQlbl347E+tQxz2D3N8Vm15Nh245e JHRWQpKyfu7qoSwY2fbzRCi3rIcNHpL3G8G0p8L0GFG86cYPDBI= X-Google-Smtp-Source: AGHT+IEYOuHf87Ml8QQMzEe7kVZPlPPQ3+aUa8b6UVnQ5ylVHFiIqe7dVTV8vNJ+dTrc7G+n+cHSig== X-Received: by 2002:a05:6a00:8c2:b0:736:491b:5370 with SMTP id d2e1a72fcca58-73681ebc96emr4594224b3a.10.1741170477317; Wed, 05 Mar 2025 02:27:57 -0800 (PST) Received: from dw-tp.ibmuc.com ([171.76.80.250]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7364ef011c1sm6252768b3a.111.2025.03.05.02.27.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Mar 2025 02:27:56 -0800 (PST) From: "Ritesh Harjani (IBM)" To: linux-xfs@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org, Jens Axboe , "Darrick J . Wong" , "Ritesh Harjani (IBM)" Subject: [PATCH v2 1/3] xfs_io: Add support for preadv2 Date: Wed, 5 Mar 2025 15:57:46 +0530 Message-ID: <68b83527415c7c2a74270193f5ffd14363e5de88.1741170031.git.ritesh.list@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch adds support for preadv2() to xfs_io. Signed-off-by: Ritesh Harjani (IBM) Reviewed-by: "Darrick J. Wong" --- io/Makefile | 2 +- io/pread.c | 45 ++++++++++++++++++++++++++++++--------------- 2 files changed, 31 insertions(+), 16 deletions(-) diff --git a/io/Makefile b/io/Makefile index 8f835ec7..14a3fe20 100644 --- a/io/Makefile +++ b/io/Makefile @@ -66,7 +66,7 @@ LLDLIBS += $(LIBEDITLINE) $(LIBTERMCAP) endif ifeq ($(HAVE_PWRITEV2),yes) -LCFLAGS += -DHAVE_PWRITEV2 +LCFLAGS += -DHAVE_PWRITEV2 -DHAVE_PREADV2 endif ifeq ($(HAVE_MAP_SYNC),yes) diff --git a/io/pread.c b/io/pread.c index 62c771fb..b314fbc7 100644 --- a/io/pread.c +++ b/io/pread.c @@ -162,7 +162,8 @@ static ssize_t do_preadv( int fd, off_t offset, - long long count) + long long count, + int preadv2_flags) { int vecs = 0; ssize_t oldlen = 0; @@ -181,8 +182,14 @@ do_preadv( } else { vecs = vectors; } +#ifdef HAVE_PREADV2 + if (preadv2_flags) + bytes = preadv2(fd, iov, vectors, offset, preadv2_flags); + else + bytes = preadv(fd, iov, vectors, offset); +#else bytes = preadv(fd, iov, vectors, offset); - +#endif /* restore trimmed iov */ if (oldlen) iov[vecs - 1].iov_len = oldlen; @@ -195,12 +202,13 @@ do_pread( int fd, off_t offset, long long count, - size_t buffer_size) + size_t buffer_size, + int preadv2_flags) { if (!vectors) return pread(fd, io_buffer, min(count, buffer_size), offset); - return do_preadv(fd, offset, count); + return do_preadv(fd, offset, count, preadv2_flags); } static int @@ -210,7 +218,8 @@ read_random( long long count, long long *total, unsigned int seed, - int eof) + int eof, + int preadv2_flags) { off_t end, off, range; ssize_t bytes; @@ -234,7 +243,7 @@ read_random( io_buffersize; else off = offset; - bytes = do_pread(fd, off, io_buffersize, io_buffersize); + bytes = do_pread(fd, off, io_buffersize, io_buffersize, preadv2_flags); if (bytes == 0) break; if (bytes < 0) { @@ -256,7 +265,8 @@ read_backward( off_t *offset, long long *count, long long *total, - int eof) + int eof, + int preadv2_flags) { off_t end, off = *offset; ssize_t bytes = 0, bytes_requested; @@ -276,7 +286,7 @@ read_backward( /* Do initial unaligned read if needed */ if ((bytes_requested = (off % io_buffersize))) { off -= bytes_requested; - bytes = do_pread(fd, off, bytes_requested, io_buffersize); + bytes = do_pread(fd, off, bytes_requested, io_buffersize, preadv2_flags); if (bytes == 0) return ops; if (bytes < 0) { @@ -294,7 +304,7 @@ read_backward( while (cnt > end) { bytes_requested = min(cnt, io_buffersize); off -= bytes_requested; - bytes = do_pread(fd, off, cnt, io_buffersize); + bytes = do_pread(fd, off, cnt, io_buffersize, preadv2_flags); if (bytes == 0) break; if (bytes < 0) { @@ -318,14 +328,15 @@ read_forward( long long *total, int verbose, int onlyone, - int eof) + int eof, + int preadv2_flags) { ssize_t bytes; int ops = 0; *total = 0; while (count > 0 || eof) { - bytes = do_pread(fd, offset, count, io_buffersize); + bytes = do_pread(fd, offset, count, io_buffersize, preadv2_flags); if (bytes == 0) break; if (bytes < 0) { @@ -353,7 +364,7 @@ read_buffer( int verbose, int onlyone) { - return read_forward(fd, offset, count, total, verbose, onlyone, 0); + return read_forward(fd, offset, count, total, verbose, onlyone, 0, 0); } static int @@ -371,6 +382,7 @@ pread_f( int Cflag, qflag, uflag, vflag; int eof = 0, direction = IO_FORWARD; int c; + int preadv2_flags = 0; Cflag = qflag = uflag = vflag = 0; init_cvtnum(&fsblocksize, &fssectsize); @@ -463,15 +475,18 @@ pread_f( case IO_RANDOM: if (!zeed) /* srandom seed */ zeed = time(NULL); - c = read_random(file->fd, offset, count, &total, zeed, eof); + c = read_random(file->fd, offset, count, &total, zeed, eof, + preadv2_flags); break; case IO_FORWARD: - c = read_forward(file->fd, offset, count, &total, vflag, 0, eof); + c = read_forward(file->fd, offset, count, &total, vflag, 0, eof, + preadv2_flags); if (eof) count = total; break; case IO_BACKWARD: - c = read_backward(file->fd, &offset, &count, &total, eof); + c = read_backward(file->fd, &offset, &count, &total, eof, + preadv2_flags); break; default: ASSERT(0); From patchwork Wed Mar 5 10:27:47 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Ritesh Harjani (IBM)" X-Patchwork-Id: 14002333 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 922B62066FD; Wed, 5 Mar 2025 10:28:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741170483; cv=none; b=t043Aeay50qvmt7esc99oaIg+i41kIkQ623zKm9NRTg96vGXv3GdhIEhUawaFbLnwsCNrGx12jIorgui3q1Ub1XrzhqFoIv5coDYxcPJJjyT3iNPD7G/nbvAKsyQL/xLrwLNk4ypeVEDkjf7L1YRxgednNdrZ0OLrAuegNDkgkw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741170483; c=relaxed/simple; bh=GBLlYgnkfy70m5cmJyaCbQCSXS94MLI9+56JOSnSQdM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CNfNBhhmzsp7G640CjAJmjDUUuLSdaxIl3NkS15mvhn2yQbA9ZDwihY9CnC92lfVs+7uS5bZ1ag3j/zn+UYyPsPh5RaU1Nqux8DXwreJ2mNXtlbHi8nteUK0uxOordJQTQsJ2k1uqUpCm+r5RV+fqGdKfWooz47V89N4lWHf9oA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=d5G/HjCw; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="d5G/HjCw" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-22374f56453so124605215ad.0; Wed, 05 Mar 2025 02:28:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741170480; x=1741775280; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=m5MQYHxeHAfGZF8CSah4zpdhnfKZ8814DwTVzOpxx/E=; b=d5G/HjCweA6KYuarg0HchYkOm8ET7355eycJvXtaiVd2uup3b3Cv6WoxmQTfqCtY90 ScLCBU6Fs+OIO89WvR8c5uZkVJVB4/ptPK/kn3cx3YjsZzbcT+7RIGHiFVNWoCHVqs0C YKGyaPfJq8aTGFOqZBzi+eaF6/pJTV22I+90+7DdFfWavGlh5k7YWE/L3dVo+gk4VYEc a9yuZBUvbmUb39wSWaNrRK267bSSBwJbc4Acili7dNWjCvnBJagVTXhxTp8iK+lgMFOE iI0VUOprOW4kbW79cJsCEidbN7X6+y+bviQXSz1b1u6VlfFh0kxEVTdwxJ0ksLFOWGCU tZLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741170480; x=1741775280; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=m5MQYHxeHAfGZF8CSah4zpdhnfKZ8814DwTVzOpxx/E=; b=w3a4KtM3EZRnZUp/YqQfS2Q3CeQofXDEGMmc1FMCdMYawRId0teXK7CcVXFvcEz7Se rrBG8LHqAv4GfKMH1zztJIi3mPpDwJYV4qJUXL/V23NwFPp0sGYTQsLfYPk1k09d8qJq 2XjsI8+dUslieUlibaELvTJvuRC8nrhYy8asQs5Gk7tKjOU0BprEjVHGqkoJqZGf1cx0 e94s2TsfYCM4AwEMoZy6H4KNa4O2hA0EklP7HymAS7TCuvIYZS7VnUzr8Z1WmUIisGnS st99M65p+ahHz4lqRA3HekDaXOObrSupvutp9fpA3W0zcQf2eo3YQVc4XB0f3GNWUB5p 2k8Q== X-Gm-Message-State: AOJu0YwYxjXeXf3tmmUS5gIJI/iZT1qTYj8SLz2Yf2eMlVUrdUyEmaEI i3+KDov9ZIwTeD6hO2xC88L8bsyLxwHXaKWIzN5xLzevc9glK5JQ8Jd1vA== X-Gm-Gg: ASbGncvCLqRWZtVk1q40IzO89PxOm9Z0fwwe44pEEIVJdE7wbOZeVandCyn0D06e96i LsKQF8sWOxTzqdaN+yQrY57zgOkabqBhkr5gVXk2b5m+NBq9VVSAUrFlhEwyHrOw1rDBBRcI2mF /Xb87UdYuZEyHaeNWwxssbmUgd1t+pT4NPOXemsWIHG0A5ST/925WfYq95tqRJB2beHj87kX9TE vUhJmi9B4/lqLzs4ml+ji/ML/XCIRFCyjzFHof2C6hY/njEDkgMufJV0mCTtjClAuywyveZlRiv kLt340Xyi6eT2Mdk5IkTRd8TxKJuIUazl6RoBSg2wiKsoZ4NCHE= X-Google-Smtp-Source: AGHT+IHT+xqBJu5vLs92hTvbcIE+VzY9IktlnRB/C0o/Y4AfDbiNKlewSHOwlLoR1q03ycaR+bB0Yg== X-Received: by 2002:a05:6a00:b81:b0:730:8a5b:6e61 with SMTP id d2e1a72fcca58-73682b4b1dbmr4052289b3a.2.1741170480328; Wed, 05 Mar 2025 02:28:00 -0800 (PST) Received: from dw-tp.ibmuc.com ([171.76.80.250]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7364ef011c1sm6252768b3a.111.2025.03.05.02.27.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Mar 2025 02:27:59 -0800 (PST) From: "Ritesh Harjani (IBM)" To: linux-xfs@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org, Jens Axboe , "Darrick J . Wong" , "Ritesh Harjani (IBM)" Subject: [PATCH v2 2/3] xfs_io: Add RWF_DONTCACHE support to pwritev2 Date: Wed, 5 Mar 2025 15:57:47 +0530 Message-ID: <57bd6d327ac8ed2f8e9859f1e42775622a8b9d09.1741170031.git.ritesh.list@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Add per-io RWF_DONTCACHE support flag to pwritev2(). This enables xfs_io to perform uncached buffered-io writes. e.g. xfs_io -fc "pwrite -U -V 1 0 16K" /mnt/f1 Signed-off-by: Ritesh Harjani (IBM) Reviewed-by: "Darrick J. Wong" --- include/linux.h | 5 +++++ io/pwrite.c | 14 ++++++++++++-- man/man8/xfs_io.8 | 8 +++++++- 3 files changed, 24 insertions(+), 3 deletions(-) diff --git a/include/linux.h b/include/linux.h index b3516d54..6e83e073 100644 --- a/include/linux.h +++ b/include/linux.h @@ -237,6 +237,11 @@ struct fsxattr { #define RWF_ATOMIC ((__kernel_rwf_t)0x00000040) #endif +/* buffered IO that drops the cache after reading or writing data */ +#ifndef RWF_DONTCACHE +#define RWF_DONTCACHE ((__kernel_rwf_t)0x00000080) +#endif + /* * Reminder: anything added to this file will be compiled into downstream * userspace projects! diff --git a/io/pwrite.c b/io/pwrite.c index fab59be4..5fb0253f 100644 --- a/io/pwrite.c +++ b/io/pwrite.c @@ -45,6 +45,7 @@ pwrite_help(void) " -N -- Perform the pwritev2() with RWF_NOWAIT\n" " -D -- Perform the pwritev2() with RWF_DSYNC\n" " -A -- Perform the pwritev2() with RWF_ATOMIC\n" +" -U -- Perform the pwritev2() with Uncached/RWF_DONTCACHE\n" #endif "\n")); } @@ -285,7 +286,7 @@ pwrite_f( init_cvtnum(&fsblocksize, &fssectsize); bsize = fsblocksize; - while ((c = getopt(argc, argv, "Ab:BCdDf:Fi:NqRs:OS:uV:wWZ:")) != EOF) { + while ((c = getopt(argc, argv, "Ab:BCdDf:Fi:NqRs:OS:uUV:wWZ:")) != EOF) { switch (c) { case 'b': tmp = cvtnum(fsblocksize, fssectsize, optarg); @@ -328,6 +329,9 @@ pwrite_f( case 'A': pwritev2_flags |= RWF_ATOMIC; break; + case 'U': + pwritev2_flags |= RWF_DONTCACHE; + break; #endif case 's': skip = cvtnum(fsblocksize, fssectsize, optarg); @@ -392,6 +396,12 @@ pwrite_f( exitcode = 1; return command_usage(&pwrite_cmd); } + if (pwritev2_flags != 0 && vectors == 0) { + printf(_("pwritev2 flags require vectored I/O (-V)\n")); + exitcode = 1; + return command_usage(&pwrite_cmd); + } + offset = cvtnum(fsblocksize, fssectsize, argv[optind]); if (offset < 0) { printf(_("non-numeric offset argument -- %s\n"), argv[optind]); @@ -480,7 +490,7 @@ pwrite_init(void) pwrite_cmd.argmax = -1; pwrite_cmd.flags = CMD_NOMAP_OK | CMD_FOREIGN_OK; pwrite_cmd.args = -_("[-i infile [-qAdDwNOW] [-s skip]] [-b bs] [-S seed] [-FBR [-Z N]] [-V N] off len"); +_("[-i infile [-qAdDwNOUW] [-s skip]] [-b bs] [-S seed] [-FBR [-Z N]] [-V N] off len"); pwrite_cmd.oneline = _("writes a number of bytes at a specified offset"); pwrite_cmd.help = pwrite_help; diff --git a/man/man8/xfs_io.8 b/man/man8/xfs_io.8 index 59d5ddc5..47af5232 100644 --- a/man/man8/xfs_io.8 +++ b/man/man8/xfs_io.8 @@ -244,7 +244,7 @@ See the .B pread command. .TP -.BI "pwrite [ \-i " file " ] [ \-qAdDwNOW ] [ \-s " skip " ] [ \-b " size " ] [ \-S " seed " ] [ \-FBR [ \-Z " zeed " ] ] [ \-V " vectors " ] " "offset length" +.BI "pwrite [ \-i " file " ] [ \-qAdDwNOUW ] [ \-s " skip " ] [ \-b " size " ] [ \-S " seed " ] [ \-FBR [ \-Z " zeed " ] ] [ \-V " vectors " ] " "offset length" Writes a range of bytes in a specified blocksize from the given .IR offset . The bytes written can be either a set pattern or read in from another @@ -287,6 +287,12 @@ Perform the call with .IR RWF_ATOMIC . .TP +.B \-U +Perform the +.BR pwritev2 (2) +call with +.IR RWF_DONTCACHE . +.TP .B \-O perform pwrite once and return the (maybe partial) bytes written. .TP From patchwork Wed Mar 5 10:27:48 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Ritesh Harjani (IBM)" X-Patchwork-Id: 14002334 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 345ED205E2B; Wed, 5 Mar 2025 10:28:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741170486; cv=none; b=LHcljWBJ8PMys/ZHcyWmGeCHaPnXXHQUFdIX+mGaqvAPPjRD5xMVMSA/H6ZgZMs6eLohfeoG+AjbW4Ruu+fa5wYptTkYFqmI541rnuP15LI4nusMDXKx1d8IwTDJgZDyr+PGbZTvKSc3yIvHS97N+BxF/Jd6agCWXFMyinktjYw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741170486; c=relaxed/simple; bh=Bg4Jpln66Q+PEDFcHmFhYqF0UtivWNAgp2+vnoajqCo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ikzGpiGaabWpwVtc8GGqyh4IcwXIa+LCZy0JRGIbooFigsDym+skLLe6A8vpeZoJRVWJMUOZFAEKnzdPOZqg6UFJ55L4NUZ29D9mPLAL5q3nx4/ztxxa6S27J3rWmCzZ9svQEpTSpH96cb6TkbCNx2z4RzVenXfzlzrlIWMobPU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hkiHYP+N; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hkiHYP+N" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-22359001f1aso149538155ad.3; Wed, 05 Mar 2025 02:28:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741170483; x=1741775283; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=trVCMKE7HG2WIAeh6lPmuLGb/xVwY5hELogdeFe7gl4=; b=hkiHYP+NhEX0CKnJF+1Ff17NUGhYYpLkEXkDG1ULovtvMw2nTCwmEtpMakorc4RCsH 7VVCsYagqnyQirK1Ps/4t8LsMR2B2mihKoyUMGh5eElXo8TH+MSEFVg2YH94h/T1+GU2 EYGWabhxu6vNZfWiqwVp6GUU5HlgS89F7NxRi6mqmp2epN84LqbHDQo1id6Vf1vaI1HU OBah6AkM/lg9IYqVFGLz05R5O6L301W1SmMcH4AftvkCFW/Wy8Kf93rWSrb/mh5lsjVG iM8OHkC6xbt1dPExwGlbIqEW4g7xzgWiXJL2IL5lrsn2JPrUFAB6r4Mr9asznuj9zYIj V8Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741170483; x=1741775283; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=trVCMKE7HG2WIAeh6lPmuLGb/xVwY5hELogdeFe7gl4=; b=pd/Ro8kMESCaIKpip7SHZbQ9WUSzSc92X28M4lSORrm6V0AYbA0fxR/bnWTtmKyQGq Bq4P0zkEdJqWIacSZBnNsATrWyuJI6iXS5PyCyKhqlWRPHurmlMb5jYZs04GqAqgDHat 7TxQwawhfbxFas/+yVe6URfU2C3UhcGSEoQSL/wdSBrPt41ljI+IrdykeS+wCZdrSaJi uDfjryclGpuP69isUK07ukMvFQO0kLarMbAfgolF5UXAfYIQYydw5bgrug7QA/mAlYCL lEflltbtQgTToD9KFt95FGt7QwSu2l2wSoNzbIgrezeXNcbuaZQb/1QV22k+2BdUCXBx FY7A== X-Gm-Message-State: AOJu0YzLpAtzg0o3V6JiMeZQAz4CCP7oRmisRuXlaDUH5vGTMnZml38f WMGs5af43gi8CODWUlViaCnhgnV4K8IcEvM74Iosd9MJrNJnVXvpdkISxw== X-Gm-Gg: ASbGnctY+ADTdftgLrmkq1VNvRvWnJUMjUNDlEdYdf+3GaMsgyo9eNfQ0lpSg6iCEiX iXBLId0UQ91XjXNFRfYUF7OH7X7dGxnrmaQaocPfj3le3+5JCOwpIDEfPXnKBrl9adQFl8U0QZX tbit+3xTiO5GVmjzOYPCvkLHaOHiK3Q3mNbgEPRBfuw65kpcVs2QeegWzf+d2mc7kqL+oHYsE+N Q/zv9MhlsLiNIvsksfGfk86bLqiKRd9gP5WVE1GokX99B9hyEGpH4t5W68bxo+ehRd/l0bQqUu/ OKcfx7WNWSnHheSXNgIqnPVFcv1hm1SgE0dPg6SOT7R8IC0I92A= X-Google-Smtp-Source: AGHT+IE2r0UU7DyXQWVVb3UEv3kbiuqbtvEyxYVscdzn1QzYP09e40Lwstvq+Nv7xlXVf9ErwQt4xA== X-Received: by 2002:a05:6a00:8d1:b0:736:55ec:ea94 with SMTP id d2e1a72fcca58-73682caa339mr4546208b3a.20.1741170483421; Wed, 05 Mar 2025 02:28:03 -0800 (PST) Received: from dw-tp.ibmuc.com ([171.76.80.250]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7364ef011c1sm6252768b3a.111.2025.03.05.02.28.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Mar 2025 02:28:02 -0800 (PST) From: "Ritesh Harjani (IBM)" To: linux-xfs@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org, Jens Axboe , "Darrick J . Wong" , "Ritesh Harjani (IBM)" Subject: [PATCH v2 3/3] xfs_io: Add RWF_DONTCACHE support to preadv2 Date: Wed, 5 Mar 2025 15:57:48 +0530 Message-ID: X-Mailer: git-send-email 2.48.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Add per-io RWF_DONTCACHE support flag to preadv2(). This enables xfs_io to perform uncached buffered-io reads. e.g. xfs_io -c "pread -U -V 1 0 16K" /mnt/f1 Signed-off-by: Ritesh Harjani (IBM) Reviewed-by: "Darrick J. Wong" --- io/pread.c | 17 +++++++++++++++-- man/man8/xfs_io.8 | 8 +++++++- 2 files changed, 22 insertions(+), 3 deletions(-) diff --git a/io/pread.c b/io/pread.c index b314fbc7..79e6570e 100644 --- a/io/pread.c +++ b/io/pread.c @@ -38,6 +38,9 @@ pread_help(void) " -Z N -- zeed the random number generator (used when reading randomly)\n" " (heh, zorry, the -s/-S arguments were already in use in pwrite)\n" " -V N -- use vectored IO with N iovecs of blocksize each (preadv)\n" +#ifdef HAVE_PREADV2 +" -U -- Perform the preadv2() with Uncached/RWF_DONTCACHE\n" +#endif "\n" " When in \"random\" mode, the number of read operations will equal the\n" " number required to do a complete forward/backward scan of the range.\n" @@ -388,7 +391,7 @@ pread_f( init_cvtnum(&fsblocksize, &fssectsize); bsize = fsblocksize; - while ((c = getopt(argc, argv, "b:BCFRquvV:Z:")) != EOF) { + while ((c = getopt(argc, argv, "b:BCFRquUvV:Z:")) != EOF) { switch (c) { case 'b': tmp = cvtnum(fsblocksize, fssectsize, optarg); @@ -417,6 +420,11 @@ pread_f( case 'u': uflag = 1; break; +#ifdef HAVE_PREADV2 + case 'U': + preadv2_flags |= RWF_DONTCACHE; + break; +#endif case 'v': vflag = 1; break; @@ -446,6 +454,11 @@ pread_f( exitcode = 1; return command_usage(&pread_cmd); } + if (preadv2_flags != 0 && vectors == 0) { + printf(_("preadv2 flags require vectored I/O (-V)\n")); + exitcode = 1; + return command_usage(&pread_cmd); + } offset = cvtnum(fsblocksize, fssectsize, argv[optind]); if (offset < 0 && (direction & (IO_RANDOM|IO_BACKWARD))) { @@ -514,7 +527,7 @@ pread_init(void) pread_cmd.argmin = 2; pread_cmd.argmax = -1; pread_cmd.flags = CMD_NOMAP_OK | CMD_FOREIGN_OK; - pread_cmd.args = _("[-b bs] [-qv] [-i N] [-FBR [-Z N]] off len"); + pread_cmd.args = _("[-b bs] [-qUv] [-i N] [-FBR [-Z N]] off len"); pread_cmd.oneline = _("reads a number of bytes at a specified offset"); pread_cmd.help = pread_help; diff --git a/man/man8/xfs_io.8 b/man/man8/xfs_io.8 index 47af5232..df508054 100644 --- a/man/man8/xfs_io.8 +++ b/man/man8/xfs_io.8 @@ -200,7 +200,7 @@ option will set the file permissions to read-write (0644). This allows xfs_io to set up mismatches between the file permissions and the open file descriptor read/write mode to exercise permission checks inside various syscalls. .TP -.BI "pread [ \-b " bsize " ] [ \-qv ] [ \-FBR [ \-Z " seed " ] ] [ \-V " vectors " ] " "offset length" +.BI "pread [ \-b " bsize " ] [ \-qUv ] [ \-FBR [ \-Z " seed " ] ] [ \-V " vectors " ] " "offset length" Reads a range of bytes in a specified blocksize from the given .IR offset . .RS 1.0i @@ -214,6 +214,12 @@ requests will be split. The default blocksize is 4096 bytes. .B \-q quiet mode, do not write anything to standard output. .TP +.B \-U +Perform the +.BR preadv2 (2) +call with +.IR RWF_DONTCACHE . +.TP .B \-v dump the contents of the buffer after reading, by default only the count of bytes actually read is dumped.