From patchwork Wed Mar 5 09:17:43 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexey Panov X-Patchwork-Id: 14003160 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D47EC19F32 for ; Wed, 5 Mar 2025 18:43:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 51A3F28000F; Wed, 5 Mar 2025 13:43:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4CB3E28000B; Wed, 5 Mar 2025 13:43:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 391E628000F; Wed, 5 Mar 2025 13:43:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 15A3B28000B for ; Wed, 5 Mar 2025 13:43:36 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B5BCBA388C for ; Wed, 5 Mar 2025 09:18:00 +0000 (UTC) X-FDA: 83186945520.01.0C41922 Received: from mail-gw02.astralinux.ru (mail-gw02.astralinux.ru [195.16.41.108]) by imf13.hostedemail.com (Postfix) with ESMTP id 3CA9420005 for ; Wed, 5 Mar 2025 09:17:57 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf13.hostedemail.com: domain of apanov@astralinux.ru designates 195.16.41.108 as permitted sender) smtp.mailfrom=apanov@astralinux.ru ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741166278; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references; bh=ikmjVS68A7xWvon2OMAHhsESzi4JFksfLXIDcJCLCSE=; b=Yuy9EnoHf1mXxfKg8KFBOybF2dEvwOVD/ddMYTf7YJjBYip6rZOmXBgYr4oaMnRuCiOsYe TLqPuZjkcGSZsq8UnwuZrTkIqtZXhAMvtINmEbGQaF2uxPYTNeUeprhLrBnVyH55v7eDyD +ej774wfLjy1s8L/Wb9dlYaIpLboK9c= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741166278; a=rsa-sha256; cv=none; b=wzuIGeA+bxoZ8Dg90/3p8aei3hEk7FicXAWFKn6jfU3yty9WFkOHau9+SIUsmJG3OeeyPc lAuQNSOF4hrbPlR9QQ8ojPYrZeATkX6XsSTIX53cXFCLPLyuG6X8XbXMZXK9XNztxeBbnk gEOqLnAuQdmlHPl1D5lZh/5BU4kKMJU= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf13.hostedemail.com: domain of apanov@astralinux.ru designates 195.16.41.108 as permitted sender) smtp.mailfrom=apanov@astralinux.ru Received: from gca-msk-a-srv-ksmg01.astralinux.ru (localhost [127.0.0.1]) by mail-gw02.astralinux.ru (Postfix) with ESMTP id EFC101F96B; Wed, 5 Mar 2025 12:17:55 +0300 (MSK) Received: from new-mail.astralinux.ru (gca-yc-ruca-srv-mail05.astralinux.ru [10.177.185.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail-gw02.astralinux.ru (Postfix) with ESMTPS; Wed, 5 Mar 2025 12:17:54 +0300 (MSK) Received: from rbta-msk-lt-156703.astralinux.ru (unknown [10.198.62.40]) by new-mail.astralinux.ru (Postfix) with ESMTPA id 4Z76Qn2n49z1c0sm; Wed, 5 Mar 2025 12:17:53 +0300 (MSK) From: Alexey Panov To: stable@vger.kernel.org, Greg Kroah-Hartman Cc: Alexey Panov , Andrew Morton , Christoph Lameter , linux-mm@kvack.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org, David Hildenbrand , syzbot+3511625422f7aa637f0d@syzkaller.appspotmail.com, "Liam R . Howlett" Subject: [PATCH 6.1] mm/mempolicy: fix migrate_to_node() assuming there is at least one VMA in a MM Date: Wed, 5 Mar 2025 12:17:43 +0300 Message-Id: <20250305091743.19962-1-apanov@astralinux.ru> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-KSMG-AntiPhishing: NotDetected, bases: 2025/03/05 07:47:00 X-KSMG-AntiSpam-Auth: dkim=none X-KSMG-AntiSpam-Envelope-From: apanov@astralinux.ru X-KSMG-AntiSpam-Info: LuaCore: 51 0.3.51 68896fb0083a027476849bf400a331a2d5d94398, {Tracking_uf_ne_domains}, {Tracking_internal2}, {Tracking_from_domain_doesnt_match_to}, lore.kernel.org:7.1.1;lkml.kernel.org:7.1.1;new-mail.astralinux.ru:7.1.1;127.0.0.199:7.1.2;astralinux.ru:7.1.1;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1, FromAlignment: s X-KSMG-AntiSpam-Interceptor-Info: scan successful X-KSMG-AntiSpam-Lua-Profiles: 191497 [Mar 05 2025] X-KSMG-AntiSpam-Method: none X-KSMG-AntiSpam-Rate: 0 X-KSMG-AntiSpam-Status: not_detected X-KSMG-AntiSpam-Version: 6.1.1.11 X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.1.0.7854, bases: 2025/03/05 06:08:00 #27609135 X-KSMG-AntiVirus-Status: NotDetected, skipped X-KSMG-LinksScanning: NotDetected, bases: 2025/03/05 07:48:00 X-KSMG-Message-Action: skipped X-KSMG-Rule-ID: 1 X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 3CA9420005 X-Stat-Signature: 3qy5w7axf8ny5h6nj9r9chukaqjqtdey X-HE-Tag: 1741166277-832723 X-HE-Meta: U2FsdGVkX18hqfa3ibaTIwmPpULrkpjOVtQS660JhgmnQOldUXklbchZGy6TQgG5YFPjuQ/t1P+XBLg30GXbGRr/o9HhhpzYSJ0V49yOohhy1GnAHeZvLQTjYIgQ1Wy7L3qziWS9ofVu16uZUF0FSAUyW4JAEiJjHfXRUUrgiCH89pidwnn53KM2gYLRtt8Epnm09dAeV1xO8S1cG5bHIK7k4BW0ugVyst9jstTAvBzB7LQAryR6tm80NkyWajrGvKfAKhXS3NwichUnV9NptxteqTE+f5OISu2XkcogXKS9J7Ii+SFXc0x3xklad6SibsSw7ZUmYX1uk17F95ER0r9kY7EtKkahf3RjNq9OpQMnYAgr2hBYUzNROjjrzINTMtHgX5EfLAQaB/0UqAqwwW2Kcg4H3Tzr3P5Yy5RfxYwai42riWzuYUWhTM2y3FL9wcM55LYat774dHAy0Zuv3Qu7Nu5k1QB3A7zffwF+mRU7v9XZ27Wqxrd/OzJJWCv+smEFC9iVAV4NgBEcePogavrAOpvmQ6e5qOvaUmY7HvtBRKF4HeN9F8VuXFyX/hK276JeLMul5X51F3GL1fxSiAQ9GwwaTMbIH2vZw73Sw5JC7p/J9AyjjRVcpHZTt9l2t6YWGK87vImslc/EAQnmHOb4Is7Cbl/TxWE6Jv4GbOkBcTdiQapg+xwf2nvqrmZeufHIMmi5TKY34kLq4X0JHt5LLY/JxVeZvil1XRCC8eGpv74Zk6a14AEDVbC8UCMM+CAPZ4s1hhT4ZSnEKuUynUBuPnhEfuWx+Ye07BGcO7XIzNfIlIxIdfxG/74C2qL7j3MlX9ocveTosKuYojwIvVUE1O6dNRdkBP0KNoCmvf7Gf3HRKclfrC4R7SUPdDazmcemTnrPfiCBWIi+QogCW7PHHRVeJ1GpiwfgjNzbz/16VOTYdt4nb/oD8WsBQstal74mQwCqxNEe8FeDcql PP0i24QP hdR5OWIGd5ZFrMn08l/dLYWUzBK2bbrJcq82m3L9VVtEYRca/Mtt6jPjxQ7lHM1QsJ9P6XxvgfHu18tSXY0RoQ6bqT17UPQWVn+Pr9VLNpLcS/K/HBzntHW7JhN+ovCMn60D25KQJGFKyPEEJBhzsu3J4mdCpiC1MqATs1cSsANG2bnx6I+POVdbWvDkQFhIm+X80KUaqPxM0HdtN9rSeyDhA01rmiuYQ/BPidT/bjiO4oD2YHq5TkssWrDj1ki4iIxJgUdBCxwwt1hNyXroQluGdKNQSN9CGSqu+MBitc+zmBjEcvsHyEI8i4GpZJYPQU3jYix5QfnMf08NBGJX2M7N5p5UV7felFJ4CGS141J3Wv8C9Gr3TiMOVuYS/D7IHdw459oxGpb33borghkw8RntJqz3X/pEs6yI1rpK46Oeq317NsTyYoXy1/Yn4310+F5coQyFau1z7f1eXlEtGvrV9XJRuw2sGECxuUzCEZLoxuFraLilcHcKeuwtjmGuBQBPjNAxhzC/pM0WyZUYxwCX7HKw5ZfGpZb2RPC4VGLzFGzmUksCytstTUHUqL/mF0KZIhGiI550hqy4/xkph7dBwJ9UZ0OyFoFnB9K0Je6CWBCWUNk+mxjc7yg8Tuv6B1cfq9hOrXaugfZMjXlDRmV/YTt2Hu5gR1es17RfC8u0ZHXEidLlp8FuJDA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: David Hildenbrand commit 091c1dd2d4df6edd1beebe0e5863d4034ade9572 upstream. We currently assume that there is at least one VMA in a MM, which isn't true. So we might end up having find_vma() return NULL, to then de-reference NULL. So properly handle find_vma() returning NULL. This fixes the report: Oops: general protection fault, probably for non-canonical address 0xdffffc0000000000: 0000 [#1] PREEMPT SMP KASAN PTI KASAN: null-ptr-deref in range [0x0000000000000000-0x0000000000000007] CPU: 1 UID: 0 PID: 6021 Comm: syz-executor284 Not tainted 6.12.0-rc7-syzkaller-00187-gf868cd251776 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/30/2024 RIP: 0010:migrate_to_node mm/mempolicy.c:1090 [inline] RIP: 0010:do_migrate_pages+0x403/0x6f0 mm/mempolicy.c:1194 Code: ... RSP: 0018:ffffc9000375fd08 EFLAGS: 00010246 RAX: 0000000000000000 RBX: ffffc9000375fd78 RCX: 0000000000000000 RDX: ffff88807e171300 RSI: dffffc0000000000 RDI: ffff88803390c044 RBP: ffff88807e171428 R08: 0000000000000014 R09: fffffbfff2039ef1 R10: ffffffff901cf78f R11: 0000000000000000 R12: 0000000000000003 R13: ffffc9000375fe90 R14: ffffc9000375fe98 R15: ffffc9000375fdf8 FS: 00005555919e1380(0000) GS:ffff8880b8700000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00005555919e1ca8 CR3: 000000007f12a000 CR4: 00000000003526f0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Call Trace: kernel_migrate_pages+0x5b2/0x750 mm/mempolicy.c:1709 __do_sys_migrate_pages mm/mempolicy.c:1727 [inline] __se_sys_migrate_pages mm/mempolicy.c:1723 [inline] __x64_sys_migrate_pages+0x96/0x100 mm/mempolicy.c:1723 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f [akpm@linux-foundation.org: add unlikely()] Link: https://lkml.kernel.org/r/20241120201151.9518-1-david@redhat.com Fixes: 39743889aaf7 ("[PATCH] Swap Migration V5: sys_migrate_pages interface") Signed-off-by: David Hildenbrand Reported-by: syzbot+3511625422f7aa637f0d@syzkaller.appspotmail.com Closes: https://lore.kernel.org/lkml/673d2696.050a0220.3c9d61.012f.GAE@google.com/T/ Reviewed-by: Liam R. Howlett Reviewed-by: Christoph Lameter Cc: Liam R. Howlett Cc: Signed-off-by: Andrew Morton [Alexey: drop mmap_read_unlock bacause there is no mmap_read_lock ] Signed-off-by: Alexey Panov --- mm/mempolicy.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/mm/mempolicy.c b/mm/mempolicy.c index 399d8cb48813..be18b399a294 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -1068,6 +1068,9 @@ static int migrate_to_node(struct mm_struct *mm, int source, int dest, * space range and MPOL_MF_DISCONTIG_OK, this call can not fail. */ vma = find_vma(mm, 0); + if (unlikely(!vma)) { + return 0; + } VM_BUG_ON(!(flags & (MPOL_MF_MOVE | MPOL_MF_MOVE_ALL))); queue_pages_range(mm, vma->vm_start, mm->task_size, &nmask, flags | MPOL_MF_DISCONTIG_OK, &pagelist);