From patchwork Wed Mar 5 09:18:20 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexey Panov X-Patchwork-Id: 14003161 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5758AC282E5 for ; Wed, 5 Mar 2025 18:43:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 748B8280013; Wed, 5 Mar 2025 13:43:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6D52928000B; Wed, 5 Mar 2025 13:43:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 599A1280013; Wed, 5 Mar 2025 13:43:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3BEF128000B for ; Wed, 5 Mar 2025 13:43:39 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 4D755A39D7 for ; Wed, 5 Mar 2025 09:18:30 +0000 (UTC) X-FDA: 83186946780.16.8A13D28 Received: from mail-gw02.astralinux.ru (mail-gw02.astralinux.ru [195.16.41.108]) by imf11.hostedemail.com (Postfix) with ESMTP id B41A74000B for ; Wed, 5 Mar 2025 09:18:27 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; spf=pass (imf11.hostedemail.com: domain of apanov@astralinux.ru designates 195.16.41.108 as permitted sender) smtp.mailfrom=apanov@astralinux.ru; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741166308; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references; bh=jbBK/NuTuCFxp1d6CSRaaZFmQn9T50FFoGJfeJHNvNE=; b=JYvMZlzQywS0SGXcnloD2278yzEXScLblL+S8VbTZ+HB8vztbFcEevKSXHhpECLW1qK1Oj DBqrf91YgQ5pN2y4A7p1+UuQwP0rbpfHNdEnKEA04Dvz190MHMfrbweqt3Hi2pTaenRLFm yTZ4Jdl4FhcRooTpFUscag1+O1FE66s= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; spf=pass (imf11.hostedemail.com: domain of apanov@astralinux.ru designates 195.16.41.108 as permitted sender) smtp.mailfrom=apanov@astralinux.ru; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741166308; a=rsa-sha256; cv=none; b=ziCBLK5hadjDEQkpiY/5lWoYsuCYJTheYlgONeYRUQuRqF0uLeIE4H3gHD9RHx8fVQTC3v t2a0FSj08IROut8NygBQkDVVWIzh+QnFkKGeozl0AbWNIbUIZdB0wf8qZkfGkx/sDNeeKe pif4dq5+ipMkbRpll2u2bMeTf84P4Ls= Received: from gca-msk-a-srv-ksmg02.astralinux.ru (localhost [127.0.0.1]) by mail-gw02.astralinux.ru (Postfix) with ESMTP id 16CFE1F982; Wed, 5 Mar 2025 12:18:26 +0300 (MSK) Received: from new-mail.astralinux.ru (gca-yc-ruca-srv-mail03.astralinux.ru [10.177.185.108]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail-gw02.astralinux.ru (Postfix) with ESMTPS; Wed, 5 Mar 2025 12:18:25 +0300 (MSK) Received: from rbta-msk-lt-156703.astralinux.ru (unknown [10.198.62.40]) by new-mail.astralinux.ru (Postfix) with ESMTPA id 4Z76RN6ZcFz1h0Bc; Wed, 5 Mar 2025 12:18:24 +0300 (MSK) From: Alexey Panov To: stable@vger.kernel.org, Greg Kroah-Hartman Cc: Alexey Panov , Andrew Morton , Christoph Lameter , linux-mm@kvack.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org, David Hildenbrand , syzbot+3511625422f7aa637f0d@syzkaller.appspotmail.com, "Liam R . Howlett" Subject: [PATCH 5.10/5.15] mm/mempolicy: fix migrate_to_node() assuming there is at least one VMA in a MM Date: Wed, 5 Mar 2025 12:18:20 +0300 Message-Id: <20250305091820.20110-1-apanov@astralinux.ru> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-KSMG-AntiPhishing: NotDetected, bases: 2025/03/05 07:47:00 X-KSMG-AntiSpam-Auth: dkim=none X-KSMG-AntiSpam-Envelope-From: apanov@astralinux.ru X-KSMG-AntiSpam-Info: LuaCore: 51 0.3.51 68896fb0083a027476849bf400a331a2d5d94398, {Tracking_uf_ne_domains}, {Tracking_internal2}, {Tracking_from_domain_doesnt_match_to}, lkml.kernel.org:7.1.1;127.0.0.199:7.1.2;lore.kernel.org:7.1.1;astralinux.ru:7.1.1;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;new-mail.astralinux.ru:7.1.1, FromAlignment: s X-KSMG-AntiSpam-Interceptor-Info: scan successful X-KSMG-AntiSpam-Lua-Profiles: 191497 [Mar 05 2025] X-KSMG-AntiSpam-Method: none X-KSMG-AntiSpam-Rate: 0 X-KSMG-AntiSpam-Status: not_detected X-KSMG-AntiSpam-Version: 6.1.1.11 X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.1.0.7854, bases: 2025/03/05 06:08:00 #27609135 X-KSMG-AntiVirus-Status: NotDetected, skipped X-KSMG-LinksScanning: NotDetected, bases: 2025/03/05 07:48:00 X-KSMG-Message-Action: skipped X-KSMG-Rule-ID: 1 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: B41A74000B X-Rspam-User: X-Stat-Signature: kp5dasrta99x9rhwmhcwetdzso1oxyi4 X-HE-Tag: 1741166307-288842 X-HE-Meta: U2FsdGVkX1+AH88Xh4Q3VOp4Q3ktK5Rth+CIgG64i0l5RYJLFMd5PF1BXD0YzQ3mQGxCWGOrtKaBEQI7P5R8cQWxVcroe651TiI47gfupYOAn3WP8eAg0Kwow+mgufks3zcTCxlf+NOkPD9OrPe3QdEoazqIl3h9i4PT8re+vknjaIpouODFYwan7prZ3qjTfuMeZT1Qyp27nMGvQ/ZHDx0DgDwQp7KWnrMYAJrphdb6zdhQQx2oqDdlSbr5+qrjPlXjQLNtom3lxAQ6kXtGj5sMVLhRub+obO2U+d+UMd943LNK2NTQX4tdcBqK8/j5R3T7xOHM1TtBYBH/bwgdFnBou19BCuMLOf3YedCx00BUoMean7VkC7ZZQ5l6bR3wl9et6gU+B9Lx2Jphqhhj+sDtYgjOgmViU4AoGQTFjcv8KrVGO6KHS5AhwQeO8hFP688nQ/HpKgILt00ydIAcgU/FcIMKkNIfy08uHvcPmWHA/Ke6hPCeZnMl3wve2KozukXSiGdek1/owu0SD94b7ZO0cRdl4JOiVFq6sv5A9skjlYFnkmOaqeySFoIEKToF8wrHTAKUf39/yuOGadDUxn4YNASvyZtE287B1T6gEYxPCNgBqVJc3D68msEI3l27h/NBOEwSSuPZ1J17F1CKKBqznjnSUKyHKEOzVMoerj1tv8YhvspNV0F4CBQj9XSiF98c+IUZrR8c3M92M/ELeFZft2bejb0DYw609ZKyOX+5Z/1em6oaVZj4i2XQ6t2ligizQcMLGc4rUyR4qhsXajB3uTQp/HHRcLu46XqCgP9HscY/8j4HNzqD1oP3u6ouLnrLEddCpK31+fYe3uhb9LZNSCMxWiGkzP/MjM027slM2q9vZlB6T8JHf1BCtJ3z9DEPY7tYc5oqsBZT9XkSLNs2zCL0D0RKGNCE0k1UhdHGKzEUmw+T3heHPnuyS/CmPTdGV3nJDnjzzc0alpW pHJ92GiA Xi9k5e6Lm66htm/MEd1jp3nrbUk0EJLt3jfLHV075Jpufp3z/7OWNVnytpa2Ud1PhY0UCxqNmbfb9ZQtHlNTVRKoKsrtzBVId06PTzmgf4KJ1jz5ix2RbEe9sHhqLyAi2TsATqlxRl2O5fi8z9JuU+CLHLKz0brZWe6PTB5+1Uwcqx3VD5OMtU1j5EmPPD10oV7ci6XUrAGbr9w0NNG+wQeFW+AhSRYycco8IiOwtdbyBp5QLlNPS51dVspXFH/wxk0odgSr1oyH/YUL1onROQat+ahDDI3bv9pJkNulk/YCCT8IEb5XKaY/aZTkoWi/Tx01OOm8FzDnIf6RW3EMKnQnbqqGMWj55pldEoxa5538KgvjLG0TXbUh9Wl0ej8C6otq0Rlp37OOMLaurxWqbZqAJWtYu3mlAceZQgTw1JhTyiwy7EU3q+JZsR/Q4ISFyHWKHs2u40fETsjvuGqBRTVG7MmxuZXbraNovDyU2zFbDJFEwocoy0dif72QehDcIbpkdHtSON3J81n6pLnAPk7GbrG2JJMhc9a4CdAhGCsp4otj+zQz8qP2qX0Imhj+RtzWPREV7vs5Nb+p4nN1IrUkUBexWdbcaoB9BIw+oMSaLqFsXgBibo/Iv4TD7IQYsn9/eZv8n2LV77QzZ4pnHWxBJMmna6R1t7YFJbMOLe7SOles9pk5KrX+/Sg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: David Hildenbrand commit 091c1dd2d4df6edd1beebe0e5863d4034ade9572 upstream. We currently assume that there is at least one VMA in a MM, which isn't true. So we might end up having find_vma() return NULL, to then de-reference NULL. So properly handle find_vma() returning NULL. This fixes the report: Oops: general protection fault, probably for non-canonical address 0xdffffc0000000000: 0000 [#1] PREEMPT SMP KASAN PTI KASAN: null-ptr-deref in range [0x0000000000000000-0x0000000000000007] CPU: 1 UID: 0 PID: 6021 Comm: syz-executor284 Not tainted 6.12.0-rc7-syzkaller-00187-gf868cd251776 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/30/2024 RIP: 0010:migrate_to_node mm/mempolicy.c:1090 [inline] RIP: 0010:do_migrate_pages+0x403/0x6f0 mm/mempolicy.c:1194 Code: ... RSP: 0018:ffffc9000375fd08 EFLAGS: 00010246 RAX: 0000000000000000 RBX: ffffc9000375fd78 RCX: 0000000000000000 RDX: ffff88807e171300 RSI: dffffc0000000000 RDI: ffff88803390c044 RBP: ffff88807e171428 R08: 0000000000000014 R09: fffffbfff2039ef1 R10: ffffffff901cf78f R11: 0000000000000000 R12: 0000000000000003 R13: ffffc9000375fe90 R14: ffffc9000375fe98 R15: ffffc9000375fdf8 FS: 00005555919e1380(0000) GS:ffff8880b8700000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00005555919e1ca8 CR3: 000000007f12a000 CR4: 00000000003526f0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Call Trace: kernel_migrate_pages+0x5b2/0x750 mm/mempolicy.c:1709 __do_sys_migrate_pages mm/mempolicy.c:1727 [inline] __se_sys_migrate_pages mm/mempolicy.c:1723 [inline] __x64_sys_migrate_pages+0x96/0x100 mm/mempolicy.c:1723 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f [akpm@linux-foundation.org: add unlikely()] Link: https://lkml.kernel.org/r/20241120201151.9518-1-david@redhat.com Fixes: 39743889aaf7 ("[PATCH] Swap Migration V5: sys_migrate_pages interface") Signed-off-by: David Hildenbrand Reported-by: syzbot+3511625422f7aa637f0d@syzkaller.appspotmail.com Closes: https://lore.kernel.org/lkml/673d2696.050a0220.3c9d61.012f.GAE@google.com/T/ Reviewed-by: Liam R. Howlett Reviewed-by: Christoph Lameter Cc: Liam R. Howlett Cc: Signed-off-by: Andrew Morton [Alexey: drop mmap_read_unlock because there is no mmap_read_lock and use find_vma instead of mm->mmap] Signed-off-by: Alexey Panov --- mm/mempolicy.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/mm/mempolicy.c b/mm/mempolicy.c index f089de8564ca..acd186331e1f 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -1048,6 +1048,7 @@ static int migrate_to_node(struct mm_struct *mm, int source, int dest, int flags) { nodemask_t nmask; + struct vm_area_struct *vma; LIST_HEAD(pagelist); int err = 0; struct migration_target_control mtc = { @@ -1063,8 +1064,12 @@ static int migrate_to_node(struct mm_struct *mm, int source, int dest, * need migration. Between passing in the full user address * space range and MPOL_MF_DISCONTIG_OK, this call can not fail. */ + vma = find_vma(mm, 0); + if (unlikely(!vma)) { + return 0; + } VM_BUG_ON(!(flags & (MPOL_MF_MOVE | MPOL_MF_MOVE_ALL))); - queue_pages_range(mm, mm->mmap->vm_start, mm->task_size, &nmask, + queue_pages_range(mm, vma->vm_start, mm->task_size, &nmask, flags | MPOL_MF_DISCONTIG_OK, &pagelist); if (!list_empty(&pagelist)) {