From patchwork Thu Mar 6 09:49:23 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zorro Lang X-Patchwork-Id: 14004080 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2973920A5E7 for ; Thu, 6 Mar 2025 09:49:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741254570; cv=none; b=dV6wo2XO5bfpZkbyKNdUYyKcJrIOlqw0AghmOo/b9HnmxqrdKKH0Zr5GuBFXNKoWhBjBP5+FsDa48vmkBVR1Kf5sb2NFy4fZYhLa7wLldXw7irdOwGrSOyRJco6X0YgJQcXvkNecVUM+TQiTQcxvckWjoNtCkZHf28rVqumWx98= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741254570; c=relaxed/simple; bh=+cx5lz/x1NkdsbeUNBxXgdCfYB4xcwBIurLylPtByrc=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=M2/Ej31OJBXj0ytt02YsP9NFhhn83OAIzyVQ3bnl9ECP5TLuRJnMt893xMkApXbPxDgwN7ePHqjk9wH8GMuJ//3gb0Hyq8YyauOHUuNCBiQvfkrfN/zbTd2wUoMHWMGParz2Jts6DC+hbp0yga7c9UwREqnCqVSvdLhczhkYkrk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=i6hB1au7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="i6hB1au7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DEC1AC4CEE4 for ; Thu, 6 Mar 2025 09:49:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741254569; bh=+cx5lz/x1NkdsbeUNBxXgdCfYB4xcwBIurLylPtByrc=; h=From:To:Subject:Date:In-Reply-To:References:From; b=i6hB1au757nrhDmGpvSc0aBtz1cElztBfZDObY3V8hse3tS5qjiLdNQ96Y1CGyhY2 fLfGICFpa6wdhxkYoYM9YPMvOsjND4bpnjxcS7jfH8WOP/seaHGifzQoi3xMf9dEnz 74N6m9K7xD2Pi0MADbdF9ZqkKw2h4AzTbeSEOlnJbuL6SlzGV1E+JKQuPacIZYFlJq w+nA+N6L96O8f1UdfeBFcm+4dOfq8yfZxYfyH/VIN3EFrWt5y2dVebqjoBYJdZbvdQ fIgQYYSTEARKx9VZha74aUSXyl6YidjUJBhLJLtFVG0jK/O5vAYSO10yWHxtthVyQW BzG4RzLhq/m7w== From: Zorro Lang To: fstests@vger.kernel.org Subject: [PATCH v2 1/2] check: disable HAVE_PRIVATENS by default Date: Thu, 6 Mar 2025 17:49:23 +0800 Message-ID: <20250306094924.1353269-2-zlang@kernel.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250306094924.1353269-1-zlang@kernel.org> References: <20250306094924.1353269-1-zlang@kernel.org> Precedence: bulk X-Mailing-List: fstests@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Currently we have 3 ways to run a test case in _run_seq(): if [ -n "${HAVE_PRIVATENS}" ]; then ./tools/run_privatens "./$seq" ... elif [ -n "${HAVE_SYSTEMD_SCOPES}" ]; then systemd-run --quiet --unit "${unit}" --scope \ ./tools/run_setsid "./$seq" & ... else ./tools/run_setsid "./$seq" & ... fi The "privatens" way brings in some regressions. We need more time to develop and test this way, it's not time let it to be the first default choice, so isolate the HAVE_PRIVATENS initialization by a TRY_PRIVATENS parameter, and disable it by default. Set TRY_PRIVATENS=yes to give "privatens" a try, otherwise run in old ways. This patch can be removed after "privatens" way is stable. Signed-off-by: Zorro Lang Reviewed-by: "Darrick J. Wong" --- check | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/check b/check index ea92b0d62..cb2f19d08 100755 --- a/check +++ b/check @@ -674,10 +674,13 @@ _stash_test_status() { esac } -# Can we run in a private pid/mount namespace? -HAVE_PRIVATENS= -./tools/run_privatens bash -c "exit 77" -test $? -eq 77 && HAVE_PRIVATENS=yes +# Don't try "privatens" by default, it's experimental for now. +if [ "$TRY_PRIVATENS" = "yes" ];then + # Can we run in a private pid/mount namespace? + HAVE_PRIVATENS= + ./tools/run_privatens bash -c "exit 77" + test $? -eq 77 && HAVE_PRIVATENS=yes +fi # Can we run systemd scopes? HAVE_SYSTEMD_SCOPES= From patchwork Thu Mar 6 09:49:24 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zorro Lang X-Patchwork-Id: 14004081 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEF5120B210 for ; Thu, 6 Mar 2025 09:49:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741254572; cv=none; b=fxGYtuc0apB2OOF6CN8kZ9QjlLuXY8DH/u2T13dNR0CRUZhOGxArpNFuE2ysJMYct+9jwoWCRwNFGf0knhts+NGJVvu+lZblTU8MRpnn30oU7btkJan2fk+C6p8ZGU4pc9KJgVADMRjqWIujzOTclbgaBTypcbs1asSm5q3ml+o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741254572; c=relaxed/simple; bh=HvbIMpbC+TlPtJavlPg7HkmLjwR9jUTAFgAeaB2lHDQ=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Tj1gGmllD2Y5m6ZcpVyNNJijkwIAxTZTGTSyx2EMcOps9dO9RkN/PWcbj9AmrVhIakXelL6xOzibvzMJXRkEuWuId+gr2ZKw9OzJh6cIja2p5AM8hh+xdujxDH7hQqqQjS6NJ6+V0Fnh3DX69xTde0q3mc96IRq1RqBBgpemR7w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=r7QJ3e8E; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="r7QJ3e8E" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 575AFC4CEE0 for ; Thu, 6 Mar 2025 09:49:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741254571; bh=HvbIMpbC+TlPtJavlPg7HkmLjwR9jUTAFgAeaB2lHDQ=; h=From:To:Subject:Date:In-Reply-To:References:From; b=r7QJ3e8EUofn9dqA39tNzwcxZT7wxJZxIKpAQ2wTzq8eHxxK3EKYXnnT32CI6ezK+ HecdiHY6WWEHVrECe81j+JbFRdnF4nYPNHMd+fN54JO5K7ZbOG4jbOrTx+9J+5CNwK llXWaczltHxmwtrZaxQyVndSP7IJnxH8w0/wdE2ZD3Mjsk/NK7w3eWGfxmOOjszhnb 9SshFMqNHcWfrx6e1bcuH8avgf6DQCe78iJHkA7XSDHqsvOcUlD13EZDc0m8i2Gh6P 1giecuC/OkEmzmJqAIhBP5+bsuAFd1gBYk2cm3RFWvDKGfqdxp4rWKClikSZcZJMt/ tzRuSkAwexDtw== From: Zorro Lang To: fstests@vger.kernel.org Subject: [PATCH v2 2/2] check: remove the deprecation of sessionid Date: Thu, 6 Mar 2025 17:49:24 +0800 Message-ID: <20250306094924.1353269-3-zlang@kernel.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250306094924.1353269-1-zlang@kernel.org> References: <20250306094924.1353269-1-zlang@kernel.org> Precedence: bulk X-Mailing-List: fstests@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 As "privatens" way isn't recommended temporarily, it can't replace "sessionid" way for now. So remove the deprecation. Signed-off-by: Zorro Lang Reviewed-by: "Darrick J. Wong" --- check | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/check b/check index cb2f19d08..33eb3e085 100755 --- a/check +++ b/check @@ -695,15 +695,6 @@ function _adjust_oom_score() { } _adjust_oom_score -500 -warn_deprecated_sessionid() -{ - if [ -z "$WARNED_DEPRECATED_SESSIONID" ]; then - echo "WARNING: Running fstests without private pid/mount namespace" - echo "support is deprecated and will be removed in February 2026." - WARNED_DEPRECATED_SESSIONID=1 - fi -} - # ...and make the tests themselves somewhat more attractive to it, so that if # the system runs out of memory it'll be the test that gets killed and not the # test framework. The test is run in a separate process without any of our @@ -903,8 +894,6 @@ function run_section() seqres="$check" _check_test_fs - test -n "$HAVE_PRIVATENS" || warn_deprecated_sessionid - loop_status=() # track rerun-on-failure state local tc_status ix local -a _list=( $list )