From patchwork Thu Mar 6 22:03:21 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Andryuk X-Patchwork-Id: 14005393 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16EA3C28B27 for ; Thu, 6 Mar 2025 22:04:10 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.904064.1311977 (Exim 4.92) (envelope-from ) id 1tqJJu-0000cv-5T; Thu, 06 Mar 2025 22:03:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 904064.1311977; Thu, 06 Mar 2025 22:03:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqJJt-0000Zy-TP; Thu, 06 Mar 2025 22:03:57 +0000 Received: by outflank-mailman (input) for mailman id 904064; Thu, 06 Mar 2025 22:03:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqJJs-0000Ss-AB for xen-devel@lists.xenproject.org; Thu, 06 Mar 2025 22:03:56 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on20603.outbound.protection.outlook.com [2a01:111:f403:200a::603]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e42e59e4-fad6-11ef-9ab4-95dc52dad729; Thu, 06 Mar 2025 23:03:54 +0100 (CET) Received: from BN9PR03CA0543.namprd03.prod.outlook.com (2603:10b6:408:138::8) by BL4PR12MB9535.namprd12.prod.outlook.com (2603:10b6:208:591::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.19; Thu, 6 Mar 2025 22:03:48 +0000 Received: from BN3PEPF0000B36E.namprd21.prod.outlook.com (2603:10b6:408:138:cafe::be) by BN9PR03CA0543.outlook.office365.com (2603:10b6:408:138::8) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8511.19 via Frontend Transport; Thu, 6 Mar 2025 22:03:48 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN3PEPF0000B36E.mail.protection.outlook.com (10.167.243.165) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8549.1 via Frontend Transport; Thu, 6 Mar 2025 22:03:48 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 6 Mar 2025 16:03:47 -0600 Received: from fedora.mshome.net (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Thu, 6 Mar 2025 16:03:46 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e42e59e4-fad6-11ef-9ab4-95dc52dad729 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=A2gsierDPhEKm1IQG1yL6KmjONIvqIfpbQQJL6hdPE0RoPmFU5FxEoDGoPsEjq9MDnHVwbNWlgQBuwQQANyWsubRJkXO2uc0i4hXVDVob4xMktVvijIb+i0GhdtmaM0ExNjBRkPa7Zv9hyjOCte5lVAf1gvHDX48FWxsdq9jU12f17NcIjzg04zkqbNaHPgIYlrWFFylb0uQkrwvNxwLKoGXFlhFvunRhHuw4QHr3USG/cdhl/+0HjzDxDA7ECdnY+8uA/7/lH7/U5S2cqYAu3PRvyxqmwOHW0Dy1hB7MKXyHiveme5qHEy0Lt2ZVnsdxwpq4sJcpMroYZdGK8s65Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C3v6UlYBcmi3ov7lYi2wo5cPY1aCBB8qLirYSeYSjb0=; b=msQC1FXgdPvjqSPW9oK2LjGhHGJN9cc+XY0Km1BGrKbDQob23pmOD83IxaiRfWND07M/+BU9w8i6IzhkmOPUlYCzXgdHLwz8XowRy/J4fLXV4kKmD4qM0vIrfkv9WizW8dR7Hmi03Wz7YGUZe/AedQqexjYvxlXv/nqu+ku+QMeGQSmoXcgIQg01R27E/NCadFRWjrymdhLcNKxBVfpPWEFY6qhQUSd4PZNoWGp5V7e/mUPsPDucbTvnwg5w32iofMR5EqDc3r8anmOxjBv4hF0dgWu5PrPcnU7Y75x/RY+2Imnwxogi9JY8gaHfo0HHVihgktBuKT8H0K/04Zzkhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C3v6UlYBcmi3ov7lYi2wo5cPY1aCBB8qLirYSeYSjb0=; b=dTzhmbBanKg4WPxSTlWqG2dtriVlLj6ZEwbCl9FuRKkG3FLTxrQNQl2tZbxsic5QJojnb0j2qQjurrC0Xsj9HB7zj83q4hEpz4g04KfjbqMLYi4zTguwBQDuCfIVwKmXucuEf8YhhaCyziNv75rC6tWqwV5jU0gnGhGl9JH94g0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Jason Andryuk To: CC: "Daniel P. Smith" , Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , "Volodymyr Babchuk" , Andrew Cooper , Anthony PERARD , "Jan Beulich" , =?utf-8?q?Roger_Pau_Monn=C3=A9?= , Jason Andryuk Subject: [PATCH 01/23] xen: introduce hardware domain create flag Date: Thu, 6 Mar 2025 17:03:21 -0500 Message-ID: <20250306220343.203047-2-jason.andryuk@amd.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250306220343.203047-1-jason.andryuk@amd.com> References: <20250306220343.203047-1-jason.andryuk@amd.com> MIME-Version: 1.0 Received-SPF: None (SATLEXMB03.amd.com: jason.andryuk@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B36E:EE_|BL4PR12MB9535:EE_ X-MS-Office365-Filtering-Correlation-Id: a74b46e0-bbff-4016-bf3d-08dd5cfac575 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|7416014|1800799024|36860700013; X-Microsoft-Antispam-Message-Info: JeeWTzqXaLc1pTTrmyWiQSndCv0qDFEX0FQonST+XiiseHX5Kv1O63VF3Ps/1h2AOuhCldJjfLybaHkoA/E+Qq+A2BHNOKd0LBabFlTgDKH15XzuSDsigCQy2B7eS+0KG7OwIQ4xeaJBevWYCtyghBKwTAD+W0uE2XVs8XaiLQr/4k+rTs8i4EtsWUSTlXpX/RuTp/AP6eIiXLIHxzO/Rhqhuvcvs2bx2iLiUv0UtXlxC58Lo1nlyFs2E3J4hbE+xfUTvgdvT/5YitTGYH+dsHB6R2UmXxbFYPtZoZhtquOASQJTjbCs5Md1C172a1G/EoIv7Uq4LSqE//4w2RNeXz/x/rbRjZo0imZVp+F3QNOTURxzhTw+7RbgeGXMc2oAlcYLqMpWkgu0L7dImqxdkuVsStbtTEbwVkkAeFkPFjrLDQxwLcNmZYzwcVvzqvYUqUagPGYkjO2UHMSn2pOzvRhh4PSl0HEtSuqdNN6XEUomvS1AoTvWny74/F4N8rn+8xvV1o9Mwk3TBUus1NmA2AZCZqbn7p0rpWxSGyHSZdnV1OGi/sStUHSr8vI1UjR6CqtduuPoMFy8c2kB0CTOUlcMV9B080H90LCSt92PhegGyksHGuiD1SeLCKQz8m4kSQ1R19f28ZF8A3JwwTcVy5kc5oDb3TURtKs7a+Ozl4JBgbwCnvc4bMzyAV5Xc5b3tnFlz630l894xNb735+be8s30+X6uYUyL/jHr2FdOfSi2uPShg7UvRNEhrxw5rEtpP97Rwy6JqgO/XHwkZBCHiygGK0VbgAZttTb/QqSF+lFbhg2cxp4GlKW/PFCNsb91Q7QxsFOQOzq6TUoFtLofz8vXXcU81LDv4AbT5zjhSY9PLIUPEpVLLYDC/u2TDxeFUgxgffuizFi0ccEFibPpwbS1CaNMGPVeXUCG0wg6oSIM71CGCncz4mpAgyhsJ0cJqfZBkBgkUu3vGNMO4W0Vid6P7rUhcjez/TK13X/D+SLStakrtWyIIz/UKtXpuiV/cSrTWOlQ4NN6e7c8FLmYpeKKxhPRNmCetV20VfVPp+zoYJl7IRdlDE1pMYG9UIFizeLUL05g12jRsHXOUY9KSBWAp4OHlKv46YKMJskYmLCcWMOeeRdl1fUjBPUFGa6yEViaFB89e0/wm8hj/XPpaN2yGQS29XNpI4Z8xQiZi3h4Czos7ANZER+79dloniKcvRVlsB8iNcDnGfGx30ghzlXveS3Q5wSvVuGfMCr0cjFomzRyw3gm+3gF/azUM6dVpxZ4YHbA0lm94WEoW3Ws+RkLXcwyvqOCJyW0Ekh8FZH2/Id9Nx3m/GqT/blpNMO6oSFt9+LR87MN/KJGaM1uCXB1ybAh+TUSIPfKwzMUaDmMDBWvSow02pJEXZBxgVMXhMnqXvZQ2v4y7uZUqg2jvtv/ESGepeHUKCe3Aw/03zbXq5La6Q36cDP3ZaPwnT9owgR6MasBEQgPqzPmvFV+Xi8D+H7WXh3Bw25Ix1O7SY= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(376014)(7416014)(1800799024)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2025 22:03:48.0417 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a74b46e0-bbff-4016-bf3d-08dd5cfac575 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B36E.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL4PR12MB9535 From: "Daniel P. Smith" Add and use a new internal create domain flag to specify the hardware domain. This removes the hardcoding of domid 0 as the hardware domain. This allows more flexibility with domain creation. Signed-off-by: Daniel P. Smith Signed-off-by: Jason Andryuk --- xen/arch/arm/domain_build.c | 2 +- xen/arch/x86/setup.c | 3 ++- xen/common/domain.c | 2 +- xen/include/xen/domain.h | 2 ++ 4 files changed, 6 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index d4570bc0b4..6784ee6f6d 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -2358,7 +2358,7 @@ void __init create_dom0(void) .max_maptrack_frames = -1, .grant_opts = XEN_DOMCTL_GRANT_version(opt_gnttab_max_version), }; - unsigned int flags = CDF_privileged; + unsigned int flags = CDF_privileged | CDF_hardware; int rc; /* The vGIC for DOM0 is exactly emulating the hardware GIC */ diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 143749e5da..fa18b9caf2 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -1017,7 +1017,8 @@ static struct domain *__init create_dom0(struct boot_info *bi) /* Create initial domain. Not d0 for pvshim. */ domid = get_initial_domain_id(); - d = domain_create(domid, &dom0_cfg, pv_shim ? 0 : CDF_privileged); + d = domain_create(domid, &dom0_cfg, + pv_shim ? 0 : CDF_privileged | CDF_hardware); if ( IS_ERR(d) ) panic("Error creating d%u: %ld\n", domid, PTR_ERR(d)); diff --git a/xen/common/domain.c b/xen/common/domain.c index 0c4cc77111..c170597410 100644 --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -699,7 +699,7 @@ struct domain *domain_create(domid_t domid, d->is_privileged = flags & CDF_privileged; /* Sort out our idea of is_hardware_domain(). */ - if ( domid == 0 || domid == hardware_domid ) + if ( flags & CDF_hardware || domid == hardware_domid ) { if ( hardware_domid < 0 || hardware_domid >= DOMID_FIRST_RESERVED ) panic("The value of hardware_dom must be a valid domain ID\n"); diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h index 3de5635291..b5e82578c3 100644 --- a/xen/include/xen/domain.h +++ b/xen/include/xen/domain.h @@ -50,6 +50,8 @@ void arch_get_domain_info(const struct domain *d, #else #define CDF_staticmem 0 #endif +/* Is this the hardware? */ +#define CDF_hardware (1U << 3) #define is_domain_direct_mapped(d) ((d)->cdf & CDF_directmap) #define is_domain_using_staticmem(d) ((d)->cdf & CDF_staticmem) From patchwork Thu Mar 6 22:03:22 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Andryuk X-Patchwork-Id: 14005390 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0B20C282D1 for ; Thu, 6 Mar 2025 22:04:07 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.904062.1311963 (Exim 4.92) (envelope-from ) id 1tqJJt-0000TG-Gt; Thu, 06 Mar 2025 22:03:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 904062.1311963; Thu, 06 Mar 2025 22:03:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqJJt-0000T9-EI; Thu, 06 Mar 2025 22:03:57 +0000 Received: by outflank-mailman (input) for mailman id 904062; Thu, 06 Mar 2025 22:03:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqJJr-0000Ss-L4 for xen-devel@lists.xenproject.org; Thu, 06 Mar 2025 22:03:55 +0000 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on20612.outbound.protection.outlook.com [2a01:111:f403:2408::612]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e486e580-fad6-11ef-9ab4-95dc52dad729; Thu, 06 Mar 2025 23:03:54 +0100 (CET) Received: from CH5P222CA0017.NAMP222.PROD.OUTLOOK.COM (2603:10b6:610:1ee::21) by DM6PR12MB4482.namprd12.prod.outlook.com (2603:10b6:5:2a8::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.16; Thu, 6 Mar 2025 22:03:50 +0000 Received: from CH2PEPF00000149.namprd02.prod.outlook.com (2603:10b6:610:1ee:cafe::7b) by CH5P222CA0017.outlook.office365.com (2603:10b6:610:1ee::21) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8511.19 via Frontend Transport; Thu, 6 Mar 2025 22:03:50 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CH2PEPF00000149.mail.protection.outlook.com (10.167.244.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8511.15 via Frontend Transport; Thu, 6 Mar 2025 22:03:50 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 6 Mar 2025 16:03:49 -0600 Received: from fedora.mshome.net (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Thu, 6 Mar 2025 16:03:49 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e486e580-fad6-11ef-9ab4-95dc52dad729 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Q3kh9HXqs3aLbsJPWEW2+pEOknZmI+NliByurJllSUbmXZpvz5khSM9+q/RVyh/ifju9Xwj4FksJzygBX4sgK+17b7WtPNYhsDFFrVHVp0N8Bs3sxCAdqa2+ZSN/6tzXbpEYwW2ca4f2tvLmdRqpuppclCQQ6xRNSWq6bANbfCORymJBNTZNWF20nIlrrCnMWWcNhQf9JQ7CWS1QRPlmlzUe9LkLuBBOYmaM8ESWkR6OB3fGRAe3NeDzwQZVuVjjMETuKXIunV3em/25w7efPrMZkhh/EmYt69lmh4+hiwPoS2Yb3/djNi5yKNbolpllaHPYgQGL5xyFAjvyMfuYQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=q7tJj+JfWBdt+nWeZjIonJo3rxvFv7v9MKH7jCHgkek=; b=U4mANfbnBSXMZ7SqWmjgps3gwAvdhhsLteTmFUv0FyJ1JrdS3K8O5YKKy3CUB5Hxpa4cEmdORaxf3ywYcgWPhMqpESnWTzqwVZP/C7M71/Y90lebgtu4EFQfLY4z78Gox1Z4WdaeM1ocdWNDVGPobutbcnp1s7YM9x4XEzrwN5+FvDyBooyfB9dGbtWWQOPhiQjGqdGeP95LhmjzH513v15uLfNzx894W1vz7Ova1c+x1bh3ZhsBjuZZeuydVtyrD6iCPv8XoqzGwAlC6FUJ5FLFiNTEk6LftTkxIb2I5/ifeQ/azN0zSu7Zgw2dBXqhxKU9zPj1+XJd0VQo46nU6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q7tJj+JfWBdt+nWeZjIonJo3rxvFv7v9MKH7jCHgkek=; b=bSIxgYb+YWqIQX6a+yFPKFqkQPTfs2bAnE9tKgkdqWV3MPWPHzck5MFS5FFWwEhyTH74yj+S1HpLLRqcRZdIJa68Nj3W9yWNE2pD5oVZ+5qS4/5Frm5s/AwRtNs62zrkDYU0fEbEKcti5dpix1Ml6LXg4gPJa2jkaZo/P85kaak= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Jason Andryuk To: CC: Jason Andryuk , Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , "Volodymyr Babchuk" Subject: [PATCH 02/23] xen/arm: Factor out construct_hwdom() Date: Thu, 6 Mar 2025 17:03:22 -0500 Message-ID: <20250306220343.203047-3-jason.andryuk@amd.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250306220343.203047-1-jason.andryuk@amd.com> References: <20250306220343.203047-1-jason.andryuk@amd.com> MIME-Version: 1.0 Received-SPF: None (SATLEXMB04.amd.com: jason.andryuk@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PEPF00000149:EE_|DM6PR12MB4482:EE_ X-MS-Office365-Filtering-Correlation-Id: 46f7c239-a419-4e8c-5389-08dd5cfac6d1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|82310400026|36860700013|1800799024; X-Microsoft-Antispam-Message-Info: q1fg9cg7XKdyMssr959HzGbfx3RaN/hjlEE2nlvace4tPqm7cXMXeuYfoX6fLKqvqiPIPTBwKbPnKS3HGIUBXFul57cxXXWJJer72FR0WP/b6XbIX8Lhqwzm/zFO9R8grspwS0+UdzztYGO9jdF4RWzX96R9Ft1rbc4+te5qe1m8sYepruBqgB/pgWEw8K1ZgEBB9NIlfYePaFde6jD8+nrUVshYjYkEvSt2EgkRiQYBTCCgCsoidt11mKzTUzXxidvVM5skomXt2fi/piegZTFQeGLMp97Di/ho1haRYvQWe/ap95IZt+sAxPkyfWcmBuwnl1vjl0yufGzN9e8KZUEDZ/I8WtNjEoiErvj+4kMZ0QAA8i4b1qWyZAvZVWzSCz+LITTpj89iLaVmXLz9ory92oJQdfYWPqZJ+1++tzrUQ44WztWpn7ZohxqDYYeCO3oWI1Vo8GiFUeHfeEjCaOOQuPnrWiW2isUkSlm8eOhpk4mCN+z2jzyCch2RJTIee6A/i+XVnjd9hH8R9N+0VjXdgAz3YRnjWRWp1IpVZDLMWCzBtJlw/GTLqyZ5octLRY/fHR/GUIZ3dlOb4LpBWI9G52H5z0aR8gDueOdvxZojwgy2avlgiWoo0tEnXCC6Qzdn8awG0Sxu7FSqgenY66LMKghQQ/n1kBbZ0GManfhG4nNI2PN0pToYpOElxDMyeGFwHMm0Aod9Gmp5A/dS0n46rgViPFecSW9lm+Thgc2OOdgw2dd7oAiGDrsql+LNnKAo6uKhhAqto+L8aCRzMx9ugj701KT0FEIvLL0K2twPwZd1Pl06iRv6uwz9FMDHueKq2cHSMkX46mz4qib5ZpkgN0zwGGnNPJeDMEwReF3Q0Wr/HLyS0auLN3Tf0rrel4KfG8sV9TkqwH/FJcDtL0iysgTItAxcxNpjFO7GQOYMf5w5LFJ3ny/39FJOg//Vr2HKEORUfrAxJ8iOBdRqxKz8AhtkuFVto+2vqeHmoe+W9iDsbKOdPJ07hs+VMC3+xljHs/ohs4MQIJZBQf+pFxeAn+I11fex7F8yGv1qltGNWLYIFjkhGRqrvFdgX9qlmTDBTUNaZI4xYSvbg+mXPytNTFNSz6HydCF3FXc2RcSKasxouV4OIwWujuTf9GEfOIWCgfDJ4lcLAZD6KfA4DqOthtwqh0gj0i/cFM7AmbSjVMWixRL/yEZZNlNETfFS8OOWK/Ymu/G/iC3KQnQQUnUsaNM7UGlS3lksnZUGWRdoIfEFI6viBq/IAamQcWibbekeCTvHN7t8PTIEn9+VPXykiDJYmojtpDcbCw/Rzwm8nNM84Z0vuI+fRzE58FA9GhtAZkwNK4Nq4nustZCtn9tYA8cQ3gxKcXsg6HTq/WKq71EjYiMPIIcIlARyYzDFCWLFI394OG4KvDbWNvEt/KxswCpWcFBSLPdYO6i8ZBXNMyX8BCdqXA0dIFJnvPeeviBX65+1dzF6gXt/d4QHjQVDi2b/3/OiJUO74yjRrv8= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(82310400026)(36860700013)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2025 22:03:50.2883 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 46f7c239-a419-4e8c-5389-08dd5cfac6d1 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH2PEPF00000149.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4482 Factor out construct_hwdom() from construct_dom0(). This will be re-used by the dom0less code when building a domain with the hardware capability. iommu_hwdom_init(d) is moved into construct_hwdom() which moves it after kernel_probe(). kernel_probe() doesn't seem to depend on its setting. Signed-off-by: Jason Andryuk Reviewed-by: Stefano Stabellini --- xen/arch/arm/domain_build.c | 28 ++++++++++++++++--------- xen/arch/arm/include/asm/domain_build.h | 1 + 2 files changed, 19 insertions(+), 10 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 6784ee6f6d..d676422496 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -2296,8 +2296,6 @@ static int __init construct_dom0(struct domain *d) dom0_mem = MB(512); } - iommu_hwdom_init(d); - d->max_pages = dom0_mem >> PAGE_SHIFT; kinfo.unassigned_mem = dom0_mem; @@ -2307,17 +2305,27 @@ static int __init construct_dom0(struct domain *d) if ( rc < 0 ) return rc; + return construct_hwdom(&kinfo); +} + +int __init construct_hwdom(struct kernel_info *kinfo) +{ + struct domain *d = kinfo->d; + int rc; + + iommu_hwdom_init(d); + #ifdef CONFIG_ARM_64 /* type must be set before allocate_memory */ - d->arch.type = kinfo.type; + d->arch.type = kinfo->type; #endif - find_gnttab_region(d, &kinfo); + find_gnttab_region(d, kinfo); if ( is_domain_direct_mapped(d) ) - allocate_memory_11(d, &kinfo); + allocate_memory_11(d, kinfo); else - allocate_memory(d, &kinfo); + allocate_memory(d, kinfo); - rc = process_shm_chosen(d, &kinfo); + rc = process_shm_chosen(d, kinfo); if ( rc < 0 ) return rc; @@ -2332,7 +2340,7 @@ static int __init construct_dom0(struct domain *d) if ( acpi_disabled ) { - rc = prepare_dtb_hwdom(d, &kinfo); + rc = prepare_dtb_hwdom(d, kinfo); if ( rc < 0 ) return rc; #ifdef CONFIG_HAS_PCI @@ -2340,12 +2348,12 @@ static int __init construct_dom0(struct domain *d) #endif } else - rc = prepare_acpi(d, &kinfo); + rc = prepare_acpi(d, kinfo); if ( rc < 0 ) return rc; - return construct_domain(d, &kinfo); + return construct_domain(d, kinfo); } void __init create_dom0(void) diff --git a/xen/arch/arm/include/asm/domain_build.h b/xen/arch/arm/include/asm/domain_build.h index 5d77af2e8b..134290853c 100644 --- a/xen/arch/arm/include/asm/domain_build.h +++ b/xen/arch/arm/include/asm/domain_build.h @@ -13,6 +13,7 @@ bool allocate_bank_memory(struct kernel_info *kinfo, gfn_t sgfn, paddr_t tot_size); void allocate_memory(struct domain *d, struct kernel_info *kinfo); int construct_domain(struct domain *d, struct kernel_info *kinfo); +int construct_hwdom(struct kernel_info *kinfo); int domain_fdt_begin_node(void *fdt, const char *name, uint64_t unit); int make_chosen_node(const struct kernel_info *kinfo); int make_cpus_node(const struct domain *d, void *fdt); From patchwork Thu Mar 6 22:03:23 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Andryuk X-Patchwork-Id: 14005391 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 12B88C28B23 for ; Thu, 6 Mar 2025 22:04:09 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.904065.1311994 (Exim 4.92) (envelope-from ) id 1tqJJv-00019u-FV; Thu, 06 Mar 2025 22:03:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 904065.1311994; Thu, 06 Mar 2025 22:03:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqJJv-00019j-Ca; Thu, 06 Mar 2025 22:03:59 +0000 Received: by outflank-mailman (input) for mailman id 904065; Thu, 06 Mar 2025 22:03:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqJJu-0000Ss-7q for xen-devel@lists.xenproject.org; Thu, 06 Mar 2025 22:03:58 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2061f.outbound.protection.outlook.com [2a01:111:f403:2412::61f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e5ea909f-fad6-11ef-9ab4-95dc52dad729; Thu, 06 Mar 2025 23:03:57 +0100 (CET) Received: from BN9PR03CA0148.namprd03.prod.outlook.com (2603:10b6:408:fe::33) by SN7PR12MB6744.namprd12.prod.outlook.com (2603:10b6:806:26c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.19; Thu, 6 Mar 2025 22:03:52 +0000 Received: from BN3PEPF0000B373.namprd21.prod.outlook.com (2603:10b6:408:fe:cafe::91) by BN9PR03CA0148.outlook.office365.com (2603:10b6:408:fe::33) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8511.19 via Frontend Transport; Thu, 6 Mar 2025 22:03:52 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN3PEPF0000B373.mail.protection.outlook.com (10.167.243.170) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8549.1 via Frontend Transport; Thu, 6 Mar 2025 22:03:51 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 6 Mar 2025 16:03:51 -0600 Received: from fedora.mshome.net (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Thu, 6 Mar 2025 16:03:50 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e5ea909f-fad6-11ef-9ab4-95dc52dad729 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Mmu++9iWtcrxjaxtS+qalyPjmS9QKKo69Om6ME+4+lC8rNlQeW2VK6bnVSNNfCWO4F4r4mWaWyETH5UfM8vFNQOju3OB++627msih+OASf0xPR9vxoPbSxfPzS92+l3FS5PuRbGyYqjxb0lyQ/rDFwC8kA6JP372ZSfXZl4pFcQItjm4DFcn1gn7ohq/6wo04F3ctvRFJlpD2RHVDnHG3qm1ljqr6K42dZL0Xexc+L80lGdXdSqUHIibUpWl6ynd4SwcOICWeJrxLLUUGDQ7PF4f+i6DfKmuzwxlAwobeC3114QEWOWfF2Y5DSZMwJOEUbAt2280wLzXjCnGjdDUbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4VPQcrgtdmm3+GRmy13JpI5He8WqKvpADWE80W2X34I=; b=sXPFGvqaMwlbLyb8J6c0+jYvuPVAyzyrn7foChJKVWw7lHtN0+i5SPoKvp4CtPdrdeX3rtnpuZZVVJHJi7Z2VXdy8IVUU/XKWce/4puiaF8f9YLXe1y2w74QchOo7eNlp/Hq3sMqDXk1O/79bJ80q52XB4QsgjhZIaN7ZRLCLknIoKy0NBvLxK3JQAVBdag9ne8aJpkuITy8d4a2JsWQVMFxxMKZSqZ1h1o4lFW/viLcu5hzEXuXCf3y4/wambCMBCp3/XpsU7XiNJiQ7TB6M1uZBZX5Ii4Ss0kV6eYtAQ//verToUPPtOdt5khUBT5oPvSS/z81ulXs9buE3N5sVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4VPQcrgtdmm3+GRmy13JpI5He8WqKvpADWE80W2X34I=; b=N9A3tQZJSwgyy+X0Z46fHQFsGdTd1w2MJuBEVxBPTPgU3nRwwNYdfvZSyuZoJC8mv4hlgFL60lIN+SCYbtidtEsAZ/A0g+ARlM28V3sy00TfvQ6nQ2Kb/dT1iYvZ1fcn6pPaYc2QZbFtFnf+5GIca351DfDl3sEQSgdSvn3bAnA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Jason Andryuk To: CC: Jason Andryuk , Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , "Volodymyr Babchuk" Subject: [PATCH 03/23] xen/arm: dom0less hwdom construction Date: Thu, 6 Mar 2025 17:03:23 -0500 Message-ID: <20250306220343.203047-4-jason.andryuk@amd.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250306220343.203047-1-jason.andryuk@amd.com> References: <20250306220343.203047-1-jason.andryuk@amd.com> MIME-Version: 1.0 Received-SPF: None (SATLEXMB03.amd.com: jason.andryuk@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B373:EE_|SN7PR12MB6744:EE_ X-MS-Office365-Filtering-Correlation-Id: 83b07267-253d-4b74-4f8d-08dd5cfac79c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|1800799024|376014|82310400026; X-Microsoft-Antispam-Message-Info: c4UuEoFjiJW6Bc8/f9iiVO6ZDEGG6alOa5MdRcdxoM5RvsrSGgJjiqYpEJOj7PG/jOpgab4HeoVATtOZ7ZrwEgbtv3AHDHhU7vs8YzNGN2WYoHPrCguhnvy7IkEoQn+CzYKdwWHq6Cr7iA/ZMUQZEJweoW7ESKE091XRNdyd0Xvwiyjgy3qUZSruBtSJccBkGI8hwecFbXCPR6e8zjlKMQSyOhSHGQZqmzdVWTkcuVEasH7azZp25UUtxHOG8vhm2AoIF9DtFG9bJZxHzsXDNMMdvX9GCYrvRcZKoa4u/tdDWY/lC22MJv/1kmHXmvCMwEpkNJeNMuISzpOpuHfyOFGvWc2pRI9tZu7pqq3x80qscdbyNpev2DmSS0ZnuiNPy14bkjx8XJYioYJPwUoSwUSNSaNFS7AAvTRolQyyRvU18y9t8qq3caq6QlbHgwpgfYu8mPawmWhfaHLOqXwwu9UbJVH9cgP2y8c1ueY/riMZEKCavcbPDx4Vz5xU1bUmYOdcPkrKEJ4KBQABqZksRoJcXC9uyxfLsSmeLaY6vAZ5dKImTVIK/lI0+VGh+2cU7mrtgGl/pkeXrcuzQnDg0ow2nBXrEIrLGHlSq/CNhYFHg47TWU1hsd3hbc0gsnxHx6SkehP/riJy5XFYtZvRB2VnnARw34DgUL70t3JYlNeuBya5dO2lOLZznhpCpWwfH5Y+mjcOrygVHFEtD3XadFQ/h9ass4MCHMiS01MLU68l3H2+/brHuop+P00ZvM5Nv0crhc/PPaMOvzscERrumsgAmP2rWAk2pWrH+SEZZpEPboYvJp3wn+WS79J0eOQuDCZquOK3I9KT0TKwDocjFMGVO1H3u32sp7wiWcznQroB9ZBe5PsglOF/M93oIotNueKNUKeCvQXnKEI6HJ0uM63EmoMrxYhgtG8CXp3j2O6cl1/7QiD+HVmuLxIJk6+8HuI33tRZwOf9fOARpWqcuur9gtGmlo0OhBYQJVlIDALND+cvclvOrwc4Mpv9Qk2earNwIbCxnBE79DY9/VXvK1PkME3BFKOyT2fMCNyn3GHJWOG2Pd8fbbTXLXiGfmblE/T8sI6OyCOi21+XHItDarPvkWBaHE/jjxZgr1rrScZ2Ajxlz8B0mIZD4Cy8hXDOKG9V3uLKlWobIf48hmo0UCE2cAQFX7a6Iha4EA0fHaxJ3OyMsW2t6n0CeJYYnb1S7rjbNPBoF/thbxcjmmKrOxXsKDaSGwRnB4c7Cmg+3AcNTpf8qpZflwUDxH0eNCSgo5Qws9zOW3Bl+a4bLhe53YkoBXVKoLPyr2WlQ4HVkRL0JzZ8GfukU7Q1oFs2VHLF4aZjXXXM2tx8oUVcJBgs1GO2UdjIE1dMKNweXyiqFxsqshyme5QEQB9bReSPuZ7EYx1OcLN2aa2KYd7y12LN0i+Kr6B9NyaTba5iHNz9VycWNx8JZlzDDn53eOOvuc3D X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(1800799024)(376014)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2025 22:03:51.6500 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 83b07267-253d-4b74-4f8d-08dd5cfac79c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B373.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6744 When creating a hardware domain, have the dom0less code call construct_hwdom() which is shared with the dom0 code. The hardware domain requires building that best matches the dom0 build path. Re-use it to keep them in sync. The device tree node of the dom0less config is now passed into construct_hwdom(). dom0 uses /chosen for process_shm while a hwdom will use the value from its dom0less device tree node. Signed-off-by: Jason Andryuk --- xen/arch/arm/dom0less-build.c | 57 ++++++++++++++----------- xen/arch/arm/domain_build.c | 10 +++-- xen/arch/arm/include/asm/domain_build.h | 3 +- 3 files changed, 42 insertions(+), 28 deletions(-) diff --git a/xen/arch/arm/dom0less-build.c b/xen/arch/arm/dom0less-build.c index 31f31c38da..e539bcc762 100644 --- a/xen/arch/arm/dom0less-build.c +++ b/xen/arch/arm/dom0less-build.c @@ -911,36 +911,45 @@ static int __init construct_domU(struct domain *d, /* type must be set before allocate memory */ d->arch.type = kinfo.type; #endif - if ( !dt_find_property(node, "xen,static-mem", NULL) ) - allocate_memory(d, &kinfo); - else if ( !is_domain_direct_mapped(d) ) - allocate_static_memory(d, &kinfo, node); - else - assign_static_memory_11(d, &kinfo, node); - - rc = process_shm(d, &kinfo, node); - if ( rc < 0 ) - return rc; - - /* - * Base address and irq number are needed when creating vpl011 device - * tree node in prepare_dtb_domU, so initialization on related variables - * shall be done first. - */ - if ( kinfo.vpl011 ) + if ( is_hardware_domain(d) ) { - rc = domain_vpl011_init(d, NULL); + rc = construct_hwdom(&kinfo, node); if ( rc < 0 ) return rc; } + else + { + if ( !dt_find_property(node, "xen,static-mem", NULL) ) + allocate_memory(d, &kinfo); + else if ( !is_domain_direct_mapped(d) ) + allocate_static_memory(d, &kinfo, node); + else + assign_static_memory_11(d, &kinfo, node); - rc = prepare_dtb_domU(d, &kinfo); - if ( rc < 0 ) - return rc; + rc = process_shm(d, &kinfo, node); + if ( rc < 0 ) + return rc; - rc = construct_domain(d, &kinfo); - if ( rc < 0 ) - return rc; + /* + * Base address and irq number are needed when creating vpl011 device + * tree node in prepare_dtb_domU, so initialization on related variables + * shall be done first. + */ + if ( kinfo.vpl011 ) + { + rc = domain_vpl011_init(d, NULL); + if ( rc < 0 ) + return rc; + } + + rc = prepare_dtb_domU(d, &kinfo); + if ( rc < 0 ) + return rc; + + rc = construct_domain(d, &kinfo); + if ( rc < 0 ) + return rc; + } domain_vcpu_affinity(d, node); diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index d676422496..00bc484642 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -2305,10 +2305,11 @@ static int __init construct_dom0(struct domain *d) if ( rc < 0 ) return rc; - return construct_hwdom(&kinfo); + return construct_hwdom(&kinfo, NULL); } -int __init construct_hwdom(struct kernel_info *kinfo) +int __init construct_hwdom(struct kernel_info *kinfo, + const struct dt_device_node *node) { struct domain *d = kinfo->d; int rc; @@ -2325,7 +2326,10 @@ int __init construct_hwdom(struct kernel_info *kinfo) else allocate_memory(d, kinfo); - rc = process_shm_chosen(d, kinfo); + if ( node ) + rc = process_shm(d, kinfo, node); + else + rc = process_shm_chosen(d, kinfo); if ( rc < 0 ) return rc; diff --git a/xen/arch/arm/include/asm/domain_build.h b/xen/arch/arm/include/asm/domain_build.h index 134290853c..17619c875d 100644 --- a/xen/arch/arm/include/asm/domain_build.h +++ b/xen/arch/arm/include/asm/domain_build.h @@ -13,7 +13,8 @@ bool allocate_bank_memory(struct kernel_info *kinfo, gfn_t sgfn, paddr_t tot_size); void allocate_memory(struct domain *d, struct kernel_info *kinfo); int construct_domain(struct domain *d, struct kernel_info *kinfo); -int construct_hwdom(struct kernel_info *kinfo); +int construct_hwdom(struct kernel_info *kinfo, + const struct dt_device_node *node); int domain_fdt_begin_node(void *fdt, const char *name, uint64_t unit); int make_chosen_node(const struct kernel_info *kinfo); int make_cpus_node(const struct domain *d, void *fdt); From patchwork Thu Mar 6 22:03:24 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Andryuk X-Patchwork-Id: 14005392 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 405EBC282EC for ; Thu, 6 Mar 2025 22:04:09 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.904066.1312004 (Exim 4.92) (envelope-from ) id 1tqJJw-0001PL-Oc; Thu, 06 Mar 2025 22:04:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 904066.1312004; Thu, 06 Mar 2025 22:04:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqJJw-0001PA-Kl; Thu, 06 Mar 2025 22:04:00 +0000 Received: by outflank-mailman (input) for mailman id 904066; Thu, 06 Mar 2025 22:03:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqJJu-0000Ss-KP for xen-devel@lists.xenproject.org; Thu, 06 Mar 2025 22:03:58 +0000 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2060c.outbound.protection.outlook.com [2a01:111:f403:2405::60c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e6811f38-fad6-11ef-9ab4-95dc52dad729; Thu, 06 Mar 2025 23:03:58 +0100 (CET) Received: from IA1P220CA0003.NAMP220.PROD.OUTLOOK.COM (2603:10b6:208:461::9) by SJ0PR12MB8613.namprd12.prod.outlook.com (2603:10b6:a03:44d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.17; Thu, 6 Mar 2025 22:03:54 +0000 Received: from BN3PEPF0000B370.namprd21.prod.outlook.com (2603:10b6:208:461:cafe::e3) by IA1P220CA0003.outlook.office365.com (2603:10b6:208:461::9) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8511.18 via Frontend Transport; Thu, 6 Mar 2025 22:03:53 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN3PEPF0000B370.mail.protection.outlook.com (10.167.243.167) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8549.1 via Frontend Transport; Thu, 6 Mar 2025 22:03:53 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 6 Mar 2025 16:03:52 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 6 Mar 2025 16:03:51 -0600 Received: from fedora.mshome.net (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Thu, 6 Mar 2025 16:03:51 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e6811f38-fad6-11ef-9ab4-95dc52dad729 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KDdLn3x0xZvWp+BBu29v9ubuzXeNuoS7x6Ggq836IbwpRfbgj38URBKEWJb4qkcR+skGpeI/djs/6xhQnEuaP14msJ2vGJbOvE1QhphCt4UJRfFyWQ7dDZNhc1lQOzIoZJ8qCSWkF9iF/7cX8YGHuqSS3eH9UL9wKgMxAtDtQer7JMPc18mSSRHSK5D+UJwGy/KbIYb+snq546OtI1YvhTxBsJArG6Q54Tza+wxlr7CYBthZIc7fDRG9L9P57PPHMnC2atuTWF/dZAq1f6341Sw+lfJXs8u7+ESBbfSUw30EXhEROwVK0L0/is5EeGKgOWL7n0PhqVzc+UhiXw/9cQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=obVZmGGT/+U9RfcJU0aGZukVfIOb/dDv2A9zwFbu3y8=; b=lx3o9g93VzlKwzQI3pmHR6yG02kBe+xqIr0xev76H2TshxW1Y/iFMGR9AyWieRqn81HRGadtZQhNKXKovBwE2ZHyBcLtMqZsWorVUdcZrmX2lncbGVtmpGXthEdem3JWAXa32NrbVY5X/zI8oixtFYnRT2omHbQ8XU7Oi7iU6Y9fE3HoB1asFSOYKj5ScI3BGaf603jgeGVlt4qPq8GrzEAVa1rVjdhs6rFMMsf/+YpVrlWvbkQ2YvaNIIBqTsCiuRjAhyGFaLBZA/QQaESdfnDFyTSUfyWD1fqisUnQKhpzsDj+PAFVMNf6Y0fZ6JjlcNTYD5BtwS2/pKknZy21RQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=obVZmGGT/+U9RfcJU0aGZukVfIOb/dDv2A9zwFbu3y8=; b=VgDOdxziE5avzH8Jr9pRgUlaS3P8Vji+++TVQmeEDf/g7WqxLztfS3etvr+5yx+DskBX/qfm/+2TpvF6JgwLtgQz3TlOU2PCi57MIrLId7FB6Npfq4mNAc+Jt1UK7Ejqi5yg04+XhyYXssmHrVNmohXB5YleHKHYupdgY5Bv0Zw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Jason Andryuk To: CC: Jason Andryuk , Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , "Volodymyr Babchuk" Subject: [PATCH 04/23] xen/arm: dom0less use domid 0 for hwdom Date: Thu, 6 Mar 2025 17:03:24 -0500 Message-ID: <20250306220343.203047-5-jason.andryuk@amd.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250306220343.203047-1-jason.andryuk@amd.com> References: <20250306220343.203047-1-jason.andryuk@amd.com> MIME-Version: 1.0 Received-SPF: None (SATLEXMB05.amd.com: jason.andryuk@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B370:EE_|SJ0PR12MB8613:EE_ X-MS-Office365-Filtering-Correlation-Id: 887ec4ab-1538-41c1-2ed5-08dd5cfac86c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|1800799024|36860700013; X-Microsoft-Antispam-Message-Info: QozOmfS1LK8WEXSkjRxc3wsUaZp2sUZm9wzF0A+wSfRzTjKjKlBcw3CTzxyH2w/tEoqK7M/dduksUsJhRrEObCfcvVZWbEXGQzULazfN5WR54REXovLu6Iy9BeSwE+nVCLGBjCocO3vpiDy9kfnkVRzvpVQkBZeXqngFMm9AR7mIJdJolEgZeDVY9MJP6ppfV5U7fSXofAd1cHLr68tMrdcZ48nRXTDikZAlncxnoPnfGMOlOOQZmjH8f0gIOcKhLjAhvqZ7GGmkRDaJIflzPEKbs6X80hGgwLFpr3K51MMrnF9pfYFhN+sweX3whepu8jBWiRWhvegY80ifauVIwn14hTXFlayqD1YfW7tO2Ua+AujVzvfEe7FakUPzW/GEmt3lfNVTVvByFCYzF1kHk+dUDhWFg9f+ukSyeE6/jdrH6hlXoMcs7pShCcodl8FTneyV7nqU0Dl47Y+LKl1I6lTzLSbNZ+cXjeGRt/9vaTjZSOdQEY3jEzAfIQr0Xay03f4qrl4kyqAZ/upopIEUPLTYy/wUtmxjyxEyeth8aJ19dN2XcAjmh7mI9lyu3HJeZNc94xApoUMejlOZUw+D+V/kVk6J2yIjLeIjGLH/kHtIyu8T/fKwZlFKsXnDCI5rijUBg9KdQCpVy+ML2mZ9GE2u7fxelgJ4zzz+Q/3wUc80i8+PZo52iPRcsonkAmaAZ283c9q+o29/x5giwT5CRk+5vdsjEuYpTcywCQ+T8vTHsXRx8zp5TIP01OlEI/m5ejP/qxE5efYPoPtNHkkabA4nzUUYdU63AbzCstVK32XxGNtw2BmMyiB708E58RnvN6g/T9npdcnVfRmnB/GjXoxTDuUm53hHIXr84u1ndVgMFF0Z4R4Mi+V72hBT8IvSuKf6vq/+GpGH3WxnJMa1tnDIh+rKS13mHnZoXhIDU/mNxYn8VoSSbsWOpCAVwU5Rm92w7LiYuIk65PB5IOneYZn8pxEr072g4+9QGxi7rGzRETWqvQ4IQyyxOFlymT7//8DO152ikDcldIe/dq5+Pc9asv8uw+spD31Q8dc5YSJZjDJtRo8+dR00GQ+WDrxPuFT9LqkthcrV5sCko0UjAici0evlvJKYjCeDuCraggp8kCaZj67QdcS1xjJxOqfUACrOLTrfBjDxECOJOmjkQ04LcyKbVDhNrhvyhcO3ARgGbXPi8hUwxXScrEd0rE/NiILfGMCmMb/tvcrWbUb2euMIf3xyGIfbsOcZKZyhgkEZoJWZJ+QhiMKsXFrazLAOU4VkRDOug88pqd0kM4eq3ncFEEtqnzyRg9nIlR1LEnLC+7f1KRXDaNshfdj28lTNtaN4Rw+WehE2AAGOJv+mGDyP6EMjo20ameNT0fsaR9VeC3UZAFziwJ03aBRpqA23v8Z/cSFRL2fsDoYxSzDN+9BeCxnHQ5Pf1Q5kE6qNQEwIUyLc16ylnWAUIawJ8z6gHWDobcOJfGJ+itglkuCCVtWIXzOPp7taeRyvhjqlUPo= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(376014)(1800799024)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2025 22:03:53.0122 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 887ec4ab-1538-41c1-2ed5-08dd5cfac86c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B370.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB8613 Assign domid 0 to the hwdom. Normally, dom0less does not use domid 0. This fixes using the Xen console which assumes domid 0 to use the hypercall interface. Signed-off-by: Jason Andryuk --- xen/arch/arm/dom0less-build.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/dom0less-build.c b/xen/arch/arm/dom0less-build.c index e539bcc762..5a7871939b 100644 --- a/xen/arch/arm/dom0less-build.c +++ b/xen/arch/arm/dom0less-build.c @@ -969,6 +969,7 @@ void __init create_domUs(void) dt_for_each_child_node(chosen, node) { struct domain *d; + domid_t domid; struct xen_domctl_createdomain d_cfg = { .arch.gic_version = XEN_DOMCTL_CONFIG_GIC_NATIVE, .flags = XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap, @@ -1121,7 +1122,12 @@ void __init create_domUs(void) * very important to use the pre-increment operator to call * domain_create() with a domid > 0. (domid == 0 is reserved for Dom0) */ - d = domain_create(++max_init_domid, &d_cfg, flags); + if ( flags & CDF_hardware ) + domid = 0; + else + domid = ++max_init_domid; + + d = domain_create(domid, &d_cfg, flags); if ( IS_ERR(d) ) panic("Error creating domain %s (rc = %ld)\n", dt_node_name(node), PTR_ERR(d)); From patchwork Thu Mar 6 22:03:25 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Andryuk X-Patchwork-Id: 14005396 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A92D4C28B26 for ; Thu, 6 Mar 2025 22:04:11 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.904068.1312014 (Exim 4.92) (envelope-from ) id 1tqJK0-0001kP-53; Thu, 06 Mar 2025 22:04:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 904068.1312014; Thu, 06 Mar 2025 22:04:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqJK0-0001kE-25; Thu, 06 Mar 2025 22:04:04 +0000 Received: by outflank-mailman (input) for mailman id 904068; Thu, 06 Mar 2025 22:04:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqJJy-0000St-Oo for xen-devel@lists.xenproject.org; Thu, 06 Mar 2025 22:04:02 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on20620.outbound.protection.outlook.com [2a01:111:f403:2413::620]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e81662a5-fad6-11ef-9898-31a8f345e629; Thu, 06 Mar 2025 23:04:00 +0100 (CET) Received: from CH2PR18CA0003.namprd18.prod.outlook.com (2603:10b6:610:4f::13) by SJ2PR12MB8884.namprd12.prod.outlook.com (2603:10b6:a03:547::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.16; Thu, 6 Mar 2025 22:03:55 +0000 Received: from CH2PEPF00000143.namprd02.prod.outlook.com (2603:10b6:610:4f:cafe::72) by CH2PR18CA0003.outlook.office365.com (2603:10b6:610:4f::13) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8511.19 via Frontend Transport; Thu, 6 Mar 2025 22:03:55 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CH2PEPF00000143.mail.protection.outlook.com (10.167.244.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8511.15 via Frontend Transport; Thu, 6 Mar 2025 22:03:54 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 6 Mar 2025 16:03:53 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 6 Mar 2025 16:03:53 -0600 Received: from fedora.mshome.net (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Thu, 6 Mar 2025 16:03:52 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e81662a5-fad6-11ef-9898-31a8f345e629 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Rg2a+Tpdr9MS1pzpHLmBtkOQA/ya2iDl12TPmzvEEmZCTZjiD3xsW2HAVeOP4eFkpWC718Rh5cX9FAFZXNTxj2JuyM4qYbIYxg0u/z4fmIccnBvAIzhqA0GyK5lhlHcoy8FULQCVxN3J+dyzvhfsycqBMy+4pdoxEnveOvYkb8zdiIDqxjFfs+wMsTG/hsc94v/MRSb5z3ihiAcmfmQ2tVGFXB0c/y/SRJTcjvcfzxJ4NZl5AQ6PzP6XTPWF2zzRu/xyrKN7wVuu2ZGBgCBDs91hgkOETWdaN96Xe3prZFRlahMrewNpEAXEAd1Rq5mV9DXAdi8Dnww6a889nr4eXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UsrTljo/Xl74FfKJIV3xkZWBNdEYe7y2ZdvEGquW2p8=; b=GlMywsA8Ncw1po0RLO4DJrl9hPz17yB7Mln8lSNT5HNnoKQe3cKk85ZcQpH/CnUzmOinRq7XAnH2ZvFdFHyd/xYmjfJPlQO8fnFz2qeAyi+GQPIavjgHjBk+cLLAq46A9gpM/SJydvEg5yydKRquEs9KShEShykzyKU9EkO9i2I5+q2mSNlBGXOF7d78RxsHcfvY0kHUoVsrBhE4LvcR4l0HiLgcLdT2c1hOYR+fwXfPjIfF6zOfuqthIxkWPyHXydCzRD47FZBIxckEjxNKpDbuJgNjviZQxkoHXF9TXQHpJbVOCzDxvDx5cHwyhNBRkTjlbfPR5hweH9xEY/4b9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UsrTljo/Xl74FfKJIV3xkZWBNdEYe7y2ZdvEGquW2p8=; b=fnS6g7+clfMVEP0JSbqJFBF/C8hAzg178oqVBdMOHk3oxcbHcdwX3glgRDGUVUyw8hnXWPQSiuXtu/I5hCLeut9LK1GxLBTmC3SdDVW1pMkD8HGFUrDQ9thep2ujEEch+2u6nfLL3HhvALoHYNRuch4M2kxmIbXTp/Rsgi+rzyQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Jason Andryuk To: CC: Jason Andryuk , Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , "Volodymyr Babchuk" , Andrew Cooper , Anthony PERARD , "Jan Beulich" , =?utf-8?q?Roger_Pau_Monn=C3=A9?= Subject: [PATCH 05/23] xen/arm: Add capabilities to dom0less Date: Thu, 6 Mar 2025 17:03:25 -0500 Message-ID: <20250306220343.203047-6-jason.andryuk@amd.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250306220343.203047-1-jason.andryuk@amd.com> References: <20250306220343.203047-1-jason.andryuk@amd.com> MIME-Version: 1.0 Received-SPF: None (SATLEXMB05.amd.com: jason.andryuk@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PEPF00000143:EE_|SJ2PR12MB8884:EE_ X-MS-Office365-Filtering-Correlation-Id: 8a514310-25fe-4496-949d-08dd5cfac943 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|36860700013|82310400026|1800799024; X-Microsoft-Antispam-Message-Info: hUqfmBXhOwfgJr7RUC78hfWjo3iXR+seiVStT/ou3UcJWN5ckUDmwsg4b0LBLK5GTWz0hOyB/y7RsJIGKIahW4wl3EUtIkdGCeucwGhbnIrajTHClTPaR1t85R4boBWr/OUYJ50KrqA/INoZJ4Xtl6Ckm01nZUm3x5gK0LPUtAfWDGfuvLgc3QtQqy7c6oPiSrPhAPPHjfzPeRLS0z3yShYUUYCQpTAyqbRSIF62/H+Db5fl7ryavJNNux3YOQrrlnja8x9DzJ/JLqMAWgHOK0gumPsmdMq98R9EIaEj2VRaHVuEK6Sv5z97cM2agomjfn/5AV2jAGJpbvTG5/QTNludnjKsgNwHhFsxiS2Oo7w/oUu9c5EX2PIprvnOpWanpUFZ9XcBo4ixChsGAJYHly9X8dUdGyiXZuTWTSKTBC7uI8aDnltndQtg+VszkoCJo8PckIrImxFjdMd0e9DJk30piBamJL4ThsPZS9TaouVYyYVe/7ISspXO0x3++2Nb+Nh21EbQq6Ail8NKx795pCxoxuyvWE2S382hCx4udC/XPkWfGabKQAMTafnupkFy8pY6OUYMir9pAojSRp0qS5p9+e4sAl/bsjmtpdooqh7T7LJR6/KDU9Rt2bBV7w8f165lRr+oe6xh7UizUjewXVqJLlg6OZGu82zFHI9o/lHTI/xGQRB5AsG67RFHFipDHMv/Kt2GIdZdDpjUT4kFmliM/EvBpsM6MkKSHmcDcSnbEhOEHVEmHAXKGimrlQeLgu/06Tbwu3hLDe615WAZNgqBTzyPB1gHbdkKHn/FRogfLMqRi86k6bzvOcl859Z63iNHwHwi1ERBbxSvlIi2ajUKfjdQsKnWCOW5MQcJT55Px/RCmAT2SBb1I2PckwLUu/ooX6PdKTpCvHXNOPj404QoEd6in0goWkOdXgNsNptW4Cl7Ks324k+kGuklQMxkQ+W3Rhx/u0S3KFoFI/3JBuAiC0Rt2OOaAg4MUhEdc2Fb/4wGuNczJ8tFY4x0d+c0i/m7xj0v3E0a4VZO/oB5Ka49MzqDNZPDd6dpGtFwtls7Eu5JQ+3a5lOZyLjrgoSc5U5S67gf75v290bJIDyTZ6xbGaYbVoWc8g4vsbhywWpd0wlUN1M/cMqxWZX4Ivba47Gm0wsRF4LmHAeBsLgBB1WDCCERed/NwdTfSzqJtH+JDscqbMaJZs/qQB94Z+fYIbpa/Q6565ohwc3WfjV/xatCYX7XNkmi8K8/kc1SLcjvQiVw9fliUTMw0Uigrch9QQ+uV7/tSZ9q1hXNqLe/Q2oh1cDk3mZY2PV7XnDogzZAYvZrPVASkRCCk29KwMMZWjYaEYg9KRBXmRnjA6MdiHgQ2chNwGu2kKuXlXKfSGuM1XEwbMlf768n8yWt0opzyvAF4za/eR/GWf5WlcBHsSvKB/Z4bpTFiQikMnboTsIM/rAvUyOqn+LZV+fkKvEgOrfHGsbZTttXbG9kM4uvlXoQyX9i82jZjhOTcdGTQkY= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(36860700013)(82310400026)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2025 22:03:54.4082 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8a514310-25fe-4496-949d-08dd5cfac943 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH2PEPF00000143.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8884 Add capabilities property to dom0less to allow building a disaggregated system. Introduce bootfdt.h to contain these constants. When using the hardware or xenstore capabilities, adjust the grant and event channel limits similar to dom0. Also for the hardware domain, set directmap and iommu. This brings its configuration in line with a dom0. Signed-off-by: Jason Andryuk --- There is overlap with hyperlaunch. The numeric values are the same. Hyperlaunch doesn't expose the values in a public header as done here. Is this to be expected for dom0less? It seems most of dom0less isn't in a header, but just in docs. Hyperlaunch uses BUILD_CAPS_, but I chose DOMAIN_CAPS_ since there are domain-level capabilities. Only a single xenstore and hardware domain make sense. A check to limit to only a single hardware domain is in place - building two breaks. But nothing prevents the dom0less configuration from only having multiple xenstore domains. Each xenstore domain would have slightly more permissions, but only the last one would be used. --- docs/misc/arm/device-tree/booting.txt | 11 ++++++++++ xen/arch/arm/dom0less-build.c | 29 +++++++++++++++++++++++++++ xen/arch/arm/domain.c | 3 ++- xen/include/public/bootfdt.h | 27 +++++++++++++++++++++++++ 4 files changed, 69 insertions(+), 1 deletion(-) create mode 100644 xen/include/public/bootfdt.h diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt index ac781c9cc8..490c792ddf 100644 --- a/docs/misc/arm/device-tree/booting.txt +++ b/docs/misc/arm/device-tree/booting.txt @@ -167,6 +167,17 @@ with the following properties: Refer to docs/misc/cache_coloring.rst for syntax. This option is applicable only to Arm64 guests. +- capabilities + Optional. A bit field of domain capabilities for a disaggregated + system. A traditional dom0 has all all of these capabilities, and a + domU has none of them. + + 0x1 DOMAIN_CAPS_CONTROL - A privileged, control domain + 0x2 DOMAIN_CAPS_HARDWARE - The hardware domain - there can be only 1 + 0x4 DOMAIN_CAPS_XENSTORE - The xenstore domain - there can be only 1 + + The default is no capabilities. + - vpl011 An empty property to enable/disable a virtual pl011 for the guest to diff --git a/xen/arch/arm/dom0less-build.c b/xen/arch/arm/dom0less-build.c index 5a7871939b..068bf99294 100644 --- a/xen/arch/arm/dom0less-build.c +++ b/xen/arch/arm/dom0less-build.c @@ -12,6 +12,7 @@ #include #include +#include #include #include @@ -994,6 +995,34 @@ void __init create_domUs(void) if ( (max_init_domid + 1) >= DOMID_FIRST_RESERVED ) panic("No more domain IDs available\n"); + if ( dt_property_read_u32(node, "capabilities", &val) ) + { + if ( val & ~DOMAIN_CAPS_MASK ) + panic("Invalid capabilities (%"PRIx32")\n", val); + + if ( val & DOMAIN_CAPS_CONTROL ) + flags |= CDF_privileged; + + if ( val & DOMAIN_CAPS_HARDWARE ) + { + if ( hardware_domain ) + panic("Only 1 hardware domain can be specified! (%pd)\n", + hardware_domain); + + d_cfg.max_grant_frames = gnttab_dom0_frames(); + d_cfg.max_evtchn_port = -1; + flags |= CDF_hardware; + flags |= CDF_directmap; + iommu = true; + } + + if ( val & DOMAIN_CAPS_XENSTORE ) + { + d_cfg.flags |= XEN_DOMCTL_CDF_xs_domain; + d_cfg.max_evtchn_port = -1; + } + } + if ( dt_find_property(node, "xen,static-mem", NULL) ) { if ( llc_coloring_enabled ) diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c index 3ba959f866..dc4b4e84c1 100644 --- a/xen/arch/arm/domain.c +++ b/xen/arch/arm/domain.c @@ -608,7 +608,8 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config) { unsigned int max_vcpus; unsigned int flags_required = (XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap); - unsigned int flags_optional = (XEN_DOMCTL_CDF_iommu | XEN_DOMCTL_CDF_vpmu); + unsigned int flags_optional = (XEN_DOMCTL_CDF_iommu | XEN_DOMCTL_CDF_vpmu | + XEN_DOMCTL_CDF_xs_domain ); unsigned int sve_vl_bits = sve_decode_vl(config->arch.sve_vl); if ( (config->flags & ~flags_optional) != flags_required ) diff --git a/xen/include/public/bootfdt.h b/xen/include/public/bootfdt.h new file mode 100644 index 0000000000..4e87aca8ac --- /dev/null +++ b/xen/include/public/bootfdt.h @@ -0,0 +1,27 @@ +/* SPDX-License-Identifier: MIT */ +/* + * Xen Device Tree boot information + * + * Information for configuring Xen domains created at boot time. + */ + +#ifndef __XEN_PUBLIC_BOOTFDT_H__ +#define __XEN_PUBLIC_BOOTFDT_H__ + +/* Domain Capabilities specified in the "capabilities" property. Use of + * this property allows splitting up the monolithic dom0 into separate, + * less privileged components. A regular domU has no capabilities + * (which is the default if nothing is specified). A traditional dom0 + * has all three capabilities.*/ + +/* Control/Privileged domain capable of affecting other domains. */ +#define DOMAIN_CAPS_CONTROL (1 << 0) +/* Hardware domain controlling physical hardware. Typically providing + * backends to other domains. */ +#define DOMAIN_CAPS_HARDWARE (1 << 1) +/* Xenstore domain. */ +#define DOMAIN_CAPS_XENSTORE (1 << 2) +#define DOMAIN_CAPS_MASK (DOMAIN_CAPS_CONTROL | DOMAIN_CAPS_HARDWARE | \ + DOMAIN_CAPS_XENSTORE) + +#endif /* __XEN_PUBLIC_BOOTFDT_H__ */ From patchwork Thu Mar 6 22:03:26 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Andryuk X-Patchwork-Id: 14005399 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3CD1FC28B25 for ; Thu, 6 Mar 2025 22:04:17 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.904073.1312046 (Exim 4.92) (envelope-from ) id 1tqJK4-0002by-Aw; Thu, 06 Mar 2025 22:04:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 904073.1312046; Thu, 06 Mar 2025 22:04:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqJK4-0002aA-4U; Thu, 06 Mar 2025 22:04:08 +0000 Received: by outflank-mailman (input) for mailman id 904073; Thu, 06 Mar 2025 22:04:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqJK2-0000Ss-Aa for xen-devel@lists.xenproject.org; Thu, 06 Mar 2025 22:04:06 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2062b.outbound.protection.outlook.com [2a01:111:f403:2414::62b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ea70cf98-fad6-11ef-9ab4-95dc52dad729; Thu, 06 Mar 2025 23:04:03 +0100 (CET) Received: from BL0PR02CA0067.namprd02.prod.outlook.com (2603:10b6:207:3d::44) by SJ0PR12MB6880.namprd12.prod.outlook.com (2603:10b6:a03:485::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.28; Thu, 6 Mar 2025 22:03:57 +0000 Received: from BN3PEPF0000B36D.namprd21.prod.outlook.com (2603:10b6:207:3d:cafe::b9) by BL0PR02CA0067.outlook.office365.com (2603:10b6:207:3d::44) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8511.16 via Frontend Transport; Thu, 6 Mar 2025 22:03:56 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN3PEPF0000B36D.mail.protection.outlook.com (10.167.243.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8549.1 via Frontend Transport; Thu, 6 Mar 2025 22:03:56 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 6 Mar 2025 16:03:55 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 6 Mar 2025 16:03:54 -0600 Received: from fedora.mshome.net (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Thu, 6 Mar 2025 16:03:54 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ea70cf98-fad6-11ef-9ab4-95dc52dad729 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jCdpWR6pP4yjaOBZgGwDtmjnJPrwj/1WPNQTOYRUvNuSXKxdXjs/I8SStc3S5i3f2JuSOgAq/+tOE3HMZpei3RLxufvBB2LzT4S/YczS0ZmFCHx2y5eWpuiyl4oZpk7jA8xflRKLAkpQmjAO2gtNA0GDo1v+sdWB3cttiW0ybVAB725E1aMqY+lKhTrTAvLamHFfD09Pe1SDF+nmy8eCuVCY/KOcSdCBFxn7trVcD3y/r4prFXANux+6kFgbJrSyDFA6jcAEO/ujhvYpcz2WAmv6t6g1f43HbaegW7coX0rkdo/KDYiDQrPPJ5KVkxA0bpvN0xlwbMmVqv/OdsUqUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gxRTK5sPthCjce7F1tIG5rxl4Y3DZmkzwFsUXndn8/c=; b=n3zxn8/UkaQ0WSdgCx4GfmlgF1oCDQISXhLiBA+BxIgK1EZQvps8Lu2lPyM/ByRyXp2rTT7UvEcVs8qbEj7kaTnuPTcqH37rfCt5o66zoG6RbYaansvayXmSUnFe+komby/4RHmyCvGclhaUbSJKCAdrO4SatrLXjAwMPa/2kNgiij0Kdl0qzm/o6MKrJJi0/szk0hkKfbVtBhue5Hfm4XTp3uPwj2Ua7TUp1FGWXBWHHfe76fG0F+hIwjfYjTxcotMipI+eWEY4GDWONjnGEBbjsJNplWOcpJo6qm3itxEWrqUyEybuUr902XetyhPbEbXQ8VMS5LzIYNv4pnGKew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gxRTK5sPthCjce7F1tIG5rxl4Y3DZmkzwFsUXndn8/c=; b=WH0GSUGCnXgrKL3QFzmn/8q040fQQTTnfv4T2OgbL+KsyujZlDxA6k9dVv8susjDj77L8PN+vo+3EskT6F3hcmfPmG2PH7HzcvZX6TyGqISnZjhfvByzHbbgceiEtoLG0k5dPieJrvF0rvo3ahwYKOAAphmsTi7qkIcNOd1NifQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Jason Andryuk To: CC: Jason Andryuk , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , "Julien Grall" , =?utf-8?q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini Subject: [PATCH 06/23] xen/domctl: Expose privileged and hardware capabilities Date: Thu, 6 Mar 2025 17:03:26 -0500 Message-ID: <20250306220343.203047-7-jason.andryuk@amd.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250306220343.203047-1-jason.andryuk@amd.com> References: <20250306220343.203047-1-jason.andryuk@amd.com> MIME-Version: 1.0 Received-SPF: None (SATLEXMB05.amd.com: jason.andryuk@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B36D:EE_|SJ0PR12MB6880:EE_ X-MS-Office365-Filtering-Correlation-Id: 197b53d0-10cd-4907-489a-08dd5cfaca48 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|36860700013|82310400026; X-Microsoft-Antispam-Message-Info: sQQy/wtFRj4CW/HIQ0CvA9jvqNPkA6HMlW19/aNJKP3CNy5jl2h2F1OXXG76QRSv1/A2wUJudiSNkp1BWQNCDsvkyL2mAPBylwiHswN72oofT5tnX8YyHBZNAya0HHbrNPIYtJ7fa+9kQbHwl/DbL+Qsm/zZn/l7ePiqC8ijGLFnM0NKUszoQIi0E7pSn+TC9vMBlZwgxuzAzlQBhC5LhYrcN7vdfm/dqvRmFrZS0xlLhDJ+2EWkcVaah/L3S9oqYzYNt60VxvUpJ9WX2+mOq1JQRLesfZJe3TU6sX4F9j3uBNN48+jF9Bi5kiV6kKxOKA7knjVkbTdHE/Z4sV2dwAWguFTCDMhbQeJPmBP257oTuwcOghc3qLV3RJ0sXkuo7xBZdEwa4m82VuRufANf8cv9vtvNl/nzAvikPdVvGR1/dOGVJVPUXFt+8lg+zpDa/NmqUt6yYYdht57wM0Om5Ds7P1nD98L4OThD/iif1vmp/QL8XYXyR5pd1q9aAsunsaJ4MxHQY9ZkhEkeOgp95uGtabPMfObY5mmlutyiVl0nvGWegi054ebqEIgMBw+HFMRGDOYDRGP+lXmRH+xgDHPIGqmQzNd07tPnEEsWEt4oQu/vYttyfKMaq1G6s8Ta0FgDGj0FDwTODP6A3N2PR31eyjHwpE8Gi1csGbjD0vW9l9iZcvyr2r9Qryb5BmRbW6F9Lk3AU+tWoXsA+WbkiA13LCBXxr0R1JHbrsrm35STWCcsrQKrx/+lx9B5Db1Qw7y4OLM4KsD6UodBjikWDNwRtCVxsmXIURludpJ5BvN3hkVt5FYPFCK3LoJrMoy6Tsn5EMxhZMr9A5ro8b3esDD/nae56LccIWX6Mf4aGrvzlSkuZi/wAJXvsJQIr3i2dAxMwAHnXDaSpRWWyRU9eGhBK0QO/YmdAU92x0ywIrFzwgjtlWjx+exS/dnohIx9DNFRTuC3TiUI/Cgdk9xAUkpmFqyxGGhUsPXZCQsvu8bZVmtbChUz/rGk93nxxkTZNwgMblyPweqCfgY7RYqIxGGfDgyTXgJnSyCUquLhrpNIY6u4S4CuHOkGkON4FZ7zb5zPa6Bt61PJh6kffyp+KhhQusdZT1ZZlQRkXGNaorAlRyrpmo4gqqQhy7+5gRqv1igdDepYU5bDtUDt728fzbTHkOIU+GZI0EVAIaK7Vj9DlX6SSUBGrWGpOUdQJACfJLlhbF3oAZzjrxnc1LDpaB+OkNFrG+rjR/Ah2YDL6z3bR02AOsK8sBkBnZFiuNrr8fajwr7wRFb2ZuGTFoCZ0dHdrHjqk6+njrgWRRgyC4sZGjnYVBBODpz/mqjK6y6bRJsk06a1WxmdZDPIJ//1BBgFypC2kiMlMbhU4X2IX757x5+1hprxS0ewvnXRorjaeP4yt56ganLxiUJTgOcHJQW4Yu8eww2QCYYbHa++aH/JV6kxULwXwPgdrGmOURPuLP1Hke+Irrzz+Y7qy8sPkKWYdCZVsx1xyi9QbBo/lL4= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(1800799024)(36860700013)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2025 22:03:56.1323 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 197b53d0-10cd-4907-489a-08dd5cfaca48 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B36D.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6880 There isn't currently a way to determine if a domain is the hardware domain or a privilged (control) domain. Add new domain info flags to indicate these properties. This is useful for a hyperlaunch-ed xenstore domain to determine which domains are privileged. Signed-off-by: Jason Andryuk --- xen/common/domctl.c | 2 ++ xen/include/public/domctl.h | 6 ++++++ 2 files changed, 8 insertions(+) diff --git a/xen/common/domctl.c b/xen/common/domctl.c index 05abb581a0..3c6dcfed87 100644 --- a/xen/common/domctl.c +++ b/xen/common/domctl.c @@ -103,6 +103,8 @@ void getdomaininfo(struct domain *d, struct xen_domctl_getdomaininfo *info) (d->debugger_attached ? XEN_DOMINF_debugged : 0) | (is_xenstore_domain(d) ? XEN_DOMINF_xs_domain : 0) | (is_hvm_domain(d) ? XEN_DOMINF_hvm_guest : 0) | + (is_hardware_domain(d) ? XEN_DOMINF_hardware : 0) | + (is_control_domain(d) ? XEN_DOMINF_priv : 0) | d->shutdown_code << XEN_DOMINF_shutdownshift; xsm_security_domaininfo(d, info); diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h index e2d392d1e5..84c2af6a09 100644 --- a/xen/include/public/domctl.h +++ b/xen/include/public/domctl.h @@ -155,6 +155,12 @@ struct xen_domctl_getdomaininfo { /* domain has hardware assisted paging */ #define _XEN_DOMINF_hap 8 #define XEN_DOMINF_hap (1U<<_XEN_DOMINF_hap) +/* domain is hardware domain */ +#define _XEN_DOMINF_hardware 9 +#define XEN_DOMINF_hardware (1U<<_XEN_DOMINF_hardware) +/* domain is privileged */ +#define _XEN_DOMINF_priv 10 +#define XEN_DOMINF_priv (1U<<_XEN_DOMINF_priv) /* XEN_DOMINF_shutdown guest-supplied code. */ #define XEN_DOMINF_shutdownmask 255 #define XEN_DOMINF_shutdownshift 16 From patchwork Thu Mar 6 22:03:27 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Andryuk X-Patchwork-Id: 14005395 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6EE59C282D1 for ; Thu, 6 Mar 2025 22:04:11 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.904069.1312019 (Exim 4.92) (envelope-from ) id 1tqJK0-0001nP-HA; Thu, 06 Mar 2025 22:04:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 904069.1312019; Thu, 06 Mar 2025 22:04:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqJK0-0001mQ-Af; Thu, 06 Mar 2025 22:04:04 +0000 Received: by outflank-mailman (input) for mailman id 904069; Thu, 06 Mar 2025 22:04:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqJJz-0000Ss-A9 for xen-devel@lists.xenproject.org; Thu, 06 Mar 2025 22:04:03 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2061e.outbound.protection.outlook.com [2a01:111:f403:2417::61e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e8e3402f-fad6-11ef-9ab4-95dc52dad729; Thu, 06 Mar 2025 23:04:02 +0100 (CET) Received: from CH2PR18CA0044.namprd18.prod.outlook.com (2603:10b6:610:55::24) by CH3PR12MB9344.namprd12.prod.outlook.com (2603:10b6:610:1c8::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.19; Thu, 6 Mar 2025 22:03:57 +0000 Received: from CH2PEPF00000144.namprd02.prod.outlook.com (2603:10b6:610:55:cafe::13) by CH2PR18CA0044.outlook.office365.com (2603:10b6:610:55::24) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8511.16 via Frontend Transport; Thu, 6 Mar 2025 22:03:57 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CH2PEPF00000144.mail.protection.outlook.com (10.167.244.101) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8511.15 via Frontend Transport; Thu, 6 Mar 2025 22:03:56 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 6 Mar 2025 16:03:56 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 6 Mar 2025 16:03:55 -0600 Received: from fedora.mshome.net (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Thu, 6 Mar 2025 16:03:55 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e8e3402f-fad6-11ef-9ab4-95dc52dad729 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=IVDL9TUBVc6TJ42XC6chKgATlMLtrut3e7ymOyXVIy4HdMCO0ZmlLEORpHu3Q+TiomO7mpjtIs1KifyxAVepcGT4yx1nwWHbsaVsvfvrU8SnCFPeg6KpMTrXcXxTG3wXX1yDtZWbw17Ag17L1pIhiwrlkclz7b/ELavCdCY1E5oOB+QU0l0n2Kfl0E/RIHpyLloUJrftIXrMNgp6XbONUffbCRI5Sk0oltPwPyK6I1bo4yP02LDtLMZkyA4ZQ4q/IN1Ux8OTaE4/9/vmPFCIudJeCkq5FKTz3ic+dmUKqSDCg7BO9RqFx/uTJZdQaLA2hwT0srqKCkM74OUbEo+UrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y+m/QdRPMsN/ArRHcQsjPmQFgNz4Tb8oT1TBtzTvHvQ=; b=TA/2jOIzAWBpIGHNzfs2dIaqznCbt3ovyhwF+QJkcZ4zPMdogoNZaMKb9QHPRQaVe1OvvmBY/6sVNfg5A+YY/nTOBr443kdWp/B7IeovMB4pVWKE6yEpWCDbzReo5Fl+Bige5j6iKgjYwqEU0t0fFfJz+3Xa9FvXSSrLyv7HXQRZkX0Du5rg39hrX5s02CAuJqI0XuJGceav8R7HR5DU9sc2nhvVZMte5k+6I4kXFwOtEv6JN+c260Ubb6Tex+m/uULxctvePHyXNV/9mARUQGzKBjWZz72LPsOV4Wqold6/cSEsfyCtk0Y6swcEmdN+jIEPn7EUEOmcDV4Ct1IkJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y+m/QdRPMsN/ArRHcQsjPmQFgNz4Tb8oT1TBtzTvHvQ=; b=RnqK++Chx2NX5HI/1X55R/bEpNfw7XngiXisDpORQCtr5Ef/5kwb51Ke5B68zp1HucVu9gtt915o/7aBRq5mvEkJqxmFbZ2CLYYYRDvWdO2XPK6uwUwVBIXf4p6q0p5c+/xu1wNG9rFRaKx/RcoNAXnDWFF/5NMqL/3p22xi0Eg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Jason Andryuk To: CC: Jason Andryuk , Anthony PERARD , Juergen Gross Subject: [PATCH 07/23] tools/libxl: Expose hardware and privileged flags Date: Thu, 6 Mar 2025 17:03:27 -0500 Message-ID: <20250306220343.203047-8-jason.andryuk@amd.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250306220343.203047-1-jason.andryuk@amd.com> References: <20250306220343.203047-1-jason.andryuk@amd.com> MIME-Version: 1.0 Received-SPF: None (SATLEXMB05.amd.com: jason.andryuk@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PEPF00000144:EE_|CH3PR12MB9344:EE_ X-MS-Office365-Filtering-Correlation-Id: 1e417f6d-e3fc-4f50-c021-08dd5cfacaba X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|1800799024|36860700013; X-Microsoft-Antispam-Message-Info: RMRLkGXCXAwlGkJY6M2CepOIB18Q4kY/gHFfeUSJUDkeuWLuTZz7n0IxPdVv6TVtVqCex1gkxyqdLA+rYiOfG7UGQJ9wRz/SdkjrI2yruuNVpteoQLTkoHiMQExMqYRji8Lab5sDvtcVvoK7+AxsFuF42Y4jzb8Uv361/ThmFe0PXVyr3JtvF3wwGQ8ycJtx9vjaM8Tm4VniVa4CRM9HgrXWnoNQHETpCIL/2fAYivR5IwOZIheq8NyZtlKkqat8Bs0eP2TFVy/pz12UBYm+o/vF+F2OMNH/NEx6znRyFa56Qi4SLjsJwTNtcGK9GJMd2vYZ+1ZBAJsYFYN3B1Ow9665iAUcOWF1t7/iHgjU8ecywFlERMfW+T2iCgfpYTfG7JSeKaOhDDByXmwCc7pKCYhHnw5+WUDW7E33wD3VQfRFKceOtT3JWjoYUnvRO2kB1J9+xqRsXxQgEqGwOzFByipnFjVtk2roSOMqelVha4SQauIHLg+NsxZ3jsimIWqKgZDCXb35wTJzGGpGCOMIf9r6nnv2Ttt4H0ptW1E+n0P0CBhL2e1Z38moMRuzF7r7KPLatNXqyxdWddxXRjYhlmucfFB3oc6ayrqd4omj+l8NfCDLanjiLHUEblc6uBu4L8jgU756Z6++GTC2UltxofZ5OcbXFSxR4N2dNdzpyESMLNQ50MUk7/awPAWQixp4kL9YUoO2kAmyNiq66LUzwZuerOjS9kUViWcuo+qp5o7/FAolQ3vuCsHtgLcocMmdeHUBqi0zRTjn4CYwybQyMdFJHJC8AqlJYXYuqmCueBhP5O5gtPEaFk81r3KN8xdlMw4bmtjsLE4tWYzu3HOlpAAF36ygdTqEO/4MKQCVSoCj8aP38zVbXkdGvzQ2UrUhLaM9X02a9nMcZNlawbfCl+xuXI1f4Noa9wgJ1X+uyHSDVhG4nAt4NoQrFOfxgmEBKdaREBoInloDbvHq0PH3we7MxYDX3f1JnJg5SrrNMnuOjZDY8+6GSgAI5OWlOD0zNBS57PT3gnUMWA/MfhHvlE28uXxNSYRuLVkI+tPUrBUp2EvkeWFqphC8/ouwuwm+67ZfB++ZoJwHkh3pSfX5LwJxZXULbfx2v5DTvu5+ajQ/wVn+zGBSVeZhUwRzKyPMd1LlXtkV7zpqfsS0TbJXET8UHiaaIRYgG8aOwZJ9A05Vs5nagXTA91bcsDTP4JiH4BKcNQejFtvOxRT4poK+zrThJzND1oZAJlbovN86JxF5Rvnb3cO/sXr+Uib6SrS49LvUfEzo28pGjdBcC3TjsX+yG2vxD7XX9M08AD4KJDemVpGW0o1qjo7f3thLQn/YSze2UYuxY81MkJHRMYC+dOdd8oxksEVbiF9wLqRYNVmBrcAl7HALTL09nq/Pgwpontdssfm9pwuMITGUGG+2VuTUDk48NS6UhB9z29kdmO972ru/mUIRr1U5lJ/IYcraPf9g1m30a2f0wZkkjmf5ukaoYerafFYtfUBZLSC4Zwk= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(376014)(1800799024)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2025 22:03:56.8513 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1e417f6d-e3fc-4f50-c021-08dd5cfacaba X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH2PEPF00000144.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB9344 Expose the new hardware and privileged domain flags in libxl_domain as boolean fields. Signed-off-by: Jason Andryuk --- tools/include/libxl.h | 16 ++++++++++++++++ tools/libs/light/libxl_domain.c | 2 ++ tools/libs/light/libxl_types.idl | 2 ++ 3 files changed, 20 insertions(+) diff --git a/tools/include/libxl.h b/tools/include/libxl.h index f8fe4afd7d..bdf4c301c0 100644 --- a/tools/include/libxl.h +++ b/tools/include/libxl.h @@ -1010,6 +1010,22 @@ typedef struct libxl__ctx libxl_ctx; */ #define LIBXL_HAVE_DOMINFO_GPADDR_BITS 1 +/* + * LIBXL_HAVE_DOMINFO_HARDWARE + * + * If this is defined, libxl_dominfo will contain a flag called hardware + * indicating that the specific domain is the hardware domain. + */ +#define LIBXL_HAVE_DOMINFO_HARDWARE 1 + +/* + * LIBXL_HAVE_DOMINFO_PRIVILEGED + * + * If this is defined, libxl_dominfo will contain a flag called privileged + * indicating that the specific domain is privileged. + */ +#define LIBXL_HAVE_DOMINFO_PRIVILEGED 1 + /* * LIBXL_HAVE_QXL * diff --git a/tools/libs/light/libxl_domain.c b/tools/libs/light/libxl_domain.c index 6751fc785f..c6e3072027 100644 --- a/tools/libs/light/libxl_domain.c +++ b/tools/libs/light/libxl_domain.c @@ -291,6 +291,8 @@ void libxl__xcinfo2xlinfo(libxl_ctx *ctx, xlinfo->blocked = !!(xcinfo->flags&XEN_DOMINF_blocked); xlinfo->running = !!(xcinfo->flags&XEN_DOMINF_running); xlinfo->never_stop = !!(xcinfo->flags&XEN_DOMINF_xs_domain); + xlinfo->hardware = !!(xcinfo->flags&XEN_DOMINF_hardware); + xlinfo->privileged = !!(xcinfo->flags&XEN_DOMINF_priv); if (xlinfo->shutdown) xlinfo->shutdown_reason = (xcinfo->flags>>XEN_DOMINF_shutdownshift) & XEN_DOMINF_shutdownmask; diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl index bd4b8721ff..4fab558896 100644 --- a/tools/libs/light/libxl_types.idl +++ b/tools/libs/light/libxl_types.idl @@ -365,6 +365,8 @@ libxl_dominfo = Struct("dominfo",[ ("shutdown", bool), ("dying", bool), ("never_stop", bool), + ("hardware", bool), + ("privileged", bool), # Valid iff ->shutdown is true. # From patchwork Thu Mar 6 22:03:28 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Andryuk X-Patchwork-Id: 14005397 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D415CC282D1 for ; Thu, 6 Mar 2025 22:04:14 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.904071.1312034 (Exim 4.92) (envelope-from ) id 1tqJK2-0002Jl-TA; Thu, 06 Mar 2025 22:04:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 904071.1312034; Thu, 06 Mar 2025 22:04:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqJK2-0002JW-NF; Thu, 06 Mar 2025 22:04:06 +0000 Received: by outflank-mailman (input) for mailman id 904071; Thu, 06 Mar 2025 22:04:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqJK1-0000St-5a for xen-devel@lists.xenproject.org; Thu, 06 Mar 2025 22:04:05 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on20603.outbound.protection.outlook.com [2a01:111:f403:2413::603]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e9ae5527-fad6-11ef-9898-31a8f345e629; Thu, 06 Mar 2025 23:04:03 +0100 (CET) Received: from BL0PR02CA0058.namprd02.prod.outlook.com (2603:10b6:207:3d::35) by BY5PR12MB4179.namprd12.prod.outlook.com (2603:10b6:a03:211::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8489.25; Thu, 6 Mar 2025 22:03:58 +0000 Received: from BN3PEPF0000B36D.namprd21.prod.outlook.com (2603:10b6:207:3d:cafe::6d) by BL0PR02CA0058.outlook.office365.com (2603:10b6:207:3d::35) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8511.19 via Frontend Transport; Thu, 6 Mar 2025 22:03:58 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN3PEPF0000B36D.mail.protection.outlook.com (10.167.243.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8549.1 via Frontend Transport; Thu, 6 Mar 2025 22:03:58 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 6 Mar 2025 16:03:57 -0600 Received: from fedora.mshome.net (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Thu, 6 Mar 2025 16:03:56 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e9ae5527-fad6-11ef-9898-31a8f345e629 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=x8mJbBtB/kEvU0i+jc7cpuxBZCQXCzkRi9nidOpzC8ITlkDQxY6L+lDifJiqZT9iElAs1k5TZS4JF3G+stl6FisIU2UuxeHKAItmn7PipJDwpI5V6RhdN28DyRptWpCnavwXwO3I9E0UqOTDQj3zUea9GkNpyRPWHGhAArT9QJ5HadkHKzQOUbrrUxL36hEE2TI8fNXNIHx6ngvXonlVN9cTMEwcKxkvU3q87V+H9cyv4vn1cHlXLIpS6MJ7ffbc+xKNNcVypY6YLz9OcTV9LuJZkKocl/fJVJn/2vbakX7Am2WDn4OkQXAD5Of4xP+j9DITxMEJ3xbcA50xGZDGPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NzAMmJ2y9UG57sCUdrV921xp8rnXUBaxfjOw07lBiGM=; b=hzzeeWnzimISjViHPGNxb0yDy1/+jtY9vg4YFe6IbMtPSS86wXPaqrc3t2Ih/CgxdReyJlJeQtnLp4c4Ayc4NpjiokO7WAxXfTOq7VNPAtbTdxXjSv4SWFjX9aH98dbpwe4BPQKQdzodbfWMPeUmF2QZOUPB82wH8eXzZhjOZGqDE1mV1SLMWk/780CMmKpx3MI/chAnF8yX+jXmwatRbYuSK2o4g4Wmo8MT4g/PaoBHaV5vCqJGvCK4bY/IuhvUPuu+yZKGt8OREupLOc4C0hp2TWBXnKCytsui6jA4ANHnOkpkD1eSZdlG9uonAayz6N3a2b9evXez2lr9g1cDlA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NzAMmJ2y9UG57sCUdrV921xp8rnXUBaxfjOw07lBiGM=; b=2hyNAqzks8yOAroztKAmQ3EbAI8na2FFNjZnjO9ZAwEFjb79XiMkHcifM2mXoNQzDAYt3oRNjWbjxTeF8VK5K38mefTK2uYD9YZ6j1ZpJCrQBrKbbkPTL80/PdOiCYG5SajktqSJZP7s/fNoLMwFSZnrkvczS7VmVwSwqK1y6qc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Jason Andryuk To: CC: Jason Andryuk , Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , "Volodymyr Babchuk" , Andrew Cooper , Anthony PERARD , "Jan Beulich" , =?utf-8?q?Roger_Pau_Monn=C3=A9?= Subject: [PATCH 08/23] xen/arm: dom0less seed xenstore grant table entry Date: Thu, 6 Mar 2025 17:03:28 -0500 Message-ID: <20250306220343.203047-9-jason.andryuk@amd.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250306220343.203047-1-jason.andryuk@amd.com> References: <20250306220343.203047-1-jason.andryuk@amd.com> MIME-Version: 1.0 Received-SPF: None (SATLEXMB03.amd.com: jason.andryuk@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B36D:EE_|BY5PR12MB4179:EE_ X-MS-Office365-Filtering-Correlation-Id: 99cc459c-f904-45c1-3a88-08dd5cfacb7e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|36860700013|1800799024; X-Microsoft-Antispam-Message-Info: I8bgLuB3Ry5t4YNdDYLd1wi4V0aSa+rx6wvCtJtA9Lu4+SJ/oNRG2Sk+vgJupRuGbZm/VnfXa+pd+C8llTSIqp6SZyKkXLVG+ZfyPAp0yZUHCYat1itdgSssu87G93BHnsr2ryleXlf2d5ip8teGHYPBv8324Y7KHYa/D7Dfxi30II+7dd/7xGCL00wLouvtOnszm2+U96CUlq4rx1xed1fGwjafX3kq1xMBz0JqmdD1ttt4yo38OOzycI0+Fz/ylJn6mpmYupi5Bf6GufbVYLV+ZVISz3eNfGIefcm8D87hvB56x0ruAA9G4yLfB+OJ8DukGPwh5d0YIpA6doXN6GQL/enUrDEvxoWk0dempmXd5w/+VqAQh8w0bV+rW7piTULaWbXZCUIyZ97AMjSAfIAnp3CycQqTA0py4Tu+bW98Lq7aUapNbmc1CsyG2cN3bc9rqsoEn95O0QGknabQJnmeOp5zOmsW2FkwVLOOUNssaXDSS6bSOCUg1RXYQSMKRrGELORcLI1gB9LyafTXR8XitsZzoLmHw26C/zWa8iUjh5y61KUBEmZyNuakqv7xgwwSsBnJGRTNbVPMdXdllOnwkM7tVqw8pvmpPW7VBC1PaGJH7ccFNKnSlQqrsZ0IMuK4BIpe9Kf/CFKAbGmVCjQaoBK7asXlEPJQCDNCSbHOIBCR+ApnTtUaYhvR5Hiqxz5+j53sg57YYnNC3BbGkSjGvjvOV6k5N0mzX3gLAzghUO8GuhV8XIzzzmnPtlUC5+pZ2YvV910Fw7JlUof/BztWYTbspc8ytQfTsLmeSDPQnLq99jwglfhP3yJx3pLB0QyIeuheIwgiL5zdQnCL//U1qGHurhsjy60fw7kIAAEW5NSgQ36uIuUvQ1kwBF0xsJwtBK7NBhXyHkTV+9vsD4v0qzjrH2S8QckzxhLh6M+JfTPJpoYY5KfmngLkaFikEx+cuPY1T3bQd4PRrPEIVqLYKdKA5aa2DcD+ImZMzop46QAwMYbSMboC1tSnz9gH4qwFUluK91hS9l/l0EAVE2Cx8XFE9xmUac7ZPVfpssfRVOfUYyA/09dmkFfJIA20iO16QldCSul4NSbiK8oiSJ4Li0An0Qq2SDkazgG1gCB3z3wL+abIq3sd75+YVDWDi6Hm6hcSyDr3dashqSX4FkmmQNk3gHO1sS/3UnttKtv7zbAWA1C4wW5uVSkv0qn9iOC3LqFCj92DzFn5QL1ygOewjhiNQ6mfg6DP0IuBJh1rjkAPOAz1kLYVtpwABh8JLPgkUecEJlDMHw+4in6AekEQ4TqjW3DhtzUDVBReFLxo7fxs1oliTDEphO3iihEVa4klCgloxSB17q0sY4z3wiC32vlVz+W8sRTuDPmjpT5mwoFoi6hQ9lRaT/d38Kxax9ZV68NLQtKRkkWm0lYvKzsv577tUXS3SJU8QECZpOqlixJf8E1WjLHqHk9ad6jqRO2hffEPoDEYTTBp7SID/82GBm1ZKeJUpRaH/uBZ6pc= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(376014)(36860700013)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2025 22:03:58.0855 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 99cc459c-f904-45c1-3a88-08dd5cfacb7e X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B36D.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4179 With a split hardware and control domain, the control domain may still want and xenstore access. Currently this relies on init-dom0less to seed the grants. This is problematic since we don't want hardware domain to be able to map the control domain's resources. Instead have the hypervisor see the grant table entry. The grant is then accessible as normal. This is also useful with a xenstore stubdom to setup the xenbus page much earlier. This works with C xenstored. OCaml xenstored does not use grants and would fail to foreign map the page. Signed-off-by: Jason Andryuk --- xen/arch/arm/dom0less-build.c | 9 +++++++++ xen/common/grant_table.c | 10 ++++++++++ xen/include/xen/grant_table.h | 8 ++++++++ 3 files changed, 27 insertions(+) diff --git a/xen/arch/arm/dom0less-build.c b/xen/arch/arm/dom0less-build.c index 068bf99294..f1d5bbb097 100644 --- a/xen/arch/arm/dom0less-build.c +++ b/xen/arch/arm/dom0less-build.c @@ -21,6 +21,8 @@ #include #include +static domid_t __initdata xs_domid = DOMID_INVALID; + bool __init is_dom0less_mode(void) { struct bootmodules *mods = &bootinfo.modules; @@ -753,6 +755,10 @@ static int __init alloc_xenstore_page(struct domain *d) interface->connection = XENSTORE_RECONNECT; unmap_domain_page(interface); + if ( xs_domid != DOMID_INVALID ) + gnttab_seed_entry(d, GNTTAB_RESERVED_XENSTORE, xs_domid, + gfn_x(gfn), GTF_permit_access); + return 0; } @@ -1173,6 +1179,9 @@ void __init create_domUs(void) if ( rc ) panic("Could not set up domain %s (rc = %d)\n", dt_node_name(node), rc); + + if ( d_cfg.flags & XEN_DOMCTL_CDF_xs_domain ) + xs_domid = d->domain_id; } } diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c index 6c77867f8c..ba93cdcbca 100644 --- a/xen/common/grant_table.c +++ b/xen/common/grant_table.c @@ -4346,6 +4346,16 @@ static void gnttab_usage_print(struct domain *rd) printk("no active grant table entries\n"); } +void gnttab_seed_entry(struct domain *d, int idx, domid_t be_domid, + uint64_t frame, unsigned int flags) +{ + struct grant_table *gt = d->grant_table; + + shared_entry_v1(gt, idx).flags = flags; + shared_entry_v1(gt, idx).domid = be_domid; + shared_entry_v1(gt, idx).frame = frame; +} + static void cf_check gnttab_usage_print_all(unsigned char key) { struct domain *d; diff --git a/xen/include/xen/grant_table.h b/xen/include/xen/grant_table.h index 50edfecfb6..63150fa497 100644 --- a/xen/include/xen/grant_table.h +++ b/xen/include/xen/grant_table.h @@ -45,6 +45,10 @@ void grant_table_destroy( struct domain *d); void grant_table_init_vcpu(struct vcpu *v); +/* Seed a gnttab entry for Hyperlaunch/dom0less. */ +void gnttab_seed_entry(struct domain *d, int idx, domid_t be_domid, + uint64_t frame, unsigned int flags); + /* * Check if domain has active grants and log first 10 of them. */ @@ -85,6 +89,10 @@ static inline void grant_table_destroy(struct domain *d) {} static inline void grant_table_init_vcpu(struct vcpu *v) {} +static inline void gnttab_seed_entry(struct domain *d, int idx, + domid_t be_domid, uint64_t frame, + unsigned int flags) {} + static inline void grant_table_warn_active_grants(struct domain *d) {} static inline int gnttab_release_mappings(struct domain *d) { return 0; } From patchwork Thu Mar 6 22:03:29 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Andryuk X-Patchwork-Id: 14005398 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6F8C6C28B23 for ; Thu, 6 Mar 2025 22:04:15 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.904072.1312038 (Exim 4.92) (envelope-from ) id 1tqJK3-0002Oq-Eu; Thu, 06 Mar 2025 22:04:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 904072.1312038; Thu, 06 Mar 2025 22:04:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqJK3-0002OI-6L; Thu, 06 Mar 2025 22:04:07 +0000 Received: by outflank-mailman (input) for mailman id 904072; Thu, 06 Mar 2025 22:04:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqJK1-0000Ss-Aj for xen-devel@lists.xenproject.org; Thu, 06 Mar 2025 22:04:05 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on20611.outbound.protection.outlook.com [2a01:111:f403:2414::611]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e93ab5b3-fad6-11ef-9ab4-95dc52dad729; Thu, 06 Mar 2025 23:04:02 +0100 (CET) Received: from IA1P220CA0001.NAMP220.PROD.OUTLOOK.COM (2603:10b6:208:461::15) by PH7PR12MB5760.namprd12.prod.outlook.com (2603:10b6:510:1d3::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.16; Thu, 6 Mar 2025 22:03:59 +0000 Received: from BN3PEPF0000B370.namprd21.prod.outlook.com (2603:10b6:208:461:cafe::35) by IA1P220CA0001.outlook.office365.com (2603:10b6:208:461::15) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8511.19 via Frontend Transport; Thu, 6 Mar 2025 22:03:59 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN3PEPF0000B370.mail.protection.outlook.com (10.167.243.167) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8549.1 via Frontend Transport; Thu, 6 Mar 2025 22:03:59 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 6 Mar 2025 16:03:58 -0600 Received: from fedora.mshome.net (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Thu, 6 Mar 2025 16:03:58 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e93ab5b3-fad6-11ef-9ab4-95dc52dad729 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=EV3DAIknSCgP+WWDAKPkYKyVWbeAinVltIoL0TLyxOtziNhzrGp56j40Ocgi6j5L6QSPyz96RG+uNoxl80bP1agFEyRpMC1/LvXzr0ysDyP0p/secFJk8q2xLN48l4ZEz92u2Tzzxo77qvm6qGTtLFfjh6lzm7/4xiLkGZDXUuYSNMoPW3uTTaHGSLfKBQd47BCyUCXw1aj+Ie6CBk0zcHWxqKZq1leOzincZas+JWFUuFfbLLfDPvUCjkBifs7w6oNYNSuPb/liToQ+A5UUZmLWImFYwuwxeLbh9o3yCU/kxgFzrH9xXznht7urrOfklFHAzgxhCKj+3DItIXf91g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h3tMNxxL+69wngCwofVJ/wGbA20D0gJe7GF8lfRxq1Y=; b=TgFfai0727G/lazIs4SVgYNtYCrn6bE21tVpmuRqYsxfiNeiHjIPyRu+3cive6Z7FzykDe6RrkFc2ihR3eezzVEQsLvLSu28YkeIeiODhZc0q4oxal3LGSVKq1ROPS6nkdndFwGzNa6snTCg85uPtxGHJN2A/YiiYmzTd5G5OPsB3/ayLy9s46dIize9CAjS6TrJ/YpKYcBT9O5WL/YbtgrutvgYosDeIBfsSJxx1XUVbmUgkkaLu2DYxJfIeECvAeMYLaFeb2dranl0YaOR1PnrklNKiKwq957vQbuvzMmeWCiZxSSoo63CYAWsirsT36DdScAZOv62Tg0dW8/ONA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h3tMNxxL+69wngCwofVJ/wGbA20D0gJe7GF8lfRxq1Y=; b=smkaHvpu03b8C94hFMRINJNG7yrbXRtnaEgpPtB3uZqg/+49hVqCXydlZkIhBsjnauer2x+eI6dXBOs3s/Ralv5WQO6WrPNbWTEh7epjnx67dKs64NdQ/C102o4ydcHPTVs8qtl40ql5YkS1LFv3azr1WMlaYgGUB5zmbWiGw4c= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Jason Andryuk To: CC: Jason Andryuk , Anthony PERARD Subject: [PATCH 09/23] tools/init-dom0less: Only seed legacy xenstore grants Date: Thu, 6 Mar 2025 17:03:29 -0500 Message-ID: <20250306220343.203047-10-jason.andryuk@amd.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250306220343.203047-1-jason.andryuk@amd.com> References: <20250306220343.203047-1-jason.andryuk@amd.com> MIME-Version: 1.0 Received-SPF: None (SATLEXMB03.amd.com: jason.andryuk@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B370:EE_|PH7PR12MB5760:EE_ X-MS-Office365-Filtering-Correlation-Id: 4830f4e5-5aa9-45d5-060d-08dd5cfacc0e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700013|376014|82310400026; X-Microsoft-Antispam-Message-Info: gNHPPqKJDgs6GwD36AszmwI7oqnKWwccyOupPOb5A0J6y6xOwhNqulb3ZlASjoxjnGNFMKchlSflzjd3rg7Er6229s976CH+bOpz4XfQKNRmWx/VNhS2UxQZ8WaWDNmPno6q89Km0pWBwrnUomJE76OY2a5/hFXSqBX81/2vJYpz3aWsJmsw0EsYVSIda+l8oTsr9VW1zGkywqjbKDxml+x1J90ClcDiVXPFmPCTGUM5HmJpxmDc1I5iIacFzKvB34IzVd/NVOWNev+mG8uzH3Ntop3BpCGL9ve1WS8a9umpGbJ2SAt6tf1+nN9O2uweyNNgCU92X0bebq+bz1fU1DdJOAIMbuIVPw8vW9/Py+a+a6858ywWjBg965/3hB7P48fum6oU8uQSbSNmlGF0HRM9yTfxfVp+ngtppv0d58cTEuylZEMo3OnRXOGjpVpp8xf1Jt6Ra6xPwm5rmZlSEH+fE9lpiCkjRVW8o7NYCFdLdT7Vmwl4VelTVFw9P9+tSIaeBvYj+hOmcj4CIdowWKNhNgQoIdxI0/gyOzk3BT7HUpHbIAmuD24kXwh6mfPJF58zta/9kb6/IVggx6CB5uqmlbZFjp9iNvBRifKv6SbnFKrfOQI7lz81byL1rCuOT6yxR9G/S63rHwJnYam/3ptg9mUEfbynqQ+joYstii/CIjEfkDoC66rQ2MD0D/nfS0ejvzcxDfHzFsaSQrAdMOjrCG6qbgPrNcdZMQd8s1VhlQJ7BkAts62ssXQSd62kTQk+ElFAscc6tOP1tg3bsUw+TJVUhAfCHfV+76QWfDYmhUp7JPf6/I/px7fJ78Pftc6vEPbM5EHC7x88g7HzMCss1JBrYEbfn8C2SHI5VxMBYqrunAlRSR9HnY3U8mzsxO46qEEdGpec3G3yvbBioNNpoaSL6QpToZ44qm2AQFT/DICUox+WRd9L8IzS4QAUXw5+QtzNoDUguc8SI9TZu3k9QNgcffdVsHwM3gl/nkPwXPPQqVrdULye1CISDfdv+rycK9A6GmZVSqYWgDWDApYJYDqigyZUZfYaphpFuO8JBfGmRbFLMUDB76Wlgg+VLwNt6fr5wZA5SagIhINCATxb8xeduylRLBgpngmaZ9LWbcFPJkPjuhc0Pd25UDzVw+E2X2MNkexXhuUg6vGIMOJ5+9GqBjMDbwZ8O1LxhgrKn3mNmc/a3vbRy/8Q5JR57qDfZonu5lZWqIJzB5bfZNp5NZQbU8Vw60mzdVsJMe49bRgTQ1TPVg0TVQUGCfcTvlph21fqPfewVg5vLXEUCl4zYVJhy9bWm/Omzd8f0170RusmwHAQXrLrNnJ4azrSjJBxgpk3b02L/HJATLDlLLyg1e9YH7qtN/86G7XhKR34UHzWUi/+KcV/kUL4zN3P1m+mkYTFlrS7f3feqtvIoN+nFVSUz9CzSdI0Efwa1UZdeYglC8ns0KlhjiEdNaRjmx5ViFHBAV9uwNZxTEmJwwAZbRs1Gy0hvNh7c/oNRpQ= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(36860700013)(376014)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2025 22:03:59.1060 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4830f4e5-5aa9-45d5-060d-08dd5cfacc0e X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B370.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5760 The hardware domain is unable to seed a control domain, but we want the control domain to use xenstore. Rely on the hypervisor to seed dom0less grant table entries for Xenstore, so this seeding is unnecessary. However, that only works for the new xenstore late init. The legacy protocol which uses init-dom0less to populate the page still needs to seed the grant. Signed-off-by: Jason Andryuk --- tools/helpers/init-dom0less.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/helpers/init-dom0less.c b/tools/helpers/init-dom0less.c index 17579fe2e8..91edf17b6c 100644 --- a/tools/helpers/init-dom0less.c +++ b/tools/helpers/init-dom0less.c @@ -286,12 +286,12 @@ static int init_domain(struct xs_handle *xsh, xenstore_pfn); if (rc < 0) return rc; - } - rc = xc_dom_gnttab_seed(xch, info->domid, true, - (xen_pfn_t)-1, xenstore_pfn, 0, 0); - if (rc) - err(1, "xc_dom_gnttab_seed"); + rc = xc_dom_gnttab_seed(xch, info->domid, true, + (xen_pfn_t)-1, xenstore_pfn, 0, 0); + if (rc) + err(1, "xc_dom_gnttab_seed"); + } libxl_uuid_generate(&uuid); xc_domain_sethandle(xch, info->domid, libxl_uuid_bytearray(&uuid)); From patchwork Thu Mar 6 22:03:30 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Andryuk X-Patchwork-Id: 14005400 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51156C282EC for ; Thu, 6 Mar 2025 22:04:19 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.904077.1312064 (Exim 4.92) (envelope-from ) id 1tqJK7-0003LE-O6; Thu, 06 Mar 2025 22:04:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 904077.1312064; Thu, 06 Mar 2025 22:04:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqJK7-0003KF-KC; Thu, 06 Mar 2025 22:04:11 +0000 Received: by outflank-mailman (input) for mailman id 904077; Thu, 06 Mar 2025 22:04:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqJK5-0000St-SH for xen-devel@lists.xenproject.org; Thu, 06 Mar 2025 22:04:09 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on20613.outbound.protection.outlook.com [2a01:111:f403:2413::613]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ec6ee5e5-fad6-11ef-9898-31a8f345e629; Thu, 06 Mar 2025 23:04:08 +0100 (CET) Received: from BN9PR03CA0068.namprd03.prod.outlook.com (2603:10b6:408:fc::13) by MW4PR12MB7467.namprd12.prod.outlook.com (2603:10b6:303:212::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.20; Thu, 6 Mar 2025 22:04:01 +0000 Received: from BN3PEPF0000B372.namprd21.prod.outlook.com (2603:10b6:408:fc:cafe::79) by BN9PR03CA0068.outlook.office365.com (2603:10b6:408:fc::13) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8511.19 via Frontend Transport; Thu, 6 Mar 2025 22:04:01 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN3PEPF0000B372.mail.protection.outlook.com (10.167.243.169) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8549.1 via Frontend Transport; Thu, 6 Mar 2025 22:04:01 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 6 Mar 2025 16:03:59 -0600 Received: from fedora.mshome.net (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Thu, 6 Mar 2025 16:03:59 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ec6ee5e5-fad6-11ef-9898-31a8f345e629 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=acN1sRDCmHjMGSoyfHaDXvzhOaCbbHidpjbHBl19IJo62S5+/R3sU9mSkpeaZN/vVANoggMCMK0lGIkuKjylxJ0NbUIIyDsQYDgOlp8cUcpEsvFO7dMjagppjLNLTQIfoxrRsjzytLQ3gZfkhOji4e39p1c2dS1J/b2uFANsCjl8E2A9Ys8KJ3TIiLcCMVxvVdzUtX71s4qcknrbtxCgiYhcrMhiPjxzifmzPIW6YUcPNScjjV6wEO9WUN54wl4TfYl7rYITL685SywEcMh2iQqeKYTq0+Ozlwg1YN+lX7LkqxnOa4zn7Ow1BMKLSs5QPbHnwWS2vfXYpfRGChNISA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rIC7xasjbalk/ExMtgL5X2h1ecLmO7GR38I48vi/PIw=; b=lbs9N7JC3Vg8gNlIecqSyNj6f+38gNyqckKK8CC3Qv7i3dB722yEvvK7AsWZMGgkZHPYS0BCq7QFMwMzNOnaX7JNYgx1YUfJafoGQXW4bxIYJuxNJcs3GbTVCoLRNnhz3eetHIdz8Xj7YjJAHXs6f51F/QG5ENmT4PlGq98QoNhcC1bxIlBbwM2tJDC8hYqTxOdpReUUaRZrNYBv0Euh+EYX5pNlY9AsS1wp5ICwSnyBvvcqmCBI2eeg2TFtKXfS9NvWZ6c5yntD0o0G5dtxoByuRCr7AtuAH0FqDJEF0RXMUMVd2qzxtKwC5mQk1LbIIJWyeo2cu+M/NdqF3mifVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rIC7xasjbalk/ExMtgL5X2h1ecLmO7GR38I48vi/PIw=; b=DsozZWtPWYpJyRqYZZ+jC5HU2Pe2xBXhYAdBMjxpEjY2DkWRUGlSvL/ZAqP5bjEXipvmFyx5e8EDVY5zC0vVZi8JhK/n6KnWp5ffmai0MAZTi2gKpmHmFiEPtsiXwO7GXstj1gmcIR4BgCiOoWR7U2MzlXufCwmUluYYjghFI0w= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Jason Andryuk To: CC: Jason Andryuk , Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , "Volodymyr Babchuk" Subject: [PATCH 10/23] xen/arm: dom0less delay xenstore initialization Date: Thu, 6 Mar 2025 17:03:30 -0500 Message-ID: <20250306220343.203047-11-jason.andryuk@amd.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250306220343.203047-1-jason.andryuk@amd.com> References: <20250306220343.203047-1-jason.andryuk@amd.com> MIME-Version: 1.0 Received-SPF: None (SATLEXMB03.amd.com: jason.andryuk@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B372:EE_|MW4PR12MB7467:EE_ X-MS-Office365-Filtering-Correlation-Id: 9cc91e06-025e-412c-5924-08dd5cfacd4a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|1800799024|82310400026|376014; X-Microsoft-Antispam-Message-Info: zxWcu6lOjk22Bu8pnjwAHqSuyNkuQHIx3VzNR03jn8benuveqsm+zl+fhrGPLolP8JTnzpcwExoJZj/5SZAQRAmkyJZEmVNlPSAb+4iWK6BL8q7kzC2hJ5obZdTB36FT+MBtu1PFGVQN6YCFPMy8j/UCszJ14hYjrndWiNlMbvTBxyI7SVUaB3TzXsqSResLHJYRiK5x2PuA8Gwm9brTHPtQLZopEOzAYjwGCqO2jsjBP45OTCcFoM61oxh8Pr6id1pyoz8YgyRiKytZMYUvkVLmo44F0zWzJul8Qnu3b8k7Xb03ELvdJpuAczF0l9z3Y05yXw8O+N/QCLAbriG5OAFd9SjXcTRRovXe7fQetfviKEpdccmngifcmAsFsB9GZ4jB31eFd8GeWzWw8IR5V5jl5CKGOqITq03hVEhgd3ApPlzZrhAlH9xq/5rcshOlXAzr4S+LaWTGpXdA+AvB6GOCBfcEpGqDcpAQPozFLjFS9enayz9YnPST4m0pZRS45xO4Ff95n8aB7gOKsnQWPGG+G5nFeiY7jlQheS1DLJYWXk6/woAU3oLgB8pEPE5BfQyMBURahpbVwU012bUhrckmRzC1QPTJaYPD/BvhAhJpImQKJd5wTE8o5sReAGnaWXTHiT/BWf5vZmMvAqwK3GZ5RDAFcMiLBnLRzd6gs5bqlfgXZ1xagJdT/rZB2ngjZ+psSxWRhBBhUfss7QLtrZcpmwAWz8Zm1l+ojo8NThXCsZePw1QGyh59f3nKvw7Fs75MypICYdLfL1Jg0iQXNf0b72rq+bWPcY/OF6L7+qIiazhuhoSV2r8RsMeDIQcGdNdSR+1mRVCRv+2cnCIcVe1F8FpuMJif+ngvgK3pjLJcG4c4iudydmnpHsaFgGQ2UsEkmU6JJaYFiCf+uUpdAWWz05mnEBaVV/XoV4kLB2lJSXBy0teTlWaQrx52ziWoUX8gQc+HuqVwPpARiBCZrqPzpb6VTc1Rw587gApnPLTmC8WJDgQl0Uc821TTsxd5colMw8axD4aH4oRhwB/lHG8kAYSiixEeMSBb4hR7bDu5UY3/zQF27AsnfhP8MWpDigS4DDwcTXauvri0yc5xnVm9oPAEMZoRIwaoibs8D8/npS3hQoJIwSW+HUrjWNmF7hvMxkHwimYol4ThDFCSYbtSSHqLpdcIp8S6yA+mHXy9AE0Q4uTiXG3vAaI2GnOunsk1BzcGCff+S0K0B926O+QnfldoPD811v18t0XQZXiVRuMCuYF+pyilqctV1mohxXK3YetZoJanw97dXj7wcbqPripPVR4oUpRigHoawp9eH/1giVtBVl6y4GpR3ANb+BklaQjCQWJ6BX52lq150KjHcXkTfNWBvJFHA6tRvrcuPFWWgIM+6ZULKPe6aXVUZmoAeb5lgIWOuEZOgDFR2d05uQ9Aait9S2yyWykPzUUPOdckneC1dwp46k6kvi+u3Fw1If9DsXSeAKVMgD6geOn/hHjEJR0HsE1W1Wp/u6s= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(1800799024)(82310400026)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2025 22:04:01.1790 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9cc91e06-025e-412c-5924-08dd5cfacd4a X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B372.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7467 To allocate the xenstore event channel and initialize the grant table entry, the xenstore domid is neeed. A dom0 is craeted before the domUs, so it is normally available through hardware_domain. With capabilities and dom0less, the xenstore domain may not be created first. Keep the population of the page and HVM_PARAM_STORE_PFN in the normal domain construction, but delay event channel and seeding to after all domUs are created. HVM_PARAM_STORE_PFN now serves as indication to setup xenstore since the device tree is no longer immediately available. 0 means no xenstore. ~0ULL means legacy so only the event channel needs setup, and any other value means to seed the page. dom0 needs to set xs_domid when it is serving as the xenstore domain. Signed-off-by: Jason Andryuk --- xen/arch/arm/dom0less-build.c | 71 +++++++++++++++-------- xen/arch/arm/domain_build.c | 1 + xen/arch/arm/include/asm/dom0less-build.h | 2 + 3 files changed, 51 insertions(+), 23 deletions(-) diff --git a/xen/arch/arm/dom0less-build.c b/xen/arch/arm/dom0less-build.c index f1d5bbb097..3b8153b05e 100644 --- a/xen/arch/arm/dom0less-build.c +++ b/xen/arch/arm/dom0less-build.c @@ -22,6 +22,12 @@ #include static domid_t __initdata xs_domid = DOMID_INVALID; +static bool __initdata need_xenstore; + +void __init set_xs_domid(domid_t domid) +{ + xs_domid = domid; +} bool __init is_dom0less_mode(void) { @@ -697,7 +703,7 @@ static int __init alloc_xenstore_evtchn(struct domain *d) int rc; alloc.dom = d->domain_id; - alloc.remote_dom = hardware_domain->domain_id; + alloc.remote_dom = xs_domid; rc = evtchn_alloc_unbound(&alloc, 0); if ( rc ) { @@ -755,10 +761,6 @@ static int __init alloc_xenstore_page(struct domain *d) interface->connection = XENSTORE_RECONNECT; unmap_domain_page(interface); - if ( xs_domid != DOMID_INVALID ) - gnttab_seed_entry(d, GNTTAB_RESERVED_XENSTORE, xs_domid, - gfn_x(gfn), GTF_permit_access); - return 0; } @@ -767,16 +769,10 @@ static int __init alloc_xenstore_params(struct kernel_info *kinfo) struct domain *d = kinfo->d; int rc = 0; - if ( kinfo->dom0less_feature & (DOM0LESS_XENSTORE | DOM0LESS_XS_LEGACY) ) - { - ASSERT(hardware_domain); - rc = alloc_xenstore_evtchn(d); - if ( rc < 0 ) - return rc; + if ( (kinfo->dom0less_feature & (DOM0LESS_XENSTORE | DOM0LESS_XS_LEGACY)) + == (DOM0LESS_XENSTORE | DOM0LESS_XS_LEGACY) ) d->arch.hvm.params[HVM_PARAM_STORE_PFN] = ~0ULL; - } - - if ( kinfo->dom0less_feature & DOM0LESS_XENSTORE ) + else if ( kinfo->dom0less_feature & DOM0LESS_XENSTORE ) { rc = alloc_xenstore_page(d); if ( rc < 0 ) @@ -848,6 +844,34 @@ static void __init domain_vcpu_affinity(struct domain *d, } } +static void __init initialize_domU_xenstore(void) +{ + struct domain *d; + + if ( xs_domid == DOMID_INVALID ) + return; + + for_each_domain( d ) + { + unsigned long gfn = d->arch.hvm.params[HVM_PARAM_STORE_PFN]; + int rc; + + if ( gfn == 0 ) + continue; + + if ( is_xenstore_domain(d) ) + continue; + + rc = alloc_xenstore_evtchn(d); + if ( rc < 0 ) + panic("%pd: Failed to allocate xenstore_evtchn\n", d); + + if ( gfn != ~0ULL ) + gnttab_seed_entry(d, GNTTAB_RESERVED_XENSTORE, xs_domid, + gfn, GTF_permit_access); + } +} + static int __init construct_domU(struct domain *d, const struct dt_device_node *node) { @@ -888,17 +912,13 @@ static int __init construct_domU(struct domain *d, rc == -ENODATA || (rc == 0 && !strcmp(dom0less_enhanced, "enabled")) ) { - if ( hardware_domain ) - kinfo.dom0less_feature = DOM0LESS_ENHANCED; - else - panic("At the moment, Xenstore support requires dom0 to be present\n"); + need_xenstore = true; + kinfo.dom0less_feature = DOM0LESS_ENHANCED; } else if ( rc == 0 && !strcmp(dom0less_enhanced, "legacy") ) { - if ( hardware_domain ) - kinfo.dom0less_feature = DOM0LESS_ENHANCED_LEGACY; - else - panic("At the moment, Xenstore support requires dom0 to be present\n"); + need_xenstore = true; + kinfo.dom0less_feature = DOM0LESS_ENHANCED_LEGACY; } else if ( rc == 0 && !strcmp(dom0less_enhanced, "no-xenstore") ) kinfo.dom0less_feature = DOM0LESS_ENHANCED_NO_XS; @@ -1181,8 +1201,13 @@ void __init create_domUs(void) dt_node_name(node), rc); if ( d_cfg.flags & XEN_DOMCTL_CDF_xs_domain ) - xs_domid = d->domain_id; + set_xs_domid(d->domain_id); } + + if ( need_xenstore && xs_domid == DOMID_INVALID ) + panic("xenstore requested, but xenstore domain not present\n"); + + initialize_domU_xenstore(); } /* diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 00bc484642..ba6bbb95c1 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -2373,6 +2373,7 @@ void __init create_dom0(void) unsigned int flags = CDF_privileged | CDF_hardware; int rc; + set_xs_domid(0); /* The vGIC for DOM0 is exactly emulating the hardware GIC */ dom0_cfg.arch.gic_version = XEN_DOMCTL_CONFIG_GIC_NATIVE; /* diff --git a/xen/arch/arm/include/asm/dom0less-build.h b/xen/arch/arm/include/asm/dom0less-build.h index 5864944bda..df879f93c8 100644 --- a/xen/arch/arm/include/asm/dom0less-build.h +++ b/xen/arch/arm/include/asm/dom0less-build.h @@ -9,6 +9,7 @@ void create_domUs(void); bool is_dom0less_mode(void); +void set_xs_domid(domid_t); #else /* !CONFIG_DOM0LESS_BOOT */ @@ -17,6 +18,7 @@ static inline bool is_dom0less_mode(void) { return false; } +static inline void set_xs_domid(domid_t) {} #endif /* CONFIG_DOM0LESS_BOOT */ From patchwork Thu Mar 6 22:03:31 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Andryuk X-Patchwork-Id: 14005459 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 10B0DC282D1 for ; Thu, 6 Mar 2025 22:41:06 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.904185.1312153 (Exim 4.92) (envelope-from ) id 1tqJth-0006CI-Bw; Thu, 06 Mar 2025 22:40:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 904185.1312153; Thu, 06 Mar 2025 22:40:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqJth-0006Bq-9B; Thu, 06 Mar 2025 22:40:57 +0000 Received: by outflank-mailman (input) for mailman id 904185; Thu, 06 Mar 2025 22:40:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqJKB-0000Ss-C6 for xen-devel@lists.xenproject.org; Thu, 06 Mar 2025 22:04:15 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2062f.outbound.protection.outlook.com [2a01:111:f403:2415::62f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id eea46da0-fad6-11ef-9ab4-95dc52dad729; Thu, 06 Mar 2025 23:04:11 +0100 (CET) Received: from BN9PR03CA0068.namprd03.prod.outlook.com (2603:10b6:408:fc::13) by BY5PR12MB4194.namprd12.prod.outlook.com (2603:10b6:a03:210::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.19; Thu, 6 Mar 2025 22:04:03 +0000 Received: from BN3PEPF0000B372.namprd21.prod.outlook.com (2603:10b6:408:fc:cafe::92) by BN9PR03CA0068.outlook.office365.com (2603:10b6:408:fc::13) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8511.19 via Frontend Transport; Thu, 6 Mar 2025 22:04:02 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN3PEPF0000B372.mail.protection.outlook.com (10.167.243.169) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8549.1 via Frontend Transport; Thu, 6 Mar 2025 22:04:02 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 6 Mar 2025 16:04:01 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 6 Mar 2025 16:04:00 -0600 Received: from fedora.mshome.net (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Thu, 6 Mar 2025 16:04:00 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eea46da0-fad6-11ef-9ab4-95dc52dad729 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xcsW3wdzI+XDR2piqXad7ZdUfq3ZY/rcJLCahasoTxYKJHp1K6gjAqUOEMzngL0XFhS7ytPF9GZXkR9palzqw/hJA7bxfW6shsjCvQBi/qDn/kdV/8onqwR342EMtU7tkU7BWFjVRdFwqaDCbTx5C5hh9cGTI1l5hKW2D6xvx/zLI3FYk7kW/lGc/oGPeh33xmcga2f0T09EEg/OuA+zOldAnmjlf2niMsK5pB+p842A7IFNjii6qeI5NqLZoA2cet2wWfZUZXvQiCNfOaN9PuUXIsH/dzY+ixS8XpktxGM8zJHy8eEGL8A2wVjCtbg4MZAIwhxVd7wuYS61gb2SGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TIFP0yUwDgWt/wxdaqwbVpnFqSs0Z5n/kZ01lqaZPKE=; b=uPg281JgquqpLDpTLIHKCBxpFFVjr4C2jzLjtIF04srQc7ghytxiLoKkKI+xb1YH9W+bIBuqQe77VqxiHgrAumJ3kqASiOPZwz/bk/qhLFEtGb1XT9Lds+J9V9ssPamCqPOZ6q5dG9K+z1sTfUMEe1faBQNKqQdQnhrq/S9Le5Y8ft30Yyxw9fRvkIy1KqObT10uKtthn3o3EiWl3R3rbaFzjLWVQmZWMNxgs5Y+2njbhUazb0yC7NJ+G4KpPbyROBasMQh0b4RJqmf9PQHZJ5fwtozpnb/XaEddQ0nIh+YbGtO1/Wi0wu8cZGAVK1oleD1HifohFkul4uj/ElYodg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TIFP0yUwDgWt/wxdaqwbVpnFqSs0Z5n/kZ01lqaZPKE=; b=092s0rQ6L64f+pe+2pm9VHlkpd/nQx10oMS1rB6NXFEnOm8DuDKkIFEDoJTxHB2a/wpMZ2gNR2nkPBoKlPMWSv+MOlDzAGaGS2h/kBLElYEjTzeZtZvX2A/WYIjK3tFb5eTQnmESlHWo1KS7wJdh6PxM0ZlUnDHBugz+33gwEuI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Jason Andryuk To: CC: Jason Andryuk , Juergen Gross , Julien Grall , Anthony PERARD Subject: [PATCH 11/23] tools/xenstored: Automatically set dom0_domid and priv_domid Date: Thu, 6 Mar 2025 17:03:31 -0500 Message-ID: <20250306220343.203047-12-jason.andryuk@amd.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250306220343.203047-1-jason.andryuk@amd.com> References: <20250306220343.203047-1-jason.andryuk@amd.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B372:EE_|BY5PR12MB4194:EE_ X-MS-Office365-Filtering-Correlation-Id: 49ee64c7-4221-4b6c-ebb8-08dd5cface3f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|36860700013|82310400026; X-Microsoft-Antispam-Message-Info: 9CrEb4EI1H7/V5m3sLXdI/wcPkcSf+U6WukhW0Bgzr/J4zRTRfpn47FGDYF0xv+X7HwWNDG9yXZIWyBGc3gNy/RI4szzANb5x6dJvLfJ2nkj947tZwFnh80qCL46oHCjU9W7Aa3qgW1y+WkIUbyyjQV6TSvfCyKEd0SOW3B8MpO0lt8S6n0u2E6ZmCFHCwSRoDRqArYq7jA0oyOmiSEteJFi5vMAqlTUDrLJ8dsQXaMZOXs4OjKALRse9CzC2YiSCEvLQCIJRAy0HXAkW7R45L9azEZZWpFPKpuneXqW6blAH2h9stg4z7JJQZuh4jH31ms5+ThL0FZCGOZPGk5bH7W+Zi0BUlsdj39QhWIt/CUrJivRRetz3jWL87txSFXnpJBfYMT/c3oohzncJBSqXtosruwIUve8OoOmKLcHoX2vSPA398fR0CCVNgF8EZWHN+wg7RLwDdUw9ch9odjQcrXIQec2/av18stATymskr1UwxEvzx/AQcLW69NqctnVY2TAiYz3sWaQgwk6KtrpW3gzGiQag/FeddnprpvhOawm+8kldM+AUuHBH7t6nPcCMqsU1oLPl9EW5PQG2YTtcvE8ZjdKoaymGxw9jes47jBfQcg23yvyX+v80K3cTDHqCd1fOGIku2t59AucXtflmfRHpPLtVACDPJKDiIdoZnLsRUZ5x7haXvg7jNB6b6wExiHhqw/OIvpMDcZYrZPkvhsO517JW1pl8lZ5LWU+lV4+gH3i0FcAbz7quheCIlUXKhNAEiMvBhTJGFKu6IrgX36uThZiV/aiYfZLajgYYthWArlJ8TsdFTedIGXmfeO7sUHQ8k2ZPg/AA7G2GHQUoCJPKHqmiRR2DBF2SMdvXnuZ5j7mN4UDdJ5cLQ07QJwvn9lUy10aZimJxcZRDpCnyyARJNA7NNyKVR+TSj5vLA7Ab7MLIuxxmUDr/Eksc/1AiWTDrW7GTOqTJ23RmvwpjqtVCAzhnzc6+aDNsjwaEa0Qn4A2Jr7BkGy002regU93ORTGoAWJK4T9Y5enRo4EQ0mWUhLJMn0Zef9SXnnJ3VfCudp87H5PZFeeLZwVBdP6fDPPSAidsFlwiRz0bFMnMIMSsUlIFLCXdbOseYYQez1sapuxXgCXexBoMkx41+/pMugph1+Pwj43EGkSto9lCxqyo7NLi1bzyxUZqRRgD4LPdW8+OE7yiqVzZnYnItRcPc9ce+whgxlEZsRGd5oEfFGW3cMW4nMGLlwrnqlvXjbsQSMoY1Y4EnpjDvt748OCSL/hXnkcc0o292Vt5szjUt/CNJD4zpY21AZVVYc49+ExYjXgg9PhRtA0jRYLoSqou7QW5K7PEuGqH7/dhXOamWwFOhgB3PtD0tJAl9aDDRhTRxgaG3B235Q8HJnaO5WCThhY/z/XszcK7vFNKvz5ZGOOvvdui0lkMBFx4cXrXqgRu7AR5v2/c1PZ9HI87+847j/Eyj4C/fvWcbQCcYhhK0jy3lSVYgQqKhogCdX6RwQ= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(376014)(36860700013)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2025 22:04:02.7884 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 49ee64c7-4221-4b6c-ebb8-08dd5cface3f X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B372.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4194 With split hardware and control domains, each domain should be privileged with respect to xenstore. When adding domains to xenstore, look at their privilege and add them to xenstored as appropriate. dom0_domid is used for the hardware domain, and priv_domid is used for a control domain. Only one of each is allowed for now. Signed-off-by: Jason Andryuk --- tools/xenstored/domain.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/tools/xenstored/domain.c b/tools/xenstored/domain.c index 64c8fd0cc3..f2394cd6e9 100644 --- a/tools/xenstored/domain.c +++ b/tools/xenstored/domain.c @@ -795,6 +795,20 @@ static struct domain *find_or_alloc_existing_domain(unsigned int domid) return domain; } +static void domain_set_privileged(struct domain *domain) +{ + xc_domaininfo_t dominfo; + + if ( !get_domain_info(domain->domid, &dominfo) ) + return; + + if ( dominfo.flags & XEN_DOMINF_priv ) + priv_domid = domain->domid; + + if ( dominfo.flags & XEN_DOMINF_hardware ) + dom0_domid = domain->domid; +} + static int new_domain(struct domain *domain, int port, bool restore) { int rc; @@ -831,6 +845,8 @@ static int new_domain(struct domain *domain, int port, bool restore) domain->conn->domain = domain; domain->conn->id = domain->domid; + domain_set_privileged(domain); + return 0; } From patchwork Thu Mar 6 22:03:32 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Andryuk X-Patchwork-Id: 14005401 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 577EBC28B23 for ; Thu, 6 Mar 2025 22:04:21 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.904079.1312069 (Exim 4.92) (envelope-from ) id 1tqJK8-0003Pj-DY; Thu, 06 Mar 2025 22:04:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 904079.1312069; Thu, 06 Mar 2025 22:04:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqJK8-0003Od-1r; Thu, 06 Mar 2025 22:04:12 +0000 Received: by outflank-mailman (input) for mailman id 904079; Thu, 06 Mar 2025 22:04:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqJK6-0000St-S8 for xen-devel@lists.xenproject.org; Thu, 06 Mar 2025 22:04:10 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on20630.outbound.protection.outlook.com [2a01:111:f403:200a::630]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id eccbd21d-fad6-11ef-9898-31a8f345e629; Thu, 06 Mar 2025 23:04:09 +0100 (CET) Received: from BN9PR03CA0081.namprd03.prod.outlook.com (2603:10b6:408:fc::26) by CY8PR12MB7609.namprd12.prod.outlook.com (2603:10b6:930:99::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.16; Thu, 6 Mar 2025 22:04:04 +0000 Received: from BN3PEPF0000B372.namprd21.prod.outlook.com (2603:10b6:408:fc:cafe::d8) by BN9PR03CA0081.outlook.office365.com (2603:10b6:408:fc::26) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8511.19 via Frontend Transport; Thu, 6 Mar 2025 22:04:03 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN3PEPF0000B372.mail.protection.outlook.com (10.167.243.169) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8549.1 via Frontend Transport; Thu, 6 Mar 2025 22:04:03 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 6 Mar 2025 16:04:02 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 6 Mar 2025 16:04:01 -0600 Received: from fedora.mshome.net (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Thu, 6 Mar 2025 16:04:01 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eccbd21d-fad6-11ef-9898-31a8f345e629 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=igBb/rNrJJtTj1OVw/FAjL+qntAwp/wMHNGkLxU36W0poKfz8Li5/B3WvTJ2UnE/7zdUV9yViiewLHaf8Tds4oH0R5cKRy48SJhesxYe4dUir50kx5HEgjKZYmUFdU5lw28ptdChd37K3zcPbE/WlT0lpFGbtQn1qlvgCs+l/+GG1+uSc+e0OZ8jYiLJA+GdBeVd+NjIcrD1+KS0jrwODlGD7nAsUOcSrEiWDGhOMji8beJ1Xw6/nxfXS7tKuLzNZfKP8QTvZZx/4TAhlW1X+3r9tjVqBoLyaFhyKtQUmZ9olWApidzqPPO+XoU0nEjp1FekSy648/kA6JRx9ViC1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u5QzHpUS/M4+Ej+uoZdfWGBbOum8MFaCVgkFfNvjpZI=; b=O1RpEQEogXejU97OBOdMxGK9X+5NceV1ObfC/5N15vaOflLUInXfr2QjylM7ALrtlEL3LZpFQJgAtAy8aKURnoAAYs38bBQE2ZwbaD4MwUKUXRn4u4XpgAB9zu6CZZbo3KDzT5Y+Sxxb3XkKIHkUO1gd2l0WtNQpEGEiLwIXGn27FUsW73zG4IOWa8g9yHt+5MsBqo0eUsxY0jPbQz8OHK24Stok5NwRXUnnlO6CkkS83aBo23hXBBRHZ1o7633V5KNMT0LnZHQav993wUebvdtjc1sq38XIycXi2yHSSm2vBmmKRGvJoqZRqYMZHfDmz0s176DfVrj4zrT+Bb3tCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u5QzHpUS/M4+Ej+uoZdfWGBbOum8MFaCVgkFfNvjpZI=; b=gMI8h3EsNOSj+TPbIOAB5KoSsQAQwF+0r4GecsOgoduHmWBU86zV+Sw05kXlQsJiEzmnIBqSc0Sa9a+2enqkLdiVyzSvq2Ptcy60uGMOKZ5wNU9yah3op/Zq1o02UVaeJ8upTyPajc8ncOQTCUkzgdd5qDkg+IrR6ZLbLJ/qzW8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Jason Andryuk To: CC: Jason Andryuk , Anthony PERARD Subject: [PATCH 12/23] tools/xl: Print domain capabilities with verbose Date: Thu, 6 Mar 2025 17:03:32 -0500 Message-ID: <20250306220343.203047-13-jason.andryuk@amd.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250306220343.203047-1-jason.andryuk@amd.com> References: <20250306220343.203047-1-jason.andryuk@amd.com> MIME-Version: 1.0 Received-SPF: None (SATLEXMB05.amd.com: jason.andryuk@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B372:EE_|CY8PR12MB7609:EE_ X-MS-Office365-Filtering-Correlation-Id: 570705b2-b948-4482-3561-08dd5cfaceab X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|1800799024|82310400026|376014; X-Microsoft-Antispam-Message-Info: XfepmS+/jEpYvu4lv01+myQGRIaYEXrXeSn6DzfUgwgMOZmhAS1B7bEUmELjeczAH5/q4U/Z3Z195AzemLpIoi3eSJWSdeh/uT2tmXInX45qqNMWDgAs3Kd7N1liIVB+8tsYKVkhidFnC3fe/5uGyEnK4B36tBYUEOMVAagWJ2lNN6y+pkFxI9Taur4KaCgdfcaZRcsrKpieW2cvJvQb6rncUvq1VW2045bBZci5eAdvH0CcfOj3/j7fHLI9uynsEMiAF7mBeHLdP2QlrZv8wfHNtkVcz3J5vk8oDLRnixLPS6zO0lQTQtwUqJ/2BFY7KuvCs0ap8Kuh/kYRYJeUxtsRG9tDTbiN2TM23B1raRnrHXlxrqfLypLZCXwdh3t9Ta3dzOZQbWgfY/My8mOc2px1X87k3iQ2nJsPUo2W8gEAOER4GEC2YlcLShvtRsdDRdTOcVtSKH/rsw5YYQn00/Xa7u4kZBFEsNg+8ENFmfMTCWr5BSwEsdt4BAGmQpOC+FWwrDbrSnuG04V+Rh+mMDfQKHNNME1MMOq3/Z1k5RG9LL1heOB9Fud7vfirzKQxabC8/Yn7rQOo0tFpARZi81YP9AAVs51C5euB7eAresIoyDajBIYXHMniuP0DwkS5Ut64jvePe22HpUCub3381zmgGxfpEZ5aB19s/SaapY1d9CSK8LhhxtX3QN3ZhK8r3ADDYiScuB2jNoJpKEhVddtE5/5kAMzo2EaeoHXs4NVNnhCgYmODpiO2elqWMiSFtLxA2xAcG7UX0rrE6mgfStvggLSzeeV8rlGCBoFMiy6fN4iZbHSq2oMz75JVNajvqcWURfmWJFJXE6CAaysSIrSslUxaRVFE2Ygmi0C7QLaUlq3uhNxkFJPxK2UXHTJhdJ7DcTaDWdiXOSX1+CQbFs5b6LyO5aPU6BCJzwE5mBhVKA9PDx5+b+lWd7xVtUsjhU/loW/+W7IAAnLyKKv4ijNaFXFvlPUL9d7zyVvFwurz9JKqPAlno5rQdX7los2UrZqw6zyX2iM8hN1Lcy4u2MC4mybwWHil/yAa+JqMxOKHMFMacjTo5eQzFbXqH9qi6oSumjlakXB4mwkVph+sDFHxRPf2EF7sKNddHQ6BMAfs23ZrU2KxX4aGb2Q2hYXBQwA4w8iWum/F9qj8NxotHs4bZ9eahYXhX4zP5XitfGoe66Ab+Pc6rATD8LFL19Qw/hBt1fghI7HFgZPPd8a2vz0Zvr/pH759uYJt91yUoaH92vzl39to1w8NxucE+ZLCX7fLWHoHAaO/Lv2814kqv2sK5WBJ2n0dsca7TzUDgiOVSwug4gwpXD5+QEd57Jy1Uagxc7E9ul6+LWmaXvu31Bh2htg95h/SWwFzfBJVAXrePqV0nLR6IC/dNvRFCCiKoQqHfXAQQP7cuBWd/P9BNqGc/ONN5DQVHLK5oTXRtgNK0knrrVhCwvOmR3aDmJZlib90sXM9VLkpwDdodv7Ycw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(1800799024)(82310400026)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2025 22:04:03.4915 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 570705b2-b948-4482-3561-08dd5cfaceab X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B372.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7609 Capabilities are show like this (long lines trimmed): xl list --verbose Name Security Label Capabilities Domain-0 - hardware xenstore dom0less-1 - - dom0less-2 - privileged Signed-off-by: Jason Andryuk --- docs/man/xl.1.pod.in | 3 ++- tools/xl/xl_info.c | 24 +++++++++++++++++++++++- 2 files changed, 25 insertions(+), 2 deletions(-) diff --git a/docs/man/xl.1.pod.in b/docs/man/xl.1.pod.in index fe38724b2b..8e253180a7 100644 --- a/docs/man/xl.1.pod.in +++ b/docs/man/xl.1.pod.in @@ -313,7 +313,8 @@ Also displays the security labels. =item B<-v>, B<--verbose> -Also displays the domain UUIDs, the shutdown reason and security labels. +Also displays the domain UUIDs, the shutdown reason, security labels, +and capabilities. =item B<-c>, B<--cpupool> diff --git a/tools/xl/xl_info.c b/tools/xl/xl_info.c index 72e87eac46..3e3a793e12 100644 --- a/tools/xl/xl_info.c +++ b/tools/xl/xl_info.c @@ -384,7 +384,7 @@ static void list_domains(bool verbose, bool context, bool claim, bool numa, libxl_physinfo_init(&physinfo); printf("Name ID Mem VCPUs\tState\tTime(s)"); - if (verbose) printf(" UUID Reason-Code\tSecurity Label"); + if (verbose) printf(" UUID Reason-Code\tSecurity Label Capabilities"); if (context && !verbose) printf(" Security Label"); if (claim) printf(" Claimed"); if (cpupool) printf(" Cpupool"); @@ -443,6 +443,28 @@ static void list_domains(bool verbose, bool context, bool claim, bool numa, putchar(' '); print_bitmap(nodemap.map, physinfo.nr_nodes, stdout); } + if (verbose) { + bool cap = false; + + if ( info[i].privileged ) + { + cap = true; + printf(" privileged"); + } + if ( info[i].hardware ) + { + cap = true; + printf(" hardware"); + } + if ( info[i].never_stop ) + { + cap = true; + printf(" xenstore"); + } + if ( !cap ) + printf(" %17s", "-"); + } + putchar('\n'); } From patchwork Thu Mar 6 22:03:33 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Andryuk X-Patchwork-Id: 14005452 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A1BF0C282D1 for ; Thu, 6 Mar 2025 22:40:44 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.904166.1312124 (Exim 4.92) (envelope-from ) id 1tqJtO-0004u6-FB; Thu, 06 Mar 2025 22:40:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 904166.1312124; Thu, 06 Mar 2025 22:40:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqJtO-0004tz-Cb; Thu, 06 Mar 2025 22:40:38 +0000 Received: by outflank-mailman (input) for mailman id 904166; Thu, 06 Mar 2025 22:40:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqJK6-0000Ss-Ff for xen-devel@lists.xenproject.org; Thu, 06 Mar 2025 22:04:10 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on20624.outbound.protection.outlook.com [2a01:111:f403:200a::624]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ed4a76af-fad6-11ef-9ab4-95dc52dad729; Thu, 06 Mar 2025 23:04:10 +0100 (CET) Received: from CH2PR04CA0021.namprd04.prod.outlook.com (2603:10b6:610:52::31) by IA0PR12MB9045.namprd12.prod.outlook.com (2603:10b6:208:406::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.19; Thu, 6 Mar 2025 22:04:04 +0000 Received: from CH2PEPF00000148.namprd02.prod.outlook.com (2603:10b6:610:52:cafe::30) by CH2PR04CA0021.outlook.office365.com (2603:10b6:610:52::31) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8511.19 via Frontend Transport; Thu, 6 Mar 2025 22:04:04 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CH2PEPF00000148.mail.protection.outlook.com (10.167.244.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8511.15 via Frontend Transport; Thu, 6 Mar 2025 22:04:03 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 6 Mar 2025 16:04:03 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 6 Mar 2025 16:04:03 -0600 Received: from fedora.mshome.net (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Thu, 6 Mar 2025 16:04:02 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ed4a76af-fad6-11ef-9ab4-95dc52dad729 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=I4heVTRoCaIPkh8WxY+fu/KCScys07aGovr1WtdUQVPPY4wWBzdrbQHp11+qduIaT7VlD54hZYUe4bbnuAIUrJAS2PnsfUjmg5oAeZ4gVgv9Iu3JTunN2PvyV1bE+cHBiXexj4jgpMgNH4OKnbkrgR/ocupKI3UyW4ioXdhua2yBuPpXqJEN49bGTmTC07Mh9pMTxXrmwBg5lGKqXQ+5/9dU3F3J0Py/dRKhwkTy/SP36/yXhqWJVtVPUO+UIaF6O9YKbyrKDC4+VCBNV/s8TpwxdwvPBs+AwmPF8EdnPKZyvAmHVZErnpBJL07PiqSPIR8zgRqr5J7iYRFHXPeWyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a+wqA1FDBIcJkmJckULDK0wV4r8kvoqJuoWnZDlDBCI=; b=K39F+RHrYyZ2eIQbrcHH/uLPLCu8fq8GswYxfy6FiNmNvb5rezjix+76322KD89f6r5YRGAGwEAvgDGlRqJPDZqyTD1lzHllbm6AqxrB4yaX+aRGq/UDwQaVbiYQVZ1Cj8LiySW8Nq8NIiadbC95xTUX8hhxN15qimOEHJXn8dCWfUP5BXOTwz+vmW0uOz7GAQy2luJFHNhQUdqqyKpYvsgoEa7863cBsEPTZ0iYgu0b+iz/cg9gtuzC1XBvCYB3Zc0/DN3+hs1pInHDcZsMsrkMjAecz9ZGXOxfrI93WlTYffqVokSTE7zLUzdY8sX6uE3/U0sUAliqf9Sq9G3Brg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a+wqA1FDBIcJkmJckULDK0wV4r8kvoqJuoWnZDlDBCI=; b=QVG3MNF68om8nIbL8N6Lv2kSb/Q30F7KTF4K2bGSxde+Bs7ITHNVBDiXUZ6wjeX/w4VY7+j9S+jbBv1shPNWCS2yOIkG7gKzExdDdlEmYfz+adjK0ULy+7mJFFZMhMCNF5foMaC2xeu3gDnAJ+0rDAiVxbHwBfxbrqvq5khCGy4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Jason Andryuk To: CC: Jason Andryuk , Andrew Cooper , Anthony PERARD , Michal Orzel , Jan Beulich , "Julien Grall" , =?utf-8?q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , "Daniel P. Smith" Subject: [PATCH 13/23] xsm/dummy: Allow XS_PRIV XEN_SYSCTL_getdomaininfolist Date: Thu, 6 Mar 2025 17:03:33 -0500 Message-ID: <20250306220343.203047-14-jason.andryuk@amd.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250306220343.203047-1-jason.andryuk@amd.com> References: <20250306220343.203047-1-jason.andryuk@amd.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PEPF00000148:EE_|IA0PR12MB9045:EE_ X-MS-Office365-Filtering-Correlation-Id: 0df5cde2-da36-490a-d8be-08dd5cfacef0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|36860700013|1800799024; X-Microsoft-Antispam-Message-Info: Cos1XVbNliabPKmO1kYDt41Rr5KhQiu4IY1X+1BFRVMTlNzo46Sqrg9himpTfI/wLU+BsrrxSD7nJFX2h1OhQBasKt+pBmBYaLHiMhjs5s/rPR8bv7govhBhxRdUPmpNJCxCTckib9dMbxTTjvG2KJm3rbfRQ3EzJKndNZQKSj78bCt8rjpFycqZB83AuT90fBwZjEtI0eiuiSiAqyiWdCORLLutijhZfUNxx9E5ORvtR283HqRhyBaNNpvNvijB63OE+JA1LsG9YA/C7kuJvTMwGDcy5mK2HZT4Ik/1zmRYlnkBv1W7nillxqf8j1C+UPm/QRkr2KXcCi3VWF0cQbr/agOqeh+YdUClQweheZTQ5xJhSkskSdDX47t6Ws6bSQ8XmyuqfhDmPn5WjMRr2IHwSJ+borsChnsgqd9svZ9PmdqA3ckJvVr00cIKXP9jjuD/wpC4PwsfbMQmVvqfTeI/3Dak14Fi2FSENksToMkBsIw4Cz76KY95ZFiCtFPnhbJBaLQv1Op/C3IGwGUwaRmAvQaVnKg1IkZ4A/o2u285Mzd0RjyX+npOUbeQbkGtnsOUt3dAjcG5BOqRKeLlQRxqQT4p1HR9HqFJaPwsLcOOKVtbhV8Pmh0tJHckZ9LV0r9OTWwjrJuyJuUaHpqvEzMXNxrWaEBGSdsy7ipn2xEiZ+Txsb6fLRKUHqWHGA4PJXIv2EAG22vQ9LJPj/8GslEhUaxOgM0SxJqLeXK7VQjS+UsG3dqTLv1SNPcz5fIwc19CvBdiARvJLIDIis5aVC5GiGNsj4R5M6f7iGfdCRIu2Gq/88hWcS7GAOOJ8lL4NSbe4sWcc6l2hzP3lDrkDDjaQfMhAbI7EmtmrdULLIh7zxrYeKlZrDHtYxPgHM8HItkuTATk+W7ACfVwAovr2Gzj6GMXcn8/aHEpEdb8DwVEXyH4g5mSaZ0Rrk3Lto0yOZwNGGgkDgaf5JEjPd7ml/cysgDhoM6xzUvdkHCJRys+LZwLFZeVNgy8mtIDdys+wyR6ReM/vRqxpmz8cjA0fDlniVH9FF0r+l7l45/tLsHZpRkOqEX26jQDCx1tVdIgh3Hq3BmbM9TpMCxTDUhOpdZogMmzdTQmoVLxFrJC6isENp4j/kv87MYL3eYds8o+6i6fZNrD+hZwzPWb25vIUrKvfxU+49Z+HR2mSgz+GNUyU8/ncdp1ltn+8Qo5vCOKHMq0+19Z3BmH/hVEgnFB5M9UItUw/gKDVf8P5m9G1+/7u4AsvlUpw5fn/Ry9ETYREJg0AK0/kxS9aOXBHvHzPNRdAdwdwhNTA9ACinUX1wwl73sCkXFh+WIf4P6BRAMH0EgCIOL/eUqBk2eecmOlJtCSwhEficDFiyupj3i8r6pqhwcsjDDka6O4OEzLkEz/Hs+ym9y2is3qiVy/vx9kOe5Ql1VCkl8WjYYSHgjTdpAPVLoHGNzxb32EEwjzxRtzaNzrgWiWnXNheoiz8vxNVGhwxIfrET5iYr6A9g8K+88= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(376014)(36860700013)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2025 22:04:03.9167 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0df5cde2-da36-490a-d8be-08dd5cfacef0 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH2PEPF00000148.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB9045 To hyperlaunch xenstore, we want it to automatically introduce all domains it finds while initializing. To do that, change xsm_sysctl to allow XS_PRIV to call XEN_SYSCTL_getdomaininfolist. Xenstore can already call XEN_DOMCTL_getdomaininfo for the same information, but it requires knowing the domid. XEN_SYSCTL_getdomaininfolist eliminates the need to guess domains. init-dom0less also calls XEN_SYSCTL_getdomaininfolist to determine running domains to initalize. Signed-off-by: Jason Andryuk --- xen/common/sysctl.c | 2 +- xen/include/xsm/dummy.h | 10 ++++++++-- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/xen/common/sysctl.c b/xen/common/sysctl.c index c2d99ae12e..89d5176f4d 100644 --- a/xen/common/sysctl.c +++ b/xen/common/sysctl.c @@ -42,7 +42,7 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl) if ( op->interface_version != XEN_SYSCTL_INTERFACE_VERSION ) return -EACCES; - ret = xsm_sysctl(XSM_PRIV, op->cmd); + ret = xsm_sysctl(XSM_OTHER, op->cmd); if ( ret ) return ret; diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h index 6a2fc33c3b..f2d6662a9d 100644 --- a/xen/include/xsm/dummy.h +++ b/xen/include/xsm/dummy.h @@ -181,8 +181,14 @@ static XSM_INLINE int cf_check xsm_domctl( static XSM_INLINE int cf_check xsm_sysctl(XSM_DEFAULT_ARG int cmd) { - XSM_ASSERT_ACTION(XSM_PRIV); - return xsm_default_action(action, current->domain, NULL); + XSM_ASSERT_ACTION(XSM_OTHER); + switch ( cmd ) + { + case XEN_SYSCTL_getdomaininfolist: + return xsm_default_action(XSM_XS_PRIV, current->domain, NULL); + default: + return xsm_default_action(XSM_PRIV, current->domain, NULL); + } } static XSM_INLINE int cf_check xsm_readconsole(XSM_DEFAULT_ARG uint32_t clear) From patchwork Thu Mar 6 22:03:34 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Andryuk X-Patchwork-Id: 14005463 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4C15C282D1 for ; Thu, 6 Mar 2025 22:41:35 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.904246.1312194 (Exim 4.92) (envelope-from ) id 1tqJuC-000142-NR; Thu, 06 Mar 2025 22:41:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 904246.1312194; Thu, 06 Mar 2025 22:41:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqJuC-00013o-KO; Thu, 06 Mar 2025 22:41:28 +0000 Received: by outflank-mailman (input) for mailman id 904246; Thu, 06 Mar 2025 22:41:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqJK9-0000Ss-Bn for xen-devel@lists.xenproject.org; Thu, 06 Mar 2025 22:04:13 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on20600.outbound.protection.outlook.com [2a01:111:f403:2413::600]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ee36c560-fad6-11ef-9ab4-95dc52dad729; Thu, 06 Mar 2025 23:04:11 +0100 (CET) Received: from BN9PR03CA0087.namprd03.prod.outlook.com (2603:10b6:408:fc::32) by PH7PR12MB9222.namprd12.prod.outlook.com (2603:10b6:510:2ef::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.17; Thu, 6 Mar 2025 22:04:05 +0000 Received: from BN3PEPF0000B372.namprd21.prod.outlook.com (2603:10b6:408:fc:cafe::7) by BN9PR03CA0087.outlook.office365.com (2603:10b6:408:fc::32) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8511.17 via Frontend Transport; Thu, 6 Mar 2025 22:04:05 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN3PEPF0000B372.mail.protection.outlook.com (10.167.243.169) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8549.1 via Frontend Transport; Thu, 6 Mar 2025 22:04:05 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 6 Mar 2025 16:04:04 -0600 Received: from fedora.mshome.net (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Thu, 6 Mar 2025 16:04:03 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ee36c560-fad6-11ef-9ab4-95dc52dad729 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=M+duMxeKFPY+K2EpRSRoDLL047tDFglfbWulRwOx2yNLxEoI4yT7jqnowhSn+QrNikdjo0GZNsqN6XnR0wQ+yKP5DjOwDhvN9++7Zj92yHVXFERDnYbxAKqqccbmgVj3h6fqChgpwgGnaBh0Jy4zNlzlcZwCDDaQGFCmqTCHxooQ+7Ffakptw0x2boyLO8TW3l7nZSl3v0n0ONi0JVJmb8k+AIC0lYcJHbHKO1n3q8f6N9GGoke8f3HJBdHwjUlhcI7fEHte1vSye1XtrdIlk6TlSYgBM8yW1SfLR8BJ9p+NjBvjBMahjc45xsxWWjB76h3Z6FzwAgSkjiE4HNmMTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TNgQrZnx+1brlKFiQ9NUOt1D3BsJYWITfDLiw9hTcZM=; b=SITUgxldZs16Fi75BN80NqQboE/qAziRO4Eevh2RSgz55Z+TVBM4qLRktuJcjlFcI4aqGAgurioDtqR8g3aqxyb7GgIHX9Hc5Vk4QBuNdb823uywL7C2Y/Kj2AxSOQJAkrUh8ymlM4rHJYRDN9pUQQzYD0VM89hrXVeVk8NjBj1JI9zbDPpFJBdINNlei3ULK+J2k2HNy2JDR9FmO/PsFQPQY5FALkya9dlmEYofuAAuiG7TYkomACHEc9GUkZqimIu8wFRX/b5s9N1H6mNl8FyworqXkT6gMRNZs1EBg9lL47jjMzZzA81/pbK8CbJU5gk1i6xrKHC61ODz0RNt5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TNgQrZnx+1brlKFiQ9NUOt1D3BsJYWITfDLiw9hTcZM=; b=YVBII0jL2M0g457n5fYBXk1Cj7DxocpvhQ5agcu6X6UxIHfvJFOUmCge4RG9SRt4plNtmhWlYXDTsEqGI0BCuOhLAeTYEh78kpyQqFX6uijYdF4BNcLHbM37u0YVg3d+8umsVzCZ/dv8iLh5Z8NILCY/t/ao5s5k0larGqDtUpU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Jason Andryuk To: CC: Jason Andryuk , Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , "Volodymyr Babchuk" , Jan Beulich , "Andrew Cooper" , =?utf-8?q?Roger_Pau_Monn=C3=A9?= , "Daniel P. Smith" Subject: [PATCH 14/23] xsm/dummy: Allow XS_PRIV to call get_hvm_param Date: Thu, 6 Mar 2025 17:03:34 -0500 Message-ID: <20250306220343.203047-15-jason.andryuk@amd.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250306220343.203047-1-jason.andryuk@amd.com> References: <20250306220343.203047-1-jason.andryuk@amd.com> MIME-Version: 1.0 Received-SPF: None (SATLEXMB03.amd.com: jason.andryuk@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B372:EE_|PH7PR12MB9222:EE_ X-MS-Office365-Filtering-Correlation-Id: fa96a43a-dcec-4fc3-1228-08dd5cfad00c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700013|82310400026|376014; X-Microsoft-Antispam-Message-Info: A+3hxxMl1yIA4nqaJNKLFOy1KzHOLdrLaI5ddjzCy2sVS5PV99/WK7n6P7ss7O9hkkSMIfiK9UgkaXMvfjKrzidQnXYueHlbg3P/oTpvQek5NRq/27v1H0Cl1hjPXP7/XXrIcj6tvkXMV4SZSm8u53DKN6B3di646Ufgqa1olGLx8HgMUyItTCnIPIcFHgn0Y4o7Pngy+JUVLQ5snTjPPt5Akwt5hs+QQZ18GP1JlENT5meQKH1jeScMyVp0mOKjnKfx6945l/sC73TLYhPte5fGJ989Z71wUDBl6GsvoK5ppAqoqG6uiIcjxG/+Yals3EUwoOl1sp24VlTCSGH86GotGQ7OAxTvKKDiNmRdp45dzBwv/5EgqjIX+rsapgtXD/mAm+bwPGuZ1gszuKmETgfJfQYesR95wwJrQVn2wPymYAIM+VCgTKXUjD9oiROxosHzAKpP0SzJFhTZswaOOWKatsEAlOOi3Yobl35Tq1s6VjY+qSBdLuqs9L4esZhRpcvE3O2RLZzKmDXWMqpieGOGo14SxTirDJ+XIXJ8YYwT8eMR696uxOc+o1Lslj8bTmWSKftu4goiZNtEg8BWCAdZX80rIsJE115t5ZYZHb8jaIxf4IL+/IezwJeL+lZufdaWFoS7D5FyfO5d7s3gkNIAfsDjL13Dea8Q6/U990ae/OTDlcIcwztEf/jtP/OVs9Qd6KKvRaEvXFLwizUM+r9iLGtWlDe0zInWqx67vZJb3s4BwvmAUIP4T1S/TpwAiy2do3LpWE+0SiXXn8kW1g5HYEaJ9JxSuhl7pi9tUQEloIAXEDhKKVqy3OCcCReSKgzMeQ+3gc8vWNRk/iWB1fu8T4zV9zFuKnxkFNwAox0SAsXs2/cI6n4f4YpBsedn0VCVglLzB68RafxCePg91OnwE1KIZZ6Y+SNwqPR1ie8BhCPGem/XmKUloqbduieBJGVFpGgTDOUAdWaS4Lo7LCE10E87/o6v12lNBc6RkXei6T5MyObK0DRjpA0u8fWpRrAqbziK/kbP0ILLDcfu7dKYzpZSu/SvI8+3H7V3J2S6G1THLupGytPSKrycr6IM2JZmSMquPIXC1ErcHRNwGt8q+9Tyic4cEe4ZZgvK3q1Cl0CC+9yhOXnRrX+Lxgk/2JuDzrPE4PCTlVHzk5gH9sYwpB9IGVdCgu+pu0MHJXwZxRhrydLf+EctXjMVmQ21kUzLQzkgm/zrMpifMNB36kxMzC/h3X2UpwFhhTb1phiXy/LsBnRZcYC2hBIyqQE43XQ+Ve84KXRzzZnGjk2WH8Qoxe2chYD/DzpdrLwmZa1DhWeh6dcssiMuw3PVS5LCUGn3xIokuNyPHS3oj7+cw0eGJvKtNeWcYAGmYgsh8qSpYr4P1mDUuZmdFNV0vRUAugaCWznHfwhVXAulR57oFW8eQgij0fCOex597K+s9lUDv8ogUp3Qf7mMOSe6nYZZZtcBZcdlU7yBezmoup2CKxxLbC5JCGTy8eluEKI2uqc= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(36860700013)(82310400026)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2025 22:04:05.8041 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fa96a43a-dcec-4fc3-1228-08dd5cfad00c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B372.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB9222 This is useful for a combined hardware/xenstore domain that will run init-dom0less and xenstored. init-dom0less calls xc_hvm_param_get() to retrieve the xenstore event channel and pfn to configure xenstore for a guest. With a hypervisor-allocated event channel and page, the set_hvm_param is not needed, and the normal domid permissions will allow xenstored to connect. Similarly, a hyperlaunch-ed xenstore stubdom needs to read a domain's xenstore event channel out of hvm_param. This allows reading but not modifying the guest, so allow the permission. Signed-off-by: Jason Andryuk --- xen/arch/arm/hvm.c | 2 +- xen/arch/x86/hvm/hvm.c | 8 ++++---- xen/include/xsm/dummy.h | 14 ++++++++++++-- 3 files changed, 17 insertions(+), 7 deletions(-) diff --git a/xen/arch/arm/hvm.c b/xen/arch/arm/hvm.c index 86e49bf474..b50ca10cee 100644 --- a/xen/arch/arm/hvm.c +++ b/xen/arch/arm/hvm.c @@ -89,7 +89,7 @@ long do_hvm_op(unsigned long op, XEN_GUEST_HANDLE_PARAM(void) arg) if ( d == NULL ) return -ESRCH; - rc = xsm_hvm_param(XSM_TARGET, d, op); + rc = xsm_hvm_param(XSM_OTHER, d, op); if ( rc ) goto param_fail; diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index 969e43c2f2..f3f1002cc9 100644 --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -4177,7 +4177,7 @@ static int hvm_allow_set_param(struct domain *d, uint64_t value; int rc; - rc = xsm_hvm_param(XSM_TARGET, d, HVMOP_set_param); + rc = xsm_hvm_param(XSM_OTHER, d, HVMOP_set_param); if ( rc ) return rc; @@ -4458,7 +4458,7 @@ static int hvm_allow_get_param(struct domain *d, { int rc; - rc = xsm_hvm_param(XSM_TARGET, d, HVMOP_get_param); + rc = xsm_hvm_param(XSM_OTHER, d, HVMOP_get_param); if ( rc ) return rc; @@ -5055,7 +5055,7 @@ static int hvmop_get_mem_type( if ( d == NULL ) return -ESRCH; - rc = xsm_hvm_param(XSM_TARGET, d, HVMOP_get_mem_type); + rc = xsm_hvm_param(XSM_OTHER, d, HVMOP_get_mem_type); if ( rc ) goto out; @@ -5148,7 +5148,7 @@ long do_hvm_op(unsigned long op, XEN_GUEST_HANDLE_PARAM(void) arg) if ( unlikely(d != current->domain) ) rc = -EOPNOTSUPP; else if ( is_hvm_domain(d) && paging_mode_shadow(d) ) - rc = xsm_hvm_param(XSM_TARGET, d, op); + rc = xsm_hvm_param(XSM_OTHER, d, op); if ( !rc ) pagetable_dying(a.gpa); diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h index f2d6662a9d..06f4eccf5f 100644 --- a/xen/include/xsm/dummy.h +++ b/xen/include/xsm/dummy.h @@ -614,8 +614,18 @@ static XSM_INLINE int cf_check xsm_map_gmfn_foreign( static XSM_INLINE int cf_check xsm_hvm_param( XSM_DEFAULT_ARG struct domain *d, unsigned long op) { - XSM_ASSERT_ACTION(XSM_TARGET); - return xsm_default_action(action, current->domain, d); + XSM_ASSERT_ACTION(XSM_OTHER); + switch ( op ) + { + case HVMOP_get_param: + /* A domain can query itself, or a DM can query its target. */ + if ( !xsm_default_action(XSM_TARGET, current->domain, d) ) + return 0; + /* Xenstore domain needs to be able to query for mapping. */ + return xsm_default_action(XSM_XS_PRIV, current->domain, d); + default: + return xsm_default_action(XSM_TARGET, current->domain, d); + } } static XSM_INLINE int cf_check xsm_hvm_param_altp2mhvm( From patchwork Thu Mar 6 22:03:35 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Andryuk X-Patchwork-Id: 14005465 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ECB27C282D1 for ; Thu, 6 Mar 2025 22:41:40 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.904252.1312214 (Exim 4.92) (envelope-from ) id 1tqJuH-0001ze-H8; Thu, 06 Mar 2025 22:41:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 904252.1312214; Thu, 06 Mar 2025 22:41:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqJuH-0001yM-Bm; Thu, 06 Mar 2025 22:41:33 +0000 Received: by outflank-mailman (input) for mailman id 904252; Thu, 06 Mar 2025 22:41:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqJKD-0000St-3U for xen-devel@lists.xenproject.org; Thu, 06 Mar 2025 22:04:17 +0000 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2061d.outbound.protection.outlook.com [2a01:111:f403:240a::61d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f14b6171-fad6-11ef-9898-31a8f345e629; Thu, 06 Mar 2025 23:04:15 +0100 (CET) Received: from IA1P220CA0010.NAMP220.PROD.OUTLOOK.COM (2603:10b6:208:461::7) by CY8PR12MB7340.namprd12.prod.outlook.com (2603:10b6:930:50::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.17; Thu, 6 Mar 2025 22:04:07 +0000 Received: from BN3PEPF0000B36F.namprd21.prod.outlook.com (2603:10b6:208:461::4) by IA1P220CA0010.outlook.office365.com (2603:10b6:208:461::7) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8511.19 via Frontend Transport; Thu, 6 Mar 2025 22:04:07 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN3PEPF0000B36F.mail.protection.outlook.com (10.167.243.166) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8549.1 via Frontend Transport; Thu, 6 Mar 2025 22:04:06 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 6 Mar 2025 16:04:06 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 6 Mar 2025 16:04:05 -0600 Received: from fedora.mshome.net (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Thu, 6 Mar 2025 16:04:05 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f14b6171-fad6-11ef-9898-31a8f345e629 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BX/xNsIhWD4JNSkV2eBTflu00DaZC8XJr7yFLJEzkaeZQLT6rETaHiWdcaKZ55YpUnWb4bZ+X6dXRUfyj8/v7PaPwv43ltGGLl0LacUdvaTQpJDwfEH80DI1QO592nLHD0PCd7c6WkWXXuxswP2wZHrk7A1Iw5bFtvlMcvnTGCrMokyS9z7ubFPUnJOJhP+1Jh2i/PRlcuDnebUJQ0y3TS9q+n3E29zMe3RVkfheX9WfJv+J20I5/cIXgFeBpueHnbfkUn2inwxFa/BSO2GvjHdVtyOXqQVNTj0szXY71Vh229D0QdOXeAISEjLW5zmrVj5K97GxYFoUozUsqKEa9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Eh5UOfi8/DTDce9DcK5p8yN56G6mdaBxAbc7mBhaKuI=; b=DSLYuGx/mcCMYq3xE5MmPROgHhZjK8LZsRTotueKhpWSMwAdcdJ1ZjfFqhFIR8/G3X2VubtdEvDBLiZOqXbtjJCuWUZ9VoEuWQU4GxPRM7mVn1SECF4irAhett+zHoWrnZyTzFcwvhy0eJ6mMlpWdqNg6cYxmyNLcFkPmgr0z75FA0XJmc0cjY2OBXHRxAzbykclY5fe2k+wd+KEA980Uyz/ctb0kds+urycrbTjp6S0WVKX+Ds/X182RdzjGHGEh0FxsQKMTGF8FeVHOzKlZ1KKURV8HdTPm0x1mZzqAwa5ViHcPEKFginWHifDfLXROI+7GsT/SOsmIUT3ypgnAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Eh5UOfi8/DTDce9DcK5p8yN56G6mdaBxAbc7mBhaKuI=; b=WslNN3vuRlBitgNOTeeMHnpal0onLbrkgNpzCgFunUedQGBGgZN7nsVhsZydklfQtiSJ91GExA+AJXj3gqWjCjm2FOpqnrx3LZrFXn/xraMTw8shrOGvmemaUsgF6c79TxuodaRGYZ3iYPBstkuHzggPcksiAJnW4EvV8KGmuWY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Jason Andryuk To: CC: Jason Andryuk , Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , "Volodymyr Babchuk" , Andrew Cooper , Anthony PERARD , "Jan Beulich" , =?utf-8?q?Roger_Pau_Monn=C3=A9?= , "Daniel P. Smith" Subject: [PATCH 15/23] xen/xsm: Add XSM_HW_PRIV Date: Thu, 6 Mar 2025 17:03:35 -0500 Message-ID: <20250306220343.203047-16-jason.andryuk@amd.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250306220343.203047-1-jason.andryuk@amd.com> References: <20250306220343.203047-1-jason.andryuk@amd.com> MIME-Version: 1.0 Received-SPF: None (SATLEXMB05.amd.com: jason.andryuk@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B36F:EE_|CY8PR12MB7340:EE_ X-MS-Office365-Filtering-Correlation-Id: 77133fa7-56fb-4f48-f460-08dd5cfad0a2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|36860700013|1800799024|82310400026; X-Microsoft-Antispam-Message-Info: kvn6oHaegUk0rpDEHUawzuuqKZ4UG8pziUnjWLc7gBmTJASG2RIXhzxJWHewpYRgioDj8Yx+7553XblW6f2yTtYhTrKkXKAj2Al/hc93tsRa4H1ANoTlF8FFjrO41umnllUWLk5180Ppsn+DNvhVU7H/76l5cKbhHwq6ydZxMXBnnakW+V+bvFc9q+W2B+HBtATrvVY1yOlcuni3tsel7W0uoIiT+8Ip/74phatX6StoOFZXw+4tHyFfXNGpYLOqTNxr8mfYLGhPCiuzQxPtFSiXgrETMqO8txxKtbqTmFfN3QSiMV6780AMzvfTR8jK3KR9hNpTeMDmrG7thAuaC3ifD65/gDXxL+mYAI6Us+LYBPu0YJvy80JbWxc9ftQSQf7fgDWxUc14TPWH8TzaaiF1lz7Qp+5WyrdmJ+ZN69b69S1KRm0RZe8xongVu6OeWGNmfn2Oi31IZefyJc9JBavUyalqoGesfvr079bT7YJYxQmvU8rdEWj1dY18IIVIeLPjlW+1tHCPHLjKENFqulCERR0XbCX1fZGjj5iXxqLlz5fei+s9JGu2vSR9ltnp9Ipi4WxXZmTfzNOL0q0xrfRCyjiOAk6w42yh0/V4Fw1R05XiBJrXDSPzr0HQ411hrUsfn73Vnv5Sq7B/Nv10eeINScAoEmY4zT0/glE3E7yZFUp2GDUTQyD24l4WFPiM2eCMnezjc7uv8pA7PLO6IQTj5ChE6pRANllrM/EZnKehzmLAzARCbmQOsuV4OPBIwnDnUDZjAIIEBBVQ3eANvefDwQKvgh518u2CiOFUNbU1xjeDxqk5+slKUtVBX3K9ty/Z94jjJPK2V83UqyCw3jekQ7t3ExVXAffr93KTX5pYKV2hQHipWnKfbakRxKliRMZKr1+nvjncIurVgbL/x5aG/BVhXH0jS+X0yc2jceFMT3YLg1Y4HOr4huaEBF6cpsE5IOcxHLp5uw6jnltmKkKNE46uHhaJHoeEl6D6d86shy4rY+s1YLWdoCrjc8Nbud6kXe8Z5aTnJQFaKDmz+R74mzeLwOwIX+IDrZPesY4IBCdKejMBdMPvfVMLsQD0FhfINNmrO2nbllXOaa4nXn2MTR5cOH8s221fhG+RaJsinx0Di5+BloRGmdhqnDneAvx51bUPErOvZA1ktMEkrIoYyy24XbaCG+DY62kT22Eoc3ETUtFK02ueSq4lgfsovQtZuJY29WTaycMNTyLvIrSb5XhNhs0NL4ujqJigogYsP5mA3s1TfwFAUpJfKQlNMi6+BoXNpj8N6fRRq0cwatDf6nUqZWfAx/VAXbx4uuYMTaxnF+iANc83MW6kiYNfivu0iaTrHY+cnIsl9w7iCB1MeootPZJaUdgx4BfUdUcsMZgD1JBtGAwpQPDZ3pV4UrYSuLgU072MZ1GT0mTGflpna7AfBJOk3e6ym+3R8yg4GhWhT/A6Ew+qdsHtikczGpe1RWT7xvBIjV1r1JU9sk4VqmZNin6gq2Qg4virg9k= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(7416014)(376014)(36860700013)(1800799024)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2025 22:04:06.7929 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 77133fa7-56fb-4f48-f460-08dd5cfad0a2 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B36F.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7340 Xen includes disctinct concepts of a control domain (privileged) and a hardware domain, but there is only a single XSM_PRIV check. For dom0 this is not an issue as they are one and the same. With hyperlaunch and its build capabiliies, a non-privileged hwdom and a privileged control domain should be possible. Today the hwdom fails the XSM_PRIV checks for hardware-related hooks which it should be allowed access to. Introduce XSM_HW_PRIV, and use it to mark many of the physdev_op and platform_op. Previously, xsm_default_action() was almost linearly increasing in permissions with its fallthroughs. When it gets to XSM_PRIV, all permissions were allowed for the control domain. That needs to change so the control domain cannot access XSM_HW_PRIV. The hwdom is allowed access for XSM_HW_PRIV and XSM_DM_PRIV. The hardware domain providing a device model for a domU is an expected use case, so those permission are needed as well. Testing was performed with hardware+xenstore capabilities for dom0 and a control dom3 booted from hyperlaunch. The additional xenstore permissions allowed hwdom+xenstore XSM_XS_PRIV which are necesary for xenstore. A traditional dom0 will be both privileged and hardware domain, so it continues to have all accesses. Why not XSM:Flask? XSM:Flask is fine grain, and this aims to allow coarse grain. domUs are still domUs. If capabilities are meant to be a first class citizen, they should be usable by the default XSM policy. Signed-off-by: Jason Andryuk --- xen/arch/arm/platform_hypercall.c | 2 +- xen/arch/x86/msi.c | 2 +- xen/arch/x86/physdev.c | 12 ++++++------ xen/arch/x86/platform_hypercall.c | 2 +- xen/drivers/passthrough/pci.c | 5 +++-- xen/drivers/pci/physdev.c | 2 +- xen/include/xsm/dummy.h | 22 +++++++++++++--------- xen/include/xsm/xsm.h | 1 + 8 files changed, 27 insertions(+), 21 deletions(-) diff --git a/xen/arch/arm/platform_hypercall.c b/xen/arch/arm/platform_hypercall.c index ac55622426..a84596ae3a 100644 --- a/xen/arch/arm/platform_hypercall.c +++ b/xen/arch/arm/platform_hypercall.c @@ -35,7 +35,7 @@ long do_platform_op(XEN_GUEST_HANDLE_PARAM(xen_platform_op_t) u_xenpf_op) if ( d == NULL ) return -ESRCH; - ret = xsm_platform_op(XSM_PRIV, op->cmd); + ret = xsm_platform_op(XSM_HW_PRIV, op->cmd); if ( ret ) return ret; diff --git a/xen/arch/x86/msi.c b/xen/arch/x86/msi.c index bf5b71822e..6b4bc712c5 100644 --- a/xen/arch/x86/msi.c +++ b/xen/arch/x86/msi.c @@ -1355,7 +1355,7 @@ int pci_restore_msi_state(struct pci_dev *pdev) if ( !use_msi ) return -EOPNOTSUPP; - ret = xsm_resource_setup_pci(XSM_PRIV, + ret = xsm_resource_setup_pci(XSM_HW_PRIV, (pdev->seg << 16) | (pdev->bus << 8) | pdev->devfn); if ( ret ) diff --git a/xen/arch/x86/physdev.c b/xen/arch/x86/physdev.c index 69fd42667c..b0bb2b846b 100644 --- a/xen/arch/x86/physdev.c +++ b/xen/arch/x86/physdev.c @@ -358,7 +358,7 @@ ret_t do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg) ret = -EFAULT; if ( copy_from_guest(&apic, arg, 1) != 0 ) break; - ret = xsm_apic(XSM_PRIV, currd, cmd); + ret = xsm_apic(XSM_HW_PRIV, currd, cmd); if ( ret ) break; ret = ioapic_guest_read(apic.apic_physbase, apic.reg, &apic.value); @@ -372,7 +372,7 @@ ret_t do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg) ret = -EFAULT; if ( copy_from_guest(&apic, arg, 1) != 0 ) break; - ret = xsm_apic(XSM_PRIV, currd, cmd); + ret = xsm_apic(XSM_HW_PRIV, currd, cmd); if ( ret ) break; ret = ioapic_guest_write(apic.apic_physbase, apic.reg, apic.value); @@ -388,7 +388,7 @@ ret_t do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg) /* Use the APIC check since this dummy hypercall should still only * be called by the domain with access to program the ioapic */ - ret = xsm_apic(XSM_PRIV, currd, cmd); + ret = xsm_apic(XSM_HW_PRIV, currd, cmd); if ( ret ) break; @@ -490,7 +490,7 @@ ret_t do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg) if ( copy_from_guest(&dev, arg, 1) ) ret = -EFAULT; else - ret = xsm_resource_setup_pci(XSM_PRIV, + ret = xsm_resource_setup_pci(XSM_HW_PRIV, (dev.seg << 16) | (dev.bus << 8) | dev.devfn) ?: pci_prepare_msix(dev.seg, dev.bus, dev.devfn, @@ -501,7 +501,7 @@ ret_t do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg) case PHYSDEVOP_pci_mmcfg_reserved: { struct physdev_pci_mmcfg_reserved info; - ret = xsm_resource_setup_misc(XSM_PRIV); + ret = xsm_resource_setup_misc(XSM_HW_PRIV); if ( ret ) break; @@ -567,7 +567,7 @@ ret_t do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg) if ( setup_gsi.gsi < 0 || setup_gsi.gsi >= nr_irqs_gsi ) break; - ret = xsm_resource_setup_gsi(XSM_PRIV, setup_gsi.gsi); + ret = xsm_resource_setup_gsi(XSM_HW_PRIV, setup_gsi.gsi); if ( ret ) break; diff --git a/xen/arch/x86/platform_hypercall.c b/xen/arch/x86/platform_hypercall.c index 90abd3197f..8efb4ad05f 100644 --- a/xen/arch/x86/platform_hypercall.c +++ b/xen/arch/x86/platform_hypercall.c @@ -228,7 +228,7 @@ ret_t do_platform_op( if ( op->interface_version != XENPF_INTERFACE_VERSION ) return -EACCES; - ret = xsm_platform_op(XSM_PRIV, op->cmd); + ret = xsm_platform_op(XSM_HW_PRIV, op->cmd); if ( ret ) return ret; diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c index ab25840e20..f25d00f7c4 100644 --- a/xen/drivers/passthrough/pci.c +++ b/xen/drivers/passthrough/pci.c @@ -678,7 +678,7 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn, else type = "device"; - ret = xsm_resource_plug_pci(XSM_PRIV, (seg << 16) | (bus << 8) | devfn); + ret = xsm_resource_plug_pci(XSM_HW_PRIV, (seg << 16) | (bus << 8) | devfn); if ( ret ) return ret; @@ -830,7 +830,8 @@ int pci_remove_device(u16 seg, u8 bus, u8 devfn) struct pci_dev *pdev; int ret; - ret = xsm_resource_unplug_pci(XSM_PRIV, (seg << 16) | (bus << 8) | devfn); + ret = xsm_resource_unplug_pci(XSM_HW_PRIV, + (seg << 16) | (bus << 8) | devfn); if ( ret ) return ret; diff --git a/xen/drivers/pci/physdev.c b/xen/drivers/pci/physdev.c index 0161a85e1e..c223611dfb 100644 --- a/xen/drivers/pci/physdev.c +++ b/xen/drivers/pci/physdev.c @@ -86,7 +86,7 @@ ret_t pci_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg) dev_reset.dev.bus, dev_reset.dev.devfn); - ret = xsm_resource_setup_pci(XSM_PRIV, sbdf.sbdf); + ret = xsm_resource_setup_pci(XSM_HW_PRIV, sbdf.sbdf); if ( ret ) break; diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h index 06f4eccf5f..4536ee5dad 100644 --- a/xen/include/xsm/dummy.h +++ b/xen/include/xsm/dummy.h @@ -95,7 +95,11 @@ static always_inline int xsm_default_action( return 0; fallthrough; case XSM_PRIV: - if ( is_control_domain(src) ) + case XSM_HW_PRIV: + if ( is_control_domain(src) && action != XSM_HW_PRIV ) + return 0; + if ( is_hardware_domain(src) && + (action == XSM_HW_PRIV || action == XSM_DM_PRIV) ) return 0; return -EPERM; default: @@ -280,7 +284,7 @@ static XSM_INLINE int cf_check xsm_console_io( if ( cmd == CONSOLEIO_write ) return xsm_default_action(XSM_HOOK, d, NULL); #endif - return xsm_default_action(XSM_PRIV, d, NULL); + return xsm_default_action(XSM_HW_PRIV, d, NULL); } static XSM_INLINE int cf_check xsm_profile( @@ -460,33 +464,33 @@ static XSM_INLINE int cf_check xsm_resource_unplug_core(XSM_DEFAULT_VOID) static XSM_INLINE int cf_check xsm_resource_plug_pci( XSM_DEFAULT_ARG uint32_t machine_bdf) { - XSM_ASSERT_ACTION(XSM_PRIV); + XSM_ASSERT_ACTION(XSM_HW_PRIV); return xsm_default_action(action, current->domain, NULL); } static XSM_INLINE int cf_check xsm_resource_unplug_pci( XSM_DEFAULT_ARG uint32_t machine_bdf) { - XSM_ASSERT_ACTION(XSM_PRIV); + XSM_ASSERT_ACTION(XSM_HW_PRIV); return xsm_default_action(action, current->domain, NULL); } static XSM_INLINE int cf_check xsm_resource_setup_pci( XSM_DEFAULT_ARG uint32_t machine_bdf) { - XSM_ASSERT_ACTION(XSM_PRIV); + XSM_ASSERT_ACTION(XSM_HW_PRIV); return xsm_default_action(action, current->domain, NULL); } static XSM_INLINE int cf_check xsm_resource_setup_gsi(XSM_DEFAULT_ARG int gsi) { - XSM_ASSERT_ACTION(XSM_PRIV); + XSM_ASSERT_ACTION(XSM_HW_PRIV); return xsm_default_action(action, current->domain, NULL); } static XSM_INLINE int cf_check xsm_resource_setup_misc(XSM_DEFAULT_VOID) { - XSM_ASSERT_ACTION(XSM_PRIV); + XSM_ASSERT_ACTION(XSM_HW_PRIV); return xsm_default_action(action, current->domain, NULL); } @@ -688,7 +692,7 @@ static XSM_INLINE int cf_check xsm_mem_sharing(XSM_DEFAULT_ARG struct domain *d) static XSM_INLINE int cf_check xsm_platform_op(XSM_DEFAULT_ARG uint32_t op) { - XSM_ASSERT_ACTION(XSM_PRIV); + XSM_ASSERT_ACTION(XSM_HW_PRIV); return xsm_default_action(action, current->domain, NULL); } @@ -716,7 +720,7 @@ static XSM_INLINE int cf_check xsm_mem_sharing_op( static XSM_INLINE int cf_check xsm_apic( XSM_DEFAULT_ARG struct domain *d, int cmd) { - XSM_ASSERT_ACTION(XSM_PRIV); + XSM_ASSERT_ACTION(XSM_HW_PRIV); return xsm_default_action(action, d, NULL); } diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h index 4dbff9d866..404491ef62 100644 --- a/xen/include/xsm/xsm.h +++ b/xen/include/xsm/xsm.h @@ -36,6 +36,7 @@ enum xsm_default { XSM_DM_PRIV, /* Device model can perform on its target domain */ XSM_TARGET, /* Can perform on self or your target domain */ XSM_PRIV, /* Privileged - normally restricted to dom0 */ + XSM_HW_PRIV, /* Hardware Privileged - normally restricted to dom0/hwdom */ XSM_XS_PRIV, /* Xenstore domain - can do some privileged operations */ XSM_OTHER /* Something more complex */ }; From patchwork Thu Mar 6 22:03:36 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Andryuk X-Patchwork-Id: 14005402 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC1CFC282EC for ; Thu, 6 Mar 2025 22:04:22 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.904081.1312084 (Exim 4.92) (envelope-from ) id 1tqJKB-00047L-2S; Thu, 06 Mar 2025 22:04:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 904081.1312084; Thu, 06 Mar 2025 22:04:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqJKA-00046w-UQ; Thu, 06 Mar 2025 22:04:14 +0000 Received: by outflank-mailman (input) for mailman id 904081; Thu, 06 Mar 2025 22:04:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqJK9-0000St-Ai for xen-devel@lists.xenproject.org; Thu, 06 Mar 2025 22:04:13 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2062a.outbound.protection.outlook.com [2a01:111:f403:2414::62a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ee8f6afe-fad6-11ef-9898-31a8f345e629; Thu, 06 Mar 2025 23:04:11 +0100 (CET) Received: from BL0PR02CA0053.namprd02.prod.outlook.com (2603:10b6:207:3d::30) by DM4PR12MB8499.namprd12.prod.outlook.com (2603:10b6:8:181::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.17; Thu, 6 Mar 2025 22:04:07 +0000 Received: from BN3PEPF0000B36D.namprd21.prod.outlook.com (2603:10b6:207:3d:cafe::c3) by BL0PR02CA0053.outlook.office365.com (2603:10b6:207:3d::30) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8511.19 via Frontend Transport; Thu, 6 Mar 2025 22:04:07 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN3PEPF0000B36D.mail.protection.outlook.com (10.167.243.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8549.1 via Frontend Transport; Thu, 6 Mar 2025 22:04:07 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 6 Mar 2025 16:04:07 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 6 Mar 2025 16:04:07 -0600 Received: from fedora.mshome.net (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Thu, 6 Mar 2025 16:04:06 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ee8f6afe-fad6-11ef-9898-31a8f345e629 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ymiJ3kJPO2/IAiytx0EQF2xpcxtd9zAIBXkQ/FuswW022g+VUyyslLoj5Ujnqs2ZU6hcR4eBnpfom2mv3tv9Fza9yqK5NpbQJDb/hgJBGFv+HQvuNfHXIeqlAyS6lLlXgj0uH89W+RhBiJTZPA/lo80NS0SKvGuhO5f3J8edJYaGMi2oeyVqGheHwCEopzqxEuLSWP/CXfMsv5WDRcuIx6PidUV/kpNDto4AaiWo9zF5yQlg6WWYFrWijNC/yigGQyzw+REnfvhh/67lgIeM6wS2GaHOdW+kdBX9a/VmxXENCMMnFXqHe8jWnzfh9OevHwDp50yi2bnhpI2wOYUGaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gEDVZclDoayKYIruSx6CXgaFNq+WT+jOC46+4RZTaGA=; b=xNVdQHMDe0bZDLes+IeDc3zJRQ7u2r9mJbVq0NlrRIebPFjaL2CZXDBZoKtCJdZKLqzrkWRMM6ozle7CwUZEpMKleAStRNZpjLLdH2EaNabkBt/BfGY3l6Fnk+5fY/5S/H1EobwCSpD8prkeTxRLG9nViOk7DQw/dyV3OPEbZ7ciUtP3RCfmAPiByDyPiR/T8RSMNEiYlEEz+PsgrirWgB8oalV9prlrldRSx8oOqjk3dv8ccPqN2z+CGE3BbPxhNvtWAMmYtAi8mQkGa7XBeBCnpme39JrWdI0w3LLIiT49MLHE6lIF26pyIJFJJza0Dqcq0FHki/XrE9mvHeKQDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gEDVZclDoayKYIruSx6CXgaFNq+WT+jOC46+4RZTaGA=; b=vIvxLt5YuAqZYYTP39WCnOUZaAHrq5DAFRhBiW4EcvIR9DTf+BVoI+CFHTP7L6DMaDHe9A3o1HyrdZRlMNDEGL6zHKZmctvFTi4x0OGkolkepGlOdPmDD1wjvtbe0rYWrUvUNZixkj6sMgZ74NaLJ2bnt1+puLdcPvZOBehsZ14= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Jason Andryuk To: CC: Jason Andryuk , "Daniel P. Smith" Subject: [PATCH 16/23] xsm/dummy: Allow hwdom xen_version Date: Thu, 6 Mar 2025 17:03:36 -0500 Message-ID: <20250306220343.203047-17-jason.andryuk@amd.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250306220343.203047-1-jason.andryuk@amd.com> References: <20250306220343.203047-1-jason.andryuk@amd.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B36D:EE_|DM4PR12MB8499:EE_ X-MS-Office365-Filtering-Correlation-Id: 953713ad-696f-410a-1e8e-08dd5cfad136 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|376014|36860700013; X-Microsoft-Antispam-Message-Info: imTtpSo1j7vf396hrmWr7dIbRIV3f04ipIiQoYSG5bbQ2IiSZe0uutHFGoGcjLEBJ3fBYm+2Cl2bmS1nNzP49KwBk3vMldYPrL9VKyNlgp9L6lxLhpVX760Huchf1c8ObumNMaQm4ELsnrLPigT0YU/hRlgJdPwrhEIaTPK1ANsgbk9bs/4WC0Ls4zuQVd1ggi8e6Dh9xtiE4dMH5A/4FgbnGDTa/CUHXjjrJA4DglI+0pvcGoS09HWTkkkhYYGqHMYswTpMcJJc8c9hGkGTJZbBeUlLq0jsVQqvtUG6BO12p3aqjZkwMY8ELSadHrxtTiyLzmouL/RflRqC1i9YnU2yDYha7Wxk3G9VC720sXEt/3EsSkD0eg3+SZqg0msWR+d3fI3zCs3cTlxkMqzNSkZMh0UsBCCFAErKnPLbSdDEQSZJrRsAl74HPHSgYjRN2hcHPnNCmnaFEiU2RMoPFv311fo7LtHg7v8WNpCF7pym040PubPJDnVRBTS7dgZfwmmECu/HYDewIDOguKD7NoSiv+Peb0vwPENhCZqCNwna7Z06NFyABbF7QdOoT/8imRcOfx5nzB8e91+7CqMeuXbe1k/YdmqPMPc6i3ScS/uof5w4S9SQuF98nqKYg4O+23vVw2dgabjsct1zNMHu32KmV217XaNhw9ujctPDphFTzqOZHIZvnm5BKXPUb3qN+eGCVQQDp6VYdnHoLHB2uPa6ZwuOav+3quyxxXmf7nNGHGgYorSeyYMWcXL293xtdMDB/2C5GV+eHEoHykDZw14wW0lKOrT/WOjb7jRq4eMB/X+QdXN+KYJF4c/dkhrV9EOwDfRJsvkAd2aHK46gqfaW4yJOGLL2sH+yTBOzLg7cgHVDNE6PxDq7KH7WQAYS/+yx0Uvj4Bo1Sz0mUDlJy/ccTI7mZdKcLTcjyy5kfVxVkmBdY2Qlb1oSR97QyP22MGUDWULAMkBAhFA+Y+tw9oVju/9dUx+TpArNvh8XiL4kObwfJ5pr9hU81OabwE1u5yem5oCXiYK8WccsSrKn/prdmIyAagUU3WEz26+YFQsiXzzNkAnI0S2opo3Ed1xGWcJYOdtnddHZ6LbktoLJTQqe+qSTotcE5qRz02DhVSGnyBm6dqK+TFixATnbAWzhaEbusSxkfEbvq1fp5716S6/S4krvJwXl5TBTLcQh5+MR3bdSZ1DBq+483l4uYi7p9ONnjvidhAeCXMSYTVeuSQlSaWX9/t8FgFURVbkKBInPQzS9lqXtE87MVCDDK2AenX9GWqmnVcjfHzT9Eb+soS8n5vj7QUqAQqdd6WZy1XneqhxBRH/aGKuU0uuGky+pQ/yxiEAjHLHJs3cT1H/sENJSMLVD8USKOsqip46Tqpk0uTusXfixHEVNXRSZKs62pnryMxuPBgqEuYpOdBWggdzmkBuwsj7dOAHWhmCi0c7/JNxeii0A/tyDYfs4882Zt7jZcDCWWfx62AyBMWIFQg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(376014)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2025 22:04:07.7574 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 953713ad-696f-410a-1e8e-08dd5cfad136 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B36D.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB8499 Running xl queries XENVER_commandline and XENVER_build_id. The hardware domain should have access to the command line. The hardware domain is at least semi-trusted - just allow it access to all the xen_version info. Signed-off-by: Jason Andryuk --- xen/include/xsm/dummy.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h index 4536ee5dad..9e6bc0ed12 100644 --- a/xen/include/xsm/dummy.h +++ b/xen/include/xsm/dummy.h @@ -859,6 +859,8 @@ static XSM_INLINE int cf_check xsm_xen_version(XSM_DEFAULT_ARG uint32_t op) /* These MUST always be accessible to any guest by default. */ return xsm_default_action(XSM_HOOK, current->domain, NULL); default: + if ( is_hardware_domain(current->domain) ) + return xsm_default_action(XSM_HW_PRIV, current->domain, NULL); return xsm_default_action(XSM_PRIV, current->domain, NULL); } } From patchwork Thu Mar 6 22:03:37 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Andryuk X-Patchwork-Id: 14005457 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DF67AC282D1 for ; Thu, 6 Mar 2025 22:40:59 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.904175.1312133 (Exim 4.92) (envelope-from ) id 1tqJtZ-0005Lg-Mu; Thu, 06 Mar 2025 22:40:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 904175.1312133; Thu, 06 Mar 2025 22:40:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqJtZ-0005LZ-Jp; Thu, 06 Mar 2025 22:40:49 +0000 Received: by outflank-mailman (input) for mailman id 904175; Thu, 06 Mar 2025 22:40:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqJKD-0000Ss-Cd for xen-devel@lists.xenproject.org; Thu, 06 Mar 2025 22:04:17 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2062e.outbound.protection.outlook.com [2a01:111:f403:2009::62e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f04a4674-fad6-11ef-9ab4-95dc52dad729; Thu, 06 Mar 2025 23:04:13 +0100 (CET) Received: from CH0PR03CA0185.namprd03.prod.outlook.com (2603:10b6:610:e4::10) by CY8PR12MB7433.namprd12.prod.outlook.com (2603:10b6:930:53::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.18; Thu, 6 Mar 2025 22:04:10 +0000 Received: from CH2PEPF00000145.namprd02.prod.outlook.com (2603:10b6:610:e4:cafe::1a) by CH0PR03CA0185.outlook.office365.com (2603:10b6:610:e4::10) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8511.19 via Frontend Transport; Thu, 6 Mar 2025 22:04:09 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CH2PEPF00000145.mail.protection.outlook.com (10.167.244.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8511.15 via Frontend Transport; Thu, 6 Mar 2025 22:04:09 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 6 Mar 2025 16:04:08 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 6 Mar 2025 16:04:08 -0600 Received: from fedora.mshome.net (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Thu, 6 Mar 2025 16:04:08 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f04a4674-fad6-11ef-9ab4-95dc52dad729 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=j+B6nF9GP4kAsmdO2oe6t0L0McwVqexmty6UvxFtuWbUYqIBm/7WiHsQjU+GtBGSWFxPo+ErTUPVikihko3ku0t9JpdvmWfCQrt8KKfC/Cq0S7/UmcZW+mUuVyAkV5pGwEMHP8OuIryRAjodX1HYZjV4npyprnGG19tYwQY2OWccWhvwRpkDFV6M6zeebAM7hlJb+FH+XaSt+y651DaMlRLe5auBr/6mfM19ddP41g973x6ubqOXjhp0yW6ot/rq1vM+ny4kypUahR2P/913txPF1BsEcAPvme6pbku7Fmi5SUfwbslXnyqbvKzsDCam2GkF1dagi8wU8oborgZNSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4iIiBhdZ7Z/AESKlqv+uNMrJ77HKz/XFz38UqOCX6i4=; b=ciJ52d8y0Lvk6R96qNP/RT9BRc9XKfFe3YuuhxEXAU9sp0N0WFZj2C6jRl/PkraDZcB8bN0SYHlvvTojJHVsq4aieujoj8vjvUSxx7Bs3CaIY7WFgMMzK6DI2b2f4dJifu2tI2HnAVhCrHg9EozvKidrSUlP6cRKoWw608Mvhh1ab7f3rqTFwAzWZLMsfee/guqhFtHDuwN0W7HBUBfXxRuzUoPbYO3r4gJxgB9266vkk0HyrqTaYRJjbiCogCRe+wPsEdUf+c50w3+51was54ObRSo/qVtRCi56KLLkhUd7SncKPxW7+davVvGmEq//iKHtWLZvrFQaFLOFROUFkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4iIiBhdZ7Z/AESKlqv+uNMrJ77HKz/XFz38UqOCX6i4=; b=JIQFsIVwvjtQRurSUhYOF+dJgYh26qPLq9dGYFL84WDhTnu8JeiYarmux+eUswnQtn/OMd5MAWJKf6IGTHb15X/yVRgVK21DnOxLAmsYuA0GJLB+SyxYom2SaryVh5SedMMvwuVZvKeN0jz/IKGXkoFSLgna5fw4gK8ViOOO2YA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Jason Andryuk To: CC: Jason Andryuk , "Daniel P. Smith" Subject: [PATCH 17/23] xsm/dummy: Allow hwdom more - except targeting control Date: Thu, 6 Mar 2025 17:03:37 -0500 Message-ID: <20250306220343.203047-18-jason.andryuk@amd.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250306220343.203047-1-jason.andryuk@amd.com> References: <20250306220343.203047-1-jason.andryuk@amd.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PEPF00000145:EE_|CY8PR12MB7433:EE_ X-MS-Office365-Filtering-Correlation-Id: f4ad279d-1b6d-4b2b-76a5-08dd5cfad227 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|36860700013|1800799024; X-Microsoft-Antispam-Message-Info: o4OYvYd2/TP4nCQdPC/q8UmtX3D/EOV8EFeLek1nnUKibkl0GyID+lk0UEVgnnBExhUPld9nIz7eE5bu1uY4Xs9wQnIoSCdf6tqgbcir8WnnMsCD24XSd/mT+FQO69DhTXZenA+dujI5RwhlyEoJ3sjuFYo7YntxVYyVbfcw4VUQpj0+89zMScwt63jHW4KE7r1kEvhdAbahJ1HU0Exe0tt7WMcZSwTEWqy2g9AxMKVkyOfh8zxXely/mi0o+jue8EsXgSi8qmBJ+R9jZdgd/23oj8vm1A5ScBiBJvXdvwb14ZZW9vTVXfkaDI5F5RRxG/bS3haDByVeHKOwxJJvu/QmdOykh5Iz9uyWxUIO1E4IvE6lbI+yB8QSQRbw8YgIWWFdi2M0ehWZ01u9m7PzVUv+wEfHnIqNiSkCD6vOZ/auCs/9HsN3LRzQsCEUtL6t744Jp1Jhasalr4IXmRJAc/9yjm7ro2krq/mDatK9/swr9lrwgqJlf2YM/9ukWoIfxCidz2NppVnKBTtzggUUv6UPCippSsCNgNNb4U3f0HzGgxDhgg9KR9DLkiXjCz/81BHyrtFfmFaXD8o5ksj+euY4wLbNO5jtdb423idCXzDYuMf5zpdl7ZsxRNx+c+FM/ykd+rvdWHPbCSY6kEROIEtlqH2VbRwunAiC4hYgqk8XijNk3veY1WH9NVg1bukNh+KZlsikcgk2PEZo5uno4Vh7mFJNknPZ3eq49oSO6Mirih1e8rrL2qphv9AolP8zgGl/abGVvOl0OIwUerllyIzaHHMNzwkgWg/nTtyaYFrJ02jPB95TLb93yJexnE4wZb3G5BqdtsdN9+MXl7+vUFiOceZSLlrb1/tzsqBRyWV8mYglxQiX3tWLZj0+a5oR9nJDFSb9tvmcfNQxFci55UVI7l/lRGh+JhRFijx9BmtenqFT3i5x3L8O/ChbnolpD/wqmqIjigcf/b7MCDEucoJkFVYV68VnjnRJAsyQQg8XHQ4eKaZ1UPIAIka/HJFXXvtkV8OTPwhof5bqxW4520jPs4AQIvNkmx51CtBNfzLt0oJg6wJbBQNU+ztDrl/ReXATUc5R5tJlzD0I2HrkgmU5BoSeQ4uvnKMeNSdDcA+GQpglSatNUXKHxVDkIy2XoHz0CJFcZ7SHbvbJUiHWpdcvM+AZbpAZyBmAxIaUReTbyqB1NDmdz2CcxB3QNxMwI5D1BwE3qC1bbAJD+J6Cd4tAmhvDYkIK21t71kHWWbP97133rz16Xo6YPnKvb3OcXhIp//s7B9INUVt2rmCZ0/epWpI/C8uvbzAPVoRS9NHcW0jcFctr1U89r5h1vPTqKM7lgSkkmw+qtCCLE9eK15MeSX63wqnXKeFIE1i0z6GcPgIJcbN8PtqKSfUo4/BeqOIHVFi2Q7114AJSTy91GkG12AJKiatvN5l6pisnor7C1qRYA9oIW4J2/5Lo8VnoepjrCbZXBVHQXwN19UdgcaOySqZSdTyaHTgFWyRCPXs= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(376014)(36860700013)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2025 22:04:09.3234 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f4ad279d-1b6d-4b2b-76a5-08dd5cfad227 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH2PEPF00000145.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7433 Allow hwdom all perms, except XSM_PRIV, and except commands where the target is the control domain. This protects the control domain from hwdom while allowing the hardware domain to serve as the backend and device model for other domUs. Signed-off-by: Jason Andryuk --- xen/include/xsm/dummy.h | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h index 9e6bc0ed12..294777e904 100644 --- a/xen/include/xsm/dummy.h +++ b/xen/include/xsm/dummy.h @@ -98,9 +98,12 @@ static always_inline int xsm_default_action( case XSM_HW_PRIV: if ( is_control_domain(src) && action != XSM_HW_PRIV ) return 0; - if ( is_hardware_domain(src) && - (action == XSM_HW_PRIV || action == XSM_DM_PRIV) ) + if ( is_hardware_domain(src) && action != XSM_PRIV ) + { + if ( target && is_control_domain(target) ) + return -EPERM; return 0; + } return -EPERM; default: LINKER_BUG_ON(1); From patchwork Thu Mar 6 22:03:38 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Andryuk X-Patchwork-Id: 14005451 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C84F7C282D1 for ; Thu, 6 Mar 2025 22:31:15 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.904143.1312104 (Exim 4.92) (envelope-from ) id 1tqJjp-0002in-Et; Thu, 06 Mar 2025 22:30:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 904143.1312104; Thu, 06 Mar 2025 22:30:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqJjp-0002ig-B1; Thu, 06 Mar 2025 22:30:45 +0000 Received: by outflank-mailman (input) for mailman id 904143; Thu, 06 Mar 2025 22:30:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqJKF-0000Ss-DB for xen-devel@lists.xenproject.org; Thu, 06 Mar 2025 22:04:19 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2062c.outbound.protection.outlook.com [2a01:111:f403:2009::62c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f129742d-fad6-11ef-9ab4-95dc52dad729; Thu, 06 Mar 2025 23:04:15 +0100 (CET) Received: from CH0PR03CA0210.namprd03.prod.outlook.com (2603:10b6:610:e4::35) by SA1PR12MB7175.namprd12.prod.outlook.com (2603:10b6:806:2b2::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.16; Thu, 6 Mar 2025 22:04:10 +0000 Received: from CH2PEPF00000145.namprd02.prod.outlook.com (2603:10b6:610:e4:cafe::f3) by CH0PR03CA0210.outlook.office365.com (2603:10b6:610:e4::35) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8511.17 via Frontend Transport; Thu, 6 Mar 2025 22:04:10 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CH2PEPF00000145.mail.protection.outlook.com (10.167.244.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8511.15 via Frontend Transport; Thu, 6 Mar 2025 22:04:10 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 6 Mar 2025 16:04:09 -0600 Received: from fedora.mshome.net (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Thu, 6 Mar 2025 16:04:09 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f129742d-fad6-11ef-9ab4-95dc52dad729 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=u5x9yXw8HTM+1bNPSwKrFNBXOJeelgEYriIrsWGpoB410YIWcSHcO27AKPIN7QDAzAXdBF/pmc8yx208fi9dlyJSHNe0nkqRqluiuorvE6AZBqYGS8fBfKL7uGi+WLKYvC4g5zW3XsdJY+B6TYopONsdSDr+cWu2X8vviOeSg9ro8nhrFLPyfPaH8VWai1Cuv283CBfUOc+P7nf++hOkJ3YrNdB86alYbtoZxlKvJCJof7yoQm9noZqQ97HDFGdQyBfRxrVmQslP9F6/mAbeOBusdlWFv0EIjolH5dGTUC6rkmmpyWjBe+OV8vHdds86Ian+ASTskUCjYFbVU9W8aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dNf6RjYjhNpFroM/vFGz8qFvPyty4gsB+36I+cSZL2A=; b=BV5vPonF4P83xj/goz1tpox21SxcnO3oM1B353uT2X7u0MMR5Th18TBVgV254vq0B8hPKvtbjSuX9IOBPHGuh4bdA63nLNvC/e6SKrGp+lckgNEBHJKjcvNTbVsUM2wAbpSA1aKcikgbmuEP7oiQfInEMgoBL8SvWDzNIf3IpWUg/OhipBkv8IXBdg//nupPxW3wF4pV9ox0XNILOluzVhmtIRjFgKFGC8huovy7Z+bXQtz+KKmhFUe0Pt5IJGZm0NjhxuqmTufVFi4WEj9Ju8KVg7L4bPoB8EAbFIiiEJ/I1CnD1EdJ7iL3FkU0xx43yw9gqmdgIQEnJAF79horLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dNf6RjYjhNpFroM/vFGz8qFvPyty4gsB+36I+cSZL2A=; b=agHAkZGYGZ9DAL6OIOSsuMnme0vwNP0eCVgFbtXDeZisjjdcoeb6Fagl5FaRpl05j/hwGFuLjAaqETMXO2mjVME/tvjs5iwVoK2WUSyo71XJl7pjDP10ho3VJhige8hKiqns8OT6zVMO/C3PxBtslwaKCGVWbQ8SB4bZFc45juA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Jason Andryuk To: CC: Jason Andryuk , "Daniel P. Smith" Subject: [PATCH 18/23] xsm/dummy: Allow hwdom SYSCTL_readconsole/physinfo Date: Thu, 6 Mar 2025 17:03:38 -0500 Message-ID: <20250306220343.203047-19-jason.andryuk@amd.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250306220343.203047-1-jason.andryuk@amd.com> References: <20250306220343.203047-1-jason.andryuk@amd.com> MIME-Version: 1.0 Received-SPF: None (SATLEXMB04.amd.com: jason.andryuk@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PEPF00000145:EE_|SA1PR12MB7175:EE_ X-MS-Office365-Filtering-Correlation-Id: 89114dba-dc84-4392-20a0-08dd5cfad2d3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|376014|36860700013; X-Microsoft-Antispam-Message-Info: L6VUTVnvL+Bbk5Doyyfc7DDku1JlBURR54u45jL7XJ5f/vpeigZ5v/7OxvU8iNBmGthu30RU+HAMC4uFdNSfMNpEcc2foxzLSA4Oz1fNJkWQ0bC9yKP9a8nShk9XGAx77ZtO2EZNASUaul6mdTIkDEwsbkipnSe+ovVJ3Y95zxjnHgGTTEzcCG0nRcRiSeJqx4RV25v9AINYHGQjGAB5lywQCFQaRthyVBMqEXrp3N3759OZTl9hi/L59sQdUOHcLXkXnn7Ybmz1fRbMYsIHlmoCtVTncy7/z2gCLUYwU6bTupnZu1cgQlFcLeLtUDTYAwtgx4mHsyKbrx28hvkSuLu2T99edZEzKBxqVTa/k35qp6TzynvilGKO/AxZvDm6eaYzXMyK7yKgtVsFegpbzsNnWugQKaUpYWOVf3EC3HAbQap+qG53ZdfnrZsy48opK54lxMa2jq8K5ZNot/gXqqI5wimS2jFkO0FSbccdEuuRT/LAvtQLArBzETYDlhIJtZ8U7AMO7pjMhumjDGMOibloqmUsYgUrWBhRAeG3/ZpG3xVQQEaUJAoclXEAdtb8UCGDE61+kRM2QSj/7+BHvGw5YSMfMQ4q900WnpTspmWW4iCpocD7hA8U4lIv6xjDbXxZV5+FTaqpQAYGkYIz9BxY1NvNOwRLWnTg+NJmS4c6FGVHLlgpft3FJFzDfDPyhsRcSgBoIhNx4HXMGROe9HUL7TQ2pa8Bh6IZQl1PwlT9aGE4bo+OutkPe1YpCgkU5Gl2yjpdJX+x8BmtnyTWGCbK1kMV2Pl5hS+UOV3Jj4VaLieUKNB1hv79hdI/E8tuuwonQWjxlxfP2w72jJYcS7XTecMPPD9mI7Y9XffWhnau3UgPxw0zyiJvDBPrjojT/DDpo2V17BkhcceBqIn5D9xufyxHcdzcFvZYMI9Vn2GxojNwOb4uJ/bUf8DhnLbVS3Iv2/bv7H6+zLLT3pEiNu2EWelm12C2klImfDUYEtGgyx9fUOA+gM6HYzBY75pIuULsHRnOk/7tCGUlNOW74+gh+JHsxqKDq+o/3ny78CbDAJF4edW9Dc1y6wUsUQmP7QGni9yQbJu8YaYICuzT0PxhsXMu946bKd7k1YgsKSEwifGzCuLJapAGveIegtuECtz9wmey2Q2GvOGllLrj5TSjTt08ruHtQsHp19nUaipjR2K2dSs1RbDyn0ncz6QvXvfg2DVGcsz/Yf9ipJUBDw+z9MXUCCbw0eAqsjpyEHhqR0puZHAZvwEG70cxnFyzk2aDIbLiV8knWiOQau/lqcAAzGpi9ecGU7662AOwpK0ayU0MrRSA05BYe6pMqaHf1rchMUICyAeunOmIMwybKoYrNOFS8+2aOT14/YytDIwdI2fVDl13Gl7+vNGXUBDIwkJfCWb4VAnIs6u6wLBr/Lhpggh/wLun5R58pe+r3byR0wsZEhdzPB5el5AT/xUR/+PLnYA60Dd+VnMRCsGFMA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(376014)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2025 22:04:10.4328 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 89114dba-dc84-4392-20a0-08dd5cfad2d3 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH2PEPF00000145.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7175 Allow the hwdom to access the console, and to access physical information about the system. Signed-off-by: Jason Andryuk --- xen/include/xsm/dummy.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h index 294777e904..f4656bd179 100644 --- a/xen/include/xsm/dummy.h +++ b/xen/include/xsm/dummy.h @@ -193,6 +193,9 @@ static XSM_INLINE int cf_check xsm_sysctl(XSM_DEFAULT_ARG int cmd) { case XEN_SYSCTL_getdomaininfolist: return xsm_default_action(XSM_XS_PRIV, current->domain, NULL); + case XEN_SYSCTL_readconsole: + case XEN_SYSCTL_physinfo: + return xsm_default_action(XSM_HW_PRIV, current->domain, NULL); default: return xsm_default_action(XSM_PRIV, current->domain, NULL); } From patchwork Thu Mar 6 22:03:39 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Andryuk X-Patchwork-Id: 14005461 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C61A9C282EC for ; Thu, 6 Mar 2025 22:41:28 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.904234.1312174 (Exim 4.92) (envelope-from ) id 1tqJu7-0008Su-3c; Thu, 06 Mar 2025 22:41:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 904234.1312174; Thu, 06 Mar 2025 22:41:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqJu7-0008Sl-0B; Thu, 06 Mar 2025 22:41:23 +0000 Received: by outflank-mailman (input) for mailman id 904234; Thu, 06 Mar 2025 22:41:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqJKE-0000St-3c for xen-devel@lists.xenproject.org; Thu, 06 Mar 2025 22:04:18 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on20606.outbound.protection.outlook.com [2a01:111:f403:2009::606]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f13a057d-fad6-11ef-9898-31a8f345e629; Thu, 06 Mar 2025 23:04:15 +0100 (CET) Received: from CH5PR02CA0014.namprd02.prod.outlook.com (2603:10b6:610:1ed::18) by SA1PR12MB7246.namprd12.prod.outlook.com (2603:10b6:806:2bc::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8489.29; Thu, 6 Mar 2025 22:04:11 +0000 Received: from CH2PEPF00000147.namprd02.prod.outlook.com (2603:10b6:610:1ed:cafe::a7) by CH5PR02CA0014.outlook.office365.com (2603:10b6:610:1ed::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8511.19 via Frontend Transport; Thu, 6 Mar 2025 22:04:11 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CH2PEPF00000147.mail.protection.outlook.com (10.167.244.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8511.15 via Frontend Transport; Thu, 6 Mar 2025 22:04:11 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 6 Mar 2025 16:04:10 -0600 Received: from fedora.mshome.net (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Thu, 6 Mar 2025 16:04:10 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f13a057d-fad6-11ef-9898-31a8f345e629 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=aIChjmyTqA6NIq4lvZH6Cg/M5b+GDs5s/V0bmizIuZp0JA2AxiBcN5++LLD2NgCr39fhb6MRbwFWaGPDegsRnp1YTu1nuwrXNxXokBOgh3jHIOjnvNcU8SgqDrbknQWvKNdz9pP3UmnlMrV6KAevR+hu4ZmmAJAvgey5GVJRPR5jIl40TxnNoXmHy78Kac7K6wwU1/9x1TkMMky/ZWN2kfj/Y4lDLj5Y80yFlmHfcIIQ2/c1+OweJ4OhSU7t1fQvOHJJcSfBmug6LNuN9BofsbyFhziVNWONlG6SvWzkp+zYw+cqXLqknWhACVrJxwVut1RaRbUi3VQ54tN0leFvMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ok8RL7TyW5vc5cM4sRmKREX6HGYDRWzAE9iCY9N4XB0=; b=bHTI0OfZ7oWOBtH22/JuiiiZuknQyAtjMEhxHpKkR9ASNEJZaKCo1BonkbVOI7FW4U+wRUuUD4hgcsAmY7BcnkY4MhmX8UtfogTtM3boDTANs+Bpu8z2gOz2v4Ol/dBBfic1gSHm2Lteb95TF0A616f25+a3M1jsxdWXqlnEvaULq47TPbN4eYW7MNYpsrlF8Zm47XnqmY0qAjeiTj/7xCmcgK6yAVz73nztn0WNPd4R/oaj5rZ0OKhJOAnFxEepckUhsT05m6lD0MMifT2xO9bHpw0jvuyJhdV3jkbuCpwcYt2JIaqtibgIpGcEuFYRz2v8CL3x46maKZAVivJyMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ok8RL7TyW5vc5cM4sRmKREX6HGYDRWzAE9iCY9N4XB0=; b=15LO/jV4EvSXoc05AUDZch9EU9d+D47Z8zEqFQ3ZwyXlQZ2NNmuwksnON56ogGkTtdmJR/a/pp5gA6DrjOscFVhtcP8Ijj0wo1DjzHKrxvaloevw/sMAg7//pHiov2uCHtWek2zKI118wdv4+AV5ZsaCSlyvruvK/yvpsskmKi4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Jason Andryuk To: CC: Jason Andryuk , "Daniel P. Smith" Subject: [PATCH 19/23] xsm/dummy: Allow sysctls to both hardware and control Date: Thu, 6 Mar 2025 17:03:39 -0500 Message-ID: <20250306220343.203047-20-jason.andryuk@amd.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250306220343.203047-1-jason.andryuk@amd.com> References: <20250306220343.203047-1-jason.andryuk@amd.com> MIME-Version: 1.0 Received-SPF: None (SATLEXMB04.amd.com: jason.andryuk@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PEPF00000147:EE_|SA1PR12MB7246:EE_ X-MS-Office365-Filtering-Correlation-Id: 9e301467-6413-4007-2fe8-08dd5cfad35c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|36860700013|376014; X-Microsoft-Antispam-Message-Info: wPu15T2MzxR4AV5WN3QDEw36Sjufkp8Sa7CTyOD8AZnwEpKZ1+4MAjWKlX3RO9Ch2kvKgL0evN+gFUg7P7vJkzAxO/dmGlEetzqIMeERFf3cs1PofYHsBangDToItTWknZbcA1PzIHyy2fDHFpLcnTQJeEpPXSI+XQvALgu0JNmTEhoTi67VnB6etYUWzSiebHzRzbjaG6bin56Q99PWZghTcBlCNoIoWWtLqstAQ3i60Gl2Zn8ZrIw712tec0kHJL/1QisUrE1uC07OXvCuR/HgMrnKk9V78Qnlvkg+C89yDKkG/KYPi8aFtUPk79NiSXZHSMb3UkVpFIrO5z6ut67RgulUuyu6p4VPdgBLtrhgzlS5gTpWlyqlXcTWPtjz+o+UsiDz66Au9G8VHx7lDhCyytRZ8WrRqJO21cm29udLUYCKSFeb+lw8hbE5Q33/n/FKymjSZd3gjeFChPtxXWa9G8ir59lMwwRBoQSVnTIuuT/XY1T1X8Ar4JJdNJYK8+WNK52PwmRheA/UM+iJ9dc3DtCVGXG/bJZMuibhngprcvdYCPvoAmJVl7yO8AzCusgS+2FX9vv0I1n7WuB+HoPASLfmaxAcup8Jt62eFhlIg1VuWWrhpCNw47sNLYJTFNqanxkLxYfxa6iq0CIDIqKgwXOR8oLkEsiMKBM+YgzOOdzMepeGPSOfLmwxw8v8LIGNt5z8sMBZhoOphI7PSUu8XsdLLilk3mC+N3+ee57Adwd5zvA1OQZqb+RRDHP2eoPZtcvaFjMOYPyfa/ZPtvcL5mmWCBt57AdTdJ0e95NAL1MhxqlLfiP5FjXB6ueq0ss+QyCTSG+df/ZVhDPCEwk0imGYGxo6I35DGQT4tUVnp4s7TkBPE2hrVScmmU4Wvxq+zCfFwJfc7XG17FR3s/88vXqkLsKBNBQJFL+SbLsx4eiulUND3odC9j6qjeyG0619FaMFB+GTlr+zj7bkX7G/hmBVLGWcdtkjJEGBoyGWoD/gthgu6yQBig95lxONkLx6LHAzLQUtZbzkahiZMpLtBpctV4EUq58vRFnMOma3PSMmvS3RafjKN9NxBu+fPhxAV+hlA2W150eArmcA91uj8aWTU/OxbUXFPk4zCR/wyz0cFN1+JLotAGMs7cf3ax3Z9okWWrrlMpbEyzSCKaHl5i66ry5yrnov1tNzMjjVmK+VXLKzFleKC3zDkopXERoJOucV6n+546zuUldXM1ewggrL27FPAfm4EpXhSiVvVELfZ6TqgS3WT4ZCDpSMOOWsSf9p+8n/aIhqqIIoNF2aBVOsWgvYNuO42JLTeiIubLVPPDZGrg7Y4tWKVZDybUVJm4OduVP3aM8Bl2TngXe6Qv5UURm7F3JHt5B/3KkztJtIoqygLgtf+eaoZ6YKuRLa9S/2f5Wiw/6sLQHo5iUv3N3hEsXDekrC9bnsODzbGls1+3nE9c3HRNUOwkz6hDS+J/CAxo3HUnvv1lVOs4GUsGkQYTu/7bbWPKARQc8= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(36860700013)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2025 22:04:11.3310 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9e301467-6413-4007-2fe8-08dd5cfad35c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH2PEPF00000147.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7246 xl queries SYSCTL_physinfo for the physical cpus: domU:~# xl list libxl: error: libxl_utils.c:817:libxl_cpu_bitmap_alloc: failed to retrieve the maximum number of cpus libxl: error: libxl_utils.c:817:libxl_cpu_bitmap_alloc: failed to retrieve the maximum number of cpus libxl: error: libxl_utils.c:817:libxl_cpu_bitmap_alloc: failed to retrieve the maximum number of cpus Name ID Mem VCPUs State Time(s) Domain-0 0 800 1 r----- 130.0 dom0less-1 1 400 1 r----- 130.3 dom0less-2 2 800 1 r----- 130.3 Hardware and control are both privileged. Allow them both access to sysctls so they have insight into the running system. This is coarse grained permissions for the dummy policy. Now the only sysctl denied to a control domain is readconsole. Signed-off-by: Jason Andryuk --- Could just allow physinfo to control as an alternative. There could be follow on sysctls needed in that case. --- xen/include/xsm/dummy.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h index f4656bd179..ea8b2fd6ee 100644 --- a/xen/include/xsm/dummy.h +++ b/xen/include/xsm/dummy.h @@ -194,9 +194,10 @@ static XSM_INLINE int cf_check xsm_sysctl(XSM_DEFAULT_ARG int cmd) case XEN_SYSCTL_getdomaininfolist: return xsm_default_action(XSM_XS_PRIV, current->domain, NULL); case XEN_SYSCTL_readconsole: - case XEN_SYSCTL_physinfo: return xsm_default_action(XSM_HW_PRIV, current->domain, NULL); default: + if ( is_hardware_domain(current->domain) ) + return xsm_default_action(XSM_HW_PRIV, current->domain, NULL); return xsm_default_action(XSM_PRIV, current->domain, NULL); } } From patchwork Thu Mar 6 22:03:40 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Andryuk X-Patchwork-Id: 14005464 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC5B4C28B25 for ; Thu, 6 Mar 2025 22:41:37 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.904248.1312203 (Exim 4.92) (envelope-from ) id 1tqJuF-0001Pa-5Q; Thu, 06 Mar 2025 22:41:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 904248.1312203; Thu, 06 Mar 2025 22:41:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqJuF-0001PN-19; Thu, 06 Mar 2025 22:41:31 +0000 Received: by outflank-mailman (input) for mailman id 904248; Thu, 06 Mar 2025 22:41:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqJKI-0000St-4c for xen-devel@lists.xenproject.org; Thu, 06 Mar 2025 22:04:22 +0000 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on20616.outbound.protection.outlook.com [2a01:111:f403:240a::616]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f1f812fe-fad6-11ef-9898-31a8f345e629; Thu, 06 Mar 2025 23:04:17 +0100 (CET) Received: from IA1P220CA0007.NAMP220.PROD.OUTLOOK.COM (2603:10b6:208:461::17) by IA0PPF1D04084C7.namprd12.prod.outlook.com (2603:10b6:20f:fc04::bca) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.20; Thu, 6 Mar 2025 22:04:12 +0000 Received: from BN3PEPF0000B370.namprd21.prod.outlook.com (2603:10b6:208:461:cafe::a) by IA1P220CA0007.outlook.office365.com (2603:10b6:208:461::17) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8511.19 via Frontend Transport; Thu, 6 Mar 2025 22:04:12 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN3PEPF0000B370.mail.protection.outlook.com (10.167.243.167) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8549.1 via Frontend Transport; Thu, 6 Mar 2025 22:04:12 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 6 Mar 2025 16:04:11 -0600 Received: from fedora.mshome.net (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Thu, 6 Mar 2025 16:04:11 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f1f812fe-fad6-11ef-9898-31a8f345e629 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XgKb1dCYQl/PL4rEeeVbJy3merYIjP8w619jubbZaZ/eFLZBmGLMpCd9tPkveTV+msh6fzQ50v1cmdkkb7AzabPFYq3MxM7jyMJmR1YEIWY+KOOHZgBDrp1Nk5gudgB2cXxW+rMzFsvd+BQTSDtrABFFjzwvpMIxFBBGDXKPgrtR8JsZYoXapnimrD63UefaXsBAOutINh3tz5+FCMTJAA2p+1z4PrO4v9vQfm/09Z4JmDZlg/HbEIkKg19gr0xft3Enoqu7utYV2QpUx38wS1ikgbJLqnMhYbwRNlDgmUmmKdQvfgSQpONSuTkhApNdSqQjdk6QhP4ZOJsRDDOWkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JPs55QsbN5eLARlGEAoRr/S0ZzRWapeUl7F5PScoPKM=; b=pgn+MTHG2aKpEq2Cv4AeffHaqRjEVr0f4uJ7M9dEv68900UUNdeKRzmukCAADcYN9+vVUs26u31SpX/uwOv1SvIzRs03QGyWUsfVnoViA0yzWhqheXD7KGXbQzzZLCDRdagiL2kjAzB1PyReN6K86lEHuoWhBTyyvXEb2hET+xQ7Q4h/z5fDgiYk9uIfBJDO2fv85TtaojKIJZ2cGaKxQUm13dvUs8zAxsGPTb9i+OXQbOrQV6HyRnvy4dg1GE263m7ZroArqN1YcE/wpuAF9bFtQvadpV7DHw1b1QyT/cGlk1EyQmm47kRt96qDI5DAWLLZS7d4TUJPnIlfnioHsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JPs55QsbN5eLARlGEAoRr/S0ZzRWapeUl7F5PScoPKM=; b=y6aUXXQfUY5YbR2S0/RqMfaS1afTwPZ2HuBsAna+trEQXBJ2eCdAHz3uPWs7jZ/ZpjjX8VDUJeFLZ//PP772X8uUGgILr2tFEF0bp/L9vsB2ZJK6OUr24/SbJpMcZRLu7cmnmpaqoK26Ilij017rnzdpKpSPKtubsHaSttUyi88= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Jason Andryuk To: CC: Jason Andryuk , "Daniel P. Smith" Subject: [PATCH 20/23] xsm/silo: Support hwdom/control domains Date: Thu, 6 Mar 2025 17:03:40 -0500 Message-ID: <20250306220343.203047-21-jason.andryuk@amd.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250306220343.203047-1-jason.andryuk@amd.com> References: <20250306220343.203047-1-jason.andryuk@amd.com> MIME-Version: 1.0 Received-SPF: None (SATLEXMB03.amd.com: jason.andryuk@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B370:EE_|IA0PPF1D04084C7:EE_ X-MS-Office365-Filtering-Correlation-Id: 4c818c7f-bee5-4c31-ad47-08dd5cfad3ec X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|36860700013|1800799024; X-Microsoft-Antispam-Message-Info: sybdcg/DlhAfGXP0hsrikDOHaUMXVwN8ZeM2YyfthrLlzd8LjsMdAISF6QNu67bsp7yoxjYKobqAZBoEs5bHQv6ByzFrD8m4KdJZrAov9tnQTlNqGxuBQOevL7NAiYa17tBLpkFu2FnMZrJGkCjfsDywVuumB52Wthhmnnh4fiVqgtOjPTxAA/pjw6svLzPB+xW6eH7H+1jCPGK+AxA4foJkmWpEk34hocmU+Pta0pYZKwjYyqoEbRerkbvgISYX2OltBdR76E6J6T6bUcx8lTglaN+rhQGSm/CZhFUTyJWOYGjkRURno+zIDITigqpJ3HOYqTT8562dHRcJn13bwAtSFDpOqjf6exso0ghs5lRG/Q18tOXwuYUMeOSSsjIWRmlRN4wlycAF3k+nWvUO9qmUY8ocwAw/I+LZ16sWN+q8B0k5l4o4D1FRRUACZWlOoI9D/60mjalc9KQFFRdltu++A8avN33JOA4/QFKzFpPM/fvGc1FKl661IQdeH+zVlHlF22X7eUhSH0b2vHv0lgOpCCzLKzo1DLTOQV2ojyVotzv3+S+Sy/k/UTa2LIDPYN//5Gpo0+dUTMYrFehtL6i8HSZDThyIUDgU8PYilqf4xbSt6CecX9WOTjXLezOBCVapcKmzB4cB288aoHRABf3e2SrPbaUKnCpiwpuGPb6g9X/CiLgGukJRziHouWiZlRsfNIpizEWqlQmFyGB9WbIHvduR5Mb+x6WF8sIpyTwkUoq9pPGxRmzy9PpDCnVrFuBr33hVQy5J/ID7MQKrqbPTYWIKVCg+C5QWjOulQFlUoKonoUqKmwno4KDscrhio5+iH4UPKTNLH38cyS2l5XyTkZwx7xue69g7iaCAchGJgMe8Npk1FQc7UHFsy7nXhhOoBPJJNYo+2gFEX+m2mC8xhUZ5uc15G4yuWXd4zCFdKWt85Buh7BKzCmNgO3mtM+I9CTAb3bc1u/PswxUeOtDQSJ40sJY1MeIPklkmD5YPAfd86uU3qFuU6C6JPnP1mmqIVCKvuDZAHrYt9y185OYWZe9Bsi9b7HUsrb0CDNtzzoXtG5S0A+gbcXRCJ/bC7jbt7YBsBY9gbJU0IDXvvqY9F7mIGriCe5ognGfAl1nRVAjPlaDsLOaZ9XWEAW0POg3BypWuP8pjBsWBX1VDxu0puxDEQ9by4pOK1s4hiZUgQt+j78n6RLIcuWs+EOqDRthKzasAzXbE5azXVk9saUwU1znVNehlNoQdrHbe0z56gMLrqEdNVb/5KtZGwL0yUY3PyGnLou1QWOblVmWRliKHM6NwsHbRHa2KN89U65+zSvcK91HLYo6uifR5tI3rW+YmnOLrO3qo/ya5DXRNm777McFfnSZqzh8mjk2NDXrw5shh15G1F2C700UBgtU1qNRUKdvFsRdwb7pljtNklieag5l7dECFCM6B6TBlTvQ7WO4XXFuEQK7Ts9y3NOK9KxdUFkO7LE3hF8f2YXMtFdGjZujLDK4U3wAk+8ux/RM= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(376014)(36860700013)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2025 22:04:12.3092 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4c818c7f-bee5-4c31-ad47-08dd5cfad3ec X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B370.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PPF1D04084C7 The is_control_domain() check is not sufficient for a split hardware/control domain. Add is_priv_domain() to support allowing for either control or hardware. Without this, a xenstore/hardware domain is unable to map a domU's grants. This silo check is for grants, events and argo. The dummy policy handles other calls, so hardware is prevented from foreign mapping control's memory with that. This would need to be expanded for a standalone Xenstore domain. Signed-off-by: Jason Andryuk --- xen/xsm/silo.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/xen/xsm/silo.c b/xen/xsm/silo.c index b89b364287..d5e1a554ea 100644 --- a/xen/xsm/silo.c +++ b/xen/xsm/silo.c @@ -20,6 +20,11 @@ #define XSM_NO_WRAPPERS #include +static always_inline bool is_priv_domain(const struct domain *d) +{ + return is_control_domain(d) || is_hardware_domain(d); +} + /* * Check if inter-domain communication is allowed. * Return true when pass check. @@ -29,8 +34,8 @@ static bool silo_mode_dom_check(const struct domain *ldom, { const struct domain *currd = current->domain; - return (is_control_domain(currd) || is_control_domain(ldom) || - is_control_domain(rdom) || ldom == rdom); + return (is_priv_domain(currd) || is_priv_domain(ldom) || + is_priv_domain(rdom) || ldom == rdom); } static int cf_check silo_evtchn_unbound( From patchwork Thu Mar 6 22:03:41 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Andryuk X-Patchwork-Id: 14005458 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 167FAC282EC for ; Thu, 6 Mar 2025 22:41:03 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.904181.1312144 (Exim 4.92) (envelope-from ) id 1tqJte-0005qK-3K; Thu, 06 Mar 2025 22:40:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 904181.1312144; Thu, 06 Mar 2025 22:40:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqJte-0005qD-0P; Thu, 06 Mar 2025 22:40:54 +0000 Received: by outflank-mailman (input) for mailman id 904181; Thu, 06 Mar 2025 22:40:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqJKN-0000Ss-EF for xen-devel@lists.xenproject.org; Thu, 06 Mar 2025 22:04:27 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2060e.outbound.protection.outlook.com [2a01:111:f403:2413::60e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f2c49f23-fad6-11ef-9ab4-95dc52dad729; Thu, 06 Mar 2025 23:04:18 +0100 (CET) Received: from BN9PR03CA0144.namprd03.prod.outlook.com (2603:10b6:408:fe::29) by CH3PR12MB8460.namprd12.prod.outlook.com (2603:10b6:610:156::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.17; Thu, 6 Mar 2025 22:04:13 +0000 Received: from BN3PEPF0000B373.namprd21.prod.outlook.com (2603:10b6:408:fe:cafe::63) by BN9PR03CA0144.outlook.office365.com (2603:10b6:408:fe::29) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8511.17 via Frontend Transport; Thu, 6 Mar 2025 22:04:13 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN3PEPF0000B373.mail.protection.outlook.com (10.167.243.170) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8549.1 via Frontend Transport; Thu, 6 Mar 2025 22:04:13 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 6 Mar 2025 16:04:13 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 6 Mar 2025 16:04:12 -0600 Received: from fedora.mshome.net (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Thu, 6 Mar 2025 16:04:12 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f2c49f23-fad6-11ef-9ab4-95dc52dad729 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gTiOTT6PtE62i9SehkDuO0BexDXnaJy1IM1A2PV6IapK7+eDFbtSMrC6veKheDY0eZ+Ak8vIWw8Sp+qZC+C5KO3ug2idypjhyrNCwqK2M0Mytmxd4OtH0d+gU0F18VJwQiWxnsIAG9vU7k/eIi/gItJ8iQeZy3hZmSTzUEraSxPqAHL4g+vH3yWc5AwxZ3EfOHGEuNX3oEb9ecWGDbPaaUbLs3Rp6v8EUmyFBFk1xZDXsJcVEyJuIO1HUZ6vJPuBzXjhfkF3z7YkFn8Tutt/VND+j8cQNq18Ujv9yifuTEbPWrOTkPiWKKNjiehGbjyNYKqkuN7U/k2b2EJweWvhrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oCnSvUEbBl2NRwW+E2RfVK1yKiEOuzZqq9MfzzVMA+c=; b=EOPG8I5kR39/xfSgLN9cl1x/ks5T2pTyqAJf3fhFUReXBRboy39CD/ogu7kB+YdD4afR/3x0LH72hXQL+NTa4IA9CQG+Ru1/cohS8glCdhbwrXLtKxt4Yc+FrJcrYZ38T4MNSajJMqIgIddKMuvQRdAqhZVHvOpJ+7sNHn6zJErYBMaoIi0zolv7rADVOTGBksGjoWHJw6W75iSBj8NnFakEPBgSsYd4lHESLC1PmQJ8CD+iEamAFLK33yE6jSdCTGWRh5LwTZFMBFmE+d7WNImV1gmJuVSOdNjtJLgtDRjlcwH3b8A5Q1WqoGhcySOBlm8fH0QlRJhQeF6t00Y1Iw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oCnSvUEbBl2NRwW+E2RfVK1yKiEOuzZqq9MfzzVMA+c=; b=OBHLwaMIelF+ktQM50iUT0WRF+p9eVUqOs1rJuwmUg4ALjw99VX/czOhZYHu9yUMq5lF6N+Cl0zU9z5v8D6++dUzx/BsUXjf7yRhjgUYiBYNTmIxn+kjVUazEDKGNbL+vr6g3AoBKUC8CiPQajP5edy4xVEWr5IoUL2j85+26jw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Jason Andryuk To: CC: Jason Andryuk , Doug Goldstein , Stefano Stabellini Subject: [PATCH 21/23] automation/dom0less-arm64: Use double quotes Date: Thu, 6 Mar 2025 17:03:41 -0500 Message-ID: <20250306220343.203047-22-jason.andryuk@amd.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250306220343.203047-1-jason.andryuk@amd.com> References: <20250306220343.203047-1-jason.andryuk@amd.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B373:EE_|CH3PR12MB8460:EE_ X-MS-Office365-Filtering-Correlation-Id: 578b3c3b-cc61-49c7-435a-08dd5cfad4b9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|376014|36860700013; X-Microsoft-Antispam-Message-Info: YMhgqCOpBckchAaG3xcFDCxOWkQocoq2Gr8QS7SdMJfqo/hedIcEspjx9H0GEXJi5HRD2xnenAH7mfYlGuhaeakrpknpspXN6Ho7OK211cFOMz6DdzhoDoTMu595AW/25ws6ohPuKNF4U7brR3VWhIdF5MCwH+aLZbq1k3kdV3kpHTO2jWwWryMPGthG3jrWqieahLjIgJbiM9S7lGq22dQORr1CZXTVJAMsdb06NRsYEYpml89mpdhqQEzhNw82+FYxD/nhhT1MZIUi4JioNVV71FKKTWQFIKnmmU3/Qf0IibWfpAFxHuIdUoUP130Jot+uVV2qMX5hQ9rp+QVSLNGOIfSHIjsHGO1ek36pvdayoJNx26+tR6FVu5ETjb1/DCLSzTvXso/CA2m4IX6p5xzmoNo2EJzhwi9w6UriW4ArpdVjSKY++YFoXI0K28GGwtfu4UF2abV58at1uXxaFyeRZIyVpDJwfqaBjLnNTaMbuZMhVrWjLqnAbgyhzndUM92GOllNS1Dxn3+UHCVzRUlnhnqROJt2g42+GZ4kbt3YXTqYGPR9gm46saP12ckDjaF5pUTlhMJvZdFT1/DOJx9Cma0Sb/9HI9ZPutNYjjo2oigDz6M3vHP90ggBUrma379qJjIoNkxU6iDN8WU/Qiph/3xAHnyZa+O5BxhEWjJhYnOczlB20Q3Z4x2+7SNpdZqZ+metVC6O4dvBGKkTTtx4KOK69hUf2GOgvpiL9EBGtApzWy/n+jTIDg+xN0sDl8jvK3pM6KkDRa29fxcv40yg7DK1dOJTaLtCzgHsqNhHn2QyyDWN1hxwQaSCDCowktjlAMH6CWGoq1BCheiFqdlkSAegERn2vG7grlTD1LfC7mXoDbSg4QHpvMLna9dRIgEr+PJD4S8F8w/Qlrhm8jsLflkOwV3QrWLyCBuXOrvxq8wi5B8lpZw0AoymelmJCC0NCnfpp7N6sgI29GvRHs82PGv6Rv0bTBeZX27t7VoN92MtF4MqKvvcOSwGGlKx3+XQcPQ9zag9kr6zFyV0z+aXBjnGz9JMBt6RvqI7yFxMCVMpFob4PDaIRr6x0P31Fh8j8yZBB1qr7fU7IAH0drzgD/x3BqvKqDfGor1jSrzrj3ARjiV9EBQxZ5yZLEUg5hrsdIzAZqHULm5AY33ETHrCrk4o4+ZawMik1GpgKHGprpU+7BpJWArp9uKKawFK3bomL1Ob5w/I9DR0E0G0igxHXpHry21bDAUu+LLwsoqfKb6VSfLGD5q2KrL/KVe34xIl6n+8v9kPK4LRqYG5rUSkYljuo6JiSJrG3ziTV6qt1TBOtbhwZhcsfgQByE1PvxPFHlXy5mJ520x+eyIeqUZ0ycUuER6GkIlrtFMLSXb5R1oYZMSy1YJVoAz25o7Wkx/JXIpEh02sPITQndv/ami3NHnLpyojYsYqwBIWmusZYr0AnodGFvC79iCMQo4/ X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(376014)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2025 22:04:13.6501 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 578b3c3b-cc61-49c7-435a-08dd5cfad4b9 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B373.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8460 Use double quotes so we can change the contents of the base imagebuilder config. Specifically, we'll want to remove the dom0 entries for a split hardware/control domain test. Signed-off-by: Jason Andryuk --- .../scripts/qemu-smoke-dom0less-arm64.sh | 34 +++++++++---------- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/automation/scripts/qemu-smoke-dom0less-arm64.sh b/automation/scripts/qemu-smoke-dom0less-arm64.sh index f72d209361..439e07c90f 100755 --- a/automation/scripts/qemu-smoke-dom0less-arm64.sh +++ b/automation/scripts/qemu-smoke-dom0less-arm64.sh @@ -147,26 +147,26 @@ find . | cpio -H newc -o | gzip > ../binaries/dom0-rootfs.cpio.gz cd .. # ImageBuilder -echo 'MEMORY_START="0x40000000" -MEMORY_END="0x50000000" +echo "MEMORY_START='0x40000000' +MEMORY_END='0x50000000' -DEVICE_TREE="virt.dtb" -XEN="xen" -DOM0_KERNEL="Image" -DOM0_RAMDISK="dom0-rootfs.cpio.gz" -XEN_CMD="console=dtuart dom0_mem=512M console_timestamps=boot" +DEVICE_TREE='virt.dtb' +XEN='xen' +DOM0_KERNEL='Image' +DOM0_RAMDISK='dom0-rootfs.cpio.gz' +XEN_CMD='console=dtuart dom0_mem=512M console_timestamps=boot' NUM_DOMUS=1 -DOMU_KERNEL[0]="Image" -DOMU_RAMDISK[0]="initrd" -DOMU_MEM[0]="256" -DOMU_KERNEL[1]="Image" -DOMU_RAMDISK[1]="initrd" -DOMU_MEM[1]="256" - -LOAD_CMD="tftpb" -UBOOT_SOURCE="boot.source" -UBOOT_SCRIPT="boot.scr"' > binaries/config +DOMU_KERNEL[0]='Image' +DOMU_RAMDISK[0]='initrd' +DOMU_MEM[0]='256' +DOMU_KERNEL[1]='Image' +DOMU_RAMDISK[1]='initrd' +DOMU_MEM[1]='256' + +LOAD_CMD='tftpb' +UBOOT_SOURCE='boot.source' +UBOOT_SCRIPT='boot.scr'" > binaries/config if [[ "${test_variant}" == "static-mem" ]]; then echo -e "\nDOMU_STATIC_MEM[0]=\"${domu_base} ${domu_size}\"" >> binaries/config From patchwork Thu Mar 6 22:03:42 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Andryuk X-Patchwork-Id: 14005460 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1E1AFC282D1 for ; Thu, 6 Mar 2025 22:41:22 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.904216.1312164 (Exim 4.92) (envelope-from ) id 1tqJtz-0007ce-OF; Thu, 06 Mar 2025 22:41:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 904216.1312164; Thu, 06 Mar 2025 22:41:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqJtz-0007cX-J3; Thu, 06 Mar 2025 22:41:15 +0000 Received: by outflank-mailman (input) for mailman id 904216; Thu, 06 Mar 2025 22:41:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqJKO-0000Ss-EO for xen-devel@lists.xenproject.org; Thu, 06 Mar 2025 22:04:28 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2061b.outbound.protection.outlook.com [2a01:111:f403:2009::61b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f3bc2bf9-fad6-11ef-9ab4-95dc52dad729; Thu, 06 Mar 2025 23:04:20 +0100 (CET) Received: from CH2PR18CA0044.namprd18.prod.outlook.com (2603:10b6:610:55::24) by CH3PR12MB9314.namprd12.prod.outlook.com (2603:10b6:610:1c5::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.16; Thu, 6 Mar 2025 22:04:14 +0000 Received: from CH2PEPF00000144.namprd02.prod.outlook.com (2603:10b6:610:55:cafe::75) by CH2PR18CA0044.outlook.office365.com (2603:10b6:610:55::24) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8511.16 via Frontend Transport; Thu, 6 Mar 2025 22:04:14 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CH2PEPF00000144.mail.protection.outlook.com (10.167.244.101) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8511.15 via Frontend Transport; Thu, 6 Mar 2025 22:04:14 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 6 Mar 2025 16:04:14 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 6 Mar 2025 16:04:13 -0600 Received: from fedora.mshome.net (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Thu, 6 Mar 2025 16:04:13 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f3bc2bf9-fad6-11ef-9ab4-95dc52dad729 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WUJDn5lI44BO4YdC/pW+R01M4NmMhS/tYq2hixFw7wGBpHGGcPjcFdPWOzeCxF82IRnI4y+xQfr6hG8Nmi2K93flr3wIREfN19hyTugNs8YDm3t2DHq8MXBj2KyF9g7KcFBxSL5ejaxRJW7UpKhJiqTB4MQ5hfIAci2Wsp9r36KFE7Wuv0H2X41VTx7072bJOLBIPKohYQX8x8YOBN5qWn41JUjnIIm2zMLSTbUiUnMfET0hJsL5EshDBqFe608XLBoLNXaP3OxHuFhRtYn0o1DaNTZG0eYBO0n2DdxsLX0if4q45Cmtz7FK9QAgUh6v8qSgqWSDeQnuUAmwOVjl2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vdj/omG7aNG4QUYzbT1Q3RmuRPZYorhXrmyOwRld3kU=; b=cpMn+kSeB9+M0IsBJrx6sVW8bOwXaMiij4oXA3igekbu70Hr2x1mkKjEBPOICUOrDrmlxX2hMT75ZJyFSAz07vSgbOF8bwgLUwr3nF8DlK95LjJHY/Y76BKke0deoM/n0R+mP+cz0rzOKuhBVpfZuau8pJb+5KZLFg0sK0CC4NVCP4mA8qH2UvbQB5XIJh2SPBX30KVQ7RJFBVwNAYkAWjEsnQayJZYwCgsEXXeKMcgW0xR42H/LChm3sKkqeXS6135AUJo7rSKZhpUXxKUBrTMFCKQbgTTtj6JbMmPLdCjF53ylJYYdxLWAAV+19NhihdChOHCw/b+JOmH7NgxKMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vdj/omG7aNG4QUYzbT1Q3RmuRPZYorhXrmyOwRld3kU=; b=cuxrcfp3/o+3bMTofiSP9+EEXs2xhHD+53XItarsjWuJQPpS/bKLmAxRKEOrTZ6LDWfyLhXCIFcWB+QdLUwD7UcnGLyAfEKx0n1lgR3FW17vdwXvWjUoCHX2HQvhaJouDp54z0YGKaGVeoR86jIOQTttIyLpWc+4Phx7mHpD+rE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Jason Andryuk To: CC: Jason Andryuk , Doug Goldstein , Stefano Stabellini Subject: [PATCH 22/23] automation: Add arm64 hardware/control split test Date: Thu, 6 Mar 2025 17:03:42 -0500 Message-ID: <20250306220343.203047-23-jason.andryuk@amd.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250306220343.203047-1-jason.andryuk@amd.com> References: <20250306220343.203047-1-jason.andryuk@amd.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PEPF00000144:EE_|CH3PR12MB9314:EE_ X-MS-Office365-Filtering-Correlation-Id: be72176e-8657-4f62-3614-08dd5cfad54f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700013|82310400026|376014|13003099007; X-Microsoft-Antispam-Message-Info: 2nuEhZcpqroSMopm4vxSaunFX8gGXnbTweGQtAvDfObhbG/kTtUxIj+42HtflHN6sUUw7KaTZQV5MjM0QRfD0z9qL9HJHN1iCUdvcwv4bx48Iut0KBfq3WZxQc1FIQC22IK/nFPWqg6KAStQU1TcpkOeKZCxqfBke7NzvXk3OHjpoXQpihrUa+X4/+MbGuFuLI7rslWJCiKAFr6RXBykAXEInJ2/hWRFn12v7/J/0YoLG3XIknFFMzht5Hbxw7FguNKmYqBMNDKKVJ49Xc5MRfhFcPnTHX8NfLU32k5shgM94j6pvZkTGEzynUmSVefu3Ko8NrBNq4e2f6DtilxYcO7LgI0kg9YiG98UECWhN9mYuaJpuWnVb177RDiqGjCB5QxFJLKQRaBmuPY0NuNazocJdnDRDeMxZejeC/8Z6zuj7ObOrgNEzLySoGzyzMoPHMupE8rQH0BGKogNTqMgTn5qexZA363IUmtnLb5jIDQbedg2B4TAYoVtygBH1rEInqwp0QAIOqg2NPPjaF5U8GjZQ7iSRJzNfS/+yviy1ynqjuAYwdiSCprPMIueZkBZNPF/vGI8VQRuUeE9s/nkb2sO5nSDM/jNcXmFnBTXtExHpKnBSBa87CvZBzv3xujthBpmdKhdYcO6TtoCYTBC2FEYwlkmyB0qaoInQDh4f2Yg1CTyNa35qaD4L1aIglgrHB5liK/b1/+Z6sDvqINCvXrvD4qx1VVENwEaoXt15YuQgNs2YJxpoTljBPUc1cqaH7pGnnbEpWm2eGtgmJ6ehpDHX+i96icgehcKkfvfVHAniZVs0GMSmbdzV5sAeJIfQC7I/pkzwijJlZaGwL+HKGS0StgWscJrvA1vB8kuXGXJkGXtkEKDdXv38IZ4MW16Us4Wy5b0cYU/koFgJJ2NyUKykdFtV+hsNggktTxSdWEQ+maL3h0bRmxBNp/9Tjttar+zyuxmTP1TDtPcoQIFhzViJt2QODZv1+D5CH5ze6/53tcoh6AOpOzsLJ2GFm/X8MvXhjAb++4LAowfV9vAEh71HYwxSmFdzUcETSkyrR1t8vDFTh531Ymg9GC9+EeddCsncAFFAV8T0yS3zFewwtu8pqrnwtLRVJUxOM8MSdgeMnVco16NdJRA+g9Os5iJ+ixA12OLrIgV4mxiSHo8em6jO8PzsM9VboCawZT5k/DvJJTYZaJ9DVUdwxBclqfVBhTRUvlviDPCDVS6yqCPmJ//XWYUPGjeKp7PPJaehBgHNXWGNpTngSB+/btSzrjmqbl9XhcENLvPRJRF4Y01jlHXYrqxqwbGZXjbupV+6zjkAuO9jur2tktgOGlkBM8JfGODhn5wyLEnuCkDB6vz0O+aRI7MoOt3G2o2aXizhERdoP/UfV8TWgFM5vQEOFRgxic4Kk01BU10eG7WSKSkFUKtABCR0M5ki53xxLmT1PWHarM99/HLivm4YVH3dTBrC8nkRpCMu07eX0/52umpWfbs9dqbxcmhyMlAbwBUJUQ= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(36860700013)(82310400026)(376014)(13003099007);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2025 22:04:14.6171 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: be72176e-8657-4f62-3614-08dd5cfad54f X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH2PEPF00000144.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB9314 Use dom0less to create a hardware+xenstore domain, a control domain, and a regular domU. Create a domU-rootfs that does not run the xen scripts, but does have the xen tools installed. The domU also uses a console on ttyAMA0 instead of hvc0. We need to increate dom0less test memory or ImageBuilder fails with: Error, not enough memory to load all binaries Use C xenstored so hardware/xenstore can grant map control's xenstore grant. Signed-off-by: Jason Andryuk --- Initially, I tried to put xl list into control. That executes before dom0 runs init-dom0less, and it hangs. I expected it to recover after init-dom0less introduces it, but it does not. That needs further investigation. --- automation/gitlab-ci/test.yaml | 8 +++ .../scripts/qemu-smoke-dom0less-arm64.sh | 67 ++++++++++++++++--- 2 files changed, 66 insertions(+), 9 deletions(-) diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index 9530e36e9a..a7f7fbb4bc 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -403,6 +403,14 @@ qemu-smoke-dom0less-arm64-gcc-debug-gicv3: - *arm64-test-needs - alpine-3.18-gcc-debug-arm64 +qemu-smoke-dom0less-arm64-gcc-debug-hwdom-control: + extends: .qemu-arm64 + script: + - ./automation/scripts/qemu-smoke-dom0less-arm64.sh hwdom-control 2>&1 | tee ${LOGFILE} + needs: + - *arm64-test-needs + - alpine-3.18-gcc-debug-arm64 + qemu-smoke-dom0less-arm64-gcc-debug-staticmem: extends: .qemu-arm64 script: diff --git a/automation/scripts/qemu-smoke-dom0less-arm64.sh b/automation/scripts/qemu-smoke-dom0less-arm64.sh index 439e07c90f..39614720a4 100755 --- a/automation/scripts/qemu-smoke-dom0less-arm64.sh +++ b/automation/scripts/qemu-smoke-dom0less-arm64.sh @@ -78,6 +78,12 @@ if [[ "${test_variant}" == "gicv3" ]]; then domU_check="echo \"${passed}\"" fi +if [[ "${test_variant}" == "hwdom-control" ]]; then + gic_version=3 + passed="hardware xenstore" + dom0_check="xl list --verbose" +fi + # XXX QEMU looks for "efi-virtio.rom" even if it is unneeded curl -fsSLO https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom ./binaries/qemu-system-aarch64 \ @@ -114,7 +120,7 @@ cd initrd find . | cpio --create --format='newc' | gzip > ../binaries/initrd cd .. -# DOM0 rootfs +# DOM0/DOMU rootfs with Xen tools mkdir -p rootfs cd rootfs tar xzf ../binaries/initrd.tar.gz @@ -125,6 +131,31 @@ mkdir sys rm var/run cp -ar ../binaries/dist/install/* . +echo "rc_verbose=yes" >> etc/rc.conf + +# Create a domU variant +if [ "$test_variant" = "hwdom-control" ] ; then + echo "domU" > etc/hostname + sed -i 's/hvc0/ttyAMA0/g' etc/inittab + + echo "#!/bin/bash + + export LD_LIBRARY_PATH=/usr/local/lib + + ${domCTL_check} + " > etc/local.d/xen.start + chmod +x etc/local.d/xen.start + + find . | cpio -H newc -o | gzip > ../binaries/domU-rootfs.cpio.gz + # Restore hwdom console + sed -i 's/ttyAMA0/hvc0/g' etc/inittab + + # For dom0 - must use xenstored for grant mapping + sed -i '/^#XENSTORED=/a XENSTORED=/usr/local/sbin/xenstored' \ + etc/default/xencommons +fi + +echo "dom0" > etc/hostname echo "#!/bin/bash export LD_LIBRARY_PATH=/usr/local/lib @@ -142,27 +173,45 @@ xl network-attach 1 type=vif ${dom0_check} " > etc/local.d/xen.start chmod +x etc/local.d/xen.start -echo "rc_verbose=yes" >> etc/rc.conf find . | cpio -H newc -o | gzip > ../binaries/dom0-rootfs.cpio.gz cd .. +if [ "$test_variant" != "hwdom-control" ] ; then + IB_DOM0='DOM0_KERNEL="Image" +DOM0_RAMDISK="dom0-rootfs.cpio.gz"' + IB_XEN_CMD='XEN_CMD="console=dtuart dom0_mem=512M console_timestamps=boot"' + IB_DOMU_EXTRA="DOMU_KERNEL[1]='Image' +DOMU_RAMDISK[1]='initrd' +DOMU_MEM[1]='256'" +else + IB_DOM0='' + IB_XEN_CMD='XEN_CMD="console=dtuart console_timestamps=boot"' + IB_DOMU_EXTRA="DOMU_KERNEL[1]='Image' +DOMU_RAMDISK[1]='dom0-rootfs.cpio.gz' +DOMU_MEM[1]='700' +DOMU_CAPS[1]='hardware|xenstore' +DOMU_CMD[1]='console=hvc0 earlycon=xen earlyprintk=xen clk_ignore_unused' +DOMU_KERNEL[2]='Image' +DOMU_RAMDISK[2]='domU-rootfs.cpio.gz' +DOMU_MEM[2]='700' +DOMU_CAPS[2]='control' +DOMU_ENHANCED[2]=1 +NUM_DOMUS=3" +fi # ImageBuilder echo "MEMORY_START='0x40000000' -MEMORY_END='0x50000000' +MEMORY_END='0x80000000' DEVICE_TREE='virt.dtb' XEN='xen' -DOM0_KERNEL='Image' -DOM0_RAMDISK='dom0-rootfs.cpio.gz' -XEN_CMD='console=dtuart dom0_mem=512M console_timestamps=boot' +$IB_XEN_CMD +$IB_DOM0 NUM_DOMUS=1 DOMU_KERNEL[0]='Image' DOMU_RAMDISK[0]='initrd' DOMU_MEM[0]='256' -DOMU_KERNEL[1]='Image' -DOMU_RAMDISK[1]='initrd' -DOMU_MEM[1]='256' +$IB_DOMU_EXTRA LOAD_CMD='tftpb' UBOOT_SOURCE='boot.source' From patchwork Thu Mar 6 22:03:43 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Andryuk X-Patchwork-Id: 14005462 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 06FF8C282D1 for ; Thu, 6 Mar 2025 22:41:31 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.904236.1312179 (Exim 4.92) (envelope-from ) id 1tqJu7-0008W7-Ep; Thu, 06 Mar 2025 22:41:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 904236.1312179; Thu, 06 Mar 2025 22:41:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqJu7-0008UM-84; Thu, 06 Mar 2025 22:41:23 +0000 Received: by outflank-mailman (input) for mailman id 904236; Thu, 06 Mar 2025 22:41:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tqJKO-0000St-54 for xen-devel@lists.xenproject.org; Thu, 06 Mar 2025 22:04:28 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2061b.outbound.protection.outlook.com [2a01:111:f403:2414::61b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f4453e15-fad6-11ef-9898-31a8f345e629; Thu, 06 Mar 2025 23:04:21 +0100 (CET) Received: from BN8PR15CA0008.namprd15.prod.outlook.com (2603:10b6:408:c0::21) by PH7PR12MB9126.namprd12.prod.outlook.com (2603:10b6:510:2f0::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.19; Thu, 6 Mar 2025 22:04:17 +0000 Received: from BN3PEPF0000B374.namprd21.prod.outlook.com (2603:10b6:408:c0:cafe::c2) by BN8PR15CA0008.outlook.office365.com (2603:10b6:408:c0::21) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8489.23 via Frontend Transport; Thu, 6 Mar 2025 22:04:16 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN3PEPF0000B374.mail.protection.outlook.com (10.167.243.171) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8549.1 via Frontend Transport; Thu, 6 Mar 2025 22:04:15 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 6 Mar 2025 16:04:15 -0600 Received: from fedora.mshome.net (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Thu, 6 Mar 2025 16:04:14 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f4453e15-fad6-11ef-9898-31a8f345e629 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LAUBJVD7RE3GQRpISjcpcpUmMapB8vP/xvawGwV1MDNiklPa8nxvmGF5OF97PyOy1glynVGiSz4QXF57Sb+p6c9heDo9Gz6U+QEpLoEvf8GwUHXenDqiOTkS1ARwC76lAaWjda6f1yYrXjDE2w3+/yQzBFOTZZFgLzk3DNHVtEULrXfISOadGRavAR5Uxq6T0IQ+wlM8tE6LOOc9rndK7fYnVMyliNTHktDE2FHJjWSZGHtxr8ojGxlSZiiDD4Q4iLwaZOKzsUtlfEVrAV9In8EWVmyaoIgPsms5b9g879SoyU2EOoqaxaXMnxA7wr2YCV8jB7PYL0TvK/oIlJG94Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SUhXI5hfUJRz8vEpwnsKqvXWD86IJzc1qF1Le5xsGbI=; b=ZM/aZLqWgpKdlNIQWHC7c5Pbhm+Bita2a1OfAYig7QWP4lsTxl2Opr0/bo0966dFhrNMlS+1T5IR4LYY1ZKPIw3TAQ6KoEcF2pvhIQ88p0EgMnlJMrR3fyrACKPlJXuSrTJ01PXYZiUDzB9HZnfkNUKDeLN4f5L0vXctd/OhbRZGupPhqW0qZRkyw5toUYLtilVf4IJMbzsbYQV6v+YhHx2a7veG5ImhHJmz6eNlNV9kO87bUlFdmIb0cn9jQsD1O2R0WfjDyR6u2ak/TKkVC+mhrotU0soMqmrENfu2XcyJ2Ca/0AdmQWPqbQ2NzBiQFG8Qmpolhj3ifvIAZxLBEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SUhXI5hfUJRz8vEpwnsKqvXWD86IJzc1qF1Le5xsGbI=; b=T/bYlYz1ntyt3Kt/SjOChpgLOO72bW4g4ojsRzBpp4Ql57O2S2IbS5tJ1ybPcTiq36ZXcUXzDaxX4IvrrK2YDNpFZQI8Re3enFoTIwPfBRu1uDY8kC9MmAQj1twBLjchdNvE443WdCbYibz6yrDTpmp5agdCWIPfxiC4idO75NY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Jason Andryuk To: CC: Jason Andryuk , Doug Goldstein , Stefano Stabellini Subject: [PATCH 23/23] DO NOT COMMIT: automation: updated imagebuilder Date: Thu, 6 Mar 2025 17:03:43 -0500 Message-ID: <20250306220343.203047-24-jason.andryuk@amd.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250306220343.203047-1-jason.andryuk@amd.com> References: <20250306220343.203047-1-jason.andryuk@amd.com> MIME-Version: 1.0 Received-SPF: None (SATLEXMB03.amd.com: jason.andryuk@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B374:EE_|PH7PR12MB9126:EE_ X-MS-Office365-Filtering-Correlation-Id: 58325df1-fbbb-47f8-e5b3-08dd5cfad5f8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|82310400026|376014|1800799024|13003099007; X-Microsoft-Antispam-Message-Info: 0P6avvlLzlPZ2dnNAx4o/kKSXpf1r1CQZxOhUDTBpNza/C19r4q9TTD6t/K7+NGFgDqlasbusCXjRdnEo9mcDESTwZ6cJowuh9b2a3rw/z+evgkuCrNlwsWCcw2tT9oZhMYMaMu4XMhQNj9S5s0Tzc8afi9zINr2EEk3VA1ZDVYBDcROaKRvnBeb1RMd/Qo+OntiAwvqejDaCbShZ2XXYL/RzSmyQyGJ7RCvss/zNI9PdsV2IVUerCSCvOhNpN0hNF94E+NYS6U+f3C5Eb0L7NtKzl8FLdibSx1J5bcDm/17GIT+++DlEeFKEKjUyGi0OYIOilhbNqnt9Hdg3DtZwGXNsxU0i0/k9ObWZEVcNhzyTPoimE36IpfeKeqsbzLaIMIen1vFXboXVhFYbnaER/Vb7mA4lJHiIH2p0HX/Bbk/NU2880aza641d0lOti3Yecneh+lbFCCzJ6R1iYdB3CKJ5HnDRj584SwWE/8XnDBz3SD4YbmynMonQgtZdUNL7Iz5Ozss4yofcXegOKTUp0OC8dXEbqotL+bNa70/lXMSULkEkSLSpojhfTXmNy/nr89NfKBLf2py9Y/UwwVoeSYiROeFWoYgeLJZAPthJ3SIusnX7JFy5dgSzHpAyCxpxFk2gfoxY0fD8/9G5Z4smuckb3/v7QFWCtScIzMXJ2DLmds6Kxg0wtU/mSceJBmcZGkQEs1BbWlDaSUG0LqUiGKP/EUx4K+l2tspSm5zNsEEhjLE+64jZBl33/UCHdH0LxxAoWGQhws+4YyFsnbcQjMD7SWNTni57bAatwko/9lrwmYNjGSrb2JjYwwOkWzZqzonU6MhVa61Pwpl5UvOCd6zMh9TUP0fwegwgOo8QcAY1wL96fhLE79drli25G4kdqCUKM8VWfJW8y2rRKqVI6eSjnyK3YbGtS3WZ9fVUvbJ13h7FWV5/sVCxWCCXno82se+kIDCO+1ESXZWFhiJmK5lZc1ik/gSb7sBG5nLu8po33WxtBc7rOh7t/XcFza/wZccryVXMAnrl/mA7UP+agY+mVgACBYMfvyLCbL0MVHjOZwtkaw9y6nwWgTBxiNoARO7XPZDRZrSON+wNgLNdK3HB8AwAj4v3IAeTcNDBg1AndFHTELIuJefsRA8YqBJMzpDyKIm3yhwkPCdyka0ci6jE2+uYfRJkyYfDh+KyOLDTwH/c+JnCvIVElXaOwxAbgdf70XYeGOarr7gqgSomGp9BCGGbEfkzrNVFqx/A+RcAgMLhOOFvDSNUIYH0vwkGQmpkk5lOTk4Vy/LPHf23XGFdemDB8SpGbEBy27zO4l/FVBGjhpZPwhM9fMsK6LEcrnF9v+6Y0bAldqaATWtS80LPVHRpYnrzqjdSETbgtxkx6FmgvCl1Lzfp9xFUKhOepSz7Ign4GjZlr2L0nvEIm8S/ydNQbaFEMteiJdgGmOOqYDpRl7AdSvMKIThPT8EBWNwV2OB9cL1/fJ+cvWpMLgP/3CNrUDG9TnHe3joLjY= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(82310400026)(376014)(1800799024)(13003099007);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2025 22:04:15.7447 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 58325df1-fbbb-47f8-e5b3-08dd5cfad5f8 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B374.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB9126 Temp commit to update imagebuilder repo for domain capabilities. Signed-off-by: Jason Andryuk --- automation/scripts/qemu-smoke-dom0less-arm64.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/automation/scripts/qemu-smoke-dom0less-arm64.sh b/automation/scripts/qemu-smoke-dom0less-arm64.sh index 39614720a4..26493ecd88 100755 --- a/automation/scripts/qemu-smoke-dom0less-arm64.sh +++ b/automation/scripts/qemu-smoke-dom0less-arm64.sh @@ -250,7 +250,7 @@ NUM_CPUPOOLS=1' >> binaries/config fi rm -rf imagebuilder -git clone --depth 1 https://gitlab.com/xen-project/imagebuilder.git +git clone --depth 1 https://gitlab.com/jandryuk-amd/imagebuilder.git -b dom0less-caps bash imagebuilder/scripts/uboot-script-gen -t tftp -d binaries/ -c binaries/config