From patchwork Sat Mar 8 20:00:58 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Heidelberg via B4 Relay X-Patchwork-Id: 14007750 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B58AB206F2A; Sat, 8 Mar 2025 20:02:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741464150; cv=none; b=uWGVNblt8lLSmYSkqXrASt58hsKaCvCHe1lV6NZVfM8AB9KX1exszAS0F09iYEFTJNtYSGKwd0fof6wLifHKhPUGgnNb3LVOGz7tTkuIa9TOKQmOrBtSycq4K1jOOECAb0yz0iufPGEFy8tmOzVqiKbb24RHgpbr7CsbqRQ0Qrc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741464150; c=relaxed/simple; bh=Vxi1aNedGR1p/1yUmMOJhh1VooIf3jj/6Tq+WoUcTG0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rfSA8XGfRdr644WjqSr7uhj3YL6QWZXbbE/eqbj9f3oKEaH6gth18tuXVFwyT7u5hhKTImnIV8VsyBhhblc7n4EcMYWow4e735b0Z9gsI/E4XNapiQfEX2tAWv0qHJKIY41+igCwL8hgBfGvGDMoarDUWWg5Ndekk1vCvLJMLX4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BYGmCvHP; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BYGmCvHP" Received: by smtp.kernel.org (Postfix) with ESMTPS id 22532C4CEE7; Sat, 8 Mar 2025 20:02:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741464150; bh=Vxi1aNedGR1p/1yUmMOJhh1VooIf3jj/6Tq+WoUcTG0=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=BYGmCvHPtZQzIGiLA3+bEXVWg7WIndlfpyvSGysU/qVf/Rh8SVZ5uBo3ThhiKdeRd CpS3/VaUw5sEgkFQ5IljQl10EG6kR9D3QdiNyH5B+bkEgY1Hpxi1odp4Q1dY3gRNkm 32jCwgFqkozsF2KKeQp7NhB/xeiaMBpJl3DlK5dWJKb02lnhY81yu2j9YBxxum1o+e 5SfUdAGKhmcb7XNqgAzRu3lXCceSeO8NVohWyfxb8Z6wzCalQ8436urD18Z0qpf/MZ 745tkSGxzOvDsVSMVO+PXRamrH9EvmYqaJBcFmQY9uasQ+En5oORYO92xJJWe2ohdY vuxlq0hVo2MTg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00770C28B28; Sat, 8 Mar 2025 20:02:30 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Sat, 08 Mar 2025 21:00:58 +0100 Subject: [PATCH 1/4] iio: light: al3320a: Drop deprecated email for Daniel Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250308-al3010-iio-regmap-v1-1-b672535e8213@ixit.cz> References: <20250308-al3010-iio-regmap-v1-0-b672535e8213@ixit.cz> In-Reply-To: <20250308-al3010-iio-regmap-v1-0-b672535e8213@ixit.cz> To: Jonathan Cameron , Lars-Peter Clausen Cc: Svyatoslav Ryhel , Robert Eckelmann , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=718; i=david@ixit.cz; h=from:subject:message-id; bh=MXlQAzTdWxMSPXOYvO5LE/IyoymDgDTuIpV9wQjHRSE=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBnzKJUrpA+Vsl85k9Ww3JP+vnbuBDlJARo0UKqw 1vhlvIi0N2JAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCZ8yiVAAKCRBgAj/E00kg ctATEACy4Yq7TFEh4DDq8NTYkhFhK6h18KSZ0BvGfh5PmB+ooHFDyjK5j7ylSBs/Mlw8iyEwFIG JBV3ENRfcGYFM+LeoD7cSKUfNH67TKv+GPJljp0LD4YEj8iMPQ/fg21lZG9hqez6qdqGqQxwPej XK8ijqON8qhuSXkVDR2Bn5P7+70M+nztt6UkRtDrZSBN1NmhqT7aB2AVrVUF65qjS8HtJRcETgF VzEqEz/neDPTnBjfI99ZgVOV0bm5naIbWnWUzifMpVe21gG4Vhv3UmjIuwwi/nQJs5NMUT1L5Ee liPypRACoJxYYzP2aezFLRZs25Jq8r+LKbWcbTVOOMQ5VUAmtHfW7hFAX5CiZfLvgoN4vitPY/X 3++mTV1n9TePORRA6f/HCSAcDiqeQ4XeceRK2IIr3S7w10dKFiJ/bQFkPmyCupccvGbeXy2vhMF NIiUj2POZr5z1CtsEygeEY75tt2Gbl2RlJ4M0fKKmeXUHekF7wLBh33kv/zg0b3BkDZ16zsU6o4 NpPSLpgKwlgRFOq0uRV52IPD8bnGdzzl9V0ONgj+0nAdn6TUtiPuULAoc3AkyeoAh3CEdtvAEAn KHMiVBhSRKtc3pBsY4Ck9rAj/LID2pQ66yhAGEAQ7ok8xuMfZIeS2+hyfn7YP3oqohIziRGJI+u x+Pbx/diuiXI7YA== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg He no longer works at Intel. Signed-off-by: David Heidelberg --- drivers/iio/light/al3320a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/light/al3320a.c b/drivers/iio/light/al3320a.c index 497ea3fe337775b07efdfc56c80beb1aa55e394c..d34a91fdafa0affad4665d995e1f66d2aaa0373b 100644 --- a/drivers/iio/light/al3320a.c +++ b/drivers/iio/light/al3320a.c @@ -266,6 +266,6 @@ static struct i2c_driver al3320a_driver = { module_i2c_driver(al3320a_driver); -MODULE_AUTHOR("Daniel Baluta "); +MODULE_AUTHOR("Daniel Baluta"); MODULE_DESCRIPTION("AL3320A Ambient Light Sensor driver"); MODULE_LICENSE("GPL v2"); From patchwork Sat Mar 8 20:00:59 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Heidelberg via B4 Relay X-Patchwork-Id: 14007746 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4374206F0B; Sat, 8 Mar 2025 20:02:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741464150; cv=none; b=XZV9btYF3DoI1b9YoiBqB18E1t6d9WdbwtfqS8pRIgBLjn0CH1alb9Mg76oO0gGaxGfpGRLA3HG4PR2262RkfAEjDvLDN5/JQjnYgwnYictN0JmMwGpa3wa15txbdj0j8QPqQImfrVwr0OjvOYVDWjgr/YPp6WWVzC8JD4+JxXo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741464150; c=relaxed/simple; bh=e/M1KcFrTfIKFEzZH5CjLPVwQnJcCPmkrwdiZwKmFT8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=XfnusLDBzgR76Egms5TOiGPEh0EL9lasOUs984hcM0SyQE3OEjLIxtujDht1ABR02c6lnNgasaCAIx7ltnZnBOUxZw/MaAjWwLLcf/GOTee/49hPMfo07dsBj5J60UdcPXW6Sh/tJetL2TSSHHTHVhH7UJhuJMah5U/obyFnIPA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=uLm2++jd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="uLm2++jd" Received: by smtp.kernel.org (Postfix) with ESMTPS id 26BE9C4CEE3; Sat, 8 Mar 2025 20:02:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741464150; bh=e/M1KcFrTfIKFEzZH5CjLPVwQnJcCPmkrwdiZwKmFT8=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=uLm2++jd5oItQkirHptb84L+yr9rhtZnncQR6glJdq9l2ZN20TXt2GcSD5qn9qyzc CyudSdC8bd9LBIJ5vN5VCrF4U9udwLnARf0WOOYdq4s7+yCt3mzglXhcjqqI26HKP2 fWsmMAsVYNeyXS/JhIYpSDCLuXDgLflL1Qf37oFv7eGL9Pf7WvodOXBLpReUXnCUJ2 EFqxqOUvXZyaC3Bvnk7uyueEWiWmM5Fb44oQH+C3ieSwoCV8SKZkjC0VNWE2Vwi/j2 aL3iggLitx+XPRqo1GcUPjhwqFv3ic7W+a8RjTh9VZaFlD89sT3ZFNNcI+CngPPld/ fvoCteRiIp1gQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 120F6C28B30; Sat, 8 Mar 2025 20:02:30 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Sat, 08 Mar 2025 21:00:59 +0100 Subject: [PATCH 2/4] iio: light: al3000a: Use DRV_NAME Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250308-al3010-iio-regmap-v1-2-b672535e8213@ixit.cz> References: <20250308-al3010-iio-regmap-v1-0-b672535e8213@ixit.cz> In-Reply-To: <20250308-al3010-iio-regmap-v1-0-b672535e8213@ixit.cz> To: Jonathan Cameron , Lars-Peter Clausen Cc: Svyatoslav Ryhel , Robert Eckelmann , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1248; i=david@ixit.cz; h=from:subject:message-id; bh=OztXp4B+Ou/RwdPOQioIug1hZ1oOyPA0zbFHMaWwpTA=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBnzKJUrEM0E1z5B6zdsevZMBPtg5f0lVFPsD1Jo IU2gNgblVmJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCZ8yiVAAKCRBgAj/E00kg cmqDD/49ajNvfw4bP7MWvD/QQ0yRsdD47903cCoa5kt/iuVpdL+E4m9TsUnBoNqV9P877afkspN xWyDbnm0w04tenzbVNKduFOwU5gFOzFkXA62PVGjO7K1EbaPzbojVcmwTwz7eNXIa+dtkdivyMR 97ucGVvT9awYNRobTo5IL1Y8swyEXtcDtHOdxovY045POFdaCyYylii5OXl2g7658aWcJmV3ZMK mQ25VT9EhTxjfJMDtKjSrrEqUoXXBymQRo1rVl+wBH9m0rZqih/fdJHGttGjeimTnRFRFOz6gHY c/5ROacg0SHHmUip0N+oftd+Q5zvm1loaaKSe/kxeG64Q1S8NGGNzv6+zlcnXbVU7hrMuBY0q7G 7MidBjLn8BSTyGQ7sWOrvKmKlixhVbzpDXMZflX5bwbYKfozBk5T2H02CXaMlVki/p55bzLWUPA LW29MT8XkZLYm7hSaBN4SttCp5D7ZNA+XpYzz2st8a0RVLfWgguNo2PJAO4Tyvy+5B6nNffgYCu RSdJUvya5hNvEJrCSpVHvaBoX1K+rsn6G0ACFxSR9+Le1dEvqooi0x+sQPbSReabF2+NU4odnW4 lKrjG2ztrvVxj2JnbgUoU5xXUvsy15dKCMrtihIpZblG3hAUcBm8BFCez9HMhaqXCQYTAkkAPT0 swYCZDFrIFJlEww== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg Sync syntax with other similar drivers. Signed-off-by: David Heidelberg --- drivers/iio/light/al3000a.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/iio/light/al3000a.c b/drivers/iio/light/al3000a.c index e2fbb1270040f43d9f0a97838861818a8eaef813..e1fa4543f336cec61140b5c44d3794df1fa485cd 100644 --- a/drivers/iio/light/al3000a.c +++ b/drivers/iio/light/al3000a.c @@ -13,6 +13,8 @@ #include +#define AL3000A_DRV_NAME "al3000a" + #define AL3000A_REG_SYSTEM 0x00 #define AL3000A_REG_DATA 0x05 @@ -148,7 +150,7 @@ static int al3000a_probe(struct i2c_client *client) "failed to get vdd regulator\n"); indio_dev->info = &al3000a_info; - indio_dev->name = "al3000a"; + indio_dev->name = AL3000A_DRV_NAME; indio_dev->channels = al3000a_channels; indio_dev->num_channels = ARRAY_SIZE(al3000a_channels); indio_dev->modes = INDIO_DIRECT_MODE; @@ -195,7 +197,7 @@ MODULE_DEVICE_TABLE(of, al3000a_of_match); static struct i2c_driver al3000a_driver = { .driver = { - .name = "al3000a", + .name = AL3000A_DRV_NAME, .of_match_table = al3000a_of_match, .pm = pm_sleep_ptr(&al3000a_pm_ops), }, From patchwork Sat Mar 8 20:01:00 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: David Heidelberg via B4 Relay X-Patchwork-Id: 14007749 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6D6D207DEB; Sat, 8 Mar 2025 20:02:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741464150; cv=none; b=JdO+4AwOuwT5TtJc98/6p3eMxfjCCbeE4CBprlRXSHrykekEBvbBwQqKe5DuaOSxaXVrGRMlEPA44plh/XfdtWfpDAu4/zs8XBlk7D8jHsJyvXqe11gbhdzVvft/n1CeW928Y0DALktCJM303ZIU0ZTryDkmCgRZ2Q0Vcu8XNkI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741464150; c=relaxed/simple; bh=6otCFNXi8rJDPgtqrJjfodfpkQOsK64XOFGkE+Uqfgk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=BBQBEjmf7br1hfWBwaZlPEyiloC8SBC/h2gUPMe0kISlUFGTLoeNFwZGYeWIDG9amo0myapnF5RRtxwyNTdPymzYaIwJU4ZWNf5CRd4wo6HdUiqIDrVaxUiYyIfAVcRD96Gh9hE+Epkkr+8MlCEqtxBUHTb0BhpnypUMgCXa1mc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GjAD7tLa; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GjAD7tLa" Received: by smtp.kernel.org (Postfix) with ESMTPS id 3A1B2C4CEEA; Sat, 8 Mar 2025 20:02:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741464150; bh=6otCFNXi8rJDPgtqrJjfodfpkQOsK64XOFGkE+Uqfgk=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=GjAD7tLarSLJnPbzbVGDVjS7QQuGzGP4wqsHwsZAvoCmxj58g8voxsa0gE1OTOuko KKvkMad2SYC+Bq5PmuhTsHhdDl7Ahlcld1dh9UV17RZxdGYwbO7FQp2lYNS8+LbaGz 2JIdxiNxcZPzRFhvHge3zMHuiSfQdmbDvWVzcemH/NuHlYOalR6dIn2aI+QipIngFu BEsdODy7CM0TFQAAOnL8hOhZ94ErPqd5hb7JAAqwUrU4ClmM2D2aHr7EnRXnk0lMjk 0zVnykA0Agognaz84nwqtMb0cm2e8MXcxlIOtaEto5dPrCHTMOYkbn6n1J3PiUrDZ5 zP2D76UieNbdw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23781C28B2F; Sat, 8 Mar 2025 20:02:30 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Sat, 08 Mar 2025 21:01:00 +0100 Subject: [PATCH 3/4] iio: light: al3010: Implement regmap support Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250308-al3010-iio-regmap-v1-3-b672535e8213@ixit.cz> References: <20250308-al3010-iio-regmap-v1-0-b672535e8213@ixit.cz> In-Reply-To: <20250308-al3010-iio-regmap-v1-0-b672535e8213@ixit.cz> To: Jonathan Cameron , Lars-Peter Clausen Cc: Svyatoslav Ryhel , Robert Eckelmann , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=6586; i=david@ixit.cz; h=from:subject:message-id; bh=0ARMKIzxYYDa8ckpNzQObR3a0fTEgZFZCzYqD+3QDso=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBnzKJUhbmOjYMI5g7UGr6V86HcY6q1ucYtsjPA5 eOjXNP1UfaJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCZ8yiVAAKCRBgAj/E00kg ciOcD/9Bgc6DYRtx+1luJ/BNm1QccnBXxKhTRPXthTkXXzodaEbrB1poTZ55hF4E653AeL0Gssp aO3nY2MShcnYd/KKTJj/wwYP9HThsB1ove7koTCeR47kQhzPHDyIUQi13iaPCqrG0coKA9XYklH vpT0J4AFeoIiEgYHkvygK/FTsBCQjUERCdQ7YNAktoNxPdH1qZXKQxwvQ4ARYdv1M+uyZ7xA1st VgyjL5d26ivJkqhIj2nZ0+r/zqKGY9IR5xQ6WNSrdCgndWYQlmjMVFK5vgF7Je0OGfU8Qg51EG4 WOEKCYwsJUWr1c8UQt8jBi6iK0lbse2bvYsnOR0AEhlgTZf9zsQ0WeUmgDDeKJDRN3Sy8bS1Ef/ LvDcLgn+7oqs5RvvbtSEnmouPRXpvKjLHcOBda45+hJs7t9VfKpPi0R9ftVBp6qTr/EmZIYU9tJ U5i/YGFzIpaQG95IiQOCrqE1ZwyNOhUJHU4Db7mJF0c2ZqZGABpECszHoPPeHDdDBywArJOAtui buidRpVxJ5Mb2g6m8ceZgIzESIHK3Pgzcbm1x4bzLyP8pNpFHNFTOH7mwXTGMBP2vqAaQL/0XB0 VFbwGesLpG5N4ZryAipw1DmgW6B7HSS9AhE2dMmEPfymByhdutbXlnjBA+jZENdyMb/baoZohfs Nk5tHI9K2KMmv7Q== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg Modernize and make driver a bit cleaner. Incorporate most of the feedback given on new AL3000A. Signed-off-by: David Heidelberg --- drivers/iio/light/al3010.c | 95 ++++++++++++++++++++++++++-------------------- 1 file changed, 53 insertions(+), 42 deletions(-) diff --git a/drivers/iio/light/al3010.c b/drivers/iio/light/al3010.c index 7cbb8b203300907a88f4a0ab87da89cabdd087f3..f6ed7246864a777fdb7d3861b74f5834e8af4105 100644 --- a/drivers/iio/light/al3010.c +++ b/drivers/iio/light/al3010.c @@ -4,7 +4,7 @@ * * Copyright (c) 2014, Intel Corporation. * Copyright (c) 2016, Dyna-Image Corp. - * Copyright (c) 2020, David Heidelberg, Michał Mirosław, Dmitry Osipenko + * Copyright (c) 2020 - 2025, David Heidelberg, Michał Mirosław, Dmitry Osipenko * * IIO driver for AL3010 (7-bit I2C slave address 0x1C). * @@ -17,6 +17,7 @@ #include #include #include +#include #include #include @@ -46,8 +47,14 @@ static const int al3010_scales[][2] = { {0, 1187200}, {0, 296800}, {0, 74200}, {0, 18600} }; +static const struct regmap_config al3010_regmap_config = { + .reg_bits = 8, + .val_bits = 8, + .max_register = AL3010_REG_CONFIG, +}; + struct al3010_data { - struct i2c_client *client; + struct regmap *regmap; }; static const struct iio_chan_spec al3010_channels[] = { @@ -69,40 +76,32 @@ static const struct attribute_group al3010_attribute_group = { .attrs = al3010_attributes, }; -static int al3010_set_pwr(struct i2c_client *client, bool pwr) +static int al3010_set_pwr_on(struct al3010_data *data) { - u8 val = pwr ? AL3010_CONFIG_ENABLE : AL3010_CONFIG_DISABLE; - return i2c_smbus_write_byte_data(client, AL3010_REG_SYSTEM, val); + return regmap_write(data->regmap, AL3010_REG_SYSTEM, AL3010_CONFIG_ENABLE); } static void al3010_set_pwr_off(void *_data) { struct al3010_data *data = _data; + struct device *dev = regmap_get_device(data->regmap); + int ret; - al3010_set_pwr(data->client, false); + ret = regmap_write(data->regmap, AL3010_REG_SYSTEM, AL3010_CONFIG_DISABLE); + if (ret) + dev_err(dev, "failed to write system register\n"); } static int al3010_init(struct al3010_data *data) { int ret; - ret = al3010_set_pwr(data->client, true); - if (ret < 0) - return ret; - - ret = devm_add_action_or_reset(&data->client->dev, - al3010_set_pwr_off, - data); - if (ret < 0) - return ret; - - ret = i2c_smbus_write_byte_data(data->client, AL3010_REG_CONFIG, - FIELD_PREP(AL3010_GAIN_MASK, - AL3XXX_RANGE_3)); - if (ret < 0) + ret = al3010_set_pwr_on(data); + if (ret) return ret; - return 0; + return regmap_write(data->regmap, AL3010_REG_CONFIG, + FIELD_PREP(AL3010_GAIN_MASK, AL3XXX_RANGE_3)); } static int al3010_read_raw(struct iio_dev *indio_dev, @@ -110,7 +109,7 @@ static int al3010_read_raw(struct iio_dev *indio_dev, int *val2, long mask) { struct al3010_data *data = iio_priv(indio_dev); - int ret; + int ret, value; switch (mask) { case IIO_CHAN_INFO_RAW: @@ -119,21 +118,21 @@ static int al3010_read_raw(struct iio_dev *indio_dev, * - low byte of output is stored at AL3010_REG_DATA_LOW * - high byte of output is stored at AL3010_REG_DATA_LOW + 1 */ - ret = i2c_smbus_read_word_data(data->client, - AL3010_REG_DATA_LOW); - if (ret < 0) + ret = regmap_read(data->regmap, AL3010_REG_DATA_LOW, &value); + if (ret) return ret; - *val = ret; + + *val = value; + return IIO_VAL_INT; case IIO_CHAN_INFO_SCALE: - ret = i2c_smbus_read_byte_data(data->client, - AL3010_REG_CONFIG); - if (ret < 0) + ret = regmap_read(data->regmap, AL3010_REG_CONFIG, &value); + if (ret) return ret; - ret = FIELD_GET(AL3010_GAIN_MASK, ret); - *val = al3010_scales[ret][0]; - *val2 = al3010_scales[ret][1]; + value = FIELD_GET(AL3010_GAIN_MASK, value); + *val = al3010_scales[value][0]; + *val2 = al3010_scales[value][1]; return IIO_VAL_INT_PLUS_MICRO; } @@ -145,7 +144,7 @@ static int al3010_write_raw(struct iio_dev *indio_dev, int val2, long mask) { struct al3010_data *data = iio_priv(indio_dev); - int i; + unsigned int i; switch (mask) { case IIO_CHAN_INFO_SCALE: @@ -154,9 +153,8 @@ static int al3010_write_raw(struct iio_dev *indio_dev, val2 != al3010_scales[i][1]) continue; - return i2c_smbus_write_byte_data(data->client, - AL3010_REG_CONFIG, - FIELD_PREP(AL3010_GAIN_MASK, i)); + return regmap_write(data->regmap, AL3010_REG_CONFIG, + FIELD_PREP(AL3010_GAIN_MASK, i)); } break; } @@ -172,16 +170,20 @@ static const struct iio_info al3010_info = { static int al3010_probe(struct i2c_client *client) { struct al3010_data *data; + struct device *dev = &client->dev; struct iio_dev *indio_dev; int ret; - indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*data)); + indio_dev = devm_iio_device_alloc(dev, sizeof(*data)); if (!indio_dev) return -ENOMEM; data = iio_priv(indio_dev); i2c_set_clientdata(client, indio_dev); - data->client = client; + data->regmap = devm_regmap_init_i2c(client, &al3010_regmap_config); + if (IS_ERR(data->regmap)) + return dev_err_probe(dev, PTR_ERR(data->regmap), + "cannot allocate regmap\n"); indio_dev->info = &al3010_info; indio_dev->name = AL3010_DRV_NAME; @@ -191,21 +193,30 @@ static int al3010_probe(struct i2c_client *client) ret = al3010_init(data); if (ret < 0) { - dev_err(&client->dev, "al3010 chip init failed\n"); + dev_err(dev, "failed to init ALS\n"); return ret; } - return devm_iio_device_register(&client->dev, indio_dev); + ret = devm_add_action_or_reset(dev, al3010_set_pwr_off, data); + if (ret < 0) + return ret; + + return devm_iio_device_register(dev, indio_dev); } static int al3010_suspend(struct device *dev) { - return al3010_set_pwr(to_i2c_client(dev), false); + struct al3010_data *data = iio_priv(dev_get_drvdata(dev)); + + al3010_set_pwr_off(data); + return 0; } static int al3010_resume(struct device *dev) { - return al3010_set_pwr(to_i2c_client(dev), true); + struct al3010_data *data = iio_priv(dev_get_drvdata(dev)); + + return al3010_set_pwr_on(data); } static DEFINE_SIMPLE_DEV_PM_OPS(al3010_pm_ops, al3010_suspend, al3010_resume); From patchwork Sat Mar 8 20:01:01 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Heidelberg via B4 Relay X-Patchwork-Id: 14007748 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B82BD2080FD; Sat, 8 Mar 2025 20:02:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741464150; cv=none; b=su5To1QS5/gwJ2KaHQZebhL7hBK3iy9bKUqN37q5qNFAdF8v/pDrf0309jT3HBFc/HZmpaVbs4eOb6K3fV0J4Js+VBnEkjSdD8HbaZkOYga48bnMogeePipW0jQ/D29sMNSc7xFiV1mqCrMQ/uiYO8EfW8BIJhl33nPsYn2rs/A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741464150; c=relaxed/simple; bh=FbwfoFA9TUfwf9Q1WJyzp7VxofeoHXHrNGqGmADWW5g=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fnEsmW1E2ZDisU1ankORNTK9G/Zu2CYmQ8W/W6A78tmDYBTU4TpqvJUe5ahiiBiGL/2hLQyFTa1d3JurUuGNeuBKOczys1DGfiJALVeDhunDDciPtMt7YLdbOJLc1+5OmRLwHGCbwKU1+DUNwHgqTm/OJC3A6u6HcMd7ATRWBOM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dq2prbBS; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dq2prbBS" Received: by smtp.kernel.org (Postfix) with ESMTPS id 480DEC4CEED; Sat, 8 Mar 2025 20:02:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741464150; bh=FbwfoFA9TUfwf9Q1WJyzp7VxofeoHXHrNGqGmADWW5g=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=dq2prbBSx6MnMHCQZdrPD3ML6cGNQbalkeDqncDsB23q3/YMhjeP4qK/FP4WRlV2R ELB4QZXMYBhKvO8NN47A+9/T2eDKwhD0y5XoVoPRcuGwlzY0WSW9C0VikU/egE3riY PzEa3yuEQOYXUsFSPaBLa0SZEQcaDRyVYBhSJfH6UVglm5IKNSKUDN3TsJNLX3y4pm mvfQNxAmTVYNwajd6Q4Gs6ABC1bkz9kxVv+Q51jHVHAzuCO2H/+oEHK9kFuIiAJNF6 cdB4iEe/Ok8o35n1Sxt1J0QqkvPlM7zOciRJkoyqh72UX1X5fRKPMw1IVlrT1W3WF/ 3X0XaNwD4uFCQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A832C28B31; Sat, 8 Mar 2025 20:02:30 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Sat, 08 Mar 2025 21:01:01 +0100 Subject: [PATCH 4/4] iio: light: al3320a: Implement regmap support Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250308-al3010-iio-regmap-v1-4-b672535e8213@ixit.cz> References: <20250308-al3010-iio-regmap-v1-0-b672535e8213@ixit.cz> In-Reply-To: <20250308-al3010-iio-regmap-v1-0-b672535e8213@ixit.cz> To: Jonathan Cameron , Lars-Peter Clausen Cc: Svyatoslav Ryhel , Robert Eckelmann , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=6797; i=david@ixit.cz; h=from:subject:message-id; bh=5I6aLiVBvHlW9GqP9cewvJ+GzQ5KKG9d4c1w8WEv3k4=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBnzKJUKSj+aSO7mnAWNa2/OCRt+uzxahs6/j9FY vOe9ckR53mJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCZ8yiVAAKCRBgAj/E00kg cu6ZEACNLmmqM1HzvFOBITah4KysNN7aImTh9WaoMLNrxeIbt/FD8lUmWA1dhB1qJC+rFCMojmB J/yJ+EbFtG6WrbkvAmWqheN5Yfyx16gbp4y1g7poVc46Gnimdnh/6pya8SolmXJM6csw3ZaxqAg 6VaICjlDub6b/O7qXxy5qLrEDfYmaBdj2oD2AGAwYBUNm4H31cOEAAZ0J7LmKLvY5d42rmOZf5y S4mKqT809e92ZzadxfpuSut6u7ubsylvuq/d5tYv75gu/B76eW6xCCvGLWN77lbryRO9ZJMJAPu t2enaOq7fgAZ0WjE/inMxVoIxBFLisk4alEBFGV80kyRZzX4IkNfdJuF+7bX2oNYUg2llw5L8NA ehuPu7SeO2u51WnbBf1WeQlVg3ckEjaSJT87DJ6zuvjw9l1AUKaaqzufrT5wtN5xe113mDGHA9J ZVkfB2oC75mGLtM/PtoboetdWrme7n8u/Ibg1hQ7Tc4g0BrcjZOcXsvKgrpVxWAeuPlbB+hcFVW zDn4drWY7enPaYxuhLp+SuJQPEOW6fsPwng+tM11GW/9keO5qudO8J8W/fMu0Y0GS5xzQHO3qDt y9UCwbhf6MRw/aWgAofh+UkIZxzhCCn1yLY28/9WyIj6ph+CuMAea0J/wF6kmMPK/FR+QMlzTfL 7bEj9bGkM24oeuA== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg Modernize and make driver a bit cleaner. Incorporate most of the feedback given on new AL3000A. Signed-off-by: David Heidelberg --- drivers/iio/light/al3320a.c | 101 ++++++++++++++++++++++++-------------------- 1 file changed, 56 insertions(+), 45 deletions(-) diff --git a/drivers/iio/light/al3320a.c b/drivers/iio/light/al3320a.c index d34a91fdafa0affad4665d995e1f66d2aaa0373b..208b4f212f3543557e99342630c92f5e6bdaf05d 100644 --- a/drivers/iio/light/al3320a.c +++ b/drivers/iio/light/al3320a.c @@ -15,6 +15,7 @@ #include #include #include +#include #include #include @@ -59,8 +60,14 @@ static const int al3320a_scales[][2] = { {0, 512000}, {0, 128000}, {0, 32000}, {0, 10000} }; +static const struct regmap_config al3320a_regmap_config = { + .reg_bits = 8, + .val_bits = 8, + .max_register = AL3320A_REG_HIGH_THRESH_HIGH, +}; + struct al3320a_data { - struct i2c_client *client; + struct regmap *regmap; }; static const struct iio_chan_spec al3320a_channels[] = { @@ -82,45 +89,42 @@ static const struct attribute_group al3320a_attribute_group = { .attrs = al3320a_attributes, }; -static int al3320a_set_pwr(struct i2c_client *client, bool pwr) +static int al3320a_set_pwr_on(struct al3320a_data *data) { - u8 val = pwr ? AL3320A_CONFIG_ENABLE : AL3320A_CONFIG_DISABLE; - return i2c_smbus_write_byte_data(client, AL3320A_REG_CONFIG, val); + return regmap_write(data->regmap, AL3320A_REG_CONFIG, AL3320A_CONFIG_ENABLE); } static void al3320a_set_pwr_off(void *_data) { struct al3320a_data *data = _data; + struct device *dev = regmap_get_device(data->regmap); + int ret; - al3320a_set_pwr(data->client, false); + ret = regmap_write(data->regmap, AL3320A_REG_CONFIG, AL3320A_CONFIG_DISABLE); + if (ret) + dev_err(dev, "failed to write system register\n"); } static int al3320a_init(struct al3320a_data *data) { int ret; - ret = al3320a_set_pwr(data->client, true); - - if (ret < 0) + ret = al3320a_set_pwr_on(data); + if (ret) return ret; - ret = i2c_smbus_write_byte_data(data->client, AL3320A_REG_CONFIG_RANGE, - FIELD_PREP(AL3320A_GAIN_MASK, - AL3320A_RANGE_3)); - if (ret < 0) - return ret; - - ret = i2c_smbus_write_byte_data(data->client, AL3320A_REG_MEAN_TIME, - AL3320A_DEFAULT_MEAN_TIME); - if (ret < 0) + ret = regmap_write(data->regmap, AL3320A_REG_CONFIG_RANGE, + FIELD_PREP(AL3320A_GAIN_MASK, AL3320A_RANGE_3)); + if (ret) return ret; - ret = i2c_smbus_write_byte_data(data->client, AL3320A_REG_WAIT, - AL3320A_DEFAULT_WAIT_TIME); - if (ret < 0) + ret = regmap_write(data->regmap, AL3320A_REG_MEAN_TIME, + AL3320A_DEFAULT_MEAN_TIME); + if (ret) return ret; - return 0; + return regmap_write(data->regmap, AL3320A_REG_WAIT, + AL3320A_DEFAULT_WAIT_TIME); } static int al3320a_read_raw(struct iio_dev *indio_dev, @@ -128,7 +132,7 @@ static int al3320a_read_raw(struct iio_dev *indio_dev, int *val2, long mask) { struct al3320a_data *data = iio_priv(indio_dev); - int ret; + int ret, value; switch (mask) { case IIO_CHAN_INFO_RAW: @@ -137,21 +141,21 @@ static int al3320a_read_raw(struct iio_dev *indio_dev, * - low byte of output is stored at AL3320A_REG_DATA_LOW * - high byte of output is stored at AL3320A_REG_DATA_LOW + 1 */ - ret = i2c_smbus_read_word_data(data->client, - AL3320A_REG_DATA_LOW); - if (ret < 0) + ret = regmap_read(data->regmap, AL3320A_REG_DATA_LOW, &value); + if (ret) return ret; - *val = ret; + + *val = value; + return IIO_VAL_INT; case IIO_CHAN_INFO_SCALE: - ret = i2c_smbus_read_byte_data(data->client, - AL3320A_REG_CONFIG_RANGE); - if (ret < 0) + ret = regmap_read(data->regmap, AL3320A_REG_CONFIG_RANGE, &value); + if (ret) return ret; - ret = FIELD_GET(AL3320A_GAIN_MASK, ret); - *val = al3320a_scales[ret][0]; - *val2 = al3320a_scales[ret][1]; + value = FIELD_GET(AL3320A_GAIN_MASK, value); + *val = al3320a_scales[value][0]; + *val2 = al3320a_scales[value][1]; return IIO_VAL_INT_PLUS_MICRO; } @@ -163,7 +167,7 @@ static int al3320a_write_raw(struct iio_dev *indio_dev, int val2, long mask) { struct al3320a_data *data = iio_priv(indio_dev); - int i; + unsigned int i; switch (mask) { case IIO_CHAN_INFO_SCALE: @@ -172,9 +176,8 @@ static int al3320a_write_raw(struct iio_dev *indio_dev, val2 != al3320a_scales[i][1]) continue; - return i2c_smbus_write_byte_data(data->client, - AL3320A_REG_CONFIG_RANGE, - FIELD_PREP(AL3320A_GAIN_MASK, i)); + return regmap_write(data->regmap, AL3320A_REG_CONFIG_RANGE, + FIELD_PREP(AL3320A_GAIN_MASK, i)); } break; } @@ -190,16 +193,21 @@ static const struct iio_info al3320a_info = { static int al3320a_probe(struct i2c_client *client) { struct al3320a_data *data; + struct device *dev = &client->dev; struct iio_dev *indio_dev; int ret; - indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*data)); + indio_dev = devm_iio_device_alloc(dev, sizeof(*data)); if (!indio_dev) return -ENOMEM; data = iio_priv(indio_dev); i2c_set_clientdata(client, indio_dev); - data->client = client; + + data->regmap = devm_regmap_init_i2c(client, &al3320a_regmap_config); + if (IS_ERR(data->regmap)) + return dev_err_probe(dev, PTR_ERR(data->regmap), + "cannot allocate regmap\n"); indio_dev->info = &al3320a_info; indio_dev->name = AL3320A_DRV_NAME; @@ -209,27 +217,30 @@ static int al3320a_probe(struct i2c_client *client) ret = al3320a_init(data); if (ret < 0) { - dev_err(&client->dev, "al3320a chip init failed\n"); + dev_err(dev, "failed to init ALS\n"); return ret; } - ret = devm_add_action_or_reset(&client->dev, - al3320a_set_pwr_off, - data); + ret = devm_add_action_or_reset(dev, al3320a_set_pwr_off, data); if (ret < 0) return ret; - return devm_iio_device_register(&client->dev, indio_dev); + return devm_iio_device_register(dev, indio_dev); } static int al3320a_suspend(struct device *dev) { - return al3320a_set_pwr(to_i2c_client(dev), false); + struct al3320a_data *data = iio_priv(dev_get_drvdata(dev)); + + al3320a_set_pwr_off(data); + return 0; } static int al3320a_resume(struct device *dev) { - return al3320a_set_pwr(to_i2c_client(dev), true); + struct al3320a_data *data = iio_priv(dev_get_drvdata(dev)); + + return al3320a_set_pwr_on(data); } static DEFINE_SIMPLE_DEV_PM_OPS(al3320a_pm_ops, al3320a_suspend,