From patchwork Mon Mar 10 02:56:55 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xuewen Yan X-Patchwork-Id: 14009186 Received: from SHSQR01.spreadtrum.com (unknown [222.66.158.135]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F19CA134B0 for ; Mon, 10 Mar 2025 03:26:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=222.66.158.135 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741577221; cv=none; b=MhsnW49vDiZzB/Vjcjaavtbh3g2GvQRfjjKR4AVS/HvYOqdTEJrgsiQNK7sNkMbnT6vb6/VIgaBrUUmNO/U9/ZG73dJ9GcRkbuaTJVo/oamhCewbOAQVP/VnDJk6KwOYhCDB/TcUuYIS+vtqjkPFcgGYyV6bA6Ehowdho2K/4QA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741577221; c=relaxed/simple; bh=GSNZxhA8Oh6wTTIEAqfSBZW5X5jGalcRCqrjPIanACw=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Vyi8tzx69ME9kOKGlW8geTu+h71u32bIb5YrqkTZHTI1tS4wnFlwg1FDj+gq0P3SCg4u/lwFL41vFLqEUPC3fLquOXZB6l9gwmsxtyw7nlJR+eNd3feY+nm7a+EbrMm04NNy26GFM7dnQ3zD9sjwZYcC2KtXe+si/NYgM2xr5IU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=unisoc.com; spf=pass smtp.mailfrom=unisoc.com; arc=none smtp.client-ip=222.66.158.135 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=unisoc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=unisoc.com Received: from SHSQR01.spreadtrum.com (localhost [127.0.0.2] (may be forged)) by SHSQR01.spreadtrum.com with ESMTP id 52A2vSnd015321 for ; Mon, 10 Mar 2025 10:57:28 +0800 (+08) (envelope-from Xuewen.Yan@unisoc.com) Received: from dlp.unisoc.com ([10.29.3.86]) by SHSQR01.spreadtrum.com with ESMTP id 52A2v5Oe012412; Mon, 10 Mar 2025 10:57:05 +0800 (+08) (envelope-from Xuewen.Yan@unisoc.com) Received: from SHDLP.spreadtrum.com (bjmbx01.spreadtrum.com [10.0.64.7]) by dlp.unisoc.com (SkyGuard) with ESMTPS id 4ZB1dK6rR1z2KFyXP; Mon, 10 Mar 2025 10:52:05 +0800 (CST) Received: from BJ10918NBW01.spreadtrum.com (10.0.73.73) by BJMBX01.spreadtrum.com (10.0.64.7) with Microsoft SMTP Server (TLS) id 15.0.1497.23; Mon, 10 Mar 2025 10:57:02 +0800 From: Xuewen Yan To: , , CC: , , , , , , , , , , Subject: [RFC PATCH] drivers/powercap: fix build error when CONFIG_SMP is not set Date: Mon, 10 Mar 2025 10:56:55 +0800 Message-ID: <20250310025655.576-1-xuewen.yan@unisoc.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <202503070326.9hEUez42-lkp@intel.com> References: <202503070326.9hEUez42-lkp@intel.com> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SHCAS03.spreadtrum.com (10.0.1.207) To BJMBX01.spreadtrum.com (10.0.64.7) X-MAIL: SHSQR01.spreadtrum.com 52A2v5Oe012412 When CONFIG_ENERGY_MODEL=y and CONFIG_SMP=n, there is build error: >> drivers/powercap/dtpm_cpu.c:83:15: error: call to undeclared function 'sched_cpu_util'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 83 | sum_util += sched_cpu_util(cpu); | ^ 1 error generated. This is because the sched_cpu_util depends on CONFIG_SMP, so using the #ifdef to guarantee the dependence. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202503070326.9hEUez42-lkp@intel.com/ Signed-off-by: Xuewen Yan --- drivers/powercap/dtpm_cpu.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/powercap/dtpm_cpu.c b/drivers/powercap/dtpm_cpu.c index 6b6f51b21550..b935e8c38b45 100644 --- a/drivers/powercap/dtpm_cpu.c +++ b/drivers/powercap/dtpm_cpu.c @@ -68,6 +68,7 @@ static u64 set_pd_power_limit(struct dtpm *dtpm, u64 power_limit) return power_limit; } +#ifdef CONFIG_SMP static u64 scale_pd_power_uw(struct cpumask *pd_mask, u64 power) { unsigned long max, sum_util = 0; @@ -84,6 +85,12 @@ static u64 scale_pd_power_uw(struct cpumask *pd_mask, u64 power) return (power * ((sum_util << 10) / max)) >> 10; } +#else /* !CONFIG_SMP */ +static inline u64 scale_pd_power_uw(struct cpumask *pd_mask, u64 power) +{ + return power; +} +#endif static u64 get_pd_power_uw(struct dtpm *dtpm) {