From patchwork Mon Mar 10 12:56:11 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matti Vaittinen X-Patchwork-Id: 14010052 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E82A0C282DE for ; Mon, 10 Mar 2025 13:55:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pvlmIYXxPFwsgRKDsD0xfbB0Kf2m77owf2uPI4W2MCQ=; b=QPrUXeflsHtE+jbokn6h7o1E32 s9WFVwzAbbPal2/2/slitcwQsJ2JS2G8uqWki4dFU7n2Wwjoml2x9wOhFc6ybM8hoHNQE0CCCfcBw 0jVTZ78wNY/sFbIUTA81adge0CBoNS2ZgiVuBP7zvzNmT4fZeSVVr5YbSXk68Lu1LwOx4Y+/mjyLK QTU0P4oLtaT2YmwBlD3Fi+INevBepDBhGuYQSb7ciSLVYiZDrhXNSPNXYAB0hpFIfNGhWuyJN3iv7 IwNlblz2xPdhQWlCJFmfAxXrXgf0NJ1NBb2+7gR/fM8tqKXWdms4oPgSXjkFMdBzImWWI14r9BPHg /cI7nMNQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1trdbZ-00000002rOx-2AIO; Mon, 10 Mar 2025 13:55:41 +0000 Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1trcg7-00000002hap-0dMh for linux-arm-kernel@lists.infradead.org; Mon, 10 Mar 2025 12:56:20 +0000 Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-54943bb8006so4697532e87.0 for ; Mon, 10 Mar 2025 05:56:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741611377; x=1742216177; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=pvlmIYXxPFwsgRKDsD0xfbB0Kf2m77owf2uPI4W2MCQ=; b=jXn84ykBSJGgO1qDGDfZMS6J40l3Fy+TSEKYcTvdi6U/GepNDReugaeBNSxwxTCchZ kU2LEvhIPydTeZKFOZ+Vf+ME14i8gIjgRKF90OAs3QLFxRUK17874fDnUy5fTNlRMPXn 30ouxfmUNWi9Wl0GWstxvOB0NLQA7aQFrzey4PoaZFknQsqIh5B0hmP4zIP3DAXd2Mr9 IjlPCUyq4z879ixyuOHUvYdRr7U16icf/qmRIZqMxFhr0wm+jViiEF3B70p5zLP6wsWR oY7ZuWwAcwLE5H8IS1TWiXvNOZOgTLm/6mcMyv7gzcjAF4oWMXzrQz2jQxn7C5sLq1rT RicQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741611377; x=1742216177; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pvlmIYXxPFwsgRKDsD0xfbB0Kf2m77owf2uPI4W2MCQ=; b=vVJbOrm2KxEB1Vqd6o5TgXdnYsOwwdjumdx68IC+1+lXlP2SnHe0bx5NhMZuUx5ayM rZh5e1DuEGlujZfSTl70DrOPm5Xi7Txdt1illJUjN8Q4UZFqn0JKi05hd8WFi5YA8468 ejAie4/UIEbrZySx2vfqbeii4AoLqYrXzMFoiO8vv+cUg6/p/lCjE6pVV4yOqrieTWmq kz2dmYvwPG1YiNVbGhJ6vUdL4q2Q228vjvdbnHM4JQJNgXwizVMjfVm/dFxZseOvyECr fkrLr5lDmG71yBOoB0ssswvIvq1PUxgOSv8sCZkpXiw1w2HDYf3t42RC4Vq5+1XyGLiM /5Sg== X-Forwarded-Encrypted: i=1; AJvYcCX78jT+KMARZ9dlSzr+Sk+jmsO2Kyz0o89Qf9uJ8gMh8VWrUG34h5NT5BHsfOzruhTmJp0Aye8CgwwkH+KyAYLR@lists.infradead.org X-Gm-Message-State: AOJu0YyMhfxXTDPFXKC8Tl08P3TeUq4/UKuTPLCrNv9ZgzrU1JVkzPqI sylrKtvXOz/IfJjG5gMl6OuirN5GgbcFUsIgbYzfs8WSX8B8d1cF X-Gm-Gg: ASbGncuPfjFmWhCk8L60RUMsgS2tXHFuPTkkamo4F8nTYA/S62GTWjly7l/XCDueg/q La49zIL22n7jrN74ur775PcLuueH7kLtaJib5KEMSrn5+ertOOYazEpzH0mvkM8WbTgRVs2nCPr dDWLtoPOSVfKa4KVTjFfXLTpiuQTk79t9tdXpUy3WC9cJ22kEYJwwbdZS/SUWN71PddMHL1hlta mhsSuTKW3s5FjBKQOm+OiAF12Va0EpVe8mMMfNaCRXOly5+Ct34/LwlYqrfSOlY/wbduCAjoELc ZvcFTXzL3tjjQhCIMr/Y+5zdGi/gPCwLIil0wIcKvos5K7N2y7M= X-Google-Smtp-Source: AGHT+IGu/NN+//EpU7CYFukNrNlPLiWHT6UQmiVwqBJ4NNs9fZZiJnlH6BOdww1vKwf1TPdeJLv8dQ== X-Received: by 2002:a05:6512:2342:b0:549:4de9:22df with SMTP id 2adb3069b0e04-54990da2057mr4566087e87.0.1741611376948; Mon, 10 Mar 2025 05:56:16 -0700 (PDT) Received: from mva-rohm ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5498b0bd0a0sm1446345e87.156.2025.03.10.05.56.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Mar 2025 05:56:15 -0700 (PDT) Date: Mon, 10 Mar 2025 14:56:11 +0200 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen Cc: Jonathan Cameron , Lars-Peter Clausen , Andy Shevchenko , Matti Vaittinen , Lad Prabhakar , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Hugo Villeneuve , Nuno Sa , David Lechner , Javier Carrasco , Guillaume Stols , Dumitru Ceclan , Trevor Gamblin , Matteo Martelli , Alisa-Dariana Roman , Ramona Alexandra Nechita , AngeloGioacchino Del Regno , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: [PATCH v6 03/10] iio: adc: add helpers for parsing ADC nodes Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250310_055619_204985_CFB0D5F1 X-CRM114-Status: GOOD ( 29.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org There are ADC ICs which may have some of the AIN pins usable for other functions. These ICs may have some of the AIN pins wired so that they should not be used for ADC. (Preferred?) way for marking pins which can be used as ADC inputs is to add corresponding channels@N nodes in the device tree as described in the ADC binding yaml. Add couple of helper functions which can be used to retrieve the channel information from the device node. Signed-off-by: Matti Vaittinen --- Revision history: v5 => v6: - Adapt to changed fwnode helper names - Fix spelling v4 => v5: - Inline iio_adc_device_num_channels() - Fix Indenting function parameters - Combine the max channel ID checks. v3 => v4: - Drop diff-channel support - Drop iio_adc_device_channels_by_property() - Add IIO_DEVICE namespace - Move industrialio-adc.o to top of the Makefile - Some styling as suggested by Andy - Re-consider included headers v2 => v3: Mostly based on review comments by Jonathan - Support differential and single-ended channels - Rename iio_adc_device_get_channels() as iio_adc_device_channels_by_property() - Improve spelling - Drop support for cases where DT comes from parent device's node - Decrease loop indent by reverting node name check conditions - Don't set 'chan->indexed' by number of channels to keep the interface consistent no matter how many channels are connected. - Fix ID range check and related comment RFC v1 => v2: - New patch --- drivers/iio/adc/Kconfig | 3 ++ drivers/iio/adc/Makefile | 2 + drivers/iio/adc/industrialio-adc.c | 79 ++++++++++++++++++++++++++++++ include/linux/iio/adc-helpers.h | 27 ++++++++++ 4 files changed, 111 insertions(+) create mode 100644 drivers/iio/adc/industrialio-adc.c create mode 100644 include/linux/iio/adc-helpers.h diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig index 849c90203071..37b70a65da6f 100644 --- a/drivers/iio/adc/Kconfig +++ b/drivers/iio/adc/Kconfig @@ -6,6 +6,9 @@ menu "Analog to digital converters" +config IIO_ADC_HELPER + tristate + config AB8500_GPADC bool "ST-Ericsson AB8500 GPADC driver" depends on AB8500_CORE && REGULATOR_AB8500 diff --git a/drivers/iio/adc/Makefile b/drivers/iio/adc/Makefile index ee19afba62b7..1c410f483029 100644 --- a/drivers/iio/adc/Makefile +++ b/drivers/iio/adc/Makefile @@ -3,6 +3,8 @@ # Makefile for IIO ADC drivers # +obj-$(CONFIG_IIO_ADC_HELPER) += industrialio-adc.o + # When adding new entries keep the list in alphabetical order obj-$(CONFIG_AB8500_GPADC) += ab8500-gpadc.o obj-$(CONFIG_AD_SIGMA_DELTA) += ad_sigma_delta.o diff --git a/drivers/iio/adc/industrialio-adc.c b/drivers/iio/adc/industrialio-adc.c new file mode 100644 index 000000000000..6cfb001c74b9 --- /dev/null +++ b/drivers/iio/adc/industrialio-adc.c @@ -0,0 +1,79 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Helpers for parsing common ADC information from a firmware node. + * + * Copyright (c) 2025 Matti Vaittinen + */ + +#include +#include +#include +#include +#include +#include + +#include +#include + +/** + * devm_iio_adc_device_alloc_chaninfo_se - allocate and fill iio_chan_spec for ADC + * + * Scan the device node for single-ended ADC channel information. Channel ID is + * expected to be found from the "reg" property. Allocate and populate the + * iio_chan_spec structure corresponding to channels that are found. The memory + * for iio_chan_spec structure will be freed upon device detach. + * + * @dev: Pointer to the ADC device. + * @template: Template iio_chan_spec from which the fields of all + * found and allocated channels are initialized. + * @max_chan_id: Maximum value of a channel ID. Use -1 if no checking + * is required. + * @cs: Location where pointer to allocated iio_chan_spec + * should be stored. + * + * Return: Number of found channels on success. Negative value to indicate + * failure. + */ +int devm_iio_adc_device_alloc_chaninfo_se(struct device *dev, + const struct iio_chan_spec *template, + int max_chan_id, + struct iio_chan_spec **cs) +{ + struct iio_chan_spec *chan_array, *chan; + int num_chan = 0, ret; + + num_chan = iio_adc_device_num_channels(dev); + if (num_chan < 1) + return num_chan; + + chan_array = devm_kcalloc(dev, num_chan, sizeof(*chan_array), + GFP_KERNEL); + if (!chan_array) + return -ENOMEM; + + chan = &chan_array[0]; + + device_for_each_named_child_node_scoped(dev, child, "channel") { + u32 ch; + + ret = fwnode_property_read_u32(child, "reg", &ch); + if (ret) + return ret; + + if (max_chan_id != -1 && ch > max_chan_id) + return -ERANGE; + + *chan = *template; + chan->channel = ch; + chan++; + } + + *cs = chan_array; + + return num_chan; +} +EXPORT_SYMBOL_NS_GPL(devm_iio_adc_device_alloc_chaninfo_se, "IIO_DRIVER"); + +MODULE_LICENSE("GPL"); +MODULE_AUTHOR("Matti Vaittinen "); +MODULE_DESCRIPTION("IIO ADC fwnode parsing helpers"); diff --git a/include/linux/iio/adc-helpers.h b/include/linux/iio/adc-helpers.h new file mode 100644 index 000000000000..56b092a2a4c4 --- /dev/null +++ b/include/linux/iio/adc-helpers.h @@ -0,0 +1,27 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +/* + * The industrial I/O ADC firmware property parsing helpers + * + * Copyright (c) 2025 Matti Vaittinen + */ + +#ifndef _INDUSTRIAL_IO_ADC_HELPERS_H_ +#define _INDUSTRIAL_IO_ADC_HELPERS_H_ + +#include + +struct device; +struct iio_chan_spec; + +static inline int iio_adc_device_num_channels(struct device *dev) +{ + return device_get_named_child_node_count(dev, "channel"); +} + +int devm_iio_adc_device_alloc_chaninfo_se(struct device *dev, + const struct iio_chan_spec *template, + int max_chan_id, + struct iio_chan_spec **cs); + +#endif /* _INDUSTRIAL_IO_ADC_HELPERS_H_ */ From patchwork Mon Mar 10 12:56:35 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matti Vaittinen X-Patchwork-Id: 14010054 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 152CEC282DE for ; Mon, 10 Mar 2025 13:57:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PcfEYtrJz5zWQt9AvTA5zPr+o4Ysr+2unMZ2MALKhvA=; b=Yuvhovj5kaN/WzdSr4KUeDXjwK 9n1ddz55Pwha4kSzEAHJgCZDZdNvZbvvmiEv5yzYeWG6yaj+SN4XYkVnF7nnly1ZfVnbQKCfG9zw2 jQqW+Zu8i1TfRW4xgnLZrbq8nSCuvR0ZONPGBvNx+ezOyuMDrX0T9zhsCPlwf6+CLB8ne3904RQ8i Mco7/+VNy21Wlkv4f8Ku67tsktZZRPGYyc4VMLOu7rK7VkRGQXzh0Tw2x+Jg964a92e54BS6csZwp Ytv4ZOhKVBSvHkZnX3tv9awB2/UhipUSAnNwa4qgukj+8m7MRT+2GHgyryGDvMVfmRgNvLaVfKtPl n7RZra4Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1trddA-00000002rYr-1lrS; Mon, 10 Mar 2025 13:57:20 +0000 Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1trcgU-00000002hgx-1y4g for linux-arm-kernel@lists.infradead.org; Mon, 10 Mar 2025 12:56:43 +0000 Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-549967c72bcso2693459e87.3 for ; Mon, 10 Mar 2025 05:56:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741611401; x=1742216201; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=PcfEYtrJz5zWQt9AvTA5zPr+o4Ysr+2unMZ2MALKhvA=; b=i/10oulkdZUjw5Q05B9nPfE2+7WzmZIT7/vuAzDibHnuadjCGbRH7ZsTOee91JcTHD 9R4YuzgC2wuvvMY1fOA47Sw6Mokiwv9WUZRLBQUHERcpuePZroUjSLoVv75lk5Nz9lFv 82bQj4vMtdkFMclEOPhL4kri4VBSS02yVyor7MwOQIhqXzitvidg6U2luBpeCSCuZnFt lMo0hRD7M/g8dKlLDYvKgQ5+giD/Ap4jRUfYc0u4oNYF1yUXkZgdXTYpCzRqEpEF4niy bQ0e+Si+pdK4C8P9Z2M/H9l3tTL0jfDOTGuIR7yuEbrX15LckQq4oPhUWC7xGbsiXh62 WXKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741611401; x=1742216201; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PcfEYtrJz5zWQt9AvTA5zPr+o4Ysr+2unMZ2MALKhvA=; b=dktsC7FDdEj0RnWHipjytpZNGLWbr185qoUJSo7kU0xtU/R2oaGXPKWWI/NxurqpEp HZlRSB6mXjWhO89X9CHfpBdLEqFxplb/g3rfOkoKrn5cjhaDwapWPT8uBUTVGIjTnXLx d2k0RDYkms+elFSIv6NDh34ix+rqrKW7nc7NikMwD6u96IEHgMEOCaMBWNN/7V4xkxjH URscphcfC5zz3ZUS/1fyYA+s2hL5F+gbf1ti/DR1GNqWTndMtGrLFADQfanpMMTC1Kup LsLHJtfP+fpkEpQfkNOLnrl6pMtfWwqaPm97AFoo1zbO32nupu/2eL7zmYWe4VXekbvV UZFw== X-Forwarded-Encrypted: i=1; AJvYcCXdJLoHzuPeceWQcu1BHOz61sCPBnLEwPLlzXD8f5ZBAFlwvw/9mh/re7qSxmzWnP1/VCuGF5gYtkxBs9l6pxhd@lists.infradead.org X-Gm-Message-State: AOJu0YwOuQENKu9NSCtfGiTUkJIIySYwi2TUdltsHHwLCpZHR3TVJhbZ wDfutRlnM9j66qxAiTgccKqnskVN7VyrB/f7aIqFeTyUWG6ZZyr3 X-Gm-Gg: ASbGncsuo7a1k/IiWD5ZjiZiZo/a6D16iMpiSJtPIcfSCmEgBbV2c0dEcZkfxz3wsxu XtjVd6NSBLXThoSDgzsXzsMN0ecE5T7mqEHUlXWj8WidOp/aqx/xnlO1EK8Le7bKiDsLyVqbcN8 AfvUNH8rO04lsD8rW3nc8iabyahNpXwDI/PBm+ewpWp52VAUMLgJ1mwmVgmB1R0ax5bWTWSOtum cxlulRf3Wb0qF5l/2mCAV4flQsho14VL/kd+547dE1Az0mN3VCiq3EMql0aZK9PIy06H1QnTK19 OwILRcNTugbFzeNwucA+gcEV5QGF7ve4cSdwaI+3NUJvKrWP7Tc= X-Google-Smtp-Source: AGHT+IFRmSf5GiiM8bfzTIfNKKyhDwDuNOYO808weMLsGD1nweR4GVyow1Hcgy16MeoRt06G5yQKvA== X-Received: by 2002:a05:6512:3993:b0:549:792a:a382 with SMTP id 2adb3069b0e04-549910b59bdmr4168207e87.32.1741611400636; Mon, 10 Mar 2025 05:56:40 -0700 (PDT) Received: from mva-rohm ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5498ae58e22sm1449802e87.86.2025.03.10.05.56.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Mar 2025 05:56:39 -0700 (PDT) Date: Mon, 10 Mar 2025 14:56:35 +0200 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen Cc: Jonathan Cameron , Lars-Peter Clausen , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Nuno Sa , David Lechner , Javier Carrasco , Matti Vaittinen , Olivier Moysan , Guillaume Stols , Dumitru Ceclan , Trevor Gamblin , Matteo Martelli , Alisa-Dariana Roman , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: [PATCH v6 05/10] iio: adc: sun20i-gpadc: Use adc-helpers Message-ID: <06e8f4f84731df9fc5d6f324e74fbd1bf83a81d5.1741610847.git.mazziesaccount@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250310_055642_512226_503853D0 X-CRM114-Status: GOOD ( 23.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The new devm_iio_adc_device_alloc_chaninfo() -helper is intended to help drivers avoid open-coding the for_each_node -loop for getting the channel IDs. The helper provides standard way to detect the ADC channel nodes (by the node name), and a standard way to convert the "reg" -properties to channel identification numbers, used in the struct iio_chan_spec. Furthermore, the helper can optionally check the found channel IDs are smaller than given maximum. This is useful for callers which later use the IDs for example for indexing a channel data array. The original driver treated all found child nodes as channel nodes. The new helper requires channel nodes to be named channel[@N]. This should help avoid problems with devices which may contain also other but ADC child nodes. Quick grep from arch/* with the sun20i-gpadc's compatible string didn't reveal any in-tree .dts with channel nodes named otherwise. Also, same grep shows all the in-tree .dts seem to have channel IDs between 0..num of channels. Use the new helper. Signed-off-by: Matti Vaittinen --- Revision history: v5 => v6: - Commit message typofix v4 => v5: - Drop the diff-channel stuff from the commit message v3 => v4: - Adapt to 'drop diff-channel support' changes to ADC-helpers - select ADC helpers in the Kconfig v2 => v3: - New patch I picked the sun20i-gpadc in this series because it has a straightforward approach for populating the struct iio_chan_spec. Everything else except the .channel can use 'template'-data. This makes the sun20i-gpadc well suited to be an example user of this new helper. I hope this patch helps to evaluate whether these helpers are worth the hassle. The change is compile tested only!! Testing before applying is highly appreciated (as always!). Also, even though I tried to audit the dts files for the reg-properties in the channel nodes, use of references didn't make it easy. I can't guarantee I didn't miss anything. --- drivers/iio/adc/Kconfig | 1 + drivers/iio/adc/sun20i-gpadc-iio.c | 38 ++++++++++++------------------ 2 files changed, 16 insertions(+), 23 deletions(-) diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig index e4933de0c366..0993008a1586 100644 --- a/drivers/iio/adc/Kconfig +++ b/drivers/iio/adc/Kconfig @@ -1357,6 +1357,7 @@ config SUN4I_GPADC config SUN20I_GPADC tristate "Allwinner D1/T113s/T507/R329 and similar GPADCs driver" depends on ARCH_SUNXI || COMPILE_TEST + select IIO_ADC_HELPER help Say yes here to build support for Allwinner (D1, T113, T507 and R329) SoCs GPADC. This ADC provides up to 16 channels. diff --git a/drivers/iio/adc/sun20i-gpadc-iio.c b/drivers/iio/adc/sun20i-gpadc-iio.c index 136b8d9c294f..bf1db2a3de9b 100644 --- a/drivers/iio/adc/sun20i-gpadc-iio.c +++ b/drivers/iio/adc/sun20i-gpadc-iio.c @@ -15,6 +15,7 @@ #include #include +#include #include #define SUN20I_GPADC_DRIVER_NAME "sun20i-gpadc" @@ -149,37 +150,27 @@ static void sun20i_gpadc_reset_assert(void *data) reset_control_assert(rst); } +static const struct iio_chan_spec sun20i_gpadc_chan_template = { + .type = IIO_VOLTAGE, + .indexed = 1, + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW), + .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE), +}; + static int sun20i_gpadc_alloc_channels(struct iio_dev *indio_dev, struct device *dev) { - unsigned int channel; - int num_channels, i, ret; + int num_channels; struct iio_chan_spec *channels; - num_channels = device_get_child_node_count(dev); + num_channels = devm_iio_adc_device_alloc_chaninfo_se(dev, + &sun20i_gpadc_chan_template, -1, &channels); + if (num_channels < 0) + return num_channels; + if (num_channels == 0) return dev_err_probe(dev, -ENODEV, "no channel children\n"); - channels = devm_kcalloc(dev, num_channels, sizeof(*channels), - GFP_KERNEL); - if (!channels) - return -ENOMEM; - - i = 0; - device_for_each_child_node_scoped(dev, node) { - ret = fwnode_property_read_u32(node, "reg", &channel); - if (ret) - return dev_err_probe(dev, ret, "invalid channel number\n"); - - channels[i].type = IIO_VOLTAGE; - channels[i].indexed = 1; - channels[i].channel = channel; - channels[i].info_mask_separate = BIT(IIO_CHAN_INFO_RAW); - channels[i].info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE); - - i++; - } - indio_dev->channels = channels; indio_dev->num_channels = num_channels; @@ -271,3 +262,4 @@ module_platform_driver(sun20i_gpadc_driver); MODULE_DESCRIPTION("ADC driver for sunxi platforms"); MODULE_AUTHOR("Maksim Kiselev "); MODULE_LICENSE("GPL"); +MODULE_IMPORT_NS("IIO_DRIVER"); From patchwork Mon Mar 10 12:56:59 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matti Vaittinen X-Patchwork-Id: 14010055 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4466BC282DE for ; Mon, 10 Mar 2025 13:59:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3YGvj5iF7isPICFknfIGBgf8Vkx+OSuL7svbCQwNvKw=; b=e+8elnFzNOWB8pAYWmNnuajx96 92jf8gtisoMrlP0brEMrY34FLnpQQPhgquWCIJaCz+ecmADuavEo5ciiQmOEh20ad/9zfzzZPvKy0 pdxnmwUISWRRU5jLd727d7QbRFoV47FuE8MO/L8n0xLR+8PFnoFu8h+lThhktBRWplGYCJnM5G7Sy RKjQaIsLNFXwKoyrGsA+IzoLA75Y/jgFU9No/P5iScYDFdnzcDujGqJQ9OPCwAC/jq5hLLscdXwa4 ZGZXFoxDxWR+roiku1+25D7LcrDdG2qYTuFgjAahMUIcfPvtUhh/WvLEzGhC3ruHbhqqfPDaHTEbt 2Q6vvOjQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1trdel-00000002rl7-0JgF; Mon, 10 Mar 2025 13:58:59 +0000 Received: from mail-lf1-x12b.google.com ([2a00:1450:4864:20::12b]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1trcgt-00000002hmr-1aLV for linux-arm-kernel@lists.infradead.org; Mon, 10 Mar 2025 12:57:08 +0000 Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-54957f0c657so4924817e87.0 for ; Mon, 10 Mar 2025 05:57:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741611426; x=1742216226; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3YGvj5iF7isPICFknfIGBgf8Vkx+OSuL7svbCQwNvKw=; b=YrU4/HP51K+XLyjF+Jy5MPaSrPAmoWJrupxh91maNsuUP0mGFqWXtQHsd0z2L58mvi ZUi3OHP1jiHgvYi+pSoZnCOGalCwS97MpTiO/xkYZuK2vxMgO00XCfjrZrKyN/AMMmLn BXJgAIBY9nznZsivWbqBbVG/BxfKY5NNluTarsVAQvunwSUXrItsI9cwe3uc6wgY5eN7 rY1cmt2gB7TUL1khR2qVs1FIjCC4NHnqSvlvBXOQ38cOg2BtASRtGrFrpDd10HNjTYu+ FNjTuB1BN6dPd3lk9Ih2pUk5KH9N71jpkznxwLrh/l8IIrp3ry1dV9+l7NBHZDEvHVDv 60zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741611426; x=1742216226; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3YGvj5iF7isPICFknfIGBgf8Vkx+OSuL7svbCQwNvKw=; b=RDcQk/qJEZnU7PSw6lD5Tyf98VKW1ePNb6GcTBYBMsXBm3p4SG/WM8Fj5aTOy2png3 aV4RoStlZsRkLXd79uiXAs6W+gRMcv/EJoItcvp2o6jfXOGhYr1QutsYHhmbVjrw4KLj 9PAO9bGn7+TJcK3eMCxka7RT4PyX4HGlOZzHOB9nCpbXkf0N4UYQnjOHHqE+s74rHVrw 54ZguldAA5imABZ3CdaJMBRHIQvt4aAKMtv99h5dcyGrgVErHkb5tv9+SOozFxocc3J2 AMn4A0/0yydH8MqXzDeGOUq80q6VjItOcIJeHbnk96b68vPch9YTfi/5sUA3GQTYMM3o x5Bw== X-Forwarded-Encrypted: i=1; AJvYcCX0hpY5cji1UW8yJhb5bO5PZEMV4FAK5tT3FYSkZxZx/S9BZd7wqfvxi+se+2D8yL3sjzZJq3UGZJaYwrpgDyVB@lists.infradead.org X-Gm-Message-State: AOJu0YzaB8aLzyRfzuGRcWA4+2VqMrA5B3AC2dbXWm4UxE+rmmOzptks lCfRSGlSAyjeQK2bxPU7s05Zdq1VEfJLPuEc2iPSpe5tKpDRnp0/ X-Gm-Gg: ASbGnctg79mNRSuro+8tyCQjmQgXRjaZiKrzXxJDs9Yy0pdLTK/ssbuodiu92uioSiO YFnmxodwjHo9m/dYmrI1DjhAavXDE/y1SmuOeF0koqTD+ICgWI7+CG3eOsGaaNUSPkWXEXOe0xE vUc03VcbC/HtGCr96HdfqnFMI68qBGrHl2lArctwoWgkJ4+oujSkopgidhD7l9GFbsLfbA+YmnZ +J3K++kPjs5NtBfx6UG6XP5/aITbcpP5yjslpendAENM2XruwlD6xFi3sLaskZRxysYGIbMe6Wl h7LpDxBBd9kE7BHSaMXpWglKKHl8OAcPbvWzF0JyDmg/1PFKddm4bxvZ037WSQ== X-Google-Smtp-Source: AGHT+IF1vXuuBbI7nLmEiCd1MxAiAY5UstFD2g17yL/xAwUgcupEf5SWUE4YyitfHSkIrkHA8dJSBQ== X-Received: by 2002:a05:6512:b0a:b0:549:8c0c:ea15 with SMTP id 2adb3069b0e04-54997d99dbemr3607673e87.0.1741611425535; Mon, 10 Mar 2025 05:57:05 -0700 (PDT) Received: from mva-rohm ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-549a17fb84csm548493e87.250.2025.03.10.05.57.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Mar 2025 05:57:03 -0700 (PDT) Date: Mon, 10 Mar 2025 14:56:59 +0200 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen Cc: Jonathan Cameron , Lars-Peter Clausen , Andy Shevchenko , Matti Vaittinen , Lad Prabhakar , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Hugo Villeneuve , Nuno Sa , David Lechner , Javier Carrasco , Guillaume Stols , Dumitru Ceclan , Trevor Gamblin , Matteo Martelli , Alisa-Dariana Roman , Ramona Alexandra Nechita , AngeloGioacchino Del Regno , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: [PATCH v6 07/10] MAINTAINERS: Add IIO ADC helpers Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250310_055707_414348_6E89741F X-CRM114-Status: GOOD ( 11.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add undersigned as a maintainer for the IIO ADC helpers. Signed-off-by: Matti Vaittinen --- Revision history: v2 => - No changes RFC v1 => v2: - New patch --- MAINTAINERS | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 8e0736dc2ee0..5b96fb864227 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11208,6 +11208,13 @@ L: linux-media@vger.kernel.org S: Maintained F: drivers/media/rc/iguanair.c +IIO ADC HELPERS +M: Matti Vaittinen +L: linux-iio@vger.kernel.org +S: Maintained +F: drivers/iio/adc/industrialio-adc.c +F: include/linux/iio/adc-helpers.h + IIO BACKEND FRAMEWORK M: Nuno Sa R: Olivier Moysan