From patchwork Mon Mar 10 14:45:34 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anthony PERARD X-Patchwork-Id: 14010228 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C64EC282DE for ; Mon, 10 Mar 2025 15:04:09 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1treex-0004Od-Ep; Mon, 10 Mar 2025 11:03:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1treeq-0004Md-Io for qemu-devel@nongnu.org; Mon, 10 Mar 2025 11:03:10 -0400 Received: from mail186-3.suw21.mandrillapp.com ([198.2.186.3]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1treen-0005La-He for qemu-devel@nongnu.org; Mon, 10 Mar 2025 11:03:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mandrillapp.com; s=mte1; t=1741617934; x=1741887934; bh=D8pjLz1P43cjnB28y4d+UMASewJChwKWZNDkhhJymtM=; h=From:Subject:To:Cc:Message-Id:In-Reply-To:References:Feedback-ID: Date:MIME-Version:Content-Type:Content-Transfer-Encoding:CC:Date: Subject:From; b=SLK41gsP9e4/+UHsXs/FBI6xKKKK6ArJNu3TtfQMD7pVdOhgkBSP+smkpuQG/0NLV 9g83sZoXoRizWvlCJ28lny0nKPx5lPFg8ZLR4/7fGYrsiISHCW3xtIlN4Ab1W2aI/5 vOy3lKImpIirNKxQeVhEqywpdCefWQOc1zdPT6dO5UZdbM8HA5Fp8BzN2IHB5gjUjA nqcYyKCR1imlNjeRFUkVPzzJrVwNPBZVZe4lLuAHq8Uf5OQXIqWjlyi9Wx7yJ+Ur4w ilfngcOtKpr6D04NsDtipIXq2qb1NhEQdmEx0VvZetR8xmtaCx/BZZE8vjNcIrT261 Rj3QF3Mz0GN1Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; s=mte1; t=1741617934; x=1741878434; i=anthony.perard@vates.tech; bh=D8pjLz1P43cjnB28y4d+UMASewJChwKWZNDkhhJymtM=; h=From:Subject:To:Cc:Message-Id:In-Reply-To:References:Feedback-ID: Date:MIME-Version:Content-Type:Content-Transfer-Encoding:CC:Date: Subject:From; b=ANzBvICEauVO5w0HQPEqkzGD/y5vlB2Hm81O1juShsFHCeE5BRwguDyPQpdlgBgni kFdkMoFmLBQfxGD56nQgye7f/eCOdvlTYSfz8A7IbCpccoJeDB2aUSHtlFDeh2FF/y 7Gg8PFoibNP4ewj9sQtyM9Kx8EelrFk7GxEI1GuziIm9qs/nppXZpDbUG641RiVKrc vED/6G+M6qqp9XeXRQf+16eap59KvwRWQPrWoIC00PsZeSlEtGXA9HpPk2U0B22FR3 xEYApb+SY729I4BSsI/XrCJGHN2k72gwetYKXiE9q0HGSA/vDKPR34V2QXf+FyB0T+ MtIuxg9/GOp0A== Received: from pmta10.mandrill.prod.suw01.rsglab.com (localhost [127.0.0.1]) by mail186-3.suw21.mandrillapp.com (Mailchimp) with ESMTP id 4ZBKSZ1lHDzDRHyB6 for ; Mon, 10 Mar 2025 14:45:34 +0000 (GMT) From: "Anthony PERARD" Subject: =?utf-8?q?=5BPULL_1/3=5D_xen/passthrough=3A_use_gsi_to_map_pirq_whe?= =?utf-8?q?n_dom0_is_PVH?= Received: from [37.26.189.201] by mandrillapp.com id 1f1809525b724d30974b587fa46d1235; Mon, 10 Mar 2025 14:45:34 +0000 X-Mailer: git-send-email 2.39.5 X-Bm-Disclaimer: Yes X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1741617933291 To: qemu-devel@nongnu.org Cc: "Jiqian Chen" , "Anthony PERARD" Message-Id: <20250310144516.28828-2-anthony.perard@vates.tech> In-Reply-To: <20250310144516.28828-1-anthony.perard@vates.tech> References: <20250310144516.28828-1-anthony.perard@vates.tech> X-Native-Encoded: 1 X-Report-Abuse: =?UTF-8?Q?Please=20forward=20a=20copy=20of=20this=20message, =20including=20all=20headers, =20to=20abuse@mandrill.com.=20You=20can=20also=20report=20abuse=20here:=20https://mandrillapp.com/contact/abuse=3Fid=3D30504962.1f1809525b724d30974b587fa46d1235?= X-Mandrill-User: md_30504962 Feedback-ID: 30504962:30504962.20250310:md Date: Mon, 10 Mar 2025 14:45:34 +0000 MIME-Version: 1.0 Received-SPF: pass client-ip=198.2.186.3; envelope-from=bounce-md_30504962.67cefb0e.v1-1f1809525b724d30974b587fa46d1235@bounce.vates.tech; helo=mail186-3.suw21.mandrillapp.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org From: Jiqian Chen In PVH dom0, when passthrough a device to domU, QEMU code xen_pt_realize->xc_physdev_map_pirq wants to use gsi, but in current codes the gsi number is got from file /sys/bus/pci/devices//irq, that is wrong, because irq is not equal with gsi, they are in different spaces, so pirq mapping fails. To solve above problem, use new interface of Xen, xc_pcidev_get_gsi to get gsi and use xc_physdev_map_pirq_gsi to map pirq when dom0 is PVH. Signed-off-by: Jiqian Chen Signed-off-by: Huang Rui Signed-off-by: Jiqian Chen Acked-by: Anthony PERARD Reviewed-by: Stewart Hildebrand Message-Id: <20241106061418.3655304-1-Jiqian.Chen@amd.com> Signed-off-by: Anthony PERARD --- hw/xen/xen_pt.c | 60 ++++++++++++++++++++++++++++++++++++++++++++ include/hw/pci/pci.h | 4 +++ 2 files changed, 64 insertions(+) diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c index e2bd4c7d41..9487f68f2e 100644 --- a/hw/xen/xen_pt.c +++ b/hw/xen/xen_pt.c @@ -766,6 +766,57 @@ static void xen_pt_destroy(PCIDevice *d) { } /* init */ +#if CONFIG_XEN_CTRL_INTERFACE_VERSION >= 42000 +static bool xen_pt_need_gsi(void) +{ + FILE *fp; + int len; + /* + * The max length of guest_type is "PVH"+'\n'+'\0', it is 5, + * so here set the length of type to be twice. + */ + char type[10]; + const char *guest_type = "/sys/hypervisor/guest_type"; + + fp = fopen(guest_type, "r"); + if (!fp) { + error_report("Cannot open %s: %s", guest_type, strerror(errno)); + return false; + } + + if (fgets(type, sizeof(type), fp)) { + len = strlen(type); + if (len) { + type[len - 1] = '\0'; + if (!strcmp(type, "PVH")) { + fclose(fp); + return true; + } + } + } + + fclose(fp); + return false; +} + +static int xen_pt_map_pirq_for_gsi(PCIDevice *d, int *pirq) +{ + int gsi; + XenPCIPassthroughState *s = XEN_PT_DEVICE(d); + + gsi = xc_pcidev_get_gsi(xen_xc, + PCI_SBDF(s->real_device.domain, + s->real_device.bus, + s->real_device.dev, + s->real_device.func)); + if (gsi >= 0) { + return xc_physdev_map_pirq_gsi(xen_xc, xen_domid, gsi, pirq); + } + + return gsi; +} +#endif + static void xen_pt_realize(PCIDevice *d, Error **errp) { ERRP_GUARD(); @@ -847,7 +898,16 @@ static void xen_pt_realize(PCIDevice *d, Error **errp) goto out; } +#if CONFIG_XEN_CTRL_INTERFACE_VERSION >= 42000 + if (xen_pt_need_gsi()) { + rc = xen_pt_map_pirq_for_gsi(d, &pirq); + } else { + rc = xc_physdev_map_pirq(xen_xc, xen_domid, machine_irq, &pirq); + } +#else rc = xc_physdev_map_pirq(xen_xc, xen_domid, machine_irq, &pirq); +#endif + if (rc < 0) { XEN_PT_ERR(d, "Mapping machine irq %u to pirq %i failed, (err: %d)\n", machine_irq, pirq, errno); diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h index c220cc8449..822fbacdf0 100644 --- a/include/hw/pci/pci.h +++ b/include/hw/pci/pci.h @@ -23,6 +23,10 @@ extern bool pci_available; #define PCI_SLOT_MAX 32 #define PCI_FUNC_MAX 8 +#define PCI_SBDF(seg, bus, dev, func) \ + ((((uint32_t)(seg)) << 16) | \ + (PCI_BUILD_BDF(bus, PCI_DEVFN(dev, func)))) + /* Class, Vendor and Device IDs from Linux's pci_ids.h */ #include "hw/pci/pci_ids.h" From patchwork Mon Mar 10 14:45:34 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anthony PERARD X-Patchwork-Id: 14010226 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1DB64C282DE for ; Mon, 10 Mar 2025 15:04:05 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1trefa-0004tN-DQ; Mon, 10 Mar 2025 11:03:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1trefR-0004me-5Q for qemu-devel@nongnu.org; Mon, 10 Mar 2025 11:03:45 -0400 Received: from mail128-10.atl41.mandrillapp.com ([198.2.128.10]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1trefL-0005Pc-QW for qemu-devel@nongnu.org; Mon, 10 Mar 2025 11:03:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mandrillapp.com; s=mte1; t=1741617934; x=1741887934; bh=Jtw83zR8ClGIKsdVW1XH0izlnw0Jjgrfmv5Kbcmzc5U=; h=From:Subject:To:Cc:Message-Id:In-Reply-To:References:Feedback-ID: Date:MIME-Version:Content-Type:Content-Transfer-Encoding:CC:Date: Subject:From; b=F9VZpSRNhoH2eFbGO1IVbEiNTCls+MNNN+3ww7UNiNBQXxWVwkoKcDGryWsMgPWMb fqcTJmDHJ3I3lFRnNTDS2xli9+Y8CpCgZ7iEzeUQVZLcM/EKxRI/y+H0Y+jpUAwqDK 0g0KOfJ62wQ/4+THO+IuDcvmAvbBlaX9g71WEVdMQRkKlJiN/uz80ix/OeluzqZdxY tuP6uYDbPURGTgd+246Va5jexhhYEAkZc4mWp7EFNhbb7VEVpPZW7C6OUwCIf2bd0Q ypHxuWUAu5hkTYM/grKE9zyWSyfTjKzbt9o+EYcQIng1ZTW8wEm6UxtkSBUPuURjly 0VW8/p4/7p63Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; s=mte1; t=1741617934; x=1741878434; i=anthony.perard@vates.tech; bh=Jtw83zR8ClGIKsdVW1XH0izlnw0Jjgrfmv5Kbcmzc5U=; h=From:Subject:To:Cc:Message-Id:In-Reply-To:References:Feedback-ID: Date:MIME-Version:Content-Type:Content-Transfer-Encoding:CC:Date: Subject:From; b=KU15XRe6+67N9xw/K7Pv7a2paah4fJm9Eml3/Vilzt1y1kKiAsC5doyHox7Ub3ysy 9CpgU61fNnmc0+TWl/6Wd+eHfUWUPlIlGD7JS1xY6IUy0D+V0GuD5QfVO3NVL1956g 5rBOnnGd9glGS80r3R8etujRAIohrMzRaS2K4ZBtDlyqWdG2lLQpBPDxWQSdMJX/H6 XD/A0zwgdbK/q99chCWSW7Em5m6fBWkrh5edy0o7UtJcHD6FjGYUdmbCJaBLbWoYe6 s6qe+JlbXstkDljmSQluSSc20Ag4a5U8Q6q6mIToVnF+uupTG9ugfPPpkWYvjR6hC/ OxeNjnESEdkuw== Received: from pmta08.mandrill.prod.atl01.rsglab.com (localhost [127.0.0.1]) by mail128-10.atl41.mandrillapp.com (Mailchimp) with ESMTP id 4ZBKSZ4FKCzLfHJ8h for ; Mon, 10 Mar 2025 14:45:34 +0000 (GMT) From: "Anthony PERARD" Subject: =?utf-8?q?=5BPULL_2/3=5D_hw/xen=3A_Add_=22mode=22_parameter_to_xen-?= =?utf-8?q?block_devices?= Received: from [37.26.189.201] by mandrillapp.com id 7bfbee78310241baba23d658a5e92bf4; Mon, 10 Mar 2025 14:45:34 +0000 X-Mailer: git-send-email 2.39.5 X-Bm-Disclaimer: Yes X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1741617933736 To: qemu-devel@nongnu.org Cc: "David Woodhouse" , "Anthony PERARD" Message-Id: <20250310144516.28828-3-anthony.perard@vates.tech> In-Reply-To: <20250310144516.28828-1-anthony.perard@vates.tech> References: <20250310144516.28828-1-anthony.perard@vates.tech> X-Native-Encoded: 1 X-Report-Abuse: =?UTF-8?Q?Please=20forward=20a=20copy=20of=20this=20message, =20including=20all=20headers, =20to=20abuse@mandrill.com.=20You=20can=20also=20report=20abuse=20here:=20https://mandrillapp.com/contact/abuse=3Fid=3D30504962.7bfbee78310241baba23d658a5e92bf4?= X-Mandrill-User: md_30504962 Feedback-ID: 30504962:30504962.20250310:md Date: Mon, 10 Mar 2025 14:45:34 +0000 MIME-Version: 1.0 Received-SPF: pass client-ip=198.2.128.10; envelope-from=bounce-md_30504962.67cefb0e.v1-7bfbee78310241baba23d658a5e92bf4@bounce.vates.tech; helo=mail128-10.atl41.mandrillapp.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org From: David Woodhouse Block devices don't work in PV Grub (0.9x) if there is no mode specified. It complains: "Error ENOENT when reading the mode" Signed-off-by: David Woodhouse Message-Id: <20250207143724.30792-2-dwmw2@infradead.org> Signed-off-by: Anthony PERARD --- hw/block/xen-block.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/block/xen-block.c b/hw/block/xen-block.c index 2098286b5f..ec04102b66 100644 --- a/hw/block/xen-block.c +++ b/hw/block/xen-block.c @@ -408,6 +408,8 @@ static void xen_block_realize(XenDevice *xendev, Error **errp) } xen_device_backend_printf(xendev, "info", "%u", blockdev->info); + xen_device_backend_printf(xendev, "mode", + (blockdev->info & VDISK_READONLY) ? "r" : "w"); xen_device_frontend_printf(xendev, "virtual-device", "%lu", vdev->number); From patchwork Mon Mar 10 14:45:35 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anthony PERARD X-Patchwork-Id: 14010227 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D503C282EC for ; Mon, 10 Mar 2025 15:04:05 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1treez-0004Rn-JL; Mon, 10 Mar 2025 11:03:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1treeq-0004Mf-Gl for qemu-devel@nongnu.org; Mon, 10 Mar 2025 11:03:10 -0400 Received: from mail186-3.suw21.mandrillapp.com ([198.2.186.3]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1treel-0005LX-VC for qemu-devel@nongnu.org; Mon, 10 Mar 2025 11:03:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mandrillapp.com; s=mte1; t=1741617935; x=1741887935; bh=4yf+U/Cs5iGe0IID9OfkhTo+yjG5clPxWQk9tooGuiU=; h=From:Subject:To:Cc:Message-Id:In-Reply-To:References:Feedback-ID: Date:MIME-Version:Content-Type:Content-Transfer-Encoding:CC:Date: Subject:From; b=hpbuo2SlDOg/BCtJw1pDwpvfIeAe4b8Hg1ktvPcf6hA2uCcd6auIrMilhsGorNc3B sSmHfhS/9nOUHE/rvLD4l92Q70W7J6bp5UQ/YbkxGNGQGyZPt4fiBlJdOmA6iXUcUX 6IHuObUD5WgTtX4tBvAhv85o/QYOYEuD9lwiVuxUGuILRwpzolbrbyZ2speH1EDiXg gAYkeEvgNW+vdmzqDJCq7cX0K637BeUwZE0NBmQIfJ48acoZRgb2cuGxhp+dhp8TDc zktiw/DmiuvqTQ1MTRoKebgal/FoFqeehKWz3SSais8PT/QUWNMP/7LUarrGHqwd73 4wNvSum6mcCog== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; s=mte1; t=1741617935; x=1741878435; i=anthony.perard@vates.tech; bh=4yf+U/Cs5iGe0IID9OfkhTo+yjG5clPxWQk9tooGuiU=; h=From:Subject:To:Cc:Message-Id:In-Reply-To:References:Feedback-ID: Date:MIME-Version:Content-Type:Content-Transfer-Encoding:CC:Date: Subject:From; b=Ukr40IJnjc1Wqxzu1vS5gMggtXf8z6WPW/NlJLw/0xBcaLZ30j1CHWCUUaqmEAXqu mWuGuxObi9PsCFhpN8DEoj3UbN0DJd9tgjYWf6cCBLgqAGauscD68VqlvcGIF3iEzw MJs2j086+yIZBIXBIWYIrg9NZkBp4QaeznfAowo3tutlKmFHueR3nZzQ3xJBsqxHam 99abFQRUYKIrPuGeoG32XrjGc0iiffO05aAIdsJKSKDJEs/TVyrRrf8IQ1XofWHfhA //ZkVakfjqcXO8jbp1hL1AWiq2/F+8jq0xwUiCJxZ23uLF7gpVJKcbQn+lrt0Z5ruJ v7uRp1NaM/wTg== Received: from pmta10.mandrill.prod.suw01.rsglab.com (localhost [127.0.0.1]) by mail186-3.suw21.mandrillapp.com (Mailchimp) with ESMTP id 4ZBKSb182czDRJ18D for ; Mon, 10 Mar 2025 14:45:35 +0000 (GMT) From: "Anthony PERARD" Subject: =?utf-8?q?=5BPULL_3/3=5D_xen=3A_No_need_to_flush_the_mapcache_for_g?= =?utf-8?q?rants?= Received: from [37.26.189.201] by mandrillapp.com id 368be07599fc4a2893c4ac517d073408; Mon, 10 Mar 2025 14:45:35 +0000 X-Mailer: git-send-email 2.39.5 X-Bm-Disclaimer: Yes X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1741617934091 To: qemu-devel@nongnu.org Cc: "Stefano Stabellini" , "Anthony PERARD" Message-Id: <20250310144516.28828-4-anthony.perard@vates.tech> In-Reply-To: <20250310144516.28828-1-anthony.perard@vates.tech> References: <20250310144516.28828-1-anthony.perard@vates.tech> X-Native-Encoded: 1 X-Report-Abuse: =?UTF-8?Q?Please=20forward=20a=20copy=20of=20this=20message, =20including=20all=20headers, =20to=20abuse@mandrill.com.=20You=20can=20also=20report=20abuse=20here:=20https://mandrillapp.com/contact/abuse=3Fid=3D30504962.368be07599fc4a2893c4ac517d073408?= X-Mandrill-User: md_30504962 Feedback-ID: 30504962:30504962.20250310:md Date: Mon, 10 Mar 2025 14:45:35 +0000 MIME-Version: 1.0 Received-SPF: pass client-ip=198.2.186.3; envelope-from=bounce-md_30504962.67cefb0f.v1-368be07599fc4a2893c4ac517d073408@bounce.vates.tech; helo=mail186-3.suw21.mandrillapp.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org From: Stefano Stabellini On IOREQ_TYPE_INVALIDATE we need to invalidate the mapcache for regular mappings. Since recently we started reusing the mapcache also to keep track of grants mappings. However, there is no need to remove grant mappings on IOREQ_TYPE_INVALIDATE requests, we shouldn't do that. So remove the function call. Fixes: 9ecdd4bf08 (xen: mapcache: Add support for grant mappings) Cc: qemu-stable@nongnu.org Reported-by: Olaf Hering Reviewed-by: Edgar E. Iglesias Signed-off-by: Stefano Stabellini Signed-off-by: Edgar E. Iglesias Reviewed-by: Anthony PERARD Message-Id: <20250206194915.3357743-2-edgar.iglesias@gmail.com> Signed-off-by: Anthony PERARD --- hw/xen/xen-mapcache.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/xen/xen-mapcache.c b/hw/xen/xen-mapcache.c index 00bfbcc6fb..698b5c53ed 100644 --- a/hw/xen/xen-mapcache.c +++ b/hw/xen/xen-mapcache.c @@ -700,7 +700,6 @@ void xen_invalidate_map_cache(void) bdrv_drain_all(); xen_invalidate_map_cache_single(mapcache); - xen_invalidate_map_cache_single(mapcache_grants); } static uint8_t *xen_replace_cache_entry_unlocked(MapCache *mc,