From patchwork Mon Mar 10 20:43:04 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 14010656 Received: from mail-oo1-f41.google.com (mail-oo1-f41.google.com [209.85.161.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF2C21DE8AB for ; Mon, 10 Mar 2025 20:43:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741639394; cv=none; b=YEgUlXU5BMk7E5rrth79LNQpoY7g3MdIsUNi0a19NFOYEjBW9+4jQEj+IbtvHomBYDcJ9K9CUk85yNWENtlltHhxtQVndDRZmcYi6Pz6dUvmiFddHF+nmfR7GEUwDTH+Fs8RysaD0jKS23WnM77ycdnzJSI4ZVTBBG6bDvLkbnY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741639394; c=relaxed/simple; bh=0xf2lfBMlkwq8GDrukDrWvlzGt+OAqJxAVu2qGUaX1U=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=g87SY62xafoii3vmLphyYfMOg6/tIi8lF23Ayoe4PcsBInVTW6yaFe6QdjEGrP7PRrJuj8a749Vql/AXMrIe0+zKmwQslCKZHSJ9VyO8UP6FxknRzBwCF6QZhYbIbHkawwJAHeJdOvJ6I2KDyFiphhF42qAF6bAjc7apkBIq9Qo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=n6hqXagm; arc=none smtp.client-ip=209.85.161.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="n6hqXagm" Received: by mail-oo1-f41.google.com with SMTP id 006d021491bc7-601a4e037a5so829458eaf.3 for ; Mon, 10 Mar 2025 13:43:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1741639391; x=1742244191; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=epdj0pGglcLo1fb3QxJPZQv/lE+WglsZbV58ruZDnRA=; b=n6hqXagmka+4Nw0mNflqhQASedNuAW2+qwbRmRCHJlBVF+i5nNZW+qpNmakA64UrhS Ar/SlCFYpaKCmaTUaX6SBuvUi8EAsSip1URPpIQgOIePIuo1CQ5UjiAKz1X6Ae2pJefd jelbsfld/VB82/6WFOcPJIErttJEzUOprv9OskVwyKm02S/Mxh9CgLaGLdRanmoTz/0x eB1x66dzpBWwDAe7HbLSAJpqVMpHWpQ5ya/KWJHJiuAIjA/VlK1EFIyrQyiS4VH5hN2z uVr1Wk9LhuzzsuaypYD6a9d6PfobF0zUa2UEtPifSK7NIMMtaUTJVRwhltRHjwnlEIFs UAHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741639391; x=1742244191; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=epdj0pGglcLo1fb3QxJPZQv/lE+WglsZbV58ruZDnRA=; b=aOLArsCzoiUkdWRczq47q8qxtd6c8vUyzM255DhZwn645Pij4kzBHlgQ1kGAb2/Gwm GGfkelSHztcuQ1zGkzeN09wtVV17mX66Q6JIbLm9dbWRXEGv9qi2MKUJkxGvwzKMuoLv zCLcLat6gb3EoQD/wn2Q7CnSF2Eg8eeeHiqVeqCuxWaw1MWyLWhbx/1wNRhKemUL+J97 uMnwhplIIb8Gg69jy2ZLLPS5y0Au77puOErlGhMR/Ys3yNM3X/cJGiy+WLeYQXvkApks IqUe9mNTz9+eubuJFuSCpmBOsGfSpHdzvco03shn+V8TgO47duJz4v6LVTD3vJYgC8oF Z6xQ== X-Gm-Message-State: AOJu0Yw2N0YNS4W2+yk+fVZtiTc1gVZZKE96UkYiCSOJZA7Eg/Og0IZb 5jtIUsC/1EGXIemU6sN+4BrkQVIkb9NvNXHu50f3hDMMsq0iayL2AhjsgNIe+5s= X-Gm-Gg: ASbGncvT/pL5fmnQFRs1Dqd3jOv+YsoYqCsAS+qaO0fVA9ysOhQu21pWEAfERgE2hPz Oi5Cs+dmgjwRmvaPKubVWHDURNYTIW2UeAAuc0lJxi9ejh4lNoKODmg/p93rrmiuAZFu3O1gwkH iAMNUeiitsP3TARhI4ywLJqNbpTnzXywFtS/fl2w7yz39w7DTDLPcKFVIpemNYHsmGq2ObwR/Y4 HDqhVzqB9tEftGTs5djBcuK+uuga4YnDa5/43Cmo6e8qad8fz7X20iE40fJFf7S47O4yXxb9VxR K9zjC4ceJPn0d2agmqJREInjHjr1EgkwAtgAKcOD+cKUWYBdve0P3a8Y/tiiLXZIsx0OmY9sEEk SYt8HqWB4Dlc= X-Google-Smtp-Source: AGHT+IF3tmx1kGHFtcRxx4TOJ+aZvJTTIq2iqIl6c/KAO5ngljUPVei58WxV+MNvlmlbqMMyOLaJYQ== X-Received: by 2002:a05:6808:1b26:b0:3f7:ff67:1d9a with SMTP id 5614622812f47-3fa2c78e8e6mr559991b6e.36.1741639390752; Mon, 10 Mar 2025 13:43:10 -0700 (PDT) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f855f69b1asm764315b6e.30.2025.03.10.13.43.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Mar 2025 13:43:09 -0700 (PDT) From: David Lechner Date: Mon, 10 Mar 2025 15:43:04 -0500 Subject: [PATCH 1/5] iio: adc: ad4030: check scan_type for error Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250310-iio-adc-ad4030-check-scan-type-err-v1-1-589e4ebd9711@baylibre.com> References: <20250310-iio-adc-ad4030-check-scan-type-err-v1-0-589e4ebd9711@baylibre.com> In-Reply-To: <20250310-iio-adc-ad4030-check-scan-type-err-v1-0-589e4ebd9711@baylibre.com> To: Lars-Peter Clausen , Michael Hennerich , =?utf-8?q?Nuno_S=C3=A1?= , Esteban Blanc , Jonathan Cameron Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, David Lechner , kernel test robot , Dan Carpenter X-Mailer: b4 0.14.2 Check scan_type for error ad4030_get_chan_scale(). Currently, this should never fail, but it is good practice to always check for errors in case of future changes. Calling iio_get_current_scan_type() is moved out of the if statement also to avoid potential issues with future changes instead of assuming that the non-differential case does not use extended scan_type. Reported-by: kernel test robot Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/202503040954.n6MhjSsV-lkp@intel.com/ Signed-off-by: David Lechner Reviewed-by: Nuno Sá --- drivers/iio/adc/ad4030.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/iio/adc/ad4030.c b/drivers/iio/adc/ad4030.c index 9a020680885d93f4da8922e5cfeecc0c7ce23f4d..af7a817e8273496e8856a5ba1a9c2e66a11f0a84 100644 --- a/drivers/iio/adc/ad4030.c +++ b/drivers/iio/adc/ad4030.c @@ -390,16 +390,18 @@ static int ad4030_get_chan_scale(struct iio_dev *indio_dev, struct ad4030_state *st = iio_priv(indio_dev); const struct iio_scan_type *scan_type; + scan_type = iio_get_current_scan_type(indio_dev, st->chip->channels); + if (IS_ERR(scan_type)) + return PTR_ERR(scan_type); + if (chan->differential) { - scan_type = iio_get_current_scan_type(indio_dev, - st->chip->channels); *val = (st->vref_uv * 2) / MILLI; *val2 = scan_type->realbits; return IIO_VAL_FRACTIONAL_LOG2; } *val = st->vref_uv / MILLI; - *val2 = chan->scan_type.realbits; + *val2 = scan_type->realbits; return IIO_VAL_FRACTIONAL_LOG2; } From patchwork Mon Mar 10 20:43:05 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 14010657 Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com [209.85.167.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E1BE1DF972 for ; Mon, 10 Mar 2025 20:43:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741639396; cv=none; b=iUmjtxkrH4ohuUDouth5+CObCEb1Ts2gncdMv5EqvWaVAnSAehPVRyPJCwQeMATHoJWmHybuiW+ngsc+SSi9+XDjvZMV9/BqO0CMAfq81O2FJAELRteW6KvqENI5VRrZa81NyBv+ruqimvqGKqdBnDSOMLWL/hXGepoGcZ4pgog= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741639396; c=relaxed/simple; bh=+TwVZuYTQ79b6GanjN1EGzCICapQzRmhbxGUNH4cu2A=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=V/gEiz2bt+lvP76SSYsdVdykzrcRa2p1II2c0D+1CqeRhxFBvXN0+Ut1/NTfWkQ0T5vn4+BtBbzWENj5su5AruUuAXgM7cJhTwLqXdSiBadG6eBoqzUVqemqSYnRzPNMEePrpb0BvUU9qaK3fTtTWWnX/X1fVJgJlu8UFRwqYYM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=ogjHy6f7; arc=none smtp.client-ip=209.85.167.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="ogjHy6f7" Received: by mail-oi1-f172.google.com with SMTP id 5614622812f47-3f682a2c3c8so2365887b6e.1 for ; Mon, 10 Mar 2025 13:43:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1741639393; x=1742244193; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=/i1+yoCcGTJxasoeXpfqdr+aTaqF2C4mUZj0mRPSSrE=; b=ogjHy6f76y//+fUvR1oAMBdS1vmIRIcT4n99bWIGJXvQCc1Eku4DWaKybQeGj9R4Z9 Kerva0ioQI5XowMFk4hu9pEGcg4PCGtk3riEXP3/oiIr2P/9ZVS0XlTE8vmlUF6Wz57s i4F5RF8VES7stnPQ6cRsTRIqLMfVcIg+6fDa8nm0ozITEEdPsvLfFvfDlgrhKX+ADVnr 48qRB8ssMCEV8P/9RvLghST2qQOkoC+ZY3NJF4V7fmqSyy0F2X5pZ1pybjSWQaiE/CGF JqmqUUd9lKSnD7wUWfAzeVJCpZAdXFrp2PomCDxMe36JJOMAiyF2eP9jONbv4TcVQK0k NZow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741639393; x=1742244193; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/i1+yoCcGTJxasoeXpfqdr+aTaqF2C4mUZj0mRPSSrE=; b=wBv1SCmaBiRaTe3FDb53Y3qQ+exUxZTi/66otJX9zxrU/3P6wRMgjrLnpdXsOm60fX X4hIKvIIoOWsKBp/48RuzQE13ZDl4hapqfDwyWjPMBpOedlvQx9HfF7mV6pRBXDpgXmX iW8eJt5p8HmY+tpMXq28cVFp41AS95Ho1NTuKmiTz6UzKDt04uHTvEoQntGTHkCm5oH2 g/7MUuErP7Hz0hs0qQgbwEFcJ/BW80r2A6+bq1HaHl7eGVVkgEa58Tm43P3cJPa/DoWJ S4aZxu9WRptlVZq7jemJQTxCtXFvvUzzUfgvL33TMpkXAGSP5N8QSmGZnJacqhDEJLx+ Lbcw== X-Gm-Message-State: AOJu0YyNQK29nuTL+zCdSQhhI4ZLFPa9mXcNmeaHfWxDyXIMDAPE+/bv aAX2qy1HtkZIoVQGi8G4Um0hGXUzdZdLeFocfIBeh8IoAkx/ZHdTYlGpLQafGUo= X-Gm-Gg: ASbGncsYoBn3qTTIcRRCaG0BX2M5E/MGNQHNMCEkRWjFnaOJ8+IFjErx7o0I91fa/fV cCwrs29aiAcUbnOzgKw4psorjCnEjB45MX4xKw2wBYQJoOBhI0YDyuSP6bvnGDbvkqSt88ODfqv q/7MHTd6obOrJohW6gwXGwl0QhBdICOnGSXSFapMPbhCdytZ65rHBwligTGTYHbr2VbB58CMEzr mNq+6UeQS+lXvxeR2k+tOVluc9pJDQbwn1KjzlxrkFSr0sdZ2dFVoFoKz53JKwG4BPfLJLQIUBQ icXG6cncNIOqm0VVZGg+STg5AqKzetpvacBn2dP7UpRJGLfLorIkdtQRsqnTXIl65CYlUGxC32a x6kFmttdYpJs= X-Google-Smtp-Source: AGHT+IHBMhf/BYV0XxOJGMPZZruARQUkU+s6sttBVMMSnUfo+mtwN1idPSs1v7/aEHUiuzefAJwfrA== X-Received: by 2002:a05:6808:1b27:b0:3f6:6b64:665f with SMTP id 5614622812f47-3f697bb581bmr7694565b6e.27.1741639393469; Mon, 10 Mar 2025 13:43:13 -0700 (PDT) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f855f69b1asm764315b6e.30.2025.03.10.13.43.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Mar 2025 13:43:12 -0700 (PDT) From: David Lechner Date: Mon, 10 Mar 2025 15:43:05 -0500 Subject: [PATCH 2/5] iio: adc: ad4030: remove some duplicate code Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250310-iio-adc-ad4030-check-scan-type-err-v1-2-589e4ebd9711@baylibre.com> References: <20250310-iio-adc-ad4030-check-scan-type-err-v1-0-589e4ebd9711@baylibre.com> In-Reply-To: <20250310-iio-adc-ad4030-check-scan-type-err-v1-0-589e4ebd9711@baylibre.com> To: Lars-Peter Clausen , Michael Hennerich , =?utf-8?q?Nuno_S=C3=A1?= , Esteban Blanc , Jonathan Cameron Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Remove some duplicate code in the ad4030_get_chan_scale() function by simplifying the if statement. Signed-off-by: David Lechner Reviewed-by: Nuno Sá --- drivers/iio/adc/ad4030.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/iio/adc/ad4030.c b/drivers/iio/adc/ad4030.c index af7a817e8273496e8856a5ba1a9c2e66a11f0a84..f24b46164a477f9b6b5c93ffeba0a335f7b3de5a 100644 --- a/drivers/iio/adc/ad4030.c +++ b/drivers/iio/adc/ad4030.c @@ -394,14 +394,13 @@ static int ad4030_get_chan_scale(struct iio_dev *indio_dev, if (IS_ERR(scan_type)) return PTR_ERR(scan_type); - if (chan->differential) { + if (chan->differential) *val = (st->vref_uv * 2) / MILLI; - *val2 = scan_type->realbits; - return IIO_VAL_FRACTIONAL_LOG2; - } + else + *val = st->vref_uv / MILLI; - *val = st->vref_uv / MILLI; *val2 = scan_type->realbits; + return IIO_VAL_FRACTIONAL_LOG2; } From patchwork Mon Mar 10 20:43:06 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 14010658 Received: from mail-oi1-f170.google.com (mail-oi1-f170.google.com [209.85.167.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A08D1DF972 for ; Mon, 10 Mar 2025 20:43:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741639399; cv=none; b=rTY1CcODo2jfFFyhnckUSeH6SiTaZkHEtfIs9oMW6jVSskRO/FwyQC0DMXZq4udggtqzXj4OywzSVwuaG6pFZ8+q8MjBDorubQtr5gDzXF+CdOH1hsiyLCu5hp1rpUglZrygPWgfTXqPqECZRHrHH0B+0BHq/GAAOgFFl1wju7A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741639399; c=relaxed/simple; bh=u5ePsmfcDhDkeOwFNFmtVTRv9Rit4LfnW4jtEHfO+UI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=EhtP6BNifxLCbI+ShOVLVCrq2YqJXRhJW3Vqc7rWWZgYQR3QziUN/MCWLZa3aI2ths8EeULOk9KfvvomLwdDwyM6c0qUwp5FlLlM639H7ipQXXiy7VXWXpkGlWkhwZhxx8UKMns5Xfpo5GUc7a0a48bPLzlwXZwYeMiDVyqSKd4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=2QBWZ2je; arc=none smtp.client-ip=209.85.167.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="2QBWZ2je" Received: by mail-oi1-f170.google.com with SMTP id 5614622812f47-3f3f4890596so2532509b6e.2 for ; Mon, 10 Mar 2025 13:43:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1741639396; x=1742244196; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=OCuzGiRhkz0CBFkmeuLAdFa7ZCDNUYxNv2hZAmPEZO0=; b=2QBWZ2jeRvH+x2Yd4Cnq3fBFXtxl+lCa8ugpxYp0AlArhQ+9lNadxKS/s5m84keVe1 EqlzsNQknkQTsyq6OVq31gzv0HXvb1z7p4n+r4p33Yr8ZLS6bWDtPEEGlC4eIE2hgk+3 /XK1POM2Kt9QhYhHIfJ8Qy0/ZU/rWoPbrXcZvHFVKm23qOyXG26pGotVOqyZCXNVei2X rskPGKUR3K8uzwYNQpx30afgYf08dabGcvb5WNDqMYuDEpWjwBZ6ST+V0hzwlfSWgLLM DCwSNn1sU3PnKxOoA/8sF+CQJr/KuI8q6Wcx6a3egejludKKaWLsvzLTN2bRUhDaiqgF 7hEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741639396; x=1742244196; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OCuzGiRhkz0CBFkmeuLAdFa7ZCDNUYxNv2hZAmPEZO0=; b=uhr34ZFI7wis0FesJup9gH8XZV5iWQ68EhaRBxaartJUghwUC3RvFwStRTWFzyJL9p 5zeNYydSYKv6XL+MH2km+S3HqPr1aXFi2v8dzjXVuk9nDVwkXhljS5U/84hq4idwmama 0bY7NXL0ti4Mz0nfHDwBjVO6RvIx1CJ8Mv2wGjJYjIj9QAfcYtbIJHjogn2Cr+pgSuHb 3GKQgS8dwWOdYtBd3JLsHtpkIaw1TlZ/68PHIbPYUfqgI6bMMShspKLXcgpwC+ewFETe 9o0Ur9xrzYQeu/a6YXRfQNSOLqdeITP5wzRBf0MyEc15oacOVTmpWmbTxzu3nRfMdiVa y26w== X-Gm-Message-State: AOJu0YyF04eyUIDNC9kcioPxTdqWbL2EzL7WTKiJaWLCNSQrgGaPoBc3 qTx/Hzu0AE87fWNRvSRpKCRE9SH9rsIjpr9rsp87QpzpdygzKuanxLww9LijQcI= X-Gm-Gg: ASbGncv2P7DV1QWk6lI+oMNY7ckX4goUzsgD7RgTi806vk3a64Sw/vmsBTvlPUw2eEO hYcaelhlq1VRG9nLvtPtp7GIj/WEe5F9n5QzPIyOinYxibTpe03zdnUSuWpi8eWnEzz3jSPKTR2 bYfXs5LfLi1kpJy26qcdF9ZxmrLKrzV3uJYi2OWs7vPLegIZQXPlwM8/IpRhextP11xcr/ralUa lZJ3i61WLFrdrWNyCl5/Qrx5JWE095fhyrYEYgWkkwKOau8dQ5pzkfzwLh+0L+w8Vz+mVkYdoCe oDzpj2xY6tUkrtzmJkxK+EHImBnworvFy4wOhZBW9ndziURERT15pXetjamYLQ//vBfvVA+t+PQ 1 X-Google-Smtp-Source: AGHT+IFyOgnLNUP09CaNVpg3/60xdXC/GRP1hdw7pw4FVDHJLFomixKx8H+hEkS0rIe2cI6usE+vUg== X-Received: by 2002:a05:6808:384a:b0:3f4:1738:f804 with SMTP id 5614622812f47-3f697afe34amr8586223b6e.4.1741639396306; Mon, 10 Mar 2025 13:43:16 -0700 (PDT) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f855f69b1asm764315b6e.30.2025.03.10.13.43.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Mar 2025 13:43:14 -0700 (PDT) From: David Lechner Date: Mon, 10 Mar 2025 15:43:06 -0500 Subject: [PATCH 3/5] iio: adc: ad4030: move setting mode to update_scan_mode Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250310-iio-adc-ad4030-check-scan-type-err-v1-3-589e4ebd9711@baylibre.com> References: <20250310-iio-adc-ad4030-check-scan-type-err-v1-0-589e4ebd9711@baylibre.com> In-Reply-To: <20250310-iio-adc-ad4030-check-scan-type-err-v1-0-589e4ebd9711@baylibre.com> To: Lars-Peter Clausen , Michael Hennerich , =?utf-8?q?Nuno_S=C3=A1?= , Esteban Blanc , Jonathan Cameron Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Move calling ad4030_set_mode() from the buffer preenable callback to the update_scan_mode callback. This doesn't change any functionality but is more logical since setting the mode is a function of the scan mask and doesn't require an "undo" operation when the buffer is disabled. Signed-off-by: David Lechner Reviewed-by: Nuno Sá --- drivers/iio/adc/ad4030.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/iio/adc/ad4030.c b/drivers/iio/adc/ad4030.c index f24b46164a477f9b6b5c93ffeba0a335f7b3de5a..c2117c7a296f22aeeec6911c8a8c74ed576296a0 100644 --- a/drivers/iio/adc/ad4030.c +++ b/drivers/iio/adc/ad4030.c @@ -868,6 +868,12 @@ static int ad4030_get_current_scan_type(const struct iio_dev *indio_dev, return st->avg_log2 ? AD4030_SCAN_TYPE_AVG : AD4030_SCAN_TYPE_NORMAL; } +static int ad4030_update_scan_mode(struct iio_dev *indio_dev, + const unsigned long *scan_mask) +{ + return ad4030_set_mode(indio_dev, *scan_mask); +} + static const struct iio_info ad4030_iio_info = { .read_avail = ad4030_read_avail, .read_raw = ad4030_read_raw, @@ -875,13 +881,9 @@ static const struct iio_info ad4030_iio_info = { .debugfs_reg_access = ad4030_reg_access, .read_label = ad4030_read_label, .get_current_scan_type = ad4030_get_current_scan_type, + .update_scan_mode = ad4030_update_scan_mode, }; -static int ad4030_buffer_preenable(struct iio_dev *indio_dev) -{ - return ad4030_set_mode(indio_dev, *indio_dev->active_scan_mask); -} - static bool ad4030_validate_scan_mask(struct iio_dev *indio_dev, const unsigned long *scan_mask) { @@ -895,7 +897,6 @@ static bool ad4030_validate_scan_mask(struct iio_dev *indio_dev, } static const struct iio_buffer_setup_ops ad4030_buffer_setup_ops = { - .preenable = ad4030_buffer_preenable, .validate_scan_mask = ad4030_validate_scan_mask, }; From patchwork Mon Mar 10 20:43:07 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 14010659 Received: from mail-oi1-f178.google.com (mail-oi1-f178.google.com [209.85.167.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16F371DEFF1 for ; Mon, 10 Mar 2025 20:43:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741639399; cv=none; b=sbzU/ZWydYi1HivjAcWpO0YixZWp6UpAcW/gnjViRX5MR53TSN7YtssuFcQLwctEjTWUmA0FtVBoakX1pBg5kTTlaHmODHCiTYyvjlo0pJl0o9oLqL54QoeFjIcUbYCWIrSZhyrfoBaWIzVphqPfzBqKOXktxyjM8FGsYtmzBag= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741639399; c=relaxed/simple; bh=Hsc2lTWIH/R8fBT/8ZsO+EBhdL1BLa9dPLrp8/P/Dew=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bpXlwbjrkF8Zusy1+tpDZt2P+mA/5Cmu6Ony+KiQE9+zCdw1BJCXH+Muvd4l2+8FxNBJnW/OO9nkg5evthnjeUYdjUiU/ZjauR8GAElSbEgfLz8DfP0hE7wmzFt5Mu1tLg0cdBe6QbnaLVMmsgenFjWZAgg4O+CSImBEJfoTmzQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=J9QOgRqt; arc=none smtp.client-ip=209.85.167.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="J9QOgRqt" Received: by mail-oi1-f178.google.com with SMTP id 5614622812f47-3f682a2c3c8so2365920b6e.1 for ; Mon, 10 Mar 2025 13:43:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1741639397; x=1742244197; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=fJTMB/Yj7akGz6eUAqBxkpGJJmFrHVTQNNCjxXAAAoM=; b=J9QOgRqtmnBKDpKg2GVjW8tgLoTqw5QGLM2A0OdSA+U2f/ycjdk7+4YGc7apmZVrDq 7pq5BnufK7wh4WGTlXo85NcMxFMxqxMTZBjDiAtOY3b42uSzIkzO2jFUSXCxhz03e4WD 1jiyJIg9o7T9UrdBZV4DZoE6zrK3f4GIvQTZnU6S0POfWZkeNw1q9uGDNJlZo0UliM1D EZkJ1HR0bfGqmirAexTk59rBUzcW95GJOAzHmecs74R4+gF2/z36ISQHrIANJnMaPGu4 nE4Af/38SFZrz0s0vBZi5tgPrDiHrekD6FLTFUtLSYGr/h0rXrnFIAdcKC5cRLX3fMYG 8vkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741639397; x=1742244197; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fJTMB/Yj7akGz6eUAqBxkpGJJmFrHVTQNNCjxXAAAoM=; b=PMUMDIfGrs010qJoM0reoMpPwY/T6/reccYFaNoZQ2Zz8u1pbw0A72GGkyPT2If+2e TOlV/cIB6ZYfmw4uP99yLoSjbS6UtxZoLXDkUvZR5hvL+OqOQLWFhnae1gDm1NaArqVg JSQXYUDc+c1Y3fjk3OF/rax62CWK3Qm55m+GmJmhmZjRbA0CARnaI1V0OYqeO6i1nHnz deA3hMu58VmAkfOghadKBLLP/VCvQpT2ZJ04pZO2uNO5CSVv03m30s9aTbTp47GkJ/lv FW4y5qWDuQeGnlZGk9fUouoeHroUhj0kiHLm2yUVeQVvjrqjxKd988ROqqVSN4W62O4K ACjg== X-Gm-Message-State: AOJu0YzjISq216jqjraR+btykx2X+yZDESHA6PoMOCCj7svY5gLWlpWV IIlHqOgYBaDOGjknKES3gWsozO9JDZ8+bA/5rEWj3kWpFfulAJd6hM3hPDsSc7M= X-Gm-Gg: ASbGncuI18oPFsDeFZ7kTM/ypFTNTrFt2g9vlqwPUWyfaSyJYKp4RC2+86BWuLHloMk FUINQ+fsGgOgVLEjMftoeEV/58nkp/yrxIEUMixWSsixAxrOht3icHBi+g2+PzCKNoNX6DvM7gk BzlVKKrCaavEMEX2V5BwkoCT0PACgxInuqguahGWCoYA5AE3Nd0i6ui5+msjWX5u7tWG7MVQtzQ W9KeeuO0iAZ5tNzoW5ONzf1Nz9k/X9TrqeE6N4/EFrazDz6i18d2Nsq7ho14HBSkymIdpS2MlUz 4mcZ/fwN+xviedMq5/MHox8oco5YdSooBPzX5Si7AVlwR5TDCU89YtnhdN6qSXBOLp8KU2vdoeX VbA2Io5ZPRKU= X-Google-Smtp-Source: AGHT+IE/v8sgTJ1kpxF4TAz8lNU+kyH/TDaACDH4/rifKyICPd/DKFS6AuPRo2wZIJ/52GOdpWETkw== X-Received: by 2002:a05:6808:1894:b0:3f8:1df6:413 with SMTP id 5614622812f47-3f81df607d5mr3628760b6e.1.1741639397012; Mon, 10 Mar 2025 13:43:17 -0700 (PDT) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f855f69b1asm764315b6e.30.2025.03.10.13.43.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Mar 2025 13:43:16 -0700 (PDT) From: David Lechner Date: Mon, 10 Mar 2025 15:43:07 -0500 Subject: [PATCH 4/5] iio: adc: ad4030: don't store scan_type in state Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250310-iio-adc-ad4030-check-scan-type-err-v1-4-589e4ebd9711@baylibre.com> References: <20250310-iio-adc-ad4030-check-scan-type-err-v1-0-589e4ebd9711@baylibre.com> In-Reply-To: <20250310-iio-adc-ad4030-check-scan-type-err-v1-0-589e4ebd9711@baylibre.com> To: Lars-Peter Clausen , Michael Hennerich , =?utf-8?q?Nuno_S=C3=A1?= , Esteban Blanc , Jonathan Cameron Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Move getting the scan_type to ad4030_conversion(). Previously, we were getting the scan_type in two other places, then storing it in the state struct before using it in ad4030_conversion(). This was a bit fragile against potential future changes since it isn't obvious that anything that could potentially change the scan_type would need to also update the state struct. Also, the non-obviousness of this led to a redundant call to iio_get_current_scan_type() in ad4030_single_conversion() since it also calls ad4030_set_mode() which in turn calls ad4030_conversion(). To simplify things, just call iio_get_current_scan_type() in ad4030_conversion() where the returned struct is actually used and don't bother storing it in the state struct. Signed-off-by: David Lechner Reviewed-by: Nuno Sá --- drivers/iio/adc/ad4030.c | 24 +++++++++--------------- 1 file changed, 9 insertions(+), 15 deletions(-) diff --git a/drivers/iio/adc/ad4030.c b/drivers/iio/adc/ad4030.c index c2117c7a296f22aeeec6911c8a8c74ed576296a0..54ad74b96c9f256a67848330f875379edc828b0b 100644 --- a/drivers/iio/adc/ad4030.c +++ b/drivers/iio/adc/ad4030.c @@ -147,7 +147,6 @@ struct ad4030_state { struct spi_device *spi; struct regmap *regmap; const struct ad4030_chip_info *chip; - const struct iio_scan_type *current_scan_type; struct gpio_desc *cnv_gpio; int vref_uv; int vio_uv; @@ -562,11 +561,6 @@ static int ad4030_set_mode(struct iio_dev *indio_dev, unsigned long mask) st->mode = AD4030_OUT_DATA_MD_DIFF; } - st->current_scan_type = iio_get_current_scan_type(indio_dev, - st->chip->channels); - if (IS_ERR(st->current_scan_type)) - return PTR_ERR(st->current_scan_type); - return regmap_update_bits(st->regmap, AD4030_REG_MODES, AD4030_REG_MODES_MASK_OUT_DATA_MODE, st->mode); @@ -614,15 +608,20 @@ static void ad4030_extract_interleaved(u8 *src, u32 *ch0, u32 *ch1) static int ad4030_conversion(struct iio_dev *indio_dev) { struct ad4030_state *st = iio_priv(indio_dev); - unsigned char diff_realbytes = - BITS_TO_BYTES(st->current_scan_type->realbits); - unsigned char diff_storagebytes = - BITS_TO_BYTES(st->current_scan_type->storagebits); + const struct iio_scan_type *scan_type; + unsigned char diff_realbytes, diff_storagebytes; unsigned int bytes_to_read; unsigned long cnv_nb = BIT(st->avg_log2); unsigned int i; int ret; + scan_type = iio_get_current_scan_type(indio_dev, st->chip->channels); + if (IS_ERR(scan_type)) + return PTR_ERR(scan_type); + + diff_realbytes = BITS_TO_BYTES(scan_type->realbits); + diff_storagebytes = BITS_TO_BYTES(scan_type->storagebits); + /* Number of bytes for one differential channel */ bytes_to_read = diff_realbytes; /* Add one byte if we are using a differential + common byte mode */ @@ -673,11 +672,6 @@ static int ad4030_single_conversion(struct iio_dev *indio_dev, if (ret) return ret; - st->current_scan_type = iio_get_current_scan_type(indio_dev, - st->chip->channels); - if (IS_ERR(st->current_scan_type)) - return PTR_ERR(st->current_scan_type); - ret = ad4030_conversion(indio_dev); if (ret) return ret; From patchwork Mon Mar 10 20:43:08 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 14010660 Received: from mail-oo1-f50.google.com (mail-oo1-f50.google.com [209.85.161.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4A731DF268 for ; Mon, 10 Mar 2025 20:43:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741639402; cv=none; b=gY2BdMIH+S+gZySKa0aaYiNPo2lFjdp5nHZIqpH6Cs0lyWGcEpcvw1GJmTpAruWmjOVo3+HYxt3Dhv5atjTmI+XyJHKN3qv6plHIM1cLxUALxBhURhOMMks5mpwo8HuPbPqKtbksDKivg4QjbLJD3kvET0eVWX9YXsPuM4wwsOk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741639402; c=relaxed/simple; bh=fy3YCEIhYXyfAtQCLfJyFl5dLmJOK0fZMwPIbAJdXh4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZdqbcVfn5xVwEniQDNkL3m7J51Vi5ODYGiDhS8nOKagtM44Z9o36GbjdwccR1gMSKvRn/L7/+GN7ISqthkCRliRw5bFlMb3pTkscUu/kQ5sgMoFZp3ByELYg80jLouDglHQQcVPU4e79BogudfuD1Tt1gOjostcTuiA5x3370do= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=gN4ONqFq; arc=none smtp.client-ip=209.85.161.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="gN4ONqFq" Received: by mail-oo1-f50.google.com with SMTP id 006d021491bc7-601a8b6c133so670483eaf.1 for ; Mon, 10 Mar 2025 13:43:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1741639400; x=1742244200; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=J1AkfraDMLpclf5PdJvYaweOQN0fYlysTRqs642bX38=; b=gN4ONqFqXpCZXYZa1f04VYSTCT1ByZqOjVf0zFSLbuSlq8bhjV2K2w2u69iYnsuEpC E40T7+kIbg1abNLY6P5PL8KcjfNBbY149mT/3EY4ZyBrIaJgCsP8uzI1YS7I0mB84rey 1RvzP3jWSmh+alAbtP9WEYy+hnKSbmpQDvP3WQ0Rcx/2t/hxLMdMhsnZZcDfIpxbP/vl iUe7XZVrGv5WKHmgm4HBh9TRO2hr/xlnsv81eEAPzkyN5uODCTLxmxpiw3z95qR/v/Ld zZRYS7YB6pa7dEum1UEAhxdiH/WWVnOGnmKDiNf1hMHy2Q9uAfGraGynpGDYSPRcHXbc XRgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741639400; x=1742244200; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=J1AkfraDMLpclf5PdJvYaweOQN0fYlysTRqs642bX38=; b=Ehbb14OOD0qUTKTcWBGhdeVIZMlN5cyc5rwCslPFltjpbFy1K8ra+T9/O0Q1MS72/C YYe9MGGNjAhQTqvXe26FGrjn4MwhdmWZrL4Qi/JBgNh4FeCcpQKW/H74fN0fRdS6WwQ9 cm2u76Ujb95mLKY1xsLEKW7nDHKBbOJaZX86n9YyJXNNn1tdK2W9Xb+Sppx7MHFmHrXq IbtHTcWEhPM/lHk1Y+V5ZvDy3WPu/WR1d4C83lN46RoUnz5UI5pq/Fe42WLiE7NLcWGF fIaFL61lmd2IKZGFnqL09AoF05E6oxD5usmieGfLjGjf99Kl84yfut8n8GgwnT2VvmGn OEpg== X-Gm-Message-State: AOJu0Yw9atYFlBiykxdORvKzaB5yNl22YKc3IzfeokwRYHVjAauN57C4 G3HDQEjKfa2tgv3dchXfwyRyq7HBB6jjVpysgpNk5b774xpnckoeKgFK4fxZ8LQ= X-Gm-Gg: ASbGncuGjakJeNvrnGo52HAnUbOKc93gf6Jcu99KliCfAPVyHWPh/iceqBEevbxBsVL 13mPcW6XI0dUl1lJMT1i/fNlspeZBpiWXTOngovBJio0sbWyAEApEMtyh0jF3en67EAtcmMvhkV dOR5t4UjovjremeARMBfZP3Hu6Wdlvjc0obUcSPpJ5gZ2lgsPTVrxupbXE02ou1vmX37jc7ogme lht+K54Taoz8Mloahxj+TXztocTvJijQ5NSvtyx1Ei4VdDx5+ZGOEIs+d25jpKdgzWHA0jlMvbG Umu3JcCv0MdjwKW/Jff6VZbv9dC3OSyeqE4O9gdf8adgkTEW9Pl057zMytPNHzlG4tpy2m4fUyA s X-Google-Smtp-Source: AGHT+IFjnN7xgqA5S6WxW9zh3aoenUjvYW1xuLxTRrObH49wacCSqx5z5F6Kj5S5n7YLILh9oajgoA== X-Received: by 2002:a05:6808:4448:b0:3eb:5a58:9b6b with SMTP id 5614622812f47-3fa2bdc5125mr556668b6e.11.1741639399765; Mon, 10 Mar 2025 13:43:19 -0700 (PDT) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f855f69b1asm764315b6e.30.2025.03.10.13.43.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Mar 2025 13:43:18 -0700 (PDT) From: David Lechner Date: Mon, 10 Mar 2025 15:43:08 -0500 Subject: [PATCH 5/5] iio: adc: ad4030: explain rearranging raw sample data Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250310-iio-adc-ad4030-check-scan-type-err-v1-5-589e4ebd9711@baylibre.com> References: <20250310-iio-adc-ad4030-check-scan-type-err-v1-0-589e4ebd9711@baylibre.com> In-Reply-To: <20250310-iio-adc-ad4030-check-scan-type-err-v1-0-589e4ebd9711@baylibre.com> To: Lars-Peter Clausen , Michael Hennerich , =?utf-8?q?Nuno_S=C3=A1?= , Esteban Blanc , Jonathan Cameron Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Add a comment explaining why the raw sample data is rearranged in the in the ad4030_conversion() function. It is not so obvious from the code why this is done. Signed-off-by: David Lechner Reviewed-by: Nuno Sá --- drivers/iio/adc/ad4030.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/iio/adc/ad4030.c b/drivers/iio/adc/ad4030.c index 54ad74b96c9f256a67848330f875379edc828b0b..636f9f33e66af73d102722b984dc1230e1417d1e 100644 --- a/drivers/iio/adc/ad4030.c +++ b/drivers/iio/adc/ad4030.c @@ -646,6 +646,12 @@ static int ad4030_conversion(struct iio_dev *indio_dev) &st->rx_data.dual.diff[0], &st->rx_data.dual.diff[1]); + /* + * If no common mode voltage channel is enabled, we can use the raw + * data as is. Otherwise, we need to rearrange the data a bit to match + * the natural alignment of the IIO buffer. + */ + if (st->mode != AD4030_OUT_DATA_MD_16_DIFF_8_COM && st->mode != AD4030_OUT_DATA_MD_24_DIFF_8_COM) return 0;