From patchwork Tue Mar 11 11:34:29 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thorsten Blum X-Patchwork-Id: 14011548 Received: from out-178.mta0.migadu.com (out-178.mta0.migadu.com [91.218.175.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6E20221F11 for ; Tue, 11 Mar 2025 11:35:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741692923; cv=none; b=YhdeeGNFV86/O7LIEwJ1PiLX4nbJIPnoNQI7bK0mo2vrJSBYoT+XAhbHMMY6QcWvoJommxNXuB2xTmOdXCnIrDkKZvh3KIWP3ObYKn7jHBWlcEjLgZrhl+n4aFNIPKaNsOieHurhSFlXePuKDPNLPL0WhMMXB+10x5arOYeG/vM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741692923; c=relaxed/simple; bh=Uhn507R8K/kps72rHsNEWrDzj3Jw8mZmyak4Q3dWwck=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=L37f1nq0dYBTEGC4II32PDsoIPZlt9dbd0pnNJqh3w6heQePmIIpqvbf9sVqskSpE44tX4u77/aA2f0qp+msQOuy1pq3rAuxMIdvtt0hazyoPDZnJsQKazi6reNfwBjljHkAcaGWMD52Kc1ZrbKT3lcmsy1XvBaMhOq9u3dPg7o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=CgaJMNd6; arc=none smtp.client-ip=91.218.175.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="CgaJMNd6" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1741692919; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=0Gj4AI+bThVGyYDQmC4PfVFErBgnDlOQcTWIIrTFHvs=; b=CgaJMNd6096l3ZhphIfcoI9NOMfyzrSYKAfKcZpx+RoU26i/cN9YOarTjfyylA5xfBZLAt QMUFtMObysMaHc8f2l63CnPu+X6gKdBS4StL/C8ufzeNVWcho+E6KJbSxomueoLrtH+4Tp U8lU06O85ttKJA2uIvhT6tX+3uUjLxw= From: Thorsten Blum To: Vishal Bhakta , Broadcom internal kernel review list , "James E.J. Bottomley" , "Martin K. Petersen" Cc: Thorsten Blum , Christophe JAILLET , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RESEND PATCH] scsi: vmw_pvscsi: Use str_enabled_disabled() helper in pvscsi_probe() Date: Tue, 11 Mar 2025 12:34:29 +0100 Message-ID: <20250311113428.496646-2-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT Remove hard-coded strings by using the str_enabled_disabled() helper function. Use pr_debug() instead of printk(KERN_DEBUG) to silence a checkpatch warning. Suggested-by: Christophe JAILLET Signed-off-by: Thorsten Blum --- drivers/scsi/vmw_pvscsi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/vmw_pvscsi.c b/drivers/scsi/vmw_pvscsi.c index 32242d86cf5b..4927c6a33bd8 100644 --- a/drivers/scsi/vmw_pvscsi.c +++ b/drivers/scsi/vmw_pvscsi.c @@ -25,6 +25,7 @@ #include #include #include +#include #include #include @@ -1508,8 +1509,8 @@ static int pvscsi_probe(struct pci_dev *pdev, const struct pci_device_id *id) goto out_reset_adapter; adapter->use_req_threshold = pvscsi_setup_req_threshold(adapter, true); - printk(KERN_DEBUG "vmw_pvscsi: driver-based request coalescing %sabled\n", - adapter->use_req_threshold ? "en" : "dis"); + pr_debug("vmw_pvscsi: driver-based request coalescing %s\n", + str_enabled_disabled(adapter->use_req_threshold)); if (adapter->dev->msix_enabled || adapter->dev->msi_enabled) { printk(KERN_INFO "vmw_pvscsi: using MSI%s\n",