From patchwork Wed Mar 20 12:52:28 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Durrant X-Patchwork-Id: 10861743 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8D4F314DE for ; Wed, 20 Mar 2019 13:30:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7296E29AB0 for ; Wed, 20 Mar 2019 13:30:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 66FEC299DC; Wed, 20 Mar 2019 13:30:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id BE0A429AA2 for ; Wed, 20 Mar 2019 13:30:18 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1h6bGF-0007fU-WB; Wed, 20 Mar 2019 13:28:03 +0000 Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1h6bGF-0007fP-Eq for xen-devel@lists.xenproject.org; Wed, 20 Mar 2019 13:28:03 +0000 X-Inumbo-ID: fbc60565-4b13-11e9-bc90-bc764e045a96 Received: from SMTP03.CITRIX.COM (unknown [162.221.156.55]) by us1-rack-dfw2.inumbo.com (Halon) with ESMTPS id fbc60565-4b13-11e9-bc90-bc764e045a96; Wed, 20 Mar 2019 13:28:01 +0000 (UTC) X-IronPort-AV: E=Sophos;i="5.60,249,1549929600"; d="scan'208";a="81121746" From: Paul Durrant To: Date: Wed, 20 Mar 2019 12:52:28 +0000 Message-ID: <20190320125228.36440-1-paul.durrant@citrix.com> X-Mailer: git-send-email 2.20.1.2.gb21ebb671 MIME-Version: 1.0 Subject: [Xen-devel] [PATCH] public/io/blkif.h: make the comments on "sectors" self-consistent X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Paul Durrant , Konrad Rzeszutek Wilk Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Currently the comment at line #267 claims that the value should be expressed in number logical sectors, whereas the comment at line #613 states that the value should be expressed strictly in units of 512 bytes. Signed-off-by: Paul Durrant Reviewed-by: Konrad Rzeszutek Wilk --- Cc: Konrad Rzeszutek Wilk Looking at xen-blkfront in Linux, I'm also not convinced that it would function correctly is sector-size != 512 anyway so I wonder whether this patch should go further and define that sector-size is strictly 512. --- xen/include/public/io/blkif.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/xen/include/public/io/blkif.h b/xen/include/public/io/blkif.h index 15a71e3fea..d7c904d9dc 100644 --- a/xen/include/public/io/blkif.h +++ b/xen/include/public/io/blkif.h @@ -264,8 +264,7 @@ * sectors * Values: * - * The size of the backend device, expressed in units of its logical - * sector size ("sector-size"). + * The size of the backend device, expressed in units of 512 bytes. * ***************************************************************************** * Frontend XenBus Nodes