From patchwork Wed Mar 12 03:23:44 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liu Ye X-Patchwork-Id: 14012823 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF1B5C28B28 for ; Wed, 12 Mar 2025 03:24:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 09F8E280002; Tue, 11 Mar 2025 23:23:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 04F7C280001; Tue, 11 Mar 2025 23:23:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E5997280002; Tue, 11 Mar 2025 23:23:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C7073280001 for ; Tue, 11 Mar 2025 23:23:57 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5D3BB1C8C54 for ; Wed, 12 Mar 2025 03:23:59 +0000 (UTC) X-FDA: 83211454998.22.75503C4 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) by imf25.hostedemail.com (Postfix) with ESMTP id 610E4A0014 for ; Wed, 12 Mar 2025 03:23:55 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf25.hostedemail.com: domain of liuye@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=liuye@kylinos.cn ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741749837; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references; bh=TSov1/hex+rIp7CTYkbSbtqaFWXB8eBFgSmgKN89q5s=; b=08lnuJJCbfrqDE7khXt0iSiTIJHdksjvh9htrmKlrrDJ8tCsuHeZK5jSx9F/Saz4P7W+cw ps9mf8I8Iw2ibWEKlsNbLlNbAfUcW16ATTgqs7TI4yV7zQbJhhjVQoHCgPJjPXZwHj0VYX Trb/TwhnGBPiSs3o49aCl6mCzMml/hs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741749837; a=rsa-sha256; cv=none; b=KdPoNedpm53oUSIiKgt7Cv+AQRUu18ncLeXtb5ziIMzMMwJ5f1Y5ccY9fNsB2jFVX/GJTy y7ap9RuGliZmCssQgs8aAkO6kgFdgNRtosJQCVF0PKWmWdIBVMuAwmvbOQCkSAxhkj9SSq di7mHqLQlVwv+OHoKCERIZ+uo0pVzyI= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf25.hostedemail.com: domain of liuye@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=liuye@kylinos.cn X-UUID: 6aae9be6fef111efa216b1d71e6e1362-20250312 X-CTIC-Tags: HR_CC_COUNT, HR_CC_DOMAIN_COUNT, HR_CC_NAME, HR_CC_NO_NAME, HR_CTE_8B HR_CTT_MISS, HR_DATE_H, HR_DATE_WKD, HR_DATE_ZONE, HR_FROM_NAME HR_SJ_DIGIT_LEN, HR_SJ_LANG, HR_SJ_LEN, HR_SJ_LETTER, HR_SJ_NOR_SYM HR_SJ_PHRASE, HR_SJ_PHRASE_LEN, HR_SJ_WS, HR_TO_COUNT, HR_TO_DOMAIN_COUNT HR_TO_NO_NAME, IP_TRUSTED, SRC_TRUSTED, DN_TRUSTED, SA_EXISTED SN_EXISTED, SPF_NOPASS, DKIM_NOPASS, DMARC_NOPASS, CIE_BAD CIE_GOOD_SPF, GTI_FG_BS, GTI_RG_INFO, GTI_C_BU, AMN_T1 AMN_GOOD, AMN_C_TI, AMN_C_BU, ABX_MISS_RDNS X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.45,REQID:11a57a68-89c1-4180-a672-f20610d247a7,IP:10, URL:0,TC:0,Content:0,EDM:25,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACT ION:release,TS:20 X-CID-INFO: VERSION:1.1.45,REQID:11a57a68-89c1-4180-a672-f20610d247a7,IP:10,UR L:0,TC:0,Content:0,EDM:25,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:20 X-CID-META: VersionHash:6493067,CLOUDID:845d2dae1041badea67863155d66218d,BulkI D:250312112352OQV2NXMX,BulkQuantity:0,Recheck:0,SF:17|19|24|44|66|78|102,T C:nil,Content:0|50,EDM:5,IP:-2,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:n il,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_FSI,TF_CID_SPAM_SNR,TF_CID_SPAM_FAS,TF_CID_SPAM_FSD X-UUID: 6aae9be6fef111efa216b1d71e6e1362-20250312 X-User: liuye@kylinos.cn Received: from localhost.localdomain [(223.70.159.239)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 867985988; Wed, 12 Mar 2025 11:23:50 +0800 From: Liu Ye To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Liu Ye Subject: [PATCH v2] mm/debug: Fix minor issues in mm Date: Wed, 12 Mar 2025 11:23:44 +0800 Message-Id: <20250312032344.297946-1-liuye@kylinos.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 610E4A0014 X-Stat-Signature: q6by53379j563kiforfwctgwrfnort3r X-HE-Tag: 1741749835-824899 X-HE-Meta: U2FsdGVkX1/lMt7myK0PUyIgSnaiCXTxuQaL8QOlQbIwMKh3bzCzsm0wxpR+BHBTyJPRgLtnPMZbz5/Nm/ntWbEtGcUtIK/pD3qBZHmGC45jjEkhYYp1U0ppw4wJLS8z/Fa41sTKoPNhDH5FkDeCKlKMm3RSRHEh8gYoY8CfhdNc48M9PGNP/rwRCuw+Qf3ht1OYM0FR0zV+XOgstIgQiAwOoBniytsorb7zb59HVbP8TtS8+Ne1uTp/tR14eXigwmKYumce5hp242fbiYnWP9mhNulqDiPMpZmRCDZ/dY8eoCgEANc2AuvWdHkfY8WED/iCA88pjQSFOQlFh2y0+BLUwOsQoiX6qTaKqHG96iADqwg6lkaEGrlnKfDQNEbKTuChfKqosf6I6jrhyifbGNJfR4f1yBbr13XCcUa7sLiZcfIlW96WYNGFNygD/VrZINKsq6EOtRidn3nvD847oIgguwqoj5xs+q0xZfPUDDrGybfaLw5bemSppYLCiBcB26wsV6P5fl9mocr8r30Arut3cJaf4H6xLulT2eiH9USF9WTCBgsrmkS9lhiF/S3ZkeuODiGHZdUwm215S/SqnYoBHt/9ShCbcMET0wzc+zuFpJ6cOL6Zbxl46hQrnkSSGU/VniaKcnAxU4JGSx3H6cyQ1Mm5lG8F9g7QPqhRbeL4EEfQo8ooimgFRseP5S3jZ7EykdneUxWdEBjKV3eJ9+2EL5IyX8qFEbpeKhDbzU+1BkW1GzKtjBsBSxwx84+9fEqHrAwHsqFQoyZWWChjGr4U4+8iIfyNq/2SgJWvedKw8KM9AIU5SXf/XTegDsE3YcjIjrfZ+R/odtI/PVOuGyt4dd75y8nC4sOV13d8s33GxdrH/0XcD5UuWglyaWvSFdZgOVXmk/p7Q1wSIABHnk4xhbIEWfQ0L2AbVSpOph3wzgCFpUPMSteoSzW6DQ5HldnMPOMC2OkFT6jvrHj 8enF+LRk XSLQNsbQI5L00YzA8yXZkGPKmaQ8K2Wj+uFpd X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This patch includes several minor fixes: - Simplify compound page judgment conditions. - Missing a newline character at the end of the format string. Each change is independent. Signed-off-by: Liu Ye --- V2 : drop Fix out-of-bounds access in page_type_name(). --- --- mm/debug.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/mm/debug.c b/mm/debug.c index 8d2acf432385..544b2b05c567 100644 --- a/mm/debug.c +++ b/mm/debug.c @@ -132,15 +132,15 @@ static void __dump_page(const struct page *page) again: memcpy(&precise, page, sizeof(*page)); head = precise.compound_head; - if ((head & 1) == 0) { + if (head & 1) { + foliop = (struct folio *)(head - 1); + idx = folio_page_idx(foliop, page); + } else { foliop = (struct folio *)&precise; idx = 0; if (!folio_test_large(foliop)) goto dump; foliop = (struct folio *)page; - } else { - foliop = (struct folio *)(head - 1); - idx = folio_page_idx(foliop, page); } if (idx < MAX_FOLIO_NR_PAGES) { @@ -165,7 +165,7 @@ static void __dump_page(const struct page *page) void dump_page(const struct page *page, const char *reason) { if (PagePoisoned(page)) - pr_warn("page:%p is uninitialized and poisoned", page); + pr_warn("page:%p is uninitialized and poisoned\n", page); else __dump_page(page); if (reason)