From patchwork Wed Mar 12 06:15:12 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Huan Yang X-Patchwork-Id: 14012889 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5343CC28B28 for ; Wed, 12 Mar 2025 06:15:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D7AA5280002; Wed, 12 Mar 2025 02:15:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D2959280001; Wed, 12 Mar 2025 02:15:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA2CA280002; Wed, 12 Mar 2025 02:15:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9ADC5280001 for ; Wed, 12 Mar 2025 02:15:38 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D5C3A160B20 for ; Wed, 12 Mar 2025 06:15:38 +0000 (UTC) X-FDA: 83211887556.08.20B5BBE Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2086.outbound.protection.outlook.com [40.107.255.86]) by imf11.hostedemail.com (Postfix) with ESMTP id 7210040002 for ; Wed, 12 Mar 2025 06:15:35 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=vivo.com header.s=selector2 header.b=afT6LRLA; spf=pass (imf11.hostedemail.com: domain of link@vivo.com designates 40.107.255.86 as permitted sender) smtp.mailfrom=link@vivo.com; dmarc=pass (policy=quarantine) header.from=vivo.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741760136; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=u1Ta+4nadU/IzGq3CoVb8kLCJv+JpgVC9Mb0LBeeeqM=; b=aYfXEAI4XeJZOIbvar7FWTc4ITd5etsLqcUAb567b7aZ3ZFhNhvRtBTH+VjuLezVzP9Vtp QpdhwnqbX2oOiV515tqHoodAcGA9bcQBgWEfY7Wue54AFPhr4oSkcGCMoGTGbY07ZaZZCw Ukc46JXoMYhnq1cNohkMbDxMlEeggtg= ARC-Authentication-Results: i=2; imf11.hostedemail.com; dkim=pass header.d=vivo.com header.s=selector2 header.b=afT6LRLA; spf=pass (imf11.hostedemail.com: domain of link@vivo.com designates 40.107.255.86 as permitted sender) smtp.mailfrom=link@vivo.com; dmarc=pass (policy=quarantine) header.from=vivo.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1741760136; a=rsa-sha256; cv=pass; b=SDGdipNDn7bNXPggN5WRUkJnkV9tAzRTXle+PoYk/+EtaHu+sc8low8mwU+cMrWOZieyh6 UL2+lZKuqTQFp4PEAAKHJmEym5+M5n1Oubz9M7uxpp6IKaULf6yoth7lVFClWQqXp96g54 MuWblG0EbBBcPU7UEVzHjo6cENuFJbg= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=imDQs1zRSZdayzDzY9CHOqEONFgIf7XRdcGvr8vCb6JDvzJYkajvZZXQjlTNhvvGZMC2bnk6qdAcc3Tczi9oUKyIfjNu6GElbe+MKdKs5jD8gRFNjzWKRZglw7/XKo6GblheTP686emE7isaQgRLhvq+SpE0NM5mfWXYi5DwmHxvmeF3kFzeSsROTzu1H33XSWG5tiRWsvSVQlAMih/jy6Adp+b4qZSVav5X34ZNyExNcK1N0bW8/jsUYSfopMDO2XU1m0jNOJUa9R3305bmgbYrIW4FqzPpxQ1FEjsw8jh7Hws6vpSA6wPnWWkCfMu5ChlXvUMyqqFEgRclV/s49g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u1Ta+4nadU/IzGq3CoVb8kLCJv+JpgVC9Mb0LBeeeqM=; b=QVyIDwrwGj6W3s9yxc/Ocly77vOK8PC2ztEZ0Ce8ymuabYzKOjK1pOrmFBwC+r/MQXC2CUo9MwMTILRIPcPnFQ+VIdMvuAquLeyOFMVUDFvA0aaXPlulFl+053Sj7MyX7yJMP9szfOPLr27Y63hhar9fbCi+KdGwRhsaKoc/msHh0okq/xPBMr8e5zVqcnccA4DF+AB3HyuitRLgadVp7aCOmjhC84yOclox10u41/Mhxbu5iVDTgBiU5ARep4zWEgNG7rFPXBd7J2FgBA3uJlmej0qa2CkMe95nbTEdGvmdQpgr5RlHbL97B7T1qD/3O61YHLNKxdPCxFIpjvkyBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u1Ta+4nadU/IzGq3CoVb8kLCJv+JpgVC9Mb0LBeeeqM=; b=afT6LRLAo3cI34nRDGA8i1QYvQjD8yL6OncOUjxbQ4PcBKKU15WgGGtam9J0ykIrW4u94UDc0zL1HGJ9lqBp/3g5jRAr2nNL0lJTmjYIFDXqJV3G7e75rubxeuA3nAig37q+J67zRXLFbJsf6CaKsbnTQ5Lz+aWuU9vq/iJWZqbNR2GSBKip6uS/OG0YfWfJYYh926eAqQ/BsxebsE5yQf7ruPRagCi3Q3jIu/a9WGn6Y4XGlTyWBkv+CMYji2tRwvR8tYZBpRGkn6rUJj/x04Jf8+ADTWlhpSMhROWMkEec7wX1sKwPT4m44TLuwMkWwdY5VRDBXbbGLzk/2TyAkA== Received: from PUZPR06MB5676.apcprd06.prod.outlook.com (2603:1096:301:f8::10) by SE1PPFA7A817EB8.apcprd06.prod.outlook.com (2603:1096:108:1::424) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.27; Wed, 12 Mar 2025 06:15:26 +0000 Received: from PUZPR06MB5676.apcprd06.prod.outlook.com ([fe80::a00b:f422:ac44:636f]) by PUZPR06MB5676.apcprd06.prod.outlook.com ([fe80::a00b:f422:ac44:636f%3]) with mapi id 15.20.8511.026; Wed, 12 Mar 2025 06:15:25 +0000 From: Huan Yang To: Andrew Morton , Uladzislau Rezki , Ryan Roberts , Zi Yan , Lorenzo Stoakes , "Mike Rapoport (IBM)" , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: opensource.kernel@vivo.com, Christoph Hellwig , Huan Yang , Bingbu Cao Subject: [PATCH] mm/vmalloc: fix mischeck pfn valid in vmap_pfns Date: Wed, 12 Mar 2025 14:15:12 +0800 Message-ID: <20250312061513.1126496-1-link@vivo.com> X-Mailer: git-send-email 2.48.1 X-ClientProxiedBy: TY2PR02CA0049.apcprd02.prod.outlook.com (2603:1096:404:e2::13) To PUZPR06MB5676.apcprd06.prod.outlook.com (2603:1096:301:f8::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PUZPR06MB5676:EE_|SE1PPFA7A817EB8:EE_ X-MS-Office365-Filtering-Correlation-Id: ce612d59-78b5-4616-4fc8-08dd612d4740 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|52116014|376014|7416014|38350700014; X-Microsoft-Antispam-Message-Info: PZUCbgrRu1CuUbZdLL7b0uRJGSFjVxGqqeloAxTDs6VjGHou654RWFoHqxZE7Rvh1AQqthi6LGFU9cRTirwCKIPmjCVujqWbFzwWLLyDCTSF1V1h8Zl8proySPuxMYPhSFG1dKN7yKT4TqwxUJMMF0yufj6aMUPm+eTHQmHQJA5J+QF1W/OeAdE1GXV6gJET3RUJ39zl6Sl+Q2Vs9/uNIskgK2sr+uOYNn9LuBAED/jDC8HzldEpPiXp7o3iKtkh2SN4EoKvJY2kjS1J87NujgX0S3KUPJ3r2WLUB14M9o1X/iTjMy6W36wpCutac87LkNSita81WSDN4UrBHQd82+uRKBefLJjJItm95EVa/juBOwtviSempEUqExINdtV07QlDbk7RmVxGrXBvSW/izN68Ty6jBvM2lfppU8WiooJiHcmFxZZ/XU/vVbj1xRqJGblcUi0OeTgtea3E0xjCHIK3ImbqBtPF7gOsvJiLAhqyY8ARkB0vQAGNd6Jmi1dd5AR8EeH+eTwHtwKmzahEzCsak8YZ+od70546ku7Cg+b8vokvpFnhu5catcqOE37e5u14hXvHAL/CeC4MCoxLPi6v8fmjL2MlBWSJjo8haVu/jB1uBKL1/VjJu1WE05/x6N1kyM2LQQFqxy6BmaYlhY/h+HKe3BBW+lxbUF043kmTc1akHe0HsSzT3I14wxMmPB4pIvu2tlBphLZi5yZHlAGXnWxsMqrpSUSfeqBbYVxk5uvp7DK8v6+E0L/THI63zG5e/cPPqiSfKtMHLjr5DlLyGgYXDJGrpMF5NyRR37zG8d3ozobZS6w2dmLKaf/kOMW94KDtps2vKkyNUid6OTmM4vJe0AB8CGl6GyIVWxc08+iODCwKD/ZyfW0U7/OhR/q9ll9x3Iz98jf5brJaoFA6yLuug8Jxhz3aQdX7QuxKW7WW9gIW1ARprZGticFNcljFdeRTc+AEKh6pH7WWX+6YmRrI+xtMGT3IwnGE1CjqpOOreJ7RA6tNSIUpPxuhcnyiPPwBa4MOaKX7/9k9diCt6AzMwl5xL8jqcih9A24ndq0JEoYfSU+Zy3b9B6nw1fWVTJ3bYi+ZKssiiWiCzm6U5R7y2FLFOnHvCtIkjclrPq/p9+i+gqRB6DELUkgcjAiMbr6wke4uiN/4JTDYZO1mf9V9VTV0EEPFZQQjccUxcJtOOb753oeXaiVMHFiQrMNdgIt4whAWF7y+8j6Kp/ogJtZih/Is4LOOdh0tg7D0tbaMCemuWjlHATXv0mBjUioxEXEWX/L+1DXS6GEKH79AL8b7xntFGtvEuYxROppF+bAdP1vbHMlzXKCI1aDoUW7ktnypd48yFdCMBJ3qoRufkGgTKV51v6V7bh/n6i4zroSE/b1ShqoUKsquW+eJ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PUZPR06MB5676.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(52116014)(376014)(7416014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: PlqayNrlchJfS9jvZve8wERI/Lj2zj/h4eRbiozPjSRWHaXW7dtyTDvM6/IEMql71QGAC7hEgq2ORk+VcOMkDSPmgWPIX/uhQwBhJL7Wq9uiCu6CVpUVreDYuz760N7O+Lk/wOzvdlzSm3KMGODVxN+/3QLGf7ZrpkPLR+54rFReXSsXXQOU/DrCj20C17P66lNPqnOXxqYJr0erAJ5kxx56XBz7DBOD6zNDw34k0DuSd+DpXI6rfy5VR4uNYuKs4jqSDtY0pdSCQYNQMC+UymMvJuKFC9PbuGWcYsPpnZVak6KjcxGVHhKCyqmmsRWcr6sg1iWSkqkKlmOY8lL0UzmfogjOXNjK7IPe0QT11i88Mgm3bH6wr9XN7/COEDVelJX6VjXy2rJW2UOp0n2TqZxmqmeHpPi0+XqrrUI0/kXeB9mnzKMWWysuEWJZ5h8tn0MClKvkxVl9EbFjF5nfYdeTUz2kULvkrETpGUvhxbWkhp7jPIYXJLt6U9JbjHEfezSapqU7DM4+hiYRHvRxM+jbyIIGiqZ48PpRgrVd2ACVNtoAaKpsTNmEk2eZmSVel72uDmHDyFNPCrtTin4iI/tDd5Ky6z0XzU9CWloumNze2WTOc5Wrg4fAjdWufIdt2+rQl4tpLTXoXV0nVP9SMXaKvUwbgKioj6bIEyplXtujiFgaCQgwAle2cdFIxD47NYIcf1fh4x7FK0iS8buQjRZ3k2wAJ5l1qcA3ni9VosUIHVdGcmfk/lqbR1LHFG2hSL5eADT16hR8os+LqbBR42WOq+v36ZWIuCdqGwsGBS7GjOwQ+IhQOBRbe3sHvDz3wRH5VurpjUCTShemeeWC24p1sRyjWkfCU7Vc+1WYQAqmLIsVpbg6maCGFJ45oB9jpcOw1NC37t+gE/ZMBbLtgOXnd4bE6olWUiLgHzCS5SIbju6Dlhxj3PLjhVGPSRkh3gQjtKLZbQlhR/yFJr1ekV9Z9RhbW0Zi/tss/d5Wq8BZAl6s4//aDBDgnx4Um7bgGKMB1TyVSX7RXQd6+Fq3oHKIs6BaCBiZ6OxaQrcv3entPkKGFxmbM+moDkxV+iYzu47HYAFwevuCU+jPn6TSGLMZSB3KHedEpLzPs6KbW4fsPimmgxwUqlqQNx9bMoWNYIWHG6BZJ6jyMY1Jxj98/IRFGzjPbPalam+TvXnH/Ff6QyXGWzTBN4og9LzO7ysouo06cOiZGYmIp+g79GNQEiUWtUfT+1tTH1Pfm8c6RNQ5OSI2z+ER+tmxmIHvx307uSOb1npjtO9C+qEiZSnqi6s1KaSHoaPqQ0iQq5kF8b61d55dW7KatX1r0xzgzerkxts56sJhkaRPClPoBkyG1hx0XLbKwW+eHCAH6DF451WxxDrywcyr9ZzSpHLfxagd9M17oB6nj74G8Lh8uS9Hbk4p/Wp6RxKbY7YFl/1s17VBuPIxxiGH40HVgfVr641BYQzzXcj6n/fcjAJ0XoKeVK3JOjMB09FnADhzTqw+7BW8XbWJfZ1zN1XTeHxFP/Ga5tb5bPDrGS6dr89Eiu2S0nLSYSABopb83/0kDrwd6bsjLt50nookiKDljr/V2Xyw X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: ce612d59-78b5-4616-4fc8-08dd612d4740 X-MS-Exchange-CrossTenant-AuthSource: PUZPR06MB5676.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2025 06:15:25.6210 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sIkZIhLXWvpsCxMdvm3HGw5ksGyxZO0uqZj8WCvzNxiVaT96uU1zecK4Adwf4TiFazVM0+tXUGXPxm+ssQcyNQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SE1PPFA7A817EB8 X-Stat-Signature: 4qrcjn4foozqssarcidmo3rd7aqqesnd X-Rspamd-Queue-Id: 7210040002 X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1741760135-72598 X-HE-Meta: U2FsdGVkX191o2IodSxGeOmqXtcZ2bF0vtIHEIO4Wm94AKuxzx++GzgAjGAa+10d5kDXXkRWbIvWw7Jrr6XBK9WQh2C7Hc4JWycTPOEd15eCWg3O+izFCMjIjPeezjFpTYo90uMayhzjkudDrcfg5ECqT9j9xV+tAzpdys2YTchACn2LD/WL8kvt1XSSPT6dRgi8sZzxMIZ+KqjaKJjrgwAx8UTGwsZMxL1UAYzbri1ssxtogko7qSb8Cz5WD7m+RAmq9jsruudHtpBq6/7TVWtvMapafK2P4KFrGhXGKAo7z8TjX8jG2HhlEKrQtFRn7LV6wYa7uBMFcFOMnwbX91gVKujsjmQ5fKuNk0/3NZVWgxxPjw2jN7g/O3pQ9QJ8VCpLOzURvhRCUcgznMWekGXysuz0erJvk6wqa+QFc2k3xa/4NJ4yABsDP0MBGU9JTjn2I5boLVNAgzBgOZFjmJLxQv7Kmy29J86Or7tPrR9ESCB0kxvTUuLkPYPoXh9DUynA2gHI8vnEkD89qAyI3HWQFUvrb25RYO8USRDqErCgLAZ78ve81VWxNdHiSOPLmTDOjFJENlM8GGr7F6wc0JEWFIH/pjE7MpPMO4vLGy01GtgFFCu5ZR9eqQcJQ6al03h/YkFr4pDqIoXXpphKFyygJ1OzOx5H5Smf2J8eHmpXJC1A/piq1is1M6D8EJG/Be/Oy9XvK/f/thbSv8QxW/EI9mXGLXaWfqKP42XEkGf7ucDkaeXJ8YDUyQnAUWjhFij5YxJ+OL66aChI+iOGn+sWZmx+iKueDWvj2Il1sh3TCeDNxy3y48IyWp3v12PSwvl3SAkjr9YxbSPDQbDB8l3k0lsC99nut+jNE3/A7VyS8Qw3HGqdz9imYlCs0KZEDV/sxG+/bW1zHdnzVRwSMOVXyxdZcFXIxebK+olupfGBr42rFOYlw9EB7rjX9uVrrWF73rCFsNqyWuVGKF1 3A/JAU4Z L9f/PYbq9os9uGBKokBfdhcMSVWtUh7shlK/DSjEAAsj4IK2lt2IZjgwzq7FkHtZ+qmMNibsp/Yeh9oQZVroj2JrRAGut1gctsTrhoBcR0rE/F1pGLNpXewshUG/5vvPXwtqFG7goIc42YtgM1v3lzAb4K3gNDnXM5Y/uKtQWd9eyg6v9LZVyy+q6sxtPekx3mTQ5TEIoW9Uw4WqecA7zUN1/KwDvd3cVlwofgGPqsV7saMyztjX3otZ1FlXbIMZMRfIBxDP4n7yc1cxdXocyBfQ7PQsjqJ4tA3Qa1SVQNvvScYLDz3DLPBh7li0+tEH0CdM5Ctz3r7O00j1u7mgY1lVGv6o29PeprpXdYQ1PigFOha1APTEbEZ2QwIVbLI17xPTpHvnu3iElCFIoDnNtpLNT3KzzZdeteK9ovynHYXReBKHL1c+OpNzByqv8oAv8L13avsjZC1TBM/UNo74xQVjq+BfiEhEiMQXkwb6U1+qApbPM1PJXPgqzc/JXRTYigCkTU9x2d9sGLlpnbAdiIaNtwdgPjaifFbS7aQyEKevx3xwbZRqzoyLczVWTu2lkvadjf2oL3vtMCz3UAqpYsV+/kA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000063, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: When invoke vmap_pfns, it call vmap_pfn_apply to set pfn into pte. It check pfn is valid, if true then warn and return. This is a mischeck, actually we need set a valid pfn into pte, not an invalid pfn. This patch fix it. Signed-off-by: Huan Yang Reported-by: Bingbu Cao Closes: https://lore.kernel.org/dri-devel/eb7e0137-3508-4287-98c4-816c5fd98e10@vivo.com/T/#mbda4f64a3532b32e061f4e8763bc8e307bea3ca8 Fixes: b3f78e749865 ("mm: vmalloc must set pte via arch code") --- mm/vmalloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 044af7088359..ebadb8ceeba7 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -3488,7 +3488,7 @@ static int vmap_pfn_apply(pte_t *pte, unsigned long addr, void *private) unsigned long pfn = data->pfns[data->idx]; pte_t ptent; - if (WARN_ON_ONCE(pfn_valid(pfn))) + if (WARN_ON_ONCE(!pfn_valid(pfn))) return -EINVAL; ptent = pte_mkspecial(pfn_pte(pfn, data->prot));