From patchwork Thu Mar 13 02:19:49 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yury Norov X-Patchwork-Id: 14014218 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2FECBC28B2F for ; Thu, 13 Mar 2025 02:20:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GCxvFZSfMDu5NNSQzBR3YB/0huyXmm5OU83X+xlFEVQ=; b=yTPkuQvPjHEYDM 5BsUuEK4dPI95Qb7MXG8KXa95DsfvVTf8JR9766hypN8wh3agoP/ha/BetGxHibhAMPpufQASamo8 sroy8sacd9Bq5EOsEliK9hzThd/VxOq/HTQTjc2cIKWsv703sQFWJzO0tMoSqQL/5Ob/Qy+eWt9yk TnTwnGh/H0aILeYypJDjgiOoEOh8XD9rXRvngHV7Zytqw1S5nLin/vEqC2ZaL9zDEbsxmzAjhcwjc 4iJUkf6FFehB81FcM1+TXpqKpllpjg9iW6ZltjQDY0bt89aG1x1YYtf7CW5ddhqZKuyNAvdKPpX4F lF2U7E6ssG/nSJbN6bnA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tsYB1-00000009uso-2J5b; Thu, 13 Mar 2025 02:20:03 +0000 Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tsYAz-00000009urq-0vt5 for linux-riscv@lists.infradead.org; Thu, 13 Mar 2025 02:20:02 +0000 Received: by mail-pj1-x102c.google.com with SMTP id 98e67ed59e1d1-300f92661fcso847434a91.3 for ; Wed, 12 Mar 2025 19:20:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741832400; x=1742437200; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rM07y6mRejtfGVMen1h/wSs59kI5KFRRXlr+zYZ8+Iw=; b=lqKYUGJR1lOtcnqHHneIF/fAdspzVU2dhTLLIwWwurN/nsuS/AdGNX0iCQ8BGi3QDz XLq2ayVBcvv5iBw3iVi0bHEzJYAUW8ecfU9BNqUva3fRgAO4VEy6gv7YhnMyPPglGz8U T4G+wNREW5x+lIEAFxYOCqbVx2IAUKUMnPnPouXNsB4dQ+OrTu79u75OHQ47bJxKLoT0 ihg3YIiMT8Vmpihc20epVxIDuOfU44KtkpCJBefw3HxjmfncE/k9eGVXgbdQNlC62/yX rDtsRgUZndvTpVH9ckR6dzdq6SALnTJUGXGdgQydBvVSP++ImC58HGxIGOpnfT93mx/m TKlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741832400; x=1742437200; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rM07y6mRejtfGVMen1h/wSs59kI5KFRRXlr+zYZ8+Iw=; b=hgxTFfQpAAzvCU9ON2tFN5yg7lPw5tqCHocO34+avVgVC9g/RG+u6lTfxW7wh+TEVQ G8tDWNBii/DdEyiZhvPdyPkoSHRLpPojeJRzaGOuqMVTH9QWUjYruqY7IjipoZw3mvMY XgJIPb2EFyEAz5cEn8/SGQ2A6F8FWFQkKlvVxgOgh5D+7KRQmpE3fqTdy0ECbQ8OWVHL WAYflBn9x7ZBpKvSFeZ2lizEM7OHZaCfGvzHGQ3+kjbQpXIrOj0RqfJWzKSnzBmPeu+u WyHbuAh36/pXsn8QchjiRJD/boaySayXslFoCRba7cKNFtmvAQR3NTX9wgDC8JFB4ueU fMtA== X-Forwarded-Encrypted: i=1; AJvYcCVqA2diZXmxAI7wx1+KlWRyLpChUwIw0Vh7lImUoI3vqt4L6BAn7VzSzwNopLCQvRP6wn3WcqwCanGp1w==@lists.infradead.org X-Gm-Message-State: AOJu0YzAieOLYchQRNtg/txqX+ULpNstme1ZG8rARg8RZEhGwVltdXM0 +pde1s6NZEoGgxq8eQNQrt7to6yaQHro8smt2sqQsiOUWI4RUzOA X-Gm-Gg: ASbGncuj9kIIcAfqVeCpgudGgusSvMD3N+LNROnS4RMWQYFfMo+Bnx6+MZNKKOrZO7U JQshntcj4D0rwxy6S/EU9YUp5yJajp0JEeANfMKiZL5L41edrPlbJeFmUQ08w3ohMjotjmGgaZY KBJbU3lfyj/zS9UzQVpmyluR1EudTGeYOBgyUF7+4mUZpjml607Hol7UaQvoWZJma65PPZLOuQ7 +FINkUkDgpSXtlMnRQBeP96Do9M45rt6CsZepbuY2JK4ky3ThjSFENzsjwl8qGDjfiuztpGllXb 5BdG1RVue68KVgc140OD2O13OAf37HjIQoyJgcv/UTgwmJBNON1yzWo= X-Google-Smtp-Source: AGHT+IH9h4gO1h633yHabDi56gUwUKc/1ei4QrFAgLV1x3b/3cKCpZ3eVwq4OVI4qIBzDVM8XCyTpg== X-Received: by 2002:a17:90b:164f:b0:2f2:ab09:c256 with SMTP id 98e67ed59e1d1-2ff7cf13a9cmr39914901a91.33.1741832400202; Wed, 12 Mar 2025 19:20:00 -0700 (PDT) Received: from localhost ([216.228.125.129]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-301182181c3sm2651251a91.5.2025.03.12.19.19.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Mar 2025 19:19:59 -0700 (PDT) From: Yury Norov To: linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Cc: Yury Norov , Paul Walmsley , Palmer Dabbelt , Albert Ou , Rasmus Villemoes , Charlie Jenkins , Alexandre Ghiti , Samuel Holland , Anup Patel Subject: [PATCH 1/4] nodemask: drop nodes_shift Date: Wed, 12 Mar 2025 22:19:49 -0400 Message-ID: <20250313021953.86035-2-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250313021953.86035-1-yury.norov@gmail.com> References: <20250313021953.86035-1-yury.norov@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250312_192001_273497_F2F39D2E X-CRM114-Status: UNSURE ( 7.06 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org nodes_shift_{left,right} are not used. Drop them. Signed-off-by: Yury Norov --- include/linux/nodemask.h | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/include/linux/nodemask.h b/include/linux/nodemask.h index 9fd7a0ce9c1a..b1a26ef5912e 100644 --- a/include/linux/nodemask.h +++ b/include/linux/nodemask.h @@ -39,9 +39,6 @@ * int nodes_full(mask) Is mask full (all bits sets)? * int nodes_weight(mask) Hamming weight - number of set bits * - * void nodes_shift_right(dst, src, n) Shift right - * void nodes_shift_left(dst, src, n) Shift left - * * unsigned int first_node(mask) Number lowest set bit, or MAX_NUMNODES * unsigend int next_node(node, mask) Next node past 'node', or MAX_NUMNODES * unsigned int next_node_in(node, mask) Next node past 'node', or wrap to first, @@ -241,22 +238,6 @@ static __always_inline int __nodes_weight(const nodemask_t *srcp, unsigned int n return bitmap_weight(srcp->bits, nbits); } -#define nodes_shift_right(dst, src, n) \ - __nodes_shift_right(&(dst), &(src), (n), MAX_NUMNODES) -static __always_inline void __nodes_shift_right(nodemask_t *dstp, - const nodemask_t *srcp, int n, int nbits) -{ - bitmap_shift_right(dstp->bits, srcp->bits, n, nbits); -} - -#define nodes_shift_left(dst, src, n) \ - __nodes_shift_left(&(dst), &(src), (n), MAX_NUMNODES) -static __always_inline void __nodes_shift_left(nodemask_t *dstp, - const nodemask_t *srcp, int n, int nbits) -{ - bitmap_shift_left(dstp->bits, srcp->bits, n, nbits); -} - /* FIXME: better would be to fix all architectures to never return > MAX_NUMNODES, then the silly min_ts could be dropped. */ From patchwork Thu Mar 13 02:19:50 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yury Norov X-Patchwork-Id: 14014219 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9DB4AC28B30 for ; Thu, 13 Mar 2025 02:20:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DaJTyC6a3gdFO7zEXBdAHQCHGihghpr4m257ujwe0Q0=; b=IMAsq47ugFx30e AmbQPWnBrG7C6zCTv5dGgM0Cqet4c3ExjfyMMk1CALTC9yYa04s66lUzE9Cio7DgCdM0oC50EMKaI UyduygfaGaUxcisH/gZsDevpirGvhQpdA7PNFPNwtB16MDQQmCqsMV/KnQslu+sneTFC9oJlzqsel jXVPc7Ep3f3VKycJ2KLKf4moT70vTk0XpmKAVfWgJMyQF8JC9SE99PfOjUA0x4P+vRTRgoK4boGjE Oz/lVof2WCmCE174IJafpIA7xPt0yKLsphm6eWwylM6sYK5R+BeLycQRIGPjvhOYglh/MkmdHljgs NmqeGJrkhBQFbMZHvj0A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tsYB4-00000009uti-0X3Y; Thu, 13 Mar 2025 02:20:06 +0000 Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tsYB1-00000009usf-3uGK for linux-riscv@lists.infradead.org; Thu, 13 Mar 2025 02:20:05 +0000 Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-22409077c06so12034615ad.1 for ; Wed, 12 Mar 2025 19:20:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741832403; x=1742437203; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JYhELuNh/H+0ZU3yo6Tx42VZD/1lCOeZE6fYEs5O9r4=; b=E/JaPdfUInlD0miYOrDoZvnQuvn32/39Q/Q6L5B6+axTRk3ZpYFwi0ARXv9h06fm1i uuy9IuhbGCZDHC3yP1Xl2Ec3NUBQWMPIti/EGgv31kzxlgX0TSb41wzPjUVrYGLR2eBe aQKESvp/0hR5RFvuPRVAnKMtjKgiA5lRlSaG2vIkarJ65wt7UgMS+GEh7n6gs5izgcCu DSswuwoGL3hG61myh2vZTwyl3AikiQO8WCduI6hkz4PtirqXpwC/DjDtxU/8RhLWev4t QmMT//24lKIRWuigTf+wErIepDvphdmFk0S/AYje+uEgIHE4YKUu5lHj6X72//osRbFW 29wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741832403; x=1742437203; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JYhELuNh/H+0ZU3yo6Tx42VZD/1lCOeZE6fYEs5O9r4=; b=E43HvpSKibgt1sdFrMYzsiPJyatXL1MuXiOA0Q51yiEVHe1ub8hy/d534PFLgLhyJO Gn+XTZCJRwPcY5llUz1/+BICXQlfk06NV4s6FBQR4LPGN+pil72+RyGPwyXts0TyqaXj GVwkyZ5+4z7kXHDT3p8kNfCiTaop86hoy1JXWbmnOYfF7OWYf6I+lFwoXFri/QB38ZVE TDgGeMn5JP+eaLyxcyOs6wiflojW8QZkptGb+R2EY0z0j8xTIb5qv0fHILiw2NNN+Ub3 blViH2i8wYZ30LqPGRFtXQFCp70JDp+mlP06us0moZIuxLjoyml3RcXRCthcRybvKpSY 66Hg== X-Forwarded-Encrypted: i=1; AJvYcCWhq5KFgjCqesUlzvZEA6LHgUuFEmUedMqBe/LwBf65o+nkLEwve55dXXXo+XWmKuqn8oAJw9foYoEPVw==@lists.infradead.org X-Gm-Message-State: AOJu0YySh069Dh9eaEJa1vn4n4s+9H22/VH0bhXsSPARyaotovZ1ieKr WQKAW51Jx/Fk7bKsyFRLJydtRD1GLzBlocedkhB0GVCxPTcZJBG6 X-Gm-Gg: ASbGncu4lZRvefP106lqJkETSw0HfwXlea5Q0alQ2IW/SG//qR6PvJKMQ8LknJ7gdwQ IGOm/RCOIR1AGQst76tArtIX2wht4dvvnDQm7/Yw+azw2zMJ5UXT4qK/m5+UE0DcSJzoNcl5yGD 50obpe8jX3KHI4ug9pJR50Eiwry+65IKv4Qg8ktaTkE696YnXU5AIqlwsSQeFxFLR9P8n55kkiE 9SJF3CUAyXByHWkWbRm0F2vPznYxEwMdDGsHwcxhZIJY9WLFWBbXYLEWDEevoMnLya2q64jbY1u +EE4pEH6NrleCAo9p2Pd9uMyt1BLQ7GRfA/CMHYaQpoo X-Google-Smtp-Source: AGHT+IHcxiSU+kMKPherfsGG+ddx6B45jAAx+w+XqsI7BCKH7gfYWRuQvwRSvxc64ktLopvBtjMDRg== X-Received: by 2002:a17:902:e80a:b0:224:13a4:d61e with SMTP id d9443c01a7336-22428c0a43bmr308389355ad.51.1741832403015; Wed, 12 Mar 2025 19:20:03 -0700 (PDT) Received: from localhost ([216.228.125.129]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-225c68887fcsm2696535ad.39.2025.03.12.19.20.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Mar 2025 19:20:02 -0700 (PDT) From: Yury Norov To: linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Cc: Yury Norov , Paul Walmsley , Palmer Dabbelt , Albert Ou , Rasmus Villemoes , Charlie Jenkins , Alexandre Ghiti , Samuel Holland , Anup Patel Subject: [PATCH 2/4] cpumask: add non-atomic __assign_cpu() Date: Wed, 12 Mar 2025 22:19:50 -0400 Message-ID: <20250313021953.86035-3-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250313021953.86035-1-yury.norov@gmail.com> References: <20250313021953.86035-1-yury.norov@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250312_192003_971152_C1F0B8C9 X-CRM114-Status: UNSURE ( 7.44 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Similarly to atomic, add a non-atomic version. Signed-off-by: Yury Norov --- include/linux/cpumask.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/cpumask.h b/include/linux/cpumask.h index 9289d4612170..f8caa025c6bb 100644 --- a/include/linux/cpumask.h +++ b/include/linux/cpumask.h @@ -1074,6 +1074,9 @@ void init_cpu_possible(const struct cpumask *src); #define assign_cpu(cpu, mask, val) \ assign_bit(cpumask_check(cpu), cpumask_bits(mask), (val)) +#define __assign_cpu(cpu, mask, val) \ + __assign_bit(cpumask_check(cpu), cpumask_bits(mask), (val)) + #define set_cpu_possible(cpu, possible) assign_cpu((cpu), &__cpu_possible_mask, (possible)) #define set_cpu_enabled(cpu, enabled) assign_cpu((cpu), &__cpu_enabled_mask, (enabled)) #define set_cpu_present(cpu, present) assign_cpu((cpu), &__cpu_present_mask, (present)) From patchwork Thu Mar 13 02:19:51 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yury Norov X-Patchwork-Id: 14014220 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5238EC28B2F for ; Thu, 13 Mar 2025 02:20:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SnhMprrfqHLpjZUCNBVUgVzJibJqOOO3yl1M5EzN5Vs=; b=G7sDz5VnNe1trB qkqB4r27zOJdRB9kjv/VjbCWllyjqH1pw05SiHF7GfC+X7fJB6NUIAPpB/OB+KNwPcbftpheiHGJS mYzhCuAXP8FnA/ZUcLl/f5NmpBYKG1qV2pogcB1hqC2ia2ERuYO40LrpwyZIMtdqkj010bdRJgMRi Ys688qH3XYuJiYFof0z/idchPDJeSoj92aBHSAjSqma8UF0iVQxoW/YHStMcwud+YtyvnnwWrnqPy ujEW6Bnz6QzEzie1t+9NlUeQN5nkhgf4ax5aZ2Me1FJuTpbwvdtwLp/JmBJ7xFzZEw4L9LIO7o/VO f0bEpVvO5W4S07FU5Btg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tsYB6-00000009uur-2th1; Thu, 13 Mar 2025 02:20:08 +0000 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tsYB4-00000009uth-1nuJ for linux-riscv@lists.infradead.org; Thu, 13 Mar 2025 02:20:07 +0000 Received: by mail-pj1-x1029.google.com with SMTP id 98e67ed59e1d1-2feae794508so887838a91.0 for ; Wed, 12 Mar 2025 19:20:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741832405; x=1742437205; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kLw67BqWA0BIkPETmcHm1W/HkXtVEPs+aCbes5Kp6pw=; b=K4s6x1YD1giNKrfpWz++3BaULoobv7igx8X+mjBeSY4Ih3GeFR52w3d3avSglB77ec 1E0oLu9DGTf1mhA+0P41F+rihS2uympMim9G2MMkwJuny3EljSQk2hJJjXqNCZnC0YEl gPkQT0YDurkkn/RfohAyhz/1MFhK4t5E+yyqZqxsT4ipgIfKsS9NsX3srpjbhH1X5Ljc T7dz8z0NLphEApxjzAZ/NDN6nfI2AAFOEaBgenbjjWke4iJwF2IWvabawKE/Y+66gaYz 0G2W0gVRuFRpFNqz0lhjgCn3LHcFllI6VisATF4hJYHkPpgD8yNB4nCu6/cLZmTUx/QY nvaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741832405; x=1742437205; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kLw67BqWA0BIkPETmcHm1W/HkXtVEPs+aCbes5Kp6pw=; b=moidCqgYc7UPSNPtSx1NsKnuzKqC3dvfMvp+mwrveST7bUJ19zV7i8gqmqFCa4Z+lo AWGuM/aeSl1iu1xM+VByi3dtt5Bu+6VLAm6SaVgyFZIMCJuEpRnCQuKXrx4F3/GOQb9H i39tP0/5LO3+n/fJQIcgHbz/sT5iX78LrExlFXDtuBJ9YFv8CbqSy0LthxpXK2CxRLJD V7aou2jJrzVZZjXLI/d94fQuSpxbYfJjm34Cul+yPLLRbYs4kgNsypqlJw5BCkCM5xeV BANpap8uLaBfTp2SRtICEBvhxxub9bDYnbUbGLSzygNcb3JTNw0s+isH3E6TXkop5X/J R3Gg== X-Forwarded-Encrypted: i=1; AJvYcCXd+eEHIIo2otakCcOkOWV/UY9V0l90I7Q+YMnxzu7nPywiWd2xng7ALYzowomukbPcHwXHnr8UpQQybw==@lists.infradead.org X-Gm-Message-State: AOJu0YzJeYMeo9aRXALjQZlvMn3a4XqVdtmDbm29tWk+zvp/MPQ2GJM6 5PO76Ymtc1kYq+GL8l/m+hpIdp6JOUuwGgxVkIM/t4rCyCrj7boJ X-Gm-Gg: ASbGnctnJ9sv6jzHBchQ7yg588YQ1VQlXWC/8O/xjsoDHu4DR3XdZaFcpvrH4xYdBqS TuTUwQMhb1lUOnoyJb/Sk9YT+Oec0wnFNdHm7eb9Zs5ITU5NcdUniIrx+06GmOUO5adrqmWHoJ+ MDzgwuTiL95+BDqns0lOVeVp3VHQSUdTWRwu8gNyDO2cRBuYmRd7wlmwDbMA+4C1iSV9RJSMYu6 T40NmrhnjgZXqTWmjOn9Izhjt4JH3SpM0sKSUCrbOyYHKWCh7Le0vTQx/Sv80mLV4gbG+szuTdN 5AF1HhnZ1+RoTjXLw02wLSGvXjDv8YfgDa3Pe7o99f1y X-Google-Smtp-Source: AGHT+IGd/HsBjLkc68NP6moc+1YM/RCLuYwV9ycuTAbmTeB62jDlEwfr3ThGTS9nnEwZw2LwUvK2WA== X-Received: by 2002:a17:90a:d605:b0:2f9:cf97:56ac with SMTP id 98e67ed59e1d1-2ff7cd3ebcfmr41200798a91.0.1741832405575; Wed, 12 Mar 2025 19:20:05 -0700 (PDT) Received: from localhost ([216.228.125.129]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3011809f308sm2668096a91.0.2025.03.12.19.20.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Mar 2025 19:20:05 -0700 (PDT) From: Yury Norov To: linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Cc: Yury Norov , Paul Walmsley , Palmer Dabbelt , Albert Ou , Rasmus Villemoes , Charlie Jenkins , Alexandre Ghiti , Samuel Holland , Anup Patel Subject: [PATCH 3/4] riscv: switch set_icache_stale_mask() to using non-atomic assign_cpu() Date: Wed, 12 Mar 2025 22:19:51 -0400 Message-ID: <20250313021953.86035-4-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250313021953.86035-1-yury.norov@gmail.com> References: <20250313021953.86035-1-yury.norov@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250312_192006_471667_3D4622CD X-CRM114-Status: UNSURE ( 9.95 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org The atomic cpumask_assign_cpu() follows non-atomic cpumask_setall(), which makes the whole operation non-atomic. Fix this by relaxing to non-atomic __assign_cpu(). Fixes: 7c1e5b9690b0e14 ("riscv: Disable preemption while handling PR_RISCV_CTX_SW_FENCEI_OFF") Signed-off-by: Yury Norov --- arch/riscv/mm/cacheflush.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/riscv/mm/cacheflush.c b/arch/riscv/mm/cacheflush.c index b81672729887..b8e96dfff19d 100644 --- a/arch/riscv/mm/cacheflush.c +++ b/arch/riscv/mm/cacheflush.c @@ -172,7 +172,7 @@ static void set_icache_stale_mask(void) stale_cpu = cpumask_test_cpu(cpu, mask); cpumask_setall(mask); - cpumask_assign_cpu(cpu, mask, stale_cpu); + __assign_cpu(cpu, mask, stale_cpu); put_cpu(); } #endif From patchwork Thu Mar 13 02:19:52 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yury Norov X-Patchwork-Id: 14014221 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E361C28B30 for ; Thu, 13 Mar 2025 02:20:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=u3vGLW2FV+tqYL/RIEVZByqIZRTiAUKfo1PwqvEURzw=; b=Y1YuXzcG172z4N gANuZaJ/HkUWgRx7cDjbUW2TPixYY816lkOPhls4tzi4VMniUkWEsB1vRECM4fZdMc95Xjt6g3NOL mtvaa3gmBxYtPEu0LzzciI3xvLp0wHsuatcZuH/Iuv8+MNENwEbKpYg9IojsJm1OJ2XvarOSS1Gn+ iZa4yX5OoofIrkhhnM1sdPXlI7It9NIce5epexA1yD4lLgxVx0qxxSyotDtkcgJpLb5aGFDWvOivd VI99fg4pzzHrVaWsUuThXC4bwPMz7fY7PM8cpvXT2sXUmJx/7tK3Gy5yEMtL3XVHptevN2BQyqziE Nds5P6QzmXsi9unGEjyg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tsYB9-00000009uwd-1nDg; Thu, 13 Mar 2025 02:20:11 +0000 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tsYB6-00000009uut-3WaH for linux-riscv@lists.infradead.org; Thu, 13 Mar 2025 02:20:10 +0000 Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-22423adf751so6770475ad.2 for ; Wed, 12 Mar 2025 19:20:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741832408; x=1742437208; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xhrJ8HGtR8k3dxAA+AgdZEOnZohoN1a96l9KBcI/XnA=; b=V8SJD6qDBxGF+QqmebMAs7mMpAbboMwqbvCx2zhF35cL6o6YjVhptj4gOBtG2PZKlG Cy7zgQghOokUYQvM2qSufoVtU8jW4RK6slQ0LFOVK06nhbe1JMSdBy3iVO+HuL5EKuXp K/sjdZ1VOWwng82hf/YyXxeTiQjLCDuevIenzbE6cSeAiyyeuBZEkKhItS3s9kuq+uwh XvzQgWTcq1PLK6udg7YCFTvpq2QY/1XCrTwCLc9iCVL2NT+UpbpP7byEE3kaT+cr/jGz YxVhlJLieJyua3/aB6uG+WWJ3ydvbInsHfGJ2uCEnOO18bowGwMm2nLqa2Brbmfzitjh 3fQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741832408; x=1742437208; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xhrJ8HGtR8k3dxAA+AgdZEOnZohoN1a96l9KBcI/XnA=; b=RaRyX01DlzaziJuQYVCt2fCNpaLktnFdSzr3YA+RFRVPViqFk1MTaWGNjbAnU8VDiN Rkcn/yh0MnTqc8BZV3ZLeSmtXl0+dmqNNBerIrijJgOSiB4sx5bgVkfQzoDTBW5mBxQv hCISgmIWklpqA0w5ghk+/z3MhpOecX8QO7YEdOr78QCEAMjoOb0sEFS/ch5+Vg4X1EAL NNPlhfs3zsNRdOaXK0RGKDGHIcuM2aH24M8qGMjHdo0UE0sCzCo39ujfxdVdhNAPo7KG EuA7SnH8rAEmkdqEZ5CsfcdlecOxlGcDH/ii/3bmmanYW4wcw4h/qrQWRUvmGWesB9Q6 PkLA== X-Forwarded-Encrypted: i=1; AJvYcCXvbSya/XWzsTMTYyqRe6Nusmb3mlFCu6jbLPIeFJcdAippk0Ck9NQcq+hznwyvSYTrmD6xh8MndLFqEw==@lists.infradead.org X-Gm-Message-State: AOJu0Yz9gNVqdwjhpmIQzs7tjt8yhqP/gs8pu1w2atgmDHO0sw0XNlQ4 7rvC7StD/EFaJcUir5TvWwVaU8/wonBAKT8PnIy2hvdMwbaLhJDw X-Gm-Gg: ASbGncsh8FRv5uOXHbN0ALdfhJGzVdkw+JWfl7eaYRgHGxO2Aww50AUotW/Ok03pQkR EIbJVrpULUr7YrU/Se97IMdVA/a84PY1cb6C4ZEuQWrFMZ+CyLvrQFS80G7I1Rj0yKdO82jQcGn muh33m0RfbMxbpuS2hmJ4+hujllV3RrNPKy+0EHmGwSxCEkcgwZCSy6Dj9YJESm9Eh95k0yt1pC uN8z+0DvEIHA+MGw/PPjUqExdRg5NPIGo7kfFperb7QEkJMUlhArBLLbcUL1TYwVSDPVNiePT2V vaLojdnCs6LLzy2vVPySBe0EUX+lX+B4IOhNELiwfoz0 X-Google-Smtp-Source: AGHT+IFcQfoNRBmW4J0WVDBuE/gGCx1w5h+8C1HXlvpyeZVWWTFjP7qL4lXzgdHuMvZqdEU+k1TZgA== X-Received: by 2002:a05:6a00:a09:b0:736:ab1d:83c4 with SMTP id d2e1a72fcca58-736eb65d07amr13574673b3a.0.1741832408295; Wed, 12 Mar 2025 19:20:08 -0700 (PDT) Received: from localhost ([216.228.125.129]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7371155934asm232634b3a.56.2025.03.12.19.20.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Mar 2025 19:20:07 -0700 (PDT) From: Yury Norov To: linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Cc: Yury Norov , Paul Walmsley , Palmer Dabbelt , Albert Ou , Rasmus Villemoes , Charlie Jenkins , Alexandre Ghiti , Samuel Holland , Anup Patel Subject: [PATCH 4/4] cpumask: drop cpumask_assign_cpu() Date: Wed, 12 Mar 2025 22:19:52 -0400 Message-ID: <20250313021953.86035-5-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250313021953.86035-1-yury.norov@gmail.com> References: <20250313021953.86035-1-yury.norov@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250312_192009_122289_321709E8 X-CRM114-Status: UNSURE ( 8.40 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Commit decde1fa209323c7 ("cpumask: Add assign cpu") was merged bypassing cpumasks reviewers. It adds atomic and non-atomic cpumask_assign_cpu() helpers. In the same merge window, commit 5c563ee90a22d3 ("cpumask: introduce assign_cpu() macro") added the same functionality. So now we have it duplicated. __cpumask_assign_cpu() has never been used since introducing, and because this series reworks the only user of cpumask_assign_cpu(), both functions become a dead code. Signed-off-by: Yury Norov --- include/linux/cpumask.h | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/include/linux/cpumask.h b/include/linux/cpumask.h index f8caa025c6bb..ddeefb2744b1 100644 --- a/include/linux/cpumask.h +++ b/include/linux/cpumask.h @@ -558,22 +558,6 @@ static __always_inline void __cpumask_clear_cpu(int cpu, struct cpumask *dstp) __clear_bit(cpumask_check(cpu), cpumask_bits(dstp)); } -/** - * cpumask_assign_cpu - assign a cpu in a cpumask - * @cpu: cpu number (< nr_cpu_ids) - * @dstp: the cpumask pointer - * @bool: the value to assign - */ -static __always_inline void cpumask_assign_cpu(int cpu, struct cpumask *dstp, bool value) -{ - assign_bit(cpumask_check(cpu), cpumask_bits(dstp), value); -} - -static __always_inline void __cpumask_assign_cpu(int cpu, struct cpumask *dstp, bool value) -{ - __assign_bit(cpumask_check(cpu), cpumask_bits(dstp), value); -} - /** * cpumask_test_cpu - test for a cpu in a cpumask * @cpu: cpu number (< nr_cpu_ids)