From patchwork Thu Mar 13 07:18:18 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matti Vaittinen X-Patchwork-Id: 14014517 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D7F4C28B28 for ; Thu, 13 Mar 2025 07:40:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yBGWyI2KhlGLTlExLjTIG8zzVp+t1U4InfDr+/tp5Go=; b=AeDhkNI0gJqDCPt5IKAJmT9gpR iaevX5OLKklH8JD6td5K7+cSSCaLPCwDhel6k4b9x+pcAWIHsefszpoVJy8cLy9cDRzcH77IvTODH DYm25RYP5KK7ckn9x1qt3g73cHrwywEreOYQnzF3MssOQHcozt0sDRm3qrwhH4nfxkdvW4P7zgJmR thSdpI1OjY39rNzDFchpnQovCkVBv2zKlohnA+xayOj0CgDMN9Cn11n8Bzt+vAb2AIub5B0UEKDQX xQ7MtCB1Y+gBqyH6s1CVc8ozIjH7tOwTXGYpTS9MHBwyg8cqt1CM6W0FtksDDLWx3fjS6phrWkIDn ovX7828Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tsdAm-0000000APDH-1Yox; Thu, 13 Mar 2025 07:40:08 +0000 Received: from mail-lf1-x134.google.com ([2a00:1450:4864:20::134]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tscpn-0000000AKs5-1zjH for linux-arm-kernel@lists.infradead.org; Thu, 13 Mar 2025 07:18:28 +0000 Received: by mail-lf1-x134.google.com with SMTP id 2adb3069b0e04-54996d30bfbso526141e87.2 for ; Thu, 13 Mar 2025 00:18:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741850306; x=1742455106; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=yBGWyI2KhlGLTlExLjTIG8zzVp+t1U4InfDr+/tp5Go=; b=US5OI/d++9sQNXgsNHE+ONQWc+eldqoQPOhu/R2h6moweiphkwg3sWrz7sb+xPJlkk euqaw7zoEtd5vK6+f1Kwz7iqchfGUboBxfeMpzLV4GVzyAG3BTF9LSxzYQnGwHs9G7Ns km6HhUHuv5eCWQYISZF3rNiG6pk2AjOP0ke2iTKD29PFStS25LYpcpDdFfAzzwv2DO4W LFGBXNwGR8885BELf0qPa12wFVquXfmmk/6s9sOpMPimy1/z6RO6x+/l7VVHn1cIg+bj DA6BHADmY/M59y7v+5gfGxxVuNtnymB6VBELFs2H1DHOdxHDqCpTy1jDAaZkKxMpJAl7 /QcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741850306; x=1742455106; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yBGWyI2KhlGLTlExLjTIG8zzVp+t1U4InfDr+/tp5Go=; b=CHPzGBifk4n/GskpNV9XiplUETdEC7fgLiBf1PntfpG5p/qmKhrrnPYT7jI7IExLRC dveOM09hZoOw9Ujgcwiwb8fwP3mJAHHLbEFgYuDgmPFiy8JOkngFaItqrVawUosZjAZz PzHycHwKpJIxPFi7e/dSkzuVfWnueVRpUQuLaxdZSXBv3AoP0xWJ7Rq22DQnjRfshMGy Ru42BMcY/jlmEGW14/tl8Ibc3XVp7qDXmPTmUKSq1RssgWjkEJ1XOoESu9qKbvPgE+xz lR9B7TaRuD1wL6yFdfywcMnikoXIV0rpvFljS2B1s9EFYDyOcpurxz7p9An+liZXGkZ9 Auww== X-Forwarded-Encrypted: i=1; AJvYcCUMESkmSpKZOyFxPyc8dCP51VuCgQHtn+26/Mkfle6/60u0bPs0rFrrv08NYBSswu0PBxNoS8u9nF46MLj+k+kg@lists.infradead.org X-Gm-Message-State: AOJu0YzCAoyF8kJG0nHk/Fom/gkBXApjpe1QMeaIAmUlr00AMKf7ZIdK KBr7HoiR6WEaPJO/Pp2PWtZTLS6OEqRKvrUnpT62w0qycV7r0QEy X-Gm-Gg: ASbGncvD5X6PrO9ljYqA8+FGQzrnTz896AIShlTWYdkximMUxGwRcqlXM8GpFM2ADXC xi7xL/qKptW2Cc0ZHBuZS9iPLJFukW907A1j1bccCCUcAjvVyv88rOO+gMkQfteTvzE2Qin+IdC w6ua478VRkrKZRpqLoGkK+6NNUMqWbcfyS9Cw0Yt41Le5jcespSMz8D59yMy2IK7GlPZdIc/SCY lKFf/Lb0GH8v1eJHIdrioZ5zjIhXmrWIRUNQRbWm1nhc1BlA8lVTL1nIXzX1XBXvKtSY5nk9k0c mZabCroln7REZdZ+zozeREVlRsJdQmij3iFdyoD6muFJE+dQZ9Q= X-Google-Smtp-Source: AGHT+IGP8h2FL/lCirDVHljxL5OfQTimB9tsLIQ+xH91borETZK6KwSphvw7DjFZLuCzX4cD5bzVZg== X-Received: by 2002:ac2:4c46:0:b0:543:baa3:87ab with SMTP id 2adb3069b0e04-549910b7f23mr8760741e87.47.1741850305346; Thu, 13 Mar 2025 00:18:25 -0700 (PDT) Received: from mva-rohm ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-549ba7c2677sm117486e87.95.2025.03.13.00.18.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Mar 2025 00:18:24 -0700 (PDT) Date: Thu, 13 Mar 2025 09:18:18 +0200 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen Cc: Jonathan Cameron , Lars-Peter Clausen , Andy Shevchenko , Matti Vaittinen , Lad Prabhakar , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Hugo Villeneuve , Nuno Sa , David Lechner , Javier Carrasco , Guillaume Stols , Dumitru Ceclan , Trevor Gamblin , Matteo Martelli , Alisa-Dariana Roman , Ramona Alexandra Nechita , AngeloGioacchino Del Regno , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: [PATCH v7 03/10] iio: adc: add helpers for parsing ADC nodes Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250313_001827_527535_733746CC X-CRM114-Status: GOOD ( 29.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org There are ADC ICs which may have some of the AIN pins usable for other functions. These ICs may have some of the AIN pins wired so that they should not be used for ADC. (Preferred?) way for marking pins which can be used as ADC inputs is to add corresponding channels@N nodes in the device tree as described in the ADC binding yaml. Add couple of helper functions which can be used to retrieve the channel information from the device node. Signed-off-by: Matti Vaittinen --- Revision history: v6 => - No changes v5 => v6: - Adapt to changed fwnode helper names - Fix spelling v4 => v5: - Inline iio_adc_device_num_channels() - Fix Indenting function parameters - Combine the max channel ID checks. v3 => v4: - Drop diff-channel support - Drop iio_adc_device_channels_by_property() - Add IIO_DEVICE namespace - Move industrialio-adc.o to top of the Makefile - Some styling as suggested by Andy - Re-consider included headers v2 => v3: Mostly based on review comments by Jonathan - Support differential and single-ended channels - Rename iio_adc_device_get_channels() as iio_adc_device_channels_by_property() - Improve spelling - Drop support for cases where DT comes from parent device's node - Decrease loop indent by reverting node name check conditions - Don't set 'chan->indexed' by number of channels to keep the interface consistent no matter how many channels are connected. - Fix ID range check and related comment RFC v1 => v2: - New patch --- drivers/iio/adc/Kconfig | 3 ++ drivers/iio/adc/Makefile | 2 + drivers/iio/adc/industrialio-adc.c | 79 ++++++++++++++++++++++++++++++ include/linux/iio/adc-helpers.h | 27 ++++++++++ 4 files changed, 111 insertions(+) create mode 100644 drivers/iio/adc/industrialio-adc.c create mode 100644 include/linux/iio/adc-helpers.h diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig index 849c90203071..37b70a65da6f 100644 --- a/drivers/iio/adc/Kconfig +++ b/drivers/iio/adc/Kconfig @@ -6,6 +6,9 @@ menu "Analog to digital converters" +config IIO_ADC_HELPER + tristate + config AB8500_GPADC bool "ST-Ericsson AB8500 GPADC driver" depends on AB8500_CORE && REGULATOR_AB8500 diff --git a/drivers/iio/adc/Makefile b/drivers/iio/adc/Makefile index ee19afba62b7..1c410f483029 100644 --- a/drivers/iio/adc/Makefile +++ b/drivers/iio/adc/Makefile @@ -3,6 +3,8 @@ # Makefile for IIO ADC drivers # +obj-$(CONFIG_IIO_ADC_HELPER) += industrialio-adc.o + # When adding new entries keep the list in alphabetical order obj-$(CONFIG_AB8500_GPADC) += ab8500-gpadc.o obj-$(CONFIG_AD_SIGMA_DELTA) += ad_sigma_delta.o diff --git a/drivers/iio/adc/industrialio-adc.c b/drivers/iio/adc/industrialio-adc.c new file mode 100644 index 000000000000..6cfb001c74b9 --- /dev/null +++ b/drivers/iio/adc/industrialio-adc.c @@ -0,0 +1,79 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Helpers for parsing common ADC information from a firmware node. + * + * Copyright (c) 2025 Matti Vaittinen + */ + +#include +#include +#include +#include +#include +#include + +#include +#include + +/** + * devm_iio_adc_device_alloc_chaninfo_se - allocate and fill iio_chan_spec for ADC + * + * Scan the device node for single-ended ADC channel information. Channel ID is + * expected to be found from the "reg" property. Allocate and populate the + * iio_chan_spec structure corresponding to channels that are found. The memory + * for iio_chan_spec structure will be freed upon device detach. + * + * @dev: Pointer to the ADC device. + * @template: Template iio_chan_spec from which the fields of all + * found and allocated channels are initialized. + * @max_chan_id: Maximum value of a channel ID. Use -1 if no checking + * is required. + * @cs: Location where pointer to allocated iio_chan_spec + * should be stored. + * + * Return: Number of found channels on success. Negative value to indicate + * failure. + */ +int devm_iio_adc_device_alloc_chaninfo_se(struct device *dev, + const struct iio_chan_spec *template, + int max_chan_id, + struct iio_chan_spec **cs) +{ + struct iio_chan_spec *chan_array, *chan; + int num_chan = 0, ret; + + num_chan = iio_adc_device_num_channels(dev); + if (num_chan < 1) + return num_chan; + + chan_array = devm_kcalloc(dev, num_chan, sizeof(*chan_array), + GFP_KERNEL); + if (!chan_array) + return -ENOMEM; + + chan = &chan_array[0]; + + device_for_each_named_child_node_scoped(dev, child, "channel") { + u32 ch; + + ret = fwnode_property_read_u32(child, "reg", &ch); + if (ret) + return ret; + + if (max_chan_id != -1 && ch > max_chan_id) + return -ERANGE; + + *chan = *template; + chan->channel = ch; + chan++; + } + + *cs = chan_array; + + return num_chan; +} +EXPORT_SYMBOL_NS_GPL(devm_iio_adc_device_alloc_chaninfo_se, "IIO_DRIVER"); + +MODULE_LICENSE("GPL"); +MODULE_AUTHOR("Matti Vaittinen "); +MODULE_DESCRIPTION("IIO ADC fwnode parsing helpers"); diff --git a/include/linux/iio/adc-helpers.h b/include/linux/iio/adc-helpers.h new file mode 100644 index 000000000000..56b092a2a4c4 --- /dev/null +++ b/include/linux/iio/adc-helpers.h @@ -0,0 +1,27 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +/* + * The industrial I/O ADC firmware property parsing helpers + * + * Copyright (c) 2025 Matti Vaittinen + */ + +#ifndef _INDUSTRIAL_IO_ADC_HELPERS_H_ +#define _INDUSTRIAL_IO_ADC_HELPERS_H_ + +#include + +struct device; +struct iio_chan_spec; + +static inline int iio_adc_device_num_channels(struct device *dev) +{ + return device_get_named_child_node_count(dev, "channel"); +} + +int devm_iio_adc_device_alloc_chaninfo_se(struct device *dev, + const struct iio_chan_spec *template, + int max_chan_id, + struct iio_chan_spec **cs); + +#endif /* _INDUSTRIAL_IO_ADC_HELPERS_H_ */ From patchwork Thu Mar 13 07:18:49 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matti Vaittinen X-Patchwork-Id: 14014520 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E16D3C282DE for ; Thu, 13 Mar 2025 07:42:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BFD+DcpWsMqfiQV+ZB7bRLNZX1LXyd6tXIeA6qREGzs=; b=FheKSmmFPJv0CKs8emRyiBHw3L TtX14IhZpd8SZQTlUhgWTjXtwQFvMBnKXt2RrjscMx+Hf7m1OlsjIdR2XnCfI3vGTW5lNsgEzB+Lx SYqKu0ZDp/Jog/lCoRSU2VjdeAvWQmQIyOwgy25tbwdayBtFcZEMQrh0wp5jSW0MkB7gqUSYOSctt OOYoQ7LgTXJgPAP1hIzNioLsA992lWM1hC+gPx70MhpZdW7iB0ZCcYY18TuJvZ1pfrL9IiqxG881E w4zX56LHNL3JPl9Tu3KeuSntAuSvp70KkC/rzbh12yXJNq4EJVs48GMxkGmg5qdMNYiIx1O6SF4Wv lImNXiDg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tsdCQ-0000000APPx-09uO; Thu, 13 Mar 2025 07:41:50 +0000 Received: from mail-lj1-x230.google.com ([2a00:1450:4864:20::230]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tscqH-0000000AL00-459P for linux-arm-kernel@lists.infradead.org; Thu, 13 Mar 2025 07:18:59 +0000 Received: by mail-lj1-x230.google.com with SMTP id 38308e7fff4ca-30c05fd126cso6057381fa.3 for ; Thu, 13 Mar 2025 00:18:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741850336; x=1742455136; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=BFD+DcpWsMqfiQV+ZB7bRLNZX1LXyd6tXIeA6qREGzs=; b=NVAgwM4dzx3qwSWzXa6jgBTEtHqJDLf3WJ6Cjvwk3WbVU6CnN67owCgVEDdXbN7obw 0hiYiEpGd9UTHOVDJleZJo3u/ikwjlP/PaF5p0hjnBDVGm7vm6bizYw3n3gGwX8jpusj bXa7zXvQZcLVDj6w8mQjQ9YkePZLvaCOkF0hwMxx4ZlQSY3Wwl2B+aSpXK4MVTLBnv/N vcWsK0yuLbDawNA7CkOOnN0UrkwY/5BLTD78cLtq+2Ml1mQPoWrqJ0lVFnQY6hvLbeo+ BAEGezBdv2AaOETj/KRBFUqod+fdrnimMFjWdWOLJpMDUAa02PhRyM+RQ8Jik7LwES3c onxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741850336; x=1742455136; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BFD+DcpWsMqfiQV+ZB7bRLNZX1LXyd6tXIeA6qREGzs=; b=U/LgvukdDXTv8geOupPwOmtLgylafPQWNlvBl0+UeCK+PVpxLMwjxpYn/MnmAl0yKI 28qIQA5cvNvuJxZ1aosMdsCOz3/L/zKPqs3/wrgW1BY/BCppTOAw/VQeR7auuC5IyQXA h0VDWvjGI+xeOn3CWvlGMMEDZobrCJ4Z/VhSRIyE4avHwL4lp3tBK119VxqTMlfFJ9VZ X1daLjOKsWtczOTBfU0NkIu/zxcTdGkpQZgj+S5sHcsFrTmNjlUM9qCNuG+0HHyLCa6A oVDnMyTAJ0Z7CsxkcQUEHvvph7l4ToSIaxBjgRlNa1pKOm8ovPHUn+AkbS/MdBAdWeRw UJeQ== X-Forwarded-Encrypted: i=1; AJvYcCWlLB+y+o2ocFAqBz3w3GFMv0NiER09/bup+Da4uwLQIXgOiRTSKWyctTTRxtiugzJoyi32nLdhIizPcVvd3NWZ@lists.infradead.org X-Gm-Message-State: AOJu0YwFeIWgqmsRdjerDV6ohTxqyNLeIoI39xL+C9BwxkhH0cXwuaJM ohFgfW9D+aWOx8WywVg+b77IwFiSMSof2rbMIjZ9RPOVpIZVkWTw X-Gm-Gg: ASbGncs1L/VkmJSpDK5FnntWiLI+45qus7iSNx22QrvFCxGMxVpu9oPdNwUHNlGuc3i 1JkRlFCuLxRli6LaKHNzj/bE/bfXwpj3o/BtoV+vmQli2O85+TEgQmL7bWpCCGSsH1fKgtQ2O4r WDYoUFg0pmJ/NAHbT+JOvZYPTLXgd35VXAqREjEV8oREMs0hi3Y1GjTmUbV2G7kHYnwCn/kfH7w e9h/u3YDZlxZ45cED19KNH9tSvrBLmYPgwFm++kV2mEKfmG77N0bF3ZwhQCooVYkmWYOxtvr2He W/AmHWKKFBP2Gl/KOo55uoYeZ1gfPum1kmdNR6i5Az6rsfozXOxTEakgZMVeVQ== X-Google-Smtp-Source: AGHT+IHmLCwaOiAyND+HYla9YJ6Owuf2FrMyU+QZHQM+mLQ3MEh0Yx2JRunjCA8pnIPh1yD8DBMFSw== X-Received: by 2002:a2e:a543:0:b0:308:eb58:6591 with SMTP id 38308e7fff4ca-30bf460589fmr89888051fa.25.1741850335814; Thu, 13 Mar 2025 00:18:55 -0700 (PDT) Received: from mva-rohm ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-30c3f1ec0f4sm1170341fa.109.2025.03.13.00.18.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Mar 2025 00:18:54 -0700 (PDT) Date: Thu, 13 Mar 2025 09:18:49 +0200 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen Cc: Jonathan Cameron , Lars-Peter Clausen , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Nuno Sa , David Lechner , Javier Carrasco , Matti Vaittinen , Olivier Moysan , Guillaume Stols , Dumitru Ceclan , Trevor Gamblin , Matteo Martelli , Alisa-Dariana Roman , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: [PATCH v7 05/10] iio: adc: sun20i-gpadc: Use adc-helpers Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250313_001858_034796_32061C91 X-CRM114-Status: GOOD ( 22.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The new devm_iio_adc_device_alloc_chaninfo_se() -helper is intended to help drivers avoid open-coding the for_each_node -loop for getting the channel IDs. The helper provides standard way to detect the ADC channel nodes (by the node name), and a standard way to convert the "reg" -properties to channel identification numbers, used in the struct iio_chan_spec. Furthermore, the helper can optionally check the found channel IDs are smaller than given maximum. This is useful for callers which later use the IDs for example for indexing a channel data array. The original driver treated all found child nodes as channel nodes. The new helper requires channel nodes to be named channel[@N]. This should help avoid problems with devices which may contain also other but ADC child nodes. Quick grep from arch/* with the sun20i-gpadc's compatible string didn't reveal any in-tree .dts with channel nodes named otherwise. Also, same grep shows all the in-tree .dts seem to have channel IDs between 0..num of channels. Use the new helper. Signed-off-by: Matti Vaittinen --- Revision history: v6 => v7: - Fix function name in the commit message v5 => v6: - Commit message typofix v4 => v5: - Drop the diff-channel stuff from the commit message v3 => v4: - Adapt to 'drop diff-channel support' changes to ADC-helpers - select ADC helpers in the Kconfig v2 => v3: - New patch I picked the sun20i-gpadc in this series because it has a straightforward approach for populating the struct iio_chan_spec. Everything else except the .channel can use 'template'-data. This makes the sun20i-gpadc well suited to be an example user of this new helper. I hope this patch helps to evaluate whether these helpers are worth the hassle. The change is compile tested only!! Testing before applying is highly appreciated (as always!). Also, even though I tried to audit the dts files for the reg-properties in the channel nodes, use of references didn't make it easy. I can't guarantee I didn't miss anything. --- drivers/iio/adc/Kconfig | 1 + drivers/iio/adc/sun20i-gpadc-iio.c | 38 ++++++++++++------------------ 2 files changed, 16 insertions(+), 23 deletions(-) diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig index e4933de0c366..0993008a1586 100644 --- a/drivers/iio/adc/Kconfig +++ b/drivers/iio/adc/Kconfig @@ -1357,6 +1357,7 @@ config SUN4I_GPADC config SUN20I_GPADC tristate "Allwinner D1/T113s/T507/R329 and similar GPADCs driver" depends on ARCH_SUNXI || COMPILE_TEST + select IIO_ADC_HELPER help Say yes here to build support for Allwinner (D1, T113, T507 and R329) SoCs GPADC. This ADC provides up to 16 channels. diff --git a/drivers/iio/adc/sun20i-gpadc-iio.c b/drivers/iio/adc/sun20i-gpadc-iio.c index 136b8d9c294f..bf1db2a3de9b 100644 --- a/drivers/iio/adc/sun20i-gpadc-iio.c +++ b/drivers/iio/adc/sun20i-gpadc-iio.c @@ -15,6 +15,7 @@ #include #include +#include #include #define SUN20I_GPADC_DRIVER_NAME "sun20i-gpadc" @@ -149,37 +150,27 @@ static void sun20i_gpadc_reset_assert(void *data) reset_control_assert(rst); } +static const struct iio_chan_spec sun20i_gpadc_chan_template = { + .type = IIO_VOLTAGE, + .indexed = 1, + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW), + .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE), +}; + static int sun20i_gpadc_alloc_channels(struct iio_dev *indio_dev, struct device *dev) { - unsigned int channel; - int num_channels, i, ret; + int num_channels; struct iio_chan_spec *channels; - num_channels = device_get_child_node_count(dev); + num_channels = devm_iio_adc_device_alloc_chaninfo_se(dev, + &sun20i_gpadc_chan_template, -1, &channels); + if (num_channels < 0) + return num_channels; + if (num_channels == 0) return dev_err_probe(dev, -ENODEV, "no channel children\n"); - channels = devm_kcalloc(dev, num_channels, sizeof(*channels), - GFP_KERNEL); - if (!channels) - return -ENOMEM; - - i = 0; - device_for_each_child_node_scoped(dev, node) { - ret = fwnode_property_read_u32(node, "reg", &channel); - if (ret) - return dev_err_probe(dev, ret, "invalid channel number\n"); - - channels[i].type = IIO_VOLTAGE; - channels[i].indexed = 1; - channels[i].channel = channel; - channels[i].info_mask_separate = BIT(IIO_CHAN_INFO_RAW); - channels[i].info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE); - - i++; - } - indio_dev->channels = channels; indio_dev->num_channels = num_channels; @@ -271,3 +262,4 @@ module_platform_driver(sun20i_gpadc_driver); MODULE_DESCRIPTION("ADC driver for sunxi platforms"); MODULE_AUTHOR("Maksim Kiselev "); MODULE_LICENSE("GPL"); +MODULE_IMPORT_NS("IIO_DRIVER"); From patchwork Thu Mar 13 07:19:17 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matti Vaittinen X-Patchwork-Id: 14014521 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 88752C282DE for ; Thu, 13 Mar 2025 07:43:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xFwqzBXDybwuD2vjc1RKwbgfdx/o0MRc2L5yNvshUHo=; b=chk7vl3evakqFtPRaM4mrFzIQU sOcBGCRGtqYr4IZm+/vhmsx752BVmZpBAfkbSgJsS477FMxJLOZvC7hbIVMnDLlZo4Zln6//B9C6j QzNH2jstzYSm9qdsfy8giggklR13sTVRbCswfGrzVmSbN6U3Hu2Xzp3J5SixbkhnTDbeQIAM25GT9 MCJH2vcgEJv9YqJxZkB8F+CQXIJ0GWwYUHdzRik0zxcdwuZjUhtUKMduDgLipbBnRl2Kwb/XM6zsE vxblsBlEgg/RcTPspRRqQ9DJpERMtCiXoU0iZIeIhjor7PC7RMGFp9E3hzQARTBNjbYtex06ELBSz ODJyvucA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tsdE2-0000000APgm-3KbH; Thu, 13 Mar 2025 07:43:30 +0000 Received: from mail-lj1-x22e.google.com ([2a00:1450:4864:20::22e]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tscqj-0000000AL5Q-3Gjz for linux-arm-kernel@lists.infradead.org; Thu, 13 Mar 2025 07:19:27 +0000 Received: by mail-lj1-x22e.google.com with SMTP id 38308e7fff4ca-30797730cbdso6258531fa.3 for ; Thu, 13 Mar 2025 00:19:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741850364; x=1742455164; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=xFwqzBXDybwuD2vjc1RKwbgfdx/o0MRc2L5yNvshUHo=; b=S6x7d1O6eGx1sPFr+mubXRuPrnyV7ssFcvAG6XjyFzxWWoC4OfCoL3cfqzUUzeRtfW I5aeVpAYuuuKkcjna4Nc/QkxChuWz2ZCczHoHhmavHhq/2V6iUejnI3cjeBNfQ2JXfQG oGuonyyqv0NVhU5QJXB5ebdnl/SRd5Za8/6XXhqxqI66GHdlRq5chVB4XYHqeHG6Drg4 6+v8wETSLvArL0mcG+y74LwEbLO0CJOokCAFvdn3gEHPN5tA8bC3nIsLQXWPhaAdUOeS 6UziNbRzcMkwOhahtX/fupd3BFpjXkqELK/LhospVoW5uHdT6wlMJT8zE5s4aDZ+bQxg OriA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741850364; x=1742455164; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xFwqzBXDybwuD2vjc1RKwbgfdx/o0MRc2L5yNvshUHo=; b=MpL/u2W7idsBx7G1JXoXOLjD4r4u8B1JyJHCkrbAEXxMKQqHy1YGQyWAMhnS9/yfBg JlEoPdKPDmI+/KFU5HQFwmRMqjvHwuLzGwGJgbdA0x28zh+j0V2BeqTOwPGqLEoOZ6R8 2KvbFqz3BNlG82luzkDqZwnam/oBKZaaoo11SjMDk8OrNMsqCPAejnM7ZmC2+nK/IJL2 i87VAXvpVb6R+H4Z0/OqsuW7KKLUtZpp9wpM1kr4Vqg7LG5xPvXdftszRmY59iXKix3n nd6rRlSU4H5cajSq2I2c1v082ghIHuRGVyUqAoj3MzYTGXBggAn3wpK5D5T3qZj36DeU 7bhg== X-Forwarded-Encrypted: i=1; AJvYcCU8JM2dIFV0Y0tLzDMSHCNdi17TbMNAfXLBhIvhnsGldFTPQFy38lQEZtWCjA9t2BhdQTR7EbzvcIihlD/70hND@lists.infradead.org X-Gm-Message-State: AOJu0YyjAPYpZ2MaPniRTOu6S8bFkevDgo4Hb41MniGUirs9mc0gwNtU BVssAwrVdK79qgJ08dnOtm7K7Al3HBop2Qa7cVukAMYt19uWzyq8 X-Gm-Gg: ASbGncsAxadyq26xYQqbB6Q0+WX7W5zK9Pg5rpaX2f7hPudjGE0I4b+wRWhG+Ff7P76 tQcHfrL72AXzN/1weL0I3Y9cbKvMsFHZRMgxEu4HMR86z9MoyKrOyTDNA6B0uEIZ027V86+AUKG 1tGB8OFJ7c0BaLSmztSGTowdETVsCuTdJ6DoHV8ljlOfak/uWczUEKQI/v+GtCpW+DsVfubszQw Psu7HlETn9p8IF9gvTy7ds/piF51N5bCf8OvSTqQqRxK2j/cQkhG95YNZLJsVw+eETmJtxUxPql VeWb4/mbcto2aY+xDgNZAH7Ev++O0LdcpLcKiKWHamsVLtA5338= X-Google-Smtp-Source: AGHT+IEjv3VEotqH5VFMYNkLSITb7yxLQ+/ZPsDGqrkSfM+X1MuBHj1FF3/q86MbLY14fdbT78uThw== X-Received: by 2002:a05:6512:3da3:b0:545:1082:91a1 with SMTP id 2adb3069b0e04-54990e2bd29mr8607537e87.7.1741850363715; Thu, 13 Mar 2025 00:19:23 -0700 (PDT) Received: from mva-rohm ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-549ba8851c4sm117554e87.199.2025.03.13.00.19.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Mar 2025 00:19:21 -0700 (PDT) Date: Thu, 13 Mar 2025 09:19:17 +0200 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen Cc: Jonathan Cameron , Lars-Peter Clausen , Andy Shevchenko , Matti Vaittinen , Lad Prabhakar , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Hugo Villeneuve , Nuno Sa , David Lechner , Javier Carrasco , Guillaume Stols , Dumitru Ceclan , Trevor Gamblin , Matteo Martelli , Alisa-Dariana Roman , Ramona Alexandra Nechita , AngeloGioacchino Del Regno , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: [PATCH v7 07/10] MAINTAINERS: Add IIO ADC helpers Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250313_001925_846508_C557C445 X-CRM114-Status: GOOD ( 11.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add undersigned as a maintainer for the IIO ADC helpers. Signed-off-by: Matti Vaittinen --- Revision history: v2 => - No changes RFC v1 => v2: - New patch --- MAINTAINERS | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 8e0736dc2ee0..5b96fb864227 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11208,6 +11208,13 @@ L: linux-media@vger.kernel.org S: Maintained F: drivers/media/rc/iguanair.c +IIO ADC HELPERS +M: Matti Vaittinen +L: linux-iio@vger.kernel.org +S: Maintained +F: drivers/iio/adc/industrialio-adc.c +F: include/linux/iio/adc-helpers.h + IIO BACKEND FRAMEWORK M: Nuno Sa R: Olivier Moysan